1 2006-03-10 Jim Meyering <jim@meyering.net>
5 Fix a bug whereby a user with write access to a directory being removed
6 could cause the removal of that directory to fail with an erroneous
7 diagnostic about a directory cycle. Reported by Vineet Chadha.
10 * src/remove.c (AD_pop_and_chdir): If the directory we're about to
11 leave (and try to rmdir) is the one whose dev_ino is being used to
12 detect a cycle, reset cycle_check_state.dev_ino to that of the parent.
14 2006-03-08 Paul Eggert <eggert@cs.ucla.edu>
16 * NEWS: Document dd's new 'directory' and 'nolinks' flags.
17 * src/dd.c (set_fd_flags): Handle file-creation flags on file
18 descriptors, rather than ignoring them.
19 * tests/dd/misc: Add test cases for append, nofollow, directory,
20 and nolinks flags. Simplify redirection to /dev/null in some cases.
22 * tests/dd/misc: iflags->iflag. This fixes a typo that meant the
23 noatime test never tested anything.
25 2006-03-05 Paul Eggert <eggert@cs.ucla.edu>
27 * src/dd.c (flags, usage): New flags directory, nolinks.
28 * src/system.h (O_NOLINKS): Define to 0 if not already defined.
30 * src/ls.c (usage): Mention that -f disables --color.
31 Problem reported by Niels Möller.
33 2006-03-03 Justin Pryzby <pryzbyj@justinpryzby.com>
35 * man/*.x: Add references to syscalls from utilities of the same name.
37 2006-03-05 Jim Meyering <jim@meyering.net>
39 * tests/help-version: Set SHELL, if not already set, in order to
40 avoid failure when `make check' is run through debuild; dircolors
41 would fail due to lack of $SHELL. Reported by Sven Joachim.
43 Make `base64 --wrap=N' work for N=0, and for N larger than SIZE_MAX.
44 * src/base64.c (wrap_write, do_encode, main): Change type of
45 parameters and locals, wrap_column, form size_t to uintmax_t.
46 (main): Adjust to use xstrtoumax, accordingly.
48 2006-03-03 Jim Meyering <jim@meyering.net>
50 Don't fail when run from an environment with SHELL not a Bourne
51 shell, e.g. `env SHELL=/bin/csh make check' would fail this test.
52 * tests/dircolors/simple: Invoke each non-failing test with -b.
53 Reported by Michael Stone.
55 2006-02-27 Jim Meyering <jim@meyering.net>
57 * tests/misc/base64: Derive --decode-using tests from the
60 * tests/misc/base64: Factor out a long constant string.
61 Split lines to stay within 80 columns.
63 * tests/misc/Makefile.am (TESTS): Add base64.
64 * tests/misc/base64: Test base64. From Simon Josefsson.
66 * src/base64.c (do_decode): Use correct type for parameter,
67 ignore_garbage: s/size_t/bool/.
69 * src/base64.c: Don't include .h files already included by system.h:
70 <string.h>, <stdlib.h>, <stdbool.h>, <limits.h>, <errno.h>.
71 Include "system.h" before the other lib/*.h header files.
72 Include <sys/types.h> before "system.h".
73 (wrap_write): Remove declaration of unused local, initial_column.
74 (wrap_write): Correct declaration syntax: s/size_t * V/size_t *V/.
76 * README: Add base64 to the list.
78 2006-02-17 Simon Josefsson <jas@extundo.com>
81 * AUTHORS: Mention base64.
83 * man/Makefile.am: Build base64.1.
84 * man/base64.x: New file.
85 * src/Makefile.am (bin_PROGRAMS): Add base64.
86 * src/base64.c: New file.
88 2006-02-25 Eric Blake <ebb9@byu.net>
90 In ls, avoid calling stat for --inode (-i), when possible.
91 * src/pwd.c (NOT_AN_INODE_NUMBER, D_INO): Move to ...
92 * src/system.h: ... here, for use in ...
93 * src/ls.c (main): ... here. Prefer dirent.d_ino to stat when
95 (gobble_file): Add inode argument.
96 (print_dir): Pass inode if available.
97 (usage): Remove inaccuracy.
99 2006-02-23 Jim Meyering <jim@meyering.net>
101 * TODO: Update/correct some obsolete entries.
103 2006-02-20 Paul Eggert <eggert@cs.ucla.edu>
105 * doc/coreutils.texi (join invocation): Mention `sort -k 1b,1'.
106 * src/join.c (usage): Likewise.
107 Documentation problem reported by Philip Kensche.
109 2006-02-20 Eric Blake <ebb9@byu.net>
111 * man/rm.x: Update documentation to match previous patch.
113 2006-02-18 Eric Blake <ebb9@byu.net>
115 New option for rm: --interactive=once (-I).
116 * NEWS: Document it, along with change to rm --interactive.
117 * TODO: Remove entry for implementing rm -I
118 * src/rm.c (INTERACTIVE_OPTION): New enum value.
119 (interactive_type): New enum.
120 (long_opts): Let interactive take an optional argument.
121 (interactive_args, interactive_types): New option arguments.
122 (usage): Document -I, --interactive=WHEN. Use program_name
123 instead of a basename.
124 (main): New -I option, new behavior to --interactive.
125 * tests/rm/interactive-once: New tests.
126 * tests/rm/interactive-always: Ditto.
127 * tests/rm/Makefile.am (TESTS): Run them.
129 2006-02-18 Jim Meyering <jim@meyering.net>
131 * Makefile.maint (sc_two_space_separator_in_usage): Make the regular
132 expression match more of the target lines, e.g., those that start with
133 `-S,' (short option followed by a comma) or that include `=[...]'.
134 Patch by Nicolas François.
135 Fix the four offenders thus exposed:
136 * src/join.c (usage): Use two spaces (not one) to separate the
137 --first-only option string from its description, so help2man formats
138 the derived man page properly.
139 * src/pr.c (usage): Likewise.
140 * src/uniq.c (usage): Likewise.
141 * src/install.c (usage): Likewise.
143 2006-02-15 Jim Meyering <jim@meyering.net>
145 * Makefile.maint (alpha beta major): For `make major', ensure that the
146 version string is of the form N.N[.N]*, where N is one or more digits.
148 2006-02-14 Jim Meyering <jim@meyering.net>
150 * INSTALL: Update from gnulib.
152 2006-02-13 Jim Meyering <jim@meyering.net>
154 * GNUmakefile (all): Emit diagnostics to stderr, not stdout.
156 2006-02-12 Jim Meyering <jim@meyering.net>
158 * Makefile.maint (patch-check): New target.
159 (local-checks-available): Add to the list.
161 2006-02-11 Jim Meyering <jim@meyering.net>
163 * src/c99-to-c89.diff: New file.
164 * src/Makefile.am (EXTRA_DIST): Add c99-to-c89.diff.
166 * .x-po-check: New file, with exclusions so that `make distcheck'
168 * Makefile.am (EXTRA_DIST): Add .x-po-check.
170 rm -r must remove an empty directory, even if it is inaccessible.
171 * src/remove.c (close_preserve_errno): New function.
172 (fd_to_subdirp): Don't print a diagnostic in this function.
173 Do it from the callers instead, unless rmdir succeeds.
174 (remove_cwd_entries, remove_dir): Adjust callers.
175 * tests/rm/empty-inacc: New test for the above.
176 * tests/rm/Makefile.am (TESTS): Add empty-inacc.
177 * NEWS: Mention this bug fix.
178 * tests/rm/rm2: Adjust two expected diagnostics, now that they're
179 a tiny bit less precise: cannot remove `a/1': ... instead of
180 cannot open directory `a/1': ...
182 * Makefile.maint (syntax-check-rules): Automatically derive this
183 list of sc_-prefixed rule names.
185 2006-02-10 Paul Eggert <eggert@cs.ucla.edu>
187 * Makefile.maint (CVS_LIST): Don't assume cvsu is available.
188 (CVS_LIST_EXCEPT): New macro, to simplify exception-processing.
189 Most uses of CVS_LIST changed to use CVS_LIST_EXCEPT.
190 (syntax-check-rules): Bring back sc_changelong. (Hmm, why did it
191 go away? was that an accident?)
192 (sc_cast_of_argument_to_free, sc_cast_of_x_alloc_return_value):
193 (sc_cast_of_alloca_return_value, sc_space_tab, sc_prohibit_atoi_atof):
194 (sc_error_exit_success, sc_file_system, sc_no_if_have_config_h):
195 (sc_system_h_headers, sc_sun_os_names, sc_trailing_blank):
196 (sc_two_space_separator_in_usage, sc_unmarked_diagnostics):
197 (sc_obsolete_symbols, sc_changelog, sc_prohibit_jm_in_m4):
198 (sc_useless_cpp_parens, makefile-check, m4-check, po-check):
199 (author_mark_check, makefile_path_separator_check):
200 Output line numbers, to simplify navigation of Emacs *compilation*
202 (sc_prohibit_atoi_atof, sc_file_system):
203 Rework slightly so that Makefile.maint doesn't get reported as a
204 violation of its own syntax rules.
205 (sc_dd_max_sym_length): Use ifneq to do nothing, instead of doing
206 it at run-time (which didn't work with Bison). Fix a makefile typo,
207 caught by Makefile.maint itself: spaces where a tab should be.
208 (po-check): Check lib/*.[ch] even if not in CVS; used by Bison,
209 which copies from ../gnulib/lib/*.[ch] to lib/*.[ch].
210 Ignore djgpp and man subdirectories, to avoid false matches with
211 Bison and coreutils, respectively. Use sort -u to remove the
212 resulting duplicates.
213 * gnupload: Rework slightly to avoid bogus warning from
214 sc_two_space_separator_in_usage.
216 2006-02-10 Jim Meyering <jim@meyering.net>
218 Use gzip's --rsyncable option only if it's available.
219 * Makefile.maint (gzip_rsyncable): New variable.
222 2006-02-08 Jim Meyering <jim@meyering.net>
224 * Makefile.maint (local-checks-available): Define in terms of
225 the expansion, $(syntax-check-rules), rather than the single,
226 top-level target `syntax-check', so that it's easier to exclude
227 individual rules (via $(local-checks-to-skip)).
228 (tgz-md5, tgz-sha1, ...): Remove now-unused definitions.
230 2006-02-07 Jim Meyering <jim@meyering.net>
232 * src/system.h (!defined O_DIRECT): If O_DIRECTIO is defined (as it
233 is on Tru64), define O_DIRECT to that. Patch From James Lemley.
235 * tests/help-version (expected_failure_status_vdir):
236 Redirect an expected disk-full diagnostic to /dev/null.
238 2006-02-06 Jim Meyering <jim@meyering.net>
240 * src/unexpand.c (usage): Use two spaces (not one) to separate the
241 --first-only option string from its description, so help2man formats
242 the derived man page properly.
243 * src/rm.c (usage): Likewise for --no-preserve-root.
244 * src/chown.c (usage): Likewise.
245 * src/chgrp.c (usage): Likewise.
247 Add a rule to ensure that the above doesn't happen again.
248 * Makefile.maint (sc_two_space_separator_in_usage): New rule.
249 (syntax-check-rules): Add it.
250 * .x-sc_two_space_separator_in_usage: New empty file.
251 * Makefile.am (EXTRA_DIST): Add .x-sc_two_space_separator_in_usage.
253 2006-02-06 Jim Meyering <jim@meyering.net>
255 * src/cp.c (usage): Use two spaces (not one) to separate each
256 option string from its description, so help2man formats the
257 derived man page properly.
258 * src/mv.c (usage): Likewise.
259 Patch from Nicolas François in http://bugs.debian.org/351601.
261 2006-02-04 Jim Meyering <jim@meyering.net>
263 * src/copy.c (copy_internal): cp -RL would fail when encountering
264 the same directory more than once in the hierarchy beneath a single
265 command-line argument. That is legitimate, e.g. when there are
266 two or more symbolic links, each pointing to some directory that
267 would not otherwise be copied. Reported by Christophe LYON.
268 * tests/cp/cp-deref: New file. Test for today's fix.
269 * tests/cp/Makefile.am (TESTS): Add cp-deref.
270 * NEWS: Document this.
272 2006-02-03 Jim Meyering <jim@meyering.net>
274 * configure.ac: Require automake-1.9.6, not 1.8.3.
276 2006-02-01 Paul Eggert <eggert@cs.ucla.edu>
278 * src/od.c (usage): Mention that -t a ignores high order bit.
279 Documentation problem reported by Ed Avis.
281 2006-02-01 Jim Meyering <jim@meyering.net>
283 * src/pwd.c (find_dir_entry): Remove unused local, `ent_sb_valid'.
285 2006-01-30 Paul Eggert <eggert@cs.ucla.edu>
287 * src/head.c (main): Use a better diagnostic when someone uses a
288 trailing numeric option in an invalid way. Problem reported by
290 * src/tail.c (parse_options): Likewise.
292 2006-01-30 Jim Meyering <jim@meyering.net>
294 * man/wc.x: Include `count' keyword in man page synopsis,
295 per suggestion from http://bugs.debian.org/181585.
297 2006-01-24 Paul Eggert <eggert@cs.ucla.edu>
299 * src/df.c (show_dev): If the file system claims to have
300 more available than total blocks, report the number of used
301 blocks as being total - available (a negative number) rather
302 than as garbage. Problem reported by Toralf Foerster.
304 2006-01-24 Jim Meyering <jim@meyering.net>
306 * src/tail.c (tail_forever): Don't exit-nonzero when an attempt
307 to put a regular file in O_NONBLOCK mode fails with EPERM.
308 That happens on Linux (up to 2.6.15) when using tail -f on a file with
309 the append-only attribute. Reported by Dean Gaudet. For details,
310 see http://savannah.gnu.org/bugs/?func=detailitem&item_id=15473.
311 * NEWS: Mention this fix.
312 * tests/tail-2/append-only: New file. Test for the above.
313 * tests/tail-2/Makefile.am (TESTS): Add append-only.
314 * tests/Makefile.am (check-root): Add tail-2/append-only
316 2006-01-21 Jim Meyering <jim@meyering.net>
318 * NEWS: Mention fts-related improvements and bug fixes.
320 2006-01-19 Jim Meyering <jim@meyering.net>
322 * tests/fmt/basic (pfx-1, pfx-2): New tests, to demonstrate the bug
323 reported as http://bugs.debian.org/147577. Forwarded by Thomas Hood.
325 2006-01-18 Jim Meyering <jim@meyering.net>
327 * tests/du/Makefile.am (TESTS): Add long-from-unreadable.
329 2006-01-17 Jim Meyering <jim@meyering.net>
331 Now that fts no longer changes the current working directory, adjust
332 its clients accordingly -- note that du.c uses fts but doesn't need
333 any adjustment, since it doesn't operate on the actual files,
334 but rather just uses the stat buffers provided by fts.
336 * src/chown-core.c: Include "openat.h".
337 Don't include "lchown.h".
338 (restricted_chown): Accept a new parameter, CWD_FD, and use it in
339 calling openat, lchownat, chownat, rather than open, lchown, chown.
341 * src/chmod.c: Include "openat.h".
342 (process_file): Use chmodat (fts->fts_cwd_fd,... in place of chmod (...
344 * tests/du/long-from-unreadable: New test, to exercise one small
347 2006-01-13 Jim Meyering <jim@meyering.net>
349 * tests/Makefile.am (SUBDIRS): Add comments discouraging the
350 addition of new directories under tests/.
352 * tests/acl: Redirect stdin to /dev/null. Otherwise, FreeBSD 5.0's
355 2006-01-12 Jim Meyering <jim@meyering.net>
357 * tests/du/long-sloop: Adjust not to hard-code the expected
358 diagnostic corresponding to ELOOP. Solaris' diagnostic differs
359 from that of GNU libc. Reported by Paul Eggert.
361 * tests/du/long-sloop: Create file at end of symlink chain.
363 * tests/misc/test: New file, with a test for one of the
364 bugs fixed by yesterday's test.c changes.
365 * tests/misc/Makefile.am (TESTS): Add test.
367 2006-01-11 Jim Meyering <jim@meyering.net>
369 * tests/du/long-sloop: New file. Test for today's fts.c bug fix.
370 That bug could make du -L, chgrp -L, or chown -L fail to diagnose
371 a very long sequence of symbolic links (not necessarily a loop).
372 * tests/du/Makefile.am (TESTS): Add long-sloop.
374 2006-01-11 Paul Eggert <eggert@cs.ucla.edu>
376 * src/test.c (test_syntax_error): Append a newline. All callers
377 changed, except for the ones that didn't already append a newline.
378 Bug reported by Eric Blake.
380 2006-01-11 Jim Meyering <jim@meyering.net>
382 * src/system.h (X2NREALLOC): Now that verify_true is no longer
383 void, cast its result to void, to avoid gcc's warning that
384 ``left-hand operand of comma expression has no effect''.
385 (DECIMAL_DIGIT_ACCUMULATE, X2REALLOC): Likewise.
387 2006-01-10 Jim Meyering <jim@meyering.net>
389 * tests/chmod/no-x: Add a test for today's fts.c fix.
391 2006-01-10 Jim Meyering <jim@meyering.net> (tiny change)
393 * src/ls.c (gobble_file): Use DTTOIF only if it's defined.
394 This is necessary for Dragonfly. Patch by Joerg Sonnenberger.
396 2006-01-10 Paul Eggert <eggert@cs.ucla.edu>
398 * src/system.h (X2NREALLOC, X2REALLOC, DECIMAL_DIGIT_ACCUMULATE):
399 Use verify_true instead of verify_expr, to sync with gnulib.
401 2006-01-08 Jim Meyering <jim@meyering.net>
403 * src/date.c (usage): Adjust the formatting of the entries for
404 %::z and %:::z (separate with two spaces, not one) so that help2man
405 formats them properly. Reported by Philip Rowlands.
407 2006-01-06 Paul Eggert <eggert@cs.ucla.edu>
409 * configure.ac (gl_IGNORE_UNUSED_LIBRARIES): Add.
411 2006-01-06 Jim Meyering <jim@meyering.net>
413 * Makefile.maint (copyright-check): Use date +%Y in place of
416 * src/remove.c (rm_1): Remove `static' attribute on local `status'.
417 First off, the attribute should have been `volatile' (not static)
418 to avoid longjmp-related risk of clobber. Secondly, now there is
419 no longer any risk of a local variable being clobbered, so there's
420 no need for any attribute at all.
422 2006-01-05 Jim Meyering <jim@meyering.net>
424 * src/remove.c: Give a few functions the inline attribute.
425 (AD_pop_and_chdir): Use gotos to avoid some duplication.
426 (AD_push): Rewrite an assertion so that the entire computation
427 goes away when assertions are turned off.
429 * src/tail.c (ENOSYS) [!defined ENOSYS]: Don't define here.
430 It's already defined in "system.h".
431 * Makefile.maint: Add a FIXME comment.
433 2006-01-04 Jim Meyering <jim@meyering.net>
435 * ChangeLog: Remove entries from 2005-10-22 and earlier.
436 * ChangeLog-2005: New file, for entries up to version 5.92.
438 2006-01-03 Jim Meyering <jim@meyering.net>
440 * tests/du/no-x: Also allow a slightly different diagnostic -- the
441 one you get when using openat-enabled fts.c and du (coming soon).
442 * tests/chmod/no-x: Likewise.
443 * tests/chgrp/no-x: Likewise.
445 * src/system.h (O_DIRECTORY) [!defined O_DIRECTORY]: Define.
447 2006-01-02 Paul Eggert <eggert@cs.ucla.edu>
449 * src/chown-core.c (RC_do_ordinary_chown): New enum value.
450 (restricted_chown): Return it, if the file cannot be accessed due
451 to EPERM, or if no uid or gid are required, or if the file is
452 neither a directory nor a regular file. Rewrite to avoid gotos.
453 (change_file_owner): Handle RC_do_ordinary_chown case.
454 Rewrite to avoid gotos.
455 * tests/chgrp/basic: Make sure we can change the group of
458 * src/date.c (usage): Explain %g, %G, and %V a bit better.
460 2006-01-02 Jim Meyering <jim@meyering.net>
462 * src/copy.c (set_owner): Correct a comment.
464 * src/tail.c (parse_options): Change warning to say that --retry
465 is useful `mainly' (not `only') when following by name.
466 Reported here: http://bugs.debian.org/273781
468 2006-01-01 Paul Eggert <eggert@cs.ucla.edu>
470 * NEWS: Document that mkfifo and mknod -m no longer set special bits.
471 * src/copy.c: Include lchmod.h.
472 (copy_internal): Use lchmod rather than chmod.
473 * src/cp.c: Include lchmod.h.
474 (re_protect, make_dir_parents_private): Use lchmod rather than chmod.
475 * src/mkdir.c: Include lchmod.h.
476 (usage): Clarify -m's operation.
477 (main): Use lchmod rather than chmod. Don't use lchmod unless the
478 new mode contains bits outside the 777 range.
479 * src/mkfifo.c (usage): Clarify -m's operation.
480 (main): If -m is given, don't invoke chmod; use umask 0 instead.
481 Report an error if -m asks for bits outside the 777 range.
482 * src/mknod.c (usage, main): Likewise.
484 * src/mkdir.c, src/mkfifo.c, src/mknod.c: Undo 2005-12-19 changes.
486 2005-12-27 Jim Meyering <jim@meyering.net>
488 * Makefile.maint (sc_obsolete_symbols): Prohibit use of O_NDELAY.
489 (sc_prohibit_assert_without_use): New rule.
490 (syntax-check-rules): Add it to the list.
491 * .x-sc_prohibit_assert_without_use: New empty file.
492 * Makefile.am (EXTRA_DIST): Add it.
494 * Makefile.maint (CVS_LIST): Define in terms of $(srcdir).
496 * cp.c, df.c, link.c, mknod.c, nice.c, sleep.c, unlink.c:
497 Don't include <assert.h>; it wasn't used.
499 2005-12-26 Paul Eggert <eggert@cs.ucla.edu>
501 * src/chown-core.c (restricted_chown):
502 Don't try O_WRONLY unless O_RDONLY failed wth EACCES.
503 * src/remove.c (fd_to_subdirp): Open with O_DIRECTORY | O_NOCTTY
504 | O_NOFOLLOW too, for consistency with other dir-openers.
505 Use POSIX-preferred O_NONBLOCK rather than O_NDELAY.
506 (is_empty_dir): Likewise.
507 * src/shred.c (wipename): Likewise. Don't bother trying to open
508 dir for writing, since POSIX prohibits it.
510 2005-12-22 Jim Meyering <jim@meyering.net>
512 * tests/help-version: Redirect stderr to /dev/full, to suppress
513 write error diagnostic.
515 2005-12-19 Jim Meyering <jim@meyering.net>
517 * src/mkdir.c, src/mknod.c, src/mkfifo.c (main)
518 Avoid a minor race condition when `-m MODE' is specified, by using
519 open, fchown, and close rather than just chown. To do that reliably --
520 even with an overly restrictive umask -- ensure that each mkdir,
521 mknod and mkfifo call uses a mode including at least owner-read access.
522 * src/mknod.c (main): When `-m MODE' is specified, exit nonzero if
523 the subsequent chown (or equivalent open,fchown,close) fails.
524 * tests/misc/mknod: New tests.
525 * tests/misc/Makefile.am (TESTS): Add mknod.
527 2005-12-17 Jim Meyering <jim@meyering.net>
529 * src/remove.c (is_empty_dir): Open with O_NDELAY, so we don't hang,
530 e.g., on a named pipe.
531 (OPEN_NO_FOLLOW_SYMLINK): Remove definition. Use O_NOFOLLOW in
532 place of all uses, since it is guaranteed (system.h) to be defined.
534 2005-12-05 Andreas Gruenbacher <agruen@suse.de>
536 Add POSIX ACL support
537 * src/ls.c: Switch back from HAVE_ACL to USE_ACL: The acl() syscall
538 is no requirement for ACL support; particularly, it does not exist
539 on systems that have POSIX ACLs.
540 * src/copy.h (cp_option_init) [umask_kill]: Remove member.
541 * src/cp.c (umask_kill): With default acls, the umask is not to be
542 applied. Remove umask_kill, don't change the process umask, and let
543 the kernel apply the umask where appropriate.
544 * src/cp.c (make_dir_parents_private): Fix logic for POSIX ACLs.
545 * src/copy.c (get_dest_mode): Remove; it is obsolete after removing
547 (copy_reg, copy_internal): Use copy_acl and set_acl
548 instead of fchown/chown. Fix the logic for POSIX ACLs.
549 (chown_succeded): Remove; we now always copy acls and
550 preserve S_ISUID, S_ISGID, and S_ISVTX when needed, no matter if we
551 did a chown before or not.
552 * src/mv.c, src/install.c (cp_option_init): Don't set umask_kill member.
553 * src/Makefile.am (dir_LDADD, ls_LDADD, vdir_LDADD, cp_LDADD,
554 mv_LDADD, ginstall_LDADD): On systems with an ACL library, arrange
555 to link with it via $(LIB_ACL), for the utilities that need it.
557 2005-12-16 Paul Eggert <eggert@cs.ucla.edu>
559 * src/remove.c (OPENAT_CWD_RESTORE__REQUIRE): Remove.
560 (OPENAT_CWD_RESTORE__ALLOW_FAILURE): Likewise.
561 (fd_to_subdirp): Remove openat_cwd_restore_allow_failure arg; its
562 value is now signified by whether cwd_errno is null.
563 (fd_to_subdirp, remove_dir, rm_1); Change cwd failure indicator from
564 pointer-to-bool to pointer-to-errno-value. All callers changed.
565 (rm_1): Don't bother setting a local cwd failure flag and then
566 ORing it into the caller's. Just set the caller's.
567 (rm): Use cwd failure errno value to print a slightly-better
570 2005-12-15 Jim Meyering <jim@meyering.net>
572 * src/stat.c (print_it): Properly handle a backslash at the
573 end of a --printf format string. Reported by Paul Eggert.
574 * tests/misc/stat-printf (end-bs): Add a test for the above.
576 2005-12-15 Paul Eggert <eggert@cs.ucla.edu>
578 * tests/acl: Port to pre-POSIX shells like Solaris 8 /bin/sh.
579 Don't assume /etc/passwd contains user names; use 'id' instead.
581 2005-12-15 Jim Meyering <jim@meyering.net>
583 stat: revert behavior of --format=FMT (-c)
584 stat: add new option: --printf=FMT
585 * NEWS: Mention this.
586 * src/stat.c (isodigit, octtobin, hextobin): Define.
587 (PRINTF_OPTION): Define.
588 (interpret_backslash_escapes, trailing_delim): New globals.
589 (usage): Document them. Alphabetize on long option names.
590 (print_esc_char): New function.
591 (print_it): Rewrite, in order to handle backslash escapes.
592 (main): Handle new option. Set globals for --format, too.
594 * tests/misc/stat-printf: Test --printf and --format.
595 * tests/misc/Makefile.am (TESTS): Add stat-printf.
597 2005-12-14 Paul Eggert <eggert@cs.ucla.edu>
599 * NEWS: sort now reports incompatible options.
600 * src/sort.c (incompatible_options, check_ordering_compatibility):
602 (main): Use them. Don't bother with a usage message for
603 "sort -c a b", for consistency with other error diagnostics.
604 * tests/sort/Test.pm (incompat1, incompat2, incompat3, incompat4):
607 * src/cat.c (main): Undo previous change. close_stdout already
608 does the check, so the previous change wasn't necessary.
610 2005-12-13 Paul Eggert <eggert@cs.ucla.edu>
612 * src/cat.c (main): Check for close (STDOUT_FILENO) failure.
614 2005-12-12 Paul Eggert <eggert@cs.ucla.edu>
616 Install a more-conservative approach for sort -R. It's the
617 same basic idea as the existing code, except it uses the full ISAAC
618 approach (called the "more kosher" approach in the existing comments).
619 This makes "sort -R" quite a bit slower (about a factor of 2 on my
620 little tests involving 10000 lines on a 2.4 GHz P4), but I think it's
621 better to be conservative here at first, and review any performance
622 improvements carefully.
623 * .x-sc_require_config_h: Add src/rand-isaac.c.
624 * src/rand-isaac.h: Remove. All uses now simply include rand-isaac.c.
625 * src/Makefile.am (noinst_HEADERS): Remove rand-isaac.h.
626 (shred_SOURCES, sort_SOURCES): Remove.
627 (EXTRA_DIST): Add rand-isaac.c.
628 * src/rand-isaac.c: Revert to what used to be in shred.c, without
629 changing it to allow for varying numbers of words in the state.
630 Alter so that we include rand-isaac.c directly rather than
631 compiling it and linking to it. Don't include config.h or
632 system.h; that's the includer's responsibility.
633 Omit functions that are specific to shred.
634 (ISAAC_LOG, ISAAC_WORDS, ISAAC_BYTES, struct isaac_state, ind):
635 (isaac_step, struct irand_state):
636 Resurrect these, with the same defns that used to be in shred.c.
637 (ISAAC_SIZE, isaac_new, isaac_copy): Remove.
638 (isaac_refill, isaac_seed_start, isaac_seed_data, irand_init, irand32):
640 (struct isaac_state, isaac_refill, isaac_mix, isaac_init):
641 (isaac_seed_start, isaac_seed_data, isaac_seed_finish, isaac_seed):
642 (irand_init, irand32, irand_mod):
643 Number of words is constant again.
644 (struct irand_state, irand_init, irand32, irand_mod): Move to shred.c.
645 * src/shred.c: Include rand-isaac.c rather than rand-isaac.h.
646 * src/sort.c: Likewise.
647 * src/shred.c (fillrand, dopass, main): Undo previous change.
648 (struct irand_state, irand_init, irand32, irand_mod): Moved back here,
650 * src/sort.c: Don't include md5.h; it wasn't needed.
651 (struct keyfield): Rename random_hash to random, for consistency
652 with the other member names. All uses changed.
653 (usage): Tweak wording to mention STRING for --seed option.
654 (short_options): Rorder for consistency with other programs.
655 (rand_state): Now a struct, not a pointer to one. All uses changed.
656 (HASH_WORDS, HASH_SIZE): Remove.
657 (get_hash): Remove comments around resbuf size, since we can assume C89.
658 Use a "more-kosher" (but slower) approach of invoking isaac_refill.
659 (keycompare): Adjust to the new get_hash.
661 (badfieldspec): Omit recently-introduced comment; it isn't needed.
662 (main): Don't set need_random simply because gkey has it set; that
663 doesn't necessarily mean we'll need random numbers.
664 Redo seeding to match new get_hash approach.
666 2005-12-10 Jim Meyering <jim@meyering.net>
668 * src/Makefile.am (noinst_HEADERS): Add rand-isaac.h.
670 Avoid shred segfault on 64-bit systems.
671 * src/rand-isaac.c (isaac_refill): Don't try to negate a
672 local of type uint32_t. Make the local an `int' instead.
674 * NEWS: Mention sort's new options.
676 * src/rand-isaac.c (isaac_mix): Declare to be static.
677 Mark all other functions as `extern' so the tight-scope
678 part of `make distcheck' passes once again.
679 * src/rand-isaac.h (isaac_mix): Remove declaration.
681 * src/sort.c (get_hash): Change position of `*' in parameter
682 type to conform with convention.
683 (main): Split a long line so it fits in 80 columns.
684 (keycompare): Remove stray SPACE before TAB that was
685 causing `make distcheck' to fail.
687 * src/shred.c: Don't include gethrxtime.h. No longer needed.
689 * tests/misc/sort-rand: New file: basic tests for the new options.
690 * tests/misc/Makefile.am (TESTS): Add sort-rand.
692 2005-12-10 Frederik Eaton <frederik@ofb.net>
694 * src/Makefile.am (sort_LDADD): Add $(LIB_GETHRXTIME).
695 (shred_SOURCES, sort_SOURCES): New macros, so we compile rand-isaac.c.
696 * src/rand-isaac.c: New file, containing ISAAC code that was in shred.c.
697 Make state size runtime-configurable.
698 (isaac_new, isaac_copy): New functions.
699 * src/rand-isaac.h: New file.
700 * src/shred.c: Include rand-isaac.h. Move ISAAC code to rand-isaac.c.
701 (fillrand, main): Adjust to the fact that the state size is now
702 runtime-configurable.
703 * src/sort.c (short_options, long_options, WORDS, keycompare, main):
704 (usage): Add options --random-sort and --seed to implement a random
706 Include md5.h and rand-isaac.h.
707 (get_hash): New function.
708 (rand_state): New var.
709 (HASH_WORDS, HASH_SIZE): New macros.
711 2005-12-09 Paul Eggert <eggert@cs.ucla.edu>
713 * tests/dd/misc: Add test for dd iflags=noatime.
715 2005-12-09 Jim Meyering <jim@meyering.net>
717 * src/sort.c (usage): Mention white space vs -b and -t options.
720 2005-12-09 Eric Blake <ebb9@byu.net>
722 * src/test.c (main): Fix misleading comment.
724 2005-12-07 Paul Eggert <eggert@cs.ucla.edu>
726 * NEWS: Mention dd's new noatime flag.
727 * src/system.h (O_NOATIME): Define to 0 if not already defined.
728 * src/dd.c (flags, usage): Add support for noatime flag.
730 2005-12-07 Jim Meyering <jim@meyering.net>
732 Distribute the cvsu script, used only by `make syntax-check'.
733 * Makefile.am (EXTRA_DIST): Add build-aux/cvsu.
734 * Makefile.maint (CVS_LIST): Use build-aux/cvsu, now that we
735 distribute a copy of this script.
736 * .x-sc_unmarked_diagnostics: Add build-aux/cvsu.
738 * tests/mv/acl: exit-77 before the trap, not after, if we fail
739 to create a temporary directory on another partition.
740 From Andreas Gruenbacher.
742 2005-12-06 Tomas Pospisek <tpo@sourcepole.ch> (tiny change)
744 * man/basename.x: Cross-reference to dirname and readlink.
745 * man/dirname.x: Cross-reference to basename and readlink.
747 2005-12-05 Andreas Gruenbacher
749 * src/copy.c [!HAVE_FCHOWN]: Define fchown(...) to -1.
750 (set_owner, preserve_author): New functions, factored out of copy_reg.
751 (copy_reg): Use them.
752 (copy_internal): Use them here, too.
754 2005-12-04 Jim Meyering <jim@meyering.net>
756 * src/sleep.c (usage): Say what happens with two or more arguments.
757 Suggested by Justin Pryzby.
759 * src/uptime.c (print_uptime): Move decl of `upsecs' into scope
762 2005-12-03 Jim Meyering <jim@meyering.net>
764 * src/rm.c (long_opts): Change the name of each undocumented, for-
765 testing-only option to start with `-', so that it cannot render
766 ambiguous any prefix it happens to share with some other option name.
767 Problem reported by Eric Blake.
768 * src/head.c (long_options): Likewise.
769 * src/tail.c (long_options): Likewise.
771 * tests/misc/head-elide-tail: Update uses of undocumented, for-
772 testing-only --presume* options to start with `---'.
773 * tests/rm/dangling-symlink: Likewise.
774 * tests/rm/dir-no-w: Likewise.
775 * tests/rm/isatty: Likewise.
777 2005-11-30 Jim Meyering <jim@meyering.net>
779 * Makefile.maint: Add a comment about cvsu.
781 2005-11-25 Paul Eggert <eggert@cs.ucla.edu>
783 * NEWS: df updates for "none", "proc", inaccessible file systems.
784 * src/df.c (show_point): Ignore inaccessible file systems.
785 (usage): -a includes dummy file systems, not size-0 file systems.
787 * src/od.c (unsigned_long_long_int): Renamed from ulonglong_t,
788 to avoid collision with POSIX name space. All uses changed.
790 2005-11-24 Jim Meyering <jim@meyering.net>
792 * tests/Makefile.am (EXTRA_DIST): Add acl to the list.
793 * tests/acl: Add `$0: ' prefix to diagnostics.
795 * .x-sc_require_config_h: Add lib/buffer-lcm.c to the list.
797 2005-11-23 Paul Eggert <eggert@cs.ucla.edu>
799 * src/copy.c: Improve performance a bit by optimizing away
800 unnecessary system calls and going to a block size of at least
801 8192 (on normal hosts, anyway). This improved performance 5% on my
802 Debian stable host (2.4.27 kernel, x86, copying from root
803 ext3 file system to itself).
804 Include "buffer-lcm.h".
805 (copy_reg): Omit last argument. All callers changed.
806 Use xmalloc to allocate rather than trusting alloca
807 (which is unwise with large block sizes).
808 Declare locals more locally, if possible.
809 Use uintptr_t words instead of int words, for a bit more speed
810 when looking for null blocks on 64-bit hosts.
811 Optimize away reads of zero bytes on regular files.
812 In the typical case, insist on 8 KiB buffers, at least.
813 Avoid unnecessary extra call to fstat when checking for sparse files.
814 Avoid now-unnecessary cast to off_t, and "0L".
815 Avoid unnecessary test of *new_dst when checking for same owner
818 2005-11-22 Paul Eggert <eggert@cs.ucla.edu>
820 * src/remove.c (rm): Don't assume C99 for-loop syntax.
822 2005-11-22 Jim Meyering <jim@meyering.net>
824 * src/remove.c (AD_push): Remove debugging cruft.
826 * tests/rm/unread2 (rm): Change expected diagnostic,
827 `cannot open directory' to `cannot remove', to align with
829 * tests/rm/rm2: Ensure that rm now continues removing entries
830 even after certain types of failure.
832 * src/remove.c: Rewrite. Now, this module is reentrant on systems
833 that provide openat (Solaris), and on systems like Linux+procfs
834 where our openat emulation code is reentrant. This also fixes a
835 few low-probability leaks and eliminates some code that could,
836 in very unusual circumstances, cause rm() (via a callee) to exit.
837 * NEWS: Mention this.
839 * configure.ac: Put copyright dates all on one line so the
840 emacs function that updates them works properly.
842 2005-11-18 Paul Eggert <eggert@cs.ucla.edu>
844 * configure.ac (AM_PROG_CC_C_O): Add. Needed for CVS Automake.
845 Problem reported by Eric Blake.
846 (AC_PROG_CC_STDC): Use this instead of AC_PROG_CC, so that
847 we get a standard-conforming compiler. This relies on the new
848 m4/c.m4 file. Note that it's a bit tricky, since c.m4 doesn't
849 define AC_PROG_CC_STDC; we are relying on Autoconf 2.59 internals.
850 m4/c.m4 can go away with Autoconf 2.60 comes out.
852 2005-11-17 Jim Meyering <jim@meyering.net>
854 * src/remove.c (AD_mark_helper): Make a `char *' parameter `const'.
855 (AD_mark_current_as_unremovable): Likewise, but for a local.
858 * tests/mv/acl: Let traps handle removing temporary directories.
860 Expect acl-related tests to fail, until the corresponding
861 patches are committed.
862 * tests/mv/Makefile.am (XFAIL_TESTS): Add acl.
863 * tests/cp/Makefile.am (XFAIL_TESTS): Likewise.
865 ACL tests, from Andreas Gruenbacher.
866 * tests/acl, tests/mv/acl, tests/cp/acl: New files.
867 * tests/mv/Makefile.am (TESTS): Add acl.
868 * tests/cp/Makefile.am (TESTS): Add acl.
870 * src/ls.c (basename_is_dot_or_dotdot): Correct wording in comment.
872 2005-11-16 Paul Eggert <eggert@cs.ucla.edu>
874 * NEWS: Improve quality of ln's diagnostics.
875 * src/ln.c (do_link, usage): Likewise.
876 (do_link): Don't use alloca on a buffer of unbounded size.
878 2005-11-16 Jim Meyering <jim@meyering.net>
880 * tests/cp/fail-perm: Accommodate HPUX. It appears to fail
881 with EACCES rather than EPERM. Reported by Peter O'Gorman here:
882 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/5766
884 2005-11-14 Jim Meyering <jim@meyering.net>
886 * NEWS (sort): Mention consequences of today's mkstemp-safer.c fix.
888 2005-11-13 Jim Meyering <jim@meyering.net>
890 * announce-gen: Accept new option, --gpg-key-id=ID and
891 emit a blurb telling how to use the .sig files.
892 * Makefile.cfg (gpg_key_ID): Define.
893 * Makefile.maint (announcement): Use new option and key.
895 Require that most .c files include <config.h>.
896 * Makefile.maint (sc_require_config_h): New rule.
897 (syntax-check-rules): Add it.
898 * .x-sc_require_config_h: New file listing exceptions to the
899 above rule. Some are legit, others are simply grandfathered in.
900 * Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h here, too.
902 2005-11-12 Jim Meyering <jim@meyering.net>
904 * src/checksum.h, src/md5.c, src/sha1sum.c: Remove now-unused files.
906 2005-11-11 Jim Meyering <jim@meyering.net>
908 * NEWS: Mention `readlink -f' bug fix in 5.3.0 news.
909 Mention new readlink options in 5.3.0's `New features' section.
910 Spotted by Thomas Hood.
912 2005-11-08 Jim Meyering <jim@meyering.net>
914 * NEWS: Merge in changes from b5_9x branch.
916 2005-11-08 Paul Eggert <eggert@cs.ucla.edu>
918 * NEWS: ls now defaults to --time-style='locale', which in turn acts
919 like --time-style='posix-long-iso' if the locale settings are messed up.
920 * src/ls.c (decode_switches): Implement this.
922 2005-11-08 Jim Meyering <jim@meyering.net>
924 * tests/du/2g: s/expensive/very expensive/ in a comment.
927 2005-10-17 Eric Blake <ebb9@byu.net>
929 * src/ls.c (usage): Fix descriptions of --sort, --time.
930 Reported by Vitaly A. Ostanin.
932 2005-11-04 Paul Eggert <eggert@cs.ucla.edu>
934 * src/ln.c: Include filenamecat.c.
935 (FILE_BASENAME_CONCAT): Remove.
936 (do_link): Remove last arg DEST_IS_DIR. All callers changed.
937 (main): Use file_name_concat, base_name, and strip_trailing_slashes
938 instead of FILE_BASENAME_CONCAT. This simplifies the code, and avoids
941 2005-11-04 Jim Meyering <jim@meyering.net>
943 * src/du.c (process_file): Don't overflow for files of size >= 2^31
944 on systems with stat.st_blocks of a signed 32-bit type.
945 This bug causes trouble on some AIX 5.1 systems.
946 Report and trivial patch from Paul Townsend:
947 <http://lists.gnu.org/archive/html/bug-coreutils/2005-11/msg00033.html>
948 * NEWS: Mention this.
950 * tests/du/2g: New (very-expensive) test for the above-fixed bug.
951 * tests/du/Makefile.am (TESTS): Add it here.
952 * tests/very-expensive: New file.
953 * tests/Makefile.am (EXTRA_DIST): Add it here.
954 * tests/cp/perm: Mark this test as `very-expensive', too.
956 2005-11-02 Paul Eggert <eggert@cs.ucla.edu>
958 * NEWS: Mention that rm -d and maybe ln -d are scheduled for
960 * src/remove.h (struct rm_options): Remove unlink_dirs. All uses
962 * src/rm.c (usage): Don't mention rm -d.
964 2005-11-02 Jim Meyering <jim@meyering.net>
966 * tests/dd/skip-seek: Fix typo in comment: s/fileutils/coreutils.
969 * tests/dd/unblock-sync: Redirect stderr to /dev/null so the
970 `M+N records in/out' lines don't pollute `make check' output.
972 * tests/dd/skip-seek (sk-seek4): New test, to exercise the bug
973 fixed on 2005-10-31. This test uses the new, IN_PIPE specifier.
974 * tests/Coreutils.pm: Accept a new type of input specifier: IN_PIPE,
975 to indicate that the input file should be piped into the command
976 under test (via `cat FILE | $prog ...').
978 * src/remove.c (remove_entry): Emit a better diagnostic when rm
979 (without -r) fails to remove a directory on a non-Linux system.
980 This change affects only newer Solaris systems (with priv_*
981 functions like priv_allocset). Reported by Keith Thompson.
983 * tests/rm/dir-nonrecur: New file/test for the above fix.
984 * tests/rm/Makefile.am (TESTS): Add dir-nonrecur.
986 2005-11-01 Paul Eggert <eggert@cs.ucla.edu>
988 * NEWS: "tail -c 2 FILE" and "touch 0101000000" now operate as
989 POSIX 1002.1-2001 requires.
990 * src/tail.c (parse_obsolete_option): Implement this.
991 Problem reported by Vincent Lefevre.
992 * src/touch.c (main): Pass PDS_PRE_2000 to posixtime.
993 * tests/tail/Test.pm (c-2, c-2-minus, c2, c2-minus): New tests.
994 (test_vector): Add special cases for _POSIX2_VERSION, and
995 regularize the old ones a bit.
996 * tests/touch/obsolescent: Add y2000 test.
998 2005-10-31 Paul Eggert <eggert@cs.ucla.edu>
1000 * src/dd.c (skip): Fix off-by-one error reported by
1001 Theodoros V. Kalamatianos.
1003 2005-10-30 Paul Eggert <eggert@cs.ucla.edu>
1005 * tests/mkdir/p-3: Require that the test be run as non-root.
1006 Problem and trivial fix reported by Theodoros V. Kalamatianos.
1008 2005-10-28 Paul Eggert <eggert@cs.ucla.edu>
1010 * src/ln.c (FILE_BASENAME_CONCAT): Omit unnecessary slashes in the
1011 boundary between DEST and SOURCE in the result.
1013 2005-10-26 Dmitry V. Levin <ldv@altlinux.org>
1015 * src/md5sum.c (main) [!O_BINARY]: Changed default read mode
1016 back to text, to sync with documentation and for backwards
1019 2005-10-25 Jim Meyering <jim@meyering.net>
1021 * tests/dircolors/simple (other-wr): Add an explicit test for
1022 the dircolors bug (NULL-dereference) fixed yesterday.
1024 2005-10-24 Jim Meyering <jim@meyering.net>
1026 * src/tac.c (tac_file): When determining whether a file is seekable,
1027 also test whether it is a tty. Using only the lseek-based test would
1028 give a false positive on Solaris. Reported by Peter Fales.
1030 2005-10-24 Dmitry V. Levin <ldv@altlinux.org>
1032 * tests/install/d-slashdot: New test, for "install -d" failure.
1033 * tests/install/Makefile.am (TESTS): Add d-slashdot.
1034 * tests/mkdir/p-slashdot: New test, for "mkdir -p" failure.
1035 * tests/mkdir/Makefile.am (TESTS): Add p-slashdot.
1037 2005-10-24 Jim Meyering <jim@meyering.net>
1039 * src/dircolors.c (ls_codes): Add missing comma.
1040 Anonymous report and patch from
1041 http://savannah.gnu.org/bugs/?func=detailitem&item_id=14849
1043 * src/dircolors.c: Add compile-time assertion that the slack_codes
1044 and ls_codes arrays have the same number of elements. This would
1045 have prevented the above-fixed bug.
1047 * src/expand.c (parse_tab_stops): Add a comment to make this function
1048 identical to the one in unexpand.c.
1049 * src/unexpand.c (parse_tab_stops): Adjust syntax to make this function
1050 identical to the one in expand.c.
1052 * src/expand.c (next_file): Don't assume fopen cannot return stdin.
1054 2005-10-23 Jim Meyering <jim@meyering.net>
1056 * src/md5sum.c (digest_check, main): Use ptr_align rather than
1057 a dangerous pointer-value-to-`unsigned' cast.
1058 * NEWS: mention the new sha* programs.
1059 * AUTHORS: Add new sha* programs.
1061 2005-08-28 David Madore <david.madore@ens.fr>
1063 Add new programs: sha224sum, sha256sum, sha384sum, sha512sum.
1064 * README: Add their names to the list.
1065 * src/md5sum.c: Provide framework for computing sha-2 hashes.
1066 * src/Makefile.am (sha224sum, sha256sum, sha384sum, sha512sum):
1067 Rules for compiling sha-2 utilities
1068 (noinst_HEADERS): Remove checksum.h.
1069 * man/sha512sum.x, man/sha384sum.x, man/sha256sum.x, man/sha224sum.x:
1071 * man/Makefile.am (dist_man_MANS): Add the corresponding .1 names.
1072 (sha224sum.1, sha256sum.1, sha384sum.1, sha512sum.1): New dependencies.
1073 * tests/misc/sha224sum, tests/misc/sha256sum: New files.
1074 * tests/misc/sha384sum, tests/misc/sha512sum: New files.
1075 * tests/misc/Makefile.am (TESTS): Add new sha224sum, sha256sum,
1076 sha384sum, sha512sum test scripts here rather that each in its
1079 2005-08-28 David Madore <david.madore@ens.fr>
1081 * tests/sha1sum/basic-1 (million-a): Add the "million a's" test (one
1082 of the FIPS test vectors).
1084 2005-10-23 Jim Meyering <jim@meyering.net>
1086 * configure.ac: Use 6.0-cvs as the version string.
1087 * NEWS: Adjust accordingly.