1 2006-07-27 Jim Meyering <jim@meyering.net>
3 * src/chgrp.c (usage): Use correct grammar in description of the
5 * src/chown.c (usage): Likewise.
7 2006-07-26 Thomas Schwinge <tschwinge@gnu.org> (tiny change)
9 * src/copy.c (set_author) [HAVE_STRUCT_STAT_ST_AUTHOR]:
10 Correctly access SRC_SB's element ST_AUTHOR.
12 2006-07-26 Jim Meyering <jim@meyering.net>
14 * tests/ls/stat-failed: Adapt to match new expected output.
17 * src/ls.c (print_color_indicator): Test for S_IFREG first, rather
18 than having the code test for all of the other types first.
19 Hoist the set-uid/gid-testing code "up" into this new block.
20 Classify any other type of file (e.g., S_TYPEISSHM, etc.) as
21 C_ORPHAN, not as C_FILE.
23 2006-07-26 Jim Meyering <jim@meyering.net>
25 Checking in a change from Paul.
27 2006-07-25 Paul Eggert <eggert@cs.ucla.edu>
29 * src/ls.c (DT_INIT): Remove. All uses removed.
30 (enum filetype): Use an ordinary enum rather than trying to keep
31 the values in sync with DT_FIFO etc. That way, we don't have
32 to make special assumptions about them. All uses changed.
33 (whiteout): New constant member of enum filetype.
34 (filetype_letter): New constant, for use with enum filetype.
35 (FILETYPE_INDICATORS): New initializer list.
36 (print_dir): Add case for DT_WHT.
37 (gobble_file): If stat fails, don't discard information from
38 readdir; instead, preserve it so it can be printed.
39 (print_long_format): Fall back on readdir result if stat info
40 is not available. Use "?" to denote each unknown mode char,
41 instead of an overall "?", since we now know some of the mode
43 (print_type_indicator): Now that MODE isn't necessarily
44 useful, guard all uses.
45 Now that two blocks in the type-checking tree can set "type = C_FILE",
46 move the suffix-handling code out and down.
48 2006-07-26 Jim Meyering <jim@meyering.net>
50 Prepare for the above change.
51 * src/ls.c [struct fileinfo] (stat_ok): Rename from stat_failed,
52 and adjust uses. From a patch by Paul Eggert.
54 2006-07-26 Jim Meyering <jim@meyering.net>
56 * src/ls.c: Correct indentation/formatting in a few places.
58 2006-07-25 Paul Eggert <eggert@cs.ucla.edu>
60 * tests/cp/fail-perm: Use "chmod 0500" rather than "chmod 500".
61 Problem report and fix from Bob Proulx.
62 * NEWS: Clarify the "chmod 0500" news, and correct the vague
63 statements about compatibility with BSD.
65 2006-07-25 Jim Meyering <jim@meyering.net>
67 * src/ls.c (gobble_file): When handling a stat-failed entry,
68 print the entry name not the absolute_name -- to be consistent
70 * tests/ls/stat-failed: Update accordingly.
72 * src/ls.c: Add parens around the new uses of ?: ternary operator.
74 * src/dircolors.hin: Mention that ORPHAN refers not just to dangling
77 Get --dired offsets right when handling stat-failed entries.
78 * src/ls.c (print_long_format): Be careful to increment P by the
79 appropriate amount, even when inode_number_width and nlink_width
81 * tests/ls/stat-failed: Test for the above.
83 * src/ls.c (gobble_file) [USE_ACL]: Don't use-uninitialized the
84 have_acl member. That would happen for a directory with both a
85 non-stat'able entry and one with an ACL.
87 * src/ls.c (gobble_file): Make it so failure to stat a
88 non-command-line file provokes an exit status of 1, not 0.
89 Say "cannot access" rather than "cannot stat".
90 * tests/ls/stat-failed: New file/test, for the above.
91 * tests/ls/Makefile.am (TESTS): Add stat-failed.
92 * tests/ls-2/tests (no-a-isdir-b): Update to reflect addition
93 of "cannot access " to diagnostic.
95 * src/ls.c: Declare stat_failed to be "bool", not "int" everywhere.
97 * src/ls.c [enum filetype] (command_line): Remove member. Not needed.
98 Replace all occurrences of "type == command_line" with the
99 equivalent, "command_line_arg".
101 * src/ls.c: Apply the stat-failed parts of Red Hat's
102 coreutils-selinux.patch. From Ulrich Drepper.
103 This makes it so files not mentioned on the command line (e.g.,
104 names read from a directory that *is* mentioned on the command
105 line) for which stat fails are still listed. With --color,
106 such files are colored just like ORPHANs (aka dangling symlinks).
108 * src/df.c (n_valid_args): Declare global to be static.
110 2006-07-24 Jim Meyering <jim@meyering.net>
112 * tests/ls/stat-dtype: Skip this test on reiserfs, since that file
113 system lacks d_type support.
115 2006-07-22 Paul Eggert <eggert@cs.ucla.edu>
117 * man/chmod.x: Update to reflect recent changes to coreutils.texi.
119 2006-07-21 Jim Meyering <jim@meyering.net>
121 * src/su.c (usage): Correct typo in --help output: s/commmand/command/
122 Reported by Tim Waugh.
123 Also remove the comment duplicating much of --help output.
125 * src/ls.c (FILE_TYPE_INDICATOR_OPTION): Reposition this new
126 name so the list remains alphabetized.
128 Fix another bug: ls --indicator-style=file-type would call
129 stat for a symlink, even though it wasn't always needed.
130 In some cases, that unnecessary stat would cause ls to fail.
131 * src/ls.c (gobble_file): Don't treat symlinks specially (in
132 requiring a stat syscall). Remove the offending exclusion.
134 * NEWS: Mention the fix.
136 * tests/ls/stat-dtype: New file/test, for the above fix.
137 Also exercises the new df feature, below.
139 * src/df.c (main): Fail and don't print the headers if no
140 file system is processed. This makes it easy to test whether
141 a specified directory is on a file system of a given type or types.
142 Otherwise, applications would have had to parse df's output.
143 E.g., is "." either ext3 or reiserfs: df -t ext3 -t reiserfs .
145 Fix a bug: ls --file-type worked like --indicator-style=slash,
146 rather than like --indicator-style=file-type.
147 * src/ls.c (FILE_TYPE_INDICATOR_OPTION): New enum member.
148 (long_options): Map "file-type" to FILE_TYPE_INDICATOR_OPTION,
150 (decode_switches): Handle new case: FILE_TYPE_INDICATOR_OPTION.
151 * NEWS: Mention the fix.
152 * tests/ls-2/tests (file-type): New test, for the above fix.
154 2006-07-19 Jim Meyering <jim@meyering.net>
156 * src/ls.c (print_dir): Give a better diagnostic for failed opendir.
158 * Makefile.am (EXTRA_DIST): Add build-aux/vc-list-files.
160 2006-07-16 Paul Eggert <eggert@cs.ucla.edu>
162 * NEWS: chmod, install, and mkdir now leave setgid and setuid bits
163 of directories alone unless you specify them explicitly.
164 install and mkdir now implement X correctly.
165 install now creates parent directories with mode 755, without
166 changing their owner or group.
167 * src/chmod.c (process_file): Adjust to mode_adjust API change.
168 * src/install.c: Include mkancesdirs.h.
169 (announce_mkdir, make_ancestor): New functions.
170 (DEFAULT_MODE): New macro, specifying initial value of 'mode'.
172 (dir_mode, dir_mode_bits): New vars.
173 (main): Set dir modes separately from nondir, so that the X
174 op of -m works correctly.
175 (main): Remove cwd_errno cruft, since make_dir_parents no longer
176 affects cwd. Adjust to new make_dir_parents API.
177 (install_file_in_file_parents): 2nd arg is now char *, not char
178 const *. Use mkancesdirs instead of rolling our own code.
179 (change_attributes): Don't worry about AFS, since that kludge
180 should not be needed any more.
181 * src/mkdir.c (struct mkdir_options): New struct.
182 (announce_mkdir, make_ancestor): New functions.
183 (main): Use them. Adjust to mode_adjust API change. Stick with
184 umask 0. Use make_dir_parents for all the work.
185 * src/mkfifo.c (main): Adjust to new mode_adjust API.
186 * src/mknod.c (main): Likewise.
187 * tests/chmod/setgid: Do the setgid test instead of bailing.
188 * tests/mkdir/p-3: Remove re_protect case that no longer applies.
189 GNU chmod now behaves like other versions of chmod.
190 * tests/mkdir/perm: Add a test for the X bug.
192 2006-07-14 Paul Eggert <eggert@cs.ucla.edu>
194 * src/base64.c (do_decode): Output to parameter OUT, not to stdout.
195 This doesn't fix any bugs, since OUT always equals stdout, but it
196 makes the code easier to understand.
198 2006-07-14 Jim Meyering <jim@meyering.net>
200 * Makefile.maint (CVS_LIST): Use new file, build-aux/vc-list-files,
201 rather than open-coding it. Now supports mercurial, too.
202 * .hgignore: New file.
203 * Makefile.am (EXTRA_DIST): Add .hgignore, which ignores nearly
204 all generated files, including ones like configure and po/*.po
205 that are currently version-controlled in cvs.
207 * Makefile.am (EXTRA_DIST): Add a few more .??* files.
208 They've been in CVS, just haven't been distributed before this.
209 Distribute ChangeLog-2005, too.
210 (MAINTAINERCLEANFILES): Add THANKS-to-translators.
212 2006-07-11 Paul Eggert <eggert@cs.ucla.edu>
214 * src/system.h: Assume <dirent.h> exists, since gnulib assumes
217 2006-07-09 Jim Meyering <jim@meyering.net>
219 * tests/mv/dir2dir: Adjust so failing with ENOTEMPTY is ok, too.
220 That happens with Linux/tmpfs.
221 * tests/mv/Makefile.am (TESTS): Add dir2dir.
223 2006-07-09 Paul Eggert <eggert@cs.ucla.edu>
225 Adjust to recent updates from gnulib.
226 * src/dd.c (apply_translations): Use toupper rather than
227 islower followed by toupper; it's simpler and typically
228 faster now that we assume at least C89 semantics. Similarly
230 * src/sort.c (inittables): Likewise.
231 * src/expand.c (expand): Don't assume that isprint etc. return
232 booleans (needed for pre-C99 hosts).
233 * src/fmt.c (check_punctuation): Likewise.
234 * src/ptx.c (initialize_regex, fix_output_parameters): Likewise.
235 * src/tr.c (is_char_class_member): Likewise.
236 * src/unexpand.c (unexpand): Likewise.
237 * src/join.c (is_blank): Remove; no longer needed. All uses
238 replaced by isblank (to_uchar (...)).
239 * src/pinky.c (create_fullname): Don't assume char is unsigned.
240 * src/printf.c (print_esc): Likewise.
241 * src/ptx.c (SKIP_NON_WHITE, SKIP_WHITE, SKIP_WHITE_BACKWARDS):
242 (copy_unescaped_string): Likewise.
243 * src/stat.c (print_it): Likewise.
244 * src/system.h (_D_EXACT_NAMELEN): Renamed from NLENGTH, for
245 convenience on GNU systems. All uses changed. Don't bother
246 looking for any dirent.h substitute other than ndir.h.
247 (D_INO): Remove unnecessary parentheses.
248 (IN_CTYPE_DOMAIN, ISGRAPH, ISPRINT, ISALNUM, ISALPHA):
249 (ISCNTRL, ISLOWER, ISPUNCT, ISSPACE, ISUPPER, ISXDIGIT):
250 (ISDIGIT_LOCALE, TOLOWER, TOUPPER): Remove. All uses changed
251 to ctype.h equivalents.
252 (isblank): Renamed from ISBLANK. Check for HAVE_DECL_ISBLANK too.
255 2006-07-08 Jim Meyering <jim@meyering.net>
257 * tests/mv/dir2dir: New file, test for 2006-07-05 fix in copy.c.
259 * Makefile.maint (sc_the_the): New rule.
261 * src/dd.c (skip): Remove one of two adjacent "the"s in a comment.
262 * tests/Coreutils.pm (run_tests): Remove one of two adjacent "then"s
265 2006-07-07 Jim Meyering <jim@meyering.net>
267 * NEWS: Mention that mv can now remove an empty destination directory,
268 and give an example. Prompted by a report from Florent Bayle.
270 2006-07-05 Jim Meyering <jim@meyering.net>
272 * src/ls.c (usage): Correct the description of -G: it is useful
273 only in a long listing. Reported by Martin Pool in
274 <https://launchpad.net/distros/ubuntu/+source/coreutils/+bug/51653>.
276 * man/chmod.x: Correct the description of the sticky bit. Reported
277 by Chris Moore via Ian Jackson in <http://bugs.debian.org/376745>.
279 * src/copy.c (copy_internal): Don't work around old NFS clients like
280 SunOS-4.1.4 and Irix 5.3 that set errno to values like EIO and
281 ENOTEMPTY upon failed rename. Otherwise, we risk misinterpreting
282 a banal failure as a recursive move-into-self failure.
283 Reported by Florent Bayle in <http://bugs.debian.org/376749>.
285 * src/c99-to-c89.diff: Regenerate, to remove fuzz.
287 2006-07-03 Jim Meyering <jim@meyering.net>
289 Plug another unusual leak.
290 (AD_mark_helper): Free malloc'd filename if hash_insert says
291 that string is already in the hash table.
293 The dev/inode of the topmost directory in each hierarchy were not
295 * src/remove.c (remove_cwd_entries): Don't call cycle_check here.
296 (AD_push): Call it from here instead.
299 * src/remove.c (AD_stack_clear): New function.
301 (AD_pop_and_chdir): Free *prev_dir just before longjmp.
303 * tests/Makefile.am, tests/*/Makefile.am: (TESTS_ENVIRONMENT):
304 Add $VG_PATH_PREFIX as a prefix to $PATH
306 * tests/envvar-check (vars): Add CDPATH and POSIXLY_CORRECT.
307 * tests/Makefile.am (evar-check): Remove rule.
308 (EXTRA_DIST): Remove .env-warn.
309 * tests/.env-warn: Remove file. No longer used.
310 Suggestion from Eric Blake.
312 2006-07-02 Paul Eggert <eggert@cs.ucla.edu>
314 * src/system.h: Include <stdint.h> unconditionally, since we
315 now assume the stdint module.
317 2006-07-01 Paul Eggert <eggert@cs.ucla.edu>
319 * NEWS: With no operand, 'tail -f' now silently ignores the '-f'
320 only if standard input is a FIFO or pipe and POSIXLY_CORRECT is set.
321 * src/tail.c (main): Implement this.
322 * tests/tail/Test.pm (f-pipe-1): Renamed from f-1.
323 (test_vector): Set POSIXLY_CORRECT for the f-pipe-* tests.
325 2006-07-01 Jim Meyering <jim@meyering.net>
327 * src/ln.c (do_link): Use new, shorter URL, for ag-review link.
329 * .x-sc_require_config_h: Add ^lib/xstrtold\.c$, so make distcheck
332 2006-06-30 Paul Eggert <eggert@cs.ucla.edu>
334 * NEWS: seq now uses long double internally rather than double.
335 It now defaults to a minimal fixed point format if possible.
336 It lets you use %a, %A, %E, %F, %G.
337 * src/Makefile.am (seq_LDADD): Remove $(SEQ_LIBM); add $(POW_LIB).
338 * src/seq.c: Don't include <math.h> or <xstrtol.h>; no longer needed.
339 (isfinite) [!defined isfinite]: New macro.
340 (separator, terminator): Now points to const.
341 (first, step, last): Remove.
342 (usage): Update to match new behavior.
343 (struct operand, operand): New type.
344 (scan_arg): Renamed from scan_double_arg, since we no longer use double.
346 Compute and return a value of type operand, not double.
347 (long_double_format): Renamed from valid_format, and now returns a
348 new format with an "L" added if needed, if the original format was
349 valid. Allow %a, %A, %E, %F, and %G formats.
350 (print_numbers): Take numeric values as args rather than from globals.
351 Print long double, not double.
352 (get_width_format): Remove.
353 (get_default_format): New function.
354 (main): Implement new way of calculating default format.
355 Don't worry about locale's representation of the decimal point, since
356 the arguments are always processed in the C locale.
357 * tests/seq/basic (neg-2): Adjust to new default format.
358 (eq-wid-1, eq-wid-2): Resurrect these tests, since the new
359 implementation should do the right thing.
361 2006-06-30 Jim Meyering <jim@meyering.net>
363 * tests/stty/basic-1: Work around an intermittent test failure
364 on HP-UX 11.11. Report and analysis from Bob Proulx.
365 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/7475
367 2006-06-28 Paul Eggert <eggert@cs.ucla.edu>
369 * NEWS: Support obsolete usages like "sort +1 -2" even when
370 conforming to POSIX 1003.1-2001, since this is a pure extension to
371 POSIX. Problem reported by Christian in:
372 http://lists.gnu.org/archive/html/bug-coreutils/2006-06/msg00220.html
373 * src/sort.c (main): Implement this.
375 * src/system.h (CLOSEDIR): Remove. All uses changed to closedir.
376 Autoconf 2.60 says this stuff was obsolete.
378 2006-06-28 Jim Meyering <jim@meyering.net>
380 * src/c99-to-c89.diff: Regenerate, to remove fuzz.
382 2006-06-28 Bob Proulx <bob@proulx.com> (tiny change)
384 * tests/mv/i-link-no: Work around HP-UX /bin/sh tracing problem
385 (set -x when VERBOSE=yes) when stderr is redirected before stdout
386 causing shell tracing of the stdout redirection to be written to
387 the stderr file. Avoid problem and test failure on HP-UX by
388 redirecting stderr last.
389 * tests/dd/unblock-sync: Order shell file redirections for
390 stderr and stdout in the common style.
393 2006-06-27 Jim Meyering <jim@meyering.net>
395 * tests/misc/cat-proc: Try to avoid any spurious numeric
396 differences in frequently-changing /proc/cpuinfo.
397 Reported by Nelson Beebe.
399 2006-06-26 Jim Meyering <jim@meyering.net>
401 Attempt rmdir (actually, unlinkat-with-AT_REMOVEDIR) upon any
402 fd_to_subdirp failure, not just when errno == EACCES.
403 * src/remove.c (remove_dir): Use unlinkat-with-AT_REMOVEDIR, not
404 rmdir, here, even though rmdir may happen to be adequate.
406 * NEWS: rm no longer fails to remove an empty, unreadable directory
407 * src/remove.c (remove_cwd_entries): If we can't open a directory,
408 and the failure is not being ignored, try to remove the directory
409 with rmdir (aka unlinkat-with-AT_REMOVEDIR), in case it's empty.
410 Problem report and test case from Paul Eggert in
411 <http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/7425>.
413 * tests/rm/empty-inacc: New test, for the above.
415 Avoid a segfault for wc --files0=- < /dev/null.
416 * src/wc.c (compute_number_width): Return right away if nfiles == 0.
418 2006-06-25 Jim Meyering <jim@meyering.net>
420 * NEWS: wc accepts a new option --files0-from=FILE, where FILE
421 contains a list of NUL-separated file names.
423 * src/wc.c: Include "readtokens.h".
424 (usage): Describe the new option, and adjust the `Usage':
425 with this option, no FILE may be specified on the command line.
426 (main): Handle the new option.
427 * tests/misc/wc-files0: New tests, for the above.
428 * tests/misc/wc-files0-from: Likewise.
429 * tests/misc/Makefile.am (TESTS): Add wc-files0.
431 2006-06-24 Jim Meyering <jim@meyering.net>
433 * src/md5sum.c (DIGEST_BUFFER): Remove now-unused definitions.
435 2006-06-22 Jim Meyering <jim@meyering.net>
437 * src/tee.c (tee_files): Rename from tee, to avoid conflict with
438 the function in glibc's <fcntl.h>. Reported by Andreas Schwab.
440 2006-06-19 Jim Meyering <jim@meyering.net>
442 * Makefile.cfg (local-checks-to-skip): Add changelog-check,
443 so this check is not run as part of "make distcheck".
445 2006-06-18 Bob Proulx <bob@proulx.com> (tiny change)
447 * tests/misc/pwd-long: Fix typo (s/neq/ne/) in previous change.
449 2006-06-18 Jim Meyering <jim@meyering.net>
451 * tests/misc/pwd-long: Make error output a little clearer.
453 2006-06-17 Jim Meyering <jim@meyering.net>
455 * tests/rm/inaccessible: Skip this test on systems without openat
456 support. Reported by Bob Proulx.
458 2006-06-15 Bob Proulx <bob@proulx.com> (tiny change)
460 * tests/misc/mknod: Improve permission checks to handle
461 running mkdir test in set-gid directories.
463 2006-06-14 Jim Meyering <jim@meyering.net>
465 * tests/du/basic: Revamp not to hard-code file system block sizes.
467 2006-06-12 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
469 * tests/du/Makefile.am (TESTS_ENVIRONMENT): Pass $(PERL), for
472 2006-06-11 Jim Meyering <jim@meyering.net>
474 * .gitignore: New file.
475 * Makefile.am (EXTRA_DIST): Add .gitignore.
477 Setting TIME_STYLE=long-iso in the environment would make the
478 cp/same-file test fail.
479 * tests/envvar-check (vars): Add TIME_STYLE to the list.
480 * tests/cp/same-file: Revert last change.
481 Source the envvar-check script, to ensure that TIME_STYLE
482 settings don't affect these tests.
484 2006-06-11 Paul Eggert <eggert@cs.ucla.edu>
486 * tests/cp/same-file: Execute 'ls' in the C locale, so that it
487 uses POSIX time stamp formats. Problem reported by John Nixon in
488 <http://lists.gnu.org/archive/html/bug-coreutils/2006-06/msg00062.html>.
490 2006-06-10 Jim Meyering <jim@meyering.net>
492 * NEWS: Mention the AIX-strndup-bug vs. dircolors workaround.
494 Require a "Version N.M" line at the top of the ChangeLog
495 file only when making the actual release, not when running
497 * Makefile.maint (maintainer-distcheck): Don't depend on
499 (alpha beta major): Depend on it here, instead.
501 2006-06-08 Jim Meyering <jim@meyering.net>
503 Ensure that cat works with any of the options, -A -v -e -E -T,
504 when applied to files in /proc and /sys, even when the FIONREAD
505 ioctl produces nonsensical results. Before this change, cat would
506 produce no output (or truncated output), for some linux kernels.
508 * src/cat.c (write_pending): New function, factored out of cat.
509 (cat): Also interpret a negative ioctl/FIONREAD count as indicating
510 that there are bytes to read. Some versions of linux-2.6.16 do that.
511 Write any pending output before returning.
512 Reported by Dan Jacobson in <http://bugs.debian.org/370583>.
513 * NEWS: Mention this bug fix.
514 * tests/misc/cat-proc: New file. Test for the above.
515 * tests/misc/Makefile.am (TESTS): Add cat-proc.
517 2006-06-07 Paul Eggert <eggert@cs.ucla.edu>
519 * src/expr.c (eval4): Detect overflow properly when multiplying
522 2006-06-06 Paul Eggert <eggert@cs.ucla.edu>
524 * NEWS: The 'expr' command now detects and reports integer overflow.
525 (It would be better to use extended precision instead, but that
527 * src/expr.c (integer_overflow): New function.
528 (eval4, eval3): Check for integer overflow.
530 2006-06-05 Paul Eggert <eggert@cs.ucla.edu>
532 Fix problems when building with Solaris/SVR4/etc. make, which uses a
533 different and somewhat bogus implementation of VPATH. In the
534 directory tests/misc, rename tests whose names might appear in the
535 Automake-generated rules. For example, we can't use a test named
536 'test', since Automake generates a rule that contains the text
537 "if test -f ./$$tst; ...", and this might expand to something like
538 "if ../../../coreutils-6.0/tests/misc/test -f ./$$test; ...",
539 which executes the 'test' script rather than the 'test' command.
540 * tests/misc/false-status: Renamed from tests/misc/false.
541 * tests/misc/pwd-long: Renamed from tests/misc/pwd.
542 * tests/misc/sort-merge: Renamed from tests/misc/sort.
543 ($prog): Set to 'sort' rather than to $PROG.
544 * tests/misc/test-diag: Renamed from tests/misc/test.
545 * tests/misc/Makefile.am (PROG): Take the basename of $$tst,
546 in case Solaris make has prepended the directory.
547 (TESTS): Adjust to above renamings.
548 * tests/misc/expand: Don't assign to PROG; no longer needed
549 now that Makefile.am sets PROG to the basename.
550 * tests/misc/fold: Likewise.
552 2006-06-03 Jim Meyering <jim@meyering.net>
554 Make `cp --link --no-dereference' work also on systems where the
555 link system call cannot create a hard link to a symbolic link.
556 * src/copy.c (copy_internal) [LINK_FOLLOWS_SYMLINKS]: Don't use
557 the link syscall on a symlink when it would do the wrong thing.
558 Based on the patch by Aurelien Jarno: <http://bugs.debian.org/329451>
559 * tests/cp/link-no-deref: New file/test for the above.
560 * tests/cp/Makefile.am (TESTS): Add link-no-deref.
561 * NEWS: Mention the change (doesn't affect Linux).
563 2006-06-01 Paul Eggert <eggert@cs.ucla.edu>
565 Fix some porting problems in the test cases reported by
566 Ralf Wildenhues for HP-UX 11.23 in:
567 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00238.html
568 * tests/help-version: Don't assume that \< \> works in sed.
569 * tests/misc/close-stdout: Don't assume that >&- works.
570 Add a /dev/full test.
571 * tests/touch/no-create-missing: Don't assume that >&- works.
573 2006-05-30 Jim Meyering <jim@meyering.net>
575 * src/ls.c (usage): Add `v' to the list of sorting-related options.
578 2006-05-28 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
580 * tests/cp/fail-perm: source lang-default.
581 * tests/rm/inaccessible: Likewise.
583 2006-05-28 Jim Meyering <jim@meyering.net>
585 * tests/rm/inaccessible: AIX 4.3.3 gives a different diagnostic.
586 Recognize it, too. Reported by Ralf Wildenhues, in
587 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
589 2006-05-27 Jim Meyering <jim@meyering.net>
591 * src/chgrp.c: Support new options: --preserve-root and
592 --no-preserve-root. Somehow this program was skipped when those
593 options were added to chown, chmod, and rm. Reported by
594 vaqflabuopac@spammotel.com in <http://bugs.debian.org/365656>.
595 * NEWS: Mention this.
597 2006-05-25 Paul Eggert <eggert@cs.ucla.edu>
599 * NEWS: Remove mention of --seed. We'll replace it with something
600 better, and don't want to indicate that it is supported.
601 * src/sort.c (usage): Likewise.
603 2006-05-20 Jim Meyering <jim@meyering.net>
605 * src/chmod.c (main): Use FTS_PHYSICAL here, too.
607 * src/du.c (main): Rename local, s/symlink_deref_bit/symlink_deref_bits/
608 and arrange for -D to set fts' FTS_PHYSICAL bit as well as
609 FTS_COMFOLLOW. Spotted by Justin Pryzby.
611 * gnupload: Merge changes from automake, retaining the ""--to...
612 kludge to placate overzealous `make distcheck' check.
614 2006-05-19 Jim Meyering <jim@meyering.net>
616 * src/du.c (main): Don't let -D, -L, or -P turn off the internal
617 FTS_TIGHT_CYCLE_CHECK directory traversal option.
618 Reported by Justin Pryzby in http://bugs.debian.org/367691
620 2006-05-15 Jim Meyering <jim@meyering.net>
622 * src/cp.c (usage): Correct description of -a: s/-dpR/-dpPR/.
625 2006-05-13 Jim Meyering <jim@meyering.net>
627 * tests/mv/no-target-dir: Test two more cases.
629 2006-05-11 Jim Meyering <jim@meyering.net>
631 mv -T DIR EMPTY_DIR no longer fails unconditionally
632 * src/copy.c (copy_internal): Don't manually prohibit a move where
633 the destination is an existing directory. Sometimes doing that is
634 valid. Let the rename system call enforce the rules. That is
635 allowed only when the source is a directory and the destination
636 directory (to be replaced) is empty. Reported by Eric Blake.
637 * tests/mv/no-target-dir: New file/test for this.
638 * tests/mv/Makefile.am (TESTS): Add no-target-dir.
639 * NEWS: Mention this.
641 * tests/mv/atomic: New file/test for yesterday's fix.
642 * tests/mv/Makefile.am (TESTS): Add atomic.
644 * tests/du/long-sloop: Avoid harmless `ambiguous redirect' diagnostic.
646 2006-05-10 Jim Meyering <jim@meyering.net>
648 * src/copy.c (copy_internal): Don't explicitly unlink the destination
649 when moving a symlink into the place of an existing non-directory.
650 Reported by Joshua Hudson.
651 * NEWS: mention this.
653 2006-05-07 Jim Meyering <jim@meyering.net>
655 * Makefile.maint (patch-check): Fail if patch generates any output,
656 even merely for changed offsets.
658 * src/c99-to-c89.diff: Adjust to reflect new offsets.
660 * NEWS: Mention changes affecting df, pwd, shred.
662 2006-05-06 Jim Meyering <jim@meyering.net>
664 * tests/ls/stat-vs-dirent: New test, to detect the bogus file
665 system condition where dirent.d_ino != stat.st_ino.
666 * tests/ls/Makefile.am (TESTS): Add stat-vs-dirent.
668 2006-05-06 Eric Blake <ebb9@byu.net>
670 * tests/ls/inode: Expand to test inode from readdir case.
671 * tests/ls/follow-slink: Expand to test broken links encountered
672 implicitly, favoring Solaris 9 and OpenBSD 3.4 behavior.
674 2006-05-06 Eric Blake <ebb9@byu.net>
676 * tests/mv/leak-fd: Work even on case-insensitive file system.
678 2006-05-04 Jim Meyering <jim@meyering.net>
680 * NEWS: Mention the 2006-03-19 pwd-related change that makes
681 lib/getcwd.c work around inconsistent file system dirent.d_ino data.
683 2006-05-03 Jim Meyering <jim@meyering.net>
685 * src/ls.c (DEFINE_SORT_FUNCTIONS, LIST_SORTFUNCTION_VARIANTS):
686 Use better macro parameter names: s/basename/key_name/,
687 s/basefunc/key_cmp_func. Fix typo in comment.
689 2006-04-29 Eric Blake <ebb9@byu.net>
691 * src/ls.c (main): On systems with d_type, directories_first only
692 implies format_needs_type, not format_needs_stat.
694 2006-05-03 Jim Meyering <jim@meyering.net>
696 * src/ls.c (xstrcoll_df_version, rev_xstrcoll_df_version): Add space
697 after comma in arg list, from Eric Blake.
699 2006-04-25 Paul Eggert <eggert@cs.ucla.edu>
701 * tests/misc/date (relative-3): New test, derived from a bug
702 report by John Thomas McDole.
704 2006-04-23 Francesco Montorsi <fr_m@hotmail.com>
706 New option for ls: --group-directories-first.
707 It makes ls list directories before files.
708 * NEWS [New features]: Mention it.
709 * src/ls.c (sort_type): Rearrange to use as an array index when
710 choosing sort function; added new sort_numtypes member for
712 (time_type): Add new time_numtypes member for compile-time check.
713 (directories_first): New global variable.
714 (GROUP_DIRECTORIES_FIRST_OPTION): New enum.
715 (long_options): Add --directories-first.
716 (main): Support new option.
717 (is_directory): New function.
718 (extract_dirs_from_files): Use it.
719 (DIRFIRST_CHECK, DEFINE_SORT_FUNCTIONS)
720 (LIST_SORTFUNCTION_VARIANTS): New macros.
721 (sort_functions): New global variable.
722 (sort_files): Use it.
723 (usage): Document new option.
725 2006-04-18 Paul Eggert <eggert@cs.ucla.edu>
727 * src/shred.c (fillrand): The assertion was way too weak, due to
728 what must be a typo. Strengthen it to its intended value.
729 (dopass): Don't use alloca; it's not worth the aggravation here,
730 since it's used only to get a page-aligned buffer, and page
731 alignment doesn't buy us much here. I'm suspicious that alloca
732 causes problems on some hosts, due to a recent bug report by Adam
733 Waltman: http://bugs.gentoo.org/130246.
735 2006-04-18 Jim Meyering <jim@meyering.net>
737 * tests/misc/tty-eof: Add new programs, base64, sha224sum, sha256sum,
738 sha384sum, sha512sum.
740 2006-04-17 Paul Eggert <eggert@cs.ucla.edu>
742 * src/chmod.c (describe_change): Adjust to filemode changes.
743 * src/ls.c (HAVE_ST_DM_MODE): Remove; moved to ../lib/filemode.c.
744 (print_long_format): Use (new) filemodestring rather than
745 (old) mode_string, so that we get more file types right, at least
746 in theory. Adjust to filemode changes.
747 * src/stat.c (human_access): Likewise.
749 2006-04-18 Jim Meyering <jim@meyering.net>
751 * src/ptx.c (main) [DEFAULT_IGNORE_FILE]: Remove code to use a default
752 ignore file. This has never been enabled. Reported by Eric Blake.
754 2006-04-12 Paul Eggert <eggert@cs.ucla.edu>
756 * src/ln.c (linkfunc): Remove. This method ran into a compiler/linker
757 bug in Interix. Just call symlink or link directly. All uses changed.
758 * src/setuidgid.c (main) [! HAVE_SETGROUPS]: Don't call setgroups.
759 * src/stat.c (USE_STATVFS): New macro.
760 Include <sys/statvfs.h> and use statvfs only if USE_STATVFS.
761 (NAMEMAX_FORMAT): define a bit more clearly, now that the
762 statvfs-using code is a bit more regular.
763 * src/system.h (sync) [!HAVE_SYNC]: New macro.
765 2006-04-11 Paul Eggert <eggert@cs.ucla.edu>
767 * NEWS: csplit, nl, expr now conform to POSIX better, and are
768 more-compatible with traditional Unix, with respect to regular
770 * src/csplit.c (extract_regexp): Set re_syntax_options to a
771 value that is compatible with what POSIX requires.
772 * src/nl.c (build_type_arg): Likewise.
773 * src/expr.c (docolon): Likewise. Also, don't let anchors match
774 newline; this fixes an incompatibility with tradition and with POSIX.
775 Don't warn about leading ^. POSIX says it is unspecified whether
776 ^ is a special character, which means that implementations can
777 either treat it as special or not, but either way a warning is not
778 allowed (unless the regexp is otherwise invalid). Instead, anchor
779 the expression but treat ^ as an anchor; this is the traditional
780 behavior (e.g., Solaris 10).
781 (eval4, eval3, eval2): Treat non-numeric args, division by zero,
782 and the like as invalid expressions (exit status 2), not as
783 failure of 'expr' (exit status 3). This is more consistent with
785 * tests/expr/basic (fail-a): Adjust exit status to match new expr
786 behavior, for status 2 versus 3.
788 (bre1, bre2, bre3, bre4, bre5, bre6, bre7, bre8, bre9, bre10):
789 (bre11, bre12, bre13, bre14, bre15, bre16, bre17, bre18, bre19, bre20):
790 (bre21, bre22, bre23, bre24, bre25, bre26, bre27, bre28, bre29, bre30):
791 (bre31, bre32, bre33, bre34, bre35, bre36, bre37, bre38, bre39, bre40):
792 (bre41, bre42, bre43, bre44, bre45, bre46, bre47, bre48, bre49, bre50):
793 (bre51, bre52, bre53, bre54, bre55, bre56, bre57, bre58, bre59, bre60):
794 (bre61, bre62): New tests.
795 * tests/misc/csplit: Use \{...\} in test RE, to test that we're
799 * tests/du/long-from-unreachable: Solaris 8 sh doesn't understand
800 "if !". Do not assume that 'sed' can handle long, newline-free input.
801 * tests/du/long-sloop: Likewise. Evaluate expr once, not $n times.
803 2006-04-10 Paul Eggert <eggert@cs.ucla.edu>
805 Adjust to new regex.h API (with new fastmap type), and clean
806 up the regex storage allocation a bit.
808 * src/csplit.c (struct control): Put re_compiled member at the
809 end, since it's large. Change regexpr member from char * to bool;
810 all uses changed. Add new member fastmap.
811 (extract_regexp): regexp arg is now char const *, not char *.
812 Don't bother duplicating the regular expression; it's not needed.
813 Set fastmap from new fastmap member. Don't bother allocating
814 a buffer, as the regexp code does a better job than we do.
815 * src/expr.c (docolon): Allocate and use a fastmap.
816 Don't bother allocating a buffer.
817 * src/nl.c (body_fastmap, header_fastmap, footer_fastmap):
819 (build_type_arg): New fastmap arg. All uses changed.
820 Don't bother allocating a buffer, but set a fastmap.
821 * src/ptx.c (context_regex_string, word_regex_string): Remove.
822 (context_regex, word_regex): New vars, replacing the above.
824 (struct regex_data): New type.
825 (compile_regex): Renamed from alloc_and_compile_regex, since
826 we no longer allocate storage. Arg is now a struct regex_data *,
827 not a const char *. All uses changed. Don't allocate the fastmap;
828 instead, take it from the caller. Don't convert size_t to int,
829 to avoid arithmetic overflow problems. Don't bother freeing
830 storage afterwards; it's not worth the aggravation.
831 * src/tac.c (compiled_separator_fastmap): New ver.
832 (main): Use it. Don't bother allocating a buffer.
834 2006-03-30 Jim Meyering <jim@meyering.net>
836 * src/dd.c (iwrite): Remove assignment without effect.
837 Reported by Felix Rauch Valenti.
839 2006-03-22 Eric Blake <ebb9@byu.net>
841 * src/ptx.c (usage): Remove mention of --copyright/-C.
842 (main): Alias --copyright to --version plus a deprecation warning.
843 * NEWS: Mention this.
845 2006-03-27 Jim Meyering <jim@meyering.net>
847 * src/Makefile.am (uptime_LDADD): Add $(POW_LIB), for uptime's
848 use of strtod. Tiny patch from Nickolai Zeldovich.
850 2006-03-11 Eric Blake <ebb9@byu.net>
852 * tests/misc/dirname: New file.
853 * tests/basename/Makefile.am: Delete.
854 * tests/basename/basic: Move to...
855 * tests/misc/basename: ... this new file. Add some tests,
856 including fixed behavior for //.
857 * tests/misc/Makefile.am (TESTS): Sort. Add basename, dirname.
858 * tests/Makefile.am (SUBDIRS): Remove basename.
859 * configure.ac (AC_CONFIG_FILES): Remove tests/basename.
861 Improvements to dirname/basename handling on platforms like
862 cygwin with distinct // and with drive letters.
863 * NEWS: Document new behavior.
864 * src/basename.c (main): Don't strip suffix from file system
866 * src/cp.c (target_directory_operand): Use new last_component.
867 (ASSIGN_BASENAME_STRDUPA): Likewise. Reduce time spent
868 traversing the string.
869 * src/dircolors.c (guess_shell_syntax): Use new last_component.
870 * src/install.c (target_directory_operand, install_file_in_dir):
872 * src/ln.c (target_directory_operand, main): Likewise.
873 * src/ls.c (basename_is_dot_or_dotdot): Likewise.
874 * src/mv.c (target_directory_operand, movefile): Likewise.
875 * src/remove.c (rm_1): Likewise.
876 * src/shred.c (wipename): Likewise.
877 * src/split.c (next_file_name): Likewise.
878 * src/su.c (log_su, run_shell): Likewise.
880 2006-03-23 Paul Eggert <eggert@cs.ucla.edu>
882 * NEWS: nohup diagnostics are now more precise, and nohup now
883 redirects stderr to nohup.out if stdout is closed and stderr is a tty.
884 * src/nohup.c (main): Implement this.
885 * tests/misc/nohup: Test the new behavior.
887 2006-03-12 Jim Meyering <jim@meyering.net>
889 * src/copy.c (set_author): Rename function, from preserve_author.
891 * src/remove.c (AD_pop_and_chdir): Use new macro,
892 CYCLE_CHECK_REFLECT_CHDIR_UP, rather than open-coding it.
894 * src/system.h (SAME_INODE): Remove definition.
895 Include "same-inode.h", instead.
897 2006-03-11 Eric Blake <ebb9@byu.net>
899 * src/pwd.c (robust_getcwd): Prepend only one slash, not two.
901 2006-03-10 Jim Meyering <jim@meyering.net>
903 Fix a bug whereby a user with write access to a directory being removed
904 could cause the removal of that directory to fail with an erroneous
905 diagnostic about a directory cycle. Reported by Vineet Chadha.
907 * NEWS: Mention this.
908 * src/remove.c (AD_pop_and_chdir): If the directory we're about to
909 leave (and try to rmdir) is the one whose dev_ino is being used to
910 detect a cycle, reset cycle_check_state.dev_ino to that of the parent.
912 2006-03-08 Paul Eggert <eggert@cs.ucla.edu>
914 * NEWS: Document dd's new 'directory' and 'nolinks' flags.
915 * src/dd.c (set_fd_flags): Handle file-creation flags on file
916 descriptors, rather than ignoring them.
917 * tests/dd/misc: Add test cases for append, nofollow, directory,
918 and nolinks flags. Simplify redirection to /dev/null in some cases.
920 * tests/dd/misc: iflags->iflag. This fixes a typo that meant the
921 noatime test never tested anything.
923 2006-03-05 Paul Eggert <eggert@cs.ucla.edu>
925 * src/dd.c (flags, usage): New flags directory, nolinks.
926 * src/system.h (O_NOLINKS): Define to 0 if not already defined.
928 * src/ls.c (usage): Mention that -f disables --color.
929 Problem reported by Niels Möller.
931 2006-03-03 Justin Pryzby <pryzbyj@justinpryzby.com>
933 * man/*.x: Add references to syscalls from utilities of the same name.
935 2006-03-05 Jim Meyering <jim@meyering.net>
937 * tests/help-version: Set SHELL, if not already set, in order to
938 avoid failure when `make check' is run through debuild; dircolors
939 would fail due to lack of $SHELL. Reported by Sven Joachim.
941 Make `base64 --wrap=N' work for N=0, and for N larger than SIZE_MAX.
942 * src/base64.c (wrap_write, do_encode, main): Change type of
943 parameters and locals, wrap_column, form size_t to uintmax_t.
944 (main): Adjust to use xstrtoumax, accordingly.
946 2006-03-03 Jim Meyering <jim@meyering.net>
948 Don't fail when run from an environment with SHELL not a Bourne
949 shell, e.g. `env SHELL=/bin/csh make check' would fail this test.
950 * tests/dircolors/simple: Invoke each non-failing test with -b.
951 Reported by Michael Stone.
953 2006-02-27 Jim Meyering <jim@meyering.net>
955 * tests/misc/base64: Derive --decode-using tests from the
958 * tests/misc/base64: Factor out a long constant string.
959 Split lines to stay within 80 columns.
961 * tests/misc/Makefile.am (TESTS): Add base64.
962 * tests/misc/base64: Test base64. From Simon Josefsson.
964 * src/base64.c (do_decode): Use correct type for parameter,
965 ignore_garbage: s/size_t/bool/.
967 * src/base64.c: Don't include .h files already included by system.h:
968 <string.h>, <stdlib.h>, <stdbool.h>, <limits.h>, <errno.h>.
969 Include "system.h" before the other lib/*.h header files.
970 Include <sys/types.h> before "system.h".
971 (wrap_write): Remove declaration of unused local, initial_column.
972 (wrap_write): Correct declaration syntax: s/size_t * V/size_t *V/.
974 * README: Add base64 to the list.
976 2006-02-17 Simon Josefsson <jas@extundo.com>
979 * AUTHORS: Mention base64.
981 * man/Makefile.am: Build base64.1.
982 * man/base64.x: New file.
983 * src/Makefile.am (bin_PROGRAMS): Add base64.
984 * src/base64.c: New file.
986 2006-02-25 Eric Blake <ebb9@byu.net>
988 In ls, avoid calling stat for --inode (-i), when possible.
989 * src/pwd.c (NOT_AN_INODE_NUMBER, D_INO): Move to ...
990 * src/system.h: ... here, for use in ...
991 * src/ls.c (main): ... here. Prefer dirent.d_ino to stat when
993 (gobble_file): Add inode argument.
994 (print_dir): Pass inode if available.
995 (usage): Remove inaccuracy.
997 2006-02-23 Jim Meyering <jim@meyering.net>
999 * TODO: Update/correct some obsolete entries.
1001 2006-02-20 Paul Eggert <eggert@cs.ucla.edu>
1003 * doc/coreutils.texi (join invocation): Mention `sort -k 1b,1'.
1004 * src/join.c (usage): Likewise.
1005 Documentation problem reported by Philip Kensche.
1007 2006-02-20 Eric Blake <ebb9@byu.net>
1009 * man/rm.x: Update documentation to match previous patch.
1011 2006-02-18 Eric Blake <ebb9@byu.net>
1013 New option for rm: --interactive=once (-I).
1014 * NEWS: Document it, along with change to rm --interactive.
1015 * TODO: Remove entry for implementing rm -I
1016 * src/rm.c (INTERACTIVE_OPTION): New enum value.
1017 (interactive_type): New enum.
1018 (long_opts): Let interactive take an optional argument.
1019 (interactive_args, interactive_types): New option arguments.
1020 (usage): Document -I, --interactive=WHEN. Use program_name
1021 instead of a basename.
1022 (main): New -I option, new behavior to --interactive.
1023 * tests/rm/interactive-once: New tests.
1024 * tests/rm/interactive-always: Ditto.
1025 * tests/rm/Makefile.am (TESTS): Run them.
1027 2006-02-18 Jim Meyering <jim@meyering.net>
1029 * Makefile.maint (sc_two_space_separator_in_usage): Make the regular
1030 expression match more of the target lines, e.g., those that start with
1031 `-S,' (short option followed by a comma) or that include `=[...]'.
1032 Patch by Nicolas François.
1033 Fix the four offenders thus exposed:
1034 * src/join.c (usage): Use two spaces (not one) to separate the
1035 --first-only option string from its description, so help2man formats
1036 the derived man page properly.
1037 * src/pr.c (usage): Likewise.
1038 * src/uniq.c (usage): Likewise.
1039 * src/install.c (usage): Likewise.
1041 2006-02-15 Jim Meyering <jim@meyering.net>
1043 * Makefile.maint (alpha beta major): For `make major', ensure that the
1044 version string is of the form N.N[.N]*, where N is one or more digits.
1046 2006-02-14 Jim Meyering <jim@meyering.net>
1048 * INSTALL: Update from gnulib.
1050 2006-02-13 Jim Meyering <jim@meyering.net>
1052 * GNUmakefile (all): Emit diagnostics to stderr, not stdout.
1054 2006-02-12 Jim Meyering <jim@meyering.net>
1056 * Makefile.maint (patch-check): New target.
1057 (local-checks-available): Add to the list.
1059 2006-02-11 Jim Meyering <jim@meyering.net>
1061 * src/c99-to-c89.diff: New file.
1062 * src/Makefile.am (EXTRA_DIST): Add c99-to-c89.diff.
1064 * .x-po-check: New file, with exclusions so that `make distcheck'
1066 * Makefile.am (EXTRA_DIST): Add .x-po-check.
1068 rm -r must remove an empty directory, even if it is inaccessible.
1069 * src/remove.c (close_preserve_errno): New function.
1070 (fd_to_subdirp): Don't print a diagnostic in this function.
1071 Do it from the callers instead, unless rmdir succeeds.
1072 (remove_cwd_entries, remove_dir): Adjust callers.
1073 * tests/rm/empty-inacc: New test for the above.
1074 * tests/rm/Makefile.am (TESTS): Add empty-inacc.
1075 * NEWS: Mention this bug fix.
1076 * tests/rm/rm2: Adjust two expected diagnostics, now that they're
1077 a tiny bit less precise: cannot remove `a/1': ... instead of
1078 cannot open directory `a/1': ...
1080 * Makefile.maint (syntax-check-rules): Automatically derive this
1081 list of sc_-prefixed rule names.
1083 2006-02-10 Paul Eggert <eggert@cs.ucla.edu>
1085 * Makefile.maint (CVS_LIST): Don't assume cvsu is available.
1086 (CVS_LIST_EXCEPT): New macro, to simplify exception-processing.
1087 Most uses of CVS_LIST changed to use CVS_LIST_EXCEPT.
1088 (syntax-check-rules): Bring back sc_changelong. (Hmm, why did it
1089 go away? was that an accident?)
1090 (sc_cast_of_argument_to_free, sc_cast_of_x_alloc_return_value):
1091 (sc_cast_of_alloca_return_value, sc_space_tab, sc_prohibit_atoi_atof):
1092 (sc_error_exit_success, sc_file_system, sc_no_if_have_config_h):
1093 (sc_system_h_headers, sc_sun_os_names, sc_trailing_blank):
1094 (sc_two_space_separator_in_usage, sc_unmarked_diagnostics):
1095 (sc_obsolete_symbols, sc_changelog, sc_prohibit_jm_in_m4):
1096 (sc_useless_cpp_parens, makefile-check, m4-check, po-check):
1097 (author_mark_check, makefile_path_separator_check):
1098 Output line numbers, to simplify navigation of Emacs *compilation*
1100 (sc_prohibit_atoi_atof, sc_file_system):
1101 Rework slightly so that Makefile.maint doesn't get reported as a
1102 violation of its own syntax rules.
1103 (sc_dd_max_sym_length): Use ifneq to do nothing, instead of doing
1104 it at run-time (which didn't work with Bison). Fix a makefile typo,
1105 caught by Makefile.maint itself: spaces where a tab should be.
1106 (po-check): Check lib/*.[ch] even if not in CVS; used by Bison,
1107 which copies from ../gnulib/lib/*.[ch] to lib/*.[ch].
1108 Ignore djgpp and man subdirectories, to avoid false matches with
1109 Bison and coreutils, respectively. Use sort -u to remove the
1110 resulting duplicates.
1111 * gnupload: Rework slightly to avoid bogus warning from
1112 sc_two_space_separator_in_usage.
1114 2006-02-10 Jim Meyering <jim@meyering.net>
1116 Use gzip's --rsyncable option only if it's available.
1117 * Makefile.maint (gzip_rsyncable): New variable.
1120 2006-02-08 Jim Meyering <jim@meyering.net>
1122 * Makefile.maint (local-checks-available): Define in terms of
1123 the expansion, $(syntax-check-rules), rather than the single,
1124 top-level target `syntax-check', so that it's easier to exclude
1125 individual rules (via $(local-checks-to-skip)).
1126 (tgz-md5, tgz-sha1, ...): Remove now-unused definitions.
1128 2006-02-07 Jim Meyering <jim@meyering.net>
1130 * src/system.h (!defined O_DIRECT): If O_DIRECTIO is defined (as it
1131 is on Tru64), define O_DIRECT to that. Patch From James Lemley.
1133 * tests/help-version (expected_failure_status_vdir):
1134 Redirect an expected disk-full diagnostic to /dev/null.
1136 2006-02-06 Jim Meyering <jim@meyering.net>
1138 * src/unexpand.c (usage): Use two spaces (not one) to separate the
1139 --first-only option string from its description, so help2man formats
1140 the derived man page properly.
1141 * src/rm.c (usage): Likewise for --no-preserve-root.
1142 * src/chown.c (usage): Likewise.
1143 * src/chgrp.c (usage): Likewise.
1145 Add a rule to ensure that the above doesn't happen again.
1146 * Makefile.maint (sc_two_space_separator_in_usage): New rule.
1147 (syntax-check-rules): Add it.
1148 * .x-sc_two_space_separator_in_usage: New empty file.
1149 * Makefile.am (EXTRA_DIST): Add .x-sc_two_space_separator_in_usage.
1151 2006-02-06 Jim Meyering <jim@meyering.net>
1153 * src/cp.c (usage): Use two spaces (not one) to separate each
1154 option string from its description, so help2man formats the
1155 derived man page properly.
1156 * src/mv.c (usage): Likewise.
1157 Patch from Nicolas François in http://bugs.debian.org/351601.
1159 2006-02-04 Jim Meyering <jim@meyering.net>
1161 * src/copy.c (copy_internal): cp -RL would fail when encountering
1162 the same directory more than once in the hierarchy beneath a single
1163 command-line argument. That is legitimate, e.g. when there are
1164 two or more symbolic links, each pointing to some directory that
1165 would not otherwise be copied. Reported by Christophe LYON.
1166 * tests/cp/cp-deref: New file. Test for today's fix.
1167 * tests/cp/Makefile.am (TESTS): Add cp-deref.
1168 * NEWS: Document this.
1170 2006-02-03 Jim Meyering <jim@meyering.net>
1172 * configure.ac: Require automake-1.9.6, not 1.8.3.
1174 2006-02-01 Paul Eggert <eggert@cs.ucla.edu>
1176 * src/od.c (usage): Mention that -t a ignores high order bit.
1177 Documentation problem reported by Ed Avis.
1179 2006-02-01 Jim Meyering <jim@meyering.net>
1181 * src/pwd.c (find_dir_entry): Remove unused local, `ent_sb_valid'.
1183 2006-01-30 Paul Eggert <eggert@cs.ucla.edu>
1185 * src/head.c (main): Use a better diagnostic when someone uses a
1186 trailing numeric option in an invalid way. Problem reported by
1188 * src/tail.c (parse_options): Likewise.
1190 2006-01-30 Jim Meyering <jim@meyering.net>
1192 * man/wc.x: Include `count' keyword in man page synopsis,
1193 per suggestion from http://bugs.debian.org/181585.
1195 2006-01-24 Paul Eggert <eggert@cs.ucla.edu>
1197 * src/df.c (show_dev): If the file system claims to have
1198 more available than total blocks, report the number of used
1199 blocks as being total - available (a negative number) rather
1200 than as garbage. Problem reported by Toralf Foerster.
1202 2006-01-24 Jim Meyering <jim@meyering.net>
1204 * src/tail.c (tail_forever): Don't exit-nonzero when an attempt
1205 to put a regular file in O_NONBLOCK mode fails with EPERM.
1206 That happens on Linux (up to 2.6.15) when using tail -f on a file with
1207 the append-only attribute. Reported by Dean Gaudet. For details,
1208 see http://savannah.gnu.org/bugs/?func=detailitem&item_id=15473.
1209 * NEWS: Mention this fix.
1210 * tests/tail-2/append-only: New file. Test for the above.
1211 * tests/tail-2/Makefile.am (TESTS): Add append-only.
1212 * tests/Makefile.am (check-root): Add tail-2/append-only
1214 2006-01-21 Jim Meyering <jim@meyering.net>
1216 * NEWS: Mention fts-related improvements and bug fixes.
1218 2006-01-19 Jim Meyering <jim@meyering.net>
1220 * tests/fmt/basic (pfx-1, pfx-2): New tests, to demonstrate the bug
1221 reported as http://bugs.debian.org/147577. Forwarded by Thomas Hood.
1223 2006-01-18 Jim Meyering <jim@meyering.net>
1225 * tests/du/Makefile.am (TESTS): Add long-from-unreadable.
1227 2006-01-17 Jim Meyering <jim@meyering.net>
1229 Now that fts no longer changes the current working directory, adjust
1230 its clients accordingly -- note that du.c uses fts but doesn't need
1231 any adjustment, since it doesn't operate on the actual files,
1232 but rather just uses the stat buffers provided by fts.
1234 * src/chown-core.c: Include "openat.h".
1235 Don't include "lchown.h".
1236 (restricted_chown): Accept a new parameter, CWD_FD, and use it in
1237 calling openat, lchownat, chownat, rather than open, lchown, chown.
1239 * src/chmod.c: Include "openat.h".
1240 (process_file): Use chmodat (fts->fts_cwd_fd,... in place of chmod (...
1242 * tests/du/long-from-unreadable: New test, to exercise one small
1245 2006-01-13 Jim Meyering <jim@meyering.net>
1247 * tests/Makefile.am (SUBDIRS): Add comments discouraging the
1248 addition of new directories under tests/.
1250 * tests/acl: Redirect stdin to /dev/null. Otherwise, FreeBSD 5.0's
1253 2006-01-12 Jim Meyering <jim@meyering.net>
1255 * tests/du/long-sloop: Adjust not to hard-code the expected
1256 diagnostic corresponding to ELOOP. Solaris' diagnostic differs
1257 from that of GNU libc. Reported by Paul Eggert.
1259 * tests/du/long-sloop: Create file at end of symlink chain.
1261 * tests/misc/test: New file, with a test for one of the
1262 bugs fixed by yesterday's test.c changes.
1263 * tests/misc/Makefile.am (TESTS): Add test.
1265 2006-01-11 Jim Meyering <jim@meyering.net>
1267 * tests/du/long-sloop: New file. Test for today's fts.c bug fix.
1268 That bug could make du -L, chgrp -L, or chown -L fail to diagnose
1269 a very long sequence of symbolic links (not necessarily a loop).
1270 * tests/du/Makefile.am (TESTS): Add long-sloop.
1272 2006-01-11 Paul Eggert <eggert@cs.ucla.edu>
1274 * src/test.c (test_syntax_error): Append a newline. All callers
1275 changed, except for the ones that didn't already append a newline.
1276 Bug reported by Eric Blake.
1278 2006-01-11 Jim Meyering <jim@meyering.net>
1280 * src/system.h (X2NREALLOC): Now that verify_true is no longer
1281 void, cast its result to void, to avoid gcc's warning that
1282 ``left-hand operand of comma expression has no effect''.
1283 (DECIMAL_DIGIT_ACCUMULATE, X2REALLOC): Likewise.
1285 2006-01-10 Jim Meyering <jim@meyering.net>
1287 * tests/chmod/no-x: Add a test for today's fts.c fix.
1289 2006-01-10 Jim Meyering <jim@meyering.net> (tiny change)
1291 * src/ls.c (gobble_file): Use DTTOIF only if it's defined.
1292 This is necessary for Dragonfly. Patch by Joerg Sonnenberger.
1294 2006-01-10 Paul Eggert <eggert@cs.ucla.edu>
1296 * src/system.h (X2NREALLOC, X2REALLOC, DECIMAL_DIGIT_ACCUMULATE):
1297 Use verify_true instead of verify_expr, to sync with gnulib.
1299 2006-01-08 Jim Meyering <jim@meyering.net>
1301 * src/date.c (usage): Adjust the formatting of the entries for
1302 %::z and %:::z (separate with two spaces, not one) so that help2man
1303 formats them properly. Reported by Philip Rowlands.
1305 2006-01-06 Paul Eggert <eggert@cs.ucla.edu>
1307 * configure.ac (gl_IGNORE_UNUSED_LIBRARIES): Add.
1309 2006-01-06 Jim Meyering <jim@meyering.net>
1311 * Makefile.maint (copyright-check): Use date +%Y in place of
1314 * src/remove.c (rm_1): Remove `static' attribute on local `status'.
1315 First off, the attribute should have been `volatile' (not static)
1316 to avoid longjmp-related risk of clobber. Secondly, now there is
1317 no longer any risk of a local variable being clobbered, so there's
1318 no need for any attribute at all.
1320 2006-01-05 Jim Meyering <jim@meyering.net>
1322 * src/remove.c: Give a few functions the inline attribute.
1323 (AD_pop_and_chdir): Use gotos to avoid some duplication.
1324 (AD_push): Rewrite an assertion so that the entire computation
1325 goes away when assertions are turned off.
1327 * src/tail.c (ENOSYS) [!defined ENOSYS]: Don't define here.
1328 It's already defined in "system.h".
1329 * Makefile.maint: Add a FIXME comment.
1331 2006-01-04 Jim Meyering <jim@meyering.net>
1333 * ChangeLog: Remove entries from 2005-10-22 and earlier.
1334 * ChangeLog-2005: New file, for entries up to version 5.92.
1336 2006-01-03 Jim Meyering <jim@meyering.net>
1338 * tests/du/no-x: Also allow a slightly different diagnostic -- the
1339 one you get when using openat-enabled fts.c and du (coming soon).
1340 * tests/chmod/no-x: Likewise.
1341 * tests/chgrp/no-x: Likewise.
1343 * src/system.h (O_DIRECTORY) [!defined O_DIRECTORY]: Define.
1345 2006-01-02 Paul Eggert <eggert@cs.ucla.edu>
1347 * src/chown-core.c (RC_do_ordinary_chown): New enum value.
1348 (restricted_chown): Return it, if the file cannot be accessed due
1349 to EPERM, or if no uid or gid are required, or if the file is
1350 neither a directory nor a regular file. Rewrite to avoid gotos.
1351 (change_file_owner): Handle RC_do_ordinary_chown case.
1352 Rewrite to avoid gotos.
1353 * tests/chgrp/basic: Make sure we can change the group of
1356 * src/date.c (usage): Explain %g, %G, and %V a bit better.
1358 2006-01-02 Jim Meyering <jim@meyering.net>
1360 * src/copy.c (set_owner): Correct a comment.
1362 * src/tail.c (parse_options): Change warning to say that --retry
1363 is useful `mainly' (not `only') when following by name.
1364 Reported here: http://bugs.debian.org/273781
1366 2006-01-01 Paul Eggert <eggert@cs.ucla.edu>
1368 * NEWS: Document that mkfifo and mknod -m no longer set special bits.
1369 * src/copy.c: Include lchmod.h.
1370 (copy_internal): Use lchmod rather than chmod.
1371 * src/cp.c: Include lchmod.h.
1372 (re_protect, make_dir_parents_private): Use lchmod rather than chmod.
1373 * src/mkdir.c: Include lchmod.h.
1374 (usage): Clarify -m's operation.
1375 (main): Use lchmod rather than chmod. Don't use lchmod unless the
1376 new mode contains bits outside the 777 range.
1377 * src/mkfifo.c (usage): Clarify -m's operation.
1378 (main): If -m is given, don't invoke chmod; use umask 0 instead.
1379 Report an error if -m asks for bits outside the 777 range.
1380 * src/mknod.c (usage, main): Likewise.
1382 * src/mkdir.c, src/mkfifo.c, src/mknod.c: Undo 2005-12-19 changes.
1384 2005-12-27 Jim Meyering <jim@meyering.net>
1386 * Makefile.maint (sc_obsolete_symbols): Prohibit use of O_NDELAY.
1387 (sc_prohibit_assert_without_use): New rule.
1388 (syntax-check-rules): Add it to the list.
1389 * .x-sc_prohibit_assert_without_use: New empty file.
1390 * Makefile.am (EXTRA_DIST): Add it.
1392 * Makefile.maint (CVS_LIST): Define in terms of $(srcdir).
1394 * cp.c, df.c, link.c, mknod.c, nice.c, sleep.c, unlink.c:
1395 Don't include <assert.h>; it wasn't used.
1397 2005-12-26 Paul Eggert <eggert@cs.ucla.edu>
1399 * src/chown-core.c (restricted_chown):
1400 Don't try O_WRONLY unless O_RDONLY failed wth EACCES.
1401 * src/remove.c (fd_to_subdirp): Open with O_DIRECTORY | O_NOCTTY
1402 | O_NOFOLLOW too, for consistency with other dir-openers.
1403 Use POSIX-preferred O_NONBLOCK rather than O_NDELAY.
1404 (is_empty_dir): Likewise.
1405 * src/shred.c (wipename): Likewise. Don't bother trying to open
1406 dir for writing, since POSIX prohibits it.
1408 2005-12-22 Jim Meyering <jim@meyering.net>
1410 * tests/help-version: Redirect stderr to /dev/full, to suppress
1411 write error diagnostic.
1413 2005-12-19 Jim Meyering <jim@meyering.net>
1415 * src/mkdir.c, src/mknod.c, src/mkfifo.c (main)
1416 Avoid a minor race condition when `-m MODE' is specified, by using
1417 open, fchown, and close rather than just chown. To do that reliably --
1418 even with an overly restrictive umask -- ensure that each mkdir,
1419 mknod and mkfifo call uses a mode including at least owner-read access.
1420 * src/mknod.c (main): When `-m MODE' is specified, exit nonzero if
1421 the subsequent chown (or equivalent open,fchown,close) fails.
1422 * tests/misc/mknod: New tests.
1423 * tests/misc/Makefile.am (TESTS): Add mknod.
1425 2005-12-17 Jim Meyering <jim@meyering.net>
1427 * src/remove.c (is_empty_dir): Open with O_NDELAY, so we don't hang,
1428 e.g., on a named pipe.
1429 (OPEN_NO_FOLLOW_SYMLINK): Remove definition. Use O_NOFOLLOW in
1430 place of all uses, since it is guaranteed (system.h) to be defined.
1432 2005-12-05 Andreas Gruenbacher <agruen@suse.de>
1434 Add POSIX ACL support
1435 * src/ls.c: Switch back from HAVE_ACL to USE_ACL: The acl() syscall
1436 is no requirement for ACL support; particularly, it does not exist
1437 on systems that have POSIX ACLs.
1438 * src/copy.h (cp_option_init) [umask_kill]: Remove member.
1439 * src/cp.c (umask_kill): With default acls, the umask is not to be
1440 applied. Remove umask_kill, don't change the process umask, and let
1441 the kernel apply the umask where appropriate.
1442 * src/cp.c (make_dir_parents_private): Fix logic for POSIX ACLs.
1443 * src/copy.c (get_dest_mode): Remove; it is obsolete after removing
1445 (copy_reg, copy_internal): Use copy_acl and set_acl
1446 instead of fchown/chown. Fix the logic for POSIX ACLs.
1447 (chown_succeded): Remove; we now always copy acls and
1448 preserve S_ISUID, S_ISGID, and S_ISVTX when needed, no matter if we
1449 did a chown before or not.
1450 * src/mv.c, src/install.c (cp_option_init): Don't set umask_kill member.
1451 * src/Makefile.am (dir_LDADD, ls_LDADD, vdir_LDADD, cp_LDADD,
1452 mv_LDADD, ginstall_LDADD): On systems with an ACL library, arrange
1453 to link with it via $(LIB_ACL), for the utilities that need it.
1455 2005-12-16 Paul Eggert <eggert@cs.ucla.edu>
1457 * src/remove.c (OPENAT_CWD_RESTORE__REQUIRE): Remove.
1458 (OPENAT_CWD_RESTORE__ALLOW_FAILURE): Likewise.
1459 (fd_to_subdirp): Remove openat_cwd_restore_allow_failure arg; its
1460 value is now signified by whether cwd_errno is null.
1461 (fd_to_subdirp, remove_dir, rm_1); Change cwd failure indicator from
1462 pointer-to-bool to pointer-to-errno-value. All callers changed.
1463 (rm_1): Don't bother setting a local cwd failure flag and then
1464 ORing it into the caller's. Just set the caller's.
1465 (rm): Use cwd failure errno value to print a slightly-better
1468 2005-12-15 Jim Meyering <jim@meyering.net>
1470 * src/stat.c (print_it): Properly handle a backslash at the
1471 end of a --printf format string. Reported by Paul Eggert.
1472 * tests/misc/stat-printf (end-bs): Add a test for the above.
1474 2005-12-15 Paul Eggert <eggert@cs.ucla.edu>
1476 * tests/acl: Port to pre-POSIX shells like Solaris 8 /bin/sh.
1477 Don't assume /etc/passwd contains user names; use 'id' instead.
1479 2005-12-15 Jim Meyering <jim@meyering.net>
1481 stat: revert behavior of --format=FMT (-c)
1482 stat: add new option: --printf=FMT
1483 * NEWS: Mention this.
1484 * src/stat.c (isodigit, octtobin, hextobin): Define.
1485 (PRINTF_OPTION): Define.
1486 (interpret_backslash_escapes, trailing_delim): New globals.
1487 (usage): Document them. Alphabetize on long option names.
1488 (print_esc_char): New function.
1489 (print_it): Rewrite, in order to handle backslash escapes.
1490 (main): Handle new option. Set globals for --format, too.
1492 * tests/misc/stat-printf: Test --printf and --format.
1493 * tests/misc/Makefile.am (TESTS): Add stat-printf.
1495 2005-12-14 Paul Eggert <eggert@cs.ucla.edu>
1497 * NEWS: sort now reports incompatible options.
1498 * src/sort.c (incompatible_options, check_ordering_compatibility):
1500 (main): Use them. Don't bother with a usage message for
1501 "sort -c a b", for consistency with other error diagnostics.
1502 * tests/sort/Test.pm (incompat1, incompat2, incompat3, incompat4):
1505 * src/cat.c (main): Undo previous change. close_stdout already
1506 does the check, so the previous change wasn't necessary.
1508 2005-12-13 Paul Eggert <eggert@cs.ucla.edu>
1510 * src/cat.c (main): Check for close (STDOUT_FILENO) failure.
1512 2005-12-12 Paul Eggert <eggert@cs.ucla.edu>
1514 Install a more-conservative approach for sort -R. It's the
1515 same basic idea as the existing code, except it uses the full ISAAC
1516 approach (called the "more kosher" approach in the existing comments).
1517 This makes "sort -R" quite a bit slower (about a factor of 2 on my
1518 little tests involving 10000 lines on a 2.4 GHz P4), but I think it's
1519 better to be conservative here at first, and review any performance
1520 improvements carefully.
1521 * .x-sc_require_config_h: Add src/rand-isaac.c.
1522 * src/rand-isaac.h: Remove. All uses now simply include rand-isaac.c.
1523 * src/Makefile.am (noinst_HEADERS): Remove rand-isaac.h.
1524 (shred_SOURCES, sort_SOURCES): Remove.
1525 (EXTRA_DIST): Add rand-isaac.c.
1526 * src/rand-isaac.c: Revert to what used to be in shred.c, without
1527 changing it to allow for varying numbers of words in the state.
1528 Alter so that we include rand-isaac.c directly rather than
1529 compiling it and linking to it. Don't include config.h or
1530 system.h; that's the includer's responsibility.
1531 Omit functions that are specific to shred.
1532 (ISAAC_LOG, ISAAC_WORDS, ISAAC_BYTES, struct isaac_state, ind):
1533 (isaac_step, struct irand_state):
1534 Resurrect these, with the same defns that used to be in shred.c.
1535 (ISAAC_SIZE, isaac_new, isaac_copy): Remove.
1536 (isaac_refill, isaac_seed_start, isaac_seed_data, irand_init, irand32):
1538 (struct isaac_state, isaac_refill, isaac_mix, isaac_init):
1539 (isaac_seed_start, isaac_seed_data, isaac_seed_finish, isaac_seed):
1540 (irand_init, irand32, irand_mod):
1541 Number of words is constant again.
1542 (struct irand_state, irand_init, irand32, irand_mod): Move to shred.c.
1543 * src/shred.c: Include rand-isaac.c rather than rand-isaac.h.
1544 * src/sort.c: Likewise.
1545 * src/shred.c (fillrand, dopass, main): Undo previous change.
1546 (struct irand_state, irand_init, irand32, irand_mod): Moved back here,
1548 * src/sort.c: Don't include md5.h; it wasn't needed.
1549 (struct keyfield): Rename random_hash to random, for consistency
1550 with the other member names. All uses changed.
1551 (usage): Tweak wording to mention STRING for --seed option.
1552 (short_options): Rorder for consistency with other programs.
1553 (rand_state): Now a struct, not a pointer to one. All uses changed.
1554 (HASH_WORDS, HASH_SIZE): Remove.
1555 (get_hash): Remove comments around resbuf size, since we can assume C89.
1556 Use a "more-kosher" (but slower) approach of invoking isaac_refill.
1557 (keycompare): Adjust to the new get_hash.
1559 (badfieldspec): Omit recently-introduced comment; it isn't needed.
1560 (main): Don't set need_random simply because gkey has it set; that
1561 doesn't necessarily mean we'll need random numbers.
1562 Redo seeding to match new get_hash approach.
1564 2005-12-10 Jim Meyering <jim@meyering.net>
1566 * src/Makefile.am (noinst_HEADERS): Add rand-isaac.h.
1568 Avoid shred segfault on 64-bit systems.
1569 * src/rand-isaac.c (isaac_refill): Don't try to negate a
1570 local of type uint32_t. Make the local an `int' instead.
1572 * NEWS: Mention sort's new options.
1574 * src/rand-isaac.c (isaac_mix): Declare to be static.
1575 Mark all other functions as `extern' so the tight-scope
1576 part of `make distcheck' passes once again.
1577 * src/rand-isaac.h (isaac_mix): Remove declaration.
1579 * src/sort.c (get_hash): Change position of `*' in parameter
1580 type to conform with convention.
1581 (main): Split a long line so it fits in 80 columns.
1582 (keycompare): Remove stray SPACE before TAB that was
1583 causing `make distcheck' to fail.
1585 * src/shred.c: Don't include gethrxtime.h. No longer needed.
1587 * tests/misc/sort-rand: New file: basic tests for the new options.
1588 * tests/misc/Makefile.am (TESTS): Add sort-rand.
1590 2005-12-10 Frederik Eaton <frederik@ofb.net>
1592 * src/Makefile.am (sort_LDADD): Add $(LIB_GETHRXTIME).
1593 (shred_SOURCES, sort_SOURCES): New macros, so we compile rand-isaac.c.
1594 * src/rand-isaac.c: New file, containing ISAAC code that was in shred.c.
1595 Make state size runtime-configurable.
1596 (isaac_new, isaac_copy): New functions.
1597 * src/rand-isaac.h: New file.
1598 * src/shred.c: Include rand-isaac.h. Move ISAAC code to rand-isaac.c.
1599 (fillrand, main): Adjust to the fact that the state size is now
1600 runtime-configurable.
1601 * src/sort.c (short_options, long_options, WORDS, keycompare, main):
1602 (usage): Add options --random-sort and --seed to implement a random
1604 Include md5.h and rand-isaac.h.
1605 (get_hash): New function.
1606 (rand_state): New var.
1607 (HASH_WORDS, HASH_SIZE): New macros.
1609 2005-12-09 Paul Eggert <eggert@cs.ucla.edu>
1611 * tests/dd/misc: Add test for dd iflags=noatime.
1613 2005-12-09 Jim Meyering <jim@meyering.net>
1615 * src/sort.c (usage): Mention white space vs -b and -t options.
1618 2005-12-09 Eric Blake <ebb9@byu.net>
1620 * src/test.c (main): Fix misleading comment.
1622 2005-12-07 Paul Eggert <eggert@cs.ucla.edu>
1624 * NEWS: Mention dd's new noatime flag.
1625 * src/system.h (O_NOATIME): Define to 0 if not already defined.
1626 * src/dd.c (flags, usage): Add support for noatime flag.
1628 2005-12-07 Jim Meyering <jim@meyering.net>
1630 Distribute the cvsu script, used only by `make syntax-check'.
1631 * Makefile.am (EXTRA_DIST): Add build-aux/cvsu.
1632 * Makefile.maint (CVS_LIST): Use build-aux/cvsu, now that we
1633 distribute a copy of this script.
1634 * .x-sc_unmarked_diagnostics: Add build-aux/cvsu.
1636 * tests/mv/acl: exit-77 before the trap, not after, if we fail
1637 to create a temporary directory on another partition.
1638 From Andreas Gruenbacher.
1640 2005-12-06 Tomas Pospisek <tpo@sourcepole.ch> (tiny change)
1642 * man/basename.x: Cross-reference to dirname and readlink.
1643 * man/dirname.x: Cross-reference to basename and readlink.
1645 2005-12-05 Andreas Gruenbacher
1647 * src/copy.c [!HAVE_FCHOWN]: Define fchown(...) to -1.
1648 (set_owner, preserve_author): New functions, factored out of copy_reg.
1649 (copy_reg): Use them.
1650 (copy_internal): Use them here, too.
1652 2005-12-04 Jim Meyering <jim@meyering.net>
1654 * src/sleep.c (usage): Say what happens with two or more arguments.
1655 Suggested by Justin Pryzby.
1657 * src/uptime.c (print_uptime): Move decl of `upsecs' into scope
1660 2005-12-03 Jim Meyering <jim@meyering.net>
1662 * src/rm.c (long_opts): Change the name of each undocumented, for-
1663 testing-only option to start with `-', so that it cannot render
1664 ambiguous any prefix it happens to share with some other option name.
1665 Problem reported by Eric Blake.
1666 * src/head.c (long_options): Likewise.
1667 * src/tail.c (long_options): Likewise.
1669 * tests/misc/head-elide-tail: Update uses of undocumented, for-
1670 testing-only --presume* options to start with `---'.
1671 * tests/rm/dangling-symlink: Likewise.
1672 * tests/rm/dir-no-w: Likewise.
1673 * tests/rm/isatty: Likewise.
1675 2005-11-30 Jim Meyering <jim@meyering.net>
1677 * Makefile.maint: Add a comment about cvsu.
1679 2005-11-25 Paul Eggert <eggert@cs.ucla.edu>
1681 * NEWS: df updates for "none", "proc", inaccessible file systems.
1682 * src/df.c (show_point): Ignore inaccessible file systems.
1683 (usage): -a includes dummy file systems, not size-0 file systems.
1685 * src/od.c (unsigned_long_long_int): Renamed from ulonglong_t,
1686 to avoid collision with POSIX name space. All uses changed.
1688 2005-11-24 Jim Meyering <jim@meyering.net>
1690 * tests/Makefile.am (EXTRA_DIST): Add acl to the list.
1691 * tests/acl: Add `$0: ' prefix to diagnostics.
1693 * .x-sc_require_config_h: Add lib/buffer-lcm.c to the list.
1695 2005-11-23 Paul Eggert <eggert@cs.ucla.edu>
1697 * src/copy.c: Improve performance a bit by optimizing away
1698 unnecessary system calls and going to a block size of at least
1699 8192 (on normal hosts, anyway). This improved performance 5% on my
1700 Debian stable host (2.4.27 kernel, x86, copying from root
1701 ext3 file system to itself).
1702 Include "buffer-lcm.h".
1703 (copy_reg): Omit last argument. All callers changed.
1704 Use xmalloc to allocate rather than trusting alloca
1705 (which is unwise with large block sizes).
1706 Declare locals more locally, if possible.
1707 Use uintptr_t words instead of int words, for a bit more speed
1708 when looking for null blocks on 64-bit hosts.
1709 Optimize away reads of zero bytes on regular files.
1710 In the typical case, insist on 8 KiB buffers, at least.
1711 Avoid unnecessary extra call to fstat when checking for sparse files.
1712 Avoid now-unnecessary cast to off_t, and "0L".
1713 Avoid unnecessary test of *new_dst when checking for same owner
1716 2005-11-22 Paul Eggert <eggert@cs.ucla.edu>
1718 * src/remove.c (rm): Don't assume C99 for-loop syntax.
1720 2005-11-22 Jim Meyering <jim@meyering.net>
1722 * src/remove.c (AD_push): Remove debugging cruft.
1724 * tests/rm/unread2 (rm): Change expected diagnostic,
1725 `cannot open directory' to `cannot remove', to align with
1727 * tests/rm/rm2: Ensure that rm now continues removing entries
1728 even after certain types of failure.
1730 * src/remove.c: Rewrite. Now, this module is reentrant on systems
1731 that provide openat (Solaris), and on systems like Linux+procfs
1732 where our openat emulation code is reentrant. This also fixes a
1733 few low-probability leaks and eliminates some code that could,
1734 in very unusual circumstances, cause rm() (via a callee) to exit.
1735 * NEWS: Mention this.
1737 * configure.ac: Put copyright dates all on one line so the
1738 emacs function that updates them works properly.
1740 2005-11-18 Paul Eggert <eggert@cs.ucla.edu>
1742 * configure.ac (AM_PROG_CC_C_O): Add. Needed for CVS Automake.
1743 Problem reported by Eric Blake.
1744 (AC_PROG_CC_STDC): Use this instead of AC_PROG_CC, so that
1745 we get a standard-conforming compiler. This relies on the new
1746 m4/c.m4 file. Note that it's a bit tricky, since c.m4 doesn't
1747 define AC_PROG_CC_STDC; we are relying on Autoconf 2.59 internals.
1748 m4/c.m4 can go away with Autoconf 2.60 comes out.
1750 2005-11-17 Jim Meyering <jim@meyering.net>
1752 * src/remove.c (AD_mark_helper): Make a `char *' parameter `const'.
1753 (AD_mark_current_as_unremovable): Likewise, but for a local.
1756 * tests/mv/acl: Let traps handle removing temporary directories.
1758 Expect acl-related tests to fail, until the corresponding
1759 patches are committed.
1760 * tests/mv/Makefile.am (XFAIL_TESTS): Add acl.
1761 * tests/cp/Makefile.am (XFAIL_TESTS): Likewise.
1763 ACL tests, from Andreas Gruenbacher.
1764 * tests/acl, tests/mv/acl, tests/cp/acl: New files.
1765 * tests/mv/Makefile.am (TESTS): Add acl.
1766 * tests/cp/Makefile.am (TESTS): Add acl.
1768 * src/ls.c (basename_is_dot_or_dotdot): Correct wording in comment.
1770 2005-11-16 Paul Eggert <eggert@cs.ucla.edu>
1772 * NEWS: Improve quality of ln's diagnostics.
1773 * src/ln.c (do_link, usage): Likewise.
1774 (do_link): Don't use alloca on a buffer of unbounded size.
1776 2005-11-16 Jim Meyering <jim@meyering.net>
1778 * tests/cp/fail-perm: Accommodate HPUX. It appears to fail
1779 with EACCES rather than EPERM. Reported by Peter O'Gorman here:
1780 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/5766
1781 This also affects AIX 4.3.3, according to Ralf Wildenhues, in
1782 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
1784 2005-11-14 Jim Meyering <jim@meyering.net>
1786 * NEWS (sort): Mention consequences of today's mkstemp-safer.c fix.
1788 2005-11-13 Jim Meyering <jim@meyering.net>
1790 * announce-gen: Accept new option, --gpg-key-id=ID and
1791 emit a blurb telling how to use the .sig files.
1792 * Makefile.cfg (gpg_key_ID): Define.
1793 * Makefile.maint (announcement): Use new option and key.
1795 Require that most .c files include <config.h>.
1796 * Makefile.maint (sc_require_config_h): New rule.
1797 (syntax-check-rules): Add it.
1798 * .x-sc_require_config_h: New file listing exceptions to the
1799 above rule. Some are legit, others are simply grandfathered in.
1800 * Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h here, too.
1802 2005-11-12 Jim Meyering <jim@meyering.net>
1804 * src/checksum.h, src/md5.c, src/sha1sum.c: Remove now-unused files.
1806 2005-11-11 Jim Meyering <jim@meyering.net>
1808 * NEWS: Mention `readlink -f' bug fix in 5.3.0 news.
1809 Mention new readlink options in 5.3.0's `New features' section.
1810 Spotted by Thomas Hood.
1812 2005-11-08 Jim Meyering <jim@meyering.net>
1814 * NEWS: Merge in changes from b5_9x branch.
1816 2005-11-08 Paul Eggert <eggert@cs.ucla.edu>
1818 * NEWS: ls now defaults to --time-style='locale', which in turn acts
1819 like --time-style='posix-long-iso' if the locale settings are messed up.
1820 * src/ls.c (decode_switches): Implement this.
1822 2005-11-08 Jim Meyering <jim@meyering.net>
1824 * tests/du/2g: s/expensive/very expensive/ in a comment.
1827 2005-10-17 Eric Blake <ebb9@byu.net>
1829 * src/ls.c (usage): Fix descriptions of --sort, --time.
1830 Reported by Vitaly A. Ostanin.
1832 2005-11-04 Paul Eggert <eggert@cs.ucla.edu>
1834 * src/ln.c: Include filenamecat.c.
1835 (FILE_BASENAME_CONCAT): Remove.
1836 (do_link): Remove last arg DEST_IS_DIR. All callers changed.
1837 (main): Use file_name_concat, base_name, and strip_trailing_slashes
1838 instead of FILE_BASENAME_CONCAT. This simplifies the code, and avoids
1841 2005-11-04 Jim Meyering <jim@meyering.net>
1843 * src/du.c (process_file): Don't overflow for files of size >= 2^31
1844 on systems with stat.st_blocks of a signed 32-bit type.
1845 This bug causes trouble on some AIX 5.1 systems.
1846 Report and trivial patch from Paul Townsend:
1847 <http://lists.gnu.org/archive/html/bug-coreutils/2005-11/msg00033.html>
1848 * NEWS: Mention this.
1850 * tests/du/2g: New (very-expensive) test for the above-fixed bug.
1851 * tests/du/Makefile.am (TESTS): Add it here.
1852 * tests/very-expensive: New file.
1853 * tests/Makefile.am (EXTRA_DIST): Add it here.
1854 * tests/cp/perm: Mark this test as `very-expensive', too.
1856 2005-11-02 Paul Eggert <eggert@cs.ucla.edu>
1858 * NEWS: Mention that rm -d and maybe ln -d are scheduled for
1860 * src/remove.h (struct rm_options): Remove unlink_dirs. All uses
1862 * src/rm.c (usage): Don't mention rm -d.
1864 2005-11-02 Jim Meyering <jim@meyering.net>
1866 * tests/dd/skip-seek: Fix typo in comment: s/fileutils/coreutils.
1867 From Andreas Schwab.
1869 * tests/dd/unblock-sync: Redirect stderr to /dev/null so the
1870 `M+N records in/out' lines don't pollute `make check' output.
1872 * tests/dd/skip-seek (sk-seek4): New test, to exercise the bug
1873 fixed on 2005-10-31. This test uses the new, IN_PIPE specifier.
1874 * tests/Coreutils.pm: Accept a new type of input specifier: IN_PIPE,
1875 to indicate that the input file should be piped into the command
1876 under test (via `cat FILE | $prog ...').
1878 * src/remove.c (remove_entry): Emit a better diagnostic when rm
1879 (without -r) fails to remove a directory on a non-Linux system.
1880 This change affects only newer Solaris systems (with priv_*
1881 functions like priv_allocset). Reported by Keith Thompson.
1883 * tests/rm/dir-nonrecur: New file/test for the above fix.
1884 * tests/rm/Makefile.am (TESTS): Add dir-nonrecur.
1886 2005-11-01 Paul Eggert <eggert@cs.ucla.edu>
1888 * NEWS: "tail -c 2 FILE" and "touch 0101000000" now operate as
1889 POSIX 1002.1-2001 requires.
1890 * src/tail.c (parse_obsolete_option): Implement this.
1891 Problem reported by Vincent Lefevre.
1892 * src/touch.c (main): Pass PDS_PRE_2000 to posixtime.
1893 * tests/tail/Test.pm (c-2, c-2-minus, c2, c2-minus): New tests.
1894 (test_vector): Add special cases for _POSIX2_VERSION, and
1895 regularize the old ones a bit.
1896 * tests/touch/obsolescent: Add y2000 test.
1898 2005-10-31 Paul Eggert <eggert@cs.ucla.edu>
1900 * src/dd.c (skip): Fix off-by-one error reported by
1901 Theodoros V. Kalamatianos.
1903 2005-10-30 Paul Eggert <eggert@cs.ucla.edu>
1905 * tests/mkdir/p-3: Require that the test be run as non-root.
1906 Problem and trivial fix reported by Theodoros V. Kalamatianos.
1908 2005-10-28 Paul Eggert <eggert@cs.ucla.edu>
1910 * src/ln.c (FILE_BASENAME_CONCAT): Omit unnecessary slashes in the
1911 boundary between DEST and SOURCE in the result.
1913 2005-10-26 Dmitry V. Levin <ldv@altlinux.org>
1915 * src/md5sum.c (main) [!O_BINARY]: Changed default read mode
1916 back to text, to sync with documentation and for backwards
1919 2005-10-25 Jim Meyering <jim@meyering.net>
1921 * tests/dircolors/simple (other-wr): Add an explicit test for
1922 the dircolors bug (NULL-dereference) fixed yesterday.
1924 2005-10-24 Jim Meyering <jim@meyering.net>
1926 * src/tac.c (tac_file): When determining whether a file is seekable,
1927 also test whether it is a tty. Using only the lseek-based test would
1928 give a false positive on Solaris. Reported by Peter Fales.
1930 2005-10-24 Dmitry V. Levin <ldv@altlinux.org>
1932 * tests/install/d-slashdot: New test, for "install -d" failure.
1933 * tests/install/Makefile.am (TESTS): Add d-slashdot.
1934 * tests/mkdir/p-slashdot: New test, for "mkdir -p" failure.
1935 * tests/mkdir/Makefile.am (TESTS): Add p-slashdot.
1937 2005-10-24 Jim Meyering <jim@meyering.net>
1939 * src/dircolors.c (ls_codes): Add missing comma.
1940 Anonymous report and patch from
1941 http://savannah.gnu.org/bugs/?func=detailitem&item_id=14849
1943 * src/dircolors.c: Add compile-time assertion that the slack_codes
1944 and ls_codes arrays have the same number of elements. This would
1945 have prevented the above-fixed bug.
1947 * src/expand.c (parse_tab_stops): Add a comment to make this function
1948 identical to the one in unexpand.c.
1949 * src/unexpand.c (parse_tab_stops): Adjust syntax to make this function
1950 identical to the one in expand.c.
1952 * src/expand.c (next_file): Don't assume fopen cannot return stdin.
1954 2005-10-23 Jim Meyering <jim@meyering.net>
1956 * src/md5sum.c (digest_check, main): Use ptr_align rather than
1957 a dangerous pointer-value-to-`unsigned' cast.
1958 * NEWS: mention the new sha* programs.
1959 * AUTHORS: Add new sha* programs.
1961 2005-08-28 David Madore <david.madore@ens.fr>
1963 Add new programs: sha224sum, sha256sum, sha384sum, sha512sum.
1964 * README: Add their names to the list.
1965 * src/md5sum.c: Provide framework for computing sha-2 hashes.
1966 * src/Makefile.am (sha224sum, sha256sum, sha384sum, sha512sum):
1967 Rules for compiling sha-2 utilities
1968 (noinst_HEADERS): Remove checksum.h.
1969 * man/sha512sum.x, man/sha384sum.x, man/sha256sum.x, man/sha224sum.x:
1971 * man/Makefile.am (dist_man_MANS): Add the corresponding .1 names.
1972 (sha224sum.1, sha256sum.1, sha384sum.1, sha512sum.1): New dependencies.
1973 * tests/misc/sha224sum, tests/misc/sha256sum: New files.
1974 * tests/misc/sha384sum, tests/misc/sha512sum: New files.
1975 * tests/misc/Makefile.am (TESTS): Add new sha224sum, sha256sum,
1976 sha384sum, sha512sum test scripts here rather that each in its
1979 2005-08-28 David Madore <david.madore@ens.fr>
1981 * tests/sha1sum/basic-1 (million-a): Add the "million a's" test (one
1982 of the FIPS test vectors).
1984 2005-10-23 Jim Meyering <jim@meyering.net>
1986 * configure.ac: Use 6.0-cvs as the version string.
1987 * NEWS: Adjust accordingly.