1 2006-06-12 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
3 * tests/du/Makefile.am (TESTS_ENVIRONMENT): Pass $(PERL), for
6 2006-06-11 Jim Meyering <jim@meyering.net>
8 * .gitignore: New file.
9 * Makefile.am (EXTRA_DIST): Add .gitignore.
11 Setting TIME_STYLE=long-iso in the environment would make the
12 cp/same-file test fail.
13 * tests/envvar-check (vars): Add TIME_STYLE to the list.
14 * tests/cp/same-file: Revert last change.
15 Source the envvar-check script, to ensure that TIME_STYLE
16 settings don't affect these tests.
18 2006-06-11 Paul Eggert <eggert@cs.ucla.edu>
20 * tests/cp/same-file: Execute 'ls' in the C locale, so that it
21 uses POSIX time stamp formats. Problem reported by John Nixon in
22 <http://lists.gnu.org/archive/html/bug-coreutils/2006-06/msg00062.html>.
24 2006-06-10 Jim Meyering <jim@meyering.net>
26 * NEWS: Mention the AIX-strndup-bug vs. dircolors workaround.
28 Require a "Version N.M" line at the top of the ChangeLog
29 file only when making the actual release, not when running
31 * Makefile.maint (maintainer-distcheck): Don't depend on
33 (alpha beta major): Depend on it here, instead.
35 2006-06-08 Jim Meyering <jim@meyering.net>
37 Ensure that cat works with any of the options, -A -v -e -E -T,
38 when applied to files in /proc and /sys, even when the FIONREAD
39 ioctl produces nonsensical results. Before this change, cat would
40 produce no output (or truncated output), for some linux kernels.
42 * src/cat.c (write_pending): New function, factored out of cat.
43 (cat): Also interpret a negative ioctl/FIONREAD count as indicating
44 that there are bytes to read. Some versions of linux-2.6.16 do that.
45 Write any pending output before returning.
46 Reported by Dan Jacobson in <http://bugs.debian.org/370583>.
47 * NEWS: Mention this bug fix.
48 * tests/misc/cat-proc: New file. Test for the above.
49 * tests/misc/Makefile.am (TESTS): Add cat-proc.
51 2006-06-07 Paul Eggert <eggert@cs.ucla.edu>
53 * src/expr.c (eval4): Detect overflow properly when multiplying
56 2006-06-06 Paul Eggert <eggert@cs.ucla.edu>
58 * NEWS: The 'expr' command now detects and reports integer overflow.
59 (It would be better to use extended precision instead, but that
61 * src/expr.c (integer_overflow): New function.
62 (eval4, eval3): Check for integer overflow.
64 2006-06-05 Paul Eggert <eggert@cs.ucla.edu>
66 Fix problems when building with Solaris/SVR4/etc. make, which uses a
67 different and somewhat bogus implementation of VPATH. In the
68 directory tests/misc, rename tests whose names might appear in the
69 Automake-generated rules. For example, we can't use a test named
70 'test', since Automake generates a rule that contains the text
71 "if test -f ./$$tst; ...", and this might expand to something like
72 "if ../../../coreutils-6.0/tests/misc/test -f ./$$test; ...",
73 which executes the 'test' script rather than the 'test' command.
74 * tests/misc/false-status: Renamed from tests/misc/false.
75 * tests/misc/pwd-long: Renamed from tests/misc/pwd.
76 * tests/misc/sort-merge: Renamed from tests/misc/sort.
77 ($prog): Set to 'sort' rather than to $PROG.
78 * tests/misc/test-diag: Renamed from tests/misc/test.
79 * tests/misc/Makefile.am (PROG): Take the basename of $$tst,
80 in case Solaris make has prepended the directory.
81 (TESTS): Adjust to above renamings.
82 * tests/misc/expand: Don't assign to PROG; no longer needed
83 now that Makefile.am sets PROG to the basename.
84 * tests/misc/fold: Likewise.
86 2006-06-03 Jim Meyering <jim@meyering.net>
88 Make `cp --link --no-dereference' work also on systems where the
89 link system call cannot create a hard link to a symbolic link.
90 * src/copy.c (copy_internal) [LINK_FOLLOWS_SYMLINKS]: Don't use
91 the link syscall on a symlink when it would do the wrong thing.
92 Based on the patch by Aurelien Jarno: <http://bugs.debian.org/329451>
93 * tests/cp/link-no-deref: New file/test for the above.
94 * tests/cp/Makefile.am (TESTS): Add link-no-deref.
95 * NEWS: Mention the change (doesn't affect Linux).
97 2006-06-01 Paul Eggert <eggert@cs.ucla.edu>
99 Fix some porting problems in the test cases reported by
100 Ralf Wildenhues for HP-UX 11.23 in:
101 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00238.html
102 * tests/help-version: Don't assume that \< \> works in sed.
103 * tests/misc/close-stdout: Don't assume that >&- works.
104 Add a /dev/full test.
105 * tests/touch/no-create-missing: Don't assume that >&- works.
107 2006-05-30 Jim Meyering <jim@meyering.net>
109 * src/ls.c (usage): Add `v' to the list of sorting-related options.
112 2006-05-28 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
114 * tests/cp/fail-perm: source lang-default.
115 * tests/rm/inaccessible: Likewise.
117 2006-05-28 Jim Meyering <jim@meyering.net>
119 * tests/rm/inaccessible: AIX 4.3.3 gives a different diagnostic.
120 Recognize it, too. Reported by Ralf Wildenhues, in
121 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
123 2006-05-27 Jim Meyering <jim@meyering.net>
125 * src/chgrp.c: Support new options: --preserve-root and
126 --no-preserve-root. Somehow this program was skipped when those
127 options were added to chown, chmod, and rm. Reported by
128 vaqflabuopac@spammotel.com in <http://bugs.debian.org/365656>.
129 * NEWS: Mention this.
131 2006-05-25 Paul Eggert <eggert@cs.ucla.edu>
133 * NEWS: Remove mention of --seed. We'll replace it with something
134 better, and don't want to indicate that it is supported.
135 * src/sort.c (usage): Likewise.
137 2006-05-20 Jim Meyering <jim@meyering.net>
139 * src/chmod.c (main): Use FTS_PHYSICAL here, too.
141 * src/du.c (main): Rename local, s/symlink_deref_bit/symlink_deref_bits/
142 and arrange for -D to set fts' FTS_PHYSICAL bit as well as
143 FTS_COMFOLLOW. Spotted by Justin Pryzby.
145 * gnupload: Merge changes from automake, retaining the ""--to...
146 kludge to placate overzealous `make distcheck' check.
148 2006-05-19 Jim Meyering <jim@meyering.net>
150 * src/du.c (main): Don't let -D, -L, or -P turn off the internal
151 FTS_TIGHT_CYCLE_CHECK directory traversal option.
152 Reported by Justin Pryzby in http://bugs.debian.org/367691
154 2006-05-15 Jim Meyering <jim@meyering.net>
156 * src/cp.c (usage): Correct description of -a: s/-dpR/-dpPR/.
159 2006-05-13 Jim Meyering <jim@meyering.net>
161 * tests/mv/no-target-dir: Test two more cases.
163 2006-05-11 Jim Meyering <jim@meyering.net>
165 mv -T DIR EMPTY_DIR no longer fails unconditionally
166 * src/copy.c (copy_internal): Don't manually prohibit a move where
167 the destination is an existing directory. Sometimes doing that is
168 valid. Let the rename system call enforce the rules. That is
169 allowed only when the source is a directory and the destination
170 directory (to be replaced) is empty. Reported by Eric Blake.
171 * tests/mv/no-target-dir: New file/test for this.
172 * tests/mv/Makefile.am (TESTS): Add no-target-dir.
173 * NEWS: Mention this.
175 * tests/mv/atomic: New file/test for yesterday's fix.
176 * tests/mv/Makefile.am (TESTS): Add atomic.
178 * tests/du/long-sloop: Avoid harmless `ambiguous redirect' diagnostic.
180 2006-05-10 Jim Meyering <jim@meyering.net>
182 * src/copy.c (copy_internal): Don't explicitly unlink the destination
183 when moving a symlink into the place of an existing non-directory.
184 Reported by Joshua Hudson.
185 * NEWS: mention this.
187 2006-05-07 Jim Meyering <jim@meyering.net>
189 * Makefile.maint (patch-check): Fail if patch generates any output,
190 even merely for changed offsets.
192 * src/c99-to-c89.diff: Adjust to reflect new offsets.
194 * NEWS: Mention changes affecting df, pwd, shred.
196 2006-05-06 Jim Meyering <jim@meyering.net>
198 * tests/ls/stat-vs-dirent: New test, to detect the bogus file
199 system condition where dirent.d_ino != stat.st_ino.
200 * tests/ls/Makefile.am (TESTS): Add stat-vs-dirent.
202 2006-05-06 Eric Blake <ebb9@byu.net>
204 * tests/ls/inode: Expand to test inode from readdir case.
205 * tests/ls/follow-slink: Expand to test broken links encountered
206 implicitly, favoring Solaris 9 and OpenBSD 3.4 behavior.
208 2006-05-06 Eric Blake <ebb9@byu.net>
210 * tests/mv/leak-fd: Work even on case-insensitive file system.
212 2006-05-04 Jim Meyering <jim@meyering.net>
214 * NEWS: Mention the 2006-03-19 pwd-related change that makes
215 lib/getcwd.c work around inconsistent file system dirent.d_ino data.
217 2006-05-03 Jim Meyering <jim@meyering.net>
219 * src/ls.c (DEFINE_SORT_FUNCTIONS, LIST_SORTFUNCTION_VARIANTS):
220 Use better macro parameter names: s/basename/key_name/,
221 s/basefunc/key_cmp_func. Fix typo in comment.
223 2006-04-29 Eric Blake <ebb9@byu.net>
225 * src/ls.c (main): On systems with d_type, directories_first only
226 implies format_needs_type, not format_needs_stat.
228 2006-05-03 Jim Meyering <jim@meyering.net>
230 * src/ls.c (xstrcoll_df_version, rev_xstrcoll_df_version): Add space
231 after comma in arg list, from Eric Blake.
233 2006-04-25 Paul Eggert <eggert@cs.ucla.edu>
235 * tests/misc/date (relative-3): New test, derived from a bug
236 report by John Thomas McDole.
238 2006-04-23 Francesco Montorsi <fr_m@hotmail.com>
240 New option for ls: --group-directories-first.
241 It makes ls list directories before files.
242 * NEWS [New features]: Mention it.
243 * src/ls.c (sort_type): Rearrange to use as an array index when
244 choosing sort function; added new sort_numtypes member for
246 (time_type): Add new time_numtypes member for compile-time check.
247 (directories_first): New global variable.
248 (GROUP_DIRECTORIES_FIRST_OPTION): New enum.
249 (long_options): Add --directories-first.
250 (main): Support new option.
251 (is_directory): New function.
252 (extract_dirs_from_files): Use it.
253 (DIRFIRST_CHECK, DEFINE_SORT_FUNCTIONS)
254 (LIST_SORTFUNCTION_VARIANTS): New macros.
255 (sort_functions): New global variable.
256 (sort_files): Use it.
257 (usage): Document new option.
259 2006-04-18 Paul Eggert <eggert@cs.ucla.edu>
261 * src/shred.c (fillrand): The assertion was way too weak, due to
262 what must be a typo. Strengthen it to its intended value.
263 (dopass): Don't use alloca; it's not worth the aggravation here,
264 since it's used only to get a page-aligned buffer, and page
265 alignment doesn't buy us much here. I'm suspicious that alloca
266 causes problems on some hosts, due to a recent bug report by Adam
267 Waltman: http://bugs.gentoo.org/130246.
269 2006-04-18 Jim Meyering <jim@meyering.net>
271 * tests/misc/tty-eof: Add new programs, base64, sha224sum, sha256sum,
272 sha384sum, sha512sum.
274 2006-04-17 Paul Eggert <eggert@cs.ucla.edu>
276 * src/chmod.c (describe_change): Adjust to filemode changes.
277 * src/ls.c (HAVE_ST_DM_MODE): Remove; moved to ../lib/filemode.c.
278 (print_long_format): Use (new) filemodestring rather than
279 (old) mode_string, so that we get more file types right, at least
280 in theory. Adjust to filemode changes.
281 * src/stat.c (human_access): Likewise.
283 2006-04-18 Jim Meyering <jim@meyering.net>
285 * src/ptx.c (main) [DEFAULT_IGNORE_FILE]: Remove code to use a default
286 ignore file. This has never been enabled. Reported by Eric Blake.
288 2006-04-12 Paul Eggert <eggert@cs.ucla.edu>
290 * src/ln.c (linkfunc): Remove. This method ran into a compiler/linker
291 bug in Interix. Just call symlink or link directly. All uses changed.
292 * src/setuidgid.c (main) [! HAVE_SETGROUPS]: Don't call setgroups.
293 * src/stat.c (USE_STATVFS): New macro.
294 Include <sys/statvfs.h> and use statvfs only if USE_STATVFS.
295 (NAMEMAX_FORMAT): define a bit more clearly, now that the
296 statvfs-using code is a bit more regular.
297 * src/system.h (sync) [!HAVE_SYNC]: New macro.
299 2006-04-11 Paul Eggert <eggert@cs.ucla.edu>
301 * NEWS: csplit, nl, expr now conform to POSIX better, and are
302 more-compatible with traditional Unix, with respect to regular
304 * src/csplit.c (extract_regexp): Set re_syntax_options to a
305 value that is compatible with what POSIX requires.
306 * src/nl.c (build_type_arg): Likewise.
307 * src/expr.c (docolon): Likewise. Also, don't let anchors match
308 newline; this fixes an incompatibility with tradition and with POSIX.
309 Don't warn about leading ^. POSIX says it is unspecified whether
310 ^ is a special character, which means that implementations can
311 either treat it as special or not, but either way a warning is not
312 allowed (unless the regexp is otherwise invalid). Instead, anchor
313 the expression but treat ^ as an anchor; this is the traditional
314 behavior (e.g., Solaris 10).
315 (eval4, eval3, eval2): Treat non-numeric args, division by zero,
316 and the like as invalid expressions (exit status 2), not as
317 failure of 'expr' (exit status 3). This is more consistent with
319 * tests/expr/basic (fail-a): Adjust exit status to match new expr
320 behavior, for status 2 versus 3.
322 (bre1, bre2, bre3, bre4, bre5, bre6, bre7, bre8, bre9, bre10):
323 (bre11, bre12, bre13, bre14, bre15, bre16, bre17, bre18, bre19, bre20):
324 (bre21, bre22, bre23, bre24, bre25, bre26, bre27, bre28, bre29, bre30):
325 (bre31, bre32, bre33, bre34, bre35, bre36, bre37, bre38, bre39, bre40):
326 (bre41, bre42, bre43, bre44, bre45, bre46, bre47, bre48, bre49, bre50):
327 (bre51, bre52, bre53, bre54, bre55, bre56, bre57, bre58, bre59, bre60):
328 (bre61, bre62): New tests.
329 * tests/misc/csplit: Use \{...\} in test RE, to test that we're
333 * tests/du/long-from-unreachable: Solaris 8 sh doesn't understand
334 "if !". Do not assume that 'sed' can handle long, newline-free input.
335 * tests/du/long-sloop: Likewise. Evaluate expr once, not $n times.
337 2006-04-10 Paul Eggert <eggert@cs.ucla.edu>
339 Adjust to new regex.h API (with new fastmap type), and clean
340 up the regex storage allocation a bit.
342 * src/csplit.c (struct control): Put re_compiled member at the
343 end, since it's large. Change regexpr member from char * to bool;
344 all uses changed. Add new member fastmap.
345 (extract_regexp): regexp arg is now char const *, not char *.
346 Don't bother duplicating the regular expression; it's not needed.
347 Set fastmap from new fastmap member. Don't bother allocating
348 a buffer, as the regexp code does a better job than we do.
349 * src/expr.c (docolon): Allocate and use a fastmap.
350 Don't bother allocating a buffer.
351 * src/nl.c (body_fastmap, header_fastmap, footer_fastmap):
353 (build_type_arg): New fastmap arg. All uses changed.
354 Don't bother allocating a buffer, but set a fastmap.
355 * src/ptx.c (context_regex_string, word_regex_string): Remove.
356 (context_regex, word_regex): New vars, replacing the above.
358 (struct regex_data): New type.
359 (compile_regex): Renamed from alloc_and_compile_regex, since
360 we no longer allocate storage. Arg is now a struct regex_data *,
361 not a const char *. All uses changed. Don't allocate the fastmap;
362 instead, take it from the caller. Don't convert size_t to int,
363 to avoid arithmetic overflow problems. Don't bother freeing
364 storage afterwards; it's not worth the aggravation.
365 * src/tac.c (compiled_separator_fastmap): New ver.
366 (main): Use it. Don't bother allocating a buffer.
368 2006-03-30 Jim Meyering <jim@meyering.net>
370 * src/dd.c (iwrite): Remove assignment without effect.
371 Reported by Felix Rauch Valenti.
373 2006-03-22 Eric Blake <ebb9@byu.net>
375 * src/ptx.c (usage): Remove mention of --copyright/-C.
376 (main): Alias --copyright to --version plus a deprecation warning.
377 * NEWS: Mention this.
379 2006-03-27 Jim Meyering <jim@meyering.net>
381 * src/Makefile.am (uptime_LDADD): Add $(POW_LIB), for uptime's
382 use of strtod. Tiny patch from Nickolai Zeldovich.
384 2006-03-11 Eric Blake <ebb9@byu.net>
386 * tests/misc/dirname: New file.
387 * tests/basename/Makefile.am: Delete.
388 * tests/basename/basic: Move to...
389 * tests/misc/basename: ... this new file. Add some tests,
390 including fixed behavior for //.
391 * tests/misc/Makefile.am (TESTS): Sort. Add basename, dirname.
392 * tests/Makefile.am (SUBDIRS): Remove basename.
393 * configure.ac (AC_CONFIG_FILES): Remove tests/basename.
395 Improvements to dirname/basename handling on platforms like
396 cygwin with distinct // and with drive letters.
397 * NEWS: Document new behavior.
398 * src/basename.c (main): Don't strip suffix from file system
400 * src/cp.c (target_directory_operand): Use new last_component.
401 (ASSIGN_BASENAME_STRDUPA): Likewise. Reduce time spent
402 traversing the string.
403 * src/dircolors.c (guess_shell_syntax): Use new last_component.
404 * src/install.c (target_directory_operand, install_file_in_dir):
406 * src/ln.c (target_directory_operand, main): Likewise.
407 * src/ls.c (basename_is_dot_or_dotdot): Likewise.
408 * src/mv.c (target_directory_operand, movefile): Likewise.
409 * src/remove.c (rm_1): Likewise.
410 * src/shred.c (wipename): Likewise.
411 * src/split.c (next_file_name): Likewise.
412 * src/su.c (log_su, run_shell): Likewise.
414 2006-03-23 Paul Eggert <eggert@cs.ucla.edu>
416 * NEWS: nohup diagnostics are now more precise, and nohup now
417 redirects stderr to nohup.out if stdout is closed and stderr is a tty.
418 * src/nohup.c (main): Implement this.
419 * tests/misc/nohup: Test the new behavior.
421 2006-03-12 Jim Meyering <jim@meyering.net>
423 * src/copy.c (set_author): Rename function, from preserve_author.
425 * src/remove.c (AD_pop_and_chdir): Use new macro,
426 CYCLE_CHECK_REFLECT_CHDIR_UP, rather than open-coding it.
428 * src/system.h (SAME_INODE): Remove definition.
429 Include "same-inode.h", instead.
431 2006-03-11 Eric Blake <ebb9@byu.net>
433 * src/pwd.c (robust_getcwd): Prepend only one slash, not two.
435 2006-03-10 Jim Meyering <jim@meyering.net>
437 Fix a bug whereby a user with write access to a directory being removed
438 could cause the removal of that directory to fail with an erroneous
439 diagnostic about a directory cycle. Reported by Vineet Chadha.
441 * NEWS: Mention this.
442 * src/remove.c (AD_pop_and_chdir): If the directory we're about to
443 leave (and try to rmdir) is the one whose dev_ino is being used to
444 detect a cycle, reset cycle_check_state.dev_ino to that of the parent.
446 2006-03-08 Paul Eggert <eggert@cs.ucla.edu>
448 * NEWS: Document dd's new 'directory' and 'nolinks' flags.
449 * src/dd.c (set_fd_flags): Handle file-creation flags on file
450 descriptors, rather than ignoring them.
451 * tests/dd/misc: Add test cases for append, nofollow, directory,
452 and nolinks flags. Simplify redirection to /dev/null in some cases.
454 * tests/dd/misc: iflags->iflag. This fixes a typo that meant the
455 noatime test never tested anything.
457 2006-03-05 Paul Eggert <eggert@cs.ucla.edu>
459 * src/dd.c (flags, usage): New flags directory, nolinks.
460 * src/system.h (O_NOLINKS): Define to 0 if not already defined.
462 * src/ls.c (usage): Mention that -f disables --color.
463 Problem reported by Niels Möller.
465 2006-03-03 Justin Pryzby <pryzbyj@justinpryzby.com>
467 * man/*.x: Add references to syscalls from utilities of the same name.
469 2006-03-05 Jim Meyering <jim@meyering.net>
471 * tests/help-version: Set SHELL, if not already set, in order to
472 avoid failure when `make check' is run through debuild; dircolors
473 would fail due to lack of $SHELL. Reported by Sven Joachim.
475 Make `base64 --wrap=N' work for N=0, and for N larger than SIZE_MAX.
476 * src/base64.c (wrap_write, do_encode, main): Change type of
477 parameters and locals, wrap_column, form size_t to uintmax_t.
478 (main): Adjust to use xstrtoumax, accordingly.
480 2006-03-03 Jim Meyering <jim@meyering.net>
482 Don't fail when run from an environment with SHELL not a Bourne
483 shell, e.g. `env SHELL=/bin/csh make check' would fail this test.
484 * tests/dircolors/simple: Invoke each non-failing test with -b.
485 Reported by Michael Stone.
487 2006-02-27 Jim Meyering <jim@meyering.net>
489 * tests/misc/base64: Derive --decode-using tests from the
492 * tests/misc/base64: Factor out a long constant string.
493 Split lines to stay within 80 columns.
495 * tests/misc/Makefile.am (TESTS): Add base64.
496 * tests/misc/base64: Test base64. From Simon Josefsson.
498 * src/base64.c (do_decode): Use correct type for parameter,
499 ignore_garbage: s/size_t/bool/.
501 * src/base64.c: Don't include .h files already included by system.h:
502 <string.h>, <stdlib.h>, <stdbool.h>, <limits.h>, <errno.h>.
503 Include "system.h" before the other lib/*.h header files.
504 Include <sys/types.h> before "system.h".
505 (wrap_write): Remove declaration of unused local, initial_column.
506 (wrap_write): Correct declaration syntax: s/size_t * V/size_t *V/.
508 * README: Add base64 to the list.
510 2006-02-17 Simon Josefsson <jas@extundo.com>
513 * AUTHORS: Mention base64.
515 * man/Makefile.am: Build base64.1.
516 * man/base64.x: New file.
517 * src/Makefile.am (bin_PROGRAMS): Add base64.
518 * src/base64.c: New file.
520 2006-02-25 Eric Blake <ebb9@byu.net>
522 In ls, avoid calling stat for --inode (-i), when possible.
523 * src/pwd.c (NOT_AN_INODE_NUMBER, D_INO): Move to ...
524 * src/system.h: ... here, for use in ...
525 * src/ls.c (main): ... here. Prefer dirent.d_ino to stat when
527 (gobble_file): Add inode argument.
528 (print_dir): Pass inode if available.
529 (usage): Remove inaccuracy.
531 2006-02-23 Jim Meyering <jim@meyering.net>
533 * TODO: Update/correct some obsolete entries.
535 2006-02-20 Paul Eggert <eggert@cs.ucla.edu>
537 * doc/coreutils.texi (join invocation): Mention `sort -k 1b,1'.
538 * src/join.c (usage): Likewise.
539 Documentation problem reported by Philip Kensche.
541 2006-02-20 Eric Blake <ebb9@byu.net>
543 * man/rm.x: Update documentation to match previous patch.
545 2006-02-18 Eric Blake <ebb9@byu.net>
547 New option for rm: --interactive=once (-I).
548 * NEWS: Document it, along with change to rm --interactive.
549 * TODO: Remove entry for implementing rm -I
550 * src/rm.c (INTERACTIVE_OPTION): New enum value.
551 (interactive_type): New enum.
552 (long_opts): Let interactive take an optional argument.
553 (interactive_args, interactive_types): New option arguments.
554 (usage): Document -I, --interactive=WHEN. Use program_name
555 instead of a basename.
556 (main): New -I option, new behavior to --interactive.
557 * tests/rm/interactive-once: New tests.
558 * tests/rm/interactive-always: Ditto.
559 * tests/rm/Makefile.am (TESTS): Run them.
561 2006-02-18 Jim Meyering <jim@meyering.net>
563 * Makefile.maint (sc_two_space_separator_in_usage): Make the regular
564 expression match more of the target lines, e.g., those that start with
565 `-S,' (short option followed by a comma) or that include `=[...]'.
566 Patch by Nicolas François.
567 Fix the four offenders thus exposed:
568 * src/join.c (usage): Use two spaces (not one) to separate the
569 --first-only option string from its description, so help2man formats
570 the derived man page properly.
571 * src/pr.c (usage): Likewise.
572 * src/uniq.c (usage): Likewise.
573 * src/install.c (usage): Likewise.
575 2006-02-15 Jim Meyering <jim@meyering.net>
577 * Makefile.maint (alpha beta major): For `make major', ensure that the
578 version string is of the form N.N[.N]*, where N is one or more digits.
580 2006-02-14 Jim Meyering <jim@meyering.net>
582 * INSTALL: Update from gnulib.
584 2006-02-13 Jim Meyering <jim@meyering.net>
586 * GNUmakefile (all): Emit diagnostics to stderr, not stdout.
588 2006-02-12 Jim Meyering <jim@meyering.net>
590 * Makefile.maint (patch-check): New target.
591 (local-checks-available): Add to the list.
593 2006-02-11 Jim Meyering <jim@meyering.net>
595 * src/c99-to-c89.diff: New file.
596 * src/Makefile.am (EXTRA_DIST): Add c99-to-c89.diff.
598 * .x-po-check: New file, with exclusions so that `make distcheck'
600 * Makefile.am (EXTRA_DIST): Add .x-po-check.
602 rm -r must remove an empty directory, even if it is inaccessible.
603 * src/remove.c (close_preserve_errno): New function.
604 (fd_to_subdirp): Don't print a diagnostic in this function.
605 Do it from the callers instead, unless rmdir succeeds.
606 (remove_cwd_entries, remove_dir): Adjust callers.
607 * tests/rm/empty-inacc: New test for the above.
608 * tests/rm/Makefile.am (TESTS): Add empty-inacc.
609 * NEWS: Mention this bug fix.
610 * tests/rm/rm2: Adjust two expected diagnostics, now that they're
611 a tiny bit less precise: cannot remove `a/1': ... instead of
612 cannot open directory `a/1': ...
614 * Makefile.maint (syntax-check-rules): Automatically derive this
615 list of sc_-prefixed rule names.
617 2006-02-10 Paul Eggert <eggert@cs.ucla.edu>
619 * Makefile.maint (CVS_LIST): Don't assume cvsu is available.
620 (CVS_LIST_EXCEPT): New macro, to simplify exception-processing.
621 Most uses of CVS_LIST changed to use CVS_LIST_EXCEPT.
622 (syntax-check-rules): Bring back sc_changelong. (Hmm, why did it
623 go away? was that an accident?)
624 (sc_cast_of_argument_to_free, sc_cast_of_x_alloc_return_value):
625 (sc_cast_of_alloca_return_value, sc_space_tab, sc_prohibit_atoi_atof):
626 (sc_error_exit_success, sc_file_system, sc_no_if_have_config_h):
627 (sc_system_h_headers, sc_sun_os_names, sc_trailing_blank):
628 (sc_two_space_separator_in_usage, sc_unmarked_diagnostics):
629 (sc_obsolete_symbols, sc_changelog, sc_prohibit_jm_in_m4):
630 (sc_useless_cpp_parens, makefile-check, m4-check, po-check):
631 (author_mark_check, makefile_path_separator_check):
632 Output line numbers, to simplify navigation of Emacs *compilation*
634 (sc_prohibit_atoi_atof, sc_file_system):
635 Rework slightly so that Makefile.maint doesn't get reported as a
636 violation of its own syntax rules.
637 (sc_dd_max_sym_length): Use ifneq to do nothing, instead of doing
638 it at run-time (which didn't work with Bison). Fix a makefile typo,
639 caught by Makefile.maint itself: spaces where a tab should be.
640 (po-check): Check lib/*.[ch] even if not in CVS; used by Bison,
641 which copies from ../gnulib/lib/*.[ch] to lib/*.[ch].
642 Ignore djgpp and man subdirectories, to avoid false matches with
643 Bison and coreutils, respectively. Use sort -u to remove the
644 resulting duplicates.
645 * gnupload: Rework slightly to avoid bogus warning from
646 sc_two_space_separator_in_usage.
648 2006-02-10 Jim Meyering <jim@meyering.net>
650 Use gzip's --rsyncable option only if it's available.
651 * Makefile.maint (gzip_rsyncable): New variable.
654 2006-02-08 Jim Meyering <jim@meyering.net>
656 * Makefile.maint (local-checks-available): Define in terms of
657 the expansion, $(syntax-check-rules), rather than the single,
658 top-level target `syntax-check', so that it's easier to exclude
659 individual rules (via $(local-checks-to-skip)).
660 (tgz-md5, tgz-sha1, ...): Remove now-unused definitions.
662 2006-02-07 Jim Meyering <jim@meyering.net>
664 * src/system.h (!defined O_DIRECT): If O_DIRECTIO is defined (as it
665 is on Tru64), define O_DIRECT to that. Patch From James Lemley.
667 * tests/help-version (expected_failure_status_vdir):
668 Redirect an expected disk-full diagnostic to /dev/null.
670 2006-02-06 Jim Meyering <jim@meyering.net>
672 * src/unexpand.c (usage): Use two spaces (not one) to separate the
673 --first-only option string from its description, so help2man formats
674 the derived man page properly.
675 * src/rm.c (usage): Likewise for --no-preserve-root.
676 * src/chown.c (usage): Likewise.
677 * src/chgrp.c (usage): Likewise.
679 Add a rule to ensure that the above doesn't happen again.
680 * Makefile.maint (sc_two_space_separator_in_usage): New rule.
681 (syntax-check-rules): Add it.
682 * .x-sc_two_space_separator_in_usage: New empty file.
683 * Makefile.am (EXTRA_DIST): Add .x-sc_two_space_separator_in_usage.
685 2006-02-06 Jim Meyering <jim@meyering.net>
687 * src/cp.c (usage): Use two spaces (not one) to separate each
688 option string from its description, so help2man formats the
689 derived man page properly.
690 * src/mv.c (usage): Likewise.
691 Patch from Nicolas François in http://bugs.debian.org/351601.
693 2006-02-04 Jim Meyering <jim@meyering.net>
695 * src/copy.c (copy_internal): cp -RL would fail when encountering
696 the same directory more than once in the hierarchy beneath a single
697 command-line argument. That is legitimate, e.g. when there are
698 two or more symbolic links, each pointing to some directory that
699 would not otherwise be copied. Reported by Christophe LYON.
700 * tests/cp/cp-deref: New file. Test for today's fix.
701 * tests/cp/Makefile.am (TESTS): Add cp-deref.
702 * NEWS: Document this.
704 2006-02-03 Jim Meyering <jim@meyering.net>
706 * configure.ac: Require automake-1.9.6, not 1.8.3.
708 2006-02-01 Paul Eggert <eggert@cs.ucla.edu>
710 * src/od.c (usage): Mention that -t a ignores high order bit.
711 Documentation problem reported by Ed Avis.
713 2006-02-01 Jim Meyering <jim@meyering.net>
715 * src/pwd.c (find_dir_entry): Remove unused local, `ent_sb_valid'.
717 2006-01-30 Paul Eggert <eggert@cs.ucla.edu>
719 * src/head.c (main): Use a better diagnostic when someone uses a
720 trailing numeric option in an invalid way. Problem reported by
722 * src/tail.c (parse_options): Likewise.
724 2006-01-30 Jim Meyering <jim@meyering.net>
726 * man/wc.x: Include `count' keyword in man page synopsis,
727 per suggestion from http://bugs.debian.org/181585.
729 2006-01-24 Paul Eggert <eggert@cs.ucla.edu>
731 * src/df.c (show_dev): If the file system claims to have
732 more available than total blocks, report the number of used
733 blocks as being total - available (a negative number) rather
734 than as garbage. Problem reported by Toralf Foerster.
736 2006-01-24 Jim Meyering <jim@meyering.net>
738 * src/tail.c (tail_forever): Don't exit-nonzero when an attempt
739 to put a regular file in O_NONBLOCK mode fails with EPERM.
740 That happens on Linux (up to 2.6.15) when using tail -f on a file with
741 the append-only attribute. Reported by Dean Gaudet. For details,
742 see http://savannah.gnu.org/bugs/?func=detailitem&item_id=15473.
743 * NEWS: Mention this fix.
744 * tests/tail-2/append-only: New file. Test for the above.
745 * tests/tail-2/Makefile.am (TESTS): Add append-only.
746 * tests/Makefile.am (check-root): Add tail-2/append-only
748 2006-01-21 Jim Meyering <jim@meyering.net>
750 * NEWS: Mention fts-related improvements and bug fixes.
752 2006-01-19 Jim Meyering <jim@meyering.net>
754 * tests/fmt/basic (pfx-1, pfx-2): New tests, to demonstrate the bug
755 reported as http://bugs.debian.org/147577. Forwarded by Thomas Hood.
757 2006-01-18 Jim Meyering <jim@meyering.net>
759 * tests/du/Makefile.am (TESTS): Add long-from-unreadable.
761 2006-01-17 Jim Meyering <jim@meyering.net>
763 Now that fts no longer changes the current working directory, adjust
764 its clients accordingly -- note that du.c uses fts but doesn't need
765 any adjustment, since it doesn't operate on the actual files,
766 but rather just uses the stat buffers provided by fts.
768 * src/chown-core.c: Include "openat.h".
769 Don't include "lchown.h".
770 (restricted_chown): Accept a new parameter, CWD_FD, and use it in
771 calling openat, lchownat, chownat, rather than open, lchown, chown.
773 * src/chmod.c: Include "openat.h".
774 (process_file): Use chmodat (fts->fts_cwd_fd,... in place of chmod (...
776 * tests/du/long-from-unreadable: New test, to exercise one small
779 2006-01-13 Jim Meyering <jim@meyering.net>
781 * tests/Makefile.am (SUBDIRS): Add comments discouraging the
782 addition of new directories under tests/.
784 * tests/acl: Redirect stdin to /dev/null. Otherwise, FreeBSD 5.0's
787 2006-01-12 Jim Meyering <jim@meyering.net>
789 * tests/du/long-sloop: Adjust not to hard-code the expected
790 diagnostic corresponding to ELOOP. Solaris' diagnostic differs
791 from that of GNU libc. Reported by Paul Eggert.
793 * tests/du/long-sloop: Create file at end of symlink chain.
795 * tests/misc/test: New file, with a test for one of the
796 bugs fixed by yesterday's test.c changes.
797 * tests/misc/Makefile.am (TESTS): Add test.
799 2006-01-11 Jim Meyering <jim@meyering.net>
801 * tests/du/long-sloop: New file. Test for today's fts.c bug fix.
802 That bug could make du -L, chgrp -L, or chown -L fail to diagnose
803 a very long sequence of symbolic links (not necessarily a loop).
804 * tests/du/Makefile.am (TESTS): Add long-sloop.
806 2006-01-11 Paul Eggert <eggert@cs.ucla.edu>
808 * src/test.c (test_syntax_error): Append a newline. All callers
809 changed, except for the ones that didn't already append a newline.
810 Bug reported by Eric Blake.
812 2006-01-11 Jim Meyering <jim@meyering.net>
814 * src/system.h (X2NREALLOC): Now that verify_true is no longer
815 void, cast its result to void, to avoid gcc's warning that
816 ``left-hand operand of comma expression has no effect''.
817 (DECIMAL_DIGIT_ACCUMULATE, X2REALLOC): Likewise.
819 2006-01-10 Jim Meyering <jim@meyering.net>
821 * tests/chmod/no-x: Add a test for today's fts.c fix.
823 2006-01-10 Jim Meyering <jim@meyering.net> (tiny change)
825 * src/ls.c (gobble_file): Use DTTOIF only if it's defined.
826 This is necessary for Dragonfly. Patch by Joerg Sonnenberger.
828 2006-01-10 Paul Eggert <eggert@cs.ucla.edu>
830 * src/system.h (X2NREALLOC, X2REALLOC, DECIMAL_DIGIT_ACCUMULATE):
831 Use verify_true instead of verify_expr, to sync with gnulib.
833 2006-01-08 Jim Meyering <jim@meyering.net>
835 * src/date.c (usage): Adjust the formatting of the entries for
836 %::z and %:::z (separate with two spaces, not one) so that help2man
837 formats them properly. Reported by Philip Rowlands.
839 2006-01-06 Paul Eggert <eggert@cs.ucla.edu>
841 * configure.ac (gl_IGNORE_UNUSED_LIBRARIES): Add.
843 2006-01-06 Jim Meyering <jim@meyering.net>
845 * Makefile.maint (copyright-check): Use date +%Y in place of
848 * src/remove.c (rm_1): Remove `static' attribute on local `status'.
849 First off, the attribute should have been `volatile' (not static)
850 to avoid longjmp-related risk of clobber. Secondly, now there is
851 no longer any risk of a local variable being clobbered, so there's
852 no need for any attribute at all.
854 2006-01-05 Jim Meyering <jim@meyering.net>
856 * src/remove.c: Give a few functions the inline attribute.
857 (AD_pop_and_chdir): Use gotos to avoid some duplication.
858 (AD_push): Rewrite an assertion so that the entire computation
859 goes away when assertions are turned off.
861 * src/tail.c (ENOSYS) [!defined ENOSYS]: Don't define here.
862 It's already defined in "system.h".
863 * Makefile.maint: Add a FIXME comment.
865 2006-01-04 Jim Meyering <jim@meyering.net>
867 * ChangeLog: Remove entries from 2005-10-22 and earlier.
868 * ChangeLog-2005: New file, for entries up to version 5.92.
870 2006-01-03 Jim Meyering <jim@meyering.net>
872 * tests/du/no-x: Also allow a slightly different diagnostic -- the
873 one you get when using openat-enabled fts.c and du (coming soon).
874 * tests/chmod/no-x: Likewise.
875 * tests/chgrp/no-x: Likewise.
877 * src/system.h (O_DIRECTORY) [!defined O_DIRECTORY]: Define.
879 2006-01-02 Paul Eggert <eggert@cs.ucla.edu>
881 * src/chown-core.c (RC_do_ordinary_chown): New enum value.
882 (restricted_chown): Return it, if the file cannot be accessed due
883 to EPERM, or if no uid or gid are required, or if the file is
884 neither a directory nor a regular file. Rewrite to avoid gotos.
885 (change_file_owner): Handle RC_do_ordinary_chown case.
886 Rewrite to avoid gotos.
887 * tests/chgrp/basic: Make sure we can change the group of
890 * src/date.c (usage): Explain %g, %G, and %V a bit better.
892 2006-01-02 Jim Meyering <jim@meyering.net>
894 * src/copy.c (set_owner): Correct a comment.
896 * src/tail.c (parse_options): Change warning to say that --retry
897 is useful `mainly' (not `only') when following by name.
898 Reported here: http://bugs.debian.org/273781
900 2006-01-01 Paul Eggert <eggert@cs.ucla.edu>
902 * NEWS: Document that mkfifo and mknod -m no longer set special bits.
903 * src/copy.c: Include lchmod.h.
904 (copy_internal): Use lchmod rather than chmod.
905 * src/cp.c: Include lchmod.h.
906 (re_protect, make_dir_parents_private): Use lchmod rather than chmod.
907 * src/mkdir.c: Include lchmod.h.
908 (usage): Clarify -m's operation.
909 (main): Use lchmod rather than chmod. Don't use lchmod unless the
910 new mode contains bits outside the 777 range.
911 * src/mkfifo.c (usage): Clarify -m's operation.
912 (main): If -m is given, don't invoke chmod; use umask 0 instead.
913 Report an error if -m asks for bits outside the 777 range.
914 * src/mknod.c (usage, main): Likewise.
916 * src/mkdir.c, src/mkfifo.c, src/mknod.c: Undo 2005-12-19 changes.
918 2005-12-27 Jim Meyering <jim@meyering.net>
920 * Makefile.maint (sc_obsolete_symbols): Prohibit use of O_NDELAY.
921 (sc_prohibit_assert_without_use): New rule.
922 (syntax-check-rules): Add it to the list.
923 * .x-sc_prohibit_assert_without_use: New empty file.
924 * Makefile.am (EXTRA_DIST): Add it.
926 * Makefile.maint (CVS_LIST): Define in terms of $(srcdir).
928 * cp.c, df.c, link.c, mknod.c, nice.c, sleep.c, unlink.c:
929 Don't include <assert.h>; it wasn't used.
931 2005-12-26 Paul Eggert <eggert@cs.ucla.edu>
933 * src/chown-core.c (restricted_chown):
934 Don't try O_WRONLY unless O_RDONLY failed wth EACCES.
935 * src/remove.c (fd_to_subdirp): Open with O_DIRECTORY | O_NOCTTY
936 | O_NOFOLLOW too, for consistency with other dir-openers.
937 Use POSIX-preferred O_NONBLOCK rather than O_NDELAY.
938 (is_empty_dir): Likewise.
939 * src/shred.c (wipename): Likewise. Don't bother trying to open
940 dir for writing, since POSIX prohibits it.
942 2005-12-22 Jim Meyering <jim@meyering.net>
944 * tests/help-version: Redirect stderr to /dev/full, to suppress
945 write error diagnostic.
947 2005-12-19 Jim Meyering <jim@meyering.net>
949 * src/mkdir.c, src/mknod.c, src/mkfifo.c (main)
950 Avoid a minor race condition when `-m MODE' is specified, by using
951 open, fchown, and close rather than just chown. To do that reliably --
952 even with an overly restrictive umask -- ensure that each mkdir,
953 mknod and mkfifo call uses a mode including at least owner-read access.
954 * src/mknod.c (main): When `-m MODE' is specified, exit nonzero if
955 the subsequent chown (or equivalent open,fchown,close) fails.
956 * tests/misc/mknod: New tests.
957 * tests/misc/Makefile.am (TESTS): Add mknod.
959 2005-12-17 Jim Meyering <jim@meyering.net>
961 * src/remove.c (is_empty_dir): Open with O_NDELAY, so we don't hang,
962 e.g., on a named pipe.
963 (OPEN_NO_FOLLOW_SYMLINK): Remove definition. Use O_NOFOLLOW in
964 place of all uses, since it is guaranteed (system.h) to be defined.
966 2005-12-05 Andreas Gruenbacher <agruen@suse.de>
968 Add POSIX ACL support
969 * src/ls.c: Switch back from HAVE_ACL to USE_ACL: The acl() syscall
970 is no requirement for ACL support; particularly, it does not exist
971 on systems that have POSIX ACLs.
972 * src/copy.h (cp_option_init) [umask_kill]: Remove member.
973 * src/cp.c (umask_kill): With default acls, the umask is not to be
974 applied. Remove umask_kill, don't change the process umask, and let
975 the kernel apply the umask where appropriate.
976 * src/cp.c (make_dir_parents_private): Fix logic for POSIX ACLs.
977 * src/copy.c (get_dest_mode): Remove; it is obsolete after removing
979 (copy_reg, copy_internal): Use copy_acl and set_acl
980 instead of fchown/chown. Fix the logic for POSIX ACLs.
981 (chown_succeded): Remove; we now always copy acls and
982 preserve S_ISUID, S_ISGID, and S_ISVTX when needed, no matter if we
983 did a chown before or not.
984 * src/mv.c, src/install.c (cp_option_init): Don't set umask_kill member.
985 * src/Makefile.am (dir_LDADD, ls_LDADD, vdir_LDADD, cp_LDADD,
986 mv_LDADD, ginstall_LDADD): On systems with an ACL library, arrange
987 to link with it via $(LIB_ACL), for the utilities that need it.
989 2005-12-16 Paul Eggert <eggert@cs.ucla.edu>
991 * src/remove.c (OPENAT_CWD_RESTORE__REQUIRE): Remove.
992 (OPENAT_CWD_RESTORE__ALLOW_FAILURE): Likewise.
993 (fd_to_subdirp): Remove openat_cwd_restore_allow_failure arg; its
994 value is now signified by whether cwd_errno is null.
995 (fd_to_subdirp, remove_dir, rm_1); Change cwd failure indicator from
996 pointer-to-bool to pointer-to-errno-value. All callers changed.
997 (rm_1): Don't bother setting a local cwd failure flag and then
998 ORing it into the caller's. Just set the caller's.
999 (rm): Use cwd failure errno value to print a slightly-better
1002 2005-12-15 Jim Meyering <jim@meyering.net>
1004 * src/stat.c (print_it): Properly handle a backslash at the
1005 end of a --printf format string. Reported by Paul Eggert.
1006 * tests/misc/stat-printf (end-bs): Add a test for the above.
1008 2005-12-15 Paul Eggert <eggert@cs.ucla.edu>
1010 * tests/acl: Port to pre-POSIX shells like Solaris 8 /bin/sh.
1011 Don't assume /etc/passwd contains user names; use 'id' instead.
1013 2005-12-15 Jim Meyering <jim@meyering.net>
1015 stat: revert behavior of --format=FMT (-c)
1016 stat: add new option: --printf=FMT
1017 * NEWS: Mention this.
1018 * src/stat.c (isodigit, octtobin, hextobin): Define.
1019 (PRINTF_OPTION): Define.
1020 (interpret_backslash_escapes, trailing_delim): New globals.
1021 (usage): Document them. Alphabetize on long option names.
1022 (print_esc_char): New function.
1023 (print_it): Rewrite, in order to handle backslash escapes.
1024 (main): Handle new option. Set globals for --format, too.
1026 * tests/misc/stat-printf: Test --printf and --format.
1027 * tests/misc/Makefile.am (TESTS): Add stat-printf.
1029 2005-12-14 Paul Eggert <eggert@cs.ucla.edu>
1031 * NEWS: sort now reports incompatible options.
1032 * src/sort.c (incompatible_options, check_ordering_compatibility):
1034 (main): Use them. Don't bother with a usage message for
1035 "sort -c a b", for consistency with other error diagnostics.
1036 * tests/sort/Test.pm (incompat1, incompat2, incompat3, incompat4):
1039 * src/cat.c (main): Undo previous change. close_stdout already
1040 does the check, so the previous change wasn't necessary.
1042 2005-12-13 Paul Eggert <eggert@cs.ucla.edu>
1044 * src/cat.c (main): Check for close (STDOUT_FILENO) failure.
1046 2005-12-12 Paul Eggert <eggert@cs.ucla.edu>
1048 Install a more-conservative approach for sort -R. It's the
1049 same basic idea as the existing code, except it uses the full ISAAC
1050 approach (called the "more kosher" approach in the existing comments).
1051 This makes "sort -R" quite a bit slower (about a factor of 2 on my
1052 little tests involving 10000 lines on a 2.4 GHz P4), but I think it's
1053 better to be conservative here at first, and review any performance
1054 improvements carefully.
1055 * .x-sc_require_config_h: Add src/rand-isaac.c.
1056 * src/rand-isaac.h: Remove. All uses now simply include rand-isaac.c.
1057 * src/Makefile.am (noinst_HEADERS): Remove rand-isaac.h.
1058 (shred_SOURCES, sort_SOURCES): Remove.
1059 (EXTRA_DIST): Add rand-isaac.c.
1060 * src/rand-isaac.c: Revert to what used to be in shred.c, without
1061 changing it to allow for varying numbers of words in the state.
1062 Alter so that we include rand-isaac.c directly rather than
1063 compiling it and linking to it. Don't include config.h or
1064 system.h; that's the includer's responsibility.
1065 Omit functions that are specific to shred.
1066 (ISAAC_LOG, ISAAC_WORDS, ISAAC_BYTES, struct isaac_state, ind):
1067 (isaac_step, struct irand_state):
1068 Resurrect these, with the same defns that used to be in shred.c.
1069 (ISAAC_SIZE, isaac_new, isaac_copy): Remove.
1070 (isaac_refill, isaac_seed_start, isaac_seed_data, irand_init, irand32):
1072 (struct isaac_state, isaac_refill, isaac_mix, isaac_init):
1073 (isaac_seed_start, isaac_seed_data, isaac_seed_finish, isaac_seed):
1074 (irand_init, irand32, irand_mod):
1075 Number of words is constant again.
1076 (struct irand_state, irand_init, irand32, irand_mod): Move to shred.c.
1077 * src/shred.c: Include rand-isaac.c rather than rand-isaac.h.
1078 * src/sort.c: Likewise.
1079 * src/shred.c (fillrand, dopass, main): Undo previous change.
1080 (struct irand_state, irand_init, irand32, irand_mod): Moved back here,
1082 * src/sort.c: Don't include md5.h; it wasn't needed.
1083 (struct keyfield): Rename random_hash to random, for consistency
1084 with the other member names. All uses changed.
1085 (usage): Tweak wording to mention STRING for --seed option.
1086 (short_options): Rorder for consistency with other programs.
1087 (rand_state): Now a struct, not a pointer to one. All uses changed.
1088 (HASH_WORDS, HASH_SIZE): Remove.
1089 (get_hash): Remove comments around resbuf size, since we can assume C89.
1090 Use a "more-kosher" (but slower) approach of invoking isaac_refill.
1091 (keycompare): Adjust to the new get_hash.
1093 (badfieldspec): Omit recently-introduced comment; it isn't needed.
1094 (main): Don't set need_random simply because gkey has it set; that
1095 doesn't necessarily mean we'll need random numbers.
1096 Redo seeding to match new get_hash approach.
1098 2005-12-10 Jim Meyering <jim@meyering.net>
1100 * src/Makefile.am (noinst_HEADERS): Add rand-isaac.h.
1102 Avoid shred segfault on 64-bit systems.
1103 * src/rand-isaac.c (isaac_refill): Don't try to negate a
1104 local of type uint32_t. Make the local an `int' instead.
1106 * NEWS: Mention sort's new options.
1108 * src/rand-isaac.c (isaac_mix): Declare to be static.
1109 Mark all other functions as `extern' so the tight-scope
1110 part of `make distcheck' passes once again.
1111 * src/rand-isaac.h (isaac_mix): Remove declaration.
1113 * src/sort.c (get_hash): Change position of `*' in parameter
1114 type to conform with convention.
1115 (main): Split a long line so it fits in 80 columns.
1116 (keycompare): Remove stray SPACE before TAB that was
1117 causing `make distcheck' to fail.
1119 * src/shred.c: Don't include gethrxtime.h. No longer needed.
1121 * tests/misc/sort-rand: New file: basic tests for the new options.
1122 * tests/misc/Makefile.am (TESTS): Add sort-rand.
1124 2005-12-10 Frederik Eaton <frederik@ofb.net>
1126 * src/Makefile.am (sort_LDADD): Add $(LIB_GETHRXTIME).
1127 (shred_SOURCES, sort_SOURCES): New macros, so we compile rand-isaac.c.
1128 * src/rand-isaac.c: New file, containing ISAAC code that was in shred.c.
1129 Make state size runtime-configurable.
1130 (isaac_new, isaac_copy): New functions.
1131 * src/rand-isaac.h: New file.
1132 * src/shred.c: Include rand-isaac.h. Move ISAAC code to rand-isaac.c.
1133 (fillrand, main): Adjust to the fact that the state size is now
1134 runtime-configurable.
1135 * src/sort.c (short_options, long_options, WORDS, keycompare, main):
1136 (usage): Add options --random-sort and --seed to implement a random
1138 Include md5.h and rand-isaac.h.
1139 (get_hash): New function.
1140 (rand_state): New var.
1141 (HASH_WORDS, HASH_SIZE): New macros.
1143 2005-12-09 Paul Eggert <eggert@cs.ucla.edu>
1145 * tests/dd/misc: Add test for dd iflags=noatime.
1147 2005-12-09 Jim Meyering <jim@meyering.net>
1149 * src/sort.c (usage): Mention white space vs -b and -t options.
1152 2005-12-09 Eric Blake <ebb9@byu.net>
1154 * src/test.c (main): Fix misleading comment.
1156 2005-12-07 Paul Eggert <eggert@cs.ucla.edu>
1158 * NEWS: Mention dd's new noatime flag.
1159 * src/system.h (O_NOATIME): Define to 0 if not already defined.
1160 * src/dd.c (flags, usage): Add support for noatime flag.
1162 2005-12-07 Jim Meyering <jim@meyering.net>
1164 Distribute the cvsu script, used only by `make syntax-check'.
1165 * Makefile.am (EXTRA_DIST): Add build-aux/cvsu.
1166 * Makefile.maint (CVS_LIST): Use build-aux/cvsu, now that we
1167 distribute a copy of this script.
1168 * .x-sc_unmarked_diagnostics: Add build-aux/cvsu.
1170 * tests/mv/acl: exit-77 before the trap, not after, if we fail
1171 to create a temporary directory on another partition.
1172 From Andreas Gruenbacher.
1174 2005-12-06 Tomas Pospisek <tpo@sourcepole.ch> (tiny change)
1176 * man/basename.x: Cross-reference to dirname and readlink.
1177 * man/dirname.x: Cross-reference to basename and readlink.
1179 2005-12-05 Andreas Gruenbacher
1181 * src/copy.c [!HAVE_FCHOWN]: Define fchown(...) to -1.
1182 (set_owner, preserve_author): New functions, factored out of copy_reg.
1183 (copy_reg): Use them.
1184 (copy_internal): Use them here, too.
1186 2005-12-04 Jim Meyering <jim@meyering.net>
1188 * src/sleep.c (usage): Say what happens with two or more arguments.
1189 Suggested by Justin Pryzby.
1191 * src/uptime.c (print_uptime): Move decl of `upsecs' into scope
1194 2005-12-03 Jim Meyering <jim@meyering.net>
1196 * src/rm.c (long_opts): Change the name of each undocumented, for-
1197 testing-only option to start with `-', so that it cannot render
1198 ambiguous any prefix it happens to share with some other option name.
1199 Problem reported by Eric Blake.
1200 * src/head.c (long_options): Likewise.
1201 * src/tail.c (long_options): Likewise.
1203 * tests/misc/head-elide-tail: Update uses of undocumented, for-
1204 testing-only --presume* options to start with `---'.
1205 * tests/rm/dangling-symlink: Likewise.
1206 * tests/rm/dir-no-w: Likewise.
1207 * tests/rm/isatty: Likewise.
1209 2005-11-30 Jim Meyering <jim@meyering.net>
1211 * Makefile.maint: Add a comment about cvsu.
1213 2005-11-25 Paul Eggert <eggert@cs.ucla.edu>
1215 * NEWS: df updates for "none", "proc", inaccessible file systems.
1216 * src/df.c (show_point): Ignore inaccessible file systems.
1217 (usage): -a includes dummy file systems, not size-0 file systems.
1219 * src/od.c (unsigned_long_long_int): Renamed from ulonglong_t,
1220 to avoid collision with POSIX name space. All uses changed.
1222 2005-11-24 Jim Meyering <jim@meyering.net>
1224 * tests/Makefile.am (EXTRA_DIST): Add acl to the list.
1225 * tests/acl: Add `$0: ' prefix to diagnostics.
1227 * .x-sc_require_config_h: Add lib/buffer-lcm.c to the list.
1229 2005-11-23 Paul Eggert <eggert@cs.ucla.edu>
1231 * src/copy.c: Improve performance a bit by optimizing away
1232 unnecessary system calls and going to a block size of at least
1233 8192 (on normal hosts, anyway). This improved performance 5% on my
1234 Debian stable host (2.4.27 kernel, x86, copying from root
1235 ext3 file system to itself).
1236 Include "buffer-lcm.h".
1237 (copy_reg): Omit last argument. All callers changed.
1238 Use xmalloc to allocate rather than trusting alloca
1239 (which is unwise with large block sizes).
1240 Declare locals more locally, if possible.
1241 Use uintptr_t words instead of int words, for a bit more speed
1242 when looking for null blocks on 64-bit hosts.
1243 Optimize away reads of zero bytes on regular files.
1244 In the typical case, insist on 8 KiB buffers, at least.
1245 Avoid unnecessary extra call to fstat when checking for sparse files.
1246 Avoid now-unnecessary cast to off_t, and "0L".
1247 Avoid unnecessary test of *new_dst when checking for same owner
1250 2005-11-22 Paul Eggert <eggert@cs.ucla.edu>
1252 * src/remove.c (rm): Don't assume C99 for-loop syntax.
1254 2005-11-22 Jim Meyering <jim@meyering.net>
1256 * src/remove.c (AD_push): Remove debugging cruft.
1258 * tests/rm/unread2 (rm): Change expected diagnostic,
1259 `cannot open directory' to `cannot remove', to align with
1261 * tests/rm/rm2: Ensure that rm now continues removing entries
1262 even after certain types of failure.
1264 * src/remove.c: Rewrite. Now, this module is reentrant on systems
1265 that provide openat (Solaris), and on systems like Linux+procfs
1266 where our openat emulation code is reentrant. This also fixes a
1267 few low-probability leaks and eliminates some code that could,
1268 in very unusual circumstances, cause rm() (via a callee) to exit.
1269 * NEWS: Mention this.
1271 * configure.ac: Put copyright dates all on one line so the
1272 emacs function that updates them works properly.
1274 2005-11-18 Paul Eggert <eggert@cs.ucla.edu>
1276 * configure.ac (AM_PROG_CC_C_O): Add. Needed for CVS Automake.
1277 Problem reported by Eric Blake.
1278 (AC_PROG_CC_STDC): Use this instead of AC_PROG_CC, so that
1279 we get a standard-conforming compiler. This relies on the new
1280 m4/c.m4 file. Note that it's a bit tricky, since c.m4 doesn't
1281 define AC_PROG_CC_STDC; we are relying on Autoconf 2.59 internals.
1282 m4/c.m4 can go away with Autoconf 2.60 comes out.
1284 2005-11-17 Jim Meyering <jim@meyering.net>
1286 * src/remove.c (AD_mark_helper): Make a `char *' parameter `const'.
1287 (AD_mark_current_as_unremovable): Likewise, but for a local.
1290 * tests/mv/acl: Let traps handle removing temporary directories.
1292 Expect acl-related tests to fail, until the corresponding
1293 patches are committed.
1294 * tests/mv/Makefile.am (XFAIL_TESTS): Add acl.
1295 * tests/cp/Makefile.am (XFAIL_TESTS): Likewise.
1297 ACL tests, from Andreas Gruenbacher.
1298 * tests/acl, tests/mv/acl, tests/cp/acl: New files.
1299 * tests/mv/Makefile.am (TESTS): Add acl.
1300 * tests/cp/Makefile.am (TESTS): Add acl.
1302 * src/ls.c (basename_is_dot_or_dotdot): Correct wording in comment.
1304 2005-11-16 Paul Eggert <eggert@cs.ucla.edu>
1306 * NEWS: Improve quality of ln's diagnostics.
1307 * src/ln.c (do_link, usage): Likewise.
1308 (do_link): Don't use alloca on a buffer of unbounded size.
1310 2005-11-16 Jim Meyering <jim@meyering.net>
1312 * tests/cp/fail-perm: Accommodate HPUX. It appears to fail
1313 with EACCES rather than EPERM. Reported by Peter O'Gorman here:
1314 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/5766
1315 This also affects AIX 4.3.3, according to Ralf Wildenhues, in
1316 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
1318 2005-11-14 Jim Meyering <jim@meyering.net>
1320 * NEWS (sort): Mention consequences of today's mkstemp-safer.c fix.
1322 2005-11-13 Jim Meyering <jim@meyering.net>
1324 * announce-gen: Accept new option, --gpg-key-id=ID and
1325 emit a blurb telling how to use the .sig files.
1326 * Makefile.cfg (gpg_key_ID): Define.
1327 * Makefile.maint (announcement): Use new option and key.
1329 Require that most .c files include <config.h>.
1330 * Makefile.maint (sc_require_config_h): New rule.
1331 (syntax-check-rules): Add it.
1332 * .x-sc_require_config_h: New file listing exceptions to the
1333 above rule. Some are legit, others are simply grandfathered in.
1334 * Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h here, too.
1336 2005-11-12 Jim Meyering <jim@meyering.net>
1338 * src/checksum.h, src/md5.c, src/sha1sum.c: Remove now-unused files.
1340 2005-11-11 Jim Meyering <jim@meyering.net>
1342 * NEWS: Mention `readlink -f' bug fix in 5.3.0 news.
1343 Mention new readlink options in 5.3.0's `New features' section.
1344 Spotted by Thomas Hood.
1346 2005-11-08 Jim Meyering <jim@meyering.net>
1348 * NEWS: Merge in changes from b5_9x branch.
1350 2005-11-08 Paul Eggert <eggert@cs.ucla.edu>
1352 * NEWS: ls now defaults to --time-style='locale', which in turn acts
1353 like --time-style='posix-long-iso' if the locale settings are messed up.
1354 * src/ls.c (decode_switches): Implement this.
1356 2005-11-08 Jim Meyering <jim@meyering.net>
1358 * tests/du/2g: s/expensive/very expensive/ in a comment.
1361 2005-10-17 Eric Blake <ebb9@byu.net>
1363 * src/ls.c (usage): Fix descriptions of --sort, --time.
1364 Reported by Vitaly A. Ostanin.
1366 2005-11-04 Paul Eggert <eggert@cs.ucla.edu>
1368 * src/ln.c: Include filenamecat.c.
1369 (FILE_BASENAME_CONCAT): Remove.
1370 (do_link): Remove last arg DEST_IS_DIR. All callers changed.
1371 (main): Use file_name_concat, base_name, and strip_trailing_slashes
1372 instead of FILE_BASENAME_CONCAT. This simplifies the code, and avoids
1375 2005-11-04 Jim Meyering <jim@meyering.net>
1377 * src/du.c (process_file): Don't overflow for files of size >= 2^31
1378 on systems with stat.st_blocks of a signed 32-bit type.
1379 This bug causes trouble on some AIX 5.1 systems.
1380 Report and trivial patch from Paul Townsend:
1381 <http://lists.gnu.org/archive/html/bug-coreutils/2005-11/msg00033.html>
1382 * NEWS: Mention this.
1384 * tests/du/2g: New (very-expensive) test for the above-fixed bug.
1385 * tests/du/Makefile.am (TESTS): Add it here.
1386 * tests/very-expensive: New file.
1387 * tests/Makefile.am (EXTRA_DIST): Add it here.
1388 * tests/cp/perm: Mark this test as `very-expensive', too.
1390 2005-11-02 Paul Eggert <eggert@cs.ucla.edu>
1392 * NEWS: Mention that rm -d and maybe ln -d are scheduled for
1394 * src/remove.h (struct rm_options): Remove unlink_dirs. All uses
1396 * src/rm.c (usage): Don't mention rm -d.
1398 2005-11-02 Jim Meyering <jim@meyering.net>
1400 * tests/dd/skip-seek: Fix typo in comment: s/fileutils/coreutils.
1401 From Andreas Schwab.
1403 * tests/dd/unblock-sync: Redirect stderr to /dev/null so the
1404 `M+N records in/out' lines don't pollute `make check' output.
1406 * tests/dd/skip-seek (sk-seek4): New test, to exercise the bug
1407 fixed on 2005-10-31. This test uses the new, IN_PIPE specifier.
1408 * tests/Coreutils.pm: Accept a new type of input specifier: IN_PIPE,
1409 to indicate that the input file should be piped into the command
1410 under test (via `cat FILE | $prog ...').
1412 * src/remove.c (remove_entry): Emit a better diagnostic when rm
1413 (without -r) fails to remove a directory on a non-Linux system.
1414 This change affects only newer Solaris systems (with priv_*
1415 functions like priv_allocset). Reported by Keith Thompson.
1417 * tests/rm/dir-nonrecur: New file/test for the above fix.
1418 * tests/rm/Makefile.am (TESTS): Add dir-nonrecur.
1420 2005-11-01 Paul Eggert <eggert@cs.ucla.edu>
1422 * NEWS: "tail -c 2 FILE" and "touch 0101000000" now operate as
1423 POSIX 1002.1-2001 requires.
1424 * src/tail.c (parse_obsolete_option): Implement this.
1425 Problem reported by Vincent Lefevre.
1426 * src/touch.c (main): Pass PDS_PRE_2000 to posixtime.
1427 * tests/tail/Test.pm (c-2, c-2-minus, c2, c2-minus): New tests.
1428 (test_vector): Add special cases for _POSIX2_VERSION, and
1429 regularize the old ones a bit.
1430 * tests/touch/obsolescent: Add y2000 test.
1432 2005-10-31 Paul Eggert <eggert@cs.ucla.edu>
1434 * src/dd.c (skip): Fix off-by-one error reported by
1435 Theodoros V. Kalamatianos.
1437 2005-10-30 Paul Eggert <eggert@cs.ucla.edu>
1439 * tests/mkdir/p-3: Require that the test be run as non-root.
1440 Problem and trivial fix reported by Theodoros V. Kalamatianos.
1442 2005-10-28 Paul Eggert <eggert@cs.ucla.edu>
1444 * src/ln.c (FILE_BASENAME_CONCAT): Omit unnecessary slashes in the
1445 boundary between DEST and SOURCE in the result.
1447 2005-10-26 Dmitry V. Levin <ldv@altlinux.org>
1449 * src/md5sum.c (main) [!O_BINARY]: Changed default read mode
1450 back to text, to sync with documentation and for backwards
1453 2005-10-25 Jim Meyering <jim@meyering.net>
1455 * tests/dircolors/simple (other-wr): Add an explicit test for
1456 the dircolors bug (NULL-dereference) fixed yesterday.
1458 2005-10-24 Jim Meyering <jim@meyering.net>
1460 * src/tac.c (tac_file): When determining whether a file is seekable,
1461 also test whether it is a tty. Using only the lseek-based test would
1462 give a false positive on Solaris. Reported by Peter Fales.
1464 2005-10-24 Dmitry V. Levin <ldv@altlinux.org>
1466 * tests/install/d-slashdot: New test, for "install -d" failure.
1467 * tests/install/Makefile.am (TESTS): Add d-slashdot.
1468 * tests/mkdir/p-slashdot: New test, for "mkdir -p" failure.
1469 * tests/mkdir/Makefile.am (TESTS): Add p-slashdot.
1471 2005-10-24 Jim Meyering <jim@meyering.net>
1473 * src/dircolors.c (ls_codes): Add missing comma.
1474 Anonymous report and patch from
1475 http://savannah.gnu.org/bugs/?func=detailitem&item_id=14849
1477 * src/dircolors.c: Add compile-time assertion that the slack_codes
1478 and ls_codes arrays have the same number of elements. This would
1479 have prevented the above-fixed bug.
1481 * src/expand.c (parse_tab_stops): Add a comment to make this function
1482 identical to the one in unexpand.c.
1483 * src/unexpand.c (parse_tab_stops): Adjust syntax to make this function
1484 identical to the one in expand.c.
1486 * src/expand.c (next_file): Don't assume fopen cannot return stdin.
1488 2005-10-23 Jim Meyering <jim@meyering.net>
1490 * src/md5sum.c (digest_check, main): Use ptr_align rather than
1491 a dangerous pointer-value-to-`unsigned' cast.
1492 * NEWS: mention the new sha* programs.
1493 * AUTHORS: Add new sha* programs.
1495 2005-08-28 David Madore <david.madore@ens.fr>
1497 Add new programs: sha224sum, sha256sum, sha384sum, sha512sum.
1498 * README: Add their names to the list.
1499 * src/md5sum.c: Provide framework for computing sha-2 hashes.
1500 * src/Makefile.am (sha224sum, sha256sum, sha384sum, sha512sum):
1501 Rules for compiling sha-2 utilities
1502 (noinst_HEADERS): Remove checksum.h.
1503 * man/sha512sum.x, man/sha384sum.x, man/sha256sum.x, man/sha224sum.x:
1505 * man/Makefile.am (dist_man_MANS): Add the corresponding .1 names.
1506 (sha224sum.1, sha256sum.1, sha384sum.1, sha512sum.1): New dependencies.
1507 * tests/misc/sha224sum, tests/misc/sha256sum: New files.
1508 * tests/misc/sha384sum, tests/misc/sha512sum: New files.
1509 * tests/misc/Makefile.am (TESTS): Add new sha224sum, sha256sum,
1510 sha384sum, sha512sum test scripts here rather that each in its
1513 2005-08-28 David Madore <david.madore@ens.fr>
1515 * tests/sha1sum/basic-1 (million-a): Add the "million a's" test (one
1516 of the FIPS test vectors).
1518 2005-10-23 Jim Meyering <jim@meyering.net>
1520 * configure.ac: Use 6.0-cvs as the version string.
1521 * NEWS: Adjust accordingly.