1 2006-02-18 Eric Blake <ebb9@byu.net>
5 New option for rm: --interactive=once (-I).
6 * NEWS: Document it, along with change to rm --interactive.
7 * TODO: Remove entry for implementing rm -I
8 * src/rm.c (INTERACTIVE_OPTION): New enum value.
9 (interactive_type): New enum.
10 (long_opts): Let interactive take an optional argument.
11 (interactive_args, interactive_types): New option arguments.
12 (usage): Document -I, --interactive=WHEN. Use program_name
13 instead of a basename.
14 (main): New -I option, new behavior to --interactive.
15 * tests/rm/interactive-once: New tests.
16 * tests/rm/interactive-always: Ditto.
17 * tests/rm/Makefile.am (TESTS): Run them.
19 2006-02-18 Jim Meyering <jim@meyering.net>
21 * Makefile.maint (sc_two_space_separator_in_usage): Make the regular
22 expression match more of the target lines, e.g., those that start with
23 `-S,' (short option followed by a comma) or that include `=[...]'.
24 Patch by Nicolas François.
25 Fix the four offenders thus exposed:
26 * src/join.c (usage): Use two spaces (not one) to separate the
27 --first-only option string from its description, so help2man formats
28 the derived man page properly.
29 * src/pr.c (usage): Likewise.
30 * src/uniq.c (usage): Likewise.
31 * src/install.c (usage): Likewise.
33 2006-02-15 Jim Meyering <jim@meyering.net>
35 * Makefile.maint (alpha beta major): For `make major', ensure that the
36 version string is of the form N.N[.N]*, where N is one or more digits.
38 2006-02-14 Jim Meyering <jim@meyering.net>
40 * INSTALL: Update from gnulib.
42 2006-02-13 Jim Meyering <jim@meyering.net>
44 * GNUmakefile (all): Emit diagnostics to stderr, not stdout.
46 2006-02-12 Jim Meyering <jim@meyering.net>
48 * Makefile.maint (patch-check): New target.
49 (local-checks-available): Add to the list.
51 2006-02-11 Jim Meyering <jim@meyering.net>
53 * src/c99-to-c89.diff: New file.
54 * src/Makefile.am (EXTRA_DIST): Add c99-to-c89.diff.
56 * .x-po-check: New file, with exclusions so that `make distcheck'
58 * Makefile.am (EXTRA_DIST): Add .x-po-check.
60 rm -r must remove an empty directory, even if it is inaccessible.
61 * src/remove.c (close_preserve_errno): New function.
62 (fd_to_subdirp): Don't print a diagnostic in this function.
63 Do it from the callers instead, unless rmdir succeeds.
64 (remove_cwd_entries, remove_dir): Adjust callers.
65 * tests/rm/empty-inacc: New test for the above.
66 * tests/rm/Makefile.am (TESTS): Add empty-inacc.
67 * NEWS: Mention this bug fix.
68 * tests/rm/rm2: Adjust two expected diagnostics, now that they're
69 a tiny bit less precise: cannot remove `a/1': ... instead of
70 cannot open directory `a/1': ...
72 * Makefile.maint (syntax-check-rules): Automatically derive this
73 list of sc_-prefixed rule names.
75 2006-02-10 Paul Eggert <eggert@cs.ucla.edu>
77 * Makefile.maint (CVS_LIST): Don't assume cvsu is available.
78 (CVS_LIST_EXCEPT): New macro, to simplify exception-processing.
79 Most uses of CVS_LIST changed to use CVS_LIST_EXCEPT.
80 (syntax-check-rules): Bring back sc_changelong. (Hmm, why did it
81 go away? was that an accident?)
82 (sc_cast_of_argument_to_free, sc_cast_of_x_alloc_return_value):
83 (sc_cast_of_alloca_return_value, sc_space_tab, sc_prohibit_atoi_atof):
84 (sc_error_exit_success, sc_file_system, sc_no_if_have_config_h):
85 (sc_system_h_headers, sc_sun_os_names, sc_trailing_blank):
86 (sc_two_space_separator_in_usage, sc_unmarked_diagnostics):
87 (sc_obsolete_symbols, sc_changelog, sc_prohibit_jm_in_m4):
88 (sc_useless_cpp_parens, makefile-check, m4-check, po-check):
89 (author_mark_check, makefile_path_separator_check):
90 Output line numbers, to simplify navigation of Emacs *compilation*
92 (sc_prohibit_atoi_atof, sc_file_system):
93 Rework slightly so that Makefile.maint doesn't get reported as a
94 violation of its own syntax rules.
95 (sc_dd_max_sym_length): Use ifneq to do nothing, instead of doing
96 it at run-time (which didn't work with Bison). Fix a makefile typo,
97 caught by Makefile.maint itself: spaces where a tab should be.
98 (po-check): Check lib/*.[ch] even if not in CVS; used by Bison,
99 which copies from ../gnulib/lib/*.[ch] to lib/*.[ch].
100 Ignore djgpp and man subdirectories, to avoid false matches with
101 Bison and coreutils, respectively. Use sort -u to remove the
102 resulting duplicates.
103 * gnupload: Rework slightly to avoid bogus warning from
104 sc_two_space_separator_in_usage.
106 2006-02-10 Jim Meyering <jim@meyering.net>
108 Use gzip's --rsyncable option only if it's available.
109 * Makefile.maint (gzip_rsyncable): New variable.
112 2006-02-08 Jim Meyering <jim@meyering.net>
114 * Makefile.maint (local-checks-available): Define in terms of
115 the expansion, $(syntax-check-rules), rather than the single,
116 top-level target `syntax-check', so that it's easier to exclude
117 individual rules (via $(local-checks-to-skip)).
118 (tgz-md5, tgz-sha1, ...): Remove now-unused definitions.
120 2006-02-07 Jim Meyering <jim@meyering.net>
122 * src/system.h (!defined O_DIRECT): If O_DIRECTIO is defined (as it
123 is on Tru64), define O_DIRECT to that. Patch From James Lemley.
125 * tests/help-version (expected_failure_status_vdir):
126 Redirect an expected disk-full diagnostic to /dev/null.
128 2006-02-06 Jim Meyering <jim@meyering.net>
130 * src/unexpand.c (usage): Use two spaces (not one) to separate the
131 --first-only option string from its description, so help2man formats
132 the derived man page properly.
133 * src/rm.c (usage): Likewise for --no-preserve-root.
134 * src/chown.c (usage): Likewise.
135 * src/chgrp.c (usage): Likewise.
137 Add a rule to ensure that the above doesn't happen again.
138 * Makefile.maint (sc_two_space_separator_in_usage): New rule.
139 (syntax-check-rules): Add it.
140 * .x-sc_two_space_separator_in_usage: New empty file.
141 * Makefile.am (EXTRA_DIST): Add .x-sc_two_space_separator_in_usage.
143 2006-02-06 Jim Meyering <jim@meyering.net>
145 * src/cp.c (usage): Use two spaces (not one) to separate each
146 option string from its description, so help2man formats the
147 derived man page properly.
148 * src/mv.c (usage): Likewise.
149 Patch from Nicolas François in http://bugs.debian.org/351601.
151 2006-02-04 Jim Meyering <jim@meyering.net>
153 * src/copy.c (copy_internal): cp -RL would fail when encountering
154 the same directory more than once in the hierarchy beneath a single
155 command-line argument. That is legitimate, e.g. when there are
156 two or more symbolic links, each pointing to some directory that
157 would not otherwise be copied. Reported by Christophe LYON.
158 * tests/cp/cp-deref: New file. Test for today's fix.
159 * tests/cp/Makefile.am (TESTS): Add cp-deref.
160 * NEWS: Document this.
162 2006-02-03 Jim Meyering <jim@meyering.net>
164 * configure.ac: Require automake-1.9.6, not 1.8.3.
166 2006-02-01 Paul Eggert <eggert@cs.ucla.edu>
168 * src/od.c (usage): Mention that -t a ignores high order bit.
169 Documentation problem reported by Ed Avis.
171 2006-02-01 Jim Meyering <jim@meyering.net>
173 * src/pwd.c (find_dir_entry): Remove unused local, `ent_sb_valid'.
175 2006-01-30 Paul Eggert <eggert@cs.ucla.edu>
177 * src/head.c (main): Use a better diagnostic when someone uses a
178 trailing numeric option in an invalid way. Problem reported by
180 * src/tail.c (parse_options): Likewise.
182 2006-01-30 Jim Meyering <jim@meyering.net>
184 * man/wc.x: Include `count' keyword in man page synopsis,
185 per suggestion from http://bugs.debian.org/181585.
187 2006-01-24 Paul Eggert <eggert@cs.ucla.edu>
189 * src/df.c (show_dev): If the file system claims to have
190 more available than total blocks, report the number of used
191 blocks as being total - available (a negative number) rather
192 than as garbage. Problem reported by Toralf Foerster.
194 2006-01-24 Jim Meyering <jim@meyering.net>
196 * src/tail.c (tail_forever): Don't exit-nonzero when an attempt
197 to put a regular file in O_NONBLOCK mode fails with EPERM.
198 That happens on Linux (up to 2.6.15) when using tail -f on a file with
199 the append-only attribute. Reported by Dean Gaudet. For details,
200 see http://savannah.gnu.org/bugs/?func=detailitem&item_id=15473.
201 * NEWS: Mention this fix.
202 * tests/tail-2/append-only: New file. Test for the above.
203 * tests/tail-2/Makefile.am (TESTS): Add append-only.
204 * tests/Makefile.am (check-root): Add tail-2/append-only
206 2006-01-21 Jim Meyering <jim@meyering.net>
208 * NEWS: Mention fts-related improvements and bug fixes.
210 2006-01-19 Jim Meyering <jim@meyering.net>
212 * tests/fmt/basic (pfx-1, pfx-2): New tests, to demonstrate the bug
213 reported as http://bugs.debian.org/147577. Forwarded by Thomas Hood.
215 2006-01-18 Jim Meyering <jim@meyering.net>
217 * tests/du/Makefile.am (TESTS): Add long-from-unreadable.
219 2006-01-17 Jim Meyering <jim@meyering.net>
221 Now that fts no longer changes the current working directory, adjust
222 its clients accordingly -- note that du.c uses fts but doesn't need
223 any adjustment, since it doesn't operate on the actual files,
224 but rather just uses the stat buffers provided by fts.
226 * src/chown-core.c: Include "openat.h".
227 Don't include "lchown.h".
228 (restricted_chown): Accept a new parameter, CWD_FD, and use it in
229 calling openat, lchownat, chownat, rather than open, lchown, chown.
231 * src/chmod.c: Include "openat.h".
232 (process_file): Use chmodat (fts->fts_cwd_fd,... in place of chmod (...
234 * tests/du/long-from-unreadable: New test, to exercise one small
237 2006-01-13 Jim Meyering <jim@meyering.net>
239 * tests/Makefile.am (SUBDIRS): Add comments discouraging the
240 addition of new directories under tests/.
242 * tests/acl: Redirect stdin to /dev/null. Otherwise, FreeBSD 5.0's
245 2006-01-12 Jim Meyering <jim@meyering.net>
247 * tests/du/long-sloop: Adjust not to hard-code the expected
248 diagnostic corresponding to ELOOP. Solaris' diagnostic differs
249 from that of GNU libc. Reported by Paul Eggert.
251 * tests/du/long-sloop: Create file at end of symlink chain.
253 * tests/misc/test: New file, with a test for one of the
254 bugs fixed by yesterday's test.c changes.
255 * tests/misc/Makefile.am (TESTS): Add test.
257 2006-01-11 Jim Meyering <jim@meyering.net>
259 * tests/du/long-sloop: New file. Test for today's fts.c bug fix.
260 That bug could make du -L, chgrp -L, or chown -L fail to diagnose
261 a very long sequence of symbolic links (not necessarily a loop).
262 * tests/du/Makefile.am (TESTS): Add long-sloop.
264 2006-01-11 Paul Eggert <eggert@cs.ucla.edu>
266 * src/test.c (test_syntax_error): Append a newline. All callers
267 changed, except for the ones that didn't already append a newline.
268 Bug reported by Eric Blake.
270 2006-01-11 Jim Meyering <jim@meyering.net>
272 * src/system.h (X2NREALLOC): Now that verify_true is no longer
273 void, cast its result to void, to avoid gcc's warning that
274 ``left-hand operand of comma expression has no effect''.
275 (DECIMAL_DIGIT_ACCUMULATE, X2REALLOC): Likewise.
277 2006-01-10 Jim Meyering <jim@meyering.net>
279 * tests/chmod/no-x: Add a test for today's fts.c fix.
281 2006-01-10 Jim Meyering <jim@meyering.net> (tiny change)
283 * src/ls.c (gobble_file): Use DTTOIF only if it's defined.
284 This is necessary for Dragonfly. Patch by Joerg Sonnenberger.
286 2006-01-10 Paul Eggert <eggert@cs.ucla.edu>
288 * src/system.h (X2NREALLOC, X2REALLOC, DECIMAL_DIGIT_ACCUMULATE):
289 Use verify_true instead of verify_expr, to sync with gnulib.
291 2006-01-08 Jim Meyering <jim@meyering.net>
293 * src/date.c (usage): Adjust the formatting of the entries for
294 %::z and %:::z (separate with two spaces, not one) so that help2man
295 formats them properly. Reported by Philip Rowlands.
297 2006-01-06 Paul Eggert <eggert@cs.ucla.edu>
299 * configure.ac (gl_IGNORE_UNUSED_LIBRARIES): Add.
301 2006-01-06 Jim Meyering <jim@meyering.net>
303 * Makefile.maint (copyright-check): Use date +%Y in place of
306 * src/remove.c (rm_1): Remove `static' attribute on local `status'.
307 First off, the attribute should have been `volatile' (not static)
308 to avoid longjmp-related risk of clobber. Secondly, now there is
309 no longer any risk of a local variable being clobbered, so there's
310 no need for any attribute at all.
312 2006-01-05 Jim Meyering <jim@meyering.net>
314 * src/remove.c: Give a few functions the inline attribute.
315 (AD_pop_and_chdir): Use gotos to avoid some duplication.
316 (AD_push): Rewrite an assertion so that the entire computation
317 goes away when assertions are turned off.
319 * src/tail.c (ENOSYS) [!defined ENOSYS]: Don't define here.
320 It's already defined in "system.h".
321 * Makefile.maint: Add a FIXME comment.
323 2006-01-04 Jim Meyering <jim@meyering.net>
325 * ChangeLog: Remove entries from 2005-10-22 and earlier.
326 * ChangeLog-2005: New file, for entries up to version 5.92.
328 2006-01-03 Jim Meyering <jim@meyering.net>
330 * tests/du/no-x: Also allow a slightly different diagnostic -- the
331 one you get when using openat-enabled fts.c and du (coming soon).
332 * tests/chmod/no-x: Likewise.
333 * tests/chgrp/no-x: Likewise.
335 * src/system.h (O_DIRECTORY) [!defined O_DIRECTORY]: Define.
337 2006-01-02 Paul Eggert <eggert@cs.ucla.edu>
339 * src/chown-core.c (RC_do_ordinary_chown): New enum value.
340 (restricted_chown): Return it, if the file cannot be accessed due
341 to EPERM, or if no uid or gid are required, or if the file is
342 neither a directory nor a regular file. Rewrite to avoid gotos.
343 (change_file_owner): Handle RC_do_ordinary_chown case.
344 Rewrite to avoid gotos.
345 * tests/chgrp/basic: Make sure we can change the group of
348 * src/date.c (usage): Explain %g, %G, and %V a bit better.
350 2006-01-02 Jim Meyering <jim@meyering.net>
352 * src/copy.c (set_owner): Correct a comment.
354 * src/tail.c (parse_options): Change warning to say that --retry
355 is useful `mainly' (not `only') when following by name.
356 Reported here: http://bugs.debian.org/273781
358 2006-01-01 Paul Eggert <eggert@cs.ucla.edu>
360 * NEWS: Document that mkfifo and mknod -m no longer set special bits.
361 * src/copy.c: Include lchmod.h.
362 (copy_internal): Use lchmod rather than chmod.
363 * src/cp.c: Include lchmod.h.
364 (re_protect, make_dir_parents_private): Use lchmod rather than chmod.
365 * src/mkdir.c: Include lchmod.h.
366 (usage): Clarify -m's operation.
367 (main): Use lchmod rather than chmod. Don't use lchmod unless the
368 new mode contains bits outside the 777 range.
369 * src/mkfifo.c (usage): Clarify -m's operation.
370 (main): If -m is given, don't invoke chmod; use umask 0 instead.
371 Report an error if -m asks for bits outside the 777 range.
372 * src/mknod.c (usage, main): Likewise.
374 * src/mkdir.c, src/mkfifo.c, src/mknod.c: Undo 2005-12-19 changes.
376 2005-12-27 Jim Meyering <jim@meyering.net>
378 * Makefile.maint (sc_obsolete_symbols): Prohibit use of O_NDELAY.
379 (sc_prohibit_assert_without_use): New rule.
380 (syntax-check-rules): Add it to the list.
381 * .x-sc_prohibit_assert_without_use: New empty file.
382 * Makefile.am (EXTRA_DIST): Add it.
384 * Makefile.maint (CVS_LIST): Define in terms of $(srcdir).
386 * cp.c, df.c, link.c, mknod.c, nice.c, sleep.c, unlink.c:
387 Don't include <assert.h>; it wasn't used.
389 2005-12-26 Paul Eggert <eggert@cs.ucla.edu>
391 * src/chown-core.c (restricted_chown):
392 Don't try O_WRONLY unless O_RDONLY failed wth EACCES.
393 * src/remove.c (fd_to_subdirp): Open with O_DIRECTORY | O_NOCTTY
394 | O_NOFOLLOW too, for consistency with other dir-openers.
395 Use POSIX-preferred O_NONBLOCK rather than O_NDELAY.
396 (is_empty_dir): Likewise.
397 * src/shred.c (wipename): Likewise. Don't bother trying to open
398 dir for writing, since POSIX prohibits it.
400 2005-12-22 Jim Meyering <jim@meyering.net>
402 * tests/help-version: Redirect stderr to /dev/full, to suppress
403 write error diagnostic.
405 2005-12-19 Jim Meyering <jim@meyering.net>
407 * src/mkdir.c, src/mknod.c, src/mkfifo.c (main)
408 Avoid a minor race condition when `-m MODE' is specified, by using
409 open, fchown, and close rather than just chown. To do that reliably --
410 even with an overly restrictive umask -- ensure that each mkdir,
411 mknod and mkfifo call uses a mode including at least owner-read access.
412 * src/mknod.c (main): When `-m MODE' is specified, exit nonzero if
413 the subsequent chown (or equivalent open,fchown,close) fails.
414 * tests/misc/mknod: New tests.
415 * tests/misc/Makefile.am (TESTS): Add mknod.
417 2005-12-17 Jim Meyering <jim@meyering.net>
419 * src/remove.c (is_empty_dir): Open with O_NDELAY, so we don't hang,
420 e.g., on a named pipe.
421 (OPEN_NO_FOLLOW_SYMLINK): Remove definition. Use O_NOFOLLOW in
422 place of all uses, since it is guaranteed (system.h) to be defined.
424 2005-12-05 Andreas Gruenbacher <agruen@suse.de>
426 Add POSIX ACL support
427 * src/ls.c: Switch back from HAVE_ACL to USE_ACL: The acl() syscall
428 is no requirement for ACL support; particularly, it does not exist
429 on systems that have POSIX ACLs.
430 * src/copy.h (cp_option_init) [umask_kill]: Remove member.
431 * src/cp.c (umask_kill): With default acls, the umask is not to be
432 applied. Remove umask_kill, don't change the process umask, and let
433 the kernel apply the umask where appropriate.
434 * src/cp.c (make_dir_parents_private): Fix logic for POSIX ACLs.
435 * src/copy.c (get_dest_mode): Remove; it is obsolete after removing
437 (copy_reg, copy_internal): Use copy_acl and set_acl
438 instead of fchown/chown. Fix the logic for POSIX ACLs.
439 (chown_succeded): Remove; we now always copy acls and
440 preserve S_ISUID, S_ISGID, and S_ISVTX when needed, no matter if we
441 did a chown before or not.
442 * src/mv.c, src/install.c (cp_option_init): Don't set umask_kill member.
443 * src/Makefile.am (dir_LDADD, ls_LDADD, vdir_LDADD, cp_LDADD,
444 mv_LDADD, ginstall_LDADD): On systems with an ACL library, arrange
445 to link with it via $(LIB_ACL), for the utilities that need it.
447 2005-12-16 Paul Eggert <eggert@cs.ucla.edu>
449 * src/remove.c (OPENAT_CWD_RESTORE__REQUIRE): Remove.
450 (OPENAT_CWD_RESTORE__ALLOW_FAILURE): Likewise.
451 (fd_to_subdirp): Remove openat_cwd_restore_allow_failure arg; its
452 value is now signified by whether cwd_errno is null.
453 (fd_to_subdirp, remove_dir, rm_1); Change cwd failure indicator from
454 pointer-to-bool to pointer-to-errno-value. All callers changed.
455 (rm_1): Don't bother setting a local cwd failure flag and then
456 ORing it into the caller's. Just set the caller's.
457 (rm): Use cwd failure errno value to print a slightly-better
460 2005-12-15 Jim Meyering <jim@meyering.net>
462 * src/stat.c (print_it): Properly handle a backslash at the
463 end of a --printf format string. Reported by Paul Eggert.
464 * tests/misc/stat-printf (end-bs): Add a test for the above.
466 2005-12-15 Paul Eggert <eggert@cs.ucla.edu>
468 * tests/acl: Port to pre-POSIX shells like Solaris 8 /bin/sh.
469 Don't assume /etc/passwd contains user names; use 'id' instead.
471 2005-12-15 Jim Meyering <jim@meyering.net>
473 stat: revert behavior of --format=FMT (-c)
474 stat: add new option: --printf=FMT
475 * NEWS: Mention this.
476 * src/stat.c (isodigit, octtobin, hextobin): Define.
477 (PRINTF_OPTION): Define.
478 (interpret_backslash_escapes, trailing_delim): New globals.
479 (usage): Document them. Alphabetize on long option names.
480 (print_esc_char): New function.
481 (print_it): Rewrite, in order to handle backslash escapes.
482 (main): Handle new option. Set globals for --format, too.
484 * tests/misc/stat-printf: Test --printf and --format.
485 * tests/misc/Makefile.am (TESTS): Add stat-printf.
487 2005-12-14 Paul Eggert <eggert@cs.ucla.edu>
489 * NEWS: sort now reports incompatible options.
490 * src/sort.c (incompatible_options, check_ordering_compatibility):
492 (main): Use them. Don't bother with a usage message for
493 "sort -c a b", for consistency with other error diagnostics.
494 * tests/sort/Test.pm (incompat1, incompat2, incompat3, incompat4):
497 * src/cat.c (main): Undo previous change. close_stdout already
498 does the check, so the previous change wasn't necessary.
500 2005-12-13 Paul Eggert <eggert@cs.ucla.edu>
502 * src/cat.c (main): Check for close (STDOUT_FILENO) failure.
504 2005-12-12 Paul Eggert <eggert@cs.ucla.edu>
506 Install a more-conservative approach for sort -R. It's the
507 same basic idea as the existing code, except it uses the full ISAAC
508 approach (called the "more kosher" approach in the existing comments).
509 This makes "sort -R" quite a bit slower (about a factor of 2 on my
510 little tests involving 10000 lines on a 2.4 GHz P4), but I think it's
511 better to be conservative here at first, and review any performance
512 improvements carefully.
513 * .x-sc_require_config_h: Add src/rand-isaac.c.
514 * src/rand-isaac.h: Remove. All uses now simply include rand-isaac.c.
515 * src/Makefile.am (noinst_HEADERS): Remove rand-isaac.h.
516 (shred_SOURCES, sort_SOURCES): Remove.
517 (EXTRA_DIST): Add rand-isaac.c.
518 * src/rand-isaac.c: Revert to what used to be in shred.c, without
519 changing it to allow for varying numbers of words in the state.
520 Alter so that we include rand-isaac.c directly rather than
521 compiling it and linking to it. Don't include config.h or
522 system.h; that's the includer's responsibility.
523 Omit functions that are specific to shred.
524 (ISAAC_LOG, ISAAC_WORDS, ISAAC_BYTES, struct isaac_state, ind):
525 (isaac_step, struct irand_state):
526 Resurrect these, with the same defns that used to be in shred.c.
527 (ISAAC_SIZE, isaac_new, isaac_copy): Remove.
528 (isaac_refill, isaac_seed_start, isaac_seed_data, irand_init, irand32):
530 (struct isaac_state, isaac_refill, isaac_mix, isaac_init):
531 (isaac_seed_start, isaac_seed_data, isaac_seed_finish, isaac_seed):
532 (irand_init, irand32, irand_mod):
533 Number of words is constant again.
534 (struct irand_state, irand_init, irand32, irand_mod): Move to shred.c.
535 * src/shred.c: Include rand-isaac.c rather than rand-isaac.h.
536 * src/sort.c: Likewise.
537 * src/shred.c (fillrand, dopass, main): Undo previous change.
538 (struct irand_state, irand_init, irand32, irand_mod): Moved back here,
540 * src/sort.c: Don't include md5.h; it wasn't needed.
541 (struct keyfield): Rename random_hash to random, for consistency
542 with the other member names. All uses changed.
543 (usage): Tweak wording to mention STRING for --seed option.
544 (short_options): Rorder for consistency with other programs.
545 (rand_state): Now a struct, not a pointer to one. All uses changed.
546 (HASH_WORDS, HASH_SIZE): Remove.
547 (get_hash): Remove comments around resbuf size, since we can assume C89.
548 Use a "more-kosher" (but slower) approach of invoking isaac_refill.
549 (keycompare): Adjust to the new get_hash.
551 (badfieldspec): Omit recently-introduced comment; it isn't needed.
552 (main): Don't set need_random simply because gkey has it set; that
553 doesn't necessarily mean we'll need random numbers.
554 Redo seeding to match new get_hash approach.
556 2005-12-10 Jim Meyering <jim@meyering.net>
558 * src/Makefile.am (noinst_HEADERS): Add rand-isaac.h.
560 Avoid shred segfault on 64-bit systems.
561 * src/rand-isaac.c (isaac_refill): Don't try to negate a
562 local of type uint32_t. Make the local an `int' instead.
564 * NEWS: Mention sort's new options.
566 * src/rand-isaac.c (isaac_mix): Declare to be static.
567 Mark all other functions as `extern' so the tight-scope
568 part of `make distcheck' passes once again.
569 * src/rand-isaac.h (isaac_mix): Remove declaration.
571 * src/sort.c (get_hash): Change position of `*' in parameter
572 type to conform with convention.
573 (main): Split a long line so it fits in 80 columns.
574 (keycompare): Remove stray SPACE before TAB that was
575 causing `make distcheck' to fail.
577 * src/shred.c: Don't include gethrxtime.h. No longer needed.
579 * tests/misc/sort-rand: New file: basic tests for the new options.
580 * tests/misc/Makefile.am (TESTS): Add sort-rand.
582 2005-12-10 Frederik Eaton <frederik@ofb.net>
584 * src/Makefile.am (sort_LDADD): Add $(LIB_GETHRXTIME).
585 (shred_SOURCES, sort_SOURCES): New macros, so we compile rand-isaac.c.
586 * src/rand-isaac.c: New file, containing ISAAC code that was in shred.c.
587 Make state size runtime-configurable.
588 (isaac_new, isaac_copy): New functions.
589 * src/rand-isaac.h: New file.
590 * src/shred.c: Include rand-isaac.h. Move ISAAC code to rand-isaac.c.
591 (fillrand, main): Adjust to the fact that the state size is now
592 runtime-configurable.
593 * src/sort.c (short_options, long_options, WORDS, keycompare, main):
594 (usage): Add options --random-sort and --seed to implement a random
596 Include md5.h and rand-isaac.h.
597 (get_hash): New function.
598 (rand_state): New var.
599 (HASH_WORDS, HASH_SIZE): New macros.
601 2005-12-09 Paul Eggert <eggert@cs.ucla.edu>
603 * tests/dd/misc: Add test for dd iflags=noatime.
605 2005-12-09 Jim Meyering <jim@meyering.net>
607 * src/sort.c (usage): Mention white space vs -b and -t options.
610 2005-12-09 Eric Blake <ebb9@byu.net>
612 * src/test.c (main): Fix misleading comment.
614 2005-12-07 Paul Eggert <eggert@cs.ucla.edu>
616 * NEWS: Mention dd's new noatime flag.
617 * src/system.h (O_NOATIME): Define to 0 if not already defined.
618 * src/dd.c (flags, usage): Add support for noatime flag.
620 2005-12-07 Jim Meyering <jim@meyering.net>
622 Distribute the cvsu script, used only by `make syntax-check'.
623 * Makefile.am (EXTRA_DIST): Add build-aux/cvsu.
624 * Makefile.maint (CVS_LIST): Use build-aux/cvsu, now that we
625 distribute a copy of this script.
626 * .x-sc_unmarked_diagnostics: Add build-aux/cvsu.
628 * tests/mv/acl: exit-77 before the trap, not after, if we fail
629 to create a temporary directory on another partition.
630 From Andreas Gruenbacher.
632 2005-12-06 Tomas Pospisek <tpo@sourcepole.ch> (tiny change)
634 * man/basename.x: Cross-reference to dirname and readlink.
635 * man/dirname.x: Cross-reference to basename and readlink.
637 2005-12-05 Andreas Gruenbacher
639 * src/copy.c [!HAVE_FCHOWN]: Define fchown(...) to -1.
640 (set_owner, preserve_author): New functions, factored out of copy_reg.
641 (copy_reg): Use them.
642 (copy_internal): Use them here, too.
644 2005-12-04 Jim Meyering <jim@meyering.net>
646 * src/sleep.c (usage): Say what happens with two or more arguments.
647 Suggested by Justin Pryzby.
649 * src/uptime.c (print_uptime): Move decl of `upsecs' into scope
652 2005-12-03 Jim Meyering <jim@meyering.net>
654 * src/rm.c (long_opts): Change the name of each undocumented, for-
655 testing-only option to start with `-', so that it cannot render
656 ambiguous any prefix it happens to share with some other option name.
657 Problem reported by Eric Blake.
658 * src/head.c (long_options): Likewise.
659 * src/tail.c (long_options): Likewise.
661 * tests/misc/head-elide-tail: Update uses of undocumented, for-
662 testing-only --presume* options to start with `---'.
663 * tests/rm/dangling-symlink: Likewise.
664 * tests/rm/dir-no-w: Likewise.
665 * tests/rm/isatty: Likewise.
667 2005-11-30 Jim Meyering <jim@meyering.net>
669 * Makefile.maint: Add a comment about cvsu.
671 2005-11-25 Paul Eggert <eggert@cs.ucla.edu>
673 * NEWS: df updates for "none", "proc", inaccessible file systems.
674 * src/df.c (show_point): Ignore inaccessible file systems.
675 (usage): -a includes dummy file systems, not size-0 file systems.
677 * src/od.c (unsigned_long_long_int): Renamed from ulonglong_t,
678 to avoid collision with POSIX name space. All uses changed.
680 2005-11-24 Jim Meyering <jim@meyering.net>
682 * tests/Makefile.am (EXTRA_DIST): Add acl to the list.
683 * tests/acl: Add `$0: ' prefix to diagnostics.
685 * .x-sc_require_config_h: Add lib/buffer-lcm.c to the list.
687 2005-11-23 Paul Eggert <eggert@cs.ucla.edu>
689 * src/copy.c: Improve performance a bit by optimizing away
690 unnecessary system calls and going to a block size of at least
691 8192 (on normal hosts, anyway). This improved performance 5% on my
692 Debian stable host (2.4.27 kernel, x86, copying from root
693 ext3 file system to itself).
694 Include "buffer-lcm.h".
695 (copy_reg): Omit last argument. All callers changed.
696 Use xmalloc to allocate rather than trusting alloca
697 (which is unwise with large block sizes).
698 Declare locals more locally, if possible.
699 Use uintptr_t words instead of int words, for a bit more speed
700 when looking for null blocks on 64-bit hosts.
701 Optimize away reads of zero bytes on regular files.
702 In the typical case, insist on 8 KiB buffers, at least.
703 Avoid unnecessary extra call to fstat when checking for sparse files.
704 Avoid now-unnecessary cast to off_t, and "0L".
705 Avoid unnecessary test of *new_dst when checking for same owner
708 2005-11-22 Paul Eggert <eggert@cs.ucla.edu>
710 * src/remove.c (rm): Don't assume C99 for-loop syntax.
712 2005-11-22 Jim Meyering <jim@meyering.net>
714 * src/remove.c (AD_push): Remove debugging cruft.
716 * tests/rm/unread2 (rm): Change expected diagnostic,
717 `cannot open directory' to `cannot remove', to align with
719 * tests/rm/rm2: Ensure that rm now continues removing entries
720 even after certain types of failure.
722 * src/remove.c: Rewrite. Now, this module is reentrant on systems
723 that provide openat (Solaris), and on systems like Linux+procfs
724 where our openat emulation code is reentrant. This also fixes a
725 few low-probability leaks and eliminates some code that could,
726 in very unusual circumstances, cause rm() (via a callee) to exit.
727 * NEWS: Mention this.
729 * configure.ac: Put copyright dates all on one line so the
730 emacs function that updates them works properly.
732 2005-11-18 Paul Eggert <eggert@cs.ucla.edu>
734 * configure.ac (AM_PROG_CC_C_O): Add. Needed for CVS Automake.
735 Problem reported by Eric Blake.
736 (AC_PROG_CC_STDC): Use this instead of AC_PROG_CC, so that
737 we get a standard-conforming compiler. This relies on the new
738 m4/c.m4 file. Note that it's a bit tricky, since c.m4 doesn't
739 define AC_PROG_CC_STDC; we are relying on Autoconf 2.59 internals.
740 m4/c.m4 can go away with Autoconf 2.60 comes out.
742 2005-11-17 Jim Meyering <jim@meyering.net>
744 * src/remove.c (AD_mark_helper): Make a `char *' parameter `const'.
745 (AD_mark_current_as_unremovable): Likewise, but for a local.
748 * tests/mv/acl: Let traps handle removing temporary directories.
750 Expect acl-related tests to fail, until the corresponding
751 patches are committed.
752 * tests/mv/Makefile.am (XFAIL_TESTS): Add acl.
753 * tests/cp/Makefile.am (XFAIL_TESTS): Likewise.
755 ACL tests, from Andreas Gruenbacher.
756 * tests/acl, tests/mv/acl, tests/cp/acl: New files.
757 * tests/mv/Makefile.am (TESTS): Add acl.
758 * tests/cp/Makefile.am (TESTS): Add acl.
760 * src/ls.c (basename_is_dot_or_dotdot): Correct wording in comment.
762 2005-11-16 Paul Eggert <eggert@cs.ucla.edu>
764 * NEWS: Improve quality of ln's diagnostics.
765 * src/ln.c (do_link, usage): Likewise.
766 (do_link): Don't use alloca on a buffer of unbounded size.
768 2005-11-16 Jim Meyering <jim@meyering.net>
770 * tests/cp/fail-perm: Accommodate HPUX. It appears to fail
771 with EACCES rather than EPERM. Reported by Peter O'Gorman here:
772 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/5766
774 2005-11-14 Jim Meyering <jim@meyering.net>
776 * NEWS (sort): Mention consequences of today's mkstemp-safer.c fix.
778 2005-11-13 Jim Meyering <jim@meyering.net>
780 * announce-gen: Accept new option, --gpg-key-id=ID and
781 emit a blurb telling how to use the .sig files.
782 * Makefile.cfg (gpg_key_ID): Define.
783 * Makefile.maint (announcement): Use new option and key.
785 Require that most .c files include <config.h>.
786 * Makefile.maint (sc_require_config_h): New rule.
787 (syntax-check-rules): Add it.
788 * .x-sc_require_config_h: New file listing exceptions to the
789 above rule. Some are legit, others are simply grandfathered in.
790 * Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h here, too.
792 2005-11-12 Jim Meyering <jim@meyering.net>
794 * src/checksum.h, src/md5.c, src/sha1sum.c: Remove now-unused files.
796 2005-11-11 Jim Meyering <jim@meyering.net>
798 * NEWS: Mention `readlink -f' bug fix in 5.3.0 news.
799 Mention new readlink options in 5.3.0's `New features' section.
800 Spotted by Thomas Hood.
802 2005-11-08 Jim Meyering <jim@meyering.net>
804 * NEWS: Merge in changes from b5_9x branch.
806 2005-11-08 Paul Eggert <eggert@cs.ucla.edu>
808 * NEWS: ls now defaults to --time-style='locale', which in turn acts
809 like --time-style='posix-long-iso' if the locale settings are messed up.
810 * src/ls.c (decode_switches): Implement this.
812 2005-11-08 Jim Meyering <jim@meyering.net>
814 * tests/du/2g: s/expensive/very expensive/ in a comment.
817 2005-10-17 Eric Blake <ebb9@byu.net>
819 * src/ls.c (usage): Fix descriptions of --sort, --time.
820 Reported by Vitaly A. Ostanin.
822 2005-11-04 Paul Eggert <eggert@cs.ucla.edu>
824 * src/ln.c: Include filenamecat.c.
825 (FILE_BASENAME_CONCAT): Remove.
826 (do_link): Remove last arg DEST_IS_DIR. All callers changed.
827 (main): Use file_name_concat, base_name, and strip_trailing_slashes
828 instead of FILE_BASENAME_CONCAT. This simplifies the code, and avoids
831 2005-11-04 Jim Meyering <jim@meyering.net>
833 * src/du.c (process_file): Don't overflow for files of size >= 2^31
834 on systems with stat.st_blocks of a signed 32-bit type.
835 This bug causes trouble on some AIX 5.1 systems.
836 Report and trivial patch from Paul Townsend:
837 <http://lists.gnu.org/archive/html/bug-coreutils/2005-11/msg00033.html>
838 * NEWS: Mention this.
840 * tests/du/2g: New (very-expensive) test for the above-fixed bug.
841 * tests/du/Makefile.am (TESTS): Add it here.
842 * tests/very-expensive: New file.
843 * tests/Makefile.am (EXTRA_DIST): Add it here.
844 * tests/cp/perm: Mark this test as `very-expensive', too.
846 2005-11-02 Paul Eggert <eggert@cs.ucla.edu>
848 * NEWS: Mention that rm -d and maybe ln -d are scheduled for
850 * src/remove.h (struct rm_options): Remove unlink_dirs. All uses
852 * src/rm.c (usage): Don't mention rm -d.
854 2005-11-02 Jim Meyering <jim@meyering.net>
856 * tests/dd/skip-seek: Fix typo in comment: s/fileutils/coreutils.
859 * tests/dd/unblock-sync: Redirect stderr to /dev/null so the
860 `M+N records in/out' lines don't pollute `make check' output.
862 * tests/dd/skip-seek (sk-seek4): New test, to exercise the bug
863 fixed on 2005-10-31. This test uses the new, IN_PIPE specifier.
864 * tests/Coreutils.pm: Accept a new type of input specifier: IN_PIPE,
865 to indicate that the input file should be piped into the command
866 under test (via `cat FILE | $prog ...').
868 * src/remove.c (remove_entry): Emit a better diagnostic when rm
869 (without -r) fails to remove a directory on a non-Linux system.
870 This change affects only newer Solaris systems (with priv_*
871 functions like priv_allocset). Reported by Keith Thompson.
873 * tests/rm/dir-nonrecur: New file/test for the above fix.
874 * tests/rm/Makefile.am (TESTS): Add dir-nonrecur.
876 2005-11-01 Paul Eggert <eggert@cs.ucla.edu>
878 * NEWS: "tail -c 2 FILE" and "touch 0101000000" now operate as
879 POSIX 1002.1-2001 requires.
880 * src/tail.c (parse_obsolete_option): Implement this.
881 Problem reported by Vincent Lefevre.
882 * src/touch.c (main): Pass PDS_PRE_2000 to posixtime.
883 * tests/tail/Test.pm (c-2, c-2-minus, c2, c2-minus): New tests.
884 (test_vector): Add special cases for _POSIX2_VERSION, and
885 regularize the old ones a bit.
886 * tests/touch/obsolescent: Add y2000 test.
888 2005-10-31 Paul Eggert <eggert@cs.ucla.edu>
890 * src/dd.c (skip): Fix off-by-one error reported by
891 Theodoros V. Kalamatianos.
893 2005-10-30 Paul Eggert <eggert@cs.ucla.edu>
895 * tests/mkdir/p-3: Require that the test be run as non-root.
896 Problem and trivial fix reported by Theodoros V. Kalamatianos.
898 2005-10-28 Paul Eggert <eggert@cs.ucla.edu>
900 * src/ln.c (FILE_BASENAME_CONCAT): Omit unnecessary slashes in the
901 boundary between DEST and SOURCE in the result.
903 2005-10-26 Dmitry V. Levin <ldv@altlinux.org>
905 * src/md5sum.c (main) [!O_BINARY]: Changed default read mode
906 back to text, to sync with documentation and for backwards
909 2005-10-25 Jim Meyering <jim@meyering.net>
911 * tests/dircolors/simple (other-wr): Add an explicit test for
912 the dircolors bug (NULL-dereference) fixed yesterday.
914 2005-10-24 Jim Meyering <jim@meyering.net>
916 * src/tac.c (tac_file): When determining whether a file is seekable,
917 also test whether it is a tty. Using only the lseek-based test would
918 give a false positive on Solaris. Reported by Peter Fales.
920 2005-10-24 Dmitry V. Levin <ldv@altlinux.org>
922 * tests/install/d-slashdot: New test, for "install -d" failure.
923 * tests/install/Makefile.am (TESTS): Add d-slashdot.
924 * tests/mkdir/p-slashdot: New test, for "mkdir -p" failure.
925 * tests/mkdir/Makefile.am (TESTS): Add p-slashdot.
927 2005-10-24 Jim Meyering <jim@meyering.net>
929 * src/dircolors.c (ls_codes): Add missing comma.
930 Anonymous report and patch from
931 http://savannah.gnu.org/bugs/?func=detailitem&item_id=14849
933 * src/dircolors.c: Add compile-time assertion that the slack_codes
934 and ls_codes arrays have the same number of elements. This would
935 have prevented the above-fixed bug.
937 * src/expand.c (parse_tab_stops): Add a comment to make this function
938 identical to the one in unexpand.c.
939 * src/unexpand.c (parse_tab_stops): Adjust syntax to make this function
940 identical to the one in expand.c.
942 * src/expand.c (next_file): Don't assume fopen cannot return stdin.
944 2005-10-23 Jim Meyering <jim@meyering.net>
946 * src/md5sum.c (digest_check, main): Use ptr_align rather than
947 a dangerous pointer-value-to-`unsigned' cast.
948 * NEWS: mention the new sha* programs.
949 * AUTHORS: Add new sha* programs.
951 2005-08-28 David Madore <david.madore@ens.fr>
953 Add new programs: sha224sum, sha256sum, sha384sum, sha512sum.
954 * README: Add their names to the list.
955 * src/md5sum.c: Provide framework for computing sha-2 hashes.
956 * src/Makefile.am (sha224sum, sha256sum, sha384sum, sha512sum):
957 Rules for compiling sha-2 utilities
958 (noinst_HEADERS): Remove checksum.h.
959 * man/sha512sum.x, man/sha384sum.x, man/sha256sum.x, man/sha224sum.x:
961 * man/Makefile.am (dist_man_MANS): Add the corresponding .1 names.
962 (sha224sum.1, sha256sum.1, sha384sum.1, sha512sum.1): New dependencies.
963 * tests/misc/sha224sum, tests/misc/sha256sum: New files.
964 * tests/misc/sha384sum, tests/misc/sha512sum: New files.
965 * tests/misc/Makefile.am (TESTS): Add new sha224sum, sha256sum,
966 sha384sum, sha512sum test scripts here rather that each in its
969 2005-08-28 David Madore <david.madore@ens.fr>
971 * tests/sha1sum/basic-1 (million-a): Add the "million a's" test (one
972 of the FIPS test vectors).
974 2005-10-23 Jim Meyering <jim@meyering.net>
976 * configure.ac: Use 6.0-cvs as the version string.
977 * NEWS: Adjust accordingly.