1 2006-06-15 Bob Proulx <bob@proulx.com> (tiny change)
3 * tests/misc/mknod: Improve permission checks to handle
4 running mkdir test in set-gid directories.
6 2006-06-14 Jim Meyering <jim@meyering.net>
8 * tests/du/basic: Revamp not to hard-code file system block sizes.
10 2006-06-12 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
12 * tests/du/Makefile.am (TESTS_ENVIRONMENT): Pass $(PERL), for
15 2006-06-11 Jim Meyering <jim@meyering.net>
17 * .gitignore: New file.
18 * Makefile.am (EXTRA_DIST): Add .gitignore.
20 Setting TIME_STYLE=long-iso in the environment would make the
21 cp/same-file test fail.
22 * tests/envvar-check (vars): Add TIME_STYLE to the list.
23 * tests/cp/same-file: Revert last change.
24 Source the envvar-check script, to ensure that TIME_STYLE
25 settings don't affect these tests.
27 2006-06-11 Paul Eggert <eggert@cs.ucla.edu>
29 * tests/cp/same-file: Execute 'ls' in the C locale, so that it
30 uses POSIX time stamp formats. Problem reported by John Nixon in
31 <http://lists.gnu.org/archive/html/bug-coreutils/2006-06/msg00062.html>.
33 2006-06-10 Jim Meyering <jim@meyering.net>
35 * NEWS: Mention the AIX-strndup-bug vs. dircolors workaround.
37 Require a "Version N.M" line at the top of the ChangeLog
38 file only when making the actual release, not when running
40 * Makefile.maint (maintainer-distcheck): Don't depend on
42 (alpha beta major): Depend on it here, instead.
44 2006-06-08 Jim Meyering <jim@meyering.net>
46 Ensure that cat works with any of the options, -A -v -e -E -T,
47 when applied to files in /proc and /sys, even when the FIONREAD
48 ioctl produces nonsensical results. Before this change, cat would
49 produce no output (or truncated output), for some linux kernels.
51 * src/cat.c (write_pending): New function, factored out of cat.
52 (cat): Also interpret a negative ioctl/FIONREAD count as indicating
53 that there are bytes to read. Some versions of linux-2.6.16 do that.
54 Write any pending output before returning.
55 Reported by Dan Jacobson in <http://bugs.debian.org/370583>.
56 * NEWS: Mention this bug fix.
57 * tests/misc/cat-proc: New file. Test for the above.
58 * tests/misc/Makefile.am (TESTS): Add cat-proc.
60 2006-06-07 Paul Eggert <eggert@cs.ucla.edu>
62 * src/expr.c (eval4): Detect overflow properly when multiplying
65 2006-06-06 Paul Eggert <eggert@cs.ucla.edu>
67 * NEWS: The 'expr' command now detects and reports integer overflow.
68 (It would be better to use extended precision instead, but that
70 * src/expr.c (integer_overflow): New function.
71 (eval4, eval3): Check for integer overflow.
73 2006-06-05 Paul Eggert <eggert@cs.ucla.edu>
75 Fix problems when building with Solaris/SVR4/etc. make, which uses a
76 different and somewhat bogus implementation of VPATH. In the
77 directory tests/misc, rename tests whose names might appear in the
78 Automake-generated rules. For example, we can't use a test named
79 'test', since Automake generates a rule that contains the text
80 "if test -f ./$$tst; ...", and this might expand to something like
81 "if ../../../coreutils-6.0/tests/misc/test -f ./$$test; ...",
82 which executes the 'test' script rather than the 'test' command.
83 * tests/misc/false-status: Renamed from tests/misc/false.
84 * tests/misc/pwd-long: Renamed from tests/misc/pwd.
85 * tests/misc/sort-merge: Renamed from tests/misc/sort.
86 ($prog): Set to 'sort' rather than to $PROG.
87 * tests/misc/test-diag: Renamed from tests/misc/test.
88 * tests/misc/Makefile.am (PROG): Take the basename of $$tst,
89 in case Solaris make has prepended the directory.
90 (TESTS): Adjust to above renamings.
91 * tests/misc/expand: Don't assign to PROG; no longer needed
92 now that Makefile.am sets PROG to the basename.
93 * tests/misc/fold: Likewise.
95 2006-06-03 Jim Meyering <jim@meyering.net>
97 Make `cp --link --no-dereference' work also on systems where the
98 link system call cannot create a hard link to a symbolic link.
99 * src/copy.c (copy_internal) [LINK_FOLLOWS_SYMLINKS]: Don't use
100 the link syscall on a symlink when it would do the wrong thing.
101 Based on the patch by Aurelien Jarno: <http://bugs.debian.org/329451>
102 * tests/cp/link-no-deref: New file/test for the above.
103 * tests/cp/Makefile.am (TESTS): Add link-no-deref.
104 * NEWS: Mention the change (doesn't affect Linux).
106 2006-06-01 Paul Eggert <eggert@cs.ucla.edu>
108 Fix some porting problems in the test cases reported by
109 Ralf Wildenhues for HP-UX 11.23 in:
110 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00238.html
111 * tests/help-version: Don't assume that \< \> works in sed.
112 * tests/misc/close-stdout: Don't assume that >&- works.
113 Add a /dev/full test.
114 * tests/touch/no-create-missing: Don't assume that >&- works.
116 2006-05-30 Jim Meyering <jim@meyering.net>
118 * src/ls.c (usage): Add `v' to the list of sorting-related options.
121 2006-05-28 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
123 * tests/cp/fail-perm: source lang-default.
124 * tests/rm/inaccessible: Likewise.
126 2006-05-28 Jim Meyering <jim@meyering.net>
128 * tests/rm/inaccessible: AIX 4.3.3 gives a different diagnostic.
129 Recognize it, too. Reported by Ralf Wildenhues, in
130 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
132 2006-05-27 Jim Meyering <jim@meyering.net>
134 * src/chgrp.c: Support new options: --preserve-root and
135 --no-preserve-root. Somehow this program was skipped when those
136 options were added to chown, chmod, and rm. Reported by
137 vaqflabuopac@spammotel.com in <http://bugs.debian.org/365656>.
138 * NEWS: Mention this.
140 2006-05-25 Paul Eggert <eggert@cs.ucla.edu>
142 * NEWS: Remove mention of --seed. We'll replace it with something
143 better, and don't want to indicate that it is supported.
144 * src/sort.c (usage): Likewise.
146 2006-05-20 Jim Meyering <jim@meyering.net>
148 * src/chmod.c (main): Use FTS_PHYSICAL here, too.
150 * src/du.c (main): Rename local, s/symlink_deref_bit/symlink_deref_bits/
151 and arrange for -D to set fts' FTS_PHYSICAL bit as well as
152 FTS_COMFOLLOW. Spotted by Justin Pryzby.
154 * gnupload: Merge changes from automake, retaining the ""--to...
155 kludge to placate overzealous `make distcheck' check.
157 2006-05-19 Jim Meyering <jim@meyering.net>
159 * src/du.c (main): Don't let -D, -L, or -P turn off the internal
160 FTS_TIGHT_CYCLE_CHECK directory traversal option.
161 Reported by Justin Pryzby in http://bugs.debian.org/367691
163 2006-05-15 Jim Meyering <jim@meyering.net>
165 * src/cp.c (usage): Correct description of -a: s/-dpR/-dpPR/.
168 2006-05-13 Jim Meyering <jim@meyering.net>
170 * tests/mv/no-target-dir: Test two more cases.
172 2006-05-11 Jim Meyering <jim@meyering.net>
174 mv -T DIR EMPTY_DIR no longer fails unconditionally
175 * src/copy.c (copy_internal): Don't manually prohibit a move where
176 the destination is an existing directory. Sometimes doing that is
177 valid. Let the rename system call enforce the rules. That is
178 allowed only when the source is a directory and the destination
179 directory (to be replaced) is empty. Reported by Eric Blake.
180 * tests/mv/no-target-dir: New file/test for this.
181 * tests/mv/Makefile.am (TESTS): Add no-target-dir.
182 * NEWS: Mention this.
184 * tests/mv/atomic: New file/test for yesterday's fix.
185 * tests/mv/Makefile.am (TESTS): Add atomic.
187 * tests/du/long-sloop: Avoid harmless `ambiguous redirect' diagnostic.
189 2006-05-10 Jim Meyering <jim@meyering.net>
191 * src/copy.c (copy_internal): Don't explicitly unlink the destination
192 when moving a symlink into the place of an existing non-directory.
193 Reported by Joshua Hudson.
194 * NEWS: mention this.
196 2006-05-07 Jim Meyering <jim@meyering.net>
198 * Makefile.maint (patch-check): Fail if patch generates any output,
199 even merely for changed offsets.
201 * src/c99-to-c89.diff: Adjust to reflect new offsets.
203 * NEWS: Mention changes affecting df, pwd, shred.
205 2006-05-06 Jim Meyering <jim@meyering.net>
207 * tests/ls/stat-vs-dirent: New test, to detect the bogus file
208 system condition where dirent.d_ino != stat.st_ino.
209 * tests/ls/Makefile.am (TESTS): Add stat-vs-dirent.
211 2006-05-06 Eric Blake <ebb9@byu.net>
213 * tests/ls/inode: Expand to test inode from readdir case.
214 * tests/ls/follow-slink: Expand to test broken links encountered
215 implicitly, favoring Solaris 9 and OpenBSD 3.4 behavior.
217 2006-05-06 Eric Blake <ebb9@byu.net>
219 * tests/mv/leak-fd: Work even on case-insensitive file system.
221 2006-05-04 Jim Meyering <jim@meyering.net>
223 * NEWS: Mention the 2006-03-19 pwd-related change that makes
224 lib/getcwd.c work around inconsistent file system dirent.d_ino data.
226 2006-05-03 Jim Meyering <jim@meyering.net>
228 * src/ls.c (DEFINE_SORT_FUNCTIONS, LIST_SORTFUNCTION_VARIANTS):
229 Use better macro parameter names: s/basename/key_name/,
230 s/basefunc/key_cmp_func. Fix typo in comment.
232 2006-04-29 Eric Blake <ebb9@byu.net>
234 * src/ls.c (main): On systems with d_type, directories_first only
235 implies format_needs_type, not format_needs_stat.
237 2006-05-03 Jim Meyering <jim@meyering.net>
239 * src/ls.c (xstrcoll_df_version, rev_xstrcoll_df_version): Add space
240 after comma in arg list, from Eric Blake.
242 2006-04-25 Paul Eggert <eggert@cs.ucla.edu>
244 * tests/misc/date (relative-3): New test, derived from a bug
245 report by John Thomas McDole.
247 2006-04-23 Francesco Montorsi <fr_m@hotmail.com>
249 New option for ls: --group-directories-first.
250 It makes ls list directories before files.
251 * NEWS [New features]: Mention it.
252 * src/ls.c (sort_type): Rearrange to use as an array index when
253 choosing sort function; added new sort_numtypes member for
255 (time_type): Add new time_numtypes member for compile-time check.
256 (directories_first): New global variable.
257 (GROUP_DIRECTORIES_FIRST_OPTION): New enum.
258 (long_options): Add --directories-first.
259 (main): Support new option.
260 (is_directory): New function.
261 (extract_dirs_from_files): Use it.
262 (DIRFIRST_CHECK, DEFINE_SORT_FUNCTIONS)
263 (LIST_SORTFUNCTION_VARIANTS): New macros.
264 (sort_functions): New global variable.
265 (sort_files): Use it.
266 (usage): Document new option.
268 2006-04-18 Paul Eggert <eggert@cs.ucla.edu>
270 * src/shred.c (fillrand): The assertion was way too weak, due to
271 what must be a typo. Strengthen it to its intended value.
272 (dopass): Don't use alloca; it's not worth the aggravation here,
273 since it's used only to get a page-aligned buffer, and page
274 alignment doesn't buy us much here. I'm suspicious that alloca
275 causes problems on some hosts, due to a recent bug report by Adam
276 Waltman: http://bugs.gentoo.org/130246.
278 2006-04-18 Jim Meyering <jim@meyering.net>
280 * tests/misc/tty-eof: Add new programs, base64, sha224sum, sha256sum,
281 sha384sum, sha512sum.
283 2006-04-17 Paul Eggert <eggert@cs.ucla.edu>
285 * src/chmod.c (describe_change): Adjust to filemode changes.
286 * src/ls.c (HAVE_ST_DM_MODE): Remove; moved to ../lib/filemode.c.
287 (print_long_format): Use (new) filemodestring rather than
288 (old) mode_string, so that we get more file types right, at least
289 in theory. Adjust to filemode changes.
290 * src/stat.c (human_access): Likewise.
292 2006-04-18 Jim Meyering <jim@meyering.net>
294 * src/ptx.c (main) [DEFAULT_IGNORE_FILE]: Remove code to use a default
295 ignore file. This has never been enabled. Reported by Eric Blake.
297 2006-04-12 Paul Eggert <eggert@cs.ucla.edu>
299 * src/ln.c (linkfunc): Remove. This method ran into a compiler/linker
300 bug in Interix. Just call symlink or link directly. All uses changed.
301 * src/setuidgid.c (main) [! HAVE_SETGROUPS]: Don't call setgroups.
302 * src/stat.c (USE_STATVFS): New macro.
303 Include <sys/statvfs.h> and use statvfs only if USE_STATVFS.
304 (NAMEMAX_FORMAT): define a bit more clearly, now that the
305 statvfs-using code is a bit more regular.
306 * src/system.h (sync) [!HAVE_SYNC]: New macro.
308 2006-04-11 Paul Eggert <eggert@cs.ucla.edu>
310 * NEWS: csplit, nl, expr now conform to POSIX better, and are
311 more-compatible with traditional Unix, with respect to regular
313 * src/csplit.c (extract_regexp): Set re_syntax_options to a
314 value that is compatible with what POSIX requires.
315 * src/nl.c (build_type_arg): Likewise.
316 * src/expr.c (docolon): Likewise. Also, don't let anchors match
317 newline; this fixes an incompatibility with tradition and with POSIX.
318 Don't warn about leading ^. POSIX says it is unspecified whether
319 ^ is a special character, which means that implementations can
320 either treat it as special or not, but either way a warning is not
321 allowed (unless the regexp is otherwise invalid). Instead, anchor
322 the expression but treat ^ as an anchor; this is the traditional
323 behavior (e.g., Solaris 10).
324 (eval4, eval3, eval2): Treat non-numeric args, division by zero,
325 and the like as invalid expressions (exit status 2), not as
326 failure of 'expr' (exit status 3). This is more consistent with
328 * tests/expr/basic (fail-a): Adjust exit status to match new expr
329 behavior, for status 2 versus 3.
331 (bre1, bre2, bre3, bre4, bre5, bre6, bre7, bre8, bre9, bre10):
332 (bre11, bre12, bre13, bre14, bre15, bre16, bre17, bre18, bre19, bre20):
333 (bre21, bre22, bre23, bre24, bre25, bre26, bre27, bre28, bre29, bre30):
334 (bre31, bre32, bre33, bre34, bre35, bre36, bre37, bre38, bre39, bre40):
335 (bre41, bre42, bre43, bre44, bre45, bre46, bre47, bre48, bre49, bre50):
336 (bre51, bre52, bre53, bre54, bre55, bre56, bre57, bre58, bre59, bre60):
337 (bre61, bre62): New tests.
338 * tests/misc/csplit: Use \{...\} in test RE, to test that we're
342 * tests/du/long-from-unreachable: Solaris 8 sh doesn't understand
343 "if !". Do not assume that 'sed' can handle long, newline-free input.
344 * tests/du/long-sloop: Likewise. Evaluate expr once, not $n times.
346 2006-04-10 Paul Eggert <eggert@cs.ucla.edu>
348 Adjust to new regex.h API (with new fastmap type), and clean
349 up the regex storage allocation a bit.
351 * src/csplit.c (struct control): Put re_compiled member at the
352 end, since it's large. Change regexpr member from char * to bool;
353 all uses changed. Add new member fastmap.
354 (extract_regexp): regexp arg is now char const *, not char *.
355 Don't bother duplicating the regular expression; it's not needed.
356 Set fastmap from new fastmap member. Don't bother allocating
357 a buffer, as the regexp code does a better job than we do.
358 * src/expr.c (docolon): Allocate and use a fastmap.
359 Don't bother allocating a buffer.
360 * src/nl.c (body_fastmap, header_fastmap, footer_fastmap):
362 (build_type_arg): New fastmap arg. All uses changed.
363 Don't bother allocating a buffer, but set a fastmap.
364 * src/ptx.c (context_regex_string, word_regex_string): Remove.
365 (context_regex, word_regex): New vars, replacing the above.
367 (struct regex_data): New type.
368 (compile_regex): Renamed from alloc_and_compile_regex, since
369 we no longer allocate storage. Arg is now a struct regex_data *,
370 not a const char *. All uses changed. Don't allocate the fastmap;
371 instead, take it from the caller. Don't convert size_t to int,
372 to avoid arithmetic overflow problems. Don't bother freeing
373 storage afterwards; it's not worth the aggravation.
374 * src/tac.c (compiled_separator_fastmap): New ver.
375 (main): Use it. Don't bother allocating a buffer.
377 2006-03-30 Jim Meyering <jim@meyering.net>
379 * src/dd.c (iwrite): Remove assignment without effect.
380 Reported by Felix Rauch Valenti.
382 2006-03-22 Eric Blake <ebb9@byu.net>
384 * src/ptx.c (usage): Remove mention of --copyright/-C.
385 (main): Alias --copyright to --version plus a deprecation warning.
386 * NEWS: Mention this.
388 2006-03-27 Jim Meyering <jim@meyering.net>
390 * src/Makefile.am (uptime_LDADD): Add $(POW_LIB), for uptime's
391 use of strtod. Tiny patch from Nickolai Zeldovich.
393 2006-03-11 Eric Blake <ebb9@byu.net>
395 * tests/misc/dirname: New file.
396 * tests/basename/Makefile.am: Delete.
397 * tests/basename/basic: Move to...
398 * tests/misc/basename: ... this new file. Add some tests,
399 including fixed behavior for //.
400 * tests/misc/Makefile.am (TESTS): Sort. Add basename, dirname.
401 * tests/Makefile.am (SUBDIRS): Remove basename.
402 * configure.ac (AC_CONFIG_FILES): Remove tests/basename.
404 Improvements to dirname/basename handling on platforms like
405 cygwin with distinct // and with drive letters.
406 * NEWS: Document new behavior.
407 * src/basename.c (main): Don't strip suffix from file system
409 * src/cp.c (target_directory_operand): Use new last_component.
410 (ASSIGN_BASENAME_STRDUPA): Likewise. Reduce time spent
411 traversing the string.
412 * src/dircolors.c (guess_shell_syntax): Use new last_component.
413 * src/install.c (target_directory_operand, install_file_in_dir):
415 * src/ln.c (target_directory_operand, main): Likewise.
416 * src/ls.c (basename_is_dot_or_dotdot): Likewise.
417 * src/mv.c (target_directory_operand, movefile): Likewise.
418 * src/remove.c (rm_1): Likewise.
419 * src/shred.c (wipename): Likewise.
420 * src/split.c (next_file_name): Likewise.
421 * src/su.c (log_su, run_shell): Likewise.
423 2006-03-23 Paul Eggert <eggert@cs.ucla.edu>
425 * NEWS: nohup diagnostics are now more precise, and nohup now
426 redirects stderr to nohup.out if stdout is closed and stderr is a tty.
427 * src/nohup.c (main): Implement this.
428 * tests/misc/nohup: Test the new behavior.
430 2006-03-12 Jim Meyering <jim@meyering.net>
432 * src/copy.c (set_author): Rename function, from preserve_author.
434 * src/remove.c (AD_pop_and_chdir): Use new macro,
435 CYCLE_CHECK_REFLECT_CHDIR_UP, rather than open-coding it.
437 * src/system.h (SAME_INODE): Remove definition.
438 Include "same-inode.h", instead.
440 2006-03-11 Eric Blake <ebb9@byu.net>
442 * src/pwd.c (robust_getcwd): Prepend only one slash, not two.
444 2006-03-10 Jim Meyering <jim@meyering.net>
446 Fix a bug whereby a user with write access to a directory being removed
447 could cause the removal of that directory to fail with an erroneous
448 diagnostic about a directory cycle. Reported by Vineet Chadha.
450 * NEWS: Mention this.
451 * src/remove.c (AD_pop_and_chdir): If the directory we're about to
452 leave (and try to rmdir) is the one whose dev_ino is being used to
453 detect a cycle, reset cycle_check_state.dev_ino to that of the parent.
455 2006-03-08 Paul Eggert <eggert@cs.ucla.edu>
457 * NEWS: Document dd's new 'directory' and 'nolinks' flags.
458 * src/dd.c (set_fd_flags): Handle file-creation flags on file
459 descriptors, rather than ignoring them.
460 * tests/dd/misc: Add test cases for append, nofollow, directory,
461 and nolinks flags. Simplify redirection to /dev/null in some cases.
463 * tests/dd/misc: iflags->iflag. This fixes a typo that meant the
464 noatime test never tested anything.
466 2006-03-05 Paul Eggert <eggert@cs.ucla.edu>
468 * src/dd.c (flags, usage): New flags directory, nolinks.
469 * src/system.h (O_NOLINKS): Define to 0 if not already defined.
471 * src/ls.c (usage): Mention that -f disables --color.
472 Problem reported by Niels Möller.
474 2006-03-03 Justin Pryzby <pryzbyj@justinpryzby.com>
476 * man/*.x: Add references to syscalls from utilities of the same name.
478 2006-03-05 Jim Meyering <jim@meyering.net>
480 * tests/help-version: Set SHELL, if not already set, in order to
481 avoid failure when `make check' is run through debuild; dircolors
482 would fail due to lack of $SHELL. Reported by Sven Joachim.
484 Make `base64 --wrap=N' work for N=0, and for N larger than SIZE_MAX.
485 * src/base64.c (wrap_write, do_encode, main): Change type of
486 parameters and locals, wrap_column, form size_t to uintmax_t.
487 (main): Adjust to use xstrtoumax, accordingly.
489 2006-03-03 Jim Meyering <jim@meyering.net>
491 Don't fail when run from an environment with SHELL not a Bourne
492 shell, e.g. `env SHELL=/bin/csh make check' would fail this test.
493 * tests/dircolors/simple: Invoke each non-failing test with -b.
494 Reported by Michael Stone.
496 2006-02-27 Jim Meyering <jim@meyering.net>
498 * tests/misc/base64: Derive --decode-using tests from the
501 * tests/misc/base64: Factor out a long constant string.
502 Split lines to stay within 80 columns.
504 * tests/misc/Makefile.am (TESTS): Add base64.
505 * tests/misc/base64: Test base64. From Simon Josefsson.
507 * src/base64.c (do_decode): Use correct type for parameter,
508 ignore_garbage: s/size_t/bool/.
510 * src/base64.c: Don't include .h files already included by system.h:
511 <string.h>, <stdlib.h>, <stdbool.h>, <limits.h>, <errno.h>.
512 Include "system.h" before the other lib/*.h header files.
513 Include <sys/types.h> before "system.h".
514 (wrap_write): Remove declaration of unused local, initial_column.
515 (wrap_write): Correct declaration syntax: s/size_t * V/size_t *V/.
517 * README: Add base64 to the list.
519 2006-02-17 Simon Josefsson <jas@extundo.com>
522 * AUTHORS: Mention base64.
524 * man/Makefile.am: Build base64.1.
525 * man/base64.x: New file.
526 * src/Makefile.am (bin_PROGRAMS): Add base64.
527 * src/base64.c: New file.
529 2006-02-25 Eric Blake <ebb9@byu.net>
531 In ls, avoid calling stat for --inode (-i), when possible.
532 * src/pwd.c (NOT_AN_INODE_NUMBER, D_INO): Move to ...
533 * src/system.h: ... here, for use in ...
534 * src/ls.c (main): ... here. Prefer dirent.d_ino to stat when
536 (gobble_file): Add inode argument.
537 (print_dir): Pass inode if available.
538 (usage): Remove inaccuracy.
540 2006-02-23 Jim Meyering <jim@meyering.net>
542 * TODO: Update/correct some obsolete entries.
544 2006-02-20 Paul Eggert <eggert@cs.ucla.edu>
546 * doc/coreutils.texi (join invocation): Mention `sort -k 1b,1'.
547 * src/join.c (usage): Likewise.
548 Documentation problem reported by Philip Kensche.
550 2006-02-20 Eric Blake <ebb9@byu.net>
552 * man/rm.x: Update documentation to match previous patch.
554 2006-02-18 Eric Blake <ebb9@byu.net>
556 New option for rm: --interactive=once (-I).
557 * NEWS: Document it, along with change to rm --interactive.
558 * TODO: Remove entry for implementing rm -I
559 * src/rm.c (INTERACTIVE_OPTION): New enum value.
560 (interactive_type): New enum.
561 (long_opts): Let interactive take an optional argument.
562 (interactive_args, interactive_types): New option arguments.
563 (usage): Document -I, --interactive=WHEN. Use program_name
564 instead of a basename.
565 (main): New -I option, new behavior to --interactive.
566 * tests/rm/interactive-once: New tests.
567 * tests/rm/interactive-always: Ditto.
568 * tests/rm/Makefile.am (TESTS): Run them.
570 2006-02-18 Jim Meyering <jim@meyering.net>
572 * Makefile.maint (sc_two_space_separator_in_usage): Make the regular
573 expression match more of the target lines, e.g., those that start with
574 `-S,' (short option followed by a comma) or that include `=[...]'.
575 Patch by Nicolas François.
576 Fix the four offenders thus exposed:
577 * src/join.c (usage): Use two spaces (not one) to separate the
578 --first-only option string from its description, so help2man formats
579 the derived man page properly.
580 * src/pr.c (usage): Likewise.
581 * src/uniq.c (usage): Likewise.
582 * src/install.c (usage): Likewise.
584 2006-02-15 Jim Meyering <jim@meyering.net>
586 * Makefile.maint (alpha beta major): For `make major', ensure that the
587 version string is of the form N.N[.N]*, where N is one or more digits.
589 2006-02-14 Jim Meyering <jim@meyering.net>
591 * INSTALL: Update from gnulib.
593 2006-02-13 Jim Meyering <jim@meyering.net>
595 * GNUmakefile (all): Emit diagnostics to stderr, not stdout.
597 2006-02-12 Jim Meyering <jim@meyering.net>
599 * Makefile.maint (patch-check): New target.
600 (local-checks-available): Add to the list.
602 2006-02-11 Jim Meyering <jim@meyering.net>
604 * src/c99-to-c89.diff: New file.
605 * src/Makefile.am (EXTRA_DIST): Add c99-to-c89.diff.
607 * .x-po-check: New file, with exclusions so that `make distcheck'
609 * Makefile.am (EXTRA_DIST): Add .x-po-check.
611 rm -r must remove an empty directory, even if it is inaccessible.
612 * src/remove.c (close_preserve_errno): New function.
613 (fd_to_subdirp): Don't print a diagnostic in this function.
614 Do it from the callers instead, unless rmdir succeeds.
615 (remove_cwd_entries, remove_dir): Adjust callers.
616 * tests/rm/empty-inacc: New test for the above.
617 * tests/rm/Makefile.am (TESTS): Add empty-inacc.
618 * NEWS: Mention this bug fix.
619 * tests/rm/rm2: Adjust two expected diagnostics, now that they're
620 a tiny bit less precise: cannot remove `a/1': ... instead of
621 cannot open directory `a/1': ...
623 * Makefile.maint (syntax-check-rules): Automatically derive this
624 list of sc_-prefixed rule names.
626 2006-02-10 Paul Eggert <eggert@cs.ucla.edu>
628 * Makefile.maint (CVS_LIST): Don't assume cvsu is available.
629 (CVS_LIST_EXCEPT): New macro, to simplify exception-processing.
630 Most uses of CVS_LIST changed to use CVS_LIST_EXCEPT.
631 (syntax-check-rules): Bring back sc_changelong. (Hmm, why did it
632 go away? was that an accident?)
633 (sc_cast_of_argument_to_free, sc_cast_of_x_alloc_return_value):
634 (sc_cast_of_alloca_return_value, sc_space_tab, sc_prohibit_atoi_atof):
635 (sc_error_exit_success, sc_file_system, sc_no_if_have_config_h):
636 (sc_system_h_headers, sc_sun_os_names, sc_trailing_blank):
637 (sc_two_space_separator_in_usage, sc_unmarked_diagnostics):
638 (sc_obsolete_symbols, sc_changelog, sc_prohibit_jm_in_m4):
639 (sc_useless_cpp_parens, makefile-check, m4-check, po-check):
640 (author_mark_check, makefile_path_separator_check):
641 Output line numbers, to simplify navigation of Emacs *compilation*
643 (sc_prohibit_atoi_atof, sc_file_system):
644 Rework slightly so that Makefile.maint doesn't get reported as a
645 violation of its own syntax rules.
646 (sc_dd_max_sym_length): Use ifneq to do nothing, instead of doing
647 it at run-time (which didn't work with Bison). Fix a makefile typo,
648 caught by Makefile.maint itself: spaces where a tab should be.
649 (po-check): Check lib/*.[ch] even if not in CVS; used by Bison,
650 which copies from ../gnulib/lib/*.[ch] to lib/*.[ch].
651 Ignore djgpp and man subdirectories, to avoid false matches with
652 Bison and coreutils, respectively. Use sort -u to remove the
653 resulting duplicates.
654 * gnupload: Rework slightly to avoid bogus warning from
655 sc_two_space_separator_in_usage.
657 2006-02-10 Jim Meyering <jim@meyering.net>
659 Use gzip's --rsyncable option only if it's available.
660 * Makefile.maint (gzip_rsyncable): New variable.
663 2006-02-08 Jim Meyering <jim@meyering.net>
665 * Makefile.maint (local-checks-available): Define in terms of
666 the expansion, $(syntax-check-rules), rather than the single,
667 top-level target `syntax-check', so that it's easier to exclude
668 individual rules (via $(local-checks-to-skip)).
669 (tgz-md5, tgz-sha1, ...): Remove now-unused definitions.
671 2006-02-07 Jim Meyering <jim@meyering.net>
673 * src/system.h (!defined O_DIRECT): If O_DIRECTIO is defined (as it
674 is on Tru64), define O_DIRECT to that. Patch From James Lemley.
676 * tests/help-version (expected_failure_status_vdir):
677 Redirect an expected disk-full diagnostic to /dev/null.
679 2006-02-06 Jim Meyering <jim@meyering.net>
681 * src/unexpand.c (usage): Use two spaces (not one) to separate the
682 --first-only option string from its description, so help2man formats
683 the derived man page properly.
684 * src/rm.c (usage): Likewise for --no-preserve-root.
685 * src/chown.c (usage): Likewise.
686 * src/chgrp.c (usage): Likewise.
688 Add a rule to ensure that the above doesn't happen again.
689 * Makefile.maint (sc_two_space_separator_in_usage): New rule.
690 (syntax-check-rules): Add it.
691 * .x-sc_two_space_separator_in_usage: New empty file.
692 * Makefile.am (EXTRA_DIST): Add .x-sc_two_space_separator_in_usage.
694 2006-02-06 Jim Meyering <jim@meyering.net>
696 * src/cp.c (usage): Use two spaces (not one) to separate each
697 option string from its description, so help2man formats the
698 derived man page properly.
699 * src/mv.c (usage): Likewise.
700 Patch from Nicolas François in http://bugs.debian.org/351601.
702 2006-02-04 Jim Meyering <jim@meyering.net>
704 * src/copy.c (copy_internal): cp -RL would fail when encountering
705 the same directory more than once in the hierarchy beneath a single
706 command-line argument. That is legitimate, e.g. when there are
707 two or more symbolic links, each pointing to some directory that
708 would not otherwise be copied. Reported by Christophe LYON.
709 * tests/cp/cp-deref: New file. Test for today's fix.
710 * tests/cp/Makefile.am (TESTS): Add cp-deref.
711 * NEWS: Document this.
713 2006-02-03 Jim Meyering <jim@meyering.net>
715 * configure.ac: Require automake-1.9.6, not 1.8.3.
717 2006-02-01 Paul Eggert <eggert@cs.ucla.edu>
719 * src/od.c (usage): Mention that -t a ignores high order bit.
720 Documentation problem reported by Ed Avis.
722 2006-02-01 Jim Meyering <jim@meyering.net>
724 * src/pwd.c (find_dir_entry): Remove unused local, `ent_sb_valid'.
726 2006-01-30 Paul Eggert <eggert@cs.ucla.edu>
728 * src/head.c (main): Use a better diagnostic when someone uses a
729 trailing numeric option in an invalid way. Problem reported by
731 * src/tail.c (parse_options): Likewise.
733 2006-01-30 Jim Meyering <jim@meyering.net>
735 * man/wc.x: Include `count' keyword in man page synopsis,
736 per suggestion from http://bugs.debian.org/181585.
738 2006-01-24 Paul Eggert <eggert@cs.ucla.edu>
740 * src/df.c (show_dev): If the file system claims to have
741 more available than total blocks, report the number of used
742 blocks as being total - available (a negative number) rather
743 than as garbage. Problem reported by Toralf Foerster.
745 2006-01-24 Jim Meyering <jim@meyering.net>
747 * src/tail.c (tail_forever): Don't exit-nonzero when an attempt
748 to put a regular file in O_NONBLOCK mode fails with EPERM.
749 That happens on Linux (up to 2.6.15) when using tail -f on a file with
750 the append-only attribute. Reported by Dean Gaudet. For details,
751 see http://savannah.gnu.org/bugs/?func=detailitem&item_id=15473.
752 * NEWS: Mention this fix.
753 * tests/tail-2/append-only: New file. Test for the above.
754 * tests/tail-2/Makefile.am (TESTS): Add append-only.
755 * tests/Makefile.am (check-root): Add tail-2/append-only
757 2006-01-21 Jim Meyering <jim@meyering.net>
759 * NEWS: Mention fts-related improvements and bug fixes.
761 2006-01-19 Jim Meyering <jim@meyering.net>
763 * tests/fmt/basic (pfx-1, pfx-2): New tests, to demonstrate the bug
764 reported as http://bugs.debian.org/147577. Forwarded by Thomas Hood.
766 2006-01-18 Jim Meyering <jim@meyering.net>
768 * tests/du/Makefile.am (TESTS): Add long-from-unreadable.
770 2006-01-17 Jim Meyering <jim@meyering.net>
772 Now that fts no longer changes the current working directory, adjust
773 its clients accordingly -- note that du.c uses fts but doesn't need
774 any adjustment, since it doesn't operate on the actual files,
775 but rather just uses the stat buffers provided by fts.
777 * src/chown-core.c: Include "openat.h".
778 Don't include "lchown.h".
779 (restricted_chown): Accept a new parameter, CWD_FD, and use it in
780 calling openat, lchownat, chownat, rather than open, lchown, chown.
782 * src/chmod.c: Include "openat.h".
783 (process_file): Use chmodat (fts->fts_cwd_fd,... in place of chmod (...
785 * tests/du/long-from-unreadable: New test, to exercise one small
788 2006-01-13 Jim Meyering <jim@meyering.net>
790 * tests/Makefile.am (SUBDIRS): Add comments discouraging the
791 addition of new directories under tests/.
793 * tests/acl: Redirect stdin to /dev/null. Otherwise, FreeBSD 5.0's
796 2006-01-12 Jim Meyering <jim@meyering.net>
798 * tests/du/long-sloop: Adjust not to hard-code the expected
799 diagnostic corresponding to ELOOP. Solaris' diagnostic differs
800 from that of GNU libc. Reported by Paul Eggert.
802 * tests/du/long-sloop: Create file at end of symlink chain.
804 * tests/misc/test: New file, with a test for one of the
805 bugs fixed by yesterday's test.c changes.
806 * tests/misc/Makefile.am (TESTS): Add test.
808 2006-01-11 Jim Meyering <jim@meyering.net>
810 * tests/du/long-sloop: New file. Test for today's fts.c bug fix.
811 That bug could make du -L, chgrp -L, or chown -L fail to diagnose
812 a very long sequence of symbolic links (not necessarily a loop).
813 * tests/du/Makefile.am (TESTS): Add long-sloop.
815 2006-01-11 Paul Eggert <eggert@cs.ucla.edu>
817 * src/test.c (test_syntax_error): Append a newline. All callers
818 changed, except for the ones that didn't already append a newline.
819 Bug reported by Eric Blake.
821 2006-01-11 Jim Meyering <jim@meyering.net>
823 * src/system.h (X2NREALLOC): Now that verify_true is no longer
824 void, cast its result to void, to avoid gcc's warning that
825 ``left-hand operand of comma expression has no effect''.
826 (DECIMAL_DIGIT_ACCUMULATE, X2REALLOC): Likewise.
828 2006-01-10 Jim Meyering <jim@meyering.net>
830 * tests/chmod/no-x: Add a test for today's fts.c fix.
832 2006-01-10 Jim Meyering <jim@meyering.net> (tiny change)
834 * src/ls.c (gobble_file): Use DTTOIF only if it's defined.
835 This is necessary for Dragonfly. Patch by Joerg Sonnenberger.
837 2006-01-10 Paul Eggert <eggert@cs.ucla.edu>
839 * src/system.h (X2NREALLOC, X2REALLOC, DECIMAL_DIGIT_ACCUMULATE):
840 Use verify_true instead of verify_expr, to sync with gnulib.
842 2006-01-08 Jim Meyering <jim@meyering.net>
844 * src/date.c (usage): Adjust the formatting of the entries for
845 %::z and %:::z (separate with two spaces, not one) so that help2man
846 formats them properly. Reported by Philip Rowlands.
848 2006-01-06 Paul Eggert <eggert@cs.ucla.edu>
850 * configure.ac (gl_IGNORE_UNUSED_LIBRARIES): Add.
852 2006-01-06 Jim Meyering <jim@meyering.net>
854 * Makefile.maint (copyright-check): Use date +%Y in place of
857 * src/remove.c (rm_1): Remove `static' attribute on local `status'.
858 First off, the attribute should have been `volatile' (not static)
859 to avoid longjmp-related risk of clobber. Secondly, now there is
860 no longer any risk of a local variable being clobbered, so there's
861 no need for any attribute at all.
863 2006-01-05 Jim Meyering <jim@meyering.net>
865 * src/remove.c: Give a few functions the inline attribute.
866 (AD_pop_and_chdir): Use gotos to avoid some duplication.
867 (AD_push): Rewrite an assertion so that the entire computation
868 goes away when assertions are turned off.
870 * src/tail.c (ENOSYS) [!defined ENOSYS]: Don't define here.
871 It's already defined in "system.h".
872 * Makefile.maint: Add a FIXME comment.
874 2006-01-04 Jim Meyering <jim@meyering.net>
876 * ChangeLog: Remove entries from 2005-10-22 and earlier.
877 * ChangeLog-2005: New file, for entries up to version 5.92.
879 2006-01-03 Jim Meyering <jim@meyering.net>
881 * tests/du/no-x: Also allow a slightly different diagnostic -- the
882 one you get when using openat-enabled fts.c and du (coming soon).
883 * tests/chmod/no-x: Likewise.
884 * tests/chgrp/no-x: Likewise.
886 * src/system.h (O_DIRECTORY) [!defined O_DIRECTORY]: Define.
888 2006-01-02 Paul Eggert <eggert@cs.ucla.edu>
890 * src/chown-core.c (RC_do_ordinary_chown): New enum value.
891 (restricted_chown): Return it, if the file cannot be accessed due
892 to EPERM, or if no uid or gid are required, or if the file is
893 neither a directory nor a regular file. Rewrite to avoid gotos.
894 (change_file_owner): Handle RC_do_ordinary_chown case.
895 Rewrite to avoid gotos.
896 * tests/chgrp/basic: Make sure we can change the group of
899 * src/date.c (usage): Explain %g, %G, and %V a bit better.
901 2006-01-02 Jim Meyering <jim@meyering.net>
903 * src/copy.c (set_owner): Correct a comment.
905 * src/tail.c (parse_options): Change warning to say that --retry
906 is useful `mainly' (not `only') when following by name.
907 Reported here: http://bugs.debian.org/273781
909 2006-01-01 Paul Eggert <eggert@cs.ucla.edu>
911 * NEWS: Document that mkfifo and mknod -m no longer set special bits.
912 * src/copy.c: Include lchmod.h.
913 (copy_internal): Use lchmod rather than chmod.
914 * src/cp.c: Include lchmod.h.
915 (re_protect, make_dir_parents_private): Use lchmod rather than chmod.
916 * src/mkdir.c: Include lchmod.h.
917 (usage): Clarify -m's operation.
918 (main): Use lchmod rather than chmod. Don't use lchmod unless the
919 new mode contains bits outside the 777 range.
920 * src/mkfifo.c (usage): Clarify -m's operation.
921 (main): If -m is given, don't invoke chmod; use umask 0 instead.
922 Report an error if -m asks for bits outside the 777 range.
923 * src/mknod.c (usage, main): Likewise.
925 * src/mkdir.c, src/mkfifo.c, src/mknod.c: Undo 2005-12-19 changes.
927 2005-12-27 Jim Meyering <jim@meyering.net>
929 * Makefile.maint (sc_obsolete_symbols): Prohibit use of O_NDELAY.
930 (sc_prohibit_assert_without_use): New rule.
931 (syntax-check-rules): Add it to the list.
932 * .x-sc_prohibit_assert_without_use: New empty file.
933 * Makefile.am (EXTRA_DIST): Add it.
935 * Makefile.maint (CVS_LIST): Define in terms of $(srcdir).
937 * cp.c, df.c, link.c, mknod.c, nice.c, sleep.c, unlink.c:
938 Don't include <assert.h>; it wasn't used.
940 2005-12-26 Paul Eggert <eggert@cs.ucla.edu>
942 * src/chown-core.c (restricted_chown):
943 Don't try O_WRONLY unless O_RDONLY failed wth EACCES.
944 * src/remove.c (fd_to_subdirp): Open with O_DIRECTORY | O_NOCTTY
945 | O_NOFOLLOW too, for consistency with other dir-openers.
946 Use POSIX-preferred O_NONBLOCK rather than O_NDELAY.
947 (is_empty_dir): Likewise.
948 * src/shred.c (wipename): Likewise. Don't bother trying to open
949 dir for writing, since POSIX prohibits it.
951 2005-12-22 Jim Meyering <jim@meyering.net>
953 * tests/help-version: Redirect stderr to /dev/full, to suppress
954 write error diagnostic.
956 2005-12-19 Jim Meyering <jim@meyering.net>
958 * src/mkdir.c, src/mknod.c, src/mkfifo.c (main)
959 Avoid a minor race condition when `-m MODE' is specified, by using
960 open, fchown, and close rather than just chown. To do that reliably --
961 even with an overly restrictive umask -- ensure that each mkdir,
962 mknod and mkfifo call uses a mode including at least owner-read access.
963 * src/mknod.c (main): When `-m MODE' is specified, exit nonzero if
964 the subsequent chown (or equivalent open,fchown,close) fails.
965 * tests/misc/mknod: New tests.
966 * tests/misc/Makefile.am (TESTS): Add mknod.
968 2005-12-17 Jim Meyering <jim@meyering.net>
970 * src/remove.c (is_empty_dir): Open with O_NDELAY, so we don't hang,
971 e.g., on a named pipe.
972 (OPEN_NO_FOLLOW_SYMLINK): Remove definition. Use O_NOFOLLOW in
973 place of all uses, since it is guaranteed (system.h) to be defined.
975 2005-12-05 Andreas Gruenbacher <agruen@suse.de>
977 Add POSIX ACL support
978 * src/ls.c: Switch back from HAVE_ACL to USE_ACL: The acl() syscall
979 is no requirement for ACL support; particularly, it does not exist
980 on systems that have POSIX ACLs.
981 * src/copy.h (cp_option_init) [umask_kill]: Remove member.
982 * src/cp.c (umask_kill): With default acls, the umask is not to be
983 applied. Remove umask_kill, don't change the process umask, and let
984 the kernel apply the umask where appropriate.
985 * src/cp.c (make_dir_parents_private): Fix logic for POSIX ACLs.
986 * src/copy.c (get_dest_mode): Remove; it is obsolete after removing
988 (copy_reg, copy_internal): Use copy_acl and set_acl
989 instead of fchown/chown. Fix the logic for POSIX ACLs.
990 (chown_succeded): Remove; we now always copy acls and
991 preserve S_ISUID, S_ISGID, and S_ISVTX when needed, no matter if we
992 did a chown before or not.
993 * src/mv.c, src/install.c (cp_option_init): Don't set umask_kill member.
994 * src/Makefile.am (dir_LDADD, ls_LDADD, vdir_LDADD, cp_LDADD,
995 mv_LDADD, ginstall_LDADD): On systems with an ACL library, arrange
996 to link with it via $(LIB_ACL), for the utilities that need it.
998 2005-12-16 Paul Eggert <eggert@cs.ucla.edu>
1000 * src/remove.c (OPENAT_CWD_RESTORE__REQUIRE): Remove.
1001 (OPENAT_CWD_RESTORE__ALLOW_FAILURE): Likewise.
1002 (fd_to_subdirp): Remove openat_cwd_restore_allow_failure arg; its
1003 value is now signified by whether cwd_errno is null.
1004 (fd_to_subdirp, remove_dir, rm_1); Change cwd failure indicator from
1005 pointer-to-bool to pointer-to-errno-value. All callers changed.
1006 (rm_1): Don't bother setting a local cwd failure flag and then
1007 ORing it into the caller's. Just set the caller's.
1008 (rm): Use cwd failure errno value to print a slightly-better
1011 2005-12-15 Jim Meyering <jim@meyering.net>
1013 * src/stat.c (print_it): Properly handle a backslash at the
1014 end of a --printf format string. Reported by Paul Eggert.
1015 * tests/misc/stat-printf (end-bs): Add a test for the above.
1017 2005-12-15 Paul Eggert <eggert@cs.ucla.edu>
1019 * tests/acl: Port to pre-POSIX shells like Solaris 8 /bin/sh.
1020 Don't assume /etc/passwd contains user names; use 'id' instead.
1022 2005-12-15 Jim Meyering <jim@meyering.net>
1024 stat: revert behavior of --format=FMT (-c)
1025 stat: add new option: --printf=FMT
1026 * NEWS: Mention this.
1027 * src/stat.c (isodigit, octtobin, hextobin): Define.
1028 (PRINTF_OPTION): Define.
1029 (interpret_backslash_escapes, trailing_delim): New globals.
1030 (usage): Document them. Alphabetize on long option names.
1031 (print_esc_char): New function.
1032 (print_it): Rewrite, in order to handle backslash escapes.
1033 (main): Handle new option. Set globals for --format, too.
1035 * tests/misc/stat-printf: Test --printf and --format.
1036 * tests/misc/Makefile.am (TESTS): Add stat-printf.
1038 2005-12-14 Paul Eggert <eggert@cs.ucla.edu>
1040 * NEWS: sort now reports incompatible options.
1041 * src/sort.c (incompatible_options, check_ordering_compatibility):
1043 (main): Use them. Don't bother with a usage message for
1044 "sort -c a b", for consistency with other error diagnostics.
1045 * tests/sort/Test.pm (incompat1, incompat2, incompat3, incompat4):
1048 * src/cat.c (main): Undo previous change. close_stdout already
1049 does the check, so the previous change wasn't necessary.
1051 2005-12-13 Paul Eggert <eggert@cs.ucla.edu>
1053 * src/cat.c (main): Check for close (STDOUT_FILENO) failure.
1055 2005-12-12 Paul Eggert <eggert@cs.ucla.edu>
1057 Install a more-conservative approach for sort -R. It's the
1058 same basic idea as the existing code, except it uses the full ISAAC
1059 approach (called the "more kosher" approach in the existing comments).
1060 This makes "sort -R" quite a bit slower (about a factor of 2 on my
1061 little tests involving 10000 lines on a 2.4 GHz P4), but I think it's
1062 better to be conservative here at first, and review any performance
1063 improvements carefully.
1064 * .x-sc_require_config_h: Add src/rand-isaac.c.
1065 * src/rand-isaac.h: Remove. All uses now simply include rand-isaac.c.
1066 * src/Makefile.am (noinst_HEADERS): Remove rand-isaac.h.
1067 (shred_SOURCES, sort_SOURCES): Remove.
1068 (EXTRA_DIST): Add rand-isaac.c.
1069 * src/rand-isaac.c: Revert to what used to be in shred.c, without
1070 changing it to allow for varying numbers of words in the state.
1071 Alter so that we include rand-isaac.c directly rather than
1072 compiling it and linking to it. Don't include config.h or
1073 system.h; that's the includer's responsibility.
1074 Omit functions that are specific to shred.
1075 (ISAAC_LOG, ISAAC_WORDS, ISAAC_BYTES, struct isaac_state, ind):
1076 (isaac_step, struct irand_state):
1077 Resurrect these, with the same defns that used to be in shred.c.
1078 (ISAAC_SIZE, isaac_new, isaac_copy): Remove.
1079 (isaac_refill, isaac_seed_start, isaac_seed_data, irand_init, irand32):
1081 (struct isaac_state, isaac_refill, isaac_mix, isaac_init):
1082 (isaac_seed_start, isaac_seed_data, isaac_seed_finish, isaac_seed):
1083 (irand_init, irand32, irand_mod):
1084 Number of words is constant again.
1085 (struct irand_state, irand_init, irand32, irand_mod): Move to shred.c.
1086 * src/shred.c: Include rand-isaac.c rather than rand-isaac.h.
1087 * src/sort.c: Likewise.
1088 * src/shred.c (fillrand, dopass, main): Undo previous change.
1089 (struct irand_state, irand_init, irand32, irand_mod): Moved back here,
1091 * src/sort.c: Don't include md5.h; it wasn't needed.
1092 (struct keyfield): Rename random_hash to random, for consistency
1093 with the other member names. All uses changed.
1094 (usage): Tweak wording to mention STRING for --seed option.
1095 (short_options): Rorder for consistency with other programs.
1096 (rand_state): Now a struct, not a pointer to one. All uses changed.
1097 (HASH_WORDS, HASH_SIZE): Remove.
1098 (get_hash): Remove comments around resbuf size, since we can assume C89.
1099 Use a "more-kosher" (but slower) approach of invoking isaac_refill.
1100 (keycompare): Adjust to the new get_hash.
1102 (badfieldspec): Omit recently-introduced comment; it isn't needed.
1103 (main): Don't set need_random simply because gkey has it set; that
1104 doesn't necessarily mean we'll need random numbers.
1105 Redo seeding to match new get_hash approach.
1107 2005-12-10 Jim Meyering <jim@meyering.net>
1109 * src/Makefile.am (noinst_HEADERS): Add rand-isaac.h.
1111 Avoid shred segfault on 64-bit systems.
1112 * src/rand-isaac.c (isaac_refill): Don't try to negate a
1113 local of type uint32_t. Make the local an `int' instead.
1115 * NEWS: Mention sort's new options.
1117 * src/rand-isaac.c (isaac_mix): Declare to be static.
1118 Mark all other functions as `extern' so the tight-scope
1119 part of `make distcheck' passes once again.
1120 * src/rand-isaac.h (isaac_mix): Remove declaration.
1122 * src/sort.c (get_hash): Change position of `*' in parameter
1123 type to conform with convention.
1124 (main): Split a long line so it fits in 80 columns.
1125 (keycompare): Remove stray SPACE before TAB that was
1126 causing `make distcheck' to fail.
1128 * src/shred.c: Don't include gethrxtime.h. No longer needed.
1130 * tests/misc/sort-rand: New file: basic tests for the new options.
1131 * tests/misc/Makefile.am (TESTS): Add sort-rand.
1133 2005-12-10 Frederik Eaton <frederik@ofb.net>
1135 * src/Makefile.am (sort_LDADD): Add $(LIB_GETHRXTIME).
1136 (shred_SOURCES, sort_SOURCES): New macros, so we compile rand-isaac.c.
1137 * src/rand-isaac.c: New file, containing ISAAC code that was in shred.c.
1138 Make state size runtime-configurable.
1139 (isaac_new, isaac_copy): New functions.
1140 * src/rand-isaac.h: New file.
1141 * src/shred.c: Include rand-isaac.h. Move ISAAC code to rand-isaac.c.
1142 (fillrand, main): Adjust to the fact that the state size is now
1143 runtime-configurable.
1144 * src/sort.c (short_options, long_options, WORDS, keycompare, main):
1145 (usage): Add options --random-sort and --seed to implement a random
1147 Include md5.h and rand-isaac.h.
1148 (get_hash): New function.
1149 (rand_state): New var.
1150 (HASH_WORDS, HASH_SIZE): New macros.
1152 2005-12-09 Paul Eggert <eggert@cs.ucla.edu>
1154 * tests/dd/misc: Add test for dd iflags=noatime.
1156 2005-12-09 Jim Meyering <jim@meyering.net>
1158 * src/sort.c (usage): Mention white space vs -b and -t options.
1161 2005-12-09 Eric Blake <ebb9@byu.net>
1163 * src/test.c (main): Fix misleading comment.
1165 2005-12-07 Paul Eggert <eggert@cs.ucla.edu>
1167 * NEWS: Mention dd's new noatime flag.
1168 * src/system.h (O_NOATIME): Define to 0 if not already defined.
1169 * src/dd.c (flags, usage): Add support for noatime flag.
1171 2005-12-07 Jim Meyering <jim@meyering.net>
1173 Distribute the cvsu script, used only by `make syntax-check'.
1174 * Makefile.am (EXTRA_DIST): Add build-aux/cvsu.
1175 * Makefile.maint (CVS_LIST): Use build-aux/cvsu, now that we
1176 distribute a copy of this script.
1177 * .x-sc_unmarked_diagnostics: Add build-aux/cvsu.
1179 * tests/mv/acl: exit-77 before the trap, not after, if we fail
1180 to create a temporary directory on another partition.
1181 From Andreas Gruenbacher.
1183 2005-12-06 Tomas Pospisek <tpo@sourcepole.ch> (tiny change)
1185 * man/basename.x: Cross-reference to dirname and readlink.
1186 * man/dirname.x: Cross-reference to basename and readlink.
1188 2005-12-05 Andreas Gruenbacher
1190 * src/copy.c [!HAVE_FCHOWN]: Define fchown(...) to -1.
1191 (set_owner, preserve_author): New functions, factored out of copy_reg.
1192 (copy_reg): Use them.
1193 (copy_internal): Use them here, too.
1195 2005-12-04 Jim Meyering <jim@meyering.net>
1197 * src/sleep.c (usage): Say what happens with two or more arguments.
1198 Suggested by Justin Pryzby.
1200 * src/uptime.c (print_uptime): Move decl of `upsecs' into scope
1203 2005-12-03 Jim Meyering <jim@meyering.net>
1205 * src/rm.c (long_opts): Change the name of each undocumented, for-
1206 testing-only option to start with `-', so that it cannot render
1207 ambiguous any prefix it happens to share with some other option name.
1208 Problem reported by Eric Blake.
1209 * src/head.c (long_options): Likewise.
1210 * src/tail.c (long_options): Likewise.
1212 * tests/misc/head-elide-tail: Update uses of undocumented, for-
1213 testing-only --presume* options to start with `---'.
1214 * tests/rm/dangling-symlink: Likewise.
1215 * tests/rm/dir-no-w: Likewise.
1216 * tests/rm/isatty: Likewise.
1218 2005-11-30 Jim Meyering <jim@meyering.net>
1220 * Makefile.maint: Add a comment about cvsu.
1222 2005-11-25 Paul Eggert <eggert@cs.ucla.edu>
1224 * NEWS: df updates for "none", "proc", inaccessible file systems.
1225 * src/df.c (show_point): Ignore inaccessible file systems.
1226 (usage): -a includes dummy file systems, not size-0 file systems.
1228 * src/od.c (unsigned_long_long_int): Renamed from ulonglong_t,
1229 to avoid collision with POSIX name space. All uses changed.
1231 2005-11-24 Jim Meyering <jim@meyering.net>
1233 * tests/Makefile.am (EXTRA_DIST): Add acl to the list.
1234 * tests/acl: Add `$0: ' prefix to diagnostics.
1236 * .x-sc_require_config_h: Add lib/buffer-lcm.c to the list.
1238 2005-11-23 Paul Eggert <eggert@cs.ucla.edu>
1240 * src/copy.c: Improve performance a bit by optimizing away
1241 unnecessary system calls and going to a block size of at least
1242 8192 (on normal hosts, anyway). This improved performance 5% on my
1243 Debian stable host (2.4.27 kernel, x86, copying from root
1244 ext3 file system to itself).
1245 Include "buffer-lcm.h".
1246 (copy_reg): Omit last argument. All callers changed.
1247 Use xmalloc to allocate rather than trusting alloca
1248 (which is unwise with large block sizes).
1249 Declare locals more locally, if possible.
1250 Use uintptr_t words instead of int words, for a bit more speed
1251 when looking for null blocks on 64-bit hosts.
1252 Optimize away reads of zero bytes on regular files.
1253 In the typical case, insist on 8 KiB buffers, at least.
1254 Avoid unnecessary extra call to fstat when checking for sparse files.
1255 Avoid now-unnecessary cast to off_t, and "0L".
1256 Avoid unnecessary test of *new_dst when checking for same owner
1259 2005-11-22 Paul Eggert <eggert@cs.ucla.edu>
1261 * src/remove.c (rm): Don't assume C99 for-loop syntax.
1263 2005-11-22 Jim Meyering <jim@meyering.net>
1265 * src/remove.c (AD_push): Remove debugging cruft.
1267 * tests/rm/unread2 (rm): Change expected diagnostic,
1268 `cannot open directory' to `cannot remove', to align with
1270 * tests/rm/rm2: Ensure that rm now continues removing entries
1271 even after certain types of failure.
1273 * src/remove.c: Rewrite. Now, this module is reentrant on systems
1274 that provide openat (Solaris), and on systems like Linux+procfs
1275 where our openat emulation code is reentrant. This also fixes a
1276 few low-probability leaks and eliminates some code that could,
1277 in very unusual circumstances, cause rm() (via a callee) to exit.
1278 * NEWS: Mention this.
1280 * configure.ac: Put copyright dates all on one line so the
1281 emacs function that updates them works properly.
1283 2005-11-18 Paul Eggert <eggert@cs.ucla.edu>
1285 * configure.ac (AM_PROG_CC_C_O): Add. Needed for CVS Automake.
1286 Problem reported by Eric Blake.
1287 (AC_PROG_CC_STDC): Use this instead of AC_PROG_CC, so that
1288 we get a standard-conforming compiler. This relies on the new
1289 m4/c.m4 file. Note that it's a bit tricky, since c.m4 doesn't
1290 define AC_PROG_CC_STDC; we are relying on Autoconf 2.59 internals.
1291 m4/c.m4 can go away with Autoconf 2.60 comes out.
1293 2005-11-17 Jim Meyering <jim@meyering.net>
1295 * src/remove.c (AD_mark_helper): Make a `char *' parameter `const'.
1296 (AD_mark_current_as_unremovable): Likewise, but for a local.
1299 * tests/mv/acl: Let traps handle removing temporary directories.
1301 Expect acl-related tests to fail, until the corresponding
1302 patches are committed.
1303 * tests/mv/Makefile.am (XFAIL_TESTS): Add acl.
1304 * tests/cp/Makefile.am (XFAIL_TESTS): Likewise.
1306 ACL tests, from Andreas Gruenbacher.
1307 * tests/acl, tests/mv/acl, tests/cp/acl: New files.
1308 * tests/mv/Makefile.am (TESTS): Add acl.
1309 * tests/cp/Makefile.am (TESTS): Add acl.
1311 * src/ls.c (basename_is_dot_or_dotdot): Correct wording in comment.
1313 2005-11-16 Paul Eggert <eggert@cs.ucla.edu>
1315 * NEWS: Improve quality of ln's diagnostics.
1316 * src/ln.c (do_link, usage): Likewise.
1317 (do_link): Don't use alloca on a buffer of unbounded size.
1319 2005-11-16 Jim Meyering <jim@meyering.net>
1321 * tests/cp/fail-perm: Accommodate HPUX. It appears to fail
1322 with EACCES rather than EPERM. Reported by Peter O'Gorman here:
1323 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/5766
1324 This also affects AIX 4.3.3, according to Ralf Wildenhues, in
1325 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
1327 2005-11-14 Jim Meyering <jim@meyering.net>
1329 * NEWS (sort): Mention consequences of today's mkstemp-safer.c fix.
1331 2005-11-13 Jim Meyering <jim@meyering.net>
1333 * announce-gen: Accept new option, --gpg-key-id=ID and
1334 emit a blurb telling how to use the .sig files.
1335 * Makefile.cfg (gpg_key_ID): Define.
1336 * Makefile.maint (announcement): Use new option and key.
1338 Require that most .c files include <config.h>.
1339 * Makefile.maint (sc_require_config_h): New rule.
1340 (syntax-check-rules): Add it.
1341 * .x-sc_require_config_h: New file listing exceptions to the
1342 above rule. Some are legit, others are simply grandfathered in.
1343 * Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h here, too.
1345 2005-11-12 Jim Meyering <jim@meyering.net>
1347 * src/checksum.h, src/md5.c, src/sha1sum.c: Remove now-unused files.
1349 2005-11-11 Jim Meyering <jim@meyering.net>
1351 * NEWS: Mention `readlink -f' bug fix in 5.3.0 news.
1352 Mention new readlink options in 5.3.0's `New features' section.
1353 Spotted by Thomas Hood.
1355 2005-11-08 Jim Meyering <jim@meyering.net>
1357 * NEWS: Merge in changes from b5_9x branch.
1359 2005-11-08 Paul Eggert <eggert@cs.ucla.edu>
1361 * NEWS: ls now defaults to --time-style='locale', which in turn acts
1362 like --time-style='posix-long-iso' if the locale settings are messed up.
1363 * src/ls.c (decode_switches): Implement this.
1365 2005-11-08 Jim Meyering <jim@meyering.net>
1367 * tests/du/2g: s/expensive/very expensive/ in a comment.
1370 2005-10-17 Eric Blake <ebb9@byu.net>
1372 * src/ls.c (usage): Fix descriptions of --sort, --time.
1373 Reported by Vitaly A. Ostanin.
1375 2005-11-04 Paul Eggert <eggert@cs.ucla.edu>
1377 * src/ln.c: Include filenamecat.c.
1378 (FILE_BASENAME_CONCAT): Remove.
1379 (do_link): Remove last arg DEST_IS_DIR. All callers changed.
1380 (main): Use file_name_concat, base_name, and strip_trailing_slashes
1381 instead of FILE_BASENAME_CONCAT. This simplifies the code, and avoids
1384 2005-11-04 Jim Meyering <jim@meyering.net>
1386 * src/du.c (process_file): Don't overflow for files of size >= 2^31
1387 on systems with stat.st_blocks of a signed 32-bit type.
1388 This bug causes trouble on some AIX 5.1 systems.
1389 Report and trivial patch from Paul Townsend:
1390 <http://lists.gnu.org/archive/html/bug-coreutils/2005-11/msg00033.html>
1391 * NEWS: Mention this.
1393 * tests/du/2g: New (very-expensive) test for the above-fixed bug.
1394 * tests/du/Makefile.am (TESTS): Add it here.
1395 * tests/very-expensive: New file.
1396 * tests/Makefile.am (EXTRA_DIST): Add it here.
1397 * tests/cp/perm: Mark this test as `very-expensive', too.
1399 2005-11-02 Paul Eggert <eggert@cs.ucla.edu>
1401 * NEWS: Mention that rm -d and maybe ln -d are scheduled for
1403 * src/remove.h (struct rm_options): Remove unlink_dirs. All uses
1405 * src/rm.c (usage): Don't mention rm -d.
1407 2005-11-02 Jim Meyering <jim@meyering.net>
1409 * tests/dd/skip-seek: Fix typo in comment: s/fileutils/coreutils.
1410 From Andreas Schwab.
1412 * tests/dd/unblock-sync: Redirect stderr to /dev/null so the
1413 `M+N records in/out' lines don't pollute `make check' output.
1415 * tests/dd/skip-seek (sk-seek4): New test, to exercise the bug
1416 fixed on 2005-10-31. This test uses the new, IN_PIPE specifier.
1417 * tests/Coreutils.pm: Accept a new type of input specifier: IN_PIPE,
1418 to indicate that the input file should be piped into the command
1419 under test (via `cat FILE | $prog ...').
1421 * src/remove.c (remove_entry): Emit a better diagnostic when rm
1422 (without -r) fails to remove a directory on a non-Linux system.
1423 This change affects only newer Solaris systems (with priv_*
1424 functions like priv_allocset). Reported by Keith Thompson.
1426 * tests/rm/dir-nonrecur: New file/test for the above fix.
1427 * tests/rm/Makefile.am (TESTS): Add dir-nonrecur.
1429 2005-11-01 Paul Eggert <eggert@cs.ucla.edu>
1431 * NEWS: "tail -c 2 FILE" and "touch 0101000000" now operate as
1432 POSIX 1002.1-2001 requires.
1433 * src/tail.c (parse_obsolete_option): Implement this.
1434 Problem reported by Vincent Lefevre.
1435 * src/touch.c (main): Pass PDS_PRE_2000 to posixtime.
1436 * tests/tail/Test.pm (c-2, c-2-minus, c2, c2-minus): New tests.
1437 (test_vector): Add special cases for _POSIX2_VERSION, and
1438 regularize the old ones a bit.
1439 * tests/touch/obsolescent: Add y2000 test.
1441 2005-10-31 Paul Eggert <eggert@cs.ucla.edu>
1443 * src/dd.c (skip): Fix off-by-one error reported by
1444 Theodoros V. Kalamatianos.
1446 2005-10-30 Paul Eggert <eggert@cs.ucla.edu>
1448 * tests/mkdir/p-3: Require that the test be run as non-root.
1449 Problem and trivial fix reported by Theodoros V. Kalamatianos.
1451 2005-10-28 Paul Eggert <eggert@cs.ucla.edu>
1453 * src/ln.c (FILE_BASENAME_CONCAT): Omit unnecessary slashes in the
1454 boundary between DEST and SOURCE in the result.
1456 2005-10-26 Dmitry V. Levin <ldv@altlinux.org>
1458 * src/md5sum.c (main) [!O_BINARY]: Changed default read mode
1459 back to text, to sync with documentation and for backwards
1462 2005-10-25 Jim Meyering <jim@meyering.net>
1464 * tests/dircolors/simple (other-wr): Add an explicit test for
1465 the dircolors bug (NULL-dereference) fixed yesterday.
1467 2005-10-24 Jim Meyering <jim@meyering.net>
1469 * src/tac.c (tac_file): When determining whether a file is seekable,
1470 also test whether it is a tty. Using only the lseek-based test would
1471 give a false positive on Solaris. Reported by Peter Fales.
1473 2005-10-24 Dmitry V. Levin <ldv@altlinux.org>
1475 * tests/install/d-slashdot: New test, for "install -d" failure.
1476 * tests/install/Makefile.am (TESTS): Add d-slashdot.
1477 * tests/mkdir/p-slashdot: New test, for "mkdir -p" failure.
1478 * tests/mkdir/Makefile.am (TESTS): Add p-slashdot.
1480 2005-10-24 Jim Meyering <jim@meyering.net>
1482 * src/dircolors.c (ls_codes): Add missing comma.
1483 Anonymous report and patch from
1484 http://savannah.gnu.org/bugs/?func=detailitem&item_id=14849
1486 * src/dircolors.c: Add compile-time assertion that the slack_codes
1487 and ls_codes arrays have the same number of elements. This would
1488 have prevented the above-fixed bug.
1490 * src/expand.c (parse_tab_stops): Add a comment to make this function
1491 identical to the one in unexpand.c.
1492 * src/unexpand.c (parse_tab_stops): Adjust syntax to make this function
1493 identical to the one in expand.c.
1495 * src/expand.c (next_file): Don't assume fopen cannot return stdin.
1497 2005-10-23 Jim Meyering <jim@meyering.net>
1499 * src/md5sum.c (digest_check, main): Use ptr_align rather than
1500 a dangerous pointer-value-to-`unsigned' cast.
1501 * NEWS: mention the new sha* programs.
1502 * AUTHORS: Add new sha* programs.
1504 2005-08-28 David Madore <david.madore@ens.fr>
1506 Add new programs: sha224sum, sha256sum, sha384sum, sha512sum.
1507 * README: Add their names to the list.
1508 * src/md5sum.c: Provide framework for computing sha-2 hashes.
1509 * src/Makefile.am (sha224sum, sha256sum, sha384sum, sha512sum):
1510 Rules for compiling sha-2 utilities
1511 (noinst_HEADERS): Remove checksum.h.
1512 * man/sha512sum.x, man/sha384sum.x, man/sha256sum.x, man/sha224sum.x:
1514 * man/Makefile.am (dist_man_MANS): Add the corresponding .1 names.
1515 (sha224sum.1, sha256sum.1, sha384sum.1, sha512sum.1): New dependencies.
1516 * tests/misc/sha224sum, tests/misc/sha256sum: New files.
1517 * tests/misc/sha384sum, tests/misc/sha512sum: New files.
1518 * tests/misc/Makefile.am (TESTS): Add new sha224sum, sha256sum,
1519 sha384sum, sha512sum test scripts here rather that each in its
1522 2005-08-28 David Madore <david.madore@ens.fr>
1524 * tests/sha1sum/basic-1 (million-a): Add the "million a's" test (one
1525 of the FIPS test vectors).
1527 2005-10-23 Jim Meyering <jim@meyering.net>
1529 * configure.ac: Use 6.0-cvs as the version string.
1530 * NEWS: Adjust accordingly.