1 2006-06-03 Jim Meyering <jim@meyering.net>
5 Make `cp --link --no-dereference' work also on systems where the
6 link system call cannot create a hard link to a symbolic link.
7 * src/copy.c (copy_internal) [LINK_FOLLOWS_SYMLINKS]: Don't use
8 the link syscall on a symlink when it would do the wrong thing.
9 Based on the patch by Aurelien Jarno: <http://bugs.debian.org/329451>
10 * tests/cp/link-no-deref: New file/test for the above.
11 * tests/cp/Makefile.am (TESTS): Add link-no-deref.
12 * NEWS: Mention the change (doesn't affect Linux).
14 2006-06-01 Paul Eggert <eggert@cs.ucla.edu>
16 Fix some porting problems in the test cases reported by
17 Ralf Wildenhues for HP-UX 11.23 in:
18 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00238.html
19 * tests/help-version: Don't assume that \< \> works in sed.
20 * tests/misc/close-stdout: Don't assume that >&- works.
22 * tests/touch/no-create-missing: Don't assume that >&- works.
24 2006-05-30 Jim Meyering <jim@meyering.net>
26 * src/ls.c (usage): Add `v' to the list of sorting-related options.
29 2006-05-28 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
31 * tests/cp/fail-perm: source lang-default.
32 * tests/rm/inaccessible: Likewise.
34 2006-05-28 Jim Meyering <jim@meyering.net>
36 * tests/rm/inaccessible: AIX 4.3.3 gives a different diagnostic.
37 Recognize it, too. Reported by Ralf Wildenhues, in
38 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
40 2006-05-27 Jim Meyering <jim@meyering.net>
42 * src/chgrp.c: Support new options: --preserve-root and
43 --no-preserve-root. Somehow this program was skipped when those
44 options were added to chown, chmod, and rm. Reported by
45 vaqflabuopac@spammotel.com in <http://bugs.debian.org/365656>.
48 2006-05-25 Paul Eggert <eggert@cs.ucla.edu>
50 * NEWS: Remove mention of --seed. We'll replace it with something
51 better, and don't want to indicate that it is supported.
52 * src/sort.c (usage): Likewise.
54 2006-05-20 Jim Meyering <jim@meyering.net>
56 * src/chmod.c (main): Use FTS_PHYSICAL here, too.
58 * src/du.c (main): Rename local, s/symlink_deref_bit/symlink_deref_bits/
59 and arrange for -D to set fts' FTS_PHYSICAL bit as well as
60 FTS_COMFOLLOW. Spotted by Justin Pryzby.
62 * gnupload: Merge changes from automake, retaining the ""--to...
63 kludge to placate overzealous `make distcheck' check.
65 2006-05-19 Jim Meyering <jim@meyering.net>
67 * src/du.c (main): Don't let -D, -L, or -P turn off the internal
68 FTS_TIGHT_CYCLE_CHECK directory traversal option.
69 Reported by Justin Pryzby in http://bugs.debian.org/367691
71 2006-05-15 Jim Meyering <jim@meyering.net>
73 * src/cp.c (usage): Correct description of -a: s/-dpR/-dpPR/.
76 2006-05-13 Jim Meyering <jim@meyering.net>
78 * tests/mv/no-target-dir: Test two more cases.
80 2006-05-11 Jim Meyering <jim@meyering.net>
82 mv -T DIR EMPTY_DIR no longer fails unconditionally
83 * src/copy.c (copy_internal): Don't manually prohibit a move where
84 the destination is an existing directory. Sometimes doing that is
85 valid. Let the rename system call enforce the rules. That is
86 allowed only when the source is a directory and the destination
87 directory (to be replaced) is empty. Reported by Eric Blake.
88 * tests/mv/no-target-dir: New file/test for this.
89 * tests/mv/Makefile.am (TESTS): Add no-target-dir.
92 * tests/mv/atomic: New file/test for yesterday's fix.
93 * tests/mv/Makefile.am (TESTS): Add atomic.
95 * tests/du/long-sloop: Avoid harmless `ambiguous redirect' diagnostic.
97 2006-05-10 Jim Meyering <jim@meyering.net>
99 * src/copy.c (copy_internal): Don't explicitly unlink the destination
100 when moving a symlink into the place of an existing non-directory.
101 Reported by Joshua Hudson.
102 * NEWS: mention this.
104 2006-05-07 Jim Meyering <jim@meyering.net>
106 * Makefile.maint (patch-check): Fail if patch generates any output,
107 even merely for changed offsets.
109 * src/c99-to-c89.diff: Adjust to reflect new offsets.
111 * NEWS: Mention changes affecting df, pwd, shred.
113 2006-05-06 Jim Meyering <jim@meyering.net>
115 * tests/ls/stat-vs-dirent: New test, to detect the bogus file
116 system condition where dirent.d_ino != stat.st_ino.
117 * tests/ls/Makefile.am (TESTS): Add stat-vs-dirent.
119 2006-05-06 Eric Blake <ebb9@byu.net>
121 * tests/ls/inode: Expand to test inode from readdir case.
122 * tests/ls/follow-slink: Expand to test broken links encountered
123 implicitly, favoring Solaris 9 and OpenBSD 3.4 behavior.
125 2006-05-06 Eric Blake <ebb9@byu.net>
127 * tests/mv/leak-fd: Work even on case-insensitive file system.
129 2006-05-04 Jim Meyering <jim@meyering.net>
131 * NEWS: Mention the 2006-03-19 pwd-related change that makes
132 lib/getcwd.c work around inconsistent file system dirent.d_ino data.
134 2006-05-03 Jim Meyering <jim@meyering.net>
136 * src/ls.c (DEFINE_SORT_FUNCTIONS, LIST_SORTFUNCTION_VARIANTS):
137 Use better macro parameter names: s/basename/key_name/,
138 s/basefunc/key_cmp_func. Fix typo in comment.
140 2006-04-29 Eric Blake <ebb9@byu.net>
142 * src/ls.c (main): On systems with d_type, directories_first only
143 implies format_needs_type, not format_needs_stat.
145 2006-05-03 Jim Meyering <jim@meyering.net>
147 * src/ls.c (xstrcoll_df_version, rev_xstrcoll_df_version): Add space
148 after comma in arg list, from Eric Blake.
150 2006-04-25 Paul Eggert <eggert@cs.ucla.edu>
152 * tests/misc/date (relative-3): New test, derived from a bug
153 report by John Thomas McDole.
155 2006-04-23 Francesco Montorsi <fr_m@hotmail.com>
157 New option for ls: --group-directories-first.
158 It makes ls list directories before files.
159 * NEWS [New features]: Mention it.
160 * src/ls.c (sort_type): Rearrange to use as an array index when
161 choosing sort function; added new sort_numtypes member for
163 (time_type): Add new time_numtypes member for compile-time check.
164 (directories_first): New global variable.
165 (GROUP_DIRECTORIES_FIRST_OPTION): New enum.
166 (long_options): Add --directories-first.
167 (main): Support new option.
168 (is_directory): New function.
169 (extract_dirs_from_files): Use it.
170 (DIRFIRST_CHECK, DEFINE_SORT_FUNCTIONS)
171 (LIST_SORTFUNCTION_VARIANTS): New macros.
172 (sort_functions): New global variable.
173 (sort_files): Use it.
174 (usage): Document new option.
176 2006-04-18 Paul Eggert <eggert@cs.ucla.edu>
178 * src/shred.c (fillrand): The assertion was way too weak, due to
179 what must be a typo. Strengthen it to its intended value.
180 (dopass): Don't use alloca; it's not worth the aggravation here,
181 since it's used only to get a page-aligned buffer, and page
182 alignment doesn't buy us much here. I'm suspicious that alloca
183 causes problems on some hosts, due to a recent bug report by Adam
184 Waltman: http://bugs.gentoo.org/130246.
186 2006-04-18 Jim Meyering <jim@meyering.net>
188 * tests/misc/tty-eof: Add new programs, base64, sha224sum, sha256sum,
189 sha384sum, sha512sum.
191 2006-04-17 Paul Eggert <eggert@cs.ucla.edu>
193 * src/chmod.c (describe_change): Adjust to filemode changes.
194 * src/ls.c (HAVE_ST_DM_MODE): Remove; moved to ../lib/filemode.c.
195 (print_long_format): Use (new) filemodestring rather than
196 (old) mode_string, so that we get more file types right, at least
197 in theory. Adjust to filemode changes.
198 * src/stat.c (human_access): Likewise.
200 2006-04-18 Jim Meyering <jim@meyering.net>
202 * src/ptx.c (main) [DEFAULT_IGNORE_FILE]: Remove code to use a default
203 ignore file. This has never been enabled. Reported by Eric Blake.
205 2006-04-12 Paul Eggert <eggert@cs.ucla.edu>
207 * src/ln.c (linkfunc): Remove. This method ran into a compiler/linker
208 bug in Interix. Just call symlink or link directly. All uses changed.
209 * src/setuidgid.c (main) [! HAVE_SETGROUPS]: Don't call setgroups.
210 * src/stat.c (USE_STATVFS): New macro.
211 Include <sys/statvfs.h> and use statvfs only if USE_STATVFS.
212 (NAMEMAX_FORMAT): define a bit more clearly, now that the
213 statvfs-using code is a bit more regular.
214 * src/system.h (sync) [!HAVE_SYNC]: New macro.
216 2006-04-11 Paul Eggert <eggert@cs.ucla.edu>
218 * NEWS: csplit, nl, expr now conform to POSIX better, and are
219 more-compatible with traditional Unix, with respect to regular
221 * src/csplit.c (extract_regexp): Set re_syntax_options to a
222 value that is compatible with what POSIX requires.
223 * src/nl.c (build_type_arg): Likewise.
224 * src/expr.c (docolon): Likewise. Also, don't let anchors match
225 newline; this fixes an incompatibility with tradition and with POSIX.
226 Don't warn about leading ^. POSIX says it is unspecified whether
227 ^ is a special character, which means that implementations can
228 either treat it as special or not, but either way a warning is not
229 allowed (unless the regexp is otherwise invalid). Instead, anchor
230 the expression but treat ^ as an anchor; this is the traditional
231 behavior (e.g., Solaris 10).
232 (eval4, eval3, eval2): Treat non-numeric args, division by zero,
233 and the like as invalid expressions (exit status 2), not as
234 failure of 'expr' (exit status 3). This is more consistent with
236 * tests/expr/basic (fail-a): Adjust exit status to match new expr
237 behavior, for status 2 versus 3.
239 (bre1, bre2, bre3, bre4, bre5, bre6, bre7, bre8, bre9, bre10):
240 (bre11, bre12, bre13, bre14, bre15, bre16, bre17, bre18, bre19, bre20):
241 (bre21, bre22, bre23, bre24, bre25, bre26, bre27, bre28, bre29, bre30):
242 (bre31, bre32, bre33, bre34, bre35, bre36, bre37, bre38, bre39, bre40):
243 (bre41, bre42, bre43, bre44, bre45, bre46, bre47, bre48, bre49, bre50):
244 (bre51, bre52, bre53, bre54, bre55, bre56, bre57, bre58, bre59, bre60):
245 (bre61, bre62): New tests.
246 * tests/misc/csplit: Use \{...\} in test RE, to test that we're
250 * tests/du/long-from-unreachable: Solaris 8 sh doesn't understand
251 "if !". Do not assume that 'sed' can handle long, newline-free input.
252 * tests/du/long-sloop: Likewise. Evaluate expr once, not $n times.
254 2006-04-10 Paul Eggert <eggert@cs.ucla.edu>
256 Adjust to new regex.h API (with new fastmap type), and clean
257 up the regex storage allocation a bit.
259 * src/csplit.c (struct control): Put re_compiled member at the
260 end, since it's large. Change regexpr member from char * to bool;
261 all uses changed. Add new member fastmap.
262 (extract_regexp): regexp arg is now char const *, not char *.
263 Don't bother duplicating the regular expression; it's not needed.
264 Set fastmap from new fastmap member. Don't bother allocating
265 a buffer, as the regexp code does a better job than we do.
266 * src/expr.c (docolon): Allocate and use a fastmap.
267 Don't bother allocating a buffer.
268 * src/nl.c (body_fastmap, header_fastmap, footer_fastmap):
270 (build_type_arg): New fastmap arg. All uses changed.
271 Don't bother allocating a buffer, but set a fastmap.
272 * src/ptx.c (context_regex_string, word_regex_string): Remove.
273 (context_regex, word_regex): New vars, replacing the above.
275 (struct regex_data): New type.
276 (compile_regex): Renamed from alloc_and_compile_regex, since
277 we no longer allocate storage. Arg is now a struct regex_data *,
278 not a const char *. All uses changed. Don't allocate the fastmap;
279 instead, take it from the caller. Don't convert size_t to int,
280 to avoid arithmetic overflow problems. Don't bother freeing
281 storage afterwards; it's not worth the aggravation.
282 * src/tac.c (compiled_separator_fastmap): New ver.
283 (main): Use it. Don't bother allocating a buffer.
285 2006-03-30 Jim Meyering <jim@meyering.net>
287 * src/dd.c (iwrite): Remove assignment without effect.
288 Reported by Felix Rauch Valenti.
290 2006-03-22 Eric Blake <ebb9@byu.net>
292 * src/ptx.c (usage): Remove mention of --copyright/-C.
293 (main): Alias --copyright to --version plus a deprecation warning.
294 * NEWS: Mention this.
296 2006-03-27 Jim Meyering <jim@meyering.net>
298 * src/Makefile.am (uptime_LDADD): Add $(POW_LIB), for uptime's
299 use of strtod. Tiny patch from Nickolai Zeldovich.
301 2006-03-11 Eric Blake <ebb9@byu.net>
303 * tests/misc/dirname: New file.
304 * tests/basename/Makefile.am: Delete.
305 * tests/basename/basic: Move to...
306 * tests/misc/basename: ... this new file. Add some tests,
307 including fixed behavior for //.
308 * tests/misc/Makefile.am (TESTS): Sort. Add basename, dirname.
309 * tests/Makefile.am (SUBDIRS): Remove basename.
310 * configure.ac (AC_CONFIG_FILES): Remove tests/basename.
312 Improvements to dirname/basename handling on platforms like
313 cygwin with distinct // and with drive letters.
314 * NEWS: Document new behavior.
315 * src/basename.c (main): Don't strip suffix from file system
317 * src/cp.c (target_directory_operand): Use new last_component.
318 (ASSIGN_BASENAME_STRDUPA): Likewise. Reduce time spent
319 traversing the string.
320 * src/dircolors.c (guess_shell_syntax): Use new last_component.
321 * src/install.c (target_directory_operand, install_file_in_dir):
323 * src/ln.c (target_directory_operand, main): Likewise.
324 * src/ls.c (basename_is_dot_or_dotdot): Likewise.
325 * src/mv.c (target_directory_operand, movefile): Likewise.
326 * src/remove.c (rm_1): Likewise.
327 * src/shred.c (wipename): Likewise.
328 * src/split.c (next_file_name): Likewise.
329 * src/su.c (log_su, run_shell): Likewise.
331 2006-03-23 Paul Eggert <eggert@cs.ucla.edu>
333 * NEWS: nohup diagnostics are now more precise, and nohup now
334 redirects stderr to nohup.out if stdout is closed and stderr is a tty.
335 * src/nohup.c (main): Implement this.
336 * tests/misc/nohup: Test the new behavior.
338 2006-03-12 Jim Meyering <jim@meyering.net>
340 * src/copy.c (set_author): Rename function, from preserve_author.
342 * src/remove.c (AD_pop_and_chdir): Use new macro,
343 CYCLE_CHECK_REFLECT_CHDIR_UP, rather than open-coding it.
345 * src/system.h (SAME_INODE): Remove definition.
346 Include "same-inode.h", instead.
348 2006-03-11 Eric Blake <ebb9@byu.net>
350 * src/pwd.c (robust_getcwd): Prepend only one slash, not two.
352 2006-03-10 Jim Meyering <jim@meyering.net>
354 Fix a bug whereby a user with write access to a directory being removed
355 could cause the removal of that directory to fail with an erroneous
356 diagnostic about a directory cycle. Reported by Vineet Chadha.
358 * NEWS: Mention this.
359 * src/remove.c (AD_pop_and_chdir): If the directory we're about to
360 leave (and try to rmdir) is the one whose dev_ino is being used to
361 detect a cycle, reset cycle_check_state.dev_ino to that of the parent.
363 2006-03-08 Paul Eggert <eggert@cs.ucla.edu>
365 * NEWS: Document dd's new 'directory' and 'nolinks' flags.
366 * src/dd.c (set_fd_flags): Handle file-creation flags on file
367 descriptors, rather than ignoring them.
368 * tests/dd/misc: Add test cases for append, nofollow, directory,
369 and nolinks flags. Simplify redirection to /dev/null in some cases.
371 * tests/dd/misc: iflags->iflag. This fixes a typo that meant the
372 noatime test never tested anything.
374 2006-03-05 Paul Eggert <eggert@cs.ucla.edu>
376 * src/dd.c (flags, usage): New flags directory, nolinks.
377 * src/system.h (O_NOLINKS): Define to 0 if not already defined.
379 * src/ls.c (usage): Mention that -f disables --color.
380 Problem reported by Niels Möller.
382 2006-03-03 Justin Pryzby <pryzbyj@justinpryzby.com>
384 * man/*.x: Add references to syscalls from utilities of the same name.
386 2006-03-05 Jim Meyering <jim@meyering.net>
388 * tests/help-version: Set SHELL, if not already set, in order to
389 avoid failure when `make check' is run through debuild; dircolors
390 would fail due to lack of $SHELL. Reported by Sven Joachim.
392 Make `base64 --wrap=N' work for N=0, and for N larger than SIZE_MAX.
393 * src/base64.c (wrap_write, do_encode, main): Change type of
394 parameters and locals, wrap_column, form size_t to uintmax_t.
395 (main): Adjust to use xstrtoumax, accordingly.
397 2006-03-03 Jim Meyering <jim@meyering.net>
399 Don't fail when run from an environment with SHELL not a Bourne
400 shell, e.g. `env SHELL=/bin/csh make check' would fail this test.
401 * tests/dircolors/simple: Invoke each non-failing test with -b.
402 Reported by Michael Stone.
404 2006-02-27 Jim Meyering <jim@meyering.net>
406 * tests/misc/base64: Derive --decode-using tests from the
409 * tests/misc/base64: Factor out a long constant string.
410 Split lines to stay within 80 columns.
412 * tests/misc/Makefile.am (TESTS): Add base64.
413 * tests/misc/base64: Test base64. From Simon Josefsson.
415 * src/base64.c (do_decode): Use correct type for parameter,
416 ignore_garbage: s/size_t/bool/.
418 * src/base64.c: Don't include .h files already included by system.h:
419 <string.h>, <stdlib.h>, <stdbool.h>, <limits.h>, <errno.h>.
420 Include "system.h" before the other lib/*.h header files.
421 Include <sys/types.h> before "system.h".
422 (wrap_write): Remove declaration of unused local, initial_column.
423 (wrap_write): Correct declaration syntax: s/size_t * V/size_t *V/.
425 * README: Add base64 to the list.
427 2006-02-17 Simon Josefsson <jas@extundo.com>
430 * AUTHORS: Mention base64.
432 * man/Makefile.am: Build base64.1.
433 * man/base64.x: New file.
434 * src/Makefile.am (bin_PROGRAMS): Add base64.
435 * src/base64.c: New file.
437 2006-02-25 Eric Blake <ebb9@byu.net>
439 In ls, avoid calling stat for --inode (-i), when possible.
440 * src/pwd.c (NOT_AN_INODE_NUMBER, D_INO): Move to ...
441 * src/system.h: ... here, for use in ...
442 * src/ls.c (main): ... here. Prefer dirent.d_ino to stat when
444 (gobble_file): Add inode argument.
445 (print_dir): Pass inode if available.
446 (usage): Remove inaccuracy.
448 2006-02-23 Jim Meyering <jim@meyering.net>
450 * TODO: Update/correct some obsolete entries.
452 2006-02-20 Paul Eggert <eggert@cs.ucla.edu>
454 * doc/coreutils.texi (join invocation): Mention `sort -k 1b,1'.
455 * src/join.c (usage): Likewise.
456 Documentation problem reported by Philip Kensche.
458 2006-02-20 Eric Blake <ebb9@byu.net>
460 * man/rm.x: Update documentation to match previous patch.
462 2006-02-18 Eric Blake <ebb9@byu.net>
464 New option for rm: --interactive=once (-I).
465 * NEWS: Document it, along with change to rm --interactive.
466 * TODO: Remove entry for implementing rm -I
467 * src/rm.c (INTERACTIVE_OPTION): New enum value.
468 (interactive_type): New enum.
469 (long_opts): Let interactive take an optional argument.
470 (interactive_args, interactive_types): New option arguments.
471 (usage): Document -I, --interactive=WHEN. Use program_name
472 instead of a basename.
473 (main): New -I option, new behavior to --interactive.
474 * tests/rm/interactive-once: New tests.
475 * tests/rm/interactive-always: Ditto.
476 * tests/rm/Makefile.am (TESTS): Run them.
478 2006-02-18 Jim Meyering <jim@meyering.net>
480 * Makefile.maint (sc_two_space_separator_in_usage): Make the regular
481 expression match more of the target lines, e.g., those that start with
482 `-S,' (short option followed by a comma) or that include `=[...]'.
483 Patch by Nicolas François.
484 Fix the four offenders thus exposed:
485 * src/join.c (usage): Use two spaces (not one) to separate the
486 --first-only option string from its description, so help2man formats
487 the derived man page properly.
488 * src/pr.c (usage): Likewise.
489 * src/uniq.c (usage): Likewise.
490 * src/install.c (usage): Likewise.
492 2006-02-15 Jim Meyering <jim@meyering.net>
494 * Makefile.maint (alpha beta major): For `make major', ensure that the
495 version string is of the form N.N[.N]*, where N is one or more digits.
497 2006-02-14 Jim Meyering <jim@meyering.net>
499 * INSTALL: Update from gnulib.
501 2006-02-13 Jim Meyering <jim@meyering.net>
503 * GNUmakefile (all): Emit diagnostics to stderr, not stdout.
505 2006-02-12 Jim Meyering <jim@meyering.net>
507 * Makefile.maint (patch-check): New target.
508 (local-checks-available): Add to the list.
510 2006-02-11 Jim Meyering <jim@meyering.net>
512 * src/c99-to-c89.diff: New file.
513 * src/Makefile.am (EXTRA_DIST): Add c99-to-c89.diff.
515 * .x-po-check: New file, with exclusions so that `make distcheck'
517 * Makefile.am (EXTRA_DIST): Add .x-po-check.
519 rm -r must remove an empty directory, even if it is inaccessible.
520 * src/remove.c (close_preserve_errno): New function.
521 (fd_to_subdirp): Don't print a diagnostic in this function.
522 Do it from the callers instead, unless rmdir succeeds.
523 (remove_cwd_entries, remove_dir): Adjust callers.
524 * tests/rm/empty-inacc: New test for the above.
525 * tests/rm/Makefile.am (TESTS): Add empty-inacc.
526 * NEWS: Mention this bug fix.
527 * tests/rm/rm2: Adjust two expected diagnostics, now that they're
528 a tiny bit less precise: cannot remove `a/1': ... instead of
529 cannot open directory `a/1': ...
531 * Makefile.maint (syntax-check-rules): Automatically derive this
532 list of sc_-prefixed rule names.
534 2006-02-10 Paul Eggert <eggert@cs.ucla.edu>
536 * Makefile.maint (CVS_LIST): Don't assume cvsu is available.
537 (CVS_LIST_EXCEPT): New macro, to simplify exception-processing.
538 Most uses of CVS_LIST changed to use CVS_LIST_EXCEPT.
539 (syntax-check-rules): Bring back sc_changelong. (Hmm, why did it
540 go away? was that an accident?)
541 (sc_cast_of_argument_to_free, sc_cast_of_x_alloc_return_value):
542 (sc_cast_of_alloca_return_value, sc_space_tab, sc_prohibit_atoi_atof):
543 (sc_error_exit_success, sc_file_system, sc_no_if_have_config_h):
544 (sc_system_h_headers, sc_sun_os_names, sc_trailing_blank):
545 (sc_two_space_separator_in_usage, sc_unmarked_diagnostics):
546 (sc_obsolete_symbols, sc_changelog, sc_prohibit_jm_in_m4):
547 (sc_useless_cpp_parens, makefile-check, m4-check, po-check):
548 (author_mark_check, makefile_path_separator_check):
549 Output line numbers, to simplify navigation of Emacs *compilation*
551 (sc_prohibit_atoi_atof, sc_file_system):
552 Rework slightly so that Makefile.maint doesn't get reported as a
553 violation of its own syntax rules.
554 (sc_dd_max_sym_length): Use ifneq to do nothing, instead of doing
555 it at run-time (which didn't work with Bison). Fix a makefile typo,
556 caught by Makefile.maint itself: spaces where a tab should be.
557 (po-check): Check lib/*.[ch] even if not in CVS; used by Bison,
558 which copies from ../gnulib/lib/*.[ch] to lib/*.[ch].
559 Ignore djgpp and man subdirectories, to avoid false matches with
560 Bison and coreutils, respectively. Use sort -u to remove the
561 resulting duplicates.
562 * gnupload: Rework slightly to avoid bogus warning from
563 sc_two_space_separator_in_usage.
565 2006-02-10 Jim Meyering <jim@meyering.net>
567 Use gzip's --rsyncable option only if it's available.
568 * Makefile.maint (gzip_rsyncable): New variable.
571 2006-02-08 Jim Meyering <jim@meyering.net>
573 * Makefile.maint (local-checks-available): Define in terms of
574 the expansion, $(syntax-check-rules), rather than the single,
575 top-level target `syntax-check', so that it's easier to exclude
576 individual rules (via $(local-checks-to-skip)).
577 (tgz-md5, tgz-sha1, ...): Remove now-unused definitions.
579 2006-02-07 Jim Meyering <jim@meyering.net>
581 * src/system.h (!defined O_DIRECT): If O_DIRECTIO is defined (as it
582 is on Tru64), define O_DIRECT to that. Patch From James Lemley.
584 * tests/help-version (expected_failure_status_vdir):
585 Redirect an expected disk-full diagnostic to /dev/null.
587 2006-02-06 Jim Meyering <jim@meyering.net>
589 * src/unexpand.c (usage): Use two spaces (not one) to separate the
590 --first-only option string from its description, so help2man formats
591 the derived man page properly.
592 * src/rm.c (usage): Likewise for --no-preserve-root.
593 * src/chown.c (usage): Likewise.
594 * src/chgrp.c (usage): Likewise.
596 Add a rule to ensure that the above doesn't happen again.
597 * Makefile.maint (sc_two_space_separator_in_usage): New rule.
598 (syntax-check-rules): Add it.
599 * .x-sc_two_space_separator_in_usage: New empty file.
600 * Makefile.am (EXTRA_DIST): Add .x-sc_two_space_separator_in_usage.
602 2006-02-06 Jim Meyering <jim@meyering.net>
604 * src/cp.c (usage): Use two spaces (not one) to separate each
605 option string from its description, so help2man formats the
606 derived man page properly.
607 * src/mv.c (usage): Likewise.
608 Patch from Nicolas François in http://bugs.debian.org/351601.
610 2006-02-04 Jim Meyering <jim@meyering.net>
612 * src/copy.c (copy_internal): cp -RL would fail when encountering
613 the same directory more than once in the hierarchy beneath a single
614 command-line argument. That is legitimate, e.g. when there are
615 two or more symbolic links, each pointing to some directory that
616 would not otherwise be copied. Reported by Christophe LYON.
617 * tests/cp/cp-deref: New file. Test for today's fix.
618 * tests/cp/Makefile.am (TESTS): Add cp-deref.
619 * NEWS: Document this.
621 2006-02-03 Jim Meyering <jim@meyering.net>
623 * configure.ac: Require automake-1.9.6, not 1.8.3.
625 2006-02-01 Paul Eggert <eggert@cs.ucla.edu>
627 * src/od.c (usage): Mention that -t a ignores high order bit.
628 Documentation problem reported by Ed Avis.
630 2006-02-01 Jim Meyering <jim@meyering.net>
632 * src/pwd.c (find_dir_entry): Remove unused local, `ent_sb_valid'.
634 2006-01-30 Paul Eggert <eggert@cs.ucla.edu>
636 * src/head.c (main): Use a better diagnostic when someone uses a
637 trailing numeric option in an invalid way. Problem reported by
639 * src/tail.c (parse_options): Likewise.
641 2006-01-30 Jim Meyering <jim@meyering.net>
643 * man/wc.x: Include `count' keyword in man page synopsis,
644 per suggestion from http://bugs.debian.org/181585.
646 2006-01-24 Paul Eggert <eggert@cs.ucla.edu>
648 * src/df.c (show_dev): If the file system claims to have
649 more available than total blocks, report the number of used
650 blocks as being total - available (a negative number) rather
651 than as garbage. Problem reported by Toralf Foerster.
653 2006-01-24 Jim Meyering <jim@meyering.net>
655 * src/tail.c (tail_forever): Don't exit-nonzero when an attempt
656 to put a regular file in O_NONBLOCK mode fails with EPERM.
657 That happens on Linux (up to 2.6.15) when using tail -f on a file with
658 the append-only attribute. Reported by Dean Gaudet. For details,
659 see http://savannah.gnu.org/bugs/?func=detailitem&item_id=15473.
660 * NEWS: Mention this fix.
661 * tests/tail-2/append-only: New file. Test for the above.
662 * tests/tail-2/Makefile.am (TESTS): Add append-only.
663 * tests/Makefile.am (check-root): Add tail-2/append-only
665 2006-01-21 Jim Meyering <jim@meyering.net>
667 * NEWS: Mention fts-related improvements and bug fixes.
669 2006-01-19 Jim Meyering <jim@meyering.net>
671 * tests/fmt/basic (pfx-1, pfx-2): New tests, to demonstrate the bug
672 reported as http://bugs.debian.org/147577. Forwarded by Thomas Hood.
674 2006-01-18 Jim Meyering <jim@meyering.net>
676 * tests/du/Makefile.am (TESTS): Add long-from-unreadable.
678 2006-01-17 Jim Meyering <jim@meyering.net>
680 Now that fts no longer changes the current working directory, adjust
681 its clients accordingly -- note that du.c uses fts but doesn't need
682 any adjustment, since it doesn't operate on the actual files,
683 but rather just uses the stat buffers provided by fts.
685 * src/chown-core.c: Include "openat.h".
686 Don't include "lchown.h".
687 (restricted_chown): Accept a new parameter, CWD_FD, and use it in
688 calling openat, lchownat, chownat, rather than open, lchown, chown.
690 * src/chmod.c: Include "openat.h".
691 (process_file): Use chmodat (fts->fts_cwd_fd,... in place of chmod (...
693 * tests/du/long-from-unreadable: New test, to exercise one small
696 2006-01-13 Jim Meyering <jim@meyering.net>
698 * tests/Makefile.am (SUBDIRS): Add comments discouraging the
699 addition of new directories under tests/.
701 * tests/acl: Redirect stdin to /dev/null. Otherwise, FreeBSD 5.0's
704 2006-01-12 Jim Meyering <jim@meyering.net>
706 * tests/du/long-sloop: Adjust not to hard-code the expected
707 diagnostic corresponding to ELOOP. Solaris' diagnostic differs
708 from that of GNU libc. Reported by Paul Eggert.
710 * tests/du/long-sloop: Create file at end of symlink chain.
712 * tests/misc/test: New file, with a test for one of the
713 bugs fixed by yesterday's test.c changes.
714 * tests/misc/Makefile.am (TESTS): Add test.
716 2006-01-11 Jim Meyering <jim@meyering.net>
718 * tests/du/long-sloop: New file. Test for today's fts.c bug fix.
719 That bug could make du -L, chgrp -L, or chown -L fail to diagnose
720 a very long sequence of symbolic links (not necessarily a loop).
721 * tests/du/Makefile.am (TESTS): Add long-sloop.
723 2006-01-11 Paul Eggert <eggert@cs.ucla.edu>
725 * src/test.c (test_syntax_error): Append a newline. All callers
726 changed, except for the ones that didn't already append a newline.
727 Bug reported by Eric Blake.
729 2006-01-11 Jim Meyering <jim@meyering.net>
731 * src/system.h (X2NREALLOC): Now that verify_true is no longer
732 void, cast its result to void, to avoid gcc's warning that
733 ``left-hand operand of comma expression has no effect''.
734 (DECIMAL_DIGIT_ACCUMULATE, X2REALLOC): Likewise.
736 2006-01-10 Jim Meyering <jim@meyering.net>
738 * tests/chmod/no-x: Add a test for today's fts.c fix.
740 2006-01-10 Jim Meyering <jim@meyering.net> (tiny change)
742 * src/ls.c (gobble_file): Use DTTOIF only if it's defined.
743 This is necessary for Dragonfly. Patch by Joerg Sonnenberger.
745 2006-01-10 Paul Eggert <eggert@cs.ucla.edu>
747 * src/system.h (X2NREALLOC, X2REALLOC, DECIMAL_DIGIT_ACCUMULATE):
748 Use verify_true instead of verify_expr, to sync with gnulib.
750 2006-01-08 Jim Meyering <jim@meyering.net>
752 * src/date.c (usage): Adjust the formatting of the entries for
753 %::z and %:::z (separate with two spaces, not one) so that help2man
754 formats them properly. Reported by Philip Rowlands.
756 2006-01-06 Paul Eggert <eggert@cs.ucla.edu>
758 * configure.ac (gl_IGNORE_UNUSED_LIBRARIES): Add.
760 2006-01-06 Jim Meyering <jim@meyering.net>
762 * Makefile.maint (copyright-check): Use date +%Y in place of
765 * src/remove.c (rm_1): Remove `static' attribute on local `status'.
766 First off, the attribute should have been `volatile' (not static)
767 to avoid longjmp-related risk of clobber. Secondly, now there is
768 no longer any risk of a local variable being clobbered, so there's
769 no need for any attribute at all.
771 2006-01-05 Jim Meyering <jim@meyering.net>
773 * src/remove.c: Give a few functions the inline attribute.
774 (AD_pop_and_chdir): Use gotos to avoid some duplication.
775 (AD_push): Rewrite an assertion so that the entire computation
776 goes away when assertions are turned off.
778 * src/tail.c (ENOSYS) [!defined ENOSYS]: Don't define here.
779 It's already defined in "system.h".
780 * Makefile.maint: Add a FIXME comment.
782 2006-01-04 Jim Meyering <jim@meyering.net>
784 * ChangeLog: Remove entries from 2005-10-22 and earlier.
785 * ChangeLog-2005: New file, for entries up to version 5.92.
787 2006-01-03 Jim Meyering <jim@meyering.net>
789 * tests/du/no-x: Also allow a slightly different diagnostic -- the
790 one you get when using openat-enabled fts.c and du (coming soon).
791 * tests/chmod/no-x: Likewise.
792 * tests/chgrp/no-x: Likewise.
794 * src/system.h (O_DIRECTORY) [!defined O_DIRECTORY]: Define.
796 2006-01-02 Paul Eggert <eggert@cs.ucla.edu>
798 * src/chown-core.c (RC_do_ordinary_chown): New enum value.
799 (restricted_chown): Return it, if the file cannot be accessed due
800 to EPERM, or if no uid or gid are required, or if the file is
801 neither a directory nor a regular file. Rewrite to avoid gotos.
802 (change_file_owner): Handle RC_do_ordinary_chown case.
803 Rewrite to avoid gotos.
804 * tests/chgrp/basic: Make sure we can change the group of
807 * src/date.c (usage): Explain %g, %G, and %V a bit better.
809 2006-01-02 Jim Meyering <jim@meyering.net>
811 * src/copy.c (set_owner): Correct a comment.
813 * src/tail.c (parse_options): Change warning to say that --retry
814 is useful `mainly' (not `only') when following by name.
815 Reported here: http://bugs.debian.org/273781
817 2006-01-01 Paul Eggert <eggert@cs.ucla.edu>
819 * NEWS: Document that mkfifo and mknod -m no longer set special bits.
820 * src/copy.c: Include lchmod.h.
821 (copy_internal): Use lchmod rather than chmod.
822 * src/cp.c: Include lchmod.h.
823 (re_protect, make_dir_parents_private): Use lchmod rather than chmod.
824 * src/mkdir.c: Include lchmod.h.
825 (usage): Clarify -m's operation.
826 (main): Use lchmod rather than chmod. Don't use lchmod unless the
827 new mode contains bits outside the 777 range.
828 * src/mkfifo.c (usage): Clarify -m's operation.
829 (main): If -m is given, don't invoke chmod; use umask 0 instead.
830 Report an error if -m asks for bits outside the 777 range.
831 * src/mknod.c (usage, main): Likewise.
833 * src/mkdir.c, src/mkfifo.c, src/mknod.c: Undo 2005-12-19 changes.
835 2005-12-27 Jim Meyering <jim@meyering.net>
837 * Makefile.maint (sc_obsolete_symbols): Prohibit use of O_NDELAY.
838 (sc_prohibit_assert_without_use): New rule.
839 (syntax-check-rules): Add it to the list.
840 * .x-sc_prohibit_assert_without_use: New empty file.
841 * Makefile.am (EXTRA_DIST): Add it.
843 * Makefile.maint (CVS_LIST): Define in terms of $(srcdir).
845 * cp.c, df.c, link.c, mknod.c, nice.c, sleep.c, unlink.c:
846 Don't include <assert.h>; it wasn't used.
848 2005-12-26 Paul Eggert <eggert@cs.ucla.edu>
850 * src/chown-core.c (restricted_chown):
851 Don't try O_WRONLY unless O_RDONLY failed wth EACCES.
852 * src/remove.c (fd_to_subdirp): Open with O_DIRECTORY | O_NOCTTY
853 | O_NOFOLLOW too, for consistency with other dir-openers.
854 Use POSIX-preferred O_NONBLOCK rather than O_NDELAY.
855 (is_empty_dir): Likewise.
856 * src/shred.c (wipename): Likewise. Don't bother trying to open
857 dir for writing, since POSIX prohibits it.
859 2005-12-22 Jim Meyering <jim@meyering.net>
861 * tests/help-version: Redirect stderr to /dev/full, to suppress
862 write error diagnostic.
864 2005-12-19 Jim Meyering <jim@meyering.net>
866 * src/mkdir.c, src/mknod.c, src/mkfifo.c (main)
867 Avoid a minor race condition when `-m MODE' is specified, by using
868 open, fchown, and close rather than just chown. To do that reliably --
869 even with an overly restrictive umask -- ensure that each mkdir,
870 mknod and mkfifo call uses a mode including at least owner-read access.
871 * src/mknod.c (main): When `-m MODE' is specified, exit nonzero if
872 the subsequent chown (or equivalent open,fchown,close) fails.
873 * tests/misc/mknod: New tests.
874 * tests/misc/Makefile.am (TESTS): Add mknod.
876 2005-12-17 Jim Meyering <jim@meyering.net>
878 * src/remove.c (is_empty_dir): Open with O_NDELAY, so we don't hang,
879 e.g., on a named pipe.
880 (OPEN_NO_FOLLOW_SYMLINK): Remove definition. Use O_NOFOLLOW in
881 place of all uses, since it is guaranteed (system.h) to be defined.
883 2005-12-05 Andreas Gruenbacher <agruen@suse.de>
885 Add POSIX ACL support
886 * src/ls.c: Switch back from HAVE_ACL to USE_ACL: The acl() syscall
887 is no requirement for ACL support; particularly, it does not exist
888 on systems that have POSIX ACLs.
889 * src/copy.h (cp_option_init) [umask_kill]: Remove member.
890 * src/cp.c (umask_kill): With default acls, the umask is not to be
891 applied. Remove umask_kill, don't change the process umask, and let
892 the kernel apply the umask where appropriate.
893 * src/cp.c (make_dir_parents_private): Fix logic for POSIX ACLs.
894 * src/copy.c (get_dest_mode): Remove; it is obsolete after removing
896 (copy_reg, copy_internal): Use copy_acl and set_acl
897 instead of fchown/chown. Fix the logic for POSIX ACLs.
898 (chown_succeded): Remove; we now always copy acls and
899 preserve S_ISUID, S_ISGID, and S_ISVTX when needed, no matter if we
900 did a chown before or not.
901 * src/mv.c, src/install.c (cp_option_init): Don't set umask_kill member.
902 * src/Makefile.am (dir_LDADD, ls_LDADD, vdir_LDADD, cp_LDADD,
903 mv_LDADD, ginstall_LDADD): On systems with an ACL library, arrange
904 to link with it via $(LIB_ACL), for the utilities that need it.
906 2005-12-16 Paul Eggert <eggert@cs.ucla.edu>
908 * src/remove.c (OPENAT_CWD_RESTORE__REQUIRE): Remove.
909 (OPENAT_CWD_RESTORE__ALLOW_FAILURE): Likewise.
910 (fd_to_subdirp): Remove openat_cwd_restore_allow_failure arg; its
911 value is now signified by whether cwd_errno is null.
912 (fd_to_subdirp, remove_dir, rm_1); Change cwd failure indicator from
913 pointer-to-bool to pointer-to-errno-value. All callers changed.
914 (rm_1): Don't bother setting a local cwd failure flag and then
915 ORing it into the caller's. Just set the caller's.
916 (rm): Use cwd failure errno value to print a slightly-better
919 2005-12-15 Jim Meyering <jim@meyering.net>
921 * src/stat.c (print_it): Properly handle a backslash at the
922 end of a --printf format string. Reported by Paul Eggert.
923 * tests/misc/stat-printf (end-bs): Add a test for the above.
925 2005-12-15 Paul Eggert <eggert@cs.ucla.edu>
927 * tests/acl: Port to pre-POSIX shells like Solaris 8 /bin/sh.
928 Don't assume /etc/passwd contains user names; use 'id' instead.
930 2005-12-15 Jim Meyering <jim@meyering.net>
932 stat: revert behavior of --format=FMT (-c)
933 stat: add new option: --printf=FMT
934 * NEWS: Mention this.
935 * src/stat.c (isodigit, octtobin, hextobin): Define.
936 (PRINTF_OPTION): Define.
937 (interpret_backslash_escapes, trailing_delim): New globals.
938 (usage): Document them. Alphabetize on long option names.
939 (print_esc_char): New function.
940 (print_it): Rewrite, in order to handle backslash escapes.
941 (main): Handle new option. Set globals for --format, too.
943 * tests/misc/stat-printf: Test --printf and --format.
944 * tests/misc/Makefile.am (TESTS): Add stat-printf.
946 2005-12-14 Paul Eggert <eggert@cs.ucla.edu>
948 * NEWS: sort now reports incompatible options.
949 * src/sort.c (incompatible_options, check_ordering_compatibility):
951 (main): Use them. Don't bother with a usage message for
952 "sort -c a b", for consistency with other error diagnostics.
953 * tests/sort/Test.pm (incompat1, incompat2, incompat3, incompat4):
956 * src/cat.c (main): Undo previous change. close_stdout already
957 does the check, so the previous change wasn't necessary.
959 2005-12-13 Paul Eggert <eggert@cs.ucla.edu>
961 * src/cat.c (main): Check for close (STDOUT_FILENO) failure.
963 2005-12-12 Paul Eggert <eggert@cs.ucla.edu>
965 Install a more-conservative approach for sort -R. It's the
966 same basic idea as the existing code, except it uses the full ISAAC
967 approach (called the "more kosher" approach in the existing comments).
968 This makes "sort -R" quite a bit slower (about a factor of 2 on my
969 little tests involving 10000 lines on a 2.4 GHz P4), but I think it's
970 better to be conservative here at first, and review any performance
971 improvements carefully.
972 * .x-sc_require_config_h: Add src/rand-isaac.c.
973 * src/rand-isaac.h: Remove. All uses now simply include rand-isaac.c.
974 * src/Makefile.am (noinst_HEADERS): Remove rand-isaac.h.
975 (shred_SOURCES, sort_SOURCES): Remove.
976 (EXTRA_DIST): Add rand-isaac.c.
977 * src/rand-isaac.c: Revert to what used to be in shred.c, without
978 changing it to allow for varying numbers of words in the state.
979 Alter so that we include rand-isaac.c directly rather than
980 compiling it and linking to it. Don't include config.h or
981 system.h; that's the includer's responsibility.
982 Omit functions that are specific to shred.
983 (ISAAC_LOG, ISAAC_WORDS, ISAAC_BYTES, struct isaac_state, ind):
984 (isaac_step, struct irand_state):
985 Resurrect these, with the same defns that used to be in shred.c.
986 (ISAAC_SIZE, isaac_new, isaac_copy): Remove.
987 (isaac_refill, isaac_seed_start, isaac_seed_data, irand_init, irand32):
989 (struct isaac_state, isaac_refill, isaac_mix, isaac_init):
990 (isaac_seed_start, isaac_seed_data, isaac_seed_finish, isaac_seed):
991 (irand_init, irand32, irand_mod):
992 Number of words is constant again.
993 (struct irand_state, irand_init, irand32, irand_mod): Move to shred.c.
994 * src/shred.c: Include rand-isaac.c rather than rand-isaac.h.
995 * src/sort.c: Likewise.
996 * src/shred.c (fillrand, dopass, main): Undo previous change.
997 (struct irand_state, irand_init, irand32, irand_mod): Moved back here,
999 * src/sort.c: Don't include md5.h; it wasn't needed.
1000 (struct keyfield): Rename random_hash to random, for consistency
1001 with the other member names. All uses changed.
1002 (usage): Tweak wording to mention STRING for --seed option.
1003 (short_options): Rorder for consistency with other programs.
1004 (rand_state): Now a struct, not a pointer to one. All uses changed.
1005 (HASH_WORDS, HASH_SIZE): Remove.
1006 (get_hash): Remove comments around resbuf size, since we can assume C89.
1007 Use a "more-kosher" (but slower) approach of invoking isaac_refill.
1008 (keycompare): Adjust to the new get_hash.
1010 (badfieldspec): Omit recently-introduced comment; it isn't needed.
1011 (main): Don't set need_random simply because gkey has it set; that
1012 doesn't necessarily mean we'll need random numbers.
1013 Redo seeding to match new get_hash approach.
1015 2005-12-10 Jim Meyering <jim@meyering.net>
1017 * src/Makefile.am (noinst_HEADERS): Add rand-isaac.h.
1019 Avoid shred segfault on 64-bit systems.
1020 * src/rand-isaac.c (isaac_refill): Don't try to negate a
1021 local of type uint32_t. Make the local an `int' instead.
1023 * NEWS: Mention sort's new options.
1025 * src/rand-isaac.c (isaac_mix): Declare to be static.
1026 Mark all other functions as `extern' so the tight-scope
1027 part of `make distcheck' passes once again.
1028 * src/rand-isaac.h (isaac_mix): Remove declaration.
1030 * src/sort.c (get_hash): Change position of `*' in parameter
1031 type to conform with convention.
1032 (main): Split a long line so it fits in 80 columns.
1033 (keycompare): Remove stray SPACE before TAB that was
1034 causing `make distcheck' to fail.
1036 * src/shred.c: Don't include gethrxtime.h. No longer needed.
1038 * tests/misc/sort-rand: New file: basic tests for the new options.
1039 * tests/misc/Makefile.am (TESTS): Add sort-rand.
1041 2005-12-10 Frederik Eaton <frederik@ofb.net>
1043 * src/Makefile.am (sort_LDADD): Add $(LIB_GETHRXTIME).
1044 (shred_SOURCES, sort_SOURCES): New macros, so we compile rand-isaac.c.
1045 * src/rand-isaac.c: New file, containing ISAAC code that was in shred.c.
1046 Make state size runtime-configurable.
1047 (isaac_new, isaac_copy): New functions.
1048 * src/rand-isaac.h: New file.
1049 * src/shred.c: Include rand-isaac.h. Move ISAAC code to rand-isaac.c.
1050 (fillrand, main): Adjust to the fact that the state size is now
1051 runtime-configurable.
1052 * src/sort.c (short_options, long_options, WORDS, keycompare, main):
1053 (usage): Add options --random-sort and --seed to implement a random
1055 Include md5.h and rand-isaac.h.
1056 (get_hash): New function.
1057 (rand_state): New var.
1058 (HASH_WORDS, HASH_SIZE): New macros.
1060 2005-12-09 Paul Eggert <eggert@cs.ucla.edu>
1062 * tests/dd/misc: Add test for dd iflags=noatime.
1064 2005-12-09 Jim Meyering <jim@meyering.net>
1066 * src/sort.c (usage): Mention white space vs -b and -t options.
1069 2005-12-09 Eric Blake <ebb9@byu.net>
1071 * src/test.c (main): Fix misleading comment.
1073 2005-12-07 Paul Eggert <eggert@cs.ucla.edu>
1075 * NEWS: Mention dd's new noatime flag.
1076 * src/system.h (O_NOATIME): Define to 0 if not already defined.
1077 * src/dd.c (flags, usage): Add support for noatime flag.
1079 2005-12-07 Jim Meyering <jim@meyering.net>
1081 Distribute the cvsu script, used only by `make syntax-check'.
1082 * Makefile.am (EXTRA_DIST): Add build-aux/cvsu.
1083 * Makefile.maint (CVS_LIST): Use build-aux/cvsu, now that we
1084 distribute a copy of this script.
1085 * .x-sc_unmarked_diagnostics: Add build-aux/cvsu.
1087 * tests/mv/acl: exit-77 before the trap, not after, if we fail
1088 to create a temporary directory on another partition.
1089 From Andreas Gruenbacher.
1091 2005-12-06 Tomas Pospisek <tpo@sourcepole.ch> (tiny change)
1093 * man/basename.x: Cross-reference to dirname and readlink.
1094 * man/dirname.x: Cross-reference to basename and readlink.
1096 2005-12-05 Andreas Gruenbacher
1098 * src/copy.c [!HAVE_FCHOWN]: Define fchown(...) to -1.
1099 (set_owner, preserve_author): New functions, factored out of copy_reg.
1100 (copy_reg): Use them.
1101 (copy_internal): Use them here, too.
1103 2005-12-04 Jim Meyering <jim@meyering.net>
1105 * src/sleep.c (usage): Say what happens with two or more arguments.
1106 Suggested by Justin Pryzby.
1108 * src/uptime.c (print_uptime): Move decl of `upsecs' into scope
1111 2005-12-03 Jim Meyering <jim@meyering.net>
1113 * src/rm.c (long_opts): Change the name of each undocumented, for-
1114 testing-only option to start with `-', so that it cannot render
1115 ambiguous any prefix it happens to share with some other option name.
1116 Problem reported by Eric Blake.
1117 * src/head.c (long_options): Likewise.
1118 * src/tail.c (long_options): Likewise.
1120 * tests/misc/head-elide-tail: Update uses of undocumented, for-
1121 testing-only --presume* options to start with `---'.
1122 * tests/rm/dangling-symlink: Likewise.
1123 * tests/rm/dir-no-w: Likewise.
1124 * tests/rm/isatty: Likewise.
1126 2005-11-30 Jim Meyering <jim@meyering.net>
1128 * Makefile.maint: Add a comment about cvsu.
1130 2005-11-25 Paul Eggert <eggert@cs.ucla.edu>
1132 * NEWS: df updates for "none", "proc", inaccessible file systems.
1133 * src/df.c (show_point): Ignore inaccessible file systems.
1134 (usage): -a includes dummy file systems, not size-0 file systems.
1136 * src/od.c (unsigned_long_long_int): Renamed from ulonglong_t,
1137 to avoid collision with POSIX name space. All uses changed.
1139 2005-11-24 Jim Meyering <jim@meyering.net>
1141 * tests/Makefile.am (EXTRA_DIST): Add acl to the list.
1142 * tests/acl: Add `$0: ' prefix to diagnostics.
1144 * .x-sc_require_config_h: Add lib/buffer-lcm.c to the list.
1146 2005-11-23 Paul Eggert <eggert@cs.ucla.edu>
1148 * src/copy.c: Improve performance a bit by optimizing away
1149 unnecessary system calls and going to a block size of at least
1150 8192 (on normal hosts, anyway). This improved performance 5% on my
1151 Debian stable host (2.4.27 kernel, x86, copying from root
1152 ext3 file system to itself).
1153 Include "buffer-lcm.h".
1154 (copy_reg): Omit last argument. All callers changed.
1155 Use xmalloc to allocate rather than trusting alloca
1156 (which is unwise with large block sizes).
1157 Declare locals more locally, if possible.
1158 Use uintptr_t words instead of int words, for a bit more speed
1159 when looking for null blocks on 64-bit hosts.
1160 Optimize away reads of zero bytes on regular files.
1161 In the typical case, insist on 8 KiB buffers, at least.
1162 Avoid unnecessary extra call to fstat when checking for sparse files.
1163 Avoid now-unnecessary cast to off_t, and "0L".
1164 Avoid unnecessary test of *new_dst when checking for same owner
1167 2005-11-22 Paul Eggert <eggert@cs.ucla.edu>
1169 * src/remove.c (rm): Don't assume C99 for-loop syntax.
1171 2005-11-22 Jim Meyering <jim@meyering.net>
1173 * src/remove.c (AD_push): Remove debugging cruft.
1175 * tests/rm/unread2 (rm): Change expected diagnostic,
1176 `cannot open directory' to `cannot remove', to align with
1178 * tests/rm/rm2: Ensure that rm now continues removing entries
1179 even after certain types of failure.
1181 * src/remove.c: Rewrite. Now, this module is reentrant on systems
1182 that provide openat (Solaris), and on systems like Linux+procfs
1183 where our openat emulation code is reentrant. This also fixes a
1184 few low-probability leaks and eliminates some code that could,
1185 in very unusual circumstances, cause rm() (via a callee) to exit.
1186 * NEWS: Mention this.
1188 * configure.ac: Put copyright dates all on one line so the
1189 emacs function that updates them works properly.
1191 2005-11-18 Paul Eggert <eggert@cs.ucla.edu>
1193 * configure.ac (AM_PROG_CC_C_O): Add. Needed for CVS Automake.
1194 Problem reported by Eric Blake.
1195 (AC_PROG_CC_STDC): Use this instead of AC_PROG_CC, so that
1196 we get a standard-conforming compiler. This relies on the new
1197 m4/c.m4 file. Note that it's a bit tricky, since c.m4 doesn't
1198 define AC_PROG_CC_STDC; we are relying on Autoconf 2.59 internals.
1199 m4/c.m4 can go away with Autoconf 2.60 comes out.
1201 2005-11-17 Jim Meyering <jim@meyering.net>
1203 * src/remove.c (AD_mark_helper): Make a `char *' parameter `const'.
1204 (AD_mark_current_as_unremovable): Likewise, but for a local.
1207 * tests/mv/acl: Let traps handle removing temporary directories.
1209 Expect acl-related tests to fail, until the corresponding
1210 patches are committed.
1211 * tests/mv/Makefile.am (XFAIL_TESTS): Add acl.
1212 * tests/cp/Makefile.am (XFAIL_TESTS): Likewise.
1214 ACL tests, from Andreas Gruenbacher.
1215 * tests/acl, tests/mv/acl, tests/cp/acl: New files.
1216 * tests/mv/Makefile.am (TESTS): Add acl.
1217 * tests/cp/Makefile.am (TESTS): Add acl.
1219 * src/ls.c (basename_is_dot_or_dotdot): Correct wording in comment.
1221 2005-11-16 Paul Eggert <eggert@cs.ucla.edu>
1223 * NEWS: Improve quality of ln's diagnostics.
1224 * src/ln.c (do_link, usage): Likewise.
1225 (do_link): Don't use alloca on a buffer of unbounded size.
1227 2005-11-16 Jim Meyering <jim@meyering.net>
1229 * tests/cp/fail-perm: Accommodate HPUX. It appears to fail
1230 with EACCES rather than EPERM. Reported by Peter O'Gorman here:
1231 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/5766
1232 This also affects AIX 4.3.3, according to Ralf Wildenhues, in
1233 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
1235 2005-11-14 Jim Meyering <jim@meyering.net>
1237 * NEWS (sort): Mention consequences of today's mkstemp-safer.c fix.
1239 2005-11-13 Jim Meyering <jim@meyering.net>
1241 * announce-gen: Accept new option, --gpg-key-id=ID and
1242 emit a blurb telling how to use the .sig files.
1243 * Makefile.cfg (gpg_key_ID): Define.
1244 * Makefile.maint (announcement): Use new option and key.
1246 Require that most .c files include <config.h>.
1247 * Makefile.maint (sc_require_config_h): New rule.
1248 (syntax-check-rules): Add it.
1249 * .x-sc_require_config_h: New file listing exceptions to the
1250 above rule. Some are legit, others are simply grandfathered in.
1251 * Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h here, too.
1253 2005-11-12 Jim Meyering <jim@meyering.net>
1255 * src/checksum.h, src/md5.c, src/sha1sum.c: Remove now-unused files.
1257 2005-11-11 Jim Meyering <jim@meyering.net>
1259 * NEWS: Mention `readlink -f' bug fix in 5.3.0 news.
1260 Mention new readlink options in 5.3.0's `New features' section.
1261 Spotted by Thomas Hood.
1263 2005-11-08 Jim Meyering <jim@meyering.net>
1265 * NEWS: Merge in changes from b5_9x branch.
1267 2005-11-08 Paul Eggert <eggert@cs.ucla.edu>
1269 * NEWS: ls now defaults to --time-style='locale', which in turn acts
1270 like --time-style='posix-long-iso' if the locale settings are messed up.
1271 * src/ls.c (decode_switches): Implement this.
1273 2005-11-08 Jim Meyering <jim@meyering.net>
1275 * tests/du/2g: s/expensive/very expensive/ in a comment.
1278 2005-10-17 Eric Blake <ebb9@byu.net>
1280 * src/ls.c (usage): Fix descriptions of --sort, --time.
1281 Reported by Vitaly A. Ostanin.
1283 2005-11-04 Paul Eggert <eggert@cs.ucla.edu>
1285 * src/ln.c: Include filenamecat.c.
1286 (FILE_BASENAME_CONCAT): Remove.
1287 (do_link): Remove last arg DEST_IS_DIR. All callers changed.
1288 (main): Use file_name_concat, base_name, and strip_trailing_slashes
1289 instead of FILE_BASENAME_CONCAT. This simplifies the code, and avoids
1292 2005-11-04 Jim Meyering <jim@meyering.net>
1294 * src/du.c (process_file): Don't overflow for files of size >= 2^31
1295 on systems with stat.st_blocks of a signed 32-bit type.
1296 This bug causes trouble on some AIX 5.1 systems.
1297 Report and trivial patch from Paul Townsend:
1298 <http://lists.gnu.org/archive/html/bug-coreutils/2005-11/msg00033.html>
1299 * NEWS: Mention this.
1301 * tests/du/2g: New (very-expensive) test for the above-fixed bug.
1302 * tests/du/Makefile.am (TESTS): Add it here.
1303 * tests/very-expensive: New file.
1304 * tests/Makefile.am (EXTRA_DIST): Add it here.
1305 * tests/cp/perm: Mark this test as `very-expensive', too.
1307 2005-11-02 Paul Eggert <eggert@cs.ucla.edu>
1309 * NEWS: Mention that rm -d and maybe ln -d are scheduled for
1311 * src/remove.h (struct rm_options): Remove unlink_dirs. All uses
1313 * src/rm.c (usage): Don't mention rm -d.
1315 2005-11-02 Jim Meyering <jim@meyering.net>
1317 * tests/dd/skip-seek: Fix typo in comment: s/fileutils/coreutils.
1318 From Andreas Schwab.
1320 * tests/dd/unblock-sync: Redirect stderr to /dev/null so the
1321 `M+N records in/out' lines don't pollute `make check' output.
1323 * tests/dd/skip-seek (sk-seek4): New test, to exercise the bug
1324 fixed on 2005-10-31. This test uses the new, IN_PIPE specifier.
1325 * tests/Coreutils.pm: Accept a new type of input specifier: IN_PIPE,
1326 to indicate that the input file should be piped into the command
1327 under test (via `cat FILE | $prog ...').
1329 * src/remove.c (remove_entry): Emit a better diagnostic when rm
1330 (without -r) fails to remove a directory on a non-Linux system.
1331 This change affects only newer Solaris systems (with priv_*
1332 functions like priv_allocset). Reported by Keith Thompson.
1334 * tests/rm/dir-nonrecur: New file/test for the above fix.
1335 * tests/rm/Makefile.am (TESTS): Add dir-nonrecur.
1337 2005-11-01 Paul Eggert <eggert@cs.ucla.edu>
1339 * NEWS: "tail -c 2 FILE" and "touch 0101000000" now operate as
1340 POSIX 1002.1-2001 requires.
1341 * src/tail.c (parse_obsolete_option): Implement this.
1342 Problem reported by Vincent Lefevre.
1343 * src/touch.c (main): Pass PDS_PRE_2000 to posixtime.
1344 * tests/tail/Test.pm (c-2, c-2-minus, c2, c2-minus): New tests.
1345 (test_vector): Add special cases for _POSIX2_VERSION, and
1346 regularize the old ones a bit.
1347 * tests/touch/obsolescent: Add y2000 test.
1349 2005-10-31 Paul Eggert <eggert@cs.ucla.edu>
1351 * src/dd.c (skip): Fix off-by-one error reported by
1352 Theodoros V. Kalamatianos.
1354 2005-10-30 Paul Eggert <eggert@cs.ucla.edu>
1356 * tests/mkdir/p-3: Require that the test be run as non-root.
1357 Problem and trivial fix reported by Theodoros V. Kalamatianos.
1359 2005-10-28 Paul Eggert <eggert@cs.ucla.edu>
1361 * src/ln.c (FILE_BASENAME_CONCAT): Omit unnecessary slashes in the
1362 boundary between DEST and SOURCE in the result.
1364 2005-10-26 Dmitry V. Levin <ldv@altlinux.org>
1366 * src/md5sum.c (main) [!O_BINARY]: Changed default read mode
1367 back to text, to sync with documentation and for backwards
1370 2005-10-25 Jim Meyering <jim@meyering.net>
1372 * tests/dircolors/simple (other-wr): Add an explicit test for
1373 the dircolors bug (NULL-dereference) fixed yesterday.
1375 2005-10-24 Jim Meyering <jim@meyering.net>
1377 * src/tac.c (tac_file): When determining whether a file is seekable,
1378 also test whether it is a tty. Using only the lseek-based test would
1379 give a false positive on Solaris. Reported by Peter Fales.
1381 2005-10-24 Dmitry V. Levin <ldv@altlinux.org>
1383 * tests/install/d-slashdot: New test, for "install -d" failure.
1384 * tests/install/Makefile.am (TESTS): Add d-slashdot.
1385 * tests/mkdir/p-slashdot: New test, for "mkdir -p" failure.
1386 * tests/mkdir/Makefile.am (TESTS): Add p-slashdot.
1388 2005-10-24 Jim Meyering <jim@meyering.net>
1390 * src/dircolors.c (ls_codes): Add missing comma.
1391 Anonymous report and patch from
1392 http://savannah.gnu.org/bugs/?func=detailitem&item_id=14849
1394 * src/dircolors.c: Add compile-time assertion that the slack_codes
1395 and ls_codes arrays have the same number of elements. This would
1396 have prevented the above-fixed bug.
1398 * src/expand.c (parse_tab_stops): Add a comment to make this function
1399 identical to the one in unexpand.c.
1400 * src/unexpand.c (parse_tab_stops): Adjust syntax to make this function
1401 identical to the one in expand.c.
1403 * src/expand.c (next_file): Don't assume fopen cannot return stdin.
1405 2005-10-23 Jim Meyering <jim@meyering.net>
1407 * src/md5sum.c (digest_check, main): Use ptr_align rather than
1408 a dangerous pointer-value-to-`unsigned' cast.
1409 * NEWS: mention the new sha* programs.
1410 * AUTHORS: Add new sha* programs.
1412 2005-08-28 David Madore <david.madore@ens.fr>
1414 Add new programs: sha224sum, sha256sum, sha384sum, sha512sum.
1415 * README: Add their names to the list.
1416 * src/md5sum.c: Provide framework for computing sha-2 hashes.
1417 * src/Makefile.am (sha224sum, sha256sum, sha384sum, sha512sum):
1418 Rules for compiling sha-2 utilities
1419 (noinst_HEADERS): Remove checksum.h.
1420 * man/sha512sum.x, man/sha384sum.x, man/sha256sum.x, man/sha224sum.x:
1422 * man/Makefile.am (dist_man_MANS): Add the corresponding .1 names.
1423 (sha224sum.1, sha256sum.1, sha384sum.1, sha512sum.1): New dependencies.
1424 * tests/misc/sha224sum, tests/misc/sha256sum: New files.
1425 * tests/misc/sha384sum, tests/misc/sha512sum: New files.
1426 * tests/misc/Makefile.am (TESTS): Add new sha224sum, sha256sum,
1427 sha384sum, sha512sum test scripts here rather that each in its
1430 2005-08-28 David Madore <david.madore@ens.fr>
1432 * tests/sha1sum/basic-1 (million-a): Add the "million a's" test (one
1433 of the FIPS test vectors).
1435 2005-10-23 Jim Meyering <jim@meyering.net>
1437 * configure.ac: Use 6.0-cvs as the version string.
1438 * NEWS: Adjust accordingly.