1 2006-07-29 Paul Eggert <eggert@cs.ucla.edu>
3 * src/copy.c (set_author): Preserve the st_author field via the
4 file descriptor dest_desc.
6 2006-07-28 Paul Eggert <eggert@cs.ucla.edu>
8 * NEWS: chmod now preserves setuid and setgid bits on directories
9 if you use a numeric mode with them clear, e.g., "chmod 755 DIR".
11 Fix test case problems if working directory is setgid,
12 reported by Bob Proulx.
13 * tests/cp/fail-perm: Use symbolic mode so that we clear
14 setgid bit more reliably on directories.
15 * tests/mkdir/special-1 (set_mode_string): Likewise.
17 2006-07-27 Jim Meyering <jim@meyering.net>
19 * src/chgrp.c (usage): Use correct grammar in description of the
21 * src/chown.c (usage): Likewise.
23 2006-07-26 Thomas Schwinge <tschwinge@gnu.org> (tiny change)
25 * src/copy.c (set_author) [HAVE_STRUCT_STAT_ST_AUTHOR]:
26 Correctly access SRC_SB's element ST_AUTHOR.
28 2006-07-26 Jim Meyering <jim@meyering.net>
30 * tests/ls/stat-failed: Adapt to match new expected output.
33 * src/ls.c (print_color_indicator): Test for S_IFREG first, rather
34 than having the code test for all of the other types first.
35 Hoist the set-uid/gid-testing code "up" into this new block.
36 Classify any other type of file (e.g., S_TYPEISSHM, etc.) as
37 C_ORPHAN, not as C_FILE.
39 2006-07-26 Jim Meyering <jim@meyering.net>
41 Checking in a change from Paul.
43 2006-07-25 Paul Eggert <eggert@cs.ucla.edu>
45 * src/ls.c (DT_INIT): Remove. All uses removed.
46 (enum filetype): Use an ordinary enum rather than trying to keep
47 the values in sync with DT_FIFO etc. That way, we don't have
48 to make special assumptions about them. All uses changed.
49 (whiteout): New constant member of enum filetype.
50 (filetype_letter): New constant, for use with enum filetype.
51 (FILETYPE_INDICATORS): New initializer list.
52 (print_dir): Add case for DT_WHT.
53 (gobble_file): If stat fails, don't discard information from
54 readdir; instead, preserve it so it can be printed.
55 (print_long_format): Fall back on readdir result if stat info
56 is not available. Use "?" to denote each unknown mode char,
57 instead of an overall "?", since we now know some of the mode
59 (print_type_indicator): Now that MODE isn't necessarily
60 useful, guard all uses.
61 Now that two blocks in the type-checking tree can set "type = C_FILE",
62 move the suffix-handling code out and down.
64 2006-07-26 Jim Meyering <jim@meyering.net>
66 Prepare for the above change.
67 * src/ls.c [struct fileinfo] (stat_ok): Rename from stat_failed,
68 and adjust uses. From a patch by Paul Eggert.
70 2006-07-26 Jim Meyering <jim@meyering.net>
72 * src/ls.c: Correct indentation/formatting in a few places.
74 2006-07-25 Paul Eggert <eggert@cs.ucla.edu>
76 * tests/cp/fail-perm: Use "chmod 0500" rather than "chmod 500".
77 Problem report and fix from Bob Proulx.
78 * NEWS: Clarify the "chmod 0500" news, and correct the vague
79 statements about compatibility with BSD.
81 2006-07-25 Jim Meyering <jim@meyering.net>
83 * src/ls.c (gobble_file): When handling a stat-failed entry,
84 print the entry name not the absolute_name -- to be consistent
86 * tests/ls/stat-failed: Update accordingly.
88 * src/ls.c: Add parens around the new uses of ?: ternary operator.
90 * src/dircolors.hin: Mention that ORPHAN refers not just to dangling
93 Get --dired offsets right when handling stat-failed entries.
94 * src/ls.c (print_long_format): Be careful to increment P by the
95 appropriate amount, even when inode_number_width and nlink_width
97 * tests/ls/stat-failed: Test for the above.
99 * src/ls.c (gobble_file) [USE_ACL]: Don't use-uninitialized the
100 have_acl member. That would happen for a directory with both a
101 non-stat'able entry and one with an ACL.
103 * src/ls.c (gobble_file): Make it so failure to stat a
104 non-command-line file provokes an exit status of 1, not 0.
105 Say "cannot access" rather than "cannot stat".
106 * tests/ls/stat-failed: New file/test, for the above.
107 * tests/ls/Makefile.am (TESTS): Add stat-failed.
108 * tests/ls-2/tests (no-a-isdir-b): Update to reflect addition
109 of "cannot access " to diagnostic.
111 * src/ls.c: Declare stat_failed to be "bool", not "int" everywhere.
113 * src/ls.c [enum filetype] (command_line): Remove member. Not needed.
114 Replace all occurrences of "type == command_line" with the
115 equivalent, "command_line_arg".
117 * src/ls.c: Apply the stat-failed parts of Red Hat's
118 coreutils-selinux.patch. From Ulrich Drepper.
119 This makes it so files not mentioned on the command line (e.g.,
120 names read from a directory that *is* mentioned on the command
121 line) for which stat fails are still listed. With --color,
122 such files are colored just like ORPHANs (aka dangling symlinks).
124 * src/df.c (n_valid_args): Declare global to be static.
126 2006-07-24 Jim Meyering <jim@meyering.net>
128 * tests/ls/stat-dtype: Skip this test on reiserfs, since that file
129 system lacks d_type support.
131 2006-07-22 Paul Eggert <eggert@cs.ucla.edu>
133 * man/chmod.x: Update to reflect recent changes to coreutils.texi.
135 2006-07-21 Jim Meyering <jim@meyering.net>
137 * src/su.c (usage): Correct typo in --help output: s/commmand/command/
138 Reported by Tim Waugh.
139 Also remove the comment duplicating much of --help output.
141 * src/ls.c (FILE_TYPE_INDICATOR_OPTION): Reposition this new
142 name so the list remains alphabetized.
144 Fix another bug: ls --indicator-style=file-type would call
145 stat for a symlink, even though it wasn't always needed.
146 In some cases, that unnecessary stat would cause ls to fail.
147 * src/ls.c (gobble_file): Don't treat symlinks specially (in
148 requiring a stat syscall). Remove the offending exclusion.
150 * NEWS: Mention the fix.
152 * tests/ls/stat-dtype: New file/test, for the above fix.
153 Also exercises the new df feature, below.
155 * src/df.c (main): Fail and don't print the headers if no
156 file system is processed. This makes it easy to test whether
157 a specified directory is on a file system of a given type or types.
158 Otherwise, applications would have had to parse df's output.
159 E.g., is "." either ext3 or reiserfs: df -t ext3 -t reiserfs .
161 Fix a bug: ls --file-type worked like --indicator-style=slash,
162 rather than like --indicator-style=file-type.
163 * src/ls.c (FILE_TYPE_INDICATOR_OPTION): New enum member.
164 (long_options): Map "file-type" to FILE_TYPE_INDICATOR_OPTION,
166 (decode_switches): Handle new case: FILE_TYPE_INDICATOR_OPTION.
167 * NEWS: Mention the fix.
168 * tests/ls-2/tests (file-type): New test, for the above fix.
170 2006-07-19 Jim Meyering <jim@meyering.net>
172 * src/ls.c (print_dir): Give a better diagnostic for failed opendir.
174 * Makefile.am (EXTRA_DIST): Add build-aux/vc-list-files.
176 2006-07-16 Paul Eggert <eggert@cs.ucla.edu>
178 * NEWS: chmod, install, and mkdir now leave setgid and setuid bits
179 of directories alone unless you specify them explicitly.
180 install and mkdir now implement X correctly.
181 install now creates parent directories with mode 755, without
182 changing their owner or group.
183 * src/chmod.c (process_file): Adjust to mode_adjust API change.
184 * src/install.c: Include mkancesdirs.h.
185 (announce_mkdir, make_ancestor): New functions.
186 (DEFAULT_MODE): New macro, specifying initial value of 'mode'.
188 (dir_mode, dir_mode_bits): New vars.
189 (main): Set dir modes separately from nondir, so that the X
190 op of -m works correctly.
191 (main): Remove cwd_errno cruft, since make_dir_parents no longer
192 affects cwd. Adjust to new make_dir_parents API.
193 (install_file_in_file_parents): 2nd arg is now char *, not char
194 const *. Use mkancesdirs instead of rolling our own code.
195 (change_attributes): Don't worry about AFS, since that kludge
196 should not be needed any more.
197 * src/mkdir.c (struct mkdir_options): New struct.
198 (announce_mkdir, make_ancestor): New functions.
199 (main): Use them. Adjust to mode_adjust API change. Stick with
200 umask 0. Use make_dir_parents for all the work.
201 * src/mkfifo.c (main): Adjust to new mode_adjust API.
202 * src/mknod.c (main): Likewise.
203 * tests/chmod/setgid: Do the setgid test instead of bailing.
204 * tests/mkdir/p-3: Remove re_protect case that no longer applies.
205 GNU chmod now behaves like other versions of chmod.
206 * tests/mkdir/perm: Add a test for the X bug.
208 2006-07-14 Paul Eggert <eggert@cs.ucla.edu>
210 * src/base64.c (do_decode): Output to parameter OUT, not to stdout.
211 This doesn't fix any bugs, since OUT always equals stdout, but it
212 makes the code easier to understand.
214 2006-07-14 Jim Meyering <jim@meyering.net>
216 * Makefile.maint (CVS_LIST): Use new file, build-aux/vc-list-files,
217 rather than open-coding it. Now supports mercurial, too.
218 * .hgignore: New file.
219 * Makefile.am (EXTRA_DIST): Add .hgignore, which ignores nearly
220 all generated files, including ones like configure and po/*.po
221 that are currently version-controlled in cvs.
223 * Makefile.am (EXTRA_DIST): Add a few more .??* files.
224 They've been in CVS, just haven't been distributed before this.
225 Distribute ChangeLog-2005, too.
226 (MAINTAINERCLEANFILES): Add THANKS-to-translators.
228 2006-07-11 Paul Eggert <eggert@cs.ucla.edu>
230 * src/system.h: Assume <dirent.h> exists, since gnulib assumes
233 2006-07-09 Jim Meyering <jim@meyering.net>
235 * tests/mv/dir2dir: Adjust so failing with ENOTEMPTY is ok, too.
236 That happens with Linux/tmpfs.
237 * tests/mv/Makefile.am (TESTS): Add dir2dir.
239 2006-07-09 Paul Eggert <eggert@cs.ucla.edu>
241 Adjust to recent updates from gnulib.
242 * src/dd.c (apply_translations): Use toupper rather than
243 islower followed by toupper; it's simpler and typically
244 faster now that we assume at least C89 semantics. Similarly
246 * src/sort.c (inittables): Likewise.
247 * src/expand.c (expand): Don't assume that isprint etc. return
248 booleans (needed for pre-C99 hosts).
249 * src/fmt.c (check_punctuation): Likewise.
250 * src/ptx.c (initialize_regex, fix_output_parameters): Likewise.
251 * src/tr.c (is_char_class_member): Likewise.
252 * src/unexpand.c (unexpand): Likewise.
253 * src/join.c (is_blank): Remove; no longer needed. All uses
254 replaced by isblank (to_uchar (...)).
255 * src/pinky.c (create_fullname): Don't assume char is unsigned.
256 * src/printf.c (print_esc): Likewise.
257 * src/ptx.c (SKIP_NON_WHITE, SKIP_WHITE, SKIP_WHITE_BACKWARDS):
258 (copy_unescaped_string): Likewise.
259 * src/stat.c (print_it): Likewise.
260 * src/system.h (_D_EXACT_NAMELEN): Renamed from NLENGTH, for
261 convenience on GNU systems. All uses changed. Don't bother
262 looking for any dirent.h substitute other than ndir.h.
263 (D_INO): Remove unnecessary parentheses.
264 (IN_CTYPE_DOMAIN, ISGRAPH, ISPRINT, ISALNUM, ISALPHA):
265 (ISCNTRL, ISLOWER, ISPUNCT, ISSPACE, ISUPPER, ISXDIGIT):
266 (ISDIGIT_LOCALE, TOLOWER, TOUPPER): Remove. All uses changed
267 to ctype.h equivalents.
268 (isblank): Renamed from ISBLANK. Check for HAVE_DECL_ISBLANK too.
271 2006-07-08 Jim Meyering <jim@meyering.net>
273 * tests/mv/dir2dir: New file, test for 2006-07-05 fix in copy.c.
275 * Makefile.maint (sc_the_the): New rule.
277 * src/dd.c (skip): Remove one of two adjacent "the"s in a comment.
278 * tests/Coreutils.pm (run_tests): Remove one of two adjacent "then"s
281 2006-07-07 Jim Meyering <jim@meyering.net>
283 * NEWS: Mention that mv can now remove an empty destination directory,
284 and give an example. Prompted by a report from Florent Bayle.
286 2006-07-05 Jim Meyering <jim@meyering.net>
288 * src/ls.c (usage): Correct the description of -G: it is useful
289 only in a long listing. Reported by Martin Pool in
290 <https://launchpad.net/distros/ubuntu/+source/coreutils/+bug/51653>.
292 * man/chmod.x: Correct the description of the sticky bit. Reported
293 by Chris Moore via Ian Jackson in <http://bugs.debian.org/376745>.
295 * src/copy.c (copy_internal): Don't work around old NFS clients like
296 SunOS-4.1.4 and Irix 5.3 that set errno to values like EIO and
297 ENOTEMPTY upon failed rename. Otherwise, we risk misinterpreting
298 a banal failure as a recursive move-into-self failure.
299 Reported by Florent Bayle in <http://bugs.debian.org/376749>.
301 * src/c99-to-c89.diff: Regenerate, to remove fuzz.
303 2006-07-03 Jim Meyering <jim@meyering.net>
305 Plug another unusual leak.
306 (AD_mark_helper): Free malloc'd filename if hash_insert says
307 that string is already in the hash table.
309 The dev/inode of the topmost directory in each hierarchy were not
311 * src/remove.c (remove_cwd_entries): Don't call cycle_check here.
312 (AD_push): Call it from here instead.
315 * src/remove.c (AD_stack_clear): New function.
317 (AD_pop_and_chdir): Free *prev_dir just before longjmp.
319 * tests/Makefile.am, tests/*/Makefile.am: (TESTS_ENVIRONMENT):
320 Add $VG_PATH_PREFIX as a prefix to $PATH
322 * tests/envvar-check (vars): Add CDPATH and POSIXLY_CORRECT.
323 * tests/Makefile.am (evar-check): Remove rule.
324 (EXTRA_DIST): Remove .env-warn.
325 * tests/.env-warn: Remove file. No longer used.
326 Suggestion from Eric Blake.
328 2006-07-02 Paul Eggert <eggert@cs.ucla.edu>
330 * src/system.h: Include <stdint.h> unconditionally, since we
331 now assume the stdint module.
333 2006-07-01 Paul Eggert <eggert@cs.ucla.edu>
335 * NEWS: With no operand, 'tail -f' now silently ignores the '-f'
336 only if standard input is a FIFO or pipe and POSIXLY_CORRECT is set.
337 * src/tail.c (main): Implement this.
338 * tests/tail/Test.pm (f-pipe-1): Renamed from f-1.
339 (test_vector): Set POSIXLY_CORRECT for the f-pipe-* tests.
341 2006-07-01 Jim Meyering <jim@meyering.net>
343 * src/ln.c (do_link): Use new, shorter URL, for ag-review link.
345 * .x-sc_require_config_h: Add ^lib/xstrtold\.c$, so make distcheck
348 2006-06-30 Paul Eggert <eggert@cs.ucla.edu>
350 * NEWS: seq now uses long double internally rather than double.
351 It now defaults to a minimal fixed point format if possible.
352 It lets you use %a, %A, %E, %F, %G.
353 * src/Makefile.am (seq_LDADD): Remove $(SEQ_LIBM); add $(POW_LIB).
354 * src/seq.c: Don't include <math.h> or <xstrtol.h>; no longer needed.
355 (isfinite) [!defined isfinite]: New macro.
356 (separator, terminator): Now points to const.
357 (first, step, last): Remove.
358 (usage): Update to match new behavior.
359 (struct operand, operand): New type.
360 (scan_arg): Renamed from scan_double_arg, since we no longer use double.
362 Compute and return a value of type operand, not double.
363 (long_double_format): Renamed from valid_format, and now returns a
364 new format with an "L" added if needed, if the original format was
365 valid. Allow %a, %A, %E, %F, and %G formats.
366 (print_numbers): Take numeric values as args rather than from globals.
367 Print long double, not double.
368 (get_width_format): Remove.
369 (get_default_format): New function.
370 (main): Implement new way of calculating default format.
371 Don't worry about locale's representation of the decimal point, since
372 the arguments are always processed in the C locale.
373 * tests/seq/basic (neg-2): Adjust to new default format.
374 (eq-wid-1, eq-wid-2): Resurrect these tests, since the new
375 implementation should do the right thing.
377 2006-06-30 Jim Meyering <jim@meyering.net>
379 * tests/stty/basic-1: Work around an intermittent test failure
380 on HP-UX 11.11. Report and analysis from Bob Proulx.
381 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/7475
383 2006-06-28 Paul Eggert <eggert@cs.ucla.edu>
385 * NEWS: Support obsolete usages like "sort +1 -2" even when
386 conforming to POSIX 1003.1-2001, since this is a pure extension to
387 POSIX. Problem reported by Christian in:
388 http://lists.gnu.org/archive/html/bug-coreutils/2006-06/msg00220.html
389 * src/sort.c (main): Implement this.
391 * src/system.h (CLOSEDIR): Remove. All uses changed to closedir.
392 Autoconf 2.60 says this stuff was obsolete.
394 2006-06-28 Jim Meyering <jim@meyering.net>
396 * src/c99-to-c89.diff: Regenerate, to remove fuzz.
398 2006-06-28 Bob Proulx <bob@proulx.com> (tiny change)
400 * tests/mv/i-link-no: Work around HP-UX /bin/sh tracing problem
401 (set -x when VERBOSE=yes) when stderr is redirected before stdout
402 causing shell tracing of the stdout redirection to be written to
403 the stderr file. Avoid problem and test failure on HP-UX by
404 redirecting stderr last.
405 * tests/dd/unblock-sync: Order shell file redirections for
406 stderr and stdout in the common style.
409 2006-06-27 Jim Meyering <jim@meyering.net>
411 * tests/misc/cat-proc: Try to avoid any spurious numeric
412 differences in frequently-changing /proc/cpuinfo.
413 Reported by Nelson Beebe.
415 2006-06-26 Jim Meyering <jim@meyering.net>
417 Attempt rmdir (actually, unlinkat-with-AT_REMOVEDIR) upon any
418 fd_to_subdirp failure, not just when errno == EACCES.
419 * src/remove.c (remove_dir): Use unlinkat-with-AT_REMOVEDIR, not
420 rmdir, here, even though rmdir may happen to be adequate.
422 * NEWS: rm no longer fails to remove an empty, unreadable directory
423 * src/remove.c (remove_cwd_entries): If we can't open a directory,
424 and the failure is not being ignored, try to remove the directory
425 with rmdir (aka unlinkat-with-AT_REMOVEDIR), in case it's empty.
426 Problem report and test case from Paul Eggert in
427 <http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/7425>.
429 * tests/rm/empty-inacc: New test, for the above.
431 Avoid a segfault for wc --files0=- < /dev/null.
432 * src/wc.c (compute_number_width): Return right away if nfiles == 0.
434 2006-06-25 Jim Meyering <jim@meyering.net>
436 * NEWS: wc accepts a new option --files0-from=FILE, where FILE
437 contains a list of NUL-separated file names.
439 * src/wc.c: Include "readtokens.h".
440 (usage): Describe the new option, and adjust the `Usage':
441 with this option, no FILE may be specified on the command line.
442 (main): Handle the new option.
443 * tests/misc/wc-files0: New tests, for the above.
444 * tests/misc/wc-files0-from: Likewise.
445 * tests/misc/Makefile.am (TESTS): Add wc-files0.
447 2006-06-24 Jim Meyering <jim@meyering.net>
449 * src/md5sum.c (DIGEST_BUFFER): Remove now-unused definitions.
451 2006-06-22 Jim Meyering <jim@meyering.net>
453 * src/tee.c (tee_files): Rename from tee, to avoid conflict with
454 the function in glibc's <fcntl.h>. Reported by Andreas Schwab.
456 2006-06-19 Jim Meyering <jim@meyering.net>
458 * Makefile.cfg (local-checks-to-skip): Add changelog-check,
459 so this check is not run as part of "make distcheck".
461 2006-06-18 Bob Proulx <bob@proulx.com> (tiny change)
463 * tests/misc/pwd-long: Fix typo (s/neq/ne/) in previous change.
465 2006-06-18 Jim Meyering <jim@meyering.net>
467 * tests/misc/pwd-long: Make error output a little clearer.
469 2006-06-17 Jim Meyering <jim@meyering.net>
471 * tests/rm/inaccessible: Skip this test on systems without openat
472 support. Reported by Bob Proulx.
474 2006-06-15 Bob Proulx <bob@proulx.com> (tiny change)
476 * tests/misc/mknod: Improve permission checks to handle
477 running mkdir test in set-gid directories.
479 2006-06-14 Jim Meyering <jim@meyering.net>
481 * tests/du/basic: Revamp not to hard-code file system block sizes.
483 2006-06-12 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
485 * tests/du/Makefile.am (TESTS_ENVIRONMENT): Pass $(PERL), for
488 2006-06-11 Jim Meyering <jim@meyering.net>
490 * .gitignore: New file.
491 * Makefile.am (EXTRA_DIST): Add .gitignore.
493 Setting TIME_STYLE=long-iso in the environment would make the
494 cp/same-file test fail.
495 * tests/envvar-check (vars): Add TIME_STYLE to the list.
496 * tests/cp/same-file: Revert last change.
497 Source the envvar-check script, to ensure that TIME_STYLE
498 settings don't affect these tests.
500 2006-06-11 Paul Eggert <eggert@cs.ucla.edu>
502 * tests/cp/same-file: Execute 'ls' in the C locale, so that it
503 uses POSIX time stamp formats. Problem reported by John Nixon in
504 <http://lists.gnu.org/archive/html/bug-coreutils/2006-06/msg00062.html>.
506 2006-06-10 Jim Meyering <jim@meyering.net>
508 * NEWS: Mention the AIX-strndup-bug vs. dircolors workaround.
510 Require a "Version N.M" line at the top of the ChangeLog
511 file only when making the actual release, not when running
513 * Makefile.maint (maintainer-distcheck): Don't depend on
515 (alpha beta major): Depend on it here, instead.
517 2006-06-08 Jim Meyering <jim@meyering.net>
519 Ensure that cat works with any of the options, -A -v -e -E -T,
520 when applied to files in /proc and /sys, even when the FIONREAD
521 ioctl produces nonsensical results. Before this change, cat would
522 produce no output (or truncated output), for some linux kernels.
524 * src/cat.c (write_pending): New function, factored out of cat.
525 (cat): Also interpret a negative ioctl/FIONREAD count as indicating
526 that there are bytes to read. Some versions of linux-2.6.16 do that.
527 Write any pending output before returning.
528 Reported by Dan Jacobson in <http://bugs.debian.org/370583>.
529 * NEWS: Mention this bug fix.
530 * tests/misc/cat-proc: New file. Test for the above.
531 * tests/misc/Makefile.am (TESTS): Add cat-proc.
533 2006-06-07 Paul Eggert <eggert@cs.ucla.edu>
535 * src/expr.c (eval4): Detect overflow properly when multiplying
538 2006-06-06 Paul Eggert <eggert@cs.ucla.edu>
540 * NEWS: The 'expr' command now detects and reports integer overflow.
541 (It would be better to use extended precision instead, but that
543 * src/expr.c (integer_overflow): New function.
544 (eval4, eval3): Check for integer overflow.
546 2006-06-05 Paul Eggert <eggert@cs.ucla.edu>
548 Fix problems when building with Solaris/SVR4/etc. make, which uses a
549 different and somewhat bogus implementation of VPATH. In the
550 directory tests/misc, rename tests whose names might appear in the
551 Automake-generated rules. For example, we can't use a test named
552 'test', since Automake generates a rule that contains the text
553 "if test -f ./$$tst; ...", and this might expand to something like
554 "if ../../../coreutils-6.0/tests/misc/test -f ./$$test; ...",
555 which executes the 'test' script rather than the 'test' command.
556 * tests/misc/false-status: Renamed from tests/misc/false.
557 * tests/misc/pwd-long: Renamed from tests/misc/pwd.
558 * tests/misc/sort-merge: Renamed from tests/misc/sort.
559 ($prog): Set to 'sort' rather than to $PROG.
560 * tests/misc/test-diag: Renamed from tests/misc/test.
561 * tests/misc/Makefile.am (PROG): Take the basename of $$tst,
562 in case Solaris make has prepended the directory.
563 (TESTS): Adjust to above renamings.
564 * tests/misc/expand: Don't assign to PROG; no longer needed
565 now that Makefile.am sets PROG to the basename.
566 * tests/misc/fold: Likewise.
568 2006-06-03 Jim Meyering <jim@meyering.net>
570 Make `cp --link --no-dereference' work also on systems where the
571 link system call cannot create a hard link to a symbolic link.
572 * src/copy.c (copy_internal) [LINK_FOLLOWS_SYMLINKS]: Don't use
573 the link syscall on a symlink when it would do the wrong thing.
574 Based on the patch by Aurelien Jarno: <http://bugs.debian.org/329451>
575 * tests/cp/link-no-deref: New file/test for the above.
576 * tests/cp/Makefile.am (TESTS): Add link-no-deref.
577 * NEWS: Mention the change (doesn't affect Linux).
579 2006-06-01 Paul Eggert <eggert@cs.ucla.edu>
581 Fix some porting problems in the test cases reported by
582 Ralf Wildenhues for HP-UX 11.23 in:
583 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00238.html
584 * tests/help-version: Don't assume that \< \> works in sed.
585 * tests/misc/close-stdout: Don't assume that >&- works.
586 Add a /dev/full test.
587 * tests/touch/no-create-missing: Don't assume that >&- works.
589 2006-05-30 Jim Meyering <jim@meyering.net>
591 * src/ls.c (usage): Add `v' to the list of sorting-related options.
594 2006-05-28 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
596 * tests/cp/fail-perm: source lang-default.
597 * tests/rm/inaccessible: Likewise.
599 2006-05-28 Jim Meyering <jim@meyering.net>
601 * tests/rm/inaccessible: AIX 4.3.3 gives a different diagnostic.
602 Recognize it, too. Reported by Ralf Wildenhues, in
603 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
605 2006-05-27 Jim Meyering <jim@meyering.net>
607 * src/chgrp.c: Support new options: --preserve-root and
608 --no-preserve-root. Somehow this program was skipped when those
609 options were added to chown, chmod, and rm. Reported by
610 vaqflabuopac@spammotel.com in <http://bugs.debian.org/365656>.
611 * NEWS: Mention this.
613 2006-05-25 Paul Eggert <eggert@cs.ucla.edu>
615 * NEWS: Remove mention of --seed. We'll replace it with something
616 better, and don't want to indicate that it is supported.
617 * src/sort.c (usage): Likewise.
619 2006-05-20 Jim Meyering <jim@meyering.net>
621 * src/chmod.c (main): Use FTS_PHYSICAL here, too.
623 * src/du.c (main): Rename local, s/symlink_deref_bit/symlink_deref_bits/
624 and arrange for -D to set fts' FTS_PHYSICAL bit as well as
625 FTS_COMFOLLOW. Spotted by Justin Pryzby.
627 * gnupload: Merge changes from automake, retaining the ""--to...
628 kludge to placate overzealous `make distcheck' check.
630 2006-05-19 Jim Meyering <jim@meyering.net>
632 * src/du.c (main): Don't let -D, -L, or -P turn off the internal
633 FTS_TIGHT_CYCLE_CHECK directory traversal option.
634 Reported by Justin Pryzby in http://bugs.debian.org/367691
636 2006-05-15 Jim Meyering <jim@meyering.net>
638 * src/cp.c (usage): Correct description of -a: s/-dpR/-dpPR/.
641 2006-05-13 Jim Meyering <jim@meyering.net>
643 * tests/mv/no-target-dir: Test two more cases.
645 2006-05-11 Jim Meyering <jim@meyering.net>
647 mv -T DIR EMPTY_DIR no longer fails unconditionally
648 * src/copy.c (copy_internal): Don't manually prohibit a move where
649 the destination is an existing directory. Sometimes doing that is
650 valid. Let the rename system call enforce the rules. That is
651 allowed only when the source is a directory and the destination
652 directory (to be replaced) is empty. Reported by Eric Blake.
653 * tests/mv/no-target-dir: New file/test for this.
654 * tests/mv/Makefile.am (TESTS): Add no-target-dir.
655 * NEWS: Mention this.
657 * tests/mv/atomic: New file/test for yesterday's fix.
658 * tests/mv/Makefile.am (TESTS): Add atomic.
660 * tests/du/long-sloop: Avoid harmless `ambiguous redirect' diagnostic.
662 2006-05-10 Jim Meyering <jim@meyering.net>
664 * src/copy.c (copy_internal): Don't explicitly unlink the destination
665 when moving a symlink into the place of an existing non-directory.
666 Reported by Joshua Hudson.
667 * NEWS: mention this.
669 2006-05-07 Jim Meyering <jim@meyering.net>
671 * Makefile.maint (patch-check): Fail if patch generates any output,
672 even merely for changed offsets.
674 * src/c99-to-c89.diff: Adjust to reflect new offsets.
676 * NEWS: Mention changes affecting df, pwd, shred.
678 2006-05-06 Jim Meyering <jim@meyering.net>
680 * tests/ls/stat-vs-dirent: New test, to detect the bogus file
681 system condition where dirent.d_ino != stat.st_ino.
682 * tests/ls/Makefile.am (TESTS): Add stat-vs-dirent.
684 2006-05-06 Eric Blake <ebb9@byu.net>
686 * tests/ls/inode: Expand to test inode from readdir case.
687 * tests/ls/follow-slink: Expand to test broken links encountered
688 implicitly, favoring Solaris 9 and OpenBSD 3.4 behavior.
690 2006-05-06 Eric Blake <ebb9@byu.net>
692 * tests/mv/leak-fd: Work even on case-insensitive file system.
694 2006-05-04 Jim Meyering <jim@meyering.net>
696 * NEWS: Mention the 2006-03-19 pwd-related change that makes
697 lib/getcwd.c work around inconsistent file system dirent.d_ino data.
699 2006-05-03 Jim Meyering <jim@meyering.net>
701 * src/ls.c (DEFINE_SORT_FUNCTIONS, LIST_SORTFUNCTION_VARIANTS):
702 Use better macro parameter names: s/basename/key_name/,
703 s/basefunc/key_cmp_func. Fix typo in comment.
705 2006-04-29 Eric Blake <ebb9@byu.net>
707 * src/ls.c (main): On systems with d_type, directories_first only
708 implies format_needs_type, not format_needs_stat.
710 2006-05-03 Jim Meyering <jim@meyering.net>
712 * src/ls.c (xstrcoll_df_version, rev_xstrcoll_df_version): Add space
713 after comma in arg list, from Eric Blake.
715 2006-04-25 Paul Eggert <eggert@cs.ucla.edu>
717 * tests/misc/date (relative-3): New test, derived from a bug
718 report by John Thomas McDole.
720 2006-04-23 Francesco Montorsi <fr_m@hotmail.com>
722 New option for ls: --group-directories-first.
723 It makes ls list directories before files.
724 * NEWS [New features]: Mention it.
725 * src/ls.c (sort_type): Rearrange to use as an array index when
726 choosing sort function; added new sort_numtypes member for
728 (time_type): Add new time_numtypes member for compile-time check.
729 (directories_first): New global variable.
730 (GROUP_DIRECTORIES_FIRST_OPTION): New enum.
731 (long_options): Add --directories-first.
732 (main): Support new option.
733 (is_directory): New function.
734 (extract_dirs_from_files): Use it.
735 (DIRFIRST_CHECK, DEFINE_SORT_FUNCTIONS)
736 (LIST_SORTFUNCTION_VARIANTS): New macros.
737 (sort_functions): New global variable.
738 (sort_files): Use it.
739 (usage): Document new option.
741 2006-04-18 Paul Eggert <eggert@cs.ucla.edu>
743 * src/shred.c (fillrand): The assertion was way too weak, due to
744 what must be a typo. Strengthen it to its intended value.
745 (dopass): Don't use alloca; it's not worth the aggravation here,
746 since it's used only to get a page-aligned buffer, and page
747 alignment doesn't buy us much here. I'm suspicious that alloca
748 causes problems on some hosts, due to a recent bug report by Adam
749 Waltman: http://bugs.gentoo.org/130246.
751 2006-04-18 Jim Meyering <jim@meyering.net>
753 * tests/misc/tty-eof: Add new programs, base64, sha224sum, sha256sum,
754 sha384sum, sha512sum.
756 2006-04-17 Paul Eggert <eggert@cs.ucla.edu>
758 * src/chmod.c (describe_change): Adjust to filemode changes.
759 * src/ls.c (HAVE_ST_DM_MODE): Remove; moved to ../lib/filemode.c.
760 (print_long_format): Use (new) filemodestring rather than
761 (old) mode_string, so that we get more file types right, at least
762 in theory. Adjust to filemode changes.
763 * src/stat.c (human_access): Likewise.
765 2006-04-18 Jim Meyering <jim@meyering.net>
767 * src/ptx.c (main) [DEFAULT_IGNORE_FILE]: Remove code to use a default
768 ignore file. This has never been enabled. Reported by Eric Blake.
770 2006-04-12 Paul Eggert <eggert@cs.ucla.edu>
772 * src/ln.c (linkfunc): Remove. This method ran into a compiler/linker
773 bug in Interix. Just call symlink or link directly. All uses changed.
774 * src/setuidgid.c (main) [! HAVE_SETGROUPS]: Don't call setgroups.
775 * src/stat.c (USE_STATVFS): New macro.
776 Include <sys/statvfs.h> and use statvfs only if USE_STATVFS.
777 (NAMEMAX_FORMAT): define a bit more clearly, now that the
778 statvfs-using code is a bit more regular.
779 * src/system.h (sync) [!HAVE_SYNC]: New macro.
781 2006-04-11 Paul Eggert <eggert@cs.ucla.edu>
783 * NEWS: csplit, nl, expr now conform to POSIX better, and are
784 more-compatible with traditional Unix, with respect to regular
786 * src/csplit.c (extract_regexp): Set re_syntax_options to a
787 value that is compatible with what POSIX requires.
788 * src/nl.c (build_type_arg): Likewise.
789 * src/expr.c (docolon): Likewise. Also, don't let anchors match
790 newline; this fixes an incompatibility with tradition and with POSIX.
791 Don't warn about leading ^. POSIX says it is unspecified whether
792 ^ is a special character, which means that implementations can
793 either treat it as special or not, but either way a warning is not
794 allowed (unless the regexp is otherwise invalid). Instead, anchor
795 the expression but treat ^ as an anchor; this is the traditional
796 behavior (e.g., Solaris 10).
797 (eval4, eval3, eval2): Treat non-numeric args, division by zero,
798 and the like as invalid expressions (exit status 2), not as
799 failure of 'expr' (exit status 3). This is more consistent with
801 * tests/expr/basic (fail-a): Adjust exit status to match new expr
802 behavior, for status 2 versus 3.
804 (bre1, bre2, bre3, bre4, bre5, bre6, bre7, bre8, bre9, bre10):
805 (bre11, bre12, bre13, bre14, bre15, bre16, bre17, bre18, bre19, bre20):
806 (bre21, bre22, bre23, bre24, bre25, bre26, bre27, bre28, bre29, bre30):
807 (bre31, bre32, bre33, bre34, bre35, bre36, bre37, bre38, bre39, bre40):
808 (bre41, bre42, bre43, bre44, bre45, bre46, bre47, bre48, bre49, bre50):
809 (bre51, bre52, bre53, bre54, bre55, bre56, bre57, bre58, bre59, bre60):
810 (bre61, bre62): New tests.
811 * tests/misc/csplit: Use \{...\} in test RE, to test that we're
815 * tests/du/long-from-unreachable: Solaris 8 sh doesn't understand
816 "if !". Do not assume that 'sed' can handle long, newline-free input.
817 * tests/du/long-sloop: Likewise. Evaluate expr once, not $n times.
819 2006-04-10 Paul Eggert <eggert@cs.ucla.edu>
821 Adjust to new regex.h API (with new fastmap type), and clean
822 up the regex storage allocation a bit.
824 * src/csplit.c (struct control): Put re_compiled member at the
825 end, since it's large. Change regexpr member from char * to bool;
826 all uses changed. Add new member fastmap.
827 (extract_regexp): regexp arg is now char const *, not char *.
828 Don't bother duplicating the regular expression; it's not needed.
829 Set fastmap from new fastmap member. Don't bother allocating
830 a buffer, as the regexp code does a better job than we do.
831 * src/expr.c (docolon): Allocate and use a fastmap.
832 Don't bother allocating a buffer.
833 * src/nl.c (body_fastmap, header_fastmap, footer_fastmap):
835 (build_type_arg): New fastmap arg. All uses changed.
836 Don't bother allocating a buffer, but set a fastmap.
837 * src/ptx.c (context_regex_string, word_regex_string): Remove.
838 (context_regex, word_regex): New vars, replacing the above.
840 (struct regex_data): New type.
841 (compile_regex): Renamed from alloc_and_compile_regex, since
842 we no longer allocate storage. Arg is now a struct regex_data *,
843 not a const char *. All uses changed. Don't allocate the fastmap;
844 instead, take it from the caller. Don't convert size_t to int,
845 to avoid arithmetic overflow problems. Don't bother freeing
846 storage afterwards; it's not worth the aggravation.
847 * src/tac.c (compiled_separator_fastmap): New ver.
848 (main): Use it. Don't bother allocating a buffer.
850 2006-03-30 Jim Meyering <jim@meyering.net>
852 * src/dd.c (iwrite): Remove assignment without effect.
853 Reported by Felix Rauch Valenti.
855 2006-03-22 Eric Blake <ebb9@byu.net>
857 * src/ptx.c (usage): Remove mention of --copyright/-C.
858 (main): Alias --copyright to --version plus a deprecation warning.
859 * NEWS: Mention this.
861 2006-03-27 Jim Meyering <jim@meyering.net>
863 * src/Makefile.am (uptime_LDADD): Add $(POW_LIB), for uptime's
864 use of strtod. Tiny patch from Nickolai Zeldovich.
866 2006-03-11 Eric Blake <ebb9@byu.net>
868 * tests/misc/dirname: New file.
869 * tests/basename/Makefile.am: Delete.
870 * tests/basename/basic: Move to...
871 * tests/misc/basename: ... this new file. Add some tests,
872 including fixed behavior for //.
873 * tests/misc/Makefile.am (TESTS): Sort. Add basename, dirname.
874 * tests/Makefile.am (SUBDIRS): Remove basename.
875 * configure.ac (AC_CONFIG_FILES): Remove tests/basename.
877 Improvements to dirname/basename handling on platforms like
878 cygwin with distinct // and with drive letters.
879 * NEWS: Document new behavior.
880 * src/basename.c (main): Don't strip suffix from file system
882 * src/cp.c (target_directory_operand): Use new last_component.
883 (ASSIGN_BASENAME_STRDUPA): Likewise. Reduce time spent
884 traversing the string.
885 * src/dircolors.c (guess_shell_syntax): Use new last_component.
886 * src/install.c (target_directory_operand, install_file_in_dir):
888 * src/ln.c (target_directory_operand, main): Likewise.
889 * src/ls.c (basename_is_dot_or_dotdot): Likewise.
890 * src/mv.c (target_directory_operand, movefile): Likewise.
891 * src/remove.c (rm_1): Likewise.
892 * src/shred.c (wipename): Likewise.
893 * src/split.c (next_file_name): Likewise.
894 * src/su.c (log_su, run_shell): Likewise.
896 2006-03-23 Paul Eggert <eggert@cs.ucla.edu>
898 * NEWS: nohup diagnostics are now more precise, and nohup now
899 redirects stderr to nohup.out if stdout is closed and stderr is a tty.
900 * src/nohup.c (main): Implement this.
901 * tests/misc/nohup: Test the new behavior.
903 2006-03-12 Jim Meyering <jim@meyering.net>
905 * src/copy.c (set_author): Rename function, from preserve_author.
907 * src/remove.c (AD_pop_and_chdir): Use new macro,
908 CYCLE_CHECK_REFLECT_CHDIR_UP, rather than open-coding it.
910 * src/system.h (SAME_INODE): Remove definition.
911 Include "same-inode.h", instead.
913 2006-03-11 Eric Blake <ebb9@byu.net>
915 * src/pwd.c (robust_getcwd): Prepend only one slash, not two.
917 2006-03-10 Jim Meyering <jim@meyering.net>
919 Fix a bug whereby a user with write access to a directory being removed
920 could cause the removal of that directory to fail with an erroneous
921 diagnostic about a directory cycle. Reported by Vineet Chadha.
923 * NEWS: Mention this.
924 * src/remove.c (AD_pop_and_chdir): If the directory we're about to
925 leave (and try to rmdir) is the one whose dev_ino is being used to
926 detect a cycle, reset cycle_check_state.dev_ino to that of the parent.
928 2006-03-08 Paul Eggert <eggert@cs.ucla.edu>
930 * NEWS: Document dd's new 'directory' and 'nolinks' flags.
931 * src/dd.c (set_fd_flags): Handle file-creation flags on file
932 descriptors, rather than ignoring them.
933 * tests/dd/misc: Add test cases for append, nofollow, directory,
934 and nolinks flags. Simplify redirection to /dev/null in some cases.
936 * tests/dd/misc: iflags->iflag. This fixes a typo that meant the
937 noatime test never tested anything.
939 2006-03-05 Paul Eggert <eggert@cs.ucla.edu>
941 * src/dd.c (flags, usage): New flags directory, nolinks.
942 * src/system.h (O_NOLINKS): Define to 0 if not already defined.
944 * src/ls.c (usage): Mention that -f disables --color.
945 Problem reported by Niels Möller.
947 2006-03-03 Justin Pryzby <pryzbyj@justinpryzby.com>
949 * man/*.x: Add references to syscalls from utilities of the same name.
951 2006-03-05 Jim Meyering <jim@meyering.net>
953 * tests/help-version: Set SHELL, if not already set, in order to
954 avoid failure when `make check' is run through debuild; dircolors
955 would fail due to lack of $SHELL. Reported by Sven Joachim.
957 Make `base64 --wrap=N' work for N=0, and for N larger than SIZE_MAX.
958 * src/base64.c (wrap_write, do_encode, main): Change type of
959 parameters and locals, wrap_column, form size_t to uintmax_t.
960 (main): Adjust to use xstrtoumax, accordingly.
962 2006-03-03 Jim Meyering <jim@meyering.net>
964 Don't fail when run from an environment with SHELL not a Bourne
965 shell, e.g. `env SHELL=/bin/csh make check' would fail this test.
966 * tests/dircolors/simple: Invoke each non-failing test with -b.
967 Reported by Michael Stone.
969 2006-02-27 Jim Meyering <jim@meyering.net>
971 * tests/misc/base64: Derive --decode-using tests from the
974 * tests/misc/base64: Factor out a long constant string.
975 Split lines to stay within 80 columns.
977 * tests/misc/Makefile.am (TESTS): Add base64.
978 * tests/misc/base64: Test base64. From Simon Josefsson.
980 * src/base64.c (do_decode): Use correct type for parameter,
981 ignore_garbage: s/size_t/bool/.
983 * src/base64.c: Don't include .h files already included by system.h:
984 <string.h>, <stdlib.h>, <stdbool.h>, <limits.h>, <errno.h>.
985 Include "system.h" before the other lib/*.h header files.
986 Include <sys/types.h> before "system.h".
987 (wrap_write): Remove declaration of unused local, initial_column.
988 (wrap_write): Correct declaration syntax: s/size_t * V/size_t *V/.
990 * README: Add base64 to the list.
992 2006-02-17 Simon Josefsson <jas@extundo.com>
995 * AUTHORS: Mention base64.
997 * man/Makefile.am: Build base64.1.
998 * man/base64.x: New file.
999 * src/Makefile.am (bin_PROGRAMS): Add base64.
1000 * src/base64.c: New file.
1002 2006-02-25 Eric Blake <ebb9@byu.net>
1004 In ls, avoid calling stat for --inode (-i), when possible.
1005 * src/pwd.c (NOT_AN_INODE_NUMBER, D_INO): Move to ...
1006 * src/system.h: ... here, for use in ...
1007 * src/ls.c (main): ... here. Prefer dirent.d_ino to stat when
1009 (gobble_file): Add inode argument.
1010 (print_dir): Pass inode if available.
1011 (usage): Remove inaccuracy.
1013 2006-02-23 Jim Meyering <jim@meyering.net>
1015 * TODO: Update/correct some obsolete entries.
1017 2006-02-20 Paul Eggert <eggert@cs.ucla.edu>
1019 * doc/coreutils.texi (join invocation): Mention `sort -k 1b,1'.
1020 * src/join.c (usage): Likewise.
1021 Documentation problem reported by Philip Kensche.
1023 2006-02-20 Eric Blake <ebb9@byu.net>
1025 * man/rm.x: Update documentation to match previous patch.
1027 2006-02-18 Eric Blake <ebb9@byu.net>
1029 New option for rm: --interactive=once (-I).
1030 * NEWS: Document it, along with change to rm --interactive.
1031 * TODO: Remove entry for implementing rm -I
1032 * src/rm.c (INTERACTIVE_OPTION): New enum value.
1033 (interactive_type): New enum.
1034 (long_opts): Let interactive take an optional argument.
1035 (interactive_args, interactive_types): New option arguments.
1036 (usage): Document -I, --interactive=WHEN. Use program_name
1037 instead of a basename.
1038 (main): New -I option, new behavior to --interactive.
1039 * tests/rm/interactive-once: New tests.
1040 * tests/rm/interactive-always: Ditto.
1041 * tests/rm/Makefile.am (TESTS): Run them.
1043 2006-02-18 Jim Meyering <jim@meyering.net>
1045 * Makefile.maint (sc_two_space_separator_in_usage): Make the regular
1046 expression match more of the target lines, e.g., those that start with
1047 `-S,' (short option followed by a comma) or that include `=[...]'.
1048 Patch by Nicolas François.
1049 Fix the four offenders thus exposed:
1050 * src/join.c (usage): Use two spaces (not one) to separate the
1051 --first-only option string from its description, so help2man formats
1052 the derived man page properly.
1053 * src/pr.c (usage): Likewise.
1054 * src/uniq.c (usage): Likewise.
1055 * src/install.c (usage): Likewise.
1057 2006-02-15 Jim Meyering <jim@meyering.net>
1059 * Makefile.maint (alpha beta major): For `make major', ensure that the
1060 version string is of the form N.N[.N]*, where N is one or more digits.
1062 2006-02-14 Jim Meyering <jim@meyering.net>
1064 * INSTALL: Update from gnulib.
1066 2006-02-13 Jim Meyering <jim@meyering.net>
1068 * GNUmakefile (all): Emit diagnostics to stderr, not stdout.
1070 2006-02-12 Jim Meyering <jim@meyering.net>
1072 * Makefile.maint (patch-check): New target.
1073 (local-checks-available): Add to the list.
1075 2006-02-11 Jim Meyering <jim@meyering.net>
1077 * src/c99-to-c89.diff: New file.
1078 * src/Makefile.am (EXTRA_DIST): Add c99-to-c89.diff.
1080 * .x-po-check: New file, with exclusions so that `make distcheck'
1082 * Makefile.am (EXTRA_DIST): Add .x-po-check.
1084 rm -r must remove an empty directory, even if it is inaccessible.
1085 * src/remove.c (close_preserve_errno): New function.
1086 (fd_to_subdirp): Don't print a diagnostic in this function.
1087 Do it from the callers instead, unless rmdir succeeds.
1088 (remove_cwd_entries, remove_dir): Adjust callers.
1089 * tests/rm/empty-inacc: New test for the above.
1090 * tests/rm/Makefile.am (TESTS): Add empty-inacc.
1091 * NEWS: Mention this bug fix.
1092 * tests/rm/rm2: Adjust two expected diagnostics, now that they're
1093 a tiny bit less precise: cannot remove `a/1': ... instead of
1094 cannot open directory `a/1': ...
1096 * Makefile.maint (syntax-check-rules): Automatically derive this
1097 list of sc_-prefixed rule names.
1099 2006-02-10 Paul Eggert <eggert@cs.ucla.edu>
1101 * Makefile.maint (CVS_LIST): Don't assume cvsu is available.
1102 (CVS_LIST_EXCEPT): New macro, to simplify exception-processing.
1103 Most uses of CVS_LIST changed to use CVS_LIST_EXCEPT.
1104 (syntax-check-rules): Bring back sc_changelong. (Hmm, why did it
1105 go away? was that an accident?)
1106 (sc_cast_of_argument_to_free, sc_cast_of_x_alloc_return_value):
1107 (sc_cast_of_alloca_return_value, sc_space_tab, sc_prohibit_atoi_atof):
1108 (sc_error_exit_success, sc_file_system, sc_no_if_have_config_h):
1109 (sc_system_h_headers, sc_sun_os_names, sc_trailing_blank):
1110 (sc_two_space_separator_in_usage, sc_unmarked_diagnostics):
1111 (sc_obsolete_symbols, sc_changelog, sc_prohibit_jm_in_m4):
1112 (sc_useless_cpp_parens, makefile-check, m4-check, po-check):
1113 (author_mark_check, makefile_path_separator_check):
1114 Output line numbers, to simplify navigation of Emacs *compilation*
1116 (sc_prohibit_atoi_atof, sc_file_system):
1117 Rework slightly so that Makefile.maint doesn't get reported as a
1118 violation of its own syntax rules.
1119 (sc_dd_max_sym_length): Use ifneq to do nothing, instead of doing
1120 it at run-time (which didn't work with Bison). Fix a makefile typo,
1121 caught by Makefile.maint itself: spaces where a tab should be.
1122 (po-check): Check lib/*.[ch] even if not in CVS; used by Bison,
1123 which copies from ../gnulib/lib/*.[ch] to lib/*.[ch].
1124 Ignore djgpp and man subdirectories, to avoid false matches with
1125 Bison and coreutils, respectively. Use sort -u to remove the
1126 resulting duplicates.
1127 * gnupload: Rework slightly to avoid bogus warning from
1128 sc_two_space_separator_in_usage.
1130 2006-02-10 Jim Meyering <jim@meyering.net>
1132 Use gzip's --rsyncable option only if it's available.
1133 * Makefile.maint (gzip_rsyncable): New variable.
1136 2006-02-08 Jim Meyering <jim@meyering.net>
1138 * Makefile.maint (local-checks-available): Define in terms of
1139 the expansion, $(syntax-check-rules), rather than the single,
1140 top-level target `syntax-check', so that it's easier to exclude
1141 individual rules (via $(local-checks-to-skip)).
1142 (tgz-md5, tgz-sha1, ...): Remove now-unused definitions.
1144 2006-02-07 Jim Meyering <jim@meyering.net>
1146 * src/system.h (!defined O_DIRECT): If O_DIRECTIO is defined (as it
1147 is on Tru64), define O_DIRECT to that. Patch From James Lemley.
1149 * tests/help-version (expected_failure_status_vdir):
1150 Redirect an expected disk-full diagnostic to /dev/null.
1152 2006-02-06 Jim Meyering <jim@meyering.net>
1154 * src/unexpand.c (usage): Use two spaces (not one) to separate the
1155 --first-only option string from its description, so help2man formats
1156 the derived man page properly.
1157 * src/rm.c (usage): Likewise for --no-preserve-root.
1158 * src/chown.c (usage): Likewise.
1159 * src/chgrp.c (usage): Likewise.
1161 Add a rule to ensure that the above doesn't happen again.
1162 * Makefile.maint (sc_two_space_separator_in_usage): New rule.
1163 (syntax-check-rules): Add it.
1164 * .x-sc_two_space_separator_in_usage: New empty file.
1165 * Makefile.am (EXTRA_DIST): Add .x-sc_two_space_separator_in_usage.
1167 2006-02-06 Jim Meyering <jim@meyering.net>
1169 * src/cp.c (usage): Use two spaces (not one) to separate each
1170 option string from its description, so help2man formats the
1171 derived man page properly.
1172 * src/mv.c (usage): Likewise.
1173 Patch from Nicolas François in http://bugs.debian.org/351601.
1175 2006-02-04 Jim Meyering <jim@meyering.net>
1177 * src/copy.c (copy_internal): cp -RL would fail when encountering
1178 the same directory more than once in the hierarchy beneath a single
1179 command-line argument. That is legitimate, e.g. when there are
1180 two or more symbolic links, each pointing to some directory that
1181 would not otherwise be copied. Reported by Christophe LYON.
1182 * tests/cp/cp-deref: New file. Test for today's fix.
1183 * tests/cp/Makefile.am (TESTS): Add cp-deref.
1184 * NEWS: Document this.
1186 2006-02-03 Jim Meyering <jim@meyering.net>
1188 * configure.ac: Require automake-1.9.6, not 1.8.3.
1190 2006-02-01 Paul Eggert <eggert@cs.ucla.edu>
1192 * src/od.c (usage): Mention that -t a ignores high order bit.
1193 Documentation problem reported by Ed Avis.
1195 2006-02-01 Jim Meyering <jim@meyering.net>
1197 * src/pwd.c (find_dir_entry): Remove unused local, `ent_sb_valid'.
1199 2006-01-30 Paul Eggert <eggert@cs.ucla.edu>
1201 * src/head.c (main): Use a better diagnostic when someone uses a
1202 trailing numeric option in an invalid way. Problem reported by
1204 * src/tail.c (parse_options): Likewise.
1206 2006-01-30 Jim Meyering <jim@meyering.net>
1208 * man/wc.x: Include `count' keyword in man page synopsis,
1209 per suggestion from http://bugs.debian.org/181585.
1211 2006-01-24 Paul Eggert <eggert@cs.ucla.edu>
1213 * src/df.c (show_dev): If the file system claims to have
1214 more available than total blocks, report the number of used
1215 blocks as being total - available (a negative number) rather
1216 than as garbage. Problem reported by Toralf Foerster.
1218 2006-01-24 Jim Meyering <jim@meyering.net>
1220 * src/tail.c (tail_forever): Don't exit-nonzero when an attempt
1221 to put a regular file in O_NONBLOCK mode fails with EPERM.
1222 That happens on Linux (up to 2.6.15) when using tail -f on a file with
1223 the append-only attribute. Reported by Dean Gaudet. For details,
1224 see http://savannah.gnu.org/bugs/?func=detailitem&item_id=15473.
1225 * NEWS: Mention this fix.
1226 * tests/tail-2/append-only: New file. Test for the above.
1227 * tests/tail-2/Makefile.am (TESTS): Add append-only.
1228 * tests/Makefile.am (check-root): Add tail-2/append-only
1230 2006-01-21 Jim Meyering <jim@meyering.net>
1232 * NEWS: Mention fts-related improvements and bug fixes.
1234 2006-01-19 Jim Meyering <jim@meyering.net>
1236 * tests/fmt/basic (pfx-1, pfx-2): New tests, to demonstrate the bug
1237 reported as http://bugs.debian.org/147577. Forwarded by Thomas Hood.
1239 2006-01-18 Jim Meyering <jim@meyering.net>
1241 * tests/du/Makefile.am (TESTS): Add long-from-unreadable.
1243 2006-01-17 Jim Meyering <jim@meyering.net>
1245 Now that fts no longer changes the current working directory, adjust
1246 its clients accordingly -- note that du.c uses fts but doesn't need
1247 any adjustment, since it doesn't operate on the actual files,
1248 but rather just uses the stat buffers provided by fts.
1250 * src/chown-core.c: Include "openat.h".
1251 Don't include "lchown.h".
1252 (restricted_chown): Accept a new parameter, CWD_FD, and use it in
1253 calling openat, lchownat, chownat, rather than open, lchown, chown.
1255 * src/chmod.c: Include "openat.h".
1256 (process_file): Use chmodat (fts->fts_cwd_fd,... in place of chmod (...
1258 * tests/du/long-from-unreadable: New test, to exercise one small
1261 2006-01-13 Jim Meyering <jim@meyering.net>
1263 * tests/Makefile.am (SUBDIRS): Add comments discouraging the
1264 addition of new directories under tests/.
1266 * tests/acl: Redirect stdin to /dev/null. Otherwise, FreeBSD 5.0's
1269 2006-01-12 Jim Meyering <jim@meyering.net>
1271 * tests/du/long-sloop: Adjust not to hard-code the expected
1272 diagnostic corresponding to ELOOP. Solaris' diagnostic differs
1273 from that of GNU libc. Reported by Paul Eggert.
1275 * tests/du/long-sloop: Create file at end of symlink chain.
1277 * tests/misc/test: New file, with a test for one of the
1278 bugs fixed by yesterday's test.c changes.
1279 * tests/misc/Makefile.am (TESTS): Add test.
1281 2006-01-11 Jim Meyering <jim@meyering.net>
1283 * tests/du/long-sloop: New file. Test for today's fts.c bug fix.
1284 That bug could make du -L, chgrp -L, or chown -L fail to diagnose
1285 a very long sequence of symbolic links (not necessarily a loop).
1286 * tests/du/Makefile.am (TESTS): Add long-sloop.
1288 2006-01-11 Paul Eggert <eggert@cs.ucla.edu>
1290 * src/test.c (test_syntax_error): Append a newline. All callers
1291 changed, except for the ones that didn't already append a newline.
1292 Bug reported by Eric Blake.
1294 2006-01-11 Jim Meyering <jim@meyering.net>
1296 * src/system.h (X2NREALLOC): Now that verify_true is no longer
1297 void, cast its result to void, to avoid gcc's warning that
1298 ``left-hand operand of comma expression has no effect''.
1299 (DECIMAL_DIGIT_ACCUMULATE, X2REALLOC): Likewise.
1301 2006-01-10 Jim Meyering <jim@meyering.net>
1303 * tests/chmod/no-x: Add a test for today's fts.c fix.
1305 2006-01-10 Jim Meyering <jim@meyering.net> (tiny change)
1307 * src/ls.c (gobble_file): Use DTTOIF only if it's defined.
1308 This is necessary for Dragonfly. Patch by Joerg Sonnenberger.
1310 2006-01-10 Paul Eggert <eggert@cs.ucla.edu>
1312 * src/system.h (X2NREALLOC, X2REALLOC, DECIMAL_DIGIT_ACCUMULATE):
1313 Use verify_true instead of verify_expr, to sync with gnulib.
1315 2006-01-08 Jim Meyering <jim@meyering.net>
1317 * src/date.c (usage): Adjust the formatting of the entries for
1318 %::z and %:::z (separate with two spaces, not one) so that help2man
1319 formats them properly. Reported by Philip Rowlands.
1321 2006-01-06 Paul Eggert <eggert@cs.ucla.edu>
1323 * configure.ac (gl_IGNORE_UNUSED_LIBRARIES): Add.
1325 2006-01-06 Jim Meyering <jim@meyering.net>
1327 * Makefile.maint (copyright-check): Use date +%Y in place of
1330 * src/remove.c (rm_1): Remove `static' attribute on local `status'.
1331 First off, the attribute should have been `volatile' (not static)
1332 to avoid longjmp-related risk of clobber. Secondly, now there is
1333 no longer any risk of a local variable being clobbered, so there's
1334 no need for any attribute at all.
1336 2006-01-05 Jim Meyering <jim@meyering.net>
1338 * src/remove.c: Give a few functions the inline attribute.
1339 (AD_pop_and_chdir): Use gotos to avoid some duplication.
1340 (AD_push): Rewrite an assertion so that the entire computation
1341 goes away when assertions are turned off.
1343 * src/tail.c (ENOSYS) [!defined ENOSYS]: Don't define here.
1344 It's already defined in "system.h".
1345 * Makefile.maint: Add a FIXME comment.
1347 2006-01-04 Jim Meyering <jim@meyering.net>
1349 * ChangeLog: Remove entries from 2005-10-22 and earlier.
1350 * ChangeLog-2005: New file, for entries up to version 5.92.
1352 2006-01-03 Jim Meyering <jim@meyering.net>
1354 * tests/du/no-x: Also allow a slightly different diagnostic -- the
1355 one you get when using openat-enabled fts.c and du (coming soon).
1356 * tests/chmod/no-x: Likewise.
1357 * tests/chgrp/no-x: Likewise.
1359 * src/system.h (O_DIRECTORY) [!defined O_DIRECTORY]: Define.
1361 2006-01-02 Paul Eggert <eggert@cs.ucla.edu>
1363 * src/chown-core.c (RC_do_ordinary_chown): New enum value.
1364 (restricted_chown): Return it, if the file cannot be accessed due
1365 to EPERM, or if no uid or gid are required, or if the file is
1366 neither a directory nor a regular file. Rewrite to avoid gotos.
1367 (change_file_owner): Handle RC_do_ordinary_chown case.
1368 Rewrite to avoid gotos.
1369 * tests/chgrp/basic: Make sure we can change the group of
1372 * src/date.c (usage): Explain %g, %G, and %V a bit better.
1374 2006-01-02 Jim Meyering <jim@meyering.net>
1376 * src/copy.c (set_owner): Correct a comment.
1378 * src/tail.c (parse_options): Change warning to say that --retry
1379 is useful `mainly' (not `only') when following by name.
1380 Reported here: http://bugs.debian.org/273781
1382 2006-01-01 Paul Eggert <eggert@cs.ucla.edu>
1384 * NEWS: Document that mkfifo and mknod -m no longer set special bits.
1385 * src/copy.c: Include lchmod.h.
1386 (copy_internal): Use lchmod rather than chmod.
1387 * src/cp.c: Include lchmod.h.
1388 (re_protect, make_dir_parents_private): Use lchmod rather than chmod.
1389 * src/mkdir.c: Include lchmod.h.
1390 (usage): Clarify -m's operation.
1391 (main): Use lchmod rather than chmod. Don't use lchmod unless the
1392 new mode contains bits outside the 777 range.
1393 * src/mkfifo.c (usage): Clarify -m's operation.
1394 (main): If -m is given, don't invoke chmod; use umask 0 instead.
1395 Report an error if -m asks for bits outside the 777 range.
1396 * src/mknod.c (usage, main): Likewise.
1398 * src/mkdir.c, src/mkfifo.c, src/mknod.c: Undo 2005-12-19 changes.
1400 2005-12-27 Jim Meyering <jim@meyering.net>
1402 * Makefile.maint (sc_obsolete_symbols): Prohibit use of O_NDELAY.
1403 (sc_prohibit_assert_without_use): New rule.
1404 (syntax-check-rules): Add it to the list.
1405 * .x-sc_prohibit_assert_without_use: New empty file.
1406 * Makefile.am (EXTRA_DIST): Add it.
1408 * Makefile.maint (CVS_LIST): Define in terms of $(srcdir).
1410 * cp.c, df.c, link.c, mknod.c, nice.c, sleep.c, unlink.c:
1411 Don't include <assert.h>; it wasn't used.
1413 2005-12-26 Paul Eggert <eggert@cs.ucla.edu>
1415 * src/chown-core.c (restricted_chown):
1416 Don't try O_WRONLY unless O_RDONLY failed wth EACCES.
1417 * src/remove.c (fd_to_subdirp): Open with O_DIRECTORY | O_NOCTTY
1418 | O_NOFOLLOW too, for consistency with other dir-openers.
1419 Use POSIX-preferred O_NONBLOCK rather than O_NDELAY.
1420 (is_empty_dir): Likewise.
1421 * src/shred.c (wipename): Likewise. Don't bother trying to open
1422 dir for writing, since POSIX prohibits it.
1424 2005-12-22 Jim Meyering <jim@meyering.net>
1426 * tests/help-version: Redirect stderr to /dev/full, to suppress
1427 write error diagnostic.
1429 2005-12-19 Jim Meyering <jim@meyering.net>
1431 * src/mkdir.c, src/mknod.c, src/mkfifo.c (main)
1432 Avoid a minor race condition when `-m MODE' is specified, by using
1433 open, fchown, and close rather than just chown. To do that reliably --
1434 even with an overly restrictive umask -- ensure that each mkdir,
1435 mknod and mkfifo call uses a mode including at least owner-read access.
1436 * src/mknod.c (main): When `-m MODE' is specified, exit nonzero if
1437 the subsequent chown (or equivalent open,fchown,close) fails.
1438 * tests/misc/mknod: New tests.
1439 * tests/misc/Makefile.am (TESTS): Add mknod.
1441 2005-12-17 Jim Meyering <jim@meyering.net>
1443 * src/remove.c (is_empty_dir): Open with O_NDELAY, so we don't hang,
1444 e.g., on a named pipe.
1445 (OPEN_NO_FOLLOW_SYMLINK): Remove definition. Use O_NOFOLLOW in
1446 place of all uses, since it is guaranteed (system.h) to be defined.
1448 2005-12-05 Andreas Gruenbacher <agruen@suse.de>
1450 Add POSIX ACL support
1451 * src/ls.c: Switch back from HAVE_ACL to USE_ACL: The acl() syscall
1452 is no requirement for ACL support; particularly, it does not exist
1453 on systems that have POSIX ACLs.
1454 * src/copy.h (cp_option_init) [umask_kill]: Remove member.
1455 * src/cp.c (umask_kill): With default acls, the umask is not to be
1456 applied. Remove umask_kill, don't change the process umask, and let
1457 the kernel apply the umask where appropriate.
1458 * src/cp.c (make_dir_parents_private): Fix logic for POSIX ACLs.
1459 * src/copy.c (get_dest_mode): Remove; it is obsolete after removing
1461 (copy_reg, copy_internal): Use copy_acl and set_acl
1462 instead of fchown/chown. Fix the logic for POSIX ACLs.
1463 (chown_succeded): Remove; we now always copy acls and
1464 preserve S_ISUID, S_ISGID, and S_ISVTX when needed, no matter if we
1465 did a chown before or not.
1466 * src/mv.c, src/install.c (cp_option_init): Don't set umask_kill member.
1467 * src/Makefile.am (dir_LDADD, ls_LDADD, vdir_LDADD, cp_LDADD,
1468 mv_LDADD, ginstall_LDADD): On systems with an ACL library, arrange
1469 to link with it via $(LIB_ACL), for the utilities that need it.
1471 2005-12-16 Paul Eggert <eggert@cs.ucla.edu>
1473 * src/remove.c (OPENAT_CWD_RESTORE__REQUIRE): Remove.
1474 (OPENAT_CWD_RESTORE__ALLOW_FAILURE): Likewise.
1475 (fd_to_subdirp): Remove openat_cwd_restore_allow_failure arg; its
1476 value is now signified by whether cwd_errno is null.
1477 (fd_to_subdirp, remove_dir, rm_1); Change cwd failure indicator from
1478 pointer-to-bool to pointer-to-errno-value. All callers changed.
1479 (rm_1): Don't bother setting a local cwd failure flag and then
1480 ORing it into the caller's. Just set the caller's.
1481 (rm): Use cwd failure errno value to print a slightly-better
1484 2005-12-15 Jim Meyering <jim@meyering.net>
1486 * src/stat.c (print_it): Properly handle a backslash at the
1487 end of a --printf format string. Reported by Paul Eggert.
1488 * tests/misc/stat-printf (end-bs): Add a test for the above.
1490 2005-12-15 Paul Eggert <eggert@cs.ucla.edu>
1492 * tests/acl: Port to pre-POSIX shells like Solaris 8 /bin/sh.
1493 Don't assume /etc/passwd contains user names; use 'id' instead.
1495 2005-12-15 Jim Meyering <jim@meyering.net>
1497 stat: revert behavior of --format=FMT (-c)
1498 stat: add new option: --printf=FMT
1499 * NEWS: Mention this.
1500 * src/stat.c (isodigit, octtobin, hextobin): Define.
1501 (PRINTF_OPTION): Define.
1502 (interpret_backslash_escapes, trailing_delim): New globals.
1503 (usage): Document them. Alphabetize on long option names.
1504 (print_esc_char): New function.
1505 (print_it): Rewrite, in order to handle backslash escapes.
1506 (main): Handle new option. Set globals for --format, too.
1508 * tests/misc/stat-printf: Test --printf and --format.
1509 * tests/misc/Makefile.am (TESTS): Add stat-printf.
1511 2005-12-14 Paul Eggert <eggert@cs.ucla.edu>
1513 * NEWS: sort now reports incompatible options.
1514 * src/sort.c (incompatible_options, check_ordering_compatibility):
1516 (main): Use them. Don't bother with a usage message for
1517 "sort -c a b", for consistency with other error diagnostics.
1518 * tests/sort/Test.pm (incompat1, incompat2, incompat3, incompat4):
1521 * src/cat.c (main): Undo previous change. close_stdout already
1522 does the check, so the previous change wasn't necessary.
1524 2005-12-13 Paul Eggert <eggert@cs.ucla.edu>
1526 * src/cat.c (main): Check for close (STDOUT_FILENO) failure.
1528 2005-12-12 Paul Eggert <eggert@cs.ucla.edu>
1530 Install a more-conservative approach for sort -R. It's the
1531 same basic idea as the existing code, except it uses the full ISAAC
1532 approach (called the "more kosher" approach in the existing comments).
1533 This makes "sort -R" quite a bit slower (about a factor of 2 on my
1534 little tests involving 10000 lines on a 2.4 GHz P4), but I think it's
1535 better to be conservative here at first, and review any performance
1536 improvements carefully.
1537 * .x-sc_require_config_h: Add src/rand-isaac.c.
1538 * src/rand-isaac.h: Remove. All uses now simply include rand-isaac.c.
1539 * src/Makefile.am (noinst_HEADERS): Remove rand-isaac.h.
1540 (shred_SOURCES, sort_SOURCES): Remove.
1541 (EXTRA_DIST): Add rand-isaac.c.
1542 * src/rand-isaac.c: Revert to what used to be in shred.c, without
1543 changing it to allow for varying numbers of words in the state.
1544 Alter so that we include rand-isaac.c directly rather than
1545 compiling it and linking to it. Don't include config.h or
1546 system.h; that's the includer's responsibility.
1547 Omit functions that are specific to shred.
1548 (ISAAC_LOG, ISAAC_WORDS, ISAAC_BYTES, struct isaac_state, ind):
1549 (isaac_step, struct irand_state):
1550 Resurrect these, with the same defns that used to be in shred.c.
1551 (ISAAC_SIZE, isaac_new, isaac_copy): Remove.
1552 (isaac_refill, isaac_seed_start, isaac_seed_data, irand_init, irand32):
1554 (struct isaac_state, isaac_refill, isaac_mix, isaac_init):
1555 (isaac_seed_start, isaac_seed_data, isaac_seed_finish, isaac_seed):
1556 (irand_init, irand32, irand_mod):
1557 Number of words is constant again.
1558 (struct irand_state, irand_init, irand32, irand_mod): Move to shred.c.
1559 * src/shred.c: Include rand-isaac.c rather than rand-isaac.h.
1560 * src/sort.c: Likewise.
1561 * src/shred.c (fillrand, dopass, main): Undo previous change.
1562 (struct irand_state, irand_init, irand32, irand_mod): Moved back here,
1564 * src/sort.c: Don't include md5.h; it wasn't needed.
1565 (struct keyfield): Rename random_hash to random, for consistency
1566 with the other member names. All uses changed.
1567 (usage): Tweak wording to mention STRING for --seed option.
1568 (short_options): Rorder for consistency with other programs.
1569 (rand_state): Now a struct, not a pointer to one. All uses changed.
1570 (HASH_WORDS, HASH_SIZE): Remove.
1571 (get_hash): Remove comments around resbuf size, since we can assume C89.
1572 Use a "more-kosher" (but slower) approach of invoking isaac_refill.
1573 (keycompare): Adjust to the new get_hash.
1575 (badfieldspec): Omit recently-introduced comment; it isn't needed.
1576 (main): Don't set need_random simply because gkey has it set; that
1577 doesn't necessarily mean we'll need random numbers.
1578 Redo seeding to match new get_hash approach.
1580 2005-12-10 Jim Meyering <jim@meyering.net>
1582 * src/Makefile.am (noinst_HEADERS): Add rand-isaac.h.
1584 Avoid shred segfault on 64-bit systems.
1585 * src/rand-isaac.c (isaac_refill): Don't try to negate a
1586 local of type uint32_t. Make the local an `int' instead.
1588 * NEWS: Mention sort's new options.
1590 * src/rand-isaac.c (isaac_mix): Declare to be static.
1591 Mark all other functions as `extern' so the tight-scope
1592 part of `make distcheck' passes once again.
1593 * src/rand-isaac.h (isaac_mix): Remove declaration.
1595 * src/sort.c (get_hash): Change position of `*' in parameter
1596 type to conform with convention.
1597 (main): Split a long line so it fits in 80 columns.
1598 (keycompare): Remove stray SPACE before TAB that was
1599 causing `make distcheck' to fail.
1601 * src/shred.c: Don't include gethrxtime.h. No longer needed.
1603 * tests/misc/sort-rand: New file: basic tests for the new options.
1604 * tests/misc/Makefile.am (TESTS): Add sort-rand.
1606 2005-12-10 Frederik Eaton <frederik@ofb.net>
1608 * src/Makefile.am (sort_LDADD): Add $(LIB_GETHRXTIME).
1609 (shred_SOURCES, sort_SOURCES): New macros, so we compile rand-isaac.c.
1610 * src/rand-isaac.c: New file, containing ISAAC code that was in shred.c.
1611 Make state size runtime-configurable.
1612 (isaac_new, isaac_copy): New functions.
1613 * src/rand-isaac.h: New file.
1614 * src/shred.c: Include rand-isaac.h. Move ISAAC code to rand-isaac.c.
1615 (fillrand, main): Adjust to the fact that the state size is now
1616 runtime-configurable.
1617 * src/sort.c (short_options, long_options, WORDS, keycompare, main):
1618 (usage): Add options --random-sort and --seed to implement a random
1620 Include md5.h and rand-isaac.h.
1621 (get_hash): New function.
1622 (rand_state): New var.
1623 (HASH_WORDS, HASH_SIZE): New macros.
1625 2005-12-09 Paul Eggert <eggert@cs.ucla.edu>
1627 * tests/dd/misc: Add test for dd iflags=noatime.
1629 2005-12-09 Jim Meyering <jim@meyering.net>
1631 * src/sort.c (usage): Mention white space vs -b and -t options.
1634 2005-12-09 Eric Blake <ebb9@byu.net>
1636 * src/test.c (main): Fix misleading comment.
1638 2005-12-07 Paul Eggert <eggert@cs.ucla.edu>
1640 * NEWS: Mention dd's new noatime flag.
1641 * src/system.h (O_NOATIME): Define to 0 if not already defined.
1642 * src/dd.c (flags, usage): Add support for noatime flag.
1644 2005-12-07 Jim Meyering <jim@meyering.net>
1646 Distribute the cvsu script, used only by `make syntax-check'.
1647 * Makefile.am (EXTRA_DIST): Add build-aux/cvsu.
1648 * Makefile.maint (CVS_LIST): Use build-aux/cvsu, now that we
1649 distribute a copy of this script.
1650 * .x-sc_unmarked_diagnostics: Add build-aux/cvsu.
1652 * tests/mv/acl: exit-77 before the trap, not after, if we fail
1653 to create a temporary directory on another partition.
1654 From Andreas Gruenbacher.
1656 2005-12-06 Tomas Pospisek <tpo@sourcepole.ch> (tiny change)
1658 * man/basename.x: Cross-reference to dirname and readlink.
1659 * man/dirname.x: Cross-reference to basename and readlink.
1661 2005-12-05 Andreas Gruenbacher
1663 * src/copy.c [!HAVE_FCHOWN]: Define fchown(...) to -1.
1664 (set_owner, preserve_author): New functions, factored out of copy_reg.
1665 (copy_reg): Use them.
1666 (copy_internal): Use them here, too.
1668 2005-12-04 Jim Meyering <jim@meyering.net>
1670 * src/sleep.c (usage): Say what happens with two or more arguments.
1671 Suggested by Justin Pryzby.
1673 * src/uptime.c (print_uptime): Move decl of `upsecs' into scope
1676 2005-12-03 Jim Meyering <jim@meyering.net>
1678 * src/rm.c (long_opts): Change the name of each undocumented, for-
1679 testing-only option to start with `-', so that it cannot render
1680 ambiguous any prefix it happens to share with some other option name.
1681 Problem reported by Eric Blake.
1682 * src/head.c (long_options): Likewise.
1683 * src/tail.c (long_options): Likewise.
1685 * tests/misc/head-elide-tail: Update uses of undocumented, for-
1686 testing-only --presume* options to start with `---'.
1687 * tests/rm/dangling-symlink: Likewise.
1688 * tests/rm/dir-no-w: Likewise.
1689 * tests/rm/isatty: Likewise.
1691 2005-11-30 Jim Meyering <jim@meyering.net>
1693 * Makefile.maint: Add a comment about cvsu.
1695 2005-11-25 Paul Eggert <eggert@cs.ucla.edu>
1697 * NEWS: df updates for "none", "proc", inaccessible file systems.
1698 * src/df.c (show_point): Ignore inaccessible file systems.
1699 (usage): -a includes dummy file systems, not size-0 file systems.
1701 * src/od.c (unsigned_long_long_int): Renamed from ulonglong_t,
1702 to avoid collision with POSIX name space. All uses changed.
1704 2005-11-24 Jim Meyering <jim@meyering.net>
1706 * tests/Makefile.am (EXTRA_DIST): Add acl to the list.
1707 * tests/acl: Add `$0: ' prefix to diagnostics.
1709 * .x-sc_require_config_h: Add lib/buffer-lcm.c to the list.
1711 2005-11-23 Paul Eggert <eggert@cs.ucla.edu>
1713 * src/copy.c: Improve performance a bit by optimizing away
1714 unnecessary system calls and going to a block size of at least
1715 8192 (on normal hosts, anyway). This improved performance 5% on my
1716 Debian stable host (2.4.27 kernel, x86, copying from root
1717 ext3 file system to itself).
1718 Include "buffer-lcm.h".
1719 (copy_reg): Omit last argument. All callers changed.
1720 Use xmalloc to allocate rather than trusting alloca
1721 (which is unwise with large block sizes).
1722 Declare locals more locally, if possible.
1723 Use uintptr_t words instead of int words, for a bit more speed
1724 when looking for null blocks on 64-bit hosts.
1725 Optimize away reads of zero bytes on regular files.
1726 In the typical case, insist on 8 KiB buffers, at least.
1727 Avoid unnecessary extra call to fstat when checking for sparse files.
1728 Avoid now-unnecessary cast to off_t, and "0L".
1729 Avoid unnecessary test of *new_dst when checking for same owner
1732 2005-11-22 Paul Eggert <eggert@cs.ucla.edu>
1734 * src/remove.c (rm): Don't assume C99 for-loop syntax.
1736 2005-11-22 Jim Meyering <jim@meyering.net>
1738 * src/remove.c (AD_push): Remove debugging cruft.
1740 * tests/rm/unread2 (rm): Change expected diagnostic,
1741 `cannot open directory' to `cannot remove', to align with
1743 * tests/rm/rm2: Ensure that rm now continues removing entries
1744 even after certain types of failure.
1746 * src/remove.c: Rewrite. Now, this module is reentrant on systems
1747 that provide openat (Solaris), and on systems like Linux+procfs
1748 where our openat emulation code is reentrant. This also fixes a
1749 few low-probability leaks and eliminates some code that could,
1750 in very unusual circumstances, cause rm() (via a callee) to exit.
1751 * NEWS: Mention this.
1753 * configure.ac: Put copyright dates all on one line so the
1754 emacs function that updates them works properly.
1756 2005-11-18 Paul Eggert <eggert@cs.ucla.edu>
1758 * configure.ac (AM_PROG_CC_C_O): Add. Needed for CVS Automake.
1759 Problem reported by Eric Blake.
1760 (AC_PROG_CC_STDC): Use this instead of AC_PROG_CC, so that
1761 we get a standard-conforming compiler. This relies on the new
1762 m4/c.m4 file. Note that it's a bit tricky, since c.m4 doesn't
1763 define AC_PROG_CC_STDC; we are relying on Autoconf 2.59 internals.
1764 m4/c.m4 can go away with Autoconf 2.60 comes out.
1766 2005-11-17 Jim Meyering <jim@meyering.net>
1768 * src/remove.c (AD_mark_helper): Make a `char *' parameter `const'.
1769 (AD_mark_current_as_unremovable): Likewise, but for a local.
1772 * tests/mv/acl: Let traps handle removing temporary directories.
1774 Expect acl-related tests to fail, until the corresponding
1775 patches are committed.
1776 * tests/mv/Makefile.am (XFAIL_TESTS): Add acl.
1777 * tests/cp/Makefile.am (XFAIL_TESTS): Likewise.
1779 ACL tests, from Andreas Gruenbacher.
1780 * tests/acl, tests/mv/acl, tests/cp/acl: New files.
1781 * tests/mv/Makefile.am (TESTS): Add acl.
1782 * tests/cp/Makefile.am (TESTS): Add acl.
1784 * src/ls.c (basename_is_dot_or_dotdot): Correct wording in comment.
1786 2005-11-16 Paul Eggert <eggert@cs.ucla.edu>
1788 * NEWS: Improve quality of ln's diagnostics.
1789 * src/ln.c (do_link, usage): Likewise.
1790 (do_link): Don't use alloca on a buffer of unbounded size.
1792 2005-11-16 Jim Meyering <jim@meyering.net>
1794 * tests/cp/fail-perm: Accommodate HPUX. It appears to fail
1795 with EACCES rather than EPERM. Reported by Peter O'Gorman here:
1796 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/5766
1797 This also affects AIX 4.3.3, according to Ralf Wildenhues, in
1798 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
1800 2005-11-14 Jim Meyering <jim@meyering.net>
1802 * NEWS (sort): Mention consequences of today's mkstemp-safer.c fix.
1804 2005-11-13 Jim Meyering <jim@meyering.net>
1806 * announce-gen: Accept new option, --gpg-key-id=ID and
1807 emit a blurb telling how to use the .sig files.
1808 * Makefile.cfg (gpg_key_ID): Define.
1809 * Makefile.maint (announcement): Use new option and key.
1811 Require that most .c files include <config.h>.
1812 * Makefile.maint (sc_require_config_h): New rule.
1813 (syntax-check-rules): Add it.
1814 * .x-sc_require_config_h: New file listing exceptions to the
1815 above rule. Some are legit, others are simply grandfathered in.
1816 * Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h here, too.
1818 2005-11-12 Jim Meyering <jim@meyering.net>
1820 * src/checksum.h, src/md5.c, src/sha1sum.c: Remove now-unused files.
1822 2005-11-11 Jim Meyering <jim@meyering.net>
1824 * NEWS: Mention `readlink -f' bug fix in 5.3.0 news.
1825 Mention new readlink options in 5.3.0's `New features' section.
1826 Spotted by Thomas Hood.
1828 2005-11-08 Jim Meyering <jim@meyering.net>
1830 * NEWS: Merge in changes from b5_9x branch.
1832 2005-11-08 Paul Eggert <eggert@cs.ucla.edu>
1834 * NEWS: ls now defaults to --time-style='locale', which in turn acts
1835 like --time-style='posix-long-iso' if the locale settings are messed up.
1836 * src/ls.c (decode_switches): Implement this.
1838 2005-11-08 Jim Meyering <jim@meyering.net>
1840 * tests/du/2g: s/expensive/very expensive/ in a comment.
1843 2005-10-17 Eric Blake <ebb9@byu.net>
1845 * src/ls.c (usage): Fix descriptions of --sort, --time.
1846 Reported by Vitaly A. Ostanin.
1848 2005-11-04 Paul Eggert <eggert@cs.ucla.edu>
1850 * src/ln.c: Include filenamecat.c.
1851 (FILE_BASENAME_CONCAT): Remove.
1852 (do_link): Remove last arg DEST_IS_DIR. All callers changed.
1853 (main): Use file_name_concat, base_name, and strip_trailing_slashes
1854 instead of FILE_BASENAME_CONCAT. This simplifies the code, and avoids
1857 2005-11-04 Jim Meyering <jim@meyering.net>
1859 * src/du.c (process_file): Don't overflow for files of size >= 2^31
1860 on systems with stat.st_blocks of a signed 32-bit type.
1861 This bug causes trouble on some AIX 5.1 systems.
1862 Report and trivial patch from Paul Townsend:
1863 <http://lists.gnu.org/archive/html/bug-coreutils/2005-11/msg00033.html>
1864 * NEWS: Mention this.
1866 * tests/du/2g: New (very-expensive) test for the above-fixed bug.
1867 * tests/du/Makefile.am (TESTS): Add it here.
1868 * tests/very-expensive: New file.
1869 * tests/Makefile.am (EXTRA_DIST): Add it here.
1870 * tests/cp/perm: Mark this test as `very-expensive', too.
1872 2005-11-02 Paul Eggert <eggert@cs.ucla.edu>
1874 * NEWS: Mention that rm -d and maybe ln -d are scheduled for
1876 * src/remove.h (struct rm_options): Remove unlink_dirs. All uses
1878 * src/rm.c (usage): Don't mention rm -d.
1880 2005-11-02 Jim Meyering <jim@meyering.net>
1882 * tests/dd/skip-seek: Fix typo in comment: s/fileutils/coreutils.
1883 From Andreas Schwab.
1885 * tests/dd/unblock-sync: Redirect stderr to /dev/null so the
1886 `M+N records in/out' lines don't pollute `make check' output.
1888 * tests/dd/skip-seek (sk-seek4): New test, to exercise the bug
1889 fixed on 2005-10-31. This test uses the new, IN_PIPE specifier.
1890 * tests/Coreutils.pm: Accept a new type of input specifier: IN_PIPE,
1891 to indicate that the input file should be piped into the command
1892 under test (via `cat FILE | $prog ...').
1894 * src/remove.c (remove_entry): Emit a better diagnostic when rm
1895 (without -r) fails to remove a directory on a non-Linux system.
1896 This change affects only newer Solaris systems (with priv_*
1897 functions like priv_allocset). Reported by Keith Thompson.
1899 * tests/rm/dir-nonrecur: New file/test for the above fix.
1900 * tests/rm/Makefile.am (TESTS): Add dir-nonrecur.
1902 2005-11-01 Paul Eggert <eggert@cs.ucla.edu>
1904 * NEWS: "tail -c 2 FILE" and "touch 0101000000" now operate as
1905 POSIX 1002.1-2001 requires.
1906 * src/tail.c (parse_obsolete_option): Implement this.
1907 Problem reported by Vincent Lefevre.
1908 * src/touch.c (main): Pass PDS_PRE_2000 to posixtime.
1909 * tests/tail/Test.pm (c-2, c-2-minus, c2, c2-minus): New tests.
1910 (test_vector): Add special cases for _POSIX2_VERSION, and
1911 regularize the old ones a bit.
1912 * tests/touch/obsolescent: Add y2000 test.
1914 2005-10-31 Paul Eggert <eggert@cs.ucla.edu>
1916 * src/dd.c (skip): Fix off-by-one error reported by
1917 Theodoros V. Kalamatianos.
1919 2005-10-30 Paul Eggert <eggert@cs.ucla.edu>
1921 * tests/mkdir/p-3: Require that the test be run as non-root.
1922 Problem and trivial fix reported by Theodoros V. Kalamatianos.
1924 2005-10-28 Paul Eggert <eggert@cs.ucla.edu>
1926 * src/ln.c (FILE_BASENAME_CONCAT): Omit unnecessary slashes in the
1927 boundary between DEST and SOURCE in the result.
1929 2005-10-26 Dmitry V. Levin <ldv@altlinux.org>
1931 * src/md5sum.c (main) [!O_BINARY]: Changed default read mode
1932 back to text, to sync with documentation and for backwards
1935 2005-10-25 Jim Meyering <jim@meyering.net>
1937 * tests/dircolors/simple (other-wr): Add an explicit test for
1938 the dircolors bug (NULL-dereference) fixed yesterday.
1940 2005-10-24 Jim Meyering <jim@meyering.net>
1942 * src/tac.c (tac_file): When determining whether a file is seekable,
1943 also test whether it is a tty. Using only the lseek-based test would
1944 give a false positive on Solaris. Reported by Peter Fales.
1946 2005-10-24 Dmitry V. Levin <ldv@altlinux.org>
1948 * tests/install/d-slashdot: New test, for "install -d" failure.
1949 * tests/install/Makefile.am (TESTS): Add d-slashdot.
1950 * tests/mkdir/p-slashdot: New test, for "mkdir -p" failure.
1951 * tests/mkdir/Makefile.am (TESTS): Add p-slashdot.
1953 2005-10-24 Jim Meyering <jim@meyering.net>
1955 * src/dircolors.c (ls_codes): Add missing comma.
1956 Anonymous report and patch from
1957 http://savannah.gnu.org/bugs/?func=detailitem&item_id=14849
1959 * src/dircolors.c: Add compile-time assertion that the slack_codes
1960 and ls_codes arrays have the same number of elements. This would
1961 have prevented the above-fixed bug.
1963 * src/expand.c (parse_tab_stops): Add a comment to make this function
1964 identical to the one in unexpand.c.
1965 * src/unexpand.c (parse_tab_stops): Adjust syntax to make this function
1966 identical to the one in expand.c.
1968 * src/expand.c (next_file): Don't assume fopen cannot return stdin.
1970 2005-10-23 Jim Meyering <jim@meyering.net>
1972 * src/md5sum.c (digest_check, main): Use ptr_align rather than
1973 a dangerous pointer-value-to-`unsigned' cast.
1974 * NEWS: mention the new sha* programs.
1975 * AUTHORS: Add new sha* programs.
1977 2005-08-28 David Madore <david.madore@ens.fr>
1979 Add new programs: sha224sum, sha256sum, sha384sum, sha512sum.
1980 * README: Add their names to the list.
1981 * src/md5sum.c: Provide framework for computing sha-2 hashes.
1982 * src/Makefile.am (sha224sum, sha256sum, sha384sum, sha512sum):
1983 Rules for compiling sha-2 utilities
1984 (noinst_HEADERS): Remove checksum.h.
1985 * man/sha512sum.x, man/sha384sum.x, man/sha256sum.x, man/sha224sum.x:
1987 * man/Makefile.am (dist_man_MANS): Add the corresponding .1 names.
1988 (sha224sum.1, sha256sum.1, sha384sum.1, sha512sum.1): New dependencies.
1989 * tests/misc/sha224sum, tests/misc/sha256sum: New files.
1990 * tests/misc/sha384sum, tests/misc/sha512sum: New files.
1991 * tests/misc/Makefile.am (TESTS): Add new sha224sum, sha256sum,
1992 sha384sum, sha512sum test scripts here rather that each in its
1995 2005-08-28 David Madore <david.madore@ens.fr>
1997 * tests/sha1sum/basic-1 (million-a): Add the "million a's" test (one
1998 of the FIPS test vectors).
2000 2005-10-23 Jim Meyering <jim@meyering.net>
2002 * configure.ac: Use 6.0-cvs as the version string.
2003 * NEWS: Adjust accordingly.