1 2003-04-10 Havoc Pennington <hp@pobox.com>
3 * bus/dispatch.c: lots of fixes
5 * dbus/dbus-mainloop.c (_dbus_loop_dispatch): export
6 (_dbus_loop_iterate): remove old "quit if no callbacks" code,
7 that was crack, broke the test service.
9 * dbus/dbus-transport.c (_dbus_transport_open): fix error
10 handling to avoid piling up errors if we get a failure on the
13 * dbus/dbus-internals.c (_dbus_real_assert_not_reached): include
14 pid in assertion failures.
16 * dbus/dbus-mainloop.c (_dbus_loop_iterate): use static arrays up
17 to some fixed size of file descriptor array. Don't return TRUE
18 anytime a timeout exists, that led to lots of busy loop silliness
21 2003-04-09 Havoc Pennington <hp@redhat.com>
23 * dbus/dbus-mainloop.c (check_timeout): fix timeouts, I thought
24 I'd checked this in earlier but hadn't.
26 2003-04-09 Havoc Pennington <hp@redhat.com>
28 * bus/dispatch.c (bus_dispatch_test): get a bit further through
29 the activation test (man this is getting old!)
31 2003-04-09 Havoc Pennington <hp@redhat.com>
33 * test/test-utils.c: use dispatch status function to fix this up
35 * bus/connection.c (connection_watch_callback): don't dispatch
37 (connection_timeout_callback): don't dispatch from here
38 (bus_connections_setup_connection): set the dispatch status function
39 (bus_connection_disconnected): unset it
41 * dbus/dbus-mainloop.c (_dbus_loop_queue_dispatch): new function
42 used to add a connection to be dispatched
43 (_dbus_loop_iterate): do the dispatching at the end of each
46 * dbus/dbus-connection.c
47 (dbus_connection_set_dispatch_status_function): new function
48 allowing us to fix up main loop usage
49 (_dbus_connection_last_unref): free all the various function
51 (dbus_connection_dispatch): call the DispatchStatusFunction
52 whenever this function returns
53 (dbus_connection_handle_watch): call DispatchStatusFunction
54 (dbus_connection_send_with_reply_and_block): call DispatchStatusFunction
55 (reply_handler_timeout): call DispatchStatusFunction
56 (dbus_connection_flush): call DispatchStatusFunction
58 2003-04-09 Havoc Pennington <hp@redhat.com>
60 * dbus/dbus-bus.c (dbus_bus_register): fix up error handling and
63 * bus/dispatch.c (check_service_activated): fix bug in test
65 * dbus/dbus-mainloop.c (check_timeout): fix this up
67 * dbus/dbus-internals.c (_dbus_verbose_real): include PID in
68 verbose output so we can sort out output from different processes,
69 e.g. in the activation case.
71 2003-04-08 Colin Walters <walters@gnu.org>
73 * bus/bus.c (struct BusContext) [pidfile]: New member, to store
75 (bus_context_new): Set it.
76 (bus_context_unref): Use it to delete the pid file.
78 2003-04-08 Havoc Pennington <hp@redhat.com>
80 * test/data/invalid-messages/array-with-mixed-types.message:
81 regression test that fails for the moment
83 * dbus/dbus-test.c (dbus_internal_do_not_use_run_tests): reorder
86 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): don't allow
87 array of nil, it broke things.
89 * test/data/invalid-messages/array-of-nil.message: regression test
91 * test/data/valid-messages/array-of-array-of-uint32.message:
92 happened to write this so added it to suite
94 2003-04-08 Havoc Pennington <hp@redhat.com>
96 * bus/driver.c (bus_driver_handle_acquire_service): init
97 retval/reply before checking name
99 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): add a
100 recursion depth argument
102 * dbus/dbus-message.h (struct DBusMessageIter): put some padding
103 in the public struct for future extension
105 * dbus/dbus-message-builder.c (_dbus_message_data_load): fix
108 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): fix a verbose
111 * doc/dbus-specification.sgml: fix typo
113 2003-04-08 Alexander Larsson <alexl@redhat.com>
115 Implemented recursive types, named types and new-style iters
118 * glib/test-thread-client.c: (thread_func):
119 * glib/test-thread-server.c: (handle_test_message):
120 * test/test-service.c: (handle_echo):
129 * dbus/dbus-internals.c: (_dbus_type_to_string):
130 Update for new types.
132 * dbus/dbus-marshal.[ch]:
133 Implement recursive types and the new marshalling format.
134 Remove hardcoded dict marshalling.
137 * dbus/dbus-message-builder.c:
139 Remove references to old types
141 * dbus/dbus-message.[ch]:
142 New non-refcounted iter API that supports recursive iters.
143 Use iters for appending, including support for recursive
145 Add byte and named type support.
146 Update everything to new marshalling formats.
147 Add tests for new API.
149 * dbus/dbus-protocol.h:
150 Remove old array types.
151 Add types: BYTE, ARRAY, DICT, NAMED
153 * dbus/dbus-string.c:
154 * dbus/dbus-sysdeps.c:
155 Make parse_double locale safe.
157 * dbus/dbus-test-main.c:
163 * doc/dbus-specification.sgml:
166 * test/data/incomplete-messages/missing-body.message:
167 * test/data/invalid-messages/bad-boolean.message:
168 * test/data/invalid-messages/bad-boolean-array.message:
169 * test/data/invalid-messages/boolean-array-length-too-long.message-raw:
170 * test/data/invalid-messages/boolean-has-no-value.message-raw:
171 * test/data/invalid-messages/too-short-dict.message:
172 * test/data/valid-messages/dict-simple.message:
173 * test/data/valid-messages/dict.message:
174 * test/data/valid-messages/emptiness.message:
175 * test/data/valid-messages/lots-of-arguments.message:
176 * test/data/valid-messages/no-padding.message:
177 * test/data/valid-messages/recursive-types.message:
178 Add missing NAME fields
179 Fix up dicts & arrays
181 * test/data/invalid-messages/dict-with-nil-value.message:
182 Removed, this is not invalid anymore.
184 * test/data/valid-messages/recursive-types.message:
185 Add new test for deeply recursive types.
187 2003-04-07 Havoc Pennington <hp@pobox.com>
189 * bus/driver.c (bus_driver_handle_acquire_service): return an
190 error if you try to acquire a service that starts with ':'
192 2003-04-07 Havoc Pennington <hp@redhat.com>
194 * doc/dbus-specification.sgml: require that base service names
195 start with ':' and that the base service is created/deleted
196 as first and last things a connection does on the bus
198 * bus/dispatch.c (check_existent_service_activation): lots more
199 work on the activation test; it doesn't fully pass yet...
201 * test/test-service.c (main): fix so we don't memleak the
202 connection to the message bus
203 (filter_func): accept a message asking us to exit
205 2003-04-06 Havoc Pennington <hp@pobox.com>
207 * qt/Makefile.am (dbusinclude_HEADERS): install dbus-qt.h,
210 * configure.in: fixes to Qt detection from Colin Walters
212 * doc/Makefile.am: Only remove generated docbook dirs if they
213 exist, from Colin Walters
215 * dbus/dbus-bus.c: change how we set well-known connections to
216 NULL, so that it works if a single connection is stored in
217 two well-known array slots.
219 * test/Makefile.am: remove a lot of stuff that isn't immediately
220 useful, it's in CVS history if we want it.
222 * test/test-service.c: use dbus-mainloop instead of that
225 2003-04-06 Havoc Pennington <hp@pobox.com>
227 * dbus/Makefile.am: split lists of sources into stuff that goes in
228 the library, util functions that go in the lib and are also used
229 elsewhere, and util functions that are used in tests/daemon but
232 * dbus/dbus-mainloop.h, dbus/dbus-mainloop.c: move bus/loop.[hc]
233 here so it can be used in test binaries also
235 2003-04-06 Havoc Pennington <hp@pobox.com>
237 * dbus/dbus-sysdeps.c (_dbus_become_daemon): write the pidfile
238 here in the parent process, so we can return an error if it
239 fails. Also, move some of the code into the child so the parent
240 is less hosed if we fail midway through.
242 * bus/bus.c (bus_context_new): move pidfile detection further up
243 in the function, before we start overwriting sockets and such.
245 * bus/messagebus.in: adjust this a bit, not sure if it will work.
247 * configure.in: add --with-system-pid-file and --with-system-socket
249 2003-04-06 Colin Walters <walters@verbum.org>
251 * configure.in (DBUS_SYSTEM_PID_FILE): New variable.
253 * bus/system.conf.in: Declare a pidfile.
255 * bus/bus.c (bus_context_new): Test for an existing pid file, and
256 create one (if appropriate).
258 * bus/config-parser.c (enum ElementType) [ELEMENT_PIDFILE]: New.
259 (struct BusConfigParser) [pidfile]: New.
260 (element_type_to_name, merge_included, start_busconfig_child)
261 (bus_config_parser_end_element, bus_config_parser_content): Handle it.
262 (bus_config_parser_unref): Free it.
263 (bus_config_parser_get_pidfile): New function.
265 * bus/config-parser.h (_dbus_write_pid_file): Prototype.
267 * dbus/dbus-errors.h (DBUS_ERROR_PIDFILE_EXISTS): New error.
269 * dbus/dbus-sysdeps.c (_dbus_write_pid_file): New function.
271 * dbus/dbus-sysdeps.h: Prototype it.
273 2003-04-06 Havoc Pennington <hp@pobox.com>
275 * bus/bus.c (bus_context_new): print the address in here, rather
276 than in main(), because we need to do it before forking the daemon
278 * bus/dispatch.c (send_service_nonexistent_error): set the sender
279 on the service nonexistent error
281 * bus/driver.c (bus_driver_handle_acquire_service): set the
282 sender on the AcquireService reply
284 * test/data/valid-config-files/debug-allow-all.conf.in: Make test
285 server also listen on a UNIX socket so services can connect to it.
287 2003-04-06 Havoc Pennington <hp@pobox.com>
289 * dbus/dbus-threads.c: Redo how the fake debug mutexes are done
290 so it detects deadlocks and also we actually init threads when
293 2003-04-06 Havoc Pennington <hp@pobox.com>
295 * dbus/dbus-server-unix.c (_dbus_server_new_for_domain_socket):
296 save the domain socket name, and unlink it when we disconnect the
297 server. Means that at least when we exit normally, we won't leave
298 a bunch of junk in /tmp
300 * dbus/dbus-transport-unix.c
301 (_dbus_transport_new_for_domain_socket): code cleanup (nicer
302 memory management). (I was making a real change here but then
305 2003-04-06 Havoc Pennington <hp@pobox.com>
307 * bus/bus.c (bus_context_new): fix wrong handling of
308 server_data_slot_unref() in the error case.
310 * dbus/dbus-internals.h (_dbus_assert): change so it passes
311 "(condition) != 0" to _dbus_real_assert so that
312 "_dbus_assert (pointer)" doesn't cause a warning
314 * bus/main.c (main): accept --print-address option to print out
315 the message bus address
317 * dbus/dbus-sysdeps.c (_dbus_generate_random_ascii): export this
319 * dbus/dbus-transport.c (_dbus_transport_open): special error for
320 "tmpdir" option to unix: address on client side
322 * dbus/dbus-server.c (dbus_server_listen): handle "tmpdir" option
325 * configure.in (TEST_SOCKET_DIR): locate a temporary directory
326 we can use to create sockets in the test suite.
328 * bus/main.c (signal_handler): on SIGTERM, exit the daemon
329 cleanly. To be used for testing.
331 * dbus/dbus-spawn.c (babysit): use _dbus_set_signal_handler()
333 * dbus/dbus-sysdeps.c (_dbus_set_signal_handler): new
335 * dbus/dbus-server-debug-pipe.c (_dbus_transport_debug_pipe_new):
336 handle trying to call this when there's no servers active
338 2003-04-05 Havoc Pennington <hp@pobox.com>
344 2003-04-05 Havoc Pennington <hp@pobox.com>
346 * bus/bus.c (setup_server): fix this so dbus-daemon-1 doesn't
347 crash on startup. Need to get "try starting the daemon"
348 in the test suite I guess. ;-)
350 * dbus/dbus-server.h, dbus/dbus-server.c: remove the stuff that
351 tracked the number of open connections; it's better done in
352 application-specific code as you want it to span all servers etc.
354 2003-04-05 Havoc Pennington <hp@pobox.com>
356 * bus/Makefile.am (install-data-hook): add missing DESTDIR,
357 patch from Colin Walters
359 2003-04-05 Havoc Pennington <hp@pobox.com>
361 * doc/config-file.txt (Elements): fix docs of <auth> to reflect
362 reality; in fact multiple mechanisms are allowed.
364 * dbus/dbus-internals.c (_dbus_real_assert)
365 (_dbus_real_assert_not_reached): move guts of _dbus_assert() and
366 _dbus_assert_not_reached() into functions, so that they don't show
367 up in basic block counts for test coverage, and don't use up as
368 much disk space. Does mean slower execution speed though, so
369 assumes --disable-asserts is the normal production case.
371 2003-04-05 Havoc Pennington <hp@pobox.com>
373 * test/Makefile.am (dist-hook): also dist *.in files
379 2003-04-05 Havoc Pennington <hp@pobox.com>
381 * dbus/dbus-string.c: docs warning
383 * dbus/dbus-spawn.c: missing docs
385 * dbus/dbus-memory.c (struct ShutdownClosure): missing docs
387 2003-04-05 Havoc Pennington <hp@pobox.com>
389 * bus/loop.c (bus_loop_iterate): fix the timeout code, using
392 * dbus/dbus-spawn.c (_dbus_babysitter_unref): set sitter_pid
393 to -1 once we've reaped the babysitter
394 (_dbus_babysitter_handle_watch): do as much work as we can, not
397 * bus/activation.c: add code using DBusBabysitter so that we
398 handle it when a service fails to start up properly.
399 (bus_activation_service_created): don't remove the activation
400 entries as we go, just let them get removed when we free the pending
401 activation. Unref reply messages after sending them.
403 2003-04-05 Havoc Pennington <hp@pobox.com>
405 * test/decode-gcov.c (main): print per-directory stats in the report
407 * Makefile.am (coverage-report.txt): don't include test/* in gcov stats
409 2003-04-05 Havoc Pennington <hp@pobox.com>
411 * Makefile.am (coverage-report.txt): add target "coverage-report.txt"
413 * test/decode-gcov.c: hack up a little program to suck data
414 out of gcov files. Yes this is sort of silly.
416 * configure.in: define something in config.h and do an
417 AM_CONDITIONAL when gcov is enabled
419 2003-04-04 Havoc Pennington <hp@redhat.com>
421 * dbus/dbus-spawn.c, dbus/dbus-spawn.h: Change dbus_spawn to
422 return a "babysitter" object that is used to monitor the status of
423 the spawned process and reap it when required.
425 * test/test-segfault.c, test/test-exit.c,
426 test/test-sleep-forever.c: binaries that do various lame things,
427 used in the test suite.
429 * dbus/dbus-sysdeps.c: kill _dbus_errno_to_string()
431 2003-04-03 Havoc Pennington <hp@pobox.com>
433 * dbus/dbus-spawn.c: Move dbus-spawn into a separate file
434 in preparation for modifying it, dbus-sysdeps is getting
437 2003-04-03 Havoc Pennington <hp@redhat.com>
439 * bus/loop.h, bus/loop.c: make the mainloop an object so we can
442 * bus/*.[hc]: adapt to mainloop change
444 2003-04-03 Havoc Pennington <hp@redhat.com>
446 * bus/activation.c (load_directory): fix up memleaks
447 (bus_activation_entry_free): free the entry
449 * dbus/dbus-bus.c (dbus_bus_acquire_service): return an error if
450 we get one from the message bus; fix memleaks.
452 * dbus/dbus-message.c (dbus_set_error_from_message): new function
454 2003-04-03 Havoc Pennington <hp@pobox.com>
456 * bus/config-parser.c (bus_config_parser_unref): free
457 list of mechanisms, bug discovered by test suite enhancements
458 (putting system.conf and session.conf into suite)
460 * test/Makefile.am, test/test-service.c: add placeholder for a
461 test service that we'll activate as part of test suite. Doesn't
464 * dbus/dbus-sysdeps.c (_dbus_setenv): support unsetenv by
465 setting NULL value, and use system malloc not dbus_malloc()
466 when we have unavoidable memleakage.
468 * dbus/dbus-bus.c (dbus_bus_get): fix bug where bus type of 0
469 didn't work, and support DBUS_BUS_ACTIVATION.
471 * bus/activation.c (child_setup): pass our well-known bus type to
474 * bus/config-parser.c: support <type> to specify well-known type
476 * doc/dbus-specification.sgml: document the env variables to
477 locate well-known buses and find service activator
479 2003-04-02 Havoc Pennington <hp@redhat.com>
481 * test/Makefile.am (all-local): add a rule to copy tests to
482 builddir, so we can have generated tests. Use this to remove the
483 silly hack for testing system.conf and session.conf. Will use this
484 shortly to generate .service files pointing to test binaries.
486 2003-04-02 Havoc Pennington <hp@redhat.com>
488 * dbus/dbus-string.c (set_length): fix a bug - we allocated max of
489 current alloc and needed new length, not max of the doubled
490 allocation and needed new length. Also, when building tests,
491 don't do the double-allocation stuff, just realloc every time.
493 2003-04-02 Havoc Pennington <hp@redhat.com>
495 * dbus/dbus-sysdeps.c (_dbus_file_get_contents): include filenames
497 (_dbus_string_get_dirname): new
498 (_dbus_sysdeps_test): new
499 (_dbus_directory_open): include dirnames in error messages
501 * bus/config-parser.c: interpret <include> and <includedir> and
502 <servicedir> relative to config file location if the given
503 filename is not absolute.
505 * dbus/dbus-string.c (_dbus_string_find_byte_backward): new
507 2003-04-02 Havoc Pennington <hp@redhat.com>
509 * bus/connection.c (bus_transaction_send_error_reply): set sender
510 service for the error, and unref the reply on success
512 * bus/activation.c: convert to use BusTransaction so OOM can be
514 (bus_activation_service_created): set sender of the message
516 2003-04-01 Havoc Pennington <hp@redhat.com>
518 * bus/config-parser.c, bus/bus.c: implement <servicedir> and
519 <includedir> (at least mostly)
521 * dbus/dbus-sysdeps.c (_dbus_change_identity): set the group ID
522 first, then the user ID
524 2003-04-01 Havoc Pennington <hp@pobox.com>
526 * dbus/dbus-server.c (dbus_server_set_auth_mechanisms): new
529 * dbus/dbus-auth.c (_dbus_auth_set_mechanisms): new
531 * dbus/dbus-internals.c (_dbus_dup_string_array): new function
533 * dbus/dbus-sysdeps.c (_dbus_listen_unix_socket): chmod the
534 socket 0777, and unlink any existing socket.
536 * bus/bus.c (bus_context_new): change our UID/GID and fork if
537 the configuration file so specifies; set up auth mechanism
540 * bus/config-parser.c (bus_config_parser_content): add support
541 for <fork> option and fill in code for <auth>
543 * bus/system.conf.in: add <fork/> to default configuration,
544 and limit auth mechanisms to EXTERNAL
546 * doc/config-file.txt (Elements): add <fork>
548 * dbus/dbus-sysdeps.c (_dbus_become_daemon): new function
549 (_dbus_change_identity): new function
551 2003-03-31 Havoc Pennington <hp@redhat.com>
553 * dbus/dbus-sysdeps.c (_dbus_connect_unix_socket)
554 (_dbus_listen_unix_socket): fix off-by-one error in null
555 termination spotted by Nalin
557 2003-03-31 Havoc Pennington <hp@redhat.com>
559 * dbus/dbus-keyring.c (_dbus_keyring_new_homedir): allow setting
560 DBUS_TEST_HOMEDIR when tests are enabled, so we can test without
561 having a real home directory available.
563 2003-03-31 Havoc Pennington <hp@redhat.com>
565 * bus/Makefile.am (install-data-hook): create /var/run/dbus
567 * bus/messagebus.in: add init script for Red Hat /etc/init.d
569 * configure.in: add support for specifying a style of init script
572 2003-03-31 Havoc Pennington <hp@redhat.com>
574 Fix some annoying DBusString API and fix all affected code.
576 * dbus/dbus-string.c (_dbus_string_init): get rid of annoying
578 (_dbus_string_get_data): change to return string instead of using
580 (_dbus_string_get_const_data): ditto
581 (_dbus_string_get_data_len): ditto
582 (_dbus_string_get_const_data_len): ditto
584 2003-03-31 Havoc Pennington <hp@redhat.com>
586 * bus/main.c (main): fix up the command line arguments to be nicer
588 2003-03-31 Havoc Pennington <hp@redhat.com>
590 * dbus/Makefile.am (INCLUDES): use EXPANDED_LOCALSTATEDIR to
591 define DBUS_SYSTEM_BUS_PATH as we want to compile in the same
592 final location that lands in the config file
594 * bus/config-loader-expat.c (bus_config_load): fix type of
597 * doc/TODO: remove TODO item for dbus_bus_get()
599 * dbus/dbus-bus.c (bus_data_free): add missing lock/unlock
601 2003-03-31 Havoc Pennington <hp@pobox.com>
603 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_domain_socket)
604 (_dbus_transport_new_for_tcp_socket): these didn't need the "server"
605 argument since they are always client side
607 * dbus/dbus-server.c (dbus_server_get_address): new function
609 * bus/main.c (main): take the configuration file as an argument.
611 * test/data/valid-config-files/debug-allow-all.conf: new file to
612 use with dispatch.c tests for example
614 * bus/test-main.c (main): require test data dir
616 * bus/bus.c (bus_context_new): change this to take a
617 configuration file name as argument
619 * doc/config-file.txt (Elements): add <servicedir>
621 * bus/system.conf, bus/session.conf: new files
623 * dbus/dbus-bus.c (dbus_bus_get): look for system bus on
624 well-known socket if none set
626 * configure.in: create system.conf and session.conf
628 2003-03-30 Havoc Pennington <hp@pobox.com>
630 * bus/config-parser.c: hacking
632 * dbus/dbus-memory.c: don't use DBusList for the list of stuff
633 to shut down, since it could cause weirdness with the DBusList
636 * dbus/dbus-list.c (_dbus_list_test): add tests for the
637 link-oriented stack routines
638 (alloc_link): free the mempool if the first alloc from it fails
640 * dbus/dbus-mempool.c (struct DBusMemBlock): fix alignment issue
642 * dbus/dbus-string.c (UNICODE_VALID): sync new version of this
644 (_dbus_string_skip_white): new
646 * doc/config-file.txt (Elements): add <includedir>
648 2003-03-28 Havoc Pennington <hp@pobox.com>
650 * dbus/dbus-string.c (_dbus_string_copy_data_len)
651 (_dbus_string_copy_data): new functions
653 2003-03-28 Anders Carlsson <andersca@codefactory.se>
655 * dbus/dbus-bus.c: (bus_data_free), (dbus_bus_get):
659 * dbus/dbus-memory.c:
662 2003-03-28 Havoc Pennington <hp@pobox.com>
664 * bus/test.c (bus_test_flush_bus): remove the sleep from here,
665 I think it may have just been superstition. Not sure.
667 * dbus/dbus-string.c (_dbus_string_base64_decode): catch some OOM
668 failures that were not being handled.
670 * dbus/dbus-auth.c (process_auth): fix a memleak in OOM handling
672 * dbus/dbus-memory.c: add ability to set number of mallocs in a
673 row that will fail on out-of-memory.
675 * dbus/dbus-internals.c (_dbus_test_oom_handling): convenience
676 function for testing out-of-memory handling.
678 * bus/config-loader-expat.c (memsuite): don't wrap the dbus
679 allocation functions, they do map exactly to the expat ones.
681 2003-03-27 Havoc Pennington <hp@redhat.com>
683 * bus/config-loader-libxml.c (bus_config_load): add another error
686 2003-03-26 Anders Carlsson <andersca@codefactory.se>
689 Add note about automatic service activation.
691 * doc/dbus-specification.sgml:
692 Rename the specification and clarify a few things.
694 2003-03-26 Anders Carlsson <andersca@codefactory.se>
697 * dbus/dbus-address.c:
699 * dbus/dbus-marshal.c:
700 * dbus/dbus-server-debug-pipe.c:
701 * dbus/dbus-transport-unix.c:
702 Fix documentation warnings.
704 2003-03-26 Havoc Pennington <hp@pobox.com>
706 * bus/test-main.c, dbus/dbus-test.c (main): check memleaks
707 after every test so it's quick and easy to see which leaked, and
708 so we test multiple dbus_shutdown() calls
710 * configure.in: change configure.in XML stuff to also support
713 * config-loader-libxml.c: some hacking
715 * config-loader-expat.c: some hacking
717 * config-parser.c: some hacking, plus tests
719 2003-03-25 Havoc Pennington <hp@redhat.com>
721 * throughout - add more _DBUS_ASSERT_ERROR_IS_CLEAR
723 * configure.in: add --with-xml option to specify XML library,
724 right now only libxml is supported.
726 * bus/config-loader-libxml.c, config-parser.c: sync some minor
727 nonworking code between home and work, still just stubs
729 2003-03-24 Havoc Pennington <hp@redhat.com>
731 * dbus/dbus-sysdeps.c (_dbus_set_fd_nonblocking): move to this
734 * dbus/dbus-errors.c (dbus_set_error, dbus_set_error_const): allow
735 NULL argument for "message" if the error is a well-known one,
736 fill in a generic message in this case.
738 * dbus/dbus-errors.h (DBusResultCode): Kill DBusResultCode in
741 * bus/test.c (bus_test_flush_bus): add
743 * bus/policy.c (bus_policy_test): test code stub
745 2003-03-24 Havoc Pennington <hp@pobox.com>
747 * bus/connection.c (bus_connections_setup_connection): set up
748 the "can this user connect" function, but it always returns
749 TRUE until we have a config file parser so we can have a config
750 file that allows connections.
752 2003-03-23 Havoc Pennington <hp@pobox.com>
754 * dbus/dbus-threads.c (dbus_mutex_new, dbus_condvar_new): with
755 DBUS_BUILD_TESTS, actually alloc/free a block of memory for
756 the mutex, so we can check for proper memory management
759 * dbus/dbus-dataslot.c: remove the mutex from
760 DBusDataSlotAllocator and lock it manually when using it,
761 to simplify fitting it into the global slots framework.
763 * dbus/dbus-threads.c (init_static_locks): rework how we're
764 handling global locks so they are easily shut down.
766 * bus/policy.c (bus_policy_append_rule): fix
768 * bus/test-main.c (main): check for memleaks
770 * dbus/dbus-test.c (dbus_internal_do_not_use_run_tests): make
771 test suite check for memleaks
773 * dbus/dbus-memory.c: add support in test mode for tracking
774 number of outstanding blocks
776 2003-03-23 Havoc Pennington <hp@pobox.com>
778 * bus/policy.c, bus/bus.c, bus/connection.c: implement allow/deny
781 * dbus/dbus-hash.h: add ULONG hash keys
783 * dbus/dbus-sysdeps.c (_dbus_get_groups): new
784 (_dbus_get_group_id): new function
786 2003-03-20 Havoc Pennington <hp@redhat.com>
788 * dbus/dbus-connection.c (dbus_connection_set_unix_user_function):
790 (dbus_connection_get_unix_user): new function
792 2003-03-20 Havoc Pennington <hp@pobox.com>
794 * bus/connection.c (bus_connection_send_oom_error): assert that
796 (connection_execute_transaction): ditto
797 (bus_connection_preallocate_oom_error): fix to set the sender, and
798 set recipient to the destination service, not the bus driver
800 * bus/policy.c: hacking
802 * dbus/dbus-message.c (dbus_message_service_is): new function
803 (dbus_message_sender_is): new
805 2003-03-19 Havoc Pennington <hp@redhat.com>
807 * bus/policy.c: start sketching code for policy restrictions on
808 what connections can do.
810 2003-03-18 Havoc Pennington <hp@redhat.com>
812 * doc/TODO: some notes on high-level todo items. Little nitpick
813 stuff is all in @todo, so no need to add it here.
815 * doc/config-file.txt: some notes on how config file might look
817 2003-03-18 Anders Carlsson <andersca@codefactory.se>
823 2003-03-17 Havoc Pennington <hp@redhat.com>
825 * dbus/dbus-internals.h: add gcc attributes so that
826 our printf-style functions warn on bad arguments to
829 * dbus/dbus-sysdeps.c (_dbus_connect_tcp_socket): fix printf
832 * dbus/dbus-message.c (_dbus_message_loader_queue_messages): fix
835 2003-03-17 Havoc Pennington <hp@redhat.com>
837 * bus/test-main.c (main): make it print something as it runs
838 so make check doesn't look stuck
840 * doc/negotiation.txt, doc/dbus-sasl-profile.txt: remove
841 from CVS, now obsolete
843 2003-03-17 Anders Carlsson <andersca@codefactory.se>
845 * bus/dispatch.c: (bus_dispatch):
846 Refetch the service name since it may have been reallocated
847 when dbus_message_set_sender was called.
849 * dbus/dbus-sysdeps.c: (_dbus_accept):
850 Add address and address length variables and use them to stop
851 valgrind from complaining.
853 2003-03-17 Havoc Pennington <hp@pobox.com>
855 All tests pass, no memleaks, no valgrind complaints.
857 * bus/test.c: refcount handler_slot
859 * bus/connection.c (bus_connections_new): refcount
862 * dbus/dbus-auth-script.c (_dbus_auth_script_run): delete unused
863 bytes so that auth scripts pass.
865 * bus/dispatch.c: init message_handler_slot so it gets allocated
868 * bus/dispatch.c (message_handler_slot_ref): fix memleak
870 * dbus/dbus-server-debug-pipe.c (_dbus_server_debug_pipe_new):
871 dealloc server_pipe_hash when no longer used for benefit of
874 * dbus/dbus-auth.c (process_command): memleak fix
876 * bus/dispatch.c (check_hello_message): memleak fix
878 2003-03-16 Havoc Pennington <hp@pobox.com>
880 * dbus/dbus-bus.c (ensure_bus_data): fix double-unref of the data slot
882 2003-03-17 Anders Carlsson <andersca@codefactory.se>
884 * bus/activation.c (bus_activation_activate_service): Append
885 the pending activation entry to the list of pending activations.
887 2003-03-16 Havoc Pennington <hp@pobox.com>
889 * bus/dispatch.c (bus_dispatch_test): remove double-unrefs of
892 * dbus/dbus-address.c (create_entry): fix OOM handling when
893 failing to alloc entry->method
895 2003-03-16 Havoc Pennington <hp@pobox.com>
897 * dbus/dbus-watch.c (_dbus_watch_new): handle failure to malloc
900 * dbus/dbus-server-debug-pipe.c (_dbus_transport_debug_pipe_new):
901 add some missing dbus_set_result
903 * bus/dispatch.c (bus_dispatch_add_connection): handle failure to
904 alloc the DBusMessageHandler
906 * dbus/dbus-transport.c (_dbus_transport_disconnect): don't ref
907 the transport here, since we call this from the finalizer; it
908 resulted in a double-finalize.
910 * dbus/dbus-transport.c (_dbus_transport_disconnect): fix a bug
911 where we tried to use transport->connection that was NULL,
912 happened when transport was disconnected early on due to OOM
914 * bus/*.c: adapt to handle OOM for watches/timeouts
916 * dbus/dbus-transport-unix.c: port to handle OOM during
919 * dbus/dbus-auth.c (_dbus_auth_get_unused_bytes): return a
920 reference to unused bytes instead of a copy
922 * dbus/dbus-server.c (dbus_server_handle_watch): return FALSE for
925 * dbus/dbus-connection.c (dbus_connection_handle_watch): return
928 * dbus/dbus-timeout.c (dbus_timeout_handle): return FALSE for out
931 2003-03-16 Anders Carlsson <andersca@codefactory.se>
933 * doc/dbus-specification.sgml:
934 Document reply message for ActivateService.
936 2003-03-16 Anders Carlsson <andersca@codefactory.se>
938 * bus/activation.c: (bus_pending_activation_entry_free),
939 (bus_pending_activation_free), (bus_activation_new),
940 (bus_activation_unref), (bus_activation_service_created),
941 (bus_activation_activate_service):
943 * bus/bus.c: (bus_context_new):
944 * bus/desktop-file.c: (new_section):
945 * bus/driver.c: (bus_driver_send_service_deleted),
946 (bus_driver_handle_activate_service):
947 * bus/services.c: (bus_registry_new), (bus_registry_ensure):
949 * dbus/dbus-connection.c:
950 (dbus_connection_send_with_reply_and_block):
951 * dbus/dbus-message.c: (dbus_message_append_args_valist):
952 * dbus/dbus-protocol.h:
953 Make activation work better. Now pending activations will be queued
954 and the daemon won't try to activate services that are already registered.
956 2003-03-16 Havoc Pennington <hp@pobox.com>
958 * dbus/dbus-bus.c (ensure_bus_data): handle failure to set
961 * dbus/dbus-memory.c (_dbus_initialize_malloc_debug): support
962 DBUS_MALLOC_BACKTRACES to print trace when failing an alloc
964 2003-03-16 Havoc Pennington <hp@pobox.com>
966 * dbus/dbus-string.c (_dbus_string_validate_utf8): oops, unbreak
967 this. always run the test suite before commit...
969 * bus/*: adapt to DBusConnection API changes
971 * glib/dbus-gmain.c: adapt to DBusConnection API changes,
972 requires renaming stuff to avoid dbus_connection_dispatch name
975 * dbus/dbus-transport.c (_dbus_transport_queue_messages): new
978 * dbus/dbus-message.c (_dbus_message_loader_queue_messages):
979 separate from _dbus_message_loader_return_buffer()
981 * dbus/dbus-connection.c (dbus_connection_get_n_messages): remove
982 this, because it's now always broken to use; the number of
983 messages in queue vs. the number still buffered by the message
984 loader is undefined/meaningless. Should use
985 dbus_connection_get_dispatch_state().
986 (dbus_connection_dispatch): rename from
987 dbus_connection_dispatch_message
989 2003-03-16 Havoc Pennington <hp@pobox.com>
991 * dbus/dbus-string.c (_dbus_string_validate_utf8): copy in a real
994 2003-03-16 Anders Carlsson <andersca@codefactory.se>
996 * dbus/dbus-connection.c:
997 (dbus_connection_send_with_reply_and_block):
998 Decrease connection->n_incoming when removing an entry
1000 * dbus/dbus-dict.c: (dbus_dict_entry_free),
1001 (dbus_dict_set_boolean_array), (dbus_dict_set_int32_array),
1002 (dbus_dict_set_uint32_array), (dbus_dict_set_double_array),
1003 (dbus_dict_set_byte_array), (dbus_dict_set_string_array),
1004 (dbus_dict_get_boolean_array), (dbus_dict_get_double_array),
1005 (dbus_dict_get_byte_array):
1006 Handle NULL arrays and strings. Also add support for byte arrays.
1008 * dbus/dbus-marshal.c: (_dbus_marshal_byte_array),
1009 (_dbus_marshal_dict), (_dbus_demarshal_byte_array),
1010 (_dbus_demarshal_int32_array), (_dbus_demarshal_uint32_array),
1011 (_dbus_demarshal_double_array), (_dbus_demarshal_string_array),
1012 (_dbus_demarshal_dict), (demarshal_and_validate_len),
1013 (_dbus_marshal_validate_arg), (_dbus_marshal_test):
1014 * dbus/dbus-marshal.h:
1015 Add support for marshalling and demarshalling empty arrays and strings.
1017 * dbus/dbus-message.c: (dbus_message_append_args_valist),
1018 (dbus_message_append_string_array),
1019 (dbus_message_iter_get_boolean),
1020 (dbus_message_iter_get_boolean_array),
1021 (dbus_message_iter_get_int32_array),
1022 (dbus_message_iter_get_uint32_array),
1023 (dbus_message_iter_get_double_array),
1024 (dbus_message_iter_get_byte_array),
1025 (dbus_message_iter_get_string_array), (dbus_message_iter_get_dict),
1026 (check_message_handling):
1027 Add support for getting empty arrays and dicts.
1029 * dbus/dbus-string.c: (_dbus_string_validate_utf8):
1030 Don't do any validation at all for now, that's better than just checking
1033 * test/data/valid-messages/emptiness.message:
1034 New test message with lots of empty arrays.
1036 2003-03-16 Havoc Pennington <hp@pobox.com>
1038 * dbus/dbus-connection.c
1039 (_dbus_connection_queue_received_message_link): new function that
1040 can't fail due to OOM
1042 * dbus/dbus-message.c (_dbus_message_loader_pop_message_link):
1043 new function pops a message together with a list link
1046 * dbus/dbus-transport-unix.c (queue_messages): use new link-based
1047 message queuing functions to avoid needing to alloc memory
1049 2003-03-16 Havoc Pennington <hp@pobox.com>
1051 Oops - test code was only testing failure of around 30 of the
1052 mallocs in the test path, but it turns out there are 500+
1053 mallocs. I believe this was due to misguided linking setup such
1054 that there was one copy of dbus_malloc etc. in the daemon and one
1055 in the shared lib, and only daemon mallocs were tested. In any
1056 case, the test case now tests all 500+ mallocs, and doesn't pass
1057 yet, though there are lots of fixes in this patch.
1059 * dbus/dbus-connection.c (dbus_connection_dispatch_message): fix
1060 this so that it doesn't need to allocate memory, since it
1061 has no way of indicating failure due to OOM (and would be
1062 annoying if it did).
1064 * dbus/dbus-list.c (_dbus_list_pop_first_link): new function
1066 * bus/Makefile.am: rearrange to create two self-contained
1067 libraries, to avoid having libraries with overlapping symbols.
1068 that was resulting in weirdness, e.g. I'm pretty sure there
1069 were two copies of global static variables.
1071 * dbus/dbus-internals.c: move the malloc debug stuff to
1074 * dbus/dbus-list.c (free_link): free list mempool if it becomes
1077 * dbus/dbus-memory.c (_dbus_disable_mem_pools): new function
1079 * dbus/dbus-address.c (dbus_parse_address): free list nodes
1082 * bus/dispatch.c (bus_dispatch_add_connection): free
1083 message_handler_slot when no longer using it, so
1084 memory leak checkers are happy for the test suite.
1086 * dbus/dbus-server-debug-pipe.c (debug_finalize): free server name
1088 * bus/bus.c (new_connection_callback): disconnect in here if
1089 bus_connections_setup_connection fails.
1091 * bus/connection.c (bus_connections_unref): fix to free the
1093 (bus_connections_setup_connection): if this fails, don't
1094 disconnect the connection, just be sure there are no side
1097 * dbus/dbus-string.c (undo_alignment): unbreak this
1099 * dbus/dbus-auth.c (_dbus_auth_unref): free some stuff we were
1101 (_dbus_auth_new): fix the order in which we free strings
1104 * bus/connection.c (bus_connection_disconnected): fix to
1105 not send ServiceDeleted multiple times in case of memory
1108 * dbus/dbus-bus.c (dbus_bus_get_base_service): new function to
1109 get the base service name
1110 (dbus_bus_register_client): don't return base service name,
1111 instead store it on the DBusConnection and have an accessor
1113 (dbus_bus_register_client): rename dbus_bus_register()
1115 * bus/dispatch.c (check_hello_message): verify that other
1116 connections on the bus also got the correct results, not
1117 just the one sending hello
1119 2003-03-15 Havoc Pennington <hp@pobox.com>
1121 Make it pass the Hello handling test including all OOM codepaths.
1122 Now to do other messages...
1124 * bus/services.c (bus_service_remove_owner): fix crash when
1125 removing owner from an empty list of owners
1126 (bus_registry_ensure): don't leave service in the list of
1127 a connection's owned services if we fail to put the service
1130 * bus/connection.c (bus_connection_preallocate_oom_error): set
1131 error flag on the OOM error.
1133 * dbus/dbus-connection.c (_dbus_connection_new_for_transport):
1134 handle _dbus_transport_set_connection failure
1136 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_fd): modify
1137 to create watches up front and simply enable/disable them as
1139 (unix_connection_set): this can now fail on OOM
1141 * dbus/dbus-timeout.c, dbus/dbus-watch.c: add concept
1142 of enabling/disabling a watch or timeout.
1144 * bus/loop.c (bus_loop_iterate): don't touch disabled
1147 * glib/dbus-gmain.c: adapt to enable/disable watches and timeouts
1149 2003-03-15 Havoc Pennington <hp@pobox.com>
1151 * bus/dispatch.c (bus_dispatch_test): OK, now finally actually
1152 write useful test code, after all that futzing around ;-)
1154 Test does not yet pass because we can't handle OOM in
1155 _dbus_transport_messages_pending (basically,
1156 dbus_connection_preallocate_send() does not prealloc the write
1157 watch). To fix this, I think we need to add new stuff to
1158 set_watch_functions, namely a SetEnabled function so we can alloc
1159 the watch earlier, then enable it later.
1161 * dbus/Makefile.am (libdbus_convenience_la_SOURCES): move
1162 dbus-memory.c to the convenience lib
1164 * bus/test.c: rename some static functions to keep them clearly
1165 distinct from stuff in connection.c. Handle client disconnection.
1167 2003-03-14 Havoc Pennington <hp@pobox.com>
1169 * bus/dispatch.c (bus_dispatch_test): do test using debug-pipe
1170 transport, tests more of the real codepath. Set up clients
1171 with bus_setup_debug_client.
1173 * bus/test.c (bus_setup_debug_client): function to set up debug
1174 "clients" on the main loop
1176 * dbus/dbus-transport.c (_dbus_transport_open): add debug-pipe
1179 * dbus/dbus-server.c (dbus_server_listen): add debug-pipe
1182 * dbus/dbus-server-debug.c: support a debug server based on pipes
1184 * dbus/dbus-sysdeps.c (_dbus_full_duplex_pipe): new function
1185 (_dbus_close): new function
1187 * configure.in: check for socketpair
1189 2003-03-14 Havoc Pennington <hp@redhat.com>
1191 * dbus/dbus-memory.c: add a "detect buffer overwrites on free"
1194 * dbus/dbus-transport-debug.c: rework this a good bit to be
1195 less complicated. hopefully still works.
1197 * dbus/dbus-server-debug.c (handle_new_client): remove timeout
1200 * glib/dbus-gmain.c (timeout_handler): don't remove timeout
1203 * dbus/dbus-message.c (dbus_message_copy): rename from
1204 dbus_message_new_from_message, fix it up to copy
1205 all the message fields, add test case
1207 * bus/dispatch.c (bus_dispatch_test): add some more test code,
1208 not quite passing yet
1210 2003-03-14 Havoc Pennington <hp@pobox.com>
1212 * bus/loop.c (bus_loop_iterate): add this so we can "run loop
1213 until no work remains" in test code. (the large diff here
1214 is just code movement, no actual changes)
1216 * dbus/dbus-server-debug.c (DEFAULT_INTERVAL): change interval to
1217 1, no point waiting around for test code.
1218 (_dbus_server_debug_accept_transport): unref the timeout
1219 after adding it (right?)
1221 * dbus/dbus-transport-debug.c (DEFAULT_INTERVAL): ditto
1223 2003-03-13 Havoc Pennington <hp@redhat.com>
1225 * dbus/dbus-timeout.c (_dbus_timeout_list_set_functions): handle
1228 * dbus/dbus-watch.c (_dbus_watch_list_set_functions): handle out
1231 * dbus/dbus-connection.h: Make AddWatchFunction and
1232 AddTimeoutFunction return a bool so they can fail on out-of-memory
1234 * bus/bus.c (bus_context_new): set up timeout handlers
1236 * bus/connection.c (bus_connections_setup_connection): set up
1239 * glib/dbus-gmain.c: adapt to the fact that set_functions stuff
1242 * bus/bus.c (bus_context_new): adapt to changes
1244 * bus/connection.c: adapt to changes
1246 * test/watch.c: adapt to DBusWatch changes
1248 * bus/dispatch.c (bus_dispatch_test): started adding this but
1251 2003-03-14 Anders Carlsson <andersca@codefactory.se>
1253 * bus/dispatch.c (send_service_nonexistent_error): Fix typo.
1255 2003-03-13 Havoc Pennington <hp@pobox.com>
1257 * bus/test.c, bus/test.h, bus/Makefile.am, bus/test-main.c:
1258 set up a test framework as for the library
1260 2003-03-12 Havoc Pennington <hp@pobox.com>
1262 Throughout: purge global variables, introduce BusActivation,
1263 BusConnections, BusRegistry, etc. objects instead.
1265 * bus/bus.h, bus/bus.c: introduce BusContext as a global
1268 * test/Makefile.am (TEST_BINARIES): disable bus-test for now,
1269 going to redo this a bit differently I think
1271 2003-03-12 Havoc Pennington <hp@redhat.com>
1273 Mega-patch that gets the message bus daemon initially handling
1274 out-of-memory. Work still needed. Also lots of random
1275 moving stuff to DBusError instead of ResultCode.
1277 * dbus/dbus-list.c (_dbus_list_length_is_one): new function
1279 * dbus/dbus-connection.c
1280 (dbus_connection_send_with_reply_and_block): use DBusError
1282 * dbus/dbus-bus.c: adapt to API changes, make it use DBusError not
1285 * dbus/dbus-connection.c (dbus_connection_send): drop the result
1286 code here, as the only failure possible is OOM.
1288 * bus/connection.c (bus_connection_disconnect):
1289 rename bus_connection_disconnected as it's a notification only
1291 * bus/driver.c (bus_driver_handle_acquire_service): don't free
1292 "name" on get_args failure, should be done by get_args;
1293 don't disconnect client for bad args, just return an error.
1294 (bus_driver_handle_service_exists): ditto
1296 * bus/services.c (bus_services_list): NULL-terminate returned array
1298 * bus/driver.c (bus_driver_send_service_lost)
1299 (bus_driver_send_service_acquired): send messages from driver to a
1300 specific client to the client's unique name, not to the broadcast
1303 * dbus/dbus-message.c (decode_header_data): reject messages that
1304 contain no name field
1305 (_dbus_message_get_client_serial): rename to
1306 dbus_message_get_serial and make public
1307 (_dbus_message_set_serial): rename from set_client_serial
1308 (_dbus_message_set_reply_serial): make public
1309 (_dbus_message_get_reply_serial): make public
1311 * bus/connection.c (bus_connection_foreach): allow stopping
1312 iteration by returning FALSE from foreach function.
1314 * dbus/dbus-connection.c (dbus_connection_send_preallocated)
1315 (dbus_connection_free_preallocated_send)
1316 (dbus_connection_preallocate_send): new API for sending a message
1317 without possibility of malloc failure.
1318 (dbus_connection_send_message): rename to just
1319 dbus_connection_send (and same for whole function family)
1321 * dbus/dbus-errors.c (dbus_error_free): make this reinit the error
1323 * dbus/dbus-sysdeps.c (_dbus_exit): new function
1325 * bus/activation.c: handle/return errors
1327 * dbus/dbus-errors.h: add more DBUS_ERROR #define
1329 * dbus/dbus-sysdeps.c (_dbus_directory_open) (_dbus_file_get_contents)
1330 (_dbus_directory_get_next_file): use DBusError instead of DBusResultCode
1331 (_dbus_result_from_errno): move to this file
1333 2003-03-10 Anders Carlsson <andersca@codefactory.se>
1335 * dbus/dbus-marshal.c:
1336 (_dbus_marshal_set_string):
1337 Take a length argument so we can marshal the correct string
1340 (_dbus_marshal_dict), (_dbus_demarshal_dict),
1341 (_dbus_marshal_get_arg_end_pos), (_dbus_marshal_validate_arg),
1342 (_dbus_marshal_test):
1343 * dbus/dbus-marshal.h:
1344 Add support for marshalling and demarshalling dicts.
1346 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
1347 Add support for TYPE DICT.
1349 * dbus/dbus-message.c: (set_string_field):
1350 Adjust header padding.
1352 (dbus_message_append_args_valist), (dbus_message_append_dict),
1353 (dbus_message_get_args_valist), (dbus_message_iter_get_arg_type),
1354 (dbus_message_iter_get_dict), (_dbus_message_loader_return_buffer),
1355 (check_message_handling), (check_have_valid_message):
1356 * dbus/dbus-message.h:
1357 Add functions for setting and getting dicts.
1359 * dbus/dbus-protocol.h:
1365 * doc/dbus-specification.sgml:
1366 Add information about how dicts are marshalled.
1368 * test/data/invalid-messages/dict-with-nil-value.message:
1369 * test/data/invalid-messages/too-short-dict.message:
1370 * test/data/valid-messages/dict-simple.message:
1371 * test/data/valid-messages/dict.message:
1372 Add sample messages containing dicts.
1374 2003-03-08 Anders Carlsson <andersca@codefactory.se>
1376 * dbus/dbus-dict.h: Add DBUS_END_DECLS.
1378 2003-03-07 Anders Carlsson <andersca@codefactory.se>
1381 * dbus/dbus-dict.c: (dbus_dict_entry_free), (dbus_dict_new),
1382 (dbus_dict_get_keys), (insert_entry), (dbus_dict_set_boolean),
1383 (dbus_dict_set_int32), (dbus_dict_set_uint32),
1384 (dbus_dict_set_double), (dbus_dict_set_string),
1385 (dbus_dict_set_boolean_array), (dbus_dict_set_int32_array),
1386 (dbus_dict_set_uint32_array), (dbus_dict_set_double_array),
1387 (dbus_dict_set_string_array), (_dbus_dict_test):
1389 Fix according to comments from Havoc.
1391 2003-03-06 Michael Meeks <michael@server.home>
1393 * configure.in: if we don't have kde-config, disable have_qt.
1395 2003-03-07 Anders Carlsson <andersca@codefactory.se>
1400 * dbus/dbus-dict.c: (dbus_dict_entry_free), (dbus_dict_new),
1401 (dbus_dict_ref), (dbus_dict_unref), (dbus_dict_contains),
1402 (dbus_dict_remove), (dbus_dict_get_value_type),
1403 (dbus_dict_get_keys), (dbus_dict_put_boolean),
1404 (dbus_dict_put_int32), (dbus_dict_put_uint32),
1405 (dbus_dict_put_double), (dbus_dict_put_string),
1406 (dbus_dict_put_boolean_array), (dbus_dict_put_int32_array),
1407 (dbus_dict_put_uint32_array), (dbus_dict_put_double_array),
1408 (dbus_dict_put_string_array), (dbus_dict_get_boolean),
1409 (dbus_dict_get_int32), (dbus_dict_get_uint32),
1410 (dbus_dict_get_double), (dbus_dict_get_string),
1411 (dbus_dict_get_boolean_array), (dbus_dict_get_int32_array),
1412 (dbus_dict_get_uint32_array), (dbus_dict_get_double_array),
1413 (dbus_dict_get_string_array), (_dbus_dict_test):
1415 Add DBusDict implementation
1417 * dbus/dbus-test.c: (dbus_internal_do_not_use_run_tests):
1421 2003-03-04 Havoc Pennington <hp@pobox.com>
1423 * test/data/auth/*: adapt to changes
1425 * dbus/dbus-auth-script.c (_dbus_auth_script_run): add
1426 USERID_BASE64 and change USERNAME_BASE64 to put in username not
1429 * dbus/dbus-keyring.c (_dbus_keyring_validate_context): prevent
1430 more stuff from being in a context name, to make the protocol
1431 simpler to deal with
1433 * dbus/dbus-errors.c (dbus_error_has_name): new function
1434 (dbus_error_is_set): new function
1436 * dbus/dbus-auth.c: replace DBUS_STUPID_TEST_MECH auth
1437 with DBUS_COOKIE_SHA1, implement DBUS_COOKIE_SHA1
1439 * dbus/dbus-connection.c (dbus_connection_flush): also read
1440 messages during a flush operation
1442 * dbus/Makefile.am: remove dbus-md5 since it isn't currently used.
1444 2003-03-05 Anders Carlsson <andersca@codefactory.se>
1446 * configure.in: Check for gethostbyname on Solaris.
1448 * dbus/dbus-transport.c: (_dbus_transport_open):
1449 Remove duplicate "tcp" entry.
1451 * doc/dbus-specification.sgml:
1452 Clarify some things.
1454 2003-03-05 Anders Carlsson <andersca@codefactory.se>
1456 * dbus/dbus-auth.c: (send_rejected), (process_test_subdir):
1457 * dbus/dbus-keyring.c: (_dbus_keyring_new_homedir),
1458 (_dbus_keyring_test):
1459 * dbus/dbus-md5.c: (_dbus_md5_compute):
1460 * dbus/dbus-sha.c: (_dbus_sha_compute):
1463 2003-03-05 Anders Carlsson <andersca@codefactory.se>
1465 * README: Add some things.
1467 2003-03-04 Anders Carlsson <andersca@codefactory.se>
1469 * dbus/dbus-message.c (dbus_message_append_args_valist): Add a break;
1470 after case DBUS_TYPE_BOOELAN.
1472 2003-03-02 Havoc Pennington <hp@pobox.com>
1474 * test/break-loader.c (randomly_set_extreme_ints): add test that
1475 sets really huge and small integers
1477 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): add check
1478 that length of boolean array fits in the string, and that
1479 string has room for boolean value in single-bool case.
1481 * dbus/dbus-message-builder.c (_dbus_message_data_load): add
1482 optional value to "ALIGN" command which is what to fill the
1485 * test/data/valid-messages/no-padding.message: add regression
1486 test for the message padding problem
1488 2003-03-02 Havoc Pennington <hp@pobox.com>
1490 * dbus/dbus-message.c (decode_header_data): fix to always init
1491 message_padding, from Benjamin Dauvergne
1493 2003-03-02 Havoc Pennington <hp@pobox.com>
1499 2003-03-01 Joe Shaw <joe@assbarn.com>
1501 * configure.in: Check for "struct cmsgcred" and try to access its
1502 members for BSD-like unices.
1504 * dbus/dbus-sysdeps.c (read_credentials_byte): Fold this back into
1505 _dbus_read_credentials_unix_socket().
1506 (_dbus_read_credentials_unix_socket): Use recvmsg() instead of
1507 read() for reading the credential byte off the unix socket. Use
1508 struct cmsgcred on systems that support it.
1510 2003-02-27 Alexander Larsson <alexl@redhat.com>
1514 Make gthreads-2.0 dependency optional. Don't build thread test if
1517 2003-02-27 Havoc Pennington <hp@pobox.com>
1519 * dbus/dbus-connection.c
1520 (dbus_connection_send_message_with_reply_and_block): fix doh!
1521 doh! doh! bug that resulted in never removing a reply from the
1522 queue, no wonder we called get_reply_serial so much ;-)
1524 * dbus/dbus-message.c (struct DBusMessage): cache reply serial
1525 and client serial instead of demarshaling them every time
1527 2003-02-27 Havoc Pennington <hp@pobox.com>
1529 * dbus/dbus-marshal.c (_dbus_demarshal_int32): rewrite to be much
1530 more inlined, using dbus-string-private.h, speeds things up
1533 * dbus/dbus-string.c (_dbus_string_free): apply align offset
1534 when freeing the string
1535 (_dbus_string_steal_data): fix for align offset
1536 (undo_alignment): new function
1538 2003-02-26 Havoc Pennington <hp@redhat.com>
1540 All kinds of audit fixes from Owen, plus initial attempt to
1541 handle unaligned memory returned from malloc.
1543 * dbus/dbus-string.c (_dbus_string_init): clamp max length to
1544 leave room for align_offset and nul byte
1545 (fixup_alignment): function to track an align_offset and
1546 ensure real->str is aligned
1547 (DBUS_GENERIC_STRING_PREAMBLE): len must be less than allocated,
1548 to allow a nul byte plus align offset
1549 (_dbus_string_lock): fix overflow issue
1550 (_dbus_string_init_const_len): add assertions on sanity of len,
1551 assign allocated to be ALLOCATION_PADDING larger than len
1552 (set_length): fixup the overflow handling
1553 (_dbus_string_get_data_len): fix overflow in assertion
1554 (open_gap): detect overflow in size of gap to be opened
1555 (_dbus_string_lengthen): add overflow check
1556 (_dbus_string_align_length): fix overflow with _DBUS_ALIGN_VALUE
1557 (_dbus_string_append): add overflow check
1558 (_dbus_string_append_unichar): overflow
1559 (_dbus_string_delete): fix overflow in assertion
1560 (_dbus_string_copy_len): overflow in assertion
1561 (_dbus_string_replace_len): overflows in assertions
1562 (_dbus_string_find): change to implement in terms of
1563 _dbus_string_find_to
1564 (_dbus_string_find_to): assorted fixage
1565 (_dbus_string_equal_c_str): assert c_str != NULL,
1566 fix logic so the function works
1567 (_dbus_string_ends_with_c_str): fix overflow thingy
1568 (_dbus_string_base64_encode): overflow fix
1569 (_dbus_string_validate_ascii): overflow
1570 (_dbus_string_validate_nul): overflow
1572 2003-02-26 Havoc Pennington <hp@redhat.com>
1574 * dbus/dbus-marshal.c (_dbus_marshal_test): fix to work with DISABLE_ASSERTS
1576 2003-02-26 Alexander Larsson <alexl@redhat.com>
1579 Set DBUS_GLIB_THREADS_LIBS for apps using gthread-2.0
1581 * dbus/dbus-connection.c:
1582 * dbus/dbus-connection.h:
1583 Fix _dbus_connection_acquire_io_path and _dbus_connection_acquire_dispatch.
1584 Add dbus_connection_set_wakeup_main_function and use it when queueing
1585 incoming and outgoing messages.
1588 * dbus/dbus-dataslot.c:
1589 Threadsafe usage of DBusDataSlotAllocator
1591 * dbus/dbus-message.c: (dbus_message_get_args_iter):
1594 * dbus/dbus-server-unix.c:
1597 * glib/dbus-gmain.c:
1598 Implement the new wakeup functions for glib.
1601 * glib/test-thread-client.c:
1602 * glib/test-thread-server.c:
1603 * glib/test-thread.h:
1604 Initial cut at some thread test code. Not really done yet.
1606 2003-02-26 Havoc Pennington <hp@pobox.com>
1608 * dbus/dbus-connection.c
1609 (dbus_connection_send_message_with_reply_and_block): fix crash
1610 where we ref'd the outgoing message instead of the returned reply
1612 * dbus/dbus-transport-unix.c (do_authentication): check read watch
1613 at the end of this function, so if we didn't need to read for
1614 authentication, we reinstall it for receiving messages
1616 * dbus/dbus-message.c (dbus_message_new_reply): allow replies to
1617 a NULL sender for peer-to-peer case
1619 * dbus/dbus-transport-unix.c (check_read_watch): handle
1620 !authenticated case correctly
1622 * glib/dbus-gmain.c: add support for DBusServer
1624 * dbus/dbus-server.c: add data slot support
1626 * glib/dbus-gmain.c (dbus_connection_setup_with_g_main): check
1627 return values and handle errors
1629 * dbus/dbus-dataslot.c: factor out the data slot stuff from
1632 * Doxyfile.in (INPUT): add glib subdir
1634 * glib/dbus-gmain.c (dbus_connection_setup_with_g_main): rename
1635 setup_with_g_main instead of hookup_with_g_main; write docs
1637 2003-02-24 Anders Carlsson <andersca@codefactory.se>
1639 * dbus/dbus-marshal.c: (_dbus_marshal_validate_arg):
1640 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
1641 * dbus/dbus-message.c: (dbus_message_append_boolean),
1642 (dbus_message_append_boolean_array),
1643 (dbus_message_get_args_valist), (_dbus_message_test):
1644 * dbus/dbus-message.h:
1645 * doc/dbus-specification.sgml:
1646 Various fixes as pointed out by Havoc.
1648 * test/data/invalid-messages/bad-boolean-array.message:
1649 * test/data/invalid-messages/bad-boolean.message:
1650 Add invalid boolean value test cases.
1652 2003-02-24 Anders Carlsson <andersca@codefactory.se>
1654 * dbus/dbus-internals.c: (_dbus_type_to_string):
1655 * dbus/dbus-marshal.c: (_dbus_marshal_get_arg_end_pos),
1656 (_dbus_marshal_validate_arg):
1657 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
1658 * dbus/dbus-message.c: (dbus_message_append_args_valist),
1659 (dbus_message_append_boolean), (dbus_message_append_boolean_array),
1660 (dbus_message_get_args_valist), (dbus_message_iter_get_boolean),
1661 (dbus_message_iter_get_int32), (dbus_message_iter_get_uint32),
1662 (dbus_message_iter_get_double),
1663 (dbus_message_iter_get_boolean_array), (message_iter_test):
1664 * dbus/dbus-message.h:
1665 * dbus/dbus-protocol.h:
1666 * doc/dbus-specification.sgml:
1667 * test/data/valid-messages/lots-of-arguments.message:
1668 Add support for boolean and boolean array types.
1670 2003-02-23 Havoc Pennington <hp@pobox.com>
1672 * dbus/dbus-keyring.c: finish most of this implementation and
1675 * dbus/dbus-errors.c (dbus_set_error_const, dbus_set_error): make
1676 these barf if the error isn't cleared to NULL
1678 * dbus/dbus-sysdeps.c (_dbus_delete_file): set error on failure
1679 (_dbus_create_directory): new function
1681 * dbus/dbus-errors.c (dbus_set_error): fix warning
1683 * dbus/dbus-string.c (_dbus_string_hex_encode): new function
1684 (_dbus_string_hex_decode): new function
1685 (test_hex_roundtrip): test code
1687 * dbus/dbus-sha.c (_dbus_sha_compute): use dbus_string_hex_encode
1689 * dbus/dbus-md5.c (_dbus_md5_compute): use dbus_string_hex_encode
1691 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): make this use
1692 the save-to-temp/rename trick to atomically write the new file
1693 (_dbus_string_parse_uint): new function
1695 2003-02-22 Havoc Pennington <hp@pobox.com>
1697 * test/Makefile.am (dist-hook): fix dist for test/data/sha-1
1699 2003-02-22 Havoc Pennington <hp@pobox.com>
1701 * dbus/dbus-message.c (dbus_message_iter_get_string_array):
1702 (dbus_message_iter_get_byte_array): Fix up doxygen warnings
1704 * dbus/dbus-sha.c: add implementation of SHA-1 algorithm
1706 * dbus/test/data/sha-1: add US government test suite for SHA-1
1708 2003-02-21 Anders Carlsson <andersca@codefactory.se>
1710 * dbus/dbus-marshal.c: (_dbus_demarshal_string_array):
1711 Make string arrays NULL-terminated.
1713 * dbus/dbus-memory.c: (dbus_free_string_array):
1714 * dbus/dbus-memory.h:
1715 New function for freeing NULL-terminated string arrays.
1717 * dbus/dbus-message-builder.c: (append_quoted_string),
1718 (_dbus_message_data_load):
1719 Add support for array types.
1721 * dbus/dbus-message.c: (check_message_handling):
1722 Add more types as test cases.
1724 * dbus/dbus-sysdeps.c: (_dbus_string_parse_int),
1725 (_dbus_string_parse_double):
1726 Add the start offset to the end offset.
1728 * test/data/valid-messages/lots-of-arguments.message:
1729 New test message with lots of arguments.
1731 2003-02-21 Anders Carlsson <andersca@codefactory.se>
1733 * dbus/dbus-message.c: (dbus_message_append_nil),
1734 (dbus_message_append_int32), (dbus_message_append_uint32),
1735 (dbus_message_append_double), (dbus_message_append_string),
1736 (dbus_message_append_int32_array),
1737 (dbus_message_append_uint32_array),
1738 (dbus_message_append_double_array),
1739 (dbus_message_append_byte_array),
1740 (dbus_message_append_string_array):
1741 Fix all out-of-memory handling in these functions.
1743 2003-02-21 Anders Carlsson <andersca@codefactory.se>
1745 * dbus/dbus-message.c: (dbus_message_append_nil):
1748 2003-02-21 Anders Carlsson <andersca@codefactory.se>
1750 * dbus/dbus-message.c: (dbus_message_append_args_valist),
1751 (dbus_message_append_nil), (dbus_message_append_int32_array),
1752 (dbus_message_append_uint32_array),
1753 (dbus_message_append_double_array),
1754 (dbus_message_append_byte_array),
1755 (dbus_message_append_string_array), (dbus_message_get_args_valist),
1756 (dbus_message_iter_get_int32_array),
1757 (dbus_message_iter_get_uint32_array),
1758 (dbus_message_iter_get_double_array),
1759 (dbus_message_iter_get_byte_array),
1760 (dbus_message_iter_get_string_array):
1762 * dbus/dbus-message.h:
1763 Add functions for appending and getting arrays.
1765 2003-02-21 Anders Carlsson <andersca@codefactory.se>
1767 * dbus/dbus-mempool.c (_dbus_mem_pool_new): Make the
1768 element size at least 8 bytes, fixes mempool tests on
1771 2003-02-20 Alexander Larsson <alexl@redhat.com>
1773 * dbus/dbus-transport-unix.c (unix_do_iteration):
1774 Unlock the connection mutex during a blocking select call.
1775 Add todo about how we need a way to wake up the select.
1777 * dbus/dbus-connection-internal.h:
1778 * dbus/dbus-connection.c:
1779 Add _dbus_connection_lock and _dbus_connection_unlock.
1781 2003-02-19 Havoc Pennington <hp@pobox.com>
1783 * Doxyfile.in (PREDEFINED): put DOXYGEN_SHOULD_SKIP_THIS in
1784 Doxyfile.in, not Doxyfile
1786 * dbus/dbus-keyring.c: do some hacking on this
1788 * dbus/dbus-sysdeps.c (_dbus_delete_file): new
1790 * dbus/dbus-errors.c (dbus_set_error_const): do not call
1792 (dbus_set_error): remove dbus_error_init, check for message ==
1793 NULL *before* we sprintf into it, and add @todo about including
1794 system headers in this file
1796 * dbus/dbus-sysdeps.c (_dbus_create_file_exclusively): new
1798 * dbus/dbus-errors.h (DBUS_ERROR_FAILED): add
1800 * dbus/dbus-sysdeps.c (get_user_info): break this function out to
1801 get various bits of user information based on either username
1803 (_dbus_homedir_from_username): new function
1805 2003-02-19 Anders Carlsson <andersca@codefactory.se>
1808 Add check for nonposix getpwnam_r
1810 * dbus/dbus-mempool.c: (_dbus_mem_pool_new):
1811 Align the pool element size to a sizeof (void *) boundary.
1813 * dbus/dbus-sysdeps.c: (_dbus_setenv), (_dbus_connect_unix_socket),
1814 (_dbus_listen_unix_socket), (_dbus_credentials_from_username):
1815 General Solaris fixes.
1817 * test/data/valid-messages/simplest-manual.message:
1818 Explicitly state that we want little-endian packing.
1820 2003-02-19 Mikael Hallendal <micke@codefactory.se>
1822 * dbus/dbus-server.c (dbus_server_listen): Support tcp: addresses.
1824 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_tcp_socket):
1825 Added to create a transport connecting using a tcp/ip socket.
1827 * dbus/dbus-sysdeps.c (_dbus_connect_tcp_socket): Added to connect
1828 to a tcp socket at given host and port.
1829 (_dbus_listen_tcp_socket): added to listen on tcp socket for given
1832 * dbus/dbus-server.c (dbus_server_listen): Support tcp: addresses.
1834 * dbus/dbus-server-unix.c (_dbus_server_new_for_tcp_socket):
1835 Added to create a server listening on a TCP/IP socket.
1837 2003-02-19 Havoc Pennington <hp@pobox.com>
1839 Throughout: mop up all the Doxygen warnings and undocumented
1842 * dbus/dbus-sysdeps.c (do_exec): do not use execvp, we don't want
1843 to search any paths.
1845 * dbus/dbus-threads.c: move global mutex initializers to
1846 dbus-internals.h, multiple prototypes was confusing doxygen
1847 besides being kind of ugly
1849 * Doxyfile (PREDEFINED): have Doxygen define
1850 DOXYGEN_SHOULD_SKIP_THIS so we can exclude things from
1851 docs with #ifndef DOXYGEN_SHOULD_SKIP_THIS
1852 (do not abuse the feature! it's for stuff like the autogenerated
1853 macros in dbus-md5.c, not just for things you don't feel like
1856 2003-02-18 Havoc Pennington <hp@pobox.com>
1858 * dbus/dbus-string.c (_dbus_string_zero): new function
1860 * dbus/dbus-md5.c: include MD5 implementation by L. Peter Deutsch,
1861 wrap it in some dbus-friendly API
1863 * dbus/dbus-types.h: add 16-bit types
1865 2003-02-18 Joe Shaw <joe@assbarn.com>
1867 * dbus/dbus-auth.c (handle_server_data_stupid_test_mech): Just get
1868 credentials from our currently running process.
1869 (get_word): Fix a buglet where we were copying the entire length
1870 instead of relative to our position.
1872 * dbus/dbus-hash.c (_dbus_hash_test): Don't try to allocate the
1873 keys on the stack... it's 640k of data.
1875 * dbus/dbus-sysdeps.c (_dbus_read_credentials_unix_socket): Always
1876 read the credentials byte off the socket, even if we don't have
1878 (_dbus_poll): Implement poll() using select() for systems which
1881 * glib/test-dbus-glib.c (main): Print out an error if no
1882 parameters are given.
1884 * test/data/auth/fallback.auth-script: Added. Tests that a client
1885 can fallback to a secondary auth mechanism if the first fails.
1887 2003-02-18 Havoc Pennington <hp@pobox.com>
1891 2003-02-17 Havoc Pennington <hp@pobox.com>
1893 * doc/dbus-specification.sgml: lots of cosmetic
1894 cleanups/rearrangement, add assorted FIXME, change DBUS_ADDRESS
1895 env variable to DBUS_BUS_ADDRESS, s/client/application/,
1896 s/server/bus/ (except in authentication section). Add a section
1897 "Message Bus Message Routing"
1899 2003-02-17 Anders Carlsson <andersca@codefactory.se.>
1905 2003-02-17 Anders Carlsson <andersca@codefactory.se>
1907 * doc/dbus-specification.sgml:
1908 Specification updates.
1910 2003-02-17 Anders Carlsson <andersca@codefactory.se>
1912 * bus/activation.c: (bus_activation_init), (child_setup),
1913 (bus_activation_activate_service):
1915 * bus/main.c: (main):
1916 Set DBUS_ADDRESS environment variable.
1918 * dbus/dbus-errors.c: (dbus_set_error):
1919 Don't use va_copy since that's a C99 feature.
1921 * dbus/dbus-sysdeps.c: (_dbus_setenv), (do_exec),
1922 (_dbus_spawn_async):
1923 * dbus/dbus-sysdeps.h:
1924 Add child_setup_func to _dbus_spawn_async.
1926 * doc/dbus-specification.sgml:
1927 Update specification.
1929 * test/spawn-test.c: (setup_func), (main):
1932 2003-02-17 Alexander Larsson <alexl@redhat.com>
1934 * dbus/dbus-connection.c (_dbus_connection_handler_destroyed_locked):
1937 2003-02-17 Anders Carlsson <andersca@codefactory.se>
1941 * doc/dbus-test-plan.sgml:
1942 Add test plan document.
1947 2003-02-17 Anders Carlsson <andersca@codefactory.se>
1949 * dbus/dbus-message.c: (decode_header_data),
1950 (_dbus_message_loader_return_buffer):
1951 Set the header padding amount when loading a message.
1953 2003-02-16 Anders Carlsson <andersca@codefactory.se>
1955 * bus/dispatch.c: (send_one_message):
1956 Only send broadcast messages to registered connections.
1958 * dbus/dbus-message.c: (dbus_message_name_is):
1959 * dbus/dbus-message.h:
1960 New convenience function.
1962 * dbus/dbus-transport-debug.c: (do_reading):
1963 Only dispatch one message per run.
1966 * test/bus-test.c: (new_connection_callback), (die),
1967 (test_hello_client1_handler), (test_hello_client2_handler),
1968 (test_hello_replies), (main):
1970 * test/bus-test-loop.[ch]:
1973 2003-02-16 Havoc Pennington <hp@pobox.com>
1975 * dbus/dbus-connection.c (dbus_connection_dispatch_message): fix
1976 backward conditional
1978 2003-02-16 Alexander Larsson <alexl@redhat.com>
1980 * dbus/dbus-connection.c:
1981 Implement sent_message_with_reply. (with_reply_and block is still
1983 Made dispatch_message not lose message if OOM.
1985 * dbus/dbus-errors.h:
1986 Add NoReply error (for reply timeouts).
1988 2003-02-16 Alexander Larsson <alexl@redhat.com>
1990 * dbus/dbus-hash.c (_dbus_hash_table_unref):
1991 Actually free keys and values when destroying hashtable.
1993 2003-02-16 Anders Carlsson <andersca@codefactory.se>
1995 * dbus/dbus-auth.c: (client_try_next_mechanism):
1998 * dbus/dbus-threads.c: (dbus_condvar_wait_timeout):
1999 Return TRUE if there's no thread implementation around.
2001 * glib/dbus-gmain.c: (free_source),
2002 (dbus_connection_hookup_with_g_main):
2003 Make sure to remove the GSource when the connection is finalized.
2005 2003-02-16 Anders Carlsson <andersca@codefactory.se>
2007 * bus/dispatch.c: (bus_dispatch_message_handler):
2008 * dbus/dbus-errors.h:
2009 Return an error if someone tries to send a message to a service
2012 2003-02-16 Anders Carlsson <andersca@codefactory.se>
2014 * bus/activation.c: (load_directory), (bus_activation_init),
2015 (bus_activation_activate_service):
2018 (bus_driver_handle_activate_service), (bus_driver_handle_message):
2019 More work on the activation handling.
2021 * dbus/dbus-errors.h:
2022 Add some error messages
2024 * dbus/dbus-message.c: (dbus_message_new_error_reply):
2025 * dbus/dbus-message.h:
2026 New function that creates an error message.
2028 * dbus/dbus-protocol.h:
2029 Add ACTIVATE_SERVER message.
2031 * dbus/dbus-server-unix.c: (unix_handle_watch),
2032 (_dbus_server_new_for_domain_socket):
2033 Call _dbus_fd_set_close_on_exec.
2035 * dbus/dbus-sysdeps.c: (make_pipe), (do_exec),
2036 (_dbus_spawn_async), (_dbus_disable_sigpipe),
2037 (_dbus_fd_set_close_on_exec):
2038 * dbus/dbus-sysdeps.h:
2039 Add _dbus_fd_set_close_on exec function. Also add function that checks
2040 that all open fds are set to close-on-exec and warns otherwise.
2042 * dbus/dbus-transport-unix.c:
2043 (_dbus_transport_new_for_domain_socket):
2044 Call _dbus_fd_set_close_on_exec.
2046 2003-02-16 Havoc Pennington <hp@pobox.com>
2048 * dbus/dbus-connection.c (dbus_connection_set_change_sigpipe):
2049 allow people to avoid setting SIGPIPE to SIG_IGN
2050 (_dbus_connection_new_for_transport): disable SIGPIPE unless
2051 we've been asked not to
2053 2003-02-15 Anders Carlsson <andersca@codefactory.se>
2055 * dbus/dbus-list.c: (_dbus_list_append_link),
2056 (_dbus_list_prepend_link):
2057 * dbus/dbus-memory.c: (dbus_malloc), (dbus_malloc0),
2061 2003-02-15 Anders Carlsson <andersca@codefactory.se>
2064 * bus/activation.c: (bus_activation_entry_free),
2065 (add_desktop_file_entry), (load_directory), (bus_activation_init):
2067 * bus/main.c: (main):
2068 Add simple activation support, doesn't work yet though.
2070 2003-02-15 Zack Rusin <zack@kde.org>
2072 * qt/dbus-qthread.cpp: small casting fix
2074 2003-02-15 Anders Carlsson <andersca@codefactory.se>
2076 * dbus/dbus-errors.c: (dbus_set_error):
2077 * dbus/dbus-errors.h:
2078 Add a few errors and make dbus_set_error void.
2080 * dbus/dbus-sysdeps.c:
2081 (_dbus_errno_to_string), (close_and_invalidate), (make_pipe),
2082 (write_err_and_exit), (read_ints), (do_exec), (_dbus_spawn_async):
2083 * dbus/dbus-sysdeps.h:
2084 Add _dbus_spawn_async.
2086 * test/spawn-test.c: (main):
2087 Test for _dbus_spawn_async.
2089 2003-02-15 Anders Carlsson <andersca@codefactory.se>
2091 * dbus/dbus-internals.h:
2092 Fix build without tests.
2094 * dbus/dbus-list.c: (alloc_link):
2095 Fix a segfault when a malloc fails.
2097 * dbus/dbus-memory.c: (initialize_malloc_debug), (dbus_malloc),
2098 (dbus_malloc0), (dbus_realloc):
2099 Add support for malloc debugging.
2101 2003-02-15 Alexander Larsson <alexl@redhat.com>
2103 * dbus/dbus-threads.c:
2104 * dbus/dbus-threads.h:
2105 Add condvars. Remove static mutext from API.
2106 Implement static mutexes by initializing them from threads_init.
2108 * glib/dbus-gthread.c:
2109 * qt/dbus-qthread.cpp:
2110 Update with the thread api changes.
2115 Turn StaticMutex into normal mutex + init function.
2116 Export new functions _dbus_list_alloc_link, _dbus_list_free_link,
2117 _dbus_list_append_link, _dbus_list_prepend_link
2120 * dbus/dbus-sysdeps.c:
2121 * dbus/dbus-sysdeps.h:
2122 New type dbus_atomic_t, and new functions _dbus_atomic_inc,
2123 _dbus_atomic_dec. Only slow fallback implementation at the moment.
2125 * dbus/dbus-protocol.h:
2126 Add DBUS_MESSAGE_LOCAL_DISCONNECT define
2128 * dbus/dbus-message.c:
2129 Make ref/unref atomic.
2132 * dbus/dbus-connection-internal.h:
2133 * dbus/dbus-connection.c:
2134 * dbus/dbus-connection.h:
2136 Change _peek to _borrow,_return & _steal_borrowed.
2137 Change disconnect callback to event.
2138 Make dbus_connection_dispatch_messages reentrant.
2140 * dbus/dbus-transport.c:
2141 Don't ref the connection on calls to the transport
2144 * dbus/dbus-message-handler.c:
2147 * glib/dbus-gmain.c:
2148 Don't use peek_message anymore
2151 * test/debug-thread.c:
2152 * test/debug-thread.h:
2153 Simple thread implementation that asserts() on deadlocks in
2154 single-threaded code.
2157 (main) Call debug_threads_init.
2160 Use disconnect message instead of disconnect callback.
2164 Don't call dbus_connection_set_disconnect_function. Instead export
2165 bus_connection_disconnect.
2168 Call bus_connection_disconnect when we get a disconnected message.
2170 2003-02-15 Havoc Pennington <hp@pobox.com>
2172 * dbus/dbus-message.c (dbus_message_new): fool around with the
2175 2003-02-14 Havoc Pennington <hp@pobox.com>
2177 * dbus/dbus-mempool.c: fail if the debug functions so indicate
2179 * dbus/dbus-memory.c: fail if the debug functions indicate we
2182 * dbus/dbus-internals.c (_dbus_set_fail_alloc_counter)
2183 (_dbus_decrement_fail_alloc_counter): debug functions to
2184 simulate memory allocation failures
2186 2003-02-14 Havoc Pennington <hp@pobox.com>
2188 * dbus/dbus-errors.h (struct DBusError): add a word of padding
2191 2003-02-13 Anders Carlsson <andersca@codefactory.se>
2193 * bus/driver.c: (bus_driver_handle_hello):
2195 * bus/services.c: (bus_service_lookup):
2196 Reorder message sending so we get a more sane order.
2198 * test/bus-test.c: (message_handler):
2201 2003-02-13 Anders Carlsson <andersca@codefactory.se>
2203 * bus/driver.c: (bus_driver_send_service_deleted),
2204 (bus_driver_send_service_created), (bus_driver_send_service_lost),
2205 (bus_driver_send_service_acquired), (bus_driver_handle_hello),
2206 (bus_driver_send_welcome_message),
2207 (bus_driver_handle_list_services),
2208 (bus_driver_handle_acquire_service),
2209 (bus_driver_handle_service_exists):
2210 * dbus/dbus-bus.c: (dbus_bus_register_client),
2211 (dbus_bus_acquire_service), (dbus_bus_service_exists):
2212 * dbus/dbus-errors.c: (dbus_result_to_string):
2213 * dbus/dbus-errors.h:
2214 * dbus/dbus-message.c: (dbus_message_append_args),
2215 (dbus_message_append_args_valist), (dbus_message_get_args),
2216 (dbus_message_get_args_valist), (dbus_message_get_args_iter),
2217 (dbus_message_iter_get_arg_type), (dbus_message_iter_get_string),
2218 (dbus_message_iter_get_byte_array),
2219 (dbus_message_iter_get_string_array), (message_iter_test),
2220 (check_message_handling), (_dbus_message_test):
2221 * dbus/dbus-message.h:
2222 * test/bus-test.c: (main):
2223 Change fields to arguments in messages, so that they won't be
2224 confused with header fields.
2226 * glib/test-dbus-glib.c: (main):
2227 Remove append_fields from hello message.
2229 2003-02-13 Anders Carlsson <andersca@codefactory.se>
2231 * dbus/dbus-errors.c:
2232 * dbus/dbus-message.c:
2233 * dbus/dbus-string.c:
2234 Documentation fixes.
2236 2003-02-13 Anders Carlsson <andersca@codefactory.se>
2238 * glib/dbus-gmain.c: (timeout_handler), (add_timeout),
2240 Implement support for timeouts in dbus-glib.
2242 2003-02-13 Anders Carlsson <andersca@codefactory.se>
2244 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
2245 * dbus/dbus-message.c: (process_test_subdir):
2246 * test/break-loader.c: (find_breaks_based_on):
2247 Plug some memory leaks.
2249 2003-02-13 Richard Hult <rhult@codefactory.se>
2251 * bus/main.c: Fix build.
2253 * dbus/dbus-errors.h:
2254 * dbus/dbus-errors.c: Fix copyright for Anders.
2256 2003-02-13 Anders Carlsson <andersca@codefactory.se>
2261 * bus/connection.c: (bus_connection_foreach):
2264 * bus/desktop-file.c: (grow_lines_in_section), (grow_sections),
2265 (unescape_string), (new_section), (parse_section_start),
2266 (parse_key_value), (report_error), (bus_desktop_file_load),
2267 (bus_desktop_file_get_string):
2268 * bus/desktop-file.h:
2269 Use DBusError for error reporting.
2271 * bus/dispatch.c: (send_one_message),
2272 (bus_dispatch_message_handler):
2273 * bus/driver.c: (bus_driver_send_service_deleted),
2274 (bus_driver_send_service_created), (bus_driver_send_service_lost),
2275 (bus_driver_send_service_acquired), (bus_driver_handle_hello),
2276 (bus_driver_send_welcome_message),
2277 (bus_driver_handle_list_services),
2278 (bus_driver_handle_acquire_service),
2279 (bus_driver_handle_service_exists):
2280 * bus/loop.c: (bus_loop_run):
2282 Use BUS_HANDLE_OOM instead of _DBUS_HANDLE_OOM.
2284 * bus/utils.c: (bus_wait_for_memory):
2286 New files with general utility functions.
2288 * dbus/dbus-internals.h:
2289 Remove _DBUS_HANDLE_OOM.
2291 2003-02-13 Anders Carlsson <andersca@codefactory.se>
2293 * dbus/dbus-errors.c: (dbus_result_to_string), (dbus_error_init),
2294 (dbus_error_free), (dbus_set_error_const), (dbus_set_error):
2295 * dbus/dbus-errors.h:
2296 Add DBusError structure.
2298 2003-02-13 Anders Carlsson <andersca@codefactory.se>
2300 * test/data/valid-messages/standard-acquire-service.message:
2301 * test/data/valid-messages/standard-hello.message:
2302 * test/data/valid-messages/standard-list-services.message:
2303 * test/data/valid-messages/standard-service-exists.message:
2304 Add some standard messages.
2306 2003-02-13 Anders Carlsson <andersca@codefactory.se>
2308 * bus/driver.c: (bus_driver_send_welcome_message),
2309 (bus_driver_handle_list_services),
2310 (bus_driver_handle_acquire_service),
2311 (bus_driver_handle_service_exists), (bus_driver_handle_message):
2312 Update for API changes in libdbus.
2314 * dbus/dbus-message.c: (dbus_message_new_reply):
2315 * dbus/dbus-message.h:
2316 Remove the name argument. The spec states that replies shouldn't
2319 2003-02-13 Anders Carlsson <andersca@codefactory.se>
2321 * bus/desktop-file.c: (parse_section_start), (parse_key_value),
2322 (report_error), (bus_desktop_file_load), (lookup_section),
2323 (lookup_line), (bus_desktop_file_get_raw),
2324 (bus_desktop_file_get_string):
2325 * bus/desktop-file.h:
2326 Some fixes, and new functions for getting a key value from a section.
2328 2003-02-13 Havoc Pennington <hp@pobox.com>
2330 * test/data/auth/fail-after-n-attempts.auth-script: new test
2332 * dbus/dbus-auth.c (send_rejected): shutdown_mech() when we
2335 2003-02-13 Havoc Pennington <hp@pobox.com>
2337 * dbus/dbus-auth.c (handle_server_data_external_mech): args to
2338 dbus_credentials_match were backward
2340 * dbus/dbus-auth-script.c (_dbus_auth_script_run): support
2341 NO_CREDENTIALS and ROOT_CREDENTIALS
2343 * dbus/dbus-auth.c (_dbus_auth_do_work): move get_state() routine
2344 into here. Never process more commands after we've reached an
2345 end state; store further data as unused bytes.
2347 * test/data/auth/*: add more auth tests
2349 * dbus/dbus-auth-script.c (_dbus_auth_script_run): support EXPECT
2350 command to match exact string and EXPECT_UNUSED to match unused
2353 * test/Makefile.am (dist-hook): fix to dist all the test stuff
2355 2003-02-12 Havoc Pennington <hp@pobox.com>
2357 * dbus/dbus-string.c (_dbus_string_pop_line): fix to also strip
2358 \r off of popped lines
2360 * dbus/dbus-auth.c (_dbus_auth_test): write code to run auth
2363 * dbus/dbus-auth-script.c (_dbus_auth_script_run): when doing a
2366 2003-02-12 Havoc Pennington <hp@pobox.com>
2368 * dbus/Makefile.am: remove break-loader from the build, since it
2371 * configure.in: add --enable-gcov to turn on coverage profiling
2372 flags and disable optimization
2374 2003-02-10 Havoc Pennington <hp@pobox.com>
2376 * dbus/dbus-auth-script.c, dbus/dbus-auth-script.h: sync
2377 initial cut at test framework for DBusAuth from laptop.
2378 Doesn't quite work yet but it compiles and I need to get
2379 it off the 266mhz laptop. ;-)
2381 * dbus/dbus-server-debug.c (_dbus_server_debug_accept_transport):
2382 fix a memleak in error case
2384 2003-02-12 Anders Carlsson <andersca@codefactory.se>
2387 * bus/desktop-file.c:
2388 * bus/desktop-file.h:
2389 Add a desktop file parser.
2391 2003-02-11 Zack Rusin <zack@kde.org>
2393 * qt/message.[h|cpp]: sample implementation
2394 of the KDE wrapper for DBusMessage
2396 2003-02-09 Zack Rusin <zack@kde.org>
2398 * test/bus-test.c: make_it_compile
2399 * doc/dbus-specification.sgml: minimal semantic fix
2401 2003-02-06 Anders Carlsson <andersca@codefactory.se>
2407 2003-02-06 Anders Carlsson <andersca@codefactory.se>
2410 * dbus/dbus-break-loader.c:
2412 * test/break-loader.c:
2413 Move dbus-break-loader to test/ and rename it to break-loader.
2415 2003-02-02 Havoc Pennington <hp@pobox.com>
2417 * dbus/dbus-keyring.c, dbus/dbus-keyring.h: template files
2418 for code to manage cookies in your home directory
2420 * dbus/dbus-sysdeps.c (_dbus_generate_random_bytes): new function
2422 * dbus/dbus-auth.c (get_state): impose a maximum number of tries
2423 to authenticate, then disconnect the client.
2425 2003-02-03 Alexander Larsson <alexl@redhat.com>
2427 * dbus/dbus-message.c (dbus_message_append_fields):
2430 2003-02-02 Anders Carlsson <andersca@codefactory.se>
2432 * doc/dbus-specification.sgml:
2433 Update address format section.
2435 2003-02-02 Anders Carlsson <andersca@codefactory.se>
2438 * test/bus-test.c: (get_time), (add_timeout), (remove_timeout),
2439 (message_handler), (new_connection_callback), (loop_quit),
2443 2003-02-02 Anders Carlsson <andersca@codefactory.se>
2445 * bus/driver.c: (bus_driver_handle_service_exists):
2446 Simplify the code a bit.
2448 * dbus/dbus-bus.c: (dbus_bus_service_exists):
2451 2003-02-02 Anders Carlsson <andersca@codefactory.se>
2454 Add libdbus-daemon.la and link to it.
2456 2003-02-01 James Willcox <jwillcox@gnome.org>
2458 * bus/driver.c: (bus_driver_handle_own_service):
2459 Actually include the service reply code in the message.
2461 2003-02-02 Anders Carlsson <andersca@codefactory.se>
2463 * bus/driver.c: (bus_driver_handle_service_exists):
2464 Don't unref the incoming message.
2466 2003-02-02 Anders Carlsson <andersca@codefactory.se>
2468 * dbus/dbus.h: Add dbus-address.h and dbus-bus.h
2470 2003-02-02 Anders Carlsson <andersca@codefactory.se>
2472 * dbus/dbus-server.c: (dbus_server_listen):
2473 * dbus/dbus-transport.c: (_dbus_transport_open):
2474 ifdef out the calls to the debug transport and server.
2476 2003-02-02 Alexander Larsson <alexl@redhat.com>
2478 * dbus/dbus-watch.c (dbus_watch_get_flags):
2479 Add note in the docs that ERROR or HANGUP won't be returned
2480 and are assumed always on.
2482 * glib/dbus-gmain.c (add_watch):
2483 Always add IO_ERR | IO_HUP
2485 * dbus/dbus-message.h:
2486 Add semicolon after dbus_message_iter_get_string_array().
2487 Makes qt code build again
2489 2003-02-01 Anders Carlsson <andersca@codefactory.se>
2491 * bus/driver.c: (create_unique_client_name),
2492 (bus_driver_handle_hello):
2493 Don't take a name, just use a numeric id to identify
2497 * dbus/dbus-bus.c: (dbus_bus_register_client),
2498 (dbus_bus_acquire_service), (dbus_bus_service_exists):
2500 Add new convenience functions for communicating with the bus.
2502 * dbus/dbus-message.h:
2504 * dbus/dbus-protocol.h:
2507 2003-02-01 Alexander Larsson <alexl@redhat.com>
2509 * dbus/dbus-message.c (dbus_message_append_fields):
2510 Add some more doc comments.
2512 2003-02-01 Havoc Pennington <hp@pobox.com>
2514 * dbus/dbus-break-loader.c (randomly_modify_length): change
2515 a 4-byte value in the message as if it were a length
2517 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): don't set
2518 execute bit on saved files
2520 2003-02-01 Havoc Pennington <hp@pobox.com>
2522 * dbus/dbus-break-loader.c (main): new program to find messages
2523 that break the loader.
2525 * dbus/dbus-sysdeps.c (_dbus_string_append_uint): new function
2526 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): new function
2528 * dbus/dbus-string.c (_dbus_string_set_byte): new
2530 2003-01-31 Havoc Pennington <hp@pobox.com>
2532 * dbus/dbus-message.c: refactor the test code to be more general,
2533 in preparation for writing a "randomly permute test cases to
2534 try to break the loader" program.
2536 2003-01-31 Havoc Pennington <hp@pobox.com>
2538 * doc/dbus-specification.sgml: work on the specification
2540 * dbus/dbus-message.c (_dbus_message_loader_return_buffer): check
2541 the protocol version of the message.
2543 * dbus/dbus-protocol.h: drop special _REPLY names, the spec
2544 no longer specifies that.
2545 (DBUS_SERVICE_REPLY_SERVICE_EXISTS): fix flags (1/2/4/8 not
2548 * dbus/dbus-marshal.c (_dbus_marshal_get_arg_end_pos): add missing
2549 "break" for DBUS_TYPE_NIL, remove @todo
2551 2003-01-31 Havoc Pennington <hp@pobox.com>
2553 * dbus/dbus-message.c (dbus_message_set_is_error_reply): rename
2554 just set_is_error/get_is_error as this is a commonly-used
2555 function, and write docs.
2557 2003-01-31 Anders Carlsson <andersca@codefactory.se>
2559 * dbus/dbus-address.c: (dbus_address_entry_free):
2560 Free key and value lists.
2562 * dbus/dbus-internals.c: (_dbus_type_to_string):
2563 Add the types we didn't have.
2565 * dbus/dbus-marshal.c: (_dbus_marshal_get_arg_end_pos),
2566 (_dbus_marshal_validate_arg):
2569 * dbus/dbus-message.c: (dbus_message_set_sender):
2570 Remove todo about being able to set sender to NULL.
2572 (dbus_message_set_is_error_reply),
2573 (dbus_message_get_is_error_reply):
2574 * dbus/dbus-message.h:
2577 * dbus/dbus-protocol.h:
2578 Add error reply flag.
2580 * test/data/valid-messages/opposite-endian.message:
2581 Add NIL type to test.
2583 2003-01-31 Havoc Pennington <hp@pobox.com>
2585 * doc/dbus-specification.sgml: fully specify the header. Add
2586 flags and major protocol version, and change header/body len to
2589 * dbus/dbus-message-builder.c (append_saved_length): append length
2592 * dbus/dbus-message.c (dbus_message_create_header): change header
2593 length and body length to unsigned. Add the new fields from the
2595 (_dbus_message_loader_return_buffer): unsigned header/body len
2597 2003-01-30 Havoc Pennington <hp@pobox.com>
2599 * dbus/dbus-auth.c: rework to use only REJECTED, no
2602 * doc/dbus-sasl-profile.txt: drop MECHANISMS and just
2603 use REJECTED, suggested by Mark McLoughlin
2605 2003-01-30 Havoc Pennington <hp@pobox.com>
2607 * dbus/dbus-server.c (dbus_server_listen): @todo about how we need
2608 a better way to report errors here. e.g. "unix address lacks
2609 path" or something. also "no such file" when the path doesn't
2612 * dbus/dbus-address.c (dbus_address_entries_free): add @todo about
2614 (dbus_parse_address): add @todo about documenting address format,
2615 and allowing , and ; to be escaped
2617 2003-01-30 Anders Carlsson <andersca@codefactory.se>
2620 Add dbus-address.[ch]
2622 * dbus/dbus-address.c: (dbus_address_entry_free),
2623 (dbus_address_entries_free), (create_entry),
2624 (dbus_address_entry_get_method), (dbus_address_entry_get_value),
2625 (dbus_parse_address), (_dbus_address_test):
2626 * dbus/dbus-address.h:
2627 New files for dealing with address parsing.
2629 * dbus/dbus-connection.c:
2630 Document timeout functions.
2632 * dbus/dbus-message.c:
2633 Document dbus_message_new_from_message.
2635 * dbus/dbus-server-debug.c:
2638 * dbus/dbus-server.c: (dbus_server_listen):
2639 Parse address and use correct server implementation.
2641 * dbus/dbus-string.c: (_dbus_string_find_to), (_dbus_string_test):
2642 * dbus/dbus-string.h:
2643 New function with test.
2645 * dbus/dbus-test.c: (dbus_internal_symbol_do_not_use_run_tests):
2649 * dbus/dbus-transport-debug.c:
2652 * dbus/dbus-transport.c: (_dbus_transport_open):
2653 Parse address and use correct transport implementation.
2655 2003-01-30 Havoc Pennington <hp@pobox.com>
2657 * dbus/dbus-message.c: use message->byte_order instead of
2658 DBUS_COMPILER_BYTE_ORDER throughout.
2659 (dbus_message_create_header): pad header to align the
2660 start of the body of the message to 8-byte boundary
2662 * dbus/dbus-marshal.h: make all the demarshalers take const
2663 DBusString arguments.
2665 * dbus/dbus-message.c (_dbus_message_loader_return_buffer):
2666 validate message args here, so we don't have to do slow validation
2667 later, and so we catch bad messages as they are incoming. Also add
2668 better checks on header_len and body_len. Also fill in
2671 * dbus/dbus-string.c (_dbus_string_validate_utf8): new (not
2672 implemented properly)
2673 (_dbus_string_validate_nul): new function to check all-nul
2675 * dbus/dbus-marshal.c (_dbus_marshal_get_field_end_pos): rename
2676 get_arg_end_pos and remove all validation
2677 (_dbus_marshal_validate_arg): actually do validation here.
2679 2003-01-29 Havoc Pennington <hp@pobox.com>
2681 * dbus/dbus-message.c (check_message_handling): fix assertion
2682 failure on set_client_serial
2684 2003-01-28 Havoc Pennington <hp@pobox.com>
2686 * dbus/dbus-server-debug.c: Add doc section comments
2688 * dbus/dbus-transport-debug.c: add doc section comments
2690 2003-01-28 Havoc Pennington <hp@redhat.com>
2692 * dbus/dbus-string.c (_dbus_string_base64_decode): append bytes in
2693 the reverse order from how I had it
2694 (_dbus_string_base64_encode): reverse encoding order. I was
2695 basically byteswapping everything during encoding.
2697 2003-01-28 Anders Carlsson <andersca@codefactory.se>
2699 * dbus/dbus-connection-internal.h:
2700 * dbus/dbus-connection.c: (_dbus_connection_add_timeout),
2701 (_dbus_connection_remove_timeout):
2702 Add functions for adding and removing timeouts.
2704 * dbus/dbus-message.c: (dbus_message_new_from_message):
2705 Add new function that takes a message and creates an exact
2706 copy of it, but with the refcount set to 1.
2707 (check_message_handling):
2710 * dbus/dbus-server-protected.h:
2711 * dbus/dbus-server.c: (_dbus_server_init_base),
2712 (_dbus_server_finalize_base), (_dbus_server_add_timeout),
2713 (dbus_server_set_timeout_functions):
2714 (_dbus_server_remove_timeout):
2715 New functions so that a server can add and remove timeouts.
2717 (dbus_server_listen):
2718 Add commented out call to dbus_server_debug_new.
2720 * dbus/dbus-timeout.c: (_dbus_timeout_new):
2721 Actually set the handler, doh.
2723 * dbus/dbus-transport.c: (_dbus_transport_open):
2724 Add commented out call to dbus_transport_debug_client_new.
2727 Add dbus-transport-debug.[ch] and dbus-server-debug.[ch]
2729 2003-01-28 Havoc Pennington <hp@pobox.com>
2731 * dbus/dbus-message.c (check_message_handling): function to check
2732 on the loaded message, iterates over it etc.
2734 2003-01-28 Havoc Pennington <hp@pobox.com>
2736 * test/Makefile.am (dist-hook): fix make distdir
2738 * dbus/Makefile.am (TESTS_ENVIRONMENT): fix make check
2740 2003-01-27 Havoc Pennington <hp@pobox.com>
2742 * dbus/dbus-mempool.c (time_for_size): replace printf with
2745 * dbus/dbus-message-builder.c (_dbus_message_data_load): allow
2746 empty lines; fix the SAVE_LENGTH stuff to be
2747 START_LENGTH/END_LENGTH so it actually works; couple other
2750 * test/Makefile.am (dist-hook): add dist-hook for .message files
2752 * dbus/dbus-string.c (DBUS_STRING_COPY_PREAMBLE): source of a copy
2753 can be constant or locked.
2754 (_dbus_string_free): allow freeing a const string as
2757 * dbus/dbus-sysdeps.c (_dbus_concat_dir_and_file): utility
2759 * dbus/dbus-test-main.c (main): take an argument which is the
2760 directory containing test data
2762 * dbus/dbus-message.c (_dbus_message_test): pass a test_data_dir
2763 argument to this and load all the messages in test/data/
2764 checking that they can be loaded or not loaded as appropriate.
2766 2003-01-27 Anders Carlsson <andersca@codefactory.se>
2768 * bus/dispatch.c: (bus_dispatch_message_handler):
2769 Dispatch messages sent to services.
2771 * bus/driver.c: (bus_driver_send_service_deleted),
2772 (bus_driver_send_service_created), (bus_driver_send_service_lost),
2773 (bus_driver_send_service_acquired):
2774 Add helper functions for sending service related messages.
2776 (bus_driver_send_welcome_message):
2777 Send HELLO_REPLY instead of WELCOME.
2779 (bus_driver_handle_list_services):
2780 Send LIST_SERVICES_REPLY instead of SERVICES.
2782 (bus_driver_handle_own_service),
2783 (bus_driver_handle_service_exists):
2784 New message handlers.
2786 (bus_driver_handle_message):
2787 Invoke new message handlers.
2789 (bus_driver_remove_connection):
2790 Don't remove any services here since that's done automatically
2791 by bus_service_remove_owner now.
2794 New function signatures.
2796 * bus/services.c: (bus_service_add_owner):
2797 Send ServiceAcquired message if we're the only primary owner.
2799 (bus_service_remove_owner):
2800 Send ServiceAcquired/ServiceLost messages.
2802 (bus_service_set_prohibit_replacement),
2803 (bus_service_get_prohibit_replacement):
2804 Functions for setting prohibit replacement.
2806 (bus_service_has_owner):
2807 New function that checks if a connection is in the owner queue of
2811 Add new function signatures.
2813 * dbus/dbus-list.c: (_dbus_list_test):
2814 Add tests for _dbus_list_remove_last and traversing the list backwards.
2817 Fix a typo in _dbus_list_get_prev_link, if we're at the first element we can't
2818 go any further, so return NULL then.
2820 * dbus/dbus-protocol.h:
2821 Add new messages, service flags and service replies.
2823 2003-01-26 Havoc Pennington <hp@pobox.com>
2825 * dbus/dbus-message-builder.c: implement, completely untested.
2827 * test/data/*: add data to be used in testing.
2828 ".message" files are our simple loadable text format.
2829 ".message-raw" will be binary dumps of messages.
2831 * dbus/dbus-string.c (_dbus_string_starts_with_c_str): new
2833 2003-01-26 Havoc Pennington <hp@pobox.com>
2835 * dbus/dbus-sysdeps.c (_dbus_file_get_contents): new function
2837 * dbus/dbus-errors.c (dbus_result_to_string): add
2840 * dbus/dbus-message-builder.c: new file, will contain code to load
2841 up messages from files. Not implemented yet.
2843 2003-01-26 Havoc Pennington <hp@pobox.com>
2845 * dbus/dbus-message.c (dbus_message_set_sender): support deleting
2846 the sender by setting to NULL
2848 2003-01-26 Havoc Pennington <hp@pobox.com>
2850 The unit tests pass, but otherwise untested. If it breaks, the
2851 tests should have been better. ;-)
2853 * bus/driver.c (bus_driver_handle_hello): return if we disconnect
2856 * dbus/dbus-message.c: redo everything so we maintain
2857 message->header as the only copy of the various fields.
2858 This avoids the possibility of out-of-memory in some cases,
2859 for example dbus_message_lock() can't run out of memory anymore,
2860 and avoids extra copying. Figured I may as well go ahead and do
2861 this since it was busted for dbus_message_lock to not return
2862 failure on OOM, and dbus_message_write_header was totally
2863 unchecked for OOM. Also fixed some random other bugs.
2865 * dbus/dbus-marshal.c (_dbus_marshal_get_field_end_pos): verify
2866 that strings are nul-terminated. Also, end_pos can be equal
2867 to string length just not greater than, I think.
2868 (_dbus_marshal_set_int32): new function
2869 (_dbus_marshal_set_uint32): new function
2870 (_dbus_marshal_set_string): new function
2872 * dbus/dbus-connection.c (_dbus_connection_new_for_transport): fix
2873 a warning, init timeout_list to NULL
2874 (dbus_connection_send_message): don't use uninitialized variable
2877 * dbus/dbus-string.c (_dbus_string_replace_len): new function
2879 2003-01-26 Anders Carlsson <andersca@codefactory.se>
2881 * bus/driver.c: (bus_driver_handle_hello),
2882 (bus_driver_send_welcome_message):
2885 2003-01-26 Anders Carlsson <andersca@codefactory.se>
2887 * dbus/dbus-auth.c: (process_auth), (_dbus_auth_unref):
2888 * dbus/dbus-connection.c: (_dbus_connection_new_for_transport),
2889 (dbus_connection_unref):
2890 * dbus/dbus-marshal.c: (_dbus_marshal_test):
2891 * dbus/dbus-message.c: (dbus_message_unref),
2894 (dbus_message_get_fields):
2895 Remove debugging printout.
2897 (_dbus_message_loader_return_buffer):
2898 Don't store the header string.
2900 (_dbus_message_test):
2903 2003-01-26 Richard Hult <rhult@codefactory.se>
2905 * glib/dbus-gmain.c (dbus_connection_dispatch): Traverse a copy of
2906 the file descriptor list, since it can change under us.
2908 2003-01-25 Anders Carlsson <andersca@codefactory.se>
2910 * glib/dbus-gmain.c: (dbus_connection_prepare),
2911 (dbus_connection_check), (dbus_connection_dispatch), (add_watch),
2912 (remove_watch), (dbus_connection_hookup_with_g_main):
2913 Rewrite the glib handling to use its own GSource instead of a
2914 GIOChannel so we can catch messages put in the queue while waiting
2917 2003-01-25 Anders Carlsson <andersca@codefactory.se>
2920 * bus/connection.c: (connection_disconnect_handler),
2921 (connection_watch_callback), (bus_connection_setup):
2922 * bus/dispatch.c: (send_one_message),
2923 (bus_dispatch_broadcast_message), (bus_dispatch_message_handler),
2924 (bus_dispatch_add_connection), (bus_dispatch_remove_connection):
2926 * bus/driver.c: (bus_driver_send_service_deleted),
2927 (bus_driver_send_service_created), (bus_driver_handle_hello),
2928 (bus_driver_send_welcome_message),
2929 (bus_driver_handle_list_services), (bus_driver_remove_connection),
2930 (bus_driver_handle_message):
2932 Refactor code, put the message dispatching in its own file. Use
2933 _DBUS_HANDLE_OOM. Also send ServiceDeleted messages when a client
2936 2003-01-25 Anders Carlsson <andersca@codefactory.se>
2938 * dbus/dbus-internals.h:
2939 Add _DBUS_HANDLE_OOM macro, it doesn't do anything currently.
2941 * dbus/dbus-message.c: (dbus_message_get_sender):
2942 * dbus/dbus-message.h:
2943 Implement dbus_message_get_sender.
2945 * dbus/dbus-protocol.h:
2946 Add message and service defines.
2948 2003-01-25 Anders Carlsson <andersca@codefactory.se>
2950 * dbus/dbus-connection.c: (dbus_connection_send_message):
2951 * dbus/dbus-message-internal.h:
2952 * dbus/dbus-message.c: (_dbus_message_get_client_serial),
2953 (dbus_message_write_header):
2954 Remove _dbus_messag_unlock and don't set the client serial on a
2955 message if one already exists.
2957 2003-01-24 Havoc Pennington <hp@pobox.com>
2959 * dbus/dbus-list.c (alloc_link): put a thread lock on the global
2962 * bus/driver.c (bus_driver_handle_list_services): fix a leak
2965 2003-01-25 Anders Carlsson <andersca@codefactory.se>
2967 * dbus/dbus-list.c: (alloc_link), (free_link):
2968 Use a memory pool for the links.
2970 2003-01-25 Anders Carlsson <andersca@codefactory.se>
2972 * bus/connection.c: (bus_connection_foreach):
2974 Add new bus_connection_foreach function.
2976 * bus/driver.c: (send_one_message), (bus_driver_broadcast_message):
2977 Add function that broadcasts a message to all clients.
2979 (bus_driver_send_service_created), (bus_driver_handle_hello),
2980 (bus_driver_send_welcome_message),
2981 (bus_driver_handle_list_services), (bus_driver_message_handler):
2982 Implement functions that take care of listing services, and notifying
2983 clients when new services are created.
2985 * bus/services.c: (bus_services_list):
2987 Add new function that returns an array of strings with the currently
2988 registered services.
2991 * glib/dbus-gmain.c:
2992 Update copyright year.
2994 2003-01-25 Anders Carlsson <andersca@codefactory.se>
2996 * dbus/dbus-connection.c: (dbus_connection_send_message):
2997 Unlock the message in case it was sent earlier.
2999 (dbus_connection_send_message_with_reply_and_block):
3000 Remove the reply message from the list.
3002 * dbus/dbus-marshal.c: (_dbus_demarshal_string_array):
3003 Set array_len and new_pos correctly.
3005 (_dbus_marshal_test):
3006 Remove debug output.
3008 * dbus/dbus-message-internal.h:
3009 * dbus/dbus-message.c: (_dbus_message_get_reply_serial):
3010 New function that returns the reply serial.
3012 (_dbus_message_unlock):
3013 New function that unlocks a message and resets its header.
3015 (dbus_message_append_string_array),
3016 (dbus_message_get_fields_valist),
3017 (dbus_message_iter_get_field_type),
3018 (dbus_message_iter_get_string_array),
3019 (dbus_message_get_fields),
3020 (dbus_message_append_fields_valist):
3021 Handle string arrays.
3023 (dbus_message_set_sender):
3024 Make this function public since the bus daemon needs it.
3026 (decode_header_data):
3027 Set the reply serial to -1 initially.
3029 * dbus/dbus-message.h:
3030 Add dbus_message_set_sender.
3032 2003-01-24 Havoc Pennington <hp@pobox.com>
3034 * doc/dbus-specification.sgml: add some stuff
3036 2003-01-22 Havoc Pennington <hp@pobox.com>
3038 * doc/dbus-specification.sgml: Start to document the protocol.
3040 2003-01-22 Havoc Pennington <hp@pobox.com>
3042 * dbus/dbus-connection.c
3043 (dbus_connection_send_message_with_reply_and_block): add some @todo
3045 * bus/driver.c (bus_driver_add_connection): add a FIXME about memleak
3047 2003-01-21 Havoc Pennington <hp@pobox.com>
3049 (patch untested because can't compile)
3051 * bus/driver.c (create_unique_client_name): make this function
3052 never recycle client names. Also, caller should initialize
3055 * dbus/dbus-sysdeps.c (_dbus_get_current_time): new function
3057 2003-01-21 Anders Carlsson <andersca@codefactory.se>
3059 * dbus/dbus-marshal.c: (_dbus_marshal_double),
3060 (_dbus_marshal_int32), (_dbus_marshal_uint32),
3061 (_dbus_marshal_int32_array), (_dbus_marshal_uint32_array),
3062 (_dbus_marshal_double_array), (_dbus_marshal_string_array),
3063 (_dbus_demarshal_int32_array), (_dbus_demarshal_uint32_array),
3064 (_dbus_demarshal_double_array), (_dbus_demarshal_string_array),
3065 (_dbus_marshal_get_field_end_pos), (_dbus_marshal_test):
3066 * dbus/dbus-marshal.h:
3067 * dbus/dbus-protocol.h:
3068 Add support for marshalling and demarshalling integer, double
3071 2003-01-21 Anders Carlsson <andersca@codefactory.se>
3076 * bus/connection.c: (connection_disconnect_handler):
3077 Remove the connection from the bus driver's list.
3079 (connection_watch_callback): Dispatch messages.
3081 (free_connection_data): Free connection name.
3083 (bus_connection_setup): Add connection to the bus driver's list.
3084 (bus_connection_remove_owned_service):
3085 (bus_connection_set_name), (bus_connection_get_name):
3086 Add functions for setting and getting the connection's name.
3089 Add function headers.
3091 * bus/driver.c: (create_unique_client_name),
3092 (bus_driver_handle_hello_message),
3093 (bus_driver_send_welcome_message), (bus_driver_message_handler),
3094 (bus_driver_add_connection), (bus_driver_remove_connection):
3097 * bus/services.c: (bus_service_free):
3099 New file that handles communication and registreation with the bus
3102 2003-01-21 Anders Carlsson <andersca@codefactory.se>
3104 * dbus/dbus-connection.c: (dbus_connection_send_message):
3105 Add a new client_serial parameter.
3107 (dbus_connection_send_message_with_reply):
3108 Remove a @todo since we've implemented the blocking function.
3110 (dbus_connection_send_message_with_reply_and_block):
3111 New function that sends a message and waits for a reply and
3112 then returns the reply.
3114 * dbus/dbus-connection.h:
3117 * dbus/dbus-errors.c: (dbus_result_to_string):
3118 * dbus/dbus-errors.h:
3119 Add new DBUS_RESULT.
3121 * dbus/dbus-message-internal.h:
3122 * dbus/dbus-message.c: (_dbus_message_get_reply_serial),
3123 (_dbus_message_set_sender), (dbus_message_write_header),
3124 (dbus_message_new_reply), (decode_header_data),
3125 (_dbus_message_loader_return_buffer), (_dbus_message_test):
3126 * dbus/dbus-message.h:
3127 Add new functions that set the reply serial and sender.
3128 Also marshal and demarshal them correctly and add test.
3130 * dbus/dbus-protocol.h:
3131 Add new DBUS_MESSAGE_TYPE_SENDER.
3134 * glib/dbus-gmain.c: (watch_callback), (free_callback_data),
3135 (add_watch), (remove_watch), (add_timeout), (remove_timeout),
3136 (dbus_connection_hookup_with_g_main):
3137 * glib/test-dbus-glib.c: (main):
3138 Rewrite to use GIOChannel and remove the GSource crack.
3140 * test/echo-client.c: (main):
3141 * test/watch.c: (check_messages):
3142 Update for changed APIs
3144 2003-01-19 Anders Carlsson <andersca@codefactory.se>
3146 * dbus/Makefile.am: Add dbus-timeout.[cħ]
3148 * dbus/dbus-connection.c: (_dbus_connection_new_for_transport):
3149 Create a DBusTimeoutList.
3150 (dbus_connection_set_timeout_functions): Add new function to
3151 set timeout callbacks
3153 * dbus/dbus-connection.h: Add public DBusTimeout API.
3155 * dbus/dbus-message.c: (dbus_message_get_service):
3156 * dbus/dbus-message.h: New function.
3158 * dbus/dbus-server.c: Fix small doc typo.
3160 * dbus/dbus-timeout.[ch]: New files for mainloop timeouts.
3162 2003-01-19 Anders Carlsson <andersca@codefactory.se>
3164 * dbus/dbus-string.c (_dbus_string_move_len): Don't delete all
3165 of the string, just as long as specified.
3167 2003-01-19 Havoc Pennington <hp@pobox.com>
3169 * dbus/dbus-connection.c (dbus_connection_get_is_authenticated):
3172 * dbus/dbus-server.c (dbus_server_set_max_connections)
3173 (dbus_server_get_max_connections, dbus_server_get_n_connections):
3174 keep track of current number of connections, and add API for
3175 setting a max (but haven't implemented enforcing the max yet)
3177 2003-01-18 Havoc Pennington <hp@pobox.com>
3179 * dbus/dbus-transport-unix.c (unix_do_iteration): only do the
3180 reading/writing if read_watch != NULL or write_watch != NULL.
3182 * dbus/dbus-message.c (_dbus_message_loader_return_buffer): fix
3183 the message loader code to actually load message->header and
3184 message->body into the newly-created message.
3186 * dbus/dbus-transport-unix.c (check_write_watch): fix a mem leak
3189 * dbus/dbus-connection.c (dbus_connection_set_max_message_size)
3190 (dbus_connection_get_max_message_size)
3191 (dbus_connection_set_max_live_messages_size)
3192 (dbus_connection_get_max_live_messages_size): implement some
3193 resource limitation functions
3195 * dbus/dbus-resources.c: new file implementing some of the
3196 resource limits stuff
3198 * dbus/dbus-message.c (dbus_message_iter_get_byte_array): add
3199 missing docs, add @todo to handle OOM etc.
3201 * dbus/dbus-marshal.c (_dbus_demarshal_byte_array): add missing
3204 2003-01-18 Havoc Pennington <hp@pobox.com>
3206 * dbus/dbus-connection.c (dbus_connection_unref): disconnect the
3207 connection if it hasn't been already.
3209 * dbus/dbus-connection.h: kill off the idea of an ErrorFunction,
3210 replace with DisconnectFunction.
3212 2003-01-18 Havoc Pennington <hp@pobox.com>
3214 Building --disable-verbose-mode --disable-asserts --disable-tests
3215 cuts the library from 112K to 45K or so
3217 * configure.in: check for varargs macro support,
3218 add --enable-verbose-mode, --enable-asserts.
3220 * dbus/dbus-internals.h (_dbus_assert): support
3222 (_dbus_verbose): support DBUS_ENABLE_VERBOSE_MODE
3224 2003-01-18 Havoc Pennington <hp@pobox.com>
3226 * dbus/dbus-test.c: include config.h so that tests actually run
3228 * dbus/dbus-string.c: add assertions that stuff is 8-byte aligned,
3229 so the failure mode when that assumption fails will be plenty
3232 2003-01-18 Havoc Pennington <hp@pobox.com>
3234 * configure.in: default --enable-tests to $USE_MAINTAINER_MODE
3236 * dbus/Makefile.am: fix it up so dubs-test-main.c is included in
3239 * test/Makefile.am: don't use special variable "TESTS" for echo-*
3240 since we don't want to use those in make check
3242 2003-01-15 Havoc Pennington <hp@redhat.com>
3248 2003-01-15 Havoc Pennington <hp@redhat.com>
3250 * test/Makefile.am: fix so that test source code ends up in the
3251 distribution on make distcheck
3253 2003-01-15 Havoc Pennington <hp@redhat.com>
3259 2003-01-15 Havoc Pennington <hp@redhat.com>
3261 * dbus/dbus-test.c (dbus_internal_symbol_do_not_use_run_tests):
3262 fix build when --disable-tests
3264 * Makefile.am (EXTRA_DIST): put HACKING in here
3266 * HACKING: document procedure for making a tarball release.
3268 2003-01-14 Anders Carlsson <andersca@codefactory.se>
3270 * bus/connection.c: (connection_error_handler),
3271 (bus_connection_setup):
3272 * bus/main.c: (main):
3273 Make sure that the DBusConnectionData struct is NULLed
3274 out to prevent a segfault.
3276 * dbus/dbus-errors.c: (dbus_result_to_string):
3277 * dbus/dbus-errors.h:
3278 * dbus/dbus-message.c: (dbus_message_get_fields),
3279 (dbus_message_get_fields_valist), (_dbus_message_test):
3280 * dbus/dbus-message.h:
3281 Make dbus_message_get_fields return a result code so we can
3282 track invalid fields as well as oom.
3284 2003-01-11 Havoc Pennington <hp@pobox.com>
3286 * configure.in: change --enable-test/--enable-ansi action-if-given
3287 to enable_foo=$enableval instead of enable_foo=yes
3289 2003-01-08 Havoc Pennington <hp@pobox.com>
3291 * dbus/dbus-string.c (_dbus_string_align_length): new function
3293 * dbus/dbus-test-main.c: move main() for test app here
3295 (dbus_internal_symbol_do_not_use_run_tests): we have to export a
3296 symbol to run tests, because dbus-test isn't in the main
3299 Code review nitpicks.
3301 * dbus/dbus-message.c (dbus_message_write_header): add newlines
3302 for people with narrow emacs ;-). Assert client_serial was filled
3303 in. Assert message->name != NULL.
3304 (dbus_message_append_fields): have "first_field_type" arg separate
3305 from va list, needed for C++ binding that also uses varargs IIRC
3306 and helps with type safety
3307 (dbus_message_new): add @todo about using DBusString to store
3308 service/name internally
3309 (dbus_message_new): don't leak ->service and ->name on OOM later
3311 (dbus_message_unref): free the service name
3312 (dbus_message_get_fields): same change to varargs
3313 i.e. first_field_type
3314 (_dbus_message_loader_return_buffer): assert that the message data
3315 is aligned (if not it's a bug in our code). Put in verbose griping
3316 about why we set corrupted = TRUE.
3317 (decode_header_data): add FIXME that char* is evil. Was going to
3318 add FIXME about evil locale-specific string.h strncmp, but just
3319 switched to wacky string-as-uint32 optimization. Move check for
3320 "no room for field name" above get_const_data_len() to avoid
3321 assertion failure in get_const_data_len if we have trailing 2
3322 bytes or the like. Check for service and name fields being
3323 provided twice. Don't leak service/name on error. Require field
3324 names to be aligned to 4 bytes.
3326 * dbus/dbus-marshal.c: move byte swap stuff to header
3327 (_dbus_pack_int32): uscore-prefix
3328 (_dbus_unpack_int32): uscore-prefix
3329 (_dbus_unpack_uint32): export
3330 (_dbus_demarshal_string): add @todo complaining about use of
3332 (_dbus_marshal_get_field_end_pos): add @todo about bad error
3333 handling allowing corrupt data to go unchecked
3335 2003-01-08 Havoc Pennington <hp@redhat.com>
3337 * dbus/dbus-transport-unix.c (unix_do_iteration): add read/write
3338 to the select() as needed for authentication. (should be using
3339 _dbus_poll() not select, but for another day)
3341 * dbus/dbus.h: include dbus/dbus-protocol.h
3343 2003-01-08 Anders Carlsson <andersca@codefactory.se>
3345 * dbus/Makefile.am (dbusinclude_HEADERS): Install
3348 2003-01-08 Anders Carlsson <andersca@codefactory.se>
3350 * dbus/dbus-internals.c: (_dbus_type_to_string):
3351 New function that returns a string describing a type.
3353 * dbus/dbus-marshal.c: (_dbus_demarshal_byte_array):
3354 * dbus/dbus-marshal.h:
3355 * dbus/dbus-message.c: (dbus_message_get_fields_valist),
3356 (dbus_message_iter_get_field_type), (dbus_message_iter_get_double),
3357 (dbus_message_iter_get_byte_array):
3358 * dbus/dbus-message.h:
3359 Add new convenience functions for appending and getting message fields.
3360 Also add demarshalling routines for byte arrays.
3362 2003-01-07 Anders Carlsson <andersca@codefactory.se>
3364 * dbus/dbus-connection-internal.h:
3365 * dbus/dbus-connection.c: (_dbus_connection_new_for_transport),
3366 (_dbus_connection_get_next_client_serial),
3367 (dbus_connection_send_message):
3368 * dbus/dbus-internals.h:
3369 * dbus/dbus-marshal.c: (unpack_uint32), (dbus_unpack_int32),
3370 (dbus_pack_int32), (_dbus_marshal_double), (_dbus_marshal_int32),
3371 (_dbus_marshal_uint32), (_dbus_demarshal_double),
3372 (_dbus_demarshal_int32), (_dbus_demarshal_uint32),
3373 (_dbus_demarshal_string), (_dbus_marshal_get_field_end_pos),
3374 (_dbus_verbose_bytes), (_dbus_marshal_test):
3375 * dbus/dbus-marshal.h:
3376 * dbus/dbus-message-internal.h:
3377 * dbus/dbus-message.c: (_dbus_message_set_client_serial),
3378 (dbus_message_write_header), (_dbus_message_lock),
3379 (dbus_message_new), (dbus_message_ref), (dbus_message_unref),
3380 (dbus_message_get_name), (dbus_message_append_int32),
3381 (dbus_message_append_uint32), (dbus_message_append_double),
3382 (dbus_message_append_string), (dbus_message_append_byte_array),
3383 (dbus_message_get_fields_iter), (dbus_message_iter_ref),
3384 (dbus_message_iter_unref), (dbus_message_iter_has_next),
3385 (dbus_message_iter_next), (dbus_message_iter_get_field_type),
3386 (dbus_message_iter_get_string), (dbus_message_iter_get_int32),
3387 (dbus_message_iter_get_uint32), (dbus_message_iter_get_double),
3388 (decode_header_data), (_dbus_message_loader_return_buffer),
3389 (message_iter_test), (_dbus_message_test):
3390 * dbus/dbus-message.h:
3391 * dbus/dbus-protocol.h:
3392 * dbus/dbus-test.c: (main):
3394 * glib/test-dbus-glib.c: (message_handler), (main):
3395 * test/echo-client.c: (main):
3396 * test/watch.c: (check_messages):
3397 Make messages sendable and receivable for real.
3399 2003-01-07 Anders Carlsson <andersca@codefactory.se>
3401 * dbus/dbus-marshal.c: (_dbus_marshal_double),
3402 (_dbus_marshal_string), (_dbus_marshal_byte_array):
3403 * dbus/dbus-message.c: (dbus_message_append_int32),
3404 (dbus_message_append_uint32), (dbus_message_append_double),
3405 (dbus_message_append_string), (dbus_message_append_byte_array):
3406 Handle OOM restoration.
3408 2003-01-07 Anders Carlsson <andersca@codefactory.se>
3410 * dbus/dbus-marshal.c: (_dbus_marshal_string),
3411 (_dbus_demarshal_string), (_dbus_marshal_test):
3412 * dbus/dbus-marshal.h:
3413 * dbus/dbus-message.c: (dbus_message_get_name),
3414 Document these functions.
3416 (dbus_message_append_int32), (dbus_message_append_uint32),
3417 (dbus_message_append_double), (dbus_message_append_string),
3418 (dbus_message_append_byte_array):
3419 * dbus/dbus-message.h:
3420 Add functions for adding message fields of different types.
3422 * dbus/dbus-protocol.h:
3423 Add the different types.
3425 2003-01-05 Havoc Pennington <hp@pobox.com>
3427 * bus/connection.c: implement routines for handling connections,
3428 first thing is keeping a list of owned services on each connection
3429 and setting up watches etc.
3431 * bus/services.c: implement a mapping from service names to lists
3434 * dbus/dbus-hash.c: add DBUS_HASH_POINTER
3436 * dbus/dbus-threads.c (dbus_static_mutex_lock): add functions
3437 to use static mutexes for global data
3439 * dbus/dbus-connection.c (dbus_connection_set_data): add new
3440 collection of functions to set/get application-specific data
3441 on the DBusConnection.
3443 2003-01-04 Havoc Pennington <hp@pobox.com>
3445 * dbus/dbus-sysdeps.c (_dbus_sleep_milliseconds): new function
3446 (_dbus_poll): new function
3448 * dbus/dbus-internals.h (_DBUS_STRUCT_OFFSET): new macro
3451 * bus/loop.c: initial code for the daemon main loop
3453 2003-01-04 Havoc Pennington <hp@pobox.com>
3455 * test/watch.c (error_handler): make it safe if the error handler
3456 is called multiple times (if we s/error handler/disconnect
3457 handler/ we should just guarantee it's called only once)
3459 * dbus/dbus-transport.c (_dbus_transport_disconnect): call the
3460 error handler on disconnect (it's quite possible we should
3461 just change the error handler to a "disconnect handler," I'm
3462 not sure we have any other meaningful errors)
3464 * configure.in: check for getpwnam_r
3466 * dbus/dbus-transport.c, dbus/dbus-transport-unix.c,
3467 dbus/dbus-auth.c: add credentials support, add EXTERNAL auth
3468 mechanism as in SASL spec, using socket credentials
3470 * dbus/dbus-sysdeps.c (_dbus_read_credentials_unix_socket): new function
3471 (_dbus_send_credentials_unix_socket): new function
3473 * dbus/dbus-sysdeps.c (_dbus_accept_unix_socket): rename just
3475 (_dbus_write): only check errno if <0 returned
3476 (_dbus_write_two): ditto
3478 2003-01-02 Anders Carlsson <andersca@codefactory.se>
3480 * dbus/dbus-marshal.c: (_dbus_marshal_utf8_string),
3481 (_dbus_marshal_byte_array), (_dbus_demarshal_utf8_string),
3482 (_dbus_marshal_test):
3483 * dbus/dbus-marshal.h:
3484 Add _dbus_marshal_byte_array and rename _dbus_marshal_string
3485 to _dbus_marshal_utf8_string. Also fix some tests.
3487 2002-12-28 Harri Porten <porten@kde.org>
3489 * configure.in: added check for C++ compiler and a very cheesy
3490 check for the Qt integration
3492 * Makefile.am (SUBDIRS): compile qt subdir if support is enabled
3494 * qt/Makefile.am: added
3496 * qt/.cvsignore: added
3498 * qt/dbus-qthread.cc, qt/dbus-qthread.cpp: renamed former to
3499 latter, added #ifdef QT_THREAD_SUPPORT guard.
3501 * dbus/Makefile.am: added missing headers for make dist
3503 2002-12-28 Kristian Rietveld <kris@gtk.org>
3505 * dbus/Makefile.am: fixup export-symbols-regex.
3507 2002-12-27 Anders Carlsson <andersca@codefactory.se>
3509 * acinclude.m4: Add this file and put the
3510 PKG_CHECK_MODULE macro in it.
3512 2002-12-27 Anders Carlsson <andersca@codefactory.se>
3514 * dbus/dbus-marshal.c: (_dbus_marshal_string),
3515 (_dbus_demarshal_double), (_dbus_demarshal_int32),
3516 (_dbus_demarshal_uint32), (_dbus_demarshal_string),
3517 (_dbus_marshal_test):
3518 Make the demarshalling routines align the pos argument.
3519 Add string marshalling tests and fix the obvious bugs
3522 2002-12-26 Havoc Pennington <hp@pobox.com>
3524 * dbus/dbus-auth.c: fixes fixes fixes
3526 * dbus/dbus-transport-unix.c: wire up support for
3527 encoding/decoding data on the wire
3529 * dbus/dbus-auth.c (_dbus_auth_encode_data)
3530 (_dbus_auth_decode_data): append to target string
3531 instead of nuking it.
3533 2002-12-26 Havoc Pennington <hp@pobox.com>
3535 * dbus/dbus-marshal.h (DBUS_COMPILER_BYTE_ORDER): #ifdef
3536 WORDS_BIGENDIAN then compiler byte order is DBUS_BIG_ENDIAN,
3539 * dbus/dbus-marshal.c: Add macros to do int swapping in-place and
3540 avoid swap_bytes() overhead (ignoring possible assembly stuff for
3541 now). Main point is because I wanted unpack_uint32 to implement
3543 (_dbus_verbose_bytes): new function
3545 * dbus/dbus-string.c (_dbus_string_validate_ascii): new function
3547 * dbus/dbus-message.c (_dbus_message_loader_get_is_corrupted): add
3548 mechanism to handle a corrupt message stream
3549 (_dbus_message_loader_new): fix preallocation to only prealloc,
3552 * dbus/dbus-string.c (_dbus_string_skip_blank): fix this function
3553 (_dbus_string_test): enhance tests for copy/move and fix the
3556 * dbus/dbus-transport-unix.c: Hold references in more places to
3557 avoid reentrancy problems
3559 * dbus/dbus-transport.c: ditto
3561 * dbus/dbus-connection.c (dbus_connection_dispatch_message): don't
3562 leak reference count in no-message case
3564 * test/watch.c (do_mainloop): handle adding/removing watches
3565 during iteration over the watches. Also, ref the connection/server
3566 stored on a watch, so we don't try to mangle a destroyed one.
3568 * dbus/dbus-transport-unix.c (do_authentication): perform
3571 * dbus/dbus-auth.c (get_state): add a state
3572 AUTHENTICATED_WITH_UNUSED_BYTES and return it if required
3573 (_dbus_auth_get_unused_bytes): append the unused bytes
3574 to the passed in string, rather than prepend
3576 * dbus/dbus-transport.c (_dbus_transport_init_base): create
3577 the auth conversation DBusAuth
3579 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_fd)
3580 (_dbus_transport_new_for_domain_socket): when creating a
3581 transport, pass in whether it's a client-side or server-side
3582 transport so we know which DBusAuth to create
3584 2002-12-03 Havoc Pennington <hp@pobox.com>
3586 * dbus/dbus-transport-unix.c (unix_finalize): finalize base
3587 _after_ finalizing the derived members
3588 (unix_connection_set): unref watch if we fail to add it
3590 * dbus/dbus-connection.c (dbus_connection_unref): delete the
3591 transport first, so that the connection owned by the
3592 transport will be valid as the transport finalizes.
3594 * dbus/dbus-transport-unix.c (unix_finalize): free the write_watch
3595 if necessary, and remove watches from the connection.
3597 * dbus/dbus-watch.c (_dbus_watch_list_free): improve a comment
3599 2002-12-26 Anders Carlsson <andersca@codefactory.se>
3601 * dbus/dbus-marshal.c: (_dbus_marshal_string),
3602 (_dbus_demarshal_double), (_dbus_demarshal_int32),
3603 (_dbus_demarshal_uint32), (_dbus_demarshal_string),
3604 (_dbus_marshal_test):
3605 * dbus/dbus-marshal.h:
3606 Add string marshal functions and have the demarshal functions
3607 return the new position.
3609 2002-12-25 Havoc Pennington <hp@pobox.com>
3611 * doc/dbus-sasl-profile.txt: docs on the authentication protocol,
3612 it is a simple protocol that just maps directly to SASL.
3614 * dbus/dbus-auth.h, dbus/dbus-auth.c: authentication protocol
3615 initial implementation, not actually used yet.
3617 * dbus/dbus-string.c (_dbus_string_find): new function
3618 (_dbus_string_equal): new function
3619 (_dbus_string_base64_encode): new function
3620 (_dbus_string_base64_decode): new function
3622 2002-12-25 Anders Carlsson <andersca@codefactory.se>
3625 * dbus/dbus-marshal.c: (swap_bytes), (_dbus_marshal_double),
3626 (_dbus_marshal_int32), (_dbus_marshal_uint32),
3627 (_dbus_demarshal_double), (_dbus_demarshal_int32),
3628 (_dbus_demarshal_uint32), (_dbus_marshal_test):
3629 * dbus/dbus-marshal.h:
3630 * dbus/dbus-protocol.h:
3631 * dbus/dbus-test.c: (main):
3633 Add un-optimized marshalling/demarshalling routines.
3635 2002-12-25 Harri Porten <porten@kde.org>
3637 * qt/dbus-qt.h: adjusted ctor and getter to KDE/Qt conventions
3639 2002-12-24 Zack Rusin <zack@kde.org>
3641 * qt/dbus-qthread.cc: adding - integrates QMutex into Dbus
3642 * qt/dbus-qt.h: skeleton with two sample implemenatation of the
3645 2002-12-24 Havoc Pennington <hp@pobox.com>
3647 * glib/dbus-gthread.c: fix include
3649 * glib/dbus-glib.h: rename DBusMessageHandler for now.
3650 I think glib API needs to change, though, as you don't
3651 want to use DBusMessageFunction, you want to use the
3652 DBusMessageHandler object. Probably
3653 dbus_connection_open_with_g_main_loop()
3654 and dbus_connection_setup_g_main_loop() or something like that
3655 (but think of better names...) that just create a connection
3656 that has watch/timeout functions etc. already set up.
3658 * dbus/dbus-connection.c
3659 (dbus_connection_send_message_with_reply): new function just to
3660 show how the message handler helps us deal with replies.
3662 * dbus/dbus-list.c (_dbus_list_remove_last): new function
3664 * dbus/dbus-string.c (_dbus_string_test): free a string that
3667 * dbus/dbus-hash.c: use memory pools for the hash entries
3668 (rebuild_table): be more paranoid about overflow, and
3669 shrink table when we can
3670 (_dbus_hash_test): reduce number of sprintfs and write
3671 valid C89. Add tests for case where we grow and then
3672 shrink the hash table.
3674 * dbus/dbus-mempool.h, dbus/dbus-mempool.c: memory pools
3676 * dbus/dbus-connection.c (dbus_connection_register_handler)
3677 (dbus_connection_unregister_handler): new functions
3679 * dbus/dbus-message.c (dbus_message_get_name): new
3681 * dbus/dbus-list.c: fix docs typo
3683 * dbus/dbus-message-handler.h, dbus/dbus-message-handler.c:
3684 an object representing a handler for messages.
3686 2002-12-16 Anders Carlsson <andersca@codefactory.se>
3689 * glib/dbus-gthread.c: (dbus_gthread_init):
3690 Don't use the gdbus prefix for public functions.
3692 2002-12-16 Anders Carlsson <andersca@codefactory.se>
3696 Add GLib checks and fixup .pc files
3700 * glib/dbus-gmain.c: (gdbus_connection_prepare),
3701 (gdbus_connection_check), (gdbus_connection_dispatch),
3702 (gdbus_add_connection_watch), (gdbus_remove_connection_watch),
3703 (dbus_connection_gsource_new):
3704 * glib/dbus-gthread.c: (dbus_gmutex_new), (dbus_gmutex_free),
3705 (dbus_gmutex_lock), (dbus_gmutex_unlock), (dbus_gthread_init):
3706 * glib/test-dbus-glib.c: (message_handler), (main):
3709 2002-12-15 Harri Porten <porten@kde.org>
3711 * autogen.sh: check for libtoolize before attempting to use it
3713 * dbus/dbus-transport-unix.c: include <sys/time.h> for timeval
3716 * .cvsignore: ignore more stamp files
3718 * dbus/dbus-watch.c (_dbus_watch_list_new): fixed doc error
3720 * test/Makefile.am: added -I$(top_srcdir) to be able to compile
3721 without make install.
3723 2002-12-15 Havoc Pennington <hp@pobox.com>
3725 * dbus/dbus-threads.c: add thread stubs that a higher library
3726 layer can fill in. e.g. the GLib wrapper might fill them in with
3727 GThread stuff. We still need to use this thread API to
3728 thread-safe-ize the library.
3730 2002-12-12 Havoc Pennington <hp@pobox.com>
3732 * dbus/dbus-transport-unix.c, dbus/dbus-server-unix.c: use the
3733 below new interfaces and include fewer system headers.
3735 * dbus/dbus-sysdeps.c (_dbus_read): new function
3736 (_dbus_write): new function
3737 (_dbus_write_two): new function
3738 (_dbus_connect_unix_socket): new function
3739 (_dbus_listen_unix_socket): new function
3741 * dbus/dbus-message-internal.h: change interfaces to use
3744 2002-12-11 Havoc Pennington <hp@pobox.com>
3746 * dbus/dbus-types.h: add dbus_unichar
3748 * dbus/dbus-internals.c (_dbus_verbose): use _dbus_getenv
3750 * dbus/dbus-connection.c (dbus_connection_send_message): return
3753 * dbus/dbus-transport.c: include dbus-watch.h
3755 * dbus/dbus-connection.c: include dbus-message-internal.h
3757 * HACKING: add file with coding guidelines stuff.
3759 * dbus/dbus-string.h, dbus/dbus-string.c: Encapsulate all string
3760 handling here, for security purposes (as in vsftpd). Not actually
3761 using this class yet.
3763 * dbus/dbus-sysdeps.h, dbus/dbus-sysdeps.c: Encapsulate all
3764 system/libc usage here, as in vsftpd, for ease of auditing (and
3765 should also simplify portability). Haven't actually moved all the
3766 system/libc usage into here yet.
3768 2002-11-25 Havoc Pennington <hp@pobox.com>
3770 * dbus/dbus-internals.c (_dbus_verbose): fix to not
3771 always print the first verbose message.
3773 2002-11-24 Havoc Pennington <hp@pobox.com>
3775 * test/echo-client.c, test/echo-server.c: cheesy test
3778 * configure.in (AC_CHECK_FUNCS): check for writev
3780 * dbus/dbus-message.c (_dbus_message_get_network_data): new
3783 * dbus/dbus-list.c (_dbus_list_foreach): new function
3785 * dbus/dbus-internals.c (_dbus_verbose): new function
3787 * dbus/dbus-server.c, dbus/dbus-server.h: public object
3788 representing a server that listens for connections.
3790 * dbus/.cvsignore: create
3792 * dbus/dbus-errors.h, dbus/dbus-errors.c:
3793 public API for reporting errors
3795 * dbus/dbus-connection.h, dbus/dbus-connection.c:
3796 public object representing a connection that
3797 sends/receives messages. (Same object used for
3798 both client and server.)
3800 * dbus/dbus-transport.h, dbus/dbus-transport.c:
3801 Basic abstraction for different kinds of stream
3802 that we might read/write messages from.
3804 2002-11-23 Havoc Pennington <hp@pobox.com>
3806 * dbus/dbus-internals.h (_DBUS_INT_MAX): add _DBUS_INT_MIN
3809 * dbus/dbus-test.c (main): add list test, and include
3810 dbus-test.h as intended
3812 * dbus/dbus-hash.c (_dbus_hash_table_remove_string)
3813 (_dbus_hash_table_remove_int): return value indicates
3814 whether the entry existed to remove
3816 * dbus/dbus-list.c: add linked list utility class,
3819 * dbus/dbus-hash.c: add TODO item about shrinking the hash bucket
3822 2002-11-23 Havoc Pennington <hp@pobox.com>
3824 * Doxyfile.in (INCLUDE_FILE_PATTERNS): expand DBUS_BEGIN_DECLS/
3825 DBUS_END_DECLS to nothing, that should fix this once and for all
3827 * Doxyfile.in (JAVADOC_AUTOBRIEF): set to YES
3829 * dbus/dbus-message.c, dbus/dbus-hash.c:
3830 add some missing @brief
3832 2002-11-23 Havoc Pennington <hp@pobox.com>
3834 * dbus/dbus-message.h: put semicolons after DEBUG_BEGIN_DECLS
3835 to avoid confusing Doxygen
3837 * dbus/dbus-hash.c: @} not }@
3839 * dbus/dbus-message.c (struct DBusMessage): split out
3842 2002-11-23 Havoc Pennington <hp@pobox.com>
3844 * configure.in: pile on more warning flags if using gcc
3846 * Doxyfile.in (EXTRACT_STATIC): set to NO, so we don't have
3847 to document static functions
3849 * configure.in: add summary to end of configure so it
3850 looks nice and attractive
3852 * dbus/dbus-hash.c: finish implementation and write unit
3855 * configure.in: add --enable-tests to enable unit tests
3857 * dbus/dbus-test.c: test program to run unit tests
3858 for all files in dbus/*, initially runs a test for
3861 * dbus/dbus-internals.h: file to hold some internal utility stuff
3863 2002-11-22 Havoc Pennington <hp@redhat.com>
3865 * dbus/dbus-hash.c: copy in Tcl hash table, not yet
3866 "ported" away from Tcl
3868 * dbus/dbus-types.h: header for types such as dbus_bool_t
3870 2002-11-22 Havoc Pennington <hp@redhat.com>
3872 * dbus/dbus.h: fixups for doc warnings
3874 * Doxyfile.in (FILE_PATTERNS): we need to scan .h to pick up
3876 (QUIET): make it quiet so we can see warnings
3878 * dbus/dbus-memory.c: teach D-BUS to allocate and free memory
3880 2002-11-22 Havoc Pennington <hp@redhat.com>
3882 * Makefile.am: include "Doxyfile" target in all-local
3884 * configure.in: generate the Doxyfile
3886 * Doxyfile.in: move Doxyfile here, so we can use
3887 configure to generate a Doxyfile with the right
3890 2002-11-22 Havoc Pennington <hp@redhat.com>
3892 * dbus/dbus-message.c: move inline docs into .c file
3894 * Doxyfile (OUTPUT_DIRECTORY): move output to doc/api
3895 so all docs are under doc/
3896 (MAN_EXTENSION): generate man pages. Use extension
3897 ".3dbus" which matches ".3qt" on my system,
3898 I guess this is OK, I don't know really.
3899 (FILE_PATTERNS): look for .c files not .h, makes sense
3902 2002-11-22 Havoc Pennington <hp@pobox.com>
3904 * Makefile.am (SUBDIRS): rename subdir "server" to "bus"
3905 because any app can be a server, and any app can be a client,
3906 the bus is a special kind of server.
3908 Thu Nov 21 23:35:31 2002 Zack Rusin <zack@kde.org>
3910 * Doxyfile : adding. Still needs Makefile rules to be generated
3911 automatically (just run "doxygen" in the toplevel dir for now to
3914 * dbus/dbus-message.h : Adding sample docs (javadoc since
3915 resembles gtk-doc a little more)
3917 * dbus/dbus.h : Adding sample docs
3919 2002-11-21 Havoc Pennington <hp@redhat.com>
3921 * dbus/Makefile.am (INCLUDES): define DBUS_COMPILATION
3922 so we can allow ourselves to include files directly,
3923 instead of having to use dbus.h
3925 * dbus/dbus.h: fill in
3927 * dbus/dbus-message.h: sketch out a sample header file.
3928 Include griping if you include it directly instead of
3931 * dbus/dbus-macros.h: new file with macros for extern "C",
3932 TRUE/FALSE, NULL, etc.
3934 * doc/file-boilerplate.c: put include guards in here
3936 2002-11-21 Havoc Pennington <hp@redhat.com>
3938 * doc/file-boilerplate.c: include both AFL and GPL boilerplate.
3940 * COPYING: include the GPL as well, and license code
3941 under both AFL and GPL.
3943 2002-11-21 Havoc Pennington <hp@redhat.com>
3945 * acconfig.h: get rid of this
3947 * autogen.sh (run_configure): add --no-configure option
3949 * configure.in: remove AC_ARG_PROGRAM to make
3950 autoconf complain less. add AC_PREREQ.
3951 add AC_DEFINE third arg.
3953 2002-11-21 Anders Carlsson <andersca@codefactory.se>
3956 Fix references so we can distcheck.
3958 2002-11-21 Havoc Pennington <hp@redhat.com>
3960 * Initial module creation