1 2006-03-05 Paul Eggert <eggert@cs.ucla.edu>
5 * src/dd.c (flags, usage): New flags directory, nolinks.
6 * src/system.h (O_NOLINKS): Define to 0 if not already defined.
8 * src/ls.c (usage): Mention that -f disables --color.
9 Problem reported by Niels Möller.
11 2006-03-03 Justin Pryzby <pryzbyj@justinpryzby.com>
13 * man/*.x: Add references to syscalls from utilities of the same name.
15 2006-03-05 Jim Meyering <jim@meyering.net>
17 * tests/help-version: Set SHELL, if not already set, in order to
18 avoid failure when `make check' is run through debuild; dircolors
19 would fail due to lack of $SHELL. Reported by Sven Joachim.
21 Make `base64 --wrap=N' work for N=0, and for N larger than SIZE_MAX.
22 * src/base64.c (wrap_write, do_encode, main): Change type of
23 parameters and locals, wrap_column, form size_t to uintmax_t.
24 (main): Adjust to use xstrtoumax, accordingly.
26 2006-03-03 Jim Meyering <jim@meyering.net>
28 Don't fail when run from an environment with SHELL not a Bourne
29 shell, e.g. `env SHELL=/bin/csh make check' would fail this test.
30 * tests/dircolors/simple: Invoke each non-failing test with -b.
31 Reported by Michael Stone.
33 2006-02-27 Jim Meyering <jim@meyering.net>
35 * tests/misc/base64: Derive --decode-using tests from the
38 * tests/misc/base64: Factor out a long constant string.
39 Split lines to stay within 80 columns.
41 * tests/misc/Makefile.am (TESTS): Add base64.
42 * tests/misc/base64: Test base64. From Simon Josefsson.
44 * src/base64.c (do_decode): Use correct type for parameter,
45 ignore_garbage: s/size_t/bool/.
47 * src/base64.c: Don't include .h files already included by system.h:
48 <string.h>, <stdlib.h>, <stdbool.h>, <limits.h>, <errno.h>.
49 Include "system.h" before the other lib/*.h header files.
50 Include <sys/types.h> before "system.h".
51 (wrap_write): Remove declaration of unused local, initial_column.
52 (wrap_write): Correct declaration syntax: s/size_t * V/size_t *V/.
54 * README: Add base64 to the list.
56 2006-02-17 Simon Josefsson <jas@extundo.com>
59 * AUTHORS: Mention base64.
61 * man/Makefile.am: Build base64.1.
62 * man/base64.x: New file.
63 * src/Makefile.am (bin_PROGRAMS): Add base64.
64 * src/base64.c: New file.
66 2006-02-25 Eric Blake <ebb9@byu.net>
68 In ls, avoid calling stat for --inode (-i), when possible.
69 * src/pwd.c (NOT_AN_INODE_NUMBER, D_INO): Move to ...
70 * src/system.h: ... here, for use in ...
71 * src/ls.c (main): ... here. Prefer dirent.d_ino to stat when
73 (gobble_file): Add inode argument.
74 (print_dir): Pass inode if available.
75 (usage): Remove inaccuracy.
77 2006-02-23 Jim Meyering <jim@meyering.net>
79 * TODO: Update/correct some obsolete entries.
81 2006-02-20 Paul Eggert <eggert@cs.ucla.edu>
83 * doc/coreutils.texi (join invocation): Mention `sort -k 1b,1'.
84 * src/join.c (usage): Likewise.
85 Documentation problem reported by Philip Kensche.
87 2006-02-20 Eric Blake <ebb9@byu.net>
89 * man/rm.x: Update documentation to match previous patch.
91 2006-02-18 Eric Blake <ebb9@byu.net>
93 New option for rm: --interactive=once (-I).
94 * NEWS: Document it, along with change to rm --interactive.
95 * TODO: Remove entry for implementing rm -I
96 * src/rm.c (INTERACTIVE_OPTION): New enum value.
97 (interactive_type): New enum.
98 (long_opts): Let interactive take an optional argument.
99 (interactive_args, interactive_types): New option arguments.
100 (usage): Document -I, --interactive=WHEN. Use program_name
101 instead of a basename.
102 (main): New -I option, new behavior to --interactive.
103 * tests/rm/interactive-once: New tests.
104 * tests/rm/interactive-always: Ditto.
105 * tests/rm/Makefile.am (TESTS): Run them.
107 2006-02-18 Jim Meyering <jim@meyering.net>
109 * Makefile.maint (sc_two_space_separator_in_usage): Make the regular
110 expression match more of the target lines, e.g., those that start with
111 `-S,' (short option followed by a comma) or that include `=[...]'.
112 Patch by Nicolas François.
113 Fix the four offenders thus exposed:
114 * src/join.c (usage): Use two spaces (not one) to separate the
115 --first-only option string from its description, so help2man formats
116 the derived man page properly.
117 * src/pr.c (usage): Likewise.
118 * src/uniq.c (usage): Likewise.
119 * src/install.c (usage): Likewise.
121 2006-02-15 Jim Meyering <jim@meyering.net>
123 * Makefile.maint (alpha beta major): For `make major', ensure that the
124 version string is of the form N.N[.N]*, where N is one or more digits.
126 2006-02-14 Jim Meyering <jim@meyering.net>
128 * INSTALL: Update from gnulib.
130 2006-02-13 Jim Meyering <jim@meyering.net>
132 * GNUmakefile (all): Emit diagnostics to stderr, not stdout.
134 2006-02-12 Jim Meyering <jim@meyering.net>
136 * Makefile.maint (patch-check): New target.
137 (local-checks-available): Add to the list.
139 2006-02-11 Jim Meyering <jim@meyering.net>
141 * src/c99-to-c89.diff: New file.
142 * src/Makefile.am (EXTRA_DIST): Add c99-to-c89.diff.
144 * .x-po-check: New file, with exclusions so that `make distcheck'
146 * Makefile.am (EXTRA_DIST): Add .x-po-check.
148 rm -r must remove an empty directory, even if it is inaccessible.
149 * src/remove.c (close_preserve_errno): New function.
150 (fd_to_subdirp): Don't print a diagnostic in this function.
151 Do it from the callers instead, unless rmdir succeeds.
152 (remove_cwd_entries, remove_dir): Adjust callers.
153 * tests/rm/empty-inacc: New test for the above.
154 * tests/rm/Makefile.am (TESTS): Add empty-inacc.
155 * NEWS: Mention this bug fix.
156 * tests/rm/rm2: Adjust two expected diagnostics, now that they're
157 a tiny bit less precise: cannot remove `a/1': ... instead of
158 cannot open directory `a/1': ...
160 * Makefile.maint (syntax-check-rules): Automatically derive this
161 list of sc_-prefixed rule names.
163 2006-02-10 Paul Eggert <eggert@cs.ucla.edu>
165 * Makefile.maint (CVS_LIST): Don't assume cvsu is available.
166 (CVS_LIST_EXCEPT): New macro, to simplify exception-processing.
167 Most uses of CVS_LIST changed to use CVS_LIST_EXCEPT.
168 (syntax-check-rules): Bring back sc_changelong. (Hmm, why did it
169 go away? was that an accident?)
170 (sc_cast_of_argument_to_free, sc_cast_of_x_alloc_return_value):
171 (sc_cast_of_alloca_return_value, sc_space_tab, sc_prohibit_atoi_atof):
172 (sc_error_exit_success, sc_file_system, sc_no_if_have_config_h):
173 (sc_system_h_headers, sc_sun_os_names, sc_trailing_blank):
174 (sc_two_space_separator_in_usage, sc_unmarked_diagnostics):
175 (sc_obsolete_symbols, sc_changelog, sc_prohibit_jm_in_m4):
176 (sc_useless_cpp_parens, makefile-check, m4-check, po-check):
177 (author_mark_check, makefile_path_separator_check):
178 Output line numbers, to simplify navigation of Emacs *compilation*
180 (sc_prohibit_atoi_atof, sc_file_system):
181 Rework slightly so that Makefile.maint doesn't get reported as a
182 violation of its own syntax rules.
183 (sc_dd_max_sym_length): Use ifneq to do nothing, instead of doing
184 it at run-time (which didn't work with Bison). Fix a makefile typo,
185 caught by Makefile.maint itself: spaces where a tab should be.
186 (po-check): Check lib/*.[ch] even if not in CVS; used by Bison,
187 which copies from ../gnulib/lib/*.[ch] to lib/*.[ch].
188 Ignore djgpp and man subdirectories, to avoid false matches with
189 Bison and coreutils, respectively. Use sort -u to remove the
190 resulting duplicates.
191 * gnupload: Rework slightly to avoid bogus warning from
192 sc_two_space_separator_in_usage.
194 2006-02-10 Jim Meyering <jim@meyering.net>
196 Use gzip's --rsyncable option only if it's available.
197 * Makefile.maint (gzip_rsyncable): New variable.
200 2006-02-08 Jim Meyering <jim@meyering.net>
202 * Makefile.maint (local-checks-available): Define in terms of
203 the expansion, $(syntax-check-rules), rather than the single,
204 top-level target `syntax-check', so that it's easier to exclude
205 individual rules (via $(local-checks-to-skip)).
206 (tgz-md5, tgz-sha1, ...): Remove now-unused definitions.
208 2006-02-07 Jim Meyering <jim@meyering.net>
210 * src/system.h (!defined O_DIRECT): If O_DIRECTIO is defined (as it
211 is on Tru64), define O_DIRECT to that. Patch From James Lemley.
213 * tests/help-version (expected_failure_status_vdir):
214 Redirect an expected disk-full diagnostic to /dev/null.
216 2006-02-06 Jim Meyering <jim@meyering.net>
218 * src/unexpand.c (usage): Use two spaces (not one) to separate the
219 --first-only option string from its description, so help2man formats
220 the derived man page properly.
221 * src/rm.c (usage): Likewise for --no-preserve-root.
222 * src/chown.c (usage): Likewise.
223 * src/chgrp.c (usage): Likewise.
225 Add a rule to ensure that the above doesn't happen again.
226 * Makefile.maint (sc_two_space_separator_in_usage): New rule.
227 (syntax-check-rules): Add it.
228 * .x-sc_two_space_separator_in_usage: New empty file.
229 * Makefile.am (EXTRA_DIST): Add .x-sc_two_space_separator_in_usage.
231 2006-02-06 Jim Meyering <jim@meyering.net>
233 * src/cp.c (usage): Use two spaces (not one) to separate each
234 option string from its description, so help2man formats the
235 derived man page properly.
236 * src/mv.c (usage): Likewise.
237 Patch from Nicolas François in http://bugs.debian.org/351601.
239 2006-02-04 Jim Meyering <jim@meyering.net>
241 * src/copy.c (copy_internal): cp -RL would fail when encountering
242 the same directory more than once in the hierarchy beneath a single
243 command-line argument. That is legitimate, e.g. when there are
244 two or more symbolic links, each pointing to some directory that
245 would not otherwise be copied. Reported by Christophe LYON.
246 * tests/cp/cp-deref: New file. Test for today's fix.
247 * tests/cp/Makefile.am (TESTS): Add cp-deref.
248 * NEWS: Document this.
250 2006-02-03 Jim Meyering <jim@meyering.net>
252 * configure.ac: Require automake-1.9.6, not 1.8.3.
254 2006-02-01 Paul Eggert <eggert@cs.ucla.edu>
256 * src/od.c (usage): Mention that -t a ignores high order bit.
257 Documentation problem reported by Ed Avis.
259 2006-02-01 Jim Meyering <jim@meyering.net>
261 * src/pwd.c (find_dir_entry): Remove unused local, `ent_sb_valid'.
263 2006-01-30 Paul Eggert <eggert@cs.ucla.edu>
265 * src/head.c (main): Use a better diagnostic when someone uses a
266 trailing numeric option in an invalid way. Problem reported by
268 * src/tail.c (parse_options): Likewise.
270 2006-01-30 Jim Meyering <jim@meyering.net>
272 * man/wc.x: Include `count' keyword in man page synopsis,
273 per suggestion from http://bugs.debian.org/181585.
275 2006-01-24 Paul Eggert <eggert@cs.ucla.edu>
277 * src/df.c (show_dev): If the file system claims to have
278 more available than total blocks, report the number of used
279 blocks as being total - available (a negative number) rather
280 than as garbage. Problem reported by Toralf Foerster.
282 2006-01-24 Jim Meyering <jim@meyering.net>
284 * src/tail.c (tail_forever): Don't exit-nonzero when an attempt
285 to put a regular file in O_NONBLOCK mode fails with EPERM.
286 That happens on Linux (up to 2.6.15) when using tail -f on a file with
287 the append-only attribute. Reported by Dean Gaudet. For details,
288 see http://savannah.gnu.org/bugs/?func=detailitem&item_id=15473.
289 * NEWS: Mention this fix.
290 * tests/tail-2/append-only: New file. Test for the above.
291 * tests/tail-2/Makefile.am (TESTS): Add append-only.
292 * tests/Makefile.am (check-root): Add tail-2/append-only
294 2006-01-21 Jim Meyering <jim@meyering.net>
296 * NEWS: Mention fts-related improvements and bug fixes.
298 2006-01-19 Jim Meyering <jim@meyering.net>
300 * tests/fmt/basic (pfx-1, pfx-2): New tests, to demonstrate the bug
301 reported as http://bugs.debian.org/147577. Forwarded by Thomas Hood.
303 2006-01-18 Jim Meyering <jim@meyering.net>
305 * tests/du/Makefile.am (TESTS): Add long-from-unreadable.
307 2006-01-17 Jim Meyering <jim@meyering.net>
309 Now that fts no longer changes the current working directory, adjust
310 its clients accordingly -- note that du.c uses fts but doesn't need
311 any adjustment, since it doesn't operate on the actual files,
312 but rather just uses the stat buffers provided by fts.
314 * src/chown-core.c: Include "openat.h".
315 Don't include "lchown.h".
316 (restricted_chown): Accept a new parameter, CWD_FD, and use it in
317 calling openat, lchownat, chownat, rather than open, lchown, chown.
319 * src/chmod.c: Include "openat.h".
320 (process_file): Use chmodat (fts->fts_cwd_fd,... in place of chmod (...
322 * tests/du/long-from-unreadable: New test, to exercise one small
325 2006-01-13 Jim Meyering <jim@meyering.net>
327 * tests/Makefile.am (SUBDIRS): Add comments discouraging the
328 addition of new directories under tests/.
330 * tests/acl: Redirect stdin to /dev/null. Otherwise, FreeBSD 5.0's
333 2006-01-12 Jim Meyering <jim@meyering.net>
335 * tests/du/long-sloop: Adjust not to hard-code the expected
336 diagnostic corresponding to ELOOP. Solaris' diagnostic differs
337 from that of GNU libc. Reported by Paul Eggert.
339 * tests/du/long-sloop: Create file at end of symlink chain.
341 * tests/misc/test: New file, with a test for one of the
342 bugs fixed by yesterday's test.c changes.
343 * tests/misc/Makefile.am (TESTS): Add test.
345 2006-01-11 Jim Meyering <jim@meyering.net>
347 * tests/du/long-sloop: New file. Test for today's fts.c bug fix.
348 That bug could make du -L, chgrp -L, or chown -L fail to diagnose
349 a very long sequence of symbolic links (not necessarily a loop).
350 * tests/du/Makefile.am (TESTS): Add long-sloop.
352 2006-01-11 Paul Eggert <eggert@cs.ucla.edu>
354 * src/test.c (test_syntax_error): Append a newline. All callers
355 changed, except for the ones that didn't already append a newline.
356 Bug reported by Eric Blake.
358 2006-01-11 Jim Meyering <jim@meyering.net>
360 * src/system.h (X2NREALLOC): Now that verify_true is no longer
361 void, cast its result to void, to avoid gcc's warning that
362 ``left-hand operand of comma expression has no effect''.
363 (DECIMAL_DIGIT_ACCUMULATE, X2REALLOC): Likewise.
365 2006-01-10 Jim Meyering <jim@meyering.net>
367 * tests/chmod/no-x: Add a test for today's fts.c fix.
369 2006-01-10 Jim Meyering <jim@meyering.net> (tiny change)
371 * src/ls.c (gobble_file): Use DTTOIF only if it's defined.
372 This is necessary for Dragonfly. Patch by Joerg Sonnenberger.
374 2006-01-10 Paul Eggert <eggert@cs.ucla.edu>
376 * src/system.h (X2NREALLOC, X2REALLOC, DECIMAL_DIGIT_ACCUMULATE):
377 Use verify_true instead of verify_expr, to sync with gnulib.
379 2006-01-08 Jim Meyering <jim@meyering.net>
381 * src/date.c (usage): Adjust the formatting of the entries for
382 %::z and %:::z (separate with two spaces, not one) so that help2man
383 formats them properly. Reported by Philip Rowlands.
385 2006-01-06 Paul Eggert <eggert@cs.ucla.edu>
387 * configure.ac (gl_IGNORE_UNUSED_LIBRARIES): Add.
389 2006-01-06 Jim Meyering <jim@meyering.net>
391 * Makefile.maint (copyright-check): Use date +%Y in place of
394 * src/remove.c (rm_1): Remove `static' attribute on local `status'.
395 First off, the attribute should have been `volatile' (not static)
396 to avoid longjmp-related risk of clobber. Secondly, now there is
397 no longer any risk of a local variable being clobbered, so there's
398 no need for any attribute at all.
400 2006-01-05 Jim Meyering <jim@meyering.net>
402 * src/remove.c: Give a few functions the inline attribute.
403 (AD_pop_and_chdir): Use gotos to avoid some duplication.
404 (AD_push): Rewrite an assertion so that the entire computation
405 goes away when assertions are turned off.
407 * src/tail.c (ENOSYS) [!defined ENOSYS]: Don't define here.
408 It's already defined in "system.h".
409 * Makefile.maint: Add a FIXME comment.
411 2006-01-04 Jim Meyering <jim@meyering.net>
413 * ChangeLog: Remove entries from 2005-10-22 and earlier.
414 * ChangeLog-2005: New file, for entries up to version 5.92.
416 2006-01-03 Jim Meyering <jim@meyering.net>
418 * tests/du/no-x: Also allow a slightly different diagnostic -- the
419 one you get when using openat-enabled fts.c and du (coming soon).
420 * tests/chmod/no-x: Likewise.
421 * tests/chgrp/no-x: Likewise.
423 * src/system.h (O_DIRECTORY) [!defined O_DIRECTORY]: Define.
425 2006-01-02 Paul Eggert <eggert@cs.ucla.edu>
427 * src/chown-core.c (RC_do_ordinary_chown): New enum value.
428 (restricted_chown): Return it, if the file cannot be accessed due
429 to EPERM, or if no uid or gid are required, or if the file is
430 neither a directory nor a regular file. Rewrite to avoid gotos.
431 (change_file_owner): Handle RC_do_ordinary_chown case.
432 Rewrite to avoid gotos.
433 * tests/chgrp/basic: Make sure we can change the group of
436 * src/date.c (usage): Explain %g, %G, and %V a bit better.
438 2006-01-02 Jim Meyering <jim@meyering.net>
440 * src/copy.c (set_owner): Correct a comment.
442 * src/tail.c (parse_options): Change warning to say that --retry
443 is useful `mainly' (not `only') when following by name.
444 Reported here: http://bugs.debian.org/273781
446 2006-01-01 Paul Eggert <eggert@cs.ucla.edu>
448 * NEWS: Document that mkfifo and mknod -m no longer set special bits.
449 * src/copy.c: Include lchmod.h.
450 (copy_internal): Use lchmod rather than chmod.
451 * src/cp.c: Include lchmod.h.
452 (re_protect, make_dir_parents_private): Use lchmod rather than chmod.
453 * src/mkdir.c: Include lchmod.h.
454 (usage): Clarify -m's operation.
455 (main): Use lchmod rather than chmod. Don't use lchmod unless the
456 new mode contains bits outside the 777 range.
457 * src/mkfifo.c (usage): Clarify -m's operation.
458 (main): If -m is given, don't invoke chmod; use umask 0 instead.
459 Report an error if -m asks for bits outside the 777 range.
460 * src/mknod.c (usage, main): Likewise.
462 * src/mkdir.c, src/mkfifo.c, src/mknod.c: Undo 2005-12-19 changes.
464 2005-12-27 Jim Meyering <jim@meyering.net>
466 * Makefile.maint (sc_obsolete_symbols): Prohibit use of O_NDELAY.
467 (sc_prohibit_assert_without_use): New rule.
468 (syntax-check-rules): Add it to the list.
469 * .x-sc_prohibit_assert_without_use: New empty file.
470 * Makefile.am (EXTRA_DIST): Add it.
472 * Makefile.maint (CVS_LIST): Define in terms of $(srcdir).
474 * cp.c, df.c, link.c, mknod.c, nice.c, sleep.c, unlink.c:
475 Don't include <assert.h>; it wasn't used.
477 2005-12-26 Paul Eggert <eggert@cs.ucla.edu>
479 * src/chown-core.c (restricted_chown):
480 Don't try O_WRONLY unless O_RDONLY failed wth EACCES.
481 * src/remove.c (fd_to_subdirp): Open with O_DIRECTORY | O_NOCTTY
482 | O_NOFOLLOW too, for consistency with other dir-openers.
483 Use POSIX-preferred O_NONBLOCK rather than O_NDELAY.
484 (is_empty_dir): Likewise.
485 * src/shred.c (wipename): Likewise. Don't bother trying to open
486 dir for writing, since POSIX prohibits it.
488 2005-12-22 Jim Meyering <jim@meyering.net>
490 * tests/help-version: Redirect stderr to /dev/full, to suppress
491 write error diagnostic.
493 2005-12-19 Jim Meyering <jim@meyering.net>
495 * src/mkdir.c, src/mknod.c, src/mkfifo.c (main)
496 Avoid a minor race condition when `-m MODE' is specified, by using
497 open, fchown, and close rather than just chown. To do that reliably --
498 even with an overly restrictive umask -- ensure that each mkdir,
499 mknod and mkfifo call uses a mode including at least owner-read access.
500 * src/mknod.c (main): When `-m MODE' is specified, exit nonzero if
501 the subsequent chown (or equivalent open,fchown,close) fails.
502 * tests/misc/mknod: New tests.
503 * tests/misc/Makefile.am (TESTS): Add mknod.
505 2005-12-17 Jim Meyering <jim@meyering.net>
507 * src/remove.c (is_empty_dir): Open with O_NDELAY, so we don't hang,
508 e.g., on a named pipe.
509 (OPEN_NO_FOLLOW_SYMLINK): Remove definition. Use O_NOFOLLOW in
510 place of all uses, since it is guaranteed (system.h) to be defined.
512 2005-12-05 Andreas Gruenbacher <agruen@suse.de>
514 Add POSIX ACL support
515 * src/ls.c: Switch back from HAVE_ACL to USE_ACL: The acl() syscall
516 is no requirement for ACL support; particularly, it does not exist
517 on systems that have POSIX ACLs.
518 * src/copy.h (cp_option_init) [umask_kill]: Remove member.
519 * src/cp.c (umask_kill): With default acls, the umask is not to be
520 applied. Remove umask_kill, don't change the process umask, and let
521 the kernel apply the umask where appropriate.
522 * src/cp.c (make_dir_parents_private): Fix logic for POSIX ACLs.
523 * src/copy.c (get_dest_mode): Remove; it is obsolete after removing
525 (copy_reg, copy_internal): Use copy_acl and set_acl
526 instead of fchown/chown. Fix the logic for POSIX ACLs.
527 (chown_succeded): Remove; we now always copy acls and
528 preserve S_ISUID, S_ISGID, and S_ISVTX when needed, no matter if we
529 did a chown before or not.
530 * src/mv.c, src/install.c (cp_option_init): Don't set umask_kill member.
531 * src/Makefile.am (dir_LDADD, ls_LDADD, vdir_LDADD, cp_LDADD,
532 mv_LDADD, ginstall_LDADD): On systems with an ACL library, arrange
533 to link with it via $(LIB_ACL), for the utilities that need it.
535 2005-12-16 Paul Eggert <eggert@cs.ucla.edu>
537 * src/remove.c (OPENAT_CWD_RESTORE__REQUIRE): Remove.
538 (OPENAT_CWD_RESTORE__ALLOW_FAILURE): Likewise.
539 (fd_to_subdirp): Remove openat_cwd_restore_allow_failure arg; its
540 value is now signified by whether cwd_errno is null.
541 (fd_to_subdirp, remove_dir, rm_1); Change cwd failure indicator from
542 pointer-to-bool to pointer-to-errno-value. All callers changed.
543 (rm_1): Don't bother setting a local cwd failure flag and then
544 ORing it into the caller's. Just set the caller's.
545 (rm): Use cwd failure errno value to print a slightly-better
548 2005-12-15 Jim Meyering <jim@meyering.net>
550 * src/stat.c (print_it): Properly handle a backslash at the
551 end of a --printf format string. Reported by Paul Eggert.
552 * tests/misc/stat-printf (end-bs): Add a test for the above.
554 2005-12-15 Paul Eggert <eggert@cs.ucla.edu>
556 * tests/acl: Port to pre-POSIX shells like Solaris 8 /bin/sh.
557 Don't assume /etc/passwd contains user names; use 'id' instead.
559 2005-12-15 Jim Meyering <jim@meyering.net>
561 stat: revert behavior of --format=FMT (-c)
562 stat: add new option: --printf=FMT
563 * NEWS: Mention this.
564 * src/stat.c (isodigit, octtobin, hextobin): Define.
565 (PRINTF_OPTION): Define.
566 (interpret_backslash_escapes, trailing_delim): New globals.
567 (usage): Document them. Alphabetize on long option names.
568 (print_esc_char): New function.
569 (print_it): Rewrite, in order to handle backslash escapes.
570 (main): Handle new option. Set globals for --format, too.
572 * tests/misc/stat-printf: Test --printf and --format.
573 * tests/misc/Makefile.am (TESTS): Add stat-printf.
575 2005-12-14 Paul Eggert <eggert@cs.ucla.edu>
577 * NEWS: sort now reports incompatible options.
578 * src/sort.c (incompatible_options, check_ordering_compatibility):
580 (main): Use them. Don't bother with a usage message for
581 "sort -c a b", for consistency with other error diagnostics.
582 * tests/sort/Test.pm (incompat1, incompat2, incompat3, incompat4):
585 * src/cat.c (main): Undo previous change. close_stdout already
586 does the check, so the previous change wasn't necessary.
588 2005-12-13 Paul Eggert <eggert@cs.ucla.edu>
590 * src/cat.c (main): Check for close (STDOUT_FILENO) failure.
592 2005-12-12 Paul Eggert <eggert@cs.ucla.edu>
594 Install a more-conservative approach for sort -R. It's the
595 same basic idea as the existing code, except it uses the full ISAAC
596 approach (called the "more kosher" approach in the existing comments).
597 This makes "sort -R" quite a bit slower (about a factor of 2 on my
598 little tests involving 10000 lines on a 2.4 GHz P4), but I think it's
599 better to be conservative here at first, and review any performance
600 improvements carefully.
601 * .x-sc_require_config_h: Add src/rand-isaac.c.
602 * src/rand-isaac.h: Remove. All uses now simply include rand-isaac.c.
603 * src/Makefile.am (noinst_HEADERS): Remove rand-isaac.h.
604 (shred_SOURCES, sort_SOURCES): Remove.
605 (EXTRA_DIST): Add rand-isaac.c.
606 * src/rand-isaac.c: Revert to what used to be in shred.c, without
607 changing it to allow for varying numbers of words in the state.
608 Alter so that we include rand-isaac.c directly rather than
609 compiling it and linking to it. Don't include config.h or
610 system.h; that's the includer's responsibility.
611 Omit functions that are specific to shred.
612 (ISAAC_LOG, ISAAC_WORDS, ISAAC_BYTES, struct isaac_state, ind):
613 (isaac_step, struct irand_state):
614 Resurrect these, with the same defns that used to be in shred.c.
615 (ISAAC_SIZE, isaac_new, isaac_copy): Remove.
616 (isaac_refill, isaac_seed_start, isaac_seed_data, irand_init, irand32):
618 (struct isaac_state, isaac_refill, isaac_mix, isaac_init):
619 (isaac_seed_start, isaac_seed_data, isaac_seed_finish, isaac_seed):
620 (irand_init, irand32, irand_mod):
621 Number of words is constant again.
622 (struct irand_state, irand_init, irand32, irand_mod): Move to shred.c.
623 * src/shred.c: Include rand-isaac.c rather than rand-isaac.h.
624 * src/sort.c: Likewise.
625 * src/shred.c (fillrand, dopass, main): Undo previous change.
626 (struct irand_state, irand_init, irand32, irand_mod): Moved back here,
628 * src/sort.c: Don't include md5.h; it wasn't needed.
629 (struct keyfield): Rename random_hash to random, for consistency
630 with the other member names. All uses changed.
631 (usage): Tweak wording to mention STRING for --seed option.
632 (short_options): Rorder for consistency with other programs.
633 (rand_state): Now a struct, not a pointer to one. All uses changed.
634 (HASH_WORDS, HASH_SIZE): Remove.
635 (get_hash): Remove comments around resbuf size, since we can assume C89.
636 Use a "more-kosher" (but slower) approach of invoking isaac_refill.
637 (keycompare): Adjust to the new get_hash.
639 (badfieldspec): Omit recently-introduced comment; it isn't needed.
640 (main): Don't set need_random simply because gkey has it set; that
641 doesn't necessarily mean we'll need random numbers.
642 Redo seeding to match new get_hash approach.
644 2005-12-10 Jim Meyering <jim@meyering.net>
646 * src/Makefile.am (noinst_HEADERS): Add rand-isaac.h.
648 Avoid shred segfault on 64-bit systems.
649 * src/rand-isaac.c (isaac_refill): Don't try to negate a
650 local of type uint32_t. Make the local an `int' instead.
652 * NEWS: Mention sort's new options.
654 * src/rand-isaac.c (isaac_mix): Declare to be static.
655 Mark all other functions as `extern' so the tight-scope
656 part of `make distcheck' passes once again.
657 * src/rand-isaac.h (isaac_mix): Remove declaration.
659 * src/sort.c (get_hash): Change position of `*' in parameter
660 type to conform with convention.
661 (main): Split a long line so it fits in 80 columns.
662 (keycompare): Remove stray SPACE before TAB that was
663 causing `make distcheck' to fail.
665 * src/shred.c: Don't include gethrxtime.h. No longer needed.
667 * tests/misc/sort-rand: New file: basic tests for the new options.
668 * tests/misc/Makefile.am (TESTS): Add sort-rand.
670 2005-12-10 Frederik Eaton <frederik@ofb.net>
672 * src/Makefile.am (sort_LDADD): Add $(LIB_GETHRXTIME).
673 (shred_SOURCES, sort_SOURCES): New macros, so we compile rand-isaac.c.
674 * src/rand-isaac.c: New file, containing ISAAC code that was in shred.c.
675 Make state size runtime-configurable.
676 (isaac_new, isaac_copy): New functions.
677 * src/rand-isaac.h: New file.
678 * src/shred.c: Include rand-isaac.h. Move ISAAC code to rand-isaac.c.
679 (fillrand, main): Adjust to the fact that the state size is now
680 runtime-configurable.
681 * src/sort.c (short_options, long_options, WORDS, keycompare, main):
682 (usage): Add options --random-sort and --seed to implement a random
684 Include md5.h and rand-isaac.h.
685 (get_hash): New function.
686 (rand_state): New var.
687 (HASH_WORDS, HASH_SIZE): New macros.
689 2005-12-09 Paul Eggert <eggert@cs.ucla.edu>
691 * tests/dd/misc: Add test for dd iflags=noatime.
693 2005-12-09 Jim Meyering <jim@meyering.net>
695 * src/sort.c (usage): Mention white space vs -b and -t options.
698 2005-12-09 Eric Blake <ebb9@byu.net>
700 * src/test.c (main): Fix misleading comment.
702 2005-12-07 Paul Eggert <eggert@cs.ucla.edu>
704 * NEWS: Mention dd's new noatime flag.
705 * src/system.h (O_NOATIME): Define to 0 if not already defined.
706 * src/dd.c (flags, usage): Add support for noatime flag.
708 2005-12-07 Jim Meyering <jim@meyering.net>
710 Distribute the cvsu script, used only by `make syntax-check'.
711 * Makefile.am (EXTRA_DIST): Add build-aux/cvsu.
712 * Makefile.maint (CVS_LIST): Use build-aux/cvsu, now that we
713 distribute a copy of this script.
714 * .x-sc_unmarked_diagnostics: Add build-aux/cvsu.
716 * tests/mv/acl: exit-77 before the trap, not after, if we fail
717 to create a temporary directory on another partition.
718 From Andreas Gruenbacher.
720 2005-12-06 Tomas Pospisek <tpo@sourcepole.ch> (tiny change)
722 * man/basename.x: Cross-reference to dirname and readlink.
723 * man/dirname.x: Cross-reference to basename and readlink.
725 2005-12-05 Andreas Gruenbacher
727 * src/copy.c [!HAVE_FCHOWN]: Define fchown(...) to -1.
728 (set_owner, preserve_author): New functions, factored out of copy_reg.
729 (copy_reg): Use them.
730 (copy_internal): Use them here, too.
732 2005-12-04 Jim Meyering <jim@meyering.net>
734 * src/sleep.c (usage): Say what happens with two or more arguments.
735 Suggested by Justin Pryzby.
737 * src/uptime.c (print_uptime): Move decl of `upsecs' into scope
740 2005-12-03 Jim Meyering <jim@meyering.net>
742 * src/rm.c (long_opts): Change the name of each undocumented, for-
743 testing-only option to start with `-', so that it cannot render
744 ambiguous any prefix it happens to share with some other option name.
745 Problem reported by Eric Blake.
746 * src/head.c (long_options): Likewise.
747 * src/tail.c (long_options): Likewise.
749 * tests/misc/head-elide-tail: Update uses of undocumented, for-
750 testing-only --presume* options to start with `---'.
751 * tests/rm/dangling-symlink: Likewise.
752 * tests/rm/dir-no-w: Likewise.
753 * tests/rm/isatty: Likewise.
755 2005-11-30 Jim Meyering <jim@meyering.net>
757 * Makefile.maint: Add a comment about cvsu.
759 2005-11-25 Paul Eggert <eggert@cs.ucla.edu>
761 * NEWS: df updates for "none", "proc", inaccessible file systems.
762 * src/df.c (show_point): Ignore inaccessible file systems.
763 (usage): -a includes dummy file systems, not size-0 file systems.
765 * src/od.c (unsigned_long_long_int): Renamed from ulonglong_t,
766 to avoid collision with POSIX name space. All uses changed.
768 2005-11-24 Jim Meyering <jim@meyering.net>
770 * tests/Makefile.am (EXTRA_DIST): Add acl to the list.
771 * tests/acl: Add `$0: ' prefix to diagnostics.
773 * .x-sc_require_config_h: Add lib/buffer-lcm.c to the list.
775 2005-11-23 Paul Eggert <eggert@cs.ucla.edu>
777 * src/copy.c: Improve performance a bit by optimizing away
778 unnecessary system calls and going to a block size of at least
779 8192 (on normal hosts, anyway). This improved performance 5% on my
780 Debian stable host (2.4.27 kernel, x86, copying from root
781 ext3 file system to itself).
782 Include "buffer-lcm.h".
783 (copy_reg): Omit last argument. All callers changed.
784 Use xmalloc to allocate rather than trusting alloca
785 (which is unwise with large block sizes).
786 Declare locals more locally, if possible.
787 Use uintptr_t words instead of int words, for a bit more speed
788 when looking for null blocks on 64-bit hosts.
789 Optimize away reads of zero bytes on regular files.
790 In the typical case, insist on 8 KiB buffers, at least.
791 Avoid unnecessary extra call to fstat when checking for sparse files.
792 Avoid now-unnecessary cast to off_t, and "0L".
793 Avoid unnecessary test of *new_dst when checking for same owner
796 2005-11-22 Paul Eggert <eggert@cs.ucla.edu>
798 * src/remove.c (rm): Don't assume C99 for-loop syntax.
800 2005-11-22 Jim Meyering <jim@meyering.net>
802 * src/remove.c (AD_push): Remove debugging cruft.
804 * tests/rm/unread2 (rm): Change expected diagnostic,
805 `cannot open directory' to `cannot remove', to align with
807 * tests/rm/rm2: Ensure that rm now continues removing entries
808 even after certain types of failure.
810 * src/remove.c: Rewrite. Now, this module is reentrant on systems
811 that provide openat (Solaris), and on systems like Linux+procfs
812 where our openat emulation code is reentrant. This also fixes a
813 few low-probability leaks and eliminates some code that could,
814 in very unusual circumstances, cause rm() (via a callee) to exit.
815 * NEWS: Mention this.
817 * configure.ac: Put copyright dates all on one line so the
818 emacs function that updates them works properly.
820 2005-11-18 Paul Eggert <eggert@cs.ucla.edu>
822 * configure.ac (AM_PROG_CC_C_O): Add. Needed for CVS Automake.
823 Problem reported by Eric Blake.
824 (AC_PROG_CC_STDC): Use this instead of AC_PROG_CC, so that
825 we get a standard-conforming compiler. This relies on the new
826 m4/c.m4 file. Note that it's a bit tricky, since c.m4 doesn't
827 define AC_PROG_CC_STDC; we are relying on Autoconf 2.59 internals.
828 m4/c.m4 can go away with Autoconf 2.60 comes out.
830 2005-11-17 Jim Meyering <jim@meyering.net>
832 * src/remove.c (AD_mark_helper): Make a `char *' parameter `const'.
833 (AD_mark_current_as_unremovable): Likewise, but for a local.
836 * tests/mv/acl: Let traps handle removing temporary directories.
838 Expect acl-related tests to fail, until the corresponding
839 patches are committed.
840 * tests/mv/Makefile.am (XFAIL_TESTS): Add acl.
841 * tests/cp/Makefile.am (XFAIL_TESTS): Likewise.
843 ACL tests, from Andreas Gruenbacher.
844 * tests/acl, tests/mv/acl, tests/cp/acl: New files.
845 * tests/mv/Makefile.am (TESTS): Add acl.
846 * tests/cp/Makefile.am (TESTS): Add acl.
848 * src/ls.c (basename_is_dot_or_dotdot): Correct wording in comment.
850 2005-11-16 Paul Eggert <eggert@cs.ucla.edu>
852 * NEWS: Improve quality of ln's diagnostics.
853 * src/ln.c (do_link, usage): Likewise.
854 (do_link): Don't use alloca on a buffer of unbounded size.
856 2005-11-16 Jim Meyering <jim@meyering.net>
858 * tests/cp/fail-perm: Accommodate HPUX. It appears to fail
859 with EACCES rather than EPERM. Reported by Peter O'Gorman here:
860 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/5766
862 2005-11-14 Jim Meyering <jim@meyering.net>
864 * NEWS (sort): Mention consequences of today's mkstemp-safer.c fix.
866 2005-11-13 Jim Meyering <jim@meyering.net>
868 * announce-gen: Accept new option, --gpg-key-id=ID and
869 emit a blurb telling how to use the .sig files.
870 * Makefile.cfg (gpg_key_ID): Define.
871 * Makefile.maint (announcement): Use new option and key.
873 Require that most .c files include <config.h>.
874 * Makefile.maint (sc_require_config_h): New rule.
875 (syntax-check-rules): Add it.
876 * .x-sc_require_config_h: New file listing exceptions to the
877 above rule. Some are legit, others are simply grandfathered in.
878 * Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h here, too.
880 2005-11-12 Jim Meyering <jim@meyering.net>
882 * src/checksum.h, src/md5.c, src/sha1sum.c: Remove now-unused files.
884 2005-11-11 Jim Meyering <jim@meyering.net>
886 * NEWS: Mention `readlink -f' bug fix in 5.3.0 news.
887 Mention new readlink options in 5.3.0's `New features' section.
888 Spotted by Thomas Hood.
890 2005-11-08 Jim Meyering <jim@meyering.net>
892 * NEWS: Merge in changes from b5_9x branch.
894 2005-11-08 Paul Eggert <eggert@cs.ucla.edu>
896 * NEWS: ls now defaults to --time-style='locale', which in turn acts
897 like --time-style='posix-long-iso' if the locale settings are messed up.
898 * src/ls.c (decode_switches): Implement this.
900 2005-11-08 Jim Meyering <jim@meyering.net>
902 * tests/du/2g: s/expensive/very expensive/ in a comment.
905 2005-10-17 Eric Blake <ebb9@byu.net>
907 * src/ls.c (usage): Fix descriptions of --sort, --time.
908 Reported by Vitaly A. Ostanin.
910 2005-11-04 Paul Eggert <eggert@cs.ucla.edu>
912 * src/ln.c: Include filenamecat.c.
913 (FILE_BASENAME_CONCAT): Remove.
914 (do_link): Remove last arg DEST_IS_DIR. All callers changed.
915 (main): Use file_name_concat, base_name, and strip_trailing_slashes
916 instead of FILE_BASENAME_CONCAT. This simplifies the code, and avoids
919 2005-11-04 Jim Meyering <jim@meyering.net>
921 * src/du.c (process_file): Don't overflow for files of size >= 2^31
922 on systems with stat.st_blocks of a signed 32-bit type.
923 This bug causes trouble on some AIX 5.1 systems.
924 Report and trivial patch from Paul Townsend:
925 <http://lists.gnu.org/archive/html/bug-coreutils/2005-11/msg00033.html>
926 * NEWS: Mention this.
928 * tests/du/2g: New (very-expensive) test for the above-fixed bug.
929 * tests/du/Makefile.am (TESTS): Add it here.
930 * tests/very-expensive: New file.
931 * tests/Makefile.am (EXTRA_DIST): Add it here.
932 * tests/cp/perm: Mark this test as `very-expensive', too.
934 2005-11-02 Paul Eggert <eggert@cs.ucla.edu>
936 * NEWS: Mention that rm -d and maybe ln -d are scheduled for
938 * src/remove.h (struct rm_options): Remove unlink_dirs. All uses
940 * src/rm.c (usage): Don't mention rm -d.
942 2005-11-02 Jim Meyering <jim@meyering.net>
944 * tests/dd/skip-seek: Fix typo in comment: s/fileutils/coreutils.
947 * tests/dd/unblock-sync: Redirect stderr to /dev/null so the
948 `M+N records in/out' lines don't pollute `make check' output.
950 * tests/dd/skip-seek (sk-seek4): New test, to exercise the bug
951 fixed on 2005-10-31. This test uses the new, IN_PIPE specifier.
952 * tests/Coreutils.pm: Accept a new type of input specifier: IN_PIPE,
953 to indicate that the input file should be piped into the command
954 under test (via `cat FILE | $prog ...').
956 * src/remove.c (remove_entry): Emit a better diagnostic when rm
957 (without -r) fails to remove a directory on a non-Linux system.
958 This change affects only newer Solaris systems (with priv_*
959 functions like priv_allocset). Reported by Keith Thompson.
961 * tests/rm/dir-nonrecur: New file/test for the above fix.
962 * tests/rm/Makefile.am (TESTS): Add dir-nonrecur.
964 2005-11-01 Paul Eggert <eggert@cs.ucla.edu>
966 * NEWS: "tail -c 2 FILE" and "touch 0101000000" now operate as
967 POSIX 1002.1-2001 requires.
968 * src/tail.c (parse_obsolete_option): Implement this.
969 Problem reported by Vincent Lefevre.
970 * src/touch.c (main): Pass PDS_PRE_2000 to posixtime.
971 * tests/tail/Test.pm (c-2, c-2-minus, c2, c2-minus): New tests.
972 (test_vector): Add special cases for _POSIX2_VERSION, and
973 regularize the old ones a bit.
974 * tests/touch/obsolescent: Add y2000 test.
976 2005-10-31 Paul Eggert <eggert@cs.ucla.edu>
978 * src/dd.c (skip): Fix off-by-one error reported by
979 Theodoros V. Kalamatianos.
981 2005-10-30 Paul Eggert <eggert@cs.ucla.edu>
983 * tests/mkdir/p-3: Require that the test be run as non-root.
984 Problem and trivial fix reported by Theodoros V. Kalamatianos.
986 2005-10-28 Paul Eggert <eggert@cs.ucla.edu>
988 * src/ln.c (FILE_BASENAME_CONCAT): Omit unnecessary slashes in the
989 boundary between DEST and SOURCE in the result.
991 2005-10-26 Dmitry V. Levin <ldv@altlinux.org>
993 * src/md5sum.c (main) [!O_BINARY]: Changed default read mode
994 back to text, to sync with documentation and for backwards
997 2005-10-25 Jim Meyering <jim@meyering.net>
999 * tests/dircolors/simple (other-wr): Add an explicit test for
1000 the dircolors bug (NULL-dereference) fixed yesterday.
1002 2005-10-24 Jim Meyering <jim@meyering.net>
1004 * src/tac.c (tac_file): When determining whether a file is seekable,
1005 also test whether it is a tty. Using only the lseek-based test would
1006 give a false positive on Solaris. Reported by Peter Fales.
1008 2005-10-24 Dmitry V. Levin <ldv@altlinux.org>
1010 * tests/install/d-slashdot: New test, for "install -d" failure.
1011 * tests/install/Makefile.am (TESTS): Add d-slashdot.
1012 * tests/mkdir/p-slashdot: New test, for "mkdir -p" failure.
1013 * tests/mkdir/Makefile.am (TESTS): Add p-slashdot.
1015 2005-10-24 Jim Meyering <jim@meyering.net>
1017 * src/dircolors.c (ls_codes): Add missing comma.
1018 Anonymous report and patch from
1019 http://savannah.gnu.org/bugs/?func=detailitem&item_id=14849
1021 * src/dircolors.c: Add compile-time assertion that the slack_codes
1022 and ls_codes arrays have the same number of elements. This would
1023 have prevented the above-fixed bug.
1025 * src/expand.c (parse_tab_stops): Add a comment to make this function
1026 identical to the one in unexpand.c.
1027 * src/unexpand.c (parse_tab_stops): Adjust syntax to make this function
1028 identical to the one in expand.c.
1030 * src/expand.c (next_file): Don't assume fopen cannot return stdin.
1032 2005-10-23 Jim Meyering <jim@meyering.net>
1034 * src/md5sum.c (digest_check, main): Use ptr_align rather than
1035 a dangerous pointer-value-to-`unsigned' cast.
1036 * NEWS: mention the new sha* programs.
1037 * AUTHORS: Add new sha* programs.
1039 2005-08-28 David Madore <david.madore@ens.fr>
1041 Add new programs: sha224sum, sha256sum, sha384sum, sha512sum.
1042 * README: Add their names to the list.
1043 * src/md5sum.c: Provide framework for computing sha-2 hashes.
1044 * src/Makefile.am (sha224sum, sha256sum, sha384sum, sha512sum):
1045 Rules for compiling sha-2 utilities
1046 (noinst_HEADERS): Remove checksum.h.
1047 * man/sha512sum.x, man/sha384sum.x, man/sha256sum.x, man/sha224sum.x:
1049 * man/Makefile.am (dist_man_MANS): Add the corresponding .1 names.
1050 (sha224sum.1, sha256sum.1, sha384sum.1, sha512sum.1): New dependencies.
1051 * tests/misc/sha224sum, tests/misc/sha256sum: New files.
1052 * tests/misc/sha384sum, tests/misc/sha512sum: New files.
1053 * tests/misc/Makefile.am (TESTS): Add new sha224sum, sha256sum,
1054 sha384sum, sha512sum test scripts here rather that each in its
1057 2005-08-28 David Madore <david.madore@ens.fr>
1059 * tests/sha1sum/basic-1 (million-a): Add the "million a's" test (one
1060 of the FIPS test vectors).
1062 2005-10-23 Jim Meyering <jim@meyering.net>
1064 * configure.ac: Use 6.0-cvs as the version string.
1065 * NEWS: Adjust accordingly.