1 2006-08-09 Paul Eggert <eggert@cs.ucla.edu>
3 * src/.cvsignore: Add shuf.
5 * Makefile.maint: Remove the po-update procedure; it doesn't
6 work with the new repository on http://www.iro.umontreal.ca/.
7 For now I guess we'll have to fix things by hand.
8 (do-po-update, po-update): Remove. All references removed.
10 * src/shuf.c (next_line): New function.
11 (read_input): Use it, to avoid relying on GCC-specific behavior
12 with void * arithmetic. Problem reported by Bob Proulx.
13 * Makefile.maint (my-distcheck): Compile with -Wpointer-arith
14 to detect this sort of problem automatically in the future.
16 2006-08-09 Jim Meyering <jim@meyering.net>
18 * src/ls.c: Add a compile-time check to ensure that filetype
19 and filetype_letter have the same number of elements.
21 * tests/misc/sort-rand: Remove use of --seed=S.
23 2006-08-08 Paul Eggert <eggert@cs.ucla.edu>
25 Add a command 'shuf', and modify shred and sort to use the new
26 random number generator library of 'shuf'.
30 * NEWS: Likewise. Mention new --random-source option for shred
31 and sort. Move "sort +1 -2" notice to the appropriate section,
32 and clarify its role with respect to POSIXLY_CORRECT.
33 * man/.cvsignore: Add shuf.1.
34 * man/Makefile.am (dist_man_MANS): Add shuf.1.
35 (shuf.1): New dependency.
36 * man/shuf.x: New file.
37 * src/Makefile.am (bin_PROGRAMS): Add shuf.
38 (EXTRA_DIST): Remove rand-isaac.c.
39 (shuf_LDADD): New macro.
40 * src/rand-isaac.c: Remove, moving most of its contents to
42 * src/shuf.c: New file.
43 * src/shred.c: Use new random-number interface rather than rand-isaac.c.
44 Don't include rand-isaac.c; include randint.h and randread.h instead.
45 (RANDOM_SOURCE_OPTION): New enum.
46 (long_opts, usage, main): New option --random-source.
47 * src/sort.c: Likewise.
48 * src/shred.c (struct irand_state, irand_init, irand32, irand_mod): Remove.
49 All callers changed to use randint interface.
50 (fillrand): Remove. All callers changed to use randread interface.
51 (dopass): Remove dependency on ISAAC buffer size.
52 (genpattern): Don't wipe the random state here.
53 (randint_source): New static var.
54 (clear_random_data): New function.
55 (main): Allocate random source, and arrange to wipe it on exit.
56 * src/sort.c: Include md5.h, randread.h, xmemxfrm.h.
57 (longopts, usage, main): Remove undocumented --seed option;
58 it's now replaced by --random-source.
59 (rand_state, get_hash): Remove.
60 (randread_source): New static var.
61 (random_state, cmp_hashes, compare_random): New functions; they guarantee
62 no collisions in the random hash function.
63 (keycompare): Use compare_random for -R; don't fall back on comparing
64 via memcoll, since compare_random does the right thing.
65 * tests/misc/Makefile.am (TESTS): Add shuf.
66 * tests/misc/shuf: New file.
68 2006-07-29 Paul Eggert <eggert@cs.ucla.edu>
70 * src/copy.c (set_author): Preserve the st_author field via the
71 file descriptor dest_desc.
73 2006-07-28 Paul Eggert <eggert@cs.ucla.edu>
75 * NEWS: chmod now preserves setuid and setgid bits on directories
76 if you use a numeric mode with them clear, e.g., "chmod 755 DIR".
78 Fix test case problems if working directory is setgid,
79 reported by Bob Proulx.
80 * tests/cp/fail-perm: Use symbolic mode so that we clear
81 setgid bit more reliably on directories.
82 * tests/mkdir/special-1 (set_mode_string): Likewise.
84 2006-07-27 Jim Meyering <jim@meyering.net>
86 * src/chgrp.c (usage): Use correct grammar in description of the
88 * src/chown.c (usage): Likewise.
90 2006-07-26 Thomas Schwinge <tschwinge@gnu.org> (tiny change)
92 * src/copy.c (set_author) [HAVE_STRUCT_STAT_ST_AUTHOR]:
93 Correctly access SRC_SB's element ST_AUTHOR.
95 2006-07-26 Jim Meyering <jim@meyering.net>
97 * tests/ls/stat-failed: Adapt to match new expected output.
100 * src/ls.c (print_color_indicator): Test for S_IFREG first, rather
101 than having the code test for all of the other types first.
102 Hoist the set-uid/gid-testing code "up" into this new block.
103 Classify any other type of file (e.g., S_TYPEISSHM, etc.) as
104 C_ORPHAN, not as C_FILE.
106 2006-07-26 Jim Meyering <jim@meyering.net>
108 Checking in a change from Paul.
110 2006-07-25 Paul Eggert <eggert@cs.ucla.edu>
112 * src/ls.c (DT_INIT): Remove. All uses removed.
113 (enum filetype): Use an ordinary enum rather than trying to keep
114 the values in sync with DT_FIFO etc. That way, we don't have
115 to make special assumptions about them. All uses changed.
116 (whiteout): New constant member of enum filetype.
117 (filetype_letter): New constant, for use with enum filetype.
118 (FILETYPE_INDICATORS): New initializer list.
119 (print_dir): Add case for DT_WHT.
120 (gobble_file): If stat fails, don't discard information from
121 readdir; instead, preserve it so it can be printed.
122 (print_long_format): Fall back on readdir result if stat info
123 is not available. Use "?" to denote each unknown mode char,
124 instead of an overall "?", since we now know some of the mode
126 (print_type_indicator): Now that MODE isn't necessarily
127 useful, guard all uses.
128 Now that two blocks in the type-checking tree can set "type = C_FILE",
129 move the suffix-handling code out and down.
131 2006-07-26 Jim Meyering <jim@meyering.net>
133 Prepare for the above change.
134 * src/ls.c [struct fileinfo] (stat_ok): Rename from stat_failed,
135 and adjust uses. From a patch by Paul Eggert.
137 2006-07-26 Jim Meyering <jim@meyering.net>
139 * src/ls.c: Correct indentation/formatting in a few places.
141 2006-07-25 Paul Eggert <eggert@cs.ucla.edu>
143 * tests/cp/fail-perm: Use "chmod 0500" rather than "chmod 500".
144 Problem report and fix from Bob Proulx.
145 * NEWS: Clarify the "chmod 0500" news, and correct the vague
146 statements about compatibility with BSD.
148 2006-07-25 Jim Meyering <jim@meyering.net>
150 * src/ls.c (gobble_file): When handling a stat-failed entry,
151 print the entry name not the absolute_name -- to be consistent
153 * tests/ls/stat-failed: Update accordingly.
155 * src/ls.c: Add parens around the new uses of ?: ternary operator.
157 * src/dircolors.hin: Mention that ORPHAN refers not just to dangling
160 Get --dired offsets right when handling stat-failed entries.
161 * src/ls.c (print_long_format): Be careful to increment P by the
162 appropriate amount, even when inode_number_width and nlink_width
164 * tests/ls/stat-failed: Test for the above.
166 * src/ls.c (gobble_file) [USE_ACL]: Don't use-uninitialized the
167 have_acl member. That would happen for a directory with both a
168 non-stat'able entry and one with an ACL.
170 * src/ls.c (gobble_file): Make it so failure to stat a
171 non-command-line file provokes an exit status of 1, not 0.
172 Say "cannot access" rather than "cannot stat".
173 * tests/ls/stat-failed: New file/test, for the above.
174 * tests/ls/Makefile.am (TESTS): Add stat-failed.
175 * tests/ls-2/tests (no-a-isdir-b): Update to reflect addition
176 of "cannot access " to diagnostic.
178 * src/ls.c: Declare stat_failed to be "bool", not "int" everywhere.
180 * src/ls.c [enum filetype] (command_line): Remove member. Not needed.
181 Replace all occurrences of "type == command_line" with the
182 equivalent, "command_line_arg".
184 * src/ls.c: Apply the stat-failed parts of Red Hat's
185 coreutils-selinux.patch. From Ulrich Drepper.
186 This makes it so files not mentioned on the command line (e.g.,
187 names read from a directory that *is* mentioned on the command
188 line) for which stat fails are still listed. With --color,
189 such files are colored just like ORPHANs (aka dangling symlinks).
191 * src/df.c (n_valid_args): Declare global to be static.
193 2006-07-24 Jim Meyering <jim@meyering.net>
195 * tests/ls/stat-dtype: Skip this test on reiserfs, since that file
196 system lacks d_type support.
198 2006-07-22 Paul Eggert <eggert@cs.ucla.edu>
200 * man/chmod.x: Update to reflect recent changes to coreutils.texi.
202 2006-07-21 Jim Meyering <jim@meyering.net>
204 * src/su.c (usage): Correct typo in --help output: s/commmand/command/
205 Reported by Tim Waugh.
206 Also remove the comment duplicating much of --help output.
208 * src/ls.c (FILE_TYPE_INDICATOR_OPTION): Reposition this new
209 name so the list remains alphabetized.
211 Fix another bug: ls --indicator-style=file-type would call
212 stat for a symlink, even though it wasn't always needed.
213 In some cases, that unnecessary stat would cause ls to fail.
214 * src/ls.c (gobble_file): Don't treat symlinks specially (in
215 requiring a stat syscall). Remove the offending exclusion.
217 * NEWS: Mention the fix.
219 * tests/ls/stat-dtype: New file/test, for the above fix.
220 Also exercises the new df feature, below.
222 * src/df.c (main): Fail and don't print the headers if no
223 file system is processed. This makes it easy to test whether
224 a specified directory is on a file system of a given type or types.
225 Otherwise, applications would have had to parse df's output.
226 E.g., is "." either ext3 or reiserfs: df -t ext3 -t reiserfs .
228 Fix a bug: ls --file-type worked like --indicator-style=slash,
229 rather than like --indicator-style=file-type.
230 * src/ls.c (FILE_TYPE_INDICATOR_OPTION): New enum member.
231 (long_options): Map "file-type" to FILE_TYPE_INDICATOR_OPTION,
233 (decode_switches): Handle new case: FILE_TYPE_INDICATOR_OPTION.
234 * NEWS: Mention the fix.
235 * tests/ls-2/tests (file-type): New test, for the above fix.
237 2006-07-19 Jim Meyering <jim@meyering.net>
239 * src/ls.c (print_dir): Give a better diagnostic for failed opendir.
241 * Makefile.am (EXTRA_DIST): Add build-aux/vc-list-files.
243 2006-07-16 Paul Eggert <eggert@cs.ucla.edu>
245 * NEWS: chmod, install, and mkdir now leave setgid and setuid bits
246 of directories alone unless you specify them explicitly.
247 install and mkdir now implement X correctly.
248 install now creates parent directories with mode 755, without
249 changing their owner or group.
250 * src/chmod.c (process_file): Adjust to mode_adjust API change.
251 * src/install.c: Include mkancesdirs.h.
252 (announce_mkdir, make_ancestor): New functions.
253 (DEFAULT_MODE): New macro, specifying initial value of 'mode'.
255 (dir_mode, dir_mode_bits): New vars.
256 (main): Set dir modes separately from nondir, so that the X
257 op of -m works correctly.
258 (main): Remove cwd_errno cruft, since make_dir_parents no longer
259 affects cwd. Adjust to new make_dir_parents API.
260 (install_file_in_file_parents): 2nd arg is now char *, not char
261 const *. Use mkancesdirs instead of rolling our own code.
262 (change_attributes): Don't worry about AFS, since that kludge
263 should not be needed any more.
264 * src/mkdir.c (struct mkdir_options): New struct.
265 (announce_mkdir, make_ancestor): New functions.
266 (main): Use them. Adjust to mode_adjust API change. Stick with
267 umask 0. Use make_dir_parents for all the work.
268 * src/mkfifo.c (main): Adjust to new mode_adjust API.
269 * src/mknod.c (main): Likewise.
270 * tests/chmod/setgid: Do the setgid test instead of bailing.
271 * tests/mkdir/p-3: Remove re_protect case that no longer applies.
272 GNU chmod now behaves like other versions of chmod.
273 * tests/mkdir/perm: Add a test for the X bug.
275 2006-07-14 Paul Eggert <eggert@cs.ucla.edu>
277 * src/base64.c (do_decode): Output to parameter OUT, not to stdout.
278 This doesn't fix any bugs, since OUT always equals stdout, but it
279 makes the code easier to understand.
281 2006-07-14 Jim Meyering <jim@meyering.net>
283 * Makefile.maint (CVS_LIST): Use new file, build-aux/vc-list-files,
284 rather than open-coding it. Now supports mercurial, too.
285 * .hgignore: New file.
286 * Makefile.am (EXTRA_DIST): Add .hgignore, which ignores nearly
287 all generated files, including ones like configure and po/*.po
288 that are currently version-controlled in cvs.
290 * Makefile.am (EXTRA_DIST): Add a few more .??* files.
291 They've been in CVS, just haven't been distributed before this.
292 Distribute ChangeLog-2005, too.
293 (MAINTAINERCLEANFILES): Add THANKS-to-translators.
295 2006-07-11 Paul Eggert <eggert@cs.ucla.edu>
297 * src/system.h: Assume <dirent.h> exists, since gnulib assumes
300 2006-07-09 Jim Meyering <jim@meyering.net>
302 * tests/mv/dir2dir: Adjust so failing with ENOTEMPTY is ok, too.
303 That happens with Linux/tmpfs.
304 * tests/mv/Makefile.am (TESTS): Add dir2dir.
306 2006-07-09 Paul Eggert <eggert@cs.ucla.edu>
308 Adjust to recent updates from gnulib.
309 * src/dd.c (apply_translations): Use toupper rather than
310 islower followed by toupper; it's simpler and typically
311 faster now that we assume at least C89 semantics. Similarly
313 * src/sort.c (inittables): Likewise.
314 * src/expand.c (expand): Don't assume that isprint etc. return
315 booleans (needed for pre-C99 hosts).
316 * src/fmt.c (check_punctuation): Likewise.
317 * src/ptx.c (initialize_regex, fix_output_parameters): Likewise.
318 * src/tr.c (is_char_class_member): Likewise.
319 * src/unexpand.c (unexpand): Likewise.
320 * src/join.c (is_blank): Remove; no longer needed. All uses
321 replaced by isblank (to_uchar (...)).
322 * src/pinky.c (create_fullname): Don't assume char is unsigned.
323 * src/printf.c (print_esc): Likewise.
324 * src/ptx.c (SKIP_NON_WHITE, SKIP_WHITE, SKIP_WHITE_BACKWARDS):
325 (copy_unescaped_string): Likewise.
326 * src/stat.c (print_it): Likewise.
327 * src/system.h (_D_EXACT_NAMELEN): Renamed from NLENGTH, for
328 convenience on GNU systems. All uses changed. Don't bother
329 looking for any dirent.h substitute other than ndir.h.
330 (D_INO): Remove unnecessary parentheses.
331 (IN_CTYPE_DOMAIN, ISGRAPH, ISPRINT, ISALNUM, ISALPHA):
332 (ISCNTRL, ISLOWER, ISPUNCT, ISSPACE, ISUPPER, ISXDIGIT):
333 (ISDIGIT_LOCALE, TOLOWER, TOUPPER): Remove. All uses changed
334 to ctype.h equivalents.
335 (isblank): Renamed from ISBLANK. Check for HAVE_DECL_ISBLANK too.
338 2006-07-08 Jim Meyering <jim@meyering.net>
340 * tests/mv/dir2dir: New file, test for 2006-07-05 fix in copy.c.
342 * Makefile.maint (sc_the_the): New rule.
344 * src/dd.c (skip): Remove one of two adjacent "the"s in a comment.
345 * tests/Coreutils.pm (run_tests): Remove one of two adjacent "then"s
348 2006-07-07 Jim Meyering <jim@meyering.net>
350 * NEWS: Mention that mv can now remove an empty destination directory,
351 and give an example. Prompted by a report from Florent Bayle.
353 2006-07-05 Jim Meyering <jim@meyering.net>
355 * src/ls.c (usage): Correct the description of -G: it is useful
356 only in a long listing. Reported by Martin Pool in
357 <https://launchpad.net/distros/ubuntu/+source/coreutils/+bug/51653>.
359 * man/chmod.x: Correct the description of the sticky bit. Reported
360 by Chris Moore via Ian Jackson in <http://bugs.debian.org/376745>.
362 * src/copy.c (copy_internal): Don't work around old NFS clients like
363 SunOS-4.1.4 and Irix 5.3 that set errno to values like EIO and
364 ENOTEMPTY upon failed rename. Otherwise, we risk misinterpreting
365 a banal failure as a recursive move-into-self failure.
366 Reported by Florent Bayle in <http://bugs.debian.org/376749>.
368 * src/c99-to-c89.diff: Regenerate, to remove fuzz.
370 2006-07-03 Jim Meyering <jim@meyering.net>
372 Plug another unusual leak.
373 (AD_mark_helper): Free malloc'd filename if hash_insert says
374 that string is already in the hash table.
376 The dev/inode of the topmost directory in each hierarchy were not
378 * src/remove.c (remove_cwd_entries): Don't call cycle_check here.
379 (AD_push): Call it from here instead.
382 * src/remove.c (AD_stack_clear): New function.
384 (AD_pop_and_chdir): Free *prev_dir just before longjmp.
386 * tests/Makefile.am, tests/*/Makefile.am: (TESTS_ENVIRONMENT):
387 Add $VG_PATH_PREFIX as a prefix to $PATH
389 * tests/envvar-check (vars): Add CDPATH and POSIXLY_CORRECT.
390 * tests/Makefile.am (evar-check): Remove rule.
391 (EXTRA_DIST): Remove .env-warn.
392 * tests/.env-warn: Remove file. No longer used.
393 Suggestion from Eric Blake.
395 2006-07-02 Paul Eggert <eggert@cs.ucla.edu>
397 * src/system.h: Include <stdint.h> unconditionally, since we
398 now assume the stdint module.
400 2006-07-01 Paul Eggert <eggert@cs.ucla.edu>
402 * NEWS: With no operand, 'tail -f' now silently ignores the '-f'
403 only if standard input is a FIFO or pipe and POSIXLY_CORRECT is set.
404 * src/tail.c (main): Implement this.
405 * tests/tail/Test.pm (f-pipe-1): Renamed from f-1.
406 (test_vector): Set POSIXLY_CORRECT for the f-pipe-* tests.
408 2006-07-01 Jim Meyering <jim@meyering.net>
410 * src/ln.c (do_link): Use new, shorter URL, for ag-review link.
412 * .x-sc_require_config_h: Add ^lib/xstrtold\.c$, so make distcheck
415 2006-06-30 Paul Eggert <eggert@cs.ucla.edu>
417 * NEWS: seq now uses long double internally rather than double.
418 It now defaults to a minimal fixed point format if possible.
419 It lets you use %a, %A, %E, %F, %G.
420 * src/Makefile.am (seq_LDADD): Remove $(SEQ_LIBM); add $(POW_LIB).
421 * src/seq.c: Don't include <math.h> or <xstrtol.h>; no longer needed.
422 (isfinite) [!defined isfinite]: New macro.
423 (separator, terminator): Now points to const.
424 (first, step, last): Remove.
425 (usage): Update to match new behavior.
426 (struct operand, operand): New type.
427 (scan_arg): Renamed from scan_double_arg, since we no longer use double.
429 Compute and return a value of type operand, not double.
430 (long_double_format): Renamed from valid_format, and now returns a
431 new format with an "L" added if needed, if the original format was
432 valid. Allow %a, %A, %E, %F, and %G formats.
433 (print_numbers): Take numeric values as args rather than from globals.
434 Print long double, not double.
435 (get_width_format): Remove.
436 (get_default_format): New function.
437 (main): Implement new way of calculating default format.
438 Don't worry about locale's representation of the decimal point, since
439 the arguments are always processed in the C locale.
440 * tests/seq/basic (neg-2): Adjust to new default format.
441 (eq-wid-1, eq-wid-2): Resurrect these tests, since the new
442 implementation should do the right thing.
444 2006-06-30 Jim Meyering <jim@meyering.net>
446 * tests/stty/basic-1: Work around an intermittent test failure
447 on HP-UX 11.11. Report and analysis from Bob Proulx.
448 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/7475
450 2006-06-28 Paul Eggert <eggert@cs.ucla.edu>
452 * NEWS: Support obsolete usages like "sort +1 -2" even when
453 conforming to POSIX 1003.1-2001, since this is a pure extension to
454 POSIX. Problem reported by Christian in:
455 http://lists.gnu.org/archive/html/bug-coreutils/2006-06/msg00220.html
456 * src/sort.c (main): Implement this.
458 * src/system.h (CLOSEDIR): Remove. All uses changed to closedir.
459 Autoconf 2.60 says this stuff was obsolete.
461 2006-06-28 Jim Meyering <jim@meyering.net>
463 * src/c99-to-c89.diff: Regenerate, to remove fuzz.
465 2006-06-28 Bob Proulx <bob@proulx.com> (tiny change)
467 * tests/mv/i-link-no: Work around HP-UX /bin/sh tracing problem
468 (set -x when VERBOSE=yes) when stderr is redirected before stdout
469 causing shell tracing of the stdout redirection to be written to
470 the stderr file. Avoid problem and test failure on HP-UX by
471 redirecting stderr last.
472 * tests/dd/unblock-sync: Order shell file redirections for
473 stderr and stdout in the common style.
476 2006-06-27 Jim Meyering <jim@meyering.net>
478 * tests/misc/cat-proc: Try to avoid any spurious numeric
479 differences in frequently-changing /proc/cpuinfo.
480 Reported by Nelson Beebe.
482 2006-06-26 Jim Meyering <jim@meyering.net>
484 Attempt rmdir (actually, unlinkat-with-AT_REMOVEDIR) upon any
485 fd_to_subdirp failure, not just when errno == EACCES.
486 * src/remove.c (remove_dir): Use unlinkat-with-AT_REMOVEDIR, not
487 rmdir, here, even though rmdir may happen to be adequate.
489 * NEWS: rm no longer fails to remove an empty, unreadable directory
490 * src/remove.c (remove_cwd_entries): If we can't open a directory,
491 and the failure is not being ignored, try to remove the directory
492 with rmdir (aka unlinkat-with-AT_REMOVEDIR), in case it's empty.
493 Problem report and test case from Paul Eggert in
494 <http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/7425>.
496 * tests/rm/empty-inacc: New test, for the above.
498 Avoid a segfault for wc --files0=- < /dev/null.
499 * src/wc.c (compute_number_width): Return right away if nfiles == 0.
501 2006-06-25 Jim Meyering <jim@meyering.net>
503 * NEWS: wc accepts a new option --files0-from=FILE, where FILE
504 contains a list of NUL-separated file names.
506 * src/wc.c: Include "readtokens.h".
507 (usage): Describe the new option, and adjust the `Usage':
508 with this option, no FILE may be specified on the command line.
509 (main): Handle the new option.
510 * tests/misc/wc-files0: New tests, for the above.
511 * tests/misc/wc-files0-from: Likewise.
512 * tests/misc/Makefile.am (TESTS): Add wc-files0.
514 2006-06-24 Jim Meyering <jim@meyering.net>
516 * src/md5sum.c (DIGEST_BUFFER): Remove now-unused definitions.
518 2006-06-22 Jim Meyering <jim@meyering.net>
520 * src/tee.c (tee_files): Rename from tee, to avoid conflict with
521 the function in glibc's <fcntl.h>. Reported by Andreas Schwab.
523 2006-06-19 Jim Meyering <jim@meyering.net>
525 * Makefile.cfg (local-checks-to-skip): Add changelog-check,
526 so this check is not run as part of "make distcheck".
528 2006-06-18 Bob Proulx <bob@proulx.com> (tiny change)
530 * tests/misc/pwd-long: Fix typo (s/neq/ne/) in previous change.
532 2006-06-18 Jim Meyering <jim@meyering.net>
534 * tests/misc/pwd-long: Make error output a little clearer.
536 2006-06-17 Jim Meyering <jim@meyering.net>
538 * tests/rm/inaccessible: Skip this test on systems without openat
539 support. Reported by Bob Proulx.
541 2006-06-15 Bob Proulx <bob@proulx.com> (tiny change)
543 * tests/misc/mknod: Improve permission checks to handle
544 running mkdir test in set-gid directories.
546 2006-06-14 Jim Meyering <jim@meyering.net>
548 * tests/du/basic: Revamp not to hard-code file system block sizes.
550 2006-06-12 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
552 * tests/du/Makefile.am (TESTS_ENVIRONMENT): Pass $(PERL), for
555 2006-06-11 Jim Meyering <jim@meyering.net>
557 * .gitignore: New file.
558 * Makefile.am (EXTRA_DIST): Add .gitignore.
560 Setting TIME_STYLE=long-iso in the environment would make the
561 cp/same-file test fail.
562 * tests/envvar-check (vars): Add TIME_STYLE to the list.
563 * tests/cp/same-file: Revert last change.
564 Source the envvar-check script, to ensure that TIME_STYLE
565 settings don't affect these tests.
567 2006-06-11 Paul Eggert <eggert@cs.ucla.edu>
569 * tests/cp/same-file: Execute 'ls' in the C locale, so that it
570 uses POSIX time stamp formats. Problem reported by John Nixon in
571 <http://lists.gnu.org/archive/html/bug-coreutils/2006-06/msg00062.html>.
573 2006-06-10 Jim Meyering <jim@meyering.net>
575 * NEWS: Mention the AIX-strndup-bug vs. dircolors workaround.
577 Require a "Version N.M" line at the top of the ChangeLog
578 file only when making the actual release, not when running
580 * Makefile.maint (maintainer-distcheck): Don't depend on
582 (alpha beta major): Depend on it here, instead.
584 2006-06-08 Jim Meyering <jim@meyering.net>
586 Ensure that cat works with any of the options, -A -v -e -E -T,
587 when applied to files in /proc and /sys, even when the FIONREAD
588 ioctl produces nonsensical results. Before this change, cat would
589 produce no output (or truncated output), for some linux kernels.
591 * src/cat.c (write_pending): New function, factored out of cat.
592 (cat): Also interpret a negative ioctl/FIONREAD count as indicating
593 that there are bytes to read. Some versions of linux-2.6.16 do that.
594 Write any pending output before returning.
595 Reported by Dan Jacobson in <http://bugs.debian.org/370583>.
596 * NEWS: Mention this bug fix.
597 * tests/misc/cat-proc: New file. Test for the above.
598 * tests/misc/Makefile.am (TESTS): Add cat-proc.
600 2006-06-07 Paul Eggert <eggert@cs.ucla.edu>
602 * src/expr.c (eval4): Detect overflow properly when multiplying
605 2006-06-06 Paul Eggert <eggert@cs.ucla.edu>
607 * NEWS: The 'expr' command now detects and reports integer overflow.
608 (It would be better to use extended precision instead, but that
610 * src/expr.c (integer_overflow): New function.
611 (eval4, eval3): Check for integer overflow.
613 2006-06-05 Paul Eggert <eggert@cs.ucla.edu>
615 Fix problems when building with Solaris/SVR4/etc. make, which uses a
616 different and somewhat bogus implementation of VPATH. In the
617 directory tests/misc, rename tests whose names might appear in the
618 Automake-generated rules. For example, we can't use a test named
619 'test', since Automake generates a rule that contains the text
620 "if test -f ./$$tst; ...", and this might expand to something like
621 "if ../../../coreutils-6.0/tests/misc/test -f ./$$test; ...",
622 which executes the 'test' script rather than the 'test' command.
623 * tests/misc/false-status: Renamed from tests/misc/false.
624 * tests/misc/pwd-long: Renamed from tests/misc/pwd.
625 * tests/misc/sort-merge: Renamed from tests/misc/sort.
626 ($prog): Set to 'sort' rather than to $PROG.
627 * tests/misc/test-diag: Renamed from tests/misc/test.
628 * tests/misc/Makefile.am (PROG): Take the basename of $$tst,
629 in case Solaris make has prepended the directory.
630 (TESTS): Adjust to above renamings.
631 * tests/misc/expand: Don't assign to PROG; no longer needed
632 now that Makefile.am sets PROG to the basename.
633 * tests/misc/fold: Likewise.
635 2006-06-03 Jim Meyering <jim@meyering.net>
637 Make `cp --link --no-dereference' work also on systems where the
638 link system call cannot create a hard link to a symbolic link.
639 * src/copy.c (copy_internal) [LINK_FOLLOWS_SYMLINKS]: Don't use
640 the link syscall on a symlink when it would do the wrong thing.
641 Based on the patch by Aurelien Jarno: <http://bugs.debian.org/329451>
642 * tests/cp/link-no-deref: New file/test for the above.
643 * tests/cp/Makefile.am (TESTS): Add link-no-deref.
644 * NEWS: Mention the change (doesn't affect Linux).
646 2006-06-01 Paul Eggert <eggert@cs.ucla.edu>
648 Fix some porting problems in the test cases reported by
649 Ralf Wildenhues for HP-UX 11.23 in:
650 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00238.html
651 * tests/help-version: Don't assume that \< \> works in sed.
652 * tests/misc/close-stdout: Don't assume that >&- works.
653 Add a /dev/full test.
654 * tests/touch/no-create-missing: Don't assume that >&- works.
656 2006-05-30 Jim Meyering <jim@meyering.net>
658 * src/ls.c (usage): Add `v' to the list of sorting-related options.
661 2006-05-28 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
663 * tests/cp/fail-perm: source lang-default.
664 * tests/rm/inaccessible: Likewise.
666 2006-05-28 Jim Meyering <jim@meyering.net>
668 * tests/rm/inaccessible: AIX 4.3.3 gives a different diagnostic.
669 Recognize it, too. Reported by Ralf Wildenhues, in
670 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
672 2006-05-27 Jim Meyering <jim@meyering.net>
674 * src/chgrp.c: Support new options: --preserve-root and
675 --no-preserve-root. Somehow this program was skipped when those
676 options were added to chown, chmod, and rm. Reported by
677 vaqflabuopac@spammotel.com in <http://bugs.debian.org/365656>.
678 * NEWS: Mention this.
680 2006-05-25 Paul Eggert <eggert@cs.ucla.edu>
682 * NEWS: Remove mention of --seed. We'll replace it with something
683 better, and don't want to indicate that it is supported.
684 * src/sort.c (usage): Likewise.
686 2006-05-20 Jim Meyering <jim@meyering.net>
688 * src/chmod.c (main): Use FTS_PHYSICAL here, too.
690 * src/du.c (main): Rename local, s/symlink_deref_bit/symlink_deref_bits/
691 and arrange for -D to set fts' FTS_PHYSICAL bit as well as
692 FTS_COMFOLLOW. Spotted by Justin Pryzby.
694 * gnupload: Merge changes from automake, retaining the ""--to...
695 kludge to placate overzealous `make distcheck' check.
697 2006-05-19 Jim Meyering <jim@meyering.net>
699 * src/du.c (main): Don't let -D, -L, or -P turn off the internal
700 FTS_TIGHT_CYCLE_CHECK directory traversal option.
701 Reported by Justin Pryzby in http://bugs.debian.org/367691
703 2006-05-15 Jim Meyering <jim@meyering.net>
705 * src/cp.c (usage): Correct description of -a: s/-dpR/-dpPR/.
708 2006-05-13 Jim Meyering <jim@meyering.net>
710 * tests/mv/no-target-dir: Test two more cases.
712 2006-05-11 Jim Meyering <jim@meyering.net>
714 mv -T DIR EMPTY_DIR no longer fails unconditionally
715 * src/copy.c (copy_internal): Don't manually prohibit a move where
716 the destination is an existing directory. Sometimes doing that is
717 valid. Let the rename system call enforce the rules. That is
718 allowed only when the source is a directory and the destination
719 directory (to be replaced) is empty. Reported by Eric Blake.
720 * tests/mv/no-target-dir: New file/test for this.
721 * tests/mv/Makefile.am (TESTS): Add no-target-dir.
722 * NEWS: Mention this.
724 * tests/mv/atomic: New file/test for yesterday's fix.
725 * tests/mv/Makefile.am (TESTS): Add atomic.
727 * tests/du/long-sloop: Avoid harmless `ambiguous redirect' diagnostic.
729 2006-05-10 Jim Meyering <jim@meyering.net>
731 * src/copy.c (copy_internal): Don't explicitly unlink the destination
732 when moving a symlink into the place of an existing non-directory.
733 Reported by Joshua Hudson.
734 * NEWS: mention this.
736 2006-05-07 Jim Meyering <jim@meyering.net>
738 * Makefile.maint (patch-check): Fail if patch generates any output,
739 even merely for changed offsets.
741 * src/c99-to-c89.diff: Adjust to reflect new offsets.
743 * NEWS: Mention changes affecting df, pwd, shred.
745 2006-05-06 Jim Meyering <jim@meyering.net>
747 * tests/ls/stat-vs-dirent: New test, to detect the bogus file
748 system condition where dirent.d_ino != stat.st_ino.
749 * tests/ls/Makefile.am (TESTS): Add stat-vs-dirent.
751 2006-05-06 Eric Blake <ebb9@byu.net>
753 * tests/ls/inode: Expand to test inode from readdir case.
754 * tests/ls/follow-slink: Expand to test broken links encountered
755 implicitly, favoring Solaris 9 and OpenBSD 3.4 behavior.
757 2006-05-06 Eric Blake <ebb9@byu.net>
759 * tests/mv/leak-fd: Work even on case-insensitive file system.
761 2006-05-04 Jim Meyering <jim@meyering.net>
763 * NEWS: Mention the 2006-03-19 pwd-related change that makes
764 lib/getcwd.c work around inconsistent file system dirent.d_ino data.
766 2006-05-03 Jim Meyering <jim@meyering.net>
768 * src/ls.c (DEFINE_SORT_FUNCTIONS, LIST_SORTFUNCTION_VARIANTS):
769 Use better macro parameter names: s/basename/key_name/,
770 s/basefunc/key_cmp_func. Fix typo in comment.
772 2006-04-29 Eric Blake <ebb9@byu.net>
774 * src/ls.c (main): On systems with d_type, directories_first only
775 implies format_needs_type, not format_needs_stat.
777 2006-05-03 Jim Meyering <jim@meyering.net>
779 * src/ls.c (xstrcoll_df_version, rev_xstrcoll_df_version): Add space
780 after comma in arg list, from Eric Blake.
782 2006-04-25 Paul Eggert <eggert@cs.ucla.edu>
784 * tests/misc/date (relative-3): New test, derived from a bug
785 report by John Thomas McDole.
787 2006-04-23 Francesco Montorsi <fr_m@hotmail.com>
789 New option for ls: --group-directories-first.
790 It makes ls list directories before files.
791 * NEWS [New features]: Mention it.
792 * src/ls.c (sort_type): Rearrange to use as an array index when
793 choosing sort function; added new sort_numtypes member for
795 (time_type): Add new time_numtypes member for compile-time check.
796 (directories_first): New global variable.
797 (GROUP_DIRECTORIES_FIRST_OPTION): New enum.
798 (long_options): Add --directories-first.
799 (main): Support new option.
800 (is_directory): New function.
801 (extract_dirs_from_files): Use it.
802 (DIRFIRST_CHECK, DEFINE_SORT_FUNCTIONS)
803 (LIST_SORTFUNCTION_VARIANTS): New macros.
804 (sort_functions): New global variable.
805 (sort_files): Use it.
806 (usage): Document new option.
808 2006-04-18 Paul Eggert <eggert@cs.ucla.edu>
810 * src/shred.c (fillrand): The assertion was way too weak, due to
811 what must be a typo. Strengthen it to its intended value.
812 (dopass): Don't use alloca; it's not worth the aggravation here,
813 since it's used only to get a page-aligned buffer, and page
814 alignment doesn't buy us much here. I'm suspicious that alloca
815 causes problems on some hosts, due to a recent bug report by Adam
816 Waltman: http://bugs.gentoo.org/130246.
818 2006-04-18 Jim Meyering <jim@meyering.net>
820 * tests/misc/tty-eof: Add new programs, base64, sha224sum, sha256sum,
821 sha384sum, sha512sum.
823 2006-04-17 Paul Eggert <eggert@cs.ucla.edu>
825 * src/chmod.c (describe_change): Adjust to filemode changes.
826 * src/ls.c (HAVE_ST_DM_MODE): Remove; moved to ../lib/filemode.c.
827 (print_long_format): Use (new) filemodestring rather than
828 (old) mode_string, so that we get more file types right, at least
829 in theory. Adjust to filemode changes.
830 * src/stat.c (human_access): Likewise.
832 2006-04-18 Jim Meyering <jim@meyering.net>
834 * src/ptx.c (main) [DEFAULT_IGNORE_FILE]: Remove code to use a default
835 ignore file. This has never been enabled. Reported by Eric Blake.
837 2006-04-12 Paul Eggert <eggert@cs.ucla.edu>
839 * src/ln.c (linkfunc): Remove. This method ran into a compiler/linker
840 bug in Interix. Just call symlink or link directly. All uses changed.
841 * src/setuidgid.c (main) [! HAVE_SETGROUPS]: Don't call setgroups.
842 * src/stat.c (USE_STATVFS): New macro.
843 Include <sys/statvfs.h> and use statvfs only if USE_STATVFS.
844 (NAMEMAX_FORMAT): define a bit more clearly, now that the
845 statvfs-using code is a bit more regular.
846 * src/system.h (sync) [!HAVE_SYNC]: New macro.
848 2006-04-11 Paul Eggert <eggert@cs.ucla.edu>
850 * NEWS: csplit, nl, expr now conform to POSIX better, and are
851 more-compatible with traditional Unix, with respect to regular
853 * src/csplit.c (extract_regexp): Set re_syntax_options to a
854 value that is compatible with what POSIX requires.
855 * src/nl.c (build_type_arg): Likewise.
856 * src/expr.c (docolon): Likewise. Also, don't let anchors match
857 newline; this fixes an incompatibility with tradition and with POSIX.
858 Don't warn about leading ^. POSIX says it is unspecified whether
859 ^ is a special character, which means that implementations can
860 either treat it as special or not, but either way a warning is not
861 allowed (unless the regexp is otherwise invalid). Instead, anchor
862 the expression but treat ^ as an anchor; this is the traditional
863 behavior (e.g., Solaris 10).
864 (eval4, eval3, eval2): Treat non-numeric args, division by zero,
865 and the like as invalid expressions (exit status 2), not as
866 failure of 'expr' (exit status 3). This is more consistent with
868 * tests/expr/basic (fail-a): Adjust exit status to match new expr
869 behavior, for status 2 versus 3.
871 (bre1, bre2, bre3, bre4, bre5, bre6, bre7, bre8, bre9, bre10):
872 (bre11, bre12, bre13, bre14, bre15, bre16, bre17, bre18, bre19, bre20):
873 (bre21, bre22, bre23, bre24, bre25, bre26, bre27, bre28, bre29, bre30):
874 (bre31, bre32, bre33, bre34, bre35, bre36, bre37, bre38, bre39, bre40):
875 (bre41, bre42, bre43, bre44, bre45, bre46, bre47, bre48, bre49, bre50):
876 (bre51, bre52, bre53, bre54, bre55, bre56, bre57, bre58, bre59, bre60):
877 (bre61, bre62): New tests.
878 * tests/misc/csplit: Use \{...\} in test RE, to test that we're
882 * tests/du/long-from-unreachable: Solaris 8 sh doesn't understand
883 "if !". Do not assume that 'sed' can handle long, newline-free input.
884 * tests/du/long-sloop: Likewise. Evaluate expr once, not $n times.
886 2006-04-10 Paul Eggert <eggert@cs.ucla.edu>
888 Adjust to new regex.h API (with new fastmap type), and clean
889 up the regex storage allocation a bit.
891 * src/csplit.c (struct control): Put re_compiled member at the
892 end, since it's large. Change regexpr member from char * to bool;
893 all uses changed. Add new member fastmap.
894 (extract_regexp): regexp arg is now char const *, not char *.
895 Don't bother duplicating the regular expression; it's not needed.
896 Set fastmap from new fastmap member. Don't bother allocating
897 a buffer, as the regexp code does a better job than we do.
898 * src/expr.c (docolon): Allocate and use a fastmap.
899 Don't bother allocating a buffer.
900 * src/nl.c (body_fastmap, header_fastmap, footer_fastmap):
902 (build_type_arg): New fastmap arg. All uses changed.
903 Don't bother allocating a buffer, but set a fastmap.
904 * src/ptx.c (context_regex_string, word_regex_string): Remove.
905 (context_regex, word_regex): New vars, replacing the above.
907 (struct regex_data): New type.
908 (compile_regex): Renamed from alloc_and_compile_regex, since
909 we no longer allocate storage. Arg is now a struct regex_data *,
910 not a const char *. All uses changed. Don't allocate the fastmap;
911 instead, take it from the caller. Don't convert size_t to int,
912 to avoid arithmetic overflow problems. Don't bother freeing
913 storage afterwards; it's not worth the aggravation.
914 * src/tac.c (compiled_separator_fastmap): New ver.
915 (main): Use it. Don't bother allocating a buffer.
917 2006-03-30 Jim Meyering <jim@meyering.net>
919 * src/dd.c (iwrite): Remove assignment without effect.
920 Reported by Felix Rauch Valenti.
922 2006-03-22 Eric Blake <ebb9@byu.net>
924 * src/ptx.c (usage): Remove mention of --copyright/-C.
925 (main): Alias --copyright to --version plus a deprecation warning.
926 * NEWS: Mention this.
928 2006-03-27 Jim Meyering <jim@meyering.net>
930 * src/Makefile.am (uptime_LDADD): Add $(POW_LIB), for uptime's
931 use of strtod. Tiny patch from Nickolai Zeldovich.
933 2006-03-11 Eric Blake <ebb9@byu.net>
935 * tests/misc/dirname: New file.
936 * tests/basename/Makefile.am: Delete.
937 * tests/basename/basic: Move to...
938 * tests/misc/basename: ... this new file. Add some tests,
939 including fixed behavior for //.
940 * tests/misc/Makefile.am (TESTS): Sort. Add basename, dirname.
941 * tests/Makefile.am (SUBDIRS): Remove basename.
942 * configure.ac (AC_CONFIG_FILES): Remove tests/basename.
944 Improvements to dirname/basename handling on platforms like
945 cygwin with distinct // and with drive letters.
946 * NEWS: Document new behavior.
947 * src/basename.c (main): Don't strip suffix from file system
949 * src/cp.c (target_directory_operand): Use new last_component.
950 (ASSIGN_BASENAME_STRDUPA): Likewise. Reduce time spent
951 traversing the string.
952 * src/dircolors.c (guess_shell_syntax): Use new last_component.
953 * src/install.c (target_directory_operand, install_file_in_dir):
955 * src/ln.c (target_directory_operand, main): Likewise.
956 * src/ls.c (basename_is_dot_or_dotdot): Likewise.
957 * src/mv.c (target_directory_operand, movefile): Likewise.
958 * src/remove.c (rm_1): Likewise.
959 * src/shred.c (wipename): Likewise.
960 * src/split.c (next_file_name): Likewise.
961 * src/su.c (log_su, run_shell): Likewise.
963 2006-03-23 Paul Eggert <eggert@cs.ucla.edu>
965 * NEWS: nohup diagnostics are now more precise, and nohup now
966 redirects stderr to nohup.out if stdout is closed and stderr is a tty.
967 * src/nohup.c (main): Implement this.
968 * tests/misc/nohup: Test the new behavior.
970 2006-03-12 Jim Meyering <jim@meyering.net>
972 * src/copy.c (set_author): Rename function, from preserve_author.
974 * src/remove.c (AD_pop_and_chdir): Use new macro,
975 CYCLE_CHECK_REFLECT_CHDIR_UP, rather than open-coding it.
977 * src/system.h (SAME_INODE): Remove definition.
978 Include "same-inode.h", instead.
980 2006-03-11 Eric Blake <ebb9@byu.net>
982 * src/pwd.c (robust_getcwd): Prepend only one slash, not two.
984 2006-03-10 Jim Meyering <jim@meyering.net>
986 Fix a bug whereby a user with write access to a directory being removed
987 could cause the removal of that directory to fail with an erroneous
988 diagnostic about a directory cycle. Reported by Vineet Chadha.
990 * NEWS: Mention this.
991 * src/remove.c (AD_pop_and_chdir): If the directory we're about to
992 leave (and try to rmdir) is the one whose dev_ino is being used to
993 detect a cycle, reset cycle_check_state.dev_ino to that of the parent.
995 2006-03-08 Paul Eggert <eggert@cs.ucla.edu>
997 * NEWS: Document dd's new 'directory' and 'nolinks' flags.
998 * src/dd.c (set_fd_flags): Handle file-creation flags on file
999 descriptors, rather than ignoring them.
1000 * tests/dd/misc: Add test cases for append, nofollow, directory,
1001 and nolinks flags. Simplify redirection to /dev/null in some cases.
1003 * tests/dd/misc: iflags->iflag. This fixes a typo that meant the
1004 noatime test never tested anything.
1006 2006-03-05 Paul Eggert <eggert@cs.ucla.edu>
1008 * src/dd.c (flags, usage): New flags directory, nolinks.
1009 * src/system.h (O_NOLINKS): Define to 0 if not already defined.
1011 * src/ls.c (usage): Mention that -f disables --color.
1012 Problem reported by Niels Möller.
1014 2006-03-03 Justin Pryzby <pryzbyj@justinpryzby.com>
1016 * man/*.x: Add references to syscalls from utilities of the same name.
1018 2006-03-05 Jim Meyering <jim@meyering.net>
1020 * tests/help-version: Set SHELL, if not already set, in order to
1021 avoid failure when `make check' is run through debuild; dircolors
1022 would fail due to lack of $SHELL. Reported by Sven Joachim.
1024 Make `base64 --wrap=N' work for N=0, and for N larger than SIZE_MAX.
1025 * src/base64.c (wrap_write, do_encode, main): Change type of
1026 parameters and locals, wrap_column, form size_t to uintmax_t.
1027 (main): Adjust to use xstrtoumax, accordingly.
1029 2006-03-03 Jim Meyering <jim@meyering.net>
1031 Don't fail when run from an environment with SHELL not a Bourne
1032 shell, e.g. `env SHELL=/bin/csh make check' would fail this test.
1033 * tests/dircolors/simple: Invoke each non-failing test with -b.
1034 Reported by Michael Stone.
1036 2006-02-27 Jim Meyering <jim@meyering.net>
1038 * tests/misc/base64: Derive --decode-using tests from the
1041 * tests/misc/base64: Factor out a long constant string.
1042 Split lines to stay within 80 columns.
1044 * tests/misc/Makefile.am (TESTS): Add base64.
1045 * tests/misc/base64: Test base64. From Simon Josefsson.
1047 * src/base64.c (do_decode): Use correct type for parameter,
1048 ignore_garbage: s/size_t/bool/.
1050 * src/base64.c: Don't include .h files already included by system.h:
1051 <string.h>, <stdlib.h>, <stdbool.h>, <limits.h>, <errno.h>.
1052 Include "system.h" before the other lib/*.h header files.
1053 Include <sys/types.h> before "system.h".
1054 (wrap_write): Remove declaration of unused local, initial_column.
1055 (wrap_write): Correct declaration syntax: s/size_t * V/size_t *V/.
1057 * README: Add base64 to the list.
1059 2006-02-17 Simon Josefsson <jas@extundo.com>
1061 New program: base64.
1062 * AUTHORS: Mention base64.
1064 * man/Makefile.am: Build base64.1.
1065 * man/base64.x: New file.
1066 * src/Makefile.am (bin_PROGRAMS): Add base64.
1067 * src/base64.c: New file.
1069 2006-02-25 Eric Blake <ebb9@byu.net>
1071 In ls, avoid calling stat for --inode (-i), when possible.
1072 * src/pwd.c (NOT_AN_INODE_NUMBER, D_INO): Move to ...
1073 * src/system.h: ... here, for use in ...
1074 * src/ls.c (main): ... here. Prefer dirent.d_ino to stat when
1076 (gobble_file): Add inode argument.
1077 (print_dir): Pass inode if available.
1078 (usage): Remove inaccuracy.
1080 2006-02-23 Jim Meyering <jim@meyering.net>
1082 * TODO: Update/correct some obsolete entries.
1084 2006-02-20 Paul Eggert <eggert@cs.ucla.edu>
1086 * doc/coreutils.texi (join invocation): Mention `sort -k 1b,1'.
1087 * src/join.c (usage): Likewise.
1088 Documentation problem reported by Philip Kensche.
1090 2006-02-20 Eric Blake <ebb9@byu.net>
1092 * man/rm.x: Update documentation to match previous patch.
1094 2006-02-18 Eric Blake <ebb9@byu.net>
1096 New option for rm: --interactive=once (-I).
1097 * NEWS: Document it, along with change to rm --interactive.
1098 * TODO: Remove entry for implementing rm -I
1099 * src/rm.c (INTERACTIVE_OPTION): New enum value.
1100 (interactive_type): New enum.
1101 (long_opts): Let interactive take an optional argument.
1102 (interactive_args, interactive_types): New option arguments.
1103 (usage): Document -I, --interactive=WHEN. Use program_name
1104 instead of a basename.
1105 (main): New -I option, new behavior to --interactive.
1106 * tests/rm/interactive-once: New tests.
1107 * tests/rm/interactive-always: Ditto.
1108 * tests/rm/Makefile.am (TESTS): Run them.
1110 2006-02-18 Jim Meyering <jim@meyering.net>
1112 * Makefile.maint (sc_two_space_separator_in_usage): Make the regular
1113 expression match more of the target lines, e.g., those that start with
1114 `-S,' (short option followed by a comma) or that include `=[...]'.
1115 Patch by Nicolas François.
1116 Fix the four offenders thus exposed:
1117 * src/join.c (usage): Use two spaces (not one) to separate the
1118 --first-only option string from its description, so help2man formats
1119 the derived man page properly.
1120 * src/pr.c (usage): Likewise.
1121 * src/uniq.c (usage): Likewise.
1122 * src/install.c (usage): Likewise.
1124 2006-02-15 Jim Meyering <jim@meyering.net>
1126 * Makefile.maint (alpha beta major): For `make major', ensure that the
1127 version string is of the form N.N[.N]*, where N is one or more digits.
1129 2006-02-14 Jim Meyering <jim@meyering.net>
1131 * INSTALL: Update from gnulib.
1133 2006-02-13 Jim Meyering <jim@meyering.net>
1135 * GNUmakefile (all): Emit diagnostics to stderr, not stdout.
1137 2006-02-12 Jim Meyering <jim@meyering.net>
1139 * Makefile.maint (patch-check): New target.
1140 (local-checks-available): Add to the list.
1142 2006-02-11 Jim Meyering <jim@meyering.net>
1144 * src/c99-to-c89.diff: New file.
1145 * src/Makefile.am (EXTRA_DIST): Add c99-to-c89.diff.
1147 * .x-po-check: New file, with exclusions so that `make distcheck'
1149 * Makefile.am (EXTRA_DIST): Add .x-po-check.
1151 rm -r must remove an empty directory, even if it is inaccessible.
1152 * src/remove.c (close_preserve_errno): New function.
1153 (fd_to_subdirp): Don't print a diagnostic in this function.
1154 Do it from the callers instead, unless rmdir succeeds.
1155 (remove_cwd_entries, remove_dir): Adjust callers.
1156 * tests/rm/empty-inacc: New test for the above.
1157 * tests/rm/Makefile.am (TESTS): Add empty-inacc.
1158 * NEWS: Mention this bug fix.
1159 * tests/rm/rm2: Adjust two expected diagnostics, now that they're
1160 a tiny bit less precise: cannot remove `a/1': ... instead of
1161 cannot open directory `a/1': ...
1163 * Makefile.maint (syntax-check-rules): Automatically derive this
1164 list of sc_-prefixed rule names.
1166 2006-02-10 Paul Eggert <eggert@cs.ucla.edu>
1168 * Makefile.maint (CVS_LIST): Don't assume cvsu is available.
1169 (CVS_LIST_EXCEPT): New macro, to simplify exception-processing.
1170 Most uses of CVS_LIST changed to use CVS_LIST_EXCEPT.
1171 (syntax-check-rules): Bring back sc_changelong. (Hmm, why did it
1172 go away? was that an accident?)
1173 (sc_cast_of_argument_to_free, sc_cast_of_x_alloc_return_value):
1174 (sc_cast_of_alloca_return_value, sc_space_tab, sc_prohibit_atoi_atof):
1175 (sc_error_exit_success, sc_file_system, sc_no_if_have_config_h):
1176 (sc_system_h_headers, sc_sun_os_names, sc_trailing_blank):
1177 (sc_two_space_separator_in_usage, sc_unmarked_diagnostics):
1178 (sc_obsolete_symbols, sc_changelog, sc_prohibit_jm_in_m4):
1179 (sc_useless_cpp_parens, makefile-check, m4-check, po-check):
1180 (author_mark_check, makefile_path_separator_check):
1181 Output line numbers, to simplify navigation of Emacs *compilation*
1183 (sc_prohibit_atoi_atof, sc_file_system):
1184 Rework slightly so that Makefile.maint doesn't get reported as a
1185 violation of its own syntax rules.
1186 (sc_dd_max_sym_length): Use ifneq to do nothing, instead of doing
1187 it at run-time (which didn't work with Bison). Fix a makefile typo,
1188 caught by Makefile.maint itself: spaces where a tab should be.
1189 (po-check): Check lib/*.[ch] even if not in CVS; used by Bison,
1190 which copies from ../gnulib/lib/*.[ch] to lib/*.[ch].
1191 Ignore djgpp and man subdirectories, to avoid false matches with
1192 Bison and coreutils, respectively. Use sort -u to remove the
1193 resulting duplicates.
1194 * gnupload: Rework slightly to avoid bogus warning from
1195 sc_two_space_separator_in_usage.
1197 2006-02-10 Jim Meyering <jim@meyering.net>
1199 Use gzip's --rsyncable option only if it's available.
1200 * Makefile.maint (gzip_rsyncable): New variable.
1203 2006-02-08 Jim Meyering <jim@meyering.net>
1205 * Makefile.maint (local-checks-available): Define in terms of
1206 the expansion, $(syntax-check-rules), rather than the single,
1207 top-level target `syntax-check', so that it's easier to exclude
1208 individual rules (via $(local-checks-to-skip)).
1209 (tgz-md5, tgz-sha1, ...): Remove now-unused definitions.
1211 2006-02-07 Jim Meyering <jim@meyering.net>
1213 * src/system.h (!defined O_DIRECT): If O_DIRECTIO is defined (as it
1214 is on Tru64), define O_DIRECT to that. Patch From James Lemley.
1216 * tests/help-version (expected_failure_status_vdir):
1217 Redirect an expected disk-full diagnostic to /dev/null.
1219 2006-02-06 Jim Meyering <jim@meyering.net>
1221 * src/unexpand.c (usage): Use two spaces (not one) to separate the
1222 --first-only option string from its description, so help2man formats
1223 the derived man page properly.
1224 * src/rm.c (usage): Likewise for --no-preserve-root.
1225 * src/chown.c (usage): Likewise.
1226 * src/chgrp.c (usage): Likewise.
1228 Add a rule to ensure that the above doesn't happen again.
1229 * Makefile.maint (sc_two_space_separator_in_usage): New rule.
1230 (syntax-check-rules): Add it.
1231 * .x-sc_two_space_separator_in_usage: New empty file.
1232 * Makefile.am (EXTRA_DIST): Add .x-sc_two_space_separator_in_usage.
1234 2006-02-06 Jim Meyering <jim@meyering.net>
1236 * src/cp.c (usage): Use two spaces (not one) to separate each
1237 option string from its description, so help2man formats the
1238 derived man page properly.
1239 * src/mv.c (usage): Likewise.
1240 Patch from Nicolas François in http://bugs.debian.org/351601.
1242 2006-02-04 Jim Meyering <jim@meyering.net>
1244 * src/copy.c (copy_internal): cp -RL would fail when encountering
1245 the same directory more than once in the hierarchy beneath a single
1246 command-line argument. That is legitimate, e.g. when there are
1247 two or more symbolic links, each pointing to some directory that
1248 would not otherwise be copied. Reported by Christophe LYON.
1249 * tests/cp/cp-deref: New file. Test for today's fix.
1250 * tests/cp/Makefile.am (TESTS): Add cp-deref.
1251 * NEWS: Document this.
1253 2006-02-03 Jim Meyering <jim@meyering.net>
1255 * configure.ac: Require automake-1.9.6, not 1.8.3.
1257 2006-02-01 Paul Eggert <eggert@cs.ucla.edu>
1259 * src/od.c (usage): Mention that -t a ignores high order bit.
1260 Documentation problem reported by Ed Avis.
1262 2006-02-01 Jim Meyering <jim@meyering.net>
1264 * src/pwd.c (find_dir_entry): Remove unused local, `ent_sb_valid'.
1266 2006-01-30 Paul Eggert <eggert@cs.ucla.edu>
1268 * src/head.c (main): Use a better diagnostic when someone uses a
1269 trailing numeric option in an invalid way. Problem reported by
1271 * src/tail.c (parse_options): Likewise.
1273 2006-01-30 Jim Meyering <jim@meyering.net>
1275 * man/wc.x: Include `count' keyword in man page synopsis,
1276 per suggestion from http://bugs.debian.org/181585.
1278 2006-01-24 Paul Eggert <eggert@cs.ucla.edu>
1280 * src/df.c (show_dev): If the file system claims to have
1281 more available than total blocks, report the number of used
1282 blocks as being total - available (a negative number) rather
1283 than as garbage. Problem reported by Toralf Foerster.
1285 2006-01-24 Jim Meyering <jim@meyering.net>
1287 * src/tail.c (tail_forever): Don't exit-nonzero when an attempt
1288 to put a regular file in O_NONBLOCK mode fails with EPERM.
1289 That happens on Linux (up to 2.6.15) when using tail -f on a file with
1290 the append-only attribute. Reported by Dean Gaudet. For details,
1291 see http://savannah.gnu.org/bugs/?func=detailitem&item_id=15473.
1292 * NEWS: Mention this fix.
1293 * tests/tail-2/append-only: New file. Test for the above.
1294 * tests/tail-2/Makefile.am (TESTS): Add append-only.
1295 * tests/Makefile.am (check-root): Add tail-2/append-only
1297 2006-01-21 Jim Meyering <jim@meyering.net>
1299 * NEWS: Mention fts-related improvements and bug fixes.
1301 2006-01-19 Jim Meyering <jim@meyering.net>
1303 * tests/fmt/basic (pfx-1, pfx-2): New tests, to demonstrate the bug
1304 reported as http://bugs.debian.org/147577. Forwarded by Thomas Hood.
1306 2006-01-18 Jim Meyering <jim@meyering.net>
1308 * tests/du/Makefile.am (TESTS): Add long-from-unreadable.
1310 2006-01-17 Jim Meyering <jim@meyering.net>
1312 Now that fts no longer changes the current working directory, adjust
1313 its clients accordingly -- note that du.c uses fts but doesn't need
1314 any adjustment, since it doesn't operate on the actual files,
1315 but rather just uses the stat buffers provided by fts.
1317 * src/chown-core.c: Include "openat.h".
1318 Don't include "lchown.h".
1319 (restricted_chown): Accept a new parameter, CWD_FD, and use it in
1320 calling openat, lchownat, chownat, rather than open, lchown, chown.
1322 * src/chmod.c: Include "openat.h".
1323 (process_file): Use chmodat (fts->fts_cwd_fd,... in place of chmod (...
1325 * tests/du/long-from-unreadable: New test, to exercise one small
1328 2006-01-13 Jim Meyering <jim@meyering.net>
1330 * tests/Makefile.am (SUBDIRS): Add comments discouraging the
1331 addition of new directories under tests/.
1333 * tests/acl: Redirect stdin to /dev/null. Otherwise, FreeBSD 5.0's
1336 2006-01-12 Jim Meyering <jim@meyering.net>
1338 * tests/du/long-sloop: Adjust not to hard-code the expected
1339 diagnostic corresponding to ELOOP. Solaris' diagnostic differs
1340 from that of GNU libc. Reported by Paul Eggert.
1342 * tests/du/long-sloop: Create file at end of symlink chain.
1344 * tests/misc/test: New file, with a test for one of the
1345 bugs fixed by yesterday's test.c changes.
1346 * tests/misc/Makefile.am (TESTS): Add test.
1348 2006-01-11 Jim Meyering <jim@meyering.net>
1350 * tests/du/long-sloop: New file. Test for today's fts.c bug fix.
1351 That bug could make du -L, chgrp -L, or chown -L fail to diagnose
1352 a very long sequence of symbolic links (not necessarily a loop).
1353 * tests/du/Makefile.am (TESTS): Add long-sloop.
1355 2006-01-11 Paul Eggert <eggert@cs.ucla.edu>
1357 * src/test.c (test_syntax_error): Append a newline. All callers
1358 changed, except for the ones that didn't already append a newline.
1359 Bug reported by Eric Blake.
1361 2006-01-11 Jim Meyering <jim@meyering.net>
1363 * src/system.h (X2NREALLOC): Now that verify_true is no longer
1364 void, cast its result to void, to avoid gcc's warning that
1365 ``left-hand operand of comma expression has no effect''.
1366 (DECIMAL_DIGIT_ACCUMULATE, X2REALLOC): Likewise.
1368 2006-01-10 Jim Meyering <jim@meyering.net>
1370 * tests/chmod/no-x: Add a test for today's fts.c fix.
1372 2006-01-10 Jim Meyering <jim@meyering.net> (tiny change)
1374 * src/ls.c (gobble_file): Use DTTOIF only if it's defined.
1375 This is necessary for Dragonfly. Patch by Joerg Sonnenberger.
1377 2006-01-10 Paul Eggert <eggert@cs.ucla.edu>
1379 * src/system.h (X2NREALLOC, X2REALLOC, DECIMAL_DIGIT_ACCUMULATE):
1380 Use verify_true instead of verify_expr, to sync with gnulib.
1382 2006-01-08 Jim Meyering <jim@meyering.net>
1384 * src/date.c (usage): Adjust the formatting of the entries for
1385 %::z and %:::z (separate with two spaces, not one) so that help2man
1386 formats them properly. Reported by Philip Rowlands.
1388 2006-01-06 Paul Eggert <eggert@cs.ucla.edu>
1390 * configure.ac (gl_IGNORE_UNUSED_LIBRARIES): Add.
1392 2006-01-06 Jim Meyering <jim@meyering.net>
1394 * Makefile.maint (copyright-check): Use date +%Y in place of
1397 * src/remove.c (rm_1): Remove `static' attribute on local `status'.
1398 First off, the attribute should have been `volatile' (not static)
1399 to avoid longjmp-related risk of clobber. Secondly, now there is
1400 no longer any risk of a local variable being clobbered, so there's
1401 no need for any attribute at all.
1403 2006-01-05 Jim Meyering <jim@meyering.net>
1405 * src/remove.c: Give a few functions the inline attribute.
1406 (AD_pop_and_chdir): Use gotos to avoid some duplication.
1407 (AD_push): Rewrite an assertion so that the entire computation
1408 goes away when assertions are turned off.
1410 * src/tail.c (ENOSYS) [!defined ENOSYS]: Don't define here.
1411 It's already defined in "system.h".
1412 * Makefile.maint: Add a FIXME comment.
1414 2006-01-04 Jim Meyering <jim@meyering.net>
1416 * ChangeLog: Remove entries from 2005-10-22 and earlier.
1417 * ChangeLog-2005: New file, for entries up to version 5.92.
1419 2006-01-03 Jim Meyering <jim@meyering.net>
1421 * tests/du/no-x: Also allow a slightly different diagnostic -- the
1422 one you get when using openat-enabled fts.c and du (coming soon).
1423 * tests/chmod/no-x: Likewise.
1424 * tests/chgrp/no-x: Likewise.
1426 * src/system.h (O_DIRECTORY) [!defined O_DIRECTORY]: Define.
1428 2006-01-02 Paul Eggert <eggert@cs.ucla.edu>
1430 * src/chown-core.c (RC_do_ordinary_chown): New enum value.
1431 (restricted_chown): Return it, if the file cannot be accessed due
1432 to EPERM, or if no uid or gid are required, or if the file is
1433 neither a directory nor a regular file. Rewrite to avoid gotos.
1434 (change_file_owner): Handle RC_do_ordinary_chown case.
1435 Rewrite to avoid gotos.
1436 * tests/chgrp/basic: Make sure we can change the group of
1439 * src/date.c (usage): Explain %g, %G, and %V a bit better.
1441 2006-01-02 Jim Meyering <jim@meyering.net>
1443 * src/copy.c (set_owner): Correct a comment.
1445 * src/tail.c (parse_options): Change warning to say that --retry
1446 is useful `mainly' (not `only') when following by name.
1447 Reported here: http://bugs.debian.org/273781
1449 2006-01-01 Paul Eggert <eggert@cs.ucla.edu>
1451 * NEWS: Document that mkfifo and mknod -m no longer set special bits.
1452 * src/copy.c: Include lchmod.h.
1453 (copy_internal): Use lchmod rather than chmod.
1454 * src/cp.c: Include lchmod.h.
1455 (re_protect, make_dir_parents_private): Use lchmod rather than chmod.
1456 * src/mkdir.c: Include lchmod.h.
1457 (usage): Clarify -m's operation.
1458 (main): Use lchmod rather than chmod. Don't use lchmod unless the
1459 new mode contains bits outside the 777 range.
1460 * src/mkfifo.c (usage): Clarify -m's operation.
1461 (main): If -m is given, don't invoke chmod; use umask 0 instead.
1462 Report an error if -m asks for bits outside the 777 range.
1463 * src/mknod.c (usage, main): Likewise.
1465 * src/mkdir.c, src/mkfifo.c, src/mknod.c: Undo 2005-12-19 changes.
1467 2005-12-27 Jim Meyering <jim@meyering.net>
1469 * Makefile.maint (sc_obsolete_symbols): Prohibit use of O_NDELAY.
1470 (sc_prohibit_assert_without_use): New rule.
1471 (syntax-check-rules): Add it to the list.
1472 * .x-sc_prohibit_assert_without_use: New empty file.
1473 * Makefile.am (EXTRA_DIST): Add it.
1475 * Makefile.maint (CVS_LIST): Define in terms of $(srcdir).
1477 * cp.c, df.c, link.c, mknod.c, nice.c, sleep.c, unlink.c:
1478 Don't include <assert.h>; it wasn't used.
1480 2005-12-26 Paul Eggert <eggert@cs.ucla.edu>
1482 * src/chown-core.c (restricted_chown):
1483 Don't try O_WRONLY unless O_RDONLY failed wth EACCES.
1484 * src/remove.c (fd_to_subdirp): Open with O_DIRECTORY | O_NOCTTY
1485 | O_NOFOLLOW too, for consistency with other dir-openers.
1486 Use POSIX-preferred O_NONBLOCK rather than O_NDELAY.
1487 (is_empty_dir): Likewise.
1488 * src/shred.c (wipename): Likewise. Don't bother trying to open
1489 dir for writing, since POSIX prohibits it.
1491 2005-12-22 Jim Meyering <jim@meyering.net>
1493 * tests/help-version: Redirect stderr to /dev/full, to suppress
1494 write error diagnostic.
1496 2005-12-19 Jim Meyering <jim@meyering.net>
1498 * src/mkdir.c, src/mknod.c, src/mkfifo.c (main)
1499 Avoid a minor race condition when `-m MODE' is specified, by using
1500 open, fchown, and close rather than just chown. To do that reliably --
1501 even with an overly restrictive umask -- ensure that each mkdir,
1502 mknod and mkfifo call uses a mode including at least owner-read access.
1503 * src/mknod.c (main): When `-m MODE' is specified, exit nonzero if
1504 the subsequent chown (or equivalent open,fchown,close) fails.
1505 * tests/misc/mknod: New tests.
1506 * tests/misc/Makefile.am (TESTS): Add mknod.
1508 2005-12-17 Jim Meyering <jim@meyering.net>
1510 * src/remove.c (is_empty_dir): Open with O_NDELAY, so we don't hang,
1511 e.g., on a named pipe.
1512 (OPEN_NO_FOLLOW_SYMLINK): Remove definition. Use O_NOFOLLOW in
1513 place of all uses, since it is guaranteed (system.h) to be defined.
1515 2005-12-05 Andreas Gruenbacher <agruen@suse.de>
1517 Add POSIX ACL support
1518 * src/ls.c: Switch back from HAVE_ACL to USE_ACL: The acl() syscall
1519 is no requirement for ACL support; particularly, it does not exist
1520 on systems that have POSIX ACLs.
1521 * src/copy.h (cp_option_init) [umask_kill]: Remove member.
1522 * src/cp.c (umask_kill): With default acls, the umask is not to be
1523 applied. Remove umask_kill, don't change the process umask, and let
1524 the kernel apply the umask where appropriate.
1525 * src/cp.c (make_dir_parents_private): Fix logic for POSIX ACLs.
1526 * src/copy.c (get_dest_mode): Remove; it is obsolete after removing
1528 (copy_reg, copy_internal): Use copy_acl and set_acl
1529 instead of fchown/chown. Fix the logic for POSIX ACLs.
1530 (chown_succeded): Remove; we now always copy acls and
1531 preserve S_ISUID, S_ISGID, and S_ISVTX when needed, no matter if we
1532 did a chown before or not.
1533 * src/mv.c, src/install.c (cp_option_init): Don't set umask_kill member.
1534 * src/Makefile.am (dir_LDADD, ls_LDADD, vdir_LDADD, cp_LDADD,
1535 mv_LDADD, ginstall_LDADD): On systems with an ACL library, arrange
1536 to link with it via $(LIB_ACL), for the utilities that need it.
1538 2005-12-16 Paul Eggert <eggert@cs.ucla.edu>
1540 * src/remove.c (OPENAT_CWD_RESTORE__REQUIRE): Remove.
1541 (OPENAT_CWD_RESTORE__ALLOW_FAILURE): Likewise.
1542 (fd_to_subdirp): Remove openat_cwd_restore_allow_failure arg; its
1543 value is now signified by whether cwd_errno is null.
1544 (fd_to_subdirp, remove_dir, rm_1); Change cwd failure indicator from
1545 pointer-to-bool to pointer-to-errno-value. All callers changed.
1546 (rm_1): Don't bother setting a local cwd failure flag and then
1547 ORing it into the caller's. Just set the caller's.
1548 (rm): Use cwd failure errno value to print a slightly-better
1551 2005-12-15 Jim Meyering <jim@meyering.net>
1553 * src/stat.c (print_it): Properly handle a backslash at the
1554 end of a --printf format string. Reported by Paul Eggert.
1555 * tests/misc/stat-printf (end-bs): Add a test for the above.
1557 2005-12-15 Paul Eggert <eggert@cs.ucla.edu>
1559 * tests/acl: Port to pre-POSIX shells like Solaris 8 /bin/sh.
1560 Don't assume /etc/passwd contains user names; use 'id' instead.
1562 2005-12-15 Jim Meyering <jim@meyering.net>
1564 stat: revert behavior of --format=FMT (-c)
1565 stat: add new option: --printf=FMT
1566 * NEWS: Mention this.
1567 * src/stat.c (isodigit, octtobin, hextobin): Define.
1568 (PRINTF_OPTION): Define.
1569 (interpret_backslash_escapes, trailing_delim): New globals.
1570 (usage): Document them. Alphabetize on long option names.
1571 (print_esc_char): New function.
1572 (print_it): Rewrite, in order to handle backslash escapes.
1573 (main): Handle new option. Set globals for --format, too.
1575 * tests/misc/stat-printf: Test --printf and --format.
1576 * tests/misc/Makefile.am (TESTS): Add stat-printf.
1578 2005-12-14 Paul Eggert <eggert@cs.ucla.edu>
1580 * NEWS: sort now reports incompatible options.
1581 * src/sort.c (incompatible_options, check_ordering_compatibility):
1583 (main): Use them. Don't bother with a usage message for
1584 "sort -c a b", for consistency with other error diagnostics.
1585 * tests/sort/Test.pm (incompat1, incompat2, incompat3, incompat4):
1588 * src/cat.c (main): Undo previous change. close_stdout already
1589 does the check, so the previous change wasn't necessary.
1591 2005-12-13 Paul Eggert <eggert@cs.ucla.edu>
1593 * src/cat.c (main): Check for close (STDOUT_FILENO) failure.
1595 2005-12-12 Paul Eggert <eggert@cs.ucla.edu>
1597 Install a more-conservative approach for sort -R. It's the
1598 same basic idea as the existing code, except it uses the full ISAAC
1599 approach (called the "more kosher" approach in the existing comments).
1600 This makes "sort -R" quite a bit slower (about a factor of 2 on my
1601 little tests involving 10000 lines on a 2.4 GHz P4), but I think it's
1602 better to be conservative here at first, and review any performance
1603 improvements carefully.
1604 * .x-sc_require_config_h: Add src/rand-isaac.c.
1605 * src/rand-isaac.h: Remove. All uses now simply include rand-isaac.c.
1606 * src/Makefile.am (noinst_HEADERS): Remove rand-isaac.h.
1607 (shred_SOURCES, sort_SOURCES): Remove.
1608 (EXTRA_DIST): Add rand-isaac.c.
1609 * src/rand-isaac.c: Revert to what used to be in shred.c, without
1610 changing it to allow for varying numbers of words in the state.
1611 Alter so that we include rand-isaac.c directly rather than
1612 compiling it and linking to it. Don't include config.h or
1613 system.h; that's the includer's responsibility.
1614 Omit functions that are specific to shred.
1615 (ISAAC_LOG, ISAAC_WORDS, ISAAC_BYTES, struct isaac_state, ind):
1616 (isaac_step, struct irand_state):
1617 Resurrect these, with the same defns that used to be in shred.c.
1618 (ISAAC_SIZE, isaac_new, isaac_copy): Remove.
1619 (isaac_refill, isaac_seed_start, isaac_seed_data, irand_init, irand32):
1621 (struct isaac_state, isaac_refill, isaac_mix, isaac_init):
1622 (isaac_seed_start, isaac_seed_data, isaac_seed_finish, isaac_seed):
1623 (irand_init, irand32, irand_mod):
1624 Number of words is constant again.
1625 (struct irand_state, irand_init, irand32, irand_mod): Move to shred.c.
1626 * src/shred.c: Include rand-isaac.c rather than rand-isaac.h.
1627 * src/sort.c: Likewise.
1628 * src/shred.c (fillrand, dopass, main): Undo previous change.
1629 (struct irand_state, irand_init, irand32, irand_mod): Moved back here,
1631 * src/sort.c: Don't include md5.h; it wasn't needed.
1632 (struct keyfield): Rename random_hash to random, for consistency
1633 with the other member names. All uses changed.
1634 (usage): Tweak wording to mention STRING for --seed option.
1635 (short_options): Rorder for consistency with other programs.
1636 (rand_state): Now a struct, not a pointer to one. All uses changed.
1637 (HASH_WORDS, HASH_SIZE): Remove.
1638 (get_hash): Remove comments around resbuf size, since we can assume C89.
1639 Use a "more-kosher" (but slower) approach of invoking isaac_refill.
1640 (keycompare): Adjust to the new get_hash.
1642 (badfieldspec): Omit recently-introduced comment; it isn't needed.
1643 (main): Don't set need_random simply because gkey has it set; that
1644 doesn't necessarily mean we'll need random numbers.
1645 Redo seeding to match new get_hash approach.
1647 2005-12-10 Jim Meyering <jim@meyering.net>
1649 * src/Makefile.am (noinst_HEADERS): Add rand-isaac.h.
1651 Avoid shred segfault on 64-bit systems.
1652 * src/rand-isaac.c (isaac_refill): Don't try to negate a
1653 local of type uint32_t. Make the local an `int' instead.
1655 * NEWS: Mention sort's new options.
1657 * src/rand-isaac.c (isaac_mix): Declare to be static.
1658 Mark all other functions as `extern' so the tight-scope
1659 part of `make distcheck' passes once again.
1660 * src/rand-isaac.h (isaac_mix): Remove declaration.
1662 * src/sort.c (get_hash): Change position of `*' in parameter
1663 type to conform with convention.
1664 (main): Split a long line so it fits in 80 columns.
1665 (keycompare): Remove stray SPACE before TAB that was
1666 causing `make distcheck' to fail.
1668 * src/shred.c: Don't include gethrxtime.h. No longer needed.
1670 * tests/misc/sort-rand: New file: basic tests for the new options.
1671 * tests/misc/Makefile.am (TESTS): Add sort-rand.
1673 2005-12-10 Frederik Eaton <frederik@ofb.net>
1675 * src/Makefile.am (sort_LDADD): Add $(LIB_GETHRXTIME).
1676 (shred_SOURCES, sort_SOURCES): New macros, so we compile rand-isaac.c.
1677 * src/rand-isaac.c: New file, containing ISAAC code that was in shred.c.
1678 Make state size runtime-configurable.
1679 (isaac_new, isaac_copy): New functions.
1680 * src/rand-isaac.h: New file.
1681 * src/shred.c: Include rand-isaac.h. Move ISAAC code to rand-isaac.c.
1682 (fillrand, main): Adjust to the fact that the state size is now
1683 runtime-configurable.
1684 * src/sort.c (short_options, long_options, WORDS, keycompare, main):
1685 (usage): Add options --random-sort and --seed to implement a random
1687 Include md5.h and rand-isaac.h.
1688 (get_hash): New function.
1689 (rand_state): New var.
1690 (HASH_WORDS, HASH_SIZE): New macros.
1692 2005-12-09 Paul Eggert <eggert@cs.ucla.edu>
1694 * tests/dd/misc: Add test for dd iflags=noatime.
1696 2005-12-09 Jim Meyering <jim@meyering.net>
1698 * src/sort.c (usage): Mention white space vs -b and -t options.
1701 2005-12-09 Eric Blake <ebb9@byu.net>
1703 * src/test.c (main): Fix misleading comment.
1705 2005-12-07 Paul Eggert <eggert@cs.ucla.edu>
1707 * NEWS: Mention dd's new noatime flag.
1708 * src/system.h (O_NOATIME): Define to 0 if not already defined.
1709 * src/dd.c (flags, usage): Add support for noatime flag.
1711 2005-12-07 Jim Meyering <jim@meyering.net>
1713 Distribute the cvsu script, used only by `make syntax-check'.
1714 * Makefile.am (EXTRA_DIST): Add build-aux/cvsu.
1715 * Makefile.maint (CVS_LIST): Use build-aux/cvsu, now that we
1716 distribute a copy of this script.
1717 * .x-sc_unmarked_diagnostics: Add build-aux/cvsu.
1719 * tests/mv/acl: exit-77 before the trap, not after, if we fail
1720 to create a temporary directory on another partition.
1721 From Andreas Gruenbacher.
1723 2005-12-06 Tomas Pospisek <tpo@sourcepole.ch> (tiny change)
1725 * man/basename.x: Cross-reference to dirname and readlink.
1726 * man/dirname.x: Cross-reference to basename and readlink.
1728 2005-12-05 Andreas Gruenbacher
1730 * src/copy.c [!HAVE_FCHOWN]: Define fchown(...) to -1.
1731 (set_owner, preserve_author): New functions, factored out of copy_reg.
1732 (copy_reg): Use them.
1733 (copy_internal): Use them here, too.
1735 2005-12-04 Jim Meyering <jim@meyering.net>
1737 * src/sleep.c (usage): Say what happens with two or more arguments.
1738 Suggested by Justin Pryzby.
1740 * src/uptime.c (print_uptime): Move decl of `upsecs' into scope
1743 2005-12-03 Jim Meyering <jim@meyering.net>
1745 * src/rm.c (long_opts): Change the name of each undocumented, for-
1746 testing-only option to start with `-', so that it cannot render
1747 ambiguous any prefix it happens to share with some other option name.
1748 Problem reported by Eric Blake.
1749 * src/head.c (long_options): Likewise.
1750 * src/tail.c (long_options): Likewise.
1752 * tests/misc/head-elide-tail: Update uses of undocumented, for-
1753 testing-only --presume* options to start with `---'.
1754 * tests/rm/dangling-symlink: Likewise.
1755 * tests/rm/dir-no-w: Likewise.
1756 * tests/rm/isatty: Likewise.
1758 2005-11-30 Jim Meyering <jim@meyering.net>
1760 * Makefile.maint: Add a comment about cvsu.
1762 2005-11-25 Paul Eggert <eggert@cs.ucla.edu>
1764 * NEWS: df updates for "none", "proc", inaccessible file systems.
1765 * src/df.c (show_point): Ignore inaccessible file systems.
1766 (usage): -a includes dummy file systems, not size-0 file systems.
1768 * src/od.c (unsigned_long_long_int): Renamed from ulonglong_t,
1769 to avoid collision with POSIX name space. All uses changed.
1771 2005-11-24 Jim Meyering <jim@meyering.net>
1773 * tests/Makefile.am (EXTRA_DIST): Add acl to the list.
1774 * tests/acl: Add `$0: ' prefix to diagnostics.
1776 * .x-sc_require_config_h: Add lib/buffer-lcm.c to the list.
1778 2005-11-23 Paul Eggert <eggert@cs.ucla.edu>
1780 * src/copy.c: Improve performance a bit by optimizing away
1781 unnecessary system calls and going to a block size of at least
1782 8192 (on normal hosts, anyway). This improved performance 5% on my
1783 Debian stable host (2.4.27 kernel, x86, copying from root
1784 ext3 file system to itself).
1785 Include "buffer-lcm.h".
1786 (copy_reg): Omit last argument. All callers changed.
1787 Use xmalloc to allocate rather than trusting alloca
1788 (which is unwise with large block sizes).
1789 Declare locals more locally, if possible.
1790 Use uintptr_t words instead of int words, for a bit more speed
1791 when looking for null blocks on 64-bit hosts.
1792 Optimize away reads of zero bytes on regular files.
1793 In the typical case, insist on 8 KiB buffers, at least.
1794 Avoid unnecessary extra call to fstat when checking for sparse files.
1795 Avoid now-unnecessary cast to off_t, and "0L".
1796 Avoid unnecessary test of *new_dst when checking for same owner
1799 2005-11-22 Paul Eggert <eggert@cs.ucla.edu>
1801 * src/remove.c (rm): Don't assume C99 for-loop syntax.
1803 2005-11-22 Jim Meyering <jim@meyering.net>
1805 * src/remove.c (AD_push): Remove debugging cruft.
1807 * tests/rm/unread2 (rm): Change expected diagnostic,
1808 `cannot open directory' to `cannot remove', to align with
1810 * tests/rm/rm2: Ensure that rm now continues removing entries
1811 even after certain types of failure.
1813 * src/remove.c: Rewrite. Now, this module is reentrant on systems
1814 that provide openat (Solaris), and on systems like Linux+procfs
1815 where our openat emulation code is reentrant. This also fixes a
1816 few low-probability leaks and eliminates some code that could,
1817 in very unusual circumstances, cause rm() (via a callee) to exit.
1818 * NEWS: Mention this.
1820 * configure.ac: Put copyright dates all on one line so the
1821 emacs function that updates them works properly.
1823 2005-11-18 Paul Eggert <eggert@cs.ucla.edu>
1825 * configure.ac (AM_PROG_CC_C_O): Add. Needed for CVS Automake.
1826 Problem reported by Eric Blake.
1827 (AC_PROG_CC_STDC): Use this instead of AC_PROG_CC, so that
1828 we get a standard-conforming compiler. This relies on the new
1829 m4/c.m4 file. Note that it's a bit tricky, since c.m4 doesn't
1830 define AC_PROG_CC_STDC; we are relying on Autoconf 2.59 internals.
1831 m4/c.m4 can go away with Autoconf 2.60 comes out.
1833 2005-11-17 Jim Meyering <jim@meyering.net>
1835 * src/remove.c (AD_mark_helper): Make a `char *' parameter `const'.
1836 (AD_mark_current_as_unremovable): Likewise, but for a local.
1839 * tests/mv/acl: Let traps handle removing temporary directories.
1841 Expect acl-related tests to fail, until the corresponding
1842 patches are committed.
1843 * tests/mv/Makefile.am (XFAIL_TESTS): Add acl.
1844 * tests/cp/Makefile.am (XFAIL_TESTS): Likewise.
1846 ACL tests, from Andreas Gruenbacher.
1847 * tests/acl, tests/mv/acl, tests/cp/acl: New files.
1848 * tests/mv/Makefile.am (TESTS): Add acl.
1849 * tests/cp/Makefile.am (TESTS): Add acl.
1851 * src/ls.c (basename_is_dot_or_dotdot): Correct wording in comment.
1853 2005-11-16 Paul Eggert <eggert@cs.ucla.edu>
1855 * NEWS: Improve quality of ln's diagnostics.
1856 * src/ln.c (do_link, usage): Likewise.
1857 (do_link): Don't use alloca on a buffer of unbounded size.
1859 2005-11-16 Jim Meyering <jim@meyering.net>
1861 * tests/cp/fail-perm: Accommodate HPUX. It appears to fail
1862 with EACCES rather than EPERM. Reported by Peter O'Gorman here:
1863 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/5766
1864 This also affects AIX 4.3.3, according to Ralf Wildenhues, in
1865 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
1867 2005-11-14 Jim Meyering <jim@meyering.net>
1869 * NEWS (sort): Mention consequences of today's mkstemp-safer.c fix.
1871 2005-11-13 Jim Meyering <jim@meyering.net>
1873 * announce-gen: Accept new option, --gpg-key-id=ID and
1874 emit a blurb telling how to use the .sig files.
1875 * Makefile.cfg (gpg_key_ID): Define.
1876 * Makefile.maint (announcement): Use new option and key.
1878 Require that most .c files include <config.h>.
1879 * Makefile.maint (sc_require_config_h): New rule.
1880 (syntax-check-rules): Add it.
1881 * .x-sc_require_config_h: New file listing exceptions to the
1882 above rule. Some are legit, others are simply grandfathered in.
1883 * Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h here, too.
1885 2005-11-12 Jim Meyering <jim@meyering.net>
1887 * src/checksum.h, src/md5.c, src/sha1sum.c: Remove now-unused files.
1889 2005-11-11 Jim Meyering <jim@meyering.net>
1891 * NEWS: Mention `readlink -f' bug fix in 5.3.0 news.
1892 Mention new readlink options in 5.3.0's `New features' section.
1893 Spotted by Thomas Hood.
1895 2005-11-08 Jim Meyering <jim@meyering.net>
1897 * NEWS: Merge in changes from b5_9x branch.
1899 2005-11-08 Paul Eggert <eggert@cs.ucla.edu>
1901 * NEWS: ls now defaults to --time-style='locale', which in turn acts
1902 like --time-style='posix-long-iso' if the locale settings are messed up.
1903 * src/ls.c (decode_switches): Implement this.
1905 2005-11-08 Jim Meyering <jim@meyering.net>
1907 * tests/du/2g: s/expensive/very expensive/ in a comment.
1910 2005-10-17 Eric Blake <ebb9@byu.net>
1912 * src/ls.c (usage): Fix descriptions of --sort, --time.
1913 Reported by Vitaly A. Ostanin.
1915 2005-11-04 Paul Eggert <eggert@cs.ucla.edu>
1917 * src/ln.c: Include filenamecat.c.
1918 (FILE_BASENAME_CONCAT): Remove.
1919 (do_link): Remove last arg DEST_IS_DIR. All callers changed.
1920 (main): Use file_name_concat, base_name, and strip_trailing_slashes
1921 instead of FILE_BASENAME_CONCAT. This simplifies the code, and avoids
1924 2005-11-04 Jim Meyering <jim@meyering.net>
1926 * src/du.c (process_file): Don't overflow for files of size >= 2^31
1927 on systems with stat.st_blocks of a signed 32-bit type.
1928 This bug causes trouble on some AIX 5.1 systems.
1929 Report and trivial patch from Paul Townsend:
1930 <http://lists.gnu.org/archive/html/bug-coreutils/2005-11/msg00033.html>
1931 * NEWS: Mention this.
1933 * tests/du/2g: New (very-expensive) test for the above-fixed bug.
1934 * tests/du/Makefile.am (TESTS): Add it here.
1935 * tests/very-expensive: New file.
1936 * tests/Makefile.am (EXTRA_DIST): Add it here.
1937 * tests/cp/perm: Mark this test as `very-expensive', too.
1939 2005-11-02 Paul Eggert <eggert@cs.ucla.edu>
1941 * NEWS: Mention that rm -d and maybe ln -d are scheduled for
1943 * src/remove.h (struct rm_options): Remove unlink_dirs. All uses
1945 * src/rm.c (usage): Don't mention rm -d.
1947 2005-11-02 Jim Meyering <jim@meyering.net>
1949 * tests/dd/skip-seek: Fix typo in comment: s/fileutils/coreutils.
1950 From Andreas Schwab.
1952 * tests/dd/unblock-sync: Redirect stderr to /dev/null so the
1953 `M+N records in/out' lines don't pollute `make check' output.
1955 * tests/dd/skip-seek (sk-seek4): New test, to exercise the bug
1956 fixed on 2005-10-31. This test uses the new, IN_PIPE specifier.
1957 * tests/Coreutils.pm: Accept a new type of input specifier: IN_PIPE,
1958 to indicate that the input file should be piped into the command
1959 under test (via `cat FILE | $prog ...').
1961 * src/remove.c (remove_entry): Emit a better diagnostic when rm
1962 (without -r) fails to remove a directory on a non-Linux system.
1963 This change affects only newer Solaris systems (with priv_*
1964 functions like priv_allocset). Reported by Keith Thompson.
1966 * tests/rm/dir-nonrecur: New file/test for the above fix.
1967 * tests/rm/Makefile.am (TESTS): Add dir-nonrecur.
1969 2005-11-01 Paul Eggert <eggert@cs.ucla.edu>
1971 * NEWS: "tail -c 2 FILE" and "touch 0101000000" now operate as
1972 POSIX 1002.1-2001 requires.
1973 * src/tail.c (parse_obsolete_option): Implement this.
1974 Problem reported by Vincent Lefevre.
1975 * src/touch.c (main): Pass PDS_PRE_2000 to posixtime.
1976 * tests/tail/Test.pm (c-2, c-2-minus, c2, c2-minus): New tests.
1977 (test_vector): Add special cases for _POSIX2_VERSION, and
1978 regularize the old ones a bit.
1979 * tests/touch/obsolescent: Add y2000 test.
1981 2005-10-31 Paul Eggert <eggert@cs.ucla.edu>
1983 * src/dd.c (skip): Fix off-by-one error reported by
1984 Theodoros V. Kalamatianos.
1986 2005-10-30 Paul Eggert <eggert@cs.ucla.edu>
1988 * tests/mkdir/p-3: Require that the test be run as non-root.
1989 Problem and trivial fix reported by Theodoros V. Kalamatianos.
1991 2005-10-28 Paul Eggert <eggert@cs.ucla.edu>
1993 * src/ln.c (FILE_BASENAME_CONCAT): Omit unnecessary slashes in the
1994 boundary between DEST and SOURCE in the result.
1996 2005-10-26 Dmitry V. Levin <ldv@altlinux.org>
1998 * src/md5sum.c (main) [!O_BINARY]: Changed default read mode
1999 back to text, to sync with documentation and for backwards
2002 2005-10-25 Jim Meyering <jim@meyering.net>
2004 * tests/dircolors/simple (other-wr): Add an explicit test for
2005 the dircolors bug (NULL-dereference) fixed yesterday.
2007 2005-10-24 Jim Meyering <jim@meyering.net>
2009 * src/tac.c (tac_file): When determining whether a file is seekable,
2010 also test whether it is a tty. Using only the lseek-based test would
2011 give a false positive on Solaris. Reported by Peter Fales.
2013 2005-10-24 Dmitry V. Levin <ldv@altlinux.org>
2015 * tests/install/d-slashdot: New test, for "install -d" failure.
2016 * tests/install/Makefile.am (TESTS): Add d-slashdot.
2017 * tests/mkdir/p-slashdot: New test, for "mkdir -p" failure.
2018 * tests/mkdir/Makefile.am (TESTS): Add p-slashdot.
2020 2005-10-24 Jim Meyering <jim@meyering.net>
2022 * src/dircolors.c (ls_codes): Add missing comma.
2023 Anonymous report and patch from
2024 http://savannah.gnu.org/bugs/?func=detailitem&item_id=14849
2026 * src/dircolors.c: Add compile-time assertion that the slack_codes
2027 and ls_codes arrays have the same number of elements. This would
2028 have prevented the above-fixed bug.
2030 * src/expand.c (parse_tab_stops): Add a comment to make this function
2031 identical to the one in unexpand.c.
2032 * src/unexpand.c (parse_tab_stops): Adjust syntax to make this function
2033 identical to the one in expand.c.
2035 * src/expand.c (next_file): Don't assume fopen cannot return stdin.
2037 2005-10-23 Jim Meyering <jim@meyering.net>
2039 * src/md5sum.c (digest_check, main): Use ptr_align rather than
2040 a dangerous pointer-value-to-`unsigned' cast.
2041 * NEWS: mention the new sha* programs.
2042 * AUTHORS: Add new sha* programs.
2044 2005-08-28 David Madore <david.madore@ens.fr>
2046 Add new programs: sha224sum, sha256sum, sha384sum, sha512sum.
2047 * README: Add their names to the list.
2048 * src/md5sum.c: Provide framework for computing sha-2 hashes.
2049 * src/Makefile.am (sha224sum, sha256sum, sha384sum, sha512sum):
2050 Rules for compiling sha-2 utilities
2051 (noinst_HEADERS): Remove checksum.h.
2052 * man/sha512sum.x, man/sha384sum.x, man/sha256sum.x, man/sha224sum.x:
2054 * man/Makefile.am (dist_man_MANS): Add the corresponding .1 names.
2055 (sha224sum.1, sha256sum.1, sha384sum.1, sha512sum.1): New dependencies.
2056 * tests/misc/sha224sum, tests/misc/sha256sum: New files.
2057 * tests/misc/sha384sum, tests/misc/sha512sum: New files.
2058 * tests/misc/Makefile.am (TESTS): Add new sha224sum, sha256sum,
2059 sha384sum, sha512sum test scripts here rather that each in its
2062 2005-08-28 David Madore <david.madore@ens.fr>
2064 * tests/sha1sum/basic-1 (million-a): Add the "million a's" test (one
2065 of the FIPS test vectors).
2067 2005-10-23 Jim Meyering <jim@meyering.net>
2069 * configure.ac: Use 6.0-cvs as the version string.
2070 * NEWS: Adjust accordingly.