1 2006-08-09 Paul Eggert <eggert@cs.ucla.edu>
3 * src/dircolors.hin: Add mlterm, rxvt-unicode; this fixes Debian
6 * src/.cvsignore: Add shuf.
8 * Makefile.maint: Remove the po-update procedure; it doesn't
9 work with the new repository on http://www.iro.umontreal.ca/.
10 For now I guess we'll have to fix things by hand.
11 (do-po-update, po-update): Remove. All references removed.
13 * src/shuf.c (next_line): New function.
14 (read_input): Use it, to avoid relying on GCC-specific behavior
15 with void * arithmetic. Problem reported by Bob Proulx.
16 * Makefile.maint (my-distcheck): Compile with -Wpointer-arith
17 to detect this sort of problem automatically in the future.
19 2006-08-09 Jim Meyering <jim@meyering.net>
21 * src/ls.c: Add a compile-time check to ensure that filetype
22 and filetype_letter have the same number of elements.
24 * tests/misc/sort-rand: Remove use of --seed=S.
26 2006-08-08 Paul Eggert <eggert@cs.ucla.edu>
28 Add a command 'shuf', and modify shred and sort to use the new
29 random number generator library of 'shuf'.
33 * NEWS: Likewise. Mention new --random-source option for shred
34 and sort. Move "sort +1 -2" notice to the appropriate section,
35 and clarify its role with respect to POSIXLY_CORRECT.
36 * man/.cvsignore: Add shuf.1.
37 * man/Makefile.am (dist_man_MANS): Add shuf.1.
38 (shuf.1): New dependency.
39 * man/shuf.x: New file.
40 * src/Makefile.am (bin_PROGRAMS): Add shuf.
41 (EXTRA_DIST): Remove rand-isaac.c.
42 (shuf_LDADD): New macro.
43 * src/rand-isaac.c: Remove, moving most of its contents to
45 * src/shuf.c: New file.
46 * src/shred.c: Use new random-number interface rather than rand-isaac.c.
47 Don't include rand-isaac.c; include randint.h and randread.h instead.
48 (RANDOM_SOURCE_OPTION): New enum.
49 (long_opts, usage, main): New option --random-source.
50 * src/sort.c: Likewise.
51 * src/shred.c (struct irand_state, irand_init, irand32, irand_mod): Remove.
52 All callers changed to use randint interface.
53 (fillrand): Remove. All callers changed to use randread interface.
54 (dopass): Remove dependency on ISAAC buffer size.
55 (genpattern): Don't wipe the random state here.
56 (randint_source): New static var.
57 (clear_random_data): New function.
58 (main): Allocate random source, and arrange to wipe it on exit.
59 * src/sort.c: Include md5.h, randread.h, xmemxfrm.h.
60 (longopts, usage, main): Remove undocumented --seed option;
61 it's now replaced by --random-source.
62 (rand_state, get_hash): Remove.
63 (randread_source): New static var.
64 (random_state, cmp_hashes, compare_random): New functions; they guarantee
65 no collisions in the random hash function.
66 (keycompare): Use compare_random for -R; don't fall back on comparing
67 via memcoll, since compare_random does the right thing.
68 * tests/misc/Makefile.am (TESTS): Add shuf.
69 * tests/misc/shuf: New file.
71 2006-07-29 Paul Eggert <eggert@cs.ucla.edu>
73 * src/copy.c (set_author): Preserve the st_author field via the
74 file descriptor dest_desc.
76 2006-07-28 Paul Eggert <eggert@cs.ucla.edu>
78 * NEWS: chmod now preserves setuid and setgid bits on directories
79 if you use a numeric mode with them clear, e.g., "chmod 755 DIR".
81 Fix test case problems if working directory is setgid,
82 reported by Bob Proulx.
83 * tests/cp/fail-perm: Use symbolic mode so that we clear
84 setgid bit more reliably on directories.
85 * tests/mkdir/special-1 (set_mode_string): Likewise.
87 2006-07-27 Jim Meyering <jim@meyering.net>
89 * src/chgrp.c (usage): Use correct grammar in description of the
91 * src/chown.c (usage): Likewise.
93 2006-07-26 Thomas Schwinge <tschwinge@gnu.org> (tiny change)
95 * src/copy.c (set_author) [HAVE_STRUCT_STAT_ST_AUTHOR]:
96 Correctly access SRC_SB's element ST_AUTHOR.
98 2006-07-26 Jim Meyering <jim@meyering.net>
100 * tests/ls/stat-failed: Adapt to match new expected output.
103 * src/ls.c (print_color_indicator): Test for S_IFREG first, rather
104 than having the code test for all of the other types first.
105 Hoist the set-uid/gid-testing code "up" into this new block.
106 Classify any other type of file (e.g., S_TYPEISSHM, etc.) as
107 C_ORPHAN, not as C_FILE.
109 2006-07-26 Jim Meyering <jim@meyering.net>
111 Checking in a change from Paul.
113 2006-07-25 Paul Eggert <eggert@cs.ucla.edu>
115 * src/ls.c (DT_INIT): Remove. All uses removed.
116 (enum filetype): Use an ordinary enum rather than trying to keep
117 the values in sync with DT_FIFO etc. That way, we don't have
118 to make special assumptions about them. All uses changed.
119 (whiteout): New constant member of enum filetype.
120 (filetype_letter): New constant, for use with enum filetype.
121 (FILETYPE_INDICATORS): New initializer list.
122 (print_dir): Add case for DT_WHT.
123 (gobble_file): If stat fails, don't discard information from
124 readdir; instead, preserve it so it can be printed.
125 (print_long_format): Fall back on readdir result if stat info
126 is not available. Use "?" to denote each unknown mode char,
127 instead of an overall "?", since we now know some of the mode
129 (print_type_indicator): Now that MODE isn't necessarily
130 useful, guard all uses.
131 Now that two blocks in the type-checking tree can set "type = C_FILE",
132 move the suffix-handling code out and down.
134 2006-07-26 Jim Meyering <jim@meyering.net>
136 Prepare for the above change.
137 * src/ls.c [struct fileinfo] (stat_ok): Rename from stat_failed,
138 and adjust uses. From a patch by Paul Eggert.
140 2006-07-26 Jim Meyering <jim@meyering.net>
142 * src/ls.c: Correct indentation/formatting in a few places.
144 2006-07-25 Paul Eggert <eggert@cs.ucla.edu>
146 * tests/cp/fail-perm: Use "chmod 0500" rather than "chmod 500".
147 Problem report and fix from Bob Proulx.
148 * NEWS: Clarify the "chmod 0500" news, and correct the vague
149 statements about compatibility with BSD.
151 2006-07-25 Jim Meyering <jim@meyering.net>
153 * src/ls.c (gobble_file): When handling a stat-failed entry,
154 print the entry name not the absolute_name -- to be consistent
156 * tests/ls/stat-failed: Update accordingly.
158 * src/ls.c: Add parens around the new uses of ?: ternary operator.
160 * src/dircolors.hin: Mention that ORPHAN refers not just to dangling
163 Get --dired offsets right when handling stat-failed entries.
164 * src/ls.c (print_long_format): Be careful to increment P by the
165 appropriate amount, even when inode_number_width and nlink_width
167 * tests/ls/stat-failed: Test for the above.
169 * src/ls.c (gobble_file) [USE_ACL]: Don't use-uninitialized the
170 have_acl member. That would happen for a directory with both a
171 non-stat'able entry and one with an ACL.
173 * src/ls.c (gobble_file): Make it so failure to stat a
174 non-command-line file provokes an exit status of 1, not 0.
175 Say "cannot access" rather than "cannot stat".
176 * tests/ls/stat-failed: New file/test, for the above.
177 * tests/ls/Makefile.am (TESTS): Add stat-failed.
178 * tests/ls-2/tests (no-a-isdir-b): Update to reflect addition
179 of "cannot access " to diagnostic.
181 * src/ls.c: Declare stat_failed to be "bool", not "int" everywhere.
183 * src/ls.c [enum filetype] (command_line): Remove member. Not needed.
184 Replace all occurrences of "type == command_line" with the
185 equivalent, "command_line_arg".
187 * src/ls.c: Apply the stat-failed parts of Red Hat's
188 coreutils-selinux.patch. From Ulrich Drepper.
189 This makes it so files not mentioned on the command line (e.g.,
190 names read from a directory that *is* mentioned on the command
191 line) for which stat fails are still listed. With --color,
192 such files are colored just like ORPHANs (aka dangling symlinks).
194 * src/df.c (n_valid_args): Declare global to be static.
196 2006-07-24 Jim Meyering <jim@meyering.net>
198 * tests/ls/stat-dtype: Skip this test on reiserfs, since that file
199 system lacks d_type support.
201 2006-07-22 Paul Eggert <eggert@cs.ucla.edu>
203 * man/chmod.x: Update to reflect recent changes to coreutils.texi.
205 2006-07-21 Jim Meyering <jim@meyering.net>
207 * src/su.c (usage): Correct typo in --help output: s/commmand/command/
208 Reported by Tim Waugh.
209 Also remove the comment duplicating much of --help output.
211 * src/ls.c (FILE_TYPE_INDICATOR_OPTION): Reposition this new
212 name so the list remains alphabetized.
214 Fix another bug: ls --indicator-style=file-type would call
215 stat for a symlink, even though it wasn't always needed.
216 In some cases, that unnecessary stat would cause ls to fail.
217 * src/ls.c (gobble_file): Don't treat symlinks specially (in
218 requiring a stat syscall). Remove the offending exclusion.
220 * NEWS: Mention the fix.
222 * tests/ls/stat-dtype: New file/test, for the above fix.
223 Also exercises the new df feature, below.
225 * src/df.c (main): Fail and don't print the headers if no
226 file system is processed. This makes it easy to test whether
227 a specified directory is on a file system of a given type or types.
228 Otherwise, applications would have had to parse df's output.
229 E.g., is "." either ext3 or reiserfs: df -t ext3 -t reiserfs .
231 Fix a bug: ls --file-type worked like --indicator-style=slash,
232 rather than like --indicator-style=file-type.
233 * src/ls.c (FILE_TYPE_INDICATOR_OPTION): New enum member.
234 (long_options): Map "file-type" to FILE_TYPE_INDICATOR_OPTION,
236 (decode_switches): Handle new case: FILE_TYPE_INDICATOR_OPTION.
237 * NEWS: Mention the fix.
238 * tests/ls-2/tests (file-type): New test, for the above fix.
240 2006-07-19 Jim Meyering <jim@meyering.net>
242 * src/ls.c (print_dir): Give a better diagnostic for failed opendir.
244 * Makefile.am (EXTRA_DIST): Add build-aux/vc-list-files.
246 2006-07-16 Paul Eggert <eggert@cs.ucla.edu>
248 * NEWS: chmod, install, and mkdir now leave setgid and setuid bits
249 of directories alone unless you specify them explicitly.
250 install and mkdir now implement X correctly.
251 install now creates parent directories with mode 755, without
252 changing their owner or group.
253 * src/chmod.c (process_file): Adjust to mode_adjust API change.
254 * src/install.c: Include mkancesdirs.h.
255 (announce_mkdir, make_ancestor): New functions.
256 (DEFAULT_MODE): New macro, specifying initial value of 'mode'.
258 (dir_mode, dir_mode_bits): New vars.
259 (main): Set dir modes separately from nondir, so that the X
260 op of -m works correctly.
261 (main): Remove cwd_errno cruft, since make_dir_parents no longer
262 affects cwd. Adjust to new make_dir_parents API.
263 (install_file_in_file_parents): 2nd arg is now char *, not char
264 const *. Use mkancesdirs instead of rolling our own code.
265 (change_attributes): Don't worry about AFS, since that kludge
266 should not be needed any more.
267 * src/mkdir.c (struct mkdir_options): New struct.
268 (announce_mkdir, make_ancestor): New functions.
269 (main): Use them. Adjust to mode_adjust API change. Stick with
270 umask 0. Use make_dir_parents for all the work.
271 * src/mkfifo.c (main): Adjust to new mode_adjust API.
272 * src/mknod.c (main): Likewise.
273 * tests/chmod/setgid: Do the setgid test instead of bailing.
274 * tests/mkdir/p-3: Remove re_protect case that no longer applies.
275 GNU chmod now behaves like other versions of chmod.
276 * tests/mkdir/perm: Add a test for the X bug.
278 2006-07-14 Paul Eggert <eggert@cs.ucla.edu>
280 * src/base64.c (do_decode): Output to parameter OUT, not to stdout.
281 This doesn't fix any bugs, since OUT always equals stdout, but it
282 makes the code easier to understand.
284 2006-07-14 Jim Meyering <jim@meyering.net>
286 * Makefile.maint (CVS_LIST): Use new file, build-aux/vc-list-files,
287 rather than open-coding it. Now supports mercurial, too.
288 * .hgignore: New file.
289 * Makefile.am (EXTRA_DIST): Add .hgignore, which ignores nearly
290 all generated files, including ones like configure and po/*.po
291 that are currently version-controlled in cvs.
293 * Makefile.am (EXTRA_DIST): Add a few more .??* files.
294 They've been in CVS, just haven't been distributed before this.
295 Distribute ChangeLog-2005, too.
296 (MAINTAINERCLEANFILES): Add THANKS-to-translators.
298 2006-07-11 Paul Eggert <eggert@cs.ucla.edu>
300 * src/system.h: Assume <dirent.h> exists, since gnulib assumes
303 2006-07-09 Jim Meyering <jim@meyering.net>
305 * tests/mv/dir2dir: Adjust so failing with ENOTEMPTY is ok, too.
306 That happens with Linux/tmpfs.
307 * tests/mv/Makefile.am (TESTS): Add dir2dir.
309 2006-07-09 Paul Eggert <eggert@cs.ucla.edu>
311 Adjust to recent updates from gnulib.
312 * src/dd.c (apply_translations): Use toupper rather than
313 islower followed by toupper; it's simpler and typically
314 faster now that we assume at least C89 semantics. Similarly
316 * src/sort.c (inittables): Likewise.
317 * src/expand.c (expand): Don't assume that isprint etc. return
318 booleans (needed for pre-C99 hosts).
319 * src/fmt.c (check_punctuation): Likewise.
320 * src/ptx.c (initialize_regex, fix_output_parameters): Likewise.
321 * src/tr.c (is_char_class_member): Likewise.
322 * src/unexpand.c (unexpand): Likewise.
323 * src/join.c (is_blank): Remove; no longer needed. All uses
324 replaced by isblank (to_uchar (...)).
325 * src/pinky.c (create_fullname): Don't assume char is unsigned.
326 * src/printf.c (print_esc): Likewise.
327 * src/ptx.c (SKIP_NON_WHITE, SKIP_WHITE, SKIP_WHITE_BACKWARDS):
328 (copy_unescaped_string): Likewise.
329 * src/stat.c (print_it): Likewise.
330 * src/system.h (_D_EXACT_NAMELEN): Renamed from NLENGTH, for
331 convenience on GNU systems. All uses changed. Don't bother
332 looking for any dirent.h substitute other than ndir.h.
333 (D_INO): Remove unnecessary parentheses.
334 (IN_CTYPE_DOMAIN, ISGRAPH, ISPRINT, ISALNUM, ISALPHA):
335 (ISCNTRL, ISLOWER, ISPUNCT, ISSPACE, ISUPPER, ISXDIGIT):
336 (ISDIGIT_LOCALE, TOLOWER, TOUPPER): Remove. All uses changed
337 to ctype.h equivalents.
338 (isblank): Renamed from ISBLANK. Check for HAVE_DECL_ISBLANK too.
341 2006-07-08 Jim Meyering <jim@meyering.net>
343 * tests/mv/dir2dir: New file, test for 2006-07-05 fix in copy.c.
345 * Makefile.maint (sc_the_the): New rule.
347 * src/dd.c (skip): Remove one of two adjacent "the"s in a comment.
348 * tests/Coreutils.pm (run_tests): Remove one of two adjacent "then"s
351 2006-07-07 Jim Meyering <jim@meyering.net>
353 * NEWS: Mention that mv can now remove an empty destination directory,
354 and give an example. Prompted by a report from Florent Bayle.
356 2006-07-05 Jim Meyering <jim@meyering.net>
358 * src/ls.c (usage): Correct the description of -G: it is useful
359 only in a long listing. Reported by Martin Pool in
360 <https://launchpad.net/distros/ubuntu/+source/coreutils/+bug/51653>.
362 * man/chmod.x: Correct the description of the sticky bit. Reported
363 by Chris Moore via Ian Jackson in <http://bugs.debian.org/376745>.
365 * src/copy.c (copy_internal): Don't work around old NFS clients like
366 SunOS-4.1.4 and Irix 5.3 that set errno to values like EIO and
367 ENOTEMPTY upon failed rename. Otherwise, we risk misinterpreting
368 a banal failure as a recursive move-into-self failure.
369 Reported by Florent Bayle in <http://bugs.debian.org/376749>.
371 * src/c99-to-c89.diff: Regenerate, to remove fuzz.
373 2006-07-03 Jim Meyering <jim@meyering.net>
375 Plug another unusual leak.
376 (AD_mark_helper): Free malloc'd filename if hash_insert says
377 that string is already in the hash table.
379 The dev/inode of the topmost directory in each hierarchy were not
381 * src/remove.c (remove_cwd_entries): Don't call cycle_check here.
382 (AD_push): Call it from here instead.
385 * src/remove.c (AD_stack_clear): New function.
387 (AD_pop_and_chdir): Free *prev_dir just before longjmp.
389 * tests/Makefile.am, tests/*/Makefile.am: (TESTS_ENVIRONMENT):
390 Add $VG_PATH_PREFIX as a prefix to $PATH
392 * tests/envvar-check (vars): Add CDPATH and POSIXLY_CORRECT.
393 * tests/Makefile.am (evar-check): Remove rule.
394 (EXTRA_DIST): Remove .env-warn.
395 * tests/.env-warn: Remove file. No longer used.
396 Suggestion from Eric Blake.
398 2006-07-02 Paul Eggert <eggert@cs.ucla.edu>
400 * src/system.h: Include <stdint.h> unconditionally, since we
401 now assume the stdint module.
403 2006-07-01 Paul Eggert <eggert@cs.ucla.edu>
405 * NEWS: With no operand, 'tail -f' now silently ignores the '-f'
406 only if standard input is a FIFO or pipe and POSIXLY_CORRECT is set.
407 * src/tail.c (main): Implement this.
408 * tests/tail/Test.pm (f-pipe-1): Renamed from f-1.
409 (test_vector): Set POSIXLY_CORRECT for the f-pipe-* tests.
411 2006-07-01 Jim Meyering <jim@meyering.net>
413 * src/ln.c (do_link): Use new, shorter URL, for ag-review link.
415 * .x-sc_require_config_h: Add ^lib/xstrtold\.c$, so make distcheck
418 2006-06-30 Paul Eggert <eggert@cs.ucla.edu>
420 * NEWS: seq now uses long double internally rather than double.
421 It now defaults to a minimal fixed point format if possible.
422 It lets you use %a, %A, %E, %F, %G.
423 * src/Makefile.am (seq_LDADD): Remove $(SEQ_LIBM); add $(POW_LIB).
424 * src/seq.c: Don't include <math.h> or <xstrtol.h>; no longer needed.
425 (isfinite) [!defined isfinite]: New macro.
426 (separator, terminator): Now points to const.
427 (first, step, last): Remove.
428 (usage): Update to match new behavior.
429 (struct operand, operand): New type.
430 (scan_arg): Renamed from scan_double_arg, since we no longer use double.
432 Compute and return a value of type operand, not double.
433 (long_double_format): Renamed from valid_format, and now returns a
434 new format with an "L" added if needed, if the original format was
435 valid. Allow %a, %A, %E, %F, and %G formats.
436 (print_numbers): Take numeric values as args rather than from globals.
437 Print long double, not double.
438 (get_width_format): Remove.
439 (get_default_format): New function.
440 (main): Implement new way of calculating default format.
441 Don't worry about locale's representation of the decimal point, since
442 the arguments are always processed in the C locale.
443 * tests/seq/basic (neg-2): Adjust to new default format.
444 (eq-wid-1, eq-wid-2): Resurrect these tests, since the new
445 implementation should do the right thing.
447 2006-06-30 Jim Meyering <jim@meyering.net>
449 * tests/stty/basic-1: Work around an intermittent test failure
450 on HP-UX 11.11. Report and analysis from Bob Proulx.
451 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/7475
453 2006-06-28 Paul Eggert <eggert@cs.ucla.edu>
455 * NEWS: Support obsolete usages like "sort +1 -2" even when
456 conforming to POSIX 1003.1-2001, since this is a pure extension to
457 POSIX. Problem reported by Christian in:
458 http://lists.gnu.org/archive/html/bug-coreutils/2006-06/msg00220.html
459 * src/sort.c (main): Implement this.
461 * src/system.h (CLOSEDIR): Remove. All uses changed to closedir.
462 Autoconf 2.60 says this stuff was obsolete.
464 2006-06-28 Jim Meyering <jim@meyering.net>
466 * src/c99-to-c89.diff: Regenerate, to remove fuzz.
468 2006-06-28 Bob Proulx <bob@proulx.com> (tiny change)
470 * tests/mv/i-link-no: Work around HP-UX /bin/sh tracing problem
471 (set -x when VERBOSE=yes) when stderr is redirected before stdout
472 causing shell tracing of the stdout redirection to be written to
473 the stderr file. Avoid problem and test failure on HP-UX by
474 redirecting stderr last.
475 * tests/dd/unblock-sync: Order shell file redirections for
476 stderr and stdout in the common style.
479 2006-06-27 Jim Meyering <jim@meyering.net>
481 * tests/misc/cat-proc: Try to avoid any spurious numeric
482 differences in frequently-changing /proc/cpuinfo.
483 Reported by Nelson Beebe.
485 2006-06-26 Jim Meyering <jim@meyering.net>
487 Attempt rmdir (actually, unlinkat-with-AT_REMOVEDIR) upon any
488 fd_to_subdirp failure, not just when errno == EACCES.
489 * src/remove.c (remove_dir): Use unlinkat-with-AT_REMOVEDIR, not
490 rmdir, here, even though rmdir may happen to be adequate.
492 * NEWS: rm no longer fails to remove an empty, unreadable directory
493 * src/remove.c (remove_cwd_entries): If we can't open a directory,
494 and the failure is not being ignored, try to remove the directory
495 with rmdir (aka unlinkat-with-AT_REMOVEDIR), in case it's empty.
496 Problem report and test case from Paul Eggert in
497 <http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/7425>.
499 * tests/rm/empty-inacc: New test, for the above.
501 Avoid a segfault for wc --files0=- < /dev/null.
502 * src/wc.c (compute_number_width): Return right away if nfiles == 0.
504 2006-06-25 Jim Meyering <jim@meyering.net>
506 * NEWS: wc accepts a new option --files0-from=FILE, where FILE
507 contains a list of NUL-separated file names.
509 * src/wc.c: Include "readtokens.h".
510 (usage): Describe the new option, and adjust the `Usage':
511 with this option, no FILE may be specified on the command line.
512 (main): Handle the new option.
513 * tests/misc/wc-files0: New tests, for the above.
514 * tests/misc/wc-files0-from: Likewise.
515 * tests/misc/Makefile.am (TESTS): Add wc-files0.
517 2006-06-24 Jim Meyering <jim@meyering.net>
519 * src/md5sum.c (DIGEST_BUFFER): Remove now-unused definitions.
521 2006-06-22 Jim Meyering <jim@meyering.net>
523 * src/tee.c (tee_files): Rename from tee, to avoid conflict with
524 the function in glibc's <fcntl.h>. Reported by Andreas Schwab.
526 2006-06-19 Jim Meyering <jim@meyering.net>
528 * Makefile.cfg (local-checks-to-skip): Add changelog-check,
529 so this check is not run as part of "make distcheck".
531 2006-06-18 Bob Proulx <bob@proulx.com> (tiny change)
533 * tests/misc/pwd-long: Fix typo (s/neq/ne/) in previous change.
535 2006-06-18 Jim Meyering <jim@meyering.net>
537 * tests/misc/pwd-long: Make error output a little clearer.
539 2006-06-17 Jim Meyering <jim@meyering.net>
541 * tests/rm/inaccessible: Skip this test on systems without openat
542 support. Reported by Bob Proulx.
544 2006-06-15 Bob Proulx <bob@proulx.com> (tiny change)
546 * tests/misc/mknod: Improve permission checks to handle
547 running mkdir test in set-gid directories.
549 2006-06-14 Jim Meyering <jim@meyering.net>
551 * tests/du/basic: Revamp not to hard-code file system block sizes.
553 2006-06-12 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
555 * tests/du/Makefile.am (TESTS_ENVIRONMENT): Pass $(PERL), for
558 2006-06-11 Jim Meyering <jim@meyering.net>
560 * .gitignore: New file.
561 * Makefile.am (EXTRA_DIST): Add .gitignore.
563 Setting TIME_STYLE=long-iso in the environment would make the
564 cp/same-file test fail.
565 * tests/envvar-check (vars): Add TIME_STYLE to the list.
566 * tests/cp/same-file: Revert last change.
567 Source the envvar-check script, to ensure that TIME_STYLE
568 settings don't affect these tests.
570 2006-06-11 Paul Eggert <eggert@cs.ucla.edu>
572 * tests/cp/same-file: Execute 'ls' in the C locale, so that it
573 uses POSIX time stamp formats. Problem reported by John Nixon in
574 <http://lists.gnu.org/archive/html/bug-coreutils/2006-06/msg00062.html>.
576 2006-06-10 Jim Meyering <jim@meyering.net>
578 * NEWS: Mention the AIX-strndup-bug vs. dircolors workaround.
580 Require a "Version N.M" line at the top of the ChangeLog
581 file only when making the actual release, not when running
583 * Makefile.maint (maintainer-distcheck): Don't depend on
585 (alpha beta major): Depend on it here, instead.
587 2006-06-08 Jim Meyering <jim@meyering.net>
589 Ensure that cat works with any of the options, -A -v -e -E -T,
590 when applied to files in /proc and /sys, even when the FIONREAD
591 ioctl produces nonsensical results. Before this change, cat would
592 produce no output (or truncated output), for some linux kernels.
594 * src/cat.c (write_pending): New function, factored out of cat.
595 (cat): Also interpret a negative ioctl/FIONREAD count as indicating
596 that there are bytes to read. Some versions of linux-2.6.16 do that.
597 Write any pending output before returning.
598 Reported by Dan Jacobson in <http://bugs.debian.org/370583>.
599 * NEWS: Mention this bug fix.
600 * tests/misc/cat-proc: New file. Test for the above.
601 * tests/misc/Makefile.am (TESTS): Add cat-proc.
603 2006-06-07 Paul Eggert <eggert@cs.ucla.edu>
605 * src/expr.c (eval4): Detect overflow properly when multiplying
608 2006-06-06 Paul Eggert <eggert@cs.ucla.edu>
610 * NEWS: The 'expr' command now detects and reports integer overflow.
611 (It would be better to use extended precision instead, but that
613 * src/expr.c (integer_overflow): New function.
614 (eval4, eval3): Check for integer overflow.
616 2006-06-05 Paul Eggert <eggert@cs.ucla.edu>
618 Fix problems when building with Solaris/SVR4/etc. make, which uses a
619 different and somewhat bogus implementation of VPATH. In the
620 directory tests/misc, rename tests whose names might appear in the
621 Automake-generated rules. For example, we can't use a test named
622 'test', since Automake generates a rule that contains the text
623 "if test -f ./$$tst; ...", and this might expand to something like
624 "if ../../../coreutils-6.0/tests/misc/test -f ./$$test; ...",
625 which executes the 'test' script rather than the 'test' command.
626 * tests/misc/false-status: Renamed from tests/misc/false.
627 * tests/misc/pwd-long: Renamed from tests/misc/pwd.
628 * tests/misc/sort-merge: Renamed from tests/misc/sort.
629 ($prog): Set to 'sort' rather than to $PROG.
630 * tests/misc/test-diag: Renamed from tests/misc/test.
631 * tests/misc/Makefile.am (PROG): Take the basename of $$tst,
632 in case Solaris make has prepended the directory.
633 (TESTS): Adjust to above renamings.
634 * tests/misc/expand: Don't assign to PROG; no longer needed
635 now that Makefile.am sets PROG to the basename.
636 * tests/misc/fold: Likewise.
638 2006-06-03 Jim Meyering <jim@meyering.net>
640 Make `cp --link --no-dereference' work also on systems where the
641 link system call cannot create a hard link to a symbolic link.
642 * src/copy.c (copy_internal) [LINK_FOLLOWS_SYMLINKS]: Don't use
643 the link syscall on a symlink when it would do the wrong thing.
644 Based on the patch by Aurelien Jarno: <http://bugs.debian.org/329451>
645 * tests/cp/link-no-deref: New file/test for the above.
646 * tests/cp/Makefile.am (TESTS): Add link-no-deref.
647 * NEWS: Mention the change (doesn't affect Linux).
649 2006-06-01 Paul Eggert <eggert@cs.ucla.edu>
651 Fix some porting problems in the test cases reported by
652 Ralf Wildenhues for HP-UX 11.23 in:
653 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00238.html
654 * tests/help-version: Don't assume that \< \> works in sed.
655 * tests/misc/close-stdout: Don't assume that >&- works.
656 Add a /dev/full test.
657 * tests/touch/no-create-missing: Don't assume that >&- works.
659 2006-05-30 Jim Meyering <jim@meyering.net>
661 * src/ls.c (usage): Add `v' to the list of sorting-related options.
664 2006-05-28 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
666 * tests/cp/fail-perm: source lang-default.
667 * tests/rm/inaccessible: Likewise.
669 2006-05-28 Jim Meyering <jim@meyering.net>
671 * tests/rm/inaccessible: AIX 4.3.3 gives a different diagnostic.
672 Recognize it, too. Reported by Ralf Wildenhues, in
673 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
675 2006-05-27 Jim Meyering <jim@meyering.net>
677 * src/chgrp.c: Support new options: --preserve-root and
678 --no-preserve-root. Somehow this program was skipped when those
679 options were added to chown, chmod, and rm. Reported by
680 vaqflabuopac@spammotel.com in <http://bugs.debian.org/365656>.
681 * NEWS: Mention this.
683 2006-05-25 Paul Eggert <eggert@cs.ucla.edu>
685 * NEWS: Remove mention of --seed. We'll replace it with something
686 better, and don't want to indicate that it is supported.
687 * src/sort.c (usage): Likewise.
689 2006-05-20 Jim Meyering <jim@meyering.net>
691 * src/chmod.c (main): Use FTS_PHYSICAL here, too.
693 * src/du.c (main): Rename local, s/symlink_deref_bit/symlink_deref_bits/
694 and arrange for -D to set fts' FTS_PHYSICAL bit as well as
695 FTS_COMFOLLOW. Spotted by Justin Pryzby.
697 * gnupload: Merge changes from automake, retaining the ""--to...
698 kludge to placate overzealous `make distcheck' check.
700 2006-05-19 Jim Meyering <jim@meyering.net>
702 * src/du.c (main): Don't let -D, -L, or -P turn off the internal
703 FTS_TIGHT_CYCLE_CHECK directory traversal option.
704 Reported by Justin Pryzby in http://bugs.debian.org/367691
706 2006-05-15 Jim Meyering <jim@meyering.net>
708 * src/cp.c (usage): Correct description of -a: s/-dpR/-dpPR/.
711 2006-05-13 Jim Meyering <jim@meyering.net>
713 * tests/mv/no-target-dir: Test two more cases.
715 2006-05-11 Jim Meyering <jim@meyering.net>
717 mv -T DIR EMPTY_DIR no longer fails unconditionally
718 * src/copy.c (copy_internal): Don't manually prohibit a move where
719 the destination is an existing directory. Sometimes doing that is
720 valid. Let the rename system call enforce the rules. That is
721 allowed only when the source is a directory and the destination
722 directory (to be replaced) is empty. Reported by Eric Blake.
723 * tests/mv/no-target-dir: New file/test for this.
724 * tests/mv/Makefile.am (TESTS): Add no-target-dir.
725 * NEWS: Mention this.
727 * tests/mv/atomic: New file/test for yesterday's fix.
728 * tests/mv/Makefile.am (TESTS): Add atomic.
730 * tests/du/long-sloop: Avoid harmless `ambiguous redirect' diagnostic.
732 2006-05-10 Jim Meyering <jim@meyering.net>
734 * src/copy.c (copy_internal): Don't explicitly unlink the destination
735 when moving a symlink into the place of an existing non-directory.
736 Reported by Joshua Hudson.
737 * NEWS: mention this.
739 2006-05-07 Jim Meyering <jim@meyering.net>
741 * Makefile.maint (patch-check): Fail if patch generates any output,
742 even merely for changed offsets.
744 * src/c99-to-c89.diff: Adjust to reflect new offsets.
746 * NEWS: Mention changes affecting df, pwd, shred.
748 2006-05-06 Jim Meyering <jim@meyering.net>
750 * tests/ls/stat-vs-dirent: New test, to detect the bogus file
751 system condition where dirent.d_ino != stat.st_ino.
752 * tests/ls/Makefile.am (TESTS): Add stat-vs-dirent.
754 2006-05-06 Eric Blake <ebb9@byu.net>
756 * tests/ls/inode: Expand to test inode from readdir case.
757 * tests/ls/follow-slink: Expand to test broken links encountered
758 implicitly, favoring Solaris 9 and OpenBSD 3.4 behavior.
760 2006-05-06 Eric Blake <ebb9@byu.net>
762 * tests/mv/leak-fd: Work even on case-insensitive file system.
764 2006-05-04 Jim Meyering <jim@meyering.net>
766 * NEWS: Mention the 2006-03-19 pwd-related change that makes
767 lib/getcwd.c work around inconsistent file system dirent.d_ino data.
769 2006-05-03 Jim Meyering <jim@meyering.net>
771 * src/ls.c (DEFINE_SORT_FUNCTIONS, LIST_SORTFUNCTION_VARIANTS):
772 Use better macro parameter names: s/basename/key_name/,
773 s/basefunc/key_cmp_func. Fix typo in comment.
775 2006-04-29 Eric Blake <ebb9@byu.net>
777 * src/ls.c (main): On systems with d_type, directories_first only
778 implies format_needs_type, not format_needs_stat.
780 2006-05-03 Jim Meyering <jim@meyering.net>
782 * src/ls.c (xstrcoll_df_version, rev_xstrcoll_df_version): Add space
783 after comma in arg list, from Eric Blake.
785 2006-04-25 Paul Eggert <eggert@cs.ucla.edu>
787 * tests/misc/date (relative-3): New test, derived from a bug
788 report by John Thomas McDole.
790 2006-04-23 Francesco Montorsi <fr_m@hotmail.com>
792 New option for ls: --group-directories-first.
793 It makes ls list directories before files.
794 * NEWS [New features]: Mention it.
795 * src/ls.c (sort_type): Rearrange to use as an array index when
796 choosing sort function; added new sort_numtypes member for
798 (time_type): Add new time_numtypes member for compile-time check.
799 (directories_first): New global variable.
800 (GROUP_DIRECTORIES_FIRST_OPTION): New enum.
801 (long_options): Add --directories-first.
802 (main): Support new option.
803 (is_directory): New function.
804 (extract_dirs_from_files): Use it.
805 (DIRFIRST_CHECK, DEFINE_SORT_FUNCTIONS)
806 (LIST_SORTFUNCTION_VARIANTS): New macros.
807 (sort_functions): New global variable.
808 (sort_files): Use it.
809 (usage): Document new option.
811 2006-04-18 Paul Eggert <eggert@cs.ucla.edu>
813 * src/shred.c (fillrand): The assertion was way too weak, due to
814 what must be a typo. Strengthen it to its intended value.
815 (dopass): Don't use alloca; it's not worth the aggravation here,
816 since it's used only to get a page-aligned buffer, and page
817 alignment doesn't buy us much here. I'm suspicious that alloca
818 causes problems on some hosts, due to a recent bug report by Adam
819 Waltman: http://bugs.gentoo.org/130246.
821 2006-04-18 Jim Meyering <jim@meyering.net>
823 * tests/misc/tty-eof: Add new programs, base64, sha224sum, sha256sum,
824 sha384sum, sha512sum.
826 2006-04-17 Paul Eggert <eggert@cs.ucla.edu>
828 * src/chmod.c (describe_change): Adjust to filemode changes.
829 * src/ls.c (HAVE_ST_DM_MODE): Remove; moved to ../lib/filemode.c.
830 (print_long_format): Use (new) filemodestring rather than
831 (old) mode_string, so that we get more file types right, at least
832 in theory. Adjust to filemode changes.
833 * src/stat.c (human_access): Likewise.
835 2006-04-18 Jim Meyering <jim@meyering.net>
837 * src/ptx.c (main) [DEFAULT_IGNORE_FILE]: Remove code to use a default
838 ignore file. This has never been enabled. Reported by Eric Blake.
840 2006-04-12 Paul Eggert <eggert@cs.ucla.edu>
842 * src/ln.c (linkfunc): Remove. This method ran into a compiler/linker
843 bug in Interix. Just call symlink or link directly. All uses changed.
844 * src/setuidgid.c (main) [! HAVE_SETGROUPS]: Don't call setgroups.
845 * src/stat.c (USE_STATVFS): New macro.
846 Include <sys/statvfs.h> and use statvfs only if USE_STATVFS.
847 (NAMEMAX_FORMAT): define a bit more clearly, now that the
848 statvfs-using code is a bit more regular.
849 * src/system.h (sync) [!HAVE_SYNC]: New macro.
851 2006-04-11 Paul Eggert <eggert@cs.ucla.edu>
853 * NEWS: csplit, nl, expr now conform to POSIX better, and are
854 more-compatible with traditional Unix, with respect to regular
856 * src/csplit.c (extract_regexp): Set re_syntax_options to a
857 value that is compatible with what POSIX requires.
858 * src/nl.c (build_type_arg): Likewise.
859 * src/expr.c (docolon): Likewise. Also, don't let anchors match
860 newline; this fixes an incompatibility with tradition and with POSIX.
861 Don't warn about leading ^. POSIX says it is unspecified whether
862 ^ is a special character, which means that implementations can
863 either treat it as special or not, but either way a warning is not
864 allowed (unless the regexp is otherwise invalid). Instead, anchor
865 the expression but treat ^ as an anchor; this is the traditional
866 behavior (e.g., Solaris 10).
867 (eval4, eval3, eval2): Treat non-numeric args, division by zero,
868 and the like as invalid expressions (exit status 2), not as
869 failure of 'expr' (exit status 3). This is more consistent with
871 * tests/expr/basic (fail-a): Adjust exit status to match new expr
872 behavior, for status 2 versus 3.
874 (bre1, bre2, bre3, bre4, bre5, bre6, bre7, bre8, bre9, bre10):
875 (bre11, bre12, bre13, bre14, bre15, bre16, bre17, bre18, bre19, bre20):
876 (bre21, bre22, bre23, bre24, bre25, bre26, bre27, bre28, bre29, bre30):
877 (bre31, bre32, bre33, bre34, bre35, bre36, bre37, bre38, bre39, bre40):
878 (bre41, bre42, bre43, bre44, bre45, bre46, bre47, bre48, bre49, bre50):
879 (bre51, bre52, bre53, bre54, bre55, bre56, bre57, bre58, bre59, bre60):
880 (bre61, bre62): New tests.
881 * tests/misc/csplit: Use \{...\} in test RE, to test that we're
885 * tests/du/long-from-unreachable: Solaris 8 sh doesn't understand
886 "if !". Do not assume that 'sed' can handle long, newline-free input.
887 * tests/du/long-sloop: Likewise. Evaluate expr once, not $n times.
889 2006-04-10 Paul Eggert <eggert@cs.ucla.edu>
891 Adjust to new regex.h API (with new fastmap type), and clean
892 up the regex storage allocation a bit.
894 * src/csplit.c (struct control): Put re_compiled member at the
895 end, since it's large. Change regexpr member from char * to bool;
896 all uses changed. Add new member fastmap.
897 (extract_regexp): regexp arg is now char const *, not char *.
898 Don't bother duplicating the regular expression; it's not needed.
899 Set fastmap from new fastmap member. Don't bother allocating
900 a buffer, as the regexp code does a better job than we do.
901 * src/expr.c (docolon): Allocate and use a fastmap.
902 Don't bother allocating a buffer.
903 * src/nl.c (body_fastmap, header_fastmap, footer_fastmap):
905 (build_type_arg): New fastmap arg. All uses changed.
906 Don't bother allocating a buffer, but set a fastmap.
907 * src/ptx.c (context_regex_string, word_regex_string): Remove.
908 (context_regex, word_regex): New vars, replacing the above.
910 (struct regex_data): New type.
911 (compile_regex): Renamed from alloc_and_compile_regex, since
912 we no longer allocate storage. Arg is now a struct regex_data *,
913 not a const char *. All uses changed. Don't allocate the fastmap;
914 instead, take it from the caller. Don't convert size_t to int,
915 to avoid arithmetic overflow problems. Don't bother freeing
916 storage afterwards; it's not worth the aggravation.
917 * src/tac.c (compiled_separator_fastmap): New ver.
918 (main): Use it. Don't bother allocating a buffer.
920 2006-03-30 Jim Meyering <jim@meyering.net>
922 * src/dd.c (iwrite): Remove assignment without effect.
923 Reported by Felix Rauch Valenti.
925 2006-03-22 Eric Blake <ebb9@byu.net>
927 * src/ptx.c (usage): Remove mention of --copyright/-C.
928 (main): Alias --copyright to --version plus a deprecation warning.
929 * NEWS: Mention this.
931 2006-03-27 Jim Meyering <jim@meyering.net>
933 * src/Makefile.am (uptime_LDADD): Add $(POW_LIB), for uptime's
934 use of strtod. Tiny patch from Nickolai Zeldovich.
936 2006-03-11 Eric Blake <ebb9@byu.net>
938 * tests/misc/dirname: New file.
939 * tests/basename/Makefile.am: Delete.
940 * tests/basename/basic: Move to...
941 * tests/misc/basename: ... this new file. Add some tests,
942 including fixed behavior for //.
943 * tests/misc/Makefile.am (TESTS): Sort. Add basename, dirname.
944 * tests/Makefile.am (SUBDIRS): Remove basename.
945 * configure.ac (AC_CONFIG_FILES): Remove tests/basename.
947 Improvements to dirname/basename handling on platforms like
948 cygwin with distinct // and with drive letters.
949 * NEWS: Document new behavior.
950 * src/basename.c (main): Don't strip suffix from file system
952 * src/cp.c (target_directory_operand): Use new last_component.
953 (ASSIGN_BASENAME_STRDUPA): Likewise. Reduce time spent
954 traversing the string.
955 * src/dircolors.c (guess_shell_syntax): Use new last_component.
956 * src/install.c (target_directory_operand, install_file_in_dir):
958 * src/ln.c (target_directory_operand, main): Likewise.
959 * src/ls.c (basename_is_dot_or_dotdot): Likewise.
960 * src/mv.c (target_directory_operand, movefile): Likewise.
961 * src/remove.c (rm_1): Likewise.
962 * src/shred.c (wipename): Likewise.
963 * src/split.c (next_file_name): Likewise.
964 * src/su.c (log_su, run_shell): Likewise.
966 2006-03-23 Paul Eggert <eggert@cs.ucla.edu>
968 * NEWS: nohup diagnostics are now more precise, and nohup now
969 redirects stderr to nohup.out if stdout is closed and stderr is a tty.
970 * src/nohup.c (main): Implement this.
971 * tests/misc/nohup: Test the new behavior.
973 2006-03-12 Jim Meyering <jim@meyering.net>
975 * src/copy.c (set_author): Rename function, from preserve_author.
977 * src/remove.c (AD_pop_and_chdir): Use new macro,
978 CYCLE_CHECK_REFLECT_CHDIR_UP, rather than open-coding it.
980 * src/system.h (SAME_INODE): Remove definition.
981 Include "same-inode.h", instead.
983 2006-03-11 Eric Blake <ebb9@byu.net>
985 * src/pwd.c (robust_getcwd): Prepend only one slash, not two.
987 2006-03-10 Jim Meyering <jim@meyering.net>
989 Fix a bug whereby a user with write access to a directory being removed
990 could cause the removal of that directory to fail with an erroneous
991 diagnostic about a directory cycle. Reported by Vineet Chadha.
993 * NEWS: Mention this.
994 * src/remove.c (AD_pop_and_chdir): If the directory we're about to
995 leave (and try to rmdir) is the one whose dev_ino is being used to
996 detect a cycle, reset cycle_check_state.dev_ino to that of the parent.
998 2006-03-08 Paul Eggert <eggert@cs.ucla.edu>
1000 * NEWS: Document dd's new 'directory' and 'nolinks' flags.
1001 * src/dd.c (set_fd_flags): Handle file-creation flags on file
1002 descriptors, rather than ignoring them.
1003 * tests/dd/misc: Add test cases for append, nofollow, directory,
1004 and nolinks flags. Simplify redirection to /dev/null in some cases.
1006 * tests/dd/misc: iflags->iflag. This fixes a typo that meant the
1007 noatime test never tested anything.
1009 2006-03-05 Paul Eggert <eggert@cs.ucla.edu>
1011 * src/dd.c (flags, usage): New flags directory, nolinks.
1012 * src/system.h (O_NOLINKS): Define to 0 if not already defined.
1014 * src/ls.c (usage): Mention that -f disables --color.
1015 Problem reported by Niels Möller.
1017 2006-03-03 Justin Pryzby <pryzbyj@justinpryzby.com>
1019 * man/*.x: Add references to syscalls from utilities of the same name.
1021 2006-03-05 Jim Meyering <jim@meyering.net>
1023 * tests/help-version: Set SHELL, if not already set, in order to
1024 avoid failure when `make check' is run through debuild; dircolors
1025 would fail due to lack of $SHELL. Reported by Sven Joachim.
1027 Make `base64 --wrap=N' work for N=0, and for N larger than SIZE_MAX.
1028 * src/base64.c (wrap_write, do_encode, main): Change type of
1029 parameters and locals, wrap_column, form size_t to uintmax_t.
1030 (main): Adjust to use xstrtoumax, accordingly.
1032 2006-03-03 Jim Meyering <jim@meyering.net>
1034 Don't fail when run from an environment with SHELL not a Bourne
1035 shell, e.g. `env SHELL=/bin/csh make check' would fail this test.
1036 * tests/dircolors/simple: Invoke each non-failing test with -b.
1037 Reported by Michael Stone.
1039 2006-02-27 Jim Meyering <jim@meyering.net>
1041 * tests/misc/base64: Derive --decode-using tests from the
1044 * tests/misc/base64: Factor out a long constant string.
1045 Split lines to stay within 80 columns.
1047 * tests/misc/Makefile.am (TESTS): Add base64.
1048 * tests/misc/base64: Test base64. From Simon Josefsson.
1050 * src/base64.c (do_decode): Use correct type for parameter,
1051 ignore_garbage: s/size_t/bool/.
1053 * src/base64.c: Don't include .h files already included by system.h:
1054 <string.h>, <stdlib.h>, <stdbool.h>, <limits.h>, <errno.h>.
1055 Include "system.h" before the other lib/*.h header files.
1056 Include <sys/types.h> before "system.h".
1057 (wrap_write): Remove declaration of unused local, initial_column.
1058 (wrap_write): Correct declaration syntax: s/size_t * V/size_t *V/.
1060 * README: Add base64 to the list.
1062 2006-02-17 Simon Josefsson <jas@extundo.com>
1064 New program: base64.
1065 * AUTHORS: Mention base64.
1067 * man/Makefile.am: Build base64.1.
1068 * man/base64.x: New file.
1069 * src/Makefile.am (bin_PROGRAMS): Add base64.
1070 * src/base64.c: New file.
1072 2006-02-25 Eric Blake <ebb9@byu.net>
1074 In ls, avoid calling stat for --inode (-i), when possible.
1075 * src/pwd.c (NOT_AN_INODE_NUMBER, D_INO): Move to ...
1076 * src/system.h: ... here, for use in ...
1077 * src/ls.c (main): ... here. Prefer dirent.d_ino to stat when
1079 (gobble_file): Add inode argument.
1080 (print_dir): Pass inode if available.
1081 (usage): Remove inaccuracy.
1083 2006-02-23 Jim Meyering <jim@meyering.net>
1085 * TODO: Update/correct some obsolete entries.
1087 2006-02-20 Paul Eggert <eggert@cs.ucla.edu>
1089 * doc/coreutils.texi (join invocation): Mention `sort -k 1b,1'.
1090 * src/join.c (usage): Likewise.
1091 Documentation problem reported by Philip Kensche.
1093 2006-02-20 Eric Blake <ebb9@byu.net>
1095 * man/rm.x: Update documentation to match previous patch.
1097 2006-02-18 Eric Blake <ebb9@byu.net>
1099 New option for rm: --interactive=once (-I).
1100 * NEWS: Document it, along with change to rm --interactive.
1101 * TODO: Remove entry for implementing rm -I
1102 * src/rm.c (INTERACTIVE_OPTION): New enum value.
1103 (interactive_type): New enum.
1104 (long_opts): Let interactive take an optional argument.
1105 (interactive_args, interactive_types): New option arguments.
1106 (usage): Document -I, --interactive=WHEN. Use program_name
1107 instead of a basename.
1108 (main): New -I option, new behavior to --interactive.
1109 * tests/rm/interactive-once: New tests.
1110 * tests/rm/interactive-always: Ditto.
1111 * tests/rm/Makefile.am (TESTS): Run them.
1113 2006-02-18 Jim Meyering <jim@meyering.net>
1115 * Makefile.maint (sc_two_space_separator_in_usage): Make the regular
1116 expression match more of the target lines, e.g., those that start with
1117 `-S,' (short option followed by a comma) or that include `=[...]'.
1118 Patch by Nicolas François.
1119 Fix the four offenders thus exposed:
1120 * src/join.c (usage): Use two spaces (not one) to separate the
1121 --first-only option string from its description, so help2man formats
1122 the derived man page properly.
1123 * src/pr.c (usage): Likewise.
1124 * src/uniq.c (usage): Likewise.
1125 * src/install.c (usage): Likewise.
1127 2006-02-15 Jim Meyering <jim@meyering.net>
1129 * Makefile.maint (alpha beta major): For `make major', ensure that the
1130 version string is of the form N.N[.N]*, where N is one or more digits.
1132 2006-02-14 Jim Meyering <jim@meyering.net>
1134 * INSTALL: Update from gnulib.
1136 2006-02-13 Jim Meyering <jim@meyering.net>
1138 * GNUmakefile (all): Emit diagnostics to stderr, not stdout.
1140 2006-02-12 Jim Meyering <jim@meyering.net>
1142 * Makefile.maint (patch-check): New target.
1143 (local-checks-available): Add to the list.
1145 2006-02-11 Jim Meyering <jim@meyering.net>
1147 * src/c99-to-c89.diff: New file.
1148 * src/Makefile.am (EXTRA_DIST): Add c99-to-c89.diff.
1150 * .x-po-check: New file, with exclusions so that `make distcheck'
1152 * Makefile.am (EXTRA_DIST): Add .x-po-check.
1154 rm -r must remove an empty directory, even if it is inaccessible.
1155 * src/remove.c (close_preserve_errno): New function.
1156 (fd_to_subdirp): Don't print a diagnostic in this function.
1157 Do it from the callers instead, unless rmdir succeeds.
1158 (remove_cwd_entries, remove_dir): Adjust callers.
1159 * tests/rm/empty-inacc: New test for the above.
1160 * tests/rm/Makefile.am (TESTS): Add empty-inacc.
1161 * NEWS: Mention this bug fix.
1162 * tests/rm/rm2: Adjust two expected diagnostics, now that they're
1163 a tiny bit less precise: cannot remove `a/1': ... instead of
1164 cannot open directory `a/1': ...
1166 * Makefile.maint (syntax-check-rules): Automatically derive this
1167 list of sc_-prefixed rule names.
1169 2006-02-10 Paul Eggert <eggert@cs.ucla.edu>
1171 * Makefile.maint (CVS_LIST): Don't assume cvsu is available.
1172 (CVS_LIST_EXCEPT): New macro, to simplify exception-processing.
1173 Most uses of CVS_LIST changed to use CVS_LIST_EXCEPT.
1174 (syntax-check-rules): Bring back sc_changelong. (Hmm, why did it
1175 go away? was that an accident?)
1176 (sc_cast_of_argument_to_free, sc_cast_of_x_alloc_return_value):
1177 (sc_cast_of_alloca_return_value, sc_space_tab, sc_prohibit_atoi_atof):
1178 (sc_error_exit_success, sc_file_system, sc_no_if_have_config_h):
1179 (sc_system_h_headers, sc_sun_os_names, sc_trailing_blank):
1180 (sc_two_space_separator_in_usage, sc_unmarked_diagnostics):
1181 (sc_obsolete_symbols, sc_changelog, sc_prohibit_jm_in_m4):
1182 (sc_useless_cpp_parens, makefile-check, m4-check, po-check):
1183 (author_mark_check, makefile_path_separator_check):
1184 Output line numbers, to simplify navigation of Emacs *compilation*
1186 (sc_prohibit_atoi_atof, sc_file_system):
1187 Rework slightly so that Makefile.maint doesn't get reported as a
1188 violation of its own syntax rules.
1189 (sc_dd_max_sym_length): Use ifneq to do nothing, instead of doing
1190 it at run-time (which didn't work with Bison). Fix a makefile typo,
1191 caught by Makefile.maint itself: spaces where a tab should be.
1192 (po-check): Check lib/*.[ch] even if not in CVS; used by Bison,
1193 which copies from ../gnulib/lib/*.[ch] to lib/*.[ch].
1194 Ignore djgpp and man subdirectories, to avoid false matches with
1195 Bison and coreutils, respectively. Use sort -u to remove the
1196 resulting duplicates.
1197 * gnupload: Rework slightly to avoid bogus warning from
1198 sc_two_space_separator_in_usage.
1200 2006-02-10 Jim Meyering <jim@meyering.net>
1202 Use gzip's --rsyncable option only if it's available.
1203 * Makefile.maint (gzip_rsyncable): New variable.
1206 2006-02-08 Jim Meyering <jim@meyering.net>
1208 * Makefile.maint (local-checks-available): Define in terms of
1209 the expansion, $(syntax-check-rules), rather than the single,
1210 top-level target `syntax-check', so that it's easier to exclude
1211 individual rules (via $(local-checks-to-skip)).
1212 (tgz-md5, tgz-sha1, ...): Remove now-unused definitions.
1214 2006-02-07 Jim Meyering <jim@meyering.net>
1216 * src/system.h (!defined O_DIRECT): If O_DIRECTIO is defined (as it
1217 is on Tru64), define O_DIRECT to that. Patch From James Lemley.
1219 * tests/help-version (expected_failure_status_vdir):
1220 Redirect an expected disk-full diagnostic to /dev/null.
1222 2006-02-06 Jim Meyering <jim@meyering.net>
1224 * src/unexpand.c (usage): Use two spaces (not one) to separate the
1225 --first-only option string from its description, so help2man formats
1226 the derived man page properly.
1227 * src/rm.c (usage): Likewise for --no-preserve-root.
1228 * src/chown.c (usage): Likewise.
1229 * src/chgrp.c (usage): Likewise.
1231 Add a rule to ensure that the above doesn't happen again.
1232 * Makefile.maint (sc_two_space_separator_in_usage): New rule.
1233 (syntax-check-rules): Add it.
1234 * .x-sc_two_space_separator_in_usage: New empty file.
1235 * Makefile.am (EXTRA_DIST): Add .x-sc_two_space_separator_in_usage.
1237 2006-02-06 Jim Meyering <jim@meyering.net>
1239 * src/cp.c (usage): Use two spaces (not one) to separate each
1240 option string from its description, so help2man formats the
1241 derived man page properly.
1242 * src/mv.c (usage): Likewise.
1243 Patch from Nicolas François in http://bugs.debian.org/351601.
1245 2006-02-04 Jim Meyering <jim@meyering.net>
1247 * src/copy.c (copy_internal): cp -RL would fail when encountering
1248 the same directory more than once in the hierarchy beneath a single
1249 command-line argument. That is legitimate, e.g. when there are
1250 two or more symbolic links, each pointing to some directory that
1251 would not otherwise be copied. Reported by Christophe LYON.
1252 * tests/cp/cp-deref: New file. Test for today's fix.
1253 * tests/cp/Makefile.am (TESTS): Add cp-deref.
1254 * NEWS: Document this.
1256 2006-02-03 Jim Meyering <jim@meyering.net>
1258 * configure.ac: Require automake-1.9.6, not 1.8.3.
1260 2006-02-01 Paul Eggert <eggert@cs.ucla.edu>
1262 * src/od.c (usage): Mention that -t a ignores high order bit.
1263 Documentation problem reported by Ed Avis.
1265 2006-02-01 Jim Meyering <jim@meyering.net>
1267 * src/pwd.c (find_dir_entry): Remove unused local, `ent_sb_valid'.
1269 2006-01-30 Paul Eggert <eggert@cs.ucla.edu>
1271 * src/head.c (main): Use a better diagnostic when someone uses a
1272 trailing numeric option in an invalid way. Problem reported by
1274 * src/tail.c (parse_options): Likewise.
1276 2006-01-30 Jim Meyering <jim@meyering.net>
1278 * man/wc.x: Include `count' keyword in man page synopsis,
1279 per suggestion from http://bugs.debian.org/181585.
1281 2006-01-24 Paul Eggert <eggert@cs.ucla.edu>
1283 * src/df.c (show_dev): If the file system claims to have
1284 more available than total blocks, report the number of used
1285 blocks as being total - available (a negative number) rather
1286 than as garbage. Problem reported by Toralf Foerster.
1288 2006-01-24 Jim Meyering <jim@meyering.net>
1290 * src/tail.c (tail_forever): Don't exit-nonzero when an attempt
1291 to put a regular file in O_NONBLOCK mode fails with EPERM.
1292 That happens on Linux (up to 2.6.15) when using tail -f on a file with
1293 the append-only attribute. Reported by Dean Gaudet. For details,
1294 see http://savannah.gnu.org/bugs/?func=detailitem&item_id=15473.
1295 * NEWS: Mention this fix.
1296 * tests/tail-2/append-only: New file. Test for the above.
1297 * tests/tail-2/Makefile.am (TESTS): Add append-only.
1298 * tests/Makefile.am (check-root): Add tail-2/append-only
1300 2006-01-21 Jim Meyering <jim@meyering.net>
1302 * NEWS: Mention fts-related improvements and bug fixes.
1304 2006-01-19 Jim Meyering <jim@meyering.net>
1306 * tests/fmt/basic (pfx-1, pfx-2): New tests, to demonstrate the bug
1307 reported as http://bugs.debian.org/147577. Forwarded by Thomas Hood.
1309 2006-01-18 Jim Meyering <jim@meyering.net>
1311 * tests/du/Makefile.am (TESTS): Add long-from-unreadable.
1313 2006-01-17 Jim Meyering <jim@meyering.net>
1315 Now that fts no longer changes the current working directory, adjust
1316 its clients accordingly -- note that du.c uses fts but doesn't need
1317 any adjustment, since it doesn't operate on the actual files,
1318 but rather just uses the stat buffers provided by fts.
1320 * src/chown-core.c: Include "openat.h".
1321 Don't include "lchown.h".
1322 (restricted_chown): Accept a new parameter, CWD_FD, and use it in
1323 calling openat, lchownat, chownat, rather than open, lchown, chown.
1325 * src/chmod.c: Include "openat.h".
1326 (process_file): Use chmodat (fts->fts_cwd_fd,... in place of chmod (...
1328 * tests/du/long-from-unreadable: New test, to exercise one small
1331 2006-01-13 Jim Meyering <jim@meyering.net>
1333 * tests/Makefile.am (SUBDIRS): Add comments discouraging the
1334 addition of new directories under tests/.
1336 * tests/acl: Redirect stdin to /dev/null. Otherwise, FreeBSD 5.0's
1339 2006-01-12 Jim Meyering <jim@meyering.net>
1341 * tests/du/long-sloop: Adjust not to hard-code the expected
1342 diagnostic corresponding to ELOOP. Solaris' diagnostic differs
1343 from that of GNU libc. Reported by Paul Eggert.
1345 * tests/du/long-sloop: Create file at end of symlink chain.
1347 * tests/misc/test: New file, with a test for one of the
1348 bugs fixed by yesterday's test.c changes.
1349 * tests/misc/Makefile.am (TESTS): Add test.
1351 2006-01-11 Jim Meyering <jim@meyering.net>
1353 * tests/du/long-sloop: New file. Test for today's fts.c bug fix.
1354 That bug could make du -L, chgrp -L, or chown -L fail to diagnose
1355 a very long sequence of symbolic links (not necessarily a loop).
1356 * tests/du/Makefile.am (TESTS): Add long-sloop.
1358 2006-01-11 Paul Eggert <eggert@cs.ucla.edu>
1360 * src/test.c (test_syntax_error): Append a newline. All callers
1361 changed, except for the ones that didn't already append a newline.
1362 Bug reported by Eric Blake.
1364 2006-01-11 Jim Meyering <jim@meyering.net>
1366 * src/system.h (X2NREALLOC): Now that verify_true is no longer
1367 void, cast its result to void, to avoid gcc's warning that
1368 ``left-hand operand of comma expression has no effect''.
1369 (DECIMAL_DIGIT_ACCUMULATE, X2REALLOC): Likewise.
1371 2006-01-10 Jim Meyering <jim@meyering.net>
1373 * tests/chmod/no-x: Add a test for today's fts.c fix.
1375 2006-01-10 Jim Meyering <jim@meyering.net> (tiny change)
1377 * src/ls.c (gobble_file): Use DTTOIF only if it's defined.
1378 This is necessary for Dragonfly. Patch by Joerg Sonnenberger.
1380 2006-01-10 Paul Eggert <eggert@cs.ucla.edu>
1382 * src/system.h (X2NREALLOC, X2REALLOC, DECIMAL_DIGIT_ACCUMULATE):
1383 Use verify_true instead of verify_expr, to sync with gnulib.
1385 2006-01-08 Jim Meyering <jim@meyering.net>
1387 * src/date.c (usage): Adjust the formatting of the entries for
1388 %::z and %:::z (separate with two spaces, not one) so that help2man
1389 formats them properly. Reported by Philip Rowlands.
1391 2006-01-06 Paul Eggert <eggert@cs.ucla.edu>
1393 * configure.ac (gl_IGNORE_UNUSED_LIBRARIES): Add.
1395 2006-01-06 Jim Meyering <jim@meyering.net>
1397 * Makefile.maint (copyright-check): Use date +%Y in place of
1400 * src/remove.c (rm_1): Remove `static' attribute on local `status'.
1401 First off, the attribute should have been `volatile' (not static)
1402 to avoid longjmp-related risk of clobber. Secondly, now there is
1403 no longer any risk of a local variable being clobbered, so there's
1404 no need for any attribute at all.
1406 2006-01-05 Jim Meyering <jim@meyering.net>
1408 * src/remove.c: Give a few functions the inline attribute.
1409 (AD_pop_and_chdir): Use gotos to avoid some duplication.
1410 (AD_push): Rewrite an assertion so that the entire computation
1411 goes away when assertions are turned off.
1413 * src/tail.c (ENOSYS) [!defined ENOSYS]: Don't define here.
1414 It's already defined in "system.h".
1415 * Makefile.maint: Add a FIXME comment.
1417 2006-01-04 Jim Meyering <jim@meyering.net>
1419 * ChangeLog: Remove entries from 2005-10-22 and earlier.
1420 * ChangeLog-2005: New file, for entries up to version 5.92.
1422 2006-01-03 Jim Meyering <jim@meyering.net>
1424 * tests/du/no-x: Also allow a slightly different diagnostic -- the
1425 one you get when using openat-enabled fts.c and du (coming soon).
1426 * tests/chmod/no-x: Likewise.
1427 * tests/chgrp/no-x: Likewise.
1429 * src/system.h (O_DIRECTORY) [!defined O_DIRECTORY]: Define.
1431 2006-01-02 Paul Eggert <eggert@cs.ucla.edu>
1433 * src/chown-core.c (RC_do_ordinary_chown): New enum value.
1434 (restricted_chown): Return it, if the file cannot be accessed due
1435 to EPERM, or if no uid or gid are required, or if the file is
1436 neither a directory nor a regular file. Rewrite to avoid gotos.
1437 (change_file_owner): Handle RC_do_ordinary_chown case.
1438 Rewrite to avoid gotos.
1439 * tests/chgrp/basic: Make sure we can change the group of
1442 * src/date.c (usage): Explain %g, %G, and %V a bit better.
1444 2006-01-02 Jim Meyering <jim@meyering.net>
1446 * src/copy.c (set_owner): Correct a comment.
1448 * src/tail.c (parse_options): Change warning to say that --retry
1449 is useful `mainly' (not `only') when following by name.
1450 Reported here: http://bugs.debian.org/273781
1452 2006-01-01 Paul Eggert <eggert@cs.ucla.edu>
1454 * NEWS: Document that mkfifo and mknod -m no longer set special bits.
1455 * src/copy.c: Include lchmod.h.
1456 (copy_internal): Use lchmod rather than chmod.
1457 * src/cp.c: Include lchmod.h.
1458 (re_protect, make_dir_parents_private): Use lchmod rather than chmod.
1459 * src/mkdir.c: Include lchmod.h.
1460 (usage): Clarify -m's operation.
1461 (main): Use lchmod rather than chmod. Don't use lchmod unless the
1462 new mode contains bits outside the 777 range.
1463 * src/mkfifo.c (usage): Clarify -m's operation.
1464 (main): If -m is given, don't invoke chmod; use umask 0 instead.
1465 Report an error if -m asks for bits outside the 777 range.
1466 * src/mknod.c (usage, main): Likewise.
1468 * src/mkdir.c, src/mkfifo.c, src/mknod.c: Undo 2005-12-19 changes.
1470 2005-12-27 Jim Meyering <jim@meyering.net>
1472 * Makefile.maint (sc_obsolete_symbols): Prohibit use of O_NDELAY.
1473 (sc_prohibit_assert_without_use): New rule.
1474 (syntax-check-rules): Add it to the list.
1475 * .x-sc_prohibit_assert_without_use: New empty file.
1476 * Makefile.am (EXTRA_DIST): Add it.
1478 * Makefile.maint (CVS_LIST): Define in terms of $(srcdir).
1480 * cp.c, df.c, link.c, mknod.c, nice.c, sleep.c, unlink.c:
1481 Don't include <assert.h>; it wasn't used.
1483 2005-12-26 Paul Eggert <eggert@cs.ucla.edu>
1485 * src/chown-core.c (restricted_chown):
1486 Don't try O_WRONLY unless O_RDONLY failed wth EACCES.
1487 * src/remove.c (fd_to_subdirp): Open with O_DIRECTORY | O_NOCTTY
1488 | O_NOFOLLOW too, for consistency with other dir-openers.
1489 Use POSIX-preferred O_NONBLOCK rather than O_NDELAY.
1490 (is_empty_dir): Likewise.
1491 * src/shred.c (wipename): Likewise. Don't bother trying to open
1492 dir for writing, since POSIX prohibits it.
1494 2005-12-22 Jim Meyering <jim@meyering.net>
1496 * tests/help-version: Redirect stderr to /dev/full, to suppress
1497 write error diagnostic.
1499 2005-12-19 Jim Meyering <jim@meyering.net>
1501 * src/mkdir.c, src/mknod.c, src/mkfifo.c (main)
1502 Avoid a minor race condition when `-m MODE' is specified, by using
1503 open, fchown, and close rather than just chown. To do that reliably --
1504 even with an overly restrictive umask -- ensure that each mkdir,
1505 mknod and mkfifo call uses a mode including at least owner-read access.
1506 * src/mknod.c (main): When `-m MODE' is specified, exit nonzero if
1507 the subsequent chown (or equivalent open,fchown,close) fails.
1508 * tests/misc/mknod: New tests.
1509 * tests/misc/Makefile.am (TESTS): Add mknod.
1511 2005-12-17 Jim Meyering <jim@meyering.net>
1513 * src/remove.c (is_empty_dir): Open with O_NDELAY, so we don't hang,
1514 e.g., on a named pipe.
1515 (OPEN_NO_FOLLOW_SYMLINK): Remove definition. Use O_NOFOLLOW in
1516 place of all uses, since it is guaranteed (system.h) to be defined.
1518 2005-12-05 Andreas Gruenbacher <agruen@suse.de>
1520 Add POSIX ACL support
1521 * src/ls.c: Switch back from HAVE_ACL to USE_ACL: The acl() syscall
1522 is no requirement for ACL support; particularly, it does not exist
1523 on systems that have POSIX ACLs.
1524 * src/copy.h (cp_option_init) [umask_kill]: Remove member.
1525 * src/cp.c (umask_kill): With default acls, the umask is not to be
1526 applied. Remove umask_kill, don't change the process umask, and let
1527 the kernel apply the umask where appropriate.
1528 * src/cp.c (make_dir_parents_private): Fix logic for POSIX ACLs.
1529 * src/copy.c (get_dest_mode): Remove; it is obsolete after removing
1531 (copy_reg, copy_internal): Use copy_acl and set_acl
1532 instead of fchown/chown. Fix the logic for POSIX ACLs.
1533 (chown_succeded): Remove; we now always copy acls and
1534 preserve S_ISUID, S_ISGID, and S_ISVTX when needed, no matter if we
1535 did a chown before or not.
1536 * src/mv.c, src/install.c (cp_option_init): Don't set umask_kill member.
1537 * src/Makefile.am (dir_LDADD, ls_LDADD, vdir_LDADD, cp_LDADD,
1538 mv_LDADD, ginstall_LDADD): On systems with an ACL library, arrange
1539 to link with it via $(LIB_ACL), for the utilities that need it.
1541 2005-12-16 Paul Eggert <eggert@cs.ucla.edu>
1543 * src/remove.c (OPENAT_CWD_RESTORE__REQUIRE): Remove.
1544 (OPENAT_CWD_RESTORE__ALLOW_FAILURE): Likewise.
1545 (fd_to_subdirp): Remove openat_cwd_restore_allow_failure arg; its
1546 value is now signified by whether cwd_errno is null.
1547 (fd_to_subdirp, remove_dir, rm_1); Change cwd failure indicator from
1548 pointer-to-bool to pointer-to-errno-value. All callers changed.
1549 (rm_1): Don't bother setting a local cwd failure flag and then
1550 ORing it into the caller's. Just set the caller's.
1551 (rm): Use cwd failure errno value to print a slightly-better
1554 2005-12-15 Jim Meyering <jim@meyering.net>
1556 * src/stat.c (print_it): Properly handle a backslash at the
1557 end of a --printf format string. Reported by Paul Eggert.
1558 * tests/misc/stat-printf (end-bs): Add a test for the above.
1560 2005-12-15 Paul Eggert <eggert@cs.ucla.edu>
1562 * tests/acl: Port to pre-POSIX shells like Solaris 8 /bin/sh.
1563 Don't assume /etc/passwd contains user names; use 'id' instead.
1565 2005-12-15 Jim Meyering <jim@meyering.net>
1567 stat: revert behavior of --format=FMT (-c)
1568 stat: add new option: --printf=FMT
1569 * NEWS: Mention this.
1570 * src/stat.c (isodigit, octtobin, hextobin): Define.
1571 (PRINTF_OPTION): Define.
1572 (interpret_backslash_escapes, trailing_delim): New globals.
1573 (usage): Document them. Alphabetize on long option names.
1574 (print_esc_char): New function.
1575 (print_it): Rewrite, in order to handle backslash escapes.
1576 (main): Handle new option. Set globals for --format, too.
1578 * tests/misc/stat-printf: Test --printf and --format.
1579 * tests/misc/Makefile.am (TESTS): Add stat-printf.
1581 2005-12-14 Paul Eggert <eggert@cs.ucla.edu>
1583 * NEWS: sort now reports incompatible options.
1584 * src/sort.c (incompatible_options, check_ordering_compatibility):
1586 (main): Use them. Don't bother with a usage message for
1587 "sort -c a b", for consistency with other error diagnostics.
1588 * tests/sort/Test.pm (incompat1, incompat2, incompat3, incompat4):
1591 * src/cat.c (main): Undo previous change. close_stdout already
1592 does the check, so the previous change wasn't necessary.
1594 2005-12-13 Paul Eggert <eggert@cs.ucla.edu>
1596 * src/cat.c (main): Check for close (STDOUT_FILENO) failure.
1598 2005-12-12 Paul Eggert <eggert@cs.ucla.edu>
1600 Install a more-conservative approach for sort -R. It's the
1601 same basic idea as the existing code, except it uses the full ISAAC
1602 approach (called the "more kosher" approach in the existing comments).
1603 This makes "sort -R" quite a bit slower (about a factor of 2 on my
1604 little tests involving 10000 lines on a 2.4 GHz P4), but I think it's
1605 better to be conservative here at first, and review any performance
1606 improvements carefully.
1607 * .x-sc_require_config_h: Add src/rand-isaac.c.
1608 * src/rand-isaac.h: Remove. All uses now simply include rand-isaac.c.
1609 * src/Makefile.am (noinst_HEADERS): Remove rand-isaac.h.
1610 (shred_SOURCES, sort_SOURCES): Remove.
1611 (EXTRA_DIST): Add rand-isaac.c.
1612 * src/rand-isaac.c: Revert to what used to be in shred.c, without
1613 changing it to allow for varying numbers of words in the state.
1614 Alter so that we include rand-isaac.c directly rather than
1615 compiling it and linking to it. Don't include config.h or
1616 system.h; that's the includer's responsibility.
1617 Omit functions that are specific to shred.
1618 (ISAAC_LOG, ISAAC_WORDS, ISAAC_BYTES, struct isaac_state, ind):
1619 (isaac_step, struct irand_state):
1620 Resurrect these, with the same defns that used to be in shred.c.
1621 (ISAAC_SIZE, isaac_new, isaac_copy): Remove.
1622 (isaac_refill, isaac_seed_start, isaac_seed_data, irand_init, irand32):
1624 (struct isaac_state, isaac_refill, isaac_mix, isaac_init):
1625 (isaac_seed_start, isaac_seed_data, isaac_seed_finish, isaac_seed):
1626 (irand_init, irand32, irand_mod):
1627 Number of words is constant again.
1628 (struct irand_state, irand_init, irand32, irand_mod): Move to shred.c.
1629 * src/shred.c: Include rand-isaac.c rather than rand-isaac.h.
1630 * src/sort.c: Likewise.
1631 * src/shred.c (fillrand, dopass, main): Undo previous change.
1632 (struct irand_state, irand_init, irand32, irand_mod): Moved back here,
1634 * src/sort.c: Don't include md5.h; it wasn't needed.
1635 (struct keyfield): Rename random_hash to random, for consistency
1636 with the other member names. All uses changed.
1637 (usage): Tweak wording to mention STRING for --seed option.
1638 (short_options): Rorder for consistency with other programs.
1639 (rand_state): Now a struct, not a pointer to one. All uses changed.
1640 (HASH_WORDS, HASH_SIZE): Remove.
1641 (get_hash): Remove comments around resbuf size, since we can assume C89.
1642 Use a "more-kosher" (but slower) approach of invoking isaac_refill.
1643 (keycompare): Adjust to the new get_hash.
1645 (badfieldspec): Omit recently-introduced comment; it isn't needed.
1646 (main): Don't set need_random simply because gkey has it set; that
1647 doesn't necessarily mean we'll need random numbers.
1648 Redo seeding to match new get_hash approach.
1650 2005-12-10 Jim Meyering <jim@meyering.net>
1652 * src/Makefile.am (noinst_HEADERS): Add rand-isaac.h.
1654 Avoid shred segfault on 64-bit systems.
1655 * src/rand-isaac.c (isaac_refill): Don't try to negate a
1656 local of type uint32_t. Make the local an `int' instead.
1658 * NEWS: Mention sort's new options.
1660 * src/rand-isaac.c (isaac_mix): Declare to be static.
1661 Mark all other functions as `extern' so the tight-scope
1662 part of `make distcheck' passes once again.
1663 * src/rand-isaac.h (isaac_mix): Remove declaration.
1665 * src/sort.c (get_hash): Change position of `*' in parameter
1666 type to conform with convention.
1667 (main): Split a long line so it fits in 80 columns.
1668 (keycompare): Remove stray SPACE before TAB that was
1669 causing `make distcheck' to fail.
1671 * src/shred.c: Don't include gethrxtime.h. No longer needed.
1673 * tests/misc/sort-rand: New file: basic tests for the new options.
1674 * tests/misc/Makefile.am (TESTS): Add sort-rand.
1676 2005-12-10 Frederik Eaton <frederik@ofb.net>
1678 * src/Makefile.am (sort_LDADD): Add $(LIB_GETHRXTIME).
1679 (shred_SOURCES, sort_SOURCES): New macros, so we compile rand-isaac.c.
1680 * src/rand-isaac.c: New file, containing ISAAC code that was in shred.c.
1681 Make state size runtime-configurable.
1682 (isaac_new, isaac_copy): New functions.
1683 * src/rand-isaac.h: New file.
1684 * src/shred.c: Include rand-isaac.h. Move ISAAC code to rand-isaac.c.
1685 (fillrand, main): Adjust to the fact that the state size is now
1686 runtime-configurable.
1687 * src/sort.c (short_options, long_options, WORDS, keycompare, main):
1688 (usage): Add options --random-sort and --seed to implement a random
1690 Include md5.h and rand-isaac.h.
1691 (get_hash): New function.
1692 (rand_state): New var.
1693 (HASH_WORDS, HASH_SIZE): New macros.
1695 2005-12-09 Paul Eggert <eggert@cs.ucla.edu>
1697 * tests/dd/misc: Add test for dd iflags=noatime.
1699 2005-12-09 Jim Meyering <jim@meyering.net>
1701 * src/sort.c (usage): Mention white space vs -b and -t options.
1704 2005-12-09 Eric Blake <ebb9@byu.net>
1706 * src/test.c (main): Fix misleading comment.
1708 2005-12-07 Paul Eggert <eggert@cs.ucla.edu>
1710 * NEWS: Mention dd's new noatime flag.
1711 * src/system.h (O_NOATIME): Define to 0 if not already defined.
1712 * src/dd.c (flags, usage): Add support for noatime flag.
1714 2005-12-07 Jim Meyering <jim@meyering.net>
1716 Distribute the cvsu script, used only by `make syntax-check'.
1717 * Makefile.am (EXTRA_DIST): Add build-aux/cvsu.
1718 * Makefile.maint (CVS_LIST): Use build-aux/cvsu, now that we
1719 distribute a copy of this script.
1720 * .x-sc_unmarked_diagnostics: Add build-aux/cvsu.
1722 * tests/mv/acl: exit-77 before the trap, not after, if we fail
1723 to create a temporary directory on another partition.
1724 From Andreas Gruenbacher.
1726 2005-12-06 Tomas Pospisek <tpo@sourcepole.ch> (tiny change)
1728 * man/basename.x: Cross-reference to dirname and readlink.
1729 * man/dirname.x: Cross-reference to basename and readlink.
1731 2005-12-05 Andreas Gruenbacher
1733 * src/copy.c [!HAVE_FCHOWN]: Define fchown(...) to -1.
1734 (set_owner, preserve_author): New functions, factored out of copy_reg.
1735 (copy_reg): Use them.
1736 (copy_internal): Use them here, too.
1738 2005-12-04 Jim Meyering <jim@meyering.net>
1740 * src/sleep.c (usage): Say what happens with two or more arguments.
1741 Suggested by Justin Pryzby.
1743 * src/uptime.c (print_uptime): Move decl of `upsecs' into scope
1746 2005-12-03 Jim Meyering <jim@meyering.net>
1748 * src/rm.c (long_opts): Change the name of each undocumented, for-
1749 testing-only option to start with `-', so that it cannot render
1750 ambiguous any prefix it happens to share with some other option name.
1751 Problem reported by Eric Blake.
1752 * src/head.c (long_options): Likewise.
1753 * src/tail.c (long_options): Likewise.
1755 * tests/misc/head-elide-tail: Update uses of undocumented, for-
1756 testing-only --presume* options to start with `---'.
1757 * tests/rm/dangling-symlink: Likewise.
1758 * tests/rm/dir-no-w: Likewise.
1759 * tests/rm/isatty: Likewise.
1761 2005-11-30 Jim Meyering <jim@meyering.net>
1763 * Makefile.maint: Add a comment about cvsu.
1765 2005-11-25 Paul Eggert <eggert@cs.ucla.edu>
1767 * NEWS: df updates for "none", "proc", inaccessible file systems.
1768 * src/df.c (show_point): Ignore inaccessible file systems.
1769 (usage): -a includes dummy file systems, not size-0 file systems.
1771 * src/od.c (unsigned_long_long_int): Renamed from ulonglong_t,
1772 to avoid collision with POSIX name space. All uses changed.
1774 2005-11-24 Jim Meyering <jim@meyering.net>
1776 * tests/Makefile.am (EXTRA_DIST): Add acl to the list.
1777 * tests/acl: Add `$0: ' prefix to diagnostics.
1779 * .x-sc_require_config_h: Add lib/buffer-lcm.c to the list.
1781 2005-11-23 Paul Eggert <eggert@cs.ucla.edu>
1783 * src/copy.c: Improve performance a bit by optimizing away
1784 unnecessary system calls and going to a block size of at least
1785 8192 (on normal hosts, anyway). This improved performance 5% on my
1786 Debian stable host (2.4.27 kernel, x86, copying from root
1787 ext3 file system to itself).
1788 Include "buffer-lcm.h".
1789 (copy_reg): Omit last argument. All callers changed.
1790 Use xmalloc to allocate rather than trusting alloca
1791 (which is unwise with large block sizes).
1792 Declare locals more locally, if possible.
1793 Use uintptr_t words instead of int words, for a bit more speed
1794 when looking for null blocks on 64-bit hosts.
1795 Optimize away reads of zero bytes on regular files.
1796 In the typical case, insist on 8 KiB buffers, at least.
1797 Avoid unnecessary extra call to fstat when checking for sparse files.
1798 Avoid now-unnecessary cast to off_t, and "0L".
1799 Avoid unnecessary test of *new_dst when checking for same owner
1802 2005-11-22 Paul Eggert <eggert@cs.ucla.edu>
1804 * src/remove.c (rm): Don't assume C99 for-loop syntax.
1806 2005-11-22 Jim Meyering <jim@meyering.net>
1808 * src/remove.c (AD_push): Remove debugging cruft.
1810 * tests/rm/unread2 (rm): Change expected diagnostic,
1811 `cannot open directory' to `cannot remove', to align with
1813 * tests/rm/rm2: Ensure that rm now continues removing entries
1814 even after certain types of failure.
1816 * src/remove.c: Rewrite. Now, this module is reentrant on systems
1817 that provide openat (Solaris), and on systems like Linux+procfs
1818 where our openat emulation code is reentrant. This also fixes a
1819 few low-probability leaks and eliminates some code that could,
1820 in very unusual circumstances, cause rm() (via a callee) to exit.
1821 * NEWS: Mention this.
1823 * configure.ac: Put copyright dates all on one line so the
1824 emacs function that updates them works properly.
1826 2005-11-18 Paul Eggert <eggert@cs.ucla.edu>
1828 * configure.ac (AM_PROG_CC_C_O): Add. Needed for CVS Automake.
1829 Problem reported by Eric Blake.
1830 (AC_PROG_CC_STDC): Use this instead of AC_PROG_CC, so that
1831 we get a standard-conforming compiler. This relies on the new
1832 m4/c.m4 file. Note that it's a bit tricky, since c.m4 doesn't
1833 define AC_PROG_CC_STDC; we are relying on Autoconf 2.59 internals.
1834 m4/c.m4 can go away with Autoconf 2.60 comes out.
1836 2005-11-17 Jim Meyering <jim@meyering.net>
1838 * src/remove.c (AD_mark_helper): Make a `char *' parameter `const'.
1839 (AD_mark_current_as_unremovable): Likewise, but for a local.
1842 * tests/mv/acl: Let traps handle removing temporary directories.
1844 Expect acl-related tests to fail, until the corresponding
1845 patches are committed.
1846 * tests/mv/Makefile.am (XFAIL_TESTS): Add acl.
1847 * tests/cp/Makefile.am (XFAIL_TESTS): Likewise.
1849 ACL tests, from Andreas Gruenbacher.
1850 * tests/acl, tests/mv/acl, tests/cp/acl: New files.
1851 * tests/mv/Makefile.am (TESTS): Add acl.
1852 * tests/cp/Makefile.am (TESTS): Add acl.
1854 * src/ls.c (basename_is_dot_or_dotdot): Correct wording in comment.
1856 2005-11-16 Paul Eggert <eggert@cs.ucla.edu>
1858 * NEWS: Improve quality of ln's diagnostics.
1859 * src/ln.c (do_link, usage): Likewise.
1860 (do_link): Don't use alloca on a buffer of unbounded size.
1862 2005-11-16 Jim Meyering <jim@meyering.net>
1864 * tests/cp/fail-perm: Accommodate HPUX. It appears to fail
1865 with EACCES rather than EPERM. Reported by Peter O'Gorman here:
1866 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/5766
1867 This also affects AIX 4.3.3, according to Ralf Wildenhues, in
1868 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
1870 2005-11-14 Jim Meyering <jim@meyering.net>
1872 * NEWS (sort): Mention consequences of today's mkstemp-safer.c fix.
1874 2005-11-13 Jim Meyering <jim@meyering.net>
1876 * announce-gen: Accept new option, --gpg-key-id=ID and
1877 emit a blurb telling how to use the .sig files.
1878 * Makefile.cfg (gpg_key_ID): Define.
1879 * Makefile.maint (announcement): Use new option and key.
1881 Require that most .c files include <config.h>.
1882 * Makefile.maint (sc_require_config_h): New rule.
1883 (syntax-check-rules): Add it.
1884 * .x-sc_require_config_h: New file listing exceptions to the
1885 above rule. Some are legit, others are simply grandfathered in.
1886 * Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h here, too.
1888 2005-11-12 Jim Meyering <jim@meyering.net>
1890 * src/checksum.h, src/md5.c, src/sha1sum.c: Remove now-unused files.
1892 2005-11-11 Jim Meyering <jim@meyering.net>
1894 * NEWS: Mention `readlink -f' bug fix in 5.3.0 news.
1895 Mention new readlink options in 5.3.0's `New features' section.
1896 Spotted by Thomas Hood.
1898 2005-11-08 Jim Meyering <jim@meyering.net>
1900 * NEWS: Merge in changes from b5_9x branch.
1902 2005-11-08 Paul Eggert <eggert@cs.ucla.edu>
1904 * NEWS: ls now defaults to --time-style='locale', which in turn acts
1905 like --time-style='posix-long-iso' if the locale settings are messed up.
1906 * src/ls.c (decode_switches): Implement this.
1908 2005-11-08 Jim Meyering <jim@meyering.net>
1910 * tests/du/2g: s/expensive/very expensive/ in a comment.
1913 2005-10-17 Eric Blake <ebb9@byu.net>
1915 * src/ls.c (usage): Fix descriptions of --sort, --time.
1916 Reported by Vitaly A. Ostanin.
1918 2005-11-04 Paul Eggert <eggert@cs.ucla.edu>
1920 * src/ln.c: Include filenamecat.c.
1921 (FILE_BASENAME_CONCAT): Remove.
1922 (do_link): Remove last arg DEST_IS_DIR. All callers changed.
1923 (main): Use file_name_concat, base_name, and strip_trailing_slashes
1924 instead of FILE_BASENAME_CONCAT. This simplifies the code, and avoids
1927 2005-11-04 Jim Meyering <jim@meyering.net>
1929 * src/du.c (process_file): Don't overflow for files of size >= 2^31
1930 on systems with stat.st_blocks of a signed 32-bit type.
1931 This bug causes trouble on some AIX 5.1 systems.
1932 Report and trivial patch from Paul Townsend:
1933 <http://lists.gnu.org/archive/html/bug-coreutils/2005-11/msg00033.html>
1934 * NEWS: Mention this.
1936 * tests/du/2g: New (very-expensive) test for the above-fixed bug.
1937 * tests/du/Makefile.am (TESTS): Add it here.
1938 * tests/very-expensive: New file.
1939 * tests/Makefile.am (EXTRA_DIST): Add it here.
1940 * tests/cp/perm: Mark this test as `very-expensive', too.
1942 2005-11-02 Paul Eggert <eggert@cs.ucla.edu>
1944 * NEWS: Mention that rm -d and maybe ln -d are scheduled for
1946 * src/remove.h (struct rm_options): Remove unlink_dirs. All uses
1948 * src/rm.c (usage): Don't mention rm -d.
1950 2005-11-02 Jim Meyering <jim@meyering.net>
1952 * tests/dd/skip-seek: Fix typo in comment: s/fileutils/coreutils.
1953 From Andreas Schwab.
1955 * tests/dd/unblock-sync: Redirect stderr to /dev/null so the
1956 `M+N records in/out' lines don't pollute `make check' output.
1958 * tests/dd/skip-seek (sk-seek4): New test, to exercise the bug
1959 fixed on 2005-10-31. This test uses the new, IN_PIPE specifier.
1960 * tests/Coreutils.pm: Accept a new type of input specifier: IN_PIPE,
1961 to indicate that the input file should be piped into the command
1962 under test (via `cat FILE | $prog ...').
1964 * src/remove.c (remove_entry): Emit a better diagnostic when rm
1965 (without -r) fails to remove a directory on a non-Linux system.
1966 This change affects only newer Solaris systems (with priv_*
1967 functions like priv_allocset). Reported by Keith Thompson.
1969 * tests/rm/dir-nonrecur: New file/test for the above fix.
1970 * tests/rm/Makefile.am (TESTS): Add dir-nonrecur.
1972 2005-11-01 Paul Eggert <eggert@cs.ucla.edu>
1974 * NEWS: "tail -c 2 FILE" and "touch 0101000000" now operate as
1975 POSIX 1002.1-2001 requires.
1976 * src/tail.c (parse_obsolete_option): Implement this.
1977 Problem reported by Vincent Lefevre.
1978 * src/touch.c (main): Pass PDS_PRE_2000 to posixtime.
1979 * tests/tail/Test.pm (c-2, c-2-minus, c2, c2-minus): New tests.
1980 (test_vector): Add special cases for _POSIX2_VERSION, and
1981 regularize the old ones a bit.
1982 * tests/touch/obsolescent: Add y2000 test.
1984 2005-10-31 Paul Eggert <eggert@cs.ucla.edu>
1986 * src/dd.c (skip): Fix off-by-one error reported by
1987 Theodoros V. Kalamatianos.
1989 2005-10-30 Paul Eggert <eggert@cs.ucla.edu>
1991 * tests/mkdir/p-3: Require that the test be run as non-root.
1992 Problem and trivial fix reported by Theodoros V. Kalamatianos.
1994 2005-10-28 Paul Eggert <eggert@cs.ucla.edu>
1996 * src/ln.c (FILE_BASENAME_CONCAT): Omit unnecessary slashes in the
1997 boundary between DEST and SOURCE in the result.
1999 2005-10-26 Dmitry V. Levin <ldv@altlinux.org>
2001 * src/md5sum.c (main) [!O_BINARY]: Changed default read mode
2002 back to text, to sync with documentation and for backwards
2005 2005-10-25 Jim Meyering <jim@meyering.net>
2007 * tests/dircolors/simple (other-wr): Add an explicit test for
2008 the dircolors bug (NULL-dereference) fixed yesterday.
2010 2005-10-24 Jim Meyering <jim@meyering.net>
2012 * src/tac.c (tac_file): When determining whether a file is seekable,
2013 also test whether it is a tty. Using only the lseek-based test would
2014 give a false positive on Solaris. Reported by Peter Fales.
2016 2005-10-24 Dmitry V. Levin <ldv@altlinux.org>
2018 * tests/install/d-slashdot: New test, for "install -d" failure.
2019 * tests/install/Makefile.am (TESTS): Add d-slashdot.
2020 * tests/mkdir/p-slashdot: New test, for "mkdir -p" failure.
2021 * tests/mkdir/Makefile.am (TESTS): Add p-slashdot.
2023 2005-10-24 Jim Meyering <jim@meyering.net>
2025 * src/dircolors.c (ls_codes): Add missing comma.
2026 Anonymous report and patch from
2027 http://savannah.gnu.org/bugs/?func=detailitem&item_id=14849
2029 * src/dircolors.c: Add compile-time assertion that the slack_codes
2030 and ls_codes arrays have the same number of elements. This would
2031 have prevented the above-fixed bug.
2033 * src/expand.c (parse_tab_stops): Add a comment to make this function
2034 identical to the one in unexpand.c.
2035 * src/unexpand.c (parse_tab_stops): Adjust syntax to make this function
2036 identical to the one in expand.c.
2038 * src/expand.c (next_file): Don't assume fopen cannot return stdin.
2040 2005-10-23 Jim Meyering <jim@meyering.net>
2042 * src/md5sum.c (digest_check, main): Use ptr_align rather than
2043 a dangerous pointer-value-to-`unsigned' cast.
2044 * NEWS: mention the new sha* programs.
2045 * AUTHORS: Add new sha* programs.
2047 2005-08-28 David Madore <david.madore@ens.fr>
2049 Add new programs: sha224sum, sha256sum, sha384sum, sha512sum.
2050 * README: Add their names to the list.
2051 * src/md5sum.c: Provide framework for computing sha-2 hashes.
2052 * src/Makefile.am (sha224sum, sha256sum, sha384sum, sha512sum):
2053 Rules for compiling sha-2 utilities
2054 (noinst_HEADERS): Remove checksum.h.
2055 * man/sha512sum.x, man/sha384sum.x, man/sha256sum.x, man/sha224sum.x:
2057 * man/Makefile.am (dist_man_MANS): Add the corresponding .1 names.
2058 (sha224sum.1, sha256sum.1, sha384sum.1, sha512sum.1): New dependencies.
2059 * tests/misc/sha224sum, tests/misc/sha256sum: New files.
2060 * tests/misc/sha384sum, tests/misc/sha512sum: New files.
2061 * tests/misc/Makefile.am (TESTS): Add new sha224sum, sha256sum,
2062 sha384sum, sha512sum test scripts here rather that each in its
2065 2005-08-28 David Madore <david.madore@ens.fr>
2067 * tests/sha1sum/basic-1 (million-a): Add the "million a's" test (one
2068 of the FIPS test vectors).
2070 2005-10-23 Jim Meyering <jim@meyering.net>
2072 * configure.ac: Use 6.0-cvs as the version string.
2073 * NEWS: Adjust accordingly.