1 2006-05-27 Jim Meyering <jim@meyering.net>
5 * src/chgrp.c: Support new options: --preserve-root and
6 --no-preserve-root. Somehow this program was skipped when those
7 options were added to chown, chmod, and rm. Reported by
8 vaqflabuopac@spammotel.com in <http://bugs.debian.org/365656>.
11 2006-05-25 Paul Eggert <eggert@cs.ucla.edu>
13 * NEWS: Remove mention of --seed. We'll replace it with something
14 better, and don't want to indicate that it is supported.
15 * src/sort.c (usage): Likewise.
17 2006-05-20 Jim Meyering <jim@meyering.net>
19 * src/chmod.c (main): Use FTS_PHYSICAL here, too.
21 * src/du.c (main): Rename local, s/symlink_deref_bit/symlink_deref_bits/
22 and arrange for -D to set fts' FTS_PHYSICAL bit as well as
23 FTS_COMFOLLOW. Spotted by Justin Pryzby.
25 * gnupload: Merge changes from automake, retaining the ""--to...
26 kludge to placate overzealous `make distcheck' check.
28 2006-05-19 Jim Meyering <jim@meyering.net>
30 * src/du.c (main): Don't let -D, -L, or -P turn off the internal
31 FTS_TIGHT_CYCLE_CHECK directory traversal option.
32 Reported by Justin Pryzby in http://bugs.debian.org/367691
34 2006-05-15 Jim Meyering <jim@meyering.net>
36 * src/cp.c (usage): Correct description of -a: s/-dpR/-dpPR/.
39 2006-05-13 Jim Meyering <jim@meyering.net>
41 * tests/mv/no-target-dir: Test two more cases.
43 2006-05-11 Jim Meyering <jim@meyering.net>
45 mv -T DIR EMPTY_DIR no longer fails unconditionally
46 * src/copy.c (copy_internal): Don't manually prohibit a move where
47 the destination is an existing directory. Sometimes doing that is
48 valid. Let the rename system call enforce the rules. That is
49 allowed only when the source is a directory and the destination
50 directory (to be replaced) is empty. Reported by Eric Blake.
51 * tests/mv/no-target-dir: New file/test for this.
52 * tests/mv/Makefile.am (TESTS): Add no-target-dir.
55 * tests/mv/atomic: New file/test for yesterday's fix.
56 * tests/mv/Makefile.am (TESTS): Add atomic.
58 * tests/du/long-sloop: Avoid harmless `ambiguous redirect' diagnostic.
60 2006-05-10 Jim Meyering <jim@meyering.net>
62 * src/copy.c (copy_internal): Don't explicitly unlink the destination
63 when moving a symlink into the place of an existing non-directory.
64 Reported by Joshua Hudson.
67 2006-05-07 Jim Meyering <jim@meyering.net>
69 * Makefile.maint (patch-check): Fail if patch generates any output,
70 even merely for changed offsets.
72 * src/c99-to-c89.diff: Adjust to reflect new offsets.
74 * NEWS: Mention changes affecting df, pwd, shred.
76 2006-05-06 Jim Meyering <jim@meyering.net>
78 * tests/ls/stat-vs-dirent: New test, to detect the bogus file
79 system condition where dirent.d_ino != stat.st_ino.
80 * tests/ls/Makefile.am (TESTS): Add stat-vs-dirent.
82 2006-05-06 Eric Blake <ebb9@byu.net>
84 * tests/ls/inode: Expand to test inode from readdir case.
85 * tests/ls/follow-slink: Expand to test broken links encountered
86 implicitly, favoring Solaris 9 and OpenBSD 3.4 behavior.
88 2006-05-06 Eric Blake <ebb9@byu.net>
90 * tests/mv/leak-fd: Work even on case-insensitive file system.
92 2006-05-04 Jim Meyering <jim@meyering.net>
94 * NEWS: Mention the 2006-03-19 pwd-related change that makes
95 lib/getcwd.c work around inconsistent file system dirent.d_ino data.
97 2006-05-03 Jim Meyering <jim@meyering.net>
99 * src/ls.c (DEFINE_SORT_FUNCTIONS, LIST_SORTFUNCTION_VARIANTS):
100 Use better macro parameter names: s/basename/key_name/,
101 s/basefunc/key_cmp_func. Fix typo in comment.
103 2006-04-29 Eric Blake <ebb9@byu.net>
105 * src/ls.c (main): On systems with d_type, directories_first only
106 implies format_needs_type, not format_needs_stat.
108 2006-05-03 Jim Meyering <jim@meyering.net>
110 * src/ls.c (xstrcoll_df_version, rev_xstrcoll_df_version): Add space
111 after comma in arg list, from Eric Blake.
113 2006-04-25 Paul Eggert <eggert@cs.ucla.edu>
115 * tests/misc/date (relative-3): New test, derived from a bug
116 report by John Thomas McDole.
118 2006-04-23 Francesco Montorsi <fr_m@hotmail.com>
120 New option for ls: --group-directories-first.
121 It makes ls list directories before files.
122 * NEWS [New features]: Mention it.
123 * src/ls.c (sort_type): Rearrange to use as an array index when
124 choosing sort function; added new sort_numtypes member for
126 (time_type): Add new time_numtypes member for compile-time check.
127 (directories_first): New global variable.
128 (GROUP_DIRECTORIES_FIRST_OPTION): New enum.
129 (long_options): Add --directories-first.
130 (main): Support new option.
131 (is_directory): New function.
132 (extract_dirs_from_files): Use it.
133 (DIRFIRST_CHECK, DEFINE_SORT_FUNCTIONS)
134 (LIST_SORTFUNCTION_VARIANTS): New macros.
135 (sort_functions): New global variable.
136 (sort_files): Use it.
137 (usage): Document new option.
139 2006-04-18 Paul Eggert <eggert@cs.ucla.edu>
141 * src/shred.c (fillrand): The assertion was way too weak, due to
142 what must be a typo. Strengthen it to its intended value.
143 (dopass): Don't use alloca; it's not worth the aggravation here,
144 since it's used only to get a page-aligned buffer, and page
145 alignment doesn't buy us much here. I'm suspicious that alloca
146 causes problems on some hosts, due to a recent bug report by Adam
147 Waltman: http://bugs.gentoo.org/130246.
149 2006-04-18 Jim Meyering <jim@meyering.net>
151 * tests/misc/tty-eof: Add new programs, base64, sha224sum, sha256sum,
152 sha384sum, sha512sum.
154 2006-04-17 Paul Eggert <eggert@cs.ucla.edu>
156 * src/chmod.c (describe_change): Adjust to filemode changes.
157 * src/ls.c (HAVE_ST_DM_MODE): Remove; moved to ../lib/filemode.c.
158 (print_long_format): Use (new) filemodestring rather than
159 (old) mode_string, so that we get more file types right, at least
160 in theory. Adjust to filemode changes.
161 * src/stat.c (human_access): Likewise.
163 2006-04-18 Jim Meyering <jim@meyering.net>
165 * src/ptx.c (main) [DEFAULT_IGNORE_FILE]: Remove code to use a default
166 ignore file. This has never been enabled. Reported by Eric Blake.
168 2006-04-12 Paul Eggert <eggert@cs.ucla.edu>
170 * src/ln.c (linkfunc): Remove. This method ran into a compiler/linker
171 bug in Interix. Just call symlink or link directly. All uses changed.
172 * src/setuidgid.c (main) [! HAVE_SETGROUPS]: Don't call setgroups.
173 * src/stat.c (USE_STATVFS): New macro.
174 Include <sys/statvfs.h> and use statvfs only if USE_STATVFS.
175 (NAMEMAX_FORMAT): define a bit more clearly, now that the
176 statvfs-using code is a bit more regular.
177 * src/system.h (sync) [!HAVE_SYNC]: New macro.
179 2006-04-11 Paul Eggert <eggert@cs.ucla.edu>
181 * NEWS: csplit, nl, expr now conform to POSIX better, and are
182 more-compatible with traditional Unix, with respect to regular
184 * src/csplit.c (extract_regexp): Set re_syntax_options to a
185 value that is compatible with what POSIX requires.
186 * src/nl.c (build_type_arg): Likewise.
187 * src/expr.c (docolon): Likewise. Also, don't let anchors match
188 newline; this fixes an incompatibility with tradition and with POSIX.
189 Don't warn about leading ^. POSIX says it is unspecified whether
190 ^ is a special character, which means that implementations can
191 either treat it as special or not, but either way a warning is not
192 allowed (unless the regexp is otherwise invalid). Instead, anchor
193 the expression but treat ^ as an anchor; this is the traditional
194 behavior (e.g., Solaris 10).
195 (eval4, eval3, eval2): Treat non-numeric args, division by zero,
196 and the like as invalid expressions (exit status 2), not as
197 failure of 'expr' (exit status 3). This is more consistent with
199 * tests/expr/basic (fail-a): Adjust exit status to match new expr
200 behavior, for status 2 versus 3.
202 (bre1, bre2, bre3, bre4, bre5, bre6, bre7, bre8, bre9, bre10):
203 (bre11, bre12, bre13, bre14, bre15, bre16, bre17, bre18, bre19, bre20):
204 (bre21, bre22, bre23, bre24, bre25, bre26, bre27, bre28, bre29, bre30):
205 (bre31, bre32, bre33, bre34, bre35, bre36, bre37, bre38, bre39, bre40):
206 (bre41, bre42, bre43, bre44, bre45, bre46, bre47, bre48, bre49, bre50):
207 (bre51, bre52, bre53, bre54, bre55, bre56, bre57, bre58, bre59, bre60):
208 (bre61, bre62): New tests.
209 * tests/misc/csplit: Use \{...\} in test RE, to test that we're
213 * tests/du/long-from-unreachable: Solaris 8 sh doesn't understand
214 "if !". Do not assume that 'sed' can handle long, newline-free input.
215 * tests/du/long-sloop: Likewise. Evaluate expr once, not $n times.
217 2006-04-10 Paul Eggert <eggert@cs.ucla.edu>
219 Adjust to new regex.h API (with new fastmap type), and clean
220 up the regex storage allocation a bit.
222 * src/csplit.c (struct control): Put re_compiled member at the
223 end, since it's large. Change regexpr member from char * to bool;
224 all uses changed. Add new member fastmap.
225 (extract_regexp): regexp arg is now char const *, not char *.
226 Don't bother duplicating the regular expression; it's not needed.
227 Set fastmap from new fastmap member. Don't bother allocating
228 a buffer, as the regexp code does a better job than we do.
229 * src/expr.c (docolon): Allocate and use a fastmap.
230 Don't bother allocating a buffer.
231 * src/nl.c (body_fastmap, header_fastmap, footer_fastmap):
233 (build_type_arg): New fastmap arg. All uses changed.
234 Don't bother allocating a buffer, but set a fastmap.
235 * src/ptx.c (context_regex_string, word_regex_string): Remove.
236 (context_regex, word_regex): New vars, replacing the above.
238 (struct regex_data): New type.
239 (compile_regex): Renamed from alloc_and_compile_regex, since
240 we no longer allocate storage. Arg is now a struct regex_data *,
241 not a const char *. All uses changed. Don't allocate the fastmap;
242 instead, take it from the caller. Don't convert size_t to int,
243 to avoid arithmetic overflow problems. Don't bother freeing
244 storage afterwards; it's not worth the aggravation.
245 * src/tac.c (compiled_separator_fastmap): New ver.
246 (main): Use it. Don't bother allocating a buffer.
248 2006-03-30 Jim Meyering <jim@meyering.net>
250 * src/dd.c (iwrite): Remove assignment without effect.
251 Reported by Felix Rauch Valenti.
253 2006-03-22 Eric Blake <ebb9@byu.net>
255 * src/ptx.c (usage): Remove mention of --copyright/-C.
256 (main): Alias --copyright to --version plus a deprecation warning.
257 * NEWS: Mention this.
259 2006-03-27 Jim Meyering <jim@meyering.net>
261 * src/Makefile.am (uptime_LDADD): Add $(POW_LIB), for uptime's
262 use of strtod. Tiny patch from Nickolai Zeldovich.
264 2006-03-11 Eric Blake <ebb9@byu.net>
266 * tests/misc/dirname: New file.
267 * tests/basename/Makefile.am: Delete.
268 * tests/basename/basic: Move to...
269 * tests/misc/basename: ... this new file. Add some tests,
270 including fixed behavior for //.
271 * tests/misc/Makefile.am (TESTS): Sort. Add basename, dirname.
272 * tests/Makefile.am (SUBDIRS): Remove basename.
273 * configure.ac (AC_CONFIG_FILES): Remove tests/basename.
275 Improvements to dirname/basename handling on platforms like
276 cygwin with distinct // and with drive letters.
277 * NEWS: Document new behavior.
278 * src/basename.c (main): Don't strip suffix from file system
280 * src/cp.c (target_directory_operand): Use new last_component.
281 (ASSIGN_BASENAME_STRDUPA): Likewise. Reduce time spent
282 traversing the string.
283 * src/dircolors.c (guess_shell_syntax): Use new last_component.
284 * src/install.c (target_directory_operand, install_file_in_dir):
286 * src/ln.c (target_directory_operand, main): Likewise.
287 * src/ls.c (basename_is_dot_or_dotdot): Likewise.
288 * src/mv.c (target_directory_operand, movefile): Likewise.
289 * src/remove.c (rm_1): Likewise.
290 * src/shred.c (wipename): Likewise.
291 * src/split.c (next_file_name): Likewise.
292 * src/su.c (log_su, run_shell): Likewise.
294 2006-03-23 Paul Eggert <eggert@cs.ucla.edu>
296 * NEWS: nohup diagnostics are now more precise, and nohup now
297 redirects stderr to nohup.out if stdout is closed and stderr is a tty.
298 * src/nohup.c (main): Implement this.
299 * tests/misc/nohup: Test the new behavior.
301 2006-03-12 Jim Meyering <jim@meyering.net>
303 * src/copy.c (set_author): Rename function, from preserve_author.
305 * src/remove.c (AD_pop_and_chdir): Use new macro,
306 CYCLE_CHECK_REFLECT_CHDIR_UP, rather than open-coding it.
308 * src/system.h (SAME_INODE): Remove definition.
309 Include "same-inode.h", instead.
311 2006-03-11 Eric Blake <ebb9@byu.net>
313 * src/pwd.c (robust_getcwd): Prepend only one slash, not two.
315 2006-03-10 Jim Meyering <jim@meyering.net>
317 Fix a bug whereby a user with write access to a directory being removed
318 could cause the removal of that directory to fail with an erroneous
319 diagnostic about a directory cycle. Reported by Vineet Chadha.
321 * NEWS: Mention this.
322 * src/remove.c (AD_pop_and_chdir): If the directory we're about to
323 leave (and try to rmdir) is the one whose dev_ino is being used to
324 detect a cycle, reset cycle_check_state.dev_ino to that of the parent.
326 2006-03-08 Paul Eggert <eggert@cs.ucla.edu>
328 * NEWS: Document dd's new 'directory' and 'nolinks' flags.
329 * src/dd.c (set_fd_flags): Handle file-creation flags on file
330 descriptors, rather than ignoring them.
331 * tests/dd/misc: Add test cases for append, nofollow, directory,
332 and nolinks flags. Simplify redirection to /dev/null in some cases.
334 * tests/dd/misc: iflags->iflag. This fixes a typo that meant the
335 noatime test never tested anything.
337 2006-03-05 Paul Eggert <eggert@cs.ucla.edu>
339 * src/dd.c (flags, usage): New flags directory, nolinks.
340 * src/system.h (O_NOLINKS): Define to 0 if not already defined.
342 * src/ls.c (usage): Mention that -f disables --color.
343 Problem reported by Niels Möller.
345 2006-03-03 Justin Pryzby <pryzbyj@justinpryzby.com>
347 * man/*.x: Add references to syscalls from utilities of the same name.
349 2006-03-05 Jim Meyering <jim@meyering.net>
351 * tests/help-version: Set SHELL, if not already set, in order to
352 avoid failure when `make check' is run through debuild; dircolors
353 would fail due to lack of $SHELL. Reported by Sven Joachim.
355 Make `base64 --wrap=N' work for N=0, and for N larger than SIZE_MAX.
356 * src/base64.c (wrap_write, do_encode, main): Change type of
357 parameters and locals, wrap_column, form size_t to uintmax_t.
358 (main): Adjust to use xstrtoumax, accordingly.
360 2006-03-03 Jim Meyering <jim@meyering.net>
362 Don't fail when run from an environment with SHELL not a Bourne
363 shell, e.g. `env SHELL=/bin/csh make check' would fail this test.
364 * tests/dircolors/simple: Invoke each non-failing test with -b.
365 Reported by Michael Stone.
367 2006-02-27 Jim Meyering <jim@meyering.net>
369 * tests/misc/base64: Derive --decode-using tests from the
372 * tests/misc/base64: Factor out a long constant string.
373 Split lines to stay within 80 columns.
375 * tests/misc/Makefile.am (TESTS): Add base64.
376 * tests/misc/base64: Test base64. From Simon Josefsson.
378 * src/base64.c (do_decode): Use correct type for parameter,
379 ignore_garbage: s/size_t/bool/.
381 * src/base64.c: Don't include .h files already included by system.h:
382 <string.h>, <stdlib.h>, <stdbool.h>, <limits.h>, <errno.h>.
383 Include "system.h" before the other lib/*.h header files.
384 Include <sys/types.h> before "system.h".
385 (wrap_write): Remove declaration of unused local, initial_column.
386 (wrap_write): Correct declaration syntax: s/size_t * V/size_t *V/.
388 * README: Add base64 to the list.
390 2006-02-17 Simon Josefsson <jas@extundo.com>
393 * AUTHORS: Mention base64.
395 * man/Makefile.am: Build base64.1.
396 * man/base64.x: New file.
397 * src/Makefile.am (bin_PROGRAMS): Add base64.
398 * src/base64.c: New file.
400 2006-02-25 Eric Blake <ebb9@byu.net>
402 In ls, avoid calling stat for --inode (-i), when possible.
403 * src/pwd.c (NOT_AN_INODE_NUMBER, D_INO): Move to ...
404 * src/system.h: ... here, for use in ...
405 * src/ls.c (main): ... here. Prefer dirent.d_ino to stat when
407 (gobble_file): Add inode argument.
408 (print_dir): Pass inode if available.
409 (usage): Remove inaccuracy.
411 2006-02-23 Jim Meyering <jim@meyering.net>
413 * TODO: Update/correct some obsolete entries.
415 2006-02-20 Paul Eggert <eggert@cs.ucla.edu>
417 * doc/coreutils.texi (join invocation): Mention `sort -k 1b,1'.
418 * src/join.c (usage): Likewise.
419 Documentation problem reported by Philip Kensche.
421 2006-02-20 Eric Blake <ebb9@byu.net>
423 * man/rm.x: Update documentation to match previous patch.
425 2006-02-18 Eric Blake <ebb9@byu.net>
427 New option for rm: --interactive=once (-I).
428 * NEWS: Document it, along with change to rm --interactive.
429 * TODO: Remove entry for implementing rm -I
430 * src/rm.c (INTERACTIVE_OPTION): New enum value.
431 (interactive_type): New enum.
432 (long_opts): Let interactive take an optional argument.
433 (interactive_args, interactive_types): New option arguments.
434 (usage): Document -I, --interactive=WHEN. Use program_name
435 instead of a basename.
436 (main): New -I option, new behavior to --interactive.
437 * tests/rm/interactive-once: New tests.
438 * tests/rm/interactive-always: Ditto.
439 * tests/rm/Makefile.am (TESTS): Run them.
441 2006-02-18 Jim Meyering <jim@meyering.net>
443 * Makefile.maint (sc_two_space_separator_in_usage): Make the regular
444 expression match more of the target lines, e.g., those that start with
445 `-S,' (short option followed by a comma) or that include `=[...]'.
446 Patch by Nicolas François.
447 Fix the four offenders thus exposed:
448 * src/join.c (usage): Use two spaces (not one) to separate the
449 --first-only option string from its description, so help2man formats
450 the derived man page properly.
451 * src/pr.c (usage): Likewise.
452 * src/uniq.c (usage): Likewise.
453 * src/install.c (usage): Likewise.
455 2006-02-15 Jim Meyering <jim@meyering.net>
457 * Makefile.maint (alpha beta major): For `make major', ensure that the
458 version string is of the form N.N[.N]*, where N is one or more digits.
460 2006-02-14 Jim Meyering <jim@meyering.net>
462 * INSTALL: Update from gnulib.
464 2006-02-13 Jim Meyering <jim@meyering.net>
466 * GNUmakefile (all): Emit diagnostics to stderr, not stdout.
468 2006-02-12 Jim Meyering <jim@meyering.net>
470 * Makefile.maint (patch-check): New target.
471 (local-checks-available): Add to the list.
473 2006-02-11 Jim Meyering <jim@meyering.net>
475 * src/c99-to-c89.diff: New file.
476 * src/Makefile.am (EXTRA_DIST): Add c99-to-c89.diff.
478 * .x-po-check: New file, with exclusions so that `make distcheck'
480 * Makefile.am (EXTRA_DIST): Add .x-po-check.
482 rm -r must remove an empty directory, even if it is inaccessible.
483 * src/remove.c (close_preserve_errno): New function.
484 (fd_to_subdirp): Don't print a diagnostic in this function.
485 Do it from the callers instead, unless rmdir succeeds.
486 (remove_cwd_entries, remove_dir): Adjust callers.
487 * tests/rm/empty-inacc: New test for the above.
488 * tests/rm/Makefile.am (TESTS): Add empty-inacc.
489 * NEWS: Mention this bug fix.
490 * tests/rm/rm2: Adjust two expected diagnostics, now that they're
491 a tiny bit less precise: cannot remove `a/1': ... instead of
492 cannot open directory `a/1': ...
494 * Makefile.maint (syntax-check-rules): Automatically derive this
495 list of sc_-prefixed rule names.
497 2006-02-10 Paul Eggert <eggert@cs.ucla.edu>
499 * Makefile.maint (CVS_LIST): Don't assume cvsu is available.
500 (CVS_LIST_EXCEPT): New macro, to simplify exception-processing.
501 Most uses of CVS_LIST changed to use CVS_LIST_EXCEPT.
502 (syntax-check-rules): Bring back sc_changelong. (Hmm, why did it
503 go away? was that an accident?)
504 (sc_cast_of_argument_to_free, sc_cast_of_x_alloc_return_value):
505 (sc_cast_of_alloca_return_value, sc_space_tab, sc_prohibit_atoi_atof):
506 (sc_error_exit_success, sc_file_system, sc_no_if_have_config_h):
507 (sc_system_h_headers, sc_sun_os_names, sc_trailing_blank):
508 (sc_two_space_separator_in_usage, sc_unmarked_diagnostics):
509 (sc_obsolete_symbols, sc_changelog, sc_prohibit_jm_in_m4):
510 (sc_useless_cpp_parens, makefile-check, m4-check, po-check):
511 (author_mark_check, makefile_path_separator_check):
512 Output line numbers, to simplify navigation of Emacs *compilation*
514 (sc_prohibit_atoi_atof, sc_file_system):
515 Rework slightly so that Makefile.maint doesn't get reported as a
516 violation of its own syntax rules.
517 (sc_dd_max_sym_length): Use ifneq to do nothing, instead of doing
518 it at run-time (which didn't work with Bison). Fix a makefile typo,
519 caught by Makefile.maint itself: spaces where a tab should be.
520 (po-check): Check lib/*.[ch] even if not in CVS; used by Bison,
521 which copies from ../gnulib/lib/*.[ch] to lib/*.[ch].
522 Ignore djgpp and man subdirectories, to avoid false matches with
523 Bison and coreutils, respectively. Use sort -u to remove the
524 resulting duplicates.
525 * gnupload: Rework slightly to avoid bogus warning from
526 sc_two_space_separator_in_usage.
528 2006-02-10 Jim Meyering <jim@meyering.net>
530 Use gzip's --rsyncable option only if it's available.
531 * Makefile.maint (gzip_rsyncable): New variable.
534 2006-02-08 Jim Meyering <jim@meyering.net>
536 * Makefile.maint (local-checks-available): Define in terms of
537 the expansion, $(syntax-check-rules), rather than the single,
538 top-level target `syntax-check', so that it's easier to exclude
539 individual rules (via $(local-checks-to-skip)).
540 (tgz-md5, tgz-sha1, ...): Remove now-unused definitions.
542 2006-02-07 Jim Meyering <jim@meyering.net>
544 * src/system.h (!defined O_DIRECT): If O_DIRECTIO is defined (as it
545 is on Tru64), define O_DIRECT to that. Patch From James Lemley.
547 * tests/help-version (expected_failure_status_vdir):
548 Redirect an expected disk-full diagnostic to /dev/null.
550 2006-02-06 Jim Meyering <jim@meyering.net>
552 * src/unexpand.c (usage): Use two spaces (not one) to separate the
553 --first-only option string from its description, so help2man formats
554 the derived man page properly.
555 * src/rm.c (usage): Likewise for --no-preserve-root.
556 * src/chown.c (usage): Likewise.
557 * src/chgrp.c (usage): Likewise.
559 Add a rule to ensure that the above doesn't happen again.
560 * Makefile.maint (sc_two_space_separator_in_usage): New rule.
561 (syntax-check-rules): Add it.
562 * .x-sc_two_space_separator_in_usage: New empty file.
563 * Makefile.am (EXTRA_DIST): Add .x-sc_two_space_separator_in_usage.
565 2006-02-06 Jim Meyering <jim@meyering.net>
567 * src/cp.c (usage): Use two spaces (not one) to separate each
568 option string from its description, so help2man formats the
569 derived man page properly.
570 * src/mv.c (usage): Likewise.
571 Patch from Nicolas François in http://bugs.debian.org/351601.
573 2006-02-04 Jim Meyering <jim@meyering.net>
575 * src/copy.c (copy_internal): cp -RL would fail when encountering
576 the same directory more than once in the hierarchy beneath a single
577 command-line argument. That is legitimate, e.g. when there are
578 two or more symbolic links, each pointing to some directory that
579 would not otherwise be copied. Reported by Christophe LYON.
580 * tests/cp/cp-deref: New file. Test for today's fix.
581 * tests/cp/Makefile.am (TESTS): Add cp-deref.
582 * NEWS: Document this.
584 2006-02-03 Jim Meyering <jim@meyering.net>
586 * configure.ac: Require automake-1.9.6, not 1.8.3.
588 2006-02-01 Paul Eggert <eggert@cs.ucla.edu>
590 * src/od.c (usage): Mention that -t a ignores high order bit.
591 Documentation problem reported by Ed Avis.
593 2006-02-01 Jim Meyering <jim@meyering.net>
595 * src/pwd.c (find_dir_entry): Remove unused local, `ent_sb_valid'.
597 2006-01-30 Paul Eggert <eggert@cs.ucla.edu>
599 * src/head.c (main): Use a better diagnostic when someone uses a
600 trailing numeric option in an invalid way. Problem reported by
602 * src/tail.c (parse_options): Likewise.
604 2006-01-30 Jim Meyering <jim@meyering.net>
606 * man/wc.x: Include `count' keyword in man page synopsis,
607 per suggestion from http://bugs.debian.org/181585.
609 2006-01-24 Paul Eggert <eggert@cs.ucla.edu>
611 * src/df.c (show_dev): If the file system claims to have
612 more available than total blocks, report the number of used
613 blocks as being total - available (a negative number) rather
614 than as garbage. Problem reported by Toralf Foerster.
616 2006-01-24 Jim Meyering <jim@meyering.net>
618 * src/tail.c (tail_forever): Don't exit-nonzero when an attempt
619 to put a regular file in O_NONBLOCK mode fails with EPERM.
620 That happens on Linux (up to 2.6.15) when using tail -f on a file with
621 the append-only attribute. Reported by Dean Gaudet. For details,
622 see http://savannah.gnu.org/bugs/?func=detailitem&item_id=15473.
623 * NEWS: Mention this fix.
624 * tests/tail-2/append-only: New file. Test for the above.
625 * tests/tail-2/Makefile.am (TESTS): Add append-only.
626 * tests/Makefile.am (check-root): Add tail-2/append-only
628 2006-01-21 Jim Meyering <jim@meyering.net>
630 * NEWS: Mention fts-related improvements and bug fixes.
632 2006-01-19 Jim Meyering <jim@meyering.net>
634 * tests/fmt/basic (pfx-1, pfx-2): New tests, to demonstrate the bug
635 reported as http://bugs.debian.org/147577. Forwarded by Thomas Hood.
637 2006-01-18 Jim Meyering <jim@meyering.net>
639 * tests/du/Makefile.am (TESTS): Add long-from-unreadable.
641 2006-01-17 Jim Meyering <jim@meyering.net>
643 Now that fts no longer changes the current working directory, adjust
644 its clients accordingly -- note that du.c uses fts but doesn't need
645 any adjustment, since it doesn't operate on the actual files,
646 but rather just uses the stat buffers provided by fts.
648 * src/chown-core.c: Include "openat.h".
649 Don't include "lchown.h".
650 (restricted_chown): Accept a new parameter, CWD_FD, and use it in
651 calling openat, lchownat, chownat, rather than open, lchown, chown.
653 * src/chmod.c: Include "openat.h".
654 (process_file): Use chmodat (fts->fts_cwd_fd,... in place of chmod (...
656 * tests/du/long-from-unreadable: New test, to exercise one small
659 2006-01-13 Jim Meyering <jim@meyering.net>
661 * tests/Makefile.am (SUBDIRS): Add comments discouraging the
662 addition of new directories under tests/.
664 * tests/acl: Redirect stdin to /dev/null. Otherwise, FreeBSD 5.0's
667 2006-01-12 Jim Meyering <jim@meyering.net>
669 * tests/du/long-sloop: Adjust not to hard-code the expected
670 diagnostic corresponding to ELOOP. Solaris' diagnostic differs
671 from that of GNU libc. Reported by Paul Eggert.
673 * tests/du/long-sloop: Create file at end of symlink chain.
675 * tests/misc/test: New file, with a test for one of the
676 bugs fixed by yesterday's test.c changes.
677 * tests/misc/Makefile.am (TESTS): Add test.
679 2006-01-11 Jim Meyering <jim@meyering.net>
681 * tests/du/long-sloop: New file. Test for today's fts.c bug fix.
682 That bug could make du -L, chgrp -L, or chown -L fail to diagnose
683 a very long sequence of symbolic links (not necessarily a loop).
684 * tests/du/Makefile.am (TESTS): Add long-sloop.
686 2006-01-11 Paul Eggert <eggert@cs.ucla.edu>
688 * src/test.c (test_syntax_error): Append a newline. All callers
689 changed, except for the ones that didn't already append a newline.
690 Bug reported by Eric Blake.
692 2006-01-11 Jim Meyering <jim@meyering.net>
694 * src/system.h (X2NREALLOC): Now that verify_true is no longer
695 void, cast its result to void, to avoid gcc's warning that
696 ``left-hand operand of comma expression has no effect''.
697 (DECIMAL_DIGIT_ACCUMULATE, X2REALLOC): Likewise.
699 2006-01-10 Jim Meyering <jim@meyering.net>
701 * tests/chmod/no-x: Add a test for today's fts.c fix.
703 2006-01-10 Jim Meyering <jim@meyering.net> (tiny change)
705 * src/ls.c (gobble_file): Use DTTOIF only if it's defined.
706 This is necessary for Dragonfly. Patch by Joerg Sonnenberger.
708 2006-01-10 Paul Eggert <eggert@cs.ucla.edu>
710 * src/system.h (X2NREALLOC, X2REALLOC, DECIMAL_DIGIT_ACCUMULATE):
711 Use verify_true instead of verify_expr, to sync with gnulib.
713 2006-01-08 Jim Meyering <jim@meyering.net>
715 * src/date.c (usage): Adjust the formatting of the entries for
716 %::z and %:::z (separate with two spaces, not one) so that help2man
717 formats them properly. Reported by Philip Rowlands.
719 2006-01-06 Paul Eggert <eggert@cs.ucla.edu>
721 * configure.ac (gl_IGNORE_UNUSED_LIBRARIES): Add.
723 2006-01-06 Jim Meyering <jim@meyering.net>
725 * Makefile.maint (copyright-check): Use date +%Y in place of
728 * src/remove.c (rm_1): Remove `static' attribute on local `status'.
729 First off, the attribute should have been `volatile' (not static)
730 to avoid longjmp-related risk of clobber. Secondly, now there is
731 no longer any risk of a local variable being clobbered, so there's
732 no need for any attribute at all.
734 2006-01-05 Jim Meyering <jim@meyering.net>
736 * src/remove.c: Give a few functions the inline attribute.
737 (AD_pop_and_chdir): Use gotos to avoid some duplication.
738 (AD_push): Rewrite an assertion so that the entire computation
739 goes away when assertions are turned off.
741 * src/tail.c (ENOSYS) [!defined ENOSYS]: Don't define here.
742 It's already defined in "system.h".
743 * Makefile.maint: Add a FIXME comment.
745 2006-01-04 Jim Meyering <jim@meyering.net>
747 * ChangeLog: Remove entries from 2005-10-22 and earlier.
748 * ChangeLog-2005: New file, for entries up to version 5.92.
750 2006-01-03 Jim Meyering <jim@meyering.net>
752 * tests/du/no-x: Also allow a slightly different diagnostic -- the
753 one you get when using openat-enabled fts.c and du (coming soon).
754 * tests/chmod/no-x: Likewise.
755 * tests/chgrp/no-x: Likewise.
757 * src/system.h (O_DIRECTORY) [!defined O_DIRECTORY]: Define.
759 2006-01-02 Paul Eggert <eggert@cs.ucla.edu>
761 * src/chown-core.c (RC_do_ordinary_chown): New enum value.
762 (restricted_chown): Return it, if the file cannot be accessed due
763 to EPERM, or if no uid or gid are required, or if the file is
764 neither a directory nor a regular file. Rewrite to avoid gotos.
765 (change_file_owner): Handle RC_do_ordinary_chown case.
766 Rewrite to avoid gotos.
767 * tests/chgrp/basic: Make sure we can change the group of
770 * src/date.c (usage): Explain %g, %G, and %V a bit better.
772 2006-01-02 Jim Meyering <jim@meyering.net>
774 * src/copy.c (set_owner): Correct a comment.
776 * src/tail.c (parse_options): Change warning to say that --retry
777 is useful `mainly' (not `only') when following by name.
778 Reported here: http://bugs.debian.org/273781
780 2006-01-01 Paul Eggert <eggert@cs.ucla.edu>
782 * NEWS: Document that mkfifo and mknod -m no longer set special bits.
783 * src/copy.c: Include lchmod.h.
784 (copy_internal): Use lchmod rather than chmod.
785 * src/cp.c: Include lchmod.h.
786 (re_protect, make_dir_parents_private): Use lchmod rather than chmod.
787 * src/mkdir.c: Include lchmod.h.
788 (usage): Clarify -m's operation.
789 (main): Use lchmod rather than chmod. Don't use lchmod unless the
790 new mode contains bits outside the 777 range.
791 * src/mkfifo.c (usage): Clarify -m's operation.
792 (main): If -m is given, don't invoke chmod; use umask 0 instead.
793 Report an error if -m asks for bits outside the 777 range.
794 * src/mknod.c (usage, main): Likewise.
796 * src/mkdir.c, src/mkfifo.c, src/mknod.c: Undo 2005-12-19 changes.
798 2005-12-27 Jim Meyering <jim@meyering.net>
800 * Makefile.maint (sc_obsolete_symbols): Prohibit use of O_NDELAY.
801 (sc_prohibit_assert_without_use): New rule.
802 (syntax-check-rules): Add it to the list.
803 * .x-sc_prohibit_assert_without_use: New empty file.
804 * Makefile.am (EXTRA_DIST): Add it.
806 * Makefile.maint (CVS_LIST): Define in terms of $(srcdir).
808 * cp.c, df.c, link.c, mknod.c, nice.c, sleep.c, unlink.c:
809 Don't include <assert.h>; it wasn't used.
811 2005-12-26 Paul Eggert <eggert@cs.ucla.edu>
813 * src/chown-core.c (restricted_chown):
814 Don't try O_WRONLY unless O_RDONLY failed wth EACCES.
815 * src/remove.c (fd_to_subdirp): Open with O_DIRECTORY | O_NOCTTY
816 | O_NOFOLLOW too, for consistency with other dir-openers.
817 Use POSIX-preferred O_NONBLOCK rather than O_NDELAY.
818 (is_empty_dir): Likewise.
819 * src/shred.c (wipename): Likewise. Don't bother trying to open
820 dir for writing, since POSIX prohibits it.
822 2005-12-22 Jim Meyering <jim@meyering.net>
824 * tests/help-version: Redirect stderr to /dev/full, to suppress
825 write error diagnostic.
827 2005-12-19 Jim Meyering <jim@meyering.net>
829 * src/mkdir.c, src/mknod.c, src/mkfifo.c (main)
830 Avoid a minor race condition when `-m MODE' is specified, by using
831 open, fchown, and close rather than just chown. To do that reliably --
832 even with an overly restrictive umask -- ensure that each mkdir,
833 mknod and mkfifo call uses a mode including at least owner-read access.
834 * src/mknod.c (main): When `-m MODE' is specified, exit nonzero if
835 the subsequent chown (or equivalent open,fchown,close) fails.
836 * tests/misc/mknod: New tests.
837 * tests/misc/Makefile.am (TESTS): Add mknod.
839 2005-12-17 Jim Meyering <jim@meyering.net>
841 * src/remove.c (is_empty_dir): Open with O_NDELAY, so we don't hang,
842 e.g., on a named pipe.
843 (OPEN_NO_FOLLOW_SYMLINK): Remove definition. Use O_NOFOLLOW in
844 place of all uses, since it is guaranteed (system.h) to be defined.
846 2005-12-05 Andreas Gruenbacher <agruen@suse.de>
848 Add POSIX ACL support
849 * src/ls.c: Switch back from HAVE_ACL to USE_ACL: The acl() syscall
850 is no requirement for ACL support; particularly, it does not exist
851 on systems that have POSIX ACLs.
852 * src/copy.h (cp_option_init) [umask_kill]: Remove member.
853 * src/cp.c (umask_kill): With default acls, the umask is not to be
854 applied. Remove umask_kill, don't change the process umask, and let
855 the kernel apply the umask where appropriate.
856 * src/cp.c (make_dir_parents_private): Fix logic for POSIX ACLs.
857 * src/copy.c (get_dest_mode): Remove; it is obsolete after removing
859 (copy_reg, copy_internal): Use copy_acl and set_acl
860 instead of fchown/chown. Fix the logic for POSIX ACLs.
861 (chown_succeded): Remove; we now always copy acls and
862 preserve S_ISUID, S_ISGID, and S_ISVTX when needed, no matter if we
863 did a chown before or not.
864 * src/mv.c, src/install.c (cp_option_init): Don't set umask_kill member.
865 * src/Makefile.am (dir_LDADD, ls_LDADD, vdir_LDADD, cp_LDADD,
866 mv_LDADD, ginstall_LDADD): On systems with an ACL library, arrange
867 to link with it via $(LIB_ACL), for the utilities that need it.
869 2005-12-16 Paul Eggert <eggert@cs.ucla.edu>
871 * src/remove.c (OPENAT_CWD_RESTORE__REQUIRE): Remove.
872 (OPENAT_CWD_RESTORE__ALLOW_FAILURE): Likewise.
873 (fd_to_subdirp): Remove openat_cwd_restore_allow_failure arg; its
874 value is now signified by whether cwd_errno is null.
875 (fd_to_subdirp, remove_dir, rm_1); Change cwd failure indicator from
876 pointer-to-bool to pointer-to-errno-value. All callers changed.
877 (rm_1): Don't bother setting a local cwd failure flag and then
878 ORing it into the caller's. Just set the caller's.
879 (rm): Use cwd failure errno value to print a slightly-better
882 2005-12-15 Jim Meyering <jim@meyering.net>
884 * src/stat.c (print_it): Properly handle a backslash at the
885 end of a --printf format string. Reported by Paul Eggert.
886 * tests/misc/stat-printf (end-bs): Add a test for the above.
888 2005-12-15 Paul Eggert <eggert@cs.ucla.edu>
890 * tests/acl: Port to pre-POSIX shells like Solaris 8 /bin/sh.
891 Don't assume /etc/passwd contains user names; use 'id' instead.
893 2005-12-15 Jim Meyering <jim@meyering.net>
895 stat: revert behavior of --format=FMT (-c)
896 stat: add new option: --printf=FMT
897 * NEWS: Mention this.
898 * src/stat.c (isodigit, octtobin, hextobin): Define.
899 (PRINTF_OPTION): Define.
900 (interpret_backslash_escapes, trailing_delim): New globals.
901 (usage): Document them. Alphabetize on long option names.
902 (print_esc_char): New function.
903 (print_it): Rewrite, in order to handle backslash escapes.
904 (main): Handle new option. Set globals for --format, too.
906 * tests/misc/stat-printf: Test --printf and --format.
907 * tests/misc/Makefile.am (TESTS): Add stat-printf.
909 2005-12-14 Paul Eggert <eggert@cs.ucla.edu>
911 * NEWS: sort now reports incompatible options.
912 * src/sort.c (incompatible_options, check_ordering_compatibility):
914 (main): Use them. Don't bother with a usage message for
915 "sort -c a b", for consistency with other error diagnostics.
916 * tests/sort/Test.pm (incompat1, incompat2, incompat3, incompat4):
919 * src/cat.c (main): Undo previous change. close_stdout already
920 does the check, so the previous change wasn't necessary.
922 2005-12-13 Paul Eggert <eggert@cs.ucla.edu>
924 * src/cat.c (main): Check for close (STDOUT_FILENO) failure.
926 2005-12-12 Paul Eggert <eggert@cs.ucla.edu>
928 Install a more-conservative approach for sort -R. It's the
929 same basic idea as the existing code, except it uses the full ISAAC
930 approach (called the "more kosher" approach in the existing comments).
931 This makes "sort -R" quite a bit slower (about a factor of 2 on my
932 little tests involving 10000 lines on a 2.4 GHz P4), but I think it's
933 better to be conservative here at first, and review any performance
934 improvements carefully.
935 * .x-sc_require_config_h: Add src/rand-isaac.c.
936 * src/rand-isaac.h: Remove. All uses now simply include rand-isaac.c.
937 * src/Makefile.am (noinst_HEADERS): Remove rand-isaac.h.
938 (shred_SOURCES, sort_SOURCES): Remove.
939 (EXTRA_DIST): Add rand-isaac.c.
940 * src/rand-isaac.c: Revert to what used to be in shred.c, without
941 changing it to allow for varying numbers of words in the state.
942 Alter so that we include rand-isaac.c directly rather than
943 compiling it and linking to it. Don't include config.h or
944 system.h; that's the includer's responsibility.
945 Omit functions that are specific to shred.
946 (ISAAC_LOG, ISAAC_WORDS, ISAAC_BYTES, struct isaac_state, ind):
947 (isaac_step, struct irand_state):
948 Resurrect these, with the same defns that used to be in shred.c.
949 (ISAAC_SIZE, isaac_new, isaac_copy): Remove.
950 (isaac_refill, isaac_seed_start, isaac_seed_data, irand_init, irand32):
952 (struct isaac_state, isaac_refill, isaac_mix, isaac_init):
953 (isaac_seed_start, isaac_seed_data, isaac_seed_finish, isaac_seed):
954 (irand_init, irand32, irand_mod):
955 Number of words is constant again.
956 (struct irand_state, irand_init, irand32, irand_mod): Move to shred.c.
957 * src/shred.c: Include rand-isaac.c rather than rand-isaac.h.
958 * src/sort.c: Likewise.
959 * src/shred.c (fillrand, dopass, main): Undo previous change.
960 (struct irand_state, irand_init, irand32, irand_mod): Moved back here,
962 * src/sort.c: Don't include md5.h; it wasn't needed.
963 (struct keyfield): Rename random_hash to random, for consistency
964 with the other member names. All uses changed.
965 (usage): Tweak wording to mention STRING for --seed option.
966 (short_options): Rorder for consistency with other programs.
967 (rand_state): Now a struct, not a pointer to one. All uses changed.
968 (HASH_WORDS, HASH_SIZE): Remove.
969 (get_hash): Remove comments around resbuf size, since we can assume C89.
970 Use a "more-kosher" (but slower) approach of invoking isaac_refill.
971 (keycompare): Adjust to the new get_hash.
973 (badfieldspec): Omit recently-introduced comment; it isn't needed.
974 (main): Don't set need_random simply because gkey has it set; that
975 doesn't necessarily mean we'll need random numbers.
976 Redo seeding to match new get_hash approach.
978 2005-12-10 Jim Meyering <jim@meyering.net>
980 * src/Makefile.am (noinst_HEADERS): Add rand-isaac.h.
982 Avoid shred segfault on 64-bit systems.
983 * src/rand-isaac.c (isaac_refill): Don't try to negate a
984 local of type uint32_t. Make the local an `int' instead.
986 * NEWS: Mention sort's new options.
988 * src/rand-isaac.c (isaac_mix): Declare to be static.
989 Mark all other functions as `extern' so the tight-scope
990 part of `make distcheck' passes once again.
991 * src/rand-isaac.h (isaac_mix): Remove declaration.
993 * src/sort.c (get_hash): Change position of `*' in parameter
994 type to conform with convention.
995 (main): Split a long line so it fits in 80 columns.
996 (keycompare): Remove stray SPACE before TAB that was
997 causing `make distcheck' to fail.
999 * src/shred.c: Don't include gethrxtime.h. No longer needed.
1001 * tests/misc/sort-rand: New file: basic tests for the new options.
1002 * tests/misc/Makefile.am (TESTS): Add sort-rand.
1004 2005-12-10 Frederik Eaton <frederik@ofb.net>
1006 * src/Makefile.am (sort_LDADD): Add $(LIB_GETHRXTIME).
1007 (shred_SOURCES, sort_SOURCES): New macros, so we compile rand-isaac.c.
1008 * src/rand-isaac.c: New file, containing ISAAC code that was in shred.c.
1009 Make state size runtime-configurable.
1010 (isaac_new, isaac_copy): New functions.
1011 * src/rand-isaac.h: New file.
1012 * src/shred.c: Include rand-isaac.h. Move ISAAC code to rand-isaac.c.
1013 (fillrand, main): Adjust to the fact that the state size is now
1014 runtime-configurable.
1015 * src/sort.c (short_options, long_options, WORDS, keycompare, main):
1016 (usage): Add options --random-sort and --seed to implement a random
1018 Include md5.h and rand-isaac.h.
1019 (get_hash): New function.
1020 (rand_state): New var.
1021 (HASH_WORDS, HASH_SIZE): New macros.
1023 2005-12-09 Paul Eggert <eggert@cs.ucla.edu>
1025 * tests/dd/misc: Add test for dd iflags=noatime.
1027 2005-12-09 Jim Meyering <jim@meyering.net>
1029 * src/sort.c (usage): Mention white space vs -b and -t options.
1032 2005-12-09 Eric Blake <ebb9@byu.net>
1034 * src/test.c (main): Fix misleading comment.
1036 2005-12-07 Paul Eggert <eggert@cs.ucla.edu>
1038 * NEWS: Mention dd's new noatime flag.
1039 * src/system.h (O_NOATIME): Define to 0 if not already defined.
1040 * src/dd.c (flags, usage): Add support for noatime flag.
1042 2005-12-07 Jim Meyering <jim@meyering.net>
1044 Distribute the cvsu script, used only by `make syntax-check'.
1045 * Makefile.am (EXTRA_DIST): Add build-aux/cvsu.
1046 * Makefile.maint (CVS_LIST): Use build-aux/cvsu, now that we
1047 distribute a copy of this script.
1048 * .x-sc_unmarked_diagnostics: Add build-aux/cvsu.
1050 * tests/mv/acl: exit-77 before the trap, not after, if we fail
1051 to create a temporary directory on another partition.
1052 From Andreas Gruenbacher.
1054 2005-12-06 Tomas Pospisek <tpo@sourcepole.ch> (tiny change)
1056 * man/basename.x: Cross-reference to dirname and readlink.
1057 * man/dirname.x: Cross-reference to basename and readlink.
1059 2005-12-05 Andreas Gruenbacher
1061 * src/copy.c [!HAVE_FCHOWN]: Define fchown(...) to -1.
1062 (set_owner, preserve_author): New functions, factored out of copy_reg.
1063 (copy_reg): Use them.
1064 (copy_internal): Use them here, too.
1066 2005-12-04 Jim Meyering <jim@meyering.net>
1068 * src/sleep.c (usage): Say what happens with two or more arguments.
1069 Suggested by Justin Pryzby.
1071 * src/uptime.c (print_uptime): Move decl of `upsecs' into scope
1074 2005-12-03 Jim Meyering <jim@meyering.net>
1076 * src/rm.c (long_opts): Change the name of each undocumented, for-
1077 testing-only option to start with `-', so that it cannot render
1078 ambiguous any prefix it happens to share with some other option name.
1079 Problem reported by Eric Blake.
1080 * src/head.c (long_options): Likewise.
1081 * src/tail.c (long_options): Likewise.
1083 * tests/misc/head-elide-tail: Update uses of undocumented, for-
1084 testing-only --presume* options to start with `---'.
1085 * tests/rm/dangling-symlink: Likewise.
1086 * tests/rm/dir-no-w: Likewise.
1087 * tests/rm/isatty: Likewise.
1089 2005-11-30 Jim Meyering <jim@meyering.net>
1091 * Makefile.maint: Add a comment about cvsu.
1093 2005-11-25 Paul Eggert <eggert@cs.ucla.edu>
1095 * NEWS: df updates for "none", "proc", inaccessible file systems.
1096 * src/df.c (show_point): Ignore inaccessible file systems.
1097 (usage): -a includes dummy file systems, not size-0 file systems.
1099 * src/od.c (unsigned_long_long_int): Renamed from ulonglong_t,
1100 to avoid collision with POSIX name space. All uses changed.
1102 2005-11-24 Jim Meyering <jim@meyering.net>
1104 * tests/Makefile.am (EXTRA_DIST): Add acl to the list.
1105 * tests/acl: Add `$0: ' prefix to diagnostics.
1107 * .x-sc_require_config_h: Add lib/buffer-lcm.c to the list.
1109 2005-11-23 Paul Eggert <eggert@cs.ucla.edu>
1111 * src/copy.c: Improve performance a bit by optimizing away
1112 unnecessary system calls and going to a block size of at least
1113 8192 (on normal hosts, anyway). This improved performance 5% on my
1114 Debian stable host (2.4.27 kernel, x86, copying from root
1115 ext3 file system to itself).
1116 Include "buffer-lcm.h".
1117 (copy_reg): Omit last argument. All callers changed.
1118 Use xmalloc to allocate rather than trusting alloca
1119 (which is unwise with large block sizes).
1120 Declare locals more locally, if possible.
1121 Use uintptr_t words instead of int words, for a bit more speed
1122 when looking for null blocks on 64-bit hosts.
1123 Optimize away reads of zero bytes on regular files.
1124 In the typical case, insist on 8 KiB buffers, at least.
1125 Avoid unnecessary extra call to fstat when checking for sparse files.
1126 Avoid now-unnecessary cast to off_t, and "0L".
1127 Avoid unnecessary test of *new_dst when checking for same owner
1130 2005-11-22 Paul Eggert <eggert@cs.ucla.edu>
1132 * src/remove.c (rm): Don't assume C99 for-loop syntax.
1134 2005-11-22 Jim Meyering <jim@meyering.net>
1136 * src/remove.c (AD_push): Remove debugging cruft.
1138 * tests/rm/unread2 (rm): Change expected diagnostic,
1139 `cannot open directory' to `cannot remove', to align with
1141 * tests/rm/rm2: Ensure that rm now continues removing entries
1142 even after certain types of failure.
1144 * src/remove.c: Rewrite. Now, this module is reentrant on systems
1145 that provide openat (Solaris), and on systems like Linux+procfs
1146 where our openat emulation code is reentrant. This also fixes a
1147 few low-probability leaks and eliminates some code that could,
1148 in very unusual circumstances, cause rm() (via a callee) to exit.
1149 * NEWS: Mention this.
1151 * configure.ac: Put copyright dates all on one line so the
1152 emacs function that updates them works properly.
1154 2005-11-18 Paul Eggert <eggert@cs.ucla.edu>
1156 * configure.ac (AM_PROG_CC_C_O): Add. Needed for CVS Automake.
1157 Problem reported by Eric Blake.
1158 (AC_PROG_CC_STDC): Use this instead of AC_PROG_CC, so that
1159 we get a standard-conforming compiler. This relies on the new
1160 m4/c.m4 file. Note that it's a bit tricky, since c.m4 doesn't
1161 define AC_PROG_CC_STDC; we are relying on Autoconf 2.59 internals.
1162 m4/c.m4 can go away with Autoconf 2.60 comes out.
1164 2005-11-17 Jim Meyering <jim@meyering.net>
1166 * src/remove.c (AD_mark_helper): Make a `char *' parameter `const'.
1167 (AD_mark_current_as_unremovable): Likewise, but for a local.
1170 * tests/mv/acl: Let traps handle removing temporary directories.
1172 Expect acl-related tests to fail, until the corresponding
1173 patches are committed.
1174 * tests/mv/Makefile.am (XFAIL_TESTS): Add acl.
1175 * tests/cp/Makefile.am (XFAIL_TESTS): Likewise.
1177 ACL tests, from Andreas Gruenbacher.
1178 * tests/acl, tests/mv/acl, tests/cp/acl: New files.
1179 * tests/mv/Makefile.am (TESTS): Add acl.
1180 * tests/cp/Makefile.am (TESTS): Add acl.
1182 * src/ls.c (basename_is_dot_or_dotdot): Correct wording in comment.
1184 2005-11-16 Paul Eggert <eggert@cs.ucla.edu>
1186 * NEWS: Improve quality of ln's diagnostics.
1187 * src/ln.c (do_link, usage): Likewise.
1188 (do_link): Don't use alloca on a buffer of unbounded size.
1190 2005-11-16 Jim Meyering <jim@meyering.net>
1192 * tests/cp/fail-perm: Accommodate HPUX. It appears to fail
1193 with EACCES rather than EPERM. Reported by Peter O'Gorman here:
1194 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/5766
1196 2005-11-14 Jim Meyering <jim@meyering.net>
1198 * NEWS (sort): Mention consequences of today's mkstemp-safer.c fix.
1200 2005-11-13 Jim Meyering <jim@meyering.net>
1202 * announce-gen: Accept new option, --gpg-key-id=ID and
1203 emit a blurb telling how to use the .sig files.
1204 * Makefile.cfg (gpg_key_ID): Define.
1205 * Makefile.maint (announcement): Use new option and key.
1207 Require that most .c files include <config.h>.
1208 * Makefile.maint (sc_require_config_h): New rule.
1209 (syntax-check-rules): Add it.
1210 * .x-sc_require_config_h: New file listing exceptions to the
1211 above rule. Some are legit, others are simply grandfathered in.
1212 * Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h here, too.
1214 2005-11-12 Jim Meyering <jim@meyering.net>
1216 * src/checksum.h, src/md5.c, src/sha1sum.c: Remove now-unused files.
1218 2005-11-11 Jim Meyering <jim@meyering.net>
1220 * NEWS: Mention `readlink -f' bug fix in 5.3.0 news.
1221 Mention new readlink options in 5.3.0's `New features' section.
1222 Spotted by Thomas Hood.
1224 2005-11-08 Jim Meyering <jim@meyering.net>
1226 * NEWS: Merge in changes from b5_9x branch.
1228 2005-11-08 Paul Eggert <eggert@cs.ucla.edu>
1230 * NEWS: ls now defaults to --time-style='locale', which in turn acts
1231 like --time-style='posix-long-iso' if the locale settings are messed up.
1232 * src/ls.c (decode_switches): Implement this.
1234 2005-11-08 Jim Meyering <jim@meyering.net>
1236 * tests/du/2g: s/expensive/very expensive/ in a comment.
1239 2005-10-17 Eric Blake <ebb9@byu.net>
1241 * src/ls.c (usage): Fix descriptions of --sort, --time.
1242 Reported by Vitaly A. Ostanin.
1244 2005-11-04 Paul Eggert <eggert@cs.ucla.edu>
1246 * src/ln.c: Include filenamecat.c.
1247 (FILE_BASENAME_CONCAT): Remove.
1248 (do_link): Remove last arg DEST_IS_DIR. All callers changed.
1249 (main): Use file_name_concat, base_name, and strip_trailing_slashes
1250 instead of FILE_BASENAME_CONCAT. This simplifies the code, and avoids
1253 2005-11-04 Jim Meyering <jim@meyering.net>
1255 * src/du.c (process_file): Don't overflow for files of size >= 2^31
1256 on systems with stat.st_blocks of a signed 32-bit type.
1257 This bug causes trouble on some AIX 5.1 systems.
1258 Report and trivial patch from Paul Townsend:
1259 <http://lists.gnu.org/archive/html/bug-coreutils/2005-11/msg00033.html>
1260 * NEWS: Mention this.
1262 * tests/du/2g: New (very-expensive) test for the above-fixed bug.
1263 * tests/du/Makefile.am (TESTS): Add it here.
1264 * tests/very-expensive: New file.
1265 * tests/Makefile.am (EXTRA_DIST): Add it here.
1266 * tests/cp/perm: Mark this test as `very-expensive', too.
1268 2005-11-02 Paul Eggert <eggert@cs.ucla.edu>
1270 * NEWS: Mention that rm -d and maybe ln -d are scheduled for
1272 * src/remove.h (struct rm_options): Remove unlink_dirs. All uses
1274 * src/rm.c (usage): Don't mention rm -d.
1276 2005-11-02 Jim Meyering <jim@meyering.net>
1278 * tests/dd/skip-seek: Fix typo in comment: s/fileutils/coreutils.
1279 From Andreas Schwab.
1281 * tests/dd/unblock-sync: Redirect stderr to /dev/null so the
1282 `M+N records in/out' lines don't pollute `make check' output.
1284 * tests/dd/skip-seek (sk-seek4): New test, to exercise the bug
1285 fixed on 2005-10-31. This test uses the new, IN_PIPE specifier.
1286 * tests/Coreutils.pm: Accept a new type of input specifier: IN_PIPE,
1287 to indicate that the input file should be piped into the command
1288 under test (via `cat FILE | $prog ...').
1290 * src/remove.c (remove_entry): Emit a better diagnostic when rm
1291 (without -r) fails to remove a directory on a non-Linux system.
1292 This change affects only newer Solaris systems (with priv_*
1293 functions like priv_allocset). Reported by Keith Thompson.
1295 * tests/rm/dir-nonrecur: New file/test for the above fix.
1296 * tests/rm/Makefile.am (TESTS): Add dir-nonrecur.
1298 2005-11-01 Paul Eggert <eggert@cs.ucla.edu>
1300 * NEWS: "tail -c 2 FILE" and "touch 0101000000" now operate as
1301 POSIX 1002.1-2001 requires.
1302 * src/tail.c (parse_obsolete_option): Implement this.
1303 Problem reported by Vincent Lefevre.
1304 * src/touch.c (main): Pass PDS_PRE_2000 to posixtime.
1305 * tests/tail/Test.pm (c-2, c-2-minus, c2, c2-minus): New tests.
1306 (test_vector): Add special cases for _POSIX2_VERSION, and
1307 regularize the old ones a bit.
1308 * tests/touch/obsolescent: Add y2000 test.
1310 2005-10-31 Paul Eggert <eggert@cs.ucla.edu>
1312 * src/dd.c (skip): Fix off-by-one error reported by
1313 Theodoros V. Kalamatianos.
1315 2005-10-30 Paul Eggert <eggert@cs.ucla.edu>
1317 * tests/mkdir/p-3: Require that the test be run as non-root.
1318 Problem and trivial fix reported by Theodoros V. Kalamatianos.
1320 2005-10-28 Paul Eggert <eggert@cs.ucla.edu>
1322 * src/ln.c (FILE_BASENAME_CONCAT): Omit unnecessary slashes in the
1323 boundary between DEST and SOURCE in the result.
1325 2005-10-26 Dmitry V. Levin <ldv@altlinux.org>
1327 * src/md5sum.c (main) [!O_BINARY]: Changed default read mode
1328 back to text, to sync with documentation and for backwards
1331 2005-10-25 Jim Meyering <jim@meyering.net>
1333 * tests/dircolors/simple (other-wr): Add an explicit test for
1334 the dircolors bug (NULL-dereference) fixed yesterday.
1336 2005-10-24 Jim Meyering <jim@meyering.net>
1338 * src/tac.c (tac_file): When determining whether a file is seekable,
1339 also test whether it is a tty. Using only the lseek-based test would
1340 give a false positive on Solaris. Reported by Peter Fales.
1342 2005-10-24 Dmitry V. Levin <ldv@altlinux.org>
1344 * tests/install/d-slashdot: New test, for "install -d" failure.
1345 * tests/install/Makefile.am (TESTS): Add d-slashdot.
1346 * tests/mkdir/p-slashdot: New test, for "mkdir -p" failure.
1347 * tests/mkdir/Makefile.am (TESTS): Add p-slashdot.
1349 2005-10-24 Jim Meyering <jim@meyering.net>
1351 * src/dircolors.c (ls_codes): Add missing comma.
1352 Anonymous report and patch from
1353 http://savannah.gnu.org/bugs/?func=detailitem&item_id=14849
1355 * src/dircolors.c: Add compile-time assertion that the slack_codes
1356 and ls_codes arrays have the same number of elements. This would
1357 have prevented the above-fixed bug.
1359 * src/expand.c (parse_tab_stops): Add a comment to make this function
1360 identical to the one in unexpand.c.
1361 * src/unexpand.c (parse_tab_stops): Adjust syntax to make this function
1362 identical to the one in expand.c.
1364 * src/expand.c (next_file): Don't assume fopen cannot return stdin.
1366 2005-10-23 Jim Meyering <jim@meyering.net>
1368 * src/md5sum.c (digest_check, main): Use ptr_align rather than
1369 a dangerous pointer-value-to-`unsigned' cast.
1370 * NEWS: mention the new sha* programs.
1371 * AUTHORS: Add new sha* programs.
1373 2005-08-28 David Madore <david.madore@ens.fr>
1375 Add new programs: sha224sum, sha256sum, sha384sum, sha512sum.
1376 * README: Add their names to the list.
1377 * src/md5sum.c: Provide framework for computing sha-2 hashes.
1378 * src/Makefile.am (sha224sum, sha256sum, sha384sum, sha512sum):
1379 Rules for compiling sha-2 utilities
1380 (noinst_HEADERS): Remove checksum.h.
1381 * man/sha512sum.x, man/sha384sum.x, man/sha256sum.x, man/sha224sum.x:
1383 * man/Makefile.am (dist_man_MANS): Add the corresponding .1 names.
1384 (sha224sum.1, sha256sum.1, sha384sum.1, sha512sum.1): New dependencies.
1385 * tests/misc/sha224sum, tests/misc/sha256sum: New files.
1386 * tests/misc/sha384sum, tests/misc/sha512sum: New files.
1387 * tests/misc/Makefile.am (TESTS): Add new sha224sum, sha256sum,
1388 sha384sum, sha512sum test scripts here rather that each in its
1391 2005-08-28 David Madore <david.madore@ens.fr>
1393 * tests/sha1sum/basic-1 (million-a): Add the "million a's" test (one
1394 of the FIPS test vectors).
1396 2005-10-23 Jim Meyering <jim@meyering.net>
1398 * configure.ac: Use 6.0-cvs as the version string.
1399 * NEWS: Adjust accordingly.