1 2003-03-02 Havoc Pennington <hp@pobox.com>
3 * test/break-loader.c (randomly_set_extreme_ints): add test that
4 sets really huge and small integers
6 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): add check
7 that length of boolean array fits in the string, and that
8 string has room for boolean value in single-bool case.
10 * dbus/dbus-message-builder.c (_dbus_message_data_load): add
11 optional value to "ALIGN" command which is what to fill the
14 * test/data/valid-messages/no-padding.message: add regression
15 test for the message padding problem
17 2003-03-02 Havoc Pennington <hp@pobox.com>
19 * dbus/dbus-message.c (decode_header_data): fix to always init
20 message_padding, from Benjamin Dauvergne
22 2003-03-02 Havoc Pennington <hp@pobox.com>
28 2003-03-01 Joe Shaw <joe@assbarn.com>
30 * configure.in: Check for "struct cmsgcred" and try to access its
31 members for BSD-like unices.
33 * dbus/dbus-sysdeps.c (read_credentials_byte): Fold this back into
34 _dbus_read_credentials_unix_socket().
35 (_dbus_read_credentials_unix_socket): Use recvmsg() instead of
36 read() for reading the credential byte off the unix socket. Use
37 struct cmsgcred on systems that support it.
39 2003-02-27 Alexander Larsson <alexl@redhat.com>
43 Make gthreads-2.0 dependency optional. Don't build thread test if
46 2003-02-27 Havoc Pennington <hp@pobox.com>
48 * dbus/dbus-connection.c
49 (dbus_connection_send_message_with_reply_and_block): fix doh!
50 doh! doh! bug that resulted in never removing a reply from the
51 queue, no wonder we called get_reply_serial so much ;-)
53 * dbus/dbus-message.c (struct DBusMessage): cache reply serial
54 and client serial instead of demarshaling them every time
56 2003-02-27 Havoc Pennington <hp@pobox.com>
58 * dbus/dbus-marshal.c (_dbus_demarshal_int32): rewrite to be much
59 more inlined, using dbus-string-private.h, speeds things up
62 * dbus/dbus-string.c (_dbus_string_free): apply align offset
63 when freeing the string
64 (_dbus_string_steal_data): fix for align offset
65 (undo_alignment): new function
67 2003-02-26 Havoc Pennington <hp@redhat.com>
69 All kinds of audit fixes from Owen, plus initial attempt to
70 handle unaligned memory returned from malloc.
72 * dbus/dbus-string.c (_dbus_string_init): clamp max length to
73 leave room for align_offset and nul byte
74 (fixup_alignment): function to track an align_offset and
75 ensure real->str is aligned
76 (DBUS_GENERIC_STRING_PREAMBLE): len must be less than allocated,
77 to allow a nul byte plus align offset
78 (_dbus_string_lock): fix overflow issue
79 (_dbus_string_init_const_len): add assertions on sanity of len,
80 assign allocated to be ALLOCATION_PADDING larger than len
81 (set_length): fixup the overflow handling
82 (_dbus_string_get_data_len): fix overflow in assertion
83 (open_gap): detect overflow in size of gap to be opened
84 (_dbus_string_lengthen): add overflow check
85 (_dbus_string_align_length): fix overflow with _DBUS_ALIGN_VALUE
86 (_dbus_string_append): add overflow check
87 (_dbus_string_append_unichar): overflow
88 (_dbus_string_delete): fix overflow in assertion
89 (_dbus_string_copy_len): overflow in assertion
90 (_dbus_string_replace_len): overflows in assertions
91 (_dbus_string_find): change to implement in terms of
93 (_dbus_string_find_to): assorted fixage
94 (_dbus_string_equal_c_str): assert c_str != NULL,
95 fix logic so the function works
96 (_dbus_string_ends_with_c_str): fix overflow thingy
97 (_dbus_string_base64_encode): overflow fix
98 (_dbus_string_validate_ascii): overflow
99 (_dbus_string_validate_nul): overflow
101 2003-02-26 Havoc Pennington <hp@redhat.com>
103 * dbus/dbus-marshal.c (_dbus_marshal_test): fix to work with DISABLE_ASSERTS
105 2003-02-26 Alexander Larsson <alexl@redhat.com>
108 Set DBUS_GLIB_THREADS_LIBS for apps using gthread-2.0
110 * dbus/dbus-connection.c:
111 * dbus/dbus-connection.h:
112 Fix _dbus_connection_acquire_io_path and _dbus_connection_acquire_dispatch.
113 Add dbus_connection_set_wakeup_main_function and use it when queueing
114 incoming and outgoing messages.
117 * dbus/dbus-dataslot.c:
118 Threadsafe usage of DBusDataSlotAllocator
120 * dbus/dbus-message.c: (dbus_message_get_args_iter):
123 * dbus/dbus-server-unix.c:
127 Implement the new wakeup functions for glib.
130 * glib/test-thread-client.c:
131 * glib/test-thread-server.c:
132 * glib/test-thread.h:
133 Initial cut at some thread test code. Not really done yet.
135 2003-02-26 Havoc Pennington <hp@pobox.com>
137 * dbus/dbus-connection.c
138 (dbus_connection_send_message_with_reply_and_block): fix crash
139 where we ref'd the outgoing message instead of the returned reply
141 * dbus/dbus-transport-unix.c (do_authentication): check read watch
142 at the end of this function, so if we didn't need to read for
143 authentication, we reinstall it for receiving messages
145 * dbus/dbus-message.c (dbus_message_new_reply): allow replies to
146 a NULL sender for peer-to-peer case
148 * dbus/dbus-transport-unix.c (check_read_watch): handle
149 !authenticated case correctly
151 * glib/dbus-gmain.c: add support for DBusServer
153 * dbus/dbus-server.c: add data slot support
155 * glib/dbus-gmain.c (dbus_connection_setup_with_g_main): check
156 return values and handle errors
158 * dbus/dbus-dataslot.c: factor out the data slot stuff from
161 * Doxyfile.in (INPUT): add glib subdir
163 * glib/dbus-gmain.c (dbus_connection_setup_with_g_main): rename
164 setup_with_g_main instead of hookup_with_g_main; write docs
166 2003-02-24 Anders Carlsson <andersca@codefactory.se>
168 * dbus/dbus-marshal.c: (_dbus_marshal_validate_arg):
169 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
170 * dbus/dbus-message.c: (dbus_message_append_boolean),
171 (dbus_message_append_boolean_array),
172 (dbus_message_get_args_valist), (_dbus_message_test):
173 * dbus/dbus-message.h:
174 * doc/dbus-specification.sgml:
175 Various fixes as pointed out by Havoc.
177 * test/data/invalid-messages/bad-boolean-array.message:
178 * test/data/invalid-messages/bad-boolean.message:
179 Add invalid boolean value test cases.
181 2003-02-24 Anders Carlsson <andersca@codefactory.se>
183 * dbus/dbus-internals.c: (_dbus_type_to_string):
184 * dbus/dbus-marshal.c: (_dbus_marshal_get_arg_end_pos),
185 (_dbus_marshal_validate_arg):
186 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
187 * dbus/dbus-message.c: (dbus_message_append_args_valist),
188 (dbus_message_append_boolean), (dbus_message_append_boolean_array),
189 (dbus_message_get_args_valist), (dbus_message_iter_get_boolean),
190 (dbus_message_iter_get_int32), (dbus_message_iter_get_uint32),
191 (dbus_message_iter_get_double),
192 (dbus_message_iter_get_boolean_array), (message_iter_test):
193 * dbus/dbus-message.h:
194 * dbus/dbus-protocol.h:
195 * doc/dbus-specification.sgml:
196 * test/data/valid-messages/lots-of-arguments.message:
197 Add support for boolean and boolean array types.
199 2003-02-23 Havoc Pennington <hp@pobox.com>
201 * dbus/dbus-keyring.c: finish most of this implementation and
204 * dbus/dbus-errors.c (dbus_set_error_const, dbus_set_error): make
205 these barf if the error isn't cleared to NULL
207 * dbus/dbus-sysdeps.c (_dbus_delete_file): set error on failure
208 (_dbus_create_directory): new function
210 * dbus/dbus-errors.c (dbus_set_error): fix warning
212 * dbus/dbus-string.c (_dbus_string_hex_encode): new function
213 (_dbus_string_hex_decode): new function
214 (test_hex_roundtrip): test code
216 * dbus/dbus-sha.c (_dbus_sha_compute): use dbus_string_hex_encode
218 * dbus/dbus-md5.c (_dbus_md5_compute): use dbus_string_hex_encode
220 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): make this use
221 the save-to-temp/rename trick to atomically write the new file
222 (_dbus_string_parse_uint): new function
224 2003-02-22 Havoc Pennington <hp@pobox.com>
226 * test/Makefile.am (dist-hook): fix dist for test/data/sha-1
228 2003-02-22 Havoc Pennington <hp@pobox.com>
230 * dbus/dbus-message.c (dbus_message_iter_get_string_array):
231 (dbus_message_iter_get_byte_array): Fix up doxygen warnings
233 * dbus/dbus-sha.c: add implementation of SHA-1 algorithm
235 * dbus/test/data/sha-1: add US government test suite for SHA-1
237 2003-02-21 Anders Carlsson <andersca@codefactory.se>
239 * dbus/dbus-marshal.c: (_dbus_demarshal_string_array):
240 Make string arrays NULL-terminated.
242 * dbus/dbus-memory.c: (dbus_free_string_array):
243 * dbus/dbus-memory.h:
244 New function for freeing NULL-terminated string arrays.
246 * dbus/dbus-message-builder.c: (append_quoted_string),
247 (_dbus_message_data_load):
248 Add support for array types.
250 * dbus/dbus-message.c: (check_message_handling):
251 Add more types as test cases.
253 * dbus/dbus-sysdeps.c: (_dbus_string_parse_int),
254 (_dbus_string_parse_double):
255 Add the start offset to the end offset.
257 * test/data/valid-messages/lots-of-arguments.message:
258 New test message with lots of arguments.
260 2003-02-21 Anders Carlsson <andersca@codefactory.se>
262 * dbus/dbus-message.c: (dbus_message_append_nil),
263 (dbus_message_append_int32), (dbus_message_append_uint32),
264 (dbus_message_append_double), (dbus_message_append_string),
265 (dbus_message_append_int32_array),
266 (dbus_message_append_uint32_array),
267 (dbus_message_append_double_array),
268 (dbus_message_append_byte_array),
269 (dbus_message_append_string_array):
270 Fix all out-of-memory handling in these functions.
272 2003-02-21 Anders Carlsson <andersca@codefactory.se>
274 * dbus/dbus-message.c: (dbus_message_append_nil):
277 2003-02-21 Anders Carlsson <andersca@codefactory.se>
279 * dbus/dbus-message.c: (dbus_message_append_args_valist),
280 (dbus_message_append_nil), (dbus_message_append_int32_array),
281 (dbus_message_append_uint32_array),
282 (dbus_message_append_double_array),
283 (dbus_message_append_byte_array),
284 (dbus_message_append_string_array), (dbus_message_get_args_valist),
285 (dbus_message_iter_get_int32_array),
286 (dbus_message_iter_get_uint32_array),
287 (dbus_message_iter_get_double_array),
288 (dbus_message_iter_get_byte_array),
289 (dbus_message_iter_get_string_array):
291 * dbus/dbus-message.h:
292 Add functions for appending and getting arrays.
294 2003-02-21 Anders Carlsson <andersca@codefactory.se>
296 * dbus/dbus-mempool.c (_dbus_mem_pool_new): Make the
297 element size at least 8 bytes, fixes mempool tests on
300 2003-02-20 Alexander Larsson <alexl@redhat.com>
302 * dbus/dbus-transport-unix.c (unix_do_iteration):
303 Unlock the connection mutex during a blocking select call.
304 Add todo about how we need a way to wake up the select.
306 * dbus/dbus-connection-internal.h:
307 * dbus/dbus-connection.c:
308 Add _dbus_connection_lock and _dbus_connection_unlock.
310 2003-02-19 Havoc Pennington <hp@pobox.com>
312 * Doxyfile.in (PREDEFINED): put DOXYGEN_SHOULD_SKIP_THIS in
313 Doxyfile.in, not Doxyfile
315 * dbus/dbus-keyring.c: do some hacking on this
317 * dbus/dbus-sysdeps.c (_dbus_delete_file): new
319 * dbus/dbus-errors.c (dbus_set_error_const): do not call
321 (dbus_set_error): remove dbus_error_init, check for message ==
322 NULL *before* we sprintf into it, and add @todo about including
323 system headers in this file
325 * dbus/dbus-sysdeps.c (_dbus_create_file_exclusively): new
327 * dbus/dbus-errors.h (DBUS_ERROR_FAILED): add
329 * dbus/dbus-sysdeps.c (get_user_info): break this function out to
330 get various bits of user information based on either username
332 (_dbus_homedir_from_username): new function
334 2003-02-19 Anders Carlsson <andersca@codefactory.se>
337 Add check for nonposix getpwnam_r
339 * dbus/dbus-mempool.c: (_dbus_mem_pool_new):
340 Align the pool element size to a sizeof (void *) boundary.
342 * dbus/dbus-sysdeps.c: (_dbus_setenv), (_dbus_connect_unix_socket),
343 (_dbus_listen_unix_socket), (_dbus_credentials_from_username):
344 General Solaris fixes.
346 * test/data/valid-messages/simplest-manual.message:
347 Explicitly state that we want little-endian packing.
349 2003-02-19 Mikael Hallendal <micke@codefactory.se>
351 * dbus/dbus-server.c (dbus_server_listen): Support tcp: addresses.
353 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_tcp_socket):
354 Added to create a transport connecting using a tcp/ip socket.
356 * dbus/dbus-sysdeps.c (_dbus_connect_tcp_socket): Added to connect
357 to a tcp socket at given host and port.
358 (_dbus_listen_tcp_socket): added to listen on tcp socket for given
361 * dbus/dbus-server.c (dbus_server_listen): Support tcp: addresses.
363 * dbus/dbus-server-unix.c (_dbus_server_new_for_tcp_socket):
364 Added to create a server listening on a TCP/IP socket.
366 2003-02-19 Havoc Pennington <hp@pobox.com>
368 Throughout: mop up all the Doxygen warnings and undocumented
371 * dbus/dbus-sysdeps.c (do_exec): do not use execvp, we don't want
374 * dbus/dbus-threads.c: move global mutex initializers to
375 dbus-internals.h, multiple prototypes was confusing doxygen
376 besides being kind of ugly
378 * Doxyfile (PREDEFINED): have Doxygen define
379 DOXYGEN_SHOULD_SKIP_THIS so we can exclude things from
380 docs with #ifndef DOXYGEN_SHOULD_SKIP_THIS
381 (do not abuse the feature! it's for stuff like the autogenerated
382 macros in dbus-md5.c, not just for things you don't feel like
385 2003-02-18 Havoc Pennington <hp@pobox.com>
387 * dbus/dbus-string.c (_dbus_string_zero): new function
389 * dbus/dbus-md5.c: include MD5 implementation by L. Peter Deutsch,
390 wrap it in some dbus-friendly API
392 * dbus/dbus-types.h: add 16-bit types
394 2003-02-18 Joe Shaw <joe@assbarn.com>
396 * dbus/dbus-auth.c (handle_server_data_stupid_test_mech): Just get
397 credentials from our currently running process.
398 (get_word): Fix a buglet where we were copying the entire length
399 instead of relative to our position.
401 * dbus/dbus-hash.c (_dbus_hash_test): Don't try to allocate the
402 keys on the stack... it's 640k of data.
404 * dbus/dbus-sysdeps.c (_dbus_read_credentials_unix_socket): Always
405 read the credentials byte off the socket, even if we don't have
407 (_dbus_poll): Implement poll() using select() for systems which
410 * glib/test-dbus-glib.c (main): Print out an error if no
411 parameters are given.
413 * test/data/auth/fallback.auth-script: Added. Tests that a client
414 can fallback to a secondary auth mechanism if the first fails.
416 2003-02-18 Havoc Pennington <hp@pobox.com>
420 2003-02-17 Havoc Pennington <hp@pobox.com>
422 * doc/dbus-specification.sgml: lots of cosmetic
423 cleanups/rearrangement, add assorted FIXME, change DBUS_ADDRESS
424 env variable to DBUS_BUS_ADDRESS, s/client/application/,
425 s/server/bus/ (except in authentication section). Add a section
426 "Message Bus Message Routing"
428 2003-02-17 Anders Carlsson <andersca@codefactory.se.>
434 2003-02-17 Anders Carlsson <andersca@codefactory.se>
436 * doc/dbus-specification.sgml:
437 Specification updates.
439 2003-02-17 Anders Carlsson <andersca@codefactory.se>
441 * bus/activation.c: (bus_activation_init), (child_setup),
442 (bus_activation_activate_service):
444 * bus/main.c: (main):
445 Set DBUS_ADDRESS environment variable.
447 * dbus/dbus-errors.c: (dbus_set_error):
448 Don't use va_copy since that's a C99 feature.
450 * dbus/dbus-sysdeps.c: (_dbus_setenv), (do_exec),
452 * dbus/dbus-sysdeps.h:
453 Add child_setup_func to _dbus_spawn_async.
455 * doc/dbus-specification.sgml:
456 Update specification.
458 * test/spawn-test.c: (setup_func), (main):
461 2003-02-17 Alexander Larsson <alexl@redhat.com>
463 * dbus/dbus-connection.c (_dbus_connection_handler_destroyed_locked):
466 2003-02-17 Anders Carlsson <andersca@codefactory.se>
470 * doc/dbus-test-plan.sgml:
471 Add test plan document.
476 2003-02-17 Anders Carlsson <andersca@codefactory.se>
478 * dbus/dbus-message.c: (decode_header_data),
479 (_dbus_message_loader_return_buffer):
480 Set the header padding amount when loading a message.
482 2003-02-16 Anders Carlsson <andersca@codefactory.se>
484 * bus/dispatch.c: (send_one_message):
485 Only send broadcast messages to registered connections.
487 * dbus/dbus-message.c: (dbus_message_name_is):
488 * dbus/dbus-message.h:
489 New convenience function.
491 * dbus/dbus-transport-debug.c: (do_reading):
492 Only dispatch one message per run.
495 * test/bus-test.c: (new_connection_callback), (die),
496 (test_hello_client1_handler), (test_hello_client2_handler),
497 (test_hello_replies), (main):
499 * test/bus-test-loop.[ch]:
502 2003-02-16 Havoc Pennington <hp@pobox.com>
504 * dbus/dbus-connection.c (dbus_connection_dispatch_message): fix
507 2003-02-16 Alexander Larsson <alexl@redhat.com>
509 * dbus/dbus-connection.c:
510 Implement sent_message_with_reply. (with_reply_and block is still
512 Made dispatch_message not lose message if OOM.
514 * dbus/dbus-errors.h:
515 Add NoReply error (for reply timeouts).
517 2003-02-16 Alexander Larsson <alexl@redhat.com>
519 * dbus/dbus-hash.c (_dbus_hash_table_unref):
520 Actually free keys and values when destroying hashtable.
522 2003-02-16 Anders Carlsson <andersca@codefactory.se>
524 * dbus/dbus-auth.c: (client_try_next_mechanism):
527 * dbus/dbus-threads.c: (dbus_condvar_wait_timeout):
528 Return TRUE if there's no thread implementation around.
530 * glib/dbus-gmain.c: (free_source),
531 (dbus_connection_hookup_with_g_main):
532 Make sure to remove the GSource when the connection is finalized.
534 2003-02-16 Anders Carlsson <andersca@codefactory.se>
536 * bus/dispatch.c: (bus_dispatch_message_handler):
537 * dbus/dbus-errors.h:
538 Return an error if someone tries to send a message to a service
541 2003-02-16 Anders Carlsson <andersca@codefactory.se>
543 * bus/activation.c: (load_directory), (bus_activation_init),
544 (bus_activation_activate_service):
547 (bus_driver_handle_activate_service), (bus_driver_handle_message):
548 More work on the activation handling.
550 * dbus/dbus-errors.h:
551 Add some error messages
553 * dbus/dbus-message.c: (dbus_message_new_error_reply):
554 * dbus/dbus-message.h:
555 New function that creates an error message.
557 * dbus/dbus-protocol.h:
558 Add ACTIVATE_SERVER message.
560 * dbus/dbus-server-unix.c: (unix_handle_watch),
561 (_dbus_server_new_for_domain_socket):
562 Call _dbus_fd_set_close_on_exec.
564 * dbus/dbus-sysdeps.c: (make_pipe), (do_exec),
565 (_dbus_spawn_async), (_dbus_disable_sigpipe),
566 (_dbus_fd_set_close_on_exec):
567 * dbus/dbus-sysdeps.h:
568 Add _dbus_fd_set_close_on exec function. Also add function that checks
569 that all open fds are set to close-on-exec and warns otherwise.
571 * dbus/dbus-transport-unix.c:
572 (_dbus_transport_new_for_domain_socket):
573 Call _dbus_fd_set_close_on_exec.
575 2003-02-16 Havoc Pennington <hp@pobox.com>
577 * dbus/dbus-connection.c (dbus_connection_set_change_sigpipe):
578 allow people to avoid setting SIGPIPE to SIG_IGN
579 (_dbus_connection_new_for_transport): disable SIGPIPE unless
580 we've been asked not to
582 2003-02-15 Anders Carlsson <andersca@codefactory.se>
584 * dbus/dbus-list.c: (_dbus_list_append_link),
585 (_dbus_list_prepend_link):
586 * dbus/dbus-memory.c: (dbus_malloc), (dbus_malloc0),
590 2003-02-15 Anders Carlsson <andersca@codefactory.se>
593 * bus/activation.c: (bus_activation_entry_free),
594 (add_desktop_file_entry), (load_directory), (bus_activation_init):
596 * bus/main.c: (main):
597 Add simple activation support, doesn't work yet though.
599 2003-02-15 Zack Rusin <zack@kde.org>
601 * qt/dbus-qthread.cpp: small casting fix
603 2003-02-15 Anders Carlsson <andersca@codefactory.se>
605 * dbus/dbus-errors.c: (dbus_set_error):
606 * dbus/dbus-errors.h:
607 Add a few errors and make dbus_set_error void.
609 * dbus/dbus-sysdeps.c:
610 (_dbus_errno_to_string), (close_and_invalidate), (make_pipe),
611 (write_err_and_exit), (read_ints), (do_exec), (_dbus_spawn_async):
612 * dbus/dbus-sysdeps.h:
613 Add _dbus_spawn_async.
615 * test/spawn-test.c: (main):
616 Test for _dbus_spawn_async.
618 2003-02-15 Anders Carlsson <andersca@codefactory.se>
620 * dbus/dbus-internals.h:
621 Fix build without tests.
623 * dbus/dbus-list.c: (alloc_link):
624 Fix a segfault when a malloc fails.
626 * dbus/dbus-memory.c: (initialize_malloc_debug), (dbus_malloc),
627 (dbus_malloc0), (dbus_realloc):
628 Add support for malloc debugging.
630 2003-02-15 Alexander Larsson <alexl@redhat.com>
632 * dbus/dbus-threads.c:
633 * dbus/dbus-threads.h:
634 Add condvars. Remove static mutext from API.
635 Implement static mutexes by initializing them from threads_init.
637 * glib/dbus-gthread.c:
638 * qt/dbus-qthread.cpp:
639 Update with the thread api changes.
644 Turn StaticMutex into normal mutex + init function.
645 Export new functions _dbus_list_alloc_link, _dbus_list_free_link,
646 _dbus_list_append_link, _dbus_list_prepend_link
649 * dbus/dbus-sysdeps.c:
650 * dbus/dbus-sysdeps.h:
651 New type dbus_atomic_t, and new functions _dbus_atomic_inc,
652 _dbus_atomic_dec. Only slow fallback implementation at the moment.
654 * dbus/dbus-protocol.h:
655 Add DBUS_MESSAGE_LOCAL_DISCONNECT define
657 * dbus/dbus-message.c:
658 Make ref/unref atomic.
661 * dbus/dbus-connection-internal.h:
662 * dbus/dbus-connection.c:
663 * dbus/dbus-connection.h:
665 Change _peek to _borrow,_return & _steal_borrowed.
666 Change disconnect callback to event.
667 Make dbus_connection_dispatch_messages reentrant.
669 * dbus/dbus-transport.c:
670 Don't ref the connection on calls to the transport
673 * dbus/dbus-message-handler.c:
677 Don't use peek_message anymore
680 * test/debug-thread.c:
681 * test/debug-thread.h:
682 Simple thread implementation that asserts() on deadlocks in
683 single-threaded code.
686 (main) Call debug_threads_init.
689 Use disconnect message instead of disconnect callback.
693 Don't call dbus_connection_set_disconnect_function. Instead export
694 bus_connection_disconnect.
697 Call bus_connection_disconnect when we get a disconnected message.
699 2003-02-15 Havoc Pennington <hp@pobox.com>
701 * dbus/dbus-message.c (dbus_message_new): fool around with the
704 2003-02-14 Havoc Pennington <hp@pobox.com>
706 * dbus/dbus-mempool.c: fail if the debug functions so indicate
708 * dbus/dbus-memory.c: fail if the debug functions indicate we
711 * dbus/dbus-internals.c (_dbus_set_fail_alloc_counter)
712 (_dbus_decrement_fail_alloc_counter): debug functions to
713 simulate memory allocation failures
715 2003-02-14 Havoc Pennington <hp@pobox.com>
717 * dbus/dbus-errors.h (struct DBusError): add a word of padding
720 2003-02-13 Anders Carlsson <andersca@codefactory.se>
722 * bus/driver.c: (bus_driver_handle_hello):
724 * bus/services.c: (bus_service_lookup):
725 Reorder message sending so we get a more sane order.
727 * test/bus-test.c: (message_handler):
730 2003-02-13 Anders Carlsson <andersca@codefactory.se>
732 * bus/driver.c: (bus_driver_send_service_deleted),
733 (bus_driver_send_service_created), (bus_driver_send_service_lost),
734 (bus_driver_send_service_acquired), (bus_driver_handle_hello),
735 (bus_driver_send_welcome_message),
736 (bus_driver_handle_list_services),
737 (bus_driver_handle_acquire_service),
738 (bus_driver_handle_service_exists):
739 * dbus/dbus-bus.c: (dbus_bus_register_client),
740 (dbus_bus_acquire_service), (dbus_bus_service_exists):
741 * dbus/dbus-errors.c: (dbus_result_to_string):
742 * dbus/dbus-errors.h:
743 * dbus/dbus-message.c: (dbus_message_append_args),
744 (dbus_message_append_args_valist), (dbus_message_get_args),
745 (dbus_message_get_args_valist), (dbus_message_get_args_iter),
746 (dbus_message_iter_get_arg_type), (dbus_message_iter_get_string),
747 (dbus_message_iter_get_byte_array),
748 (dbus_message_iter_get_string_array), (message_iter_test),
749 (check_message_handling), (_dbus_message_test):
750 * dbus/dbus-message.h:
751 * test/bus-test.c: (main):
752 Change fields to arguments in messages, so that they won't be
753 confused with header fields.
755 * glib/test-dbus-glib.c: (main):
756 Remove append_fields from hello message.
758 2003-02-13 Anders Carlsson <andersca@codefactory.se>
760 * dbus/dbus-errors.c:
761 * dbus/dbus-message.c:
762 * dbus/dbus-string.c:
765 2003-02-13 Anders Carlsson <andersca@codefactory.se>
767 * glib/dbus-gmain.c: (timeout_handler), (add_timeout),
769 Implement support for timeouts in dbus-glib.
771 2003-02-13 Anders Carlsson <andersca@codefactory.se>
773 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
774 * dbus/dbus-message.c: (process_test_subdir):
775 * test/break-loader.c: (find_breaks_based_on):
776 Plug some memory leaks.
778 2003-02-13 Richard Hult <rhult@codefactory.se>
780 * bus/main.c: Fix build.
782 * dbus/dbus-errors.h:
783 * dbus/dbus-errors.c: Fix copyright for Anders.
785 2003-02-13 Anders Carlsson <andersca@codefactory.se>
790 * bus/connection.c: (bus_connection_foreach):
793 * bus/desktop-file.c: (grow_lines_in_section), (grow_sections),
794 (unescape_string), (new_section), (parse_section_start),
795 (parse_key_value), (report_error), (bus_desktop_file_load),
796 (bus_desktop_file_get_string):
797 * bus/desktop-file.h:
798 Use DBusError for error reporting.
800 * bus/dispatch.c: (send_one_message),
801 (bus_dispatch_message_handler):
802 * bus/driver.c: (bus_driver_send_service_deleted),
803 (bus_driver_send_service_created), (bus_driver_send_service_lost),
804 (bus_driver_send_service_acquired), (bus_driver_handle_hello),
805 (bus_driver_send_welcome_message),
806 (bus_driver_handle_list_services),
807 (bus_driver_handle_acquire_service),
808 (bus_driver_handle_service_exists):
809 * bus/loop.c: (bus_loop_run):
811 Use BUS_HANDLE_OOM instead of _DBUS_HANDLE_OOM.
813 * bus/utils.c: (bus_wait_for_memory):
815 New files with general utility functions.
817 * dbus/dbus-internals.h:
818 Remove _DBUS_HANDLE_OOM.
820 2003-02-13 Anders Carlsson <andersca@codefactory.se>
822 * dbus/dbus-errors.c: (dbus_result_to_string), (dbus_error_init),
823 (dbus_error_free), (dbus_set_error_const), (dbus_set_error):
824 * dbus/dbus-errors.h:
825 Add DBusError structure.
827 2003-02-13 Anders Carlsson <andersca@codefactory.se>
829 * test/data/valid-messages/standard-acquire-service.message:
830 * test/data/valid-messages/standard-hello.message:
831 * test/data/valid-messages/standard-list-services.message:
832 * test/data/valid-messages/standard-service-exists.message:
833 Add some standard messages.
835 2003-02-13 Anders Carlsson <andersca@codefactory.se>
837 * bus/driver.c: (bus_driver_send_welcome_message),
838 (bus_driver_handle_list_services),
839 (bus_driver_handle_acquire_service),
840 (bus_driver_handle_service_exists), (bus_driver_handle_message):
841 Update for API changes in libdbus.
843 * dbus/dbus-message.c: (dbus_message_new_reply):
844 * dbus/dbus-message.h:
845 Remove the name argument. The spec states that replies shouldn't
848 2003-02-13 Anders Carlsson <andersca@codefactory.se>
850 * bus/desktop-file.c: (parse_section_start), (parse_key_value),
851 (report_error), (bus_desktop_file_load), (lookup_section),
852 (lookup_line), (bus_desktop_file_get_raw),
853 (bus_desktop_file_get_string):
854 * bus/desktop-file.h:
855 Some fixes, and new functions for getting a key value from a section.
857 2003-02-13 Havoc Pennington <hp@pobox.com>
859 * test/data/auth/fail-after-n-attempts.auth-script: new test
861 * dbus/dbus-auth.c (send_rejected): shutdown_mech() when we
864 2003-02-13 Havoc Pennington <hp@pobox.com>
866 * dbus/dbus-auth.c (handle_server_data_external_mech): args to
867 dbus_credentials_match were backward
869 * dbus/dbus-auth-script.c (_dbus_auth_script_run): support
870 NO_CREDENTIALS and ROOT_CREDENTIALS
872 * dbus/dbus-auth.c (_dbus_auth_do_work): move get_state() routine
873 into here. Never process more commands after we've reached an
874 end state; store further data as unused bytes.
876 * test/data/auth/*: add more auth tests
878 * dbus/dbus-auth-script.c (_dbus_auth_script_run): support EXPECT
879 command to match exact string and EXPECT_UNUSED to match unused
882 * test/Makefile.am (dist-hook): fix to dist all the test stuff
884 2003-02-12 Havoc Pennington <hp@pobox.com>
886 * dbus/dbus-string.c (_dbus_string_pop_line): fix to also strip
887 \r off of popped lines
889 * dbus/dbus-auth.c (_dbus_auth_test): write code to run auth
892 * dbus/dbus-auth-script.c (_dbus_auth_script_run): when doing a
895 2003-02-12 Havoc Pennington <hp@pobox.com>
897 * dbus/Makefile.am: remove break-loader from the build, since it
900 * configure.in: add --enable-gcov to turn on coverage profiling
901 flags and disable optimization
903 2003-02-10 Havoc Pennington <hp@pobox.com>
905 * dbus/dbus-auth-script.c, dbus/dbus-auth-script.h: sync
906 initial cut at test framework for DBusAuth from laptop.
907 Doesn't quite work yet but it compiles and I need to get
908 it off the 266mhz laptop. ;-)
910 * dbus/dbus-server-debug.c (_dbus_server_debug_accept_transport):
911 fix a memleak in error case
913 2003-02-12 Anders Carlsson <andersca@codefactory.se>
916 * bus/desktop-file.c:
917 * bus/desktop-file.h:
918 Add a desktop file parser.
920 2003-02-11 Zack Rusin <zack@kde.org>
922 * qt/message.[h|cpp]: sample implementation
923 of the KDE wrapper for DBusMessage
925 2003-02-09 Zack Rusin <zack@kde.org>
927 * test/bus-test.c: make_it_compile
928 * doc/dbus-specification.sgml: minimal semantic fix
930 2003-02-06 Anders Carlsson <andersca@codefactory.se>
936 2003-02-06 Anders Carlsson <andersca@codefactory.se>
939 * dbus/dbus-break-loader.c:
941 * test/break-loader.c:
942 Move dbus-break-loader to test/ and rename it to break-loader.
944 2003-02-02 Havoc Pennington <hp@pobox.com>
946 * dbus/dbus-keyring.c, dbus/dbus-keyring.h: template files
947 for code to manage cookies in your home directory
949 * dbus/dbus-sysdeps.c (_dbus_generate_random_bytes): new function
951 * dbus/dbus-auth.c (get_state): impose a maximum number of tries
952 to authenticate, then disconnect the client.
954 2003-02-03 Alexander Larsson <alexl@redhat.com>
956 * dbus/dbus-message.c (dbus_message_append_fields):
959 2003-02-02 Anders Carlsson <andersca@codefactory.se>
961 * doc/dbus-specification.sgml:
962 Update address format section.
964 2003-02-02 Anders Carlsson <andersca@codefactory.se>
967 * test/bus-test.c: (get_time), (add_timeout), (remove_timeout),
968 (message_handler), (new_connection_callback), (loop_quit),
972 2003-02-02 Anders Carlsson <andersca@codefactory.se>
974 * bus/driver.c: (bus_driver_handle_service_exists):
975 Simplify the code a bit.
977 * dbus/dbus-bus.c: (dbus_bus_service_exists):
980 2003-02-02 Anders Carlsson <andersca@codefactory.se>
983 Add libdbus-daemon.la and link to it.
985 2003-02-01 James Willcox <jwillcox@gnome.org>
987 * bus/driver.c: (bus_driver_handle_own_service):
988 Actually include the service reply code in the message.
990 2003-02-02 Anders Carlsson <andersca@codefactory.se>
992 * bus/driver.c: (bus_driver_handle_service_exists):
993 Don't unref the incoming message.
995 2003-02-02 Anders Carlsson <andersca@codefactory.se>
997 * dbus/dbus.h: Add dbus-address.h and dbus-bus.h
999 2003-02-02 Anders Carlsson <andersca@codefactory.se>
1001 * dbus/dbus-server.c: (dbus_server_listen):
1002 * dbus/dbus-transport.c: (_dbus_transport_open):
1003 ifdef out the calls to the debug transport and server.
1005 2003-02-02 Alexander Larsson <alexl@redhat.com>
1007 * dbus/dbus-watch.c (dbus_watch_get_flags):
1008 Add note in the docs that ERROR or HANGUP won't be returned
1009 and are assumed always on.
1011 * glib/dbus-gmain.c (add_watch):
1012 Always add IO_ERR | IO_HUP
1014 * dbus/dbus-message.h:
1015 Add semicolon after dbus_message_iter_get_string_array().
1016 Makes qt code build again
1018 2003-02-01 Anders Carlsson <andersca@codefactory.se>
1020 * bus/driver.c: (create_unique_client_name),
1021 (bus_driver_handle_hello):
1022 Don't take a name, just use a numeric id to identify
1026 * dbus/dbus-bus.c: (dbus_bus_register_client),
1027 (dbus_bus_acquire_service), (dbus_bus_service_exists):
1029 Add new convenience functions for communicating with the bus.
1031 * dbus/dbus-message.h:
1033 * dbus/dbus-protocol.h:
1036 2003-02-01 Alexander Larsson <alexl@redhat.com>
1038 * dbus/dbus-message.c (dbus_message_append_fields):
1039 Add some more doc comments.
1041 2003-02-01 Havoc Pennington <hp@pobox.com>
1043 * dbus/dbus-break-loader.c (randomly_modify_length): change
1044 a 4-byte value in the message as if it were a length
1046 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): don't set
1047 execute bit on saved files
1049 2003-02-01 Havoc Pennington <hp@pobox.com>
1051 * dbus/dbus-break-loader.c (main): new program to find messages
1052 that break the loader.
1054 * dbus/dbus-sysdeps.c (_dbus_string_append_uint): new function
1055 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): new function
1057 * dbus/dbus-string.c (_dbus_string_set_byte): new
1059 2003-01-31 Havoc Pennington <hp@pobox.com>
1061 * dbus/dbus-message.c: refactor the test code to be more general,
1062 in preparation for writing a "randomly permute test cases to
1063 try to break the loader" program.
1065 2003-01-31 Havoc Pennington <hp@pobox.com>
1067 * doc/dbus-specification.sgml: work on the specification
1069 * dbus/dbus-message.c (_dbus_message_loader_return_buffer): check
1070 the protocol version of the message.
1072 * dbus/dbus-protocol.h: drop special _REPLY names, the spec
1073 no longer specifies that.
1074 (DBUS_SERVICE_REPLY_SERVICE_EXISTS): fix flags (1/2/4/8 not
1077 * dbus/dbus-marshal.c (_dbus_marshal_get_arg_end_pos): add missing
1078 "break" for DBUS_TYPE_NIL, remove @todo
1080 2003-01-31 Havoc Pennington <hp@pobox.com>
1082 * dbus/dbus-message.c (dbus_message_set_is_error_reply): rename
1083 just set_is_error/get_is_error as this is a commonly-used
1084 function, and write docs.
1086 2003-01-31 Anders Carlsson <andersca@codefactory.se>
1088 * dbus/dbus-address.c: (dbus_address_entry_free):
1089 Free key and value lists.
1091 * dbus/dbus-internals.c: (_dbus_type_to_string):
1092 Add the types we didn't have.
1094 * dbus/dbus-marshal.c: (_dbus_marshal_get_arg_end_pos),
1095 (_dbus_marshal_validate_arg):
1098 * dbus/dbus-message.c: (dbus_message_set_sender):
1099 Remove todo about being able to set sender to NULL.
1101 (dbus_message_set_is_error_reply),
1102 (dbus_message_get_is_error_reply):
1103 * dbus/dbus-message.h:
1106 * dbus/dbus-protocol.h:
1107 Add error reply flag.
1109 * test/data/valid-messages/opposite-endian.message:
1110 Add NIL type to test.
1112 2003-01-31 Havoc Pennington <hp@pobox.com>
1114 * doc/dbus-specification.sgml: fully specify the header. Add
1115 flags and major protocol version, and change header/body len to
1118 * dbus/dbus-message-builder.c (append_saved_length): append length
1121 * dbus/dbus-message.c (dbus_message_create_header): change header
1122 length and body length to unsigned. Add the new fields from the
1124 (_dbus_message_loader_return_buffer): unsigned header/body len
1126 2003-01-30 Havoc Pennington <hp@pobox.com>
1128 * dbus/dbus-auth.c: rework to use only REJECTED, no
1131 * doc/dbus-sasl-profile.txt: drop MECHANISMS and just
1132 use REJECTED, suggested by Mark McLoughlin
1134 2003-01-30 Havoc Pennington <hp@pobox.com>
1136 * dbus/dbus-server.c (dbus_server_listen): @todo about how we need
1137 a better way to report errors here. e.g. "unix address lacks
1138 path" or something. also "no such file" when the path doesn't
1141 * dbus/dbus-address.c (dbus_address_entries_free): add @todo about
1143 (dbus_parse_address): add @todo about documenting address format,
1144 and allowing , and ; to be escaped
1146 2003-01-30 Anders Carlsson <andersca@codefactory.se>
1149 Add dbus-address.[ch]
1151 * dbus/dbus-address.c: (dbus_address_entry_free),
1152 (dbus_address_entries_free), (create_entry),
1153 (dbus_address_entry_get_method), (dbus_address_entry_get_value),
1154 (dbus_parse_address), (_dbus_address_test):
1155 * dbus/dbus-address.h:
1156 New files for dealing with address parsing.
1158 * dbus/dbus-connection.c:
1159 Document timeout functions.
1161 * dbus/dbus-message.c:
1162 Document dbus_message_new_from_message.
1164 * dbus/dbus-server-debug.c:
1167 * dbus/dbus-server.c: (dbus_server_listen):
1168 Parse address and use correct server implementation.
1170 * dbus/dbus-string.c: (_dbus_string_find_to), (_dbus_string_test):
1171 * dbus/dbus-string.h:
1172 New function with test.
1174 * dbus/dbus-test.c: (dbus_internal_symbol_do_not_use_run_tests):
1178 * dbus/dbus-transport-debug.c:
1181 * dbus/dbus-transport.c: (_dbus_transport_open):
1182 Parse address and use correct transport implementation.
1184 2003-01-30 Havoc Pennington <hp@pobox.com>
1186 * dbus/dbus-message.c: use message->byte_order instead of
1187 DBUS_COMPILER_BYTE_ORDER throughout.
1188 (dbus_message_create_header): pad header to align the
1189 start of the body of the message to 8-byte boundary
1191 * dbus/dbus-marshal.h: make all the demarshalers take const
1192 DBusString arguments.
1194 * dbus/dbus-message.c (_dbus_message_loader_return_buffer):
1195 validate message args here, so we don't have to do slow validation
1196 later, and so we catch bad messages as they are incoming. Also add
1197 better checks on header_len and body_len. Also fill in
1200 * dbus/dbus-string.c (_dbus_string_validate_utf8): new (not
1201 implemented properly)
1202 (_dbus_string_validate_nul): new function to check all-nul
1204 * dbus/dbus-marshal.c (_dbus_marshal_get_field_end_pos): rename
1205 get_arg_end_pos and remove all validation
1206 (_dbus_marshal_validate_arg): actually do validation here.
1208 2003-01-29 Havoc Pennington <hp@pobox.com>
1210 * dbus/dbus-message.c (check_message_handling): fix assertion
1211 failure on set_client_serial
1213 2003-01-28 Havoc Pennington <hp@pobox.com>
1215 * dbus/dbus-server-debug.c: Add doc section comments
1217 * dbus/dbus-transport-debug.c: add doc section comments
1219 2003-01-28 Havoc Pennington <hp@redhat.com>
1221 * dbus/dbus-string.c (_dbus_string_base64_decode): append bytes in
1222 the reverse order from how I had it
1223 (_dbus_string_base64_encode): reverse encoding order. I was
1224 basically byteswapping everything during encoding.
1226 2003-01-28 Anders Carlsson <andersca@codefactory.se>
1228 * dbus/dbus-connection-internal.h:
1229 * dbus/dbus-connection.c: (_dbus_connection_add_timeout),
1230 (_dbus_connection_remove_timeout):
1231 Add functions for adding and removing timeouts.
1233 * dbus/dbus-message.c: (dbus_message_new_from_message):
1234 Add new function that takes a message and creates an exact
1235 copy of it, but with the refcount set to 1.
1236 (check_message_handling):
1239 * dbus/dbus-server-protected.h:
1240 * dbus/dbus-server.c: (_dbus_server_init_base),
1241 (_dbus_server_finalize_base), (_dbus_server_add_timeout),
1242 (dbus_server_set_timeout_functions):
1243 (_dbus_server_remove_timeout):
1244 New functions so that a server can add and remove timeouts.
1246 (dbus_server_listen):
1247 Add commented out call to dbus_server_debug_new.
1249 * dbus/dbus-timeout.c: (_dbus_timeout_new):
1250 Actually set the handler, doh.
1252 * dbus/dbus-transport.c: (_dbus_transport_open):
1253 Add commented out call to dbus_transport_debug_client_new.
1256 Add dbus-transport-debug.[ch] and dbus-server-debug.[ch]
1258 2003-01-28 Havoc Pennington <hp@pobox.com>
1260 * dbus/dbus-message.c (check_message_handling): function to check
1261 on the loaded message, iterates over it etc.
1263 2003-01-28 Havoc Pennington <hp@pobox.com>
1265 * test/Makefile.am (dist-hook): fix make distdir
1267 * dbus/Makefile.am (TESTS_ENVIRONMENT): fix make check
1269 2003-01-27 Havoc Pennington <hp@pobox.com>
1271 * dbus/dbus-mempool.c (time_for_size): replace printf with
1274 * dbus/dbus-message-builder.c (_dbus_message_data_load): allow
1275 empty lines; fix the SAVE_LENGTH stuff to be
1276 START_LENGTH/END_LENGTH so it actually works; couple other
1279 * test/Makefile.am (dist-hook): add dist-hook for .message files
1281 * dbus/dbus-string.c (DBUS_STRING_COPY_PREAMBLE): source of a copy
1282 can be constant or locked.
1283 (_dbus_string_free): allow freeing a const string as
1286 * dbus/dbus-sysdeps.c (_dbus_concat_dir_and_file): utility
1288 * dbus/dbus-test-main.c (main): take an argument which is the
1289 directory containing test data
1291 * dbus/dbus-message.c (_dbus_message_test): pass a test_data_dir
1292 argument to this and load all the messages in test/data/
1293 checking that they can be loaded or not loaded as appropriate.
1295 2003-01-27 Anders Carlsson <andersca@codefactory.se>
1297 * bus/dispatch.c: (bus_dispatch_message_handler):
1298 Dispatch messages sent to services.
1300 * bus/driver.c: (bus_driver_send_service_deleted),
1301 (bus_driver_send_service_created), (bus_driver_send_service_lost),
1302 (bus_driver_send_service_acquired):
1303 Add helper functions for sending service related messages.
1305 (bus_driver_send_welcome_message):
1306 Send HELLO_REPLY instead of WELCOME.
1308 (bus_driver_handle_list_services):
1309 Send LIST_SERVICES_REPLY instead of SERVICES.
1311 (bus_driver_handle_own_service),
1312 (bus_driver_handle_service_exists):
1313 New message handlers.
1315 (bus_driver_handle_message):
1316 Invoke new message handlers.
1318 (bus_driver_remove_connection):
1319 Don't remove any services here since that's done automatically
1320 by bus_service_remove_owner now.
1323 New function signatures.
1325 * bus/services.c: (bus_service_add_owner):
1326 Send ServiceAcquired message if we're the only primary owner.
1328 (bus_service_remove_owner):
1329 Send ServiceAcquired/ServiceLost messages.
1331 (bus_service_set_prohibit_replacement),
1332 (bus_service_get_prohibit_replacement):
1333 Functions for setting prohibit replacement.
1335 (bus_service_has_owner):
1336 New function that checks if a connection is in the owner queue of
1340 Add new function signatures.
1342 * dbus/dbus-list.c: (_dbus_list_test):
1343 Add tests for _dbus_list_remove_last and traversing the list backwards.
1346 Fix a typo in _dbus_list_get_prev_link, if we're at the first element we can't
1347 go any further, so return NULL then.
1349 * dbus/dbus-protocol.h:
1350 Add new messages, service flags and service replies.
1352 2003-01-26 Havoc Pennington <hp@pobox.com>
1354 * dbus/dbus-message-builder.c: implement, completely untested.
1356 * test/data/*: add data to be used in testing.
1357 ".message" files are our simple loadable text format.
1358 ".message-raw" will be binary dumps of messages.
1360 * dbus/dbus-string.c (_dbus_string_starts_with_c_str): new
1362 2003-01-26 Havoc Pennington <hp@pobox.com>
1364 * dbus/dbus-sysdeps.c (_dbus_file_get_contents): new function
1366 * dbus/dbus-errors.c (dbus_result_to_string): add
1369 * dbus/dbus-message-builder.c: new file, will contain code to load
1370 up messages from files. Not implemented yet.
1372 2003-01-26 Havoc Pennington <hp@pobox.com>
1374 * dbus/dbus-message.c (dbus_message_set_sender): support deleting
1375 the sender by setting to NULL
1377 2003-01-26 Havoc Pennington <hp@pobox.com>
1379 The unit tests pass, but otherwise untested. If it breaks, the
1380 tests should have been better. ;-)
1382 * bus/driver.c (bus_driver_handle_hello): return if we disconnect
1385 * dbus/dbus-message.c: redo everything so we maintain
1386 message->header as the only copy of the various fields.
1387 This avoids the possibility of out-of-memory in some cases,
1388 for example dbus_message_lock() can't run out of memory anymore,
1389 and avoids extra copying. Figured I may as well go ahead and do
1390 this since it was busted for dbus_message_lock to not return
1391 failure on OOM, and dbus_message_write_header was totally
1392 unchecked for OOM. Also fixed some random other bugs.
1394 * dbus/dbus-marshal.c (_dbus_marshal_get_field_end_pos): verify
1395 that strings are nul-terminated. Also, end_pos can be equal
1396 to string length just not greater than, I think.
1397 (_dbus_marshal_set_int32): new function
1398 (_dbus_marshal_set_uint32): new function
1399 (_dbus_marshal_set_string): new function
1401 * dbus/dbus-connection.c (_dbus_connection_new_for_transport): fix
1402 a warning, init timeout_list to NULL
1403 (dbus_connection_send_message): don't use uninitialized variable
1406 * dbus/dbus-string.c (_dbus_string_replace_len): new function
1408 2003-01-26 Anders Carlsson <andersca@codefactory.se>
1410 * bus/driver.c: (bus_driver_handle_hello),
1411 (bus_driver_send_welcome_message):
1414 2003-01-26 Anders Carlsson <andersca@codefactory.se>
1416 * dbus/dbus-auth.c: (process_auth), (_dbus_auth_unref):
1417 * dbus/dbus-connection.c: (_dbus_connection_new_for_transport),
1418 (dbus_connection_unref):
1419 * dbus/dbus-marshal.c: (_dbus_marshal_test):
1420 * dbus/dbus-message.c: (dbus_message_unref),
1423 (dbus_message_get_fields):
1424 Remove debugging printout.
1426 (_dbus_message_loader_return_buffer):
1427 Don't store the header string.
1429 (_dbus_message_test):
1432 2003-01-26 Richard Hult <rhult@codefactory.se>
1434 * glib/dbus-gmain.c (dbus_connection_dispatch): Traverse a copy of
1435 the file descriptor list, since it can change under us.
1437 2003-01-25 Anders Carlsson <andersca@codefactory.se>
1439 * glib/dbus-gmain.c: (dbus_connection_prepare),
1440 (dbus_connection_check), (dbus_connection_dispatch), (add_watch),
1441 (remove_watch), (dbus_connection_hookup_with_g_main):
1442 Rewrite the glib handling to use its own GSource instead of a
1443 GIOChannel so we can catch messages put in the queue while waiting
1446 2003-01-25 Anders Carlsson <andersca@codefactory.se>
1449 * bus/connection.c: (connection_disconnect_handler),
1450 (connection_watch_callback), (bus_connection_setup):
1451 * bus/dispatch.c: (send_one_message),
1452 (bus_dispatch_broadcast_message), (bus_dispatch_message_handler),
1453 (bus_dispatch_add_connection), (bus_dispatch_remove_connection):
1455 * bus/driver.c: (bus_driver_send_service_deleted),
1456 (bus_driver_send_service_created), (bus_driver_handle_hello),
1457 (bus_driver_send_welcome_message),
1458 (bus_driver_handle_list_services), (bus_driver_remove_connection),
1459 (bus_driver_handle_message):
1461 Refactor code, put the message dispatching in its own file. Use
1462 _DBUS_HANDLE_OOM. Also send ServiceDeleted messages when a client
1465 2003-01-25 Anders Carlsson <andersca@codefactory.se>
1467 * dbus/dbus-internals.h:
1468 Add _DBUS_HANDLE_OOM macro, it doesn't do anything currently.
1470 * dbus/dbus-message.c: (dbus_message_get_sender):
1471 * dbus/dbus-message.h:
1472 Implement dbus_message_get_sender.
1474 * dbus/dbus-protocol.h:
1475 Add message and service defines.
1477 2003-01-25 Anders Carlsson <andersca@codefactory.se>
1479 * dbus/dbus-connection.c: (dbus_connection_send_message):
1480 * dbus/dbus-message-internal.h:
1481 * dbus/dbus-message.c: (_dbus_message_get_client_serial),
1482 (dbus_message_write_header):
1483 Remove _dbus_messag_unlock and don't set the client serial on a
1484 message if one already exists.
1486 2003-01-24 Havoc Pennington <hp@pobox.com>
1488 * dbus/dbus-list.c (alloc_link): put a thread lock on the global
1491 * bus/driver.c (bus_driver_handle_list_services): fix a leak
1494 2003-01-25 Anders Carlsson <andersca@codefactory.se>
1496 * dbus/dbus-list.c: (alloc_link), (free_link):
1497 Use a memory pool for the links.
1499 2003-01-25 Anders Carlsson <andersca@codefactory.se>
1501 * bus/connection.c: (bus_connection_foreach):
1503 Add new bus_connection_foreach function.
1505 * bus/driver.c: (send_one_message), (bus_driver_broadcast_message):
1506 Add function that broadcasts a message to all clients.
1508 (bus_driver_send_service_created), (bus_driver_handle_hello),
1509 (bus_driver_send_welcome_message),
1510 (bus_driver_handle_list_services), (bus_driver_message_handler):
1511 Implement functions that take care of listing services, and notifying
1512 clients when new services are created.
1514 * bus/services.c: (bus_services_list):
1516 Add new function that returns an array of strings with the currently
1517 registered services.
1520 * glib/dbus-gmain.c:
1521 Update copyright year.
1523 2003-01-25 Anders Carlsson <andersca@codefactory.se>
1525 * dbus/dbus-connection.c: (dbus_connection_send_message):
1526 Unlock the message in case it was sent earlier.
1528 (dbus_connection_send_message_with_reply_and_block):
1529 Remove the reply message from the list.
1531 * dbus/dbus-marshal.c: (_dbus_demarshal_string_array):
1532 Set array_len and new_pos correctly.
1534 (_dbus_marshal_test):
1535 Remove debug output.
1537 * dbus/dbus-message-internal.h:
1538 * dbus/dbus-message.c: (_dbus_message_get_reply_serial):
1539 New function that returns the reply serial.
1541 (_dbus_message_unlock):
1542 New function that unlocks a message and resets its header.
1544 (dbus_message_append_string_array),
1545 (dbus_message_get_fields_valist),
1546 (dbus_message_iter_get_field_type),
1547 (dbus_message_iter_get_string_array),
1548 (dbus_message_get_fields),
1549 (dbus_message_append_fields_valist):
1550 Handle string arrays.
1552 (dbus_message_set_sender):
1553 Make this function public since the bus daemon needs it.
1555 (decode_header_data):
1556 Set the reply serial to -1 initially.
1558 * dbus/dbus-message.h:
1559 Add dbus_message_set_sender.
1561 2003-01-24 Havoc Pennington <hp@pobox.com>
1563 * doc/dbus-specification.sgml: add some stuff
1565 2003-01-22 Havoc Pennington <hp@pobox.com>
1567 * doc/dbus-specification.sgml: Start to document the protocol.
1569 2003-01-22 Havoc Pennington <hp@pobox.com>
1571 * dbus/dbus-connection.c
1572 (dbus_connection_send_message_with_reply_and_block): add some @todo
1574 * bus/driver.c (bus_driver_add_connection): add a FIXME about memleak
1576 2003-01-21 Havoc Pennington <hp@pobox.com>
1578 (patch untested because can't compile)
1580 * bus/driver.c (create_unique_client_name): make this function
1581 never recycle client names. Also, caller should initialize
1584 * dbus/dbus-sysdeps.c (_dbus_get_current_time): new function
1586 2003-01-21 Anders Carlsson <andersca@codefactory.se>
1588 * dbus/dbus-marshal.c: (_dbus_marshal_double),
1589 (_dbus_marshal_int32), (_dbus_marshal_uint32),
1590 (_dbus_marshal_int32_array), (_dbus_marshal_uint32_array),
1591 (_dbus_marshal_double_array), (_dbus_marshal_string_array),
1592 (_dbus_demarshal_int32_array), (_dbus_demarshal_uint32_array),
1593 (_dbus_demarshal_double_array), (_dbus_demarshal_string_array),
1594 (_dbus_marshal_get_field_end_pos), (_dbus_marshal_test):
1595 * dbus/dbus-marshal.h:
1596 * dbus/dbus-protocol.h:
1597 Add support for marshalling and demarshalling integer, double
1600 2003-01-21 Anders Carlsson <andersca@codefactory.se>
1605 * bus/connection.c: (connection_disconnect_handler):
1606 Remove the connection from the bus driver's list.
1608 (connection_watch_callback): Dispatch messages.
1610 (free_connection_data): Free connection name.
1612 (bus_connection_setup): Add connection to the bus driver's list.
1613 (bus_connection_remove_owned_service):
1614 (bus_connection_set_name), (bus_connection_get_name):
1615 Add functions for setting and getting the connection's name.
1618 Add function headers.
1620 * bus/driver.c: (create_unique_client_name),
1621 (bus_driver_handle_hello_message),
1622 (bus_driver_send_welcome_message), (bus_driver_message_handler),
1623 (bus_driver_add_connection), (bus_driver_remove_connection):
1626 * bus/services.c: (bus_service_free):
1628 New file that handles communication and registreation with the bus
1631 2003-01-21 Anders Carlsson <andersca@codefactory.se>
1633 * dbus/dbus-connection.c: (dbus_connection_send_message):
1634 Add a new client_serial parameter.
1636 (dbus_connection_send_message_with_reply):
1637 Remove a @todo since we've implemented the blocking function.
1639 (dbus_connection_send_message_with_reply_and_block):
1640 New function that sends a message and waits for a reply and
1641 then returns the reply.
1643 * dbus/dbus-connection.h:
1646 * dbus/dbus-errors.c: (dbus_result_to_string):
1647 * dbus/dbus-errors.h:
1648 Add new DBUS_RESULT.
1650 * dbus/dbus-message-internal.h:
1651 * dbus/dbus-message.c: (_dbus_message_get_reply_serial),
1652 (_dbus_message_set_sender), (dbus_message_write_header),
1653 (dbus_message_new_reply), (decode_header_data),
1654 (_dbus_message_loader_return_buffer), (_dbus_message_test):
1655 * dbus/dbus-message.h:
1656 Add new functions that set the reply serial and sender.
1657 Also marshal and demarshal them correctly and add test.
1659 * dbus/dbus-protocol.h:
1660 Add new DBUS_MESSAGE_TYPE_SENDER.
1663 * glib/dbus-gmain.c: (watch_callback), (free_callback_data),
1664 (add_watch), (remove_watch), (add_timeout), (remove_timeout),
1665 (dbus_connection_hookup_with_g_main):
1666 * glib/test-dbus-glib.c: (main):
1667 Rewrite to use GIOChannel and remove the GSource crack.
1669 * test/echo-client.c: (main):
1670 * test/watch.c: (check_messages):
1671 Update for changed APIs
1673 2003-01-19 Anders Carlsson <andersca@codefactory.se>
1675 * dbus/Makefile.am: Add dbus-timeout.[cħ]
1677 * dbus/dbus-connection.c: (_dbus_connection_new_for_transport):
1678 Create a DBusTimeoutList.
1679 (dbus_connection_set_timeout_functions): Add new function to
1680 set timeout callbacks
1682 * dbus/dbus-connection.h: Add public DBusTimeout API.
1684 * dbus/dbus-message.c: (dbus_message_get_service):
1685 * dbus/dbus-message.h: New function.
1687 * dbus/dbus-server.c: Fix small doc typo.
1689 * dbus/dbus-timeout.[ch]: New files for mainloop timeouts.
1691 2003-01-19 Anders Carlsson <andersca@codefactory.se>
1693 * dbus/dbus-string.c (_dbus_string_move_len): Don't delete all
1694 of the string, just as long as specified.
1696 2003-01-19 Havoc Pennington <hp@pobox.com>
1698 * dbus/dbus-connection.c (dbus_connection_get_is_authenticated):
1701 * dbus/dbus-server.c (dbus_server_set_max_connections)
1702 (dbus_server_get_max_connections, dbus_server_get_n_connections):
1703 keep track of current number of connections, and add API for
1704 setting a max (but haven't implemented enforcing the max yet)
1706 2003-01-18 Havoc Pennington <hp@pobox.com>
1708 * dbus/dbus-transport-unix.c (unix_do_iteration): only do the
1709 reading/writing if read_watch != NULL or write_watch != NULL.
1711 * dbus/dbus-message.c (_dbus_message_loader_return_buffer): fix
1712 the message loader code to actually load message->header and
1713 message->body into the newly-created message.
1715 * dbus/dbus-transport-unix.c (check_write_watch): fix a mem leak
1718 * dbus/dbus-connection.c (dbus_connection_set_max_message_size)
1719 (dbus_connection_get_max_message_size)
1720 (dbus_connection_set_max_live_messages_size)
1721 (dbus_connection_get_max_live_messages_size): implement some
1722 resource limitation functions
1724 * dbus/dbus-resources.c: new file implementing some of the
1725 resource limits stuff
1727 * dbus/dbus-message.c (dbus_message_iter_get_byte_array): add
1728 missing docs, add @todo to handle OOM etc.
1730 * dbus/dbus-marshal.c (_dbus_demarshal_byte_array): add missing
1733 2003-01-18 Havoc Pennington <hp@pobox.com>
1735 * dbus/dbus-connection.c (dbus_connection_unref): disconnect the
1736 connection if it hasn't been already.
1738 * dbus/dbus-connection.h: kill off the idea of an ErrorFunction,
1739 replace with DisconnectFunction.
1741 2003-01-18 Havoc Pennington <hp@pobox.com>
1743 Building --disable-verbose-mode --disable-asserts --disable-tests
1744 cuts the library from 112K to 45K or so
1746 * configure.in: check for varargs macro support,
1747 add --enable-verbose-mode, --enable-asserts.
1749 * dbus/dbus-internals.h (_dbus_assert): support
1751 (_dbus_verbose): support DBUS_ENABLE_VERBOSE_MODE
1753 2003-01-18 Havoc Pennington <hp@pobox.com>
1755 * dbus/dbus-test.c: include config.h so that tests actually run
1757 * dbus/dbus-string.c: add assertions that stuff is 8-byte aligned,
1758 so the failure mode when that assumption fails will be plenty
1761 2003-01-18 Havoc Pennington <hp@pobox.com>
1763 * configure.in: default --enable-tests to $USE_MAINTAINER_MODE
1765 * dbus/Makefile.am: fix it up so dubs-test-main.c is included in
1768 * test/Makefile.am: don't use special variable "TESTS" for echo-*
1769 since we don't want to use those in make check
1771 2003-01-15 Havoc Pennington <hp@redhat.com>
1777 2003-01-15 Havoc Pennington <hp@redhat.com>
1779 * test/Makefile.am: fix so that test source code ends up in the
1780 distribution on make distcheck
1782 2003-01-15 Havoc Pennington <hp@redhat.com>
1788 2003-01-15 Havoc Pennington <hp@redhat.com>
1790 * dbus/dbus-test.c (dbus_internal_symbol_do_not_use_run_tests):
1791 fix build when --disable-tests
1793 * Makefile.am (EXTRA_DIST): put HACKING in here
1795 * HACKING: document procedure for making a tarball release.
1797 2003-01-14 Anders Carlsson <andersca@codefactory.se>
1799 * bus/connection.c: (connection_error_handler),
1800 (bus_connection_setup):
1801 * bus/main.c: (main):
1802 Make sure that the DBusConnectionData struct is NULLed
1803 out to prevent a segfault.
1805 * dbus/dbus-errors.c: (dbus_result_to_string):
1806 * dbus/dbus-errors.h:
1807 * dbus/dbus-message.c: (dbus_message_get_fields),
1808 (dbus_message_get_fields_valist), (_dbus_message_test):
1809 * dbus/dbus-message.h:
1810 Make dbus_message_get_fields return a result code so we can
1811 track invalid fields as well as oom.
1813 2003-01-11 Havoc Pennington <hp@pobox.com>
1815 * configure.in: change --enable-test/--enable-ansi action-if-given
1816 to enable_foo=$enableval instead of enable_foo=yes
1818 2003-01-08 Havoc Pennington <hp@pobox.com>
1820 * dbus/dbus-string.c (_dbus_string_align_length): new function
1822 * dbus/dbus-test-main.c: move main() for test app here
1824 (dbus_internal_symbol_do_not_use_run_tests): we have to export a
1825 symbol to run tests, because dbus-test isn't in the main
1828 Code review nitpicks.
1830 * dbus/dbus-message.c (dbus_message_write_header): add newlines
1831 for people with narrow emacs ;-). Assert client_serial was filled
1832 in. Assert message->name != NULL.
1833 (dbus_message_append_fields): have "first_field_type" arg separate
1834 from va list, needed for C++ binding that also uses varargs IIRC
1835 and helps with type safety
1836 (dbus_message_new): add @todo about using DBusString to store
1837 service/name internally
1838 (dbus_message_new): don't leak ->service and ->name on OOM later
1840 (dbus_message_unref): free the service name
1841 (dbus_message_get_fields): same change to varargs
1842 i.e. first_field_type
1843 (_dbus_message_loader_return_buffer): assert that the message data
1844 is aligned (if not it's a bug in our code). Put in verbose griping
1845 about why we set corrupted = TRUE.
1846 (decode_header_data): add FIXME that char* is evil. Was going to
1847 add FIXME about evil locale-specific string.h strncmp, but just
1848 switched to wacky string-as-uint32 optimization. Move check for
1849 "no room for field name" above get_const_data_len() to avoid
1850 assertion failure in get_const_data_len if we have trailing 2
1851 bytes or the like. Check for service and name fields being
1852 provided twice. Don't leak service/name on error. Require field
1853 names to be aligned to 4 bytes.
1855 * dbus/dbus-marshal.c: move byte swap stuff to header
1856 (_dbus_pack_int32): uscore-prefix
1857 (_dbus_unpack_int32): uscore-prefix
1858 (_dbus_unpack_uint32): export
1859 (_dbus_demarshal_string): add @todo complaining about use of
1861 (_dbus_marshal_get_field_end_pos): add @todo about bad error
1862 handling allowing corrupt data to go unchecked
1864 2003-01-08 Havoc Pennington <hp@redhat.com>
1866 * dbus/dbus-transport-unix.c (unix_do_iteration): add read/write
1867 to the select() as needed for authentication. (should be using
1868 _dbus_poll() not select, but for another day)
1870 * dbus/dbus.h: include dbus/dbus-protocol.h
1872 2003-01-08 Anders Carlsson <andersca@codefactory.se>
1874 * dbus/Makefile.am (dbusinclude_HEADERS): Install
1877 2003-01-08 Anders Carlsson <andersca@codefactory.se>
1879 * dbus/dbus-internals.c: (_dbus_type_to_string):
1880 New function that returns a string describing a type.
1882 * dbus/dbus-marshal.c: (_dbus_demarshal_byte_array):
1883 * dbus/dbus-marshal.h:
1884 * dbus/dbus-message.c: (dbus_message_get_fields_valist),
1885 (dbus_message_iter_get_field_type), (dbus_message_iter_get_double),
1886 (dbus_message_iter_get_byte_array):
1887 * dbus/dbus-message.h:
1888 Add new convenience functions for appending and getting message fields.
1889 Also add demarshalling routines for byte arrays.
1891 2003-01-07 Anders Carlsson <andersca@codefactory.se>
1893 * dbus/dbus-connection-internal.h:
1894 * dbus/dbus-connection.c: (_dbus_connection_new_for_transport),
1895 (_dbus_connection_get_next_client_serial),
1896 (dbus_connection_send_message):
1897 * dbus/dbus-internals.h:
1898 * dbus/dbus-marshal.c: (unpack_uint32), (dbus_unpack_int32),
1899 (dbus_pack_int32), (_dbus_marshal_double), (_dbus_marshal_int32),
1900 (_dbus_marshal_uint32), (_dbus_demarshal_double),
1901 (_dbus_demarshal_int32), (_dbus_demarshal_uint32),
1902 (_dbus_demarshal_string), (_dbus_marshal_get_field_end_pos),
1903 (_dbus_verbose_bytes), (_dbus_marshal_test):
1904 * dbus/dbus-marshal.h:
1905 * dbus/dbus-message-internal.h:
1906 * dbus/dbus-message.c: (_dbus_message_set_client_serial),
1907 (dbus_message_write_header), (_dbus_message_lock),
1908 (dbus_message_new), (dbus_message_ref), (dbus_message_unref),
1909 (dbus_message_get_name), (dbus_message_append_int32),
1910 (dbus_message_append_uint32), (dbus_message_append_double),
1911 (dbus_message_append_string), (dbus_message_append_byte_array),
1912 (dbus_message_get_fields_iter), (dbus_message_iter_ref),
1913 (dbus_message_iter_unref), (dbus_message_iter_has_next),
1914 (dbus_message_iter_next), (dbus_message_iter_get_field_type),
1915 (dbus_message_iter_get_string), (dbus_message_iter_get_int32),
1916 (dbus_message_iter_get_uint32), (dbus_message_iter_get_double),
1917 (decode_header_data), (_dbus_message_loader_return_buffer),
1918 (message_iter_test), (_dbus_message_test):
1919 * dbus/dbus-message.h:
1920 * dbus/dbus-protocol.h:
1921 * dbus/dbus-test.c: (main):
1923 * glib/test-dbus-glib.c: (message_handler), (main):
1924 * test/echo-client.c: (main):
1925 * test/watch.c: (check_messages):
1926 Make messages sendable and receivable for real.
1928 2003-01-07 Anders Carlsson <andersca@codefactory.se>
1930 * dbus/dbus-marshal.c: (_dbus_marshal_double),
1931 (_dbus_marshal_string), (_dbus_marshal_byte_array):
1932 * dbus/dbus-message.c: (dbus_message_append_int32),
1933 (dbus_message_append_uint32), (dbus_message_append_double),
1934 (dbus_message_append_string), (dbus_message_append_byte_array):
1935 Handle OOM restoration.
1937 2003-01-07 Anders Carlsson <andersca@codefactory.se>
1939 * dbus/dbus-marshal.c: (_dbus_marshal_string),
1940 (_dbus_demarshal_string), (_dbus_marshal_test):
1941 * dbus/dbus-marshal.h:
1942 * dbus/dbus-message.c: (dbus_message_get_name),
1943 Document these functions.
1945 (dbus_message_append_int32), (dbus_message_append_uint32),
1946 (dbus_message_append_double), (dbus_message_append_string),
1947 (dbus_message_append_byte_array):
1948 * dbus/dbus-message.h:
1949 Add functions for adding message fields of different types.
1951 * dbus/dbus-protocol.h:
1952 Add the different types.
1954 2003-01-05 Havoc Pennington <hp@pobox.com>
1956 * bus/connection.c: implement routines for handling connections,
1957 first thing is keeping a list of owned services on each connection
1958 and setting up watches etc.
1960 * bus/services.c: implement a mapping from service names to lists
1963 * dbus/dbus-hash.c: add DBUS_HASH_POINTER
1965 * dbus/dbus-threads.c (dbus_static_mutex_lock): add functions
1966 to use static mutexes for global data
1968 * dbus/dbus-connection.c (dbus_connection_set_data): add new
1969 collection of functions to set/get application-specific data
1970 on the DBusConnection.
1972 2003-01-04 Havoc Pennington <hp@pobox.com>
1974 * dbus/dbus-sysdeps.c (_dbus_sleep_milliseconds): new function
1975 (_dbus_poll): new function
1977 * dbus/dbus-internals.h (_DBUS_STRUCT_OFFSET): new macro
1980 * bus/loop.c: initial code for the daemon main loop
1982 2003-01-04 Havoc Pennington <hp@pobox.com>
1984 * test/watch.c (error_handler): make it safe if the error handler
1985 is called multiple times (if we s/error handler/disconnect
1986 handler/ we should just guarantee it's called only once)
1988 * dbus/dbus-transport.c (_dbus_transport_disconnect): call the
1989 error handler on disconnect (it's quite possible we should
1990 just change the error handler to a "disconnect handler," I'm
1991 not sure we have any other meaningful errors)
1993 * configure.in: check for getpwnam_r
1995 * dbus/dbus-transport.c, dbus/dbus-transport-unix.c,
1996 dbus/dbus-auth.c: add credentials support, add EXTERNAL auth
1997 mechanism as in SASL spec, using socket credentials
1999 * dbus/dbus-sysdeps.c (_dbus_read_credentials_unix_socket): new function
2000 (_dbus_send_credentials_unix_socket): new function
2002 * dbus/dbus-sysdeps.c (_dbus_accept_unix_socket): rename just
2004 (_dbus_write): only check errno if <0 returned
2005 (_dbus_write_two): ditto
2007 2003-01-02 Anders Carlsson <andersca@codefactory.se>
2009 * dbus/dbus-marshal.c: (_dbus_marshal_utf8_string),
2010 (_dbus_marshal_byte_array), (_dbus_demarshal_utf8_string),
2011 (_dbus_marshal_test):
2012 * dbus/dbus-marshal.h:
2013 Add _dbus_marshal_byte_array and rename _dbus_marshal_string
2014 to _dbus_marshal_utf8_string. Also fix some tests.
2016 2002-12-28 Harri Porten <porten@kde.org>
2018 * configure.in: added check for C++ compiler and a very cheesy
2019 check for the Qt integration
2021 * Makefile.am (SUBDIRS): compile qt subdir if support is enabled
2023 * qt/Makefile.am: added
2025 * qt/.cvsignore: added
2027 * qt/dbus-qthread.cc, qt/dbus-qthread.cpp: renamed former to
2028 latter, added #ifdef QT_THREAD_SUPPORT guard.
2030 * dbus/Makefile.am: added missing headers for make dist
2032 2002-12-28 Kristian Rietveld <kris@gtk.org>
2034 * dbus/Makefile.am: fixup export-symbols-regex.
2036 2002-12-27 Anders Carlsson <andersca@codefactory.se>
2038 * acinclude.m4: Add this file and put the
2039 PKG_CHECK_MODULE macro in it.
2041 2002-12-27 Anders Carlsson <andersca@codefactory.se>
2043 * dbus/dbus-marshal.c: (_dbus_marshal_string),
2044 (_dbus_demarshal_double), (_dbus_demarshal_int32),
2045 (_dbus_demarshal_uint32), (_dbus_demarshal_string),
2046 (_dbus_marshal_test):
2047 Make the demarshalling routines align the pos argument.
2048 Add string marshalling tests and fix the obvious bugs
2051 2002-12-26 Havoc Pennington <hp@pobox.com>
2053 * dbus/dbus-auth.c: fixes fixes fixes
2055 * dbus/dbus-transport-unix.c: wire up support for
2056 encoding/decoding data on the wire
2058 * dbus/dbus-auth.c (_dbus_auth_encode_data)
2059 (_dbus_auth_decode_data): append to target string
2060 instead of nuking it.
2062 2002-12-26 Havoc Pennington <hp@pobox.com>
2064 * dbus/dbus-marshal.h (DBUS_COMPILER_BYTE_ORDER): #ifdef
2065 WORDS_BIGENDIAN then compiler byte order is DBUS_BIG_ENDIAN,
2068 * dbus/dbus-marshal.c: Add macros to do int swapping in-place and
2069 avoid swap_bytes() overhead (ignoring possible assembly stuff for
2070 now). Main point is because I wanted unpack_uint32 to implement
2072 (_dbus_verbose_bytes): new function
2074 * dbus/dbus-string.c (_dbus_string_validate_ascii): new function
2076 * dbus/dbus-message.c (_dbus_message_loader_get_is_corrupted): add
2077 mechanism to handle a corrupt message stream
2078 (_dbus_message_loader_new): fix preallocation to only prealloc,
2081 * dbus/dbus-string.c (_dbus_string_skip_blank): fix this function
2082 (_dbus_string_test): enhance tests for copy/move and fix the
2085 * dbus/dbus-transport-unix.c: Hold references in more places to
2086 avoid reentrancy problems
2088 * dbus/dbus-transport.c: ditto
2090 * dbus/dbus-connection.c (dbus_connection_dispatch_message): don't
2091 leak reference count in no-message case
2093 * test/watch.c (do_mainloop): handle adding/removing watches
2094 during iteration over the watches. Also, ref the connection/server
2095 stored on a watch, so we don't try to mangle a destroyed one.
2097 * dbus/dbus-transport-unix.c (do_authentication): perform
2100 * dbus/dbus-auth.c (get_state): add a state
2101 AUTHENTICATED_WITH_UNUSED_BYTES and return it if required
2102 (_dbus_auth_get_unused_bytes): append the unused bytes
2103 to the passed in string, rather than prepend
2105 * dbus/dbus-transport.c (_dbus_transport_init_base): create
2106 the auth conversation DBusAuth
2108 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_fd)
2109 (_dbus_transport_new_for_domain_socket): when creating a
2110 transport, pass in whether it's a client-side or server-side
2111 transport so we know which DBusAuth to create
2113 2002-12-03 Havoc Pennington <hp@pobox.com>
2115 * dbus/dbus-transport-unix.c (unix_finalize): finalize base
2116 _after_ finalizing the derived members
2117 (unix_connection_set): unref watch if we fail to add it
2119 * dbus/dbus-connection.c (dbus_connection_unref): delete the
2120 transport first, so that the connection owned by the
2121 transport will be valid as the transport finalizes.
2123 * dbus/dbus-transport-unix.c (unix_finalize): free the write_watch
2124 if necessary, and remove watches from the connection.
2126 * dbus/dbus-watch.c (_dbus_watch_list_free): improve a comment
2128 2002-12-26 Anders Carlsson <andersca@codefactory.se>
2130 * dbus/dbus-marshal.c: (_dbus_marshal_string),
2131 (_dbus_demarshal_double), (_dbus_demarshal_int32),
2132 (_dbus_demarshal_uint32), (_dbus_demarshal_string),
2133 (_dbus_marshal_test):
2134 * dbus/dbus-marshal.h:
2135 Add string marshal functions and have the demarshal functions
2136 return the new position.
2138 2002-12-25 Havoc Pennington <hp@pobox.com>
2140 * doc/dbus-sasl-profile.txt: docs on the authentication protocol,
2141 it is a simple protocol that just maps directly to SASL.
2143 * dbus/dbus-auth.h, dbus/dbus-auth.c: authentication protocol
2144 initial implementation, not actually used yet.
2146 * dbus/dbus-string.c (_dbus_string_find): new function
2147 (_dbus_string_equal): new function
2148 (_dbus_string_base64_encode): new function
2149 (_dbus_string_base64_decode): new function
2151 2002-12-25 Anders Carlsson <andersca@codefactory.se>
2154 * dbus/dbus-marshal.c: (swap_bytes), (_dbus_marshal_double),
2155 (_dbus_marshal_int32), (_dbus_marshal_uint32),
2156 (_dbus_demarshal_double), (_dbus_demarshal_int32),
2157 (_dbus_demarshal_uint32), (_dbus_marshal_test):
2158 * dbus/dbus-marshal.h:
2159 * dbus/dbus-protocol.h:
2160 * dbus/dbus-test.c: (main):
2162 Add un-optimized marshalling/demarshalling routines.
2164 2002-12-25 Harri Porten <porten@kde.org>
2166 * qt/dbus-qt.h: adjusted ctor and getter to KDE/Qt conventions
2168 2002-12-24 Zack Rusin <zack@kde.org>
2170 * qt/dbus-qthread.cc: adding - integrates QMutex into Dbus
2171 * qt/dbus-qt.h: skeleton with two sample implemenatation of the
2174 2002-12-24 Havoc Pennington <hp@pobox.com>
2176 * glib/dbus-gthread.c: fix include
2178 * glib/dbus-glib.h: rename DBusMessageHandler for now.
2179 I think glib API needs to change, though, as you don't
2180 want to use DBusMessageFunction, you want to use the
2181 DBusMessageHandler object. Probably
2182 dbus_connection_open_with_g_main_loop()
2183 and dbus_connection_setup_g_main_loop() or something like that
2184 (but think of better names...) that just create a connection
2185 that has watch/timeout functions etc. already set up.
2187 * dbus/dbus-connection.c
2188 (dbus_connection_send_message_with_reply): new function just to
2189 show how the message handler helps us deal with replies.
2191 * dbus/dbus-list.c (_dbus_list_remove_last): new function
2193 * dbus/dbus-string.c (_dbus_string_test): free a string that
2196 * dbus/dbus-hash.c: use memory pools for the hash entries
2197 (rebuild_table): be more paranoid about overflow, and
2198 shrink table when we can
2199 (_dbus_hash_test): reduce number of sprintfs and write
2200 valid C89. Add tests for case where we grow and then
2201 shrink the hash table.
2203 * dbus/dbus-mempool.h, dbus/dbus-mempool.c: memory pools
2205 * dbus/dbus-connection.c (dbus_connection_register_handler)
2206 (dbus_connection_unregister_handler): new functions
2208 * dbus/dbus-message.c (dbus_message_get_name): new
2210 * dbus/dbus-list.c: fix docs typo
2212 * dbus/dbus-message-handler.h, dbus/dbus-message-handler.c:
2213 an object representing a handler for messages.
2215 2002-12-16 Anders Carlsson <andersca@codefactory.se>
2218 * glib/dbus-gthread.c: (dbus_gthread_init):
2219 Don't use the gdbus prefix for public functions.
2221 2002-12-16 Anders Carlsson <andersca@codefactory.se>
2225 Add GLib checks and fixup .pc files
2229 * glib/dbus-gmain.c: (gdbus_connection_prepare),
2230 (gdbus_connection_check), (gdbus_connection_dispatch),
2231 (gdbus_add_connection_watch), (gdbus_remove_connection_watch),
2232 (dbus_connection_gsource_new):
2233 * glib/dbus-gthread.c: (dbus_gmutex_new), (dbus_gmutex_free),
2234 (dbus_gmutex_lock), (dbus_gmutex_unlock), (dbus_gthread_init):
2235 * glib/test-dbus-glib.c: (message_handler), (main):
2238 2002-12-15 Harri Porten <porten@kde.org>
2240 * autogen.sh: check for libtoolize before attempting to use it
2242 * dbus/dbus-transport-unix.c: include <sys/time.h> for timeval
2245 * .cvsignore: ignore more stamp files
2247 * dbus/dbus-watch.c (_dbus_watch_list_new): fixed doc error
2249 * test/Makefile.am: added -I$(top_srcdir) to be able to compile
2250 without make install.
2252 2002-12-15 Havoc Pennington <hp@pobox.com>
2254 * dbus/dbus-threads.c: add thread stubs that a higher library
2255 layer can fill in. e.g. the GLib wrapper might fill them in with
2256 GThread stuff. We still need to use this thread API to
2257 thread-safe-ize the library.
2259 2002-12-12 Havoc Pennington <hp@pobox.com>
2261 * dbus/dbus-transport-unix.c, dbus/dbus-server-unix.c: use the
2262 below new interfaces and include fewer system headers.
2264 * dbus/dbus-sysdeps.c (_dbus_read): new function
2265 (_dbus_write): new function
2266 (_dbus_write_two): new function
2267 (_dbus_connect_unix_socket): new function
2268 (_dbus_listen_unix_socket): new function
2270 * dbus/dbus-message-internal.h: change interfaces to use
2273 2002-12-11 Havoc Pennington <hp@pobox.com>
2275 * dbus/dbus-types.h: add dbus_unichar
2277 * dbus/dbus-internals.c (_dbus_verbose): use _dbus_getenv
2279 * dbus/dbus-connection.c (dbus_connection_send_message): return
2282 * dbus/dbus-transport.c: include dbus-watch.h
2284 * dbus/dbus-connection.c: include dbus-message-internal.h
2286 * HACKING: add file with coding guidelines stuff.
2288 * dbus/dbus-string.h, dbus/dbus-string.c: Encapsulate all string
2289 handling here, for security purposes (as in vsftpd). Not actually
2290 using this class yet.
2292 * dbus/dbus-sysdeps.h, dbus/dbus-sysdeps.c: Encapsulate all
2293 system/libc usage here, as in vsftpd, for ease of auditing (and
2294 should also simplify portability). Haven't actually moved all the
2295 system/libc usage into here yet.
2297 2002-11-25 Havoc Pennington <hp@pobox.com>
2299 * dbus/dbus-internals.c (_dbus_verbose): fix to not
2300 always print the first verbose message.
2302 2002-11-24 Havoc Pennington <hp@pobox.com>
2304 * test/echo-client.c, test/echo-server.c: cheesy test
2307 * configure.in (AC_CHECK_FUNCS): check for writev
2309 * dbus/dbus-message.c (_dbus_message_get_network_data): new
2312 * dbus/dbus-list.c (_dbus_list_foreach): new function
2314 * dbus/dbus-internals.c (_dbus_verbose): new function
2316 * dbus/dbus-server.c, dbus/dbus-server.h: public object
2317 representing a server that listens for connections.
2319 * dbus/.cvsignore: create
2321 * dbus/dbus-errors.h, dbus/dbus-errors.c:
2322 public API for reporting errors
2324 * dbus/dbus-connection.h, dbus/dbus-connection.c:
2325 public object representing a connection that
2326 sends/receives messages. (Same object used for
2327 both client and server.)
2329 * dbus/dbus-transport.h, dbus/dbus-transport.c:
2330 Basic abstraction for different kinds of stream
2331 that we might read/write messages from.
2333 2002-11-23 Havoc Pennington <hp@pobox.com>
2335 * dbus/dbus-internals.h (_DBUS_INT_MAX): add _DBUS_INT_MIN
2338 * dbus/dbus-test.c (main): add list test, and include
2339 dbus-test.h as intended
2341 * dbus/dbus-hash.c (_dbus_hash_table_remove_string)
2342 (_dbus_hash_table_remove_int): return value indicates
2343 whether the entry existed to remove
2345 * dbus/dbus-list.c: add linked list utility class,
2348 * dbus/dbus-hash.c: add TODO item about shrinking the hash bucket
2351 2002-11-23 Havoc Pennington <hp@pobox.com>
2353 * Doxyfile.in (INCLUDE_FILE_PATTERNS): expand DBUS_BEGIN_DECLS/
2354 DBUS_END_DECLS to nothing, that should fix this once and for all
2356 * Doxyfile.in (JAVADOC_AUTOBRIEF): set to YES
2358 * dbus/dbus-message.c, dbus/dbus-hash.c:
2359 add some missing @brief
2361 2002-11-23 Havoc Pennington <hp@pobox.com>
2363 * dbus/dbus-message.h: put semicolons after DEBUG_BEGIN_DECLS
2364 to avoid confusing Doxygen
2366 * dbus/dbus-hash.c: @} not }@
2368 * dbus/dbus-message.c (struct DBusMessage): split out
2371 2002-11-23 Havoc Pennington <hp@pobox.com>
2373 * configure.in: pile on more warning flags if using gcc
2375 * Doxyfile.in (EXTRACT_STATIC): set to NO, so we don't have
2376 to document static functions
2378 * configure.in: add summary to end of configure so it
2379 looks nice and attractive
2381 * dbus/dbus-hash.c: finish implementation and write unit
2384 * configure.in: add --enable-tests to enable unit tests
2386 * dbus/dbus-test.c: test program to run unit tests
2387 for all files in dbus/*, initially runs a test for
2390 * dbus/dbus-internals.h: file to hold some internal utility stuff
2392 2002-11-22 Havoc Pennington <hp@redhat.com>
2394 * dbus/dbus-hash.c: copy in Tcl hash table, not yet
2395 "ported" away from Tcl
2397 * dbus/dbus-types.h: header for types such as dbus_bool_t
2399 2002-11-22 Havoc Pennington <hp@redhat.com>
2401 * dbus/dbus.h: fixups for doc warnings
2403 * Doxyfile.in (FILE_PATTERNS): we need to scan .h to pick up
2405 (QUIET): make it quiet so we can see warnings
2407 * dbus/dbus-memory.c: teach D-BUS to allocate and free memory
2409 2002-11-22 Havoc Pennington <hp@redhat.com>
2411 * Makefile.am: include "Doxyfile" target in all-local
2413 * configure.in: generate the Doxyfile
2415 * Doxyfile.in: move Doxyfile here, so we can use
2416 configure to generate a Doxyfile with the right
2419 2002-11-22 Havoc Pennington <hp@redhat.com>
2421 * dbus/dbus-message.c: move inline docs into .c file
2423 * Doxyfile (OUTPUT_DIRECTORY): move output to doc/api
2424 so all docs are under doc/
2425 (MAN_EXTENSION): generate man pages. Use extension
2426 ".3dbus" which matches ".3qt" on my system,
2427 I guess this is OK, I don't know really.
2428 (FILE_PATTERNS): look for .c files not .h, makes sense
2431 2002-11-22 Havoc Pennington <hp@pobox.com>
2433 * Makefile.am (SUBDIRS): rename subdir "server" to "bus"
2434 because any app can be a server, and any app can be a client,
2435 the bus is a special kind of server.
2437 Thu Nov 21 23:35:31 2002 Zack Rusin <zack@kde.org>
2439 * Doxyfile : adding. Still needs Makefile rules to be generated
2440 automatically (just run "doxygen" in the toplevel dir for now to
2443 * dbus/dbus-message.h : Adding sample docs (javadoc since
2444 resembles gtk-doc a little more)
2446 * dbus/dbus.h : Adding sample docs
2448 2002-11-21 Havoc Pennington <hp@redhat.com>
2450 * dbus/Makefile.am (INCLUDES): define DBUS_COMPILATION
2451 so we can allow ourselves to include files directly,
2452 instead of having to use dbus.h
2454 * dbus/dbus.h: fill in
2456 * dbus/dbus-message.h: sketch out a sample header file.
2457 Include griping if you include it directly instead of
2460 * dbus/dbus-macros.h: new file with macros for extern "C",
2461 TRUE/FALSE, NULL, etc.
2463 * doc/file-boilerplate.c: put include guards in here
2465 2002-11-21 Havoc Pennington <hp@redhat.com>
2467 * doc/file-boilerplate.c: include both AFL and GPL boilerplate.
2469 * COPYING: include the GPL as well, and license code
2470 under both AFL and GPL.
2472 2002-11-21 Havoc Pennington <hp@redhat.com>
2474 * acconfig.h: get rid of this
2476 * autogen.sh (run_configure): add --no-configure option
2478 * configure.in: remove AC_ARG_PROGRAM to make
2479 autoconf complain less. add AC_PREREQ.
2480 add AC_DEFINE third arg.
2482 2002-11-21 Anders Carlsson <andersca@codefactory.se>
2485 Fix references so we can distcheck.
2487 2002-11-21 Havoc Pennington <hp@redhat.com>
2489 * Initial module creation