1 2006-07-25 Jim Meyering <jim@meyering.net>
3 * src/ls.c (gobble_file): Make it so failure to stat a
4 non-command-line file provokes an exit status of 1, not 0.
5 Say "cannot access" rather than "cannot stat".
6 * tests/ls/stat-failed: New file/test, for the above.
7 * tests/ls/Makefile.am (TESTS): Add stat-failed.
9 * src/ls.c: Declare stat_failed to be "bool", not "int" everywhere.
11 * src/ls.c [enum filetype] (command_line): Remove member. Not needed.
12 Replace all occurrences of "type == command_line" with the
13 equivalent, "command_line_arg".
15 * src/ls.c: Apply the stat-failed parts of Red Hat's
16 coreutils-selinux.patch. From Ulrich Drepper.
17 This makes it so files not mentioned on the command line (e.g.,
18 names read from a directory that *is* mentioned on the command
19 line) for which stat fails are still listed. With --color,
20 such files are colored just like ORPHANs (aka dangling symlinks).
22 * src/df.c (n_valid_args): Declare global to be static.
24 2006-07-24 Jim Meyering <jim@meyering.net>
26 * tests/ls/stat-dtype: Skip this test on reiserfs, since that file
27 system lacks d_type support.
29 2006-07-22 Paul Eggert <eggert@cs.ucla.edu>
31 * man/chmod.x: Update to reflect recent changes to coreutils.texi.
33 2006-07-21 Jim Meyering <jim@meyering.net>
35 * src/su.c (usage): Correct typo in --help output: s/commmand/command/
36 Reported by Tim Waugh.
37 Also remove the comment duplicating much of --help output.
39 * src/ls.c (FILE_TYPE_INDICATOR_OPTION): Reposition this new
40 name so the list remains alphabetized.
42 Fix another bug: ls --indicator-style=file-type would call
43 stat for a symlink, even though it wasn't always needed.
44 In some cases, that unnecessary stat would cause ls to fail.
45 * src/ls.c (gobble_file): Don't treat symlinks specially (in
46 requiring a stat syscall). Remove the offending exclusion.
48 * NEWS: Mention the fix.
50 * tests/ls/stat-dtype: New file/test, for the above fix.
51 Also exercises the new df feature, below.
53 * src/df.c (main): Fail and don't print the headers if no
54 file system is processed. This makes it easy to test whether
55 a specified directory is on a file system of a given type or types.
56 Otherwise, applications would have had to parse df's output.
57 E.g., is "." either ext3 or reiserfs: df -t ext3 -t reiserfs .
59 Fix a bug: ls --file-type worked like --indicator-style=slash,
60 rather than like --indicator-style=file-type.
61 * src/ls.c (FILE_TYPE_INDICATOR_OPTION): New enum member.
62 (long_options): Map "file-type" to FILE_TYPE_INDICATOR_OPTION,
64 (decode_switches): Handle new case: FILE_TYPE_INDICATOR_OPTION.
65 * NEWS: Mention the fix.
66 * tests/ls-2/tests (file-type): New test, for the above fix.
68 2006-07-19 Jim Meyering <jim@meyering.net>
70 * src/ls.c (print_dir): Give a better diagnostic for failed opendir.
72 * Makefile.am (EXTRA_DIST): Add build-aux/vc-list-files.
74 2006-07-16 Paul Eggert <eggert@cs.ucla.edu>
76 * NEWS: chmod, install, and mkdir now leave setgid and setuid bits
77 of directories alone unless you specify them explicitly.
78 install and mkdir now implement X correctly.
79 install now creates parent directories with mode 755, without
80 changing their owner or group.
81 * src/chmod.c (process_file): Adjust to mode_adjust API change.
82 * src/install.c: Include mkancesdirs.h.
83 (announce_mkdir, make_ancestor): New functions.
84 (DEFAULT_MODE): New macro, specifying initial value of 'mode'.
86 (dir_mode, dir_mode_bits): New vars.
87 (main): Set dir modes separately from nondir, so that the X
88 op of -m works correctly.
89 (main): Remove cwd_errno cruft, since make_dir_parents no longer
90 affects cwd. Adjust to new make_dir_parents API.
91 (install_file_in_file_parents): 2nd arg is now char *, not char
92 const *. Use mkancesdirs instead of rolling our own code.
93 (change_attributes): Don't worry about AFS, since that kludge
94 should not be needed any more.
95 * src/mkdir.c (struct mkdir_options): New struct.
96 (announce_mkdir, make_ancestor): New functions.
97 (main): Use them. Adjust to mode_adjust API change. Stick with
98 umask 0. Use make_dir_parents for all the work.
99 * src/mkfifo.c (main): Adjust to new mode_adjust API.
100 * src/mknod.c (main): Likewise.
101 * tests/chmod/setgid: Do the setgid test instead of bailing.
102 * tests/mkdir/p-3: Remove re_protect case that no longer applies.
103 GNU chmod now behaves like other versions of chmod.
104 * tests/mkdir/perm: Add a test for the X bug.
106 2006-07-14 Paul Eggert <eggert@cs.ucla.edu>
108 * src/base64.c (do_decode): Output to parameter OUT, not to stdout.
109 This doesn't fix any bugs, since OUT always equals stdout, but it
110 makes the code easier to understand.
112 2006-07-14 Jim Meyering <jim@meyering.net>
114 * Makefile.maint (CVS_LIST): Use new file, build-aux/vc-list-files,
115 rather than open-coding it. Now supports mercurial, too.
116 * .hgignore: New file.
117 * Makefile.am (EXTRA_DIST): Add .hgignore, which ignores nearly
118 all generated files, including ones like configure and po/*.po
119 that are currently version-controlled in cvs.
121 * Makefile.am (EXTRA_DIST): Add a few more .??* files.
122 They've been in CVS, just haven't been distributed before this.
123 Distribute ChangeLog-2005, too.
124 (MAINTAINERCLEANFILES): Add THANKS-to-translators.
126 2006-07-11 Paul Eggert <eggert@cs.ucla.edu>
128 * src/system.h: Assume <dirent.h> exists, since gnulib assumes
131 2006-07-09 Jim Meyering <jim@meyering.net>
133 * tests/mv/dir2dir: Adjust so failing with ENOTEMPTY is ok, too.
134 That happens with Linux/tmpfs.
135 * tests/mv/Makefile.am (TESTS): Add dir2dir.
137 2006-07-09 Paul Eggert <eggert@cs.ucla.edu>
139 Adjust to recent updates from gnulib.
140 * src/dd.c (apply_translations): Use toupper rather than
141 islower followed by toupper; it's simpler and typically
142 faster now that we assume at least C89 semantics. Similarly
144 * src/sort.c (inittables): Likewise.
145 * src/expand.c (expand): Don't assume that isprint etc. return
146 booleans (needed for pre-C99 hosts).
147 * src/fmt.c (check_punctuation): Likewise.
148 * src/ptx.c (initialize_regex, fix_output_parameters): Likewise.
149 * src/tr.c (is_char_class_member): Likewise.
150 * src/unexpand.c (unexpand): Likewise.
151 * src/join.c (is_blank): Remove; no longer needed. All uses
152 replaced by isblank (to_uchar (...)).
153 * src/pinky.c (create_fullname): Don't assume char is unsigned.
154 * src/printf.c (print_esc): Likewise.
155 * src/ptx.c (SKIP_NON_WHITE, SKIP_WHITE, SKIP_WHITE_BACKWARDS):
156 (copy_unescaped_string): Likewise.
157 * src/stat.c (print_it): Likewise.
158 * src/system.h (_D_EXACT_NAMELEN): Renamed from NLENGTH, for
159 convenience on GNU systems. All uses changed. Don't bother
160 looking for any dirent.h substitute other than ndir.h.
161 (D_INO): Remove unnecessary parentheses.
162 (IN_CTYPE_DOMAIN, ISGRAPH, ISPRINT, ISALNUM, ISALPHA):
163 (ISCNTRL, ISLOWER, ISPUNCT, ISSPACE, ISUPPER, ISXDIGIT):
164 (ISDIGIT_LOCALE, TOLOWER, TOUPPER): Remove. All uses changed
165 to ctype.h equivalents.
166 (isblank): Renamed from ISBLANK. Check for HAVE_DECL_ISBLANK too.
169 2006-07-08 Jim Meyering <jim@meyering.net>
171 * tests/mv/dir2dir: New file, test for 2006-07-05 fix in copy.c.
173 * Makefile.maint (sc_the_the): New rule.
175 * src/dd.c (skip): Remove one of two adjacent "the"s in a comment.
176 * tests/Coreutils.pm (run_tests): Remove one of two adjacent "then"s
179 2006-07-07 Jim Meyering <jim@meyering.net>
181 * NEWS: Mention that mv can now remove an empty destination directory,
182 and give an example. Prompted by a report from Florent Bayle.
184 2006-07-05 Jim Meyering <jim@meyering.net>
186 * src/ls.c (usage): Correct the description of -G: it is useful
187 only in a long listing. Reported by Martin Pool in
188 <https://launchpad.net/distros/ubuntu/+source/coreutils/+bug/51653>.
190 * man/chmod.x: Correct the description of the sticky bit. Reported
191 by Chris Moore via Ian Jackson in <http://bugs.debian.org/376745>.
193 * src/copy.c (copy_internal): Don't work around old NFS clients like
194 SunOS-4.1.4 and Irix 5.3 that set errno to values like EIO and
195 ENOTEMPTY upon failed rename. Otherwise, we risk misinterpreting
196 a banal failure as a recursive move-into-self failure.
197 Reported by Florent Bayle in <http://bugs.debian.org/376749>.
199 * src/c99-to-c89.diff: Regenerate, to remove fuzz.
201 2006-07-03 Jim Meyering <jim@meyering.net>
203 Plug another unusual leak.
204 (AD_mark_helper): Free malloc'd filename if hash_insert says
205 that string is already in the hash table.
207 The dev/inode of the topmost directory in each hierarchy were not
209 * src/remove.c (remove_cwd_entries): Don't call cycle_check here.
210 (AD_push): Call it from here instead.
213 * src/remove.c (AD_stack_clear): New function.
215 (AD_pop_and_chdir): Free *prev_dir just before longjmp.
217 * tests/Makefile.am, tests/*/Makefile.am: (TESTS_ENVIRONMENT):
218 Add $VG_PATH_PREFIX as a prefix to $PATH
220 * tests/envvar-check (vars): Add CDPATH and POSIXLY_CORRECT.
221 * tests/Makefile.am (evar-check): Remove rule.
222 (EXTRA_DIST): Remove .env-warn.
223 * tests/.env-warn: Remove file. No longer used.
224 Suggestion from Eric Blake.
226 2006-07-02 Paul Eggert <eggert@cs.ucla.edu>
228 * src/system.h: Include <stdint.h> unconditionally, since we
229 now assume the stdint module.
231 2006-07-01 Paul Eggert <eggert@cs.ucla.edu>
233 * NEWS: With no operand, 'tail -f' now silently ignores the '-f'
234 only if standard input is a FIFO or pipe and POSIXLY_CORRECT is set.
235 * src/tail.c (main): Implement this.
236 * tests/tail/Test.pm (f-pipe-1): Renamed from f-1.
237 (test_vector): Set POSIXLY_CORRECT for the f-pipe-* tests.
239 2006-07-01 Jim Meyering <jim@meyering.net>
241 * src/ln.c (do_link): Use new, shorter URL, for ag-review link.
243 * .x-sc_require_config_h: Add ^lib/xstrtold\.c$, so make distcheck
246 2006-06-30 Paul Eggert <eggert@cs.ucla.edu>
248 * NEWS: seq now uses long double internally rather than double.
249 It now defaults to a minimal fixed point format if possible.
250 It lets you use %a, %A, %E, %F, %G.
251 * src/Makefile.am (seq_LDADD): Remove $(SEQ_LIBM); add $(POW_LIB).
252 * src/seq.c: Don't include <math.h> or <xstrtol.h>; no longer needed.
253 (isfinite) [!defined isfinite]: New macro.
254 (separator, terminator): Now points to const.
255 (first, step, last): Remove.
256 (usage): Update to match new behavior.
257 (struct operand, operand): New type.
258 (scan_arg): Renamed from scan_double_arg, since we no longer use double.
260 Compute and return a value of type operand, not double.
261 (long_double_format): Renamed from valid_format, and now returns a
262 new format with an "L" added if needed, if the original format was
263 valid. Allow %a, %A, %E, %F, and %G formats.
264 (print_numbers): Take numeric values as args rather than from globals.
265 Print long double, not double.
266 (get_width_format): Remove.
267 (get_default_format): New function.
268 (main): Implement new way of calculating default format.
269 Don't worry about locale's representation of the decimal point, since
270 the arguments are always processed in the C locale.
271 * tests/seq/basic (neg-2): Adjust to new default format.
272 (eq-wid-1, eq-wid-2): Resurrect these tests, since the new
273 implementation should do the right thing.
275 2006-06-30 Jim Meyering <jim@meyering.net>
277 * tests/stty/basic-1: Work around an intermittent test failure
278 on HP-UX 11.11. Report and analysis from Bob Proulx.
279 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/7475
281 2006-06-28 Paul Eggert <eggert@cs.ucla.edu>
283 * NEWS: Support obsolete usages like "sort +1 -2" even when
284 conforming to POSIX 1003.1-2001, since this is a pure extension to
285 POSIX. Problem reported by Christian in:
286 http://lists.gnu.org/archive/html/bug-coreutils/2006-06/msg00220.html
287 * src/sort.c (main): Implement this.
289 * src/system.h (CLOSEDIR): Remove. All uses changed to closedir.
290 Autoconf 2.60 says this stuff was obsolete.
292 2006-06-28 Jim Meyering <jim@meyering.net>
294 * src/c99-to-c89.diff: Regenerate, to remove fuzz.
296 2006-06-28 Bob Proulx <bob@proulx.com> (tiny change)
298 * tests/mv/i-link-no: Work around HP-UX /bin/sh tracing problem
299 (set -x when VERBOSE=yes) when stderr is redirected before stdout
300 causing shell tracing of the stdout redirection to be written to
301 the stderr file. Avoid problem and test failure on HP-UX by
302 redirecting stderr last.
303 * tests/dd/unblock-sync: Order shell file redirections for
304 stderr and stdout in the common style.
307 2006-06-27 Jim Meyering <jim@meyering.net>
309 * tests/misc/cat-proc: Try to avoid any spurious numeric
310 differences in frequently-changing /proc/cpuinfo.
311 Reported by Nelson Beebe.
313 2006-06-26 Jim Meyering <jim@meyering.net>
315 Attempt rmdir (actually, unlinkat-with-AT_REMOVEDIR) upon any
316 fd_to_subdirp failure, not just when errno == EACCES.
317 * src/remove.c (remove_dir): Use unlinkat-with-AT_REMOVEDIR, not
318 rmdir, here, even though rmdir may happen to be adequate.
320 * NEWS: rm no longer fails to remove an empty, unreadable directory
321 * src/remove.c (remove_cwd_entries): If we can't open a directory,
322 and the failure is not being ignored, try to remove the directory
323 with rmdir (aka unlinkat-with-AT_REMOVEDIR), in case it's empty.
324 Problem report and test case from Paul Eggert in
325 <http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/7425>.
327 * tests/rm/empty-inacc: New test, for the above.
329 Avoid a segfault for wc --files0=- < /dev/null.
330 * src/wc.c (compute_number_width): Return right away if nfiles == 0.
332 2006-06-25 Jim Meyering <jim@meyering.net>
334 * NEWS: wc accepts a new option --files0-from=FILE, where FILE
335 contains a list of NUL-separated file names.
337 * src/wc.c: Include "readtokens.h".
338 (usage): Describe the new option, and adjust the `Usage':
339 with this option, no FILE may be specified on the command line.
340 (main): Handle the new option.
341 * tests/misc/wc-files0: New tests, for the above.
342 * tests/misc/wc-files0-from: Likewise.
343 * tests/misc/Makefile.am (TESTS): Add wc-files0.
345 2006-06-24 Jim Meyering <jim@meyering.net>
347 * src/md5sum.c (DIGEST_BUFFER): Remove now-unused definitions.
349 2006-06-22 Jim Meyering <jim@meyering.net>
351 * src/tee.c (tee_files): Rename from tee, to avoid conflict with
352 the function in glibc's <fcntl.h>. Reported by Andreas Schwab.
354 2006-06-19 Jim Meyering <jim@meyering.net>
356 * Makefile.cfg (local-checks-to-skip): Add changelog-check,
357 so this check is not run as part of "make distcheck".
359 2006-06-18 Bob Proulx <bob@proulx.com> (tiny change)
361 * tests/misc/pwd-long: Fix typo (s/neq/ne/) in previous change.
363 2006-06-18 Jim Meyering <jim@meyering.net>
365 * tests/misc/pwd-long: Make error output a little clearer.
367 2006-06-17 Jim Meyering <jim@meyering.net>
369 * tests/rm/inaccessible: Skip this test on systems without openat
370 support. Reported by Bob Proulx.
372 2006-06-15 Bob Proulx <bob@proulx.com> (tiny change)
374 * tests/misc/mknod: Improve permission checks to handle
375 running mkdir test in set-gid directories.
377 2006-06-14 Jim Meyering <jim@meyering.net>
379 * tests/du/basic: Revamp not to hard-code file system block sizes.
381 2006-06-12 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
383 * tests/du/Makefile.am (TESTS_ENVIRONMENT): Pass $(PERL), for
386 2006-06-11 Jim Meyering <jim@meyering.net>
388 * .gitignore: New file.
389 * Makefile.am (EXTRA_DIST): Add .gitignore.
391 Setting TIME_STYLE=long-iso in the environment would make the
392 cp/same-file test fail.
393 * tests/envvar-check (vars): Add TIME_STYLE to the list.
394 * tests/cp/same-file: Revert last change.
395 Source the envvar-check script, to ensure that TIME_STYLE
396 settings don't affect these tests.
398 2006-06-11 Paul Eggert <eggert@cs.ucla.edu>
400 * tests/cp/same-file: Execute 'ls' in the C locale, so that it
401 uses POSIX time stamp formats. Problem reported by John Nixon in
402 <http://lists.gnu.org/archive/html/bug-coreutils/2006-06/msg00062.html>.
404 2006-06-10 Jim Meyering <jim@meyering.net>
406 * NEWS: Mention the AIX-strndup-bug vs. dircolors workaround.
408 Require a "Version N.M" line at the top of the ChangeLog
409 file only when making the actual release, not when running
411 * Makefile.maint (maintainer-distcheck): Don't depend on
413 (alpha beta major): Depend on it here, instead.
415 2006-06-08 Jim Meyering <jim@meyering.net>
417 Ensure that cat works with any of the options, -A -v -e -E -T,
418 when applied to files in /proc and /sys, even when the FIONREAD
419 ioctl produces nonsensical results. Before this change, cat would
420 produce no output (or truncated output), for some linux kernels.
422 * src/cat.c (write_pending): New function, factored out of cat.
423 (cat): Also interpret a negative ioctl/FIONREAD count as indicating
424 that there are bytes to read. Some versions of linux-2.6.16 do that.
425 Write any pending output before returning.
426 Reported by Dan Jacobson in <http://bugs.debian.org/370583>.
427 * NEWS: Mention this bug fix.
428 * tests/misc/cat-proc: New file. Test for the above.
429 * tests/misc/Makefile.am (TESTS): Add cat-proc.
431 2006-06-07 Paul Eggert <eggert@cs.ucla.edu>
433 * src/expr.c (eval4): Detect overflow properly when multiplying
436 2006-06-06 Paul Eggert <eggert@cs.ucla.edu>
438 * NEWS: The 'expr' command now detects and reports integer overflow.
439 (It would be better to use extended precision instead, but that
441 * src/expr.c (integer_overflow): New function.
442 (eval4, eval3): Check for integer overflow.
444 2006-06-05 Paul Eggert <eggert@cs.ucla.edu>
446 Fix problems when building with Solaris/SVR4/etc. make, which uses a
447 different and somewhat bogus implementation of VPATH. In the
448 directory tests/misc, rename tests whose names might appear in the
449 Automake-generated rules. For example, we can't use a test named
450 'test', since Automake generates a rule that contains the text
451 "if test -f ./$$tst; ...", and this might expand to something like
452 "if ../../../coreutils-6.0/tests/misc/test -f ./$$test; ...",
453 which executes the 'test' script rather than the 'test' command.
454 * tests/misc/false-status: Renamed from tests/misc/false.
455 * tests/misc/pwd-long: Renamed from tests/misc/pwd.
456 * tests/misc/sort-merge: Renamed from tests/misc/sort.
457 ($prog): Set to 'sort' rather than to $PROG.
458 * tests/misc/test-diag: Renamed from tests/misc/test.
459 * tests/misc/Makefile.am (PROG): Take the basename of $$tst,
460 in case Solaris make has prepended the directory.
461 (TESTS): Adjust to above renamings.
462 * tests/misc/expand: Don't assign to PROG; no longer needed
463 now that Makefile.am sets PROG to the basename.
464 * tests/misc/fold: Likewise.
466 2006-06-03 Jim Meyering <jim@meyering.net>
468 Make `cp --link --no-dereference' work also on systems where the
469 link system call cannot create a hard link to a symbolic link.
470 * src/copy.c (copy_internal) [LINK_FOLLOWS_SYMLINKS]: Don't use
471 the link syscall on a symlink when it would do the wrong thing.
472 Based on the patch by Aurelien Jarno: <http://bugs.debian.org/329451>
473 * tests/cp/link-no-deref: New file/test for the above.
474 * tests/cp/Makefile.am (TESTS): Add link-no-deref.
475 * NEWS: Mention the change (doesn't affect Linux).
477 2006-06-01 Paul Eggert <eggert@cs.ucla.edu>
479 Fix some porting problems in the test cases reported by
480 Ralf Wildenhues for HP-UX 11.23 in:
481 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00238.html
482 * tests/help-version: Don't assume that \< \> works in sed.
483 * tests/misc/close-stdout: Don't assume that >&- works.
484 Add a /dev/full test.
485 * tests/touch/no-create-missing: Don't assume that >&- works.
487 2006-05-30 Jim Meyering <jim@meyering.net>
489 * src/ls.c (usage): Add `v' to the list of sorting-related options.
492 2006-05-28 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
494 * tests/cp/fail-perm: source lang-default.
495 * tests/rm/inaccessible: Likewise.
497 2006-05-28 Jim Meyering <jim@meyering.net>
499 * tests/rm/inaccessible: AIX 4.3.3 gives a different diagnostic.
500 Recognize it, too. Reported by Ralf Wildenhues, in
501 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
503 2006-05-27 Jim Meyering <jim@meyering.net>
505 * src/chgrp.c: Support new options: --preserve-root and
506 --no-preserve-root. Somehow this program was skipped when those
507 options were added to chown, chmod, and rm. Reported by
508 vaqflabuopac@spammotel.com in <http://bugs.debian.org/365656>.
509 * NEWS: Mention this.
511 2006-05-25 Paul Eggert <eggert@cs.ucla.edu>
513 * NEWS: Remove mention of --seed. We'll replace it with something
514 better, and don't want to indicate that it is supported.
515 * src/sort.c (usage): Likewise.
517 2006-05-20 Jim Meyering <jim@meyering.net>
519 * src/chmod.c (main): Use FTS_PHYSICAL here, too.
521 * src/du.c (main): Rename local, s/symlink_deref_bit/symlink_deref_bits/
522 and arrange for -D to set fts' FTS_PHYSICAL bit as well as
523 FTS_COMFOLLOW. Spotted by Justin Pryzby.
525 * gnupload: Merge changes from automake, retaining the ""--to...
526 kludge to placate overzealous `make distcheck' check.
528 2006-05-19 Jim Meyering <jim@meyering.net>
530 * src/du.c (main): Don't let -D, -L, or -P turn off the internal
531 FTS_TIGHT_CYCLE_CHECK directory traversal option.
532 Reported by Justin Pryzby in http://bugs.debian.org/367691
534 2006-05-15 Jim Meyering <jim@meyering.net>
536 * src/cp.c (usage): Correct description of -a: s/-dpR/-dpPR/.
539 2006-05-13 Jim Meyering <jim@meyering.net>
541 * tests/mv/no-target-dir: Test two more cases.
543 2006-05-11 Jim Meyering <jim@meyering.net>
545 mv -T DIR EMPTY_DIR no longer fails unconditionally
546 * src/copy.c (copy_internal): Don't manually prohibit a move where
547 the destination is an existing directory. Sometimes doing that is
548 valid. Let the rename system call enforce the rules. That is
549 allowed only when the source is a directory and the destination
550 directory (to be replaced) is empty. Reported by Eric Blake.
551 * tests/mv/no-target-dir: New file/test for this.
552 * tests/mv/Makefile.am (TESTS): Add no-target-dir.
553 * NEWS: Mention this.
555 * tests/mv/atomic: New file/test for yesterday's fix.
556 * tests/mv/Makefile.am (TESTS): Add atomic.
558 * tests/du/long-sloop: Avoid harmless `ambiguous redirect' diagnostic.
560 2006-05-10 Jim Meyering <jim@meyering.net>
562 * src/copy.c (copy_internal): Don't explicitly unlink the destination
563 when moving a symlink into the place of an existing non-directory.
564 Reported by Joshua Hudson.
565 * NEWS: mention this.
567 2006-05-07 Jim Meyering <jim@meyering.net>
569 * Makefile.maint (patch-check): Fail if patch generates any output,
570 even merely for changed offsets.
572 * src/c99-to-c89.diff: Adjust to reflect new offsets.
574 * NEWS: Mention changes affecting df, pwd, shred.
576 2006-05-06 Jim Meyering <jim@meyering.net>
578 * tests/ls/stat-vs-dirent: New test, to detect the bogus file
579 system condition where dirent.d_ino != stat.st_ino.
580 * tests/ls/Makefile.am (TESTS): Add stat-vs-dirent.
582 2006-05-06 Eric Blake <ebb9@byu.net>
584 * tests/ls/inode: Expand to test inode from readdir case.
585 * tests/ls/follow-slink: Expand to test broken links encountered
586 implicitly, favoring Solaris 9 and OpenBSD 3.4 behavior.
588 2006-05-06 Eric Blake <ebb9@byu.net>
590 * tests/mv/leak-fd: Work even on case-insensitive file system.
592 2006-05-04 Jim Meyering <jim@meyering.net>
594 * NEWS: Mention the 2006-03-19 pwd-related change that makes
595 lib/getcwd.c work around inconsistent file system dirent.d_ino data.
597 2006-05-03 Jim Meyering <jim@meyering.net>
599 * src/ls.c (DEFINE_SORT_FUNCTIONS, LIST_SORTFUNCTION_VARIANTS):
600 Use better macro parameter names: s/basename/key_name/,
601 s/basefunc/key_cmp_func. Fix typo in comment.
603 2006-04-29 Eric Blake <ebb9@byu.net>
605 * src/ls.c (main): On systems with d_type, directories_first only
606 implies format_needs_type, not format_needs_stat.
608 2006-05-03 Jim Meyering <jim@meyering.net>
610 * src/ls.c (xstrcoll_df_version, rev_xstrcoll_df_version): Add space
611 after comma in arg list, from Eric Blake.
613 2006-04-25 Paul Eggert <eggert@cs.ucla.edu>
615 * tests/misc/date (relative-3): New test, derived from a bug
616 report by John Thomas McDole.
618 2006-04-23 Francesco Montorsi <fr_m@hotmail.com>
620 New option for ls: --group-directories-first.
621 It makes ls list directories before files.
622 * NEWS [New features]: Mention it.
623 * src/ls.c (sort_type): Rearrange to use as an array index when
624 choosing sort function; added new sort_numtypes member for
626 (time_type): Add new time_numtypes member for compile-time check.
627 (directories_first): New global variable.
628 (GROUP_DIRECTORIES_FIRST_OPTION): New enum.
629 (long_options): Add --directories-first.
630 (main): Support new option.
631 (is_directory): New function.
632 (extract_dirs_from_files): Use it.
633 (DIRFIRST_CHECK, DEFINE_SORT_FUNCTIONS)
634 (LIST_SORTFUNCTION_VARIANTS): New macros.
635 (sort_functions): New global variable.
636 (sort_files): Use it.
637 (usage): Document new option.
639 2006-04-18 Paul Eggert <eggert@cs.ucla.edu>
641 * src/shred.c (fillrand): The assertion was way too weak, due to
642 what must be a typo. Strengthen it to its intended value.
643 (dopass): Don't use alloca; it's not worth the aggravation here,
644 since it's used only to get a page-aligned buffer, and page
645 alignment doesn't buy us much here. I'm suspicious that alloca
646 causes problems on some hosts, due to a recent bug report by Adam
647 Waltman: http://bugs.gentoo.org/130246.
649 2006-04-18 Jim Meyering <jim@meyering.net>
651 * tests/misc/tty-eof: Add new programs, base64, sha224sum, sha256sum,
652 sha384sum, sha512sum.
654 2006-04-17 Paul Eggert <eggert@cs.ucla.edu>
656 * src/chmod.c (describe_change): Adjust to filemode changes.
657 * src/ls.c (HAVE_ST_DM_MODE): Remove; moved to ../lib/filemode.c.
658 (print_long_format): Use (new) filemodestring rather than
659 (old) mode_string, so that we get more file types right, at least
660 in theory. Adjust to filemode changes.
661 * src/stat.c (human_access): Likewise.
663 2006-04-18 Jim Meyering <jim@meyering.net>
665 * src/ptx.c (main) [DEFAULT_IGNORE_FILE]: Remove code to use a default
666 ignore file. This has never been enabled. Reported by Eric Blake.
668 2006-04-12 Paul Eggert <eggert@cs.ucla.edu>
670 * src/ln.c (linkfunc): Remove. This method ran into a compiler/linker
671 bug in Interix. Just call symlink or link directly. All uses changed.
672 * src/setuidgid.c (main) [! HAVE_SETGROUPS]: Don't call setgroups.
673 * src/stat.c (USE_STATVFS): New macro.
674 Include <sys/statvfs.h> and use statvfs only if USE_STATVFS.
675 (NAMEMAX_FORMAT): define a bit more clearly, now that the
676 statvfs-using code is a bit more regular.
677 * src/system.h (sync) [!HAVE_SYNC]: New macro.
679 2006-04-11 Paul Eggert <eggert@cs.ucla.edu>
681 * NEWS: csplit, nl, expr now conform to POSIX better, and are
682 more-compatible with traditional Unix, with respect to regular
684 * src/csplit.c (extract_regexp): Set re_syntax_options to a
685 value that is compatible with what POSIX requires.
686 * src/nl.c (build_type_arg): Likewise.
687 * src/expr.c (docolon): Likewise. Also, don't let anchors match
688 newline; this fixes an incompatibility with tradition and with POSIX.
689 Don't warn about leading ^. POSIX says it is unspecified whether
690 ^ is a special character, which means that implementations can
691 either treat it as special or not, but either way a warning is not
692 allowed (unless the regexp is otherwise invalid). Instead, anchor
693 the expression but treat ^ as an anchor; this is the traditional
694 behavior (e.g., Solaris 10).
695 (eval4, eval3, eval2): Treat non-numeric args, division by zero,
696 and the like as invalid expressions (exit status 2), not as
697 failure of 'expr' (exit status 3). This is more consistent with
699 * tests/expr/basic (fail-a): Adjust exit status to match new expr
700 behavior, for status 2 versus 3.
702 (bre1, bre2, bre3, bre4, bre5, bre6, bre7, bre8, bre9, bre10):
703 (bre11, bre12, bre13, bre14, bre15, bre16, bre17, bre18, bre19, bre20):
704 (bre21, bre22, bre23, bre24, bre25, bre26, bre27, bre28, bre29, bre30):
705 (bre31, bre32, bre33, bre34, bre35, bre36, bre37, bre38, bre39, bre40):
706 (bre41, bre42, bre43, bre44, bre45, bre46, bre47, bre48, bre49, bre50):
707 (bre51, bre52, bre53, bre54, bre55, bre56, bre57, bre58, bre59, bre60):
708 (bre61, bre62): New tests.
709 * tests/misc/csplit: Use \{...\} in test RE, to test that we're
713 * tests/du/long-from-unreachable: Solaris 8 sh doesn't understand
714 "if !". Do not assume that 'sed' can handle long, newline-free input.
715 * tests/du/long-sloop: Likewise. Evaluate expr once, not $n times.
717 2006-04-10 Paul Eggert <eggert@cs.ucla.edu>
719 Adjust to new regex.h API (with new fastmap type), and clean
720 up the regex storage allocation a bit.
722 * src/csplit.c (struct control): Put re_compiled member at the
723 end, since it's large. Change regexpr member from char * to bool;
724 all uses changed. Add new member fastmap.
725 (extract_regexp): regexp arg is now char const *, not char *.
726 Don't bother duplicating the regular expression; it's not needed.
727 Set fastmap from new fastmap member. Don't bother allocating
728 a buffer, as the regexp code does a better job than we do.
729 * src/expr.c (docolon): Allocate and use a fastmap.
730 Don't bother allocating a buffer.
731 * src/nl.c (body_fastmap, header_fastmap, footer_fastmap):
733 (build_type_arg): New fastmap arg. All uses changed.
734 Don't bother allocating a buffer, but set a fastmap.
735 * src/ptx.c (context_regex_string, word_regex_string): Remove.
736 (context_regex, word_regex): New vars, replacing the above.
738 (struct regex_data): New type.
739 (compile_regex): Renamed from alloc_and_compile_regex, since
740 we no longer allocate storage. Arg is now a struct regex_data *,
741 not a const char *. All uses changed. Don't allocate the fastmap;
742 instead, take it from the caller. Don't convert size_t to int,
743 to avoid arithmetic overflow problems. Don't bother freeing
744 storage afterwards; it's not worth the aggravation.
745 * src/tac.c (compiled_separator_fastmap): New ver.
746 (main): Use it. Don't bother allocating a buffer.
748 2006-03-30 Jim Meyering <jim@meyering.net>
750 * src/dd.c (iwrite): Remove assignment without effect.
751 Reported by Felix Rauch Valenti.
753 2006-03-22 Eric Blake <ebb9@byu.net>
755 * src/ptx.c (usage): Remove mention of --copyright/-C.
756 (main): Alias --copyright to --version plus a deprecation warning.
757 * NEWS: Mention this.
759 2006-03-27 Jim Meyering <jim@meyering.net>
761 * src/Makefile.am (uptime_LDADD): Add $(POW_LIB), for uptime's
762 use of strtod. Tiny patch from Nickolai Zeldovich.
764 2006-03-11 Eric Blake <ebb9@byu.net>
766 * tests/misc/dirname: New file.
767 * tests/basename/Makefile.am: Delete.
768 * tests/basename/basic: Move to...
769 * tests/misc/basename: ... this new file. Add some tests,
770 including fixed behavior for //.
771 * tests/misc/Makefile.am (TESTS): Sort. Add basename, dirname.
772 * tests/Makefile.am (SUBDIRS): Remove basename.
773 * configure.ac (AC_CONFIG_FILES): Remove tests/basename.
775 Improvements to dirname/basename handling on platforms like
776 cygwin with distinct // and with drive letters.
777 * NEWS: Document new behavior.
778 * src/basename.c (main): Don't strip suffix from file system
780 * src/cp.c (target_directory_operand): Use new last_component.
781 (ASSIGN_BASENAME_STRDUPA): Likewise. Reduce time spent
782 traversing the string.
783 * src/dircolors.c (guess_shell_syntax): Use new last_component.
784 * src/install.c (target_directory_operand, install_file_in_dir):
786 * src/ln.c (target_directory_operand, main): Likewise.
787 * src/ls.c (basename_is_dot_or_dotdot): Likewise.
788 * src/mv.c (target_directory_operand, movefile): Likewise.
789 * src/remove.c (rm_1): Likewise.
790 * src/shred.c (wipename): Likewise.
791 * src/split.c (next_file_name): Likewise.
792 * src/su.c (log_su, run_shell): Likewise.
794 2006-03-23 Paul Eggert <eggert@cs.ucla.edu>
796 * NEWS: nohup diagnostics are now more precise, and nohup now
797 redirects stderr to nohup.out if stdout is closed and stderr is a tty.
798 * src/nohup.c (main): Implement this.
799 * tests/misc/nohup: Test the new behavior.
801 2006-03-12 Jim Meyering <jim@meyering.net>
803 * src/copy.c (set_author): Rename function, from preserve_author.
805 * src/remove.c (AD_pop_and_chdir): Use new macro,
806 CYCLE_CHECK_REFLECT_CHDIR_UP, rather than open-coding it.
808 * src/system.h (SAME_INODE): Remove definition.
809 Include "same-inode.h", instead.
811 2006-03-11 Eric Blake <ebb9@byu.net>
813 * src/pwd.c (robust_getcwd): Prepend only one slash, not two.
815 2006-03-10 Jim Meyering <jim@meyering.net>
817 Fix a bug whereby a user with write access to a directory being removed
818 could cause the removal of that directory to fail with an erroneous
819 diagnostic about a directory cycle. Reported by Vineet Chadha.
821 * NEWS: Mention this.
822 * src/remove.c (AD_pop_and_chdir): If the directory we're about to
823 leave (and try to rmdir) is the one whose dev_ino is being used to
824 detect a cycle, reset cycle_check_state.dev_ino to that of the parent.
826 2006-03-08 Paul Eggert <eggert@cs.ucla.edu>
828 * NEWS: Document dd's new 'directory' and 'nolinks' flags.
829 * src/dd.c (set_fd_flags): Handle file-creation flags on file
830 descriptors, rather than ignoring them.
831 * tests/dd/misc: Add test cases for append, nofollow, directory,
832 and nolinks flags. Simplify redirection to /dev/null in some cases.
834 * tests/dd/misc: iflags->iflag. This fixes a typo that meant the
835 noatime test never tested anything.
837 2006-03-05 Paul Eggert <eggert@cs.ucla.edu>
839 * src/dd.c (flags, usage): New flags directory, nolinks.
840 * src/system.h (O_NOLINKS): Define to 0 if not already defined.
842 * src/ls.c (usage): Mention that -f disables --color.
843 Problem reported by Niels Möller.
845 2006-03-03 Justin Pryzby <pryzbyj@justinpryzby.com>
847 * man/*.x: Add references to syscalls from utilities of the same name.
849 2006-03-05 Jim Meyering <jim@meyering.net>
851 * tests/help-version: Set SHELL, if not already set, in order to
852 avoid failure when `make check' is run through debuild; dircolors
853 would fail due to lack of $SHELL. Reported by Sven Joachim.
855 Make `base64 --wrap=N' work for N=0, and for N larger than SIZE_MAX.
856 * src/base64.c (wrap_write, do_encode, main): Change type of
857 parameters and locals, wrap_column, form size_t to uintmax_t.
858 (main): Adjust to use xstrtoumax, accordingly.
860 2006-03-03 Jim Meyering <jim@meyering.net>
862 Don't fail when run from an environment with SHELL not a Bourne
863 shell, e.g. `env SHELL=/bin/csh make check' would fail this test.
864 * tests/dircolors/simple: Invoke each non-failing test with -b.
865 Reported by Michael Stone.
867 2006-02-27 Jim Meyering <jim@meyering.net>
869 * tests/misc/base64: Derive --decode-using tests from the
872 * tests/misc/base64: Factor out a long constant string.
873 Split lines to stay within 80 columns.
875 * tests/misc/Makefile.am (TESTS): Add base64.
876 * tests/misc/base64: Test base64. From Simon Josefsson.
878 * src/base64.c (do_decode): Use correct type for parameter,
879 ignore_garbage: s/size_t/bool/.
881 * src/base64.c: Don't include .h files already included by system.h:
882 <string.h>, <stdlib.h>, <stdbool.h>, <limits.h>, <errno.h>.
883 Include "system.h" before the other lib/*.h header files.
884 Include <sys/types.h> before "system.h".
885 (wrap_write): Remove declaration of unused local, initial_column.
886 (wrap_write): Correct declaration syntax: s/size_t * V/size_t *V/.
888 * README: Add base64 to the list.
890 2006-02-17 Simon Josefsson <jas@extundo.com>
893 * AUTHORS: Mention base64.
895 * man/Makefile.am: Build base64.1.
896 * man/base64.x: New file.
897 * src/Makefile.am (bin_PROGRAMS): Add base64.
898 * src/base64.c: New file.
900 2006-02-25 Eric Blake <ebb9@byu.net>
902 In ls, avoid calling stat for --inode (-i), when possible.
903 * src/pwd.c (NOT_AN_INODE_NUMBER, D_INO): Move to ...
904 * src/system.h: ... here, for use in ...
905 * src/ls.c (main): ... here. Prefer dirent.d_ino to stat when
907 (gobble_file): Add inode argument.
908 (print_dir): Pass inode if available.
909 (usage): Remove inaccuracy.
911 2006-02-23 Jim Meyering <jim@meyering.net>
913 * TODO: Update/correct some obsolete entries.
915 2006-02-20 Paul Eggert <eggert@cs.ucla.edu>
917 * doc/coreutils.texi (join invocation): Mention `sort -k 1b,1'.
918 * src/join.c (usage): Likewise.
919 Documentation problem reported by Philip Kensche.
921 2006-02-20 Eric Blake <ebb9@byu.net>
923 * man/rm.x: Update documentation to match previous patch.
925 2006-02-18 Eric Blake <ebb9@byu.net>
927 New option for rm: --interactive=once (-I).
928 * NEWS: Document it, along with change to rm --interactive.
929 * TODO: Remove entry for implementing rm -I
930 * src/rm.c (INTERACTIVE_OPTION): New enum value.
931 (interactive_type): New enum.
932 (long_opts): Let interactive take an optional argument.
933 (interactive_args, interactive_types): New option arguments.
934 (usage): Document -I, --interactive=WHEN. Use program_name
935 instead of a basename.
936 (main): New -I option, new behavior to --interactive.
937 * tests/rm/interactive-once: New tests.
938 * tests/rm/interactive-always: Ditto.
939 * tests/rm/Makefile.am (TESTS): Run them.
941 2006-02-18 Jim Meyering <jim@meyering.net>
943 * Makefile.maint (sc_two_space_separator_in_usage): Make the regular
944 expression match more of the target lines, e.g., those that start with
945 `-S,' (short option followed by a comma) or that include `=[...]'.
946 Patch by Nicolas François.
947 Fix the four offenders thus exposed:
948 * src/join.c (usage): Use two spaces (not one) to separate the
949 --first-only option string from its description, so help2man formats
950 the derived man page properly.
951 * src/pr.c (usage): Likewise.
952 * src/uniq.c (usage): Likewise.
953 * src/install.c (usage): Likewise.
955 2006-02-15 Jim Meyering <jim@meyering.net>
957 * Makefile.maint (alpha beta major): For `make major', ensure that the
958 version string is of the form N.N[.N]*, where N is one or more digits.
960 2006-02-14 Jim Meyering <jim@meyering.net>
962 * INSTALL: Update from gnulib.
964 2006-02-13 Jim Meyering <jim@meyering.net>
966 * GNUmakefile (all): Emit diagnostics to stderr, not stdout.
968 2006-02-12 Jim Meyering <jim@meyering.net>
970 * Makefile.maint (patch-check): New target.
971 (local-checks-available): Add to the list.
973 2006-02-11 Jim Meyering <jim@meyering.net>
975 * src/c99-to-c89.diff: New file.
976 * src/Makefile.am (EXTRA_DIST): Add c99-to-c89.diff.
978 * .x-po-check: New file, with exclusions so that `make distcheck'
980 * Makefile.am (EXTRA_DIST): Add .x-po-check.
982 rm -r must remove an empty directory, even if it is inaccessible.
983 * src/remove.c (close_preserve_errno): New function.
984 (fd_to_subdirp): Don't print a diagnostic in this function.
985 Do it from the callers instead, unless rmdir succeeds.
986 (remove_cwd_entries, remove_dir): Adjust callers.
987 * tests/rm/empty-inacc: New test for the above.
988 * tests/rm/Makefile.am (TESTS): Add empty-inacc.
989 * NEWS: Mention this bug fix.
990 * tests/rm/rm2: Adjust two expected diagnostics, now that they're
991 a tiny bit less precise: cannot remove `a/1': ... instead of
992 cannot open directory `a/1': ...
994 * Makefile.maint (syntax-check-rules): Automatically derive this
995 list of sc_-prefixed rule names.
997 2006-02-10 Paul Eggert <eggert@cs.ucla.edu>
999 * Makefile.maint (CVS_LIST): Don't assume cvsu is available.
1000 (CVS_LIST_EXCEPT): New macro, to simplify exception-processing.
1001 Most uses of CVS_LIST changed to use CVS_LIST_EXCEPT.
1002 (syntax-check-rules): Bring back sc_changelong. (Hmm, why did it
1003 go away? was that an accident?)
1004 (sc_cast_of_argument_to_free, sc_cast_of_x_alloc_return_value):
1005 (sc_cast_of_alloca_return_value, sc_space_tab, sc_prohibit_atoi_atof):
1006 (sc_error_exit_success, sc_file_system, sc_no_if_have_config_h):
1007 (sc_system_h_headers, sc_sun_os_names, sc_trailing_blank):
1008 (sc_two_space_separator_in_usage, sc_unmarked_diagnostics):
1009 (sc_obsolete_symbols, sc_changelog, sc_prohibit_jm_in_m4):
1010 (sc_useless_cpp_parens, makefile-check, m4-check, po-check):
1011 (author_mark_check, makefile_path_separator_check):
1012 Output line numbers, to simplify navigation of Emacs *compilation*
1014 (sc_prohibit_atoi_atof, sc_file_system):
1015 Rework slightly so that Makefile.maint doesn't get reported as a
1016 violation of its own syntax rules.
1017 (sc_dd_max_sym_length): Use ifneq to do nothing, instead of doing
1018 it at run-time (which didn't work with Bison). Fix a makefile typo,
1019 caught by Makefile.maint itself: spaces where a tab should be.
1020 (po-check): Check lib/*.[ch] even if not in CVS; used by Bison,
1021 which copies from ../gnulib/lib/*.[ch] to lib/*.[ch].
1022 Ignore djgpp and man subdirectories, to avoid false matches with
1023 Bison and coreutils, respectively. Use sort -u to remove the
1024 resulting duplicates.
1025 * gnupload: Rework slightly to avoid bogus warning from
1026 sc_two_space_separator_in_usage.
1028 2006-02-10 Jim Meyering <jim@meyering.net>
1030 Use gzip's --rsyncable option only if it's available.
1031 * Makefile.maint (gzip_rsyncable): New variable.
1034 2006-02-08 Jim Meyering <jim@meyering.net>
1036 * Makefile.maint (local-checks-available): Define in terms of
1037 the expansion, $(syntax-check-rules), rather than the single,
1038 top-level target `syntax-check', so that it's easier to exclude
1039 individual rules (via $(local-checks-to-skip)).
1040 (tgz-md5, tgz-sha1, ...): Remove now-unused definitions.
1042 2006-02-07 Jim Meyering <jim@meyering.net>
1044 * src/system.h (!defined O_DIRECT): If O_DIRECTIO is defined (as it
1045 is on Tru64), define O_DIRECT to that. Patch From James Lemley.
1047 * tests/help-version (expected_failure_status_vdir):
1048 Redirect an expected disk-full diagnostic to /dev/null.
1050 2006-02-06 Jim Meyering <jim@meyering.net>
1052 * src/unexpand.c (usage): Use two spaces (not one) to separate the
1053 --first-only option string from its description, so help2man formats
1054 the derived man page properly.
1055 * src/rm.c (usage): Likewise for --no-preserve-root.
1056 * src/chown.c (usage): Likewise.
1057 * src/chgrp.c (usage): Likewise.
1059 Add a rule to ensure that the above doesn't happen again.
1060 * Makefile.maint (sc_two_space_separator_in_usage): New rule.
1061 (syntax-check-rules): Add it.
1062 * .x-sc_two_space_separator_in_usage: New empty file.
1063 * Makefile.am (EXTRA_DIST): Add .x-sc_two_space_separator_in_usage.
1065 2006-02-06 Jim Meyering <jim@meyering.net>
1067 * src/cp.c (usage): Use two spaces (not one) to separate each
1068 option string from its description, so help2man formats the
1069 derived man page properly.
1070 * src/mv.c (usage): Likewise.
1071 Patch from Nicolas François in http://bugs.debian.org/351601.
1073 2006-02-04 Jim Meyering <jim@meyering.net>
1075 * src/copy.c (copy_internal): cp -RL would fail when encountering
1076 the same directory more than once in the hierarchy beneath a single
1077 command-line argument. That is legitimate, e.g. when there are
1078 two or more symbolic links, each pointing to some directory that
1079 would not otherwise be copied. Reported by Christophe LYON.
1080 * tests/cp/cp-deref: New file. Test for today's fix.
1081 * tests/cp/Makefile.am (TESTS): Add cp-deref.
1082 * NEWS: Document this.
1084 2006-02-03 Jim Meyering <jim@meyering.net>
1086 * configure.ac: Require automake-1.9.6, not 1.8.3.
1088 2006-02-01 Paul Eggert <eggert@cs.ucla.edu>
1090 * src/od.c (usage): Mention that -t a ignores high order bit.
1091 Documentation problem reported by Ed Avis.
1093 2006-02-01 Jim Meyering <jim@meyering.net>
1095 * src/pwd.c (find_dir_entry): Remove unused local, `ent_sb_valid'.
1097 2006-01-30 Paul Eggert <eggert@cs.ucla.edu>
1099 * src/head.c (main): Use a better diagnostic when someone uses a
1100 trailing numeric option in an invalid way. Problem reported by
1102 * src/tail.c (parse_options): Likewise.
1104 2006-01-30 Jim Meyering <jim@meyering.net>
1106 * man/wc.x: Include `count' keyword in man page synopsis,
1107 per suggestion from http://bugs.debian.org/181585.
1109 2006-01-24 Paul Eggert <eggert@cs.ucla.edu>
1111 * src/df.c (show_dev): If the file system claims to have
1112 more available than total blocks, report the number of used
1113 blocks as being total - available (a negative number) rather
1114 than as garbage. Problem reported by Toralf Foerster.
1116 2006-01-24 Jim Meyering <jim@meyering.net>
1118 * src/tail.c (tail_forever): Don't exit-nonzero when an attempt
1119 to put a regular file in O_NONBLOCK mode fails with EPERM.
1120 That happens on Linux (up to 2.6.15) when using tail -f on a file with
1121 the append-only attribute. Reported by Dean Gaudet. For details,
1122 see http://savannah.gnu.org/bugs/?func=detailitem&item_id=15473.
1123 * NEWS: Mention this fix.
1124 * tests/tail-2/append-only: New file. Test for the above.
1125 * tests/tail-2/Makefile.am (TESTS): Add append-only.
1126 * tests/Makefile.am (check-root): Add tail-2/append-only
1128 2006-01-21 Jim Meyering <jim@meyering.net>
1130 * NEWS: Mention fts-related improvements and bug fixes.
1132 2006-01-19 Jim Meyering <jim@meyering.net>
1134 * tests/fmt/basic (pfx-1, pfx-2): New tests, to demonstrate the bug
1135 reported as http://bugs.debian.org/147577. Forwarded by Thomas Hood.
1137 2006-01-18 Jim Meyering <jim@meyering.net>
1139 * tests/du/Makefile.am (TESTS): Add long-from-unreadable.
1141 2006-01-17 Jim Meyering <jim@meyering.net>
1143 Now that fts no longer changes the current working directory, adjust
1144 its clients accordingly -- note that du.c uses fts but doesn't need
1145 any adjustment, since it doesn't operate on the actual files,
1146 but rather just uses the stat buffers provided by fts.
1148 * src/chown-core.c: Include "openat.h".
1149 Don't include "lchown.h".
1150 (restricted_chown): Accept a new parameter, CWD_FD, and use it in
1151 calling openat, lchownat, chownat, rather than open, lchown, chown.
1153 * src/chmod.c: Include "openat.h".
1154 (process_file): Use chmodat (fts->fts_cwd_fd,... in place of chmod (...
1156 * tests/du/long-from-unreadable: New test, to exercise one small
1159 2006-01-13 Jim Meyering <jim@meyering.net>
1161 * tests/Makefile.am (SUBDIRS): Add comments discouraging the
1162 addition of new directories under tests/.
1164 * tests/acl: Redirect stdin to /dev/null. Otherwise, FreeBSD 5.0's
1167 2006-01-12 Jim Meyering <jim@meyering.net>
1169 * tests/du/long-sloop: Adjust not to hard-code the expected
1170 diagnostic corresponding to ELOOP. Solaris' diagnostic differs
1171 from that of GNU libc. Reported by Paul Eggert.
1173 * tests/du/long-sloop: Create file at end of symlink chain.
1175 * tests/misc/test: New file, with a test for one of the
1176 bugs fixed by yesterday's test.c changes.
1177 * tests/misc/Makefile.am (TESTS): Add test.
1179 2006-01-11 Jim Meyering <jim@meyering.net>
1181 * tests/du/long-sloop: New file. Test for today's fts.c bug fix.
1182 That bug could make du -L, chgrp -L, or chown -L fail to diagnose
1183 a very long sequence of symbolic links (not necessarily a loop).
1184 * tests/du/Makefile.am (TESTS): Add long-sloop.
1186 2006-01-11 Paul Eggert <eggert@cs.ucla.edu>
1188 * src/test.c (test_syntax_error): Append a newline. All callers
1189 changed, except for the ones that didn't already append a newline.
1190 Bug reported by Eric Blake.
1192 2006-01-11 Jim Meyering <jim@meyering.net>
1194 * src/system.h (X2NREALLOC): Now that verify_true is no longer
1195 void, cast its result to void, to avoid gcc's warning that
1196 ``left-hand operand of comma expression has no effect''.
1197 (DECIMAL_DIGIT_ACCUMULATE, X2REALLOC): Likewise.
1199 2006-01-10 Jim Meyering <jim@meyering.net>
1201 * tests/chmod/no-x: Add a test for today's fts.c fix.
1203 2006-01-10 Jim Meyering <jim@meyering.net> (tiny change)
1205 * src/ls.c (gobble_file): Use DTTOIF only if it's defined.
1206 This is necessary for Dragonfly. Patch by Joerg Sonnenberger.
1208 2006-01-10 Paul Eggert <eggert@cs.ucla.edu>
1210 * src/system.h (X2NREALLOC, X2REALLOC, DECIMAL_DIGIT_ACCUMULATE):
1211 Use verify_true instead of verify_expr, to sync with gnulib.
1213 2006-01-08 Jim Meyering <jim@meyering.net>
1215 * src/date.c (usage): Adjust the formatting of the entries for
1216 %::z and %:::z (separate with two spaces, not one) so that help2man
1217 formats them properly. Reported by Philip Rowlands.
1219 2006-01-06 Paul Eggert <eggert@cs.ucla.edu>
1221 * configure.ac (gl_IGNORE_UNUSED_LIBRARIES): Add.
1223 2006-01-06 Jim Meyering <jim@meyering.net>
1225 * Makefile.maint (copyright-check): Use date +%Y in place of
1228 * src/remove.c (rm_1): Remove `static' attribute on local `status'.
1229 First off, the attribute should have been `volatile' (not static)
1230 to avoid longjmp-related risk of clobber. Secondly, now there is
1231 no longer any risk of a local variable being clobbered, so there's
1232 no need for any attribute at all.
1234 2006-01-05 Jim Meyering <jim@meyering.net>
1236 * src/remove.c: Give a few functions the inline attribute.
1237 (AD_pop_and_chdir): Use gotos to avoid some duplication.
1238 (AD_push): Rewrite an assertion so that the entire computation
1239 goes away when assertions are turned off.
1241 * src/tail.c (ENOSYS) [!defined ENOSYS]: Don't define here.
1242 It's already defined in "system.h".
1243 * Makefile.maint: Add a FIXME comment.
1245 2006-01-04 Jim Meyering <jim@meyering.net>
1247 * ChangeLog: Remove entries from 2005-10-22 and earlier.
1248 * ChangeLog-2005: New file, for entries up to version 5.92.
1250 2006-01-03 Jim Meyering <jim@meyering.net>
1252 * tests/du/no-x: Also allow a slightly different diagnostic -- the
1253 one you get when using openat-enabled fts.c and du (coming soon).
1254 * tests/chmod/no-x: Likewise.
1255 * tests/chgrp/no-x: Likewise.
1257 * src/system.h (O_DIRECTORY) [!defined O_DIRECTORY]: Define.
1259 2006-01-02 Paul Eggert <eggert@cs.ucla.edu>
1261 * src/chown-core.c (RC_do_ordinary_chown): New enum value.
1262 (restricted_chown): Return it, if the file cannot be accessed due
1263 to EPERM, or if no uid or gid are required, or if the file is
1264 neither a directory nor a regular file. Rewrite to avoid gotos.
1265 (change_file_owner): Handle RC_do_ordinary_chown case.
1266 Rewrite to avoid gotos.
1267 * tests/chgrp/basic: Make sure we can change the group of
1270 * src/date.c (usage): Explain %g, %G, and %V a bit better.
1272 2006-01-02 Jim Meyering <jim@meyering.net>
1274 * src/copy.c (set_owner): Correct a comment.
1276 * src/tail.c (parse_options): Change warning to say that --retry
1277 is useful `mainly' (not `only') when following by name.
1278 Reported here: http://bugs.debian.org/273781
1280 2006-01-01 Paul Eggert <eggert@cs.ucla.edu>
1282 * NEWS: Document that mkfifo and mknod -m no longer set special bits.
1283 * src/copy.c: Include lchmod.h.
1284 (copy_internal): Use lchmod rather than chmod.
1285 * src/cp.c: Include lchmod.h.
1286 (re_protect, make_dir_parents_private): Use lchmod rather than chmod.
1287 * src/mkdir.c: Include lchmod.h.
1288 (usage): Clarify -m's operation.
1289 (main): Use lchmod rather than chmod. Don't use lchmod unless the
1290 new mode contains bits outside the 777 range.
1291 * src/mkfifo.c (usage): Clarify -m's operation.
1292 (main): If -m is given, don't invoke chmod; use umask 0 instead.
1293 Report an error if -m asks for bits outside the 777 range.
1294 * src/mknod.c (usage, main): Likewise.
1296 * src/mkdir.c, src/mkfifo.c, src/mknod.c: Undo 2005-12-19 changes.
1298 2005-12-27 Jim Meyering <jim@meyering.net>
1300 * Makefile.maint (sc_obsolete_symbols): Prohibit use of O_NDELAY.
1301 (sc_prohibit_assert_without_use): New rule.
1302 (syntax-check-rules): Add it to the list.
1303 * .x-sc_prohibit_assert_without_use: New empty file.
1304 * Makefile.am (EXTRA_DIST): Add it.
1306 * Makefile.maint (CVS_LIST): Define in terms of $(srcdir).
1308 * cp.c, df.c, link.c, mknod.c, nice.c, sleep.c, unlink.c:
1309 Don't include <assert.h>; it wasn't used.
1311 2005-12-26 Paul Eggert <eggert@cs.ucla.edu>
1313 * src/chown-core.c (restricted_chown):
1314 Don't try O_WRONLY unless O_RDONLY failed wth EACCES.
1315 * src/remove.c (fd_to_subdirp): Open with O_DIRECTORY | O_NOCTTY
1316 | O_NOFOLLOW too, for consistency with other dir-openers.
1317 Use POSIX-preferred O_NONBLOCK rather than O_NDELAY.
1318 (is_empty_dir): Likewise.
1319 * src/shred.c (wipename): Likewise. Don't bother trying to open
1320 dir for writing, since POSIX prohibits it.
1322 2005-12-22 Jim Meyering <jim@meyering.net>
1324 * tests/help-version: Redirect stderr to /dev/full, to suppress
1325 write error diagnostic.
1327 2005-12-19 Jim Meyering <jim@meyering.net>
1329 * src/mkdir.c, src/mknod.c, src/mkfifo.c (main)
1330 Avoid a minor race condition when `-m MODE' is specified, by using
1331 open, fchown, and close rather than just chown. To do that reliably --
1332 even with an overly restrictive umask -- ensure that each mkdir,
1333 mknod and mkfifo call uses a mode including at least owner-read access.
1334 * src/mknod.c (main): When `-m MODE' is specified, exit nonzero if
1335 the subsequent chown (or equivalent open,fchown,close) fails.
1336 * tests/misc/mknod: New tests.
1337 * tests/misc/Makefile.am (TESTS): Add mknod.
1339 2005-12-17 Jim Meyering <jim@meyering.net>
1341 * src/remove.c (is_empty_dir): Open with O_NDELAY, so we don't hang,
1342 e.g., on a named pipe.
1343 (OPEN_NO_FOLLOW_SYMLINK): Remove definition. Use O_NOFOLLOW in
1344 place of all uses, since it is guaranteed (system.h) to be defined.
1346 2005-12-05 Andreas Gruenbacher <agruen@suse.de>
1348 Add POSIX ACL support
1349 * src/ls.c: Switch back from HAVE_ACL to USE_ACL: The acl() syscall
1350 is no requirement for ACL support; particularly, it does not exist
1351 on systems that have POSIX ACLs.
1352 * src/copy.h (cp_option_init) [umask_kill]: Remove member.
1353 * src/cp.c (umask_kill): With default acls, the umask is not to be
1354 applied. Remove umask_kill, don't change the process umask, and let
1355 the kernel apply the umask where appropriate.
1356 * src/cp.c (make_dir_parents_private): Fix logic for POSIX ACLs.
1357 * src/copy.c (get_dest_mode): Remove; it is obsolete after removing
1359 (copy_reg, copy_internal): Use copy_acl and set_acl
1360 instead of fchown/chown. Fix the logic for POSIX ACLs.
1361 (chown_succeded): Remove; we now always copy acls and
1362 preserve S_ISUID, S_ISGID, and S_ISVTX when needed, no matter if we
1363 did a chown before or not.
1364 * src/mv.c, src/install.c (cp_option_init): Don't set umask_kill member.
1365 * src/Makefile.am (dir_LDADD, ls_LDADD, vdir_LDADD, cp_LDADD,
1366 mv_LDADD, ginstall_LDADD): On systems with an ACL library, arrange
1367 to link with it via $(LIB_ACL), for the utilities that need it.
1369 2005-12-16 Paul Eggert <eggert@cs.ucla.edu>
1371 * src/remove.c (OPENAT_CWD_RESTORE__REQUIRE): Remove.
1372 (OPENAT_CWD_RESTORE__ALLOW_FAILURE): Likewise.
1373 (fd_to_subdirp): Remove openat_cwd_restore_allow_failure arg; its
1374 value is now signified by whether cwd_errno is null.
1375 (fd_to_subdirp, remove_dir, rm_1); Change cwd failure indicator from
1376 pointer-to-bool to pointer-to-errno-value. All callers changed.
1377 (rm_1): Don't bother setting a local cwd failure flag and then
1378 ORing it into the caller's. Just set the caller's.
1379 (rm): Use cwd failure errno value to print a slightly-better
1382 2005-12-15 Jim Meyering <jim@meyering.net>
1384 * src/stat.c (print_it): Properly handle a backslash at the
1385 end of a --printf format string. Reported by Paul Eggert.
1386 * tests/misc/stat-printf (end-bs): Add a test for the above.
1388 2005-12-15 Paul Eggert <eggert@cs.ucla.edu>
1390 * tests/acl: Port to pre-POSIX shells like Solaris 8 /bin/sh.
1391 Don't assume /etc/passwd contains user names; use 'id' instead.
1393 2005-12-15 Jim Meyering <jim@meyering.net>
1395 stat: revert behavior of --format=FMT (-c)
1396 stat: add new option: --printf=FMT
1397 * NEWS: Mention this.
1398 * src/stat.c (isodigit, octtobin, hextobin): Define.
1399 (PRINTF_OPTION): Define.
1400 (interpret_backslash_escapes, trailing_delim): New globals.
1401 (usage): Document them. Alphabetize on long option names.
1402 (print_esc_char): New function.
1403 (print_it): Rewrite, in order to handle backslash escapes.
1404 (main): Handle new option. Set globals for --format, too.
1406 * tests/misc/stat-printf: Test --printf and --format.
1407 * tests/misc/Makefile.am (TESTS): Add stat-printf.
1409 2005-12-14 Paul Eggert <eggert@cs.ucla.edu>
1411 * NEWS: sort now reports incompatible options.
1412 * src/sort.c (incompatible_options, check_ordering_compatibility):
1414 (main): Use them. Don't bother with a usage message for
1415 "sort -c a b", for consistency with other error diagnostics.
1416 * tests/sort/Test.pm (incompat1, incompat2, incompat3, incompat4):
1419 * src/cat.c (main): Undo previous change. close_stdout already
1420 does the check, so the previous change wasn't necessary.
1422 2005-12-13 Paul Eggert <eggert@cs.ucla.edu>
1424 * src/cat.c (main): Check for close (STDOUT_FILENO) failure.
1426 2005-12-12 Paul Eggert <eggert@cs.ucla.edu>
1428 Install a more-conservative approach for sort -R. It's the
1429 same basic idea as the existing code, except it uses the full ISAAC
1430 approach (called the "more kosher" approach in the existing comments).
1431 This makes "sort -R" quite a bit slower (about a factor of 2 on my
1432 little tests involving 10000 lines on a 2.4 GHz P4), but I think it's
1433 better to be conservative here at first, and review any performance
1434 improvements carefully.
1435 * .x-sc_require_config_h: Add src/rand-isaac.c.
1436 * src/rand-isaac.h: Remove. All uses now simply include rand-isaac.c.
1437 * src/Makefile.am (noinst_HEADERS): Remove rand-isaac.h.
1438 (shred_SOURCES, sort_SOURCES): Remove.
1439 (EXTRA_DIST): Add rand-isaac.c.
1440 * src/rand-isaac.c: Revert to what used to be in shred.c, without
1441 changing it to allow for varying numbers of words in the state.
1442 Alter so that we include rand-isaac.c directly rather than
1443 compiling it and linking to it. Don't include config.h or
1444 system.h; that's the includer's responsibility.
1445 Omit functions that are specific to shred.
1446 (ISAAC_LOG, ISAAC_WORDS, ISAAC_BYTES, struct isaac_state, ind):
1447 (isaac_step, struct irand_state):
1448 Resurrect these, with the same defns that used to be in shred.c.
1449 (ISAAC_SIZE, isaac_new, isaac_copy): Remove.
1450 (isaac_refill, isaac_seed_start, isaac_seed_data, irand_init, irand32):
1452 (struct isaac_state, isaac_refill, isaac_mix, isaac_init):
1453 (isaac_seed_start, isaac_seed_data, isaac_seed_finish, isaac_seed):
1454 (irand_init, irand32, irand_mod):
1455 Number of words is constant again.
1456 (struct irand_state, irand_init, irand32, irand_mod): Move to shred.c.
1457 * src/shred.c: Include rand-isaac.c rather than rand-isaac.h.
1458 * src/sort.c: Likewise.
1459 * src/shred.c (fillrand, dopass, main): Undo previous change.
1460 (struct irand_state, irand_init, irand32, irand_mod): Moved back here,
1462 * src/sort.c: Don't include md5.h; it wasn't needed.
1463 (struct keyfield): Rename random_hash to random, for consistency
1464 with the other member names. All uses changed.
1465 (usage): Tweak wording to mention STRING for --seed option.
1466 (short_options): Rorder for consistency with other programs.
1467 (rand_state): Now a struct, not a pointer to one. All uses changed.
1468 (HASH_WORDS, HASH_SIZE): Remove.
1469 (get_hash): Remove comments around resbuf size, since we can assume C89.
1470 Use a "more-kosher" (but slower) approach of invoking isaac_refill.
1471 (keycompare): Adjust to the new get_hash.
1473 (badfieldspec): Omit recently-introduced comment; it isn't needed.
1474 (main): Don't set need_random simply because gkey has it set; that
1475 doesn't necessarily mean we'll need random numbers.
1476 Redo seeding to match new get_hash approach.
1478 2005-12-10 Jim Meyering <jim@meyering.net>
1480 * src/Makefile.am (noinst_HEADERS): Add rand-isaac.h.
1482 Avoid shred segfault on 64-bit systems.
1483 * src/rand-isaac.c (isaac_refill): Don't try to negate a
1484 local of type uint32_t. Make the local an `int' instead.
1486 * NEWS: Mention sort's new options.
1488 * src/rand-isaac.c (isaac_mix): Declare to be static.
1489 Mark all other functions as `extern' so the tight-scope
1490 part of `make distcheck' passes once again.
1491 * src/rand-isaac.h (isaac_mix): Remove declaration.
1493 * src/sort.c (get_hash): Change position of `*' in parameter
1494 type to conform with convention.
1495 (main): Split a long line so it fits in 80 columns.
1496 (keycompare): Remove stray SPACE before TAB that was
1497 causing `make distcheck' to fail.
1499 * src/shred.c: Don't include gethrxtime.h. No longer needed.
1501 * tests/misc/sort-rand: New file: basic tests for the new options.
1502 * tests/misc/Makefile.am (TESTS): Add sort-rand.
1504 2005-12-10 Frederik Eaton <frederik@ofb.net>
1506 * src/Makefile.am (sort_LDADD): Add $(LIB_GETHRXTIME).
1507 (shred_SOURCES, sort_SOURCES): New macros, so we compile rand-isaac.c.
1508 * src/rand-isaac.c: New file, containing ISAAC code that was in shred.c.
1509 Make state size runtime-configurable.
1510 (isaac_new, isaac_copy): New functions.
1511 * src/rand-isaac.h: New file.
1512 * src/shred.c: Include rand-isaac.h. Move ISAAC code to rand-isaac.c.
1513 (fillrand, main): Adjust to the fact that the state size is now
1514 runtime-configurable.
1515 * src/sort.c (short_options, long_options, WORDS, keycompare, main):
1516 (usage): Add options --random-sort and --seed to implement a random
1518 Include md5.h and rand-isaac.h.
1519 (get_hash): New function.
1520 (rand_state): New var.
1521 (HASH_WORDS, HASH_SIZE): New macros.
1523 2005-12-09 Paul Eggert <eggert@cs.ucla.edu>
1525 * tests/dd/misc: Add test for dd iflags=noatime.
1527 2005-12-09 Jim Meyering <jim@meyering.net>
1529 * src/sort.c (usage): Mention white space vs -b and -t options.
1532 2005-12-09 Eric Blake <ebb9@byu.net>
1534 * src/test.c (main): Fix misleading comment.
1536 2005-12-07 Paul Eggert <eggert@cs.ucla.edu>
1538 * NEWS: Mention dd's new noatime flag.
1539 * src/system.h (O_NOATIME): Define to 0 if not already defined.
1540 * src/dd.c (flags, usage): Add support for noatime flag.
1542 2005-12-07 Jim Meyering <jim@meyering.net>
1544 Distribute the cvsu script, used only by `make syntax-check'.
1545 * Makefile.am (EXTRA_DIST): Add build-aux/cvsu.
1546 * Makefile.maint (CVS_LIST): Use build-aux/cvsu, now that we
1547 distribute a copy of this script.
1548 * .x-sc_unmarked_diagnostics: Add build-aux/cvsu.
1550 * tests/mv/acl: exit-77 before the trap, not after, if we fail
1551 to create a temporary directory on another partition.
1552 From Andreas Gruenbacher.
1554 2005-12-06 Tomas Pospisek <tpo@sourcepole.ch> (tiny change)
1556 * man/basename.x: Cross-reference to dirname and readlink.
1557 * man/dirname.x: Cross-reference to basename and readlink.
1559 2005-12-05 Andreas Gruenbacher
1561 * src/copy.c [!HAVE_FCHOWN]: Define fchown(...) to -1.
1562 (set_owner, preserve_author): New functions, factored out of copy_reg.
1563 (copy_reg): Use them.
1564 (copy_internal): Use them here, too.
1566 2005-12-04 Jim Meyering <jim@meyering.net>
1568 * src/sleep.c (usage): Say what happens with two or more arguments.
1569 Suggested by Justin Pryzby.
1571 * src/uptime.c (print_uptime): Move decl of `upsecs' into scope
1574 2005-12-03 Jim Meyering <jim@meyering.net>
1576 * src/rm.c (long_opts): Change the name of each undocumented, for-
1577 testing-only option to start with `-', so that it cannot render
1578 ambiguous any prefix it happens to share with some other option name.
1579 Problem reported by Eric Blake.
1580 * src/head.c (long_options): Likewise.
1581 * src/tail.c (long_options): Likewise.
1583 * tests/misc/head-elide-tail: Update uses of undocumented, for-
1584 testing-only --presume* options to start with `---'.
1585 * tests/rm/dangling-symlink: Likewise.
1586 * tests/rm/dir-no-w: Likewise.
1587 * tests/rm/isatty: Likewise.
1589 2005-11-30 Jim Meyering <jim@meyering.net>
1591 * Makefile.maint: Add a comment about cvsu.
1593 2005-11-25 Paul Eggert <eggert@cs.ucla.edu>
1595 * NEWS: df updates for "none", "proc", inaccessible file systems.
1596 * src/df.c (show_point): Ignore inaccessible file systems.
1597 (usage): -a includes dummy file systems, not size-0 file systems.
1599 * src/od.c (unsigned_long_long_int): Renamed from ulonglong_t,
1600 to avoid collision with POSIX name space. All uses changed.
1602 2005-11-24 Jim Meyering <jim@meyering.net>
1604 * tests/Makefile.am (EXTRA_DIST): Add acl to the list.
1605 * tests/acl: Add `$0: ' prefix to diagnostics.
1607 * .x-sc_require_config_h: Add lib/buffer-lcm.c to the list.
1609 2005-11-23 Paul Eggert <eggert@cs.ucla.edu>
1611 * src/copy.c: Improve performance a bit by optimizing away
1612 unnecessary system calls and going to a block size of at least
1613 8192 (on normal hosts, anyway). This improved performance 5% on my
1614 Debian stable host (2.4.27 kernel, x86, copying from root
1615 ext3 file system to itself).
1616 Include "buffer-lcm.h".
1617 (copy_reg): Omit last argument. All callers changed.
1618 Use xmalloc to allocate rather than trusting alloca
1619 (which is unwise with large block sizes).
1620 Declare locals more locally, if possible.
1621 Use uintptr_t words instead of int words, for a bit more speed
1622 when looking for null blocks on 64-bit hosts.
1623 Optimize away reads of zero bytes on regular files.
1624 In the typical case, insist on 8 KiB buffers, at least.
1625 Avoid unnecessary extra call to fstat when checking for sparse files.
1626 Avoid now-unnecessary cast to off_t, and "0L".
1627 Avoid unnecessary test of *new_dst when checking for same owner
1630 2005-11-22 Paul Eggert <eggert@cs.ucla.edu>
1632 * src/remove.c (rm): Don't assume C99 for-loop syntax.
1634 2005-11-22 Jim Meyering <jim@meyering.net>
1636 * src/remove.c (AD_push): Remove debugging cruft.
1638 * tests/rm/unread2 (rm): Change expected diagnostic,
1639 `cannot open directory' to `cannot remove', to align with
1641 * tests/rm/rm2: Ensure that rm now continues removing entries
1642 even after certain types of failure.
1644 * src/remove.c: Rewrite. Now, this module is reentrant on systems
1645 that provide openat (Solaris), and on systems like Linux+procfs
1646 where our openat emulation code is reentrant. This also fixes a
1647 few low-probability leaks and eliminates some code that could,
1648 in very unusual circumstances, cause rm() (via a callee) to exit.
1649 * NEWS: Mention this.
1651 * configure.ac: Put copyright dates all on one line so the
1652 emacs function that updates them works properly.
1654 2005-11-18 Paul Eggert <eggert@cs.ucla.edu>
1656 * configure.ac (AM_PROG_CC_C_O): Add. Needed for CVS Automake.
1657 Problem reported by Eric Blake.
1658 (AC_PROG_CC_STDC): Use this instead of AC_PROG_CC, so that
1659 we get a standard-conforming compiler. This relies on the new
1660 m4/c.m4 file. Note that it's a bit tricky, since c.m4 doesn't
1661 define AC_PROG_CC_STDC; we are relying on Autoconf 2.59 internals.
1662 m4/c.m4 can go away with Autoconf 2.60 comes out.
1664 2005-11-17 Jim Meyering <jim@meyering.net>
1666 * src/remove.c (AD_mark_helper): Make a `char *' parameter `const'.
1667 (AD_mark_current_as_unremovable): Likewise, but for a local.
1670 * tests/mv/acl: Let traps handle removing temporary directories.
1672 Expect acl-related tests to fail, until the corresponding
1673 patches are committed.
1674 * tests/mv/Makefile.am (XFAIL_TESTS): Add acl.
1675 * tests/cp/Makefile.am (XFAIL_TESTS): Likewise.
1677 ACL tests, from Andreas Gruenbacher.
1678 * tests/acl, tests/mv/acl, tests/cp/acl: New files.
1679 * tests/mv/Makefile.am (TESTS): Add acl.
1680 * tests/cp/Makefile.am (TESTS): Add acl.
1682 * src/ls.c (basename_is_dot_or_dotdot): Correct wording in comment.
1684 2005-11-16 Paul Eggert <eggert@cs.ucla.edu>
1686 * NEWS: Improve quality of ln's diagnostics.
1687 * src/ln.c (do_link, usage): Likewise.
1688 (do_link): Don't use alloca on a buffer of unbounded size.
1690 2005-11-16 Jim Meyering <jim@meyering.net>
1692 * tests/cp/fail-perm: Accommodate HPUX. It appears to fail
1693 with EACCES rather than EPERM. Reported by Peter O'Gorman here:
1694 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/5766
1695 This also affects AIX 4.3.3, according to Ralf Wildenhues, in
1696 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
1698 2005-11-14 Jim Meyering <jim@meyering.net>
1700 * NEWS (sort): Mention consequences of today's mkstemp-safer.c fix.
1702 2005-11-13 Jim Meyering <jim@meyering.net>
1704 * announce-gen: Accept new option, --gpg-key-id=ID and
1705 emit a blurb telling how to use the .sig files.
1706 * Makefile.cfg (gpg_key_ID): Define.
1707 * Makefile.maint (announcement): Use new option and key.
1709 Require that most .c files include <config.h>.
1710 * Makefile.maint (sc_require_config_h): New rule.
1711 (syntax-check-rules): Add it.
1712 * .x-sc_require_config_h: New file listing exceptions to the
1713 above rule. Some are legit, others are simply grandfathered in.
1714 * Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h here, too.
1716 2005-11-12 Jim Meyering <jim@meyering.net>
1718 * src/checksum.h, src/md5.c, src/sha1sum.c: Remove now-unused files.
1720 2005-11-11 Jim Meyering <jim@meyering.net>
1722 * NEWS: Mention `readlink -f' bug fix in 5.3.0 news.
1723 Mention new readlink options in 5.3.0's `New features' section.
1724 Spotted by Thomas Hood.
1726 2005-11-08 Jim Meyering <jim@meyering.net>
1728 * NEWS: Merge in changes from b5_9x branch.
1730 2005-11-08 Paul Eggert <eggert@cs.ucla.edu>
1732 * NEWS: ls now defaults to --time-style='locale', which in turn acts
1733 like --time-style='posix-long-iso' if the locale settings are messed up.
1734 * src/ls.c (decode_switches): Implement this.
1736 2005-11-08 Jim Meyering <jim@meyering.net>
1738 * tests/du/2g: s/expensive/very expensive/ in a comment.
1741 2005-10-17 Eric Blake <ebb9@byu.net>
1743 * src/ls.c (usage): Fix descriptions of --sort, --time.
1744 Reported by Vitaly A. Ostanin.
1746 2005-11-04 Paul Eggert <eggert@cs.ucla.edu>
1748 * src/ln.c: Include filenamecat.c.
1749 (FILE_BASENAME_CONCAT): Remove.
1750 (do_link): Remove last arg DEST_IS_DIR. All callers changed.
1751 (main): Use file_name_concat, base_name, and strip_trailing_slashes
1752 instead of FILE_BASENAME_CONCAT. This simplifies the code, and avoids
1755 2005-11-04 Jim Meyering <jim@meyering.net>
1757 * src/du.c (process_file): Don't overflow for files of size >= 2^31
1758 on systems with stat.st_blocks of a signed 32-bit type.
1759 This bug causes trouble on some AIX 5.1 systems.
1760 Report and trivial patch from Paul Townsend:
1761 <http://lists.gnu.org/archive/html/bug-coreutils/2005-11/msg00033.html>
1762 * NEWS: Mention this.
1764 * tests/du/2g: New (very-expensive) test for the above-fixed bug.
1765 * tests/du/Makefile.am (TESTS): Add it here.
1766 * tests/very-expensive: New file.
1767 * tests/Makefile.am (EXTRA_DIST): Add it here.
1768 * tests/cp/perm: Mark this test as `very-expensive', too.
1770 2005-11-02 Paul Eggert <eggert@cs.ucla.edu>
1772 * NEWS: Mention that rm -d and maybe ln -d are scheduled for
1774 * src/remove.h (struct rm_options): Remove unlink_dirs. All uses
1776 * src/rm.c (usage): Don't mention rm -d.
1778 2005-11-02 Jim Meyering <jim@meyering.net>
1780 * tests/dd/skip-seek: Fix typo in comment: s/fileutils/coreutils.
1781 From Andreas Schwab.
1783 * tests/dd/unblock-sync: Redirect stderr to /dev/null so the
1784 `M+N records in/out' lines don't pollute `make check' output.
1786 * tests/dd/skip-seek (sk-seek4): New test, to exercise the bug
1787 fixed on 2005-10-31. This test uses the new, IN_PIPE specifier.
1788 * tests/Coreutils.pm: Accept a new type of input specifier: IN_PIPE,
1789 to indicate that the input file should be piped into the command
1790 under test (via `cat FILE | $prog ...').
1792 * src/remove.c (remove_entry): Emit a better diagnostic when rm
1793 (without -r) fails to remove a directory on a non-Linux system.
1794 This change affects only newer Solaris systems (with priv_*
1795 functions like priv_allocset). Reported by Keith Thompson.
1797 * tests/rm/dir-nonrecur: New file/test for the above fix.
1798 * tests/rm/Makefile.am (TESTS): Add dir-nonrecur.
1800 2005-11-01 Paul Eggert <eggert@cs.ucla.edu>
1802 * NEWS: "tail -c 2 FILE" and "touch 0101000000" now operate as
1803 POSIX 1002.1-2001 requires.
1804 * src/tail.c (parse_obsolete_option): Implement this.
1805 Problem reported by Vincent Lefevre.
1806 * src/touch.c (main): Pass PDS_PRE_2000 to posixtime.
1807 * tests/tail/Test.pm (c-2, c-2-minus, c2, c2-minus): New tests.
1808 (test_vector): Add special cases for _POSIX2_VERSION, and
1809 regularize the old ones a bit.
1810 * tests/touch/obsolescent: Add y2000 test.
1812 2005-10-31 Paul Eggert <eggert@cs.ucla.edu>
1814 * src/dd.c (skip): Fix off-by-one error reported by
1815 Theodoros V. Kalamatianos.
1817 2005-10-30 Paul Eggert <eggert@cs.ucla.edu>
1819 * tests/mkdir/p-3: Require that the test be run as non-root.
1820 Problem and trivial fix reported by Theodoros V. Kalamatianos.
1822 2005-10-28 Paul Eggert <eggert@cs.ucla.edu>
1824 * src/ln.c (FILE_BASENAME_CONCAT): Omit unnecessary slashes in the
1825 boundary between DEST and SOURCE in the result.
1827 2005-10-26 Dmitry V. Levin <ldv@altlinux.org>
1829 * src/md5sum.c (main) [!O_BINARY]: Changed default read mode
1830 back to text, to sync with documentation and for backwards
1833 2005-10-25 Jim Meyering <jim@meyering.net>
1835 * tests/dircolors/simple (other-wr): Add an explicit test for
1836 the dircolors bug (NULL-dereference) fixed yesterday.
1838 2005-10-24 Jim Meyering <jim@meyering.net>
1840 * src/tac.c (tac_file): When determining whether a file is seekable,
1841 also test whether it is a tty. Using only the lseek-based test would
1842 give a false positive on Solaris. Reported by Peter Fales.
1844 2005-10-24 Dmitry V. Levin <ldv@altlinux.org>
1846 * tests/install/d-slashdot: New test, for "install -d" failure.
1847 * tests/install/Makefile.am (TESTS): Add d-slashdot.
1848 * tests/mkdir/p-slashdot: New test, for "mkdir -p" failure.
1849 * tests/mkdir/Makefile.am (TESTS): Add p-slashdot.
1851 2005-10-24 Jim Meyering <jim@meyering.net>
1853 * src/dircolors.c (ls_codes): Add missing comma.
1854 Anonymous report and patch from
1855 http://savannah.gnu.org/bugs/?func=detailitem&item_id=14849
1857 * src/dircolors.c: Add compile-time assertion that the slack_codes
1858 and ls_codes arrays have the same number of elements. This would
1859 have prevented the above-fixed bug.
1861 * src/expand.c (parse_tab_stops): Add a comment to make this function
1862 identical to the one in unexpand.c.
1863 * src/unexpand.c (parse_tab_stops): Adjust syntax to make this function
1864 identical to the one in expand.c.
1866 * src/expand.c (next_file): Don't assume fopen cannot return stdin.
1868 2005-10-23 Jim Meyering <jim@meyering.net>
1870 * src/md5sum.c (digest_check, main): Use ptr_align rather than
1871 a dangerous pointer-value-to-`unsigned' cast.
1872 * NEWS: mention the new sha* programs.
1873 * AUTHORS: Add new sha* programs.
1875 2005-08-28 David Madore <david.madore@ens.fr>
1877 Add new programs: sha224sum, sha256sum, sha384sum, sha512sum.
1878 * README: Add their names to the list.
1879 * src/md5sum.c: Provide framework for computing sha-2 hashes.
1880 * src/Makefile.am (sha224sum, sha256sum, sha384sum, sha512sum):
1881 Rules for compiling sha-2 utilities
1882 (noinst_HEADERS): Remove checksum.h.
1883 * man/sha512sum.x, man/sha384sum.x, man/sha256sum.x, man/sha224sum.x:
1885 * man/Makefile.am (dist_man_MANS): Add the corresponding .1 names.
1886 (sha224sum.1, sha256sum.1, sha384sum.1, sha512sum.1): New dependencies.
1887 * tests/misc/sha224sum, tests/misc/sha256sum: New files.
1888 * tests/misc/sha384sum, tests/misc/sha512sum: New files.
1889 * tests/misc/Makefile.am (TESTS): Add new sha224sum, sha256sum,
1890 sha384sum, sha512sum test scripts here rather that each in its
1893 2005-08-28 David Madore <david.madore@ens.fr>
1895 * tests/sha1sum/basic-1 (million-a): Add the "million a's" test (one
1896 of the FIPS test vectors).
1898 2005-10-23 Jim Meyering <jim@meyering.net>
1900 * configure.ac: Use 6.0-cvs as the version string.
1901 * NEWS: Adjust accordingly.