1 2006-06-28 Paul Eggert <eggert@cs.ucla.edu>
3 * NEWS: Support obsolete usages like "sort +1 -2" even when
4 conforming to POSIX 1003.1-2001, since this is a pure extension to
5 POSIX. Problem reported by Christian in:
6 http://lists.gnu.org/archive/html/bug-coreutils/2006-06/msg00220.html
7 * src/sort.c (main): Implement this.
9 * src/system.h (CLOSEDIR): Remove. All uses changed to closedir.
10 Autoconf 2.60 says this stuff was obsolete.
12 2006-06-28 Jim Meyering <jim@meyering.net>
14 * src/c99-to-c89.diff: Regenerate, to remove fuzz.
16 2006-06-28 Bob Proulx <bob@proulx.com> (tiny change)
18 * tests/mv/i-link-no: Work around HP-UX /bin/sh tracing problem
19 (set -x when VERBOSE=yes) when stderr is redirected before stdout
20 causing shell tracing of the stdout redirection to be written to
21 the stderr file. Avoid problem and test failure on HP-UX by
22 redirecting stderr last.
23 * tests/dd/unblock-sync: Order shell file redirections for
24 stderr and stdout in the common style.
27 2006-06-27 Jim Meyering <jim@meyering.net>
29 * tests/misc/cat-proc: Try to avoid any spurious numeric
30 differences in frequently-changing /proc/cpuinfo.
31 Reported by Nelson Beebe.
33 2006-06-26 Jim Meyering <jim@meyering.net>
35 Attempt rmdir (actually, unlinkat-with-AT_REMOVEDIR) upon any
36 fd_to_subdirp failure, not just when errno == EACCES.
37 * src/remove.c (remove_dir): Use unlinkat-with-AT_REMOVEDIR, not
38 rmdir, here, even though rmdir may happen to be adequate.
40 * NEWS: rm no longer fails to remove an empty, unreadable directory
41 * src/remove.c (remove_cwd_entries): If we can't open a directory,
42 and the failure is not being ignored, try to remove the directory
43 with rmdir (aka unlinkat-with-AT_REMOVEDIR), in case it's empty.
44 Problem report and test case from Paul Eggert in
45 <http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/7425>.
47 * tests/rm/empty-inacc: New test, for the above.
49 Avoid a segfault for wc --files0=- < /dev/null.
50 * src/wc.c (compute_number_width): Return right away if nfiles == 0.
52 2006-06-25 Jim Meyering <jim@meyering.net>
54 * NEWS: wc accepts a new option --files0-from=FILE, where FILE
55 contains a list of NUL-separated file names.
57 * src/wc.c: Include "readtokens.h".
58 (usage): Describe the new option, and adjust the `Usage':
59 with this option, no FILE may be specified on the command line.
60 (main): Handle the new option.
61 * tests/misc/wc-files0: New tests, for the above.
62 * tests/misc/wc-files0-from: Likewise.
63 * tests/misc/Makefile.am (TESTS): Add wc-files0.
65 2006-06-24 Jim Meyering <jim@meyering.net>
67 * src/md5sum.c (DIGEST_BUFFER): Remove now-unused definitions.
69 2006-06-22 Jim Meyering <jim@meyering.net>
71 * src/tee.c (tee_files): Rename from tee, to avoid conflict with
72 the function in glibc's <fcntl.h>. Reported by Andreas Schwab.
74 2006-06-19 Jim Meyering <jim@meyering.net>
76 * Makefile.cfg (local-checks-to-skip): Add changelog-check,
77 so this check is not run as part of "make distcheck".
79 2006-06-18 Bob Proulx <bob@proulx.com> (tiny change)
81 * tests/misc/pwd-long: Fix typo (s/neq/ne/) in previous change.
83 2006-06-18 Jim Meyering <jim@meyering.net>
85 * tests/misc/pwd-long: Make error output a little clearer.
87 2006-06-17 Jim Meyering <jim@meyering.net>
89 * tests/rm/inaccessible: Skip this test on systems without openat
90 support. Reported by Bob Proulx.
92 2006-06-15 Bob Proulx <bob@proulx.com> (tiny change)
94 * tests/misc/mknod: Improve permission checks to handle
95 running mkdir test in set-gid directories.
97 2006-06-14 Jim Meyering <jim@meyering.net>
99 * tests/du/basic: Revamp not to hard-code file system block sizes.
101 2006-06-12 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
103 * tests/du/Makefile.am (TESTS_ENVIRONMENT): Pass $(PERL), for
106 2006-06-11 Jim Meyering <jim@meyering.net>
108 * .gitignore: New file.
109 * Makefile.am (EXTRA_DIST): Add .gitignore.
111 Setting TIME_STYLE=long-iso in the environment would make the
112 cp/same-file test fail.
113 * tests/envvar-check (vars): Add TIME_STYLE to the list.
114 * tests/cp/same-file: Revert last change.
115 Source the envvar-check script, to ensure that TIME_STYLE
116 settings don't affect these tests.
118 2006-06-11 Paul Eggert <eggert@cs.ucla.edu>
120 * tests/cp/same-file: Execute 'ls' in the C locale, so that it
121 uses POSIX time stamp formats. Problem reported by John Nixon in
122 <http://lists.gnu.org/archive/html/bug-coreutils/2006-06/msg00062.html>.
124 2006-06-10 Jim Meyering <jim@meyering.net>
126 * NEWS: Mention the AIX-strndup-bug vs. dircolors workaround.
128 Require a "Version N.M" line at the top of the ChangeLog
129 file only when making the actual release, not when running
131 * Makefile.maint (maintainer-distcheck): Don't depend on
133 (alpha beta major): Depend on it here, instead.
135 2006-06-08 Jim Meyering <jim@meyering.net>
137 Ensure that cat works with any of the options, -A -v -e -E -T,
138 when applied to files in /proc and /sys, even when the FIONREAD
139 ioctl produces nonsensical results. Before this change, cat would
140 produce no output (or truncated output), for some linux kernels.
142 * src/cat.c (write_pending): New function, factored out of cat.
143 (cat): Also interpret a negative ioctl/FIONREAD count as indicating
144 that there are bytes to read. Some versions of linux-2.6.16 do that.
145 Write any pending output before returning.
146 Reported by Dan Jacobson in <http://bugs.debian.org/370583>.
147 * NEWS: Mention this bug fix.
148 * tests/misc/cat-proc: New file. Test for the above.
149 * tests/misc/Makefile.am (TESTS): Add cat-proc.
151 2006-06-07 Paul Eggert <eggert@cs.ucla.edu>
153 * src/expr.c (eval4): Detect overflow properly when multiplying
156 2006-06-06 Paul Eggert <eggert@cs.ucla.edu>
158 * NEWS: The 'expr' command now detects and reports integer overflow.
159 (It would be better to use extended precision instead, but that
161 * src/expr.c (integer_overflow): New function.
162 (eval4, eval3): Check for integer overflow.
164 2006-06-05 Paul Eggert <eggert@cs.ucla.edu>
166 Fix problems when building with Solaris/SVR4/etc. make, which uses a
167 different and somewhat bogus implementation of VPATH. In the
168 directory tests/misc, rename tests whose names might appear in the
169 Automake-generated rules. For example, we can't use a test named
170 'test', since Automake generates a rule that contains the text
171 "if test -f ./$$tst; ...", and this might expand to something like
172 "if ../../../coreutils-6.0/tests/misc/test -f ./$$test; ...",
173 which executes the 'test' script rather than the 'test' command.
174 * tests/misc/false-status: Renamed from tests/misc/false.
175 * tests/misc/pwd-long: Renamed from tests/misc/pwd.
176 * tests/misc/sort-merge: Renamed from tests/misc/sort.
177 ($prog): Set to 'sort' rather than to $PROG.
178 * tests/misc/test-diag: Renamed from tests/misc/test.
179 * tests/misc/Makefile.am (PROG): Take the basename of $$tst,
180 in case Solaris make has prepended the directory.
181 (TESTS): Adjust to above renamings.
182 * tests/misc/expand: Don't assign to PROG; no longer needed
183 now that Makefile.am sets PROG to the basename.
184 * tests/misc/fold: Likewise.
186 2006-06-03 Jim Meyering <jim@meyering.net>
188 Make `cp --link --no-dereference' work also on systems where the
189 link system call cannot create a hard link to a symbolic link.
190 * src/copy.c (copy_internal) [LINK_FOLLOWS_SYMLINKS]: Don't use
191 the link syscall on a symlink when it would do the wrong thing.
192 Based on the patch by Aurelien Jarno: <http://bugs.debian.org/329451>
193 * tests/cp/link-no-deref: New file/test for the above.
194 * tests/cp/Makefile.am (TESTS): Add link-no-deref.
195 * NEWS: Mention the change (doesn't affect Linux).
197 2006-06-01 Paul Eggert <eggert@cs.ucla.edu>
199 Fix some porting problems in the test cases reported by
200 Ralf Wildenhues for HP-UX 11.23 in:
201 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00238.html
202 * tests/help-version: Don't assume that \< \> works in sed.
203 * tests/misc/close-stdout: Don't assume that >&- works.
204 Add a /dev/full test.
205 * tests/touch/no-create-missing: Don't assume that >&- works.
207 2006-05-30 Jim Meyering <jim@meyering.net>
209 * src/ls.c (usage): Add `v' to the list of sorting-related options.
212 2006-05-28 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
214 * tests/cp/fail-perm: source lang-default.
215 * tests/rm/inaccessible: Likewise.
217 2006-05-28 Jim Meyering <jim@meyering.net>
219 * tests/rm/inaccessible: AIX 4.3.3 gives a different diagnostic.
220 Recognize it, too. Reported by Ralf Wildenhues, in
221 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
223 2006-05-27 Jim Meyering <jim@meyering.net>
225 * src/chgrp.c: Support new options: --preserve-root and
226 --no-preserve-root. Somehow this program was skipped when those
227 options were added to chown, chmod, and rm. Reported by
228 vaqflabuopac@spammotel.com in <http://bugs.debian.org/365656>.
229 * NEWS: Mention this.
231 2006-05-25 Paul Eggert <eggert@cs.ucla.edu>
233 * NEWS: Remove mention of --seed. We'll replace it with something
234 better, and don't want to indicate that it is supported.
235 * src/sort.c (usage): Likewise.
237 2006-05-20 Jim Meyering <jim@meyering.net>
239 * src/chmod.c (main): Use FTS_PHYSICAL here, too.
241 * src/du.c (main): Rename local, s/symlink_deref_bit/symlink_deref_bits/
242 and arrange for -D to set fts' FTS_PHYSICAL bit as well as
243 FTS_COMFOLLOW. Spotted by Justin Pryzby.
245 * gnupload: Merge changes from automake, retaining the ""--to...
246 kludge to placate overzealous `make distcheck' check.
248 2006-05-19 Jim Meyering <jim@meyering.net>
250 * src/du.c (main): Don't let -D, -L, or -P turn off the internal
251 FTS_TIGHT_CYCLE_CHECK directory traversal option.
252 Reported by Justin Pryzby in http://bugs.debian.org/367691
254 2006-05-15 Jim Meyering <jim@meyering.net>
256 * src/cp.c (usage): Correct description of -a: s/-dpR/-dpPR/.
259 2006-05-13 Jim Meyering <jim@meyering.net>
261 * tests/mv/no-target-dir: Test two more cases.
263 2006-05-11 Jim Meyering <jim@meyering.net>
265 mv -T DIR EMPTY_DIR no longer fails unconditionally
266 * src/copy.c (copy_internal): Don't manually prohibit a move where
267 the destination is an existing directory. Sometimes doing that is
268 valid. Let the rename system call enforce the rules. That is
269 allowed only when the source is a directory and the destination
270 directory (to be replaced) is empty. Reported by Eric Blake.
271 * tests/mv/no-target-dir: New file/test for this.
272 * tests/mv/Makefile.am (TESTS): Add no-target-dir.
273 * NEWS: Mention this.
275 * tests/mv/atomic: New file/test for yesterday's fix.
276 * tests/mv/Makefile.am (TESTS): Add atomic.
278 * tests/du/long-sloop: Avoid harmless `ambiguous redirect' diagnostic.
280 2006-05-10 Jim Meyering <jim@meyering.net>
282 * src/copy.c (copy_internal): Don't explicitly unlink the destination
283 when moving a symlink into the place of an existing non-directory.
284 Reported by Joshua Hudson.
285 * NEWS: mention this.
287 2006-05-07 Jim Meyering <jim@meyering.net>
289 * Makefile.maint (patch-check): Fail if patch generates any output,
290 even merely for changed offsets.
292 * src/c99-to-c89.diff: Adjust to reflect new offsets.
294 * NEWS: Mention changes affecting df, pwd, shred.
296 2006-05-06 Jim Meyering <jim@meyering.net>
298 * tests/ls/stat-vs-dirent: New test, to detect the bogus file
299 system condition where dirent.d_ino != stat.st_ino.
300 * tests/ls/Makefile.am (TESTS): Add stat-vs-dirent.
302 2006-05-06 Eric Blake <ebb9@byu.net>
304 * tests/ls/inode: Expand to test inode from readdir case.
305 * tests/ls/follow-slink: Expand to test broken links encountered
306 implicitly, favoring Solaris 9 and OpenBSD 3.4 behavior.
308 2006-05-06 Eric Blake <ebb9@byu.net>
310 * tests/mv/leak-fd: Work even on case-insensitive file system.
312 2006-05-04 Jim Meyering <jim@meyering.net>
314 * NEWS: Mention the 2006-03-19 pwd-related change that makes
315 lib/getcwd.c work around inconsistent file system dirent.d_ino data.
317 2006-05-03 Jim Meyering <jim@meyering.net>
319 * src/ls.c (DEFINE_SORT_FUNCTIONS, LIST_SORTFUNCTION_VARIANTS):
320 Use better macro parameter names: s/basename/key_name/,
321 s/basefunc/key_cmp_func. Fix typo in comment.
323 2006-04-29 Eric Blake <ebb9@byu.net>
325 * src/ls.c (main): On systems with d_type, directories_first only
326 implies format_needs_type, not format_needs_stat.
328 2006-05-03 Jim Meyering <jim@meyering.net>
330 * src/ls.c (xstrcoll_df_version, rev_xstrcoll_df_version): Add space
331 after comma in arg list, from Eric Blake.
333 2006-04-25 Paul Eggert <eggert@cs.ucla.edu>
335 * tests/misc/date (relative-3): New test, derived from a bug
336 report by John Thomas McDole.
338 2006-04-23 Francesco Montorsi <fr_m@hotmail.com>
340 New option for ls: --group-directories-first.
341 It makes ls list directories before files.
342 * NEWS [New features]: Mention it.
343 * src/ls.c (sort_type): Rearrange to use as an array index when
344 choosing sort function; added new sort_numtypes member for
346 (time_type): Add new time_numtypes member for compile-time check.
347 (directories_first): New global variable.
348 (GROUP_DIRECTORIES_FIRST_OPTION): New enum.
349 (long_options): Add --directories-first.
350 (main): Support new option.
351 (is_directory): New function.
352 (extract_dirs_from_files): Use it.
353 (DIRFIRST_CHECK, DEFINE_SORT_FUNCTIONS)
354 (LIST_SORTFUNCTION_VARIANTS): New macros.
355 (sort_functions): New global variable.
356 (sort_files): Use it.
357 (usage): Document new option.
359 2006-04-18 Paul Eggert <eggert@cs.ucla.edu>
361 * src/shred.c (fillrand): The assertion was way too weak, due to
362 what must be a typo. Strengthen it to its intended value.
363 (dopass): Don't use alloca; it's not worth the aggravation here,
364 since it's used only to get a page-aligned buffer, and page
365 alignment doesn't buy us much here. I'm suspicious that alloca
366 causes problems on some hosts, due to a recent bug report by Adam
367 Waltman: http://bugs.gentoo.org/130246.
369 2006-04-18 Jim Meyering <jim@meyering.net>
371 * tests/misc/tty-eof: Add new programs, base64, sha224sum, sha256sum,
372 sha384sum, sha512sum.
374 2006-04-17 Paul Eggert <eggert@cs.ucla.edu>
376 * src/chmod.c (describe_change): Adjust to filemode changes.
377 * src/ls.c (HAVE_ST_DM_MODE): Remove; moved to ../lib/filemode.c.
378 (print_long_format): Use (new) filemodestring rather than
379 (old) mode_string, so that we get more file types right, at least
380 in theory. Adjust to filemode changes.
381 * src/stat.c (human_access): Likewise.
383 2006-04-18 Jim Meyering <jim@meyering.net>
385 * src/ptx.c (main) [DEFAULT_IGNORE_FILE]: Remove code to use a default
386 ignore file. This has never been enabled. Reported by Eric Blake.
388 2006-04-12 Paul Eggert <eggert@cs.ucla.edu>
390 * src/ln.c (linkfunc): Remove. This method ran into a compiler/linker
391 bug in Interix. Just call symlink or link directly. All uses changed.
392 * src/setuidgid.c (main) [! HAVE_SETGROUPS]: Don't call setgroups.
393 * src/stat.c (USE_STATVFS): New macro.
394 Include <sys/statvfs.h> and use statvfs only if USE_STATVFS.
395 (NAMEMAX_FORMAT): define a bit more clearly, now that the
396 statvfs-using code is a bit more regular.
397 * src/system.h (sync) [!HAVE_SYNC]: New macro.
399 2006-04-11 Paul Eggert <eggert@cs.ucla.edu>
401 * NEWS: csplit, nl, expr now conform to POSIX better, and are
402 more-compatible with traditional Unix, with respect to regular
404 * src/csplit.c (extract_regexp): Set re_syntax_options to a
405 value that is compatible with what POSIX requires.
406 * src/nl.c (build_type_arg): Likewise.
407 * src/expr.c (docolon): Likewise. Also, don't let anchors match
408 newline; this fixes an incompatibility with tradition and with POSIX.
409 Don't warn about leading ^. POSIX says it is unspecified whether
410 ^ is a special character, which means that implementations can
411 either treat it as special or not, but either way a warning is not
412 allowed (unless the regexp is otherwise invalid). Instead, anchor
413 the expression but treat ^ as an anchor; this is the traditional
414 behavior (e.g., Solaris 10).
415 (eval4, eval3, eval2): Treat non-numeric args, division by zero,
416 and the like as invalid expressions (exit status 2), not as
417 failure of 'expr' (exit status 3). This is more consistent with
419 * tests/expr/basic (fail-a): Adjust exit status to match new expr
420 behavior, for status 2 versus 3.
422 (bre1, bre2, bre3, bre4, bre5, bre6, bre7, bre8, bre9, bre10):
423 (bre11, bre12, bre13, bre14, bre15, bre16, bre17, bre18, bre19, bre20):
424 (bre21, bre22, bre23, bre24, bre25, bre26, bre27, bre28, bre29, bre30):
425 (bre31, bre32, bre33, bre34, bre35, bre36, bre37, bre38, bre39, bre40):
426 (bre41, bre42, bre43, bre44, bre45, bre46, bre47, bre48, bre49, bre50):
427 (bre51, bre52, bre53, bre54, bre55, bre56, bre57, bre58, bre59, bre60):
428 (bre61, bre62): New tests.
429 * tests/misc/csplit: Use \{...\} in test RE, to test that we're
433 * tests/du/long-from-unreachable: Solaris 8 sh doesn't understand
434 "if !". Do not assume that 'sed' can handle long, newline-free input.
435 * tests/du/long-sloop: Likewise. Evaluate expr once, not $n times.
437 2006-04-10 Paul Eggert <eggert@cs.ucla.edu>
439 Adjust to new regex.h API (with new fastmap type), and clean
440 up the regex storage allocation a bit.
442 * src/csplit.c (struct control): Put re_compiled member at the
443 end, since it's large. Change regexpr member from char * to bool;
444 all uses changed. Add new member fastmap.
445 (extract_regexp): regexp arg is now char const *, not char *.
446 Don't bother duplicating the regular expression; it's not needed.
447 Set fastmap from new fastmap member. Don't bother allocating
448 a buffer, as the regexp code does a better job than we do.
449 * src/expr.c (docolon): Allocate and use a fastmap.
450 Don't bother allocating a buffer.
451 * src/nl.c (body_fastmap, header_fastmap, footer_fastmap):
453 (build_type_arg): New fastmap arg. All uses changed.
454 Don't bother allocating a buffer, but set a fastmap.
455 * src/ptx.c (context_regex_string, word_regex_string): Remove.
456 (context_regex, word_regex): New vars, replacing the above.
458 (struct regex_data): New type.
459 (compile_regex): Renamed from alloc_and_compile_regex, since
460 we no longer allocate storage. Arg is now a struct regex_data *,
461 not a const char *. All uses changed. Don't allocate the fastmap;
462 instead, take it from the caller. Don't convert size_t to int,
463 to avoid arithmetic overflow problems. Don't bother freeing
464 storage afterwards; it's not worth the aggravation.
465 * src/tac.c (compiled_separator_fastmap): New ver.
466 (main): Use it. Don't bother allocating a buffer.
468 2006-03-30 Jim Meyering <jim@meyering.net>
470 * src/dd.c (iwrite): Remove assignment without effect.
471 Reported by Felix Rauch Valenti.
473 2006-03-22 Eric Blake <ebb9@byu.net>
475 * src/ptx.c (usage): Remove mention of --copyright/-C.
476 (main): Alias --copyright to --version plus a deprecation warning.
477 * NEWS: Mention this.
479 2006-03-27 Jim Meyering <jim@meyering.net>
481 * src/Makefile.am (uptime_LDADD): Add $(POW_LIB), for uptime's
482 use of strtod. Tiny patch from Nickolai Zeldovich.
484 2006-03-11 Eric Blake <ebb9@byu.net>
486 * tests/misc/dirname: New file.
487 * tests/basename/Makefile.am: Delete.
488 * tests/basename/basic: Move to...
489 * tests/misc/basename: ... this new file. Add some tests,
490 including fixed behavior for //.
491 * tests/misc/Makefile.am (TESTS): Sort. Add basename, dirname.
492 * tests/Makefile.am (SUBDIRS): Remove basename.
493 * configure.ac (AC_CONFIG_FILES): Remove tests/basename.
495 Improvements to dirname/basename handling on platforms like
496 cygwin with distinct // and with drive letters.
497 * NEWS: Document new behavior.
498 * src/basename.c (main): Don't strip suffix from file system
500 * src/cp.c (target_directory_operand): Use new last_component.
501 (ASSIGN_BASENAME_STRDUPA): Likewise. Reduce time spent
502 traversing the string.
503 * src/dircolors.c (guess_shell_syntax): Use new last_component.
504 * src/install.c (target_directory_operand, install_file_in_dir):
506 * src/ln.c (target_directory_operand, main): Likewise.
507 * src/ls.c (basename_is_dot_or_dotdot): Likewise.
508 * src/mv.c (target_directory_operand, movefile): Likewise.
509 * src/remove.c (rm_1): Likewise.
510 * src/shred.c (wipename): Likewise.
511 * src/split.c (next_file_name): Likewise.
512 * src/su.c (log_su, run_shell): Likewise.
514 2006-03-23 Paul Eggert <eggert@cs.ucla.edu>
516 * NEWS: nohup diagnostics are now more precise, and nohup now
517 redirects stderr to nohup.out if stdout is closed and stderr is a tty.
518 * src/nohup.c (main): Implement this.
519 * tests/misc/nohup: Test the new behavior.
521 2006-03-12 Jim Meyering <jim@meyering.net>
523 * src/copy.c (set_author): Rename function, from preserve_author.
525 * src/remove.c (AD_pop_and_chdir): Use new macro,
526 CYCLE_CHECK_REFLECT_CHDIR_UP, rather than open-coding it.
528 * src/system.h (SAME_INODE): Remove definition.
529 Include "same-inode.h", instead.
531 2006-03-11 Eric Blake <ebb9@byu.net>
533 * src/pwd.c (robust_getcwd): Prepend only one slash, not two.
535 2006-03-10 Jim Meyering <jim@meyering.net>
537 Fix a bug whereby a user with write access to a directory being removed
538 could cause the removal of that directory to fail with an erroneous
539 diagnostic about a directory cycle. Reported by Vineet Chadha.
541 * NEWS: Mention this.
542 * src/remove.c (AD_pop_and_chdir): If the directory we're about to
543 leave (and try to rmdir) is the one whose dev_ino is being used to
544 detect a cycle, reset cycle_check_state.dev_ino to that of the parent.
546 2006-03-08 Paul Eggert <eggert@cs.ucla.edu>
548 * NEWS: Document dd's new 'directory' and 'nolinks' flags.
549 * src/dd.c (set_fd_flags): Handle file-creation flags on file
550 descriptors, rather than ignoring them.
551 * tests/dd/misc: Add test cases for append, nofollow, directory,
552 and nolinks flags. Simplify redirection to /dev/null in some cases.
554 * tests/dd/misc: iflags->iflag. This fixes a typo that meant the
555 noatime test never tested anything.
557 2006-03-05 Paul Eggert <eggert@cs.ucla.edu>
559 * src/dd.c (flags, usage): New flags directory, nolinks.
560 * src/system.h (O_NOLINKS): Define to 0 if not already defined.
562 * src/ls.c (usage): Mention that -f disables --color.
563 Problem reported by Niels Möller.
565 2006-03-03 Justin Pryzby <pryzbyj@justinpryzby.com>
567 * man/*.x: Add references to syscalls from utilities of the same name.
569 2006-03-05 Jim Meyering <jim@meyering.net>
571 * tests/help-version: Set SHELL, if not already set, in order to
572 avoid failure when `make check' is run through debuild; dircolors
573 would fail due to lack of $SHELL. Reported by Sven Joachim.
575 Make `base64 --wrap=N' work for N=0, and for N larger than SIZE_MAX.
576 * src/base64.c (wrap_write, do_encode, main): Change type of
577 parameters and locals, wrap_column, form size_t to uintmax_t.
578 (main): Adjust to use xstrtoumax, accordingly.
580 2006-03-03 Jim Meyering <jim@meyering.net>
582 Don't fail when run from an environment with SHELL not a Bourne
583 shell, e.g. `env SHELL=/bin/csh make check' would fail this test.
584 * tests/dircolors/simple: Invoke each non-failing test with -b.
585 Reported by Michael Stone.
587 2006-02-27 Jim Meyering <jim@meyering.net>
589 * tests/misc/base64: Derive --decode-using tests from the
592 * tests/misc/base64: Factor out a long constant string.
593 Split lines to stay within 80 columns.
595 * tests/misc/Makefile.am (TESTS): Add base64.
596 * tests/misc/base64: Test base64. From Simon Josefsson.
598 * src/base64.c (do_decode): Use correct type for parameter,
599 ignore_garbage: s/size_t/bool/.
601 * src/base64.c: Don't include .h files already included by system.h:
602 <string.h>, <stdlib.h>, <stdbool.h>, <limits.h>, <errno.h>.
603 Include "system.h" before the other lib/*.h header files.
604 Include <sys/types.h> before "system.h".
605 (wrap_write): Remove declaration of unused local, initial_column.
606 (wrap_write): Correct declaration syntax: s/size_t * V/size_t *V/.
608 * README: Add base64 to the list.
610 2006-02-17 Simon Josefsson <jas@extundo.com>
613 * AUTHORS: Mention base64.
615 * man/Makefile.am: Build base64.1.
616 * man/base64.x: New file.
617 * src/Makefile.am (bin_PROGRAMS): Add base64.
618 * src/base64.c: New file.
620 2006-02-25 Eric Blake <ebb9@byu.net>
622 In ls, avoid calling stat for --inode (-i), when possible.
623 * src/pwd.c (NOT_AN_INODE_NUMBER, D_INO): Move to ...
624 * src/system.h: ... here, for use in ...
625 * src/ls.c (main): ... here. Prefer dirent.d_ino to stat when
627 (gobble_file): Add inode argument.
628 (print_dir): Pass inode if available.
629 (usage): Remove inaccuracy.
631 2006-02-23 Jim Meyering <jim@meyering.net>
633 * TODO: Update/correct some obsolete entries.
635 2006-02-20 Paul Eggert <eggert@cs.ucla.edu>
637 * doc/coreutils.texi (join invocation): Mention `sort -k 1b,1'.
638 * src/join.c (usage): Likewise.
639 Documentation problem reported by Philip Kensche.
641 2006-02-20 Eric Blake <ebb9@byu.net>
643 * man/rm.x: Update documentation to match previous patch.
645 2006-02-18 Eric Blake <ebb9@byu.net>
647 New option for rm: --interactive=once (-I).
648 * NEWS: Document it, along with change to rm --interactive.
649 * TODO: Remove entry for implementing rm -I
650 * src/rm.c (INTERACTIVE_OPTION): New enum value.
651 (interactive_type): New enum.
652 (long_opts): Let interactive take an optional argument.
653 (interactive_args, interactive_types): New option arguments.
654 (usage): Document -I, --interactive=WHEN. Use program_name
655 instead of a basename.
656 (main): New -I option, new behavior to --interactive.
657 * tests/rm/interactive-once: New tests.
658 * tests/rm/interactive-always: Ditto.
659 * tests/rm/Makefile.am (TESTS): Run them.
661 2006-02-18 Jim Meyering <jim@meyering.net>
663 * Makefile.maint (sc_two_space_separator_in_usage): Make the regular
664 expression match more of the target lines, e.g., those that start with
665 `-S,' (short option followed by a comma) or that include `=[...]'.
666 Patch by Nicolas François.
667 Fix the four offenders thus exposed:
668 * src/join.c (usage): Use two spaces (not one) to separate the
669 --first-only option string from its description, so help2man formats
670 the derived man page properly.
671 * src/pr.c (usage): Likewise.
672 * src/uniq.c (usage): Likewise.
673 * src/install.c (usage): Likewise.
675 2006-02-15 Jim Meyering <jim@meyering.net>
677 * Makefile.maint (alpha beta major): For `make major', ensure that the
678 version string is of the form N.N[.N]*, where N is one or more digits.
680 2006-02-14 Jim Meyering <jim@meyering.net>
682 * INSTALL: Update from gnulib.
684 2006-02-13 Jim Meyering <jim@meyering.net>
686 * GNUmakefile (all): Emit diagnostics to stderr, not stdout.
688 2006-02-12 Jim Meyering <jim@meyering.net>
690 * Makefile.maint (patch-check): New target.
691 (local-checks-available): Add to the list.
693 2006-02-11 Jim Meyering <jim@meyering.net>
695 * src/c99-to-c89.diff: New file.
696 * src/Makefile.am (EXTRA_DIST): Add c99-to-c89.diff.
698 * .x-po-check: New file, with exclusions so that `make distcheck'
700 * Makefile.am (EXTRA_DIST): Add .x-po-check.
702 rm -r must remove an empty directory, even if it is inaccessible.
703 * src/remove.c (close_preserve_errno): New function.
704 (fd_to_subdirp): Don't print a diagnostic in this function.
705 Do it from the callers instead, unless rmdir succeeds.
706 (remove_cwd_entries, remove_dir): Adjust callers.
707 * tests/rm/empty-inacc: New test for the above.
708 * tests/rm/Makefile.am (TESTS): Add empty-inacc.
709 * NEWS: Mention this bug fix.
710 * tests/rm/rm2: Adjust two expected diagnostics, now that they're
711 a tiny bit less precise: cannot remove `a/1': ... instead of
712 cannot open directory `a/1': ...
714 * Makefile.maint (syntax-check-rules): Automatically derive this
715 list of sc_-prefixed rule names.
717 2006-02-10 Paul Eggert <eggert@cs.ucla.edu>
719 * Makefile.maint (CVS_LIST): Don't assume cvsu is available.
720 (CVS_LIST_EXCEPT): New macro, to simplify exception-processing.
721 Most uses of CVS_LIST changed to use CVS_LIST_EXCEPT.
722 (syntax-check-rules): Bring back sc_changelong. (Hmm, why did it
723 go away? was that an accident?)
724 (sc_cast_of_argument_to_free, sc_cast_of_x_alloc_return_value):
725 (sc_cast_of_alloca_return_value, sc_space_tab, sc_prohibit_atoi_atof):
726 (sc_error_exit_success, sc_file_system, sc_no_if_have_config_h):
727 (sc_system_h_headers, sc_sun_os_names, sc_trailing_blank):
728 (sc_two_space_separator_in_usage, sc_unmarked_diagnostics):
729 (sc_obsolete_symbols, sc_changelog, sc_prohibit_jm_in_m4):
730 (sc_useless_cpp_parens, makefile-check, m4-check, po-check):
731 (author_mark_check, makefile_path_separator_check):
732 Output line numbers, to simplify navigation of Emacs *compilation*
734 (sc_prohibit_atoi_atof, sc_file_system):
735 Rework slightly so that Makefile.maint doesn't get reported as a
736 violation of its own syntax rules.
737 (sc_dd_max_sym_length): Use ifneq to do nothing, instead of doing
738 it at run-time (which didn't work with Bison). Fix a makefile typo,
739 caught by Makefile.maint itself: spaces where a tab should be.
740 (po-check): Check lib/*.[ch] even if not in CVS; used by Bison,
741 which copies from ../gnulib/lib/*.[ch] to lib/*.[ch].
742 Ignore djgpp and man subdirectories, to avoid false matches with
743 Bison and coreutils, respectively. Use sort -u to remove the
744 resulting duplicates.
745 * gnupload: Rework slightly to avoid bogus warning from
746 sc_two_space_separator_in_usage.
748 2006-02-10 Jim Meyering <jim@meyering.net>
750 Use gzip's --rsyncable option only if it's available.
751 * Makefile.maint (gzip_rsyncable): New variable.
754 2006-02-08 Jim Meyering <jim@meyering.net>
756 * Makefile.maint (local-checks-available): Define in terms of
757 the expansion, $(syntax-check-rules), rather than the single,
758 top-level target `syntax-check', so that it's easier to exclude
759 individual rules (via $(local-checks-to-skip)).
760 (tgz-md5, tgz-sha1, ...): Remove now-unused definitions.
762 2006-02-07 Jim Meyering <jim@meyering.net>
764 * src/system.h (!defined O_DIRECT): If O_DIRECTIO is defined (as it
765 is on Tru64), define O_DIRECT to that. Patch From James Lemley.
767 * tests/help-version (expected_failure_status_vdir):
768 Redirect an expected disk-full diagnostic to /dev/null.
770 2006-02-06 Jim Meyering <jim@meyering.net>
772 * src/unexpand.c (usage): Use two spaces (not one) to separate the
773 --first-only option string from its description, so help2man formats
774 the derived man page properly.
775 * src/rm.c (usage): Likewise for --no-preserve-root.
776 * src/chown.c (usage): Likewise.
777 * src/chgrp.c (usage): Likewise.
779 Add a rule to ensure that the above doesn't happen again.
780 * Makefile.maint (sc_two_space_separator_in_usage): New rule.
781 (syntax-check-rules): Add it.
782 * .x-sc_two_space_separator_in_usage: New empty file.
783 * Makefile.am (EXTRA_DIST): Add .x-sc_two_space_separator_in_usage.
785 2006-02-06 Jim Meyering <jim@meyering.net>
787 * src/cp.c (usage): Use two spaces (not one) to separate each
788 option string from its description, so help2man formats the
789 derived man page properly.
790 * src/mv.c (usage): Likewise.
791 Patch from Nicolas François in http://bugs.debian.org/351601.
793 2006-02-04 Jim Meyering <jim@meyering.net>
795 * src/copy.c (copy_internal): cp -RL would fail when encountering
796 the same directory more than once in the hierarchy beneath a single
797 command-line argument. That is legitimate, e.g. when there are
798 two or more symbolic links, each pointing to some directory that
799 would not otherwise be copied. Reported by Christophe LYON.
800 * tests/cp/cp-deref: New file. Test for today's fix.
801 * tests/cp/Makefile.am (TESTS): Add cp-deref.
802 * NEWS: Document this.
804 2006-02-03 Jim Meyering <jim@meyering.net>
806 * configure.ac: Require automake-1.9.6, not 1.8.3.
808 2006-02-01 Paul Eggert <eggert@cs.ucla.edu>
810 * src/od.c (usage): Mention that -t a ignores high order bit.
811 Documentation problem reported by Ed Avis.
813 2006-02-01 Jim Meyering <jim@meyering.net>
815 * src/pwd.c (find_dir_entry): Remove unused local, `ent_sb_valid'.
817 2006-01-30 Paul Eggert <eggert@cs.ucla.edu>
819 * src/head.c (main): Use a better diagnostic when someone uses a
820 trailing numeric option in an invalid way. Problem reported by
822 * src/tail.c (parse_options): Likewise.
824 2006-01-30 Jim Meyering <jim@meyering.net>
826 * man/wc.x: Include `count' keyword in man page synopsis,
827 per suggestion from http://bugs.debian.org/181585.
829 2006-01-24 Paul Eggert <eggert@cs.ucla.edu>
831 * src/df.c (show_dev): If the file system claims to have
832 more available than total blocks, report the number of used
833 blocks as being total - available (a negative number) rather
834 than as garbage. Problem reported by Toralf Foerster.
836 2006-01-24 Jim Meyering <jim@meyering.net>
838 * src/tail.c (tail_forever): Don't exit-nonzero when an attempt
839 to put a regular file in O_NONBLOCK mode fails with EPERM.
840 That happens on Linux (up to 2.6.15) when using tail -f on a file with
841 the append-only attribute. Reported by Dean Gaudet. For details,
842 see http://savannah.gnu.org/bugs/?func=detailitem&item_id=15473.
843 * NEWS: Mention this fix.
844 * tests/tail-2/append-only: New file. Test for the above.
845 * tests/tail-2/Makefile.am (TESTS): Add append-only.
846 * tests/Makefile.am (check-root): Add tail-2/append-only
848 2006-01-21 Jim Meyering <jim@meyering.net>
850 * NEWS: Mention fts-related improvements and bug fixes.
852 2006-01-19 Jim Meyering <jim@meyering.net>
854 * tests/fmt/basic (pfx-1, pfx-2): New tests, to demonstrate the bug
855 reported as http://bugs.debian.org/147577. Forwarded by Thomas Hood.
857 2006-01-18 Jim Meyering <jim@meyering.net>
859 * tests/du/Makefile.am (TESTS): Add long-from-unreadable.
861 2006-01-17 Jim Meyering <jim@meyering.net>
863 Now that fts no longer changes the current working directory, adjust
864 its clients accordingly -- note that du.c uses fts but doesn't need
865 any adjustment, since it doesn't operate on the actual files,
866 but rather just uses the stat buffers provided by fts.
868 * src/chown-core.c: Include "openat.h".
869 Don't include "lchown.h".
870 (restricted_chown): Accept a new parameter, CWD_FD, and use it in
871 calling openat, lchownat, chownat, rather than open, lchown, chown.
873 * src/chmod.c: Include "openat.h".
874 (process_file): Use chmodat (fts->fts_cwd_fd,... in place of chmod (...
876 * tests/du/long-from-unreadable: New test, to exercise one small
879 2006-01-13 Jim Meyering <jim@meyering.net>
881 * tests/Makefile.am (SUBDIRS): Add comments discouraging the
882 addition of new directories under tests/.
884 * tests/acl: Redirect stdin to /dev/null. Otherwise, FreeBSD 5.0's
887 2006-01-12 Jim Meyering <jim@meyering.net>
889 * tests/du/long-sloop: Adjust not to hard-code the expected
890 diagnostic corresponding to ELOOP. Solaris' diagnostic differs
891 from that of GNU libc. Reported by Paul Eggert.
893 * tests/du/long-sloop: Create file at end of symlink chain.
895 * tests/misc/test: New file, with a test for one of the
896 bugs fixed by yesterday's test.c changes.
897 * tests/misc/Makefile.am (TESTS): Add test.
899 2006-01-11 Jim Meyering <jim@meyering.net>
901 * tests/du/long-sloop: New file. Test for today's fts.c bug fix.
902 That bug could make du -L, chgrp -L, or chown -L fail to diagnose
903 a very long sequence of symbolic links (not necessarily a loop).
904 * tests/du/Makefile.am (TESTS): Add long-sloop.
906 2006-01-11 Paul Eggert <eggert@cs.ucla.edu>
908 * src/test.c (test_syntax_error): Append a newline. All callers
909 changed, except for the ones that didn't already append a newline.
910 Bug reported by Eric Blake.
912 2006-01-11 Jim Meyering <jim@meyering.net>
914 * src/system.h (X2NREALLOC): Now that verify_true is no longer
915 void, cast its result to void, to avoid gcc's warning that
916 ``left-hand operand of comma expression has no effect''.
917 (DECIMAL_DIGIT_ACCUMULATE, X2REALLOC): Likewise.
919 2006-01-10 Jim Meyering <jim@meyering.net>
921 * tests/chmod/no-x: Add a test for today's fts.c fix.
923 2006-01-10 Jim Meyering <jim@meyering.net> (tiny change)
925 * src/ls.c (gobble_file): Use DTTOIF only if it's defined.
926 This is necessary for Dragonfly. Patch by Joerg Sonnenberger.
928 2006-01-10 Paul Eggert <eggert@cs.ucla.edu>
930 * src/system.h (X2NREALLOC, X2REALLOC, DECIMAL_DIGIT_ACCUMULATE):
931 Use verify_true instead of verify_expr, to sync with gnulib.
933 2006-01-08 Jim Meyering <jim@meyering.net>
935 * src/date.c (usage): Adjust the formatting of the entries for
936 %::z and %:::z (separate with two spaces, not one) so that help2man
937 formats them properly. Reported by Philip Rowlands.
939 2006-01-06 Paul Eggert <eggert@cs.ucla.edu>
941 * configure.ac (gl_IGNORE_UNUSED_LIBRARIES): Add.
943 2006-01-06 Jim Meyering <jim@meyering.net>
945 * Makefile.maint (copyright-check): Use date +%Y in place of
948 * src/remove.c (rm_1): Remove `static' attribute on local `status'.
949 First off, the attribute should have been `volatile' (not static)
950 to avoid longjmp-related risk of clobber. Secondly, now there is
951 no longer any risk of a local variable being clobbered, so there's
952 no need for any attribute at all.
954 2006-01-05 Jim Meyering <jim@meyering.net>
956 * src/remove.c: Give a few functions the inline attribute.
957 (AD_pop_and_chdir): Use gotos to avoid some duplication.
958 (AD_push): Rewrite an assertion so that the entire computation
959 goes away when assertions are turned off.
961 * src/tail.c (ENOSYS) [!defined ENOSYS]: Don't define here.
962 It's already defined in "system.h".
963 * Makefile.maint: Add a FIXME comment.
965 2006-01-04 Jim Meyering <jim@meyering.net>
967 * ChangeLog: Remove entries from 2005-10-22 and earlier.
968 * ChangeLog-2005: New file, for entries up to version 5.92.
970 2006-01-03 Jim Meyering <jim@meyering.net>
972 * tests/du/no-x: Also allow a slightly different diagnostic -- the
973 one you get when using openat-enabled fts.c and du (coming soon).
974 * tests/chmod/no-x: Likewise.
975 * tests/chgrp/no-x: Likewise.
977 * src/system.h (O_DIRECTORY) [!defined O_DIRECTORY]: Define.
979 2006-01-02 Paul Eggert <eggert@cs.ucla.edu>
981 * src/chown-core.c (RC_do_ordinary_chown): New enum value.
982 (restricted_chown): Return it, if the file cannot be accessed due
983 to EPERM, or if no uid or gid are required, or if the file is
984 neither a directory nor a regular file. Rewrite to avoid gotos.
985 (change_file_owner): Handle RC_do_ordinary_chown case.
986 Rewrite to avoid gotos.
987 * tests/chgrp/basic: Make sure we can change the group of
990 * src/date.c (usage): Explain %g, %G, and %V a bit better.
992 2006-01-02 Jim Meyering <jim@meyering.net>
994 * src/copy.c (set_owner): Correct a comment.
996 * src/tail.c (parse_options): Change warning to say that --retry
997 is useful `mainly' (not `only') when following by name.
998 Reported here: http://bugs.debian.org/273781
1000 2006-01-01 Paul Eggert <eggert@cs.ucla.edu>
1002 * NEWS: Document that mkfifo and mknod -m no longer set special bits.
1003 * src/copy.c: Include lchmod.h.
1004 (copy_internal): Use lchmod rather than chmod.
1005 * src/cp.c: Include lchmod.h.
1006 (re_protect, make_dir_parents_private): Use lchmod rather than chmod.
1007 * src/mkdir.c: Include lchmod.h.
1008 (usage): Clarify -m's operation.
1009 (main): Use lchmod rather than chmod. Don't use lchmod unless the
1010 new mode contains bits outside the 777 range.
1011 * src/mkfifo.c (usage): Clarify -m's operation.
1012 (main): If -m is given, don't invoke chmod; use umask 0 instead.
1013 Report an error if -m asks for bits outside the 777 range.
1014 * src/mknod.c (usage, main): Likewise.
1016 * src/mkdir.c, src/mkfifo.c, src/mknod.c: Undo 2005-12-19 changes.
1018 2005-12-27 Jim Meyering <jim@meyering.net>
1020 * Makefile.maint (sc_obsolete_symbols): Prohibit use of O_NDELAY.
1021 (sc_prohibit_assert_without_use): New rule.
1022 (syntax-check-rules): Add it to the list.
1023 * .x-sc_prohibit_assert_without_use: New empty file.
1024 * Makefile.am (EXTRA_DIST): Add it.
1026 * Makefile.maint (CVS_LIST): Define in terms of $(srcdir).
1028 * cp.c, df.c, link.c, mknod.c, nice.c, sleep.c, unlink.c:
1029 Don't include <assert.h>; it wasn't used.
1031 2005-12-26 Paul Eggert <eggert@cs.ucla.edu>
1033 * src/chown-core.c (restricted_chown):
1034 Don't try O_WRONLY unless O_RDONLY failed wth EACCES.
1035 * src/remove.c (fd_to_subdirp): Open with O_DIRECTORY | O_NOCTTY
1036 | O_NOFOLLOW too, for consistency with other dir-openers.
1037 Use POSIX-preferred O_NONBLOCK rather than O_NDELAY.
1038 (is_empty_dir): Likewise.
1039 * src/shred.c (wipename): Likewise. Don't bother trying to open
1040 dir for writing, since POSIX prohibits it.
1042 2005-12-22 Jim Meyering <jim@meyering.net>
1044 * tests/help-version: Redirect stderr to /dev/full, to suppress
1045 write error diagnostic.
1047 2005-12-19 Jim Meyering <jim@meyering.net>
1049 * src/mkdir.c, src/mknod.c, src/mkfifo.c (main)
1050 Avoid a minor race condition when `-m MODE' is specified, by using
1051 open, fchown, and close rather than just chown. To do that reliably --
1052 even with an overly restrictive umask -- ensure that each mkdir,
1053 mknod and mkfifo call uses a mode including at least owner-read access.
1054 * src/mknod.c (main): When `-m MODE' is specified, exit nonzero if
1055 the subsequent chown (or equivalent open,fchown,close) fails.
1056 * tests/misc/mknod: New tests.
1057 * tests/misc/Makefile.am (TESTS): Add mknod.
1059 2005-12-17 Jim Meyering <jim@meyering.net>
1061 * src/remove.c (is_empty_dir): Open with O_NDELAY, so we don't hang,
1062 e.g., on a named pipe.
1063 (OPEN_NO_FOLLOW_SYMLINK): Remove definition. Use O_NOFOLLOW in
1064 place of all uses, since it is guaranteed (system.h) to be defined.
1066 2005-12-05 Andreas Gruenbacher <agruen@suse.de>
1068 Add POSIX ACL support
1069 * src/ls.c: Switch back from HAVE_ACL to USE_ACL: The acl() syscall
1070 is no requirement for ACL support; particularly, it does not exist
1071 on systems that have POSIX ACLs.
1072 * src/copy.h (cp_option_init) [umask_kill]: Remove member.
1073 * src/cp.c (umask_kill): With default acls, the umask is not to be
1074 applied. Remove umask_kill, don't change the process umask, and let
1075 the kernel apply the umask where appropriate.
1076 * src/cp.c (make_dir_parents_private): Fix logic for POSIX ACLs.
1077 * src/copy.c (get_dest_mode): Remove; it is obsolete after removing
1079 (copy_reg, copy_internal): Use copy_acl and set_acl
1080 instead of fchown/chown. Fix the logic for POSIX ACLs.
1081 (chown_succeded): Remove; we now always copy acls and
1082 preserve S_ISUID, S_ISGID, and S_ISVTX when needed, no matter if we
1083 did a chown before or not.
1084 * src/mv.c, src/install.c (cp_option_init): Don't set umask_kill member.
1085 * src/Makefile.am (dir_LDADD, ls_LDADD, vdir_LDADD, cp_LDADD,
1086 mv_LDADD, ginstall_LDADD): On systems with an ACL library, arrange
1087 to link with it via $(LIB_ACL), for the utilities that need it.
1089 2005-12-16 Paul Eggert <eggert@cs.ucla.edu>
1091 * src/remove.c (OPENAT_CWD_RESTORE__REQUIRE): Remove.
1092 (OPENAT_CWD_RESTORE__ALLOW_FAILURE): Likewise.
1093 (fd_to_subdirp): Remove openat_cwd_restore_allow_failure arg; its
1094 value is now signified by whether cwd_errno is null.
1095 (fd_to_subdirp, remove_dir, rm_1); Change cwd failure indicator from
1096 pointer-to-bool to pointer-to-errno-value. All callers changed.
1097 (rm_1): Don't bother setting a local cwd failure flag and then
1098 ORing it into the caller's. Just set the caller's.
1099 (rm): Use cwd failure errno value to print a slightly-better
1102 2005-12-15 Jim Meyering <jim@meyering.net>
1104 * src/stat.c (print_it): Properly handle a backslash at the
1105 end of a --printf format string. Reported by Paul Eggert.
1106 * tests/misc/stat-printf (end-bs): Add a test for the above.
1108 2005-12-15 Paul Eggert <eggert@cs.ucla.edu>
1110 * tests/acl: Port to pre-POSIX shells like Solaris 8 /bin/sh.
1111 Don't assume /etc/passwd contains user names; use 'id' instead.
1113 2005-12-15 Jim Meyering <jim@meyering.net>
1115 stat: revert behavior of --format=FMT (-c)
1116 stat: add new option: --printf=FMT
1117 * NEWS: Mention this.
1118 * src/stat.c (isodigit, octtobin, hextobin): Define.
1119 (PRINTF_OPTION): Define.
1120 (interpret_backslash_escapes, trailing_delim): New globals.
1121 (usage): Document them. Alphabetize on long option names.
1122 (print_esc_char): New function.
1123 (print_it): Rewrite, in order to handle backslash escapes.
1124 (main): Handle new option. Set globals for --format, too.
1126 * tests/misc/stat-printf: Test --printf and --format.
1127 * tests/misc/Makefile.am (TESTS): Add stat-printf.
1129 2005-12-14 Paul Eggert <eggert@cs.ucla.edu>
1131 * NEWS: sort now reports incompatible options.
1132 * src/sort.c (incompatible_options, check_ordering_compatibility):
1134 (main): Use them. Don't bother with a usage message for
1135 "sort -c a b", for consistency with other error diagnostics.
1136 * tests/sort/Test.pm (incompat1, incompat2, incompat3, incompat4):
1139 * src/cat.c (main): Undo previous change. close_stdout already
1140 does the check, so the previous change wasn't necessary.
1142 2005-12-13 Paul Eggert <eggert@cs.ucla.edu>
1144 * src/cat.c (main): Check for close (STDOUT_FILENO) failure.
1146 2005-12-12 Paul Eggert <eggert@cs.ucla.edu>
1148 Install a more-conservative approach for sort -R. It's the
1149 same basic idea as the existing code, except it uses the full ISAAC
1150 approach (called the "more kosher" approach in the existing comments).
1151 This makes "sort -R" quite a bit slower (about a factor of 2 on my
1152 little tests involving 10000 lines on a 2.4 GHz P4), but I think it's
1153 better to be conservative here at first, and review any performance
1154 improvements carefully.
1155 * .x-sc_require_config_h: Add src/rand-isaac.c.
1156 * src/rand-isaac.h: Remove. All uses now simply include rand-isaac.c.
1157 * src/Makefile.am (noinst_HEADERS): Remove rand-isaac.h.
1158 (shred_SOURCES, sort_SOURCES): Remove.
1159 (EXTRA_DIST): Add rand-isaac.c.
1160 * src/rand-isaac.c: Revert to what used to be in shred.c, without
1161 changing it to allow for varying numbers of words in the state.
1162 Alter so that we include rand-isaac.c directly rather than
1163 compiling it and linking to it. Don't include config.h or
1164 system.h; that's the includer's responsibility.
1165 Omit functions that are specific to shred.
1166 (ISAAC_LOG, ISAAC_WORDS, ISAAC_BYTES, struct isaac_state, ind):
1167 (isaac_step, struct irand_state):
1168 Resurrect these, with the same defns that used to be in shred.c.
1169 (ISAAC_SIZE, isaac_new, isaac_copy): Remove.
1170 (isaac_refill, isaac_seed_start, isaac_seed_data, irand_init, irand32):
1172 (struct isaac_state, isaac_refill, isaac_mix, isaac_init):
1173 (isaac_seed_start, isaac_seed_data, isaac_seed_finish, isaac_seed):
1174 (irand_init, irand32, irand_mod):
1175 Number of words is constant again.
1176 (struct irand_state, irand_init, irand32, irand_mod): Move to shred.c.
1177 * src/shred.c: Include rand-isaac.c rather than rand-isaac.h.
1178 * src/sort.c: Likewise.
1179 * src/shred.c (fillrand, dopass, main): Undo previous change.
1180 (struct irand_state, irand_init, irand32, irand_mod): Moved back here,
1182 * src/sort.c: Don't include md5.h; it wasn't needed.
1183 (struct keyfield): Rename random_hash to random, for consistency
1184 with the other member names. All uses changed.
1185 (usage): Tweak wording to mention STRING for --seed option.
1186 (short_options): Rorder for consistency with other programs.
1187 (rand_state): Now a struct, not a pointer to one. All uses changed.
1188 (HASH_WORDS, HASH_SIZE): Remove.
1189 (get_hash): Remove comments around resbuf size, since we can assume C89.
1190 Use a "more-kosher" (but slower) approach of invoking isaac_refill.
1191 (keycompare): Adjust to the new get_hash.
1193 (badfieldspec): Omit recently-introduced comment; it isn't needed.
1194 (main): Don't set need_random simply because gkey has it set; that
1195 doesn't necessarily mean we'll need random numbers.
1196 Redo seeding to match new get_hash approach.
1198 2005-12-10 Jim Meyering <jim@meyering.net>
1200 * src/Makefile.am (noinst_HEADERS): Add rand-isaac.h.
1202 Avoid shred segfault on 64-bit systems.
1203 * src/rand-isaac.c (isaac_refill): Don't try to negate a
1204 local of type uint32_t. Make the local an `int' instead.
1206 * NEWS: Mention sort's new options.
1208 * src/rand-isaac.c (isaac_mix): Declare to be static.
1209 Mark all other functions as `extern' so the tight-scope
1210 part of `make distcheck' passes once again.
1211 * src/rand-isaac.h (isaac_mix): Remove declaration.
1213 * src/sort.c (get_hash): Change position of `*' in parameter
1214 type to conform with convention.
1215 (main): Split a long line so it fits in 80 columns.
1216 (keycompare): Remove stray SPACE before TAB that was
1217 causing `make distcheck' to fail.
1219 * src/shred.c: Don't include gethrxtime.h. No longer needed.
1221 * tests/misc/sort-rand: New file: basic tests for the new options.
1222 * tests/misc/Makefile.am (TESTS): Add sort-rand.
1224 2005-12-10 Frederik Eaton <frederik@ofb.net>
1226 * src/Makefile.am (sort_LDADD): Add $(LIB_GETHRXTIME).
1227 (shred_SOURCES, sort_SOURCES): New macros, so we compile rand-isaac.c.
1228 * src/rand-isaac.c: New file, containing ISAAC code that was in shred.c.
1229 Make state size runtime-configurable.
1230 (isaac_new, isaac_copy): New functions.
1231 * src/rand-isaac.h: New file.
1232 * src/shred.c: Include rand-isaac.h. Move ISAAC code to rand-isaac.c.
1233 (fillrand, main): Adjust to the fact that the state size is now
1234 runtime-configurable.
1235 * src/sort.c (short_options, long_options, WORDS, keycompare, main):
1236 (usage): Add options --random-sort and --seed to implement a random
1238 Include md5.h and rand-isaac.h.
1239 (get_hash): New function.
1240 (rand_state): New var.
1241 (HASH_WORDS, HASH_SIZE): New macros.
1243 2005-12-09 Paul Eggert <eggert@cs.ucla.edu>
1245 * tests/dd/misc: Add test for dd iflags=noatime.
1247 2005-12-09 Jim Meyering <jim@meyering.net>
1249 * src/sort.c (usage): Mention white space vs -b and -t options.
1252 2005-12-09 Eric Blake <ebb9@byu.net>
1254 * src/test.c (main): Fix misleading comment.
1256 2005-12-07 Paul Eggert <eggert@cs.ucla.edu>
1258 * NEWS: Mention dd's new noatime flag.
1259 * src/system.h (O_NOATIME): Define to 0 if not already defined.
1260 * src/dd.c (flags, usage): Add support for noatime flag.
1262 2005-12-07 Jim Meyering <jim@meyering.net>
1264 Distribute the cvsu script, used only by `make syntax-check'.
1265 * Makefile.am (EXTRA_DIST): Add build-aux/cvsu.
1266 * Makefile.maint (CVS_LIST): Use build-aux/cvsu, now that we
1267 distribute a copy of this script.
1268 * .x-sc_unmarked_diagnostics: Add build-aux/cvsu.
1270 * tests/mv/acl: exit-77 before the trap, not after, if we fail
1271 to create a temporary directory on another partition.
1272 From Andreas Gruenbacher.
1274 2005-12-06 Tomas Pospisek <tpo@sourcepole.ch> (tiny change)
1276 * man/basename.x: Cross-reference to dirname and readlink.
1277 * man/dirname.x: Cross-reference to basename and readlink.
1279 2005-12-05 Andreas Gruenbacher
1281 * src/copy.c [!HAVE_FCHOWN]: Define fchown(...) to -1.
1282 (set_owner, preserve_author): New functions, factored out of copy_reg.
1283 (copy_reg): Use them.
1284 (copy_internal): Use them here, too.
1286 2005-12-04 Jim Meyering <jim@meyering.net>
1288 * src/sleep.c (usage): Say what happens with two or more arguments.
1289 Suggested by Justin Pryzby.
1291 * src/uptime.c (print_uptime): Move decl of `upsecs' into scope
1294 2005-12-03 Jim Meyering <jim@meyering.net>
1296 * src/rm.c (long_opts): Change the name of each undocumented, for-
1297 testing-only option to start with `-', so that it cannot render
1298 ambiguous any prefix it happens to share with some other option name.
1299 Problem reported by Eric Blake.
1300 * src/head.c (long_options): Likewise.
1301 * src/tail.c (long_options): Likewise.
1303 * tests/misc/head-elide-tail: Update uses of undocumented, for-
1304 testing-only --presume* options to start with `---'.
1305 * tests/rm/dangling-symlink: Likewise.
1306 * tests/rm/dir-no-w: Likewise.
1307 * tests/rm/isatty: Likewise.
1309 2005-11-30 Jim Meyering <jim@meyering.net>
1311 * Makefile.maint: Add a comment about cvsu.
1313 2005-11-25 Paul Eggert <eggert@cs.ucla.edu>
1315 * NEWS: df updates for "none", "proc", inaccessible file systems.
1316 * src/df.c (show_point): Ignore inaccessible file systems.
1317 (usage): -a includes dummy file systems, not size-0 file systems.
1319 * src/od.c (unsigned_long_long_int): Renamed from ulonglong_t,
1320 to avoid collision with POSIX name space. All uses changed.
1322 2005-11-24 Jim Meyering <jim@meyering.net>
1324 * tests/Makefile.am (EXTRA_DIST): Add acl to the list.
1325 * tests/acl: Add `$0: ' prefix to diagnostics.
1327 * .x-sc_require_config_h: Add lib/buffer-lcm.c to the list.
1329 2005-11-23 Paul Eggert <eggert@cs.ucla.edu>
1331 * src/copy.c: Improve performance a bit by optimizing away
1332 unnecessary system calls and going to a block size of at least
1333 8192 (on normal hosts, anyway). This improved performance 5% on my
1334 Debian stable host (2.4.27 kernel, x86, copying from root
1335 ext3 file system to itself).
1336 Include "buffer-lcm.h".
1337 (copy_reg): Omit last argument. All callers changed.
1338 Use xmalloc to allocate rather than trusting alloca
1339 (which is unwise with large block sizes).
1340 Declare locals more locally, if possible.
1341 Use uintptr_t words instead of int words, for a bit more speed
1342 when looking for null blocks on 64-bit hosts.
1343 Optimize away reads of zero bytes on regular files.
1344 In the typical case, insist on 8 KiB buffers, at least.
1345 Avoid unnecessary extra call to fstat when checking for sparse files.
1346 Avoid now-unnecessary cast to off_t, and "0L".
1347 Avoid unnecessary test of *new_dst when checking for same owner
1350 2005-11-22 Paul Eggert <eggert@cs.ucla.edu>
1352 * src/remove.c (rm): Don't assume C99 for-loop syntax.
1354 2005-11-22 Jim Meyering <jim@meyering.net>
1356 * src/remove.c (AD_push): Remove debugging cruft.
1358 * tests/rm/unread2 (rm): Change expected diagnostic,
1359 `cannot open directory' to `cannot remove', to align with
1361 * tests/rm/rm2: Ensure that rm now continues removing entries
1362 even after certain types of failure.
1364 * src/remove.c: Rewrite. Now, this module is reentrant on systems
1365 that provide openat (Solaris), and on systems like Linux+procfs
1366 where our openat emulation code is reentrant. This also fixes a
1367 few low-probability leaks and eliminates some code that could,
1368 in very unusual circumstances, cause rm() (via a callee) to exit.
1369 * NEWS: Mention this.
1371 * configure.ac: Put copyright dates all on one line so the
1372 emacs function that updates them works properly.
1374 2005-11-18 Paul Eggert <eggert@cs.ucla.edu>
1376 * configure.ac (AM_PROG_CC_C_O): Add. Needed for CVS Automake.
1377 Problem reported by Eric Blake.
1378 (AC_PROG_CC_STDC): Use this instead of AC_PROG_CC, so that
1379 we get a standard-conforming compiler. This relies on the new
1380 m4/c.m4 file. Note that it's a bit tricky, since c.m4 doesn't
1381 define AC_PROG_CC_STDC; we are relying on Autoconf 2.59 internals.
1382 m4/c.m4 can go away with Autoconf 2.60 comes out.
1384 2005-11-17 Jim Meyering <jim@meyering.net>
1386 * src/remove.c (AD_mark_helper): Make a `char *' parameter `const'.
1387 (AD_mark_current_as_unremovable): Likewise, but for a local.
1390 * tests/mv/acl: Let traps handle removing temporary directories.
1392 Expect acl-related tests to fail, until the corresponding
1393 patches are committed.
1394 * tests/mv/Makefile.am (XFAIL_TESTS): Add acl.
1395 * tests/cp/Makefile.am (XFAIL_TESTS): Likewise.
1397 ACL tests, from Andreas Gruenbacher.
1398 * tests/acl, tests/mv/acl, tests/cp/acl: New files.
1399 * tests/mv/Makefile.am (TESTS): Add acl.
1400 * tests/cp/Makefile.am (TESTS): Add acl.
1402 * src/ls.c (basename_is_dot_or_dotdot): Correct wording in comment.
1404 2005-11-16 Paul Eggert <eggert@cs.ucla.edu>
1406 * NEWS: Improve quality of ln's diagnostics.
1407 * src/ln.c (do_link, usage): Likewise.
1408 (do_link): Don't use alloca on a buffer of unbounded size.
1410 2005-11-16 Jim Meyering <jim@meyering.net>
1412 * tests/cp/fail-perm: Accommodate HPUX. It appears to fail
1413 with EACCES rather than EPERM. Reported by Peter O'Gorman here:
1414 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/5766
1415 This also affects AIX 4.3.3, according to Ralf Wildenhues, in
1416 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
1418 2005-11-14 Jim Meyering <jim@meyering.net>
1420 * NEWS (sort): Mention consequences of today's mkstemp-safer.c fix.
1422 2005-11-13 Jim Meyering <jim@meyering.net>
1424 * announce-gen: Accept new option, --gpg-key-id=ID and
1425 emit a blurb telling how to use the .sig files.
1426 * Makefile.cfg (gpg_key_ID): Define.
1427 * Makefile.maint (announcement): Use new option and key.
1429 Require that most .c files include <config.h>.
1430 * Makefile.maint (sc_require_config_h): New rule.
1431 (syntax-check-rules): Add it.
1432 * .x-sc_require_config_h: New file listing exceptions to the
1433 above rule. Some are legit, others are simply grandfathered in.
1434 * Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h here, too.
1436 2005-11-12 Jim Meyering <jim@meyering.net>
1438 * src/checksum.h, src/md5.c, src/sha1sum.c: Remove now-unused files.
1440 2005-11-11 Jim Meyering <jim@meyering.net>
1442 * NEWS: Mention `readlink -f' bug fix in 5.3.0 news.
1443 Mention new readlink options in 5.3.0's `New features' section.
1444 Spotted by Thomas Hood.
1446 2005-11-08 Jim Meyering <jim@meyering.net>
1448 * NEWS: Merge in changes from b5_9x branch.
1450 2005-11-08 Paul Eggert <eggert@cs.ucla.edu>
1452 * NEWS: ls now defaults to --time-style='locale', which in turn acts
1453 like --time-style='posix-long-iso' if the locale settings are messed up.
1454 * src/ls.c (decode_switches): Implement this.
1456 2005-11-08 Jim Meyering <jim@meyering.net>
1458 * tests/du/2g: s/expensive/very expensive/ in a comment.
1461 2005-10-17 Eric Blake <ebb9@byu.net>
1463 * src/ls.c (usage): Fix descriptions of --sort, --time.
1464 Reported by Vitaly A. Ostanin.
1466 2005-11-04 Paul Eggert <eggert@cs.ucla.edu>
1468 * src/ln.c: Include filenamecat.c.
1469 (FILE_BASENAME_CONCAT): Remove.
1470 (do_link): Remove last arg DEST_IS_DIR. All callers changed.
1471 (main): Use file_name_concat, base_name, and strip_trailing_slashes
1472 instead of FILE_BASENAME_CONCAT. This simplifies the code, and avoids
1475 2005-11-04 Jim Meyering <jim@meyering.net>
1477 * src/du.c (process_file): Don't overflow for files of size >= 2^31
1478 on systems with stat.st_blocks of a signed 32-bit type.
1479 This bug causes trouble on some AIX 5.1 systems.
1480 Report and trivial patch from Paul Townsend:
1481 <http://lists.gnu.org/archive/html/bug-coreutils/2005-11/msg00033.html>
1482 * NEWS: Mention this.
1484 * tests/du/2g: New (very-expensive) test for the above-fixed bug.
1485 * tests/du/Makefile.am (TESTS): Add it here.
1486 * tests/very-expensive: New file.
1487 * tests/Makefile.am (EXTRA_DIST): Add it here.
1488 * tests/cp/perm: Mark this test as `very-expensive', too.
1490 2005-11-02 Paul Eggert <eggert@cs.ucla.edu>
1492 * NEWS: Mention that rm -d and maybe ln -d are scheduled for
1494 * src/remove.h (struct rm_options): Remove unlink_dirs. All uses
1496 * src/rm.c (usage): Don't mention rm -d.
1498 2005-11-02 Jim Meyering <jim@meyering.net>
1500 * tests/dd/skip-seek: Fix typo in comment: s/fileutils/coreutils.
1501 From Andreas Schwab.
1503 * tests/dd/unblock-sync: Redirect stderr to /dev/null so the
1504 `M+N records in/out' lines don't pollute `make check' output.
1506 * tests/dd/skip-seek (sk-seek4): New test, to exercise the bug
1507 fixed on 2005-10-31. This test uses the new, IN_PIPE specifier.
1508 * tests/Coreutils.pm: Accept a new type of input specifier: IN_PIPE,
1509 to indicate that the input file should be piped into the command
1510 under test (via `cat FILE | $prog ...').
1512 * src/remove.c (remove_entry): Emit a better diagnostic when rm
1513 (without -r) fails to remove a directory on a non-Linux system.
1514 This change affects only newer Solaris systems (with priv_*
1515 functions like priv_allocset). Reported by Keith Thompson.
1517 * tests/rm/dir-nonrecur: New file/test for the above fix.
1518 * tests/rm/Makefile.am (TESTS): Add dir-nonrecur.
1520 2005-11-01 Paul Eggert <eggert@cs.ucla.edu>
1522 * NEWS: "tail -c 2 FILE" and "touch 0101000000" now operate as
1523 POSIX 1002.1-2001 requires.
1524 * src/tail.c (parse_obsolete_option): Implement this.
1525 Problem reported by Vincent Lefevre.
1526 * src/touch.c (main): Pass PDS_PRE_2000 to posixtime.
1527 * tests/tail/Test.pm (c-2, c-2-minus, c2, c2-minus): New tests.
1528 (test_vector): Add special cases for _POSIX2_VERSION, and
1529 regularize the old ones a bit.
1530 * tests/touch/obsolescent: Add y2000 test.
1532 2005-10-31 Paul Eggert <eggert@cs.ucla.edu>
1534 * src/dd.c (skip): Fix off-by-one error reported by
1535 Theodoros V. Kalamatianos.
1537 2005-10-30 Paul Eggert <eggert@cs.ucla.edu>
1539 * tests/mkdir/p-3: Require that the test be run as non-root.
1540 Problem and trivial fix reported by Theodoros V. Kalamatianos.
1542 2005-10-28 Paul Eggert <eggert@cs.ucla.edu>
1544 * src/ln.c (FILE_BASENAME_CONCAT): Omit unnecessary slashes in the
1545 boundary between DEST and SOURCE in the result.
1547 2005-10-26 Dmitry V. Levin <ldv@altlinux.org>
1549 * src/md5sum.c (main) [!O_BINARY]: Changed default read mode
1550 back to text, to sync with documentation and for backwards
1553 2005-10-25 Jim Meyering <jim@meyering.net>
1555 * tests/dircolors/simple (other-wr): Add an explicit test for
1556 the dircolors bug (NULL-dereference) fixed yesterday.
1558 2005-10-24 Jim Meyering <jim@meyering.net>
1560 * src/tac.c (tac_file): When determining whether a file is seekable,
1561 also test whether it is a tty. Using only the lseek-based test would
1562 give a false positive on Solaris. Reported by Peter Fales.
1564 2005-10-24 Dmitry V. Levin <ldv@altlinux.org>
1566 * tests/install/d-slashdot: New test, for "install -d" failure.
1567 * tests/install/Makefile.am (TESTS): Add d-slashdot.
1568 * tests/mkdir/p-slashdot: New test, for "mkdir -p" failure.
1569 * tests/mkdir/Makefile.am (TESTS): Add p-slashdot.
1571 2005-10-24 Jim Meyering <jim@meyering.net>
1573 * src/dircolors.c (ls_codes): Add missing comma.
1574 Anonymous report and patch from
1575 http://savannah.gnu.org/bugs/?func=detailitem&item_id=14849
1577 * src/dircolors.c: Add compile-time assertion that the slack_codes
1578 and ls_codes arrays have the same number of elements. This would
1579 have prevented the above-fixed bug.
1581 * src/expand.c (parse_tab_stops): Add a comment to make this function
1582 identical to the one in unexpand.c.
1583 * src/unexpand.c (parse_tab_stops): Adjust syntax to make this function
1584 identical to the one in expand.c.
1586 * src/expand.c (next_file): Don't assume fopen cannot return stdin.
1588 2005-10-23 Jim Meyering <jim@meyering.net>
1590 * src/md5sum.c (digest_check, main): Use ptr_align rather than
1591 a dangerous pointer-value-to-`unsigned' cast.
1592 * NEWS: mention the new sha* programs.
1593 * AUTHORS: Add new sha* programs.
1595 2005-08-28 David Madore <david.madore@ens.fr>
1597 Add new programs: sha224sum, sha256sum, sha384sum, sha512sum.
1598 * README: Add their names to the list.
1599 * src/md5sum.c: Provide framework for computing sha-2 hashes.
1600 * src/Makefile.am (sha224sum, sha256sum, sha384sum, sha512sum):
1601 Rules for compiling sha-2 utilities
1602 (noinst_HEADERS): Remove checksum.h.
1603 * man/sha512sum.x, man/sha384sum.x, man/sha256sum.x, man/sha224sum.x:
1605 * man/Makefile.am (dist_man_MANS): Add the corresponding .1 names.
1606 (sha224sum.1, sha256sum.1, sha384sum.1, sha512sum.1): New dependencies.
1607 * tests/misc/sha224sum, tests/misc/sha256sum: New files.
1608 * tests/misc/sha384sum, tests/misc/sha512sum: New files.
1609 * tests/misc/Makefile.am (TESTS): Add new sha224sum, sha256sum,
1610 sha384sum, sha512sum test scripts here rather that each in its
1613 2005-08-28 David Madore <david.madore@ens.fr>
1615 * tests/sha1sum/basic-1 (million-a): Add the "million a's" test (one
1616 of the FIPS test vectors).
1618 2005-10-23 Jim Meyering <jim@meyering.net>
1620 * configure.ac: Use 6.0-cvs as the version string.
1621 * NEWS: Adjust accordingly.