1 2006-02-20 Paul Eggert <eggert@cs.ucla.edu>
5 * doc/coreutils.texi (join invocation): Mention `sort -k 1b,1'.
6 * src/join.c (usage): Likewise.
7 Documentation problem reported by Philip Kensche.
9 2006-02-20 Eric Blake <ebb9@byu.net>
11 * man/rm.x: Update documentation to match previous patch.
13 2006-02-18 Eric Blake <ebb9@byu.net>
15 New option for rm: --interactive=once (-I).
16 * NEWS: Document it, along with change to rm --interactive.
17 * TODO: Remove entry for implementing rm -I
18 * src/rm.c (INTERACTIVE_OPTION): New enum value.
19 (interactive_type): New enum.
20 (long_opts): Let interactive take an optional argument.
21 (interactive_args, interactive_types): New option arguments.
22 (usage): Document -I, --interactive=WHEN. Use program_name
23 instead of a basename.
24 (main): New -I option, new behavior to --interactive.
25 * tests/rm/interactive-once: New tests.
26 * tests/rm/interactive-always: Ditto.
27 * tests/rm/Makefile.am (TESTS): Run them.
29 2006-02-18 Jim Meyering <jim@meyering.net>
31 * Makefile.maint (sc_two_space_separator_in_usage): Make the regular
32 expression match more of the target lines, e.g., those that start with
33 `-S,' (short option followed by a comma) or that include `=[...]'.
34 Patch by Nicolas François.
35 Fix the four offenders thus exposed:
36 * src/join.c (usage): Use two spaces (not one) to separate the
37 --first-only option string from its description, so help2man formats
38 the derived man page properly.
39 * src/pr.c (usage): Likewise.
40 * src/uniq.c (usage): Likewise.
41 * src/install.c (usage): Likewise.
43 2006-02-15 Jim Meyering <jim@meyering.net>
45 * Makefile.maint (alpha beta major): For `make major', ensure that the
46 version string is of the form N.N[.N]*, where N is one or more digits.
48 2006-02-14 Jim Meyering <jim@meyering.net>
50 * INSTALL: Update from gnulib.
52 2006-02-13 Jim Meyering <jim@meyering.net>
54 * GNUmakefile (all): Emit diagnostics to stderr, not stdout.
56 2006-02-12 Jim Meyering <jim@meyering.net>
58 * Makefile.maint (patch-check): New target.
59 (local-checks-available): Add to the list.
61 2006-02-11 Jim Meyering <jim@meyering.net>
63 * src/c99-to-c89.diff: New file.
64 * src/Makefile.am (EXTRA_DIST): Add c99-to-c89.diff.
66 * .x-po-check: New file, with exclusions so that `make distcheck'
68 * Makefile.am (EXTRA_DIST): Add .x-po-check.
70 rm -r must remove an empty directory, even if it is inaccessible.
71 * src/remove.c (close_preserve_errno): New function.
72 (fd_to_subdirp): Don't print a diagnostic in this function.
73 Do it from the callers instead, unless rmdir succeeds.
74 (remove_cwd_entries, remove_dir): Adjust callers.
75 * tests/rm/empty-inacc: New test for the above.
76 * tests/rm/Makefile.am (TESTS): Add empty-inacc.
77 * NEWS: Mention this bug fix.
78 * tests/rm/rm2: Adjust two expected diagnostics, now that they're
79 a tiny bit less precise: cannot remove `a/1': ... instead of
80 cannot open directory `a/1': ...
82 * Makefile.maint (syntax-check-rules): Automatically derive this
83 list of sc_-prefixed rule names.
85 2006-02-10 Paul Eggert <eggert@cs.ucla.edu>
87 * Makefile.maint (CVS_LIST): Don't assume cvsu is available.
88 (CVS_LIST_EXCEPT): New macro, to simplify exception-processing.
89 Most uses of CVS_LIST changed to use CVS_LIST_EXCEPT.
90 (syntax-check-rules): Bring back sc_changelong. (Hmm, why did it
91 go away? was that an accident?)
92 (sc_cast_of_argument_to_free, sc_cast_of_x_alloc_return_value):
93 (sc_cast_of_alloca_return_value, sc_space_tab, sc_prohibit_atoi_atof):
94 (sc_error_exit_success, sc_file_system, sc_no_if_have_config_h):
95 (sc_system_h_headers, sc_sun_os_names, sc_trailing_blank):
96 (sc_two_space_separator_in_usage, sc_unmarked_diagnostics):
97 (sc_obsolete_symbols, sc_changelog, sc_prohibit_jm_in_m4):
98 (sc_useless_cpp_parens, makefile-check, m4-check, po-check):
99 (author_mark_check, makefile_path_separator_check):
100 Output line numbers, to simplify navigation of Emacs *compilation*
102 (sc_prohibit_atoi_atof, sc_file_system):
103 Rework slightly so that Makefile.maint doesn't get reported as a
104 violation of its own syntax rules.
105 (sc_dd_max_sym_length): Use ifneq to do nothing, instead of doing
106 it at run-time (which didn't work with Bison). Fix a makefile typo,
107 caught by Makefile.maint itself: spaces where a tab should be.
108 (po-check): Check lib/*.[ch] even if not in CVS; used by Bison,
109 which copies from ../gnulib/lib/*.[ch] to lib/*.[ch].
110 Ignore djgpp and man subdirectories, to avoid false matches with
111 Bison and coreutils, respectively. Use sort -u to remove the
112 resulting duplicates.
113 * gnupload: Rework slightly to avoid bogus warning from
114 sc_two_space_separator_in_usage.
116 2006-02-10 Jim Meyering <jim@meyering.net>
118 Use gzip's --rsyncable option only if it's available.
119 * Makefile.maint (gzip_rsyncable): New variable.
122 2006-02-08 Jim Meyering <jim@meyering.net>
124 * Makefile.maint (local-checks-available): Define in terms of
125 the expansion, $(syntax-check-rules), rather than the single,
126 top-level target `syntax-check', so that it's easier to exclude
127 individual rules (via $(local-checks-to-skip)).
128 (tgz-md5, tgz-sha1, ...): Remove now-unused definitions.
130 2006-02-07 Jim Meyering <jim@meyering.net>
132 * src/system.h (!defined O_DIRECT): If O_DIRECTIO is defined (as it
133 is on Tru64), define O_DIRECT to that. Patch From James Lemley.
135 * tests/help-version (expected_failure_status_vdir):
136 Redirect an expected disk-full diagnostic to /dev/null.
138 2006-02-06 Jim Meyering <jim@meyering.net>
140 * src/unexpand.c (usage): Use two spaces (not one) to separate the
141 --first-only option string from its description, so help2man formats
142 the derived man page properly.
143 * src/rm.c (usage): Likewise for --no-preserve-root.
144 * src/chown.c (usage): Likewise.
145 * src/chgrp.c (usage): Likewise.
147 Add a rule to ensure that the above doesn't happen again.
148 * Makefile.maint (sc_two_space_separator_in_usage): New rule.
149 (syntax-check-rules): Add it.
150 * .x-sc_two_space_separator_in_usage: New empty file.
151 * Makefile.am (EXTRA_DIST): Add .x-sc_two_space_separator_in_usage.
153 2006-02-06 Jim Meyering <jim@meyering.net>
155 * src/cp.c (usage): Use two spaces (not one) to separate each
156 option string from its description, so help2man formats the
157 derived man page properly.
158 * src/mv.c (usage): Likewise.
159 Patch from Nicolas François in http://bugs.debian.org/351601.
161 2006-02-04 Jim Meyering <jim@meyering.net>
163 * src/copy.c (copy_internal): cp -RL would fail when encountering
164 the same directory more than once in the hierarchy beneath a single
165 command-line argument. That is legitimate, e.g. when there are
166 two or more symbolic links, each pointing to some directory that
167 would not otherwise be copied. Reported by Christophe LYON.
168 * tests/cp/cp-deref: New file. Test for today's fix.
169 * tests/cp/Makefile.am (TESTS): Add cp-deref.
170 * NEWS: Document this.
172 2006-02-03 Jim Meyering <jim@meyering.net>
174 * configure.ac: Require automake-1.9.6, not 1.8.3.
176 2006-02-01 Paul Eggert <eggert@cs.ucla.edu>
178 * src/od.c (usage): Mention that -t a ignores high order bit.
179 Documentation problem reported by Ed Avis.
181 2006-02-01 Jim Meyering <jim@meyering.net>
183 * src/pwd.c (find_dir_entry): Remove unused local, `ent_sb_valid'.
185 2006-01-30 Paul Eggert <eggert@cs.ucla.edu>
187 * src/head.c (main): Use a better diagnostic when someone uses a
188 trailing numeric option in an invalid way. Problem reported by
190 * src/tail.c (parse_options): Likewise.
192 2006-01-30 Jim Meyering <jim@meyering.net>
194 * man/wc.x: Include `count' keyword in man page synopsis,
195 per suggestion from http://bugs.debian.org/181585.
197 2006-01-24 Paul Eggert <eggert@cs.ucla.edu>
199 * src/df.c (show_dev): If the file system claims to have
200 more available than total blocks, report the number of used
201 blocks as being total - available (a negative number) rather
202 than as garbage. Problem reported by Toralf Foerster.
204 2006-01-24 Jim Meyering <jim@meyering.net>
206 * src/tail.c (tail_forever): Don't exit-nonzero when an attempt
207 to put a regular file in O_NONBLOCK mode fails with EPERM.
208 That happens on Linux (up to 2.6.15) when using tail -f on a file with
209 the append-only attribute. Reported by Dean Gaudet. For details,
210 see http://savannah.gnu.org/bugs/?func=detailitem&item_id=15473.
211 * NEWS: Mention this fix.
212 * tests/tail-2/append-only: New file. Test for the above.
213 * tests/tail-2/Makefile.am (TESTS): Add append-only.
214 * tests/Makefile.am (check-root): Add tail-2/append-only
216 2006-01-21 Jim Meyering <jim@meyering.net>
218 * NEWS: Mention fts-related improvements and bug fixes.
220 2006-01-19 Jim Meyering <jim@meyering.net>
222 * tests/fmt/basic (pfx-1, pfx-2): New tests, to demonstrate the bug
223 reported as http://bugs.debian.org/147577. Forwarded by Thomas Hood.
225 2006-01-18 Jim Meyering <jim@meyering.net>
227 * tests/du/Makefile.am (TESTS): Add long-from-unreadable.
229 2006-01-17 Jim Meyering <jim@meyering.net>
231 Now that fts no longer changes the current working directory, adjust
232 its clients accordingly -- note that du.c uses fts but doesn't need
233 any adjustment, since it doesn't operate on the actual files,
234 but rather just uses the stat buffers provided by fts.
236 * src/chown-core.c: Include "openat.h".
237 Don't include "lchown.h".
238 (restricted_chown): Accept a new parameter, CWD_FD, and use it in
239 calling openat, lchownat, chownat, rather than open, lchown, chown.
241 * src/chmod.c: Include "openat.h".
242 (process_file): Use chmodat (fts->fts_cwd_fd,... in place of chmod (...
244 * tests/du/long-from-unreadable: New test, to exercise one small
247 2006-01-13 Jim Meyering <jim@meyering.net>
249 * tests/Makefile.am (SUBDIRS): Add comments discouraging the
250 addition of new directories under tests/.
252 * tests/acl: Redirect stdin to /dev/null. Otherwise, FreeBSD 5.0's
255 2006-01-12 Jim Meyering <jim@meyering.net>
257 * tests/du/long-sloop: Adjust not to hard-code the expected
258 diagnostic corresponding to ELOOP. Solaris' diagnostic differs
259 from that of GNU libc. Reported by Paul Eggert.
261 * tests/du/long-sloop: Create file at end of symlink chain.
263 * tests/misc/test: New file, with a test for one of the
264 bugs fixed by yesterday's test.c changes.
265 * tests/misc/Makefile.am (TESTS): Add test.
267 2006-01-11 Jim Meyering <jim@meyering.net>
269 * tests/du/long-sloop: New file. Test for today's fts.c bug fix.
270 That bug could make du -L, chgrp -L, or chown -L fail to diagnose
271 a very long sequence of symbolic links (not necessarily a loop).
272 * tests/du/Makefile.am (TESTS): Add long-sloop.
274 2006-01-11 Paul Eggert <eggert@cs.ucla.edu>
276 * src/test.c (test_syntax_error): Append a newline. All callers
277 changed, except for the ones that didn't already append a newline.
278 Bug reported by Eric Blake.
280 2006-01-11 Jim Meyering <jim@meyering.net>
282 * src/system.h (X2NREALLOC): Now that verify_true is no longer
283 void, cast its result to void, to avoid gcc's warning that
284 ``left-hand operand of comma expression has no effect''.
285 (DECIMAL_DIGIT_ACCUMULATE, X2REALLOC): Likewise.
287 2006-01-10 Jim Meyering <jim@meyering.net>
289 * tests/chmod/no-x: Add a test for today's fts.c fix.
291 2006-01-10 Jim Meyering <jim@meyering.net> (tiny change)
293 * src/ls.c (gobble_file): Use DTTOIF only if it's defined.
294 This is necessary for Dragonfly. Patch by Joerg Sonnenberger.
296 2006-01-10 Paul Eggert <eggert@cs.ucla.edu>
298 * src/system.h (X2NREALLOC, X2REALLOC, DECIMAL_DIGIT_ACCUMULATE):
299 Use verify_true instead of verify_expr, to sync with gnulib.
301 2006-01-08 Jim Meyering <jim@meyering.net>
303 * src/date.c (usage): Adjust the formatting of the entries for
304 %::z and %:::z (separate with two spaces, not one) so that help2man
305 formats them properly. Reported by Philip Rowlands.
307 2006-01-06 Paul Eggert <eggert@cs.ucla.edu>
309 * configure.ac (gl_IGNORE_UNUSED_LIBRARIES): Add.
311 2006-01-06 Jim Meyering <jim@meyering.net>
313 * Makefile.maint (copyright-check): Use date +%Y in place of
316 * src/remove.c (rm_1): Remove `static' attribute on local `status'.
317 First off, the attribute should have been `volatile' (not static)
318 to avoid longjmp-related risk of clobber. Secondly, now there is
319 no longer any risk of a local variable being clobbered, so there's
320 no need for any attribute at all.
322 2006-01-05 Jim Meyering <jim@meyering.net>
324 * src/remove.c: Give a few functions the inline attribute.
325 (AD_pop_and_chdir): Use gotos to avoid some duplication.
326 (AD_push): Rewrite an assertion so that the entire computation
327 goes away when assertions are turned off.
329 * src/tail.c (ENOSYS) [!defined ENOSYS]: Don't define here.
330 It's already defined in "system.h".
331 * Makefile.maint: Add a FIXME comment.
333 2006-01-04 Jim Meyering <jim@meyering.net>
335 * ChangeLog: Remove entries from 2005-10-22 and earlier.
336 * ChangeLog-2005: New file, for entries up to version 5.92.
338 2006-01-03 Jim Meyering <jim@meyering.net>
340 * tests/du/no-x: Also allow a slightly different diagnostic -- the
341 one you get when using openat-enabled fts.c and du (coming soon).
342 * tests/chmod/no-x: Likewise.
343 * tests/chgrp/no-x: Likewise.
345 * src/system.h (O_DIRECTORY) [!defined O_DIRECTORY]: Define.
347 2006-01-02 Paul Eggert <eggert@cs.ucla.edu>
349 * src/chown-core.c (RC_do_ordinary_chown): New enum value.
350 (restricted_chown): Return it, if the file cannot be accessed due
351 to EPERM, or if no uid or gid are required, or if the file is
352 neither a directory nor a regular file. Rewrite to avoid gotos.
353 (change_file_owner): Handle RC_do_ordinary_chown case.
354 Rewrite to avoid gotos.
355 * tests/chgrp/basic: Make sure we can change the group of
358 * src/date.c (usage): Explain %g, %G, and %V a bit better.
360 2006-01-02 Jim Meyering <jim@meyering.net>
362 * src/copy.c (set_owner): Correct a comment.
364 * src/tail.c (parse_options): Change warning to say that --retry
365 is useful `mainly' (not `only') when following by name.
366 Reported here: http://bugs.debian.org/273781
368 2006-01-01 Paul Eggert <eggert@cs.ucla.edu>
370 * NEWS: Document that mkfifo and mknod -m no longer set special bits.
371 * src/copy.c: Include lchmod.h.
372 (copy_internal): Use lchmod rather than chmod.
373 * src/cp.c: Include lchmod.h.
374 (re_protect, make_dir_parents_private): Use lchmod rather than chmod.
375 * src/mkdir.c: Include lchmod.h.
376 (usage): Clarify -m's operation.
377 (main): Use lchmod rather than chmod. Don't use lchmod unless the
378 new mode contains bits outside the 777 range.
379 * src/mkfifo.c (usage): Clarify -m's operation.
380 (main): If -m is given, don't invoke chmod; use umask 0 instead.
381 Report an error if -m asks for bits outside the 777 range.
382 * src/mknod.c (usage, main): Likewise.
384 * src/mkdir.c, src/mkfifo.c, src/mknod.c: Undo 2005-12-19 changes.
386 2005-12-27 Jim Meyering <jim@meyering.net>
388 * Makefile.maint (sc_obsolete_symbols): Prohibit use of O_NDELAY.
389 (sc_prohibit_assert_without_use): New rule.
390 (syntax-check-rules): Add it to the list.
391 * .x-sc_prohibit_assert_without_use: New empty file.
392 * Makefile.am (EXTRA_DIST): Add it.
394 * Makefile.maint (CVS_LIST): Define in terms of $(srcdir).
396 * cp.c, df.c, link.c, mknod.c, nice.c, sleep.c, unlink.c:
397 Don't include <assert.h>; it wasn't used.
399 2005-12-26 Paul Eggert <eggert@cs.ucla.edu>
401 * src/chown-core.c (restricted_chown):
402 Don't try O_WRONLY unless O_RDONLY failed wth EACCES.
403 * src/remove.c (fd_to_subdirp): Open with O_DIRECTORY | O_NOCTTY
404 | O_NOFOLLOW too, for consistency with other dir-openers.
405 Use POSIX-preferred O_NONBLOCK rather than O_NDELAY.
406 (is_empty_dir): Likewise.
407 * src/shred.c (wipename): Likewise. Don't bother trying to open
408 dir for writing, since POSIX prohibits it.
410 2005-12-22 Jim Meyering <jim@meyering.net>
412 * tests/help-version: Redirect stderr to /dev/full, to suppress
413 write error diagnostic.
415 2005-12-19 Jim Meyering <jim@meyering.net>
417 * src/mkdir.c, src/mknod.c, src/mkfifo.c (main)
418 Avoid a minor race condition when `-m MODE' is specified, by using
419 open, fchown, and close rather than just chown. To do that reliably --
420 even with an overly restrictive umask -- ensure that each mkdir,
421 mknod and mkfifo call uses a mode including at least owner-read access.
422 * src/mknod.c (main): When `-m MODE' is specified, exit nonzero if
423 the subsequent chown (or equivalent open,fchown,close) fails.
424 * tests/misc/mknod: New tests.
425 * tests/misc/Makefile.am (TESTS): Add mknod.
427 2005-12-17 Jim Meyering <jim@meyering.net>
429 * src/remove.c (is_empty_dir): Open with O_NDELAY, so we don't hang,
430 e.g., on a named pipe.
431 (OPEN_NO_FOLLOW_SYMLINK): Remove definition. Use O_NOFOLLOW in
432 place of all uses, since it is guaranteed (system.h) to be defined.
434 2005-12-05 Andreas Gruenbacher <agruen@suse.de>
436 Add POSIX ACL support
437 * src/ls.c: Switch back from HAVE_ACL to USE_ACL: The acl() syscall
438 is no requirement for ACL support; particularly, it does not exist
439 on systems that have POSIX ACLs.
440 * src/copy.h (cp_option_init) [umask_kill]: Remove member.
441 * src/cp.c (umask_kill): With default acls, the umask is not to be
442 applied. Remove umask_kill, don't change the process umask, and let
443 the kernel apply the umask where appropriate.
444 * src/cp.c (make_dir_parents_private): Fix logic for POSIX ACLs.
445 * src/copy.c (get_dest_mode): Remove; it is obsolete after removing
447 (copy_reg, copy_internal): Use copy_acl and set_acl
448 instead of fchown/chown. Fix the logic for POSIX ACLs.
449 (chown_succeded): Remove; we now always copy acls and
450 preserve S_ISUID, S_ISGID, and S_ISVTX when needed, no matter if we
451 did a chown before or not.
452 * src/mv.c, src/install.c (cp_option_init): Don't set umask_kill member.
453 * src/Makefile.am (dir_LDADD, ls_LDADD, vdir_LDADD, cp_LDADD,
454 mv_LDADD, ginstall_LDADD): On systems with an ACL library, arrange
455 to link with it via $(LIB_ACL), for the utilities that need it.
457 2005-12-16 Paul Eggert <eggert@cs.ucla.edu>
459 * src/remove.c (OPENAT_CWD_RESTORE__REQUIRE): Remove.
460 (OPENAT_CWD_RESTORE__ALLOW_FAILURE): Likewise.
461 (fd_to_subdirp): Remove openat_cwd_restore_allow_failure arg; its
462 value is now signified by whether cwd_errno is null.
463 (fd_to_subdirp, remove_dir, rm_1); Change cwd failure indicator from
464 pointer-to-bool to pointer-to-errno-value. All callers changed.
465 (rm_1): Don't bother setting a local cwd failure flag and then
466 ORing it into the caller's. Just set the caller's.
467 (rm): Use cwd failure errno value to print a slightly-better
470 2005-12-15 Jim Meyering <jim@meyering.net>
472 * src/stat.c (print_it): Properly handle a backslash at the
473 end of a --printf format string. Reported by Paul Eggert.
474 * tests/misc/stat-printf (end-bs): Add a test for the above.
476 2005-12-15 Paul Eggert <eggert@cs.ucla.edu>
478 * tests/acl: Port to pre-POSIX shells like Solaris 8 /bin/sh.
479 Don't assume /etc/passwd contains user names; use 'id' instead.
481 2005-12-15 Jim Meyering <jim@meyering.net>
483 stat: revert behavior of --format=FMT (-c)
484 stat: add new option: --printf=FMT
485 * NEWS: Mention this.
486 * src/stat.c (isodigit, octtobin, hextobin): Define.
487 (PRINTF_OPTION): Define.
488 (interpret_backslash_escapes, trailing_delim): New globals.
489 (usage): Document them. Alphabetize on long option names.
490 (print_esc_char): New function.
491 (print_it): Rewrite, in order to handle backslash escapes.
492 (main): Handle new option. Set globals for --format, too.
494 * tests/misc/stat-printf: Test --printf and --format.
495 * tests/misc/Makefile.am (TESTS): Add stat-printf.
497 2005-12-14 Paul Eggert <eggert@cs.ucla.edu>
499 * NEWS: sort now reports incompatible options.
500 * src/sort.c (incompatible_options, check_ordering_compatibility):
502 (main): Use them. Don't bother with a usage message for
503 "sort -c a b", for consistency with other error diagnostics.
504 * tests/sort/Test.pm (incompat1, incompat2, incompat3, incompat4):
507 * src/cat.c (main): Undo previous change. close_stdout already
508 does the check, so the previous change wasn't necessary.
510 2005-12-13 Paul Eggert <eggert@cs.ucla.edu>
512 * src/cat.c (main): Check for close (STDOUT_FILENO) failure.
514 2005-12-12 Paul Eggert <eggert@cs.ucla.edu>
516 Install a more-conservative approach for sort -R. It's the
517 same basic idea as the existing code, except it uses the full ISAAC
518 approach (called the "more kosher" approach in the existing comments).
519 This makes "sort -R" quite a bit slower (about a factor of 2 on my
520 little tests involving 10000 lines on a 2.4 GHz P4), but I think it's
521 better to be conservative here at first, and review any performance
522 improvements carefully.
523 * .x-sc_require_config_h: Add src/rand-isaac.c.
524 * src/rand-isaac.h: Remove. All uses now simply include rand-isaac.c.
525 * src/Makefile.am (noinst_HEADERS): Remove rand-isaac.h.
526 (shred_SOURCES, sort_SOURCES): Remove.
527 (EXTRA_DIST): Add rand-isaac.c.
528 * src/rand-isaac.c: Revert to what used to be in shred.c, without
529 changing it to allow for varying numbers of words in the state.
530 Alter so that we include rand-isaac.c directly rather than
531 compiling it and linking to it. Don't include config.h or
532 system.h; that's the includer's responsibility.
533 Omit functions that are specific to shred.
534 (ISAAC_LOG, ISAAC_WORDS, ISAAC_BYTES, struct isaac_state, ind):
535 (isaac_step, struct irand_state):
536 Resurrect these, with the same defns that used to be in shred.c.
537 (ISAAC_SIZE, isaac_new, isaac_copy): Remove.
538 (isaac_refill, isaac_seed_start, isaac_seed_data, irand_init, irand32):
540 (struct isaac_state, isaac_refill, isaac_mix, isaac_init):
541 (isaac_seed_start, isaac_seed_data, isaac_seed_finish, isaac_seed):
542 (irand_init, irand32, irand_mod):
543 Number of words is constant again.
544 (struct irand_state, irand_init, irand32, irand_mod): Move to shred.c.
545 * src/shred.c: Include rand-isaac.c rather than rand-isaac.h.
546 * src/sort.c: Likewise.
547 * src/shred.c (fillrand, dopass, main): Undo previous change.
548 (struct irand_state, irand_init, irand32, irand_mod): Moved back here,
550 * src/sort.c: Don't include md5.h; it wasn't needed.
551 (struct keyfield): Rename random_hash to random, for consistency
552 with the other member names. All uses changed.
553 (usage): Tweak wording to mention STRING for --seed option.
554 (short_options): Rorder for consistency with other programs.
555 (rand_state): Now a struct, not a pointer to one. All uses changed.
556 (HASH_WORDS, HASH_SIZE): Remove.
557 (get_hash): Remove comments around resbuf size, since we can assume C89.
558 Use a "more-kosher" (but slower) approach of invoking isaac_refill.
559 (keycompare): Adjust to the new get_hash.
561 (badfieldspec): Omit recently-introduced comment; it isn't needed.
562 (main): Don't set need_random simply because gkey has it set; that
563 doesn't necessarily mean we'll need random numbers.
564 Redo seeding to match new get_hash approach.
566 2005-12-10 Jim Meyering <jim@meyering.net>
568 * src/Makefile.am (noinst_HEADERS): Add rand-isaac.h.
570 Avoid shred segfault on 64-bit systems.
571 * src/rand-isaac.c (isaac_refill): Don't try to negate a
572 local of type uint32_t. Make the local an `int' instead.
574 * NEWS: Mention sort's new options.
576 * src/rand-isaac.c (isaac_mix): Declare to be static.
577 Mark all other functions as `extern' so the tight-scope
578 part of `make distcheck' passes once again.
579 * src/rand-isaac.h (isaac_mix): Remove declaration.
581 * src/sort.c (get_hash): Change position of `*' in parameter
582 type to conform with convention.
583 (main): Split a long line so it fits in 80 columns.
584 (keycompare): Remove stray SPACE before TAB that was
585 causing `make distcheck' to fail.
587 * src/shred.c: Don't include gethrxtime.h. No longer needed.
589 * tests/misc/sort-rand: New file: basic tests for the new options.
590 * tests/misc/Makefile.am (TESTS): Add sort-rand.
592 2005-12-10 Frederik Eaton <frederik@ofb.net>
594 * src/Makefile.am (sort_LDADD): Add $(LIB_GETHRXTIME).
595 (shred_SOURCES, sort_SOURCES): New macros, so we compile rand-isaac.c.
596 * src/rand-isaac.c: New file, containing ISAAC code that was in shred.c.
597 Make state size runtime-configurable.
598 (isaac_new, isaac_copy): New functions.
599 * src/rand-isaac.h: New file.
600 * src/shred.c: Include rand-isaac.h. Move ISAAC code to rand-isaac.c.
601 (fillrand, main): Adjust to the fact that the state size is now
602 runtime-configurable.
603 * src/sort.c (short_options, long_options, WORDS, keycompare, main):
604 (usage): Add options --random-sort and --seed to implement a random
606 Include md5.h and rand-isaac.h.
607 (get_hash): New function.
608 (rand_state): New var.
609 (HASH_WORDS, HASH_SIZE): New macros.
611 2005-12-09 Paul Eggert <eggert@cs.ucla.edu>
613 * tests/dd/misc: Add test for dd iflags=noatime.
615 2005-12-09 Jim Meyering <jim@meyering.net>
617 * src/sort.c (usage): Mention white space vs -b and -t options.
620 2005-12-09 Eric Blake <ebb9@byu.net>
622 * src/test.c (main): Fix misleading comment.
624 2005-12-07 Paul Eggert <eggert@cs.ucla.edu>
626 * NEWS: Mention dd's new noatime flag.
627 * src/system.h (O_NOATIME): Define to 0 if not already defined.
628 * src/dd.c (flags, usage): Add support for noatime flag.
630 2005-12-07 Jim Meyering <jim@meyering.net>
632 Distribute the cvsu script, used only by `make syntax-check'.
633 * Makefile.am (EXTRA_DIST): Add build-aux/cvsu.
634 * Makefile.maint (CVS_LIST): Use build-aux/cvsu, now that we
635 distribute a copy of this script.
636 * .x-sc_unmarked_diagnostics: Add build-aux/cvsu.
638 * tests/mv/acl: exit-77 before the trap, not after, if we fail
639 to create a temporary directory on another partition.
640 From Andreas Gruenbacher.
642 2005-12-06 Tomas Pospisek <tpo@sourcepole.ch> (tiny change)
644 * man/basename.x: Cross-reference to dirname and readlink.
645 * man/dirname.x: Cross-reference to basename and readlink.
647 2005-12-05 Andreas Gruenbacher
649 * src/copy.c [!HAVE_FCHOWN]: Define fchown(...) to -1.
650 (set_owner, preserve_author): New functions, factored out of copy_reg.
651 (copy_reg): Use them.
652 (copy_internal): Use them here, too.
654 2005-12-04 Jim Meyering <jim@meyering.net>
656 * src/sleep.c (usage): Say what happens with two or more arguments.
657 Suggested by Justin Pryzby.
659 * src/uptime.c (print_uptime): Move decl of `upsecs' into scope
662 2005-12-03 Jim Meyering <jim@meyering.net>
664 * src/rm.c (long_opts): Change the name of each undocumented, for-
665 testing-only option to start with `-', so that it cannot render
666 ambiguous any prefix it happens to share with some other option name.
667 Problem reported by Eric Blake.
668 * src/head.c (long_options): Likewise.
669 * src/tail.c (long_options): Likewise.
671 * tests/misc/head-elide-tail: Update uses of undocumented, for-
672 testing-only --presume* options to start with `---'.
673 * tests/rm/dangling-symlink: Likewise.
674 * tests/rm/dir-no-w: Likewise.
675 * tests/rm/isatty: Likewise.
677 2005-11-30 Jim Meyering <jim@meyering.net>
679 * Makefile.maint: Add a comment about cvsu.
681 2005-11-25 Paul Eggert <eggert@cs.ucla.edu>
683 * NEWS: df updates for "none", "proc", inaccessible file systems.
684 * src/df.c (show_point): Ignore inaccessible file systems.
685 (usage): -a includes dummy file systems, not size-0 file systems.
687 * src/od.c (unsigned_long_long_int): Renamed from ulonglong_t,
688 to avoid collision with POSIX name space. All uses changed.
690 2005-11-24 Jim Meyering <jim@meyering.net>
692 * tests/Makefile.am (EXTRA_DIST): Add acl to the list.
693 * tests/acl: Add `$0: ' prefix to diagnostics.
695 * .x-sc_require_config_h: Add lib/buffer-lcm.c to the list.
697 2005-11-23 Paul Eggert <eggert@cs.ucla.edu>
699 * src/copy.c: Improve performance a bit by optimizing away
700 unnecessary system calls and going to a block size of at least
701 8192 (on normal hosts, anyway). This improved performance 5% on my
702 Debian stable host (2.4.27 kernel, x86, copying from root
703 ext3 file system to itself).
704 Include "buffer-lcm.h".
705 (copy_reg): Omit last argument. All callers changed.
706 Use xmalloc to allocate rather than trusting alloca
707 (which is unwise with large block sizes).
708 Declare locals more locally, if possible.
709 Use uintptr_t words instead of int words, for a bit more speed
710 when looking for null blocks on 64-bit hosts.
711 Optimize away reads of zero bytes on regular files.
712 In the typical case, insist on 8 KiB buffers, at least.
713 Avoid unnecessary extra call to fstat when checking for sparse files.
714 Avoid now-unnecessary cast to off_t, and "0L".
715 Avoid unnecessary test of *new_dst when checking for same owner
718 2005-11-22 Paul Eggert <eggert@cs.ucla.edu>
720 * src/remove.c (rm): Don't assume C99 for-loop syntax.
722 2005-11-22 Jim Meyering <jim@meyering.net>
724 * src/remove.c (AD_push): Remove debugging cruft.
726 * tests/rm/unread2 (rm): Change expected diagnostic,
727 `cannot open directory' to `cannot remove', to align with
729 * tests/rm/rm2: Ensure that rm now continues removing entries
730 even after certain types of failure.
732 * src/remove.c: Rewrite. Now, this module is reentrant on systems
733 that provide openat (Solaris), and on systems like Linux+procfs
734 where our openat emulation code is reentrant. This also fixes a
735 few low-probability leaks and eliminates some code that could,
736 in very unusual circumstances, cause rm() (via a callee) to exit.
737 * NEWS: Mention this.
739 * configure.ac: Put copyright dates all on one line so the
740 emacs function that updates them works properly.
742 2005-11-18 Paul Eggert <eggert@cs.ucla.edu>
744 * configure.ac (AM_PROG_CC_C_O): Add. Needed for CVS Automake.
745 Problem reported by Eric Blake.
746 (AC_PROG_CC_STDC): Use this instead of AC_PROG_CC, so that
747 we get a standard-conforming compiler. This relies on the new
748 m4/c.m4 file. Note that it's a bit tricky, since c.m4 doesn't
749 define AC_PROG_CC_STDC; we are relying on Autoconf 2.59 internals.
750 m4/c.m4 can go away with Autoconf 2.60 comes out.
752 2005-11-17 Jim Meyering <jim@meyering.net>
754 * src/remove.c (AD_mark_helper): Make a `char *' parameter `const'.
755 (AD_mark_current_as_unremovable): Likewise, but for a local.
758 * tests/mv/acl: Let traps handle removing temporary directories.
760 Expect acl-related tests to fail, until the corresponding
761 patches are committed.
762 * tests/mv/Makefile.am (XFAIL_TESTS): Add acl.
763 * tests/cp/Makefile.am (XFAIL_TESTS): Likewise.
765 ACL tests, from Andreas Gruenbacher.
766 * tests/acl, tests/mv/acl, tests/cp/acl: New files.
767 * tests/mv/Makefile.am (TESTS): Add acl.
768 * tests/cp/Makefile.am (TESTS): Add acl.
770 * src/ls.c (basename_is_dot_or_dotdot): Correct wording in comment.
772 2005-11-16 Paul Eggert <eggert@cs.ucla.edu>
774 * NEWS: Improve quality of ln's diagnostics.
775 * src/ln.c (do_link, usage): Likewise.
776 (do_link): Don't use alloca on a buffer of unbounded size.
778 2005-11-16 Jim Meyering <jim@meyering.net>
780 * tests/cp/fail-perm: Accommodate HPUX. It appears to fail
781 with EACCES rather than EPERM. Reported by Peter O'Gorman here:
782 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/5766
784 2005-11-14 Jim Meyering <jim@meyering.net>
786 * NEWS (sort): Mention consequences of today's mkstemp-safer.c fix.
788 2005-11-13 Jim Meyering <jim@meyering.net>
790 * announce-gen: Accept new option, --gpg-key-id=ID and
791 emit a blurb telling how to use the .sig files.
792 * Makefile.cfg (gpg_key_ID): Define.
793 * Makefile.maint (announcement): Use new option and key.
795 Require that most .c files include <config.h>.
796 * Makefile.maint (sc_require_config_h): New rule.
797 (syntax-check-rules): Add it.
798 * .x-sc_require_config_h: New file listing exceptions to the
799 above rule. Some are legit, others are simply grandfathered in.
800 * Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h here, too.
802 2005-11-12 Jim Meyering <jim@meyering.net>
804 * src/checksum.h, src/md5.c, src/sha1sum.c: Remove now-unused files.
806 2005-11-11 Jim Meyering <jim@meyering.net>
808 * NEWS: Mention `readlink -f' bug fix in 5.3.0 news.
809 Mention new readlink options in 5.3.0's `New features' section.
810 Spotted by Thomas Hood.
812 2005-11-08 Jim Meyering <jim@meyering.net>
814 * NEWS: Merge in changes from b5_9x branch.
816 2005-11-08 Paul Eggert <eggert@cs.ucla.edu>
818 * NEWS: ls now defaults to --time-style='locale', which in turn acts
819 like --time-style='posix-long-iso' if the locale settings are messed up.
820 * src/ls.c (decode_switches): Implement this.
822 2005-11-08 Jim Meyering <jim@meyering.net>
824 * tests/du/2g: s/expensive/very expensive/ in a comment.
827 2005-10-17 Eric Blake <ebb9@byu.net>
829 * src/ls.c (usage): Fix descriptions of --sort, --time.
830 Reported by Vitaly A. Ostanin.
832 2005-11-04 Paul Eggert <eggert@cs.ucla.edu>
834 * src/ln.c: Include filenamecat.c.
835 (FILE_BASENAME_CONCAT): Remove.
836 (do_link): Remove last arg DEST_IS_DIR. All callers changed.
837 (main): Use file_name_concat, base_name, and strip_trailing_slashes
838 instead of FILE_BASENAME_CONCAT. This simplifies the code, and avoids
841 2005-11-04 Jim Meyering <jim@meyering.net>
843 * src/du.c (process_file): Don't overflow for files of size >= 2^31
844 on systems with stat.st_blocks of a signed 32-bit type.
845 This bug causes trouble on some AIX 5.1 systems.
846 Report and trivial patch from Paul Townsend:
847 <http://lists.gnu.org/archive/html/bug-coreutils/2005-11/msg00033.html>
848 * NEWS: Mention this.
850 * tests/du/2g: New (very-expensive) test for the above-fixed bug.
851 * tests/du/Makefile.am (TESTS): Add it here.
852 * tests/very-expensive: New file.
853 * tests/Makefile.am (EXTRA_DIST): Add it here.
854 * tests/cp/perm: Mark this test as `very-expensive', too.
856 2005-11-02 Paul Eggert <eggert@cs.ucla.edu>
858 * NEWS: Mention that rm -d and maybe ln -d are scheduled for
860 * src/remove.h (struct rm_options): Remove unlink_dirs. All uses
862 * src/rm.c (usage): Don't mention rm -d.
864 2005-11-02 Jim Meyering <jim@meyering.net>
866 * tests/dd/skip-seek: Fix typo in comment: s/fileutils/coreutils.
869 * tests/dd/unblock-sync: Redirect stderr to /dev/null so the
870 `M+N records in/out' lines don't pollute `make check' output.
872 * tests/dd/skip-seek (sk-seek4): New test, to exercise the bug
873 fixed on 2005-10-31. This test uses the new, IN_PIPE specifier.
874 * tests/Coreutils.pm: Accept a new type of input specifier: IN_PIPE,
875 to indicate that the input file should be piped into the command
876 under test (via `cat FILE | $prog ...').
878 * src/remove.c (remove_entry): Emit a better diagnostic when rm
879 (without -r) fails to remove a directory on a non-Linux system.
880 This change affects only newer Solaris systems (with priv_*
881 functions like priv_allocset). Reported by Keith Thompson.
883 * tests/rm/dir-nonrecur: New file/test for the above fix.
884 * tests/rm/Makefile.am (TESTS): Add dir-nonrecur.
886 2005-11-01 Paul Eggert <eggert@cs.ucla.edu>
888 * NEWS: "tail -c 2 FILE" and "touch 0101000000" now operate as
889 POSIX 1002.1-2001 requires.
890 * src/tail.c (parse_obsolete_option): Implement this.
891 Problem reported by Vincent Lefevre.
892 * src/touch.c (main): Pass PDS_PRE_2000 to posixtime.
893 * tests/tail/Test.pm (c-2, c-2-minus, c2, c2-minus): New tests.
894 (test_vector): Add special cases for _POSIX2_VERSION, and
895 regularize the old ones a bit.
896 * tests/touch/obsolescent: Add y2000 test.
898 2005-10-31 Paul Eggert <eggert@cs.ucla.edu>
900 * src/dd.c (skip): Fix off-by-one error reported by
901 Theodoros V. Kalamatianos.
903 2005-10-30 Paul Eggert <eggert@cs.ucla.edu>
905 * tests/mkdir/p-3: Require that the test be run as non-root.
906 Problem and trivial fix reported by Theodoros V. Kalamatianos.
908 2005-10-28 Paul Eggert <eggert@cs.ucla.edu>
910 * src/ln.c (FILE_BASENAME_CONCAT): Omit unnecessary slashes in the
911 boundary between DEST and SOURCE in the result.
913 2005-10-26 Dmitry V. Levin <ldv@altlinux.org>
915 * src/md5sum.c (main) [!O_BINARY]: Changed default read mode
916 back to text, to sync with documentation and for backwards
919 2005-10-25 Jim Meyering <jim@meyering.net>
921 * tests/dircolors/simple (other-wr): Add an explicit test for
922 the dircolors bug (NULL-dereference) fixed yesterday.
924 2005-10-24 Jim Meyering <jim@meyering.net>
926 * src/tac.c (tac_file): When determining whether a file is seekable,
927 also test whether it is a tty. Using only the lseek-based test would
928 give a false positive on Solaris. Reported by Peter Fales.
930 2005-10-24 Dmitry V. Levin <ldv@altlinux.org>
932 * tests/install/d-slashdot: New test, for "install -d" failure.
933 * tests/install/Makefile.am (TESTS): Add d-slashdot.
934 * tests/mkdir/p-slashdot: New test, for "mkdir -p" failure.
935 * tests/mkdir/Makefile.am (TESTS): Add p-slashdot.
937 2005-10-24 Jim Meyering <jim@meyering.net>
939 * src/dircolors.c (ls_codes): Add missing comma.
940 Anonymous report and patch from
941 http://savannah.gnu.org/bugs/?func=detailitem&item_id=14849
943 * src/dircolors.c: Add compile-time assertion that the slack_codes
944 and ls_codes arrays have the same number of elements. This would
945 have prevented the above-fixed bug.
947 * src/expand.c (parse_tab_stops): Add a comment to make this function
948 identical to the one in unexpand.c.
949 * src/unexpand.c (parse_tab_stops): Adjust syntax to make this function
950 identical to the one in expand.c.
952 * src/expand.c (next_file): Don't assume fopen cannot return stdin.
954 2005-10-23 Jim Meyering <jim@meyering.net>
956 * src/md5sum.c (digest_check, main): Use ptr_align rather than
957 a dangerous pointer-value-to-`unsigned' cast.
958 * NEWS: mention the new sha* programs.
959 * AUTHORS: Add new sha* programs.
961 2005-08-28 David Madore <david.madore@ens.fr>
963 Add new programs: sha224sum, sha256sum, sha384sum, sha512sum.
964 * README: Add their names to the list.
965 * src/md5sum.c: Provide framework for computing sha-2 hashes.
966 * src/Makefile.am (sha224sum, sha256sum, sha384sum, sha512sum):
967 Rules for compiling sha-2 utilities
968 (noinst_HEADERS): Remove checksum.h.
969 * man/sha512sum.x, man/sha384sum.x, man/sha256sum.x, man/sha224sum.x:
971 * man/Makefile.am (dist_man_MANS): Add the corresponding .1 names.
972 (sha224sum.1, sha256sum.1, sha384sum.1, sha512sum.1): New dependencies.
973 * tests/misc/sha224sum, tests/misc/sha256sum: New files.
974 * tests/misc/sha384sum, tests/misc/sha512sum: New files.
975 * tests/misc/Makefile.am (TESTS): Add new sha224sum, sha256sum,
976 sha384sum, sha512sum test scripts here rather that each in its
979 2005-08-28 David Madore <david.madore@ens.fr>
981 * tests/sha1sum/basic-1 (million-a): Add the "million a's" test (one
982 of the FIPS test vectors).
984 2005-10-23 Jim Meyering <jim@meyering.net>
986 * configure.ac: Use 6.0-cvs as the version string.
987 * NEWS: Adjust accordingly.