1 2006-04-18 Jim Meyering <jim@meyering.net>
5 * src/ptx.c (main) [DEFAULT_IGNORE_FILE]: Remove code to use a default
6 ignore file. This has never been enabled. Reported by Eric Blake.
8 2006-04-12 Paul Eggert <eggert@cs.ucla.edu>
10 * src/ln.c (linkfunc): Remove. This method ran into a compiler/linker
11 bug in Interix. Just call symlink or link directly. All uses changed.
12 * src/setuidgid.c (main) [! HAVE_SETGROUPS]: Don't call setgroups.
13 * src/stat.c (USE_STATVFS): New macro.
14 Include <sys/statvfs.h> and use statvfs only if USE_STATVFS.
15 (NAMEMAX_FORMAT): define a bit more clearly, now that the
16 statvfs-using code is a bit more regular.
17 * src/system.h (sync) [!HAVE_SYNC]: New macro.
19 2006-04-11 Paul Eggert <eggert@cs.ucla.edu>
21 * NEWS: csplit, nl, expr now conform to POSIX better, and are
22 more-compatible with traditional Unix, with respect to regular
24 * src/csplit.c (extract_regexp): Set re_syntax_options to a
25 value that is compatible with what POSIX requires.
26 * src/nl.c (build_type_arg): Likewise.
27 * src/expr.c (docolon): Likewise. Also, don't let anchors match
28 newline; this fixes an incompatibility with tradition and with POSIX.
29 Don't warn about leading ^. POSIX says it is unspecified whether
30 ^ is a special character, which means that implementations can
31 either treat it as special or not, but either way a warning is not
32 allowed (unless the regexp is otherwise invalid). Instead, anchor
33 the expression but treat ^ as an anchor; this is the traditional
34 behavior (e.g., Solaris 10).
35 (eval4, eval3, eval2): Treat non-numeric args, division by zero,
36 and the like as invalid expressions (exit status 2), not as
37 failure of 'expr' (exit status 3). This is more consistent with
39 * tests/expr/basic (fail-a): Adjust exit status to match new expr
40 behavior, for status 2 versus 3.
42 (bre1, bre2, bre3, bre4, bre5, bre6, bre7, bre8, bre9, bre10):
43 (bre11, bre12, bre13, bre14, bre15, bre16, bre17, bre18, bre19, bre20):
44 (bre21, bre22, bre23, bre24, bre25, bre26, bre27, bre28, bre29, bre30):
45 (bre31, bre32, bre33, bre34, bre35, bre36, bre37, bre38, bre39, bre40):
46 (bre41, bre42, bre43, bre44, bre45, bre46, bre47, bre48, bre49, bre50):
47 (bre51, bre52, bre53, bre54, bre55, bre56, bre57, bre58, bre59, bre60):
48 (bre61, bre62): New tests.
49 * tests/misc/csplit: Use \{...\} in test RE, to test that we're
53 * tests/du/long-from-unreachable: Solaris 8 sh doesn't understand
54 "if !". Do not assume that 'sed' can handle long, newline-free input.
55 * tests/du/long-sloop: Likewise. Evaluate expr once, not $n times.
57 2006-04-10 Paul Eggert <eggert@cs.ucla.edu>
59 Adjust to new regex.h API (with new fastmap type), and clean
60 up the regex storage allocation a bit.
62 * src/csplit.c (struct control): Put re_compiled member at the
63 end, since it's large. Change regexpr member from char * to bool;
64 all uses changed. Add new member fastmap.
65 (extract_regexp): regexp arg is now char const *, not char *.
66 Don't bother duplicating the regular expression; it's not needed.
67 Set fastmap from new fastmap member. Don't bother allocating
68 a buffer, as the regexp code does a better job than we do.
69 * src/expr.c (docolon): Allocate and use a fastmap.
70 Don't bother allocating a buffer.
71 * src/nl.c (body_fastmap, header_fastmap, footer_fastmap):
73 (build_type_arg): New fastmap arg. All uses changed.
74 Don't bother allocating a buffer, but set a fastmap.
75 * src/ptx.c (context_regex_string, word_regex_string): Remove.
76 (context_regex, word_regex): New vars, replacing the above.
78 (struct regex_data): New type.
79 (compile_regex): Renamed from alloc_and_compile_regex, since
80 we no longer allocate storage. Arg is now a struct regex_data *,
81 not a const char *. All uses changed. Don't allocate the fastmap;
82 instead, take it from the caller. Don't convert size_t to int,
83 to avoid arithmetic overflow problems. Don't bother freeing
84 storage afterwards; it's not worth the aggravation.
85 * src/tac.c (compiled_separator_fastmap): New ver.
86 (main): Use it. Don't bother allocating a buffer.
88 2006-03-30 Jim Meyering <jim@meyering.net>
90 * src/dd.c (iwrite): Remove assignment without effect.
91 Reported by Felix Rauch Valenti.
93 2006-03-22 Eric Blake <ebb9@byu.net>
95 * src/ptx.c (usage): Remove mention of --copyright/-C.
96 (main): Alias --copyright to --version plus a deprecation warning.
99 2006-03-27 Jim Meyering <jim@meyering.net>
101 * src/Makefile.am (uptime_LDADD): Add $(POW_LIB), for uptime's
102 use of strtod. Tiny patch from Nickolai Zeldovich.
104 2006-03-11 Eric Blake <ebb9@byu.net>
106 * tests/misc/dirname: New file.
107 * tests/basename/Makefile.am: Delete.
108 * tests/basename/basic: Move to...
109 * tests/misc/basename: ... this new file. Add some tests,
110 including fixed behavior for //.
111 * tests/misc/Makefile.am (TESTS): Sort. Add basename, dirname.
112 * tests/Makefile.am (SUBDIRS): Remove basename.
113 * configure.ac (AC_CONFIG_FILES): Remove tests/basename.
115 Improvements to dirname/basename handling on platforms like
116 cygwin with distinct // and with drive letters.
117 * NEWS: Document new behavior.
118 * src/basename.c (main): Don't strip suffix from file system
120 * src/cp.c (target_directory_operand): Use new last_component.
121 (ASSIGN_BASENAME_STRDUPA): Likewise. Reduce time spent
122 traversing the string.
123 * src/dircolors.c (guess_shell_syntax): Use new last_component.
124 * src/install.c (target_directory_operand, install_file_in_dir):
126 * src/ln.c (target_directory_operand, main): Likewise.
127 * src/ls.c (basename_is_dot_or_dotdot): Likewise.
128 * src/mv.c (target_directory_operand, movefile): Likewise.
129 * src/remove.c (rm_1): Likewise.
130 * src/shred.c (wipename): Likewise.
131 * src/split.c (next_file_name): Likewise.
132 * src/su.c (log_su, run_shell): Likewise.
134 2006-03-23 Paul Eggert <eggert@cs.ucla.edu>
136 * NEWS: nohup diagnostics are now more precise, and nohup now
137 redirects stderr to nohup.out if stdout is closed and stderr is a tty.
138 * src/nohup.c (main): Implement this.
139 * tests/misc/nohup: Test the new behavior.
141 2006-03-12 Jim Meyering <jim@meyering.net>
143 * src/copy.c (set_author): Rename function, from preserve_author.
145 * src/remove.c (AD_pop_and_chdir): Use new macro,
146 CYCLE_CHECK_REFLECT_CHDIR_UP, rather than open-coding it.
148 * src/system.h (SAME_INODE): Remove definition.
149 Include "same-inode.h", instead.
151 2006-03-11 Eric Blake <ebb9@byu.net>
153 * src/pwd.c (robust_getcwd): Prepend only one slash, not two.
155 2006-03-10 Jim Meyering <jim@meyering.net>
157 Fix a bug whereby a user with write access to a directory being removed
158 could cause the removal of that directory to fail with an erroneous
159 diagnostic about a directory cycle. Reported by Vineet Chadha.
161 * NEWS: Mention this.
162 * src/remove.c (AD_pop_and_chdir): If the directory we're about to
163 leave (and try to rmdir) is the one whose dev_ino is being used to
164 detect a cycle, reset cycle_check_state.dev_ino to that of the parent.
166 2006-03-08 Paul Eggert <eggert@cs.ucla.edu>
168 * NEWS: Document dd's new 'directory' and 'nolinks' flags.
169 * src/dd.c (set_fd_flags): Handle file-creation flags on file
170 descriptors, rather than ignoring them.
171 * tests/dd/misc: Add test cases for append, nofollow, directory,
172 and nolinks flags. Simplify redirection to /dev/null in some cases.
174 * tests/dd/misc: iflags->iflag. This fixes a typo that meant the
175 noatime test never tested anything.
177 2006-03-05 Paul Eggert <eggert@cs.ucla.edu>
179 * src/dd.c (flags, usage): New flags directory, nolinks.
180 * src/system.h (O_NOLINKS): Define to 0 if not already defined.
182 * src/ls.c (usage): Mention that -f disables --color.
183 Problem reported by Niels Möller.
185 2006-03-03 Justin Pryzby <pryzbyj@justinpryzby.com>
187 * man/*.x: Add references to syscalls from utilities of the same name.
189 2006-03-05 Jim Meyering <jim@meyering.net>
191 * tests/help-version: Set SHELL, if not already set, in order to
192 avoid failure when `make check' is run through debuild; dircolors
193 would fail due to lack of $SHELL. Reported by Sven Joachim.
195 Make `base64 --wrap=N' work for N=0, and for N larger than SIZE_MAX.
196 * src/base64.c (wrap_write, do_encode, main): Change type of
197 parameters and locals, wrap_column, form size_t to uintmax_t.
198 (main): Adjust to use xstrtoumax, accordingly.
200 2006-03-03 Jim Meyering <jim@meyering.net>
202 Don't fail when run from an environment with SHELL not a Bourne
203 shell, e.g. `env SHELL=/bin/csh make check' would fail this test.
204 * tests/dircolors/simple: Invoke each non-failing test with -b.
205 Reported by Michael Stone.
207 2006-02-27 Jim Meyering <jim@meyering.net>
209 * tests/misc/base64: Derive --decode-using tests from the
212 * tests/misc/base64: Factor out a long constant string.
213 Split lines to stay within 80 columns.
215 * tests/misc/Makefile.am (TESTS): Add base64.
216 * tests/misc/base64: Test base64. From Simon Josefsson.
218 * src/base64.c (do_decode): Use correct type for parameter,
219 ignore_garbage: s/size_t/bool/.
221 * src/base64.c: Don't include .h files already included by system.h:
222 <string.h>, <stdlib.h>, <stdbool.h>, <limits.h>, <errno.h>.
223 Include "system.h" before the other lib/*.h header files.
224 Include <sys/types.h> before "system.h".
225 (wrap_write): Remove declaration of unused local, initial_column.
226 (wrap_write): Correct declaration syntax: s/size_t * V/size_t *V/.
228 * README: Add base64 to the list.
230 2006-02-17 Simon Josefsson <jas@extundo.com>
233 * AUTHORS: Mention base64.
235 * man/Makefile.am: Build base64.1.
236 * man/base64.x: New file.
237 * src/Makefile.am (bin_PROGRAMS): Add base64.
238 * src/base64.c: New file.
240 2006-02-25 Eric Blake <ebb9@byu.net>
242 In ls, avoid calling stat for --inode (-i), when possible.
243 * src/pwd.c (NOT_AN_INODE_NUMBER, D_INO): Move to ...
244 * src/system.h: ... here, for use in ...
245 * src/ls.c (main): ... here. Prefer dirent.d_ino to stat when
247 (gobble_file): Add inode argument.
248 (print_dir): Pass inode if available.
249 (usage): Remove inaccuracy.
251 2006-02-23 Jim Meyering <jim@meyering.net>
253 * TODO: Update/correct some obsolete entries.
255 2006-02-20 Paul Eggert <eggert@cs.ucla.edu>
257 * doc/coreutils.texi (join invocation): Mention `sort -k 1b,1'.
258 * src/join.c (usage): Likewise.
259 Documentation problem reported by Philip Kensche.
261 2006-02-20 Eric Blake <ebb9@byu.net>
263 * man/rm.x: Update documentation to match previous patch.
265 2006-02-18 Eric Blake <ebb9@byu.net>
267 New option for rm: --interactive=once (-I).
268 * NEWS: Document it, along with change to rm --interactive.
269 * TODO: Remove entry for implementing rm -I
270 * src/rm.c (INTERACTIVE_OPTION): New enum value.
271 (interactive_type): New enum.
272 (long_opts): Let interactive take an optional argument.
273 (interactive_args, interactive_types): New option arguments.
274 (usage): Document -I, --interactive=WHEN. Use program_name
275 instead of a basename.
276 (main): New -I option, new behavior to --interactive.
277 * tests/rm/interactive-once: New tests.
278 * tests/rm/interactive-always: Ditto.
279 * tests/rm/Makefile.am (TESTS): Run them.
281 2006-02-18 Jim Meyering <jim@meyering.net>
283 * Makefile.maint (sc_two_space_separator_in_usage): Make the regular
284 expression match more of the target lines, e.g., those that start with
285 `-S,' (short option followed by a comma) or that include `=[...]'.
286 Patch by Nicolas François.
287 Fix the four offenders thus exposed:
288 * src/join.c (usage): Use two spaces (not one) to separate the
289 --first-only option string from its description, so help2man formats
290 the derived man page properly.
291 * src/pr.c (usage): Likewise.
292 * src/uniq.c (usage): Likewise.
293 * src/install.c (usage): Likewise.
295 2006-02-15 Jim Meyering <jim@meyering.net>
297 * Makefile.maint (alpha beta major): For `make major', ensure that the
298 version string is of the form N.N[.N]*, where N is one or more digits.
300 2006-02-14 Jim Meyering <jim@meyering.net>
302 * INSTALL: Update from gnulib.
304 2006-02-13 Jim Meyering <jim@meyering.net>
306 * GNUmakefile (all): Emit diagnostics to stderr, not stdout.
308 2006-02-12 Jim Meyering <jim@meyering.net>
310 * Makefile.maint (patch-check): New target.
311 (local-checks-available): Add to the list.
313 2006-02-11 Jim Meyering <jim@meyering.net>
315 * src/c99-to-c89.diff: New file.
316 * src/Makefile.am (EXTRA_DIST): Add c99-to-c89.diff.
318 * .x-po-check: New file, with exclusions so that `make distcheck'
320 * Makefile.am (EXTRA_DIST): Add .x-po-check.
322 rm -r must remove an empty directory, even if it is inaccessible.
323 * src/remove.c (close_preserve_errno): New function.
324 (fd_to_subdirp): Don't print a diagnostic in this function.
325 Do it from the callers instead, unless rmdir succeeds.
326 (remove_cwd_entries, remove_dir): Adjust callers.
327 * tests/rm/empty-inacc: New test for the above.
328 * tests/rm/Makefile.am (TESTS): Add empty-inacc.
329 * NEWS: Mention this bug fix.
330 * tests/rm/rm2: Adjust two expected diagnostics, now that they're
331 a tiny bit less precise: cannot remove `a/1': ... instead of
332 cannot open directory `a/1': ...
334 * Makefile.maint (syntax-check-rules): Automatically derive this
335 list of sc_-prefixed rule names.
337 2006-02-10 Paul Eggert <eggert@cs.ucla.edu>
339 * Makefile.maint (CVS_LIST): Don't assume cvsu is available.
340 (CVS_LIST_EXCEPT): New macro, to simplify exception-processing.
341 Most uses of CVS_LIST changed to use CVS_LIST_EXCEPT.
342 (syntax-check-rules): Bring back sc_changelong. (Hmm, why did it
343 go away? was that an accident?)
344 (sc_cast_of_argument_to_free, sc_cast_of_x_alloc_return_value):
345 (sc_cast_of_alloca_return_value, sc_space_tab, sc_prohibit_atoi_atof):
346 (sc_error_exit_success, sc_file_system, sc_no_if_have_config_h):
347 (sc_system_h_headers, sc_sun_os_names, sc_trailing_blank):
348 (sc_two_space_separator_in_usage, sc_unmarked_diagnostics):
349 (sc_obsolete_symbols, sc_changelog, sc_prohibit_jm_in_m4):
350 (sc_useless_cpp_parens, makefile-check, m4-check, po-check):
351 (author_mark_check, makefile_path_separator_check):
352 Output line numbers, to simplify navigation of Emacs *compilation*
354 (sc_prohibit_atoi_atof, sc_file_system):
355 Rework slightly so that Makefile.maint doesn't get reported as a
356 violation of its own syntax rules.
357 (sc_dd_max_sym_length): Use ifneq to do nothing, instead of doing
358 it at run-time (which didn't work with Bison). Fix a makefile typo,
359 caught by Makefile.maint itself: spaces where a tab should be.
360 (po-check): Check lib/*.[ch] even if not in CVS; used by Bison,
361 which copies from ../gnulib/lib/*.[ch] to lib/*.[ch].
362 Ignore djgpp and man subdirectories, to avoid false matches with
363 Bison and coreutils, respectively. Use sort -u to remove the
364 resulting duplicates.
365 * gnupload: Rework slightly to avoid bogus warning from
366 sc_two_space_separator_in_usage.
368 2006-02-10 Jim Meyering <jim@meyering.net>
370 Use gzip's --rsyncable option only if it's available.
371 * Makefile.maint (gzip_rsyncable): New variable.
374 2006-02-08 Jim Meyering <jim@meyering.net>
376 * Makefile.maint (local-checks-available): Define in terms of
377 the expansion, $(syntax-check-rules), rather than the single,
378 top-level target `syntax-check', so that it's easier to exclude
379 individual rules (via $(local-checks-to-skip)).
380 (tgz-md5, tgz-sha1, ...): Remove now-unused definitions.
382 2006-02-07 Jim Meyering <jim@meyering.net>
384 * src/system.h (!defined O_DIRECT): If O_DIRECTIO is defined (as it
385 is on Tru64), define O_DIRECT to that. Patch From James Lemley.
387 * tests/help-version (expected_failure_status_vdir):
388 Redirect an expected disk-full diagnostic to /dev/null.
390 2006-02-06 Jim Meyering <jim@meyering.net>
392 * src/unexpand.c (usage): Use two spaces (not one) to separate the
393 --first-only option string from its description, so help2man formats
394 the derived man page properly.
395 * src/rm.c (usage): Likewise for --no-preserve-root.
396 * src/chown.c (usage): Likewise.
397 * src/chgrp.c (usage): Likewise.
399 Add a rule to ensure that the above doesn't happen again.
400 * Makefile.maint (sc_two_space_separator_in_usage): New rule.
401 (syntax-check-rules): Add it.
402 * .x-sc_two_space_separator_in_usage: New empty file.
403 * Makefile.am (EXTRA_DIST): Add .x-sc_two_space_separator_in_usage.
405 2006-02-06 Jim Meyering <jim@meyering.net>
407 * src/cp.c (usage): Use two spaces (not one) to separate each
408 option string from its description, so help2man formats the
409 derived man page properly.
410 * src/mv.c (usage): Likewise.
411 Patch from Nicolas François in http://bugs.debian.org/351601.
413 2006-02-04 Jim Meyering <jim@meyering.net>
415 * src/copy.c (copy_internal): cp -RL would fail when encountering
416 the same directory more than once in the hierarchy beneath a single
417 command-line argument. That is legitimate, e.g. when there are
418 two or more symbolic links, each pointing to some directory that
419 would not otherwise be copied. Reported by Christophe LYON.
420 * tests/cp/cp-deref: New file. Test for today's fix.
421 * tests/cp/Makefile.am (TESTS): Add cp-deref.
422 * NEWS: Document this.
424 2006-02-03 Jim Meyering <jim@meyering.net>
426 * configure.ac: Require automake-1.9.6, not 1.8.3.
428 2006-02-01 Paul Eggert <eggert@cs.ucla.edu>
430 * src/od.c (usage): Mention that -t a ignores high order bit.
431 Documentation problem reported by Ed Avis.
433 2006-02-01 Jim Meyering <jim@meyering.net>
435 * src/pwd.c (find_dir_entry): Remove unused local, `ent_sb_valid'.
437 2006-01-30 Paul Eggert <eggert@cs.ucla.edu>
439 * src/head.c (main): Use a better diagnostic when someone uses a
440 trailing numeric option in an invalid way. Problem reported by
442 * src/tail.c (parse_options): Likewise.
444 2006-01-30 Jim Meyering <jim@meyering.net>
446 * man/wc.x: Include `count' keyword in man page synopsis,
447 per suggestion from http://bugs.debian.org/181585.
449 2006-01-24 Paul Eggert <eggert@cs.ucla.edu>
451 * src/df.c (show_dev): If the file system claims to have
452 more available than total blocks, report the number of used
453 blocks as being total - available (a negative number) rather
454 than as garbage. Problem reported by Toralf Foerster.
456 2006-01-24 Jim Meyering <jim@meyering.net>
458 * src/tail.c (tail_forever): Don't exit-nonzero when an attempt
459 to put a regular file in O_NONBLOCK mode fails with EPERM.
460 That happens on Linux (up to 2.6.15) when using tail -f on a file with
461 the append-only attribute. Reported by Dean Gaudet. For details,
462 see http://savannah.gnu.org/bugs/?func=detailitem&item_id=15473.
463 * NEWS: Mention this fix.
464 * tests/tail-2/append-only: New file. Test for the above.
465 * tests/tail-2/Makefile.am (TESTS): Add append-only.
466 * tests/Makefile.am (check-root): Add tail-2/append-only
468 2006-01-21 Jim Meyering <jim@meyering.net>
470 * NEWS: Mention fts-related improvements and bug fixes.
472 2006-01-19 Jim Meyering <jim@meyering.net>
474 * tests/fmt/basic (pfx-1, pfx-2): New tests, to demonstrate the bug
475 reported as http://bugs.debian.org/147577. Forwarded by Thomas Hood.
477 2006-01-18 Jim Meyering <jim@meyering.net>
479 * tests/du/Makefile.am (TESTS): Add long-from-unreadable.
481 2006-01-17 Jim Meyering <jim@meyering.net>
483 Now that fts no longer changes the current working directory, adjust
484 its clients accordingly -- note that du.c uses fts but doesn't need
485 any adjustment, since it doesn't operate on the actual files,
486 but rather just uses the stat buffers provided by fts.
488 * src/chown-core.c: Include "openat.h".
489 Don't include "lchown.h".
490 (restricted_chown): Accept a new parameter, CWD_FD, and use it in
491 calling openat, lchownat, chownat, rather than open, lchown, chown.
493 * src/chmod.c: Include "openat.h".
494 (process_file): Use chmodat (fts->fts_cwd_fd,... in place of chmod (...
496 * tests/du/long-from-unreadable: New test, to exercise one small
499 2006-01-13 Jim Meyering <jim@meyering.net>
501 * tests/Makefile.am (SUBDIRS): Add comments discouraging the
502 addition of new directories under tests/.
504 * tests/acl: Redirect stdin to /dev/null. Otherwise, FreeBSD 5.0's
507 2006-01-12 Jim Meyering <jim@meyering.net>
509 * tests/du/long-sloop: Adjust not to hard-code the expected
510 diagnostic corresponding to ELOOP. Solaris' diagnostic differs
511 from that of GNU libc. Reported by Paul Eggert.
513 * tests/du/long-sloop: Create file at end of symlink chain.
515 * tests/misc/test: New file, with a test for one of the
516 bugs fixed by yesterday's test.c changes.
517 * tests/misc/Makefile.am (TESTS): Add test.
519 2006-01-11 Jim Meyering <jim@meyering.net>
521 * tests/du/long-sloop: New file. Test for today's fts.c bug fix.
522 That bug could make du -L, chgrp -L, or chown -L fail to diagnose
523 a very long sequence of symbolic links (not necessarily a loop).
524 * tests/du/Makefile.am (TESTS): Add long-sloop.
526 2006-01-11 Paul Eggert <eggert@cs.ucla.edu>
528 * src/test.c (test_syntax_error): Append a newline. All callers
529 changed, except for the ones that didn't already append a newline.
530 Bug reported by Eric Blake.
532 2006-01-11 Jim Meyering <jim@meyering.net>
534 * src/system.h (X2NREALLOC): Now that verify_true is no longer
535 void, cast its result to void, to avoid gcc's warning that
536 ``left-hand operand of comma expression has no effect''.
537 (DECIMAL_DIGIT_ACCUMULATE, X2REALLOC): Likewise.
539 2006-01-10 Jim Meyering <jim@meyering.net>
541 * tests/chmod/no-x: Add a test for today's fts.c fix.
543 2006-01-10 Jim Meyering <jim@meyering.net> (tiny change)
545 * src/ls.c (gobble_file): Use DTTOIF only if it's defined.
546 This is necessary for Dragonfly. Patch by Joerg Sonnenberger.
548 2006-01-10 Paul Eggert <eggert@cs.ucla.edu>
550 * src/system.h (X2NREALLOC, X2REALLOC, DECIMAL_DIGIT_ACCUMULATE):
551 Use verify_true instead of verify_expr, to sync with gnulib.
553 2006-01-08 Jim Meyering <jim@meyering.net>
555 * src/date.c (usage): Adjust the formatting of the entries for
556 %::z and %:::z (separate with two spaces, not one) so that help2man
557 formats them properly. Reported by Philip Rowlands.
559 2006-01-06 Paul Eggert <eggert@cs.ucla.edu>
561 * configure.ac (gl_IGNORE_UNUSED_LIBRARIES): Add.
563 2006-01-06 Jim Meyering <jim@meyering.net>
565 * Makefile.maint (copyright-check): Use date +%Y in place of
568 * src/remove.c (rm_1): Remove `static' attribute on local `status'.
569 First off, the attribute should have been `volatile' (not static)
570 to avoid longjmp-related risk of clobber. Secondly, now there is
571 no longer any risk of a local variable being clobbered, so there's
572 no need for any attribute at all.
574 2006-01-05 Jim Meyering <jim@meyering.net>
576 * src/remove.c: Give a few functions the inline attribute.
577 (AD_pop_and_chdir): Use gotos to avoid some duplication.
578 (AD_push): Rewrite an assertion so that the entire computation
579 goes away when assertions are turned off.
581 * src/tail.c (ENOSYS) [!defined ENOSYS]: Don't define here.
582 It's already defined in "system.h".
583 * Makefile.maint: Add a FIXME comment.
585 2006-01-04 Jim Meyering <jim@meyering.net>
587 * ChangeLog: Remove entries from 2005-10-22 and earlier.
588 * ChangeLog-2005: New file, for entries up to version 5.92.
590 2006-01-03 Jim Meyering <jim@meyering.net>
592 * tests/du/no-x: Also allow a slightly different diagnostic -- the
593 one you get when using openat-enabled fts.c and du (coming soon).
594 * tests/chmod/no-x: Likewise.
595 * tests/chgrp/no-x: Likewise.
597 * src/system.h (O_DIRECTORY) [!defined O_DIRECTORY]: Define.
599 2006-01-02 Paul Eggert <eggert@cs.ucla.edu>
601 * src/chown-core.c (RC_do_ordinary_chown): New enum value.
602 (restricted_chown): Return it, if the file cannot be accessed due
603 to EPERM, or if no uid or gid are required, or if the file is
604 neither a directory nor a regular file. Rewrite to avoid gotos.
605 (change_file_owner): Handle RC_do_ordinary_chown case.
606 Rewrite to avoid gotos.
607 * tests/chgrp/basic: Make sure we can change the group of
610 * src/date.c (usage): Explain %g, %G, and %V a bit better.
612 2006-01-02 Jim Meyering <jim@meyering.net>
614 * src/copy.c (set_owner): Correct a comment.
616 * src/tail.c (parse_options): Change warning to say that --retry
617 is useful `mainly' (not `only') when following by name.
618 Reported here: http://bugs.debian.org/273781
620 2006-01-01 Paul Eggert <eggert@cs.ucla.edu>
622 * NEWS: Document that mkfifo and mknod -m no longer set special bits.
623 * src/copy.c: Include lchmod.h.
624 (copy_internal): Use lchmod rather than chmod.
625 * src/cp.c: Include lchmod.h.
626 (re_protect, make_dir_parents_private): Use lchmod rather than chmod.
627 * src/mkdir.c: Include lchmod.h.
628 (usage): Clarify -m's operation.
629 (main): Use lchmod rather than chmod. Don't use lchmod unless the
630 new mode contains bits outside the 777 range.
631 * src/mkfifo.c (usage): Clarify -m's operation.
632 (main): If -m is given, don't invoke chmod; use umask 0 instead.
633 Report an error if -m asks for bits outside the 777 range.
634 * src/mknod.c (usage, main): Likewise.
636 * src/mkdir.c, src/mkfifo.c, src/mknod.c: Undo 2005-12-19 changes.
638 2005-12-27 Jim Meyering <jim@meyering.net>
640 * Makefile.maint (sc_obsolete_symbols): Prohibit use of O_NDELAY.
641 (sc_prohibit_assert_without_use): New rule.
642 (syntax-check-rules): Add it to the list.
643 * .x-sc_prohibit_assert_without_use: New empty file.
644 * Makefile.am (EXTRA_DIST): Add it.
646 * Makefile.maint (CVS_LIST): Define in terms of $(srcdir).
648 * cp.c, df.c, link.c, mknod.c, nice.c, sleep.c, unlink.c:
649 Don't include <assert.h>; it wasn't used.
651 2005-12-26 Paul Eggert <eggert@cs.ucla.edu>
653 * src/chown-core.c (restricted_chown):
654 Don't try O_WRONLY unless O_RDONLY failed wth EACCES.
655 * src/remove.c (fd_to_subdirp): Open with O_DIRECTORY | O_NOCTTY
656 | O_NOFOLLOW too, for consistency with other dir-openers.
657 Use POSIX-preferred O_NONBLOCK rather than O_NDELAY.
658 (is_empty_dir): Likewise.
659 * src/shred.c (wipename): Likewise. Don't bother trying to open
660 dir for writing, since POSIX prohibits it.
662 2005-12-22 Jim Meyering <jim@meyering.net>
664 * tests/help-version: Redirect stderr to /dev/full, to suppress
665 write error diagnostic.
667 2005-12-19 Jim Meyering <jim@meyering.net>
669 * src/mkdir.c, src/mknod.c, src/mkfifo.c (main)
670 Avoid a minor race condition when `-m MODE' is specified, by using
671 open, fchown, and close rather than just chown. To do that reliably --
672 even with an overly restrictive umask -- ensure that each mkdir,
673 mknod and mkfifo call uses a mode including at least owner-read access.
674 * src/mknod.c (main): When `-m MODE' is specified, exit nonzero if
675 the subsequent chown (or equivalent open,fchown,close) fails.
676 * tests/misc/mknod: New tests.
677 * tests/misc/Makefile.am (TESTS): Add mknod.
679 2005-12-17 Jim Meyering <jim@meyering.net>
681 * src/remove.c (is_empty_dir): Open with O_NDELAY, so we don't hang,
682 e.g., on a named pipe.
683 (OPEN_NO_FOLLOW_SYMLINK): Remove definition. Use O_NOFOLLOW in
684 place of all uses, since it is guaranteed (system.h) to be defined.
686 2005-12-05 Andreas Gruenbacher <agruen@suse.de>
688 Add POSIX ACL support
689 * src/ls.c: Switch back from HAVE_ACL to USE_ACL: The acl() syscall
690 is no requirement for ACL support; particularly, it does not exist
691 on systems that have POSIX ACLs.
692 * src/copy.h (cp_option_init) [umask_kill]: Remove member.
693 * src/cp.c (umask_kill): With default acls, the umask is not to be
694 applied. Remove umask_kill, don't change the process umask, and let
695 the kernel apply the umask where appropriate.
696 * src/cp.c (make_dir_parents_private): Fix logic for POSIX ACLs.
697 * src/copy.c (get_dest_mode): Remove; it is obsolete after removing
699 (copy_reg, copy_internal): Use copy_acl and set_acl
700 instead of fchown/chown. Fix the logic for POSIX ACLs.
701 (chown_succeded): Remove; we now always copy acls and
702 preserve S_ISUID, S_ISGID, and S_ISVTX when needed, no matter if we
703 did a chown before or not.
704 * src/mv.c, src/install.c (cp_option_init): Don't set umask_kill member.
705 * src/Makefile.am (dir_LDADD, ls_LDADD, vdir_LDADD, cp_LDADD,
706 mv_LDADD, ginstall_LDADD): On systems with an ACL library, arrange
707 to link with it via $(LIB_ACL), for the utilities that need it.
709 2005-12-16 Paul Eggert <eggert@cs.ucla.edu>
711 * src/remove.c (OPENAT_CWD_RESTORE__REQUIRE): Remove.
712 (OPENAT_CWD_RESTORE__ALLOW_FAILURE): Likewise.
713 (fd_to_subdirp): Remove openat_cwd_restore_allow_failure arg; its
714 value is now signified by whether cwd_errno is null.
715 (fd_to_subdirp, remove_dir, rm_1); Change cwd failure indicator from
716 pointer-to-bool to pointer-to-errno-value. All callers changed.
717 (rm_1): Don't bother setting a local cwd failure flag and then
718 ORing it into the caller's. Just set the caller's.
719 (rm): Use cwd failure errno value to print a slightly-better
722 2005-12-15 Jim Meyering <jim@meyering.net>
724 * src/stat.c (print_it): Properly handle a backslash at the
725 end of a --printf format string. Reported by Paul Eggert.
726 * tests/misc/stat-printf (end-bs): Add a test for the above.
728 2005-12-15 Paul Eggert <eggert@cs.ucla.edu>
730 * tests/acl: Port to pre-POSIX shells like Solaris 8 /bin/sh.
731 Don't assume /etc/passwd contains user names; use 'id' instead.
733 2005-12-15 Jim Meyering <jim@meyering.net>
735 stat: revert behavior of --format=FMT (-c)
736 stat: add new option: --printf=FMT
737 * NEWS: Mention this.
738 * src/stat.c (isodigit, octtobin, hextobin): Define.
739 (PRINTF_OPTION): Define.
740 (interpret_backslash_escapes, trailing_delim): New globals.
741 (usage): Document them. Alphabetize on long option names.
742 (print_esc_char): New function.
743 (print_it): Rewrite, in order to handle backslash escapes.
744 (main): Handle new option. Set globals for --format, too.
746 * tests/misc/stat-printf: Test --printf and --format.
747 * tests/misc/Makefile.am (TESTS): Add stat-printf.
749 2005-12-14 Paul Eggert <eggert@cs.ucla.edu>
751 * NEWS: sort now reports incompatible options.
752 * src/sort.c (incompatible_options, check_ordering_compatibility):
754 (main): Use them. Don't bother with a usage message for
755 "sort -c a b", for consistency with other error diagnostics.
756 * tests/sort/Test.pm (incompat1, incompat2, incompat3, incompat4):
759 * src/cat.c (main): Undo previous change. close_stdout already
760 does the check, so the previous change wasn't necessary.
762 2005-12-13 Paul Eggert <eggert@cs.ucla.edu>
764 * src/cat.c (main): Check for close (STDOUT_FILENO) failure.
766 2005-12-12 Paul Eggert <eggert@cs.ucla.edu>
768 Install a more-conservative approach for sort -R. It's the
769 same basic idea as the existing code, except it uses the full ISAAC
770 approach (called the "more kosher" approach in the existing comments).
771 This makes "sort -R" quite a bit slower (about a factor of 2 on my
772 little tests involving 10000 lines on a 2.4 GHz P4), but I think it's
773 better to be conservative here at first, and review any performance
774 improvements carefully.
775 * .x-sc_require_config_h: Add src/rand-isaac.c.
776 * src/rand-isaac.h: Remove. All uses now simply include rand-isaac.c.
777 * src/Makefile.am (noinst_HEADERS): Remove rand-isaac.h.
778 (shred_SOURCES, sort_SOURCES): Remove.
779 (EXTRA_DIST): Add rand-isaac.c.
780 * src/rand-isaac.c: Revert to what used to be in shred.c, without
781 changing it to allow for varying numbers of words in the state.
782 Alter so that we include rand-isaac.c directly rather than
783 compiling it and linking to it. Don't include config.h or
784 system.h; that's the includer's responsibility.
785 Omit functions that are specific to shred.
786 (ISAAC_LOG, ISAAC_WORDS, ISAAC_BYTES, struct isaac_state, ind):
787 (isaac_step, struct irand_state):
788 Resurrect these, with the same defns that used to be in shred.c.
789 (ISAAC_SIZE, isaac_new, isaac_copy): Remove.
790 (isaac_refill, isaac_seed_start, isaac_seed_data, irand_init, irand32):
792 (struct isaac_state, isaac_refill, isaac_mix, isaac_init):
793 (isaac_seed_start, isaac_seed_data, isaac_seed_finish, isaac_seed):
794 (irand_init, irand32, irand_mod):
795 Number of words is constant again.
796 (struct irand_state, irand_init, irand32, irand_mod): Move to shred.c.
797 * src/shred.c: Include rand-isaac.c rather than rand-isaac.h.
798 * src/sort.c: Likewise.
799 * src/shred.c (fillrand, dopass, main): Undo previous change.
800 (struct irand_state, irand_init, irand32, irand_mod): Moved back here,
802 * src/sort.c: Don't include md5.h; it wasn't needed.
803 (struct keyfield): Rename random_hash to random, for consistency
804 with the other member names. All uses changed.
805 (usage): Tweak wording to mention STRING for --seed option.
806 (short_options): Rorder for consistency with other programs.
807 (rand_state): Now a struct, not a pointer to one. All uses changed.
808 (HASH_WORDS, HASH_SIZE): Remove.
809 (get_hash): Remove comments around resbuf size, since we can assume C89.
810 Use a "more-kosher" (but slower) approach of invoking isaac_refill.
811 (keycompare): Adjust to the new get_hash.
813 (badfieldspec): Omit recently-introduced comment; it isn't needed.
814 (main): Don't set need_random simply because gkey has it set; that
815 doesn't necessarily mean we'll need random numbers.
816 Redo seeding to match new get_hash approach.
818 2005-12-10 Jim Meyering <jim@meyering.net>
820 * src/Makefile.am (noinst_HEADERS): Add rand-isaac.h.
822 Avoid shred segfault on 64-bit systems.
823 * src/rand-isaac.c (isaac_refill): Don't try to negate a
824 local of type uint32_t. Make the local an `int' instead.
826 * NEWS: Mention sort's new options.
828 * src/rand-isaac.c (isaac_mix): Declare to be static.
829 Mark all other functions as `extern' so the tight-scope
830 part of `make distcheck' passes once again.
831 * src/rand-isaac.h (isaac_mix): Remove declaration.
833 * src/sort.c (get_hash): Change position of `*' in parameter
834 type to conform with convention.
835 (main): Split a long line so it fits in 80 columns.
836 (keycompare): Remove stray SPACE before TAB that was
837 causing `make distcheck' to fail.
839 * src/shred.c: Don't include gethrxtime.h. No longer needed.
841 * tests/misc/sort-rand: New file: basic tests for the new options.
842 * tests/misc/Makefile.am (TESTS): Add sort-rand.
844 2005-12-10 Frederik Eaton <frederik@ofb.net>
846 * src/Makefile.am (sort_LDADD): Add $(LIB_GETHRXTIME).
847 (shred_SOURCES, sort_SOURCES): New macros, so we compile rand-isaac.c.
848 * src/rand-isaac.c: New file, containing ISAAC code that was in shred.c.
849 Make state size runtime-configurable.
850 (isaac_new, isaac_copy): New functions.
851 * src/rand-isaac.h: New file.
852 * src/shred.c: Include rand-isaac.h. Move ISAAC code to rand-isaac.c.
853 (fillrand, main): Adjust to the fact that the state size is now
854 runtime-configurable.
855 * src/sort.c (short_options, long_options, WORDS, keycompare, main):
856 (usage): Add options --random-sort and --seed to implement a random
858 Include md5.h and rand-isaac.h.
859 (get_hash): New function.
860 (rand_state): New var.
861 (HASH_WORDS, HASH_SIZE): New macros.
863 2005-12-09 Paul Eggert <eggert@cs.ucla.edu>
865 * tests/dd/misc: Add test for dd iflags=noatime.
867 2005-12-09 Jim Meyering <jim@meyering.net>
869 * src/sort.c (usage): Mention white space vs -b and -t options.
872 2005-12-09 Eric Blake <ebb9@byu.net>
874 * src/test.c (main): Fix misleading comment.
876 2005-12-07 Paul Eggert <eggert@cs.ucla.edu>
878 * NEWS: Mention dd's new noatime flag.
879 * src/system.h (O_NOATIME): Define to 0 if not already defined.
880 * src/dd.c (flags, usage): Add support for noatime flag.
882 2005-12-07 Jim Meyering <jim@meyering.net>
884 Distribute the cvsu script, used only by `make syntax-check'.
885 * Makefile.am (EXTRA_DIST): Add build-aux/cvsu.
886 * Makefile.maint (CVS_LIST): Use build-aux/cvsu, now that we
887 distribute a copy of this script.
888 * .x-sc_unmarked_diagnostics: Add build-aux/cvsu.
890 * tests/mv/acl: exit-77 before the trap, not after, if we fail
891 to create a temporary directory on another partition.
892 From Andreas Gruenbacher.
894 2005-12-06 Tomas Pospisek <tpo@sourcepole.ch> (tiny change)
896 * man/basename.x: Cross-reference to dirname and readlink.
897 * man/dirname.x: Cross-reference to basename and readlink.
899 2005-12-05 Andreas Gruenbacher
901 * src/copy.c [!HAVE_FCHOWN]: Define fchown(...) to -1.
902 (set_owner, preserve_author): New functions, factored out of copy_reg.
903 (copy_reg): Use them.
904 (copy_internal): Use them here, too.
906 2005-12-04 Jim Meyering <jim@meyering.net>
908 * src/sleep.c (usage): Say what happens with two or more arguments.
909 Suggested by Justin Pryzby.
911 * src/uptime.c (print_uptime): Move decl of `upsecs' into scope
914 2005-12-03 Jim Meyering <jim@meyering.net>
916 * src/rm.c (long_opts): Change the name of each undocumented, for-
917 testing-only option to start with `-', so that it cannot render
918 ambiguous any prefix it happens to share with some other option name.
919 Problem reported by Eric Blake.
920 * src/head.c (long_options): Likewise.
921 * src/tail.c (long_options): Likewise.
923 * tests/misc/head-elide-tail: Update uses of undocumented, for-
924 testing-only --presume* options to start with `---'.
925 * tests/rm/dangling-symlink: Likewise.
926 * tests/rm/dir-no-w: Likewise.
927 * tests/rm/isatty: Likewise.
929 2005-11-30 Jim Meyering <jim@meyering.net>
931 * Makefile.maint: Add a comment about cvsu.
933 2005-11-25 Paul Eggert <eggert@cs.ucla.edu>
935 * NEWS: df updates for "none", "proc", inaccessible file systems.
936 * src/df.c (show_point): Ignore inaccessible file systems.
937 (usage): -a includes dummy file systems, not size-0 file systems.
939 * src/od.c (unsigned_long_long_int): Renamed from ulonglong_t,
940 to avoid collision with POSIX name space. All uses changed.
942 2005-11-24 Jim Meyering <jim@meyering.net>
944 * tests/Makefile.am (EXTRA_DIST): Add acl to the list.
945 * tests/acl: Add `$0: ' prefix to diagnostics.
947 * .x-sc_require_config_h: Add lib/buffer-lcm.c to the list.
949 2005-11-23 Paul Eggert <eggert@cs.ucla.edu>
951 * src/copy.c: Improve performance a bit by optimizing away
952 unnecessary system calls and going to a block size of at least
953 8192 (on normal hosts, anyway). This improved performance 5% on my
954 Debian stable host (2.4.27 kernel, x86, copying from root
955 ext3 file system to itself).
956 Include "buffer-lcm.h".
957 (copy_reg): Omit last argument. All callers changed.
958 Use xmalloc to allocate rather than trusting alloca
959 (which is unwise with large block sizes).
960 Declare locals more locally, if possible.
961 Use uintptr_t words instead of int words, for a bit more speed
962 when looking for null blocks on 64-bit hosts.
963 Optimize away reads of zero bytes on regular files.
964 In the typical case, insist on 8 KiB buffers, at least.
965 Avoid unnecessary extra call to fstat when checking for sparse files.
966 Avoid now-unnecessary cast to off_t, and "0L".
967 Avoid unnecessary test of *new_dst when checking for same owner
970 2005-11-22 Paul Eggert <eggert@cs.ucla.edu>
972 * src/remove.c (rm): Don't assume C99 for-loop syntax.
974 2005-11-22 Jim Meyering <jim@meyering.net>
976 * src/remove.c (AD_push): Remove debugging cruft.
978 * tests/rm/unread2 (rm): Change expected diagnostic,
979 `cannot open directory' to `cannot remove', to align with
981 * tests/rm/rm2: Ensure that rm now continues removing entries
982 even after certain types of failure.
984 * src/remove.c: Rewrite. Now, this module is reentrant on systems
985 that provide openat (Solaris), and on systems like Linux+procfs
986 where our openat emulation code is reentrant. This also fixes a
987 few low-probability leaks and eliminates some code that could,
988 in very unusual circumstances, cause rm() (via a callee) to exit.
989 * NEWS: Mention this.
991 * configure.ac: Put copyright dates all on one line so the
992 emacs function that updates them works properly.
994 2005-11-18 Paul Eggert <eggert@cs.ucla.edu>
996 * configure.ac (AM_PROG_CC_C_O): Add. Needed for CVS Automake.
997 Problem reported by Eric Blake.
998 (AC_PROG_CC_STDC): Use this instead of AC_PROG_CC, so that
999 we get a standard-conforming compiler. This relies on the new
1000 m4/c.m4 file. Note that it's a bit tricky, since c.m4 doesn't
1001 define AC_PROG_CC_STDC; we are relying on Autoconf 2.59 internals.
1002 m4/c.m4 can go away with Autoconf 2.60 comes out.
1004 2005-11-17 Jim Meyering <jim@meyering.net>
1006 * src/remove.c (AD_mark_helper): Make a `char *' parameter `const'.
1007 (AD_mark_current_as_unremovable): Likewise, but for a local.
1010 * tests/mv/acl: Let traps handle removing temporary directories.
1012 Expect acl-related tests to fail, until the corresponding
1013 patches are committed.
1014 * tests/mv/Makefile.am (XFAIL_TESTS): Add acl.
1015 * tests/cp/Makefile.am (XFAIL_TESTS): Likewise.
1017 ACL tests, from Andreas Gruenbacher.
1018 * tests/acl, tests/mv/acl, tests/cp/acl: New files.
1019 * tests/mv/Makefile.am (TESTS): Add acl.
1020 * tests/cp/Makefile.am (TESTS): Add acl.
1022 * src/ls.c (basename_is_dot_or_dotdot): Correct wording in comment.
1024 2005-11-16 Paul Eggert <eggert@cs.ucla.edu>
1026 * NEWS: Improve quality of ln's diagnostics.
1027 * src/ln.c (do_link, usage): Likewise.
1028 (do_link): Don't use alloca on a buffer of unbounded size.
1030 2005-11-16 Jim Meyering <jim@meyering.net>
1032 * tests/cp/fail-perm: Accommodate HPUX. It appears to fail
1033 with EACCES rather than EPERM. Reported by Peter O'Gorman here:
1034 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/5766
1036 2005-11-14 Jim Meyering <jim@meyering.net>
1038 * NEWS (sort): Mention consequences of today's mkstemp-safer.c fix.
1040 2005-11-13 Jim Meyering <jim@meyering.net>
1042 * announce-gen: Accept new option, --gpg-key-id=ID and
1043 emit a blurb telling how to use the .sig files.
1044 * Makefile.cfg (gpg_key_ID): Define.
1045 * Makefile.maint (announcement): Use new option and key.
1047 Require that most .c files include <config.h>.
1048 * Makefile.maint (sc_require_config_h): New rule.
1049 (syntax-check-rules): Add it.
1050 * .x-sc_require_config_h: New file listing exceptions to the
1051 above rule. Some are legit, others are simply grandfathered in.
1052 * Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h here, too.
1054 2005-11-12 Jim Meyering <jim@meyering.net>
1056 * src/checksum.h, src/md5.c, src/sha1sum.c: Remove now-unused files.
1058 2005-11-11 Jim Meyering <jim@meyering.net>
1060 * NEWS: Mention `readlink -f' bug fix in 5.3.0 news.
1061 Mention new readlink options in 5.3.0's `New features' section.
1062 Spotted by Thomas Hood.
1064 2005-11-08 Jim Meyering <jim@meyering.net>
1066 * NEWS: Merge in changes from b5_9x branch.
1068 2005-11-08 Paul Eggert <eggert@cs.ucla.edu>
1070 * NEWS: ls now defaults to --time-style='locale', which in turn acts
1071 like --time-style='posix-long-iso' if the locale settings are messed up.
1072 * src/ls.c (decode_switches): Implement this.
1074 2005-11-08 Jim Meyering <jim@meyering.net>
1076 * tests/du/2g: s/expensive/very expensive/ in a comment.
1079 2005-10-17 Eric Blake <ebb9@byu.net>
1081 * src/ls.c (usage): Fix descriptions of --sort, --time.
1082 Reported by Vitaly A. Ostanin.
1084 2005-11-04 Paul Eggert <eggert@cs.ucla.edu>
1086 * src/ln.c: Include filenamecat.c.
1087 (FILE_BASENAME_CONCAT): Remove.
1088 (do_link): Remove last arg DEST_IS_DIR. All callers changed.
1089 (main): Use file_name_concat, base_name, and strip_trailing_slashes
1090 instead of FILE_BASENAME_CONCAT. This simplifies the code, and avoids
1093 2005-11-04 Jim Meyering <jim@meyering.net>
1095 * src/du.c (process_file): Don't overflow for files of size >= 2^31
1096 on systems with stat.st_blocks of a signed 32-bit type.
1097 This bug causes trouble on some AIX 5.1 systems.
1098 Report and trivial patch from Paul Townsend:
1099 <http://lists.gnu.org/archive/html/bug-coreutils/2005-11/msg00033.html>
1100 * NEWS: Mention this.
1102 * tests/du/2g: New (very-expensive) test for the above-fixed bug.
1103 * tests/du/Makefile.am (TESTS): Add it here.
1104 * tests/very-expensive: New file.
1105 * tests/Makefile.am (EXTRA_DIST): Add it here.
1106 * tests/cp/perm: Mark this test as `very-expensive', too.
1108 2005-11-02 Paul Eggert <eggert@cs.ucla.edu>
1110 * NEWS: Mention that rm -d and maybe ln -d are scheduled for
1112 * src/remove.h (struct rm_options): Remove unlink_dirs. All uses
1114 * src/rm.c (usage): Don't mention rm -d.
1116 2005-11-02 Jim Meyering <jim@meyering.net>
1118 * tests/dd/skip-seek: Fix typo in comment: s/fileutils/coreutils.
1119 From Andreas Schwab.
1121 * tests/dd/unblock-sync: Redirect stderr to /dev/null so the
1122 `M+N records in/out' lines don't pollute `make check' output.
1124 * tests/dd/skip-seek (sk-seek4): New test, to exercise the bug
1125 fixed on 2005-10-31. This test uses the new, IN_PIPE specifier.
1126 * tests/Coreutils.pm: Accept a new type of input specifier: IN_PIPE,
1127 to indicate that the input file should be piped into the command
1128 under test (via `cat FILE | $prog ...').
1130 * src/remove.c (remove_entry): Emit a better diagnostic when rm
1131 (without -r) fails to remove a directory on a non-Linux system.
1132 This change affects only newer Solaris systems (with priv_*
1133 functions like priv_allocset). Reported by Keith Thompson.
1135 * tests/rm/dir-nonrecur: New file/test for the above fix.
1136 * tests/rm/Makefile.am (TESTS): Add dir-nonrecur.
1138 2005-11-01 Paul Eggert <eggert@cs.ucla.edu>
1140 * NEWS: "tail -c 2 FILE" and "touch 0101000000" now operate as
1141 POSIX 1002.1-2001 requires.
1142 * src/tail.c (parse_obsolete_option): Implement this.
1143 Problem reported by Vincent Lefevre.
1144 * src/touch.c (main): Pass PDS_PRE_2000 to posixtime.
1145 * tests/tail/Test.pm (c-2, c-2-minus, c2, c2-minus): New tests.
1146 (test_vector): Add special cases for _POSIX2_VERSION, and
1147 regularize the old ones a bit.
1148 * tests/touch/obsolescent: Add y2000 test.
1150 2005-10-31 Paul Eggert <eggert@cs.ucla.edu>
1152 * src/dd.c (skip): Fix off-by-one error reported by
1153 Theodoros V. Kalamatianos.
1155 2005-10-30 Paul Eggert <eggert@cs.ucla.edu>
1157 * tests/mkdir/p-3: Require that the test be run as non-root.
1158 Problem and trivial fix reported by Theodoros V. Kalamatianos.
1160 2005-10-28 Paul Eggert <eggert@cs.ucla.edu>
1162 * src/ln.c (FILE_BASENAME_CONCAT): Omit unnecessary slashes in the
1163 boundary between DEST and SOURCE in the result.
1165 2005-10-26 Dmitry V. Levin <ldv@altlinux.org>
1167 * src/md5sum.c (main) [!O_BINARY]: Changed default read mode
1168 back to text, to sync with documentation and for backwards
1171 2005-10-25 Jim Meyering <jim@meyering.net>
1173 * tests/dircolors/simple (other-wr): Add an explicit test for
1174 the dircolors bug (NULL-dereference) fixed yesterday.
1176 2005-10-24 Jim Meyering <jim@meyering.net>
1178 * src/tac.c (tac_file): When determining whether a file is seekable,
1179 also test whether it is a tty. Using only the lseek-based test would
1180 give a false positive on Solaris. Reported by Peter Fales.
1182 2005-10-24 Dmitry V. Levin <ldv@altlinux.org>
1184 * tests/install/d-slashdot: New test, for "install -d" failure.
1185 * tests/install/Makefile.am (TESTS): Add d-slashdot.
1186 * tests/mkdir/p-slashdot: New test, for "mkdir -p" failure.
1187 * tests/mkdir/Makefile.am (TESTS): Add p-slashdot.
1189 2005-10-24 Jim Meyering <jim@meyering.net>
1191 * src/dircolors.c (ls_codes): Add missing comma.
1192 Anonymous report and patch from
1193 http://savannah.gnu.org/bugs/?func=detailitem&item_id=14849
1195 * src/dircolors.c: Add compile-time assertion that the slack_codes
1196 and ls_codes arrays have the same number of elements. This would
1197 have prevented the above-fixed bug.
1199 * src/expand.c (parse_tab_stops): Add a comment to make this function
1200 identical to the one in unexpand.c.
1201 * src/unexpand.c (parse_tab_stops): Adjust syntax to make this function
1202 identical to the one in expand.c.
1204 * src/expand.c (next_file): Don't assume fopen cannot return stdin.
1206 2005-10-23 Jim Meyering <jim@meyering.net>
1208 * src/md5sum.c (digest_check, main): Use ptr_align rather than
1209 a dangerous pointer-value-to-`unsigned' cast.
1210 * NEWS: mention the new sha* programs.
1211 * AUTHORS: Add new sha* programs.
1213 2005-08-28 David Madore <david.madore@ens.fr>
1215 Add new programs: sha224sum, sha256sum, sha384sum, sha512sum.
1216 * README: Add their names to the list.
1217 * src/md5sum.c: Provide framework for computing sha-2 hashes.
1218 * src/Makefile.am (sha224sum, sha256sum, sha384sum, sha512sum):
1219 Rules for compiling sha-2 utilities
1220 (noinst_HEADERS): Remove checksum.h.
1221 * man/sha512sum.x, man/sha384sum.x, man/sha256sum.x, man/sha224sum.x:
1223 * man/Makefile.am (dist_man_MANS): Add the corresponding .1 names.
1224 (sha224sum.1, sha256sum.1, sha384sum.1, sha512sum.1): New dependencies.
1225 * tests/misc/sha224sum, tests/misc/sha256sum: New files.
1226 * tests/misc/sha384sum, tests/misc/sha512sum: New files.
1227 * tests/misc/Makefile.am (TESTS): Add new sha224sum, sha256sum,
1228 sha384sum, sha512sum test scripts here rather that each in its
1231 2005-08-28 David Madore <david.madore@ens.fr>
1233 * tests/sha1sum/basic-1 (million-a): Add the "million a's" test (one
1234 of the FIPS test vectors).
1236 2005-10-23 Jim Meyering <jim@meyering.net>
1238 * configure.ac: Use 6.0-cvs as the version string.
1239 * NEWS: Adjust accordingly.