1 2006-02-08 Jim Meyering <jim@meyering.net>
5 * Makefile.maint (local-checks-available): Define in terms of
6 the expansion, $(syntax-check-rules), rather than the single,
7 top-level target `syntax-check', so that it's easier to exclude
8 individual rules (via $(local-checks-to-skip)).
9 (tgz-md5, tgz-sha1, ...): Remove now-unused definitions.
11 2006-02-07 Jim Meyering <jim@meyering.net>
13 * src/system.h (!defined O_DIRECT): If O_DIRECTIO is defined (as it
14 is on Tru64), define O_DIRECT to that. Patch From James Lemley.
16 * tests/help-version (expected_failure_status_vdir):
17 Redirect an expected disk-full diagnostic to /dev/null.
19 2006-02-06 Jim Meyering <jim@meyering.net>
21 * src/unexpand.c (usage): Use two spaces (not one) to separate the
22 --first-only option string from its description, so help2man formats
23 the derived man page properly.
24 * src/rm.c (usage): Likewise for --no-preserve-root.
25 * src/chown.c (usage): Likewise.
26 * src/chgrp.c (usage): Likewise.
28 Add a rule to ensure that the above doesn't happen again.
29 * Makefile.maint (sc_two_space_separator_in_usage): New rule.
30 (syntax-check-rules): Add it.
31 * .x-sc_two_space_separator_in_usage: New empty file.
32 * Makefile.am (EXTRA_DIST): Add .x-sc_two_space_separator_in_usage.
34 2006-02-06 Jim Meyering <jim@meyering.net>
36 * src/cp.c (usage): Use two spaces (not one) to separate each
37 option string from its description, so help2man formats the
38 derived man page properly.
39 * src/mv.c (usage): Likewise.
40 Patch from Nicolas François in http://bugs.debian.org/351601.
42 2006-02-04 Jim Meyering <jim@meyering.net>
44 * src/copy.c (copy_internal): cp -RL would fail when encountering
45 the same directory more than once in the hierarchy beneath a single
46 command-line argument. That is legitimate, e.g. when there are
47 two or more symbolic links, each pointing to some directory that
48 would not otherwise be copied. Reported by Christophe LYON.
49 * tests/cp/cp-deref: New file. Test for today's fix.
50 * tests/cp/Makefile.am (TESTS): Add cp-deref.
51 * NEWS: Document this.
53 2006-02-03 Jim Meyering <jim@meyering.net>
55 * configure.ac: Require automake-1.9.6, not 1.8.3.
57 2006-02-01 Paul Eggert <eggert@cs.ucla.edu>
59 * src/od.c (usage): Mention that -t a ignores high order bit.
60 Documentation problem reported by Ed Avis.
62 2006-02-01 Jim Meyering <jim@meyering.net>
64 * src/pwd.c (find_dir_entry): Remove unused local, `ent_sb_valid'.
66 2006-01-30 Paul Eggert <eggert@cs.ucla.edu>
68 * src/head.c (main): Use a better diagnostic when someone uses a
69 trailing numeric option in an invalid way. Problem reported by
71 * src/tail.c (parse_options): Likewise.
73 2006-01-30 Jim Meyering <jim@meyering.net>
75 * man/wc.x: Include `count' keyword in man page synopsis,
76 per suggestion from http://bugs.debian.org/181585.
78 2006-01-24 Paul Eggert <eggert@cs.ucla.edu>
80 * src/df.c (show_dev): If the file system claims to have
81 more available than total blocks, report the number of used
82 blocks as being total - available (a negative number) rather
83 than as garbage. Problem reported by Toralf Foerster.
85 2006-01-24 Jim Meyering <jim@meyering.net>
87 * src/tail.c (tail_forever): Don't exit-nonzero when an attempt
88 to put a regular file in O_NONBLOCK mode fails with EPERM.
89 That happens on Linux (up to 2.6.15) when using tail -f on a file with
90 the append-only attribute. Reported by Dean Gaudet. For details,
91 see http://savannah.gnu.org/bugs/?func=detailitem&item_id=15473.
92 * NEWS: Mention this fix.
93 * tests/tail-2/append-only: New file. Test for the above.
94 * tests/tail-2/Makefile.am (TESTS): Add append-only.
95 * tests/Makefile.am (check-root): Add tail-2/append-only
97 2006-01-21 Jim Meyering <jim@meyering.net>
99 * NEWS: Mention fts-related improvements and bug fixes.
101 2006-01-19 Jim Meyering <jim@meyering.net>
103 * tests/fmt/basic (pfx-1, pfx-2): New tests, to demonstrate the bug
104 reported as http://bugs.debian.org/147577. Forwarded by Thomas Hood.
106 2006-01-18 Jim Meyering <jim@meyering.net>
108 * tests/du/Makefile.am (TESTS): Add long-from-unreadable.
110 2006-01-17 Jim Meyering <jim@meyering.net>
112 Now that fts no longer changes the current working directory, adjust
113 its clients accordingly -- note that du.c uses fts but doesn't need
114 any adjustment, since it doesn't operate on the actual files,
115 but rather just uses the stat buffers provided by fts.
117 * src/chown-core.c: Include "openat.h".
118 Don't include "lchown.h".
119 (restricted_chown): Accept a new parameter, CWD_FD, and use it in
120 calling openat, lchownat, chownat, rather than open, lchown, chown.
122 * src/chmod.c: Include "openat.h".
123 (process_file): Use chmodat (fts->fts_cwd_fd,... in place of chmod (...
125 * tests/du/long-from-unreadable: New test, to exercise one small
128 2006-01-13 Jim Meyering <jim@meyering.net>
130 * tests/Makefile.am (SUBDIRS): Add comments discouraging the
131 addition of new directories under tests/.
133 * tests/acl: Redirect stdin to /dev/null. Otherwise, FreeBSD 5.0's
136 2006-01-12 Jim Meyering <jim@meyering.net>
138 * tests/du/long-sloop: Adjust not to hard-code the expected
139 diagnostic corresponding to ELOOP. Solaris' diagnostic differs
140 from that of GNU libc. Reported by Paul Eggert.
142 * tests/du/long-sloop: Create file at end of symlink chain.
144 * tests/misc/test: New file, with a test for one of the
145 bugs fixed by yesterday's test.c changes.
146 * tests/misc/Makefile.am (TESTS): Add test.
148 2006-01-11 Jim Meyering <jim@meyering.net>
150 * tests/du/long-sloop: New file. Test for today's fts.c bug fix.
151 That bug could make du -L, chgrp -L, or chown -L fail to diagnose
152 a very long sequence of symbolic links (not necessarily a loop).
153 * tests/du/Makefile.am (TESTS): Add long-sloop.
155 2006-01-11 Paul Eggert <eggert@cs.ucla.edu>
157 * src/test.c (test_syntax_error): Append a newline. All callers
158 changed, except for the ones that didn't already append a newline.
159 Bug reported by Eric Blake.
161 2006-01-11 Jim Meyering <jim@meyering.net>
163 * src/system.h (X2NREALLOC): Now that verify_true is no longer
164 void, cast its result to void, to avoid gcc's warning that
165 ``left-hand operand of comma expression has no effect''.
166 (DECIMAL_DIGIT_ACCUMULATE, X2REALLOC): Likewise.
168 2006-01-10 Jim Meyering <jim@meyering.net>
170 * tests/chmod/no-x: Add a test for today's fts.c fix.
172 2006-01-10 Jim Meyering <jim@meyering.net> (tiny change)
174 * src/ls.c (gobble_file): Use DTTOIF only if it's defined.
175 This is necessary for Dragonfly. Patch by Joerg Sonnenberger.
177 2006-01-10 Paul Eggert <eggert@cs.ucla.edu>
179 * src/system.h (X2NREALLOC, X2REALLOC, DECIMAL_DIGIT_ACCUMULATE):
180 Use verify_true instead of verify_expr, to sync with gnulib.
182 2006-01-08 Jim Meyering <jim@meyering.net>
184 * src/date.c (usage): Adjust the formatting of the entries for
185 %::z and %:::z (separate with two spaces, not one) so that help2man
186 formats them properly. Reported by Philip Rowlands.
188 2006-01-06 Paul Eggert <eggert@cs.ucla.edu>
190 * configure.ac (gl_IGNORE_UNUSED_LIBRARIES): Add.
192 2006-01-06 Jim Meyering <jim@meyering.net>
194 * Makefile.maint (copyright-check): Use date +%Y in place of
197 * src/remove.c (rm_1): Remove `static' attribute on local `status'.
198 First off, the attribute should have been `volatile' (not static)
199 to avoid longjmp-related risk of clobber. Secondly, now there is
200 no longer any risk of a local variable being clobbered, so there's
201 no need for any attribute at all.
203 2006-01-05 Jim Meyering <jim@meyering.net>
205 * src/remove.c: Give a few functions the inline attribute.
206 (AD_pop_and_chdir): Use gotos to avoid some duplication.
207 (AD_push): Rewrite an assertion so that the entire computation
208 goes away when assertions are turned off.
210 * src/tail.c (ENOSYS) [!defined ENOSYS]: Don't define here.
211 It's already defined in "system.h".
212 * Makefile.maint: Add a FIXME comment.
214 2006-01-04 Jim Meyering <jim@meyering.net>
216 * ChangeLog: Remove entries from 2005-10-22 and earlier.
217 * ChangeLog-2005: New file, for entries up to version 5.92.
219 2006-01-03 Jim Meyering <jim@meyering.net>
221 * tests/du/no-x: Also allow a slightly different diagnostic -- the
222 one you get when using openat-enabled fts.c and du (coming soon).
223 * tests/chmod/no-x: Likewise.
224 * tests/chgrp/no-x: Likewise.
226 * src/system.h (O_DIRECTORY) [!defined O_DIRECTORY]: Define.
228 2006-01-02 Paul Eggert <eggert@cs.ucla.edu>
230 * src/chown-core.c (RC_do_ordinary_chown): New enum value.
231 (restricted_chown): Return it, if the file cannot be accessed due
232 to EPERM, or if no uid or gid are required, or if the file is
233 neither a directory nor a regular file. Rewrite to avoid gotos.
234 (change_file_owner): Handle RC_do_ordinary_chown case.
235 Rewrite to avoid gotos.
236 * tests/chgrp/basic: Make sure we can change the group of
239 * src/date.c (usage): Explain %g, %G, and %V a bit better.
241 2006-01-02 Jim Meyering <jim@meyering.net>
243 * src/copy.c (set_owner): Correct a comment.
245 * src/tail.c (parse_options): Change warning to say that --retry
246 is useful `mainly' (not `only') when following by name.
247 Reported here: http://bugs.debian.org/273781
249 2006-01-01 Paul Eggert <eggert@cs.ucla.edu>
251 * NEWS: Document that mkfifo and mknod -m no longer set special bits.
252 * src/copy.c: Include lchmod.h.
253 (copy_internal): Use lchmod rather than chmod.
254 * src/cp.c: Include lchmod.h.
255 (re_protect, make_dir_parents_private): Use lchmod rather than chmod.
256 * src/mkdir.c: Include lchmod.h.
257 (usage): Clarify -m's operation.
258 (main): Use lchmod rather than chmod. Don't use lchmod unless the
259 new mode contains bits outside the 777 range.
260 * src/mkfifo.c (usage): Clarify -m's operation.
261 (main): If -m is given, don't invoke chmod; use umask 0 instead.
262 Report an error if -m asks for bits outside the 777 range.
263 * src/mknod.c (usage, main): Likewise.
265 * src/mkdir.c, src/mkfifo.c, src/mknod.c: Undo 2005-12-19 changes.
267 2005-12-27 Jim Meyering <jim@meyering.net>
269 * Makefile.maint (sc_obsolete_symbols): Prohibit use of O_NDELAY.
270 (sc_prohibit_assert_without_use): New rule.
271 (syntax-check-rules): Add it to the list.
272 * .x-sc_prohibit_assert_without_use: New empty file.
273 * Makefile.am (EXTRA_DIST): Add it.
275 * Makefile.maint (CVS_LIST): Define in terms of $(srcdir).
277 * cp.c, df.c, link.c, mknod.c, nice.c, sleep.c, unlink.c:
278 Don't include <assert.h>; it wasn't used.
280 2005-12-26 Paul Eggert <eggert@cs.ucla.edu>
282 * src/chown-core.c (restricted_chown):
283 Don't try O_WRONLY unless O_RDONLY failed wth EACCES.
284 * src/remove.c (fd_to_subdirp): Open with O_DIRECTORY | O_NOCTTY
285 | O_NOFOLLOW too, for consistency with other dir-openers.
286 Use POSIX-preferred O_NONBLOCK rather than O_NDELAY.
287 (is_empty_dir): Likewise.
288 * src/shred.c (wipename): Likewise. Don't bother trying to open
289 dir for writing, since POSIX prohibits it.
291 2005-12-22 Jim Meyering <jim@meyering.net>
293 * tests/help-version: Redirect stderr to /dev/full, to suppress
294 write error diagnostic.
296 2005-12-19 Jim Meyering <jim@meyering.net>
298 * src/mkdir.c, src/mknod.c, src/mkfifo.c (main)
299 Avoid a minor race condition when `-m MODE' is specified, by using
300 open, fchown, and close rather than just chown. To do that reliably --
301 even with an overly restrictive umask -- ensure that each mkdir,
302 mknod and mkfifo call uses a mode including at least owner-read access.
303 * src/mknod.c (main): When `-m MODE' is specified, exit nonzero if
304 the subsequent chown (or equivalent open,fchown,close) fails.
305 * tests/misc/mknod: New tests.
306 * tests/misc/Makefile.am (TESTS): Add mknod.
308 2005-12-17 Jim Meyering <jim@meyering.net>
310 * src/remove.c (is_empty_dir): Open with O_NDELAY, so we don't hang,
311 e.g., on a named pipe.
312 (OPEN_NO_FOLLOW_SYMLINK): Remove definition. Use O_NOFOLLOW in
313 place of all uses, since it is guaranteed (system.h) to be defined.
315 2005-12-05 Andreas Gruenbacher <agruen@suse.de>
317 Add POSIX ACL support
318 * src/ls.c: Switch back from HAVE_ACL to USE_ACL: The acl() syscall
319 is no requirement for ACL support; particularly, it does not exist
320 on systems that have POSIX ACLs.
321 * src/copy.h (cp_option_init) [umask_kill]: Remove member.
322 * src/cp.c (umask_kill): With default acls, the umask is not to be
323 applied. Remove umask_kill, don't change the process umask, and let
324 the kernel apply the umask where appropriate.
325 * src/cp.c (make_dir_parents_private): Fix logic for POSIX ACLs.
326 * src/copy.c (get_dest_mode): Remove; it is obsolete after removing
328 (copy_reg, copy_internal): Use copy_acl and set_acl
329 instead of fchown/chown. Fix the logic for POSIX ACLs.
330 (chown_succeded): Remove; we now always copy acls and
331 preserve S_ISUID, S_ISGID, and S_ISVTX when needed, no matter if we
332 did a chown before or not.
333 * src/mv.c, src/install.c (cp_option_init): Don't set umask_kill member.
334 * src/Makefile.am (dir_LDADD, ls_LDADD, vdir_LDADD, cp_LDADD,
335 mv_LDADD, ginstall_LDADD): On systems with an ACL library, arrange
336 to link with it via $(LIB_ACL), for the utilities that need it.
338 2005-12-16 Paul Eggert <eggert@cs.ucla.edu>
340 * src/remove.c (OPENAT_CWD_RESTORE__REQUIRE): Remove.
341 (OPENAT_CWD_RESTORE__ALLOW_FAILURE): Likewise.
342 (fd_to_subdirp): Remove openat_cwd_restore_allow_failure arg; its
343 value is now signified by whether cwd_errno is null.
344 (fd_to_subdirp, remove_dir, rm_1); Change cwd failure indicator from
345 pointer-to-bool to pointer-to-errno-value. All callers changed.
346 (rm_1): Don't bother setting a local cwd failure flag and then
347 ORing it into the caller's. Just set the caller's.
348 (rm): Use cwd failure errno value to print a slightly-better
351 2005-12-15 Jim Meyering <jim@meyering.net>
353 * src/stat.c (print_it): Properly handle a backslash at the
354 end of a --printf format string. Reported by Paul Eggert.
355 * tests/misc/stat-printf (end-bs): Add a test for the above.
357 2005-12-15 Paul Eggert <eggert@cs.ucla.edu>
359 * tests/acl: Port to pre-POSIX shells like Solaris 8 /bin/sh.
360 Don't assume /etc/passwd contains user names; use 'id' instead.
362 2005-12-15 Jim Meyering <jim@meyering.net>
364 stat: revert behavior of --format=FMT (-c)
365 stat: add new option: --printf=FMT
366 * NEWS: Mention this.
367 * src/stat.c (isodigit, octtobin, hextobin): Define.
368 (PRINTF_OPTION): Define.
369 (interpret_backslash_escapes, trailing_delim): New globals.
370 (usage): Document them. Alphabetize on long option names.
371 (print_esc_char): New function.
372 (print_it): Rewrite, in order to handle backslash escapes.
373 (main): Handle new option. Set globals for --format, too.
375 * tests/misc/stat-printf: Test --printf and --format.
376 * tests/misc/Makefile.am (TESTS): Add stat-printf.
378 2005-12-14 Paul Eggert <eggert@cs.ucla.edu>
380 * NEWS: sort now reports incompatible options.
381 * src/sort.c (incompatible_options, check_ordering_compatibility):
383 (main): Use them. Don't bother with a usage message for
384 "sort -c a b", for consistency with other error diagnostics.
385 * tests/sort/Test.pm (incompat1, incompat2, incompat3, incompat4):
388 * src/cat.c (main): Undo previous change. close_stdout already
389 does the check, so the previous change wasn't necessary.
391 2005-12-13 Paul Eggert <eggert@cs.ucla.edu>
393 * src/cat.c (main): Check for close (STDOUT_FILENO) failure.
395 2005-12-12 Paul Eggert <eggert@cs.ucla.edu>
397 Install a more-conservative approach for sort -R. It's the
398 same basic idea as the existing code, except it uses the full ISAAC
399 approach (called the "more kosher" approach in the existing comments).
400 This makes "sort -R" quite a bit slower (about a factor of 2 on my
401 little tests involving 10000 lines on a 2.4 GHz P4), but I think it's
402 better to be conservative here at first, and review any performance
403 improvements carefully.
404 * .x-sc_require_config_h: Add src/rand-isaac.c.
405 * src/rand-isaac.h: Remove. All uses now simply include rand-isaac.c.
406 * src/Makefile.am (noinst_HEADERS): Remove rand-isaac.h.
407 (shred_SOURCES, sort_SOURCES): Remove.
408 (EXTRA_DIST): Add rand-isaac.c.
409 * src/rand-isaac.c: Revert to what used to be in shred.c, without
410 changing it to allow for varying numbers of words in the state.
411 Alter so that we include rand-isaac.c directly rather than
412 compiling it and linking to it. Don't include config.h or
413 system.h; that's the includer's responsibility.
414 Omit functions that are specific to shred.
415 (ISAAC_LOG, ISAAC_WORDS, ISAAC_BYTES, struct isaac_state, ind):
416 (isaac_step, struct irand_state):
417 Resurrect these, with the same defns that used to be in shred.c.
418 (ISAAC_SIZE, isaac_new, isaac_copy): Remove.
419 (isaac_refill, isaac_seed_start, isaac_seed_data, irand_init, irand32):
421 (struct isaac_state, isaac_refill, isaac_mix, isaac_init):
422 (isaac_seed_start, isaac_seed_data, isaac_seed_finish, isaac_seed):
423 (irand_init, irand32, irand_mod):
424 Number of words is constant again.
425 (struct irand_state, irand_init, irand32, irand_mod): Move to shred.c.
426 * src/shred.c: Include rand-isaac.c rather than rand-isaac.h.
427 * src/sort.c: Likewise.
428 * src/shred.c (fillrand, dopass, main): Undo previous change.
429 (struct irand_state, irand_init, irand32, irand_mod): Moved back here,
431 * src/sort.c: Don't include md5.h; it wasn't needed.
432 (struct keyfield): Rename random_hash to random, for consistency
433 with the other member names. All uses changed.
434 (usage): Tweak wording to mention STRING for --seed option.
435 (short_options): Rorder for consistency with other programs.
436 (rand_state): Now a struct, not a pointer to one. All uses changed.
437 (HASH_WORDS, HASH_SIZE): Remove.
438 (get_hash): Remove comments around resbuf size, since we can assume C89.
439 Use a "more-kosher" (but slower) approach of invoking isaac_refill.
440 (keycompare): Adjust to the new get_hash.
442 (badfieldspec): Omit recently-introduced comment; it isn't needed.
443 (main): Don't set need_random simply because gkey has it set; that
444 doesn't necessarily mean we'll need random numbers.
445 Redo seeding to match new get_hash approach.
447 2005-12-10 Jim Meyering <jim@meyering.net>
449 * src/Makefile.am (noinst_HEADERS): Add rand-isaac.h.
451 Avoid shred segfault on 64-bit systems.
452 * src/rand-isaac.c (isaac_refill): Don't try to negate a
453 local of type uint32_t. Make the local an `int' instead.
455 * NEWS: Mention sort's new options.
457 * src/rand-isaac.c (isaac_mix): Declare to be static.
458 Mark all other functions as `extern' so the tight-scope
459 part of `make distcheck' passes once again.
460 * src/rand-isaac.h (isaac_mix): Remove declaration.
462 * src/sort.c (get_hash): Change position of `*' in parameter
463 type to conform with convention.
464 (main): Split a long line so it fits in 80 columns.
465 (keycompare): Remove stray SPACE before TAB that was
466 causing `make distcheck' to fail.
468 * src/shred.c: Don't include gethrxtime.h. No longer needed.
470 * tests/misc/sort-rand: New file: basic tests for the new options.
471 * tests/misc/Makefile.am (TESTS): Add sort-rand.
473 2005-12-10 Frederik Eaton <frederik@ofb.net>
475 * src/Makefile.am (sort_LDADD): Add $(LIB_GETHRXTIME).
476 (shred_SOURCES, sort_SOURCES): New macros, so we compile rand-isaac.c.
477 * src/rand-isaac.c: New file, containing ISAAC code that was in shred.c.
478 Make state size runtime-configurable.
479 (isaac_new, isaac_copy): New functions.
480 * src/rand-isaac.h: New file.
481 * src/shred.c: Include rand-isaac.h. Move ISAAC code to rand-isaac.c.
482 (fillrand, main): Adjust to the fact that the state size is now
483 runtime-configurable.
484 * src/sort.c (short_options, long_options, WORDS, keycompare, main):
485 (usage): Add options --random-sort and --seed to implement a random
487 Include md5.h and rand-isaac.h.
488 (get_hash): New function.
489 (rand_state): New var.
490 (HASH_WORDS, HASH_SIZE): New macros.
492 2005-12-09 Paul Eggert <eggert@cs.ucla.edu>
494 * tests/dd/misc: Add test for dd iflags=noatime.
496 2005-12-09 Jim Meyering <jim@meyering.net>
498 * src/sort.c (usage): Mention white space vs -b and -t options.
501 2005-12-09 Eric Blake <ebb9@byu.net>
503 * src/test.c (main): Fix misleading comment.
505 2005-12-07 Paul Eggert <eggert@cs.ucla.edu>
507 * NEWS: Mention dd's new noatime flag.
508 * src/system.h (O_NOATIME): Define to 0 if not already defined.
509 * src/dd.c (flags, usage): Add support for noatime flag.
511 2005-12-07 Jim Meyering <jim@meyering.net>
513 Distribute the cvsu script, used only by `make syntax-check'.
514 * Makefile.am (EXTRA_DIST): Add build-aux/cvsu.
515 * Makefile.maint (CVS_LIST): Use build-aux/cvsu, now that we
516 distribute a copy of this script.
517 * .x-sc_unmarked_diagnostics: Add build-aux/cvsu.
519 * tests/mv/acl: exit-77 before the trap, not after, if we fail
520 to create a temporary directory on another partition.
521 From Andreas Gruenbacher.
523 2005-12-06 Tomas Pospisek <tpo@sourcepole.ch> (tiny change)
525 * man/basename.x: Cross-reference to dirname and readlink.
526 * man/dirname.x: Cross-reference to basename and readlink.
528 2005-12-05 Andreas Gruenbacher
530 * src/copy.c [!HAVE_FCHOWN]: Define fchown(...) to -1.
531 (set_owner, preserve_author): New functions, factored out of copy_reg.
532 (copy_reg): Use them.
533 (copy_internal): Use them here, too.
535 2005-12-04 Jim Meyering <jim@meyering.net>
537 * src/sleep.c (usage): Say what happens with two or more arguments.
538 Suggested by Justin Pryzby.
540 * src/uptime.c (print_uptime): Move decl of `upsecs' into scope
543 2005-12-03 Jim Meyering <jim@meyering.net>
545 * src/rm.c (long_opts): Change the name of each undocumented, for-
546 testing-only option to start with `-', so that it cannot render
547 ambiguous any prefix it happens to share with some other option name.
548 Problem reported by Eric Blake.
549 * src/head.c (long_options): Likewise.
550 * src/tail.c (long_options): Likewise.
552 * tests/misc/head-elide-tail: Update uses of undocumented, for-
553 testing-only --presume* options to start with `---'.
554 * tests/rm/dangling-symlink: Likewise.
555 * tests/rm/dir-no-w: Likewise.
556 * tests/rm/isatty: Likewise.
558 2005-11-30 Jim Meyering <jim@meyering.net>
560 * Makefile.maint: Add a comment about cvsu.
562 2005-11-25 Paul Eggert <eggert@cs.ucla.edu>
564 * NEWS: df updates for "none", "proc", inaccessible file systems.
565 * src/df.c (show_point): Ignore inaccessible file systems.
566 (usage): -a includes dummy file systems, not size-0 file systems.
568 * src/od.c (unsigned_long_long_int): Renamed from ulonglong_t,
569 to avoid collision with POSIX name space. All uses changed.
571 2005-11-24 Jim Meyering <jim@meyering.net>
573 * tests/Makefile.am (EXTRA_DIST): Add acl to the list.
574 * tests/acl: Add `$0: ' prefix to diagnostics.
576 * .x-sc_require_config_h: Add lib/buffer-lcm.c to the list.
578 2005-11-23 Paul Eggert <eggert@cs.ucla.edu>
580 * src/copy.c: Improve performance a bit by optimizing away
581 unnecessary system calls and going to a block size of at least
582 8192 (on normal hosts, anyway). This improved performance 5% on my
583 Debian stable host (2.4.27 kernel, x86, copying from root
584 ext3 file system to itself).
585 Include "buffer-lcm.h".
586 (copy_reg): Omit last argument. All callers changed.
587 Use xmalloc to allocate rather than trusting alloca
588 (which is unwise with large block sizes).
589 Declare locals more locally, if possible.
590 Use uintptr_t words instead of int words, for a bit more speed
591 when looking for null blocks on 64-bit hosts.
592 Optimize away reads of zero bytes on regular files.
593 In the typical case, insist on 8 KiB buffers, at least.
594 Avoid unnecessary extra call to fstat when checking for sparse files.
595 Avoid now-unnecessary cast to off_t, and "0L".
596 Avoid unnecessary test of *new_dst when checking for same owner
599 2005-11-22 Paul Eggert <eggert@cs.ucla.edu>
601 * src/remove.c (rm): Don't assume C99 for-loop syntax.
603 2005-11-22 Jim Meyering <jim@meyering.net>
605 * src/remove.c (AD_push): Remove debugging cruft.
607 * tests/rm/unread2 (rm): Change expected diagnostic,
608 `cannot open directory' to `cannot remove', to align with
610 * tests/rm/rm2: Ensure that rm now continues removing entries
611 even after certain types of failure.
613 * src/remove.c: Rewrite. Now, this module is reentrant on systems
614 that provide openat (Solaris), and on systems like Linux+procfs
615 where our openat emulation code is reentrant. This also fixes a
616 few low-probability leaks and eliminates some code that could,
617 in very unusual circumstances, cause rm() (via a callee) to exit.
618 * NEWS: Mention this.
620 * configure.ac: Put copyright dates all on one line so the
621 emacs function that updates them works properly.
623 2005-11-18 Paul Eggert <eggert@cs.ucla.edu>
625 * configure.ac (AM_PROG_CC_C_O): Add. Needed for CVS Automake.
626 Problem reported by Eric Blake.
627 (AC_PROG_CC_STDC): Use this instead of AC_PROG_CC, so that
628 we get a standard-conforming compiler. This relies on the new
629 m4/c.m4 file. Note that it's a bit tricky, since c.m4 doesn't
630 define AC_PROG_CC_STDC; we are relying on Autoconf 2.59 internals.
631 m4/c.m4 can go away with Autoconf 2.60 comes out.
633 2005-11-17 Jim Meyering <jim@meyering.net>
635 * src/remove.c (AD_mark_helper): Make a `char *' parameter `const'.
636 (AD_mark_current_as_unremovable): Likewise, but for a local.
639 * tests/mv/acl: Let traps handle removing temporary directories.
641 Expect acl-related tests to fail, until the corresponding
642 patches are committed.
643 * tests/mv/Makefile.am (XFAIL_TESTS): Add acl.
644 * tests/cp/Makefile.am (XFAIL_TESTS): Likewise.
646 ACL tests, from Andreas Gruenbacher.
647 * tests/acl, tests/mv/acl, tests/cp/acl: New files.
648 * tests/mv/Makefile.am (TESTS): Add acl.
649 * tests/cp/Makefile.am (TESTS): Add acl.
651 * src/ls.c (basename_is_dot_or_dotdot): Correct wording in comment.
653 2005-11-16 Paul Eggert <eggert@cs.ucla.edu>
655 * NEWS: Improve quality of ln's diagnostics.
656 * src/ln.c (do_link, usage): Likewise.
657 (do_link): Don't use alloca on a buffer of unbounded size.
659 2005-11-16 Jim Meyering <jim@meyering.net>
661 * tests/cp/fail-perm: Accommodate HPUX. It appears to fail
662 with EACCES rather than EPERM. Reported by Peter O'Gorman here:
663 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/5766
665 2005-11-14 Jim Meyering <jim@meyering.net>
667 * NEWS (sort): Mention consequences of today's mkstemp-safer.c fix.
669 2005-11-13 Jim Meyering <jim@meyering.net>
671 * announce-gen: Accept new option, --gpg-key-id=ID and
672 emit a blurb telling how to use the .sig files.
673 * Makefile.cfg (gpg_key_ID): Define.
674 * Makefile.maint (announcement): Use new option and key.
676 Require that most .c files include <config.h>.
677 * Makefile.maint (sc_require_config_h): New rule.
678 (syntax-check-rules): Add it.
679 * .x-sc_require_config_h: New file listing exceptions to the
680 above rule. Some are legit, others are simply grandfathered in.
681 * Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h here, too.
683 2005-11-12 Jim Meyering <jim@meyering.net>
685 * src/checksum.h, src/md5.c, src/sha1sum.c: Remove now-unused files.
687 2005-11-11 Jim Meyering <jim@meyering.net>
689 * NEWS: Mention `readlink -f' bug fix in 5.3.0 news.
690 Mention new readlink options in 5.3.0's `New features' section.
691 Spotted by Thomas Hood.
693 2005-11-08 Jim Meyering <jim@meyering.net>
695 * NEWS: Merge in changes from b5_9x branch.
697 2005-11-08 Paul Eggert <eggert@cs.ucla.edu>
699 * NEWS: ls now defaults to --time-style='locale', which in turn acts
700 like --time-style='posix-long-iso' if the locale settings are messed up.
701 * src/ls.c (decode_switches): Implement this.
703 2005-11-08 Jim Meyering <jim@meyering.net>
705 * tests/du/2g: s/expensive/very expensive/ in a comment.
708 2005-10-17 Eric Blake <ebb9@byu.net>
710 * src/ls.c (usage): Fix descriptions of --sort, --time.
711 Reported by Vitaly A. Ostanin.
713 2005-11-04 Paul Eggert <eggert@cs.ucla.edu>
715 * src/ln.c: Include filenamecat.c.
716 (FILE_BASENAME_CONCAT): Remove.
717 (do_link): Remove last arg DEST_IS_DIR. All callers changed.
718 (main): Use file_name_concat, base_name, and strip_trailing_slashes
719 instead of FILE_BASENAME_CONCAT. This simplifies the code, and avoids
722 2005-11-04 Jim Meyering <jim@meyering.net>
724 * src/du.c (process_file): Don't overflow for files of size >= 2^31
725 on systems with stat.st_blocks of a signed 32-bit type.
726 This bug causes trouble on some AIX 5.1 systems.
727 Report and trivial patch from Paul Townsend:
728 <http://lists.gnu.org/archive/html/bug-coreutils/2005-11/msg00033.html>
729 * NEWS: Mention this.
731 * tests/du/2g: New (very-expensive) test for the above-fixed bug.
732 * tests/du/Makefile.am (TESTS): Add it here.
733 * tests/very-expensive: New file.
734 * tests/Makefile.am (EXTRA_DIST): Add it here.
735 * tests/cp/perm: Mark this test as `very-expensive', too.
737 2005-11-02 Paul Eggert <eggert@cs.ucla.edu>
739 * NEWS: Mention that rm -d and maybe ln -d are scheduled for
741 * src/remove.h (struct rm_options): Remove unlink_dirs. All uses
743 * src/rm.c (usage): Don't mention rm -d.
745 2005-11-02 Jim Meyering <jim@meyering.net>
747 * tests/dd/skip-seek: Fix typo in comment: s/fileutils/coreutils.
750 * tests/dd/unblock-sync: Redirect stderr to /dev/null so the
751 `M+N records in/out' lines don't pollute `make check' output.
753 * tests/dd/skip-seek (sk-seek4): New test, to exercise the bug
754 fixed on 2005-10-31. This test uses the new, IN_PIPE specifier.
755 * tests/Coreutils.pm: Accept a new type of input specifier: IN_PIPE,
756 to indicate that the input file should be piped into the command
757 under test (via `cat FILE | $prog ...').
759 * src/remove.c (remove_entry): Emit a better diagnostic when rm
760 (without -r) fails to remove a directory on a non-Linux system.
761 This change affects only newer Solaris systems (with priv_*
762 functions like priv_allocset). Reported by Keith Thompson.
764 * tests/rm/dir-nonrecur: New file/test for the above fix.
765 * tests/rm/Makefile.am (TESTS): Add dir-nonrecur.
767 2005-11-01 Paul Eggert <eggert@cs.ucla.edu>
769 * NEWS: "tail -c 2 FILE" and "touch 0101000000" now operate as
770 POSIX 1002.1-2001 requires.
771 * src/tail.c (parse_obsolete_option): Implement this.
772 Problem reported by Vincent Lefevre.
773 * src/touch.c (main): Pass PDS_PRE_2000 to posixtime.
774 * tests/tail/Test.pm (c-2, c-2-minus, c2, c2-minus): New tests.
775 (test_vector): Add special cases for _POSIX2_VERSION, and
776 regularize the old ones a bit.
777 * tests/touch/obsolescent: Add y2000 test.
779 2005-10-31 Paul Eggert <eggert@cs.ucla.edu>
781 * src/dd.c (skip): Fix off-by-one error reported by
782 Theodoros V. Kalamatianos.
784 2005-10-30 Paul Eggert <eggert@cs.ucla.edu>
786 * tests/mkdir/p-3: Require that the test be run as non-root.
787 Problem and trivial fix reported by Theodoros V. Kalamatianos.
789 2005-10-28 Paul Eggert <eggert@cs.ucla.edu>
791 * src/ln.c (FILE_BASENAME_CONCAT): Omit unnecessary slashes in the
792 boundary between DEST and SOURCE in the result.
794 2005-10-26 Dmitry V. Levin <ldv@altlinux.org>
796 * src/md5sum.c (main) [!O_BINARY]: Changed default read mode
797 back to text, to sync with documentation and for backwards
800 2005-10-25 Jim Meyering <jim@meyering.net>
802 * tests/dircolors/simple (other-wr): Add an explicit test for
803 the dircolors bug (NULL-dereference) fixed yesterday.
805 2005-10-24 Jim Meyering <jim@meyering.net>
807 * src/tac.c (tac_file): When determining whether a file is seekable,
808 also test whether it is a tty. Using only the lseek-based test would
809 give a false positive on Solaris. Reported by Peter Fales.
811 2005-10-24 Dmitry V. Levin <ldv@altlinux.org>
813 * tests/install/d-slashdot: New test, for "install -d" failure.
814 * tests/install/Makefile.am (TESTS): Add d-slashdot.
815 * tests/mkdir/p-slashdot: New test, for "mkdir -p" failure.
816 * tests/mkdir/Makefile.am (TESTS): Add p-slashdot.
818 2005-10-24 Jim Meyering <jim@meyering.net>
820 * src/dircolors.c (ls_codes): Add missing comma.
821 Anonymous report and patch from
822 http://savannah.gnu.org/bugs/?func=detailitem&item_id=14849
824 * src/dircolors.c: Add compile-time assertion that the slack_codes
825 and ls_codes arrays have the same number of elements. This would
826 have prevented the above-fixed bug.
828 * src/expand.c (parse_tab_stops): Add a comment to make this function
829 identical to the one in unexpand.c.
830 * src/unexpand.c (parse_tab_stops): Adjust syntax to make this function
831 identical to the one in expand.c.
833 * src/expand.c (next_file): Don't assume fopen cannot return stdin.
835 2005-10-23 Jim Meyering <jim@meyering.net>
837 * src/md5sum.c (digest_check, main): Use ptr_align rather than
838 a dangerous pointer-value-to-`unsigned' cast.
839 * NEWS: mention the new sha* programs.
840 * AUTHORS: Add new sha* programs.
842 2005-08-28 David Madore <david.madore@ens.fr>
844 Add new programs: sha224sum, sha256sum, sha384sum, sha512sum.
845 * README: Add their names to the list.
846 * src/md5sum.c: Provide framework for computing sha-2 hashes.
847 * src/Makefile.am (sha224sum, sha256sum, sha384sum, sha512sum):
848 Rules for compiling sha-2 utilities
849 (noinst_HEADERS): Remove checksum.h.
850 * man/sha512sum.x, man/sha384sum.x, man/sha256sum.x, man/sha224sum.x:
852 * man/Makefile.am (dist_man_MANS): Add the corresponding .1 names.
853 (sha224sum.1, sha256sum.1, sha384sum.1, sha512sum.1): New dependencies.
854 * tests/misc/sha224sum, tests/misc/sha256sum: New files.
855 * tests/misc/sha384sum, tests/misc/sha512sum: New files.
856 * tests/misc/Makefile.am (TESTS): Add new sha224sum, sha256sum,
857 sha384sum, sha512sum test scripts here rather that each in its
860 2005-08-28 David Madore <david.madore@ens.fr>
862 * tests/sha1sum/basic-1 (million-a): Add the "million a's" test (one
863 of the FIPS test vectors).
865 2005-10-23 Jim Meyering <jim@meyering.net>
867 * configure.ac: Use 6.0-cvs as the version string.
868 * NEWS: Adjust accordingly.