1 2006-07-26 Thomas Schwinge <tschwinge@gnu.org> (tiny change)
3 * src/copy.c (set_author) [HAVE_STRUCT_STAT_ST_AUTHOR]:
4 Correctly access SRC_SB's element ST_AUTHOR.
6 2006-07-26 Jim Meyering <jim@meyering.net>
8 * tests/ls/stat-failed: Adapt to match new expected output.
11 * src/ls.c (print_color_indicator): Test for S_IFREG first, rather
12 than having the code test for all of the other types first.
13 Hoist the set-uid/gid-testing code "up" into this new block.
14 Classify any other type of file (e.g., S_TYPEISSHM, etc.) as
15 C_ORPHAN, not as C_FILE.
17 2006-07-26 Jim Meyering <jim@meyering.net>
19 Checking in a change from Paul.
21 2006-07-25 Paul Eggert <eggert@cs.ucla.edu>
23 * src/ls.c (DT_INIT): Remove. All uses removed.
24 (enum filetype): Use an ordinary enum rather than trying to keep
25 the values in sync with DT_FIFO etc. That way, we don't have
26 to make special assumptions about them. All uses changed.
27 (whiteout): New constant member of enum filetype.
28 (filetype_letter): New constant, for use with enum filetype.
29 (FILETYPE_INDICATORS): New initializer list.
30 (print_dir): Add case for DT_WHT.
31 (gobble_file): If stat fails, don't discard information from
32 readdir; instead, preserve it so it can be printed.
33 (print_long_format): Fall back on readdir result if stat info
34 is not available. Use "?" to denote each unknown mode char,
35 instead of an overall "?", since we now know some of the mode
37 (print_type_indicator): Now that MODE isn't necessarily
38 useful, guard all uses.
39 Now that two blocks in the type-checking tree can set "type = C_FILE",
40 move the suffix-handling code out and down.
42 2006-07-26 Jim Meyering <jim@meyering.net>
44 Prepare for the above change.
45 * src/ls.c [struct fileinfo] (stat_ok): Rename from stat_failed,
46 and adjust uses. From a patch by Paul Eggert.
48 2006-07-26 Jim Meyering <jim@meyering.net>
50 * src/ls.c: Correct indentation/formatting in a few places.
52 2006-07-25 Paul Eggert <eggert@cs.ucla.edu>
54 * tests/cp/fail-perm: Use "chmod 0500" rather than "chmod 500".
55 Problem report and fix from Bob Proulx.
56 * NEWS: Clarify the "chmod 0500" news, and correct the vague
57 statements about compatibility with BSD.
59 2006-07-25 Jim Meyering <jim@meyering.net>
61 * src/ls.c (gobble_file): When handling a stat-failed entry,
62 print the entry name not the absolute_name -- to be consistent
64 * tests/ls/stat-failed: Update accordingly.
66 * src/ls.c: Add parens around the new uses of ?: ternary operator.
68 * src/dircolors.hin: Mention that ORPHAN refers not just to dangling
71 Get --dired offsets right when handling stat-failed entries.
72 * src/ls.c (print_long_format): Be careful to increment P by the
73 appropriate amount, even when inode_number_width and nlink_width
75 * tests/ls/stat-failed: Test for the above.
77 * src/ls.c (gobble_file) [USE_ACL]: Don't use-uninitialized the
78 have_acl member. That would happen for a directory with both a
79 non-stat'able entry and one with an ACL.
81 * src/ls.c (gobble_file): Make it so failure to stat a
82 non-command-line file provokes an exit status of 1, not 0.
83 Say "cannot access" rather than "cannot stat".
84 * tests/ls/stat-failed: New file/test, for the above.
85 * tests/ls/Makefile.am (TESTS): Add stat-failed.
86 * tests/ls-2/tests (no-a-isdir-b): Update to reflect addition
87 of "cannot access " to diagnostic.
89 * src/ls.c: Declare stat_failed to be "bool", not "int" everywhere.
91 * src/ls.c [enum filetype] (command_line): Remove member. Not needed.
92 Replace all occurrences of "type == command_line" with the
93 equivalent, "command_line_arg".
95 * src/ls.c: Apply the stat-failed parts of Red Hat's
96 coreutils-selinux.patch. From Ulrich Drepper.
97 This makes it so files not mentioned on the command line (e.g.,
98 names read from a directory that *is* mentioned on the command
99 line) for which stat fails are still listed. With --color,
100 such files are colored just like ORPHANs (aka dangling symlinks).
102 * src/df.c (n_valid_args): Declare global to be static.
104 2006-07-24 Jim Meyering <jim@meyering.net>
106 * tests/ls/stat-dtype: Skip this test on reiserfs, since that file
107 system lacks d_type support.
109 2006-07-22 Paul Eggert <eggert@cs.ucla.edu>
111 * man/chmod.x: Update to reflect recent changes to coreutils.texi.
113 2006-07-21 Jim Meyering <jim@meyering.net>
115 * src/su.c (usage): Correct typo in --help output: s/commmand/command/
116 Reported by Tim Waugh.
117 Also remove the comment duplicating much of --help output.
119 * src/ls.c (FILE_TYPE_INDICATOR_OPTION): Reposition this new
120 name so the list remains alphabetized.
122 Fix another bug: ls --indicator-style=file-type would call
123 stat for a symlink, even though it wasn't always needed.
124 In some cases, that unnecessary stat would cause ls to fail.
125 * src/ls.c (gobble_file): Don't treat symlinks specially (in
126 requiring a stat syscall). Remove the offending exclusion.
128 * NEWS: Mention the fix.
130 * tests/ls/stat-dtype: New file/test, for the above fix.
131 Also exercises the new df feature, below.
133 * src/df.c (main): Fail and don't print the headers if no
134 file system is processed. This makes it easy to test whether
135 a specified directory is on a file system of a given type or types.
136 Otherwise, applications would have had to parse df's output.
137 E.g., is "." either ext3 or reiserfs: df -t ext3 -t reiserfs .
139 Fix a bug: ls --file-type worked like --indicator-style=slash,
140 rather than like --indicator-style=file-type.
141 * src/ls.c (FILE_TYPE_INDICATOR_OPTION): New enum member.
142 (long_options): Map "file-type" to FILE_TYPE_INDICATOR_OPTION,
144 (decode_switches): Handle new case: FILE_TYPE_INDICATOR_OPTION.
145 * NEWS: Mention the fix.
146 * tests/ls-2/tests (file-type): New test, for the above fix.
148 2006-07-19 Jim Meyering <jim@meyering.net>
150 * src/ls.c (print_dir): Give a better diagnostic for failed opendir.
152 * Makefile.am (EXTRA_DIST): Add build-aux/vc-list-files.
154 2006-07-16 Paul Eggert <eggert@cs.ucla.edu>
156 * NEWS: chmod, install, and mkdir now leave setgid and setuid bits
157 of directories alone unless you specify them explicitly.
158 install and mkdir now implement X correctly.
159 install now creates parent directories with mode 755, without
160 changing their owner or group.
161 * src/chmod.c (process_file): Adjust to mode_adjust API change.
162 * src/install.c: Include mkancesdirs.h.
163 (announce_mkdir, make_ancestor): New functions.
164 (DEFAULT_MODE): New macro, specifying initial value of 'mode'.
166 (dir_mode, dir_mode_bits): New vars.
167 (main): Set dir modes separately from nondir, so that the X
168 op of -m works correctly.
169 (main): Remove cwd_errno cruft, since make_dir_parents no longer
170 affects cwd. Adjust to new make_dir_parents API.
171 (install_file_in_file_parents): 2nd arg is now char *, not char
172 const *. Use mkancesdirs instead of rolling our own code.
173 (change_attributes): Don't worry about AFS, since that kludge
174 should not be needed any more.
175 * src/mkdir.c (struct mkdir_options): New struct.
176 (announce_mkdir, make_ancestor): New functions.
177 (main): Use them. Adjust to mode_adjust API change. Stick with
178 umask 0. Use make_dir_parents for all the work.
179 * src/mkfifo.c (main): Adjust to new mode_adjust API.
180 * src/mknod.c (main): Likewise.
181 * tests/chmod/setgid: Do the setgid test instead of bailing.
182 * tests/mkdir/p-3: Remove re_protect case that no longer applies.
183 GNU chmod now behaves like other versions of chmod.
184 * tests/mkdir/perm: Add a test for the X bug.
186 2006-07-14 Paul Eggert <eggert@cs.ucla.edu>
188 * src/base64.c (do_decode): Output to parameter OUT, not to stdout.
189 This doesn't fix any bugs, since OUT always equals stdout, but it
190 makes the code easier to understand.
192 2006-07-14 Jim Meyering <jim@meyering.net>
194 * Makefile.maint (CVS_LIST): Use new file, build-aux/vc-list-files,
195 rather than open-coding it. Now supports mercurial, too.
196 * .hgignore: New file.
197 * Makefile.am (EXTRA_DIST): Add .hgignore, which ignores nearly
198 all generated files, including ones like configure and po/*.po
199 that are currently version-controlled in cvs.
201 * Makefile.am (EXTRA_DIST): Add a few more .??* files.
202 They've been in CVS, just haven't been distributed before this.
203 Distribute ChangeLog-2005, too.
204 (MAINTAINERCLEANFILES): Add THANKS-to-translators.
206 2006-07-11 Paul Eggert <eggert@cs.ucla.edu>
208 * src/system.h: Assume <dirent.h> exists, since gnulib assumes
211 2006-07-09 Jim Meyering <jim@meyering.net>
213 * tests/mv/dir2dir: Adjust so failing with ENOTEMPTY is ok, too.
214 That happens with Linux/tmpfs.
215 * tests/mv/Makefile.am (TESTS): Add dir2dir.
217 2006-07-09 Paul Eggert <eggert@cs.ucla.edu>
219 Adjust to recent updates from gnulib.
220 * src/dd.c (apply_translations): Use toupper rather than
221 islower followed by toupper; it's simpler and typically
222 faster now that we assume at least C89 semantics. Similarly
224 * src/sort.c (inittables): Likewise.
225 * src/expand.c (expand): Don't assume that isprint etc. return
226 booleans (needed for pre-C99 hosts).
227 * src/fmt.c (check_punctuation): Likewise.
228 * src/ptx.c (initialize_regex, fix_output_parameters): Likewise.
229 * src/tr.c (is_char_class_member): Likewise.
230 * src/unexpand.c (unexpand): Likewise.
231 * src/join.c (is_blank): Remove; no longer needed. All uses
232 replaced by isblank (to_uchar (...)).
233 * src/pinky.c (create_fullname): Don't assume char is unsigned.
234 * src/printf.c (print_esc): Likewise.
235 * src/ptx.c (SKIP_NON_WHITE, SKIP_WHITE, SKIP_WHITE_BACKWARDS):
236 (copy_unescaped_string): Likewise.
237 * src/stat.c (print_it): Likewise.
238 * src/system.h (_D_EXACT_NAMELEN): Renamed from NLENGTH, for
239 convenience on GNU systems. All uses changed. Don't bother
240 looking for any dirent.h substitute other than ndir.h.
241 (D_INO): Remove unnecessary parentheses.
242 (IN_CTYPE_DOMAIN, ISGRAPH, ISPRINT, ISALNUM, ISALPHA):
243 (ISCNTRL, ISLOWER, ISPUNCT, ISSPACE, ISUPPER, ISXDIGIT):
244 (ISDIGIT_LOCALE, TOLOWER, TOUPPER): Remove. All uses changed
245 to ctype.h equivalents.
246 (isblank): Renamed from ISBLANK. Check for HAVE_DECL_ISBLANK too.
249 2006-07-08 Jim Meyering <jim@meyering.net>
251 * tests/mv/dir2dir: New file, test for 2006-07-05 fix in copy.c.
253 * Makefile.maint (sc_the_the): New rule.
255 * src/dd.c (skip): Remove one of two adjacent "the"s in a comment.
256 * tests/Coreutils.pm (run_tests): Remove one of two adjacent "then"s
259 2006-07-07 Jim Meyering <jim@meyering.net>
261 * NEWS: Mention that mv can now remove an empty destination directory,
262 and give an example. Prompted by a report from Florent Bayle.
264 2006-07-05 Jim Meyering <jim@meyering.net>
266 * src/ls.c (usage): Correct the description of -G: it is useful
267 only in a long listing. Reported by Martin Pool in
268 <https://launchpad.net/distros/ubuntu/+source/coreutils/+bug/51653>.
270 * man/chmod.x: Correct the description of the sticky bit. Reported
271 by Chris Moore via Ian Jackson in <http://bugs.debian.org/376745>.
273 * src/copy.c (copy_internal): Don't work around old NFS clients like
274 SunOS-4.1.4 and Irix 5.3 that set errno to values like EIO and
275 ENOTEMPTY upon failed rename. Otherwise, we risk misinterpreting
276 a banal failure as a recursive move-into-self failure.
277 Reported by Florent Bayle in <http://bugs.debian.org/376749>.
279 * src/c99-to-c89.diff: Regenerate, to remove fuzz.
281 2006-07-03 Jim Meyering <jim@meyering.net>
283 Plug another unusual leak.
284 (AD_mark_helper): Free malloc'd filename if hash_insert says
285 that string is already in the hash table.
287 The dev/inode of the topmost directory in each hierarchy were not
289 * src/remove.c (remove_cwd_entries): Don't call cycle_check here.
290 (AD_push): Call it from here instead.
293 * src/remove.c (AD_stack_clear): New function.
295 (AD_pop_and_chdir): Free *prev_dir just before longjmp.
297 * tests/Makefile.am, tests/*/Makefile.am: (TESTS_ENVIRONMENT):
298 Add $VG_PATH_PREFIX as a prefix to $PATH
300 * tests/envvar-check (vars): Add CDPATH and POSIXLY_CORRECT.
301 * tests/Makefile.am (evar-check): Remove rule.
302 (EXTRA_DIST): Remove .env-warn.
303 * tests/.env-warn: Remove file. No longer used.
304 Suggestion from Eric Blake.
306 2006-07-02 Paul Eggert <eggert@cs.ucla.edu>
308 * src/system.h: Include <stdint.h> unconditionally, since we
309 now assume the stdint module.
311 2006-07-01 Paul Eggert <eggert@cs.ucla.edu>
313 * NEWS: With no operand, 'tail -f' now silently ignores the '-f'
314 only if standard input is a FIFO or pipe and POSIXLY_CORRECT is set.
315 * src/tail.c (main): Implement this.
316 * tests/tail/Test.pm (f-pipe-1): Renamed from f-1.
317 (test_vector): Set POSIXLY_CORRECT for the f-pipe-* tests.
319 2006-07-01 Jim Meyering <jim@meyering.net>
321 * src/ln.c (do_link): Use new, shorter URL, for ag-review link.
323 * .x-sc_require_config_h: Add ^lib/xstrtold\.c$, so make distcheck
326 2006-06-30 Paul Eggert <eggert@cs.ucla.edu>
328 * NEWS: seq now uses long double internally rather than double.
329 It now defaults to a minimal fixed point format if possible.
330 It lets you use %a, %A, %E, %F, %G.
331 * src/Makefile.am (seq_LDADD): Remove $(SEQ_LIBM); add $(POW_LIB).
332 * src/seq.c: Don't include <math.h> or <xstrtol.h>; no longer needed.
333 (isfinite) [!defined isfinite]: New macro.
334 (separator, terminator): Now points to const.
335 (first, step, last): Remove.
336 (usage): Update to match new behavior.
337 (struct operand, operand): New type.
338 (scan_arg): Renamed from scan_double_arg, since we no longer use double.
340 Compute and return a value of type operand, not double.
341 (long_double_format): Renamed from valid_format, and now returns a
342 new format with an "L" added if needed, if the original format was
343 valid. Allow %a, %A, %E, %F, and %G formats.
344 (print_numbers): Take numeric values as args rather than from globals.
345 Print long double, not double.
346 (get_width_format): Remove.
347 (get_default_format): New function.
348 (main): Implement new way of calculating default format.
349 Don't worry about locale's representation of the decimal point, since
350 the arguments are always processed in the C locale.
351 * tests/seq/basic (neg-2): Adjust to new default format.
352 (eq-wid-1, eq-wid-2): Resurrect these tests, since the new
353 implementation should do the right thing.
355 2006-06-30 Jim Meyering <jim@meyering.net>
357 * tests/stty/basic-1: Work around an intermittent test failure
358 on HP-UX 11.11. Report and analysis from Bob Proulx.
359 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/7475
361 2006-06-28 Paul Eggert <eggert@cs.ucla.edu>
363 * NEWS: Support obsolete usages like "sort +1 -2" even when
364 conforming to POSIX 1003.1-2001, since this is a pure extension to
365 POSIX. Problem reported by Christian in:
366 http://lists.gnu.org/archive/html/bug-coreutils/2006-06/msg00220.html
367 * src/sort.c (main): Implement this.
369 * src/system.h (CLOSEDIR): Remove. All uses changed to closedir.
370 Autoconf 2.60 says this stuff was obsolete.
372 2006-06-28 Jim Meyering <jim@meyering.net>
374 * src/c99-to-c89.diff: Regenerate, to remove fuzz.
376 2006-06-28 Bob Proulx <bob@proulx.com> (tiny change)
378 * tests/mv/i-link-no: Work around HP-UX /bin/sh tracing problem
379 (set -x when VERBOSE=yes) when stderr is redirected before stdout
380 causing shell tracing of the stdout redirection to be written to
381 the stderr file. Avoid problem and test failure on HP-UX by
382 redirecting stderr last.
383 * tests/dd/unblock-sync: Order shell file redirections for
384 stderr and stdout in the common style.
387 2006-06-27 Jim Meyering <jim@meyering.net>
389 * tests/misc/cat-proc: Try to avoid any spurious numeric
390 differences in frequently-changing /proc/cpuinfo.
391 Reported by Nelson Beebe.
393 2006-06-26 Jim Meyering <jim@meyering.net>
395 Attempt rmdir (actually, unlinkat-with-AT_REMOVEDIR) upon any
396 fd_to_subdirp failure, not just when errno == EACCES.
397 * src/remove.c (remove_dir): Use unlinkat-with-AT_REMOVEDIR, not
398 rmdir, here, even though rmdir may happen to be adequate.
400 * NEWS: rm no longer fails to remove an empty, unreadable directory
401 * src/remove.c (remove_cwd_entries): If we can't open a directory,
402 and the failure is not being ignored, try to remove the directory
403 with rmdir (aka unlinkat-with-AT_REMOVEDIR), in case it's empty.
404 Problem report and test case from Paul Eggert in
405 <http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/7425>.
407 * tests/rm/empty-inacc: New test, for the above.
409 Avoid a segfault for wc --files0=- < /dev/null.
410 * src/wc.c (compute_number_width): Return right away if nfiles == 0.
412 2006-06-25 Jim Meyering <jim@meyering.net>
414 * NEWS: wc accepts a new option --files0-from=FILE, where FILE
415 contains a list of NUL-separated file names.
417 * src/wc.c: Include "readtokens.h".
418 (usage): Describe the new option, and adjust the `Usage':
419 with this option, no FILE may be specified on the command line.
420 (main): Handle the new option.
421 * tests/misc/wc-files0: New tests, for the above.
422 * tests/misc/wc-files0-from: Likewise.
423 * tests/misc/Makefile.am (TESTS): Add wc-files0.
425 2006-06-24 Jim Meyering <jim@meyering.net>
427 * src/md5sum.c (DIGEST_BUFFER): Remove now-unused definitions.
429 2006-06-22 Jim Meyering <jim@meyering.net>
431 * src/tee.c (tee_files): Rename from tee, to avoid conflict with
432 the function in glibc's <fcntl.h>. Reported by Andreas Schwab.
434 2006-06-19 Jim Meyering <jim@meyering.net>
436 * Makefile.cfg (local-checks-to-skip): Add changelog-check,
437 so this check is not run as part of "make distcheck".
439 2006-06-18 Bob Proulx <bob@proulx.com> (tiny change)
441 * tests/misc/pwd-long: Fix typo (s/neq/ne/) in previous change.
443 2006-06-18 Jim Meyering <jim@meyering.net>
445 * tests/misc/pwd-long: Make error output a little clearer.
447 2006-06-17 Jim Meyering <jim@meyering.net>
449 * tests/rm/inaccessible: Skip this test on systems without openat
450 support. Reported by Bob Proulx.
452 2006-06-15 Bob Proulx <bob@proulx.com> (tiny change)
454 * tests/misc/mknod: Improve permission checks to handle
455 running mkdir test in set-gid directories.
457 2006-06-14 Jim Meyering <jim@meyering.net>
459 * tests/du/basic: Revamp not to hard-code file system block sizes.
461 2006-06-12 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
463 * tests/du/Makefile.am (TESTS_ENVIRONMENT): Pass $(PERL), for
466 2006-06-11 Jim Meyering <jim@meyering.net>
468 * .gitignore: New file.
469 * Makefile.am (EXTRA_DIST): Add .gitignore.
471 Setting TIME_STYLE=long-iso in the environment would make the
472 cp/same-file test fail.
473 * tests/envvar-check (vars): Add TIME_STYLE to the list.
474 * tests/cp/same-file: Revert last change.
475 Source the envvar-check script, to ensure that TIME_STYLE
476 settings don't affect these tests.
478 2006-06-11 Paul Eggert <eggert@cs.ucla.edu>
480 * tests/cp/same-file: Execute 'ls' in the C locale, so that it
481 uses POSIX time stamp formats. Problem reported by John Nixon in
482 <http://lists.gnu.org/archive/html/bug-coreutils/2006-06/msg00062.html>.
484 2006-06-10 Jim Meyering <jim@meyering.net>
486 * NEWS: Mention the AIX-strndup-bug vs. dircolors workaround.
488 Require a "Version N.M" line at the top of the ChangeLog
489 file only when making the actual release, not when running
491 * Makefile.maint (maintainer-distcheck): Don't depend on
493 (alpha beta major): Depend on it here, instead.
495 2006-06-08 Jim Meyering <jim@meyering.net>
497 Ensure that cat works with any of the options, -A -v -e -E -T,
498 when applied to files in /proc and /sys, even when the FIONREAD
499 ioctl produces nonsensical results. Before this change, cat would
500 produce no output (or truncated output), for some linux kernels.
502 * src/cat.c (write_pending): New function, factored out of cat.
503 (cat): Also interpret a negative ioctl/FIONREAD count as indicating
504 that there are bytes to read. Some versions of linux-2.6.16 do that.
505 Write any pending output before returning.
506 Reported by Dan Jacobson in <http://bugs.debian.org/370583>.
507 * NEWS: Mention this bug fix.
508 * tests/misc/cat-proc: New file. Test for the above.
509 * tests/misc/Makefile.am (TESTS): Add cat-proc.
511 2006-06-07 Paul Eggert <eggert@cs.ucla.edu>
513 * src/expr.c (eval4): Detect overflow properly when multiplying
516 2006-06-06 Paul Eggert <eggert@cs.ucla.edu>
518 * NEWS: The 'expr' command now detects and reports integer overflow.
519 (It would be better to use extended precision instead, but that
521 * src/expr.c (integer_overflow): New function.
522 (eval4, eval3): Check for integer overflow.
524 2006-06-05 Paul Eggert <eggert@cs.ucla.edu>
526 Fix problems when building with Solaris/SVR4/etc. make, which uses a
527 different and somewhat bogus implementation of VPATH. In the
528 directory tests/misc, rename tests whose names might appear in the
529 Automake-generated rules. For example, we can't use a test named
530 'test', since Automake generates a rule that contains the text
531 "if test -f ./$$tst; ...", and this might expand to something like
532 "if ../../../coreutils-6.0/tests/misc/test -f ./$$test; ...",
533 which executes the 'test' script rather than the 'test' command.
534 * tests/misc/false-status: Renamed from tests/misc/false.
535 * tests/misc/pwd-long: Renamed from tests/misc/pwd.
536 * tests/misc/sort-merge: Renamed from tests/misc/sort.
537 ($prog): Set to 'sort' rather than to $PROG.
538 * tests/misc/test-diag: Renamed from tests/misc/test.
539 * tests/misc/Makefile.am (PROG): Take the basename of $$tst,
540 in case Solaris make has prepended the directory.
541 (TESTS): Adjust to above renamings.
542 * tests/misc/expand: Don't assign to PROG; no longer needed
543 now that Makefile.am sets PROG to the basename.
544 * tests/misc/fold: Likewise.
546 2006-06-03 Jim Meyering <jim@meyering.net>
548 Make `cp --link --no-dereference' work also on systems where the
549 link system call cannot create a hard link to a symbolic link.
550 * src/copy.c (copy_internal) [LINK_FOLLOWS_SYMLINKS]: Don't use
551 the link syscall on a symlink when it would do the wrong thing.
552 Based on the patch by Aurelien Jarno: <http://bugs.debian.org/329451>
553 * tests/cp/link-no-deref: New file/test for the above.
554 * tests/cp/Makefile.am (TESTS): Add link-no-deref.
555 * NEWS: Mention the change (doesn't affect Linux).
557 2006-06-01 Paul Eggert <eggert@cs.ucla.edu>
559 Fix some porting problems in the test cases reported by
560 Ralf Wildenhues for HP-UX 11.23 in:
561 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00238.html
562 * tests/help-version: Don't assume that \< \> works in sed.
563 * tests/misc/close-stdout: Don't assume that >&- works.
564 Add a /dev/full test.
565 * tests/touch/no-create-missing: Don't assume that >&- works.
567 2006-05-30 Jim Meyering <jim@meyering.net>
569 * src/ls.c (usage): Add `v' to the list of sorting-related options.
572 2006-05-28 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
574 * tests/cp/fail-perm: source lang-default.
575 * tests/rm/inaccessible: Likewise.
577 2006-05-28 Jim Meyering <jim@meyering.net>
579 * tests/rm/inaccessible: AIX 4.3.3 gives a different diagnostic.
580 Recognize it, too. Reported by Ralf Wildenhues, in
581 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
583 2006-05-27 Jim Meyering <jim@meyering.net>
585 * src/chgrp.c: Support new options: --preserve-root and
586 --no-preserve-root. Somehow this program was skipped when those
587 options were added to chown, chmod, and rm. Reported by
588 vaqflabuopac@spammotel.com in <http://bugs.debian.org/365656>.
589 * NEWS: Mention this.
591 2006-05-25 Paul Eggert <eggert@cs.ucla.edu>
593 * NEWS: Remove mention of --seed. We'll replace it with something
594 better, and don't want to indicate that it is supported.
595 * src/sort.c (usage): Likewise.
597 2006-05-20 Jim Meyering <jim@meyering.net>
599 * src/chmod.c (main): Use FTS_PHYSICAL here, too.
601 * src/du.c (main): Rename local, s/symlink_deref_bit/symlink_deref_bits/
602 and arrange for -D to set fts' FTS_PHYSICAL bit as well as
603 FTS_COMFOLLOW. Spotted by Justin Pryzby.
605 * gnupload: Merge changes from automake, retaining the ""--to...
606 kludge to placate overzealous `make distcheck' check.
608 2006-05-19 Jim Meyering <jim@meyering.net>
610 * src/du.c (main): Don't let -D, -L, or -P turn off the internal
611 FTS_TIGHT_CYCLE_CHECK directory traversal option.
612 Reported by Justin Pryzby in http://bugs.debian.org/367691
614 2006-05-15 Jim Meyering <jim@meyering.net>
616 * src/cp.c (usage): Correct description of -a: s/-dpR/-dpPR/.
619 2006-05-13 Jim Meyering <jim@meyering.net>
621 * tests/mv/no-target-dir: Test two more cases.
623 2006-05-11 Jim Meyering <jim@meyering.net>
625 mv -T DIR EMPTY_DIR no longer fails unconditionally
626 * src/copy.c (copy_internal): Don't manually prohibit a move where
627 the destination is an existing directory. Sometimes doing that is
628 valid. Let the rename system call enforce the rules. That is
629 allowed only when the source is a directory and the destination
630 directory (to be replaced) is empty. Reported by Eric Blake.
631 * tests/mv/no-target-dir: New file/test for this.
632 * tests/mv/Makefile.am (TESTS): Add no-target-dir.
633 * NEWS: Mention this.
635 * tests/mv/atomic: New file/test for yesterday's fix.
636 * tests/mv/Makefile.am (TESTS): Add atomic.
638 * tests/du/long-sloop: Avoid harmless `ambiguous redirect' diagnostic.
640 2006-05-10 Jim Meyering <jim@meyering.net>
642 * src/copy.c (copy_internal): Don't explicitly unlink the destination
643 when moving a symlink into the place of an existing non-directory.
644 Reported by Joshua Hudson.
645 * NEWS: mention this.
647 2006-05-07 Jim Meyering <jim@meyering.net>
649 * Makefile.maint (patch-check): Fail if patch generates any output,
650 even merely for changed offsets.
652 * src/c99-to-c89.diff: Adjust to reflect new offsets.
654 * NEWS: Mention changes affecting df, pwd, shred.
656 2006-05-06 Jim Meyering <jim@meyering.net>
658 * tests/ls/stat-vs-dirent: New test, to detect the bogus file
659 system condition where dirent.d_ino != stat.st_ino.
660 * tests/ls/Makefile.am (TESTS): Add stat-vs-dirent.
662 2006-05-06 Eric Blake <ebb9@byu.net>
664 * tests/ls/inode: Expand to test inode from readdir case.
665 * tests/ls/follow-slink: Expand to test broken links encountered
666 implicitly, favoring Solaris 9 and OpenBSD 3.4 behavior.
668 2006-05-06 Eric Blake <ebb9@byu.net>
670 * tests/mv/leak-fd: Work even on case-insensitive file system.
672 2006-05-04 Jim Meyering <jim@meyering.net>
674 * NEWS: Mention the 2006-03-19 pwd-related change that makes
675 lib/getcwd.c work around inconsistent file system dirent.d_ino data.
677 2006-05-03 Jim Meyering <jim@meyering.net>
679 * src/ls.c (DEFINE_SORT_FUNCTIONS, LIST_SORTFUNCTION_VARIANTS):
680 Use better macro parameter names: s/basename/key_name/,
681 s/basefunc/key_cmp_func. Fix typo in comment.
683 2006-04-29 Eric Blake <ebb9@byu.net>
685 * src/ls.c (main): On systems with d_type, directories_first only
686 implies format_needs_type, not format_needs_stat.
688 2006-05-03 Jim Meyering <jim@meyering.net>
690 * src/ls.c (xstrcoll_df_version, rev_xstrcoll_df_version): Add space
691 after comma in arg list, from Eric Blake.
693 2006-04-25 Paul Eggert <eggert@cs.ucla.edu>
695 * tests/misc/date (relative-3): New test, derived from a bug
696 report by John Thomas McDole.
698 2006-04-23 Francesco Montorsi <fr_m@hotmail.com>
700 New option for ls: --group-directories-first.
701 It makes ls list directories before files.
702 * NEWS [New features]: Mention it.
703 * src/ls.c (sort_type): Rearrange to use as an array index when
704 choosing sort function; added new sort_numtypes member for
706 (time_type): Add new time_numtypes member for compile-time check.
707 (directories_first): New global variable.
708 (GROUP_DIRECTORIES_FIRST_OPTION): New enum.
709 (long_options): Add --directories-first.
710 (main): Support new option.
711 (is_directory): New function.
712 (extract_dirs_from_files): Use it.
713 (DIRFIRST_CHECK, DEFINE_SORT_FUNCTIONS)
714 (LIST_SORTFUNCTION_VARIANTS): New macros.
715 (sort_functions): New global variable.
716 (sort_files): Use it.
717 (usage): Document new option.
719 2006-04-18 Paul Eggert <eggert@cs.ucla.edu>
721 * src/shred.c (fillrand): The assertion was way too weak, due to
722 what must be a typo. Strengthen it to its intended value.
723 (dopass): Don't use alloca; it's not worth the aggravation here,
724 since it's used only to get a page-aligned buffer, and page
725 alignment doesn't buy us much here. I'm suspicious that alloca
726 causes problems on some hosts, due to a recent bug report by Adam
727 Waltman: http://bugs.gentoo.org/130246.
729 2006-04-18 Jim Meyering <jim@meyering.net>
731 * tests/misc/tty-eof: Add new programs, base64, sha224sum, sha256sum,
732 sha384sum, sha512sum.
734 2006-04-17 Paul Eggert <eggert@cs.ucla.edu>
736 * src/chmod.c (describe_change): Adjust to filemode changes.
737 * src/ls.c (HAVE_ST_DM_MODE): Remove; moved to ../lib/filemode.c.
738 (print_long_format): Use (new) filemodestring rather than
739 (old) mode_string, so that we get more file types right, at least
740 in theory. Adjust to filemode changes.
741 * src/stat.c (human_access): Likewise.
743 2006-04-18 Jim Meyering <jim@meyering.net>
745 * src/ptx.c (main) [DEFAULT_IGNORE_FILE]: Remove code to use a default
746 ignore file. This has never been enabled. Reported by Eric Blake.
748 2006-04-12 Paul Eggert <eggert@cs.ucla.edu>
750 * src/ln.c (linkfunc): Remove. This method ran into a compiler/linker
751 bug in Interix. Just call symlink or link directly. All uses changed.
752 * src/setuidgid.c (main) [! HAVE_SETGROUPS]: Don't call setgroups.
753 * src/stat.c (USE_STATVFS): New macro.
754 Include <sys/statvfs.h> and use statvfs only if USE_STATVFS.
755 (NAMEMAX_FORMAT): define a bit more clearly, now that the
756 statvfs-using code is a bit more regular.
757 * src/system.h (sync) [!HAVE_SYNC]: New macro.
759 2006-04-11 Paul Eggert <eggert@cs.ucla.edu>
761 * NEWS: csplit, nl, expr now conform to POSIX better, and are
762 more-compatible with traditional Unix, with respect to regular
764 * src/csplit.c (extract_regexp): Set re_syntax_options to a
765 value that is compatible with what POSIX requires.
766 * src/nl.c (build_type_arg): Likewise.
767 * src/expr.c (docolon): Likewise. Also, don't let anchors match
768 newline; this fixes an incompatibility with tradition and with POSIX.
769 Don't warn about leading ^. POSIX says it is unspecified whether
770 ^ is a special character, which means that implementations can
771 either treat it as special or not, but either way a warning is not
772 allowed (unless the regexp is otherwise invalid). Instead, anchor
773 the expression but treat ^ as an anchor; this is the traditional
774 behavior (e.g., Solaris 10).
775 (eval4, eval3, eval2): Treat non-numeric args, division by zero,
776 and the like as invalid expressions (exit status 2), not as
777 failure of 'expr' (exit status 3). This is more consistent with
779 * tests/expr/basic (fail-a): Adjust exit status to match new expr
780 behavior, for status 2 versus 3.
782 (bre1, bre2, bre3, bre4, bre5, bre6, bre7, bre8, bre9, bre10):
783 (bre11, bre12, bre13, bre14, bre15, bre16, bre17, bre18, bre19, bre20):
784 (bre21, bre22, bre23, bre24, bre25, bre26, bre27, bre28, bre29, bre30):
785 (bre31, bre32, bre33, bre34, bre35, bre36, bre37, bre38, bre39, bre40):
786 (bre41, bre42, bre43, bre44, bre45, bre46, bre47, bre48, bre49, bre50):
787 (bre51, bre52, bre53, bre54, bre55, bre56, bre57, bre58, bre59, bre60):
788 (bre61, bre62): New tests.
789 * tests/misc/csplit: Use \{...\} in test RE, to test that we're
793 * tests/du/long-from-unreachable: Solaris 8 sh doesn't understand
794 "if !". Do not assume that 'sed' can handle long, newline-free input.
795 * tests/du/long-sloop: Likewise. Evaluate expr once, not $n times.
797 2006-04-10 Paul Eggert <eggert@cs.ucla.edu>
799 Adjust to new regex.h API (with new fastmap type), and clean
800 up the regex storage allocation a bit.
802 * src/csplit.c (struct control): Put re_compiled member at the
803 end, since it's large. Change regexpr member from char * to bool;
804 all uses changed. Add new member fastmap.
805 (extract_regexp): regexp arg is now char const *, not char *.
806 Don't bother duplicating the regular expression; it's not needed.
807 Set fastmap from new fastmap member. Don't bother allocating
808 a buffer, as the regexp code does a better job than we do.
809 * src/expr.c (docolon): Allocate and use a fastmap.
810 Don't bother allocating a buffer.
811 * src/nl.c (body_fastmap, header_fastmap, footer_fastmap):
813 (build_type_arg): New fastmap arg. All uses changed.
814 Don't bother allocating a buffer, but set a fastmap.
815 * src/ptx.c (context_regex_string, word_regex_string): Remove.
816 (context_regex, word_regex): New vars, replacing the above.
818 (struct regex_data): New type.
819 (compile_regex): Renamed from alloc_and_compile_regex, since
820 we no longer allocate storage. Arg is now a struct regex_data *,
821 not a const char *. All uses changed. Don't allocate the fastmap;
822 instead, take it from the caller. Don't convert size_t to int,
823 to avoid arithmetic overflow problems. Don't bother freeing
824 storage afterwards; it's not worth the aggravation.
825 * src/tac.c (compiled_separator_fastmap): New ver.
826 (main): Use it. Don't bother allocating a buffer.
828 2006-03-30 Jim Meyering <jim@meyering.net>
830 * src/dd.c (iwrite): Remove assignment without effect.
831 Reported by Felix Rauch Valenti.
833 2006-03-22 Eric Blake <ebb9@byu.net>
835 * src/ptx.c (usage): Remove mention of --copyright/-C.
836 (main): Alias --copyright to --version plus a deprecation warning.
837 * NEWS: Mention this.
839 2006-03-27 Jim Meyering <jim@meyering.net>
841 * src/Makefile.am (uptime_LDADD): Add $(POW_LIB), for uptime's
842 use of strtod. Tiny patch from Nickolai Zeldovich.
844 2006-03-11 Eric Blake <ebb9@byu.net>
846 * tests/misc/dirname: New file.
847 * tests/basename/Makefile.am: Delete.
848 * tests/basename/basic: Move to...
849 * tests/misc/basename: ... this new file. Add some tests,
850 including fixed behavior for //.
851 * tests/misc/Makefile.am (TESTS): Sort. Add basename, dirname.
852 * tests/Makefile.am (SUBDIRS): Remove basename.
853 * configure.ac (AC_CONFIG_FILES): Remove tests/basename.
855 Improvements to dirname/basename handling on platforms like
856 cygwin with distinct // and with drive letters.
857 * NEWS: Document new behavior.
858 * src/basename.c (main): Don't strip suffix from file system
860 * src/cp.c (target_directory_operand): Use new last_component.
861 (ASSIGN_BASENAME_STRDUPA): Likewise. Reduce time spent
862 traversing the string.
863 * src/dircolors.c (guess_shell_syntax): Use new last_component.
864 * src/install.c (target_directory_operand, install_file_in_dir):
866 * src/ln.c (target_directory_operand, main): Likewise.
867 * src/ls.c (basename_is_dot_or_dotdot): Likewise.
868 * src/mv.c (target_directory_operand, movefile): Likewise.
869 * src/remove.c (rm_1): Likewise.
870 * src/shred.c (wipename): Likewise.
871 * src/split.c (next_file_name): Likewise.
872 * src/su.c (log_su, run_shell): Likewise.
874 2006-03-23 Paul Eggert <eggert@cs.ucla.edu>
876 * NEWS: nohup diagnostics are now more precise, and nohup now
877 redirects stderr to nohup.out if stdout is closed and stderr is a tty.
878 * src/nohup.c (main): Implement this.
879 * tests/misc/nohup: Test the new behavior.
881 2006-03-12 Jim Meyering <jim@meyering.net>
883 * src/copy.c (set_author): Rename function, from preserve_author.
885 * src/remove.c (AD_pop_and_chdir): Use new macro,
886 CYCLE_CHECK_REFLECT_CHDIR_UP, rather than open-coding it.
888 * src/system.h (SAME_INODE): Remove definition.
889 Include "same-inode.h", instead.
891 2006-03-11 Eric Blake <ebb9@byu.net>
893 * src/pwd.c (robust_getcwd): Prepend only one slash, not two.
895 2006-03-10 Jim Meyering <jim@meyering.net>
897 Fix a bug whereby a user with write access to a directory being removed
898 could cause the removal of that directory to fail with an erroneous
899 diagnostic about a directory cycle. Reported by Vineet Chadha.
901 * NEWS: Mention this.
902 * src/remove.c (AD_pop_and_chdir): If the directory we're about to
903 leave (and try to rmdir) is the one whose dev_ino is being used to
904 detect a cycle, reset cycle_check_state.dev_ino to that of the parent.
906 2006-03-08 Paul Eggert <eggert@cs.ucla.edu>
908 * NEWS: Document dd's new 'directory' and 'nolinks' flags.
909 * src/dd.c (set_fd_flags): Handle file-creation flags on file
910 descriptors, rather than ignoring them.
911 * tests/dd/misc: Add test cases for append, nofollow, directory,
912 and nolinks flags. Simplify redirection to /dev/null in some cases.
914 * tests/dd/misc: iflags->iflag. This fixes a typo that meant the
915 noatime test never tested anything.
917 2006-03-05 Paul Eggert <eggert@cs.ucla.edu>
919 * src/dd.c (flags, usage): New flags directory, nolinks.
920 * src/system.h (O_NOLINKS): Define to 0 if not already defined.
922 * src/ls.c (usage): Mention that -f disables --color.
923 Problem reported by Niels Möller.
925 2006-03-03 Justin Pryzby <pryzbyj@justinpryzby.com>
927 * man/*.x: Add references to syscalls from utilities of the same name.
929 2006-03-05 Jim Meyering <jim@meyering.net>
931 * tests/help-version: Set SHELL, if not already set, in order to
932 avoid failure when `make check' is run through debuild; dircolors
933 would fail due to lack of $SHELL. Reported by Sven Joachim.
935 Make `base64 --wrap=N' work for N=0, and for N larger than SIZE_MAX.
936 * src/base64.c (wrap_write, do_encode, main): Change type of
937 parameters and locals, wrap_column, form size_t to uintmax_t.
938 (main): Adjust to use xstrtoumax, accordingly.
940 2006-03-03 Jim Meyering <jim@meyering.net>
942 Don't fail when run from an environment with SHELL not a Bourne
943 shell, e.g. `env SHELL=/bin/csh make check' would fail this test.
944 * tests/dircolors/simple: Invoke each non-failing test with -b.
945 Reported by Michael Stone.
947 2006-02-27 Jim Meyering <jim@meyering.net>
949 * tests/misc/base64: Derive --decode-using tests from the
952 * tests/misc/base64: Factor out a long constant string.
953 Split lines to stay within 80 columns.
955 * tests/misc/Makefile.am (TESTS): Add base64.
956 * tests/misc/base64: Test base64. From Simon Josefsson.
958 * src/base64.c (do_decode): Use correct type for parameter,
959 ignore_garbage: s/size_t/bool/.
961 * src/base64.c: Don't include .h files already included by system.h:
962 <string.h>, <stdlib.h>, <stdbool.h>, <limits.h>, <errno.h>.
963 Include "system.h" before the other lib/*.h header files.
964 Include <sys/types.h> before "system.h".
965 (wrap_write): Remove declaration of unused local, initial_column.
966 (wrap_write): Correct declaration syntax: s/size_t * V/size_t *V/.
968 * README: Add base64 to the list.
970 2006-02-17 Simon Josefsson <jas@extundo.com>
973 * AUTHORS: Mention base64.
975 * man/Makefile.am: Build base64.1.
976 * man/base64.x: New file.
977 * src/Makefile.am (bin_PROGRAMS): Add base64.
978 * src/base64.c: New file.
980 2006-02-25 Eric Blake <ebb9@byu.net>
982 In ls, avoid calling stat for --inode (-i), when possible.
983 * src/pwd.c (NOT_AN_INODE_NUMBER, D_INO): Move to ...
984 * src/system.h: ... here, for use in ...
985 * src/ls.c (main): ... here. Prefer dirent.d_ino to stat when
987 (gobble_file): Add inode argument.
988 (print_dir): Pass inode if available.
989 (usage): Remove inaccuracy.
991 2006-02-23 Jim Meyering <jim@meyering.net>
993 * TODO: Update/correct some obsolete entries.
995 2006-02-20 Paul Eggert <eggert@cs.ucla.edu>
997 * doc/coreutils.texi (join invocation): Mention `sort -k 1b,1'.
998 * src/join.c (usage): Likewise.
999 Documentation problem reported by Philip Kensche.
1001 2006-02-20 Eric Blake <ebb9@byu.net>
1003 * man/rm.x: Update documentation to match previous patch.
1005 2006-02-18 Eric Blake <ebb9@byu.net>
1007 New option for rm: --interactive=once (-I).
1008 * NEWS: Document it, along with change to rm --interactive.
1009 * TODO: Remove entry for implementing rm -I
1010 * src/rm.c (INTERACTIVE_OPTION): New enum value.
1011 (interactive_type): New enum.
1012 (long_opts): Let interactive take an optional argument.
1013 (interactive_args, interactive_types): New option arguments.
1014 (usage): Document -I, --interactive=WHEN. Use program_name
1015 instead of a basename.
1016 (main): New -I option, new behavior to --interactive.
1017 * tests/rm/interactive-once: New tests.
1018 * tests/rm/interactive-always: Ditto.
1019 * tests/rm/Makefile.am (TESTS): Run them.
1021 2006-02-18 Jim Meyering <jim@meyering.net>
1023 * Makefile.maint (sc_two_space_separator_in_usage): Make the regular
1024 expression match more of the target lines, e.g., those that start with
1025 `-S,' (short option followed by a comma) or that include `=[...]'.
1026 Patch by Nicolas François.
1027 Fix the four offenders thus exposed:
1028 * src/join.c (usage): Use two spaces (not one) to separate the
1029 --first-only option string from its description, so help2man formats
1030 the derived man page properly.
1031 * src/pr.c (usage): Likewise.
1032 * src/uniq.c (usage): Likewise.
1033 * src/install.c (usage): Likewise.
1035 2006-02-15 Jim Meyering <jim@meyering.net>
1037 * Makefile.maint (alpha beta major): For `make major', ensure that the
1038 version string is of the form N.N[.N]*, where N is one or more digits.
1040 2006-02-14 Jim Meyering <jim@meyering.net>
1042 * INSTALL: Update from gnulib.
1044 2006-02-13 Jim Meyering <jim@meyering.net>
1046 * GNUmakefile (all): Emit diagnostics to stderr, not stdout.
1048 2006-02-12 Jim Meyering <jim@meyering.net>
1050 * Makefile.maint (patch-check): New target.
1051 (local-checks-available): Add to the list.
1053 2006-02-11 Jim Meyering <jim@meyering.net>
1055 * src/c99-to-c89.diff: New file.
1056 * src/Makefile.am (EXTRA_DIST): Add c99-to-c89.diff.
1058 * .x-po-check: New file, with exclusions so that `make distcheck'
1060 * Makefile.am (EXTRA_DIST): Add .x-po-check.
1062 rm -r must remove an empty directory, even if it is inaccessible.
1063 * src/remove.c (close_preserve_errno): New function.
1064 (fd_to_subdirp): Don't print a diagnostic in this function.
1065 Do it from the callers instead, unless rmdir succeeds.
1066 (remove_cwd_entries, remove_dir): Adjust callers.
1067 * tests/rm/empty-inacc: New test for the above.
1068 * tests/rm/Makefile.am (TESTS): Add empty-inacc.
1069 * NEWS: Mention this bug fix.
1070 * tests/rm/rm2: Adjust two expected diagnostics, now that they're
1071 a tiny bit less precise: cannot remove `a/1': ... instead of
1072 cannot open directory `a/1': ...
1074 * Makefile.maint (syntax-check-rules): Automatically derive this
1075 list of sc_-prefixed rule names.
1077 2006-02-10 Paul Eggert <eggert@cs.ucla.edu>
1079 * Makefile.maint (CVS_LIST): Don't assume cvsu is available.
1080 (CVS_LIST_EXCEPT): New macro, to simplify exception-processing.
1081 Most uses of CVS_LIST changed to use CVS_LIST_EXCEPT.
1082 (syntax-check-rules): Bring back sc_changelong. (Hmm, why did it
1083 go away? was that an accident?)
1084 (sc_cast_of_argument_to_free, sc_cast_of_x_alloc_return_value):
1085 (sc_cast_of_alloca_return_value, sc_space_tab, sc_prohibit_atoi_atof):
1086 (sc_error_exit_success, sc_file_system, sc_no_if_have_config_h):
1087 (sc_system_h_headers, sc_sun_os_names, sc_trailing_blank):
1088 (sc_two_space_separator_in_usage, sc_unmarked_diagnostics):
1089 (sc_obsolete_symbols, sc_changelog, sc_prohibit_jm_in_m4):
1090 (sc_useless_cpp_parens, makefile-check, m4-check, po-check):
1091 (author_mark_check, makefile_path_separator_check):
1092 Output line numbers, to simplify navigation of Emacs *compilation*
1094 (sc_prohibit_atoi_atof, sc_file_system):
1095 Rework slightly so that Makefile.maint doesn't get reported as a
1096 violation of its own syntax rules.
1097 (sc_dd_max_sym_length): Use ifneq to do nothing, instead of doing
1098 it at run-time (which didn't work with Bison). Fix a makefile typo,
1099 caught by Makefile.maint itself: spaces where a tab should be.
1100 (po-check): Check lib/*.[ch] even if not in CVS; used by Bison,
1101 which copies from ../gnulib/lib/*.[ch] to lib/*.[ch].
1102 Ignore djgpp and man subdirectories, to avoid false matches with
1103 Bison and coreutils, respectively. Use sort -u to remove the
1104 resulting duplicates.
1105 * gnupload: Rework slightly to avoid bogus warning from
1106 sc_two_space_separator_in_usage.
1108 2006-02-10 Jim Meyering <jim@meyering.net>
1110 Use gzip's --rsyncable option only if it's available.
1111 * Makefile.maint (gzip_rsyncable): New variable.
1114 2006-02-08 Jim Meyering <jim@meyering.net>
1116 * Makefile.maint (local-checks-available): Define in terms of
1117 the expansion, $(syntax-check-rules), rather than the single,
1118 top-level target `syntax-check', so that it's easier to exclude
1119 individual rules (via $(local-checks-to-skip)).
1120 (tgz-md5, tgz-sha1, ...): Remove now-unused definitions.
1122 2006-02-07 Jim Meyering <jim@meyering.net>
1124 * src/system.h (!defined O_DIRECT): If O_DIRECTIO is defined (as it
1125 is on Tru64), define O_DIRECT to that. Patch From James Lemley.
1127 * tests/help-version (expected_failure_status_vdir):
1128 Redirect an expected disk-full diagnostic to /dev/null.
1130 2006-02-06 Jim Meyering <jim@meyering.net>
1132 * src/unexpand.c (usage): Use two spaces (not one) to separate the
1133 --first-only option string from its description, so help2man formats
1134 the derived man page properly.
1135 * src/rm.c (usage): Likewise for --no-preserve-root.
1136 * src/chown.c (usage): Likewise.
1137 * src/chgrp.c (usage): Likewise.
1139 Add a rule to ensure that the above doesn't happen again.
1140 * Makefile.maint (sc_two_space_separator_in_usage): New rule.
1141 (syntax-check-rules): Add it.
1142 * .x-sc_two_space_separator_in_usage: New empty file.
1143 * Makefile.am (EXTRA_DIST): Add .x-sc_two_space_separator_in_usage.
1145 2006-02-06 Jim Meyering <jim@meyering.net>
1147 * src/cp.c (usage): Use two spaces (not one) to separate each
1148 option string from its description, so help2man formats the
1149 derived man page properly.
1150 * src/mv.c (usage): Likewise.
1151 Patch from Nicolas François in http://bugs.debian.org/351601.
1153 2006-02-04 Jim Meyering <jim@meyering.net>
1155 * src/copy.c (copy_internal): cp -RL would fail when encountering
1156 the same directory more than once in the hierarchy beneath a single
1157 command-line argument. That is legitimate, e.g. when there are
1158 two or more symbolic links, each pointing to some directory that
1159 would not otherwise be copied. Reported by Christophe LYON.
1160 * tests/cp/cp-deref: New file. Test for today's fix.
1161 * tests/cp/Makefile.am (TESTS): Add cp-deref.
1162 * NEWS: Document this.
1164 2006-02-03 Jim Meyering <jim@meyering.net>
1166 * configure.ac: Require automake-1.9.6, not 1.8.3.
1168 2006-02-01 Paul Eggert <eggert@cs.ucla.edu>
1170 * src/od.c (usage): Mention that -t a ignores high order bit.
1171 Documentation problem reported by Ed Avis.
1173 2006-02-01 Jim Meyering <jim@meyering.net>
1175 * src/pwd.c (find_dir_entry): Remove unused local, `ent_sb_valid'.
1177 2006-01-30 Paul Eggert <eggert@cs.ucla.edu>
1179 * src/head.c (main): Use a better diagnostic when someone uses a
1180 trailing numeric option in an invalid way. Problem reported by
1182 * src/tail.c (parse_options): Likewise.
1184 2006-01-30 Jim Meyering <jim@meyering.net>
1186 * man/wc.x: Include `count' keyword in man page synopsis,
1187 per suggestion from http://bugs.debian.org/181585.
1189 2006-01-24 Paul Eggert <eggert@cs.ucla.edu>
1191 * src/df.c (show_dev): If the file system claims to have
1192 more available than total blocks, report the number of used
1193 blocks as being total - available (a negative number) rather
1194 than as garbage. Problem reported by Toralf Foerster.
1196 2006-01-24 Jim Meyering <jim@meyering.net>
1198 * src/tail.c (tail_forever): Don't exit-nonzero when an attempt
1199 to put a regular file in O_NONBLOCK mode fails with EPERM.
1200 That happens on Linux (up to 2.6.15) when using tail -f on a file with
1201 the append-only attribute. Reported by Dean Gaudet. For details,
1202 see http://savannah.gnu.org/bugs/?func=detailitem&item_id=15473.
1203 * NEWS: Mention this fix.
1204 * tests/tail-2/append-only: New file. Test for the above.
1205 * tests/tail-2/Makefile.am (TESTS): Add append-only.
1206 * tests/Makefile.am (check-root): Add tail-2/append-only
1208 2006-01-21 Jim Meyering <jim@meyering.net>
1210 * NEWS: Mention fts-related improvements and bug fixes.
1212 2006-01-19 Jim Meyering <jim@meyering.net>
1214 * tests/fmt/basic (pfx-1, pfx-2): New tests, to demonstrate the bug
1215 reported as http://bugs.debian.org/147577. Forwarded by Thomas Hood.
1217 2006-01-18 Jim Meyering <jim@meyering.net>
1219 * tests/du/Makefile.am (TESTS): Add long-from-unreadable.
1221 2006-01-17 Jim Meyering <jim@meyering.net>
1223 Now that fts no longer changes the current working directory, adjust
1224 its clients accordingly -- note that du.c uses fts but doesn't need
1225 any adjustment, since it doesn't operate on the actual files,
1226 but rather just uses the stat buffers provided by fts.
1228 * src/chown-core.c: Include "openat.h".
1229 Don't include "lchown.h".
1230 (restricted_chown): Accept a new parameter, CWD_FD, and use it in
1231 calling openat, lchownat, chownat, rather than open, lchown, chown.
1233 * src/chmod.c: Include "openat.h".
1234 (process_file): Use chmodat (fts->fts_cwd_fd,... in place of chmod (...
1236 * tests/du/long-from-unreadable: New test, to exercise one small
1239 2006-01-13 Jim Meyering <jim@meyering.net>
1241 * tests/Makefile.am (SUBDIRS): Add comments discouraging the
1242 addition of new directories under tests/.
1244 * tests/acl: Redirect stdin to /dev/null. Otherwise, FreeBSD 5.0's
1247 2006-01-12 Jim Meyering <jim@meyering.net>
1249 * tests/du/long-sloop: Adjust not to hard-code the expected
1250 diagnostic corresponding to ELOOP. Solaris' diagnostic differs
1251 from that of GNU libc. Reported by Paul Eggert.
1253 * tests/du/long-sloop: Create file at end of symlink chain.
1255 * tests/misc/test: New file, with a test for one of the
1256 bugs fixed by yesterday's test.c changes.
1257 * tests/misc/Makefile.am (TESTS): Add test.
1259 2006-01-11 Jim Meyering <jim@meyering.net>
1261 * tests/du/long-sloop: New file. Test for today's fts.c bug fix.
1262 That bug could make du -L, chgrp -L, or chown -L fail to diagnose
1263 a very long sequence of symbolic links (not necessarily a loop).
1264 * tests/du/Makefile.am (TESTS): Add long-sloop.
1266 2006-01-11 Paul Eggert <eggert@cs.ucla.edu>
1268 * src/test.c (test_syntax_error): Append a newline. All callers
1269 changed, except for the ones that didn't already append a newline.
1270 Bug reported by Eric Blake.
1272 2006-01-11 Jim Meyering <jim@meyering.net>
1274 * src/system.h (X2NREALLOC): Now that verify_true is no longer
1275 void, cast its result to void, to avoid gcc's warning that
1276 ``left-hand operand of comma expression has no effect''.
1277 (DECIMAL_DIGIT_ACCUMULATE, X2REALLOC): Likewise.
1279 2006-01-10 Jim Meyering <jim@meyering.net>
1281 * tests/chmod/no-x: Add a test for today's fts.c fix.
1283 2006-01-10 Jim Meyering <jim@meyering.net> (tiny change)
1285 * src/ls.c (gobble_file): Use DTTOIF only if it's defined.
1286 This is necessary for Dragonfly. Patch by Joerg Sonnenberger.
1288 2006-01-10 Paul Eggert <eggert@cs.ucla.edu>
1290 * src/system.h (X2NREALLOC, X2REALLOC, DECIMAL_DIGIT_ACCUMULATE):
1291 Use verify_true instead of verify_expr, to sync with gnulib.
1293 2006-01-08 Jim Meyering <jim@meyering.net>
1295 * src/date.c (usage): Adjust the formatting of the entries for
1296 %::z and %:::z (separate with two spaces, not one) so that help2man
1297 formats them properly. Reported by Philip Rowlands.
1299 2006-01-06 Paul Eggert <eggert@cs.ucla.edu>
1301 * configure.ac (gl_IGNORE_UNUSED_LIBRARIES): Add.
1303 2006-01-06 Jim Meyering <jim@meyering.net>
1305 * Makefile.maint (copyright-check): Use date +%Y in place of
1308 * src/remove.c (rm_1): Remove `static' attribute on local `status'.
1309 First off, the attribute should have been `volatile' (not static)
1310 to avoid longjmp-related risk of clobber. Secondly, now there is
1311 no longer any risk of a local variable being clobbered, so there's
1312 no need for any attribute at all.
1314 2006-01-05 Jim Meyering <jim@meyering.net>
1316 * src/remove.c: Give a few functions the inline attribute.
1317 (AD_pop_and_chdir): Use gotos to avoid some duplication.
1318 (AD_push): Rewrite an assertion so that the entire computation
1319 goes away when assertions are turned off.
1321 * src/tail.c (ENOSYS) [!defined ENOSYS]: Don't define here.
1322 It's already defined in "system.h".
1323 * Makefile.maint: Add a FIXME comment.
1325 2006-01-04 Jim Meyering <jim@meyering.net>
1327 * ChangeLog: Remove entries from 2005-10-22 and earlier.
1328 * ChangeLog-2005: New file, for entries up to version 5.92.
1330 2006-01-03 Jim Meyering <jim@meyering.net>
1332 * tests/du/no-x: Also allow a slightly different diagnostic -- the
1333 one you get when using openat-enabled fts.c and du (coming soon).
1334 * tests/chmod/no-x: Likewise.
1335 * tests/chgrp/no-x: Likewise.
1337 * src/system.h (O_DIRECTORY) [!defined O_DIRECTORY]: Define.
1339 2006-01-02 Paul Eggert <eggert@cs.ucla.edu>
1341 * src/chown-core.c (RC_do_ordinary_chown): New enum value.
1342 (restricted_chown): Return it, if the file cannot be accessed due
1343 to EPERM, or if no uid or gid are required, or if the file is
1344 neither a directory nor a regular file. Rewrite to avoid gotos.
1345 (change_file_owner): Handle RC_do_ordinary_chown case.
1346 Rewrite to avoid gotos.
1347 * tests/chgrp/basic: Make sure we can change the group of
1350 * src/date.c (usage): Explain %g, %G, and %V a bit better.
1352 2006-01-02 Jim Meyering <jim@meyering.net>
1354 * src/copy.c (set_owner): Correct a comment.
1356 * src/tail.c (parse_options): Change warning to say that --retry
1357 is useful `mainly' (not `only') when following by name.
1358 Reported here: http://bugs.debian.org/273781
1360 2006-01-01 Paul Eggert <eggert@cs.ucla.edu>
1362 * NEWS: Document that mkfifo and mknod -m no longer set special bits.
1363 * src/copy.c: Include lchmod.h.
1364 (copy_internal): Use lchmod rather than chmod.
1365 * src/cp.c: Include lchmod.h.
1366 (re_protect, make_dir_parents_private): Use lchmod rather than chmod.
1367 * src/mkdir.c: Include lchmod.h.
1368 (usage): Clarify -m's operation.
1369 (main): Use lchmod rather than chmod. Don't use lchmod unless the
1370 new mode contains bits outside the 777 range.
1371 * src/mkfifo.c (usage): Clarify -m's operation.
1372 (main): If -m is given, don't invoke chmod; use umask 0 instead.
1373 Report an error if -m asks for bits outside the 777 range.
1374 * src/mknod.c (usage, main): Likewise.
1376 * src/mkdir.c, src/mkfifo.c, src/mknod.c: Undo 2005-12-19 changes.
1378 2005-12-27 Jim Meyering <jim@meyering.net>
1380 * Makefile.maint (sc_obsolete_symbols): Prohibit use of O_NDELAY.
1381 (sc_prohibit_assert_without_use): New rule.
1382 (syntax-check-rules): Add it to the list.
1383 * .x-sc_prohibit_assert_without_use: New empty file.
1384 * Makefile.am (EXTRA_DIST): Add it.
1386 * Makefile.maint (CVS_LIST): Define in terms of $(srcdir).
1388 * cp.c, df.c, link.c, mknod.c, nice.c, sleep.c, unlink.c:
1389 Don't include <assert.h>; it wasn't used.
1391 2005-12-26 Paul Eggert <eggert@cs.ucla.edu>
1393 * src/chown-core.c (restricted_chown):
1394 Don't try O_WRONLY unless O_RDONLY failed wth EACCES.
1395 * src/remove.c (fd_to_subdirp): Open with O_DIRECTORY | O_NOCTTY
1396 | O_NOFOLLOW too, for consistency with other dir-openers.
1397 Use POSIX-preferred O_NONBLOCK rather than O_NDELAY.
1398 (is_empty_dir): Likewise.
1399 * src/shred.c (wipename): Likewise. Don't bother trying to open
1400 dir for writing, since POSIX prohibits it.
1402 2005-12-22 Jim Meyering <jim@meyering.net>
1404 * tests/help-version: Redirect stderr to /dev/full, to suppress
1405 write error diagnostic.
1407 2005-12-19 Jim Meyering <jim@meyering.net>
1409 * src/mkdir.c, src/mknod.c, src/mkfifo.c (main)
1410 Avoid a minor race condition when `-m MODE' is specified, by using
1411 open, fchown, and close rather than just chown. To do that reliably --
1412 even with an overly restrictive umask -- ensure that each mkdir,
1413 mknod and mkfifo call uses a mode including at least owner-read access.
1414 * src/mknod.c (main): When `-m MODE' is specified, exit nonzero if
1415 the subsequent chown (or equivalent open,fchown,close) fails.
1416 * tests/misc/mknod: New tests.
1417 * tests/misc/Makefile.am (TESTS): Add mknod.
1419 2005-12-17 Jim Meyering <jim@meyering.net>
1421 * src/remove.c (is_empty_dir): Open with O_NDELAY, so we don't hang,
1422 e.g., on a named pipe.
1423 (OPEN_NO_FOLLOW_SYMLINK): Remove definition. Use O_NOFOLLOW in
1424 place of all uses, since it is guaranteed (system.h) to be defined.
1426 2005-12-05 Andreas Gruenbacher <agruen@suse.de>
1428 Add POSIX ACL support
1429 * src/ls.c: Switch back from HAVE_ACL to USE_ACL: The acl() syscall
1430 is no requirement for ACL support; particularly, it does not exist
1431 on systems that have POSIX ACLs.
1432 * src/copy.h (cp_option_init) [umask_kill]: Remove member.
1433 * src/cp.c (umask_kill): With default acls, the umask is not to be
1434 applied. Remove umask_kill, don't change the process umask, and let
1435 the kernel apply the umask where appropriate.
1436 * src/cp.c (make_dir_parents_private): Fix logic for POSIX ACLs.
1437 * src/copy.c (get_dest_mode): Remove; it is obsolete after removing
1439 (copy_reg, copy_internal): Use copy_acl and set_acl
1440 instead of fchown/chown. Fix the logic for POSIX ACLs.
1441 (chown_succeded): Remove; we now always copy acls and
1442 preserve S_ISUID, S_ISGID, and S_ISVTX when needed, no matter if we
1443 did a chown before or not.
1444 * src/mv.c, src/install.c (cp_option_init): Don't set umask_kill member.
1445 * src/Makefile.am (dir_LDADD, ls_LDADD, vdir_LDADD, cp_LDADD,
1446 mv_LDADD, ginstall_LDADD): On systems with an ACL library, arrange
1447 to link with it via $(LIB_ACL), for the utilities that need it.
1449 2005-12-16 Paul Eggert <eggert@cs.ucla.edu>
1451 * src/remove.c (OPENAT_CWD_RESTORE__REQUIRE): Remove.
1452 (OPENAT_CWD_RESTORE__ALLOW_FAILURE): Likewise.
1453 (fd_to_subdirp): Remove openat_cwd_restore_allow_failure arg; its
1454 value is now signified by whether cwd_errno is null.
1455 (fd_to_subdirp, remove_dir, rm_1); Change cwd failure indicator from
1456 pointer-to-bool to pointer-to-errno-value. All callers changed.
1457 (rm_1): Don't bother setting a local cwd failure flag and then
1458 ORing it into the caller's. Just set the caller's.
1459 (rm): Use cwd failure errno value to print a slightly-better
1462 2005-12-15 Jim Meyering <jim@meyering.net>
1464 * src/stat.c (print_it): Properly handle a backslash at the
1465 end of a --printf format string. Reported by Paul Eggert.
1466 * tests/misc/stat-printf (end-bs): Add a test for the above.
1468 2005-12-15 Paul Eggert <eggert@cs.ucla.edu>
1470 * tests/acl: Port to pre-POSIX shells like Solaris 8 /bin/sh.
1471 Don't assume /etc/passwd contains user names; use 'id' instead.
1473 2005-12-15 Jim Meyering <jim@meyering.net>
1475 stat: revert behavior of --format=FMT (-c)
1476 stat: add new option: --printf=FMT
1477 * NEWS: Mention this.
1478 * src/stat.c (isodigit, octtobin, hextobin): Define.
1479 (PRINTF_OPTION): Define.
1480 (interpret_backslash_escapes, trailing_delim): New globals.
1481 (usage): Document them. Alphabetize on long option names.
1482 (print_esc_char): New function.
1483 (print_it): Rewrite, in order to handle backslash escapes.
1484 (main): Handle new option. Set globals for --format, too.
1486 * tests/misc/stat-printf: Test --printf and --format.
1487 * tests/misc/Makefile.am (TESTS): Add stat-printf.
1489 2005-12-14 Paul Eggert <eggert@cs.ucla.edu>
1491 * NEWS: sort now reports incompatible options.
1492 * src/sort.c (incompatible_options, check_ordering_compatibility):
1494 (main): Use them. Don't bother with a usage message for
1495 "sort -c a b", for consistency with other error diagnostics.
1496 * tests/sort/Test.pm (incompat1, incompat2, incompat3, incompat4):
1499 * src/cat.c (main): Undo previous change. close_stdout already
1500 does the check, so the previous change wasn't necessary.
1502 2005-12-13 Paul Eggert <eggert@cs.ucla.edu>
1504 * src/cat.c (main): Check for close (STDOUT_FILENO) failure.
1506 2005-12-12 Paul Eggert <eggert@cs.ucla.edu>
1508 Install a more-conservative approach for sort -R. It's the
1509 same basic idea as the existing code, except it uses the full ISAAC
1510 approach (called the "more kosher" approach in the existing comments).
1511 This makes "sort -R" quite a bit slower (about a factor of 2 on my
1512 little tests involving 10000 lines on a 2.4 GHz P4), but I think it's
1513 better to be conservative here at first, and review any performance
1514 improvements carefully.
1515 * .x-sc_require_config_h: Add src/rand-isaac.c.
1516 * src/rand-isaac.h: Remove. All uses now simply include rand-isaac.c.
1517 * src/Makefile.am (noinst_HEADERS): Remove rand-isaac.h.
1518 (shred_SOURCES, sort_SOURCES): Remove.
1519 (EXTRA_DIST): Add rand-isaac.c.
1520 * src/rand-isaac.c: Revert to what used to be in shred.c, without
1521 changing it to allow for varying numbers of words in the state.
1522 Alter so that we include rand-isaac.c directly rather than
1523 compiling it and linking to it. Don't include config.h or
1524 system.h; that's the includer's responsibility.
1525 Omit functions that are specific to shred.
1526 (ISAAC_LOG, ISAAC_WORDS, ISAAC_BYTES, struct isaac_state, ind):
1527 (isaac_step, struct irand_state):
1528 Resurrect these, with the same defns that used to be in shred.c.
1529 (ISAAC_SIZE, isaac_new, isaac_copy): Remove.
1530 (isaac_refill, isaac_seed_start, isaac_seed_data, irand_init, irand32):
1532 (struct isaac_state, isaac_refill, isaac_mix, isaac_init):
1533 (isaac_seed_start, isaac_seed_data, isaac_seed_finish, isaac_seed):
1534 (irand_init, irand32, irand_mod):
1535 Number of words is constant again.
1536 (struct irand_state, irand_init, irand32, irand_mod): Move to shred.c.
1537 * src/shred.c: Include rand-isaac.c rather than rand-isaac.h.
1538 * src/sort.c: Likewise.
1539 * src/shred.c (fillrand, dopass, main): Undo previous change.
1540 (struct irand_state, irand_init, irand32, irand_mod): Moved back here,
1542 * src/sort.c: Don't include md5.h; it wasn't needed.
1543 (struct keyfield): Rename random_hash to random, for consistency
1544 with the other member names. All uses changed.
1545 (usage): Tweak wording to mention STRING for --seed option.
1546 (short_options): Rorder for consistency with other programs.
1547 (rand_state): Now a struct, not a pointer to one. All uses changed.
1548 (HASH_WORDS, HASH_SIZE): Remove.
1549 (get_hash): Remove comments around resbuf size, since we can assume C89.
1550 Use a "more-kosher" (but slower) approach of invoking isaac_refill.
1551 (keycompare): Adjust to the new get_hash.
1553 (badfieldspec): Omit recently-introduced comment; it isn't needed.
1554 (main): Don't set need_random simply because gkey has it set; that
1555 doesn't necessarily mean we'll need random numbers.
1556 Redo seeding to match new get_hash approach.
1558 2005-12-10 Jim Meyering <jim@meyering.net>
1560 * src/Makefile.am (noinst_HEADERS): Add rand-isaac.h.
1562 Avoid shred segfault on 64-bit systems.
1563 * src/rand-isaac.c (isaac_refill): Don't try to negate a
1564 local of type uint32_t. Make the local an `int' instead.
1566 * NEWS: Mention sort's new options.
1568 * src/rand-isaac.c (isaac_mix): Declare to be static.
1569 Mark all other functions as `extern' so the tight-scope
1570 part of `make distcheck' passes once again.
1571 * src/rand-isaac.h (isaac_mix): Remove declaration.
1573 * src/sort.c (get_hash): Change position of `*' in parameter
1574 type to conform with convention.
1575 (main): Split a long line so it fits in 80 columns.
1576 (keycompare): Remove stray SPACE before TAB that was
1577 causing `make distcheck' to fail.
1579 * src/shred.c: Don't include gethrxtime.h. No longer needed.
1581 * tests/misc/sort-rand: New file: basic tests for the new options.
1582 * tests/misc/Makefile.am (TESTS): Add sort-rand.
1584 2005-12-10 Frederik Eaton <frederik@ofb.net>
1586 * src/Makefile.am (sort_LDADD): Add $(LIB_GETHRXTIME).
1587 (shred_SOURCES, sort_SOURCES): New macros, so we compile rand-isaac.c.
1588 * src/rand-isaac.c: New file, containing ISAAC code that was in shred.c.
1589 Make state size runtime-configurable.
1590 (isaac_new, isaac_copy): New functions.
1591 * src/rand-isaac.h: New file.
1592 * src/shred.c: Include rand-isaac.h. Move ISAAC code to rand-isaac.c.
1593 (fillrand, main): Adjust to the fact that the state size is now
1594 runtime-configurable.
1595 * src/sort.c (short_options, long_options, WORDS, keycompare, main):
1596 (usage): Add options --random-sort and --seed to implement a random
1598 Include md5.h and rand-isaac.h.
1599 (get_hash): New function.
1600 (rand_state): New var.
1601 (HASH_WORDS, HASH_SIZE): New macros.
1603 2005-12-09 Paul Eggert <eggert@cs.ucla.edu>
1605 * tests/dd/misc: Add test for dd iflags=noatime.
1607 2005-12-09 Jim Meyering <jim@meyering.net>
1609 * src/sort.c (usage): Mention white space vs -b and -t options.
1612 2005-12-09 Eric Blake <ebb9@byu.net>
1614 * src/test.c (main): Fix misleading comment.
1616 2005-12-07 Paul Eggert <eggert@cs.ucla.edu>
1618 * NEWS: Mention dd's new noatime flag.
1619 * src/system.h (O_NOATIME): Define to 0 if not already defined.
1620 * src/dd.c (flags, usage): Add support for noatime flag.
1622 2005-12-07 Jim Meyering <jim@meyering.net>
1624 Distribute the cvsu script, used only by `make syntax-check'.
1625 * Makefile.am (EXTRA_DIST): Add build-aux/cvsu.
1626 * Makefile.maint (CVS_LIST): Use build-aux/cvsu, now that we
1627 distribute a copy of this script.
1628 * .x-sc_unmarked_diagnostics: Add build-aux/cvsu.
1630 * tests/mv/acl: exit-77 before the trap, not after, if we fail
1631 to create a temporary directory on another partition.
1632 From Andreas Gruenbacher.
1634 2005-12-06 Tomas Pospisek <tpo@sourcepole.ch> (tiny change)
1636 * man/basename.x: Cross-reference to dirname and readlink.
1637 * man/dirname.x: Cross-reference to basename and readlink.
1639 2005-12-05 Andreas Gruenbacher
1641 * src/copy.c [!HAVE_FCHOWN]: Define fchown(...) to -1.
1642 (set_owner, preserve_author): New functions, factored out of copy_reg.
1643 (copy_reg): Use them.
1644 (copy_internal): Use them here, too.
1646 2005-12-04 Jim Meyering <jim@meyering.net>
1648 * src/sleep.c (usage): Say what happens with two or more arguments.
1649 Suggested by Justin Pryzby.
1651 * src/uptime.c (print_uptime): Move decl of `upsecs' into scope
1654 2005-12-03 Jim Meyering <jim@meyering.net>
1656 * src/rm.c (long_opts): Change the name of each undocumented, for-
1657 testing-only option to start with `-', so that it cannot render
1658 ambiguous any prefix it happens to share with some other option name.
1659 Problem reported by Eric Blake.
1660 * src/head.c (long_options): Likewise.
1661 * src/tail.c (long_options): Likewise.
1663 * tests/misc/head-elide-tail: Update uses of undocumented, for-
1664 testing-only --presume* options to start with `---'.
1665 * tests/rm/dangling-symlink: Likewise.
1666 * tests/rm/dir-no-w: Likewise.
1667 * tests/rm/isatty: Likewise.
1669 2005-11-30 Jim Meyering <jim@meyering.net>
1671 * Makefile.maint: Add a comment about cvsu.
1673 2005-11-25 Paul Eggert <eggert@cs.ucla.edu>
1675 * NEWS: df updates for "none", "proc", inaccessible file systems.
1676 * src/df.c (show_point): Ignore inaccessible file systems.
1677 (usage): -a includes dummy file systems, not size-0 file systems.
1679 * src/od.c (unsigned_long_long_int): Renamed from ulonglong_t,
1680 to avoid collision with POSIX name space. All uses changed.
1682 2005-11-24 Jim Meyering <jim@meyering.net>
1684 * tests/Makefile.am (EXTRA_DIST): Add acl to the list.
1685 * tests/acl: Add `$0: ' prefix to diagnostics.
1687 * .x-sc_require_config_h: Add lib/buffer-lcm.c to the list.
1689 2005-11-23 Paul Eggert <eggert@cs.ucla.edu>
1691 * src/copy.c: Improve performance a bit by optimizing away
1692 unnecessary system calls and going to a block size of at least
1693 8192 (on normal hosts, anyway). This improved performance 5% on my
1694 Debian stable host (2.4.27 kernel, x86, copying from root
1695 ext3 file system to itself).
1696 Include "buffer-lcm.h".
1697 (copy_reg): Omit last argument. All callers changed.
1698 Use xmalloc to allocate rather than trusting alloca
1699 (which is unwise with large block sizes).
1700 Declare locals more locally, if possible.
1701 Use uintptr_t words instead of int words, for a bit more speed
1702 when looking for null blocks on 64-bit hosts.
1703 Optimize away reads of zero bytes on regular files.
1704 In the typical case, insist on 8 KiB buffers, at least.
1705 Avoid unnecessary extra call to fstat when checking for sparse files.
1706 Avoid now-unnecessary cast to off_t, and "0L".
1707 Avoid unnecessary test of *new_dst when checking for same owner
1710 2005-11-22 Paul Eggert <eggert@cs.ucla.edu>
1712 * src/remove.c (rm): Don't assume C99 for-loop syntax.
1714 2005-11-22 Jim Meyering <jim@meyering.net>
1716 * src/remove.c (AD_push): Remove debugging cruft.
1718 * tests/rm/unread2 (rm): Change expected diagnostic,
1719 `cannot open directory' to `cannot remove', to align with
1721 * tests/rm/rm2: Ensure that rm now continues removing entries
1722 even after certain types of failure.
1724 * src/remove.c: Rewrite. Now, this module is reentrant on systems
1725 that provide openat (Solaris), and on systems like Linux+procfs
1726 where our openat emulation code is reentrant. This also fixes a
1727 few low-probability leaks and eliminates some code that could,
1728 in very unusual circumstances, cause rm() (via a callee) to exit.
1729 * NEWS: Mention this.
1731 * configure.ac: Put copyright dates all on one line so the
1732 emacs function that updates them works properly.
1734 2005-11-18 Paul Eggert <eggert@cs.ucla.edu>
1736 * configure.ac (AM_PROG_CC_C_O): Add. Needed for CVS Automake.
1737 Problem reported by Eric Blake.
1738 (AC_PROG_CC_STDC): Use this instead of AC_PROG_CC, so that
1739 we get a standard-conforming compiler. This relies on the new
1740 m4/c.m4 file. Note that it's a bit tricky, since c.m4 doesn't
1741 define AC_PROG_CC_STDC; we are relying on Autoconf 2.59 internals.
1742 m4/c.m4 can go away with Autoconf 2.60 comes out.
1744 2005-11-17 Jim Meyering <jim@meyering.net>
1746 * src/remove.c (AD_mark_helper): Make a `char *' parameter `const'.
1747 (AD_mark_current_as_unremovable): Likewise, but for a local.
1750 * tests/mv/acl: Let traps handle removing temporary directories.
1752 Expect acl-related tests to fail, until the corresponding
1753 patches are committed.
1754 * tests/mv/Makefile.am (XFAIL_TESTS): Add acl.
1755 * tests/cp/Makefile.am (XFAIL_TESTS): Likewise.
1757 ACL tests, from Andreas Gruenbacher.
1758 * tests/acl, tests/mv/acl, tests/cp/acl: New files.
1759 * tests/mv/Makefile.am (TESTS): Add acl.
1760 * tests/cp/Makefile.am (TESTS): Add acl.
1762 * src/ls.c (basename_is_dot_or_dotdot): Correct wording in comment.
1764 2005-11-16 Paul Eggert <eggert@cs.ucla.edu>
1766 * NEWS: Improve quality of ln's diagnostics.
1767 * src/ln.c (do_link, usage): Likewise.
1768 (do_link): Don't use alloca on a buffer of unbounded size.
1770 2005-11-16 Jim Meyering <jim@meyering.net>
1772 * tests/cp/fail-perm: Accommodate HPUX. It appears to fail
1773 with EACCES rather than EPERM. Reported by Peter O'Gorman here:
1774 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/5766
1775 This also affects AIX 4.3.3, according to Ralf Wildenhues, in
1776 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
1778 2005-11-14 Jim Meyering <jim@meyering.net>
1780 * NEWS (sort): Mention consequences of today's mkstemp-safer.c fix.
1782 2005-11-13 Jim Meyering <jim@meyering.net>
1784 * announce-gen: Accept new option, --gpg-key-id=ID and
1785 emit a blurb telling how to use the .sig files.
1786 * Makefile.cfg (gpg_key_ID): Define.
1787 * Makefile.maint (announcement): Use new option and key.
1789 Require that most .c files include <config.h>.
1790 * Makefile.maint (sc_require_config_h): New rule.
1791 (syntax-check-rules): Add it.
1792 * .x-sc_require_config_h: New file listing exceptions to the
1793 above rule. Some are legit, others are simply grandfathered in.
1794 * Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h here, too.
1796 2005-11-12 Jim Meyering <jim@meyering.net>
1798 * src/checksum.h, src/md5.c, src/sha1sum.c: Remove now-unused files.
1800 2005-11-11 Jim Meyering <jim@meyering.net>
1802 * NEWS: Mention `readlink -f' bug fix in 5.3.0 news.
1803 Mention new readlink options in 5.3.0's `New features' section.
1804 Spotted by Thomas Hood.
1806 2005-11-08 Jim Meyering <jim@meyering.net>
1808 * NEWS: Merge in changes from b5_9x branch.
1810 2005-11-08 Paul Eggert <eggert@cs.ucla.edu>
1812 * NEWS: ls now defaults to --time-style='locale', which in turn acts
1813 like --time-style='posix-long-iso' if the locale settings are messed up.
1814 * src/ls.c (decode_switches): Implement this.
1816 2005-11-08 Jim Meyering <jim@meyering.net>
1818 * tests/du/2g: s/expensive/very expensive/ in a comment.
1821 2005-10-17 Eric Blake <ebb9@byu.net>
1823 * src/ls.c (usage): Fix descriptions of --sort, --time.
1824 Reported by Vitaly A. Ostanin.
1826 2005-11-04 Paul Eggert <eggert@cs.ucla.edu>
1828 * src/ln.c: Include filenamecat.c.
1829 (FILE_BASENAME_CONCAT): Remove.
1830 (do_link): Remove last arg DEST_IS_DIR. All callers changed.
1831 (main): Use file_name_concat, base_name, and strip_trailing_slashes
1832 instead of FILE_BASENAME_CONCAT. This simplifies the code, and avoids
1835 2005-11-04 Jim Meyering <jim@meyering.net>
1837 * src/du.c (process_file): Don't overflow for files of size >= 2^31
1838 on systems with stat.st_blocks of a signed 32-bit type.
1839 This bug causes trouble on some AIX 5.1 systems.
1840 Report and trivial patch from Paul Townsend:
1841 <http://lists.gnu.org/archive/html/bug-coreutils/2005-11/msg00033.html>
1842 * NEWS: Mention this.
1844 * tests/du/2g: New (very-expensive) test for the above-fixed bug.
1845 * tests/du/Makefile.am (TESTS): Add it here.
1846 * tests/very-expensive: New file.
1847 * tests/Makefile.am (EXTRA_DIST): Add it here.
1848 * tests/cp/perm: Mark this test as `very-expensive', too.
1850 2005-11-02 Paul Eggert <eggert@cs.ucla.edu>
1852 * NEWS: Mention that rm -d and maybe ln -d are scheduled for
1854 * src/remove.h (struct rm_options): Remove unlink_dirs. All uses
1856 * src/rm.c (usage): Don't mention rm -d.
1858 2005-11-02 Jim Meyering <jim@meyering.net>
1860 * tests/dd/skip-seek: Fix typo in comment: s/fileutils/coreutils.
1861 From Andreas Schwab.
1863 * tests/dd/unblock-sync: Redirect stderr to /dev/null so the
1864 `M+N records in/out' lines don't pollute `make check' output.
1866 * tests/dd/skip-seek (sk-seek4): New test, to exercise the bug
1867 fixed on 2005-10-31. This test uses the new, IN_PIPE specifier.
1868 * tests/Coreutils.pm: Accept a new type of input specifier: IN_PIPE,
1869 to indicate that the input file should be piped into the command
1870 under test (via `cat FILE | $prog ...').
1872 * src/remove.c (remove_entry): Emit a better diagnostic when rm
1873 (without -r) fails to remove a directory on a non-Linux system.
1874 This change affects only newer Solaris systems (with priv_*
1875 functions like priv_allocset). Reported by Keith Thompson.
1877 * tests/rm/dir-nonrecur: New file/test for the above fix.
1878 * tests/rm/Makefile.am (TESTS): Add dir-nonrecur.
1880 2005-11-01 Paul Eggert <eggert@cs.ucla.edu>
1882 * NEWS: "tail -c 2 FILE" and "touch 0101000000" now operate as
1883 POSIX 1002.1-2001 requires.
1884 * src/tail.c (parse_obsolete_option): Implement this.
1885 Problem reported by Vincent Lefevre.
1886 * src/touch.c (main): Pass PDS_PRE_2000 to posixtime.
1887 * tests/tail/Test.pm (c-2, c-2-minus, c2, c2-minus): New tests.
1888 (test_vector): Add special cases for _POSIX2_VERSION, and
1889 regularize the old ones a bit.
1890 * tests/touch/obsolescent: Add y2000 test.
1892 2005-10-31 Paul Eggert <eggert@cs.ucla.edu>
1894 * src/dd.c (skip): Fix off-by-one error reported by
1895 Theodoros V. Kalamatianos.
1897 2005-10-30 Paul Eggert <eggert@cs.ucla.edu>
1899 * tests/mkdir/p-3: Require that the test be run as non-root.
1900 Problem and trivial fix reported by Theodoros V. Kalamatianos.
1902 2005-10-28 Paul Eggert <eggert@cs.ucla.edu>
1904 * src/ln.c (FILE_BASENAME_CONCAT): Omit unnecessary slashes in the
1905 boundary between DEST and SOURCE in the result.
1907 2005-10-26 Dmitry V. Levin <ldv@altlinux.org>
1909 * src/md5sum.c (main) [!O_BINARY]: Changed default read mode
1910 back to text, to sync with documentation and for backwards
1913 2005-10-25 Jim Meyering <jim@meyering.net>
1915 * tests/dircolors/simple (other-wr): Add an explicit test for
1916 the dircolors bug (NULL-dereference) fixed yesterday.
1918 2005-10-24 Jim Meyering <jim@meyering.net>
1920 * src/tac.c (tac_file): When determining whether a file is seekable,
1921 also test whether it is a tty. Using only the lseek-based test would
1922 give a false positive on Solaris. Reported by Peter Fales.
1924 2005-10-24 Dmitry V. Levin <ldv@altlinux.org>
1926 * tests/install/d-slashdot: New test, for "install -d" failure.
1927 * tests/install/Makefile.am (TESTS): Add d-slashdot.
1928 * tests/mkdir/p-slashdot: New test, for "mkdir -p" failure.
1929 * tests/mkdir/Makefile.am (TESTS): Add p-slashdot.
1931 2005-10-24 Jim Meyering <jim@meyering.net>
1933 * src/dircolors.c (ls_codes): Add missing comma.
1934 Anonymous report and patch from
1935 http://savannah.gnu.org/bugs/?func=detailitem&item_id=14849
1937 * src/dircolors.c: Add compile-time assertion that the slack_codes
1938 and ls_codes arrays have the same number of elements. This would
1939 have prevented the above-fixed bug.
1941 * src/expand.c (parse_tab_stops): Add a comment to make this function
1942 identical to the one in unexpand.c.
1943 * src/unexpand.c (parse_tab_stops): Adjust syntax to make this function
1944 identical to the one in expand.c.
1946 * src/expand.c (next_file): Don't assume fopen cannot return stdin.
1948 2005-10-23 Jim Meyering <jim@meyering.net>
1950 * src/md5sum.c (digest_check, main): Use ptr_align rather than
1951 a dangerous pointer-value-to-`unsigned' cast.
1952 * NEWS: mention the new sha* programs.
1953 * AUTHORS: Add new sha* programs.
1955 2005-08-28 David Madore <david.madore@ens.fr>
1957 Add new programs: sha224sum, sha256sum, sha384sum, sha512sum.
1958 * README: Add their names to the list.
1959 * src/md5sum.c: Provide framework for computing sha-2 hashes.
1960 * src/Makefile.am (sha224sum, sha256sum, sha384sum, sha512sum):
1961 Rules for compiling sha-2 utilities
1962 (noinst_HEADERS): Remove checksum.h.
1963 * man/sha512sum.x, man/sha384sum.x, man/sha256sum.x, man/sha224sum.x:
1965 * man/Makefile.am (dist_man_MANS): Add the corresponding .1 names.
1966 (sha224sum.1, sha256sum.1, sha384sum.1, sha512sum.1): New dependencies.
1967 * tests/misc/sha224sum, tests/misc/sha256sum: New files.
1968 * tests/misc/sha384sum, tests/misc/sha512sum: New files.
1969 * tests/misc/Makefile.am (TESTS): Add new sha224sum, sha256sum,
1970 sha384sum, sha512sum test scripts here rather that each in its
1973 2005-08-28 David Madore <david.madore@ens.fr>
1975 * tests/sha1sum/basic-1 (million-a): Add the "million a's" test (one
1976 of the FIPS test vectors).
1978 2005-10-23 Jim Meyering <jim@meyering.net>
1980 * configure.ac: Use 6.0-cvs as the version string.
1981 * NEWS: Adjust accordingly.