1 2005-06-20 Colin Walters <walters@verbum.org>
3 * configure.in: Add glib/examples.
5 * glib/Makefile.am: Add examples/
7 * glib/examples/.cvsignore
8 * glib/examples/Makefile.am
9 * glib/examples/example-client.c
10 * glib/examples/example-service.c
11 * glib/examples/example-service.xml
12 * glib/examples/example-signal-emitter.c
13 * glib/examples/example-signal-emitter.xml
14 * glib/examples/example-signal-recipient.c:
15 New files; GLib binding examples, ported from
18 2005-06-20 Colin Walters <walters@verbum.org>
21 * glib/dbus-gproxy.c: Rename dbus_g_proxy_invoke to
24 * glib/dbus-binding-tool-glib.c:
25 * doc/dbus-tutorial.xml:
26 * test/glib/test-dbus-glib.c: Update for rename.
28 2005-06-20 Colin Walters <walters@verbum.org>
30 Patch suggested by Ross Burton <ross@openedhand.com>
32 * glib/dbus-gobject.c (export_signals): Free signal name.
33 (g_value_init): Use G_VALUE_NOCOPY_CONTENTS to plug
34 memory leak. Add a bit of documentation.
35 (dbus_g_method_return_error): Free context, and note we do
38 2005-06-18 Murray Cumming <murrayc@murrayc.com>
41 * glib/dbus-gobject.c:
43 * glib/dbus-gvalue.c: Predeclare structs as
44 typedef struct _Something Something instead of
45 typedef struct Something Something, so we can
46 redeclare the prototypes. Other GNOME libraries
49 2005-06-17 Colin Walters <walters@verbum.org>
51 * tools/dbus-names-model.c (have_names_notify): Fix call
52 to dbus_g_proxy_end_call.
54 2005-06-17 Colin Walters <walters@verbum.org>
56 * glib/dbus-gproxy.c (dbus_g_proxy_emit_remote_signal): Don't
57 spew warnings if we get malformed remote signals.
59 * glib/dbus-gobject.c (propsig_iterate): New function.
60 (lookup_object_info): New function, extracted from
61 lookup_object_and_method.
62 (introspect_properties, introspect_signals): Delete; these
63 are merged into write_interface.
64 (write_interface): Write out signals and properties here;
65 dump the org.gtk.object stuff and use the interface given
66 in the introspection data blob. Also fix up property XML.
67 (lookup_values): New function.
68 (introspect_interfaces): Gather a mapping from interface to a
69 list of its methods, signals, and properties, then write out
71 (lookup_object_and_method): Use lookup_object_info.
72 (struct DBusGSignalClosure): Add interface.
73 (dbus_g_signal_closure_new): Add interface. Don't dup signame;
74 we can just use the constant data.
75 (dbus_g_signal_closure_finalize): Don't free signal name.
76 (signal_emitter_marshaller): Use interface from signal closure.
77 (export_signals): Only export signals mentioned in introspection
79 (dbus_g_connection_register_g_object): Warn if we have no
80 introspection data for an object.
81 (funcsig_equal): Remove unused variable.
82 (dbus_g_object_register_marshaller): Take varargs instead of
84 (dbus_g_object_register_marshaller_array): New function,
85 extracted from old dbus_g_object_register_marshaller.
87 * glib/dbus-binding-tool-glib.c (struct DBusBindingToolCData): Add
88 signals and property data.
89 (write_quoted_string): New function, extracted from generate_glue.
90 (generate_glue): Write signals and properties to introspection
93 * dbus/dbus-glib.h (struct DBusGObjectInfo): Include
94 exported_signals and exported_properties.
95 (dbus_g_object_register_marshaller): Update prototype.
96 (dbus_g_object_register_marshaller_array): Prototype.
98 * test/glib/test-dbus-glib.c: Extend testing to cover new signals.
100 * test/glib/test-service-glib.c: Add new test signals and method
103 * test/glib/test-service-glib.xml: Add some test signals.
105 * test/glib/Makefile.am (BUILT_SOURCES): Add my-object-marshal.c
106 and my-object-marshal.h
107 (test_service_glib_SOURCES, test_dbus_glib_SOURCES): Add
109 (my-object-marshal.c, my-object-marshal.h): Implement.
111 * test/glib/.cvsignore: Update.
113 * doc/TODO: Remove two GLib TODO items fixed by this
116 2005-06-16 Colin Walters <walters@verbum.org>
118 * doc/TODO: Update for GLib bindings.
120 2005-06-16 Colin Walters <walters@verbum.org>
122 * glib/dbus-binding-tool-glib.c:
123 * glib/dbus-gobject.c:
124 * glib/dbus-gproxy.c: Add Nokia copyright; Patch
125 from Ross Burton, for his GLib bindings work.
127 2005-06-16 Colin Walters <walters@verbum.org>
129 * glib/dbus-gobject.c (funcsig_hash, funcsig_equal): Use n_params
130 to iterate instead of walking to G_TYPE_INVALID.
132 Patch based on a patch from Ryan Gammon.
134 2005-06-16 Colin Walters <walters@verbum.org>
136 * bus/bus.c (bus_context_new): Set parser to NULL
137 after we unref it (Patch from Chris Boscolo, #2174).
139 2005-06-16 Colin Walters <walters@verbum.org>
141 * python/dbus_bindings.pyx.in: Import size_t,
142 __int64_t, __uint64_t, and __signed.
144 * dbus/dbus-sysdeps.c <HAVE_CMSGCRED> (write_credentials_byte):
145 Define cmsg struct, output it.
146 (_dbus_read_credentials_unix_socket):
149 Patch from Joe Markus Clarke for FreeBSD support.
151 2005-06-16 Colin Walters <walters@verbum.org>
153 * tools/dbus-send.c (append_array): Use strtok.
154 (append_dict): New function.
155 (type_from_name): New function, extracted from main.
156 (main): Handle sending dicts.
158 * tools/dbus-print-message.c (print_iter): Print dict
161 2005-06-16 Colin Walters <walters@verbum.org>
163 * glib/dbus-gvalue.c (marshal_basic): Marshal NULL string
164 values as the empty string (#2948).
166 2005-06-16 Colin Walters <walters@verbum.org>
169 * mono/doc/Makefile.am:
170 * test/glib/Makefile.am:
172 Fix srcdir != builddir issues (Patch from Chris Wilson, #3477)
174 2005-06-16 Colin Walters <walters@verbum.org>
176 * dbus/dbus-marshal-header.c (_dbus_header_load): Set
177 header byte order from expected byte order (Patch from Chris Wilson, #3475).
179 * dbus/dbus-marshal-byteswap.c (byteswap_body_helper):
180 Increment pointer after swapping fixed array. Add assertion
183 2005-06-15 Colin Walters <walters@verbum.org>
185 * dbus/dbus-sysdeps.c <HAVE_CMSGCRED> (_dbus_read_credentials_unix_socket):
186 Fix call to dbus_set_error. (Patch from Michael Banck, #3461)
188 2005-06-15 John (J5) Palmieri <johnp@redhat.com>
190 * NEWS: Update to 0.34
192 2005-06-15 David Zeuthen <davidz@redhat.com>
194 * configure.in (LT_CURRENT): Revert back to 1 as the library
195 hasn't changed and we've certainly not committed to protocol
196 stability yet. All this does is to break ABI. See commit note
197 from hp@redhat.com 2005-05-05 for details.
199 2005-06-15 John (J5) Palmieri <johnp@redhat.com>
201 * dbus/dbus-connection.c (_dbus_connection_peer_filter): New method
202 (_dbus_connection_run_builtin_filters): New method
203 (dbus_connection_dispatch): Run the builtin filters which in turn
204 runs the peer filter which handles Ping messages.
207 - Ping isn't handled: This patch fixes it
209 - Add a test case for the Ping message: added TODO item
211 2005-06-15 John (J5) Palmieri <johnp@redhat.com>
213 * dbus/dbus-message.c:
214 (dbus_message_has_path): New method
215 (dbus_message_has_interface): New method
216 (dbus_message_has_member): New method
218 * dbus/dbus/dbus-sysdeps.c (_dbus_check_dir_is_private_to_user):
221 * dbus/dbus-keyring.c (_dbus_keyring_reload): Check to see that
222 the keyring directory is private to the user
225 - The convenience functions in dbus-bus.h should perhaps have
226 the signatures that they would have if they were autogenerated
227 stubs. e.g. the acquire service function. We should also evaluate
228 which of these functions to include, in light of the fact that
229 GLib/Qt native stubs will probably also exist.: Punted
231 - add dbus_message_has_path(), maybe has_member/interface:
234 - in dbus-keyring.c, enforce that the keyring dir is not
235 world readable/writable: Fixed in this patch
237 2005-06-15 John (J5) Palmieri <johnp@redhat.com>
239 * dbus/dbus-marshal-validate.h: Added a new validation
240 error code DBUS_VALIDITY_UNKNOWN_OOM_ERROR = -4 for
241 out of memory errors when validating signitures
243 * dbus/dbus-marshal-header.c: use DBUS_VALIDITY_UNKNOWN_OOM_ERROR
244 in places where we previously used DBUS_VALID and a FALSE return
245 value to indicate OOM
247 * dbus/dbus-marshal-validate.c (_dbus_validate_signature_with_reason):
248 Use a stack to track the number of elements inside containers. The
249 stack values are then used to validate that dict entries have only two
250 elements within them.
251 (validate_body_helper): check the reason for failure when validating
254 * dbus/dbus-message.c (load_message): use
255 DBUS_VALIDITY_UNKNOWN_OOM_ERROR in places where we previously used
256 DBUS_VALID and a FALSE return value to indicate OOM
258 * doc/TODO: remove "- validate dict entry number of fields" as this
261 2005-06-14 David Zeuthen <davidz@redhat.com>
263 * bus/bus.c (process_config_every_time): Drop existing conf-dir
264 watches (if applicable) and add new watches
266 * bus/main.c (signal_handler): Handle SIGIO if using D_NOTIFY
267 (main): Setup SIGIO signal handler if using D_NOTIFY
269 * bus/config-parser.h: Add prototype bus_config_parser_get_conf_dirs
271 * bus/config-parser.c (struct BusConfigParser): Add conf_dirs list
272 (merge_included): Also merge conf_dirs list
273 (bus_config_parser_unref): Clear conf_dirs list
274 (include_dir): Add directory to conf_dirs list
275 (bus_config_parser_get_conf_dirs): New function
277 * bus/dir-watch.[ch]: New files
279 * bus/Makefile.am (BUS_SOURCES): Add dir-watch.[ch]
281 * configure.in: Add checks for D_NOTIFY on Linux
283 2005-06-14 Colin Walters <walters@verbum.org>
285 * glib/dbus-binding-tool-glib.c:
286 * glib/dbus-gobject.c:
287 * glib/dbus-gvalue.c: Fix indentation and brace style.
289 2005-06-14 Ross Burton <ross@openedhand.com>.
291 * glib/dbus-glib.h: Make DBusGMethodInvocation
292 a private structure. Rearrange prototypes a bit.
294 * glib/dbus-gproxy.c (dbus_g_proxy_invoke): Add
295 documentation for first_arg_type.
297 * glib/dbus-gobject.c: Move DBusGMethodInvocation
298 here, add documentation. Move dbus_g_method_return
299 and dbus_g_method_return_error into public API
302 2005-06-14 Colin Walters <walters@verbum.org>
304 * glib/dbus-gobject.c (_dbus_gobject_lookup_marshaller):
305 Add missing return statements, noticed by Ross Burton.
307 2005-06-13 Ross Burton <ross@openedhand.com>.
309 * glib/dbus-gobject.c: Handle errors on message
310 demarshalling by sending error message back.
311 * glib/dbus-gvalue.c: Initialize return variables.
313 2005-06-13 Colin Walters <walters@verbum.org>
315 * glib/Makefile.am: Fix thinko in last patch.
317 2005-06-13 Colin Walters <walters@verbum.org>
319 * glib/Makefile.am: Move dbus-gtype-specialized.c
320 and dbus-gtype-specialized.h into a _HEADERS variable,
323 2005-06-12 Colin Walters <walters@verbum.org>
325 Async signals and various bugfixes and testing by
326 Ross Burton <ross@openedhand.com>.
328 * glib/dbus-gvalue.h: (struct DBusBasicGValue): Delete.
329 (dbus_gvalue_genmarshal_name_from_type)
330 (dbus_gvalue_ctype_from_type): Moved to dbus-binding-tool-glib.c.
331 (dbus_gtype_to_dbus_type): Renamed to dbus_gtype_from_signature.
332 (dbus_g_value_types_init, dbus_gtype_from_signature)
333 (dbus_gtype_from_signature_iter, dbus_gtype_to_signature)
334 (dbus_gtypes_from_arg_signature): New function prototypes.
335 (dbus_gvalue_demarshal): Take context and error arguments.
336 (dbus_gvalue_demarshal_variant): New function.
337 (dbus_gvalue_demarshal_message): New function.
338 (dbus_gvalue_store): Delete.
340 * glib/dbus-gvalue.c:
342 File has been almost entirely rewritten; now we special-case
343 more types such as DBUS_TYPE_SIGNATURE, handle arrays and
344 hash tables correctly, etc. Full support for recursive values
347 * glib/dbus-gproxy.c (dbus_g_proxy_class_init): Change last
348 argument of signal to G_TYPE_POINTER since we now pass a
350 (lookup_g_marshaller): Delete in favor of
351 _dbus_gobject_lookup_marshaller.
352 (marshal_dbus_message_to_g_marshaller): Use
353 _dbus_gobject_lookup_marshaller and dbus_gvalue_demarshal_message
354 to handle remote signal callbacks.
355 (dbus_g_proxy_new_from_proxy): New function; creates a new
356 DBusGProxy by copying an existing one.
357 (dbus_g_proxy_get_interface, dbus_g_proxy_set_interface)
358 (dbus_g_proxy_get_path): New functions.
359 (dbus_g_proxy_marshal_args_to_message): New function;
360 factored out of existing code.
361 (DBUS_G_VALUE_ARRAY_COLLECT_ALL): Collect all arguments
362 from a varargs array.
363 (dbus_g_proxy_begin_call_internal): New function.
364 (dbus_g_proxy_end_call_internal): New function.
365 (dbus_g_proxy_begin_call): Take GTypes instead of DBus types
366 as arguments; simply invoke dbus_g_proxy_begin_call_internal
367 after collecting args into value array.
368 (dbus_g_proxy_end_call): Take GTypes instead of DBus types;
369 invoke dbus_g_proxy_end_call_internal.
370 (dbus_g_proxy_invoke): Simply invoke begin_call_interanl and
372 (dbus_g_proxy_call_no_reply): Take GTypes instead of DBus
374 (array_free_all): New function.
375 (dbus_g_proxy_add_signal): Take GTypes.
377 * glib/dbus-gobject.h:
378 (_dbus_glib_marshal_dbus_message_to_gvalue_array): Delete.
379 (_dbus_gobject_get_path, _dbus_gobject_lookup_marshaller):
382 * glib/dbus-gobject.c: Add a global marshal_table hash which
383 stores mappings from type signatures to marshallers. Change lots
384 of invocations of dbus_gtype_to_dbus_type to
385 dbus_gtype_to_signature.
386 (_dbus_glib_marshal_dbus_message_to_gvalue_array): Delete.
387 (introspect_signals): Fix test for query.return_type.
388 (set_object_property): Update invocation of dbus_gvalue_demarshal.
389 (invoke_object_method): Many changes. Handle asynchronous
390 invocations. Convert arguments with
391 dbus_gvalue_demarshal_message. Handle errors. Use
392 DBusSignatureIter instead of strlen on args. Handle all arguments
393 generically. Special-case variants.
394 (dbus_g_method_return, dbus_g_method_return_error): New function.
395 (DBusGSignalClosure): New structure, closes over signal
397 (dbus_g_signal_closure_new): New function.
398 (dbus_g_signal_closure_finalize): New function.
399 (signal_emitter_marshaller): New function; is special marshaller
400 which emits signals on bus.
401 (export_signals): New function; introspects object signals and
403 (dbus_g_object_type_install_info): Take GType instead of
405 (dbus_g_connection_register_g_object): Invoke export_signals.
406 (dbus_g_connection_lookup_g_object): New function.
407 (DBusGFuncSignature) New structure; used for mapping type
408 signatures to marshallers.
409 (funcsig_hash): New function; hashes DBusGFuncSignature.
410 (funcsig_equal): New function; compares DBusGFuncSignature.
411 (_dbus_gobject_lookup_marshaller): New function.
412 (dbus_g_object_register_marshaller): New function; used to
413 register a marshaller at runtime for a particular signature.
415 * glib/dbus-gmain.c (_dbus_gmain_test): Add various tests.
417 * glib/dbus-binding-tool-glib.h: Add DBUS_GLIB_ANNOTATION_ASYNC
418 which notes a server method implementation should be
421 * glib/dbus-binding-tool-glib.c
422 (dbus_binding_tool_output_glib_server): Call
423 dbus_g_value_types_init.
424 (write_formal_parameters): Use dbus_gtype_from_signature. Handle
426 (dbus_g_type_get_lookup_function): Turn GType into an invocation
427 of a lookup function.
428 (write_args_for_direction): Use dbus_g_type_get_lookup_function.
429 (write_untyped_out_args): New method; write output arguments.
430 (write_formal_declarations_for_direction): Function for
432 (write_formal_parameters_for_direction): Function for
433 writing implementations.
434 (write_typed_args_for_direction): Function for writing
435 arguments prefixed with GTypes.
436 (write_async_method_client): Write out async version
439 * glib/dbus-binding-tool-glib.c: Include dbus-gvalue-utils.h.
440 (dbus_g_type_get_marshal_name): Move mapping from GType
441 to marshal name into here.
442 (dbus_g_type_get_c_name): Move into here.
443 (compute_marshaller): Convert signature to type with
444 dbus_gtype_from_signature, use dbus_g_type_get_marshal_name.
445 (compute_marshaller_name): Ditto.
446 (compute_marshaller): Handle async signal annotations.
447 (gather_marshallers): Return if we don't have a known
449 (generate_glue): Collect introspection blob here, and
450 write all of the blob at the end. This allows an object
451 with multiple interfaces to work.
452 Mark async methods in introspection blob.
454 * glib/Makefile.am (libdbus_glib_1_la_SOURCES): Add
455 dbus-gtype-specialized.c, dbus-gtype-specialized.h,
456 dbus-gvalue-utils.h, dbus-gvalue-utils.c.
458 * dbus/dbus-glib.h: Don't include dbus-protocol.h; this
459 avoids people accidentally using DBUS_TYPE_* which should
460 not be necessary anymore.
461 Do include dbus-gtype-specialized.h, which are utilities
462 for GLib container types.
463 Add various #defines for types such as
464 DBUS_TYPE_G_BOOLEAN_ARRAY.
465 (DBusGValueIterator, DBusGValue): Define, not fully used
467 (dbus_g_value_get_g_type): Type for recursive value.
468 (dbus_g_value_open, dbus_g_value_iterator_get_value)
469 (dbus_g_value_iterator_get_values, dbus_g_value_iterator_recurse)
470 (dbus_g_value_free): Prototypes.
471 (dbus_g_object_register_marshaller, dbus_g_proxy_new_from_proxy): Prototype.
472 (dbus_g_proxy_set_interface): Prototype.
473 (dbus_g_proxy_begin_call, dbus_g_proxy_end_call)
474 (dbus_g_proxy_call_no_reply): Take GLib types instead of DBus
476 (dbus_g_proxy_get_path, dbus_g_proxy_get_interface):
478 (DBusGAsyncData, DBusGMethodInvocation): Structures for
479 doing async invocations.
480 (dbus_g_method_return, dbus_g_method_return_error):
482 * doc/dbus-tutorial.xml: Update GLib section.
484 * tools/dbus-viewer.c (load_child_nodes): Update
485 for new invocation type of dbus_g_proxy_end_call.
486 (load_from_service_thread_func): Ditto.
488 * tools/print-introspect.c (main): Ditto.
490 * tools/dbus-names-model.c (have_names_notify)
491 (names_model_reload, names_model_set_connection)
494 * python/Makefile.am (INCLUDES): Define DBUS_COMPILATION,
495 needed since Python bindings use GLib bindings.
497 * test/glib/Makefile.am (INCLUDES): Define DBUS_COMPILATION.
498 Add --prefix argument.
500 * tools/Makefile.am: Define DBUS_COMPILATION. Remove
501 unneeded --ignore-unsupported arg.
503 * test/glib/test-service-glib.c:
504 * test/glib/test-service-glib.xml:
505 * test/glib/test-dbus-glib.c: Add many more tests.
507 2005-06-06 David Zeuthen <davidz@redhat.com>
509 * doc/TODO: Add item about need to remove deprecated functions.
511 * dbus/dbus-connection.h: Add prototype for dbus_connection_disconnect
513 * dbus/dbus-connection.c (dbus_connection_disconnect): New function
514 to repair the ABI which was broken with the last commit.
516 2005-06-02 John (J5) Palmieri <johnp@redhat.com>
518 * dbus/dbus-connection.c, dbus/dbus-connection.h
519 (dbus_connection_disconnect): renamed to dbus_connection_close
520 for API symmetry with dbus_connection_open
521 (_dbus_connection_open_internal):
522 s/dbus_connection_disconnect/dbus_connection_close
524 * dbus/dbus-bus.c (dbus_bus_get):
525 s/dbus_connection_disconnect/dbus_connection_close
527 * bus/connection.c (bus_connections_unref,
528 bus_connections_setup_connection, bus_connections_expire_incomplete):
529 s/dbus_connection_disconnect/dbus_connection_close
531 * bus/dispatch.c (bus_dispatch, kill_client_connection,
532 kill_client_connection_unchecked, check_hello_connection):
533 s/dbus_connection_disconnect/dbus_connection_close
535 * bus/bus.c (new_connection_callback):
536 s/dbus_connection_disconnect/dbus_connection_close
538 * tools/dbus-send.c (main):
539 s/dbus_connection_disconnect/dbus_connection_close
541 * test/glib/test-profile.c (no_bus_thread_func, with_bus_thread_func):
542 s/dbus_connection_disconnect/dbus_connection_close
544 * test/test-service.c (path_message_func, filter_func):
545 s/dbus_connection_disconnect/dbus_connection_close
547 * doc/TODO: remove connection_open/connection_disconnect lacks symmetry item that was just fixed
549 2005-05-25 Colin Walters <walters@verbum.org>
551 * dbus/dbus-protocol.h: Move various bus service #defines such
552 as DBUS_SERVICE_DBUS and DBUS_NAME_FLAG_PROHIBIT_REPLACEMENT to
554 * dbus/dbus-shared.h: Various defines moved here.
555 * dbus/dbus-marshal-header.c: Include dbus-shared.h.
557 2005-05-25 John (J5) Palmieri <johnp@redhat.com>
559 * python/__init__.py: Python bindings deserve a minor version
560 update. Upped to (0, 40, 2)
562 2005-05-24 John (J5) Palmieri <johnp@redhat.com>
564 * python/decorators.py: add explicitly_pass_message decorator
565 for passing in the dbus message as keyword for edge case signal
568 * python/matchrules.py (SignalMatchRule.__repr__): fix output
569 to conform with what dbus expects for match rules
570 (SignalMatchRule.execute): add the dbus message as a keyword
571 if the signal handler has requested it
573 * python/examples/example/signal-recipient.py: added some more
574 examples on how to hook up to signals
576 2005-05-23 John (J5) Palmieri <johnp@redhat.com>
578 * python/decorators.py: import dbus_bindings
580 * python/matchrules.py (SignalMatchRule, SignalMatchTree,
581 SignalMatchNode): new classes that implement wildcard signal
582 callback matching using a tree lookup. Heavily modified from a
583 patch sent by Celso Pinto (fd.o bug #3241)
585 * _dbus.py (add_signal_receiver, remove_signal_receiver, _signal_func):
586 use new match classes to handle signals.
588 2005-05-19 John (J5) Palmieri <johnp@redhat.com>
590 * python/dbus_bindings.pyx.in: s/TYPE_PATH/TYPE_OBJECT_PATH
592 2005-05-18 Havoc Pennington <hp@redhat.com>
594 * configure.in: use GLIB_GNU_GETTEXT to get INTLLIBS and require
595 gettext. Not really worth requiring yet perhaps, but any
596 production quality 1.0 would require it so we should go ahead and
597 get things set up. We do have a couple token calls to
598 bindtextdomain in the code already.
600 2005-05-16 John (J5) Palmieri <johnp@redhat.com>
602 * glib/dbus-gmain.c (io_handler_dispatch): fix deadlock
603 when using recursive g_main_loops
605 * python/_dbus.py (class Bus): add the ProxyObjectClass
606 alias for ProxyObject to make it easier for the Twisted
607 networking framework to integrate dbus.
609 * python/proxies.py (class ProxyObject): add the ProxyMethodClass
610 alias for ProxyMethod to make it easier for the Twisted
611 networking framework to integrate dbus.
613 2005-05-11 Ross Burton <ross@openedhand.com>
615 * glib/dbus-glib-tool.c: Add --prefix argument.
616 * glib/dbus-binding-tool-glib.h: Add prefix argument.
617 * glib/dbus-binding-tool-glib.c (compute_marshaller_name):
619 (generate_glue): Pass prefix argument down.
620 (dbus_binding_tool_output_glib_server): Pass prefix to
623 2005-05-11 Colin Walters <walters@verbum.org>
625 * tools/dbus-send.c (append_array): New function.
626 (append_arg): Broken out from main.
627 (main): Add cheesy hack to send arrays and variants.
629 * tools/dbus-print-message.c (print_iter): Broken out
632 2005-05-11 Colin Walters <walters@verbum.org>
634 * dbus/dbus-signature.c (dbus_signature_iter_get_signature):
635 New function, returns signature string for signature iter.
636 * dbus/dbus-signature.h: Prototype it.
637 * dbus/dbus-message.c (dbus_message_iter_get_signature):
638 New function, returns signature string for message iter.
639 (dbus_message_iter_get_array_len): New function, returns
641 (dbus_message_iter_get_fixed_array): Fix assertion; this
642 function should be used when the iter is pointing to the
644 * dbus/dbus-message.h: Prototypes.
645 * dbus/dbus-marshal-recursive.c (_dbus_type_reader_get_array_length):
646 New function; returns length of an array.
647 * dbus/dbus-marshal-recursive.h: Prototype it.
649 2005-05-11 Colin Walters <walters@verbum.org>
651 * dbus/dbus-sysdeps-util.c <!HAVE_POSIX_GETPWNAM_R>: Fix
654 2005-05-08 Havoc Pennington <hp@redhat.com>
656 * dbus/dbus-sysdeps-util.c (_dbus_become_daemon): write the
657 daemon's pid, not the parent's pid, to the file descriptor.
658 Reported by Taj Morton.
660 2005-05-05 Havoc Pennington <hp@redhat.com>
662 * configure.in (LT_*): add notes on how the libtool versioning
663 works to save thinking. Increment soname to indicate protocol
664 breakage (though really the library interface hasn't changed I
667 * dbus/dbus-transport.c (_dbus_transport_get_is_authenticated):
668 verify the GUID received from server matches what we were
669 expecting, if we had an expectation
671 * dbus/dbus-auth.c (send_ok): send GUID along with the OK command
672 (_dbus_auth_get_guid_from_server): new function
673 (send_begin): parse the OK args
675 * doc/dbus-specification.xml: add GUID to the auth protocol
677 2005-05-05 John (J5) Palmieri <johnp@redhat.com>
679 * Fix my name in previous changelog ;)
681 * python/proxies.py (ProxyObject.__getattr__): add further patch
682 from Anthony Baxter to throw an AttributeError when python
683 __special__ functions are called instead of marshling them over
684 the bus (Bug#1685 comment 3).
686 2005-05-04 John (J5) Palmieri <johnp@redhat.com>
688 * python/Makefile.am: changed to use pyexecdir for the binding
689 shared libraries (Bug#2494)
691 * python/exceptions.py: bring exceptions over from the bindings
692 so they can be used in applications (Bug#2036)
693 Make all exceptions derive from DBusException
695 * python/_dbus.py, python/proxies.py: implement __repr__ in a couple
696 of classes so that print obj doesn't throw an exception (Bug #1685)
698 2005-05-03 Ross Burton <ross@openedhand.com>
700 * glib/dbus-gobject.c (dbus_g_connection_register_g_object):
701 Return if we get an error during registration. Set up a
702 weak reference on object to unregister if object is destroyed.
703 (unregister_gobject): New function.
705 2005-05-01 John (J5) Palmieri <johnp@redhat.com>
707 * python/dbus_bindings.pyx.in:
708 - added new type classes for hinting to the marashaler what type
709 to send over the wire
710 - added int16 and uint16 marshalers
711 - Fixed a bug in the type constants that caused int32 to go out
712 as uint16 over the wire
713 * python/dbus.py: split up into different files and renamed _dbus.py
714 * python/__init__.py, python/_util.py, python/decorators.py,
715 python/exceptions.py, python/proxies.py, python/services.py,
716 python/types.py: new files split off from dbus.py
717 * python/Makefile.am: Add new files, remove dbus.py and
718 install all python files to <python module dir>/dbus
719 * python/examples/*: Added #!/usr/bin/env python to the top of
720 every example. Patch provided by Tatavarty Kalyan
722 2005-04-25 John (J5) Palmieri <johnp@redhat.com>
724 * NEWS: Update to 0.33
726 2005-04-25 John (J5) Palmieri <johnp@redhat.com>
728 * python/dbus_bindings.pyx.in (send_with_reply_handlers): New send
729 method for doing async calls
730 (_pending_call_notification): New C function for handling pendning call
732 (set_notify): New method for setting pending call notification
734 * python/dbus.py: new version tuple "version" is set at (0, 40, 0)
735 Async capabilities added to remote method calls
736 (Sender): class removed
737 (RemoteService): class removed
738 (ObjectTree): class removed for now
739 (RemoteObject): Renamed to ProxyObject
740 (RemoteMethod): Renamed to ProxyMethod
741 (method): Decorator added for decorating python methods as dbus methods
742 (signal): Decorator added for decorating python methods as signal emitters
743 (ObjectType): Metaclass added for generating introspection data and the
744 method callback vtable
745 (Interface): Wrapper class added to wrap objects in a dbus interface
746 (Object): Uses ObjectType as its metaclass and exports Introspect
747 of the org.freedesktop.DBus.Introspectable interface
748 (ValidationException, UnknownMethodException): new exceptions
750 * python/examples/*: Modified to fit with the new bindings
752 2005-04-23 Havoc Pennington <hp@redhat.com>
754 * dbus/dbus-message.c (dbus_message_append_args): fix doc comment,
755 reported by Tony Houghton
757 * test/test-service.c (main): test
758 dbus_connection_get_object_path_data()
760 * dbus/dbus-object-tree.c (find_handler): be sure we always init
762 (_dbus_object_tree_get_user_data_unlocked): new function used by
763 dbus_connection_get_object_path_data()
764 (do_register): add assertion test for get_user_data_unlocked
765 (object_tree_test_iteration): more tests
767 * dbus/dbus-connection.c (dbus_connection_get_object_path_data):
768 new function from Dan Reed to let you get the user data from
769 dbus_connection_register_object_path()
771 2005-04-23 John (J5) Palmieri <johnp@redhat.com>
773 * dbus/dbus-marshal-recursive-util.c: Fixed buffer overflow
774 in numerous places that did not account for the NULL terminator
775 (signature_from_seed): changed the manual string copy loop to
776 just use strcpy instead
777 make check should now pass
779 2005-04-19 John (J5) Palmieri <johnp@redhat.com>
781 * dbus/dbus-marshal-header.c (_dbus_header_create): Fix assert
782 so that it allows messages that are not signals to pass in
783 NULL as the interface.
785 2005-04-18 David Zeuthen <davidz@redhat.com>
787 * glib/dbus-gmain.c (io_handler_destroy_source):
788 (timeout_handler_destroy_source, connection_setup_free):
789 Also unref the source to avoid memory leaks.
791 2005-04-13 David Zeuthen <davidz@redhat.com>
793 * bus/config-parser.c (bus_config_parser_new): Bump this to a
794 more reasonable, yet still totally arbitrary, value :-).
796 2005-04-13 David Zeuthen <davidz@redhat.com>
798 * doc/TODO: Added an "important for 1.0" item about selinux
801 2005-04-13 David Zeuthen <davidz@redhat.com>
803 * bus/selinux.c: Add c-file-style to top of file
804 (log_audit_callback): Don't free the data here anymore
805 (bus_selinux_check): Don't take spid and tpid since appending
806 that to auxdata may OOM.
807 (bus_selinux_allows_acquire_service): Handle OOM and signal back
808 to the caller if we are OOM by taking an error object.
809 (bus_selinux_allows_send): -do-
811 * bus/selinux.h: Fix prototypes for bus_selinux_allows_acquire_service
812 and bus_selinux_allows_send
814 * bus/bus.c (bus_context_check_security_policy): Pass error and
815 pass on OOM thrown by bus_selinux_allows_send()
817 * bus/services.c (bus_registry_acquire_service): Pass error and
818 pass on OOM thrown by bus_selinux_allows_acquire_service()
820 2005-04-13 Havoc Pennington <hp@redhat.com>
822 * glib/dbus-gmain.c (message_queue_dispatch): only dispatch one
823 message at a time to avoid monopolizing the main loop, bug
824 #2953 from Benjamin Otte
826 2005-04-09 Havoc Pennington <hp@redhat.com>
828 * dbus/dbus-string.c (copy): change a memcpy to memmove due to
829 possible overlap, fix from Daniel Reed
830 (fixup_alignment): fix signedness warnings
831 (_dbus_string_append_unichar): ditto
833 2005-04-09 Havoc Pennington <hp@redhat.com>
835 * dbus/dbus-message-util.c (_dbus_message_test): fix signedness warning
837 * glib/dbus-glib-tool.c (main): fix warning
839 * glib/dbus-binding-tool-glib.c (generate_glue): fix warning
841 * dbus/dbus-connection.c (dbus_connection_read_write_dispatch):
842 add a new function that can be used in simple applications that
843 don't have a main loop and are willing to block
845 2005-04-05 David Zeuthen <davidz@redhat.com>
847 Fix https://bugs.freedesktop.org/show_bug.cgi?id=2889
850 (io_handler_destroy_source): Remove from list of IO handlers
851 of the ConnectionSetup object
852 (timeout_handler_destroy_source): -do- for timeout handlers
853 (io_handler_source_finalized): Don't remove from list since
854 we now do that in io_handler_destroy_source(). Renamed from
855 io_handler_source_destroyed
856 (timeout_handler_source_destroyed): -do- for timeout handlers
857 (connection_setup_free): It is now safe to iterate over all
858 IO and timeout handlers as the _destroy_source removes them
859 from the list synchronously
861 2005-03-30 Havoc Pennington <hp@redhat.com>
863 * configure.in: change check to gtk 2.4
865 * tools/dbus-viewer.c (name_combo_changed_callback): remove
866 gtk_combo_box_get_active_text() usage to decrement GTK requirement
869 2005-03-29 John (J5) Palmieri <johnp@redhat.com>
873 * HACKING: Fixed realease instructions. configure.in should be updated to
874 the next release by the person who made the last release.
876 2005-03-29 John (J5) Palmieri <johnp@redhat.com>
878 * python/lvalue_cast_post_process.py - removed. Patch has been
879 submitted to Pyrex maintainers that fixes gcc4.0 errors
881 * python/Makefile.am: removed refrences to lvalue_cast_post_process.py
883 2005-03-24 Daniel Reed <n@ml.org>
885 * tools/Makefile.am: Make print-introspect and
886 dbus-bus-introspect.xml building conditional on HAVE_GLIB.
888 2005-03-22 John (J5) Palmieri <johnp@redhat.com>
890 * tools/Makefile.am: Patch by Colin Walters that fixes distcheck
892 * dbus/dbus-userdb.c, dbus/dbus-userdb-util.c: Add patch we have
893 had in Red Hat packages for a while but for some reason never
895 (_dbus_is_a_number): New checks if a string
896 can be converted to a number and does the conversion if it can
897 (_dbus_user_database_lookup): Add check to see if the given username
898 is a udi. This allows udi's to be used instead of usernames in the
900 (_dbus_user_database_lookup_group): Add check to see if the given groupname
901 is a gdi. This allows gdi's to be used instead of groupnames in the
904 2005-03-21 John (J5) Palmieri <johnp@redhat.com>
906 * python/lvalue_cast_post_process.py - added post processor to fix Pyrex
907 code so that it compiles with gcc4.0
909 * python/Makefile.am: Added lvalue_cast_post_process.py to EXTRA_DIST
910 run dbus_bindings.c through lvalue_cast_post_process.py and copy the
911 results back to dbus_binding.c
913 2005-03-20 Colin Walters <walters@verbum.org>
915 Patch suggested by Inguva Rajasekhar <ringuva@novell.com>.
917 * configure.in: Require GTK+ 2.6.
919 2005-03-20 Colin Walters <walters@verbum.org>
921 * Makefile.am (SUBDIRS, DIST_SUBDIRS): Build tools before test.
923 2005-03-17 Tom Parker <palfrey@tevp.net>
925 * dbus/dbus-userdb.c (_dbus_user_database_lookup): Don't
926 print DBUS_UID_UNSET; instead print passed username. Also
927 be sure to actually use gid looked up in cache.
929 * dbus/dbus-userdb-util.c (_dbus_user_database_lookup_group): Ditto
930 for DBUS_GID_UNSET and groupname.
932 2005-03-17 Colin Walters <walters@verbum.org>
934 * bus/print-introspect.c: Move to tools/.
935 * bus/run-with-tmp-session-bus.sh: Ditto.
937 * glib/Makefile.am (dbus-glib-bindings.h): Move
938 generation to tools/Makefile.am.
940 * test/glib/run-test.sh: Update to handle move
941 of run-with-tmp-session-bus.sh.
943 * test/glib/test-service-glib.c: Update to handle
944 move of dbus-glib-bindings.h.
946 * tools/print-introspect.c: Moved here
947 from bus/, and ported to GLib bindings.
949 * tools/run-with-tmp-session-bus.sh: Moved here
952 * tools/Makefile.am: Generate dbus-glib-bindings.h
953 and dbus-bus-introspect.xml here.
955 * tools/.cvsignore, glib/.cvsignore, bus/.cvsignore:
958 2005-03-17 Colin Walters <walters@verbum.org>
960 * bus/driver.c (write_args_for_direction): Use
961 _dbus_string_get_const_data to retrieve string;
962 _dbus_string_get_const_data_len doesn't actually return
963 a NULL-terminated substring.
965 * test/glib/test-service-glib.c: Include dbus-glib-bindings.h.
966 (main): Change to use org_freedesktop_DBus_request_name
967 instead of using g_proxy_begin_call/end_call.
969 2005-03-15 Joe Shaw <joeshaw@novell.com>
971 * mono/ProxyBuilder.cs (BuildFinalizer): Fix some invalid IL when
972 generating the finalizer. Fixes from Ben Maurer.
974 2005-03-12 Joe Shaw <joeshaw@novell.com>
976 * mono/BusDriver.cs: Update method names: ListServices
977 becomes ListNames; GetOwner becomes GetNameOwner.
979 * mono/ProxyBuilder.cs (BuildFinalizer): Need to load arg 0
980 onto the eval stack when removing the delegate.
982 2005-03-12 Joe Shaw <joeshaw@novell.com>
984 * mono/dbus-sharp.dll.config.in: Don't hardcode 0 for
985 LT_CURRENT. Set it to the autoconf variable.
987 * mono/ProxyBuilder.cs: Add a finalizer to the generated proxy
988 classes that disconnects the signal handler delegate from the
989 service object. Fixes a big leak of proxy objects on the
990 client side of things. Patch from Ben Maurer
993 2005-03-12 Colin Walters <walters@verbum.org>
995 * bus/driver.c (write_args_for_direction): New function,
996 parses a type signature into arguments and outputs to
998 (bus_driver_handle_introspect): Use it instead of
999 hardcoding XML for certain signatures.
1001 * bus/Makefile.am (dbus-bus-introspect.xml): Add
1002 dependency on dbus-daemon.
1004 * glib/dbus-glib-tool.c (main): Parse ignore_unsupported
1005 argument, pass it to dbus_binding_tool_output_glib_client.
1007 * glib/dbus-binding-tool-glib.c
1008 (generate_client_glue): Protect against multiple inclusion.
1009 (dbus_binding_tool_output_glib_client): Add
1010 G_BEGIN_DECLS/G_END_DECLS.
1012 * glib/dbus-binding-tool-glib.c (compute_client_method_name):
1013 Change to just take iface prefix directly.
1014 (write_formal_parameters): Clarify error message.
1015 (check_supported_parameters): New function; checks to see type
1016 signatures of method parameters are supported.
1017 (generate_client_glue): Handle ignore_unsupported flag.
1018 (dbus_binding_tool_output_glib_client): Handle ignore_unsupported
1021 * glib/Makefile.am (dbus-glib-bindings.h): Pass
1022 --ignore-unsupported by default until glib bindings
1025 2005-03-11 Colin Walters <walters@verbum.org>
1027 * glib/Makefile.am: Generate dbus-glib-bindings.h and
1030 * bus/print-introspect.c: New file; prints introspection
1031 data for a given name and object path.
1033 * bus/run-with-tmp-session-bus.sh: New file, refactored
1034 from test/glib/run-test.sh. Creates a temporary session
1035 bus and runs another program.
1037 * test/glib/run-test.sh: Refactor to invoke
1038 run-with-tmp-session-bus.sh.
1040 * bus/driver.c (bus_driver_handle_introspect): Fix to print new
1041 introspection format. Also change to use DBUS_TYPE_x_AS_STRING
1042 macros instead of hardcoding.
1044 * glib/.cvsignore, bus/.cvsignore, test/glib/.cvsignore: Update.
1046 2005-03-11 Joe Shaw <joeshaw@novell.com>
1048 * dbus/dbus-connection.c (dbus_connection_send_with_reply): Remove
1049 this unref; it doesn't match up evenly in some codepaths.
1050 (_dbus_connection_block_pending_call): Unref at every exitpoint;
1051 this evenly matches with the ref near the top of this function.
1053 2005-03-09 Joe Shaw <joeshaw@novell.com>
1055 * dbus/dbus-object-tree.c
1056 (_dbus_object_tree_unregister_and_unlock): If checks are enabled
1057 and we try to unregister a path that's not registered, still go
1058 through the process of unlocking and don't just return.
1060 2005-03-09 Colin Walters <walters@verbum.org>
1062 * glib/dbus-gproxy.c (dbus_g_proxy_invoke): New method; calls
1063 to this are generated for client-side wrappers. Invokes a
1064 D-BUS method and returns reply values.
1066 * glib/dbus-binding-tool-glib.c (write_args_sig_for_direction): New
1067 function; writes signature string for argument direction.
1068 (write_args_for_direction): Change to pass input values directly
1069 instead of via address, and fix indentation.
1070 (generate_client_glue): Change to invoke dbus_g_proxy_invoke. Also
1071 make generated wrappers inlineable.
1073 * dbus/dbus-message.c (dbus_message_iter_get_fixed_array): Add
1074 note about using dbus_type_is_fixed.
1076 * dbus/dbus-marshal-basic.c (_dbus_type_is_fixed): Moved to
1077 dbus/dbus-signature.c as dbus_type_is_fixed.
1079 All callers updated.
1081 * dbus/dbus-signature.c (dbus_type_is_fixed): Moved here
1082 from dbus/dbus-marshal-basic.c:_dbus_type_is_fixed.
1084 * dbus/dbus-signature.h: Prototype.
1086 * glib/dbus-binding-tool-glib.c (compute_marshaller_name): Fix
1089 * test/glib/test-dbus-glib.c (main): Be sure to clear error as
1090 appropriate instead of just freeing it.
1091 (main): Free returned strings using g_free.
1093 * test/glib/Makefile.am (test-service-glib-glue.h)
1094 (test-service-glib-bindings.h): Add dependency on dbus-binding-tool.
1096 * glib/dbus-gvalue.c (MAP_BASIC): Refactored from MAP_BASIC_INIT;
1097 simply maps a simple D-BUS type to GType.
1098 (dbus_dbus_type_to_gtype): Function which maps D-BUS type to
1100 (dbus_gvalue_init): Just invoke dbus_dbus_type_to_gtype and
1101 initialize the value with it.
1102 (dbus_gvalue_binding_type_from_type): Unused, delete.
1103 (dbus_gvalue_demarshal): Switch to hardcoding demarshalling for
1104 various types instead of unmarshalling to value data directly.
1105 Remove can_convert boolean.
1106 (dbus_gvalue_marshal): Remove duplicate initialization; switch to
1107 returning directly instead of using can_convert boolean.
1108 (dbus_gvalue_store): New function; not related to D-BUS per-se.
1109 Stores a GValue in a pointer to a value of its corresponding C
1112 * glib/dbus-gvalue.h: Remove dbus_gvalue_binding_type_from_type,
1113 add dbus_gvalue_store.
1115 2005-03-08 Joe Shaw <joeshaw@novell.com>
1117 Fix a bunch of lifecycle and memory management problems
1118 in the mono bindings.
1120 * mono/Arguments.cs (Arguments): Implement IDisposable
1122 * mono/Bus.cs (Bus): Don't allow public instantiation. This is
1123 strictly a static class.
1125 * mono/Connection.cs: Move the DBusObjectPathVTable and associated
1126 delegates into this file.
1127 (Connection): Implement IDisposable.
1128 (Dispose): Disconnect the connection and set the raw connection
1129 pointer to IntPtr.Zero.
1130 (~Connection): Call Dispose().
1131 (RegisterObjectPath): Added. Manages the registration of object
1132 paths so we can cleanly disconnect them at dispose/finalize time.
1133 (UnregisterObjectPath): Ditto.
1134 (set_RawConnection): Unregister all of the object paths when
1135 changing the underlying DBusConnection. Add them back onto the
1136 new connection, if any.
1138 * mono/Handler.cs: Don't implement IDisposable; it doesn't use any
1139 more unmanaged resources anymore, so it's not necessary. Move all
1140 the DBusObjectPathVTable stuff out of here.
1141 (Handler): Save references to our delegates so that they don't get
1142 finalized. Call Connection.RegisterObjectPath() instead of
1143 dbus_connection_register_object_path() directly.
1144 (Message_Called): Dispose the message after we're finished with
1147 * mono/Message.cs (Message): Implement IDisposable.
1148 (Dispose): Dispose the Arguments, and set the RawMessage to
1150 (SendWithReplyAndBlock): We own the ref to the reply that comes
1151 back from dbus_connection_send_with_reply_and_block() so add a
1152 comment about that and unref it after we've constructed a managed
1153 MethodReturn class around it. Fixes a big, big leak.
1155 * mono/ProxyBuilder.cs: Reflect into Message to get the Dispose
1157 (BuildSignalHandler): After we've sent the Signal message, dispose
1159 (BuildMethod): Dispose of the method call and reply messages after
1160 we've sent the message and extracted the data we want from the
1163 * mono/Service.cs (UnregisterObject): Don't call handler.Dispose()
1165 (Service_FilterCalled): Dispose of the message after we're
1168 2005-03-08 Joe Shaw <joeshaw@novell.com>
1170 * dbus/dbus-connection.c (dbus_connection_send_with_reply):
1171 After we attach our pending call to the connection, unref
1174 * mono/Connection.cs (set_RawConnection): Disconnect our
1175 filter and match callbacks from the old connection and
1176 reconnect them to the new connection, if any.
1178 * mono/DBusType/Array.cs: "Code" is a static member, so
1179 don't use "this" to refer to it. Fix for stricter checking
1182 * mono/DBusType/ObjectPath.cs (Append): Don't leak the
1183 object path that we pass into unmanaged code.
1185 * mono/DBusType/String.cs (Append): Don't leak the string
1186 that we pass into unmanged code.
1188 2005-03-07 John (J5) Palmieri <johnp@redhat.com>
1189 * NEWS: Update for 0.31
1191 * configure.in: Release 0.31
1192 add LT_CURRENT, LT_REVISION, LT_AGE for easy soname bumping
1194 * qt/Makefile.am: fixed build
1196 * dbus/Makefile.am: soname bump for libdbus
1198 * glib/Makefile.am: soname bump for libdbus-glib
1200 2005-03-05 Havoc Pennington <hp@redhat.com>
1202 * dbus/dbus-sysdeps.c:
1203 (pseudorandom_generate_random_bytes_buffer): fix to have no return
1205 (_dbus_generate_random_bytes_buffer): fix return value
1207 * dbus/dbus-sysdeps-util.c: s/GETPWNAME/GETPWNAM/ so configure
1208 checks actually work, from Tom Parker <fdo@tevp.net>
1210 2005-03-01 Colin Walters <walters@verbum.org>
1212 * test/glib/test-dbus-glib.c (lose, lose_gerror): Utility
1213 functions copied from dbus-glib-tool.c.
1214 (main): Convert lots of error code to use them.
1215 Also add some testing for introspection bits.
1217 2005-03-01 Colin Walters <walters@verbum.org>
1219 * doc/TODO: Remove introspection signature TODO.
1221 2005-02-27 Colin Walters <walters@verbum.org>
1223 * glib/dbus-gidl.c (property_info_get_type, arg_info_get_type):
1224 Change return value to const char * instead of int so we can do
1226 (struct PropertyInfo, struct ArgInfo): Store char *.
1227 (property_info_new, arg_info_new): Update parameters, strdup.
1228 (property_info_unref, arg_info_unref): Free.
1230 * glib/dbus-gidl.h: Update prototypes.
1232 * glib/dbus-gparser.c (basic_type_from_string): Delete.
1233 (validate_signature): New function, just validates signature and
1235 (parse_property, parse_arg): Invoke validate_signature. Store
1236 signature instead of just type code.
1238 * glib/dbus-gvalue.c (base_type_from_signature): New utility
1239 function to return a primary type for a signature, dropping
1240 information about types in container types.
1241 (dbus_gvalue_genmarshal_name_from_type)
1242 (dbus_gvalue_binding_type_from_type)
1243 (dbus_gvalue_ctype_from_type): Update to take full signature
1244 instead of type code.
1245 (dbus_gtype_to_dbus_type): Moved here from glib/dbus-gobject.c.
1247 * glib/dbus-gvalue.h: Update prototypes for above.
1249 * glib/dbus-gobject.c (gtype_to_dbus_type): Moved to
1250 glib/dbus-gvalue.c as dbus_gtype_to_dbus_type.
1251 (introspect_properties, introspect_signals, write_interface):
1252 Update to handle signatures, and remove usage of
1253 _dbus_gutils_type_to_string.
1254 (handle_introspect): Print out type codes instead of e.g. "string"
1255 in hardcoded introspection XML; also use x_AS_STRING constants
1256 instead of hardcoding in string.
1258 * glib/dbus-glib-tool.c (pretty_print): Handle signature change
1259 to string. Remove usage of _dbus_gutils_type_to_string.
1261 * glib/dbus-gutils.c (_dbus_gutils_type_to_string): Delete.
1263 * glib/dbus-gutils.h (_dbus_gutils_type_to_string): Update for
1266 * glib/dbus-binding-tool-glib.c (compute_marshaller)
1267 (compute_marshaller_name, generate_glue): Handle signature change
1269 (write_formal_parameters, write_args_for_direction): Ditto, and
1272 * tools/dbus-tree-view.c (type_to_string): Delete.
1273 (info_set_func_text): Update to print full signatures.
1275 * test/glib/test-service-glib.xml: Change types to new
1276 introspection format.
1278 2005-02-26 Havoc Pennington <hp@redhat.com>
1280 * doc/TODO: remove the "guid" item
1282 * test/glib/test-profile.c (no_bus_thread_func): use open_private
1283 (with_bus_thread_func): use open_private
1285 * dbus/dbus-connection.c (dbus_connection_open_private): new
1286 function that works like the old dbus_connection_open()
1287 (dbus_connection_open): now returns an existing connection if
1290 * dbus/dbus-server-unix.c (handle_new_client_fd_and_unlock): pass
1291 through the GUID to the transport
1293 * dbus/dbus-server.c (_dbus_server_init_base): keep around the
1294 GUID in hex-encoded form.
1296 * dbus/dbus-server-debug-pipe.c (_dbus_transport_debug_pipe_new):
1297 pass GUID argument in to the transport
1299 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_fd): add
1302 * dbus/dbus-transport.c (_dbus_transport_init_base): add guid argument
1304 * dbus/dbus-auth.c (_dbus_auth_server_new): add guid argument
1306 2005-02-25 Havoc Pennington <hp@redhat.com>
1308 * doc/dbus-specification.xml: document the GUID thing
1310 * dbus/dbus-server.c (_dbus_server_init_base): initialize a
1311 globally unique ID for the server, and put a "guid=hexencoded"
1312 field in the address
1314 * dbus/dbus-bus.c: fix missing #include of dbus-threads-internal.h
1316 * dbus/dbus-message.c: ditto
1318 * dbus/dbus-dataslot.c: ditto
1320 * dbus/dbus-list.c: ditto
1322 * dbus/dbus-internals.h: wait, just include
1323 dbus-threads-internal.h here
1325 * dbus/dbus-string.c (_dbus_string_copy_to_buffer): move back for
1328 * dbus/dbus-sysdeps.c (_dbus_generate_random_bytes_buffer): new function
1330 2005-02-24 Colin Walters <walters@verbum.org>
1332 * test/glib/Makefile.am (EXTRA_DIST): Add test-service-glib.xml
1334 2005-02-24 John (J5) Palmieir <johnp@redhat.com>
1336 * glib/Makefile.am: added dbus-gobject.h to sources list
1337 so distcheck doesn't fail
1339 2005-02-24 Havoc Pennington <hp@redhat.com>
1341 * dbus/dbus-server.c, dbus/dbus-server-unix.c: change semantics so
1342 you must disconnect before unref, since locking and other things
1343 are screwed up otherwise. Fix assorted other locking stuff.
1345 * dbus/dbus-signature.c (dbus_signature_iter_get_element_type):
1348 * dbus/dbus-threads-internal.h: move the mutex/condvar wrappers
1349 into a private header and don't export from the library
1351 * throughout - call _dbus_thread_stuff vs. dbus_thread_stuff
1353 2005-02-24 Colin Walters <walters@verbum.org>
1355 * dbus/dbus-signature.c: New file; implements various functions
1356 related to type signatures. Includes an interator for parsing,
1357 validation functions.
1358 (dbus_type_is_basic): Moved here from
1359 dbus-marshal-basic.c:_dbus_type_is_basic.
1360 (dbus_type_is_container): Moved here from
1361 dbus-marshal-basic.c:_dbus_type_is_container.
1363 All callers of _dbus_type_is_container and _dbus_type_is_basic
1364 updated, and include dbus-signature.h.
1366 * dbus/dbus-signature.h: New file; prototypes for the above.
1368 * dbus/Makefile.am (DBUS_LIB_SOURCES): Add dbus-signature.c,
1371 * dbus/dbus-marshal-basic.c (map_type_char_to_type): New utility
1372 function factored out of _dbus_first_type_in_signature.
1373 (_dbus_first_type_in_signature_c_str): New function; returns first
1374 type code for a type signature character.
1376 * dbus/dbus-marshal-basic.h: Prototype _dbus_first_type_in_signature_c_str,
1377 handle function moves.
1379 * dbus/dbus-marshal-recursive.h: Export _dbus_type_signature_next.
1381 * dbus/dbus-marshal-recursive.c (_dbus_type_signature_next): New
1382 function; skips to next complete type in type signature.
1383 Implemented using previous skip_one_complete_type. Now
1384 skip_one_complete_type just delegates to
1385 _dbus_type_signature_next.
1387 * dbus/dbus-marshal-basic.c (_dbus_type_is_basic): Moved
1389 (_dbus_type_is_container): Ditto.
1391 * doc/dbus-specification.xml: Update introspection sample to
1392 use real type signatures.
1394 * dbus/dbus-test.h: Prototype signature test.
1396 * dbus/dbus-test.c (dbus_internal_do_not_use_run_tests): Run
1399 * dbus/dbus-protocol.h (DBUS_ERROR_INVALID_SIGNATURE): New error.
1401 2005-02-23 John (J5) Palmieri <johnp@redhat.com>
1403 * python/dbus_bindings.pyx.in (PendingCall::get_reply):
1404 s/dbus_pending_call_get_reply/dbus_pending_call_steal_reply
1406 2005-02-21 Colin Walters <walters@verbum.org>
1408 * dbus/dbus-test-main.c (main): Take optional specific test
1411 * dbus/dbus-test.c (run_test): New function, runs a test function
1412 with no data directory.
1413 (run_data_test): Like above, but takes data directory.
1414 (dbus_internal_do_not_use_run_tests): Take
1415 specific test argument. Replace lots of cut n' paste code
1416 with run_test and run_data_test.
1418 * dbus/dbus-test.h: Update prototype for
1419 dbus_internal_do_not_use_run_tests.
1421 2005-02-20 Havoc Pennington <hp@redhat.com>
1423 Fix bugs reported by Daniel P. Berrange
1425 * dbus/dbus-server.c (_dbus_server_unref_unlocked): new function
1426 (protected_change_watch): new function
1427 (_dbus_server_toggle_watch, _dbus_server_remove_watch)
1428 (_dbus_server_add_watch): change to work like the
1429 dbus-connection.c equivalents; like those, probably kind of
1430 busted, but should at least mostly work for now
1431 (dbus_server_disconnect): drop the lock if we were already
1432 disconnected, patch from Daniel P. Berrange
1434 * dbus/dbus-server.c (_dbus_server_toggle_timeout)
1435 (_dbus_server_remove_timeout, _dbus_server_add_timeout): all the
1438 * doc/TODO: todo about unscrewing this mess
1440 2005-02-19 Colin Walters <walters@verbum.org>
1442 * glib/dbus-binding-tool-glib.c
1443 (dbus_binding_tool_output_glib_server): Fix iochannel refcounting.
1445 * glib/dbus-glib-tool.c: Include dbus-glib-tool.h, as well
1446 as errno.h and sys/stat.h.
1447 (lose): New function, prints error with
1449 (lose_gerror): Similar, but takes GError for message.
1450 (main): Add --output argument to specify output file to write to,
1451 instead of always printing to stdout. In this mode, determine
1452 timestamps on source files to see whether any are newer than the
1453 target file. If not, exit. Also convert a number of error
1454 messages to use lose (since it's shorter), and switch to using
1455 g_io_channel_shutdown.
1457 2005-02-19 Havoc Pennington <hp@redhat.com>
1459 * glib/dbus-gobject.c
1460 (_dbus_glib_marshal_dbus_message_to_gvalue_array): add docs
1462 * glib/dbus-glib.c: fix doxygen warnings
1464 * glib/dbus-gparser.c (parse_annotation): error if an annotation
1465 is found on an <arg>
1467 2005-02-17 Colin Walters <walters@verbum.org>
1469 * glib/dbus-gobject.h: Don't export
1470 _dbus_glib_marshal_dbus_message_to_gvalue_array.
1472 * glib/dbus-gobject.c (_dbus_glib_marshal_dbus_message_to_gvalue_array): Do rename.
1473 (invoke_object_method): Handle it.
1475 * glib/dbus-gproxy.c (marshal_dbus_message_to_g_marshaller):
1478 2005-02-17 Colin Walters <walters@verbum.org>
1480 * bus/.cvsignore, doc/.cvsignore
1481 * test/data/valid-service-files/.cvsignore, test/glib/.cvsignore:
1484 2005-02-17 Colin Walters <walters@verbum.org>
1486 * dbus/dbus-protocol.h (DBUS_SERVICE_ORG_FREEDESKTOP_DBUS):
1487 Rename to DBUS_SERVICE_DBUS.
1488 (DBUS_PATH_ORG_FREEDESKTOP_DBUS): Rename to DBUS_PATH_DBUS.
1489 (DBUS_PATH_ORG_FREEDESKTOP_LOCAL): Rename to DBUS_PATH_LOCAL.
1490 Change the value from "org.freedesktop.Local"
1491 to "org.freedesktop.DBus.Local".
1492 (DBUS_INTERFACE_ORG_FREEDESKTOP_DBUS): Rename to DBUS_INTERFACE_DBUS.
1493 (DBUS_INTERFACE_ORG_FREEDESKTOP_INTROSPECTABLE): Rename to
1494 DBUS_INTERFACE_INTROSPECTABLE.
1495 Change the value from "org.freedesktop.Introspectable"
1496 to "org.freedesktop.DBus.Introspectable".
1497 (DBUS_INTERFACE_ORG_FREEDESKTOP_PROPERTIES): Rename to
1498 DBUS_INTERFACE_PROPERTIES.
1499 Change the value from "org.freedesktop.Properties"
1500 to "org.freedesktop.DBus.Properties".
1501 (DBUS_INTERFACE_ORG_FREEDESKTOP_PEER): Rename to
1502 DBUS_INTERFACE_PEER.
1503 Change the value from "org.freedesktop.Peer"
1504 to "org.freedesktop.DBus.Peer".
1505 (DBUS_INTERFACE_ORG_FREEDESKTOP_LOCAL):
1506 DBUS_INTERFACE_LOCAL.
1507 Change the value from "org.freedesktop.Local"
1508 to "org.freedesktop.DBus.Local".
1510 All other users of those constants have been changed.
1512 * bus/driver.c (bus_driver_handle_introspect): Use constants.
1514 * glib/dbus-gobject.c (handle_introspect): Use constants.
1516 * doc/dbus-faq.xml, doc/dbus-specification.xml: Update for rename.
1518 2005-02-17 Colin Walters <walters@verbum.org>
1520 * glib/dbus-gparser.c (struct Parser): Add in_annotation boolean.
1521 (parse_node, parse_interface, parse_method, parse_signal)
1522 (parse_property, parse_annotation): Lose if we're currently in an
1524 (parse_annotation): New function.
1525 (parser_start_element, parser_end_element): Handle annotation.
1526 (parse_method, parse_interface): Remove support for c_name attribute,
1527 switch to annotations.
1529 * glib/dbus-gidl.h (interface_info_get_binding_names)
1530 (method_info_get_binding_names)
1531 (interface_info_get_binding_name, method_info_get_binding_name)
1532 (interface_info_set_binding_name, method_info_set_binding_name):
1534 (interface_info_get_annotations, method_info_get_annotations)
1535 (interface_info_get_annotation, method_info_get_annotation)
1536 (interface_info_add_annotation, method_info_add_annotation):
1539 * glib/dbus-gidl.c (struct InterfaceInfo): Substitute "annotations"
1541 (struct MethodInfo): Ditto.
1542 Straightfoward conversion of binding methods into annotation methods
1545 * glib/dbus-glib-tool.c (pretty_print): Print annotations.
1547 * glib/dbus-binding-tool-glib.h (DBUS_GLIB_ANNOTATION_C_SYMBOL): Define.
1549 * glib/dbus-binding-tool-glib.c (gather_marshallers, generate_glue):
1550 Use new annotation API.
1552 * doc/introspect.dtd: Fix a number of DTD syntax errors. Add
1555 * doc/dbus-specification.xml: Discuss introspection annotations,
1556 include list of well-known annotations.
1558 * test/glib/test-service-glib.xml: Make validate against new DTD.
1560 2005-02-17 Colin Walters <walters@verbum.org>
1562 This patch is based on initial work from
1563 Paul Kuliniewicz <kuliniew@purdue.edu>.
1565 * glib/dbus-gvalue.c (dbus_gvalue_init): New function; move
1566 initialization of GValue from dbus type to here.
1567 (dbus_gvalue_genmarshal_name_from_type): New function; generates a string
1568 for the "glib-genmarshal" program from a DBus type.
1569 (dbus_gvalue_binding_type_from_type): New function; turns a DBus type
1570 into the C name for it we use in the glib bindings.
1571 (dbus_gvalue_ctype_from_type): New function; maps a DBus type into a
1572 glib C type (not GValue).
1573 (dbus_gvalue_demarshal): invoke dbus_gvalue_init.
1575 * glib/dbus-gutils.c (_dbus_gutils_wincaps_to_uscore): Moved here
1576 from dbus-gobject.c.
1578 * glib/dbus-gutils.h: Prototype it.
1580 * glib/dbus-gproxy.c: Include new dbus-gobject.h.
1581 (marshal_dbus_message_to_g_marshaller): Use new shared function
1582 dbus_glib_marshal_dbus_message_to_gvalue_array.
1584 * glib/dbus-gparser.c (parse_interface, parse_method): Handle c_name attribute.
1585 Will be changed once we have annotations.
1587 * glib/dbus-gobject.c: Change info_hash_mutex from GStaticMutex to
1588 GStaticRWLock. Callers updated.
1589 (wincaps_to_uscore): Move to dbus-gutils.c. Callers updated.
1590 (string_table_next): New function for iterating over zero-terminated
1592 (string_table_lookup): New function; retrieves specific entry in
1594 (get_method_data): New function; look up method data in object data chunk.
1595 (object_error_domain_prefix_from_object_info)
1596 (object_error_code_from_object_info): New functions, but not implemented yet.
1597 (method_interface_from_object_info): New function; retrieve interface name.
1598 (method_name_from_object_info): New function; retrieve method name.
1599 (method_arg_info_from_object_info): New function; retrieve argument data.
1600 (arg_iterate): New function; iterates over serialized argument data.
1601 (method_dir_signature_from_object_info): New function; returns a
1602 GString holding type signature for arguments for just one
1603 direction (input or output).
1604 (method_input_signature_from_object_info)
1605 (method_output_signature_from_object_info): New functions.
1606 (dbus_glib_marshal_dbus_message_to_gvalue_array): New shared function;
1607 converts dbus message arguments into a GValue array. Used for both
1608 signal handling and method invocation.
1609 (struct DBusGlibWriteIterfaceData): New utility structure.
1610 (write_interface): New function; generate introspection XML for
1612 (introspect_interfaces): New function; gathers all interface->methods,
1613 generates introspection XML for them.
1614 (handle_introspect): Invoke introspect_interfaces.
1615 (get_object_property): Be sure to zero-initalize stack-allocated GValue.
1616 (lookup_object_and_method): New function; examines an incoming message
1617 and attempts to match it up (via interface, method name, and argument
1618 signature) with a known object and method.
1619 (gerror_domaincode_to_dbus_error_name): New function; converts a
1620 GError domain and code into a DBus error name. Needs GError data
1621 added to object introspection to work well.
1622 (gerror_to_dbus_error_message): Creates a DBusMessage error return from
1624 (invoke_object_method): New function to invoke an object method
1625 looked up via lookup_object_and_method. Parses the incoming
1626 message, turns it into a GValue array, then invokes the marshaller
1627 specified in the DBusGMethodInfo. Creates a new message with
1628 either return values or error message as appropriate.
1629 (gobject_message_function): Invoke lookup_object_and_method and
1630 invoke_object_method.
1632 * glib/dbus-glib-tool.c: Include dbus-binding-tool-glib.h.
1633 (enum DBusBindingOutputMode): New enum for binding output modes.
1634 (pretty_print): Print binding names.
1635 (dbus_binding_tool_error_quark): GError bits.
1636 (version): Fix typo.
1637 (main): Create GIOChannel for output. Parse new --mode argument,
1638 possible values are "pretty-print", "glib-server", "glib-client".
1639 Use mode to invoke appropriate function.
1641 * glib/dbus-gobject.h: Prototype dbus_glib_marshal_dbus_message_to_gvalue_array.
1643 * glib/dbus-glib-tool.h: New header, just includes GError bits
1646 * glib/dbus-gidl.c (struct InterfaceInfo): Add bindings hashtable;
1647 maps binding style to name.
1648 (struct MethodInfo): Ditto.
1649 (get_hash_keys, get_hash_key): Utility function, returns keys for
1651 (interface_info_new, method_info_new): Initialize bindings.
1652 (interface_info_unref, method_info_unref): Destroy bindings.
1653 (method_info_get_binding_names, method_info_get_binding_name)
1654 (interface_info_get_binding_names, interface_info_get_binding_name):
1655 Functions for retrieving binding names.
1656 (method_info_set_binding_name, interface_info_set_binding_name):
1657 Functions for setting binding names.
1659 * glib/dbus-binding-tool-glib.h: New file, has prototypes
1660 for glib binding generation.
1662 * glib/dbus-binding-tool-glib.c: New file, implements server-side
1663 and client-side glib glue generation.
1665 * glib/Makefile.am (dbus_binding_tool_SOURCES): Add
1666 dbus-binding-tool-glib.c, dbus-binding-tool-glib.h,
1669 * dbus/dbus-glib.h (struct DBusGMethodMarshaller): Remove in favor
1670 of using GClosureMarshal directly.
1671 (struct DBusGObjectInfo): Add n_infos member.
1673 * test/glib/test-service-glib.xml: New file; contains introspection data
1674 for MyTestObject used in test-service-glib.c.
1676 * test/glib/test-service-glib.c (enum MyObjectError): New GError enum.
1677 (my_object_do_nothing, my_object_increment, my_object_throw_error)
1678 (my_object_uppercase, my_object_many_args): New test methods.
1679 (main): Use dbus_g_object_class_install_info to include generated object
1682 * test/glib/Makefile.am: Generate server-side glue for test-service-glib.c,
1683 as well as client-side bindings.
1685 * test/glib/test-dbus-glib.c: Include test-service-glib-bindings.h.
1686 (main): Activate TestSuiteGLibService; test invoke a bunch of its methods
1687 using both the dbus_gproxy stuff directly as well as the generated bindings.
1689 2005-02-15 Havoc Pennington <hp@redhat.com>
1691 * dbus/dbus-connection.c (dbus_connection_dispatch): always
1692 complete a pending call, don't run filters first.
1694 * glib/dbus-gproxy.c (dbus_g_proxy_end_call): change to use
1695 dbus_pending_call_steal_reply
1697 * dbus/dbus-pending-call.c (dbus_pending_call_block): just call
1698 _dbus_connection_block_pending_call
1699 (dbus_pending_call_get_reply): change to steal_reply and return a
1702 * dbus/dbus-connection.c
1703 (dbus_connection_send_with_reply_and_block): port to work in terms
1705 (_dbus_connection_block_pending_call): replace block_for_reply
1708 2005-02-14 Havoc Pennington <hp@redhat.com>
1710 * dbus/dbus-userdb-util.c (_dbus_user_database_lookup_group):
1711 properly handle looking up group information by name; fix
1714 2005-02-13 Havoc Pennington <hp@redhat.com>
1716 * dbus/dbus-connection.c (dbus_connection_return_message)
1717 (dbus_connection_borrow_message): hold dispatch lock while message
1719 (_dbus_connection_block_for_reply): hold dispatch lock while we
1720 block for the reply, so nobody steals our reply
1721 (dbus_connection_pop_message): hold the dispatch lock while we
1724 2005-02-13 Havoc Pennington <hp@redhat.com>
1726 * dbus/dbus-connection.c (_dbus_connection_acquire_dispatch)
1727 (_dbus_connection_release_dispatch)
1728 (_dbus_connection_acquire_io_path)
1729 (_dbus_connection_release_io_path): make the mutex and condvar
1730 control access to the "acquired" flag. Drop the connection lock
1731 while waiting on the condvar. Hopefully these are baby steps in
1732 roughly the right direction.
1734 2005-02-13 Havoc Pennington <hp@redhat.com>
1736 * dbus/dbus-connection.c: use separate mutexes for the condition
1737 variables; this is some kind of baseline for sanity, but the
1738 condition variables still aren't used correctly afaict
1740 2005-02-13 Havoc Pennington <hp@redhat.com>
1742 * dbus/dbus-object-tree.c (handle_default_introspect_and_unlock):
1745 * dbus/dbus-connection.c
1746 (_dbus_connection_detach_pending_call_unlocked): add this
1748 Initial semi-correct pass through to fix thread locking; there are
1749 still some issues with the condition variable paths I'm pretty
1752 * dbus/dbus-server.c: add a mutex on DBusServer and appropriate
1755 * dbus/dbus-connection.c (_dbus_connection_do_iteration_unlocked):
1756 rename to add _unlocked
1757 (struct DBusConnection): move "dispatch_acquired" and
1758 "io_path_acquired" to use only one bit each.
1759 (CONNECTION_LOCK, CONNECTION_UNLOCK): add checks with !DBUS_DISABLE_CHECKS
1760 (dbus_connection_set_watch_functions): hacky fix to reentrancy
1761 (_dbus_connection_add_watch, _dbus_connection_remove_watch)
1762 (_dbus_connection_toggle_watch, _dbus_connection_add_timeout)
1763 (_dbus_connection_remove_timeout)
1764 (_dbus_connection_toggle_timeout): drop lock when calling out to
1765 user functions; done in a hacky/bad way.
1766 (_dbus_connection_send_and_unlock): add a missing unlock
1767 (_dbus_connection_block_for_reply): add a missing unlock
1769 * dbus/dbus-transport.c (_dbus_transport_get_is_authenticated):
1770 drop lock in a hacky probably unsafe way to call out to user
1773 2005-02-12 Havoc Pennington <hp@redhat.com>
1775 * tools/dbus-tree-view.c (info_set_func_text): display more
1778 * bus/driver.c (bus_driver_handle_list_services): list the bus
1781 * glib/dbus-gparser.c (parse_arg): generate an arg name if none is supplied
1783 * glib/dbus-gidl.c (signal_info_get_n_args): new function
1784 (method_info_get_n_args): new function
1786 2005-02-12 Havoc Pennington <hp@redhat.com>
1788 * bus/driver.c (bus_driver_handle_introspect): add introspection
1791 2005-02-12 Havoc Pennington <hp@redhat.com>
1793 * bus/driver.c: put the signature of each bus driver method in the
1794 table of handlers and check it on incoming calls; this isn't
1795 really useful, but going to add introspect support in a minute.
1797 2005-02-11 Joe Shaw <joeshaw@novell.com>
1799 * mono/Connection.cs: The unpredictability of finalizers in mono
1800 prevents us from deterministically disconnecting the filters from
1801 the Service class's finalizer, so move tracking of filters and
1802 matches here. Add API for that.
1804 * mono/Service.cs: Remove the code, add code which calls the
1805 methods now on the Connection class.
1807 2005-02-11 John (J5) Palmieri <johnp@redhat.com>
1809 * python/dbus.py (class Sender): added to support dbus signals better
1810 (Bus::add_signal_receiver): added expand_args parameter which defaults
1811 to True. When expand args is True the signal handler will pass the
1812 message arguments as parameters to the signal handler. If False
1813 revert to previous behavior where the signal handler must get the
1814 argument list from the message. This is to help port applications
1815 like HAL that have a tendancy to send variable length argument lists.
1816 self._match_rule_to_receivers is now a dict of dicts.
1817 (Bus::remove_signal_receiver): pop handler off the dict intead of
1818 removing it from a list
1819 (Bus::_signal_func): change signal handlers so that interface,
1820 signal_name, service, path and message are packed into a Sender
1821 object and that is passed to the handler. If expand_args is True
1822 extract the args list from the message and append it to the parameter
1825 * python/dbus_bindings.pyx.in (class Signature): added to support
1827 (MessageIter::__init__): changed iteration limit to match D-BUS
1828 (MessageIter::get*): added INT16, UINT16, SIGNATURE, DICT_ENTRY,
1829 STRUCT and VARIENT type support
1830 (MessageIter::python_value_to_dbus_sig): made recursive to support
1832 (MessageIter::append*): added Signature, dict, tuple
1835 * python/examples/example-client.py: added examples of getting tuples
1838 * python/examples/example-service.py: added examples of sending tuples
1841 * python/examples/example-signal-recipient.py: Fixed to handle new
1842 signal callback format
1844 2005-02-10 Havoc Pennington <hp@redhat.com>
1846 * test/glib/test-dbus-glib.c (main): fix so this test doesn't fail
1847 (call dbus_g_proxy_add_signal)
1849 * dbus/dbus-server-unix.c (_dbus_server_new_for_tcp_socket):
1851 (_dbus_server_new_for_domain_socket): escape the path
1853 * dbus/dbus-address.c (dbus_address_escape_value): new
1854 (dbus_address_unescape_value): new
1855 (dbus_parse_address): unescape values
1857 * dbus/dbus-string.c (_dbus_string_append_byte_as_hex): new function
1859 * doc/dbus-specification.xml: explain how to escape values in
1862 2005-02-10 Havoc Pennington <hp@redhat.com>
1864 * dbus/dbus-message-factory.c (generate_special): modify test to
1865 avoid using a non-basic dict key
1867 * dbus/dbus-marshal-validate-util.c: add test for the below
1869 * doc/dbus-specification.xml: require that dict keys are a basic
1872 * dbus/dbus-marshal-validate.c
1873 (_dbus_validate_signature_with_reason): require that dict key is a
1876 2005-02-10 Havoc Pennington <hp@redhat.com>
1878 * dbus/dbus-object-tree.c (handle_default_introspect_and_unlock):
1879 change to be _and_unlock instead of _unlocked
1881 * dbus/dbus-connection.c
1882 (_dbus_connection_send_preallocated_unlocked_no_update): rename to
1883 have no_update so we can find this bug quickly in future
1885 2005-02-10 Havoc Pennington <hp@redhat.com>
1887 * dbus/dbus-message-util.c (verify_test_message): tests for string
1890 * dbus/dbus-message.c (dbus_message_append_args_valist): add
1891 support for arrays of string/signature/path
1893 2005-02-10 Joe Shaw <joeshaw@novell.com>
1895 * dbus/dbus-connection.c
1896 (_dbus_connection_queue_received_message_link,
1897 _dbus_connection_message_sent): Add the path to
1899 (_dbus_connection_send_preallocated_and_unlock): Added. Calls
1900 _dbus_connection_send_preallocated_unlocked(), updated the
1901 dispatch status, and unlocks. Fixes a bug where certain
1902 situations (like a broken pipe) could cause a Disconnect message
1903 to not be sent, tricking the bus into thinking a service was still
1904 there when the process had quit.
1905 (_dbus_connection_send_preallocated): Call
1906 _dbus_connection_send_preallocated_and_unlock().
1907 (_dbus_connection_send_and_unlock): Added. Calls
1908 _dbus_connection_send_preallocated_and_unlock().
1909 (dbus_connection_send): Call _dbus_connection_send_and_unlock().
1910 (dbus_connection_send_with_reply): Update the dispatch status and
1913 * mono/Service.cs (~Service): Added. Removes the filter so that
1914 we don't get unmanaged code calling back into a GCed delegate.
1915 (RemoveFilter); Added.
1917 2005-02-09 John (J5) Palmieri <johnp@redhat.com>
1919 * dbus/dbus-message.c (dbus_message_iter_open_container):
1920 - Removed check for iterator type being an array because
1921 get_arg_type does not work with writer iterators
1922 - Pass NULL to _dbus_type_writer_recurse if signiture is NULL
1924 2005-02-07 Havoc Pennington <hp@redhat.com>
1926 * doc/dbus-specification.xml: some more language cleanups; add
1927 stuff about how to deal with invalid protocol and extension
1928 points; add _ to allowed chars in auth commands; add EXTENSION_
1931 2005-02-06 Havoc Pennington <hp@redhat.com>
1933 * s/expected/required/ in a couple places for clarity
1935 2005-02-07 Colin Walters <walters@verbum.org>
1937 * bus/selinux.c (bus_selinux_allows_send): Handle NULL for
1938 sender or proposed_recipient.
1940 2005-02-06 Havoc Pennington <hp@redhat.com>
1942 * dbus/dbus-message-factory.c (generate_special): more tests
1944 * dbus/dbus-marshal-validate.c (validate_body_helper): detect
1945 array length that exceeds the maximum
1947 2005-02-05 Havoc Pennington <hp@redhat.com>
1949 * dbus/dbus-message-factory.c (generate_special): more test cases,
1952 * dbus/dbus-marshal-validate.c (validate_body_helper): return the
1953 reason why a signature was invalid
1955 * dbus/dbus-marshal-header.c (load_and_validate_field): fix to
1956 skip the length of the string before we look at it in validation
1958 * dbus/dbus-string-util.c (_dbus_string_test): add tests for
1961 * dbus/dbus-message.c (_dbus_message_loader_new): default
1962 max_message_length to DBUS_MAXIMUM_MESSAGE_LENGTH
1964 2005-02-05 Havoc Pennington <hp@redhat.com>
1966 * dbus/dbus-marshal-validate.c (validate_body_helper): fix crash
1967 if the signature of a variant was empty
1968 (_dbus_validate_signature_with_reason): catch "(a)" (array inside
1969 struct with no element type)
1971 * dbus/dbus-message-factory.c (generate_uint32_changed): add more
1972 mangled messages to break things
1974 2005-02-04 Havoc Pennington <hp@redhat.com>
1976 * glib/dbus-gproxy.c (dbus_g_proxy_disconnect_signal): use
1977 g_quark_try_string() so it actually can return 0
1978 (dbus_g_proxy_connect_signal): ditto
1980 2005-02-04 Havoc Pennington <hp@redhat.com>
1982 * glib/dbus-gproxy.c (dbus_g_proxy_emit_remote_signal): fix a
1984 (tristring_from_message): assert cleanly on null path/interface
1985 (should not be possible though I decided later)
1986 (dbus_g_proxy_dispose): move proxy manager unregistration here
1987 (DBUS_G_PROXY_DESTROYED): add this macro, and use it in a bunch of
1988 g_return_if_fail() checks
1990 2005-02-04 Havoc Pennington <hp@redhat.com>
1992 * doc/Makefile.am (EXTRA_DIST): add DTDs to makefile
1994 * doc/introspect.dtd: add introspect.dtd from David A. Wheeler
1995 (with some minor changes)
1997 * doc/dbus-specification.xml: add deprecated attribute to
1998 introspection format
2000 2005-01-31 Havoc Pennington <hp@redhat.com>
2002 * glib/dbus-gproxy.c: rewrite how signals work again, this time I
2003 think it's sort of right
2005 2005-01-30 Havoc Pennington <hp@redhat.com>
2007 * tools/dbus-viewer.c: kind of half-ass hook up the option menu.
2009 2005-01-30 Havoc Pennington <hp@redhat.com>
2011 * tools/dbus-names-model.c: dynamically watch NameOwnerChanged
2013 * autogen.sh: change to autotools 1.9
2015 * glib/dbus-gproxy.c: completely change how signals work
2016 (dbus_g_proxy_add_signal): new function to specify signature of a
2018 (dbus_g_proxy_emit_received): marshal the dbus message to GValues,
2019 and g_warning if the incoming message has the wrong signature.
2021 2005-01-30 Havoc Pennington <hp@redhat.com>
2023 * tools/dbus-names-model.c (have_names_notify): fix this
2025 * dbus/dbus-message.c (_dbus_message_iter_get_args_valist): clean
2026 up the string array handling a bit
2028 2005-01-30 Havoc Pennington <hp@redhat.com>
2030 * glib/dbus-glib.c (dbus_g_pending_call_set_notify): new function
2031 (dbus_g_pending_call_cancel): new function
2033 * dbus/dbus-glib.h: move GType decls for connection/message here;
2034 * dbus/dbus-glib.c: move all the g_type and ref/unref stuff in
2035 here, just kind of rationalizing how we handle all that
2037 * tools/dbus-names-model.c: new file for a tree model listing the
2040 * tools/dbus-tree-view.c (model_new): use proper typing on the
2043 2005-01-30 Havoc Pennington <hp@redhat.com>
2045 * glib/dbus-gmain.c: add a custom GSource back that just checks
2046 whether the message queue has anything in it; otherwise, there are
2047 cases where we won't see messages in the queue since there was no
2048 IO visible to the glib main loop
2050 * dbus/dbus-connection-internal.h (_DBUS_DEFAULT_TIMEOUT_VALUE):
2051 increase default message timeout to 25 seconds
2053 2005-01-30 Havoc Pennington <hp@redhat.com>
2055 * test/glib/test-profile.c (no_bus_stop_server): remove the
2056 warning about the g_warning that I just fixed
2058 * glib/dbus-gmain.c: rewrite the main loop stuff to avoid the
2059 custom source, seems to be a lot easier to understand and work
2062 2005-01-30 Havoc Pennington <hp@redhat.com>
2064 I think this main loop thing is conceptually broken, but here are
2065 some band aids. I'll maybe rewrite it in a minute.
2067 * glib/dbus-gmain.c (add_timeout): timeout stuff doesn't use the
2068 custom GSource, so don't pass it in; confusing
2069 (gsource_server_finalize, gsource_connection_finalize): add
2070 finalize handlers that remove all the watches.
2072 2005-01-30 Havoc Pennington <hp@redhat.com>
2074 * glib/dbus-gobject.c (introspect_properties): fix the XML
2077 * dbus/dbus-message.c (dbus_message_unref): add an in_cache flag
2078 which effectively detects the use of freed messages
2080 * glib/dbus-gobject.c (handle_introspect): modify and return the
2081 reply message instead of the incoming message
2083 * dbus/dbus-object-tree.c (handle_default_introspect_unlocked):
2084 gee, maybe it should SEND THE XML instead of just making a string
2085 and freeing it again ;-)
2087 * tools/dbus-print-message.c (print_message): improve printing of
2090 * configure.in: add debug-glib.service to the output
2092 2005-01-30 Havoc Pennington <hp@redhat.com>
2094 dbus-viewer introspected and displayed the bus driver
2096 * dbus/dbus-object-tree.c
2097 (object_tree_test_iteration): add tests for a handler registered on "/"
2099 * dbus/dbus-object-tree.c
2100 (_dbus_decompose_path): fix to handle path "/" properly
2101 (run_decompose_tests): add tests for path decomposition
2103 * glib/dbus-gutils.c (_dbus_gutils_split_path): fix to handle "/"
2106 * glib/dbus-gobject.c (handle_introspect): fix quotes
2108 * test/glib/run-test.sh: support launching the bus, then running
2111 * test/glib/test-service-glib.c (main): put in a trivial gobject
2112 subclass and register it on the connection
2114 * bus/driver.c (bus_driver_handle_introspect): implement
2115 introspection of the bus driver service
2117 * dbus/dbus-protocol.h: add #defines for the XML namespace,
2118 identifiers, doctype decl
2120 * bus/driver.c (bus_driver_handle_get_service_owner): handle
2121 attempts to get owner of DBUS_SERVICE_ORG_FREEDESKTOP_DBUS by
2122 returning the service unchanged.
2123 (bus_driver_handle_message): remove old check for reply_serial in
2124 method calls, now the message type deals with that
2125 (bus_driver_handle_message): handle NULL interface
2127 * glib/dbus-gproxy.c (dbus_g_proxy_get_bus_name): new function
2129 * glib/dbus-gloader-expat.c (description_load_from_string): allow
2132 * tools/dbus-viewer.c: add support for introspecting a service on
2135 * glib/dbus-gproxy.c (dbus_g_pending_call_ref): add
2136 (dbus_g_pending_call_unref): add
2138 2005-01-29 Havoc Pennington <hp@redhat.com>
2140 * tools/dbus-tree-view.c: add support for displaying properties.
2141 (run dbus-viewer with an introspect xml file as arg, then resize
2142 the window so the tree elements show up, not sure what that is)
2144 * glib/dbus-gobject.c (handle_introspect): return
2145 org.freedesktop.Properties and org.freedesktop.Introspectable
2146 interfaces when we are introspected.
2148 * doc/dbus-specification.xml: allow empty interface name when
2151 2005-01-29 Havoc Pennington <hp@redhat.com>
2153 * glib/Makefile.am: rename dbus-glib-tool to dbus-binding-tool;
2154 though it uses glib, it could be extended for any binding in
2157 * glib/dbus-gobject.c (gobject_message_function): change to the
2158 new way properties work
2160 * dbus/dbus-protocol.h: add the new interfaces
2162 * doc/dbus-specification.xml: document the introspection format,
2163 Introspectable interface, and add an org.freedesktop.Properties
2166 * glib/dbus-gparser.c: add support for a <property> element
2168 * glib/dbus-gidl.c: add PropertyInfo
2170 * glib/dbus-gobject.c (handle_introspect): put the outermost
2171 <node> outside the signal and property descriptions.
2172 (introspect_properties): export properties as <property> rather
2173 than as method calls
2175 2005-01-28 Havoc Pennington <hp@redhat.com>
2177 * doc/TODO, doc/dbus-specification.xml: spec and TODO tweaks
2178 related to authentication protocol
2180 2005-01-28 John (J5) Palmieri <johnp@redhat.com>
2182 * python/dbus_bindings.pyx.in: Updated to handle new D-BUS type system
2183 - BUS_ACTIVATION -> BUS_STARTER
2184 - DBUS_BUS_ACTIVATION -> DBUS_BUS_STARTER
2185 - class MessageIter (__init__): Added recursion checking
2186 so we throw a nice error instead of just disconnecting from the
2188 (get): Added arg_type parameter for recursion.
2189 Removed the nil type
2190 Added signiture type placeholder (not implemented)
2191 Added struct type placeholder (not implemented)
2192 Added varient type placeholder (not implemented)
2193 Commented out dict type for now
2194 (get_element_type): renamed from get_array_type
2195 (get_*): changed to use the dbus_message_iter_get_basic API
2196 (get_*_array): removed in favor of recursive get_array method
2197 (get_array): new recursive method which calls get to marshal
2198 the elements of the array
2199 (value_to_dbus_sig): New method returns the corrasponding
2200 dbus signiture to a python value
2201 (append): Comment out dict handling for now
2202 Handle lists with the new recursive API
2203 Comment out None handling for now
2204 (append_nil): removed
2205 (append_*): changed to use dbus_message_iter_append_basic API
2206 (append_*_array): removed in favor of recursive append_array
2208 (__str__): Make it easier to print out recursive iterators
2210 - class Message (__str__): moved type inspection to the
2211 MessageIter class' __str__ method
2212 (get_iter): Added an append parameter wich defaults to False
2213 If True use the new API's to create an append iterator
2215 * python/dbus.py: Update to use new bindings API
2216 - TYPE_ACTIVATION -> TYPE_STARTER
2217 - class Bus (_get_match_rule): GetServiceOwner -> GetNameOwner
2218 - class ActivationBus -> class StarterBus
2219 - class RemoteObject (__call__): get an append iterator
2220 - (_dispatch_dbus_method_call): get an append iterator
2221 - class Object (emit_signal): get an append iterator
2223 * python/examples/: Fixed up the examples to work with the new API
2225 2005-01-28 Joe Shaw <joeshaw@novell.com>
2227 * configure.in: Bump version up to 0.30.
2229 * HACKING: Add a release item to bump the version number up after
2232 2005-01-28 Havoc Pennington <hp@redhat.com>
2234 * doc/dbus-specification.xml: update to describe 16-bit types and
2237 * dbus/dbus-marshal-basic.c (_dbus_unpack_uint16): fix broken
2240 * dbus/dbus-protocol.h (DBUS_TYPE_DICT_ENTRY): add DICT_ENTRY as a
2243 * dbus/dbus-marshal-recursive.c: implement
2245 2005-01-27 Havoc Pennington <hp@redhat.com>
2247 * dbus/dbus-arch-deps.h.in: add 16/32-bit types
2249 * configure.in: find the right type for 16 and 32 bit ints as well
2252 * dbus/dbus-protocol.h (DBUS_TYPE_INT16, DBUS_TYPE_UINT16): add
2253 the 16-bit types so people don't have to stuff them in 32-bit or
2256 2005-01-27 Havoc Pennington <hp@redhat.com>
2258 * dbus/dbus-message.c: byteswap the message if you init an
2259 iterator to read/write from it
2261 * dbus/dbus-marshal-byteswap.c: new file implementing
2262 _dbus_marshal_byteswap()
2264 * dbus/dbus-marshal-basic.c: add _dbus_swap_array()
2266 2005-01-26 Havoc Pennington <hp@redhat.com>
2268 * dbus/dbus-marshal-validate-util.c: break this out (and fix
2269 build, apparently - nobody noticed?)
2271 2005-01-26 Havoc Pennington <hp@redhat.com>
2273 * dbus/dbus-marshal-recursive.h: remove todo comment
2275 2005-01-25 Joe Shaw <joeshaw@novell.com>
2277 * Land the mono binding changes to conform to the new APIs.
2279 * mono/Makefile.am: Remove Custom.cs, DBusType/Custom.cs,
2280 DBusType/Dict.cs, and DBusType/Nil.cs from the build.
2282 * mono/Arguments.cs (GetCodeAsString): Added. Returns the dbus
2283 type code as a string.
2284 (InitAppending): Rename dbus_message_append_iter_init() to
2285 dbus_message_iter_init_append().
2287 * mono/BusDriver.cs: Rename ServiceEventHandler to
2288 NameOwnerChangedHandler. Rename GetServiceOwner to GetOwner.
2289 Rename ServiceOwnerChanged to NameOwnerChanged.
2291 * mono/Connection.cs: Rename BaseService to UniqueName, and the
2294 * mono/Custom.cs: Removed. The CUSTOM type has been removed.
2296 * mono/Service.cs: Rename Exists to HasOwner, internally rename
2297 dbus_bus_acquire_service() to dbus_bus_request_name().
2299 * mono/DBusType/Array.cs (ctor): Use Type.GetElementType() instead
2300 of Type.UnderlyingSystemType to get the correct element type for
2302 (ctor): Update code for new APIs: use dbus_message_iter_recurse(),
2303 dbus_message_get_{element|arg}_type() instead of
2304 dbus_message_iter_init_array_iterator().
2305 (Append): Replace dbus_message_iter_append_array() with
2306 dbus_message_iter_open_container() and
2307 dbus_message_iter_close_container().
2309 * mono/DBusType/Custom.cs, mono/DBusType/Nil.cs: Removed. These
2310 types have been removed.
2312 * mono/DBusType/*.cs: Replace calls of
2313 dbus_message_iter_get_[type]() to dbus_message_iter_get_basic(),
2314 but specify the type in the DllImport extern declaration. Ditto
2315 for dbus_message_iter_append_[type]() ->
2316 dbus_message_iter_append_basic().
2318 * mono/example/BusListener.cs: Update for ServiceEventHandler ->
2319 NameOwnerChangedHandler.
2321 2005-01-25 John (J5) Palmieri <johnp@redhat.com>
2323 * python/dbus_bindings.pyx.in: Rename of methods and bindings
2324 - get_base_service -> get_unique_name
2325 - bus_get_base_service -> bus_get_unique_name
2326 - dbus_bus_get_base_service -> dbus_bus_get_unique_name
2327 - ACTIVATION_REPLY_ACTIVATED -> DBUS_START_REPLY_SUCCESS
2328 - ACTIVATION_REPLY_ALREADY_ACTIVE -> DBUS_START_REPLY_ALREADY_RUNNING
2329 - bus_activate_service -> bus_start_service_by_name
2330 - dbus_bus_activate_service -> dbus_bus_start_service_by_name
2331 - bus_acquire_service -> bus_request_name
2332 - dbus_bus_acquire_service -> dbus_bus_request_name
2333 - bus_service_exists -> bus_name_has_owner
2334 - dbus_bus_service_exists -> dbus_bus_name_has_owner
2336 * python/dbus.py: Rename of methods
2337 - activate_service -> start_service_by_name
2338 - bus_acquire_service -> bus_request_name
2339 - ACTIVATION_REPLY_ACTIVATED -> START_REPLY_SUCCESS
2340 - ACTIVATION_REPLY_ALREADY_ACTIVE -> START_REPLY_ALREADY_RUNNING
2343 2005-01-24 Joe Shaw <joeshaw@novell.com>
2345 * dbus/dbus-connection.c (dbus_connection_dispatch): Print out the
2346 signature for the method that can't be found.
2348 * dbus/dbus-message.c (dbus_message_iter_init): To check to see if
2349 the message has any arguments, we need to call
2350 _dbus_type_reader_get_current_type(), not
2351 _dbus_type_reader_has_next().
2353 2005-01-24 Havoc Pennington <hp@redhat.com>
2355 * dbus/dbus-message-factory.c: more testing of message validation
2357 * dbus/dbus-protocol.h (DBUS_MINIMUM_HEADER_SIZE): move to this
2360 2005-01-23 Havoc Pennington <hp@redhat.com>
2362 * dbus/dbus-message-factory.c, dbus/dbus-message-util.c:
2363 get this all working, not many tests in the framework yet though
2365 2005-01-22 Havoc Pennington <hp@redhat.com>
2367 * doc/dbus-faq.xml, doc/dbus-tutorial: add a FAQ and update
2368 tutorial, based on work from David Wheeler.
2370 2005-01-21 Havoc Pennington <hp@redhat.com>
2372 * dbus/dbus-bus.c: add more return_if_fail checks
2374 * dbus/dbus-message.c (load_message): have the "no validation"
2375 mode (have to edit the code to toggle the mode for now though)
2377 * dbus/dbus-marshal-header.c (_dbus_header_load): have a mode that
2378 skips all validation; I want to use this at least for benchmark
2379 baseline, I'm not sure if it should be a publicly-available switch.
2381 2005-01-21 Havoc Pennington <hp@redhat.com>
2383 * glib/dbus-gmain.c: don't put the GLib bindings in the same
2384 toplevel doxygen group as the low-level API stuff
2386 * dbus/dbus.h: note that libdbus is the low-level API
2388 2005-01-20 Havoc Pennington <hp@redhat.com>
2390 * update-dbus-docs.sh: script to update docs on the web site, only
2391 works for me though. neener.
2393 2005-01-20 Havoc Pennington <hp@redhat.com>
2395 * dbus/dbus-sysdeps.c (_dbus_poll): amazingly, trying to compile
2396 code can reveal bugs in it
2398 2005-01-20 Havoc Pennington <hp@redhat.com>
2400 * dbus/dbus-sysdeps.c (_dbus_poll): fix several bugs in the
2401 select() version, patches from Tor Lillqvist
2403 2005-01-20 Havoc Pennington <hp@redhat.com>
2405 * doc/dbus-tutorial.xml: replace > with >
2407 * bus/services.c (bus_registry_acquire_service): validate the name
2408 and return a better error if it's no good.
2410 * doc/dbus-specification.xml: note NO_AUTO_START change
2412 * dbus/dbus-protocol.h (DBUS_HEADER_FLAG_NO_AUTO_START): change
2413 from AUTO_START, we're toggling the default
2415 * bus/dispatch.c: adapt the tests to change of auto-start default
2417 2005-01-18 Havoc Pennington <hp@redhat.com>
2419 * rename dbus-daemon-1 to dbus-daemon throughout
2421 2005-01-18 Havoc Pennington <hp@redhat.com>
2423 * Throughout, grand renaming to strip out the use of "service",
2424 just say "name" instead (or "bus name" when ambiguous). Did not
2425 change the internal code of the message bus itself, only the
2426 programmer-facing API and messages.
2428 * doc/dbus-specification.xml: further update the message bus section
2430 * bus/config-parser.c (all_are_equiv): fix bug using freed string
2433 2005-01-17 Havoc Pennington <hp@redhat.com>
2435 * dbus/dbus-types.h: remove 16-bit types since we don't use them
2438 * dbus/dbus-marshal-validate.c (_dbus_validate_path): disallow any
2439 "invalid name character" not only non-ASCII
2441 * doc/dbus-specification.xml: further update spec, message bus
2442 parts are still out-of-date but the marshaling etc. stuff is now
2445 2005-01-17 Havoc Pennington <hp@redhat.com>
2447 * doc/dbus-specification.xml: partially update spec
2449 2005-01-17 Havoc Pennington <hp@redhat.com>
2451 * Throughout, align variant bodies according to the contained
2452 type, rather than always to 8. Should save a fair bit of space in
2455 * dbus/dbus-marshal-validate.c (_dbus_validate_body_with_reason):
2456 fix handling of case where p == end
2458 * doc/TODO: remove the dbus_bool_t item and variant alignment items
2460 2005-01-17 Havoc Pennington <hp@redhat.com>
2462 * dbus/dbus-types.h: hardcode dbus_bool_t to 32 bits
2464 * Throughout: modify DBUS_TYPE_BOOLEAN to be a 32-bit type instead
2465 of an 8-bit type. Now dbus_bool_t is the type to use whenever you
2466 are marshaling/unmarshaling a boolean.
2468 2005-01-16 Havoc Pennington <hp@redhat.com>
2470 This is about it on what can be disabled/deleted from libdbus
2471 easily, back below 150K anyhow. Deeper cuts are more work than
2472 just turning the code off as I've done here.
2474 * dbus/dbus-marshal-basic.c (_dbus_pack_int32): we don't need the
2475 signed int convenience funcs
2477 * dbus/dbus-internals.c (_dbus_verbose_real): omit when not in
2480 * dbus/dbus-string-util.c, dbus/dbus-string.c: more breaking
2481 things out of libdbus
2483 * dbus/dbus-sysdeps.c, dbus/dbus-sysdeps-util.c: same
2485 * dbus/dbus-hash.c: purge the TWO_STRINGS crap (well, make it
2486 tests-enabled-only, though it should probably be deleted)
2488 * dbus/dbus-message-util.c: same stuff
2490 * dbus/dbus-auth-util.c: same stuff
2492 2005-01-16 Havoc Pennington <hp@redhat.com>
2494 * dbus/dbus-userdb-util.c: split out part of dbus-userdb.c
2496 * dbus/dbus-sysdeps.c (_dbus_uid_from_string): move here to pave
2497 way for stripping down dbus-userdb.c stuff included in libdbus.
2498 Rename _dbus_parse_uid for consistency.
2500 2005-01-16 Havoc Pennington <hp@redhat.com>
2502 * dbus/dbus-internals.c (_dbus_real_assert): print the function
2503 name the assertion failed in
2505 * dbus/dbus-internals.h (_dbus_return_if_fail)
2506 (_dbus_return_val_if_fail): assert that the name of the function
2507 containing the check doesn't start with '_', since we only want to
2508 use checks on public functions
2510 * dbus/dbus-connection.c (_dbus_connection_ref_unlocked): change
2511 checks to assertions
2513 * dbus/dbus-marshal-header.c (_dbus_header_set_field_basic):
2514 change checks to asserts for private function
2516 * dbus/dbus-message.c (_dbus_message_set_serial): checks
2517 to asserts for private function
2519 * dbus/dbus-marshal-recursive.c (skip_one_complete_type): remove
2520 broken assertion that was breaking make check
2521 (_dbus_type_reader_array_is_empty): remove this rather than fix
2522 it, was only used in assertions
2524 2005-01-16 Havoc Pennington <hp@redhat.com>
2526 * test/unused-code-gc.py: hacky script to find code that's used
2527 only by the bus (not libdbus) or used only by tests or not used at
2528 all. It has some false alarms, but looks like we can clean up a
2529 lot of size from libdbus.
2531 * dbus/dbus-sysdeps.c, dbus/dbus-sysdeps-utils.c,
2532 dbus/Makefile.am: initially move 10K of binary size out of libdbus
2534 2005-01-16 Havoc Pennington <hp@redhat.com>
2536 * Add and fix docs according to Doxygen warnings throughout
2539 * dbus/dbus-marshal-recursive.c
2540 (_dbus_type_reader_array_is_empty): change this to just call
2541 array_reader_get_array_len() and make it static
2543 * dbus/dbus-message.c (dbus_message_iter_get_element_type): rename
2545 (dbus_message_iter_init_append): rename from append_iter_init
2547 * dbus/dbus-marshal-recursive.c
2548 (_dbus_type_reader_get_element_type): rename from
2549 _dbus_type_reader_get_array_type
2551 2005-01-15 Havoc Pennington <hp@redhat.com>
2553 * test/glib/test-profile.c (with_bus_server_filter): fix crash
2555 * dbus/dbus-marshal-basic.c (_dbus_unpack_uint32): inline as macro
2556 when DBUS_DISABLE_ASSERT
2557 (_dbus_marshal_set_basic): be sure we align for the string length
2559 * dbus/dbus-marshal-recursive.c (skip_one_complete_type): make
2562 * dbus/dbus-string.c (_dbus_string_get_const_data_len): add an
2563 inline macro version
2564 (_dbus_string_set_byte): provide inline macro version
2566 2005-01-15 Havoc Pennington <hp@redhat.com>
2568 * Land the new message args API and type system.
2570 This patch is huge, but the public API change is not
2571 really large. The set of D-BUS types has changed somewhat,
2572 and the arg "getters" are more geared toward language bindings;
2573 they don't make a copy, etc.
2575 There are also some known issues. See these emails for details
2577 http://lists.freedesktop.org/archives/dbus/2004-December/001836.html
2578 http://lists.freedesktop.org/archives/dbus/2005-January/001922.html
2580 * dbus/dbus-marshal-*: all the new stuff
2582 * dbus/dbus-message.c: basically rewritten
2584 * dbus/dbus-memory.c (check_guards): with "guards" enabled, init
2585 freed blocks to be all non-nul bytes so using freed memory is less
2586 likely to work right
2588 * dbus/dbus-internals.c (_dbus_test_oom_handling): add
2589 DBUS_FAIL_MALLOC=N environment variable, so you can do
2590 DBUS_FAIL_MALLOC=0 to skip the out-of-memory checking, or
2591 DBUS_FAIL_MALLOC=10 to make it really, really, really slow and
2594 * qt/message.cpp: port to the new message args API
2595 (operator<<): use str.utf8() rather than str.unicode()
2596 (pretty sure this is right from the Qt docs?)
2598 * glib/dbus-gvalue.c: port to the new message args API
2600 * bus/dispatch.c, bus/driver.c: port to the new message args API
2602 * dbus/dbus-string.c (_dbus_string_init_const_len): initialize the
2603 "locked" flag to TRUE and align_offset to 0; I guess we never
2604 looked at these anyhow, but seems cleaner.
2606 * dbus/dbus-string.h (_DBUS_STRING_ALLOCATION_PADDING):
2607 move allocation padding macro to this header; use it to implement
2608 (_DBUS_STRING_STATIC): ability to declare a static string.
2610 * dbus/dbus-message.c (_dbus_message_has_type_interface_member):
2611 change to return TRUE if the interface is not set.
2613 * dbus/dbus-string.[hc]: move the D-BUS specific validation stuff
2614 to dbus-marshal-validate.[hc]
2616 * dbus/dbus-marshal-basic.c (_dbus_type_to_string): move here from
2619 * dbus/Makefile.am: cut over from dbus-marshal.[hc]
2620 to dbus-marshal-*.[hc]
2622 * dbus/dbus-object-tree.c (_dbus_decompose_path): move this
2623 function here from dbus-marshal.c
2625 2005-01-12 Joe Shaw <joeshaw@novell.com>
2627 * NEWS: Update for 0.23.
2629 * configure.in: Release 0.23.
2631 2005-01-12 Joe Shaw <joeshaw@novell.com>
2633 * mono/Makefile.am, mono/example/Makefile.am: Always build the
2634 dbus DLL with --debug. Clean up after the .mdb files this leaves
2637 * mono/doc/Makefile.am: Need to uninstall the docs on "make
2640 * mono/Arguments.cs (GetDBusTypeConstructor): If the type
2641 is an enum, get the enum's underlying type. Another mono
2644 2005-01-11 Joe Shaw <joeshaw@novell.com>
2646 Patch from Sjoerd Simons <sjoerd@luon.net>
2648 * mono/Makefile.am, mono/example/Makefile.am: Don't redefine
2649 DESTDIR. It breaks stuff.
2651 2005-01-11 Joe Shaw <joeshaw@novell.com>
2653 Patch from Tambet Ingo <tambet@ximian.com>
2655 * mono/DBusType/Array.cs (Get): Get the underlying element type by
2656 calling type.GetElementType(). The code previously depended on
2657 broken Mono behavior, which was fixed in Mono 1.1.3.
2659 * mono/DBusType/Dict.cs (constructor): Fix the parameters for
2660 Activator.CreateInstance() so that the class's constructor is
2661 called with the right parameters.
2663 2005-01-11 Joe Shaw <joeshaw@novell.com>
2665 Patch from Timo Teräs <ext-timo.teras@nokia.com>
2667 * dbus/dbus-connection.c
2668 (_dbus_connection_queue_received_message_link): Call
2669 _dbus_connection_remove_timeout() instead of the _locked()
2670 variant, since it's always called from
2671 _dbus_connection_handle_watch(), which handles the locking.
2672 Removed the _locked() variant since it's no longer used.
2674 2005-01-03 Havoc Pennington <hp@redhat.com>
2676 * dbus/dbus-internals.h: I'm an idiot, _dbus_assert certainly can
2679 2004-12-26 Havoc Pennington <hp@redhat.com>
2681 * dbus/dbus-internals.h: add _DBUS_GNUC_NORETURN to _dbus_assert
2683 2005-01-03 Havoc Pennington <hp@redhat.com>
2685 * dbus/dbus-sysdeps.c (_dbus_sysdeps_test): fix using == on
2688 * dbus/dbus-string.c (_dbus_string_insert_alignment): new function
2690 2005-01-02 Havoc Pennington <hp@redhat.com>
2692 * dbus/dbus-internals.h (_DBUS_ALIGN_OFFSET): new macro
2694 2005-01-01 Havoc Pennington <hp@redhat.com>
2696 * configure.in: add -Wfloat-equal
2698 2005-01-01 Havoc Pennington <hp@redhat.com>
2700 * dbus/dbus-sysdeps.h: add _DBUS_DOUBLES_BITWISE_EQUAL macro,
2701 for a variety of reasons '==' doesn't do this.
2703 2004-12-31 Havoc Pennington <hp@redhat.com>
2705 * dbus/dbus-string.c (_dbus_string_equal_substrings): new function
2706 I keep wishing I had
2708 2004-12-30 John (J5) Palmieri <johnp@redhat.com>
2710 * python/dbus.py: s/ACTIVATION_REPLY_ACTIVE/ACTIVATION_REPLY_ACTIVATED
2712 2004-12-30 John (J5) Palmieri <johnp@redhat.com>
2714 * python/dbus_bindings.pyx.in: Change DBUS_ACTIVATION_REPLY_ACTIVATED
2715 and DBUS_ACTIVATION_REPLY_ALREADY_ACTIVE to match the values in
2716 dbus-protocol.h. Because they are defines and not enums they are not
2719 2004-12-26 John (J5) Palmieri <johnp@redhat.com>
2721 * python/dbus_bindings.pyx.in (bus_activate_service): Bind
2722 dbus_bus_activate_service
2724 * python/dbus.py (Bus.activate_service): activate a service on the
2727 2004-12-24 Havoc Pennington <hp@redhat.com>
2729 * test/decode-gcov.c: change to use .gcno and .gcda files, but the
2730 file format has also changed and I haven't adapted to that yet
2732 * Makefile.am: load .gcno files from latest gcc
2734 2004-12-23 John (J5) Palmieri <johnp@redhat.com>
2735 * Patch from Rob Taylor <robtaylor@fastmail.fm>
2737 * python/dbus_bindings.pyx.in (bus_get_unix_user): New
2740 * python/dbus.py (get_unix_user): Added binding to
2741 call dbus_bindings.bus_get_unix_user
2743 * python/extract.py: Modified the proto_pat regex to
2744 handle unsigned long
2746 2004-12-21 Olivier Andrieu <oliv__a@users.sourceforge.net>
2748 * dbus/make-dbus-glib-error-enum.sh: omit the function keyword for
2749 better POSIX compliance.
2751 2004-12-19 Havoc Pennington <hp@redhat.com>
2753 * dbus/dbus-string.c (_dbus_string_insert_4_aligned)
2754 (_dbus_string_insert_8_aligned): new functions
2756 * dbus/dbus-string.c (_dbus_string_alloc_space): new function
2758 2004-12-18 Havoc Pennington <hp@redhat.com>
2760 * dbus/dbus-string.c (_dbus_string_validate_ascii): use ISASCII
2763 * dbus/dbus-message.c: fix a comment, and add a still-unused
2764 not-implemented function
2766 * dbus/dbus-marshal.h: fix comment
2768 * dbus/dbus-internals.h (_DBUS_ISASCII): new macro
2770 2004-12-17 Joe Shaw <joeshaw@novell.com>
2772 * mono/DBusType/Byte.cs, mono/DBusType/Int32.cs,
2773 mono/DBusType/Int64.cs, mono/DBusType/UInt32.cs,
2774 mono/DBusType/UInt64.cs: Use Enum.GetUnderlyingType() instead of
2775 Type.UnderlyingSystemType to get the actual system type
2776 underneath. This code previously depended on the broken Mono
2777 behavior, which was fixed in 1.1.3.
2779 2004-11-27 Havoc Pennington <hp@redhat.com>
2781 * dbus/dbus-string.h (_dbus_string_get_byte): inline when asserts
2783 (_dbus_string_get_const_data): inline when asserts are disabled
2785 * dbus/dbus-message.c: record the _dbus_current_generation of
2786 creation so we can complain if dbus_shutdown() is used improperly.
2787 Do this only if checks are enabled.
2789 * dbus/dbus-connection.c: ditto
2791 2004-11-26 Havoc Pennington <hp@redhat.com>
2793 * test/glib/test-profile.c: add with_bus mode to profile echoes
2794 that go through the bus.
2796 * test/glib/run-test.sh: add ability to run test-profile
2798 * bus/dbus-daemon-1.1.in: fix to say that SIGHUP causes partial
2801 2004-11-26 Havoc Pennington <hp@redhat.com>
2803 * test/glib/test-profile.c: clean up how the fake_malloc_overhead
2804 thing was implemented
2806 2004-11-26 Havoc Pennington <hp@redhat.com>
2808 * test/glib/test-profile.c: tweak a bit, add support for some
2809 made-up minimal malloc overhead with plain sockets, since in
2810 real life some sort of buffers are unavoidable thus we could
2811 count them in the theoretical best case
2813 2004-11-26 Havoc Pennington <hp@redhat.com>
2815 * dbus/dbus-message.c (dbus_message_cache_or_finalize): fix bug
2816 where I was trying to cache one too many messages
2818 2004-11-26 Havoc Pennington <hp@redhat.com>
2820 * dbus/dbus-message.c: reimplement message cache as an array which
2821 makes the cache about twice as fast and saves maybe 1.5% overall
2823 2004-11-26 Havoc Pennington <hp@redhat.com>
2825 * dbus/dbus-threads.c (init_global_locks): forgot to put the
2826 message cache lock here
2828 2004-11-26 Havoc Pennington <hp@redhat.com>
2830 * dbus/dbus-message.c (struct DBusMessage): put the locked bit and
2831 the "char byte_order" next to each other to save 4 bytes
2832 (dbus_message_new_empty_header): reduce preallocation, since the
2833 message cache should achieve a similar effect
2834 (dbus_message_cache_or_finalize, dbus_message_get_cached): add a
2835 message cache that keeps a few DBusMessage around in a pool,
2836 another 8% speedup or so.
2838 * dbus/dbus-dataslot.c (_dbus_data_slot_list_clear): new function
2840 2004-11-25 Havoc Pennington <hp@redhat.com>
2842 * dbus/dbus-transport-unix.c (unix_do_iteration): if we're going
2843 to write, without reading or blocking, try it before the poll()
2844 and skip the poll() if nothing remains to write. This is about a
2845 3% speedup in the echo client/server
2847 2004-11-25 Havoc Pennington <hp@redhat.com>
2849 The primary change here is to always write() once before adding
2850 the write watch, which gives us about a 10% performance increase.
2852 * dbus/dbus-transport-unix.c: a number of modifications to cope
2853 with removing messages_pending
2854 (check_write_watch): properly handle
2855 DBUS_AUTH_STATE_WAITING_FOR_MEMORY; adapt to removal of
2856 messages_pending stuff
2857 (check_read_watch): properly handle WAITING_FOR_MEMORY and
2859 (unix_handle_watch): after writing, see if the write watch can be
2861 (unix_do_iteration): assert that write_watch/read_watch are
2862 non-NULL rather than testing that they aren't, since they
2863 aren't allowed to be NULL. check_write_watch() at the end so
2864 we add the watch if we did not finish writing (e.g. got EAGAIN)
2866 * dbus/dbus-transport-protected.h: remove messages_pending call,
2867 since it resulted in too much inefficient watch adding/removing;
2868 instead we now require that the transport user does an iteration
2869 after queueing outgoing messages, and after trying the first
2870 write() we add a write watch if we got EAGAIN or exceeded our
2871 max bytes to write per iteration setting
2873 * dbus/dbus-string.c (_dbus_string_validate_signature): add this
2876 * dbus/dbus-server-unix.c (unix_finalize): the socket name was
2877 freed and then accessed, valgrind flagged this bug, fix it
2879 * dbus/dbus-message.c: fix several bugs where HEADER_FIELD_LAST was taken
2880 as the last valid field plus 1, where really it is equal to the
2881 last valid field. Corrects some message corruption issues.
2883 * dbus/dbus-mainloop.c: verbosity changes
2885 * dbus/dbus-keyring.c (_dbus_keyring_new_homedir): handle OOM
2886 instead of aborting in one of the test codepaths
2888 * dbus/dbus-internals.c (_dbus_verbose_real): fix a bug that
2889 caused not printing the pid ever again if a verbose was missing
2890 the newline at the end
2891 (_dbus_header_field_to_string): add HEADER_FIELD_SIGNATURE
2893 * dbus/dbus-connection.c: verbosity changes;
2894 (dbus_connection_has_messages_to_send): new function
2895 (_dbus_connection_message_sent): no longer call transport->messages_pending
2896 (_dbus_connection_send_preallocated_unlocked): do one iteration to
2897 try to write() immediately, so we can avoid the write watch. This
2898 is the core purpose of this patchset
2899 (_dbus_connection_get_dispatch_status_unlocked): if disconnected,
2900 dump the outgoing message queue, so nobody will get confused
2901 trying to send them or thinking stuff is pending to be sent
2903 * bus/test.c: verbosity changes
2905 * bus/driver.c: verbosity/assertion changes
2907 * bus/dispatch.c: a bunch of little tweaks to get it working again
2908 because this patchset changes when/where you need to block.
2910 2004-11-23 Havoc Pennington <hp@redhat.com>
2912 * test/glib/test-profile.c: modify to accept a plain_sockets
2913 argument in which case it will bench plain sockets instead of
2914 libdbus, for comparison purposes.
2916 2004-11-22 Havoc Pennington <hp@redhat.com>
2918 * test/glib/test-profile.c (N_CLIENT_THREADS): run multiple
2919 threads for more time, so sysprof can get a grip on it.
2921 * dbus/dbus-string.c (_dbus_string_validate_utf8): remove
2924 2004-11-13 Havoc Pennington <hp@redhat.com>
2926 * test/glib/test-profile.c: fix this thing up a bit
2928 * dbus/dbus-message.c (dbus_message_new_empty_header): increase
2929 preallocation sizes by a fair bit; not sure if this will be an
2930 overall performance win or not, but it does reduce reallocs.
2932 * dbus/dbus-string.c (set_length, reallocate_for_length): ignore
2933 the test hack that forced constant realloc if asserts are
2934 disabled, so we can profile sanely. Sprinkle in some
2935 _DBUS_UNLIKELY() which are probably pointless, but before I
2936 noticed the real performance problem I put them in.
2937 (_dbus_string_validate_utf8): micro-optimize this thing a little
2938 bit, though callgrind says it didn't help; then special-case
2939 ascii, which did help a lot; then be sure we detect nul bytes as
2940 invalid, which is a bugfix.
2941 (align_length_then_lengthen): add some more _DBUS_UNLIKELY
2942 superstition; use memset to nul the padding instead of a manual
2944 (_dbus_string_get_length): inline this as a
2945 macro; it showed up in the profile because it's used for loop
2948 2004-11-10 Colin Walters <walters@verbum.org>
2950 * dbus/dbus-spawn.c (check_babysit_events): Handle EINTR,
2953 2004-11-09 Colin Walters <walters@verbum.org>
2955 * dbus/dbus-string.c (_dbus_string_get_length): New
2956 function, writes DBusString to C buffer.
2958 * dbus/dbus-string.h: Prototype it.
2960 * dbus/dbus-message.c (dbus_message_type_to_string): New
2961 function, converts message type into C string.
2963 * dbus/dbus-message.h: Prototype it.
2965 * bus/selinux.c (bus_selinux_check): Take source pid,
2966 target pid, and audit data. Pass audit data to
2968 (log_audit_callback): New function, appends extra
2970 (bus_selinux_allows_acquire_service): Also take
2971 service name, add it to audit data.
2972 (bus_selinux_allows_send): Also take message
2973 type, interface, method member, error name,
2974 and destination, and add them to audit data.
2975 (log_cb): Initialize func_audit.
2977 * bus/selinux.h (bus_selinux_allows_acquire_service)
2978 (bus_selinux_allows_send): Update prototypes
2980 * bus/services.c (bus_registry_acquire_service): Pass
2981 service name to bus_selinux_allows_acquire_service.
2983 * bus/bus.c (bus_context_check_security_policy): Pass
2984 additional audit data. Move assignment of dest
2987 2004-11-07 Colin Walters <walters@verbum.org>
2989 * dbus/dbus-transport-unix.c (do_authentication): Always
2990 initialize auth_completed.
2992 2004-11-07 Colin Walters <walters@verbum.org>
2994 * bus/bus.c (load_config): Break into three
2995 separate functions: process_config_first_time_only,
2996 process_config_every_time, and process_config_postinit.
2997 (process_config_every_time): Move call of
2998 bus_registry_set_service_context_table into
2999 process_config_postinit.
3000 (process_config_postinit): New function, does
3001 any processing that needs to happen late
3002 in initialization (and also on reload).
3003 (bus_context_new): Instead of calling load_config,
3004 open config parser here and call process_config_first_time_only
3005 and process_config_every_time directly. Later, after
3006 we have forked but before changing UID,
3007 invoke bus_selinux_full_init, and then call
3008 process_config_postinit.
3009 (bus_context_reload_config): As in bus_context_new,
3010 load parse file inside here, and call process_config_every_time
3011 and process_config_postinit.
3013 * bus/services.h, bus/services.c
3014 (bus_registry_set_service_context_table): Rename
3015 from bus_registry_set_sid_table. Take string hash from config
3016 parser, and convert them here into SIDs.
3018 * bus/config-parser.c (struct BusConfigParser): Have
3019 config parser only store a mapping of service->context
3021 (merge_service_context_hash): New function.
3022 (merge_included): Merge context string hashes instead
3023 of using bus_selinux_id_table_union.
3024 (bus_config_parser_new): Don't use bus_selinux_id_table_new;
3025 simply create a new string hash.
3026 (bus_config_parser_unref): Unref it.
3027 (start_selinux_child): Simply insert strings into hash,
3028 don't call bus_selinux_id_table_copy_over.
3030 * bus/selinux.h, bus/selinux.c (bus_selinux_id_table_union)
3031 (bus_selinux_id_table_copy_over): Delete.
3033 2004-11-03 Colin Walters <walters@verbum.org>
3035 * bus/selinux.c (bus_selinux_pre_init): Kill some unused
3038 2004-11-03 Colin Walters <walters@verbum.org>
3040 * bus/test-main.c (test_pre_hook): Fix test logic,
3041 thanks Joerg Barfurth <Joerg.Barfurth@Sun.COM>.
3043 2004-11-02 Colin Walters <walters@redhat.com>
3045 * bus/selinux.c (bus_selinux_init): Split into two functions,
3046 bus_selinux_pre_init and bus_selinux_post_init.
3047 (bus_selinux_pre_init): Just determine whether SELinux is
3049 (bus_selinux_post_init): Do everything else.
3051 * bus/main.c (main): Call bus_selinux_pre_init before parsing
3052 config file, and bus_selinux_post_init after. This ensures that
3053 we don't lose the policyreload notification thread that
3054 bus_selinux_init created before forking previously.
3056 * bus/test-main.c (test_pre_hook): Update for split.
3058 2004-10-31 Owen Fraser-Green <owen@discobabe.net>
3060 Patch from Johan Fischer <linux@fischaz.com>
3062 * mono/doc/Makefile.am (install-data-local): Added directory
3065 2004-10-29 Colin Walters <walters@redhat.com>
3067 * dbus/dbus-sysdeps.h (_dbus_become_daemon): Also take
3068 parameter for fd to write pid to.
3070 * dbus/dbus-sysdeps.c (_dbus_become_daemon): Implement it.
3072 * bus/bus.c (bus_context_new): Pass print_pid_fd
3073 to _dbus_become_daemon (bug #1720)
3075 2004-10-29 Colin Walters <walters@redhat.com>
3077 Patch from Ed Catmur <ed@catmur.co.uk>
3079 * mono/doc/Makefile.am (install-data-local): Handle
3082 2004-10-29 Colin Walters <walters@redhat.com>
3084 * bus/.cvsignore, qt/.cvsignore: Update.
3086 2004-10-29 Colin Walters <walters@redhat.com>
3088 Patch from Kristof Vansant <de_lupus@pandora.be>
3090 * configure.in: Detect Slackware.
3091 * bus/Makefile.am (SCRIPT_IN_FILES): Add rc.messagebus.in.
3092 * bus/rc.messagebus.in: New file.
3094 2004-10-29 Colin Walters <walters@redhat.com>
3096 * tools/dbus-monitor.c (filter_func): Return
3097 DBUS_HANDLER_RESULT_HANDLED in filter function
3099 http://freedesktop.org/pipermail/dbus/2004-August/001433.html
3101 2004-10-29 Colin Walters <walters@redhat.com>
3103 Patch from Matthew Rickard <mjricka@epoch.ncsc.mil>
3105 * bus/services.c (bus_registry_acquire_service):
3106 Correctly retrieve service name from DBusString
3109 2004-10-29 Colin Walters <walters@redhat.com>
3111 * dbus/dbus-glib.h: Update documentation to not
3112 refer to internal APIs.
3114 2004-10-27 Joe Shaw <joeshaw@novell.com>
3116 * mono/Arguments.cs (GetDBusTypeConstructor):
3117 type.UnderlyingSystemType will return "System.Byte" if you do it
3118 on "byte[]", which is not what we want. So check the type.IsArray
3119 property and use System.Array instead.
3121 2004-10-25 John (J5) Palmieri <johnp@redhat.com>
3123 * dbus/dbus-sysdeps.c (fill_user_info): On errors do not free
3124 the DBusUserInfo structure since this is passed into the function.
3125 This would cause a double free when the function that allocated
3126 the structure would try to free it when an error occured.
3128 * (bus/session.conf.in, bus/Makefile.am, dbus/configure.in):
3129 use /usr/share/dbus-1/services instead of /usr/lib/dbus-1.0/services
3130 for service activation to avoid 32bit/64bit parallel install issues
3132 2004-10-21 Colin Walters <walters@verbum.org>
3134 * AUTHORS: Fix my email address, the @gnu.org one
3135 has been bouncing for some time. Also add J5.
3137 2004-10-21 Colin Walters <walters@verbum.org>
3139 * dbus/dbus-transport-unix.c (do_authentication): Return
3140 authentication status to callers.
3141 (unix_handle_watch): If we completed authentication this round,
3142 don't do another read. Instead wait until the next iteration,
3143 after we've read any pending data in the auth buffer.
3144 (unix_do_iteration): Ditto.
3145 (unix_handle_watch): Updated for new do_authentication prototype.
3147 2004-10-18 Colin Walters <walters@verbum.org>
3149 * bus/selinux.c (bus_selinux_enabled): Handle
3150 --disable-selinux case.
3152 2004-10-18 Colin Walters <walters@verbum.org>
3154 * bus/selinux.h: Add bus_selinux_enabled.
3156 * bus/selinux.c (bus_selinux_enabled): Implement it.
3158 * bus/config-parser.c (struct include): Add
3159 if_selinux_enabled member.
3160 (start_busconfig_child): Parse if_selinux_enabled
3161 attribute for include.
3162 (bus_config_parser_content): Handle it.
3164 * bus/session.conf.in, bus/system.conf.in: Add
3165 inclusion of context mapping to default config files;
3166 conditional on SELinux being enabled.
3168 * doc/busconfig.dtd: Add to if_selinux_enabled to default DTD.
3170 * test/data/invalid-config-files/badselinux-1.conf,
3171 test/data/invalid-config-files/badselinux-2.conf:
3172 Test files for bad syntax.
3174 2004-10-17 Colin Walters <walters@verbum.org>
3176 * dbus/dbus-memory.c (_dbus_initialize_malloc_debug, check_guards)
3177 (dbus_malloc, dbus_malloc0, dbus_realloc): Fix up printf
3178 format specifier mismatches.
3180 2004-10-07 Olivier Andrieu <oliv__a@users.sourceforge.net>
3182 * dbus/dbus-sysdeps.c (_dbus_file_get_contents): fix an incorrect
3185 * glib/dbus-dbus-gmain.c (dbus_g_bus_get): do not mangle NULL
3186 pointer (bug #1540, Leonardo Boiko).
3188 2004-09-28 Jon Trowbridge <trow@ximian.com>
3190 * mono/BusDriver.cs: Changed BusDriver struct to remove
3191 the ServiceCreated and ServiceDeleted events and replace them
3192 with the new ServiceOwnerChanged event.
3194 * mono/example/BusListener.cs: Added a new example program,
3195 which listens for and reports any ServiceOwnerChanged events
3198 * mono/example/Makefile.am (DESTDIR): Build changes for the
3199 new BusListener.cs example.
3201 2004-09-27 Olivier Andrieu <oliv__a@users.sourceforge.net>
3203 * bus/signals.c (bus_match_rule_parse): validate the components of
3204 match rules (bug #1439).
3206 * dbus/dbus-bus.c (dbus_bus_add_match): add a missing OOM test.
3208 2004-09-24 Olivier Andrieu <oliv__a@users.sourceforge.net>
3210 * doc/dbus-specification.xml: document ServiceOwnerChanged
3213 * bus/driver.c, bus/driver.h, bus/services.c: Use
3214 ServiceOwnerChanged signal instead of ServiceCreated and
3217 * bus/dispatch.c: update testcase for the new signal.
3219 2004-09-20 Jon Trowbridge <trow@ximian.com>
3221 Patch from Nat Friedman <nat@novell.com>
3223 * mono/Makefile.am: A number of small build fixes to allow "make
3224 distcheck" to succeed.
3226 * mono/example/Makefile.am: "make distcheck" fixes.
3228 * mono/AssemblyInfo.cs.in: When signing the assembly, look for the
3231 * test/Makefile.am: "make distcheck" fixes.
3233 2004-09-17 Olivier Andrieu <oliv__a@users.sourceforge.net>
3235 * dbus/dbus-sysdeps.c (_dbus_user_at_console): fix memleak in OOM.
3237 * doc/busconfig.dtd: update the DTD for the at_console attribute.
3239 * bus/driver.c (bus_driver_handle_hello): correctly handle Hello
3240 messages after the first one (bug #1389).
3242 * bus/dispatch.c (check_double_hello_message): add a test case for
3243 the double hello message bug.
3244 (check_existent_service_activation): fix check of spawning error.
3246 2004-09-16 David Zeuthen <david@fubar.dk>
3248 * python/dbus_bindings.pyx.in: Add support for int64 and uint64
3250 2004-09-12 David Zeuthen <david@fubar.dk>
3252 Patch from Kay Sievers <kay.sievers@vrfy.org>
3254 * bus/bus.c (bus_context_new):
3256 * bus/main.c (usage)
3258 Add commandline option --nofork to override configuration file
3261 2004-09-09 Olivier Andrieu <oliv__a@users.sourceforge.net>
3263 * dbus/dbus-*.h: remove the ; after DBUS_(BEGIN|END)_DECLS. Some C
3264 compilers don't like it (bug #974).
3266 2004-09-04 Harald Fernengel <harry@kdevelop.org>
3268 * qt/connection.*: Applied patch by Jérôme Lodewyck
3269 <lodewyck@clipper.ens.fr> to integrate an existing
3270 connection into the Qt eventloop
3272 2004-08-30 Jon Trowbridge <trow@ximian.com>
3274 * mono/BusDriver.cs: Added. This is a class for interacting with
3275 the org.freedesktop.DBus service.
3277 * mono/Message.cs: Added a mechanism to expose the message that is
3278 currently being dispatched via the static Message.Current
3279 property. Added Message.Sender and Message.Destination
3282 * mono/Handler.cs: Expose the dispatched message via
3283 Message.Current when handling method calls.
3285 * mono/Service.cs: Expose the dispatched message via
3286 Message.Current when handling signal emissions.
3288 * mono/Connection.cs: Bind dbus_bus_get_base_service via the
3289 Connection.BaseService property.
3291 2004-08-28 Havoc Pennington <hp@redhat.com>
3293 * dbus/dbus-userdb.c (_dbus_is_console_user): remove unused variable
3295 More fixes from Steve Grubb
3297 * dbus/dbus-sysdeps.c (_dbus_connect_tcp_socket): fix fd leak
3298 (_dbus_listen_tcp_socket): fix fd leak
3300 * dbus/dbus-spawn.c (read_pid, read_ints): move the "again:" for
3301 EINTR to a bit lower in the code
3303 2004-08-26 Jon Trowbridge <trow@ximian.com>
3305 * bus/driver.c (bus_driver_handle_service_exists): Respond with
3306 TRUE if we are inquiring about the existence of the built-in
3307 org.freedesktop.DBus service.
3309 2004-08-25 John Palmieri <johnp@redhat.com>
3310 * bus/config-parser.c:
3311 (struct PolicyType): Add POLICY_CONSOLE
3312 (struct Element.d.policy): s/gid_or_uid/gid_uid_or_at_console
3313 (start_busconfig_child): Sets up console element when
3314 <policy at_console=""> is encountered in a policy file
3315 (append_rule_from_element): Convert console elements to console
3319 (bus_policy_create_client_policy): Add console rules to the client
3320 policy based on if the client is at the console
3321 (bus_policy_append_console_rule): New function for adding a
3322 console rule to a policy
3323 (bus_policy_merge): Handle console rule merging
3325 * dbus/dbus-sysdeps.h: Added the DBUS_CONSOLE_DIR constant
3326 where we check for console user files
3328 * dbus/dbus-sysdeps.c:
3329 (_dbus_file_exists): New function which checks if the given
3331 (_dbus_user_at_console): New function which does the system
3332 specific process of checking if the user is at the console
3334 * dbus/dbus-userdb.c:
3335 (_dbus_is_console_user): New function converts a UID to user name
3336 and then calls the system specific _dbus_user_at_console to
3337 see if the user is at the console and therefor a console user
3339 2004-08-25 Olivier Andrieu <oliv__a@users.sourceforge.net>
3341 * bus/config-parser.c (set_limit):
3342 * bus/dbus-daemon-1.1.in:
3343 * test/data/valid-config-files/many-rules.conf: set the
3344 max_match_rules_per_connection limt from the config file.
3346 * doc/busconfig.dtd: update the DTD.
3348 * bus/driver.c: remove some unused variables.
3350 2004-08-24 Mikael Hallendal <micke@imendio.com>
3352 * dbus/dbus-glib-lowlevel.h: Removed dbus_bus_get_with_g_main since
3353 it's been replaced by dbus_g_bus_get
3355 2004-08-23 Colin Walters <walters@redhat.com>
3357 Updated SELinux support from Matthew Rickard <mjricka@epoch.ncsc.mil>
3359 * bus/selinux.h: Prototype bus_selinux_get_policy_root.
3361 * bus/selinux.c: Create a thread for policy reload notification.
3362 (bus_selinux_get_policy_root): Implement.
3364 * bus/config-parser.c (start_busconfig_child)
3365 (bus_config_parser_content): Support SELinux-root relative
3368 * configure.in <HAVE_SELINUX>: Add -lpthread.
3370 * bus/test-main.c (test_pre_hook, test_post_hook): New.
3371 (test_post_hook): Move memory checking into here.
3372 (test_pre_hook, test_post_hook): Move SELinux checks in
3373 here, but conditional on a DBUS_TEST_SELINUX environment
3374 variable. Unfortunately we can't run the SELinux checks
3375 as a normal user, since they won't have any permissions
3376 for /selinux. So this will have to be tested manually
3377 for now, until we have virtualization for most of
3380 2004-08-23 Havoc Pennington <hp@redhat.com>
3382 * dbus/dbus-sysdeps.c (_dbus_change_identity): add setgroups() to
3383 drop supplementary groups, suggested by Steve Grubb
3385 2004-08-20 Colin Walters <walters@redhat.com>
3387 * bus/config-parser.c (start_busconfig_child): Remove some unused
3390 * bus/selinux.c (bus_selinux_id_table_insert): Avoid compiler
3393 2004-08-17 Joe Shaw <joeshaw@novell.com>
3395 * configure.in: If --enable-mono is passed in, if we can't find
3398 * mono/Makefile.am: Use /gacutil to install assemblies into the
3401 2004-08-12 Havoc Pennington <hp@redhat.com>
3403 * NEWS: update for 0.22
3405 * configure.in: release 0.22
3407 2004-08-11 Colin Walters <walters@redhat.com>
3409 * tools/dbus-send.c (main, usage): Add --reply-timeout
3412 2004-08-10 Olivier Andrieu <oliv__a@users.sourceforge.net>
3414 * bus/bus.c (process_config_first_time_only): get rid of an unused
3415 DBusError that was causing a memoy leak (bug #989).
3417 * dbus/dbus-keyring.c, dbus/dbus-message.c:
3418 fix compilation on Solaris/Forte C (bug #974)
3420 * bus/main.c (main): plug two minuscule memleaks.
3422 2004-08-10 Havoc Pennington <hp@redhat.com>
3424 * doc/dbus-tutorial.xml: add some more info on GLib bindings
3426 2004-08-09 Havoc Pennington <hp@redhat.com>
3428 * COPYING: switch to Academic Free License version 2.1 instead of
3429 2.0, to resolve complaints about patent termination clause.
3431 2004-07-31 John (J5) Palmieri <johnp@redhat.com>
3433 * README: added documentation for the --enable-python
3436 2004-07-31 Olivier Andrieu <oliv__a@users.sourceforge.net>
3438 * bus/config-parser.c (bus_config_parser_new): fix an invalid
3439 _unref in the SELinux support.
3441 * doc/busconfig.dtd: update DTD for SELinux support.
3443 * bus/config-loader-libxml.c: fix error handler and parser
3444 initialisation/cleanup. OOM test now works with libxml2 HEAD.
3446 * configure.in: remove the warning about libxml2.
3448 * dbus/dbus-bus.c: silence doxygen warning.
3450 2004-07-31 Colin Walters <walters@redhat.com>
3452 * configure.in: Move #error in SELinux check to its own line.
3454 2004-07-31 Olivier Andrieu <oliv__a@users.sourceforge.net>
3456 * dbus/dbus-internals.h (_DBUS_SET_OOM):
3457 * bus/utils.h (BUS_SET_OOM): use dbus_error_set_const instead of
3460 * bus/dispatch.c (check_send_exit_to_service): fix the test case,
3461 broken by the change in the _SET_OOM macros.
3463 2004-07-31 Colin Walters <walters@redhat.com>
3465 * bus/selinux.c <HAVE_SELINUX>: Include utils.h to get
3468 2004-07-31 Colin Walters <walters@redhat.com>
3470 * configure.in: Use AC_TRY_COMPILE instead of AC_EGREP_HEADER
3471 to correctly detect DBUS__ACQUIRE_SVC. Also add an
3474 2004-07-24 Havoc Pennington <hp@redhat.com>
3476 SELinux support from Matthew Rickard <mjricka@epoch.ncsc.mil>
3478 * bus/selinux.c, bus/selinux.h: new file encapsulating selinux
3481 * configure.in: add --enable-selinux
3483 * bus/policy.c (bus_policy_merge): add FIXME to a comment
3485 * bus/main.c (main): initialize and shut down selinux
3487 * bus/connection.c: store SELinux ID on each connection, to avoid
3488 repeated getting of the string context and converting it into
3491 * bus/bus.c (bus_context_get_policy): new accessor, though it
3493 (bus_context_check_security_policy): check whether the security
3494 context of sender connection can send to the security context of
3495 recipient connection
3497 * bus/config-parser.c: add parsing for <selinux> and <associate>
3499 * dbus/dbus-transport.c (_dbus_transport_get_unix_fd): to
3500 implement dbus_connection_get_unix_fd()
3502 * dbus/dbus-connection.c (dbus_connection_get_unix_fd): new
3503 function, used by the selinux stuff
3505 2004-07-29 Olivier Andrieu <oliv__a@users.sourceforge.net>
3507 * bus/config-loader-libxml.c: complete the implementation of
3508 libxml backend for config file loader. Doesn't work with full OOM
3511 * configure.in: change error when selecting libxml into a warning.
3513 * test/data/invalid-config-files: add two non-well-formed XML
3516 * glib/Makefile.am: libdbus_gtool always uses expat, not libxml.
3518 * dbus/dbus-transport-unix.c (unix_handle_watch): do not
3519 disconnect in case of DBUS_WATCH_HANGUP, several do_reading() may
3520 be necessary to read all the buffer. (bug #894)
3522 * bus/activation.c (bus_activation_activate_service): fix a
3523 potential assertion failure (bug #896). Small optimization in the
3524 case of auto-activation messages.
3526 * dbus/dbus-message.c (verify_test_message, _dbus_message_test):
3527 add test case for byte-through-vararg bug (#901). patch by Kimmo
3530 2004-07-28 Anders Carlsson <andersca@gnome.org>
3533 * python/dbus_bindings.pyx.in:
3534 Add dbus.init_gthreads (), allow emit_signal to pass
3535 arguments to the signal.
3537 2004-07-24 Havoc Pennington <hp@redhat.com>
3539 * AUTHORS: add some people, not really comprehensively, let me
3540 know if I missed you
3542 2004-07-24 Havoc Pennington <hp@redhat.com>
3544 * Makefile.am (DIST_SUBDIRS): add DIST_SUBDIRS, problem solved by
3547 * test/Makefile.am (DIST_SUBDIRS): here also
3549 2004-07-22 Olivier Andrieu <oliv__a@users.sourceforge.net>
3551 * dbus/dbus-sysdeps.c (fill_user_info): fix inexistent label name,
3552 breaking build on Solaris, reported by Farhad Saberi on the ML.
3554 * dbus/dbus-message.c (dbus_message_append_args_valist): fix the
3555 va_arg invocation to account for integer promotion in the case of
3556 DBUS_TYPE_BYTE (unsigned char is promoted to int). (bug #901)
3558 * bus/services.c (bus_service_remove_owner): fix bug #902, use
3559 _dbus_list_get_first_link, not _dbus_list_get_first.
3561 * dbus/dbus-bus.c (dbus_bus_service_exists): plug a memory leak.
3563 * dbus/dbus-object-tree.c (free_subtree_recurse): always null
3564 handler functions so that the asserts in _dbus_object_subtree_unref
3567 * dbus/dbus-transport-unix.c (do_reading):
3568 _dbus_transport_queue_messages return value is of type
3569 dbus_bool_t, not DBusDispatchStatus.
3571 2004-07-19 David Zeuthen <david@fubar.dk>
3573 * dbus/dbus-protocol.h: Add DBUS_ERROR_UNIX_PROCESS_ID_UNKNOWN
3576 (check_get_connection_unix_user): Debug says GetProperty; but the
3577 method is called GetConnectionUnixUser
3578 (check_get_connection_unix_process_id): New function
3579 (bus_dispatch_test): Actually call check_get_connection_unix_user();
3580 also call check_get_connection_unix_process_id()
3583 (bus_driver_handle_get_connection_unix_process_id): New function,
3584 handles GetConnectionUnixProcessID on the org.freedesktop.DBus
3588 (handle_server_data_external_mech): Set pid from the credentials
3589 obtained from the socket
3591 * dbus/dbus-connection.c:
3592 (dbus_connection_get_unix_process_id): New function
3594 * dbus/dbus-connection.h:
3595 Add prototype for dbus_connection_get_unix_process_id
3597 * dbus/dbus-transport.c:
3598 (_dbus_transport_get_unix_process_id): New function
3600 * dbus/dbus-transport.h:
3601 Add prototype for _dbus_transport_get_unix_process_id
3603 2004-07-19 Olivier Andrieu <oliv__a@users.sourceforge.net>
3605 * dbus/dbus-message.c: Message counter fix, patch by Christian
3606 Hammond <chipx86@gnupdate.org>
3608 2004-07-18 Seth Nickell <seth@gnome.org>
3611 * python/dbus_bindings.pyx.in:
3612 * python/tests/test-client.py:
3614 Add dbus.ByteArray and dbus_bindings.ByteArray
3615 types so that byte streams can be passed back.
3617 Give jdahlin the heaps of credit that are so
3620 2004-07-12 Seth Nickell <seth@gnome.org>
3624 Add message argument to the default object_method_handler
3627 * python/dbus_bindings.pyx.in:
3629 Automatically return NIL when passed an empty list
3630 (we can't pass back a list since lists are typed
3631 and we don't have any idea what type the the client
3632 intended the list to be... :-( )
3634 2004-07-10 Seth Nickell <seth@gnome.org>
3636 * python/examples/Makefile.am:
3638 Fix distcheck breakage caused by new examples.
3640 2004-07-10 Seth Nickell <seth@gnome.org>
3644 Add "message" argument to service-side dbus.Object
3645 methods. This will break existing services written
3646 using the python bindings, but will allow extraction
3647 of all the message information (e.g. who its from).
3649 Add improved "object oriented" signal handling/emission.
3651 * python/examples/example-service.py:
3655 * python/examples/example-signal-emitter.py:
3656 * python/examples/example-signal-recipient.py:
3658 Two new examples that show how to emit and receive
3659 signals using the new APIs.
3661 * python/examples/example-signals.py:
3662 * python/examples/gconf-proxy-service.py:
3663 * python/examples/gconf-proxy-service2.py:
3665 Add "message" argument to service methods.
3667 2004-06-28 Kay Sievers <kay.sievers@vrfy.org>
3669 * bus/driver.c (bus_driver_handle_get_connection_unix_user)
3670 * dbus/bus.c (dbus_bus_get_unix_user)
3671 * doc/dbus-specification.xml: implement GetConnectionUnixUser
3672 method of org.freedesktop.DBus interface.
3674 * bus/dispatch.c: test case
3676 2004-06-23 John (J5) Palmieri <johnp@redhat.com>
3678 * python/Makefile.am: switched include directory from glib/ to dbus/
3679 since dbus-glib.h moved
3681 2004-06-22 Olivier Andrieu <oliv__a@users.sourceforge.net>
3683 * configure.in: prevent building the gcj stuff and libxml loader
3684 since they are broken.
3686 2004-06-20 Havoc Pennington <hp@redhat.com>
3688 * dbus/dbus-glib-error-enum.h: autogenerate the GError enum
3689 codes from the dbus error names
3691 * glib/dbus-glib.h: move to subdir dbus/ since it's included
3692 as dbus/dbus-glib.h and that breakage is now visible due to
3693 including dbus/dbus-glib.h in dbus-glib-lowlevel.h
3695 * glib/dbus-glib.h: s/gproxy/g_proxy/
3697 * dbus/dbus-shared.h: new header to hold stuff shared with
3700 * dbus/dbus-protocol.h (DBUS_ERROR_*): move errors here rather
3703 * glib/dbus-glib.h (dbus_set_g_error): move to
3704 dbus-glib-lowlevel.h
3706 * glib/dbus-glib.h: remove dbus/dbus.h from here; change a bunch
3707 of stuff to enable this
3709 * dbus/dbus-glib-lowlevel.h: put dbus/dbus.h here
3711 * a bunch of other changes with the same basic "separate glib
3712 bindings from dbus.h" theme
3714 2004-06-10 Owen Fraser-Green <owen@discobabe.net>
3716 * dbus-sharp.pc.in: Removed glib-sharp inclusion in Libs.
3718 * python/examples/Makefile.am: Fixed typo in EXTRA_DIST.
3720 2004-06-09 Olivier Andrieu <oliv__a@users.sourceforge.net>
3722 * bus/driver.c, dbus/dbus-bus.c: use BOOLEAN instead of UINT32 for
3723 the reply value of the ServiceExists message.
3725 2004-06-07 John (J5) Palmieri <johnp@redhat.com>
3727 * python/dbus_bindings.pyx.in: No longer need to parse path
3728 elements and pass them as arrays of strings. The C API now
3729 accepts plain path strings.
3730 (_build_parsed_path): removed
3732 2004-06-07 Havoc Pennington <hp@redhat.com>
3734 * doc/TODO: remove auto-activation item since it's done; sort
3735 items by importance/milestone
3737 2004-06-07 Havoc Pennington <hp@redhat.com>
3739 * dbus/dbus-message-builder.c (_dbus_message_data_load): append
3740 random signature when using REQUIRED_FIELDS (this hack won't work
3743 * dbus/dbus-message.c: change the signature to be a header field,
3744 instead of message->signature special-case string. Incremental
3745 step forward. Then we can fix up code to send the signature in the
3746 message, then fix up code to validate said signature, then fix up
3747 code to not put the typecodes inline, etc.
3748 (load_one_message): don't make up the signature after the fact
3749 (decode_header_data): require signature field for the known
3752 * dbus/dbus-marshal.c (_dbus_marshal_string_len): new
3754 * dbus/dbus-protocol.h: add DBUS_HEADER_FIELD_SIGNATURE
3756 2004-06-07 Owen Fraser-Green <owen@discobabe.net>
3758 * mono/DBusType/ObjectPath.cs: Renamed PathName argument to Path
3760 * mono/Handler.cs: Updated to follow new path argument for
3761 (un-)registering objects.
3763 * mono/example/Makefile.am:
3765 * configure.in: Bumped required version for mono and use new -pkg
3768 2004-06-05 Olivier Andrieu <oliv__a@users.sourceforge.net>
3770 * dbus/dbus-connection.h, dbus/dbus-connection.c: have object path
3771 registration functions take the path argument as char* instead of
3774 * dbus/dbus-marshal.h, dbus/dbus-marshal.c (_dbus_decompose_path):
3775 split off the path decompostion part of
3776 _dbus_demarshal_object_path. Some misc. fixes to silence compiler
3779 * glib/dbus-gobject.c, test/test-service.c: update accordingly.
3781 2004-06-02 Kristian Høgsberg <krh@redhat.com>
3783 * dbus/dbus-auth.c: Rewrite auth protocol handling to use a state
3784 machine approach. A state is implemented as a function that
3785 handles incoming events as specified for that state.
3787 * doc/dbus-specification.xml: Update auth protocol state machine
3788 specification to match implementation. Remove some leftover
3791 2004-06-02 Kristian Høgsberg <krh@redhat.com>
3793 * glib/dbus-gproxy.c, glib/dbus-gmain.c, dbus/dbus-string.c,
3794 dbus/dbus-object-tree.c, dbus/dbus-message.c: add comments to
3797 * Doxyfile.in: remove deprecated options.
3799 * dbus/dbus-message-handler.c, dbus/dbus-message-handler.h,
3800 glib/test-thread.h, glib/test-thread-client.c,
3801 glib/test-thread-server.c, glib/test-profile.c,
3802 glib/test-dbus-glib.c: remove these unused files.
3804 2004-06-01 Olivier Andrieu <oliv__a@users.sourceforge.net>
3806 * dbus/dbus-object-tree.c
3807 (_dbus_object_tree_dispatch_and_unlock): fix dispatch for
3808 non-fallback handlers (bug #684).
3809 (_dbus_object_subtree_new): initialize invoke_as_fallback field.
3810 (find_subtree_recurse): report wether the returned subtree is an
3811 exact match or a "fallback" match higher up in the tree.
3812 (object_tree_test_iteration): update test case.
3814 2004-06-01 Seth Nickell <seth@gnome.org>
3816 * python/dbus_bindings.pyx.in:
3817 * python/tests/test-client.py:
3819 Round off basic type support. Add dicts (yay!), and
3820 remaining array types.
3822 Make MessageIter more general so it works for dicts too.
3824 Mark all loop variables as C integers.
3826 2004-05-31 Havoc Pennington <hp@redhat.com>
3828 * glib/dbus-gidl.c (method_info_add_arg): keep args sorted with
3831 * glib/dbus-gobject.c (dbus_type_to_string): move to dbus-gutils.c
3833 * glib/dbus-glib-tool.c (main): set up to have a --self-test
3834 option that runs the tests, and start filling in some code
3835 including for starters just dumping the interfaces to stdout
3837 * glib/Makefile.am (INCLUDES): define DBUS_LOCALEDIR
3839 * test/data/valid-introspection-files/lots-of-types.xml: test of
3840 an example introspection file
3842 * glib/dbus-gparser.c (parser_check_doctype): doctype should be
3845 2004-05-31 Seth Nickell <seth@gnome.org>
3847 * python/dbus_bindings.pyx.in:
3848 * python/tests/test-client.py:
3853 Fix string array memory trashing bug... oops...
3855 2004-05-30 Seth Nickell <seth@gnome.org>
3859 Add a nicer-but-less-flexible alternate API for handling
3860 calls to virtual objects in dbus.ObjectTree.
3862 Screw up the argument order to the dbus.Object constructor
3863 for consistency with dbus.ObjectTree (and to make dbus_methods
3864 optional for future extension)
3866 * python/examples/Makefile.am:
3867 * python/examples/gconf-proxy-service.py:
3868 * python/examples/gconf-proxy-service2.py:
3870 Alternate implementation of gconf-proxy-service using the
3871 nicer dbus.ObjectTree API.
3873 * python/examples/example-service.py:
3874 * python/tests/test-server.py
3876 Reverse the argument order to deal with dbus.Object constructor
3879 2004-05-30 Seth Nickell <seth@gnome.org>
3881 * python/examples/example-client.py:
3882 * python/examples/example-service.py:
3884 Take it back. Lists seem to work but they're broken
3885 in the test suite. Make the base examples use
3888 2004-05-30 Seth Nickell <seth@gnome.org>
3890 * python/dbus_bindings.pyx.in:
3891 * python/tests/test-client.py:
3893 Add some more tests and fix errors that crop up.
3894 Unfortunately, currently it seems like marshalling
3895 and unmarshalling of lists is completely broken :-(
3897 2004-05-30 Seth Nickell <seth@gnome.org>
3899 * python/dbus_bindings.pyx.in:
3901 Add support for ObjectPath type.
3905 Refactor message handling code to a common function.
3907 * python/tests/test-client.py:
3908 * python/tests/test-server.py:
3910 Add tests that check to make sure values of all types
3911 can be echoed from a service w/o mangling.
3913 2004-05-29 Seth Nickell <seth@gnome.org>
3917 Add ObjectTree class which allows implementation
3918 of trees of "virtual" objects. Basically the python
3919 wrapper for "register_fallback".
3921 * python/examples/Makefile.am
3922 * python/examples/gconf-proxy-client.py:
3923 * python/examples/gconf-proxy-service.py:
3925 Implement a simple GConf proxy service that supports
3926 get/set on string and int GConf keys using the ObjectTree.
3928 2004-05-29 Seth Nickell <seth@gnome.org>
3931 * python/examples/example-client.py:
3932 * python/examples/example-service.py:
3933 * python/examples/list-system-services.py:
3935 Add SessionBus, SystemBus and ActivationBus classes
3936 so you don't need to know the special little BUS_TYPE
3939 2004-05-29 Havoc Pennington <hp@redhat.com>
3941 * bus/config-parser.c (process_test_valid_subdir): temporarily
3942 stop testing config parser OOM handling, since expat has issues
3943 http://freedesktop.org/pipermail/dbus/2004-May/001153.html
3945 * bus/dbus-daemon-1.1.in: change requested_reply to
3946 send_requested_reply/receive_requested_reply so we can send the
3947 replies, not just receive them.
3949 * bus/config-parser.c: parse the new
3950 send_requested_reply/receive_requested_reply
3952 * bus/policy.c (bus_client_policy_check_can_send): add
3953 requested_reply argument and use it
3955 * bus/bus.c (bus_context_check_security_policy): pass through
3956 requested_reply status to message send check
3958 * bus/system.conf.in: adapt to requested_reply change
3960 2004-05-28 Havoc Pennington <hp@redhat.com>
3962 * test/glib/test-service-glib.c (main): remove unused variable
3964 * glib/dbus-gidl.c (base_info_ref): fix a silly compiler warning
3966 * dbus/dbus-auth.h (enum): remove AUTHENTICATED_WITH_UNUSED_BYTES
3967 from the enum, no longer in use.
3969 * dbus/dbus-sysdeps.h: include config.h so DBUS_VA_COPY actually
3972 * dbus/dbus-message.c: add various _dbus_return_val_if_fail for
3973 whether error_name passed in is a valid error name.
3975 2004-05-28 John (J5) Palmieri <johnp@redhat.com>
3977 * dbus/dbus-message.c (dbus_message_get_args): Added support for
3978 OBJECT_PATH and OBJECT_PATH_ARRAY
3980 2004-05-28 Seth Nickell <seth@gnome.org>
3982 * python/examples/Makefile.am:
3984 Forget to add Makefile.am. Do not pass go.
3986 2004-05-28 Michael Meeks <michael@ximian.com>
3988 * glib/dbus-gvalue.c (dbus_gvalue_marshal, dbus_gvalue_demarshal):
3991 * dbus/dbus-string.c (_dbus_string_parse_basic_type): impl.
3993 * dbus/dbus-message.c (_dbus_message_iter_get_basic_type),
3994 (_dbus_message_iter_get_basic_type_array): impl.
3995 drastically simplify ~all relevant _get methods to use these.
3996 (_dbus_message_iter_append_basic_array),
3997 (dbus_message_iter_append_basic): impl
3998 drastically simplify ~all relevant _append methods to use these.
4000 * dbus/dbus-message-builder.c (parse_basic_type)
4001 (parse_basic_array, lookup_basic_type): impl.
4002 (_dbus_message_data_load): prune scads of duplicate /
4005 * dbus/dbus-marshal.c (_dbus_demarshal_basic_type_array)
4006 (_dbus_demarshal_basic_type): implement,
4007 (demarshal_and_validate_len/arg): beef up debug.
4008 (_dbus_marshal_basic_type, _dbus_marshal_basic_type_array): impl.
4010 2004-05-27 Seth Nickell <seth@gnome.org>
4013 * python/Makefile.am:
4015 Include the example python apps in the tarball.
4017 * python/examples/list-system-services.py
4019 Add a python new example that fetches the list of services
4020 from the system bus.
4022 2004-05-27 Seth Nickell <seth@gnome.org>
4025 * python/dbus_bindings.pyx.in:
4027 Fix failure to notify that a signal was not handled,
4028 resulted in hung functions.
4030 2004-05-25 Colin Walters <walters@redhat.com>
4032 * tools/dbus-monitor.c (main): Monitor all types of messages.
4034 2004-05-23 Owen Fraser-Green <owen@discobabe.net>
4036 * mono/Handler.cs, mono/Service.cs: Added UnregisterObject method
4037 which unregisters the object path and disposes the handler.
4039 2004-05-23 Kristian Høgsberg <krh@redhat.com>
4041 Patch from Timo Teräs <ext-timo.teras@nokia.com> (#614):
4043 * dbus/dbus-message.c (dbus_message_iter_get_args_valist): Swap
4044 operands to && so we call dbus_message_iter_next () for the last
4047 2004-05-21 Olivier Andrieu <oliv__a@users.sourceforge.net>
4049 * dbus/dbus-object-tree.c
4050 (_dbus_object_tree_list_registered_unlock, lookup_subtree): return
4051 children even if the requested path isn't registered.
4052 (object_tree_test_iteration): test object_tree_list_registered.
4054 * configure.in: undefine HAVE_ABSTRACT_SOCKETS instead of defining
4057 2004-05-20 Kristian Høgsberg <krh@redhat.com>
4059 * doc/TODO: Remove resolved items.
4061 * bus/expirelist.h (struct BusExpireList): remove unused n_items
4064 * bus/connection.c (bus_connections_expect_reply): Enforce the
4065 per-connection limit on pending replies.
4067 Patch from Jon Trowbridge <trow@ximian.com>:
4069 * bus/main.c (setup_reload_pipe): Added. Creates a pipe and sets
4070 up a watch that triggers a config reload when one end of the pipe
4072 (signal_handler): Instead of doing the config reload in our SIGHUP
4073 handler, just write to the reload pipe and let the associated
4074 watch handle the reload when control returns to the main loop.
4076 * bus/driver.c (bus_driver_handle_reload_config): Added.
4077 Implements a ReloadConfig method for requesting a configuration
4078 file reload via the bus driver.
4080 2004-05-19 Owen Fraser-Green <owen@discobabe.net>
4082 * HACKING: Updated release instructions concerning the wiki page.
4084 2004-05-18 Kristian Høgsberg <krh@redhat.com>
4086 * dbus/dbus-auth.c (client_try_next_mechanism): Remove logic to
4087 filter against auth->allowed_mechs; we only add allowed mechs in
4088 record_mechanisms().
4090 * dbus/dbus-auth-script.c (_dbus_auth_script_run): Add an
4091 ALLOWED_MECHS to auth-script format so we can set the list of
4094 * data/auth/client-out-of-mechanisms.auth-script: New test to
4095 check client disconnects when it is out of mechanisms to try.
4097 * dbus/dbus-auth.c (process_command): Remove check for lines
4098 longer that 1 MB; we only buffer up maximum 16 kB.
4100 * dbus/dbus-transport.c, dbus/dbus-transport-unix.c,
4101 dbus/dbus-auth-script.c, dbus/dbus-auth.c, dbus/dbus-auth.h:
4102 Remove auth state AUTHENTICATED_WITH_UNUSED_BYTES, instead always
4103 assume there might be unused bytes.
4105 * dbus/dbus-auth.c (_dbus_auth_do_work): Remove check for
4106 client-out-of-mechs, it is handled in process_reject(). Move check
4107 for max failures to send_rejected(), as it's a server-only thing.
4109 * dbus/dbus-auth.c: Factor out protocol reply code into functions
4110 send_auth(), send_data(), send_rejected(), send_error(),
4111 send_ok(), send_begin() and send_cancel().
4113 2004-05-17 Kristian Høgsberg <krh@redhat.com>
4115 Remove base64 encoding, replace with hex encoding. Original patch
4116 from trow@ximian.com, added error handling.
4118 * dbus/dbus-string.c (_dbus_string_base64_encode)
4119 (_dbus_string_base64_decode): Remove.
4120 (_dbus_string_hex_decode): Add end_return argument so we can
4121 distinguish between OOM and invalid hex encoding.
4122 (_dbus_string_test): Remove base64 tests and add test case for
4125 * dbus/dbus-keyring.c, dbus/dbus-auth-script.c, dbus/dbus-auth.c:
4126 Replace base64 with hex.
4128 * test/data/auth/invalid-hex-encoding.auth-script: New test case
4129 for invalid hex encoded data in auth protocol.
4131 2004-05-17 Olivier Andrieu <oliv__a@users.sourceforge.net>
4133 * dbus/dbus-connection.c (check_for_reply_unlocked): plug a memory
4136 2004-05-15 Owen Fraser-Green <owen@discobabe.net>
4138 * mono/dbus-sharp.dll.config.in: Added for GAC
4139 * mono/dbus-sharp.snk: Added for GAC
4140 * mono/Assembly.cs.in: Added for GAC
4141 * mono/Makefile.am: Changes for GAC installation
4142 * configure.in: Added refs for dbus-sharp.dll.config.in and
4143 Assembly.cs.in. More fixes for mono testing
4144 * mono/example/Makefile.am: Changed var to CSC
4145 * Makefile.am: Changed flag name to DBUS_USE_CSC
4147 2004-05-15 Owen Fraser-Green <owen@discobabe.net>
4149 * mono/Makefile.am: Added SUBDIRS for docs. Changed SUBDIRS order
4150 * mono/doc/*: Added documentation framework
4151 * configure.in: Added monodoc check
4152 * README: Added description of mono configure flags
4154 2004-05-11 John (J5) Palmieri <johnp@redhat.com>:
4156 * doc/dbus-specification.xml: Added a "Required" column to the
4157 header fields table and changed the "zero or more" verbage in
4158 the above paragraph to read "The header must contain the required
4159 named header fields and zero or more of the optional named header
4161 * test/data/invalid-messages/*.message: Added the required PATH
4162 named header field to the tests so that they don't fail on
4163 'Missing path field'
4165 2004-05-07 John (J5) Palmieri <johnp@redhat.com>
4167 * python/dbus-bindings.pyx.in: Stopped the bindings from trashing
4168 the stack by implicitly defining variable and parameter types and
4169 removing the hack of defining C pointers as python objects and later
4172 2004-05-02 Owen Fraser-Green <owen@discobabe.net>
4174 * mono/Makefile.am: Removed test-dbus-sharp.exe from all target
4176 2004-05-01 Owen Fraser-Green <owen@discobabe.net>
4178 * mono/DBusType/Dict.cs: Handle empty dicts
4179 * mono/DBusType/Array.cs: Handle empty arrays
4180 * mono/Arguments.cs: Handle empty arguments
4182 2004-04-30 Owen Fraser-Green <owen@discobabe.net>
4184 * dbus-sharp.pc.in: Modified to include include Libs and Requires
4187 2004-04-25 Kristian Høgsberg <krh@redhat.com>
4189 * test/data/valid-messages/standard-*.message: Update message
4190 test scripts to new header field names.
4192 2004-04-22 John (J5) Palmieri <johnp@redhat.com>
4194 * test/break-loader.c (randomly_do_n_things): tracked down buffer
4195 overflow to times_we_did_each_thing array which would chop off the
4196 first character of the failure_dir string. Increased the size of
4197 the array to 7 to reflect the number of random mutation functions
4200 2004-04-21 Kristian Høgsberg <krh@redhat.com>
4202 * dbus/dbus-server-unix.c (unix_finalize): Don't unref
4203 unix_server->watch here, it is unreffed in disconnect.
4204 (_dbus_server_new_for_tcp_socket): convert NULL host to
4205 "localhost" here so we don't append NULL to address.
4207 * dbus/dbus-server.c (_dbus_server_test): Add test case for
4208 various addresses, including tcp with no explicit host.
4210 2004-04-21 Olivier Andrieu <oliv__a@users.sourceforge.net>
4212 * dbus/dbus-message.c (decode_header_data, decode_string_field):
4213 fix incorrect setting of .name_offset in the HeaderField (it was
4214 off by two bytes, positioned right after the name and typecode)
4216 * bus/bus.c (bus_context_new, bus_context_unref): test before
4217 calling dbus_server_free_data_slot and _dbus_user_database_unref
4218 in case of an error.
4220 * tools/Makefile.am: add $(DBUS_GLIB_TOOL_LIBS), xml libs needed
4223 2004-04-19 Kristian Høgsberg <krh@redhat.com>
4225 * dbus/dbus-transport-unix.c (unix_do_iteration): Rewrite to use
4226 _dbus_poll() instead of select().
4228 2004-04-15 Jon Trowbridge <trow@ximian.com>
4230 * bus/main.c (signal_handler): Reload the configuration files
4232 (main): Set up our SIGHUP handler.
4234 * bus/bus.c (struct BusContext): Store the config file, user and
4235 fork flag in the BusContext.
4236 (process_config_first_time_only): Added. Contains the code
4237 (previously in bus_context_new) for setting up the BusContext from
4238 the BusConfigParser that should only be run the first time the
4239 config files are read.
4240 (process_config_every_time): Added. Contains the code (previously
4241 in bus_context_new) for setting up the BusContext from the
4242 BusConfigParser that should be run every time the config files are
4244 (load_config): Added. Builds a BusConfigParser from the config
4245 files and passes the resulting structure off to
4246 process_config_first_time_only (assuming this is the first time)
4247 and process_config_every_time.
4248 (bus_context_new): All of the config-related code has been moved
4249 to process_config_first_time_only and process_config_every_time.
4250 Now this function just does the non-config-related initializations
4251 and calls load_config.
4252 (bus_context_reload_config): Added.
4254 2004-04-15 Olivier Andrieu <oliv__a@users.sourceforge.net>
4256 * bus/driver.c (bus_driver_handle_get_service_owner):
4257 implement a GetServiceOwner method.
4258 * doc/dbus-specification.xml: document it.
4259 * dbus/dbus-errors.h: add a 'ServiceHasNoOwner' error.
4261 * glib/dbus-gproxy.c (dbus_gproxy_new_for_service_owner):
4262 implement, using the bus GetServiceOwner method.
4264 * test/glib/test-dbus-glib.c:
4265 use dbus_gproxy_new_for_service_owner so that we can receive the
4268 2004-04-15 John (J5) Palmieri <johnp@redhat.com>
4270 * dbus/dbus-internals.c, dbus/dbus-message-builder.c,
4271 dbus/dbus-message.c, dbus/dbus-protocol.h
4272 (DBUS_HEADER_FIELD_SERVICE): renamed DBUS_HEADER_FIELD_DESTINATION
4274 * dbus/dbus-internals.c, dbus/dbus-message-builder.c,
4275 dbus/dbus-message.c, dbus/dbus-protocol.h
4276 (DBUS_HEADER_FIELD_SENDER_SERVICE): renamed DBUS_HEADER_FIELD_SENDER
4278 * dbus/dbus-internals.c (_dbus_header_field_to_string):
4279 DBUS_HEADER_FIELD_DESTINATION resolves to "destination"
4280 DBUS_HEADER_FIELD_SENDER resolves to "sender"
4282 * doc/dbus-specification.xml (Header Fields Table):
4283 s/SERVICE/DESTINATION
4284 s/SENDER_SERVICE/SENDER
4287 2004-04-14 Olivier Andrieu <oliv__a@users.sourceforge.net>
4289 * test/glib/test-dbus-glib.c (timed_exit): fail the test after
4292 2004-04-13 Michael Meeks <michael@ximian.com>
4294 * glib/dbus-gobject.c (handle_introspect): split out
4295 (introspect_properties): this.
4296 (handle_introspect): implement this.
4298 * test/glib/Makefile.am: use the absolute path so the bus
4299 daemon's chdir ("/") doesn't kill us dead.
4301 * configure.in: subst ABSOLUTE_TOP_BUILDDIR
4303 2004-04-12 Jon Trowbridge <trow@ximian.com>
4305 * bus/config-parser.c (struct BusConfigParser): Added
4306 included_files field.
4307 (seen_include): Added. Checks whether or not a file has already
4308 been included by any parent BusConfigParser.
4309 (bus_config_parser_new): Copy the parent's included_files.
4310 (include_file): Track which files have been included, and fail on
4311 circular inclusions.
4312 (process_test_valid_subdir): Changed printf to report if we are
4313 testing valid or invalid conf files.
4314 (all_are_equiv): Changed printf to be a bit clearer about
4315 what we are actually doing.
4316 (bus_config_parser_test): Test invalid configuration files.
4318 2004-04-09 Jon Trowbridge <trow@ximian.com>
4320 * bus/config-parser.c (bus_config_parser_new): Added a 'parent'
4321 argument. If non-null, the newly-constructed BusConfigParser will
4322 be initialized with the parent's BusLimits instead of the default
4324 (include_file): When including a config file, pass in
4325 the current parser as the parent and then copy the BusLimits
4326 from the included BusConfigParser pack to the current parser.
4327 (process_test_valid_subdir): Renamed from process_test_subdir.
4328 (process_test_equiv_subdir): Added. Walks through a directory,
4329 descending into each subdirectory and loading the config files
4330 it finds there. If any subdirectory contains two config files
4331 that don't produce identical BusConfigParser structs, fail.
4332 For now, the BusConfigParser's BusPolicies are not compared.
4333 (bus_config_parser_test): Call both process_test_valid_subdir and
4334 process_test_equiv_subdir.
4336 * bus/config-loader-libxml.c (bus_config_load): Take a parent
4337 argument and pass it along to the call to bus_config_parser_new.
4338 Also made a few small changes to allow this code to compile.
4340 * bus/config-loader-expat.c (bus_config_load): Take a parent
4341 argument and pass it along to the call to bus_config_parser_new.
4343 * bus/bus.c (bus_context_new): Load the config file
4344 with a NULL parent argument.
4346 2004-03-29 Michael Meeks <michael@ximian.com>
4348 * glib/dbus-gobject.c (introspect_properties): split
4349 out, fix mangled 'while' flow control.
4350 (introspect_signals): implement.
4351 (handle_introspect): update.
4353 2004-03-29 Michael Meeks <michael@ximian.com>
4355 * glib/dbus-gobject.c (set_object_property): split out /
4356 re-work, use the property type, and not the message type(!)
4357 (get_object_property): ditto.
4359 * glib/dbus-gvalue.c (dbus_gvalue_demarshal),
4360 (dbus_gvalue_marshal): make this code re-usable, needed
4361 for signals too, also on both proxy and server side.
4362 Re-write for more efficiency / readability.
4364 2004-03-29 Michael Meeks <michael@ximian.com>
4366 * dbus/dbus-message.c
4367 (dbus_message_new_error_printf): impl.
4369 * dbus/dbus-connection.c
4370 (dbus_connection_unregister_object_path): fix warning.
4372 * configure.in: fix no-mono-installed situation.
4374 2004-03-27 Havoc Pennington <hp@redhat.com>
4376 Patch from Timo Teräs:
4378 * tools/dbus-send.c (main): if --print-reply, assume type is
4379 method call; support boolean type args
4381 * dbus/dbus-connection.c (dbus_connection_send_with_reply): fix a
4382 bunch of memleak and logic bugs
4384 2004-03-23 Owen Fraser-Green <owen@discobabe.net>
4386 * mono/Arguments.cs:
4387 * mono/Introspector.cs:
4389 * mono/InterfaceProxy.cs:
4391 * mono/ProxyBuilder.cs:
4393 Added InterfaceProxy class to avoid building proxies for every
4397 * dbus-message.c (dbus_message_append_args_valist)
4398 (dbus_message_iter_get_object_path)
4399 (dbus_message_iter_get_object_path_array)
4400 (dbus_message_iter_append_object_path)
4401 (dbus_message_iter_append_object_path_array):
4402 Added object_path iter functions to handle OBJECT_PATH arguments
4404 2004-03-23 Owen Fraser-Green <owen@discobabe.net>
4406 First checkin of mono bindings.
4409 Build stuff for the bindings
4410 * dbus-sharp.pc.in: Added for pkgconfig
4412 2004-03-21 Havoc Pennington <hp@redhat.com>
4414 * test/test-service.c (main): remove debug spew
4416 2004-03-21 Olivier Andrieu <oliv__a@users.sourceforge.net>
4418 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): accept empty
4421 * dbus/dbus-message.h, bus/dbus-message.c (dbus_message_iter_init)
4422 (dbus_message_iter_init_array_iterator)
4423 (dbus_message_iter_init_dict_iterator): return a dbus_bool_t to
4424 indicate whether the iterator is empty
4426 * dbus/dbus-pending-call.c, dbus/dbus-server.c: silence compiler
4429 2004-03-19 Havoc Pennington <hp@redhat.com>
4431 * NEWS: 0.21 updates
4433 * configure.in: 0.21
4435 * doc/Makefile.am: add all XMLTO usage to DBUS_XML_DOCS_ENABLED
4437 * python/Makefile.am: change to avoid dist of dbus_bindings.c so
4438 you don't need pyrex to make dist
4440 * qt/Makefile.am (libdbus_qt_1_la_SOURCES): add integrator.h to
4443 2004-03-18 Richard Hult <richard@imendio.com>
4445 * dbus/dbus-message.c (dbus_message_get_auto_activation)
4446 (dbus_message_set_auto_activation): Add doxygen docs.
4448 2004-03-16 Richard Hult <richard@imendio.com>
4450 * bus/activation.c: (bus_activation_service_created),
4451 (bus_activation_send_pending_auto_activation_messages),
4452 (bus_activation_activate_service):
4454 * bus/dispatch.c: (bus_dispatch),
4455 (check_nonexistent_service_auto_activation),
4456 (check_service_auto_activated),
4457 (check_segfault_service_auto_activation),
4458 (check_existent_service_auto_activation), (bus_dispatch_test):
4459 * bus/driver.c: (bus_driver_handle_activate_service):
4460 * bus/services.c: (bus_registry_acquire_service):
4461 * dbus/dbus-message.c: (dbus_message_set_auto_activation),
4462 (dbus_message_get_auto_activation):
4463 * dbus/dbus-message.h:
4464 * dbus/dbus-protocol.h: Implement auto-activation.
4466 * doc/dbus-specification.xml: Add auto-activation to the spec.
4468 2004-03-12 Olivier Andrieu <oliv__a@users.sourceforge.net>
4470 * dbus/dbus-marshal.c (_dbus_marshal_get_arg_end_pos):
4471 fix a bug with CUSTOM types.
4473 * dbus/dbus-message.c (message_iter_test, _dbus_message_test): add
4474 a unit test for this bug (used to fail).
4476 2004-03-12 Mikael Hallendal <micke@imendio.com>
4479 (babysitter_watch_callback): notify all pending activations waiting for
4480 the same exec that the activation failed.
4481 (bus_activation_activate_service): shortcut the activation if we
4482 already waiting for the same executable to start up.
4484 2004-03-12 Mikael Hallendal <micke@imendio.com>
4487 - Added service file reloading.
4488 Each service files directory is kept in an hash table in
4489 BusActivation and each BusActivationEntry knows what .service-file it
4490 was read from. So when you try to activate a service the bus will
4491 check if it's been updated, removed or if new .service-files has
4493 - Test code at the bottom for the service file reloading.
4494 * bus/test-main.c: (main):
4496 - added service reloading test.
4497 * dbus/dbus-sysdeps.c:
4498 * dbus/dbus-sysdeps.h: (_dbus_delete_directory): Added.
4500 2004-03-08 Michael Meeks <michael@ximian.com>
4502 * dbus/dbus-connection.c (_dbus_connection_block_for_reply):
4503 bail immediately if disconnected, to avoid busy loop.
4505 * dbus/dbus-message.c (dbus_message_iter_get_args_valist):
4506 cleanup cut/paste/inefficiency.
4508 2004-03-01 David Zeuthen <david@fubar.dk>
4510 * dbus/dbus-string.c (_dbus_string_append_printf_valist): Fix a
4511 bug where args were used twice. This bug resulted in a segfault
4512 on a Debian/PPC system when starting the messagebus daemon. Include
4513 dbus-sysdeps.h for DBUS_VA_COPY
4515 * dbus/dbus-sysdeps.h: Define DBUS_VA_COPY if neccessary. From GLib
4517 * configure.in: Check for va_copy; define DBUS_VA_COPY to the
4518 appropriate va_copy implementation. From GLib
4520 2004-02-24 Joe Shaw <joe@ximian.com>
4522 * bus/services.c (bus_registry_acquire_service): We need to pass
4523 in the service name to dbus_set_error() to prevent a crash.
4525 2003-12-26 Anders Carlsson <andersca@gnome.org>
4527 * AUTHORS: Reveal my True identity.
4529 2003-12-17 Mikael Hallendal <micke@imendio.com>
4531 * dbus/dbus-message.c: (dbus_message_append_args_valist):
4532 - Added case for DBUS_TYPE_BYTE, patch from Johan Hedberg.
4534 2003-12-13 Mikael Hallendal <micke@imendio.com>
4536 * doc/TODO: Added not about better error check of configuration files.
4538 2003-12-02 Richard Hult <richard@imendio.com>
4540 * Update AFL version to 2.0 throughout the source files to reflect
4541 the update that was done a while ago.
4543 2003-12-02 Richard Hult <richard@imendio.com>
4545 * dbus/dbus-message.c (dbus_message_iter_append_dict): Set
4546 wrote_dict_key to FALSE on the iter that the dict is appended to,
4547 just like when appending other types. Fixes a bug where a dict
4548 couldn't be put inside a dict.
4549 (dbus_message_iter_append_dict_key): Fix typo in warning message.
4550 (message_iter_test, _dbus_message_test): Add test case for dict
4553 2003-12-01 David Zeuthen <david@fubar.dk>
4555 * python/dbus.py: Add the actual message when calling the reciever
4556 of a signal such that parameters can be inspected. Add the method
4557 remove_signal_receiver
4559 2003-11-26 Mikael Hallendal <micke@imendio.com>
4563 * glib/*.[ch]: Made ref functions return the pointer
4565 2003-11-25 Zack Rusin <zack@kde.org>
4567 * qt/integrator.h, qt/integrator.cpp: Adding handling of DBusServer,
4569 * qt/server.h, qt/server.cpp, qt/Makefile.am: Adding DBusServer
4572 * qt/connection.h, qt/connection.cpp: Adjusting to changes in
4573 the Integrator and to better fit with the server,
4575 2003-11-24 Zack Rusin <zack@kde.org>
4577 * qt/connection.h, qt/connection.cpp: removing initDbus method since
4578 the integrator handles it now
4580 * qt/integrator.h, qt/integrator.cpp: reworking handling of timeouts,
4581 since QTimer wasn't really meant to be used the way DBusTimeout is
4583 2003-11-24 Zack Rusin <zack@kde.org>
4585 * qt/integrator.h, qt/integrator.cpp, Makefile.am: Adding
4586 Integrator class which integrates D-BUS with the Qt event loop,
4588 * qt/connection.h, qt/connection.cpp: Move all the code which
4589 was dealing with D-BUS integration to the Integrator class,
4590 and start using Integrator,
4592 2003-11-23 Zack Rusin <zack@kde.org>
4594 * qt/connection.h, qt/connection.cpp: Adding the DBusConnection
4597 * qt/message.h, qt/message.cpp: updating to the current D-BUS api,
4598 switching namespaces to DBusQt, reworking the class,
4600 * Makefile.cvs: switching dependencies so that it matches KDE
4603 * qt/Makefile.am: adding connection.{h,cpp} and message.{h,cpp} to
4606 2003-11-19 Havoc Pennington <hp@redhat.com>
4610 * configure.in: bump version to 0.20
4612 * configure.in (have_qt): add yet another place to look for qt
4613 (someone hand trolltech a .pc file...)
4615 2003-11-01 Havoc Pennington <hp@redhat.com>
4617 * doc/dbus-specification.xml: add state machine docs on the auth
4618 protocol; just a first draft, I'm sure it's wrong.
4620 2003-10-28 David Zeuthen <david@fubar.dk>
4622 * python/dbus_bindings.pyx.in: add get_dict to handle dictionaries
4623 return types. Fixup TYPE_* to reflect changes in dbus/dbus-protocol.h
4625 2003-10-28 Havoc Pennington <hp@redhat.com>
4627 * dbus/dbus-message.c (get_next_field): delete unused function
4629 2003-10-28 Havoc Pennington <hp@redhat.com>
4631 * bus/expirelist.c (do_expiration_with_current_time): detect
4632 failure of the expire_func due to OOM
4634 * bus/connection.c (bus_pending_reply_expired): return FALSE on OOM
4636 * bus/dispatch.c (check_send_exit_to_service): fix to handle the
4637 NoReply error that's now created by the bus when the service exits
4639 2003-10-28 Havoc Pennington <hp@redhat.com>
4641 * dbus/dbus-message.c (_dbus_message_test): enable and fix the
4642 tests for set_path, set_interface, set_member, etc.
4644 * dbus/dbus-string.c (_dbus_string_insert_bytes): allow 0 bytes
4646 * dbus/dbus-message.c (set_string_field): always just delete and
4647 re-append the field; accept NULL for deletion
4648 (re_align_fields_recurse): reimplement
4650 2003-10-26 Havoc Pennington <hp@redhat.com>
4652 * dbus/dbus-connection.c: fix docs to properly describe the
4653 disconnected message
4654 (_dbus_connection_notify_disconnected): remove this function;
4655 we can't synchronously add the disconnected message, we have to
4656 do it after we've queued any remaining real messages
4657 (_dbus_connection_get_dispatch_status_unlocked): queue the
4658 disconnect message only if the transport has finished queueing all
4659 its real messages and is disconnected.
4660 (dbus_connection_disconnect): update the dispatch status here
4662 2003-10-22 Havoc Pennington <hp@redhat.com>
4664 * bus/bus.c (bus_context_check_security_policy): fix up assertion
4666 * bus/connection.c (bus_transaction_send_from_driver): set the
4667 destination to the connection's base service
4669 2003-10-20 Havoc Pennington <hp@redhat.com>
4671 hmm, make check is currently not passing.
4673 * doc/dbus-specification.xml: add requirement that custom type
4674 names follow the same rules as interface names.
4676 * dbus/dbus-protocol.h: change some of the byte codes, to avoid
4677 duplication and allow 'c' to be 'custom'; dict is now 'm' for
4680 * doc/dbus-specification.xml: update type codes to match
4681 dbus-protocol.h, using the ASCII byte values. Rename type NAMED to
4682 CUSTOM. Add type OBJECT_PATH to the spec.
4684 2003-10-17 Havoc Pennington <hp@redhat.com>
4686 * bus/driver.c (create_unique_client_name): use "." as separator
4687 in base service names instead of '-'
4689 * dbus/dbus-string.c (_dbus_string_get_byte): allow getting nul
4690 byte at the end of the string
4692 * dbus/dbus-internals.h (_DBUS_LIKELY, _DBUS_UNLIKELY): add
4693 optimization macros since string validation seems to be a slow
4696 * doc/dbus-specification.xml: restrict valid
4697 service/interface/member/error names. Add test suite code for the
4700 * dbus/dbus-string.c: limit service/interface/member/error names
4703 * dbus/dbus-connection.c (dbus_connection_dispatch): add missing
4704 format arg to verbose spew
4706 * glib/dbus-gproxy.c (dbus_gproxy_call_no_reply): if not out of
4707 memory, return instead of g_error
4709 * test/test-service.c (path_message_func): support emitting a
4712 * dbus/dbus-bus.c (init_connections_unlocked): only fill in
4713 activation bus type if DBUS_BUS_ACTIVATION was set; default to
4714 assuming the activation bus was the session bus so that services
4715 started manually will still register.
4716 (init_connections_unlocked): fix so that in OOM situation we get
4717 the same semantics when retrying the function
4719 * test/test-service.c (main): change to use path registration, to
4720 test those codepaths; register with DBUS_BUS_ACTIVATION rather
4721 than DBUS_BUS_SESSION
4723 2003-10-16 Havoc Pennington <hp@redhat.com>
4725 * glib/dbus-gtest-main.c: bracket with #ifdef DBUS_BUILD_TESTS
4727 * Makefile.am (GCOV_DIRS): remove "test", we don't care about test
4728 coverage of the tests
4729 (coverage-report.txt): don't move the .da and .bbg files around
4731 2003-10-16 Havoc Pennington <hp@redhat.com>
4733 * bus/bus.c (struct BusContext): remove struct field I didn't mean
4736 2003-10-16 Havoc Pennington <hp@redhat.com>
4738 * bus/connection.c (bus_pending_reply_expired): either cancel or
4740 (bus_connections_check_reply): use unlink, not remove_link, as we
4741 don't want to free the link; fixes double free mess
4743 * dbus/dbus-pending-call.c (dbus_pending_call_block): fix in case
4744 where no reply was received
4746 * dbus/dbus-connection.c (_dbus_pending_call_complete_and_unlock):
4749 * bus/signals.c (match_rule_matches): add special cases for the
4750 bus driver, so you can match on sender/destination for it.
4752 * dbus/dbus-sysdeps.c (_dbus_abort): print backtrace if
4753 DBUS_PRINT_BACKTRACE is set
4755 * dbus/dbus-internals.c: add pid to assertion failure messages
4757 * dbus/dbus-connection.c: add message type code to the debug spew
4759 * glib/dbus-gproxy.c (gproxy_get_match_rule): match rules want
4760 sender=foo not service=foo
4762 * dbus/dbus-bus.c (dbus_bus_get): if the activation bus is the
4763 session bus but DBUS_SESSION_BUS_ADDRESS isn't set, use
4764 DBUS_ACTIVATION_ADDRESS instead
4766 * bus/activation.c: set DBUS_SESSION_BUS_ADDRESS,
4767 DBUS_SYSTEM_BUS_ADDRESS if appropriate
4769 * bus/bus.c (bus_context_new): handle OOM copying bus type into
4772 * dbus/dbus-message.c (dbus_message_iter_get_object_path): new function
4773 (dbus_message_iter_get_object_path_array): new function (half
4774 finished, disabled for the moment)
4776 * glib/dbus-gproxy.c (dbus_gproxy_end_call): properly handle
4777 DBUS_MESSAGE_TYPE_ERROR
4779 * tools/dbus-launch.c (babysit): support DBUS_DEBUG_OUTPUT to
4780 avoid redirecting stderr to /dev/null
4781 (babysit): close stdin if not doing the "exit_with_session" thing
4783 * dbus/dbus-sysdeps.c (_dbus_become_daemon): delete some leftover
4784 debug code; change DBUS_DEBUG_OUTPUT to only enable stderr, not
4785 stdout/stdin, so things don't get confused
4787 * bus/system.conf.in: fix to allow replies, I modified .conf
4788 instead of .conf.in again.
4790 2003-10-14 David Zeuthen <david@fubar.dk>
4792 * python/dbus_bindings.pyx.in (MessageIter.get): fixed typo in
4793 argtype to arg_type when raising unknown arg type exception.
4794 Changed type list to reflect the changes in dbus-protocol.h so
4795 the bindings actually work.
4797 2003-10-14 Havoc Pennington <hp@redhat.com>
4799 * test/decode-gcov.c: support gcc 3.3 also, though gcc 3.3 seems
4800 to have a bug keeping it from outputting the .da files sometimes
4801 (string_get_string): don't append garbage nul bytes to the string.
4803 2003-10-15 Seth Nickell <seth@gnome.org>
4805 * python/Makefile.am:
4807 Include dbus_h_wrapper.h in the dist tarball.
4809 2003-10-14 Havoc Pennington <hp@redhat.com>
4811 * bus/bus.c (bus_context_check_security_policy): revamp this to
4812 work more sanely with new policy-based requested reply setup
4814 * bus/connection.c (bus_transaction_send_from_driver): set bus
4815 driver messages as no reply
4817 * bus/policy.c (bus_client_policy_check_can_receive): handle a
4818 requested_reply attribute on allow/deny rules
4820 * bus/system.conf: add <allow requested_reply="true"/>
4822 * bus/driver.c (bus_driver_handle_message): fix check for replies
4823 sent to the bus driver, which was backward. How did this ever work
4824 at all though? I think I'm missing something.
4826 * dbus/dbus-message.c (decode_header_data): require error and
4827 method return messages to have a reply serial field to be valid
4828 (_dbus_message_loader_queue_messages): break up this function;
4829 validate that reply serial and plain serial are nonzero;
4830 clean up the OOM/error handling.
4831 (get_uint_field): don't return -1 from this
4832 (dbus_message_create_header): fix signed/unsigned bug
4834 * bus/connection.c (bus_connections_expect_reply): save serial of
4835 the incoming message, not reply serial
4837 2003-10-14 Havoc Pennington <hp@redhat.com>
4839 * bus/connection.c: implement pending reply tracking using
4842 * bus/bus.c (bus_context_check_security_policy): verify that a
4843 reply is pending in order to allow a reply to be sent. Deny
4844 messages of unknown type.
4846 * bus/dbus-daemon-1.1.in: update to mention new resource limits
4848 * bus/bus.c (bus_context_get_max_replies_per_connection): new
4849 (bus_context_get_reply_timeout): new
4851 2003-10-13 Seth Nickell <seth@gnome.org>
4853 * python/Makefile.am:
4855 Pass "make distcheck": remove a couple files from DIST_FILES
4856 that weren't included in the final version.
4858 2003-10-12 Havoc Pennington <hp@pobox.com>
4860 Added test code that 1) starts an actual bus daemon and 2) uses
4861 DBusGProxy; fixed bugs that were revealed by the test. Lots
4862 more testing possible, but this is the basic framework.
4864 * glib/dbus-gproxy.c (dbus_gproxy_manager_unregister): remove
4865 empty proxy lists from the proxy list hash
4867 * dbus/dbus-message.c (dbus_message_iter_get_args_valist): add a
4868 couple of return_if_fail checks
4870 * dbus/dbus-pending-call.c (_dbus_pending_call_new): use dbus_new0
4871 to allocate, so everything is cleared to NULL as it should be.
4873 * glib/dbus-gmain.c (dbus_connection_setup_with_g_main): pass
4874 source as data to dbus_connection_set_timeout_functions() as the
4875 timeout functions expected
4877 * test/glib/run-test.sh: add a little script to start up a message
4878 bus and run tests using it
4880 * tools/dbus-launch.1: updates
4882 * tools/dbus-launch.c (main): add --config-file option
4884 * tools/dbus-launch.c (main): remove confusing else if (runprog)
4885 that could never be reached.
4887 * dbus/dbus-message.c (dbus_message_new_method_return)
4888 (dbus_message_new_error, dbus_message_new_signal): set the
4889 no-reply-expected flag on all these. Redundant, but may
4890 as well be consistent.
4892 2003-10-11 Havoc Pennington <hp@pobox.com>
4894 * test/decode-gcov.c (function_solve_graph): make broken block
4895 graph a nonfatal error since it seems to be broken. Need to debug
4898 * dbus/dbus-marshal.c (_dbus_type_is_valid): new function since we
4899 can't just check type > INVALID < LAST anymore
4901 * dbus/dbus-message.c (dbus_message_get_signature): new function
4902 (dbus_message_has_signature): new function
4903 (struct DBusMessage): add signature field (right now it isn't sent
4904 over the wire, just generated on the fly)
4905 (dbus_message_copy): copy the signature, and init strings to
4906 proper length to avoid some reallocs
4907 (dbus_message_iter_init_array_iterator): return void, since it
4909 (dbus_message_iter_init_dict_iterator): return void since it can't fail
4910 (_dbus_message_loader_queue_messages): add silly temporary hack to
4911 fill in message->signature on load
4913 * dbus/dbus-protocol.h: change DBUS_TYPE_* values to be ASCII
4914 characters, so they are relatively human-readable.
4916 2003-10-11 Havoc Pennington <hp@pobox.com>
4918 * dbus/dbus-message.c (_dbus_message_test): add more test
4919 coverage, but #if 0 for now since they uncover a bug
4920 not fixed yet; I think in re_align_field_recurse()
4921 (re_align_field_recurse): add FIXME about broken assertion
4923 * dbus/dbus-sysdeps.c (_dbus_sysdeps_test): add more test coverage
4925 * bus/connection.c: share a couple code bits with expirelist.c
4927 * bus/expirelist.h, bus/expirelist.c: implement a generic
4928 expire-items-after-N-seconds facility, was going to share between
4929 expiring connections and replies, decided not to use for expiring
4930 connections for now.
4932 * COPYING: include AFL 2.0 (still need to change all the file headers)
4934 2003-10-09 Havoc Pennington <hp@redhat.com>
4936 * configure.in: define DBUS_HAVE_GCC33_GCOV if we have
4937 gcc 3.3. Not that we do anything about it yet.
4939 * bus/signals.c (bus_match_rule_parse): impose max length on the
4942 * dbus/dbus-protocol.h: add DBUS_MAXIMUM_MATCH_RULE_LENGTH
4944 2003-10-09 Havoc Pennington <hp@redhat.com>
4946 Make matching rules theoretically work (add parser).
4948 * bus/bus.c (bus_context_check_security_policy): fix up to handle
4949 the case where destination is explicitly specified as bus driver
4950 and someone else is eavesdropping.
4952 * bus/policy.c (bus_client_policy_check_can_receive): fix up
4953 definition of eavesdropping and assertion
4955 * tools/dbus-send.c (main): use dbus_message_type_from_string
4957 * bus/signals.c (bus_match_rule_parse): implement
4959 * dbus/dbus-message.c (dbus_message_type_from_string): new
4961 * dbus/dbus-errors.h (DBUS_ERROR_MATCH_RULE_INVALID): add
4963 2003-10-02 Havoc Pennington <hp@pobox.com>
4965 * glib/dbus-gproxy.c (dbus_gproxy_call_no_reply): rename from
4966 dbus_gproxy_oneway_call
4968 * glib/dbus-gmain.c (dbus_connection_setup_with_g_main)
4969 (dbus_server_setup_with_g_main): fix to allow calling them more
4970 than once on the same args
4971 (dbus_bus_get_with_g_main): new function
4973 2003-10-02 Havoc Pennington <hp@redhat.com>
4975 * doc/dbus-tutorial.xml: write some stuff
4977 2003-09-29 Havoc Pennington <hp@pobox.com>
4979 * configure.in: split checks for Doxygen from XML docs, check for
4982 * doc/Makefile.am: XML-ify all the docs, and add a blank
4985 2003-09-29 Havoc Pennington <hp@pobox.com>
4987 * Merge dbus-object-names branch. To see the entire patch
4988 do cvs diff -r DBUS_OBJECT_NAMES_BRANCHPOINT -r dbus-object-names,
4989 it's huuuuge though.
4990 To revert, I tagged DBUS_BEFORE_OBJECT_NAMES_MERGE.
4992 2003-09-28 Havoc Pennington <hp@pobox.com>
4994 * HACKING: update to reflect new server
4996 2003-09-26 Seth Nickell <seth@gnome.org>
4999 * python/examples/example-signals.py:
5001 Start implementing some notions of signals. The API
5002 is really terrible, but they sort of work (with the
5003 exception of being able to filter by service, and to
5004 transmit signals *as* a particular service). Need to
5005 figure out how to make messages come from the service
5008 * python/dbus_bindings.pyx.in:
5010 Removed duplicate message_handler callbacks.
5012 2003-09-25 Havoc Pennington <hp@redhat.com>
5014 * bus/session.conf.in: fix my mess
5016 2003-09-25 Havoc Pennington <hp@pobox.com>
5018 * bus/session.conf.in: fix security policy, reported by Seth Nickell
5020 2003-09-25 Seth Nickell <seth@gnome.org>
5022 * python/examples/example-service.py:
5024 Johan notices complete wrong code in example-service, but
5025 completely wrong in a way that works exactly the same (!).
5026 Johan is confused, how could this possibly work? Example
5027 code fails to serve purpose of making things clear.
5030 2003-09-25 Mark McLoughlin <mark@skynet.ie>
5032 * doc/dbus-specification.sgml: don't require header fields
5033 to be 4-byte aligned and specify that fields should be
5034 distinguished from padding by the fact that zero is not
5037 * doc/TODO: remove re-alignment item and add item to doc
5038 the OBJECT_PATH type.
5040 * dbus/dbus-message.c:
5041 (HeaderField): rename the original member to value_offset
5042 and introduce a name_offset member to keep track of where
5043 the field actually begins.
5044 (adjust_field_offsets): remove.
5045 (append_int_field), (append_uint_field),
5046 (append_string_field): don't align the start of the header
5047 field to a 4-byte boundary.
5048 (get_next_field): impl finding the next marhsalled field
5049 after a given field.
5050 (re_align_field_recurse): impl re-aligning a number of
5051 already marshalled fields.
5052 (delete_field): impl deleting a field of any type and
5053 re-aligning any following fields.
5054 (delete_int_or_uint_field), (delete_string_field): remove.
5055 (set_int_field), (set_uint_field): no need to re-check
5056 that we have the correct type for the field.
5057 (set_string_field): ditto and impl re-aligning any
5059 (decode_header_data): update to take into account that
5060 the fields aren't 4-byte aligned any more and the new
5061 way to distinguish padding from header fields. Also,
5062 don't exit when there is too much header padding.
5063 (process_test_subdir): print the directory.
5064 (_dbus_message_test): add test to make sure a following
5065 field is re-aligned correctly after field deletion.
5067 * dbus/dbus-string.[ch]:
5068 (_dbus_string_insert_bytes): rename from insert_byte and
5069 allow the insert of multiple bytes.
5070 (_dbus_string_test): test inserting multiple bytes.
5072 * dbus/dbus-marshal.c: (_dbus_marshal_set_string): add
5073 warning note to docs about having to re-align any
5074 marshalled values following the string.
5076 * dbus/dbus-message-builder.c:
5077 (append_string_field), (_dbus_message_data_load):
5078 don't align the header field.
5080 * dbus/dbus-auth.c: (process_test_subdir): print the
5083 * test/break-loader.c: (randomly_add_one_byte): upd. for
5086 * test/data/invalid-messages/bad-header-field-alignment.message:
5089 * test/data/valid-messages/unknown-header-field.message: shove
5090 a dict in the unknown field.
5092 2003-09-25 Seth Nickell <seth@gnome.org>
5095 * python/dbus_bindings.pyx.in:
5097 Handle return values.
5099 * python/examples/example-client.py:
5100 * python/examples/example-service.py:
5102 Pass back return values from the service to the client.
5104 2003-09-24 Seth Nickell <seth@gnome.org>
5108 Connect Object methods (when you are sharing an object) up... pass
5109 in a list of methods to be shared. Sharing all the methods just
5110 worked out too weird. You can now create nice Services over the
5113 * python/dbus_bindings.pyx.in:
5115 Keep references to user_data tuples passed into C functions so
5116 Python doesn't garbage collect on us.
5118 Implement MethodReturn and Error subclasses of Message for creating
5119 DBusMessage's of those types.
5121 * python/examples/example-client.py:
5122 * python/examples/example-service.py:
5124 Simple example code showing both how create DBus services and objects,
5125 and how to use them.
5127 2003-09-23 Havoc Pennington <hp@pobox.com>
5129 * glib/dbus-gproxy.c (dbus_gproxy_manager_filter): implement
5131 2003-09-23 Havoc Pennington <hp@redhat.com>
5133 * glib/dbus-gproxy.c (dbus_gproxy_connect_signal): implement
5134 (dbus_gproxy_disconnect_signal): implement
5135 (dbus_gproxy_manager_remove_signal_match): implement
5136 (dbus_gproxy_manager_add_signal_match): implement
5137 (dbus_gproxy_oneway_call): implement
5139 2003-09-23 Havoc Pennington <hp@pobox.com>
5141 * glib/dbus-gproxy.c (struct DBusGProxy): convert to a GObject
5142 subclass. This means dropping the transparent thread safety of the
5143 proxy; you now need a separate proxy per-thread, or your own
5144 locking on the proxy. Probably right anyway.
5145 (dbus_gproxy_ref, dbus_gproxy_unref): nuke, just use g_object_ref
5147 2003-09-22 Havoc Pennington <hp@redhat.com>
5149 * glib/dbus-gproxy.c (dbus_gproxy_manager_get): implement
5151 2003-09-21 Seth Nickell <seth@gnome.org>
5153 First checkin of the Python bindings.
5155 * python/.cvsignore:
5156 * python/Makefile.am:
5157 * python/dbus_bindings.pyx.in:
5158 * python/dbus_h_wrapper.h:
5160 Pieces for Pyrex to operate on, building a dbus_bindings.so
5161 python module for low-level access to the DBus APIs.
5165 High-level Python module for accessing DBus objects.
5170 Build stuff for the python bindings.
5174 Extra macro needed for finding the Python C header files.
5176 2003-09-21 Havoc Pennington <hp@pobox.com>
5178 * glib/dbus-gproxy.c (dbus_gproxy_manager_new): start
5179 implementing the proxy manager, didn't get very far.
5181 * dbus/dbus-bus.c (dbus_bus_add_match): new
5182 (dbus_bus_remove_match): new
5184 * glib/dbus-gproxy.c (dbus_gproxy_new_for_service): add a
5185 path_name argument; adjust the other not-yet-implemented
5186 gproxy constructors to be what I think they should be.
5188 2003-09-21 Havoc Pennington <hp@pobox.com>
5190 * dbus/dbus-bus.c (dbus_bus_get): set exit_on_disconnect to TRUE
5191 by default for message bus connections.
5193 * dbus/dbus-connection.c (dbus_connection_dispatch): exit if
5194 exit_on_disconnect flag is set and we process the disconnected
5196 (dbus_connection_set_exit_on_disconnect): new function
5198 2003-09-21 Havoc Pennington <hp@pobox.com>
5200 Get matching rules mostly working in the bus; only actually
5201 parsing the rule text remains. However, the client side of
5202 "signal connections" hasn't been started, this patch is only the
5205 * dbus/dispatch.c: fix for the matching rules changes
5207 * bus/driver.c (bus_driver_handle_remove_match)
5208 (bus_driver_handle_add_match): send an ack reply from these
5211 * glib/dbus-gproxy.c (dbus_gproxy_begin_call): fix order of
5212 arguments, reported by Seth Nickell
5214 * bus/config-parser.c (append_rule_from_element): support
5215 eavesdrop=true|false attribute on policies so match rules
5216 can be prevented from snooping on the system bus.
5218 * bus/dbus-daemon-1.1.in: consistently use terminology "sender"
5219 and "destination" in attribute names; fix some docs bugs;
5220 add eavesdrop=true|false attribute
5222 * bus/driver.c (bus_driver_handle_add_match)
5223 (bus_driver_handle_remove_match): handle AddMatch, RemoveMatch
5226 * dbus/dbus-protocol.h (DBUS_SERVICE_ORG_FREEDESKTOP_BROADCAST): get
5227 rid of broadcast service concept, signals are just always broadcast
5229 * bus/signals.c, bus/dispatch.c, bus/connection.c, bus/bus.c:
5230 mostly implement matching rules stuff (currently only exposed as signal
5233 2003-09-21 Mark McLoughlin <mark@skynet.ie>
5235 * doc/dbus-specification.sgml: Change the header field name
5236 to be an enum and update the rest of the spec to reference
5237 the fields using the conventinal name.
5239 * dbus/dbus-protocol.h: update to reflect the spec.
5241 * doc/TODO: add item to remove the 4 byte alignment requirement.
5243 * dbus/dbus-message.c: Remove the code to generalise the
5244 header/body length and serial number header fields as named
5245 header fields so we can reference field names using the
5247 (append_int_field), (append_uint_field), (append_string_field):
5248 Append the field name as a byte rather than four chars.
5249 (delete_int_or_uint_field), (delete_string_field): reflect the
5250 fact that the field name and typecode now occupy 4 bytes instead
5252 (decode_string_field), (decode_header_data): update to reflect
5253 protocol changes and move the field specific encoding from
5254 decode_string_field() back into decode_header_data().
5256 * dbus/dbus-internals.[ch]: (_dbus_header_field_to_string):
5257 Add utility to aid debugging.
5259 * dbus/dbus-message-builder.c:
5260 (append_string_field), (_dbus_message_data_load): Update to
5261 reflect protocol changes; Change the FIELD_NAME directive
5262 to HEADER_FIELD and allow it to take the field's conventional
5263 name rather than the actual value.
5265 * test/data/*/*.message: Update to use HEADER_FIELD instead
5266 of FIELD_NAME; Always align the header on an 8 byte boundary
5267 *before* updating the header length.
5269 2003-09-15 Havoc Pennington <hp@pobox.com>
5271 * dbus/dbus-pending-call.c: add the get/set object data
5272 boilerplate as for DBusConnection, etc. Use generic object data
5273 for the notify callback.
5275 * glib/dbus-gparser.c (parse_node): parse child nodes
5277 * tools/dbus-viewer.c: more hacking on the dbus-viewer
5279 * glib/dbus-gutils.c (_dbus_gutils_split_path): add a file to
5280 contain functions shared between the convenience lib and the
5283 * glib/Makefile.am (libdbus_glib_1_la_LDFLAGS): add
5284 -export-symbols-regex to the GLib library
5286 * dbus/dbus-object-tree.c (_dbus_object_tree_dispatch_and_unlock):
5287 fix the locking in here, and add a default handler for
5288 Introspect() that just returns sub-nodes.
5290 2003-09-14 Havoc Pennington <hp@pobox.com>
5292 * glib/dbus-gthread.c (dbus_g_thread_init): rename to make g_foo
5293 rather than gfoo consistent
5295 * glib/dbus-gproxy.h: delete for now, move contents to
5296 dbus-glib.h, because the include files don't work right since we
5297 aren't in the dbus/ subdir.
5299 * glib/dbus-gproxy.c (dbus_gproxy_send): finish implementing
5300 (dbus_gproxy_end_call): finish
5301 (dbus_gproxy_begin_call): finish
5303 * glib/dbus-gmain.c (dbus_set_g_error): new
5305 * glib/dbus-gobject.c (handle_introspect): include information
5306 about child nodes in the introspection
5308 * dbus/dbus-connection.c (dbus_connection_list_registered): new
5309 function to help in implementation of introspection
5311 * dbus/dbus-object-tree.c
5312 (_dbus_object_tree_list_registered_and_unlock): new function
5314 2003-09-12 Havoc Pennington <hp@pobox.com>
5316 * glib/dbus-gidl.h: add common base class for all the foo_info
5319 * tools/dbus-viewer.c: add GTK-based introspection UI thingy
5322 * test/Makefile.am: try test srcdir -ef . in addition to test
5323 srcdir = ., one of them should work (yeah lame)
5325 * glib/Makefile.am: build the "idl" parser stuff as a convenience
5328 * glib/dbus-gparser.h: make description_load routines return
5329 NodeInfo* not Parser*
5331 * Makefile.am (SUBDIRS): build test dir after all library dirs
5333 * configure.in: add GTK+ detection
5335 2003-09-07 Havoc Pennington <hp@pobox.com>
5337 * Make Doxygen contented.
5339 2003-09-07 Havoc Pennington <hp@pobox.com>
5341 * doc/dbus-specification.sgml: more updates
5343 2003-09-06 Havoc Pennington <hp@pobox.com>
5345 * doc/dbus-specification.sgml: partial updates
5347 * bus/dbus-daemon-1.1.in: fix the config file docs for the
5348 zillionth time; hopefully I edited the right file this time.
5350 * bus/config-parser.c (append_rule_from_element): support
5351 send_type, send_path, receive_type, receive_path
5353 * bus/policy.c: add message type and path to the list of things
5354 that can be "firewalled"
5356 2003-09-06 Havoc Pennington <hp@pobox.com>
5358 * dbus/dbus-connection.c (dbus_connection_register_fallback): add this
5359 (dbus_connection_register_object_path): make this not handle
5360 messages to paths below the given path
5362 2003-09-03 Havoc Pennington <hp@pobox.com>
5364 * test/glib/Makefile.am: add this with random glib-linked test
5367 * glib/Makefile.am: remove the random test programs from here,
5368 leave only the unit tests
5370 * glib/dbus-gobject.c (_dbus_gobject_test): add test for
5371 uscore/javacaps conversion, and fix
5372 (get_object_property, set_object_property): change to .NET
5373 convention for mapping props to methods, set_FooBar/get_FooBar,
5374 since one language has such a convention we may as well copy it.
5375 Plus real methods in either getFooBar or get_foo_bar style won't
5376 collide with this convention.
5378 2003-09-01 Havoc Pennington <hp@pobox.com>
5380 * glib/dbus-gparser.c: implement
5382 * glib/dbus-gobject.c: start implementing skeletons support
5384 * configure.in: when disabling checks/assert, also define
5385 G_DISABLE_ASSERT and G_DISABLE_CHECKS
5387 2003-09-01 Havoc Pennington <hp@pobox.com>
5389 * glib/Makefile.am: rearrange a bunch of files and get "make
5390 check" framework set up
5392 2003-08-31 Havoc Pennington <hp@pobox.com>
5394 * fix build with --disable-tests
5396 2003-08-30 Havoc Pennington <hp@pobox.com>
5398 * dbus/dbus-connection.c: purge DBusMessageHandler
5400 * dbus/dbus-message-handler.c: remove DBusMessageHandler, just
5401 use callbacks everywhere
5403 2003-08-30 Havoc Pennington <hp@pobox.com>
5405 * test/data/valid-config-files/system.d/test.conf: change to
5406 root for the user so warnings don't get printed
5408 * dbus/dbus-message.c: add dbus_message_get_path,
5409 dbus_message_set_path
5411 * dbus/dbus-object-tree.c (do_test_dispatch): add test of
5412 dispatching to a path
5414 * dbus/dbus-string.c (_dbus_string_validate_path): add
5416 * dbus/dbus-marshal.c (_dbus_demarshal_object_path): implement
5417 (_dbus_marshal_object_path): implement
5419 * dbus/dbus-protocol.h (DBUS_HEADER_FIELD_PATH): new header field
5420 to contain the path to the target object
5421 (DBUS_HEADER_FIELD_SENDER_SERVICE): rename
5422 DBUS_HEADER_FIELD_SENDER to explicitly say it's the sender service
5424 2003-08-30 Havoc Pennington <hp@pobox.com>
5426 * dbus/dbus-object-tree.c: write tests and fix the discovered bugs
5428 2003-08-29 Havoc Pennington <hp@pobox.com>
5430 * dbus/dbus-object-tree.c: modify to allow overlapping paths to be
5432 (struct DBusObjectSubtree): shrink this
5433 a lot, since we may have a lot of them
5434 (_dbus_object_tree_free_all_unlocked): implement
5435 (_dbus_object_tree_dispatch_and_unlock): implement
5437 2003-08-29 Havoc Pennington <hp@pobox.com>
5439 * dbus/dbus-internals.h: fix _DBUS_N_GLOBAL_LOCKS
5441 2003-08-28 Havoc Pennington <hp@pobox.com>
5445 * dbus/dbus-connection.c: port to no ObjectID, create a
5446 DBusObjectTree, rename ObjectTree to ObjectPath in public API
5448 * dbus/dbus-connection.h (struct DBusObjectTreeVTable): delete
5449 everything except UnregisterFunction and MessageFunction
5451 * dbus/dbus-marshal.c: port away from DBusObjectID,
5452 add DBUS_TYPE_OBJECT_PATH
5454 * dbus/dbus-object-registry.[hc], dbus/dbus-object.[hc],
5455 dbus/dbus-objectid.[hc]: remove these, we are moving to
5456 path-based object IDs
5458 2003-08-25 Havoc Pennington <hp@pobox.com>
5460 Just noticed that dbus_message_test is hosed, I wonder when I
5461 broke that. I thought make check was passing earlier...
5463 * dbus/dbus-object-tree.c: add new "object tree" to match DCOP
5464 container tree, will replace most of dbus-object-registry
5466 * dbus/dbus-string.c (_dbus_string_append_printf_valist): fix C99
5469 2003-08-19 Havoc Pennington <hp@pobox.com>
5471 * dbus/dbus-message.c (decode_string_field): support FIELD_SENDER
5472 (dbus_message_is_error): fix this function
5474 * bus/dbus-daemon-1.1: clarify logic on when <deny>/<allow> rules
5477 * bus/policy.c (bus_client_policy_check_can_receive): fix code to
5478 reflect clarified man page
5479 (bus_client_policy_check_can_send): ditto
5481 * bus/session.conf.in: fixup
5483 * bus/system.conf.in: fixup
5485 2003-08-18 Havoc Pennington <hp@redhat.com>
5487 * dbus/dbus-hash.c (_dbus_hash_table_insert_two_strings): fix
5489 * dbus/dbus-message.c (_dbus_message_loader_queue_messages): fix
5490 dumb bug created earlier (wrong order of args to
5491 decode_header_data())
5493 * tools/dbus-send.c: port
5495 * tools/dbus-print-message.c (print_message): port
5497 * test/data/*messages: port all messages over
5499 * dbus/dbus-message-builder.c: support including
5502 * bus/driver.c: port over
5504 * bus/dispatch.c: port over to new stuff
5506 * dbus/dbus-connection.c (_dbus_connection_new_for_transport):
5507 rename disconnect signal to "Disconnected"
5509 2003-08-17 Havoc Pennington <hp@pobox.com>
5511 This doesn't compile yet, but syncing up so I can hack on it from
5512 work. What are branches for if not broken code? ;-)
5514 * dbus/dbus-protocol.h: remove DBUS_HEADER_FIELD_NAME, add
5515 DBUS_HEADER_FIELD_INTERFACE, DBUS_HEADER_FIELD_MEMBER,
5516 DBUS_HEADER_FIELD_ERROR_NAME
5518 * dbus/dbus-hash.c: Introduce DBUS_HASH_TWO_STRINGS as hack to use
5519 for the interface+member pairs
5520 (string_hash): change to use g_str_hash algorithm
5521 (find_direct_function, find_string_function): refactor these to
5524 * dbus/dbus-message.c: port all of this over to support
5525 interface/member fields instead of name field
5527 * dbus/dbus-object-registry.c: port over
5529 * dbus/dbus-string.c (_dbus_string_validate_interface): rename
5530 from _dbus_string_validate_name
5532 * bus/dbus-daemon-1.1: change file format for the
5533 <deny>/<allow> stuff to match new message naming scheme
5535 * bus/policy.c: port over
5537 * bus/config-parser.c: parse new format
5539 2003-08-16 Havoc Pennington <hp@pobox.com>
5541 * dbus/dbus-object-registry.c (add_and_remove_objects): remove
5544 * glib/dbus-gproxy.c: some hacking
5546 2003-08-15 Havoc Pennington <hp@redhat.com>
5548 * dbus/dbus-pending-call.c (dbus_pending_call_block): implement
5550 * dbus/dbus-connection.c
5551 (dbus_connection_send_with_reply_and_block): factor out internals;
5552 change to convert any error replies to DBusError instead of
5553 returning them as a message
5555 2003-08-15 Havoc Pennington <hp@pobox.com>
5557 * dbus/dbus-connection.c,
5558 dbus/dbus-pending-call.c: Finish the pending call stuff
5560 2003-08-14 Havoc Pennington <hp@redhat.com>
5562 * dbus/dbus-pending-call.c: start on new object that will replace
5563 DBusMessageHandler and ReplyHandlerData for tracking outstanding
5566 * dbus/dbus-gproxy.c: start on proxy object used to communicate
5567 with remote interfaces
5569 * dbus/dbus-gidl.c: do the boring boilerplate in here
5571 2003-08-12 Havoc Pennington <hp@pobox.com>
5573 * bus/dispatch.c (bus_dispatch): make this return proper
5574 DBusHandlerResult to avoid DBUS_ERROR_UNKNOWN_METHOD
5576 * dbus/dbus-errors.c (dbus_set_error): use
5577 _dbus_string_append_printf_valist
5579 * dbus/dbus-string.c (_dbus_string_append_printf_valist)
5580 (_dbus_string_append_printf): new
5582 * dbus/dbus-errors.h (DBUS_ERROR_UNKNOWN_MESSAGE): change to
5585 * dbus/dbus-connection.c (dbus_connection_dispatch): handle
5586 DBUS_HANDLER_RESULT_NEED_MEMORY; send default error reply if a
5587 message is unhandled.
5589 2003-08-11 Havoc Pennington <hp@pobox.com>
5591 * bus/test.c (client_disconnect_handler): change to return
5592 HANDLED (would have been REMOVE_MESSAGE)
5594 * dbus/dbus-object.h (enum DBusHandlerResult): rename to
5595 HANDLED/NOT_YET_HANDLED instead of
5596 REMOVE_MESSAGE/ALLOW_MORE_HANDLERS to make it clearer how it
5599 2003-08-10 Havoc Pennington <hp@pobox.com>
5601 * tools/dbus-send.c (main): add --type argument, for now
5602 supporting only method_call and signal types.
5604 * tools/dbus-print-message.c: print message type
5606 * dbus/dbus-connection.c (_dbus_connection_new_for_transport):
5607 init connection->objects
5609 * doc/dbus-specification.sgml: fix sgml
5611 * bus/*.c: port over to object-instance API changes
5613 * test/test-service.c: ditto
5615 * dbus/dbus-message.c (dbus_message_create_header): allow #NULL
5616 name, we will have to fix up the rest of the code to also handle
5618 (dbus_message_new): generic message-creation call
5619 (set_string_field): allow appending name field
5621 2003-08-06 Havoc Pennington <hp@pobox.com>
5623 * dbus/dbus-object-registry.c: implement signal connection
5626 * dbus/dbus-connection.c (_dbus_connection_unref_unlocked): new
5628 * dbus/dbus-internals.c (_dbus_memdup): new function
5630 2003-08-02 Havoc Pennington <hp@pobox.com>
5632 * dbus/dbus-message.c (dbus_message_get_no_reply)
5633 (dbus_message_set_no_reply): add these and remove
5634 set_is_error/get_is_error
5636 * dbus/dbus-protocol.h, doc/dbus-specification.sgml:
5637 remove the ERROR flag, since there's now an ERROR type
5639 2003-08-01 Havoc Pennington <hp@pobox.com>
5641 * dbus/dbus-object-registry.c (_dbus_object_registry_handle_and_unlock):
5644 * dbus/dbus-message.c (dbus_message_get_type): new function
5646 * doc/dbus-specification.sgml: add "type" byte to messages
5648 2003-08-01 Havoc Pennington <hp@pobox.com>
5650 * dbus/dbus-protocol.h (DBUS_MESSAGE_TYPE_*): introduce
5651 a message type enum to distinguish kinds of message
5652 (DBUS_HEADER_FLAG_NO_REPLY_EXPECTED): flag for a message
5653 that need not be replied to
5655 2003-08-01 Havoc Pennington <hp@pobox.com>
5657 * dbus/dbus-marshal.c: adapt to DBusObjectID changes
5658 (unpack_8_octets): fix no-64-bit-int bug
5660 * dbus/dbus-object-registry.c (validate_id): validate the
5661 connection ID bits, not just the instance ID.
5663 * dbus/dbus-connection.c (_dbus_connection_init_id): initialize
5664 the connection-global 33 bits of the object ID
5666 * dbus/dbus-object-registry.c (info_from_entry): fill in
5667 object ID in the new way
5669 * dbus/dbus-objectid.h: rather than high/low bits, specifically
5670 define server/client/instance bits.
5672 2003-07-30 Havoc Pennington <hp@pobox.com>
5674 * dbus/dbus-connection.c (dbus_connection_register_object): fix
5677 2003-07-13 Havoc Pennington <hp@pobox.com>
5679 * dbus/dbus-object.h (struct DBusObjectVTable): add padding
5680 fields to DBusObjectVTable and DBusObjectInfo
5682 2003-07-12 Havoc Pennington <hp@pobox.com>
5684 * dbus/dbus-object-registry.c: implement unit test,
5685 fix bugs discovered in process
5687 * dbus/dbus-connection.c: remove handler_table and
5688 register_handler(), add DBusObjectRegistry usage
5690 * dbus/dbus-objectid.c (dbus_object_id_is_null)
5691 (dbus_object_id_set_null): new functions
5693 2003-07-08 Havoc Pennington <hp@pobox.com>
5695 * dbus/dbus-object.c: implement some of this
5697 * dbus/dbus-object-registry.c
5698 (_dbus_object_registry_add_and_unlock): fill in the object_id out
5700 (_dbus_object_registry_new): handle OOM
5702 2003-07-08 Havoc Pennington <hp@pobox.com>
5704 * dbus/dbus-object.h: sketch out an API for registering objects
5705 with a connection, that allows us to use as little as 24 bytes
5706 per object and lets application code represent an object in
5707 any conceivable way.
5709 * dbus/dbus-object-registry.c: implement the hard bits of the
5710 DBusConnection aspect of object API. Not yet wired up.
5712 2003-07-06 Havoc Pennington <hp@pobox.com>
5714 * dbus/dbus-marshal.c (_dbus_marshal_set_object_id): new function
5715 (_dbus_marshal_object_id): new
5716 (_dbus_demarshal_object_id): new
5717 (_dbus_marshal_get_arg_end_pos): support object ID type, and
5718 consolidate identical switch cases. Don't conditionalize handling
5719 of DBUS_TYPE_UINT64, need to handle the type always.
5720 (_dbus_marshal_validate_arg): consolidate identical cases, and
5721 handle DBUS_TYPE_OBJECT_ID
5723 * dbus/dbus-objectid.c: new file with DBusObjectID data type.
5725 * dbus/dbus-protocol.h: add DBUS_TYPE_OBJECT_ID
5727 2003-09-28 Havoc Pennington <hp@pobox.com>
5731 2003-09-28 Havoc Pennington <hp@pobox.com>
5733 * doc/Makefile.am (dbus-specification.html): testing a funky hack
5734 to work with Debian db2html
5736 2003-09-28 Havoc Pennington <hp@pobox.com>
5738 * configure.in: 0.13
5740 * doc/Makefile.am (dbus-test-plan.html): accept nonexistence of
5741 stylesheet-images for benefit of Debian
5743 Change back to using filesystem-linked sockets for the system
5744 bus, so only root can create the default system bus address.
5746 * bus/system.conf.in: change to use
5747 DBUS_SYSTEM_BUS_DEFAULT_ADDRESS
5749 * dbus/Makefile.am (INCLUDES): remove DBUS_SYSTEM_BUS_PATH define
5752 * configure.in: define DBUS_SYSTEM_BUS_DEFAULT_ADDRESS
5753 here, and AC_DEFINE DBUS_SYSTEM_PATH
5755 2003-08-09 Anders Carlsson <andersca@codefactory.se>
5758 * doc/busconfig.dtd:
5761 2003-08-09 Anders Carlsson <andersca@codefactory.se>
5763 * doc/dbus-specification.sgml:
5764 Add activation reply values.
5766 2003-08-05 Havoc Pennington <hp@redhat.com>
5768 * configure.in: 0.12
5770 2003-08-05 Anders Carlsson <andersca@codefactory.se>
5772 * glib/dbus-gmain.c: (watch_fd_new), (watch_fd_ref),
5773 (watch_fd_unref), (dbus_gsource_check), (dbus_gsource_dispatch),
5774 (add_watch), (remove_watch), (create_source):
5775 Refcount fds, fixes some reentrancy issues.
5777 2003-07-30 Havoc Pennington <hp@redhat.com>
5779 * dbus/dbus-bus.c (init_connections_unlocked): fix default system
5780 bus address to be abstract if we have abstract sockets
5784 2003-07-28 Havoc Pennington <hp@redhat.com>
5786 * bus/messagebus.in: fix to avoid processname/servicename
5787 confusion, from Michael Kearey
5788 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=100965
5790 2003-07-23 Havoc Pennington <hp@pobox.com>
5792 * dbus/dbus-message.c (dbus_message_iter_get_named):
5793 fix from Andy Hanton to remove broken "+1"
5795 2003-07-16 Havoc Pennington <hp@pobox.com>
5797 * tools/dbus-launch.c (babysit): close stdout/stderr in the
5798 babysitter process, as suggested by Thomas Leonard, so
5799 an "eval `dbus-launch --exit-with-session`" will actually
5802 2003-07-16 Havoc Pennington <hp@pobox.com>
5804 * configure.in: print out EXPANDED_* variables in the summary at
5805 the end; clean up the code that computes EXPANDED_ variables and
5806 get the ones using exec_prefix right. Should make things work
5807 when you build without --prefix
5809 2003-06-29 Havoc Pennington <hp@pobox.com>
5811 * mono/Test.cs (class Test): fire up a main loop and run it
5813 * mono/DBus.cs (DBus): don't g_thread_init since it can only be
5814 done once, the app has to do it
5816 2003-06-26 Havoc Pennington <hp@pobox.com>
5818 * mono/Connection.cs: set up connection with the glib main loop
5820 2003-07-01 Havoc Pennington <hp@redhat.com>
5822 * doc/dbus-specification.sgml: clarify the format of a type code,
5823 change suggested by Jim Blandy
5825 2003-06-29 Miloslav Trmac <mitr@volny.cz>
5828 * tools/Makefile.am: Don't assume srcdir == builddir.
5830 * dbus/dbus-memory.c (dbus_realloc): Don't check guards after shrinking
5831 the allocated block.
5832 (_dbus_memory_test): New function.
5833 * dbus/dbus-test.h: Add _dbus_memory_test ().
5834 * dbus/dbus-test.c (dbus_internal_do_not_use_run_tests): Call it.
5836 * dbus/dbus-message.c (decode_header_data): Use %.4s instead
5838 (dbus_message_new): Remove obsolete @todo.
5840 * dbus/dbus-marshal.c (_dbus_marshal_set_int64)
5841 (_dbus_marshal_set_uint64): Fix comment.
5843 * dbus/dbus-message.c (append_int_field, append_uint_field): Don't
5844 hardcode FIELD_REPLY_SERIAL.
5846 * dbus/dbus-mainloop.c (_dbus_loop_remove_watch)
5847 (_dbus_loop_remove_timeout): Cast function pointers to (void *) for %p
5849 * configure.in: Add -D_POSIX_C_SOURCE=199309L -DBSD_SOURCE to CFLAGS
5850 and disable DBUS_USE_ATOMIC_INT_486 when --enable-ansi is used
5852 2003-06-24 Havoc Pennington <hp@pobox.com>
5854 * mono/*.cs: Use IntPtr.Zero instead of ((IntPtr) 0)
5856 2003-06-23 Anders Carlsson <andersca@codefactory.se>
5862 * gcj/TestMessage.java: (TestMessage), (TestMessage.main):
5863 * gcj/org/.cvsignore:
5864 * gcj/org/Makefile.am:
5865 * gcj/org/freedesktop/.cvsignore:
5866 * gcj/org/freedesktop/Makefile.am:
5867 * gcj/org/freedesktop/dbus/.cvsignore:
5868 * gcj/org/freedesktop/dbus/Makefile.am:
5869 * gcj/org/freedesktop/dbus/Message.java: (Message),
5871 * gcj/org/freedesktop/dbus/natMessage.cc:
5872 Fix the build system.
5874 2003-06-22 Havoc Pennington <hp@pobox.com>
5876 * mono/Connection.cs: add more bindings
5878 * dbus/dbus-threads.c (dbus_threads_init): allow calling this
5881 2003-06-22 Havoc Pennington <hp@pobox.com>
5883 * mono/Connection.cs, mono/DBus.cs, mono/Error.cs:
5884 Start wrapping more stuff.
5886 2003-06-22 Havoc Pennington <hp@pobox.com>
5888 * mono/Message.cs: implement Message.Wrap() that ensures we only
5889 have a single C# wrapper per DBusMessage, assuming it works which
5890 it probably doesn't.
5892 * dbus/dbus-message.c (dbus_message_allocate_data_slot): new
5893 (dbus_message_free_data_slot): new
5894 (dbus_message_set_data): new
5895 (dbus_message_get_data): new
5897 2003-06-22 Havoc Pennington <hp@pobox.com>
5899 * dbus/dbus-dataslot.c (_dbus_data_slot_allocator_unref)
5900 (_dbus_data_slot_allocator_alloc): rework these to keep a
5901 reference count on each slot and automatically manage a global
5902 slot ID variable passed in by address
5904 * bus/bus.c: convert to new dataslot API
5906 * dbus/dbus-bus.c: convert to new dataslot API
5908 * dbus/dbus-connection.c: convert to new dataslot API
5910 * dbus/dbus-server.c: convert to new dataslot API
5912 * glib/dbus-gmain.c: ditto
5916 * bus/connection.c: ditto
5918 2003-06-22 Anders Carlsson <andersca@codefactory.se>
5920 * configure.in: Add AM_PROG_GCJ and move AM_PROG_LIBTOOL
5921 after the gcj checks so that the correct configuration tags
5922 will be added to libtool.
5924 * dbus-glib-1.pc.in: No need to specify any includes since
5925 dbus-1.pc.in has those.
5927 2003-06-22 Havoc Pennington <hp@pobox.com>
5929 * mono/*, gcj/*, configure.in, Makefile.am:
5930 Check in makefiles and subdirs for mono and gcj bindings.
5931 Neither binding actually exists, just trying to get through
5932 all the build and other boring bits.
5934 2003-06-21 Philip Blundell <philb@gnu.org>
5936 * tools/dbus-monitor.1: Updated.
5938 * tools/dbus-send.1: Likewise.
5940 2003-06-20 Anders Carlsson <andersca@codefactory.se>
5942 * dbus/dbus-transport-unix.c (unix_handle_watch): Check
5943 for hangup and error after checking read so we won't discard
5944 pending data if both hangup and read are set.
5946 2003-06-19 Philip Blundell <philb@gnu.org>
5948 * tools/dbus-print-message.c (print_message): Handle BOOLEAN.
5950 * tools/dbus-send.c: Accept both --system and --session.
5952 * tools/dbus-monitor.c: Same here.
5954 2003-06-19 Anders Carlsson <andersca@codefactory.se>
5956 * glib/dbus-glib.h: Fix so that dbus-glib.h can be used
5957 from C++ (Patch by Miloslav Trmac).
5959 2003-06-15 Joe Shaw <joe@assbarn.com>
5961 * configure.in: Check for socklen_t.
5963 * dbus/dbus-sysdeps.c: Define socklen_t if it's not defined.
5965 * test/test-segfault.c: Add #include <sys/time.h>
5967 * tools/Makefile.am: Add DBUS_X_CFLAGS to the INCLUDES since
5968 dbus-launch needs it.
5970 2003-06-09 Havoc Pennington <hp@redhat.com>
5972 * dbus/dbus-sysdeps.c (_dbus_listen_unix_socket): don't use
5973 SUN_LEN, it breaks abstract socket usage
5975 * dbus/dbus-internals.c (_dbus_verbose_real): only print PID at
5978 2003-06-04 Havoc Pennington <hp@pobox.com>
5980 * dbus/dbus-server.c (dbus_server_listen): allow abstract sockets
5981 using unix:abstract=/foo, and when listening in a tmpdir
5982 i.e. unix:tmpdir=/tmp, always use abstract sockets if we can.
5984 * dbus/dbus-transport.c (_dbus_transport_open): support
5987 * dbus/dbus-server-unix.c (_dbus_server_new_for_domain_socket):
5988 support abstract sockets
5990 * dbus/dbus-transport-unix.c
5991 (_dbus_transport_new_for_domain_socket): support abstract sockets
5993 * dbus/dbus-sysdeps.c (_dbus_connect_unix_socket): add "abstract"
5994 toggle as an argument, implement abstract namespace support
5995 (_dbus_listen_unix_socket): ditto
5997 * configure.in: add --enable-abstract-sockets and implement
5998 a configure check for autodetection of the right value.
6000 2003-06-01 Havoc Pennington <hp@pobox.com>
6002 * tools/dbus-cleanup-sockets.c: add utility to clean up sockets
6003 in /tmp (though on Linux this will end up being useless,
6004 when we add abstract namespace support)
6006 * configure.in: define DBUS_SESSION_SOCKET_DIR in addition to
6009 2003-05-28 Colin Walters <walters@verbum.org>
6011 * tools/dbus-monitor.c (main): Fix silly typo (s/--session/--system/).
6013 2003-05-18 Anders Carlsson <andersca@codefactory.se>
6015 * dbus/dbus-message.c (dbus_message_new): Remove @todo.
6017 2003-05-17 Colin Walters <walters@gnu.org>
6019 * tools/dbus-send.c: Don't exit with an error code if --help was
6020 passed. Default to using the session bus instead of the system
6023 * tools/dbus-launch.c: Ditto.
6025 * tools/dbus-monitor.c: Ditto.
6027 * tools/dbus-send.1: Update with new arguments.
6029 * tools/dbus-launch.c: Emit code to export variables. New
6030 arguments -s and -c to specify shell syntax, and a bit of code to
6031 autodetect syntax. Also, allow specifying a program to run.
6033 * tools/dbus-launch.1: Update with new arguments.
6035 * tools/dbus-send.1: Ditto.
6037 * tools/dbus-monitor.1: Ditto.
6039 2003-05-17 Havoc Pennington <hp@pobox.com>
6041 * bus/config-parser.c (merge_included): merge in policies from
6042 child configuration file.
6044 * bus/policy.c (bus_policy_merge): function to merge two policies
6047 2003-05-16 Havoc Pennington <hp@redhat.com>
6049 * dbus/dbus-connection.c: disable verbose lock spew
6051 * tools/dbus-send.c: add --print-reply command line option
6053 * tools/dbus-print-message.h (print_message): new util function
6054 shared by dbus-send and dbus-monitor
6056 * tools/dbus-monitor.c (handler_func): exit on disconnect
6058 * dbus/dbus-transport-unix.c (do_reading): if the transport is
6059 disconnected, don't try to use the read_watch
6061 * dbus/dbus-watch.c (dbus_watch_get_enabled): assert watch != NULL
6062 so we can find this bug more easily
6064 2003-05-16 Havoc Pennington <hp@redhat.com>
6066 * bus/policy.c (free_rule_list_func): avoid a crash when passed
6067 NULL as DBusHashTable is annoyingly likely to do.
6069 2003-05-16 Colin Walters <walters@verbum.org>
6071 * tools/dbus-monitor.c: Add --session argument and usage()
6074 * tools/dbus-monitor.1: Update with new --session arg.
6076 * bus/Makefile.am (install-data-hook): Create
6077 $(libdir)/dbus-1.0/services so that the session bus is happy.
6079 2003-05-15 Havoc Pennington <hp@redhat.com>
6081 * dbus/dbus-sysdeps.c (_dbus_atomic_dec, _dbus_atomic_inc): work
6082 on non-x86. ifdef's are evil.
6084 2003-05-15 Havoc Pennington <hp@redhat.com>
6086 * configure.in: 0.11
6090 * bus/Makefile.am (initddir): apparently we are supposed to put
6091 init scripts in /etc/rc.d/init.d not /etc/init.d
6093 * bus/Makefile.am: remove the "you must --enable-tests to make
6094 check" as it broke distcheck
6096 * bus/Makefile.am (install-data-hook): create /etc/dbus-1/system.d
6098 2003-05-13 James Willcox <jwillcox@gnome.org>
6101 * bus/activation.c: (bus_activation_service_created),
6102 (bus_activation_activate_service):
6103 * bus/driver.c: (bus_driver_send_service_deleted),
6104 (bus_driver_send_service_created), (bus_driver_send_service_lost),
6105 (bus_driver_send_service_acquired),
6106 (bus_driver_send_welcome_message),
6107 (bus_driver_handle_list_services):
6108 * bus/session.conf.in:
6109 * dbus/dbus-bus.c: (dbus_bus_acquire_service),
6110 (dbus_bus_service_exists), (dbus_bus_activate_service):
6113 Add some convenience API which lets you activate a service, and did a
6114 bunch of s/0/DBUS_TYPE_INVALID/ in calls to dbus_message_append_args()
6115 and dbus_message_get_args()
6117 2003-05-11 Havoc Pennington <hp@pobox.com>
6119 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): fix to avoid
6120 calling _dbus_marshal_validate_arg() for every byte in a byte
6123 * dbus/dbus-message-handler.c: use atomic reference counting to
6124 reduce number of locks slightly; the global lock in here sucks
6126 * dbus/dbus-connection.c
6127 (_dbus_connection_update_dispatch_status_and_unlock): variant of
6128 update_dispatch_status that can be called with lock held; then use
6129 in a couple places to reduce locking/unlocking
6130 (dbus_connection_send): hold the lock over the whole function
6131 instead of acquiring it twice.
6133 * dbus/dbus-timeout.c (_dbus_timeout_new): handle OOM
6135 * bus/connection.c (bus_connections_setup_connection): fix access
6136 to already-freed memory.
6138 * dbus/dbus-connection.c: keep a little cache of linked list
6139 nodes, to avoid using the global linked list alloc lock in the
6140 normal send-message case. Instead we just use the connection lock
6141 that we already have to take.
6143 * dbus/dbus-list.c (_dbus_list_find_last): new function
6145 * dbus/dbus-sysdeps.c (_dbus_atomic_inc, _dbus_atomic_dec):
6146 change to use a struct for the atomic type; fix docs,
6147 they return value before increment, not after increment.
6149 * dbus/dbus-string.c (_dbus_string_append_4_aligned)
6150 (_dbus_string_append_8_aligned): new functions to try to
6151 microoptimize this operation.
6152 (reallocate_for_length): break this out of set_length(), to
6153 improve profile info, and also so we can consider inlining the
6156 * dbus/dbus-message.c (dbus_message_new_empty_header): init data
6157 strings with some preallocation, cuts down on our calls to realloc
6158 a fair bit. Though if we can get the "move entire string to empty
6159 string" optimization below to kick in here, it would be better.
6161 * dbus/dbus-string.c (_dbus_string_move): just call
6162 _dbus_string_move_len
6163 (_dbus_string_move_len): add a special case for moving
6164 an entire string into an empty string; we can just
6165 swap the string data instead of doing any reallocs.
6166 (_dbus_string_init_preallocated): new function
6168 2003-05-11 Havoc Pennington <hp@pobox.com>
6170 Write a "test-profile" that does echo client-server with threads;
6171 profile reveals lock contention, memcpy/realloc of buffers, and
6172 UTF-8 validation as hot spots. 20% of lock contention eliminated
6173 with dbus_atomic_inc/dec implementation on x86. Much remaining
6174 contention is global mempool locks for GList and DBusList.
6176 * dbus/dbus-sysdeps.c (_dbus_atomic_inc, _dbus_atomic_dec): add
6179 * dbus/dbus-connection.c (struct DBusConnection): use
6180 dbus_atomic_t for the reference count
6182 * dbus/dbus-message.c (struct DBusMessage): declare
6183 dbus_atomic_t values as volatile
6185 * configure.in: code to detect ability to use atomic integer
6186 operations in assembly, from GLib patch
6188 * dbus/dbus-internals.c (_dbus_verbose_real): call getpid every
6189 time, tired of it being wrong in threads and forked processes
6191 * glib/test-profile.c: a little program to bounce messages back
6192 and forth between threads and eat CPU
6194 * dbus/dbus-connection.c: add debug spew macros for debugging
6195 thread locks; include config.h at top; fix deadlock in
6196 dbus_connection_flush()
6198 2003-05-08 Havoc Pennington <hp@pobox.com>
6200 * dbus/dbus-spawn.c: s/_exit/exit/ because it was keeping gcov
6201 data from getting written, and there wasn't a good reason to
6204 * test/decode-gcov.c (mark_inside_dbus_build_tests): don't count
6205 dbus_verbose lines in test coverage
6206 (main): add list of functions sorted by # of untested blocks
6207 to the coverage report
6209 * dbus/dbus-mempool.c: put some test-only code in DBUS_BUILD_TESTS
6211 * dbus/dbus-marshal.c (_dbus_marshal_test): extend test coverage
6213 * dbus/dbus-message-handler.c (_dbus_message_handler_test):
6214 extend test coverage
6216 * test/data/auth/cancel.auth-script: test canceling an
6219 * dbus/Makefile.am: remove dbus-server-debug.[hc] for now, as they
6220 aren't used. in CVS history if we end up needing them.
6222 2003-05-04 Havoc Pennington <hp@pobox.com>
6224 * dbus/dbus-message-handler.c (_dbus_message_handler_test): add
6227 * dbus/dbus-marshal.c (_dbus_demarshal_string_array): fix this
6228 function, which assumed length was in # of strings, not bytes
6230 * dbus/dbus-message.c (_dbus_message_test): add tests for some
6233 * dbus/dbus-connection.c
6234 (_dbus_connection_queue_received_message): disable function for
6235 now, we are only using it in test mode
6237 * dbus/dbus-message.c (_dbus_message_loader_queue_messages):
6238 remove a mistaken FIXME
6240 2003-05-04 Havoc Pennington <hp@pobox.com>
6242 * dbus/dbus-connection.c (dbus_connection_preallocate_send):
6243 unlock mutex on successful return, patch from Anders Gustafsson
6245 2003-05-04 Havoc Pennington <hp@pobox.com>
6247 * dbus-glib-1.pc.in (Requires): fix dependencies, from
6250 2003-05-04 Havoc Pennington <hp@pobox.com>
6252 * tools/dbus-launch.c: implement
6254 * bus/main.c (main), bus/bus.c (bus_context_new):
6255 implement --print-pid and --fork
6257 2003-05-03 Havoc Pennington <hp@redhat.com>
6259 * dbus/dbus-address.c (dbus_parse_address): fix bug when a key in
6260 the address had no value, and add to test suite. Fix and
6261 regression test from Miloslav Trmac
6263 2003-05-03 Havoc Pennington <hp@pobox.com>
6265 * dbus/dbus-watch.c (dbus_watch_handle): warn and return if a
6266 watch is invalid when handled
6268 * tools/Makefile.am, tools/dbus-launch.c, tools/dbus-launch.1: add
6269 dbus-launch utility to launch the bus from a shell script. Didn't
6270 actually implement dbus-launch yet, it's just a placeholder still.
6272 2003-05-03 Havoc Pennington <hp@pobox.com>
6274 * bus/Makefile.am, bus/dbus-daemon-1.1.in: man page for the
6275 daemon; also documents daemon config file, so replaces
6276 doc/config-file.txt. Corrected some stuff from config-file.txt in
6277 the process of moving it.
6279 2003-05-03 Havoc Pennington <hp@pobox.com>
6281 * tools/Makefile.am, tools/dbus-send.1, tools/dbus-monitor.1:
6284 2003-05-03 Colin Walters <walters@verbum.org>
6286 * dbus/dbus-sysdeps.c (fill_user_info): Test against
6287 DBUS_UID_UNSET to determine whether to do a uid lookup or not.
6289 * Makefile.am: Update to use new .pc versioning scheme.
6291 2003-05-02 Havoc Pennington <hp@redhat.com>
6293 * bus/system.conf.in: allow send/receive to/from message bus
6296 2003-04-30 Havoc Pennington <hp@redhat.com>
6298 * configure.in: print a note when building with unit tests and
6301 2003-04-30 Havoc Pennington <hp@redhat.com>
6303 * Makefile.am: add a check-local that complains if you didn't
6304 configure with --enable-tests
6306 2003-04-29 Havoc Pennington <hp@redhat.com>
6308 * glib/dbus-gmain.c: docs cleanups
6310 * dbus/dbus-types.h: add docs on int64 types
6312 * dbus/dbus-memory.c: fix docs to avoid putting private API in
6313 public API docs section
6315 2003-04-29 Havoc Pennington <hp@redhat.com>
6317 * dbus-1.pc.in, dbus-glib-1.pc.in: rename these from
6318 dbus-1.0.pc.in, dbus-glib-1.0.pc.in. As these change with the
6319 parallel install API version, not with the D-BUS package version.
6321 * HACKING: move some of README over here
6323 * README: updates, and document API/ABI policy
6325 * configure.in: reindentation
6327 2003-04-29 Havoc Pennington <hp@redhat.com>
6329 * dbus/dbus.h: add "you have to define DBUS_API_SUBJECT_TO_CHANGE
6330 to use this library" to be sure people have the right
6333 2003-04-28 Havoc Pennington <hp@redhat.com>
6335 * configure.in: add --enable-docs which by default is auto yes if
6336 doxygen and db2html found, no otherwise; but can be forced on/off
6338 * doc/Makefile.am: conditionalize whether to build docs on
6341 2003-04-28 Havoc Pennington <hp@redhat.com>
6343 * configure.in: 0.10
6347 * bus/system.conf.in: add <includedir>system.d</includedir>
6349 * dbus/dbus-userdb.c (_dbus_user_database_lookup): fix bug when
6350 username was provided but not uid
6352 * bus/config-parser.c (struct BusConfigParser): keep track of
6353 whether the parser is toplevel or was included; change some
6354 of the error handling if it's included.
6356 2003-04-27 Havoc Pennington <hp@pobox.com>
6360 * dbus/dbus-transport.c (_dbus_transport_get_dispatch_status):
6361 report correct status if we finish processing authentication
6362 inside this function.
6364 * bus/activation.c (try_send_activation_failure): use
6365 bus_transaction_send_error_reply
6367 * bus/connection.c (bus_connection_get_groups): return an error
6368 explaining the problem
6370 * bus/bus.c (bus_context_check_security_policy): implement
6371 restriction here that inactive connections can only send the
6372 hello message. Also, allow bus driver to send anything to
6375 * bus/connection.c (bus_connection_complete): create the
6376 BusClientPolicy here instead of on-demand.
6377 (bus_connection_get_policy): don't return an error
6379 * dbus/dbus-message.c (dbus_message_new_error_reply): allow NULL
6380 sender field in message being replied to
6382 * bus/bus.c (bus_context_check_security_policy): fix silly typo
6383 causing it to return FALSE always
6385 * bus/policy.c (bus_client_policy_check_can_send): fix bug where
6386 we checked sender rather than destination
6388 2003-04-25 Havoc Pennington <hp@redhat.com>
6390 test suite is slightly hosed at the moment, will fix soon
6392 * bus/connection.c (bus_connections_expire_incomplete): fix to
6393 properly disable the timeout when required
6394 (bus_connection_set_name): check whether we can remove incomplete
6395 connections timeout after we complete each connection.
6397 * dbus/dbus-mainloop.c (check_timeout): fix this up a bit,
6398 probably still broken.
6400 * bus/services.c (bus_registry_acquire_service): implement max
6401 number of services owned, and honor allow/deny rules on which
6402 services a connection can own.
6404 * bus/connection.c (bus_connection_get_policy): report errors here
6406 * bus/activation.c: implement limit on number of pending
6409 2003-04-25 Havoc Pennington <hp@redhat.com>
6411 * dbus/dbus-transport.c (_dbus_transport_get_unix_user): fix bug
6412 where we used >= 0 instead of != DBUS_UID_UNSET.
6414 2003-04-25 Havoc Pennington <hp@redhat.com>
6416 * glib/dbus-gmain.c (remove_watch): fix for a crash when watches
6417 were toggled without add/remove, fix from Anders Gustafsson
6419 2003-04-24 Havoc Pennington <hp@redhat.com>
6421 * test/data/valid-config-files/basic.conf: add <limit> tags to
6424 * bus/config-parser.h, bus/config-parser.c, bus/bus.c: Implement
6425 <limit> tag in configuration file.
6427 2003-04-24 Havoc Pennington <hp@redhat.com>
6429 * bus/dispatch.c: somehow missed some name_is
6431 * dbus/dbus-timeout.c (_dbus_timeout_set_enabled)
6432 (_dbus_timeout_set_interval): new
6434 * bus/connection.c (bus_connections_setup_connection): record time
6435 when each connection is first set up, and expire them after the
6436 auth timeout passes.
6438 2003-04-24 Havoc Pennington <hp@redhat.com>
6440 * dbus/dbus-message.c (dbus_message_name_is): rename
6441 (dbus_message_service_is): rename
6442 (dbus_message_sender_is): rename
6443 (dbus_message_get_service): rename
6445 2003-04-24 Havoc Pennington <hp@redhat.com>
6447 * configure.in: add --enable-checks
6449 * dbus/dbus-message.c (dbus_message_new): reverse name/service arguments
6451 * dbus/dbus-connection.c (dbus_connection_preallocate_send): fix
6452 to use thread locks.
6453 (_dbus_connection_handler_destroyed_locked): move some private
6454 functions into proper docs group
6456 * dbus/dbus-internals.h: add _dbus_return_if_fail,
6457 _dbus_return_val_if_fail
6459 Throughout: use dbus_return_if_fail
6461 2003-04-23 James Willcox <jwillcox@gnome.org>
6464 * glib/dbus-gmain.c: (add_timeout), (wakeup_main), (create_source),
6465 (dbus_connection_setup_with_g_main),
6466 (dbus_server_setup_with_g_main):
6467 * glib/test-dbus-glib.c: (main):
6468 * glib/test-thread-client.c: (main):
6469 * glib/test-thread-server.c: (new_connection_callback), (main):
6470 * tools/dbus-monitor.c: (main):
6472 Added a GMainContext argument to dbus_connection_setup_with_g_main()
6473 and dbus_server_setup_with_g_main().
6475 2003-04-20 Havoc Pennington <hp@pobox.com>
6477 * doc/dbus-specification.sgml: document the restrictions on
6478 message and service names
6480 2003-04-22 Havoc Pennington <hp@redhat.com>
6482 * dbus/dbus-message.c, dbus/dbus-marshal.c: add 64-bit integer
6483 support, and do some code cleanups to share more code and
6484 speed up array marshal/demarshal.
6486 * dbus-1.0.pc.in (Cflags): put libdir include file in cflags
6488 * configure.in: generate dbus-arch-deps.h
6490 * dbus/dbus-protocol.h (DBUS_TYPE_INT64, DBUS_TYPE_UINT64): add
6493 2003-04-22 Havoc Pennington <hp@redhat.com>
6495 * test/data/valid-messages/opposite-endian.message: fix test
6496 to use proper type for rply field
6498 * test/data/invalid-messages: add tests for below validation
6500 * dbus/dbus-message.c (decode_header_data): validate field types,
6501 and validate that named fields are valid names
6502 (decode_name_field): consider messages in the
6503 org.freedesktop.Local. namespace to be invalid.
6505 * dbus/dbus-string.c (_dbus_string_validate_name): new
6507 2003-04-19 Havoc Pennington <hp@pobox.com>
6509 * bus/driver.c (bus_driver_handle_hello): check limits and
6510 return an error if they are exceeded.
6512 * bus/connection.c: maintain separate lists of active and inactive
6513 connections, and a count of each. Maintain count of completed
6514 connections per user. Implement code to check connection limits.
6516 * dbus/dbus-list.c (_dbus_list_unlink): export
6518 * bus/bus.c (bus_context_check_security_policy): enforce a maximum
6519 number of bytes in the message queue for a connection
6521 2003-04-18 Havoc Pennington <hp@pobox.com>
6523 * dbus/dbus-auth.c (record_mechanisms): memleak fixes
6525 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): fix some
6528 * dbus/dbus-keyring.c (add_new_key): fix a memleak, and
6529 on realloc be sure to update the pointer in the keyring
6531 * dbus/dbus-string.c (_dbus_string_zero): compensate for align
6532 offset to avoid writing to unallocated memory
6534 * dbus/dbus-auth.c (process_rejected): return FALSE if we fail to
6535 try the next mechanism, so we properly handle OOM
6537 * dbus/dbus-keyring.c (_dbus_keyring_new_homedir): fix double-free
6539 (_dbus_keyring_new): fix OOM bug
6540 (_dbus_keyring_new_homedir): always set error; impose a maximum
6541 number of keys we'll load from the file, mostly to speed up the
6542 test suite and make its OOM checks more useful, but also for
6545 * dbus/dbus-auth.c (process_error_server): reject authentication
6546 if we get an error from the client
6547 (process_cancel): on cancel, send REJECTED, per the spec
6548 (process_error_client): send CANCEL if we get an error from the
6551 2003-04-18 Havoc Pennington <hp@pobox.com>
6553 * dbus/dbus-mainloop.c (_dbus_loop_iterate): fix UMR in verbose
6556 * dbus/dbus-auth.c (handle_client_data_cookie_sha1_mech): fix OOM
6559 * dbus/dbus-keyring.c (_dbus_keyring_new_homedir): only whine
6560 about DBUS_TEST_HOMEDIR once
6562 * bus/Makefile.am (TESTS_ENVIRONMENT): put DBUS_TEST_HOMEDIR in
6565 * bus/dispatch.c (bus_dispatch_sha1_test): actually load sha1
6566 config file so we test the right thing
6568 Throughout: assorted docs improvements
6570 2003-04-18 Havoc Pennington <hp@pobox.com>
6572 * glib/dbus-gmain.c: adapt to watch changes
6574 * bus/bus.c, bus/activation.c, etc.: adjust to watch changes
6576 * dbus/dbus-server.h: remove dbus_server_handle_watch
6578 * dbus/dbus-connection.h: remove dbus_connection_handle_watch
6580 * dbus/dbus-watch.c (dbus_watch_handle): change DBusWatch to work
6581 like DBusTimeout, so we don't need dbus_connection_handle_watch
6584 2003-04-17 Havoc Pennington <hp@redhat.com>
6586 * dbus/dbus-userdb.c, dbus/dbus-sysdeps.c: redo all the passwd
6587 database usage so it all goes via the DBusUserDatabase cache.
6589 2003-04-17 Havoc Pennington <hp@redhat.com>
6591 * dbus/dbus-mainloop.c (_dbus_loop_iterate): fix logic so that if
6592 there was an OOM watch we skipped, we always return TRUE so we
6593 iterate again to have a look at it again. Fixes test suite hang.
6594 Code rearrangement also lets us lose some memset and only iterate
6595 over callbacks once.
6597 * bus/driver.c (bus_driver_handle_message): sense of test for
6600 2003-04-16 Havoc Pennington <hp@pobox.com>
6602 * doc/dbus-specification.sgml: make spec say serials are unsigned
6604 * dbus/dbus-message.h: change message serials to unsigned
6606 * dbus/dbus-connection.c: adapt to message serials being unsigned
6608 2003-04-15 Havoc Pennington <hp@pobox.com>
6610 * bus/bus.c: create and keep around a shared DBusUserDatabase
6613 * bus/connection.c (bus_connection_get_groups): don't cache
6614 groups for user in the connection object, since user database
6615 object now does that.
6617 2003-04-16 Havoc Pennington <hp@redhat.com>
6619 * dbus/dbus-message.c (_dbus_message_add_size_counter): keep a
6620 list of size counters
6621 (_dbus_message_loader_putback_message_link): put back a popped link
6623 * dbus/dbus-connection.c
6624 (dbus_connection_set_max_live_messages_size): rename
6626 (dbus_connection_get_outgoing_size): get size of outgoing
6628 (_dbus_connection_set_connection_counter): remove this cruft
6630 2003-04-14 Havoc Pennington <hp@redhat.com>
6632 * dbus/dbus-userdb.c: user database abstraction, mostly to get
6633 caching, but at some point we might want to be able to use a
6636 * bus/dispatch.c (bus_dispatch_sha1_test): add a test that uses
6637 SHA1 conf file to test the sha1 auth mechanism, since the regular
6638 test always uses EXTERNAL when available.
6641 test/data/valid-config-files/debug-allow-all-sha1.conf.in:
6642 add conf file that requires use of sha1 auth
6644 2003-04-13 Havoc Pennington <hp@pobox.com>
6646 * tools/dbus-send.c, tools/dbus-monitor.c: two utility programs
6647 from Philip Blundell to send messages and monitor them.
6649 2003-04-13 Havoc Pennington <hp@pobox.com>
6651 * dbus/dbus-mainloop.c: fix some reentrancy issues by refcounting
6654 * test/data/valid-config-files/debug-allow-all.conf.in: allow all
6657 * dbus/dbus-transport.c (_dbus_transport_get_dispatch_status):
6658 fix to only recover unused bytes if we're already authenticated
6659 (_dbus_transport_get_is_authenticated): fix to still mark us
6660 authenticated if there are unused bytes.
6662 * bus/dispatch.c: implement security policy checking
6664 * bus/connection.c (bus_transaction_send_from_driver): new
6666 * bus/bus.c (bus_context_check_security_policy): new
6668 * bus/dispatch.c (send_service_nonexistent_error): delete this,
6669 now we just set the DBusError and it gets converted to an error
6672 * bus/connection.c (allow_user_function): enable code using actual
6673 data from the config file
6675 * bus/policy.c (list_allows_user): handle wildcard rules for
6676 user/group connection perms
6678 2003-04-13 Havoc Pennington <hp@pobox.com>
6680 * bus/config-parser.c: Load up the BusPolicy and BusPolicyRules
6682 * dbus/dbus-sysdeps.c (_dbus_get_user_id): new function
6684 * bus/policy.c (bus_policy_append_mandatory_rule)
6685 (bus_policy_append_default_rule, bus_policy_append_user_rule)
6686 (bus_policy_append_group_rule): new functions
6688 2003-04-12 Havoc Pennington <hp@pobox.com>
6690 * bus/config-parser.c (bus_config_parser_new): fix a memleak
6692 * dbus/dbus-sysdeps.c: change DBusCredentials to use longs for
6693 the pid/gid/uid, just for paranoia.
6695 * test/break-loader.c (randomly_do_n_things): find a byte
6696 containing a type code, and randomly change it to a different
6699 2003-04-12 Havoc Pennington <hp@pobox.com>
6701 * bus/policy.h: change BusPolicy to be the thing from the config
6702 file, and rename old BusPolicy to BusClientPolicy
6704 * bus/bus.c, bus/connection.c, bus/config-parser.c: change to
6705 match change in how policy works
6707 * dbus/dbus-internals.h: mark assert_not_reached as
6708 __attribute((noreturn))__
6710 2003-04-11 Havoc Pennington <hp@redhat.com>
6712 * doc/dbus-specification.sgml: fix a spot with the wrong name for
6713 the broadcast service. Use boolean return for ServiceExists.
6715 2003-04-11 Havoc Pennington <hp@redhat.com>
6717 * configure.in: add another directory to look for qt in.
6719 2003-04-11 Havoc Pennington <hp@redhat.com>
6721 * AUTHORS: add Colin Walters
6723 2003-04-11 Havoc Pennington <hp@redhat.com>
6729 2003-04-11 Havoc Pennington <hp@redhat.com>
6731 * bus/messagebus.in: remove pid file when stopping the
6732 message bus, since the bus won't have privileges to remove it
6735 2003-04-11 Havoc Pennington <hp@redhat.com>
6737 * bus/bus.c (bus_context_new): move credentials change after
6740 2003-04-11 Havoc Pennington <hp@pobox.com>
6742 * test/decode-gcov.c: add "below average functions" to the
6743 coverage report, and change how some of the code works.
6745 * bus/test-main.c: bracket some stuff in DBUS_BUILD_TESTS so it's
6746 not in the coverage stats.
6748 * test/test-service.c (main): use _dbus_verbose not fprintf in a
6749 couple places so running the test suite doesn't result in megaspam.
6751 2003-04-11 Havoc Pennington <hp@pobox.com>
6753 * bus/dispatch.c (check_existent_service_activation): accept a no
6754 memory error in a place we didn't before
6756 * bus/test.c (bus_test_run_everything): remove hacky "do it twice
6757 in case the first one failed," since the test suite is less
6760 2003-04-10 Havoc Pennington <hp@pobox.com>
6762 * bus/dispatch.c (check_segfault_service_activation): add test
6763 for launching an executable that just crashes.
6765 * test/test-segfault.c (main): try setting coredumpsize to 0 so we
6766 don't leave a million cores. We'll see how portable this is.
6768 2003-04-10 Havoc Pennington <hp@pobox.com>
6770 * dbus/dbus-spawn.c (_dbus_spawn_async_with_babysitter): move all
6771 the possible parent failures before we fork, so that we don't
6772 fail to create a babysitter after creating the child.
6774 * bus/activation.c (bus_activation_activate_service): kill child
6775 if we don't successfully complete the activation.
6777 2003-04-10 Havoc Pennington <hp@redhat.com>
6779 * dbus/dbus-connection.c (dbus_connection_flush): don't spin on
6780 the connection if it's disconnected
6782 * bus/activation.c (bus_activation_service_created): use new
6783 transaction features to roll back removal of pending activation if
6784 we don't successfully create the service after all. Don't remove
6785 pending activation if the function fails.
6787 * dbus/dbus-list.c (_dbus_list_insert_before_link)
6788 (_dbus_list_insert_after_link): new code to facilitate
6791 * dbus/dbus-hash.c (_dbus_hash_table_insert_string_preallocated):
6792 new functionality, so we can preallocate the ability to insert
6795 * bus/connection.c (bus_transaction_add_cancel_hook): new function
6796 allowing us to put custom hooks in a transaction to be used for
6797 cancelling said transaction
6799 * doc/dbus-specification.sgml: add some discussion of secondary
6800 service owners, and disallow zero-length service names
6802 * bus/services.c (bus_registry_acquire_service): new function,
6803 splits out part of bus_driver_handle_acquire_service() and fixes
6804 a bug where we didn't remove the service doing the acquiring
6805 from the secondary queue if we failed to remove the current owner
6806 from the front of the queue.
6808 2003-04-10 Alexander Larsson <alexl@redhat.com>
6810 * doc/dbus-specification.sgml:
6811 s/org.freedesktop.Broadcast/org.freedesktop.DBus.Broadcast/
6813 2003-04-10 Alexander Larsson <alexl@redhat.com>
6818 Added files to cvsignore
6820 * dbus/dbus-message.h:
6821 * dbus/dbus-message.c: (dbus_message_iter_get_named):
6822 Make get_named() take two out argument and return a boolean.
6823 (dbus_message_iter_get_args_valist):
6824 Update usage of get_named().
6825 (dbus_message_iter_append_byte):
6827 (dbus_message_iter_append_named)
6829 (message_iter_test), (check_message_handling_type), (_dbus_message_test):
6832 2003-04-10 Alexander Larsson <alexl@redhat.com>
6834 * dbus/dbus-marshal.[ch]:
6835 Add array_type_pos argument to _dbus_marshal_validate_arg.
6836 Let you pass a NULL end_pos to _dbus_marshal_validate_type.
6838 * dbus/dbus-message.[ch]:
6839 Multi-dimensional arrays have full type specification in the
6840 outermost array. Iter code re-arranged to handle this.
6841 Added some more iter tests.
6843 * doc/dbus-specification.sgml:
6846 Update new array encoding description.
6847 Correct DBUS_SERVICE_FLAGS_REPLACE_EXISTING description.
6849 * test/data/invalid-messages/array-with-mixed-types.message:
6850 * test/data/valid-messages/array-of-array-of-uint32.message:
6851 Change to the new array format.
6853 * test/data/invalid-messages/too-short-dict.message:
6856 * test/data/valid-messages/recursive-types.message:
6857 Fix up and extend test.
6859 2003-04-10 Havoc Pennington <hp@pobox.com>
6861 * bus/dispatch.c: lots of fixes
6863 * dbus/dbus-mainloop.c (_dbus_loop_dispatch): export
6864 (_dbus_loop_iterate): remove old "quit if no callbacks" code,
6865 that was crack, broke the test service.
6867 * dbus/dbus-transport.c (_dbus_transport_open): fix error
6868 handling to avoid piling up errors if we get a failure on the
6871 * dbus/dbus-internals.c (_dbus_real_assert_not_reached): include
6872 pid in assertion failures.
6874 * dbus/dbus-mainloop.c (_dbus_loop_iterate): use static arrays up
6875 to some fixed size of file descriptor array. Don't return TRUE
6876 anytime a timeout exists, that led to lots of busy loop silliness
6879 2003-04-09 Havoc Pennington <hp@redhat.com>
6881 * dbus/dbus-mainloop.c (check_timeout): fix timeouts, I thought
6882 I'd checked this in earlier but hadn't.
6884 2003-04-09 Havoc Pennington <hp@redhat.com>
6886 * bus/dispatch.c (bus_dispatch_test): get a bit further through
6887 the activation test (man this is getting old!)
6889 2003-04-09 Havoc Pennington <hp@redhat.com>
6891 * test/test-utils.c: use dispatch status function to fix this up
6893 * bus/connection.c (connection_watch_callback): don't dispatch
6895 (connection_timeout_callback): don't dispatch from here
6896 (bus_connections_setup_connection): set the dispatch status function
6897 (bus_connection_disconnected): unset it
6899 * dbus/dbus-mainloop.c (_dbus_loop_queue_dispatch): new function
6900 used to add a connection to be dispatched
6901 (_dbus_loop_iterate): do the dispatching at the end of each
6904 * dbus/dbus-connection.c
6905 (dbus_connection_set_dispatch_status_function): new function
6906 allowing us to fix up main loop usage
6907 (_dbus_connection_last_unref): free all the various function
6909 (dbus_connection_dispatch): call the DispatchStatusFunction
6910 whenever this function returns
6911 (dbus_connection_handle_watch): call DispatchStatusFunction
6912 (dbus_connection_send_with_reply_and_block): call DispatchStatusFunction
6913 (reply_handler_timeout): call DispatchStatusFunction
6914 (dbus_connection_flush): call DispatchStatusFunction
6916 2003-04-09 Havoc Pennington <hp@redhat.com>
6918 * dbus/dbus-bus.c (dbus_bus_register): fix up error handling and
6921 * bus/dispatch.c (check_service_activated): fix bug in test
6923 * dbus/dbus-mainloop.c (check_timeout): fix this up
6925 * dbus/dbus-internals.c (_dbus_verbose_real): include PID in
6926 verbose output so we can sort out output from different processes,
6927 e.g. in the activation case.
6929 2003-04-08 Colin Walters <walters@gnu.org>
6931 * bus/bus.c (struct BusContext) [pidfile]: New member, to store
6933 (bus_context_new): Set it.
6934 (bus_context_unref): Use it to delete the pid file.
6936 2003-04-08 Havoc Pennington <hp@redhat.com>
6938 * test/data/invalid-messages/array-with-mixed-types.message:
6939 regression test that fails for the moment
6941 * dbus/dbus-test.c (dbus_internal_do_not_use_run_tests): reorder
6942 tests for convenience
6944 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): don't allow
6945 array of nil, it broke things.
6947 * test/data/invalid-messages/array-of-nil.message: regression test
6949 * test/data/valid-messages/array-of-array-of-uint32.message:
6950 happened to write this so added it to suite
6952 2003-04-08 Havoc Pennington <hp@redhat.com>
6954 * bus/driver.c (bus_driver_handle_acquire_service): init
6955 retval/reply before checking name
6957 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): add a
6958 recursion depth argument
6960 * dbus/dbus-message.h (struct DBusMessageIter): put some padding
6961 in the public struct for future extension
6963 * dbus/dbus-message-builder.c (_dbus_message_data_load): fix
6966 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): fix a verbose
6969 * doc/dbus-specification.sgml: fix typo
6971 2003-04-08 Alexander Larsson <alexl@redhat.com>
6973 Implemented recursive types, named types and new-style iters
6976 * glib/test-thread-client.c: (thread_func):
6977 * glib/test-thread-server.c: (handle_test_message):
6978 * test/test-service.c: (handle_echo):
6987 * dbus/dbus-internals.c: (_dbus_type_to_string):
6988 Update for new types.
6990 * dbus/dbus-marshal.[ch]:
6991 Implement recursive types and the new marshalling format.
6992 Remove hardcoded dict marshalling.
6993 Marshal named types.
6995 * dbus/dbus-message-builder.c:
6997 Remove references to old types
6999 * dbus/dbus-message.[ch]:
7000 New non-refcounted iter API that supports recursive iters.
7001 Use iters for appending, including support for recursive
7003 Add byte and named type support.
7004 Update everything to new marshalling formats.
7005 Add tests for new API.
7007 * dbus/dbus-protocol.h:
7008 Remove old array types.
7009 Add types: BYTE, ARRAY, DICT, NAMED
7011 * dbus/dbus-string.c:
7012 * dbus/dbus-sysdeps.c:
7013 Make parse_double locale safe.
7015 * dbus/dbus-test-main.c:
7021 * doc/dbus-specification.sgml:
7024 * test/data/incomplete-messages/missing-body.message:
7025 * test/data/invalid-messages/bad-boolean.message:
7026 * test/data/invalid-messages/bad-boolean-array.message:
7027 * test/data/invalid-messages/boolean-array-length-too-long.message-raw:
7028 * test/data/invalid-messages/boolean-has-no-value.message-raw:
7029 * test/data/invalid-messages/too-short-dict.message:
7030 * test/data/valid-messages/dict-simple.message:
7031 * test/data/valid-messages/dict.message:
7032 * test/data/valid-messages/emptiness.message:
7033 * test/data/valid-messages/lots-of-arguments.message:
7034 * test/data/valid-messages/no-padding.message:
7035 * test/data/valid-messages/recursive-types.message:
7036 Add missing NAME fields
7037 Fix up dicts & arrays
7039 * test/data/invalid-messages/dict-with-nil-value.message:
7040 Removed, this is not invalid anymore.
7042 * test/data/valid-messages/recursive-types.message:
7043 Add new test for deeply recursive types.
7045 2003-04-07 Havoc Pennington <hp@pobox.com>
7047 * bus/driver.c (bus_driver_handle_acquire_service): return an
7048 error if you try to acquire a service that starts with ':'
7050 2003-04-07 Havoc Pennington <hp@redhat.com>
7052 * doc/dbus-specification.sgml: require that base service names
7053 start with ':' and that the base service is created/deleted
7054 as first and last things a connection does on the bus
7056 * bus/dispatch.c (check_existent_service_activation): lots more
7057 work on the activation test; it doesn't fully pass yet...
7059 * test/test-service.c (main): fix so we don't memleak the
7060 connection to the message bus
7061 (filter_func): accept a message asking us to exit
7063 2003-04-06 Havoc Pennington <hp@pobox.com>
7065 * qt/Makefile.am (dbusinclude_HEADERS): install dbus-qt.h,
7068 * configure.in: fixes to Qt detection from Colin Walters
7070 * doc/Makefile.am: Only remove generated docbook dirs if they
7071 exist, from Colin Walters
7073 * dbus/dbus-bus.c: change how we set well-known connections to
7074 NULL, so that it works if a single connection is stored in
7075 two well-known array slots.
7077 * test/Makefile.am: remove a lot of stuff that isn't immediately
7078 useful, it's in CVS history if we want it.
7080 * test/test-service.c: use dbus-mainloop instead of that
7083 2003-04-06 Havoc Pennington <hp@pobox.com>
7085 * dbus/Makefile.am: split lists of sources into stuff that goes in
7086 the library, util functions that go in the lib and are also used
7087 elsewhere, and util functions that are used in tests/daemon but
7088 don't go in the lib.
7090 * dbus/dbus-mainloop.h, dbus/dbus-mainloop.c: move bus/loop.[hc]
7091 here so it can be used in test binaries also
7093 2003-04-06 Havoc Pennington <hp@pobox.com>
7095 * dbus/dbus-sysdeps.c (_dbus_become_daemon): write the pidfile
7096 here in the parent process, so we can return an error if it
7097 fails. Also, move some of the code into the child so the parent
7098 is less hosed if we fail midway through.
7100 * bus/bus.c (bus_context_new): move pidfile detection further up
7101 in the function, before we start overwriting sockets and such.
7103 * bus/messagebus.in: adjust this a bit, not sure if it will work.
7105 * configure.in: add --with-system-pid-file and --with-system-socket
7107 2003-04-06 Colin Walters <walters@verbum.org>
7109 * configure.in (DBUS_SYSTEM_PID_FILE): New variable.
7111 * bus/system.conf.in: Declare a pidfile.
7113 * bus/bus.c (bus_context_new): Test for an existing pid file, and
7114 create one (if appropriate).
7116 * bus/config-parser.c (enum ElementType) [ELEMENT_PIDFILE]: New.
7117 (struct BusConfigParser) [pidfile]: New.
7118 (element_type_to_name, merge_included, start_busconfig_child)
7119 (bus_config_parser_end_element, bus_config_parser_content): Handle it.
7120 (bus_config_parser_unref): Free it.
7121 (bus_config_parser_get_pidfile): New function.
7123 * bus/config-parser.h (_dbus_write_pid_file): Prototype.
7125 * dbus/dbus-errors.h (DBUS_ERROR_PIDFILE_EXISTS): New error.
7127 * dbus/dbus-sysdeps.c (_dbus_write_pid_file): New function.
7129 * dbus/dbus-sysdeps.h: Prototype it.
7131 2003-04-06 Havoc Pennington <hp@pobox.com>
7133 * bus/bus.c (bus_context_new): print the address in here, rather
7134 than in main(), because we need to do it before forking the daemon
7136 * bus/dispatch.c (send_service_nonexistent_error): set the sender
7137 on the service nonexistent error
7139 * bus/driver.c (bus_driver_handle_acquire_service): set the
7140 sender on the AcquireService reply
7142 * test/data/valid-config-files/debug-allow-all.conf.in: Make test
7143 server also listen on a UNIX socket so services can connect to it.
7145 2003-04-06 Havoc Pennington <hp@pobox.com>
7147 * dbus/dbus-threads.c: Redo how the fake debug mutexes are done
7148 so it detects deadlocks and also we actually init threads when
7151 2003-04-06 Havoc Pennington <hp@pobox.com>
7153 * dbus/dbus-server-unix.c (_dbus_server_new_for_domain_socket):
7154 save the domain socket name, and unlink it when we disconnect the
7155 server. Means that at least when we exit normally, we won't leave
7156 a bunch of junk in /tmp
7158 * dbus/dbus-transport-unix.c
7159 (_dbus_transport_new_for_domain_socket): code cleanup (nicer
7160 memory management). (I was making a real change here but then
7163 2003-04-06 Havoc Pennington <hp@pobox.com>
7165 * bus/bus.c (bus_context_new): fix wrong handling of
7166 server_data_slot_unref() in the error case.
7168 * dbus/dbus-internals.h (_dbus_assert): change so it passes
7169 "(condition) != 0" to _dbus_real_assert so that
7170 "_dbus_assert (pointer)" doesn't cause a warning
7172 * bus/main.c (main): accept --print-address option to print out
7173 the message bus address
7175 * dbus/dbus-sysdeps.c (_dbus_generate_random_ascii): export this
7177 * dbus/dbus-transport.c (_dbus_transport_open): special error for
7178 "tmpdir" option to unix: address on client side
7180 * dbus/dbus-server.c (dbus_server_listen): handle "tmpdir" option
7183 * configure.in (TEST_SOCKET_DIR): locate a temporary directory
7184 we can use to create sockets in the test suite.
7186 * bus/main.c (signal_handler): on SIGTERM, exit the daemon
7187 cleanly. To be used for testing.
7189 * dbus/dbus-spawn.c (babysit): use _dbus_set_signal_handler()
7191 * dbus/dbus-sysdeps.c (_dbus_set_signal_handler): new
7193 * dbus/dbus-server-debug-pipe.c (_dbus_transport_debug_pipe_new):
7194 handle trying to call this when there's no servers active
7196 2003-04-05 Havoc Pennington <hp@pobox.com>
7202 2003-04-05 Havoc Pennington <hp@pobox.com>
7204 * bus/bus.c (setup_server): fix this so dbus-daemon-1 doesn't
7205 crash on startup. Need to get "try starting the daemon"
7206 in the test suite I guess. ;-)
7208 * dbus/dbus-server.h, dbus/dbus-server.c: remove the stuff that
7209 tracked the number of open connections; it's better done in
7210 application-specific code as you want it to span all servers etc.
7212 2003-04-05 Havoc Pennington <hp@pobox.com>
7214 * bus/Makefile.am (install-data-hook): add missing DESTDIR,
7215 patch from Colin Walters
7217 2003-04-05 Havoc Pennington <hp@pobox.com>
7219 * doc/config-file.txt (Elements): fix docs of <auth> to reflect
7220 reality; in fact multiple mechanisms are allowed.
7222 * dbus/dbus-internals.c (_dbus_real_assert)
7223 (_dbus_real_assert_not_reached): move guts of _dbus_assert() and
7224 _dbus_assert_not_reached() into functions, so that they don't show
7225 up in basic block counts for test coverage, and don't use up as
7226 much disk space. Does mean slower execution speed though, so
7227 assumes --disable-asserts is the normal production case.
7229 2003-04-05 Havoc Pennington <hp@pobox.com>
7231 * test/Makefile.am (dist-hook): also dist *.in files
7237 2003-04-05 Havoc Pennington <hp@pobox.com>
7239 * dbus/dbus-string.c: docs warning
7241 * dbus/dbus-spawn.c: missing docs
7243 * dbus/dbus-memory.c (struct ShutdownClosure): missing docs
7245 2003-04-05 Havoc Pennington <hp@pobox.com>
7247 * bus/loop.c (bus_loop_iterate): fix the timeout code, using
7250 * dbus/dbus-spawn.c (_dbus_babysitter_unref): set sitter_pid
7251 to -1 once we've reaped the babysitter
7252 (_dbus_babysitter_handle_watch): do as much work as we can, not
7255 * bus/activation.c: add code using DBusBabysitter so that we
7256 handle it when a service fails to start up properly.
7257 (bus_activation_service_created): don't remove the activation
7258 entries as we go, just let them get removed when we free the pending
7259 activation. Unref reply messages after sending them.
7261 2003-04-05 Havoc Pennington <hp@pobox.com>
7263 * test/decode-gcov.c (main): print per-directory stats in the report
7265 * Makefile.am (coverage-report.txt): don't include test/* in gcov stats
7267 2003-04-05 Havoc Pennington <hp@pobox.com>
7269 * Makefile.am (coverage-report.txt): add target "coverage-report.txt"
7271 * test/decode-gcov.c: hack up a little program to suck data
7272 out of gcov files. Yes this is sort of silly.
7274 * configure.in: define something in config.h and do an
7275 AM_CONDITIONAL when gcov is enabled
7277 2003-04-04 Havoc Pennington <hp@redhat.com>
7279 * dbus/dbus-spawn.c, dbus/dbus-spawn.h: Change dbus_spawn to
7280 return a "babysitter" object that is used to monitor the status of
7281 the spawned process and reap it when required.
7283 * test/test-segfault.c, test/test-exit.c,
7284 test/test-sleep-forever.c: binaries that do various lame things,
7285 used in the test suite.
7287 * dbus/dbus-sysdeps.c: kill _dbus_errno_to_string()
7289 2003-04-03 Havoc Pennington <hp@pobox.com>
7291 * dbus/dbus-spawn.c: Move dbus-spawn into a separate file
7292 in preparation for modifying it, dbus-sysdeps is getting
7295 2003-04-03 Havoc Pennington <hp@redhat.com>
7297 * bus/loop.h, bus/loop.c: make the mainloop an object so we can
7300 * bus/*.[hc]: adapt to mainloop change
7302 2003-04-03 Havoc Pennington <hp@redhat.com>
7304 * bus/activation.c (load_directory): fix up memleaks
7305 (bus_activation_entry_free): free the entry
7307 * dbus/dbus-bus.c (dbus_bus_acquire_service): return an error if
7308 we get one from the message bus; fix memleaks.
7310 * dbus/dbus-message.c (dbus_set_error_from_message): new function
7312 2003-04-03 Havoc Pennington <hp@pobox.com>
7314 * bus/config-parser.c (bus_config_parser_unref): free
7315 list of mechanisms, bug discovered by test suite enhancements
7316 (putting system.conf and session.conf into suite)
7318 * test/Makefile.am, test/test-service.c: add placeholder for a
7319 test service that we'll activate as part of test suite. Doesn't
7322 * dbus/dbus-sysdeps.c (_dbus_setenv): support unsetenv by
7323 setting NULL value, and use system malloc not dbus_malloc()
7324 when we have unavoidable memleakage.
7326 * dbus/dbus-bus.c (dbus_bus_get): fix bug where bus type of 0
7327 didn't work, and support DBUS_BUS_ACTIVATION.
7329 * bus/activation.c (child_setup): pass our well-known bus type to
7332 * bus/config-parser.c: support <type> to specify well-known type
7334 * doc/dbus-specification.sgml: document the env variables to
7335 locate well-known buses and find service activator
7337 2003-04-02 Havoc Pennington <hp@redhat.com>
7339 * test/Makefile.am (all-local): add a rule to copy tests to
7340 builddir, so we can have generated tests. Use this to remove the
7341 silly hack for testing system.conf and session.conf. Will use this
7342 shortly to generate .service files pointing to test binaries.
7344 2003-04-02 Havoc Pennington <hp@redhat.com>
7346 * dbus/dbus-string.c (set_length): fix a bug - we allocated max of
7347 current alloc and needed new length, not max of the doubled
7348 allocation and needed new length. Also, when building tests,
7349 don't do the double-allocation stuff, just realloc every time.
7351 2003-04-02 Havoc Pennington <hp@redhat.com>
7353 * dbus/dbus-sysdeps.c (_dbus_file_get_contents): include filenames
7355 (_dbus_string_get_dirname): new
7356 (_dbus_sysdeps_test): new
7357 (_dbus_directory_open): include dirnames in error messages
7359 * bus/config-parser.c: interpret <include> and <includedir> and
7360 <servicedir> relative to config file location if the given
7361 filename is not absolute.
7363 * dbus/dbus-string.c (_dbus_string_find_byte_backward): new
7365 2003-04-02 Havoc Pennington <hp@redhat.com>
7367 * bus/connection.c (bus_transaction_send_error_reply): set sender
7368 service for the error, and unref the reply on success
7370 * bus/activation.c: convert to use BusTransaction so OOM can be
7372 (bus_activation_service_created): set sender of the message
7374 2003-04-01 Havoc Pennington <hp@redhat.com>
7376 * bus/config-parser.c, bus/bus.c: implement <servicedir> and
7377 <includedir> (at least mostly)
7379 * dbus/dbus-sysdeps.c (_dbus_change_identity): set the group ID
7380 first, then the user ID
7382 2003-04-01 Havoc Pennington <hp@pobox.com>
7384 * dbus/dbus-server.c (dbus_server_set_auth_mechanisms): new
7387 * dbus/dbus-auth.c (_dbus_auth_set_mechanisms): new
7389 * dbus/dbus-internals.c (_dbus_dup_string_array): new function
7391 * dbus/dbus-sysdeps.c (_dbus_listen_unix_socket): chmod the
7392 socket 0777, and unlink any existing socket.
7394 * bus/bus.c (bus_context_new): change our UID/GID and fork if
7395 the configuration file so specifies; set up auth mechanism
7398 * bus/config-parser.c (bus_config_parser_content): add support
7399 for <fork> option and fill in code for <auth>
7401 * bus/system.conf.in: add <fork/> to default configuration,
7402 and limit auth mechanisms to EXTERNAL
7404 * doc/config-file.txt (Elements): add <fork>
7406 * dbus/dbus-sysdeps.c (_dbus_become_daemon): new function
7407 (_dbus_change_identity): new function
7409 2003-03-31 Havoc Pennington <hp@redhat.com>
7411 * dbus/dbus-sysdeps.c (_dbus_connect_unix_socket)
7412 (_dbus_listen_unix_socket): fix off-by-one error in null
7413 termination spotted by Nalin
7415 2003-03-31 Havoc Pennington <hp@redhat.com>
7417 * dbus/dbus-keyring.c (_dbus_keyring_new_homedir): allow setting
7418 DBUS_TEST_HOMEDIR when tests are enabled, so we can test without
7419 having a real home directory available.
7421 2003-03-31 Havoc Pennington <hp@redhat.com>
7423 * bus/Makefile.am (install-data-hook): create /var/run/dbus
7425 * bus/messagebus.in: add init script for Red Hat /etc/init.d
7427 * configure.in: add support for specifying a style of init script
7430 2003-03-31 Havoc Pennington <hp@redhat.com>
7432 Fix some annoying DBusString API and fix all affected code.
7434 * dbus/dbus-string.c (_dbus_string_init): get rid of annoying
7436 (_dbus_string_get_data): change to return string instead of using
7438 (_dbus_string_get_const_data): ditto
7439 (_dbus_string_get_data_len): ditto
7440 (_dbus_string_get_const_data_len): ditto
7442 2003-03-31 Havoc Pennington <hp@redhat.com>
7444 * bus/main.c (main): fix up the command line arguments to be nicer
7446 2003-03-31 Havoc Pennington <hp@redhat.com>
7448 * dbus/Makefile.am (INCLUDES): use EXPANDED_LOCALSTATEDIR to
7449 define DBUS_SYSTEM_BUS_PATH as we want to compile in the same
7450 final location that lands in the config file
7452 * bus/config-loader-expat.c (bus_config_load): fix type of
7455 * doc/TODO: remove TODO item for dbus_bus_get()
7457 * dbus/dbus-bus.c (bus_data_free): add missing lock/unlock
7459 2003-03-31 Havoc Pennington <hp@pobox.com>
7461 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_domain_socket)
7462 (_dbus_transport_new_for_tcp_socket): these didn't need the "server"
7463 argument since they are always client side
7465 * dbus/dbus-server.c (dbus_server_get_address): new function
7467 * bus/main.c (main): take the configuration file as an argument.
7469 * test/data/valid-config-files/debug-allow-all.conf: new file to
7470 use with dispatch.c tests for example
7472 * bus/test-main.c (main): require test data dir
7474 * bus/bus.c (bus_context_new): change this to take a
7475 configuration file name as argument
7477 * doc/config-file.txt (Elements): add <servicedir>
7479 * bus/system.conf, bus/session.conf: new files
7481 * dbus/dbus-bus.c (dbus_bus_get): look for system bus on
7482 well-known socket if none set
7484 * configure.in: create system.conf and session.conf
7486 2003-03-30 Havoc Pennington <hp@pobox.com>
7488 * bus/config-parser.c: hacking
7490 * dbus/dbus-memory.c: don't use DBusList for the list of stuff
7491 to shut down, since it could cause weirdness with the DBusList
7494 * dbus/dbus-list.c (_dbus_list_test): add tests for the
7495 link-oriented stack routines
7496 (alloc_link): free the mempool if the first alloc from it fails
7498 * dbus/dbus-mempool.c (struct DBusMemBlock): fix alignment issue
7500 * dbus/dbus-string.c (UNICODE_VALID): sync new version of this
7502 (_dbus_string_skip_white): new
7504 * doc/config-file.txt (Elements): add <includedir>
7506 2003-03-28 Havoc Pennington <hp@pobox.com>
7508 * dbus/dbus-string.c (_dbus_string_copy_data_len)
7509 (_dbus_string_copy_data): new functions
7511 2003-03-28 Anders Carlsson <andersca@codefactory.se>
7513 * dbus/dbus-bus.c: (bus_data_free), (dbus_bus_get):
7517 * dbus/dbus-memory.c:
7520 2003-03-28 Havoc Pennington <hp@pobox.com>
7522 * bus/test.c (bus_test_flush_bus): remove the sleep from here,
7523 I think it may have just been superstition. Not sure.
7525 * dbus/dbus-string.c (_dbus_string_base64_decode): catch some OOM
7526 failures that were not being handled.
7528 * dbus/dbus-auth.c (process_auth): fix a memleak in OOM handling
7530 * dbus/dbus-memory.c: add ability to set number of mallocs in a
7531 row that will fail on out-of-memory.
7533 * dbus/dbus-internals.c (_dbus_test_oom_handling): convenience
7534 function for testing out-of-memory handling.
7536 * bus/config-loader-expat.c (memsuite): don't wrap the dbus
7537 allocation functions, they do map exactly to the expat ones.
7539 2003-03-27 Havoc Pennington <hp@redhat.com>
7541 * bus/config-loader-libxml.c (bus_config_load): add another error
7544 2003-03-26 Anders Carlsson <andersca@codefactory.se>
7547 Add note about automatic service activation.
7549 * doc/dbus-specification.sgml:
7550 Rename the specification and clarify a few things.
7552 2003-03-26 Anders Carlsson <andersca@codefactory.se>
7555 * dbus/dbus-address.c:
7557 * dbus/dbus-marshal.c:
7558 * dbus/dbus-server-debug-pipe.c:
7559 * dbus/dbus-transport-unix.c:
7560 Fix documentation warnings.
7562 2003-03-26 Havoc Pennington <hp@pobox.com>
7564 * bus/test-main.c, dbus/dbus-test.c (main): check memleaks
7565 after every test so it's quick and easy to see which leaked, and
7566 so we test multiple dbus_shutdown() calls
7568 * configure.in: change configure.in XML stuff to also support
7571 * config-loader-libxml.c: some hacking
7573 * config-loader-expat.c: some hacking
7575 * config-parser.c: some hacking, plus tests
7577 2003-03-25 Havoc Pennington <hp@redhat.com>
7579 * throughout - add more _DBUS_ASSERT_ERROR_IS_CLEAR
7581 * configure.in: add --with-xml option to specify XML library,
7582 right now only libxml is supported.
7584 * bus/config-loader-libxml.c, config-parser.c: sync some minor
7585 nonworking code between home and work, still just stubs
7587 2003-03-24 Havoc Pennington <hp@redhat.com>
7589 * dbus/dbus-sysdeps.c (_dbus_set_fd_nonblocking): move to this
7592 * dbus/dbus-errors.c (dbus_set_error, dbus_set_error_const): allow
7593 NULL argument for "message" if the error is a well-known one,
7594 fill in a generic message in this case.
7596 * dbus/dbus-errors.h (DBusResultCode): Kill DBusResultCode in
7599 * bus/test.c (bus_test_flush_bus): add
7601 * bus/policy.c (bus_policy_test): test code stub
7603 2003-03-24 Havoc Pennington <hp@pobox.com>
7605 * bus/connection.c (bus_connections_setup_connection): set up
7606 the "can this user connect" function, but it always returns
7607 TRUE until we have a config file parser so we can have a config
7608 file that allows connections.
7610 2003-03-23 Havoc Pennington <hp@pobox.com>
7612 * dbus/dbus-threads.c (dbus_mutex_new, dbus_condvar_new): with
7613 DBUS_BUILD_TESTS, actually alloc/free a block of memory for
7614 the mutex, so we can check for proper memory management
7617 * dbus/dbus-dataslot.c: remove the mutex from
7618 DBusDataSlotAllocator and lock it manually when using it,
7619 to simplify fitting it into the global slots framework.
7621 * dbus/dbus-threads.c (init_static_locks): rework how we're
7622 handling global locks so they are easily shut down.
7624 * bus/policy.c (bus_policy_append_rule): fix
7626 * bus/test-main.c (main): check for memleaks
7628 * dbus/dbus-test.c (dbus_internal_do_not_use_run_tests): make
7629 test suite check for memleaks
7631 * dbus/dbus-memory.c: add support in test mode for tracking
7632 number of outstanding blocks
7634 2003-03-23 Havoc Pennington <hp@pobox.com>
7636 * bus/policy.c, bus/bus.c, bus/connection.c: implement allow/deny
7639 * dbus/dbus-hash.h: add ULONG hash keys
7641 * dbus/dbus-sysdeps.c (_dbus_get_groups): new
7642 (_dbus_get_group_id): new function
7644 2003-03-20 Havoc Pennington <hp@redhat.com>
7646 * dbus/dbus-connection.c (dbus_connection_set_unix_user_function):
7648 (dbus_connection_get_unix_user): new function
7650 2003-03-20 Havoc Pennington <hp@pobox.com>
7652 * bus/connection.c (bus_connection_send_oom_error): assert that
7653 message has a sender
7654 (connection_execute_transaction): ditto
7655 (bus_connection_preallocate_oom_error): fix to set the sender, and
7656 set recipient to the destination service, not the bus driver
7658 * bus/policy.c: hacking
7660 * dbus/dbus-message.c (dbus_message_service_is): new function
7661 (dbus_message_sender_is): new
7663 2003-03-19 Havoc Pennington <hp@redhat.com>
7665 * bus/policy.c: start sketching code for policy restrictions on
7666 what connections can do.
7668 2003-03-18 Havoc Pennington <hp@redhat.com>
7670 * doc/TODO: some notes on high-level todo items. Little nitpick
7671 stuff is all in @todo, so no need to add it here.
7673 * doc/config-file.txt: some notes on how config file might look
7675 2003-03-18 Anders Carlsson <andersca@codefactory.se>
7681 2003-03-17 Havoc Pennington <hp@redhat.com>
7683 * dbus/dbus-internals.h: add gcc attributes so that
7684 our printf-style functions warn on bad arguments to
7687 * dbus/dbus-sysdeps.c (_dbus_connect_tcp_socket): fix printf
7690 * dbus/dbus-message.c (_dbus_message_loader_queue_messages): fix
7693 2003-03-17 Havoc Pennington <hp@redhat.com>
7695 * bus/test-main.c (main): make it print something as it runs
7696 so make check doesn't look stuck
7698 * doc/negotiation.txt, doc/dbus-sasl-profile.txt: remove
7699 from CVS, now obsolete
7701 2003-03-17 Anders Carlsson <andersca@codefactory.se>
7703 * bus/dispatch.c: (bus_dispatch):
7704 Refetch the service name since it may have been reallocated
7705 when dbus_message_set_sender was called.
7707 * dbus/dbus-sysdeps.c: (_dbus_accept):
7708 Add address and address length variables and use them to stop
7709 valgrind from complaining.
7711 2003-03-17 Havoc Pennington <hp@pobox.com>
7713 All tests pass, no memleaks, no valgrind complaints.
7715 * bus/test.c: refcount handler_slot
7717 * bus/connection.c (bus_connections_new): refcount
7718 connection_data_slot
7720 * dbus/dbus-auth-script.c (_dbus_auth_script_run): delete unused
7721 bytes so that auth scripts pass.
7723 * bus/dispatch.c: init message_handler_slot so it gets allocated
7726 * bus/dispatch.c (message_handler_slot_ref): fix memleak
7728 * dbus/dbus-server-debug-pipe.c (_dbus_server_debug_pipe_new):
7729 dealloc server_pipe_hash when no longer used for benefit of
7732 * dbus/dbus-auth.c (process_command): memleak fix
7734 * bus/dispatch.c (check_hello_message): memleak fix
7736 2003-03-16 Havoc Pennington <hp@pobox.com>
7738 * dbus/dbus-bus.c (ensure_bus_data): fix double-unref of the data slot
7740 2003-03-17 Anders Carlsson <andersca@codefactory.se>
7742 * bus/activation.c (bus_activation_activate_service): Append
7743 the pending activation entry to the list of pending activations.
7745 2003-03-16 Havoc Pennington <hp@pobox.com>
7747 * bus/dispatch.c (bus_dispatch_test): remove double-unrefs of
7750 * dbus/dbus-address.c (create_entry): fix OOM handling when
7751 failing to alloc entry->method
7753 2003-03-16 Havoc Pennington <hp@pobox.com>
7755 * dbus/dbus-watch.c (_dbus_watch_new): handle failure to malloc
7758 * dbus/dbus-server-debug-pipe.c (_dbus_transport_debug_pipe_new):
7759 add some missing dbus_set_result
7761 * bus/dispatch.c (bus_dispatch_add_connection): handle failure to
7762 alloc the DBusMessageHandler
7764 * dbus/dbus-transport.c (_dbus_transport_disconnect): don't ref
7765 the transport here, since we call this from the finalizer; it
7766 resulted in a double-finalize.
7768 * dbus/dbus-transport.c (_dbus_transport_disconnect): fix a bug
7769 where we tried to use transport->connection that was NULL,
7770 happened when transport was disconnected early on due to OOM
7772 * bus/*.c: adapt to handle OOM for watches/timeouts
7774 * dbus/dbus-transport-unix.c: port to handle OOM during
7777 * dbus/dbus-auth.c (_dbus_auth_get_unused_bytes): return a
7778 reference to unused bytes instead of a copy
7780 * dbus/dbus-server.c (dbus_server_handle_watch): return FALSE for
7783 * dbus/dbus-connection.c (dbus_connection_handle_watch): return
7786 * dbus/dbus-timeout.c (dbus_timeout_handle): return FALSE for out
7789 2003-03-16 Anders Carlsson <andersca@codefactory.se>
7791 * doc/dbus-specification.sgml:
7792 Document reply message for ActivateService.
7794 2003-03-16 Anders Carlsson <andersca@codefactory.se>
7796 * bus/activation.c: (bus_pending_activation_entry_free),
7797 (bus_pending_activation_free), (bus_activation_new),
7798 (bus_activation_unref), (bus_activation_service_created),
7799 (bus_activation_activate_service):
7801 * bus/bus.c: (bus_context_new):
7802 * bus/desktop-file.c: (new_section):
7803 * bus/driver.c: (bus_driver_send_service_deleted),
7804 (bus_driver_handle_activate_service):
7805 * bus/services.c: (bus_registry_new), (bus_registry_ensure):
7807 * dbus/dbus-connection.c:
7808 (dbus_connection_send_with_reply_and_block):
7809 * dbus/dbus-message.c: (dbus_message_append_args_valist):
7810 * dbus/dbus-protocol.h:
7811 Make activation work better. Now pending activations will be queued
7812 and the daemon won't try to activate services that are already registered.
7814 2003-03-16 Havoc Pennington <hp@pobox.com>
7816 * dbus/dbus-bus.c (ensure_bus_data): handle failure to set
7819 * dbus/dbus-memory.c (_dbus_initialize_malloc_debug): support
7820 DBUS_MALLOC_BACKTRACES to print trace when failing an alloc
7822 2003-03-16 Havoc Pennington <hp@pobox.com>
7824 * dbus/dbus-string.c (_dbus_string_validate_utf8): oops, unbreak
7825 this. always run the test suite before commit...
7827 * bus/*: adapt to DBusConnection API changes
7829 * glib/dbus-gmain.c: adapt to DBusConnection API changes,
7830 requires renaming stuff to avoid dbus_connection_dispatch name
7833 * dbus/dbus-transport.c (_dbus_transport_queue_messages): new
7836 * dbus/dbus-message.c (_dbus_message_loader_queue_messages):
7837 separate from _dbus_message_loader_return_buffer()
7839 * dbus/dbus-connection.c (dbus_connection_get_n_messages): remove
7840 this, because it's now always broken to use; the number of
7841 messages in queue vs. the number still buffered by the message
7842 loader is undefined/meaningless. Should use
7843 dbus_connection_get_dispatch_state().
7844 (dbus_connection_dispatch): rename from
7845 dbus_connection_dispatch_message
7847 2003-03-16 Havoc Pennington <hp@pobox.com>
7849 * dbus/dbus-string.c (_dbus_string_validate_utf8): copy in a real
7852 2003-03-16 Anders Carlsson <andersca@codefactory.se>
7854 * dbus/dbus-connection.c:
7855 (dbus_connection_send_with_reply_and_block):
7856 Decrease connection->n_incoming when removing an entry
7858 * dbus/dbus-dict.c: (dbus_dict_entry_free),
7859 (dbus_dict_set_boolean_array), (dbus_dict_set_int32_array),
7860 (dbus_dict_set_uint32_array), (dbus_dict_set_double_array),
7861 (dbus_dict_set_byte_array), (dbus_dict_set_string_array),
7862 (dbus_dict_get_boolean_array), (dbus_dict_get_double_array),
7863 (dbus_dict_get_byte_array):
7864 Handle NULL arrays and strings. Also add support for byte arrays.
7866 * dbus/dbus-marshal.c: (_dbus_marshal_byte_array),
7867 (_dbus_marshal_dict), (_dbus_demarshal_byte_array),
7868 (_dbus_demarshal_int32_array), (_dbus_demarshal_uint32_array),
7869 (_dbus_demarshal_double_array), (_dbus_demarshal_string_array),
7870 (_dbus_demarshal_dict), (demarshal_and_validate_len),
7871 (_dbus_marshal_validate_arg), (_dbus_marshal_test):
7872 * dbus/dbus-marshal.h:
7873 Add support for marshalling and demarshalling empty arrays and strings.
7875 * dbus/dbus-message.c: (dbus_message_append_args_valist),
7876 (dbus_message_append_string_array),
7877 (dbus_message_iter_get_boolean),
7878 (dbus_message_iter_get_boolean_array),
7879 (dbus_message_iter_get_int32_array),
7880 (dbus_message_iter_get_uint32_array),
7881 (dbus_message_iter_get_double_array),
7882 (dbus_message_iter_get_byte_array),
7883 (dbus_message_iter_get_string_array), (dbus_message_iter_get_dict),
7884 (check_message_handling):
7885 Add support for getting empty arrays and dicts.
7887 * dbus/dbus-string.c: (_dbus_string_validate_utf8):
7888 Don't do any validation at all for now, that's better than just checking
7891 * test/data/valid-messages/emptiness.message:
7892 New test message with lots of empty arrays.
7894 2003-03-16 Havoc Pennington <hp@pobox.com>
7896 * dbus/dbus-connection.c
7897 (_dbus_connection_queue_received_message_link): new function that
7898 can't fail due to OOM
7900 * dbus/dbus-message.c (_dbus_message_loader_pop_message_link):
7901 new function pops a message together with a list link
7904 * dbus/dbus-transport-unix.c (queue_messages): use new link-based
7905 message queuing functions to avoid needing to alloc memory
7907 2003-03-16 Havoc Pennington <hp@pobox.com>
7909 Oops - test code was only testing failure of around 30 of the
7910 mallocs in the test path, but it turns out there are 500+
7911 mallocs. I believe this was due to misguided linking setup such
7912 that there was one copy of dbus_malloc etc. in the daemon and one
7913 in the shared lib, and only daemon mallocs were tested. In any
7914 case, the test case now tests all 500+ mallocs, and doesn't pass
7915 yet, though there are lots of fixes in this patch.
7917 * dbus/dbus-connection.c (dbus_connection_dispatch_message): fix
7918 this so that it doesn't need to allocate memory, since it
7919 has no way of indicating failure due to OOM (and would be
7920 annoying if it did).
7922 * dbus/dbus-list.c (_dbus_list_pop_first_link): new function
7924 * bus/Makefile.am: rearrange to create two self-contained
7925 libraries, to avoid having libraries with overlapping symbols.
7926 that was resulting in weirdness, e.g. I'm pretty sure there
7927 were two copies of global static variables.
7929 * dbus/dbus-internals.c: move the malloc debug stuff to
7932 * dbus/dbus-list.c (free_link): free list mempool if it becomes
7935 * dbus/dbus-memory.c (_dbus_disable_mem_pools): new function
7937 * dbus/dbus-address.c (dbus_parse_address): free list nodes
7940 * bus/dispatch.c (bus_dispatch_add_connection): free
7941 message_handler_slot when no longer using it, so
7942 memory leak checkers are happy for the test suite.
7944 * dbus/dbus-server-debug-pipe.c (debug_finalize): free server name
7946 * bus/bus.c (new_connection_callback): disconnect in here if
7947 bus_connections_setup_connection fails.
7949 * bus/connection.c (bus_connections_unref): fix to free the
7951 (bus_connections_setup_connection): if this fails, don't
7952 disconnect the connection, just be sure there are no side
7955 * dbus/dbus-string.c (undo_alignment): unbreak this
7957 * dbus/dbus-auth.c (_dbus_auth_unref): free some stuff we were
7959 (_dbus_auth_new): fix the order in which we free strings
7962 * bus/connection.c (bus_connection_disconnected): fix to
7963 not send ServiceDeleted multiple times in case of memory
7966 * dbus/dbus-bus.c (dbus_bus_get_base_service): new function to
7967 get the base service name
7968 (dbus_bus_register_client): don't return base service name,
7969 instead store it on the DBusConnection and have an accessor
7971 (dbus_bus_register_client): rename dbus_bus_register()
7973 * bus/dispatch.c (check_hello_message): verify that other
7974 connections on the bus also got the correct results, not
7975 just the one sending hello
7977 2003-03-15 Havoc Pennington <hp@pobox.com>
7979 Make it pass the Hello handling test including all OOM codepaths.
7980 Now to do other messages...
7982 * bus/services.c (bus_service_remove_owner): fix crash when
7983 removing owner from an empty list of owners
7984 (bus_registry_ensure): don't leave service in the list of
7985 a connection's owned services if we fail to put the service
7988 * bus/connection.c (bus_connection_preallocate_oom_error): set
7989 error flag on the OOM error.
7991 * dbus/dbus-connection.c (_dbus_connection_new_for_transport):
7992 handle _dbus_transport_set_connection failure
7994 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_fd): modify
7995 to create watches up front and simply enable/disable them as
7997 (unix_connection_set): this can now fail on OOM
7999 * dbus/dbus-timeout.c, dbus/dbus-watch.c: add concept
8000 of enabling/disabling a watch or timeout.
8002 * bus/loop.c (bus_loop_iterate): don't touch disabled
8005 * glib/dbus-gmain.c: adapt to enable/disable watches and timeouts
8007 2003-03-15 Havoc Pennington <hp@pobox.com>
8009 * bus/dispatch.c (bus_dispatch_test): OK, now finally actually
8010 write useful test code, after all that futzing around ;-)
8012 Test does not yet pass because we can't handle OOM in
8013 _dbus_transport_messages_pending (basically,
8014 dbus_connection_preallocate_send() does not prealloc the write
8015 watch). To fix this, I think we need to add new stuff to
8016 set_watch_functions, namely a SetEnabled function so we can alloc
8017 the watch earlier, then enable it later.
8019 * dbus/Makefile.am (libdbus_convenience_la_SOURCES): move
8020 dbus-memory.c to the convenience lib
8022 * bus/test.c: rename some static functions to keep them clearly
8023 distinct from stuff in connection.c. Handle client disconnection.
8025 2003-03-14 Havoc Pennington <hp@pobox.com>
8027 * bus/dispatch.c (bus_dispatch_test): do test using debug-pipe
8028 transport, tests more of the real codepath. Set up clients
8029 with bus_setup_debug_client.
8031 * bus/test.c (bus_setup_debug_client): function to set up debug
8032 "clients" on the main loop
8034 * dbus/dbus-transport.c (_dbus_transport_open): add debug-pipe
8037 * dbus/dbus-server.c (dbus_server_listen): add debug-pipe
8040 * dbus/dbus-server-debug.c: support a debug server based on pipes
8042 * dbus/dbus-sysdeps.c (_dbus_full_duplex_pipe): new function
8043 (_dbus_close): new function
8045 * configure.in: check for socketpair
8047 2003-03-14 Havoc Pennington <hp@redhat.com>
8049 * dbus/dbus-memory.c: add a "detect buffer overwrites on free"
8052 * dbus/dbus-transport-debug.c: rework this a good bit to be
8053 less complicated. hopefully still works.
8055 * dbus/dbus-server-debug.c (handle_new_client): remove timeout
8058 * glib/dbus-gmain.c (timeout_handler): don't remove timeout
8061 * dbus/dbus-message.c (dbus_message_copy): rename from
8062 dbus_message_new_from_message, fix it up to copy
8063 all the message fields, add test case
8065 * bus/dispatch.c (bus_dispatch_test): add some more test code,
8066 not quite passing yet
8068 2003-03-14 Havoc Pennington <hp@pobox.com>
8070 * bus/loop.c (bus_loop_iterate): add this so we can "run loop
8071 until no work remains" in test code. (the large diff here
8072 is just code movement, no actual changes)
8074 * dbus/dbus-server-debug.c (DEFAULT_INTERVAL): change interval to
8075 1, no point waiting around for test code.
8076 (_dbus_server_debug_accept_transport): unref the timeout
8077 after adding it (right?)
8079 * dbus/dbus-transport-debug.c (DEFAULT_INTERVAL): ditto
8081 2003-03-13 Havoc Pennington <hp@redhat.com>
8083 * dbus/dbus-timeout.c (_dbus_timeout_list_set_functions): handle
8086 * dbus/dbus-watch.c (_dbus_watch_list_set_functions): handle out
8089 * dbus/dbus-connection.h: Make AddWatchFunction and
8090 AddTimeoutFunction return a bool so they can fail on out-of-memory
8092 * bus/bus.c (bus_context_new): set up timeout handlers
8094 * bus/connection.c (bus_connections_setup_connection): set up
8097 * glib/dbus-gmain.c: adapt to the fact that set_functions stuff
8100 * bus/bus.c (bus_context_new): adapt to changes
8102 * bus/connection.c: adapt to changes
8104 * test/watch.c: adapt to DBusWatch changes
8106 * bus/dispatch.c (bus_dispatch_test): started adding this but
8109 2003-03-14 Anders Carlsson <andersca@codefactory.se>
8111 * bus/dispatch.c (send_service_nonexistent_error): Fix typo.
8113 2003-03-13 Havoc Pennington <hp@pobox.com>
8115 * bus/test.c, bus/test.h, bus/Makefile.am, bus/test-main.c:
8116 set up a test framework as for the library
8118 2003-03-12 Havoc Pennington <hp@pobox.com>
8120 Throughout: purge global variables, introduce BusActivation,
8121 BusConnections, BusRegistry, etc. objects instead.
8123 * bus/bus.h, bus/bus.c: introduce BusContext as a global
8126 * test/Makefile.am (TEST_BINARIES): disable bus-test for now,
8127 going to redo this a bit differently I think
8129 2003-03-12 Havoc Pennington <hp@redhat.com>
8131 Mega-patch that gets the message bus daemon initially handling
8132 out-of-memory. Work still needed. Also lots of random
8133 moving stuff to DBusError instead of ResultCode.
8135 * dbus/dbus-list.c (_dbus_list_length_is_one): new function
8137 * dbus/dbus-connection.c
8138 (dbus_connection_send_with_reply_and_block): use DBusError
8140 * dbus/dbus-bus.c: adapt to API changes, make it use DBusError not
8143 * dbus/dbus-connection.c (dbus_connection_send): drop the result
8144 code here, as the only failure possible is OOM.
8146 * bus/connection.c (bus_connection_disconnect):
8147 rename bus_connection_disconnected as it's a notification only
8149 * bus/driver.c (bus_driver_handle_acquire_service): don't free
8150 "name" on get_args failure, should be done by get_args;
8151 don't disconnect client for bad args, just return an error.
8152 (bus_driver_handle_service_exists): ditto
8154 * bus/services.c (bus_services_list): NULL-terminate returned array
8156 * bus/driver.c (bus_driver_send_service_lost)
8157 (bus_driver_send_service_acquired): send messages from driver to a
8158 specific client to the client's unique name, not to the broadcast
8161 * dbus/dbus-message.c (decode_header_data): reject messages that
8162 contain no name field
8163 (_dbus_message_get_client_serial): rename to
8164 dbus_message_get_serial and make public
8165 (_dbus_message_set_serial): rename from set_client_serial
8166 (_dbus_message_set_reply_serial): make public
8167 (_dbus_message_get_reply_serial): make public
8169 * bus/connection.c (bus_connection_foreach): allow stopping
8170 iteration by returning FALSE from foreach function.
8172 * dbus/dbus-connection.c (dbus_connection_send_preallocated)
8173 (dbus_connection_free_preallocated_send)
8174 (dbus_connection_preallocate_send): new API for sending a message
8175 without possibility of malloc failure.
8176 (dbus_connection_send_message): rename to just
8177 dbus_connection_send (and same for whole function family)
8179 * dbus/dbus-errors.c (dbus_error_free): make this reinit the error
8181 * dbus/dbus-sysdeps.c (_dbus_exit): new function
8183 * bus/activation.c: handle/return errors
8185 * dbus/dbus-errors.h: add more DBUS_ERROR #define
8187 * dbus/dbus-sysdeps.c (_dbus_directory_open) (_dbus_file_get_contents)
8188 (_dbus_directory_get_next_file): use DBusError instead of DBusResultCode
8189 (_dbus_result_from_errno): move to this file
8191 2003-03-10 Anders Carlsson <andersca@codefactory.se>
8193 * dbus/dbus-marshal.c:
8194 (_dbus_marshal_set_string):
8195 Take a length argument so we can marshal the correct string
8198 (_dbus_marshal_dict), (_dbus_demarshal_dict),
8199 (_dbus_marshal_get_arg_end_pos), (_dbus_marshal_validate_arg),
8200 (_dbus_marshal_test):
8201 * dbus/dbus-marshal.h:
8202 Add support for marshalling and demarshalling dicts.
8204 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
8205 Add support for TYPE DICT.
8207 * dbus/dbus-message.c: (set_string_field):
8208 Adjust header padding.
8210 (dbus_message_append_args_valist), (dbus_message_append_dict),
8211 (dbus_message_get_args_valist), (dbus_message_iter_get_arg_type),
8212 (dbus_message_iter_get_dict), (_dbus_message_loader_return_buffer),
8213 (check_message_handling), (check_have_valid_message):
8214 * dbus/dbus-message.h:
8215 Add functions for setting and getting dicts.
8217 * dbus/dbus-protocol.h:
8223 * doc/dbus-specification.sgml:
8224 Add information about how dicts are marshalled.
8226 * test/data/invalid-messages/dict-with-nil-value.message:
8227 * test/data/invalid-messages/too-short-dict.message:
8228 * test/data/valid-messages/dict-simple.message:
8229 * test/data/valid-messages/dict.message:
8230 Add sample messages containing dicts.
8232 2003-03-08 Anders Carlsson <andersca@codefactory.se>
8234 * dbus/dbus-dict.h: Add DBUS_END_DECLS.
8236 2003-03-07 Anders Carlsson <andersca@codefactory.se>
8239 * dbus/dbus-dict.c: (dbus_dict_entry_free), (dbus_dict_new),
8240 (dbus_dict_get_keys), (insert_entry), (dbus_dict_set_boolean),
8241 (dbus_dict_set_int32), (dbus_dict_set_uint32),
8242 (dbus_dict_set_double), (dbus_dict_set_string),
8243 (dbus_dict_set_boolean_array), (dbus_dict_set_int32_array),
8244 (dbus_dict_set_uint32_array), (dbus_dict_set_double_array),
8245 (dbus_dict_set_string_array), (_dbus_dict_test):
8247 Fix according to comments from Havoc.
8249 2003-03-06 Michael Meeks <michael@server.home>
8251 * configure.in: if we don't have kde-config, disable have_qt.
8253 2003-03-07 Anders Carlsson <andersca@codefactory.se>
8258 * dbus/dbus-dict.c: (dbus_dict_entry_free), (dbus_dict_new),
8259 (dbus_dict_ref), (dbus_dict_unref), (dbus_dict_contains),
8260 (dbus_dict_remove), (dbus_dict_get_value_type),
8261 (dbus_dict_get_keys), (dbus_dict_put_boolean),
8262 (dbus_dict_put_int32), (dbus_dict_put_uint32),
8263 (dbus_dict_put_double), (dbus_dict_put_string),
8264 (dbus_dict_put_boolean_array), (dbus_dict_put_int32_array),
8265 (dbus_dict_put_uint32_array), (dbus_dict_put_double_array),
8266 (dbus_dict_put_string_array), (dbus_dict_get_boolean),
8267 (dbus_dict_get_int32), (dbus_dict_get_uint32),
8268 (dbus_dict_get_double), (dbus_dict_get_string),
8269 (dbus_dict_get_boolean_array), (dbus_dict_get_int32_array),
8270 (dbus_dict_get_uint32_array), (dbus_dict_get_double_array),
8271 (dbus_dict_get_string_array), (_dbus_dict_test):
8273 Add DBusDict implementation
8275 * dbus/dbus-test.c: (dbus_internal_do_not_use_run_tests):
8279 2003-03-04 Havoc Pennington <hp@pobox.com>
8281 * test/data/auth/*: adapt to changes
8283 * dbus/dbus-auth-script.c (_dbus_auth_script_run): add
8284 USERID_BASE64 and change USERNAME_BASE64 to put in username not
8287 * dbus/dbus-keyring.c (_dbus_keyring_validate_context): prevent
8288 more stuff from being in a context name, to make the protocol
8289 simpler to deal with
8291 * dbus/dbus-errors.c (dbus_error_has_name): new function
8292 (dbus_error_is_set): new function
8294 * dbus/dbus-auth.c: replace DBUS_STUPID_TEST_MECH auth
8295 with DBUS_COOKIE_SHA1, implement DBUS_COOKIE_SHA1
8297 * dbus/dbus-connection.c (dbus_connection_flush): also read
8298 messages during a flush operation
8300 * dbus/Makefile.am: remove dbus-md5 since it isn't currently used.
8302 2003-03-05 Anders Carlsson <andersca@codefactory.se>
8304 * configure.in: Check for gethostbyname on Solaris.
8306 * dbus/dbus-transport.c: (_dbus_transport_open):
8307 Remove duplicate "tcp" entry.
8309 * doc/dbus-specification.sgml:
8310 Clarify some things.
8312 2003-03-05 Anders Carlsson <andersca@codefactory.se>
8314 * dbus/dbus-auth.c: (send_rejected), (process_test_subdir):
8315 * dbus/dbus-keyring.c: (_dbus_keyring_new_homedir),
8316 (_dbus_keyring_test):
8317 * dbus/dbus-md5.c: (_dbus_md5_compute):
8318 * dbus/dbus-sha.c: (_dbus_sha_compute):
8321 2003-03-05 Anders Carlsson <andersca@codefactory.se>
8323 * README: Add some things.
8325 2003-03-04 Anders Carlsson <andersca@codefactory.se>
8327 * dbus/dbus-message.c (dbus_message_append_args_valist): Add a break;
8328 after case DBUS_TYPE_BOOELAN.
8330 2003-03-02 Havoc Pennington <hp@pobox.com>
8332 * test/break-loader.c (randomly_set_extreme_ints): add test that
8333 sets really huge and small integers
8335 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): add check
8336 that length of boolean array fits in the string, and that
8337 string has room for boolean value in single-bool case.
8339 * dbus/dbus-message-builder.c (_dbus_message_data_load): add
8340 optional value to "ALIGN" command which is what to fill the
8343 * test/data/valid-messages/no-padding.message: add regression
8344 test for the message padding problem
8346 2003-03-02 Havoc Pennington <hp@pobox.com>
8348 * dbus/dbus-message.c (decode_header_data): fix to always init
8349 message_padding, from Benjamin Dauvergne
8351 2003-03-02 Havoc Pennington <hp@pobox.com>
8357 2003-03-01 Joe Shaw <joe@assbarn.com>
8359 * configure.in: Check for "struct cmsgcred" and try to access its
8360 members for BSD-like unices.
8362 * dbus/dbus-sysdeps.c (read_credentials_byte): Fold this back into
8363 _dbus_read_credentials_unix_socket().
8364 (_dbus_read_credentials_unix_socket): Use recvmsg() instead of
8365 read() for reading the credential byte off the unix socket. Use
8366 struct cmsgcred on systems that support it.
8368 2003-02-27 Alexander Larsson <alexl@redhat.com>
8372 Make gthreads-2.0 dependency optional. Don't build thread test if
8375 2003-02-27 Havoc Pennington <hp@pobox.com>
8377 * dbus/dbus-connection.c
8378 (dbus_connection_send_message_with_reply_and_block): fix doh!
8379 doh! doh! bug that resulted in never removing a reply from the
8380 queue, no wonder we called get_reply_serial so much ;-)
8382 * dbus/dbus-message.c (struct DBusMessage): cache reply serial
8383 and client serial instead of demarshaling them every time
8385 2003-02-27 Havoc Pennington <hp@pobox.com>
8387 * dbus/dbus-marshal.c (_dbus_demarshal_int32): rewrite to be much
8388 more inlined, using dbus-string-private.h, speeds things up
8391 * dbus/dbus-string.c (_dbus_string_free): apply align offset
8392 when freeing the string
8393 (_dbus_string_steal_data): fix for align offset
8394 (undo_alignment): new function
8396 2003-02-26 Havoc Pennington <hp@redhat.com>
8398 All kinds of audit fixes from Owen, plus initial attempt to
8399 handle unaligned memory returned from malloc.
8401 * dbus/dbus-string.c (_dbus_string_init): clamp max length to
8402 leave room for align_offset and nul byte
8403 (fixup_alignment): function to track an align_offset and
8404 ensure real->str is aligned
8405 (DBUS_GENERIC_STRING_PREAMBLE): len must be less than allocated,
8406 to allow a nul byte plus align offset
8407 (_dbus_string_lock): fix overflow issue
8408 (_dbus_string_init_const_len): add assertions on sanity of len,
8409 assign allocated to be ALLOCATION_PADDING larger than len
8410 (set_length): fixup the overflow handling
8411 (_dbus_string_get_data_len): fix overflow in assertion
8412 (open_gap): detect overflow in size of gap to be opened
8413 (_dbus_string_lengthen): add overflow check
8414 (_dbus_string_align_length): fix overflow with _DBUS_ALIGN_VALUE
8415 (_dbus_string_append): add overflow check
8416 (_dbus_string_append_unichar): overflow
8417 (_dbus_string_delete): fix overflow in assertion
8418 (_dbus_string_copy_len): overflow in assertion
8419 (_dbus_string_replace_len): overflows in assertions
8420 (_dbus_string_find): change to implement in terms of
8421 _dbus_string_find_to
8422 (_dbus_string_find_to): assorted fixage
8423 (_dbus_string_equal_c_str): assert c_str != NULL,
8424 fix logic so the function works
8425 (_dbus_string_ends_with_c_str): fix overflow thingy
8426 (_dbus_string_base64_encode): overflow fix
8427 (_dbus_string_validate_ascii): overflow
8428 (_dbus_string_validate_nul): overflow
8430 2003-02-26 Havoc Pennington <hp@redhat.com>
8432 * dbus/dbus-marshal.c (_dbus_marshal_test): fix to work with DISABLE_ASSERTS
8434 2003-02-26 Alexander Larsson <alexl@redhat.com>
8437 Set DBUS_GLIB_THREADS_LIBS for apps using gthread-2.0
8439 * dbus/dbus-connection.c:
8440 * dbus/dbus-connection.h:
8441 Fix _dbus_connection_acquire_io_path and _dbus_connection_acquire_dispatch.
8442 Add dbus_connection_set_wakeup_main_function and use it when queueing
8443 incoming and outgoing messages.
8446 * dbus/dbus-dataslot.c:
8447 Threadsafe usage of DBusDataSlotAllocator
8449 * dbus/dbus-message.c: (dbus_message_get_args_iter):
8452 * dbus/dbus-server-unix.c:
8455 * glib/dbus-gmain.c:
8456 Implement the new wakeup functions for glib.
8459 * glib/test-thread-client.c:
8460 * glib/test-thread-server.c:
8461 * glib/test-thread.h:
8462 Initial cut at some thread test code. Not really done yet.
8464 2003-02-26 Havoc Pennington <hp@pobox.com>
8466 * dbus/dbus-connection.c
8467 (dbus_connection_send_message_with_reply_and_block): fix crash
8468 where we ref'd the outgoing message instead of the returned reply
8470 * dbus/dbus-transport-unix.c (do_authentication): check read watch
8471 at the end of this function, so if we didn't need to read for
8472 authentication, we reinstall it for receiving messages
8474 * dbus/dbus-message.c (dbus_message_new_reply): allow replies to
8475 a NULL sender for peer-to-peer case
8477 * dbus/dbus-transport-unix.c (check_read_watch): handle
8478 !authenticated case correctly
8480 * glib/dbus-gmain.c: add support for DBusServer
8482 * dbus/dbus-server.c: add data slot support
8484 * glib/dbus-gmain.c (dbus_connection_setup_with_g_main): check
8485 return values and handle errors
8487 * dbus/dbus-dataslot.c: factor out the data slot stuff from
8490 * Doxyfile.in (INPUT): add glib subdir
8492 * glib/dbus-gmain.c (dbus_connection_setup_with_g_main): rename
8493 setup_with_g_main instead of hookup_with_g_main; write docs
8495 2003-02-24 Anders Carlsson <andersca@codefactory.se>
8497 * dbus/dbus-marshal.c: (_dbus_marshal_validate_arg):
8498 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
8499 * dbus/dbus-message.c: (dbus_message_append_boolean),
8500 (dbus_message_append_boolean_array),
8501 (dbus_message_get_args_valist), (_dbus_message_test):
8502 * dbus/dbus-message.h:
8503 * doc/dbus-specification.sgml:
8504 Various fixes as pointed out by Havoc.
8506 * test/data/invalid-messages/bad-boolean-array.message:
8507 * test/data/invalid-messages/bad-boolean.message:
8508 Add invalid boolean value test cases.
8510 2003-02-24 Anders Carlsson <andersca@codefactory.se>
8512 * dbus/dbus-internals.c: (_dbus_type_to_string):
8513 * dbus/dbus-marshal.c: (_dbus_marshal_get_arg_end_pos),
8514 (_dbus_marshal_validate_arg):
8515 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
8516 * dbus/dbus-message.c: (dbus_message_append_args_valist),
8517 (dbus_message_append_boolean), (dbus_message_append_boolean_array),
8518 (dbus_message_get_args_valist), (dbus_message_iter_get_boolean),
8519 (dbus_message_iter_get_int32), (dbus_message_iter_get_uint32),
8520 (dbus_message_iter_get_double),
8521 (dbus_message_iter_get_boolean_array), (message_iter_test):
8522 * dbus/dbus-message.h:
8523 * dbus/dbus-protocol.h:
8524 * doc/dbus-specification.sgml:
8525 * test/data/valid-messages/lots-of-arguments.message:
8526 Add support for boolean and boolean array types.
8528 2003-02-23 Havoc Pennington <hp@pobox.com>
8530 * dbus/dbus-keyring.c: finish most of this implementation and
8533 * dbus/dbus-errors.c (dbus_set_error_const, dbus_set_error): make
8534 these barf if the error isn't cleared to NULL
8536 * dbus/dbus-sysdeps.c (_dbus_delete_file): set error on failure
8537 (_dbus_create_directory): new function
8539 * dbus/dbus-errors.c (dbus_set_error): fix warning
8541 * dbus/dbus-string.c (_dbus_string_hex_encode): new function
8542 (_dbus_string_hex_decode): new function
8543 (test_hex_roundtrip): test code
8545 * dbus/dbus-sha.c (_dbus_sha_compute): use dbus_string_hex_encode
8547 * dbus/dbus-md5.c (_dbus_md5_compute): use dbus_string_hex_encode
8549 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): make this use
8550 the save-to-temp/rename trick to atomically write the new file
8551 (_dbus_string_parse_uint): new function
8553 2003-02-22 Havoc Pennington <hp@pobox.com>
8555 * test/Makefile.am (dist-hook): fix dist for test/data/sha-1
8557 2003-02-22 Havoc Pennington <hp@pobox.com>
8559 * dbus/dbus-message.c (dbus_message_iter_get_string_array):
8560 (dbus_message_iter_get_byte_array): Fix up doxygen warnings
8562 * dbus/dbus-sha.c: add implementation of SHA-1 algorithm
8564 * dbus/test/data/sha-1: add US government test suite for SHA-1
8566 2003-02-21 Anders Carlsson <andersca@codefactory.se>
8568 * dbus/dbus-marshal.c: (_dbus_demarshal_string_array):
8569 Make string arrays NULL-terminated.
8571 * dbus/dbus-memory.c: (dbus_free_string_array):
8572 * dbus/dbus-memory.h:
8573 New function for freeing NULL-terminated string arrays.
8575 * dbus/dbus-message-builder.c: (append_quoted_string),
8576 (_dbus_message_data_load):
8577 Add support for array types.
8579 * dbus/dbus-message.c: (check_message_handling):
8580 Add more types as test cases.
8582 * dbus/dbus-sysdeps.c: (_dbus_string_parse_int),
8583 (_dbus_string_parse_double):
8584 Add the start offset to the end offset.
8586 * test/data/valid-messages/lots-of-arguments.message:
8587 New test message with lots of arguments.
8589 2003-02-21 Anders Carlsson <andersca@codefactory.se>
8591 * dbus/dbus-message.c: (dbus_message_append_nil),
8592 (dbus_message_append_int32), (dbus_message_append_uint32),
8593 (dbus_message_append_double), (dbus_message_append_string),
8594 (dbus_message_append_int32_array),
8595 (dbus_message_append_uint32_array),
8596 (dbus_message_append_double_array),
8597 (dbus_message_append_byte_array),
8598 (dbus_message_append_string_array):
8599 Fix all out-of-memory handling in these functions.
8601 2003-02-21 Anders Carlsson <andersca@codefactory.se>
8603 * dbus/dbus-message.c: (dbus_message_append_nil):
8606 2003-02-21 Anders Carlsson <andersca@codefactory.se>
8608 * dbus/dbus-message.c: (dbus_message_append_args_valist),
8609 (dbus_message_append_nil), (dbus_message_append_int32_array),
8610 (dbus_message_append_uint32_array),
8611 (dbus_message_append_double_array),
8612 (dbus_message_append_byte_array),
8613 (dbus_message_append_string_array), (dbus_message_get_args_valist),
8614 (dbus_message_iter_get_int32_array),
8615 (dbus_message_iter_get_uint32_array),
8616 (dbus_message_iter_get_double_array),
8617 (dbus_message_iter_get_byte_array),
8618 (dbus_message_iter_get_string_array):
8620 * dbus/dbus-message.h:
8621 Add functions for appending and getting arrays.
8623 2003-02-21 Anders Carlsson <andersca@codefactory.se>
8625 * dbus/dbus-mempool.c (_dbus_mem_pool_new): Make the
8626 element size at least 8 bytes, fixes mempool tests on
8629 2003-02-20 Alexander Larsson <alexl@redhat.com>
8631 * dbus/dbus-transport-unix.c (unix_do_iteration):
8632 Unlock the connection mutex during a blocking select call.
8633 Add todo about how we need a way to wake up the select.
8635 * dbus/dbus-connection-internal.h:
8636 * dbus/dbus-connection.c:
8637 Add _dbus_connection_lock and _dbus_connection_unlock.
8639 2003-02-19 Havoc Pennington <hp@pobox.com>
8641 * Doxyfile.in (PREDEFINED): put DOXYGEN_SHOULD_SKIP_THIS in
8642 Doxyfile.in, not Doxyfile
8644 * dbus/dbus-keyring.c: do some hacking on this
8646 * dbus/dbus-sysdeps.c (_dbus_delete_file): new
8648 * dbus/dbus-errors.c (dbus_set_error_const): do not call
8650 (dbus_set_error): remove dbus_error_init, check for message ==
8651 NULL *before* we sprintf into it, and add @todo about including
8652 system headers in this file
8654 * dbus/dbus-sysdeps.c (_dbus_create_file_exclusively): new
8656 * dbus/dbus-errors.h (DBUS_ERROR_FAILED): add
8658 * dbus/dbus-sysdeps.c (get_user_info): break this function out to
8659 get various bits of user information based on either username
8661 (_dbus_homedir_from_username): new function
8663 2003-02-19 Anders Carlsson <andersca@codefactory.se>
8666 Add check for nonposix getpwnam_r
8668 * dbus/dbus-mempool.c: (_dbus_mem_pool_new):
8669 Align the pool element size to a sizeof (void *) boundary.
8671 * dbus/dbus-sysdeps.c: (_dbus_setenv), (_dbus_connect_unix_socket),
8672 (_dbus_listen_unix_socket), (_dbus_credentials_from_username):
8673 General Solaris fixes.
8675 * test/data/valid-messages/simplest-manual.message:
8676 Explicitly state that we want little-endian packing.
8678 2003-02-19 Mikael Hallendal <micke@codefactory.se>
8680 * dbus/dbus-server.c (dbus_server_listen): Support tcp: addresses.
8682 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_tcp_socket):
8683 Added to create a transport connecting using a tcp/ip socket.
8685 * dbus/dbus-sysdeps.c (_dbus_connect_tcp_socket): Added to connect
8686 to a tcp socket at given host and port.
8687 (_dbus_listen_tcp_socket): added to listen on tcp socket for given
8690 * dbus/dbus-server.c (dbus_server_listen): Support tcp: addresses.
8692 * dbus/dbus-server-unix.c (_dbus_server_new_for_tcp_socket):
8693 Added to create a server listening on a TCP/IP socket.
8695 2003-02-19 Havoc Pennington <hp@pobox.com>
8697 Throughout: mop up all the Doxygen warnings and undocumented
8700 * dbus/dbus-sysdeps.c (do_exec): do not use execvp, we don't want
8701 to search any paths.
8703 * dbus/dbus-threads.c: move global mutex initializers to
8704 dbus-internals.h, multiple prototypes was confusing doxygen
8705 besides being kind of ugly
8707 * Doxyfile (PREDEFINED): have Doxygen define
8708 DOXYGEN_SHOULD_SKIP_THIS so we can exclude things from
8709 docs with #ifndef DOXYGEN_SHOULD_SKIP_THIS
8710 (do not abuse the feature! it's for stuff like the autogenerated
8711 macros in dbus-md5.c, not just for things you don't feel like
8714 2003-02-18 Havoc Pennington <hp@pobox.com>
8716 * dbus/dbus-string.c (_dbus_string_zero): new function
8718 * dbus/dbus-md5.c: include MD5 implementation by L. Peter Deutsch,
8719 wrap it in some dbus-friendly API
8721 * dbus/dbus-types.h: add 16-bit types
8723 2003-02-18 Joe Shaw <joe@assbarn.com>
8725 * dbus/dbus-auth.c (handle_server_data_stupid_test_mech): Just get
8726 credentials from our currently running process.
8727 (get_word): Fix a buglet where we were copying the entire length
8728 instead of relative to our position.
8730 * dbus/dbus-hash.c (_dbus_hash_test): Don't try to allocate the
8731 keys on the stack... it's 640k of data.
8733 * dbus/dbus-sysdeps.c (_dbus_read_credentials_unix_socket): Always
8734 read the credentials byte off the socket, even if we don't have
8736 (_dbus_poll): Implement poll() using select() for systems which
8739 * glib/test-dbus-glib.c (main): Print out an error if no
8740 parameters are given.
8742 * test/data/auth/fallback.auth-script: Added. Tests that a client
8743 can fallback to a secondary auth mechanism if the first fails.
8745 2003-02-18 Havoc Pennington <hp@pobox.com>
8749 2003-02-17 Havoc Pennington <hp@pobox.com>
8751 * doc/dbus-specification.sgml: lots of cosmetic
8752 cleanups/rearrangement, add assorted FIXME, change DBUS_ADDRESS
8753 env variable to DBUS_BUS_ADDRESS, s/client/application/,
8754 s/server/bus/ (except in authentication section). Add a section
8755 "Message Bus Message Routing"
8757 2003-02-17 Anders Carlsson <andersca@codefactory.se.>
8763 2003-02-17 Anders Carlsson <andersca@codefactory.se>
8765 * doc/dbus-specification.sgml:
8766 Specification updates.
8768 2003-02-17 Anders Carlsson <andersca@codefactory.se>
8770 * bus/activation.c: (bus_activation_init), (child_setup),
8771 (bus_activation_activate_service):
8773 * bus/main.c: (main):
8774 Set DBUS_ADDRESS environment variable.
8776 * dbus/dbus-errors.c: (dbus_set_error):
8777 Don't use va_copy since that's a C99 feature.
8779 * dbus/dbus-sysdeps.c: (_dbus_setenv), (do_exec),
8780 (_dbus_spawn_async):
8781 * dbus/dbus-sysdeps.h:
8782 Add child_setup_func to _dbus_spawn_async.
8784 * doc/dbus-specification.sgml:
8785 Update specification.
8787 * test/spawn-test.c: (setup_func), (main):
8790 2003-02-17 Alexander Larsson <alexl@redhat.com>
8792 * dbus/dbus-connection.c (_dbus_connection_handler_destroyed_locked):
8795 2003-02-17 Anders Carlsson <andersca@codefactory.se>
8799 * doc/dbus-test-plan.sgml:
8800 Add test plan document.
8805 2003-02-17 Anders Carlsson <andersca@codefactory.se>
8807 * dbus/dbus-message.c: (decode_header_data),
8808 (_dbus_message_loader_return_buffer):
8809 Set the header padding amount when loading a message.
8811 2003-02-16 Anders Carlsson <andersca@codefactory.se>
8813 * bus/dispatch.c: (send_one_message):
8814 Only send broadcast messages to registered connections.
8816 * dbus/dbus-message.c: (dbus_message_name_is):
8817 * dbus/dbus-message.h:
8818 New convenience function.
8820 * dbus/dbus-transport-debug.c: (do_reading):
8821 Only dispatch one message per run.
8824 * test/bus-test.c: (new_connection_callback), (die),
8825 (test_hello_client1_handler), (test_hello_client2_handler),
8826 (test_hello_replies), (main):
8828 * test/bus-test-loop.[ch]:
8831 2003-02-16 Havoc Pennington <hp@pobox.com>
8833 * dbus/dbus-connection.c (dbus_connection_dispatch_message): fix
8834 backward conditional
8836 2003-02-16 Alexander Larsson <alexl@redhat.com>
8838 * dbus/dbus-connection.c:
8839 Implement sent_message_with_reply. (with_reply_and block is still
8841 Made dispatch_message not lose message if OOM.
8843 * dbus/dbus-errors.h:
8844 Add NoReply error (for reply timeouts).
8846 2003-02-16 Alexander Larsson <alexl@redhat.com>
8848 * dbus/dbus-hash.c (_dbus_hash_table_unref):
8849 Actually free keys and values when destroying hashtable.
8851 2003-02-16 Anders Carlsson <andersca@codefactory.se>
8853 * dbus/dbus-auth.c: (client_try_next_mechanism):
8856 * dbus/dbus-threads.c: (dbus_condvar_wait_timeout):
8857 Return TRUE if there's no thread implementation around.
8859 * glib/dbus-gmain.c: (free_source),
8860 (dbus_connection_hookup_with_g_main):
8861 Make sure to remove the GSource when the connection is finalized.
8863 2003-02-16 Anders Carlsson <andersca@codefactory.se>
8865 * bus/dispatch.c: (bus_dispatch_message_handler):
8866 * dbus/dbus-errors.h:
8867 Return an error if someone tries to send a message to a service
8870 2003-02-16 Anders Carlsson <andersca@codefactory.se>
8872 * bus/activation.c: (load_directory), (bus_activation_init),
8873 (bus_activation_activate_service):
8876 (bus_driver_handle_activate_service), (bus_driver_handle_message):
8877 More work on the activation handling.
8879 * dbus/dbus-errors.h:
8880 Add some error messages
8882 * dbus/dbus-message.c: (dbus_message_new_error_reply):
8883 * dbus/dbus-message.h:
8884 New function that creates an error message.
8886 * dbus/dbus-protocol.h:
8887 Add ACTIVATE_SERVER message.
8889 * dbus/dbus-server-unix.c: (unix_handle_watch),
8890 (_dbus_server_new_for_domain_socket):
8891 Call _dbus_fd_set_close_on_exec.
8893 * dbus/dbus-sysdeps.c: (make_pipe), (do_exec),
8894 (_dbus_spawn_async), (_dbus_disable_sigpipe),
8895 (_dbus_fd_set_close_on_exec):
8896 * dbus/dbus-sysdeps.h:
8897 Add _dbus_fd_set_close_on exec function. Also add function that checks
8898 that all open fds are set to close-on-exec and warns otherwise.
8900 * dbus/dbus-transport-unix.c:
8901 (_dbus_transport_new_for_domain_socket):
8902 Call _dbus_fd_set_close_on_exec.
8904 2003-02-16 Havoc Pennington <hp@pobox.com>
8906 * dbus/dbus-connection.c (dbus_connection_set_change_sigpipe):
8907 allow people to avoid setting SIGPIPE to SIG_IGN
8908 (_dbus_connection_new_for_transport): disable SIGPIPE unless
8909 we've been asked not to
8911 2003-02-15 Anders Carlsson <andersca@codefactory.se>
8913 * dbus/dbus-list.c: (_dbus_list_append_link),
8914 (_dbus_list_prepend_link):
8915 * dbus/dbus-memory.c: (dbus_malloc), (dbus_malloc0),
8919 2003-02-15 Anders Carlsson <andersca@codefactory.se>
8922 * bus/activation.c: (bus_activation_entry_free),
8923 (add_desktop_file_entry), (load_directory), (bus_activation_init):
8925 * bus/main.c: (main):
8926 Add simple activation support, doesn't work yet though.
8928 2003-02-15 Zack Rusin <zack@kde.org>
8930 * qt/dbus-qthread.cpp: small casting fix
8932 2003-02-15 Anders Carlsson <andersca@codefactory.se>
8934 * dbus/dbus-errors.c: (dbus_set_error):
8935 * dbus/dbus-errors.h:
8936 Add a few errors and make dbus_set_error void.
8938 * dbus/dbus-sysdeps.c:
8939 (_dbus_errno_to_string), (close_and_invalidate), (make_pipe),
8940 (write_err_and_exit), (read_ints), (do_exec), (_dbus_spawn_async):
8941 * dbus/dbus-sysdeps.h:
8942 Add _dbus_spawn_async.
8944 * test/spawn-test.c: (main):
8945 Test for _dbus_spawn_async.
8947 2003-02-15 Anders Carlsson <andersca@codefactory.se>
8949 * dbus/dbus-internals.h:
8950 Fix build without tests.
8952 * dbus/dbus-list.c: (alloc_link):
8953 Fix a segfault when a malloc fails.
8955 * dbus/dbus-memory.c: (initialize_malloc_debug), (dbus_malloc),
8956 (dbus_malloc0), (dbus_realloc):
8957 Add support for malloc debugging.
8959 2003-02-15 Alexander Larsson <alexl@redhat.com>
8961 * dbus/dbus-threads.c:
8962 * dbus/dbus-threads.h:
8963 Add condvars. Remove static mutext from API.
8964 Implement static mutexes by initializing them from threads_init.
8966 * glib/dbus-gthread.c:
8967 * qt/dbus-qthread.cpp:
8968 Update with the thread api changes.
8973 Turn StaticMutex into normal mutex + init function.
8974 Export new functions _dbus_list_alloc_link, _dbus_list_free_link,
8975 _dbus_list_append_link, _dbus_list_prepend_link
8978 * dbus/dbus-sysdeps.c:
8979 * dbus/dbus-sysdeps.h:
8980 New type dbus_atomic_t, and new functions _dbus_atomic_inc,
8981 _dbus_atomic_dec. Only slow fallback implementation at the moment.
8983 * dbus/dbus-protocol.h:
8984 Add DBUS_MESSAGE_LOCAL_DISCONNECT define
8986 * dbus/dbus-message.c:
8987 Make ref/unref atomic.
8990 * dbus/dbus-connection-internal.h:
8991 * dbus/dbus-connection.c:
8992 * dbus/dbus-connection.h:
8994 Change _peek to _borrow,_return & _steal_borrowed.
8995 Change disconnect callback to event.
8996 Make dbus_connection_dispatch_messages reentrant.
8998 * dbus/dbus-transport.c:
8999 Don't ref the connection on calls to the transport
9002 * dbus/dbus-message-handler.c:
9005 * glib/dbus-gmain.c:
9006 Don't use peek_message anymore
9009 * test/debug-thread.c:
9010 * test/debug-thread.h:
9011 Simple thread implementation that asserts() on deadlocks in
9012 single-threaded code.
9015 (main) Call debug_threads_init.
9018 Use disconnect message instead of disconnect callback.
9022 Don't call dbus_connection_set_disconnect_function. Instead export
9023 bus_connection_disconnect.
9026 Call bus_connection_disconnect when we get a disconnected message.
9028 2003-02-15 Havoc Pennington <hp@pobox.com>
9030 * dbus/dbus-message.c (dbus_message_new): fool around with the
9033 2003-02-14 Havoc Pennington <hp@pobox.com>
9035 * dbus/dbus-mempool.c: fail if the debug functions so indicate
9037 * dbus/dbus-memory.c: fail if the debug functions indicate we
9040 * dbus/dbus-internals.c (_dbus_set_fail_alloc_counter)
9041 (_dbus_decrement_fail_alloc_counter): debug functions to
9042 simulate memory allocation failures
9044 2003-02-14 Havoc Pennington <hp@pobox.com>
9046 * dbus/dbus-errors.h (struct DBusError): add a word of padding
9049 2003-02-13 Anders Carlsson <andersca@codefactory.se>
9051 * bus/driver.c: (bus_driver_handle_hello):
9053 * bus/services.c: (bus_service_lookup):
9054 Reorder message sending so we get a more sane order.
9056 * test/bus-test.c: (message_handler):
9059 2003-02-13 Anders Carlsson <andersca@codefactory.se>
9061 * bus/driver.c: (bus_driver_send_service_deleted),
9062 (bus_driver_send_service_created), (bus_driver_send_service_lost),
9063 (bus_driver_send_service_acquired), (bus_driver_handle_hello),
9064 (bus_driver_send_welcome_message),
9065 (bus_driver_handle_list_services),
9066 (bus_driver_handle_acquire_service),
9067 (bus_driver_handle_service_exists):
9068 * dbus/dbus-bus.c: (dbus_bus_register_client),
9069 (dbus_bus_acquire_service), (dbus_bus_service_exists):
9070 * dbus/dbus-errors.c: (dbus_result_to_string):
9071 * dbus/dbus-errors.h:
9072 * dbus/dbus-message.c: (dbus_message_append_args),
9073 (dbus_message_append_args_valist), (dbus_message_get_args),
9074 (dbus_message_get_args_valist), (dbus_message_get_args_iter),
9075 (dbus_message_iter_get_arg_type), (dbus_message_iter_get_string),
9076 (dbus_message_iter_get_byte_array),
9077 (dbus_message_iter_get_string_array), (message_iter_test),
9078 (check_message_handling), (_dbus_message_test):
9079 * dbus/dbus-message.h:
9080 * test/bus-test.c: (main):
9081 Change fields to arguments in messages, so that they won't be
9082 confused with header fields.
9084 * glib/test-dbus-glib.c: (main):
9085 Remove append_fields from hello message.
9087 2003-02-13 Anders Carlsson <andersca@codefactory.se>
9089 * dbus/dbus-errors.c:
9090 * dbus/dbus-message.c:
9091 * dbus/dbus-string.c:
9092 Documentation fixes.
9094 2003-02-13 Anders Carlsson <andersca@codefactory.se>
9096 * glib/dbus-gmain.c: (timeout_handler), (add_timeout),
9098 Implement support for timeouts in dbus-glib.
9100 2003-02-13 Anders Carlsson <andersca@codefactory.se>
9102 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
9103 * dbus/dbus-message.c: (process_test_subdir):
9104 * test/break-loader.c: (find_breaks_based_on):
9105 Plug some memory leaks.
9107 2003-02-13 Richard Hult <rhult@codefactory.se>
9109 * bus/main.c: Fix build.
9111 * dbus/dbus-errors.h:
9112 * dbus/dbus-errors.c: Fix copyright for Anders.
9114 2003-02-13 Anders Carlsson <andersca@codefactory.se>
9119 * bus/connection.c: (bus_connection_foreach):
9122 * bus/desktop-file.c: (grow_lines_in_section), (grow_sections),
9123 (unescape_string), (new_section), (parse_section_start),
9124 (parse_key_value), (report_error), (bus_desktop_file_load),
9125 (bus_desktop_file_get_string):
9126 * bus/desktop-file.h:
9127 Use DBusError for error reporting.
9129 * bus/dispatch.c: (send_one_message),
9130 (bus_dispatch_message_handler):
9131 * bus/driver.c: (bus_driver_send_service_deleted),
9132 (bus_driver_send_service_created), (bus_driver_send_service_lost),
9133 (bus_driver_send_service_acquired), (bus_driver_handle_hello),
9134 (bus_driver_send_welcome_message),
9135 (bus_driver_handle_list_services),
9136 (bus_driver_handle_acquire_service),
9137 (bus_driver_handle_service_exists):
9138 * bus/loop.c: (bus_loop_run):
9140 Use BUS_HANDLE_OOM instead of _DBUS_HANDLE_OOM.
9142 * bus/utils.c: (bus_wait_for_memory):
9144 New files with general utility functions.
9146 * dbus/dbus-internals.h:
9147 Remove _DBUS_HANDLE_OOM.
9149 2003-02-13 Anders Carlsson <andersca@codefactory.se>
9151 * dbus/dbus-errors.c: (dbus_result_to_string), (dbus_error_init),
9152 (dbus_error_free), (dbus_set_error_const), (dbus_set_error):
9153 * dbus/dbus-errors.h:
9154 Add DBusError structure.
9156 2003-02-13 Anders Carlsson <andersca@codefactory.se>
9158 * test/data/valid-messages/standard-acquire-service.message:
9159 * test/data/valid-messages/standard-hello.message:
9160 * test/data/valid-messages/standard-list-services.message:
9161 * test/data/valid-messages/standard-service-exists.message:
9162 Add some standard messages.
9164 2003-02-13 Anders Carlsson <andersca@codefactory.se>
9166 * bus/driver.c: (bus_driver_send_welcome_message),
9167 (bus_driver_handle_list_services),
9168 (bus_driver_handle_acquire_service),
9169 (bus_driver_handle_service_exists), (bus_driver_handle_message):
9170 Update for API changes in libdbus.
9172 * dbus/dbus-message.c: (dbus_message_new_reply):
9173 * dbus/dbus-message.h:
9174 Remove the name argument. The spec states that replies shouldn't
9177 2003-02-13 Anders Carlsson <andersca@codefactory.se>
9179 * bus/desktop-file.c: (parse_section_start), (parse_key_value),
9180 (report_error), (bus_desktop_file_load), (lookup_section),
9181 (lookup_line), (bus_desktop_file_get_raw),
9182 (bus_desktop_file_get_string):
9183 * bus/desktop-file.h:
9184 Some fixes, and new functions for getting a key value from a section.
9186 2003-02-13 Havoc Pennington <hp@pobox.com>
9188 * test/data/auth/fail-after-n-attempts.auth-script: new test
9190 * dbus/dbus-auth.c (send_rejected): shutdown_mech() when we
9193 2003-02-13 Havoc Pennington <hp@pobox.com>
9195 * dbus/dbus-auth.c (handle_server_data_external_mech): args to
9196 dbus_credentials_match were backward
9198 * dbus/dbus-auth-script.c (_dbus_auth_script_run): support
9199 NO_CREDENTIALS and ROOT_CREDENTIALS
9201 * dbus/dbus-auth.c (_dbus_auth_do_work): move get_state() routine
9202 into here. Never process more commands after we've reached an
9203 end state; store further data as unused bytes.
9205 * test/data/auth/*: add more auth tests
9207 * dbus/dbus-auth-script.c (_dbus_auth_script_run): support EXPECT
9208 command to match exact string and EXPECT_UNUSED to match unused
9211 * test/Makefile.am (dist-hook): fix to dist all the test stuff
9213 2003-02-12 Havoc Pennington <hp@pobox.com>
9215 * dbus/dbus-string.c (_dbus_string_pop_line): fix to also strip
9216 \r off of popped lines
9218 * dbus/dbus-auth.c (_dbus_auth_test): write code to run auth
9221 * dbus/dbus-auth-script.c (_dbus_auth_script_run): when doing a
9224 2003-02-12 Havoc Pennington <hp@pobox.com>
9226 * dbus/Makefile.am: remove break-loader from the build, since it
9229 * configure.in: add --enable-gcov to turn on coverage profiling
9230 flags and disable optimization
9232 2003-02-10 Havoc Pennington <hp@pobox.com>
9234 * dbus/dbus-auth-script.c, dbus/dbus-auth-script.h: sync
9235 initial cut at test framework for DBusAuth from laptop.
9236 Doesn't quite work yet but it compiles and I need to get
9237 it off the 266mhz laptop. ;-)
9239 * dbus/dbus-server-debug.c (_dbus_server_debug_accept_transport):
9240 fix a memleak in error case
9242 2003-02-12 Anders Carlsson <andersca@codefactory.se>
9245 * bus/desktop-file.c:
9246 * bus/desktop-file.h:
9247 Add a desktop file parser.
9249 2003-02-11 Zack Rusin <zack@kde.org>
9251 * qt/message.[h|cpp]: sample implementation
9252 of the KDE wrapper for DBusMessage
9254 2003-02-09 Zack Rusin <zack@kde.org>
9256 * test/bus-test.c: make_it_compile
9257 * doc/dbus-specification.sgml: minimal semantic fix
9259 2003-02-06 Anders Carlsson <andersca@codefactory.se>
9265 2003-02-06 Anders Carlsson <andersca@codefactory.se>
9268 * dbus/dbus-break-loader.c:
9270 * test/break-loader.c:
9271 Move dbus-break-loader to test/ and rename it to break-loader.
9273 2003-02-02 Havoc Pennington <hp@pobox.com>
9275 * dbus/dbus-keyring.c, dbus/dbus-keyring.h: template files
9276 for code to manage cookies in your home directory
9278 * dbus/dbus-sysdeps.c (_dbus_generate_random_bytes): new function
9280 * dbus/dbus-auth.c (get_state): impose a maximum number of tries
9281 to authenticate, then disconnect the client.
9283 2003-02-03 Alexander Larsson <alexl@redhat.com>
9285 * dbus/dbus-message.c (dbus_message_append_fields):
9288 2003-02-02 Anders Carlsson <andersca@codefactory.se>
9290 * doc/dbus-specification.sgml:
9291 Update address format section.
9293 2003-02-02 Anders Carlsson <andersca@codefactory.se>
9296 * test/bus-test.c: (get_time), (add_timeout), (remove_timeout),
9297 (message_handler), (new_connection_callback), (loop_quit),
9301 2003-02-02 Anders Carlsson <andersca@codefactory.se>
9303 * bus/driver.c: (bus_driver_handle_service_exists):
9304 Simplify the code a bit.
9306 * dbus/dbus-bus.c: (dbus_bus_service_exists):
9309 2003-02-02 Anders Carlsson <andersca@codefactory.se>
9312 Add libdbus-daemon.la and link to it.
9314 2003-02-01 James Willcox <jwillcox@gnome.org>
9316 * bus/driver.c: (bus_driver_handle_own_service):
9317 Actually include the service reply code in the message.
9319 2003-02-02 Anders Carlsson <andersca@codefactory.se>
9321 * bus/driver.c: (bus_driver_handle_service_exists):
9322 Don't unref the incoming message.
9324 2003-02-02 Anders Carlsson <andersca@codefactory.se>
9326 * dbus/dbus.h: Add dbus-address.h and dbus-bus.h
9328 2003-02-02 Anders Carlsson <andersca@codefactory.se>
9330 * dbus/dbus-server.c: (dbus_server_listen):
9331 * dbus/dbus-transport.c: (_dbus_transport_open):
9332 ifdef out the calls to the debug transport and server.
9334 2003-02-02 Alexander Larsson <alexl@redhat.com>
9336 * dbus/dbus-watch.c (dbus_watch_get_flags):
9337 Add note in the docs that ERROR or HANGUP won't be returned
9338 and are assumed always on.
9340 * glib/dbus-gmain.c (add_watch):
9341 Always add IO_ERR | IO_HUP
9343 * dbus/dbus-message.h:
9344 Add semicolon after dbus_message_iter_get_string_array().
9345 Makes qt code build again
9347 2003-02-01 Anders Carlsson <andersca@codefactory.se>
9349 * bus/driver.c: (create_unique_client_name),
9350 (bus_driver_handle_hello):
9351 Don't take a name, just use a numeric id to identify
9355 * dbus/dbus-bus.c: (dbus_bus_register_client),
9356 (dbus_bus_acquire_service), (dbus_bus_service_exists):
9358 Add new convenience functions for communicating with the bus.
9360 * dbus/dbus-message.h:
9362 * dbus/dbus-protocol.h:
9365 2003-02-01 Alexander Larsson <alexl@redhat.com>
9367 * dbus/dbus-message.c (dbus_message_append_fields):
9368 Add some more doc comments.
9370 2003-02-01 Havoc Pennington <hp@pobox.com>
9372 * dbus/dbus-break-loader.c (randomly_modify_length): change
9373 a 4-byte value in the message as if it were a length
9375 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): don't set
9376 execute bit on saved files
9378 2003-02-01 Havoc Pennington <hp@pobox.com>
9380 * dbus/dbus-break-loader.c (main): new program to find messages
9381 that break the loader.
9383 * dbus/dbus-sysdeps.c (_dbus_string_append_uint): new function
9384 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): new function
9386 * dbus/dbus-string.c (_dbus_string_set_byte): new
9388 2003-01-31 Havoc Pennington <hp@pobox.com>
9390 * dbus/dbus-message.c: refactor the test code to be more general,
9391 in preparation for writing a "randomly permute test cases to
9392 try to break the loader" program.
9394 2003-01-31 Havoc Pennington <hp@pobox.com>
9396 * doc/dbus-specification.sgml: work on the specification
9398 * dbus/dbus-message.c (_dbus_message_loader_return_buffer): check
9399 the protocol version of the message.
9401 * dbus/dbus-protocol.h: drop special _REPLY names, the spec
9402 no longer specifies that.
9403 (DBUS_SERVICE_REPLY_SERVICE_EXISTS): fix flags (1/2/4/8 not
9406 * dbus/dbus-marshal.c (_dbus_marshal_get_arg_end_pos): add missing
9407 "break" for DBUS_TYPE_NIL, remove @todo
9409 2003-01-31 Havoc Pennington <hp@pobox.com>
9411 * dbus/dbus-message.c (dbus_message_set_is_error_reply): rename
9412 just set_is_error/get_is_error as this is a commonly-used
9413 function, and write docs.
9415 2003-01-31 Anders Carlsson <andersca@codefactory.se>
9417 * dbus/dbus-address.c: (dbus_address_entry_free):
9418 Free key and value lists.
9420 * dbus/dbus-internals.c: (_dbus_type_to_string):
9421 Add the types we didn't have.
9423 * dbus/dbus-marshal.c: (_dbus_marshal_get_arg_end_pos),
9424 (_dbus_marshal_validate_arg):
9427 * dbus/dbus-message.c: (dbus_message_set_sender):
9428 Remove todo about being able to set sender to NULL.
9430 (dbus_message_set_is_error_reply),
9431 (dbus_message_get_is_error_reply):
9432 * dbus/dbus-message.h:
9435 * dbus/dbus-protocol.h:
9436 Add error reply flag.
9438 * test/data/valid-messages/opposite-endian.message:
9439 Add NIL type to test.
9441 2003-01-31 Havoc Pennington <hp@pobox.com>
9443 * doc/dbus-specification.sgml: fully specify the header. Add
9444 flags and major protocol version, and change header/body len to
9447 * dbus/dbus-message-builder.c (append_saved_length): append length
9450 * dbus/dbus-message.c (dbus_message_create_header): change header
9451 length and body length to unsigned. Add the new fields from the
9453 (_dbus_message_loader_return_buffer): unsigned header/body len
9455 2003-01-30 Havoc Pennington <hp@pobox.com>
9457 * dbus/dbus-auth.c: rework to use only REJECTED, no
9460 * doc/dbus-sasl-profile.txt: drop MECHANISMS and just
9461 use REJECTED, suggested by Mark McLoughlin
9463 2003-01-30 Havoc Pennington <hp@pobox.com>
9465 * dbus/dbus-server.c (dbus_server_listen): @todo about how we need
9466 a better way to report errors here. e.g. "unix address lacks
9467 path" or something. also "no such file" when the path doesn't
9470 * dbus/dbus-address.c (dbus_address_entries_free): add @todo about
9472 (dbus_parse_address): add @todo about documenting address format,
9473 and allowing , and ; to be escaped
9475 2003-01-30 Anders Carlsson <andersca@codefactory.se>
9478 Add dbus-address.[ch]
9480 * dbus/dbus-address.c: (dbus_address_entry_free),
9481 (dbus_address_entries_free), (create_entry),
9482 (dbus_address_entry_get_method), (dbus_address_entry_get_value),
9483 (dbus_parse_address), (_dbus_address_test):
9484 * dbus/dbus-address.h:
9485 New files for dealing with address parsing.
9487 * dbus/dbus-connection.c:
9488 Document timeout functions.
9490 * dbus/dbus-message.c:
9491 Document dbus_message_new_from_message.
9493 * dbus/dbus-server-debug.c:
9496 * dbus/dbus-server.c: (dbus_server_listen):
9497 Parse address and use correct server implementation.
9499 * dbus/dbus-string.c: (_dbus_string_find_to), (_dbus_string_test):
9500 * dbus/dbus-string.h:
9501 New function with test.
9503 * dbus/dbus-test.c: (dbus_internal_symbol_do_not_use_run_tests):
9507 * dbus/dbus-transport-debug.c:
9510 * dbus/dbus-transport.c: (_dbus_transport_open):
9511 Parse address and use correct transport implementation.
9513 2003-01-30 Havoc Pennington <hp@pobox.com>
9515 * dbus/dbus-message.c: use message->byte_order instead of
9516 DBUS_COMPILER_BYTE_ORDER throughout.
9517 (dbus_message_create_header): pad header to align the
9518 start of the body of the message to 8-byte boundary
9520 * dbus/dbus-marshal.h: make all the demarshalers take const
9521 DBusString arguments.
9523 * dbus/dbus-message.c (_dbus_message_loader_return_buffer):
9524 validate message args here, so we don't have to do slow validation
9525 later, and so we catch bad messages as they are incoming. Also add
9526 better checks on header_len and body_len. Also fill in
9529 * dbus/dbus-string.c (_dbus_string_validate_utf8): new (not
9530 implemented properly)
9531 (_dbus_string_validate_nul): new function to check all-nul
9533 * dbus/dbus-marshal.c (_dbus_marshal_get_field_end_pos): rename
9534 get_arg_end_pos and remove all validation
9535 (_dbus_marshal_validate_arg): actually do validation here.
9537 2003-01-29 Havoc Pennington <hp@pobox.com>
9539 * dbus/dbus-message.c (check_message_handling): fix assertion
9540 failure on set_client_serial
9542 2003-01-28 Havoc Pennington <hp@pobox.com>
9544 * dbus/dbus-server-debug.c: Add doc section comments
9546 * dbus/dbus-transport-debug.c: add doc section comments
9548 2003-01-28 Havoc Pennington <hp@redhat.com>
9550 * dbus/dbus-string.c (_dbus_string_base64_decode): append bytes in
9551 the reverse order from how I had it
9552 (_dbus_string_base64_encode): reverse encoding order. I was
9553 basically byteswapping everything during encoding.
9555 2003-01-28 Anders Carlsson <andersca@codefactory.se>
9557 * dbus/dbus-connection-internal.h:
9558 * dbus/dbus-connection.c: (_dbus_connection_add_timeout),
9559 (_dbus_connection_remove_timeout):
9560 Add functions for adding and removing timeouts.
9562 * dbus/dbus-message.c: (dbus_message_new_from_message):
9563 Add new function that takes a message and creates an exact
9564 copy of it, but with the refcount set to 1.
9565 (check_message_handling):
9568 * dbus/dbus-server-protected.h:
9569 * dbus/dbus-server.c: (_dbus_server_init_base),
9570 (_dbus_server_finalize_base), (_dbus_server_add_timeout),
9571 (dbus_server_set_timeout_functions):
9572 (_dbus_server_remove_timeout):
9573 New functions so that a server can add and remove timeouts.
9575 (dbus_server_listen):
9576 Add commented out call to dbus_server_debug_new.
9578 * dbus/dbus-timeout.c: (_dbus_timeout_new):
9579 Actually set the handler, doh.
9581 * dbus/dbus-transport.c: (_dbus_transport_open):
9582 Add commented out call to dbus_transport_debug_client_new.
9585 Add dbus-transport-debug.[ch] and dbus-server-debug.[ch]
9587 2003-01-28 Havoc Pennington <hp@pobox.com>
9589 * dbus/dbus-message.c (check_message_handling): function to check
9590 on the loaded message, iterates over it etc.
9592 2003-01-28 Havoc Pennington <hp@pobox.com>
9594 * test/Makefile.am (dist-hook): fix make distdir
9596 * dbus/Makefile.am (TESTS_ENVIRONMENT): fix make check
9598 2003-01-27 Havoc Pennington <hp@pobox.com>
9600 * dbus/dbus-mempool.c (time_for_size): replace printf with
9603 * dbus/dbus-message-builder.c (_dbus_message_data_load): allow
9604 empty lines; fix the SAVE_LENGTH stuff to be
9605 START_LENGTH/END_LENGTH so it actually works; couple other
9608 * test/Makefile.am (dist-hook): add dist-hook for .message files
9610 * dbus/dbus-string.c (DBUS_STRING_COPY_PREAMBLE): source of a copy
9611 can be constant or locked.
9612 (_dbus_string_free): allow freeing a const string as
9615 * dbus/dbus-sysdeps.c (_dbus_concat_dir_and_file): utility
9617 * dbus/dbus-test-main.c (main): take an argument which is the
9618 directory containing test data
9620 * dbus/dbus-message.c (_dbus_message_test): pass a test_data_dir
9621 argument to this and load all the messages in test/data/
9622 checking that they can be loaded or not loaded as appropriate.
9624 2003-01-27 Anders Carlsson <andersca@codefactory.se>
9626 * bus/dispatch.c: (bus_dispatch_message_handler):
9627 Dispatch messages sent to services.
9629 * bus/driver.c: (bus_driver_send_service_deleted),
9630 (bus_driver_send_service_created), (bus_driver_send_service_lost),
9631 (bus_driver_send_service_acquired):
9632 Add helper functions for sending service related messages.
9634 (bus_driver_send_welcome_message):
9635 Send HELLO_REPLY instead of WELCOME.
9637 (bus_driver_handle_list_services):
9638 Send LIST_SERVICES_REPLY instead of SERVICES.
9640 (bus_driver_handle_own_service),
9641 (bus_driver_handle_service_exists):
9642 New message handlers.
9644 (bus_driver_handle_message):
9645 Invoke new message handlers.
9647 (bus_driver_remove_connection):
9648 Don't remove any services here since that's done automatically
9649 by bus_service_remove_owner now.
9652 New function signatures.
9654 * bus/services.c: (bus_service_add_owner):
9655 Send ServiceAcquired message if we're the only primary owner.
9657 (bus_service_remove_owner):
9658 Send ServiceAcquired/ServiceLost messages.
9660 (bus_service_set_prohibit_replacement),
9661 (bus_service_get_prohibit_replacement):
9662 Functions for setting prohibit replacement.
9664 (bus_service_has_owner):
9665 New function that checks if a connection is in the owner queue of
9669 Add new function signatures.
9671 * dbus/dbus-list.c: (_dbus_list_test):
9672 Add tests for _dbus_list_remove_last and traversing the list backwards.
9675 Fix a typo in _dbus_list_get_prev_link, if we're at the first element we can't
9676 go any further, so return NULL then.
9678 * dbus/dbus-protocol.h:
9679 Add new messages, service flags and service replies.
9681 2003-01-26 Havoc Pennington <hp@pobox.com>
9683 * dbus/dbus-message-builder.c: implement, completely untested.
9685 * test/data/*: add data to be used in testing.
9686 ".message" files are our simple loadable text format.
9687 ".message-raw" will be binary dumps of messages.
9689 * dbus/dbus-string.c (_dbus_string_starts_with_c_str): new
9691 2003-01-26 Havoc Pennington <hp@pobox.com>
9693 * dbus/dbus-sysdeps.c (_dbus_file_get_contents): new function
9695 * dbus/dbus-errors.c (dbus_result_to_string): add
9698 * dbus/dbus-message-builder.c: new file, will contain code to load
9699 up messages from files. Not implemented yet.
9701 2003-01-26 Havoc Pennington <hp@pobox.com>
9703 * dbus/dbus-message.c (dbus_message_set_sender): support deleting
9704 the sender by setting to NULL
9706 2003-01-26 Havoc Pennington <hp@pobox.com>
9708 The unit tests pass, but otherwise untested. If it breaks, the
9709 tests should have been better. ;-)
9711 * bus/driver.c (bus_driver_handle_hello): return if we disconnect
9714 * dbus/dbus-message.c: redo everything so we maintain
9715 message->header as the only copy of the various fields.
9716 This avoids the possibility of out-of-memory in some cases,
9717 for example dbus_message_lock() can't run out of memory anymore,
9718 and avoids extra copying. Figured I may as well go ahead and do
9719 this since it was busted for dbus_message_lock to not return
9720 failure on OOM, and dbus_message_write_header was totally
9721 unchecked for OOM. Also fixed some random other bugs.
9723 * dbus/dbus-marshal.c (_dbus_marshal_get_field_end_pos): verify
9724 that strings are nul-terminated. Also, end_pos can be equal
9725 to string length just not greater than, I think.
9726 (_dbus_marshal_set_int32): new function
9727 (_dbus_marshal_set_uint32): new function
9728 (_dbus_marshal_set_string): new function
9730 * dbus/dbus-connection.c (_dbus_connection_new_for_transport): fix
9731 a warning, init timeout_list to NULL
9732 (dbus_connection_send_message): don't use uninitialized variable
9735 * dbus/dbus-string.c (_dbus_string_replace_len): new function
9737 2003-01-26 Anders Carlsson <andersca@codefactory.se>
9739 * bus/driver.c: (bus_driver_handle_hello),
9740 (bus_driver_send_welcome_message):
9743 2003-01-26 Anders Carlsson <andersca@codefactory.se>
9745 * dbus/dbus-auth.c: (process_auth), (_dbus_auth_unref):
9746 * dbus/dbus-connection.c: (_dbus_connection_new_for_transport),
9747 (dbus_connection_unref):
9748 * dbus/dbus-marshal.c: (_dbus_marshal_test):
9749 * dbus/dbus-message.c: (dbus_message_unref),
9752 (dbus_message_get_fields):
9753 Remove debugging printout.
9755 (_dbus_message_loader_return_buffer):
9756 Don't store the header string.
9758 (_dbus_message_test):
9761 2003-01-26 Richard Hult <rhult@codefactory.se>
9763 * glib/dbus-gmain.c (dbus_connection_dispatch): Traverse a copy of
9764 the file descriptor list, since it can change under us.
9766 2003-01-25 Anders Carlsson <andersca@codefactory.se>
9768 * glib/dbus-gmain.c: (dbus_connection_prepare),
9769 (dbus_connection_check), (dbus_connection_dispatch), (add_watch),
9770 (remove_watch), (dbus_connection_hookup_with_g_main):
9771 Rewrite the glib handling to use its own GSource instead of a
9772 GIOChannel so we can catch messages put in the queue while waiting
9775 2003-01-25 Anders Carlsson <andersca@codefactory.se>
9778 * bus/connection.c: (connection_disconnect_handler),
9779 (connection_watch_callback), (bus_connection_setup):
9780 * bus/dispatch.c: (send_one_message),
9781 (bus_dispatch_broadcast_message), (bus_dispatch_message_handler),
9782 (bus_dispatch_add_connection), (bus_dispatch_remove_connection):
9784 * bus/driver.c: (bus_driver_send_service_deleted),
9785 (bus_driver_send_service_created), (bus_driver_handle_hello),
9786 (bus_driver_send_welcome_message),
9787 (bus_driver_handle_list_services), (bus_driver_remove_connection),
9788 (bus_driver_handle_message):
9790 Refactor code, put the message dispatching in its own file. Use
9791 _DBUS_HANDLE_OOM. Also send ServiceDeleted messages when a client
9794 2003-01-25 Anders Carlsson <andersca@codefactory.se>
9796 * dbus/dbus-internals.h:
9797 Add _DBUS_HANDLE_OOM macro, it doesn't do anything currently.
9799 * dbus/dbus-message.c: (dbus_message_get_sender):
9800 * dbus/dbus-message.h:
9801 Implement dbus_message_get_sender.
9803 * dbus/dbus-protocol.h:
9804 Add message and service defines.
9806 2003-01-25 Anders Carlsson <andersca@codefactory.se>
9808 * dbus/dbus-connection.c: (dbus_connection_send_message):
9809 * dbus/dbus-message-internal.h:
9810 * dbus/dbus-message.c: (_dbus_message_get_client_serial),
9811 (dbus_message_write_header):
9812 Remove _dbus_messag_unlock and don't set the client serial on a
9813 message if one already exists.
9815 2003-01-24 Havoc Pennington <hp@pobox.com>
9817 * dbus/dbus-list.c (alloc_link): put a thread lock on the global
9820 * bus/driver.c (bus_driver_handle_list_services): fix a leak
9823 2003-01-25 Anders Carlsson <andersca@codefactory.se>
9825 * dbus/dbus-list.c: (alloc_link), (free_link):
9826 Use a memory pool for the links.
9828 2003-01-25 Anders Carlsson <andersca@codefactory.se>
9830 * bus/connection.c: (bus_connection_foreach):
9832 Add new bus_connection_foreach function.
9834 * bus/driver.c: (send_one_message), (bus_driver_broadcast_message):
9835 Add function that broadcasts a message to all clients.
9837 (bus_driver_send_service_created), (bus_driver_handle_hello),
9838 (bus_driver_send_welcome_message),
9839 (bus_driver_handle_list_services), (bus_driver_message_handler):
9840 Implement functions that take care of listing services, and notifying
9841 clients when new services are created.
9843 * bus/services.c: (bus_services_list):
9845 Add new function that returns an array of strings with the currently
9846 registered services.
9849 * glib/dbus-gmain.c:
9850 Update copyright year.
9852 2003-01-25 Anders Carlsson <andersca@codefactory.se>
9854 * dbus/dbus-connection.c: (dbus_connection_send_message):
9855 Unlock the message in case it was sent earlier.
9857 (dbus_connection_send_message_with_reply_and_block):
9858 Remove the reply message from the list.
9860 * dbus/dbus-marshal.c: (_dbus_demarshal_string_array):
9861 Set array_len and new_pos correctly.
9863 (_dbus_marshal_test):
9864 Remove debug output.
9866 * dbus/dbus-message-internal.h:
9867 * dbus/dbus-message.c: (_dbus_message_get_reply_serial):
9868 New function that returns the reply serial.
9870 (_dbus_message_unlock):
9871 New function that unlocks a message and resets its header.
9873 (dbus_message_append_string_array),
9874 (dbus_message_get_fields_valist),
9875 (dbus_message_iter_get_field_type),
9876 (dbus_message_iter_get_string_array),
9877 (dbus_message_get_fields),
9878 (dbus_message_append_fields_valist):
9879 Handle string arrays.
9881 (dbus_message_set_sender):
9882 Make this function public since the bus daemon needs it.
9884 (decode_header_data):
9885 Set the reply serial to -1 initially.
9887 * dbus/dbus-message.h:
9888 Add dbus_message_set_sender.
9890 2003-01-24 Havoc Pennington <hp@pobox.com>
9892 * doc/dbus-specification.sgml: add some stuff
9894 2003-01-22 Havoc Pennington <hp@pobox.com>
9896 * doc/dbus-specification.sgml: Start to document the protocol.
9898 2003-01-22 Havoc Pennington <hp@pobox.com>
9900 * dbus/dbus-connection.c
9901 (dbus_connection_send_message_with_reply_and_block): add some @todo
9903 * bus/driver.c (bus_driver_add_connection): add a FIXME about memleak
9905 2003-01-21 Havoc Pennington <hp@pobox.com>
9907 (patch untested because can't compile)
9909 * bus/driver.c (create_unique_client_name): make this function
9910 never recycle client names. Also, caller should initialize
9913 * dbus/dbus-sysdeps.c (_dbus_get_current_time): new function
9915 2003-01-21 Anders Carlsson <andersca@codefactory.se>
9917 * dbus/dbus-marshal.c: (_dbus_marshal_double),
9918 (_dbus_marshal_int32), (_dbus_marshal_uint32),
9919 (_dbus_marshal_int32_array), (_dbus_marshal_uint32_array),
9920 (_dbus_marshal_double_array), (_dbus_marshal_string_array),
9921 (_dbus_demarshal_int32_array), (_dbus_demarshal_uint32_array),
9922 (_dbus_demarshal_double_array), (_dbus_demarshal_string_array),
9923 (_dbus_marshal_get_field_end_pos), (_dbus_marshal_test):
9924 * dbus/dbus-marshal.h:
9925 * dbus/dbus-protocol.h:
9926 Add support for marshalling and demarshalling integer, double
9929 2003-01-21 Anders Carlsson <andersca@codefactory.se>
9934 * bus/connection.c: (connection_disconnect_handler):
9935 Remove the connection from the bus driver's list.
9937 (connection_watch_callback): Dispatch messages.
9939 (free_connection_data): Free connection name.
9941 (bus_connection_setup): Add connection to the bus driver's list.
9942 (bus_connection_remove_owned_service):
9943 (bus_connection_set_name), (bus_connection_get_name):
9944 Add functions for setting and getting the connection's name.
9947 Add function headers.
9949 * bus/driver.c: (create_unique_client_name),
9950 (bus_driver_handle_hello_message),
9951 (bus_driver_send_welcome_message), (bus_driver_message_handler),
9952 (bus_driver_add_connection), (bus_driver_remove_connection):
9955 * bus/services.c: (bus_service_free):
9957 New file that handles communication and registreation with the bus
9960 2003-01-21 Anders Carlsson <andersca@codefactory.se>
9962 * dbus/dbus-connection.c: (dbus_connection_send_message):
9963 Add a new client_serial parameter.
9965 (dbus_connection_send_message_with_reply):
9966 Remove a @todo since we've implemented the blocking function.
9968 (dbus_connection_send_message_with_reply_and_block):
9969 New function that sends a message and waits for a reply and
9970 then returns the reply.
9972 * dbus/dbus-connection.h:
9975 * dbus/dbus-errors.c: (dbus_result_to_string):
9976 * dbus/dbus-errors.h:
9977 Add new DBUS_RESULT.
9979 * dbus/dbus-message-internal.h:
9980 * dbus/dbus-message.c: (_dbus_message_get_reply_serial),
9981 (_dbus_message_set_sender), (dbus_message_write_header),
9982 (dbus_message_new_reply), (decode_header_data),
9983 (_dbus_message_loader_return_buffer), (_dbus_message_test):
9984 * dbus/dbus-message.h:
9985 Add new functions that set the reply serial and sender.
9986 Also marshal and demarshal them correctly and add test.
9988 * dbus/dbus-protocol.h:
9989 Add new DBUS_MESSAGE_TYPE_SENDER.
9992 * glib/dbus-gmain.c: (watch_callback), (free_callback_data),
9993 (add_watch), (remove_watch), (add_timeout), (remove_timeout),
9994 (dbus_connection_hookup_with_g_main):
9995 * glib/test-dbus-glib.c: (main):
9996 Rewrite to use GIOChannel and remove the GSource crack.
9998 * test/echo-client.c: (main):
9999 * test/watch.c: (check_messages):
10000 Update for changed APIs
10002 2003-01-19 Anders Carlsson <andersca@codefactory.se>
10004 * dbus/Makefile.am: Add dbus-timeout.[cħ]
10006 * dbus/dbus-connection.c: (_dbus_connection_new_for_transport):
10007 Create a DBusTimeoutList.
10008 (dbus_connection_set_timeout_functions): Add new function to
10009 set timeout callbacks
10011 * dbus/dbus-connection.h: Add public DBusTimeout API.
10013 * dbus/dbus-message.c: (dbus_message_get_service):
10014 * dbus/dbus-message.h: New function.
10016 * dbus/dbus-server.c: Fix small doc typo.
10018 * dbus/dbus-timeout.[ch]: New files for mainloop timeouts.
10020 2003-01-19 Anders Carlsson <andersca@codefactory.se>
10022 * dbus/dbus-string.c (_dbus_string_move_len): Don't delete all
10023 of the string, just as long as specified.
10025 2003-01-19 Havoc Pennington <hp@pobox.com>
10027 * dbus/dbus-connection.c (dbus_connection_get_is_authenticated):
10030 * dbus/dbus-server.c (dbus_server_set_max_connections)
10031 (dbus_server_get_max_connections, dbus_server_get_n_connections):
10032 keep track of current number of connections, and add API for
10033 setting a max (but haven't implemented enforcing the max yet)
10035 2003-01-18 Havoc Pennington <hp@pobox.com>
10037 * dbus/dbus-transport-unix.c (unix_do_iteration): only do the
10038 reading/writing if read_watch != NULL or write_watch != NULL.
10040 * dbus/dbus-message.c (_dbus_message_loader_return_buffer): fix
10041 the message loader code to actually load message->header and
10042 message->body into the newly-created message.
10044 * dbus/dbus-transport-unix.c (check_write_watch): fix a mem leak
10047 * dbus/dbus-connection.c (dbus_connection_set_max_message_size)
10048 (dbus_connection_get_max_message_size)
10049 (dbus_connection_set_max_live_messages_size)
10050 (dbus_connection_get_max_live_messages_size): implement some
10051 resource limitation functions
10053 * dbus/dbus-resources.c: new file implementing some of the
10054 resource limits stuff
10056 * dbus/dbus-message.c (dbus_message_iter_get_byte_array): add
10057 missing docs, add @todo to handle OOM etc.
10059 * dbus/dbus-marshal.c (_dbus_demarshal_byte_array): add missing
10062 2003-01-18 Havoc Pennington <hp@pobox.com>
10064 * dbus/dbus-connection.c (dbus_connection_unref): disconnect the
10065 connection if it hasn't been already.
10067 * dbus/dbus-connection.h: kill off the idea of an ErrorFunction,
10068 replace with DisconnectFunction.
10070 2003-01-18 Havoc Pennington <hp@pobox.com>
10072 Building --disable-verbose-mode --disable-asserts --disable-tests
10073 cuts the library from 112K to 45K or so
10075 * configure.in: check for varargs macro support,
10076 add --enable-verbose-mode, --enable-asserts.
10078 * dbus/dbus-internals.h (_dbus_assert): support
10079 DBUS_DISABLE_ASSERT
10080 (_dbus_verbose): support DBUS_ENABLE_VERBOSE_MODE
10082 2003-01-18 Havoc Pennington <hp@pobox.com>
10084 * dbus/dbus-test.c: include config.h so that tests actually run
10086 * dbus/dbus-string.c: add assertions that stuff is 8-byte aligned,
10087 so the failure mode when that assumption fails will be plenty
10090 2003-01-18 Havoc Pennington <hp@pobox.com>
10092 * configure.in: default --enable-tests to $USE_MAINTAINER_MODE
10094 * dbus/Makefile.am: fix it up so dubs-test-main.c is included in
10097 * test/Makefile.am: don't use special variable "TESTS" for echo-*
10098 since we don't want to use those in make check
10100 2003-01-15 Havoc Pennington <hp@redhat.com>
10106 2003-01-15 Havoc Pennington <hp@redhat.com>
10108 * test/Makefile.am: fix so that test source code ends up in the
10109 distribution on make distcheck
10111 2003-01-15 Havoc Pennington <hp@redhat.com>
10117 2003-01-15 Havoc Pennington <hp@redhat.com>
10119 * dbus/dbus-test.c (dbus_internal_symbol_do_not_use_run_tests):
10120 fix build when --disable-tests
10122 * Makefile.am (EXTRA_DIST): put HACKING in here
10124 * HACKING: document procedure for making a tarball release.
10126 2003-01-14 Anders Carlsson <andersca@codefactory.se>
10128 * bus/connection.c: (connection_error_handler),
10129 (bus_connection_setup):
10130 * bus/main.c: (main):
10131 Make sure that the DBusConnectionData struct is NULLed
10132 out to prevent a segfault.
10134 * dbus/dbus-errors.c: (dbus_result_to_string):
10135 * dbus/dbus-errors.h:
10136 * dbus/dbus-message.c: (dbus_message_get_fields),
10137 (dbus_message_get_fields_valist), (_dbus_message_test):
10138 * dbus/dbus-message.h:
10139 Make dbus_message_get_fields return a result code so we can
10140 track invalid fields as well as oom.
10142 2003-01-11 Havoc Pennington <hp@pobox.com>
10144 * configure.in: change --enable-test/--enable-ansi action-if-given
10145 to enable_foo=$enableval instead of enable_foo=yes
10147 2003-01-08 Havoc Pennington <hp@pobox.com>
10149 * dbus/dbus-string.c (_dbus_string_align_length): new function
10151 * dbus/dbus-test-main.c: move main() for test app here
10153 (dbus_internal_symbol_do_not_use_run_tests): we have to export a
10154 symbol to run tests, because dbus-test isn't in the main
10157 Code review nitpicks.
10159 * dbus/dbus-message.c (dbus_message_write_header): add newlines
10160 for people with narrow emacs ;-). Assert client_serial was filled
10161 in. Assert message->name != NULL.
10162 (dbus_message_append_fields): have "first_field_type" arg separate
10163 from va list, needed for C++ binding that also uses varargs IIRC
10164 and helps with type safety
10165 (dbus_message_new): add @todo about using DBusString to store
10166 service/name internally
10167 (dbus_message_new): don't leak ->service and ->name on OOM later
10169 (dbus_message_unref): free the service name
10170 (dbus_message_get_fields): same change to varargs
10171 i.e. first_field_type
10172 (_dbus_message_loader_return_buffer): assert that the message data
10173 is aligned (if not it's a bug in our code). Put in verbose griping
10174 about why we set corrupted = TRUE.
10175 (decode_header_data): add FIXME that char* is evil. Was going to
10176 add FIXME about evil locale-specific string.h strncmp, but just
10177 switched to wacky string-as-uint32 optimization. Move check for
10178 "no room for field name" above get_const_data_len() to avoid
10179 assertion failure in get_const_data_len if we have trailing 2
10180 bytes or the like. Check for service and name fields being
10181 provided twice. Don't leak service/name on error. Require field
10182 names to be aligned to 4 bytes.
10184 * dbus/dbus-marshal.c: move byte swap stuff to header
10185 (_dbus_pack_int32): uscore-prefix
10186 (_dbus_unpack_int32): uscore-prefix
10187 (_dbus_unpack_uint32): export
10188 (_dbus_demarshal_string): add @todo complaining about use of
10190 (_dbus_marshal_get_field_end_pos): add @todo about bad error
10191 handling allowing corrupt data to go unchecked
10193 2003-01-08 Havoc Pennington <hp@redhat.com>
10195 * dbus/dbus-transport-unix.c (unix_do_iteration): add read/write
10196 to the select() as needed for authentication. (should be using
10197 _dbus_poll() not select, but for another day)
10199 * dbus/dbus.h: include dbus/dbus-protocol.h
10201 2003-01-08 Anders Carlsson <andersca@codefactory.se>
10203 * dbus/Makefile.am (dbusinclude_HEADERS): Install
10206 2003-01-08 Anders Carlsson <andersca@codefactory.se>
10208 * dbus/dbus-internals.c: (_dbus_type_to_string):
10209 New function that returns a string describing a type.
10211 * dbus/dbus-marshal.c: (_dbus_demarshal_byte_array):
10212 * dbus/dbus-marshal.h:
10213 * dbus/dbus-message.c: (dbus_message_get_fields_valist),
10214 (dbus_message_iter_get_field_type), (dbus_message_iter_get_double),
10215 (dbus_message_iter_get_byte_array):
10216 * dbus/dbus-message.h:
10217 Add new convenience functions for appending and getting message fields.
10218 Also add demarshalling routines for byte arrays.
10220 2003-01-07 Anders Carlsson <andersca@codefactory.se>
10222 * dbus/dbus-connection-internal.h:
10223 * dbus/dbus-connection.c: (_dbus_connection_new_for_transport),
10224 (_dbus_connection_get_next_client_serial),
10225 (dbus_connection_send_message):
10226 * dbus/dbus-internals.h:
10227 * dbus/dbus-marshal.c: (unpack_uint32), (dbus_unpack_int32),
10228 (dbus_pack_int32), (_dbus_marshal_double), (_dbus_marshal_int32),
10229 (_dbus_marshal_uint32), (_dbus_demarshal_double),
10230 (_dbus_demarshal_int32), (_dbus_demarshal_uint32),
10231 (_dbus_demarshal_string), (_dbus_marshal_get_field_end_pos),
10232 (_dbus_verbose_bytes), (_dbus_marshal_test):
10233 * dbus/dbus-marshal.h:
10234 * dbus/dbus-message-internal.h:
10235 * dbus/dbus-message.c: (_dbus_message_set_client_serial),
10236 (dbus_message_write_header), (_dbus_message_lock),
10237 (dbus_message_new), (dbus_message_ref), (dbus_message_unref),
10238 (dbus_message_get_name), (dbus_message_append_int32),
10239 (dbus_message_append_uint32), (dbus_message_append_double),
10240 (dbus_message_append_string), (dbus_message_append_byte_array),
10241 (dbus_message_get_fields_iter), (dbus_message_iter_ref),
10242 (dbus_message_iter_unref), (dbus_message_iter_has_next),
10243 (dbus_message_iter_next), (dbus_message_iter_get_field_type),
10244 (dbus_message_iter_get_string), (dbus_message_iter_get_int32),
10245 (dbus_message_iter_get_uint32), (dbus_message_iter_get_double),
10246 (decode_header_data), (_dbus_message_loader_return_buffer),
10247 (message_iter_test), (_dbus_message_test):
10248 * dbus/dbus-message.h:
10249 * dbus/dbus-protocol.h:
10250 * dbus/dbus-test.c: (main):
10251 * dbus/dbus-test.h:
10252 * glib/test-dbus-glib.c: (message_handler), (main):
10253 * test/echo-client.c: (main):
10254 * test/watch.c: (check_messages):
10255 Make messages sendable and receivable for real.
10257 2003-01-07 Anders Carlsson <andersca@codefactory.se>
10259 * dbus/dbus-marshal.c: (_dbus_marshal_double),
10260 (_dbus_marshal_string), (_dbus_marshal_byte_array):
10261 * dbus/dbus-message.c: (dbus_message_append_int32),
10262 (dbus_message_append_uint32), (dbus_message_append_double),
10263 (dbus_message_append_string), (dbus_message_append_byte_array):
10264 Handle OOM restoration.
10266 2003-01-07 Anders Carlsson <andersca@codefactory.se>
10268 * dbus/dbus-marshal.c: (_dbus_marshal_string),
10269 (_dbus_demarshal_string), (_dbus_marshal_test):
10270 * dbus/dbus-marshal.h:
10271 * dbus/dbus-message.c: (dbus_message_get_name),
10272 Document these functions.
10274 (dbus_message_append_int32), (dbus_message_append_uint32),
10275 (dbus_message_append_double), (dbus_message_append_string),
10276 (dbus_message_append_byte_array):
10277 * dbus/dbus-message.h:
10278 Add functions for adding message fields of different types.
10280 * dbus/dbus-protocol.h:
10281 Add the different types.
10283 2003-01-05 Havoc Pennington <hp@pobox.com>
10285 * bus/connection.c: implement routines for handling connections,
10286 first thing is keeping a list of owned services on each connection
10287 and setting up watches etc.
10289 * bus/services.c: implement a mapping from service names to lists
10292 * dbus/dbus-hash.c: add DBUS_HASH_POINTER
10294 * dbus/dbus-threads.c (dbus_static_mutex_lock): add functions
10295 to use static mutexes for global data
10297 * dbus/dbus-connection.c (dbus_connection_set_data): add new
10298 collection of functions to set/get application-specific data
10299 on the DBusConnection.
10301 2003-01-04 Havoc Pennington <hp@pobox.com>
10303 * dbus/dbus-sysdeps.c (_dbus_sleep_milliseconds): new function
10304 (_dbus_poll): new function
10306 * dbus/dbus-internals.h (_DBUS_STRUCT_OFFSET): new macro
10309 * bus/loop.c: initial code for the daemon main loop
10311 2003-01-04 Havoc Pennington <hp@pobox.com>
10313 * test/watch.c (error_handler): make it safe if the error handler
10314 is called multiple times (if we s/error handler/disconnect
10315 handler/ we should just guarantee it's called only once)
10317 * dbus/dbus-transport.c (_dbus_transport_disconnect): call the
10318 error handler on disconnect (it's quite possible we should
10319 just change the error handler to a "disconnect handler," I'm
10320 not sure we have any other meaningful errors)
10322 * configure.in: check for getpwnam_r
10324 * dbus/dbus-transport.c, dbus/dbus-transport-unix.c,
10325 dbus/dbus-auth.c: add credentials support, add EXTERNAL auth
10326 mechanism as in SASL spec, using socket credentials
10328 * dbus/dbus-sysdeps.c (_dbus_read_credentials_unix_socket): new function
10329 (_dbus_send_credentials_unix_socket): new function
10331 * dbus/dbus-sysdeps.c (_dbus_accept_unix_socket): rename just
10333 (_dbus_write): only check errno if <0 returned
10334 (_dbus_write_two): ditto
10336 2003-01-02 Anders Carlsson <andersca@codefactory.se>
10338 * dbus/dbus-marshal.c: (_dbus_marshal_utf8_string),
10339 (_dbus_marshal_byte_array), (_dbus_demarshal_utf8_string),
10340 (_dbus_marshal_test):
10341 * dbus/dbus-marshal.h:
10342 Add _dbus_marshal_byte_array and rename _dbus_marshal_string
10343 to _dbus_marshal_utf8_string. Also fix some tests.
10345 2002-12-28 Harri Porten <porten@kde.org>
10347 * configure.in: added check for C++ compiler and a very cheesy
10348 check for the Qt integration
10350 * Makefile.am (SUBDIRS): compile qt subdir if support is enabled
10352 * qt/Makefile.am: added
10354 * qt/.cvsignore: added
10356 * qt/dbus-qthread.cc, qt/dbus-qthread.cpp: renamed former to
10357 latter, added #ifdef QT_THREAD_SUPPORT guard.
10359 * dbus/Makefile.am: added missing headers for make dist
10361 2002-12-28 Kristian Rietveld <kris@gtk.org>
10363 * dbus/Makefile.am: fixup export-symbols-regex.
10365 2002-12-27 Anders Carlsson <andersca@codefactory.se>
10367 * acinclude.m4: Add this file and put the
10368 PKG_CHECK_MODULE macro in it.
10370 2002-12-27 Anders Carlsson <andersca@codefactory.se>
10372 * dbus/dbus-marshal.c: (_dbus_marshal_string),
10373 (_dbus_demarshal_double), (_dbus_demarshal_int32),
10374 (_dbus_demarshal_uint32), (_dbus_demarshal_string),
10375 (_dbus_marshal_test):
10376 Make the demarshalling routines align the pos argument.
10377 Add string marshalling tests and fix the obvious bugs
10380 2002-12-26 Havoc Pennington <hp@pobox.com>
10382 * dbus/dbus-auth.c: fixes fixes fixes
10384 * dbus/dbus-transport-unix.c: wire up support for
10385 encoding/decoding data on the wire
10387 * dbus/dbus-auth.c (_dbus_auth_encode_data)
10388 (_dbus_auth_decode_data): append to target string
10389 instead of nuking it.
10391 2002-12-26 Havoc Pennington <hp@pobox.com>
10393 * dbus/dbus-marshal.h (DBUS_COMPILER_BYTE_ORDER): #ifdef
10394 WORDS_BIGENDIAN then compiler byte order is DBUS_BIG_ENDIAN,
10397 * dbus/dbus-marshal.c: Add macros to do int swapping in-place and
10398 avoid swap_bytes() overhead (ignoring possible assembly stuff for
10399 now). Main point is because I wanted unpack_uint32 to implement
10400 _dbus_verbose_bytes
10401 (_dbus_verbose_bytes): new function
10403 * dbus/dbus-string.c (_dbus_string_validate_ascii): new function
10405 * dbus/dbus-message.c (_dbus_message_loader_get_is_corrupted): add
10406 mechanism to handle a corrupt message stream
10407 (_dbus_message_loader_new): fix preallocation to only prealloc,
10410 * dbus/dbus-string.c (_dbus_string_skip_blank): fix this function
10411 (_dbus_string_test): enhance tests for copy/move and fix the
10414 * dbus/dbus-transport-unix.c: Hold references in more places to
10415 avoid reentrancy problems
10417 * dbus/dbus-transport.c: ditto
10419 * dbus/dbus-connection.c (dbus_connection_dispatch_message): don't
10420 leak reference count in no-message case
10422 * test/watch.c (do_mainloop): handle adding/removing watches
10423 during iteration over the watches. Also, ref the connection/server
10424 stored on a watch, so we don't try to mangle a destroyed one.
10426 * dbus/dbus-transport-unix.c (do_authentication): perform
10429 * dbus/dbus-auth.c (get_state): add a state
10430 AUTHENTICATED_WITH_UNUSED_BYTES and return it if required
10431 (_dbus_auth_get_unused_bytes): append the unused bytes
10432 to the passed in string, rather than prepend
10434 * dbus/dbus-transport.c (_dbus_transport_init_base): create
10435 the auth conversation DBusAuth
10437 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_fd)
10438 (_dbus_transport_new_for_domain_socket): when creating a
10439 transport, pass in whether it's a client-side or server-side
10440 transport so we know which DBusAuth to create
10442 2002-12-03 Havoc Pennington <hp@pobox.com>
10444 * dbus/dbus-transport-unix.c (unix_finalize): finalize base
10445 _after_ finalizing the derived members
10446 (unix_connection_set): unref watch if we fail to add it
10448 * dbus/dbus-connection.c (dbus_connection_unref): delete the
10449 transport first, so that the connection owned by the
10450 transport will be valid as the transport finalizes.
10452 * dbus/dbus-transport-unix.c (unix_finalize): free the write_watch
10453 if necessary, and remove watches from the connection.
10455 * dbus/dbus-watch.c (_dbus_watch_list_free): improve a comment
10457 2002-12-26 Anders Carlsson <andersca@codefactory.se>
10459 * dbus/dbus-marshal.c: (_dbus_marshal_string),
10460 (_dbus_demarshal_double), (_dbus_demarshal_int32),
10461 (_dbus_demarshal_uint32), (_dbus_demarshal_string),
10462 (_dbus_marshal_test):
10463 * dbus/dbus-marshal.h:
10464 Add string marshal functions and have the demarshal functions
10465 return the new position.
10467 2002-12-25 Havoc Pennington <hp@pobox.com>
10469 * doc/dbus-sasl-profile.txt: docs on the authentication protocol,
10470 it is a simple protocol that just maps directly to SASL.
10472 * dbus/dbus-auth.h, dbus/dbus-auth.c: authentication protocol
10473 initial implementation, not actually used yet.
10475 * dbus/dbus-string.c (_dbus_string_find): new function
10476 (_dbus_string_equal): new function
10477 (_dbus_string_base64_encode): new function
10478 (_dbus_string_base64_decode): new function
10480 2002-12-25 Anders Carlsson <andersca@codefactory.se>
10482 * dbus/Makefile.am:
10483 * dbus/dbus-marshal.c: (swap_bytes), (_dbus_marshal_double),
10484 (_dbus_marshal_int32), (_dbus_marshal_uint32),
10485 (_dbus_demarshal_double), (_dbus_demarshal_int32),
10486 (_dbus_demarshal_uint32), (_dbus_marshal_test):
10487 * dbus/dbus-marshal.h:
10488 * dbus/dbus-protocol.h:
10489 * dbus/dbus-test.c: (main):
10490 * dbus/dbus-test.h:
10491 Add un-optimized marshalling/demarshalling routines.
10493 2002-12-25 Harri Porten <porten@kde.org>
10495 * qt/dbus-qt.h: adjusted ctor and getter to KDE/Qt conventions
10497 2002-12-24 Zack Rusin <zack@kde.org>
10499 * qt/dbus-qthread.cc: adding - integrates QMutex into Dbus
10500 * qt/dbus-qt.h: skeleton with two sample implemenatation of the
10503 2002-12-24 Havoc Pennington <hp@pobox.com>
10505 * glib/dbus-gthread.c: fix include
10507 * glib/dbus-glib.h: rename DBusMessageHandler for now.
10508 I think glib API needs to change, though, as you don't
10509 want to use DBusMessageFunction, you want to use the
10510 DBusMessageHandler object. Probably
10511 dbus_connection_open_with_g_main_loop()
10512 and dbus_connection_setup_g_main_loop() or something like that
10513 (but think of better names...) that just create a connection
10514 that has watch/timeout functions etc. already set up.
10516 * dbus/dbus-connection.c
10517 (dbus_connection_send_message_with_reply): new function just to
10518 show how the message handler helps us deal with replies.
10520 * dbus/dbus-list.c (_dbus_list_remove_last): new function
10522 * dbus/dbus-string.c (_dbus_string_test): free a string that
10525 * dbus/dbus-hash.c: use memory pools for the hash entries
10526 (rebuild_table): be more paranoid about overflow, and
10527 shrink table when we can
10528 (_dbus_hash_test): reduce number of sprintfs and write
10529 valid C89. Add tests for case where we grow and then
10530 shrink the hash table.
10532 * dbus/dbus-mempool.h, dbus/dbus-mempool.c: memory pools
10534 * dbus/dbus-connection.c (dbus_connection_register_handler)
10535 (dbus_connection_unregister_handler): new functions
10537 * dbus/dbus-message.c (dbus_message_get_name): new
10539 * dbus/dbus-list.c: fix docs typo
10541 * dbus/dbus-message-handler.h, dbus/dbus-message-handler.c:
10542 an object representing a handler for messages.
10544 2002-12-16 Anders Carlsson <andersca@codefactory.se>
10546 * glib/dbus-glib.h:
10547 * glib/dbus-gthread.c: (dbus_gthread_init):
10548 Don't use the gdbus prefix for public functions.
10550 2002-12-16 Anders Carlsson <andersca@codefactory.se>
10554 Add GLib checks and fixup .pc files
10556 * glib/Makefile.am:
10557 * glib/dbus-glib.h:
10558 * glib/dbus-gmain.c: (gdbus_connection_prepare),
10559 (gdbus_connection_check), (gdbus_connection_dispatch),
10560 (gdbus_add_connection_watch), (gdbus_remove_connection_watch),
10561 (dbus_connection_gsource_new):
10562 * glib/dbus-gthread.c: (dbus_gmutex_new), (dbus_gmutex_free),
10563 (dbus_gmutex_lock), (dbus_gmutex_unlock), (dbus_gthread_init):
10564 * glib/test-dbus-glib.c: (message_handler), (main):
10567 2002-12-15 Harri Porten <porten@kde.org>
10569 * autogen.sh: check for libtoolize before attempting to use it
10571 * dbus/dbus-transport-unix.c: include <sys/time.h> for timeval
10574 * .cvsignore: ignore more stamp files
10576 * dbus/dbus-watch.c (_dbus_watch_list_new): fixed doc error
10578 * test/Makefile.am: added -I$(top_srcdir) to be able to compile
10579 without make install.
10581 2002-12-15 Havoc Pennington <hp@pobox.com>
10583 * dbus/dbus-threads.c: add thread stubs that a higher library
10584 layer can fill in. e.g. the GLib wrapper might fill them in with
10585 GThread stuff. We still need to use this thread API to
10586 thread-safe-ize the library.
10588 2002-12-12 Havoc Pennington <hp@pobox.com>
10590 * dbus/dbus-transport-unix.c, dbus/dbus-server-unix.c: use the
10591 below new interfaces and include fewer system headers.
10593 * dbus/dbus-sysdeps.c (_dbus_read): new function
10594 (_dbus_write): new function
10595 (_dbus_write_two): new function
10596 (_dbus_connect_unix_socket): new function
10597 (_dbus_listen_unix_socket): new function
10599 * dbus/dbus-message-internal.h: change interfaces to use
10602 2002-12-11 Havoc Pennington <hp@pobox.com>
10604 * dbus/dbus-types.h: add dbus_unichar
10606 * dbus/dbus-internals.c (_dbus_verbose): use _dbus_getenv
10608 * dbus/dbus-connection.c (dbus_connection_send_message): return
10611 * dbus/dbus-transport.c: include dbus-watch.h
10613 * dbus/dbus-connection.c: include dbus-message-internal.h
10615 * HACKING: add file with coding guidelines stuff.
10617 * dbus/dbus-string.h, dbus/dbus-string.c: Encapsulate all string
10618 handling here, for security purposes (as in vsftpd). Not actually
10619 using this class yet.
10621 * dbus/dbus-sysdeps.h, dbus/dbus-sysdeps.c: Encapsulate all
10622 system/libc usage here, as in vsftpd, for ease of auditing (and
10623 should also simplify portability). Haven't actually moved all the
10624 system/libc usage into here yet.
10626 2002-11-25 Havoc Pennington <hp@pobox.com>
10628 * dbus/dbus-internals.c (_dbus_verbose): fix to not
10629 always print the first verbose message.
10631 2002-11-24 Havoc Pennington <hp@pobox.com>
10633 * test/echo-client.c, test/echo-server.c: cheesy test
10636 * configure.in (AC_CHECK_FUNCS): check for writev
10638 * dbus/dbus-message.c (_dbus_message_get_network_data): new
10641 * dbus/dbus-list.c (_dbus_list_foreach): new function
10643 * dbus/dbus-internals.c (_dbus_verbose): new function
10645 * dbus/dbus-server.c, dbus/dbus-server.h: public object
10646 representing a server that listens for connections.
10648 * dbus/.cvsignore: create
10650 * dbus/dbus-errors.h, dbus/dbus-errors.c:
10651 public API for reporting errors
10653 * dbus/dbus-connection.h, dbus/dbus-connection.c:
10654 public object representing a connection that
10655 sends/receives messages. (Same object used for
10656 both client and server.)
10658 * dbus/dbus-transport.h, dbus/dbus-transport.c:
10659 Basic abstraction for different kinds of stream
10660 that we might read/write messages from.
10662 2002-11-23 Havoc Pennington <hp@pobox.com>
10664 * dbus/dbus-internals.h (_DBUS_INT_MAX): add _DBUS_INT_MIN
10667 * dbus/dbus-test.c (main): add list test, and include
10668 dbus-test.h as intended
10670 * dbus/dbus-hash.c (_dbus_hash_table_remove_string)
10671 (_dbus_hash_table_remove_int): return value indicates
10672 whether the entry existed to remove
10674 * dbus/dbus-list.c: add linked list utility class,
10675 with docs and tests
10677 * dbus/dbus-hash.c: add TODO item about shrinking the hash bucket
10680 2002-11-23 Havoc Pennington <hp@pobox.com>
10682 * Doxyfile.in (INCLUDE_FILE_PATTERNS): expand DBUS_BEGIN_DECLS/
10683 DBUS_END_DECLS to nothing, that should fix this once and for all
10685 * Doxyfile.in (JAVADOC_AUTOBRIEF): set to YES
10687 * dbus/dbus-message.c, dbus/dbus-hash.c:
10688 add some missing @brief
10690 2002-11-23 Havoc Pennington <hp@pobox.com>
10692 * dbus/dbus-message.h: put semicolons after DEBUG_BEGIN_DECLS
10693 to avoid confusing Doxygen
10695 * dbus/dbus-hash.c: @} not }@
10697 * dbus/dbus-message.c (struct DBusMessage): split out
10700 2002-11-23 Havoc Pennington <hp@pobox.com>
10702 * configure.in: pile on more warning flags if using gcc
10704 * Doxyfile.in (EXTRACT_STATIC): set to NO, so we don't have
10705 to document static functions
10707 * configure.in: add summary to end of configure so it
10708 looks nice and attractive
10710 * dbus/dbus-hash.c: finish implementation and write unit
10713 * configure.in: add --enable-tests to enable unit tests
10715 * dbus/dbus-test.c: test program to run unit tests
10716 for all files in dbus/*, initially runs a test for
10719 * dbus/dbus-internals.h: file to hold some internal utility stuff
10721 2002-11-22 Havoc Pennington <hp@redhat.com>
10723 * dbus/dbus-hash.c: copy in Tcl hash table, not yet
10724 "ported" away from Tcl
10726 * dbus/dbus-types.h: header for types such as dbus_bool_t
10728 2002-11-22 Havoc Pennington <hp@redhat.com>
10730 * dbus/dbus.h: fixups for doc warnings
10732 * Doxyfile.in (FILE_PATTERNS): we need to scan .h to pick up
10734 (QUIET): make it quiet so we can see warnings
10736 * dbus/dbus-memory.c: teach D-BUS to allocate and free memory
10738 2002-11-22 Havoc Pennington <hp@redhat.com>
10740 * Makefile.am: include "Doxyfile" target in all-local
10742 * configure.in: generate the Doxyfile
10744 * Doxyfile.in: move Doxyfile here, so we can use
10745 configure to generate a Doxyfile with the right
10746 version number etc.
10748 2002-11-22 Havoc Pennington <hp@redhat.com>
10750 * dbus/dbus-message.c: move inline docs into .c file
10752 * Doxyfile (OUTPUT_DIRECTORY): move output to doc/api
10753 so all docs are under doc/
10754 (MAN_EXTENSION): generate man pages. Use extension
10755 ".3dbus" which matches ".3qt" on my system,
10756 I guess this is OK, I don't know really.
10757 (FILE_PATTERNS): look for .c files not .h, makes sense
10758 for plain C I think
10760 2002-11-22 Havoc Pennington <hp@pobox.com>
10762 * Makefile.am (SUBDIRS): rename subdir "server" to "bus"
10763 because any app can be a server, and any app can be a client,
10764 the bus is a special kind of server.
10766 Thu Nov 21 23:35:31 2002 Zack Rusin <zack@kde.org>
10768 * Doxyfile : adding. Still needs Makefile rules to be generated
10769 automatically (just run "doxygen" in the toplevel dir for now to
10772 * dbus/dbus-message.h : Adding sample docs (javadoc since
10773 resembles gtk-doc a little more)
10775 * dbus/dbus.h : Adding sample docs
10777 2002-11-21 Havoc Pennington <hp@redhat.com>
10779 * dbus/Makefile.am (INCLUDES): define DBUS_COMPILATION
10780 so we can allow ourselves to include files directly,
10781 instead of having to use dbus.h
10783 * dbus/dbus.h: fill in
10785 * dbus/dbus-message.h: sketch out a sample header file.
10786 Include griping if you include it directly instead of
10789 * dbus/dbus-macros.h: new file with macros for extern "C",
10790 TRUE/FALSE, NULL, etc.
10792 * doc/file-boilerplate.c: put include guards in here
10794 2002-11-21 Havoc Pennington <hp@redhat.com>
10796 * doc/file-boilerplate.c: include both AFL and GPL boilerplate.
10798 * COPYING: include the GPL as well, and license code
10799 under both AFL and GPL.
10801 2002-11-21 Havoc Pennington <hp@redhat.com>
10803 * acconfig.h: get rid of this
10805 * autogen.sh (run_configure): add --no-configure option
10807 * configure.in: remove AC_ARG_PROGRAM to make
10808 autoconf complain less. add AC_PREREQ.
10809 add AC_DEFINE third arg.
10811 2002-11-21 Anders Carlsson <andersca@codefactory.se>
10814 Fix references so we can distcheck.
10816 2002-11-21 Havoc Pennington <hp@redhat.com>
10818 * Initial module creation