1 2006-07-25 Jim Meyering <jim@meyering.net>
3 * src/ls.c [enum filetype] (command_line): Remove member. Not needed.
4 Replace all occurrences of "type == command_line" with the
5 equivalent, "command_line_arg".
7 * src/ls.c: Apply the stat-failed parts of Red Hat's
8 coreutils-selinux.patch. From Ulrich Drepper.
9 This makes it so files not mentioned on the command line (e.g.,
10 names read from a directory that *is* mentioned on the command
11 line) for which stat fails are still listed. With --color,
12 such files are colored just like ORPHANs (aka dangling symlinks).
14 * src/df.c (n_valid_args): Declare global to be static.
16 2006-07-24 Jim Meyering <jim@meyering.net>
18 * tests/ls/stat-dtype: Skip this test on reiserfs, since that file
19 system lacks d_type support.
21 2006-07-22 Paul Eggert <eggert@cs.ucla.edu>
23 * man/chmod.x: Update to reflect recent changes to coreutils.texi.
25 2006-07-21 Jim Meyering <jim@meyering.net>
27 * src/su.c (usage): Correct typo in --help output: s/commmand/command/
28 Reported by Tim Waugh.
29 Also remove the comment duplicating much of --help output.
31 * src/ls.c (FILE_TYPE_INDICATOR_OPTION): Reposition this new
32 name so the list remains alphabetized.
34 Fix another bug: ls --indicator-style=file-type would call
35 stat for a symlink, even though it wasn't always needed.
36 In some cases, that unnecessary stat would cause ls to fail.
37 * src/ls.c (gobble_file): Don't treat symlinks specially (in
38 requiring a stat syscall). Remove the offending exclusion.
40 * NEWS: Mention the fix.
42 * tests/ls/stat-dtype: New file/test, for the above fix.
43 Also exercises the new df feature, below.
45 * src/df.c (main): Fail and don't print the headers if no
46 file system is processed. This makes it easy to test whether
47 a specified directory is on a file system of a given type or types.
48 Otherwise, applications would have had to parse df's output.
49 E.g., is "." either ext3 or reiserfs: df -t ext3 -t reiserfs .
51 Fix a bug: ls --file-type worked like --indicator-style=slash,
52 rather than like --indicator-style=file-type.
53 * src/ls.c (FILE_TYPE_INDICATOR_OPTION): New enum member.
54 (long_options): Map "file-type" to FILE_TYPE_INDICATOR_OPTION,
56 (decode_switches): Handle new case: FILE_TYPE_INDICATOR_OPTION.
57 * NEWS: Mention the fix.
58 * tests/ls-2/tests (file-type): New test, for the above fix.
60 2006-07-19 Jim Meyering <jim@meyering.net>
62 * src/ls.c (print_dir): Give a better diagnostic for failed opendir.
64 * Makefile.am (EXTRA_DIST): Add build-aux/vc-list-files.
66 2006-07-16 Paul Eggert <eggert@cs.ucla.edu>
68 * NEWS: chmod, install, and mkdir now leave setgid and setuid bits
69 of directories alone unless you specify them explicitly.
70 install and mkdir now implement X correctly.
71 install now creates parent directories with mode 755, without
72 changing their owner or group.
73 * src/chmod.c (process_file): Adjust to mode_adjust API change.
74 * src/install.c: Include mkancesdirs.h.
75 (announce_mkdir, make_ancestor): New functions.
76 (DEFAULT_MODE): New macro, specifying initial value of 'mode'.
78 (dir_mode, dir_mode_bits): New vars.
79 (main): Set dir modes separately from nondir, so that the X
80 op of -m works correctly.
81 (main): Remove cwd_errno cruft, since make_dir_parents no longer
82 affects cwd. Adjust to new make_dir_parents API.
83 (install_file_in_file_parents): 2nd arg is now char *, not char
84 const *. Use mkancesdirs instead of rolling our own code.
85 (change_attributes): Don't worry about AFS, since that kludge
86 should not be needed any more.
87 * src/mkdir.c (struct mkdir_options): New struct.
88 (announce_mkdir, make_ancestor): New functions.
89 (main): Use them. Adjust to mode_adjust API change. Stick with
90 umask 0. Use make_dir_parents for all the work.
91 * src/mkfifo.c (main): Adjust to new mode_adjust API.
92 * src/mknod.c (main): Likewise.
93 * tests/chmod/setgid: Do the setgid test instead of bailing.
94 * tests/mkdir/p-3: Remove re_protect case that no longer applies.
95 GNU chmod now behaves like other versions of chmod.
96 * tests/mkdir/perm: Add a test for the X bug.
98 2006-07-14 Paul Eggert <eggert@cs.ucla.edu>
100 * src/base64.c (do_decode): Output to parameter OUT, not to stdout.
101 This doesn't fix any bugs, since OUT always equals stdout, but it
102 makes the code easier to understand.
104 2006-07-14 Jim Meyering <jim@meyering.net>
106 * Makefile.maint (CVS_LIST): Use new file, build-aux/vc-list-files,
107 rather than open-coding it. Now supports mercurial, too.
108 * .hgignore: New file.
109 * Makefile.am (EXTRA_DIST): Add .hgignore, which ignores nearly
110 all generated files, including ones like configure and po/*.po
111 that are currently version-controlled in cvs.
113 * Makefile.am (EXTRA_DIST): Add a few more .??* files.
114 They've been in CVS, just haven't been distributed before this.
115 Distribute ChangeLog-2005, too.
116 (MAINTAINERCLEANFILES): Add THANKS-to-translators.
118 2006-07-11 Paul Eggert <eggert@cs.ucla.edu>
120 * src/system.h: Assume <dirent.h> exists, since gnulib assumes
123 2006-07-09 Jim Meyering <jim@meyering.net>
125 * tests/mv/dir2dir: Adjust so failing with ENOTEMPTY is ok, too.
126 That happens with Linux/tmpfs.
127 * tests/mv/Makefile.am (TESTS): Add dir2dir.
129 2006-07-09 Paul Eggert <eggert@cs.ucla.edu>
131 Adjust to recent updates from gnulib.
132 * src/dd.c (apply_translations): Use toupper rather than
133 islower followed by toupper; it's simpler and typically
134 faster now that we assume at least C89 semantics. Similarly
136 * src/sort.c (inittables): Likewise.
137 * src/expand.c (expand): Don't assume that isprint etc. return
138 booleans (needed for pre-C99 hosts).
139 * src/fmt.c (check_punctuation): Likewise.
140 * src/ptx.c (initialize_regex, fix_output_parameters): Likewise.
141 * src/tr.c (is_char_class_member): Likewise.
142 * src/unexpand.c (unexpand): Likewise.
143 * src/join.c (is_blank): Remove; no longer needed. All uses
144 replaced by isblank (to_uchar (...)).
145 * src/pinky.c (create_fullname): Don't assume char is unsigned.
146 * src/printf.c (print_esc): Likewise.
147 * src/ptx.c (SKIP_NON_WHITE, SKIP_WHITE, SKIP_WHITE_BACKWARDS):
148 (copy_unescaped_string): Likewise.
149 * src/stat.c (print_it): Likewise.
150 * src/system.h (_D_EXACT_NAMELEN): Renamed from NLENGTH, for
151 convenience on GNU systems. All uses changed. Don't bother
152 looking for any dirent.h substitute other than ndir.h.
153 (D_INO): Remove unnecessary parentheses.
154 (IN_CTYPE_DOMAIN, ISGRAPH, ISPRINT, ISALNUM, ISALPHA):
155 (ISCNTRL, ISLOWER, ISPUNCT, ISSPACE, ISUPPER, ISXDIGIT):
156 (ISDIGIT_LOCALE, TOLOWER, TOUPPER): Remove. All uses changed
157 to ctype.h equivalents.
158 (isblank): Renamed from ISBLANK. Check for HAVE_DECL_ISBLANK too.
161 2006-07-08 Jim Meyering <jim@meyering.net>
163 * tests/mv/dir2dir: New file, test for 2006-07-05 fix in copy.c.
165 * Makefile.maint (sc_the_the): New rule.
167 * src/dd.c (skip): Remove one of two adjacent "the"s in a comment.
168 * tests/Coreutils.pm (run_tests): Remove one of two adjacent "then"s
171 2006-07-07 Jim Meyering <jim@meyering.net>
173 * NEWS: Mention that mv can now remove an empty destination directory,
174 and give an example. Prompted by a report from Florent Bayle.
176 2006-07-05 Jim Meyering <jim@meyering.net>
178 * src/ls.c (usage): Correct the description of -G: it is useful
179 only in a long listing. Reported by Martin Pool in
180 <https://launchpad.net/distros/ubuntu/+source/coreutils/+bug/51653>.
182 * man/chmod.x: Correct the description of the sticky bit. Reported
183 by Chris Moore via Ian Jackson in <http://bugs.debian.org/376745>.
185 * src/copy.c (copy_internal): Don't work around old NFS clients like
186 SunOS-4.1.4 and Irix 5.3 that set errno to values like EIO and
187 ENOTEMPTY upon failed rename. Otherwise, we risk misinterpreting
188 a banal failure as a recursive move-into-self failure.
189 Reported by Florent Bayle in <http://bugs.debian.org/376749>.
191 * src/c99-to-c89.diff: Regenerate, to remove fuzz.
193 2006-07-03 Jim Meyering <jim@meyering.net>
195 Plug another unusual leak.
196 (AD_mark_helper): Free malloc'd filename if hash_insert says
197 that string is already in the hash table.
199 The dev/inode of the topmost directory in each hierarchy were not
201 * src/remove.c (remove_cwd_entries): Don't call cycle_check here.
202 (AD_push): Call it from here instead.
205 * src/remove.c (AD_stack_clear): New function.
207 (AD_pop_and_chdir): Free *prev_dir just before longjmp.
209 * tests/Makefile.am, tests/*/Makefile.am: (TESTS_ENVIRONMENT):
210 Add $VG_PATH_PREFIX as a prefix to $PATH
212 * tests/envvar-check (vars): Add CDPATH and POSIXLY_CORRECT.
213 * tests/Makefile.am (evar-check): Remove rule.
214 (EXTRA_DIST): Remove .env-warn.
215 * tests/.env-warn: Remove file. No longer used.
216 Suggestion from Eric Blake.
218 2006-07-02 Paul Eggert <eggert@cs.ucla.edu>
220 * src/system.h: Include <stdint.h> unconditionally, since we
221 now assume the stdint module.
223 2006-07-01 Paul Eggert <eggert@cs.ucla.edu>
225 * NEWS: With no operand, 'tail -f' now silently ignores the '-f'
226 only if standard input is a FIFO or pipe and POSIXLY_CORRECT is set.
227 * src/tail.c (main): Implement this.
228 * tests/tail/Test.pm (f-pipe-1): Renamed from f-1.
229 (test_vector): Set POSIXLY_CORRECT for the f-pipe-* tests.
231 2006-07-01 Jim Meyering <jim@meyering.net>
233 * src/ln.c (do_link): Use new, shorter URL, for ag-review link.
235 * .x-sc_require_config_h: Add ^lib/xstrtold\.c$, so make distcheck
238 2006-06-30 Paul Eggert <eggert@cs.ucla.edu>
240 * NEWS: seq now uses long double internally rather than double.
241 It now defaults to a minimal fixed point format if possible.
242 It lets you use %a, %A, %E, %F, %G.
243 * src/Makefile.am (seq_LDADD): Remove $(SEQ_LIBM); add $(POW_LIB).
244 * src/seq.c: Don't include <math.h> or <xstrtol.h>; no longer needed.
245 (isfinite) [!defined isfinite]: New macro.
246 (separator, terminator): Now points to const.
247 (first, step, last): Remove.
248 (usage): Update to match new behavior.
249 (struct operand, operand): New type.
250 (scan_arg): Renamed from scan_double_arg, since we no longer use double.
252 Compute and return a value of type operand, not double.
253 (long_double_format): Renamed from valid_format, and now returns a
254 new format with an "L" added if needed, if the original format was
255 valid. Allow %a, %A, %E, %F, and %G formats.
256 (print_numbers): Take numeric values as args rather than from globals.
257 Print long double, not double.
258 (get_width_format): Remove.
259 (get_default_format): New function.
260 (main): Implement new way of calculating default format.
261 Don't worry about locale's representation of the decimal point, since
262 the arguments are always processed in the C locale.
263 * tests/seq/basic (neg-2): Adjust to new default format.
264 (eq-wid-1, eq-wid-2): Resurrect these tests, since the new
265 implementation should do the right thing.
267 2006-06-30 Jim Meyering <jim@meyering.net>
269 * tests/stty/basic-1: Work around an intermittent test failure
270 on HP-UX 11.11. Report and analysis from Bob Proulx.
271 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/7475
273 2006-06-28 Paul Eggert <eggert@cs.ucla.edu>
275 * NEWS: Support obsolete usages like "sort +1 -2" even when
276 conforming to POSIX 1003.1-2001, since this is a pure extension to
277 POSIX. Problem reported by Christian in:
278 http://lists.gnu.org/archive/html/bug-coreutils/2006-06/msg00220.html
279 * src/sort.c (main): Implement this.
281 * src/system.h (CLOSEDIR): Remove. All uses changed to closedir.
282 Autoconf 2.60 says this stuff was obsolete.
284 2006-06-28 Jim Meyering <jim@meyering.net>
286 * src/c99-to-c89.diff: Regenerate, to remove fuzz.
288 2006-06-28 Bob Proulx <bob@proulx.com> (tiny change)
290 * tests/mv/i-link-no: Work around HP-UX /bin/sh tracing problem
291 (set -x when VERBOSE=yes) when stderr is redirected before stdout
292 causing shell tracing of the stdout redirection to be written to
293 the stderr file. Avoid problem and test failure on HP-UX by
294 redirecting stderr last.
295 * tests/dd/unblock-sync: Order shell file redirections for
296 stderr and stdout in the common style.
299 2006-06-27 Jim Meyering <jim@meyering.net>
301 * tests/misc/cat-proc: Try to avoid any spurious numeric
302 differences in frequently-changing /proc/cpuinfo.
303 Reported by Nelson Beebe.
305 2006-06-26 Jim Meyering <jim@meyering.net>
307 Attempt rmdir (actually, unlinkat-with-AT_REMOVEDIR) upon any
308 fd_to_subdirp failure, not just when errno == EACCES.
309 * src/remove.c (remove_dir): Use unlinkat-with-AT_REMOVEDIR, not
310 rmdir, here, even though rmdir may happen to be adequate.
312 * NEWS: rm no longer fails to remove an empty, unreadable directory
313 * src/remove.c (remove_cwd_entries): If we can't open a directory,
314 and the failure is not being ignored, try to remove the directory
315 with rmdir (aka unlinkat-with-AT_REMOVEDIR), in case it's empty.
316 Problem report and test case from Paul Eggert in
317 <http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/7425>.
319 * tests/rm/empty-inacc: New test, for the above.
321 Avoid a segfault for wc --files0=- < /dev/null.
322 * src/wc.c (compute_number_width): Return right away if nfiles == 0.
324 2006-06-25 Jim Meyering <jim@meyering.net>
326 * NEWS: wc accepts a new option --files0-from=FILE, where FILE
327 contains a list of NUL-separated file names.
329 * src/wc.c: Include "readtokens.h".
330 (usage): Describe the new option, and adjust the `Usage':
331 with this option, no FILE may be specified on the command line.
332 (main): Handle the new option.
333 * tests/misc/wc-files0: New tests, for the above.
334 * tests/misc/wc-files0-from: Likewise.
335 * tests/misc/Makefile.am (TESTS): Add wc-files0.
337 2006-06-24 Jim Meyering <jim@meyering.net>
339 * src/md5sum.c (DIGEST_BUFFER): Remove now-unused definitions.
341 2006-06-22 Jim Meyering <jim@meyering.net>
343 * src/tee.c (tee_files): Rename from tee, to avoid conflict with
344 the function in glibc's <fcntl.h>. Reported by Andreas Schwab.
346 2006-06-19 Jim Meyering <jim@meyering.net>
348 * Makefile.cfg (local-checks-to-skip): Add changelog-check,
349 so this check is not run as part of "make distcheck".
351 2006-06-18 Bob Proulx <bob@proulx.com> (tiny change)
353 * tests/misc/pwd-long: Fix typo (s/neq/ne/) in previous change.
355 2006-06-18 Jim Meyering <jim@meyering.net>
357 * tests/misc/pwd-long: Make error output a little clearer.
359 2006-06-17 Jim Meyering <jim@meyering.net>
361 * tests/rm/inaccessible: Skip this test on systems without openat
362 support. Reported by Bob Proulx.
364 2006-06-15 Bob Proulx <bob@proulx.com> (tiny change)
366 * tests/misc/mknod: Improve permission checks to handle
367 running mkdir test in set-gid directories.
369 2006-06-14 Jim Meyering <jim@meyering.net>
371 * tests/du/basic: Revamp not to hard-code file system block sizes.
373 2006-06-12 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
375 * tests/du/Makefile.am (TESTS_ENVIRONMENT): Pass $(PERL), for
378 2006-06-11 Jim Meyering <jim@meyering.net>
380 * .gitignore: New file.
381 * Makefile.am (EXTRA_DIST): Add .gitignore.
383 Setting TIME_STYLE=long-iso in the environment would make the
384 cp/same-file test fail.
385 * tests/envvar-check (vars): Add TIME_STYLE to the list.
386 * tests/cp/same-file: Revert last change.
387 Source the envvar-check script, to ensure that TIME_STYLE
388 settings don't affect these tests.
390 2006-06-11 Paul Eggert <eggert@cs.ucla.edu>
392 * tests/cp/same-file: Execute 'ls' in the C locale, so that it
393 uses POSIX time stamp formats. Problem reported by John Nixon in
394 <http://lists.gnu.org/archive/html/bug-coreutils/2006-06/msg00062.html>.
396 2006-06-10 Jim Meyering <jim@meyering.net>
398 * NEWS: Mention the AIX-strndup-bug vs. dircolors workaround.
400 Require a "Version N.M" line at the top of the ChangeLog
401 file only when making the actual release, not when running
403 * Makefile.maint (maintainer-distcheck): Don't depend on
405 (alpha beta major): Depend on it here, instead.
407 2006-06-08 Jim Meyering <jim@meyering.net>
409 Ensure that cat works with any of the options, -A -v -e -E -T,
410 when applied to files in /proc and /sys, even when the FIONREAD
411 ioctl produces nonsensical results. Before this change, cat would
412 produce no output (or truncated output), for some linux kernels.
414 * src/cat.c (write_pending): New function, factored out of cat.
415 (cat): Also interpret a negative ioctl/FIONREAD count as indicating
416 that there are bytes to read. Some versions of linux-2.6.16 do that.
417 Write any pending output before returning.
418 Reported by Dan Jacobson in <http://bugs.debian.org/370583>.
419 * NEWS: Mention this bug fix.
420 * tests/misc/cat-proc: New file. Test for the above.
421 * tests/misc/Makefile.am (TESTS): Add cat-proc.
423 2006-06-07 Paul Eggert <eggert@cs.ucla.edu>
425 * src/expr.c (eval4): Detect overflow properly when multiplying
428 2006-06-06 Paul Eggert <eggert@cs.ucla.edu>
430 * NEWS: The 'expr' command now detects and reports integer overflow.
431 (It would be better to use extended precision instead, but that
433 * src/expr.c (integer_overflow): New function.
434 (eval4, eval3): Check for integer overflow.
436 2006-06-05 Paul Eggert <eggert@cs.ucla.edu>
438 Fix problems when building with Solaris/SVR4/etc. make, which uses a
439 different and somewhat bogus implementation of VPATH. In the
440 directory tests/misc, rename tests whose names might appear in the
441 Automake-generated rules. For example, we can't use a test named
442 'test', since Automake generates a rule that contains the text
443 "if test -f ./$$tst; ...", and this might expand to something like
444 "if ../../../coreutils-6.0/tests/misc/test -f ./$$test; ...",
445 which executes the 'test' script rather than the 'test' command.
446 * tests/misc/false-status: Renamed from tests/misc/false.
447 * tests/misc/pwd-long: Renamed from tests/misc/pwd.
448 * tests/misc/sort-merge: Renamed from tests/misc/sort.
449 ($prog): Set to 'sort' rather than to $PROG.
450 * tests/misc/test-diag: Renamed from tests/misc/test.
451 * tests/misc/Makefile.am (PROG): Take the basename of $$tst,
452 in case Solaris make has prepended the directory.
453 (TESTS): Adjust to above renamings.
454 * tests/misc/expand: Don't assign to PROG; no longer needed
455 now that Makefile.am sets PROG to the basename.
456 * tests/misc/fold: Likewise.
458 2006-06-03 Jim Meyering <jim@meyering.net>
460 Make `cp --link --no-dereference' work also on systems where the
461 link system call cannot create a hard link to a symbolic link.
462 * src/copy.c (copy_internal) [LINK_FOLLOWS_SYMLINKS]: Don't use
463 the link syscall on a symlink when it would do the wrong thing.
464 Based on the patch by Aurelien Jarno: <http://bugs.debian.org/329451>
465 * tests/cp/link-no-deref: New file/test for the above.
466 * tests/cp/Makefile.am (TESTS): Add link-no-deref.
467 * NEWS: Mention the change (doesn't affect Linux).
469 2006-06-01 Paul Eggert <eggert@cs.ucla.edu>
471 Fix some porting problems in the test cases reported by
472 Ralf Wildenhues for HP-UX 11.23 in:
473 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00238.html
474 * tests/help-version: Don't assume that \< \> works in sed.
475 * tests/misc/close-stdout: Don't assume that >&- works.
476 Add a /dev/full test.
477 * tests/touch/no-create-missing: Don't assume that >&- works.
479 2006-05-30 Jim Meyering <jim@meyering.net>
481 * src/ls.c (usage): Add `v' to the list of sorting-related options.
484 2006-05-28 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
486 * tests/cp/fail-perm: source lang-default.
487 * tests/rm/inaccessible: Likewise.
489 2006-05-28 Jim Meyering <jim@meyering.net>
491 * tests/rm/inaccessible: AIX 4.3.3 gives a different diagnostic.
492 Recognize it, too. Reported by Ralf Wildenhues, in
493 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
495 2006-05-27 Jim Meyering <jim@meyering.net>
497 * src/chgrp.c: Support new options: --preserve-root and
498 --no-preserve-root. Somehow this program was skipped when those
499 options were added to chown, chmod, and rm. Reported by
500 vaqflabuopac@spammotel.com in <http://bugs.debian.org/365656>.
501 * NEWS: Mention this.
503 2006-05-25 Paul Eggert <eggert@cs.ucla.edu>
505 * NEWS: Remove mention of --seed. We'll replace it with something
506 better, and don't want to indicate that it is supported.
507 * src/sort.c (usage): Likewise.
509 2006-05-20 Jim Meyering <jim@meyering.net>
511 * src/chmod.c (main): Use FTS_PHYSICAL here, too.
513 * src/du.c (main): Rename local, s/symlink_deref_bit/symlink_deref_bits/
514 and arrange for -D to set fts' FTS_PHYSICAL bit as well as
515 FTS_COMFOLLOW. Spotted by Justin Pryzby.
517 * gnupload: Merge changes from automake, retaining the ""--to...
518 kludge to placate overzealous `make distcheck' check.
520 2006-05-19 Jim Meyering <jim@meyering.net>
522 * src/du.c (main): Don't let -D, -L, or -P turn off the internal
523 FTS_TIGHT_CYCLE_CHECK directory traversal option.
524 Reported by Justin Pryzby in http://bugs.debian.org/367691
526 2006-05-15 Jim Meyering <jim@meyering.net>
528 * src/cp.c (usage): Correct description of -a: s/-dpR/-dpPR/.
531 2006-05-13 Jim Meyering <jim@meyering.net>
533 * tests/mv/no-target-dir: Test two more cases.
535 2006-05-11 Jim Meyering <jim@meyering.net>
537 mv -T DIR EMPTY_DIR no longer fails unconditionally
538 * src/copy.c (copy_internal): Don't manually prohibit a move where
539 the destination is an existing directory. Sometimes doing that is
540 valid. Let the rename system call enforce the rules. That is
541 allowed only when the source is a directory and the destination
542 directory (to be replaced) is empty. Reported by Eric Blake.
543 * tests/mv/no-target-dir: New file/test for this.
544 * tests/mv/Makefile.am (TESTS): Add no-target-dir.
545 * NEWS: Mention this.
547 * tests/mv/atomic: New file/test for yesterday's fix.
548 * tests/mv/Makefile.am (TESTS): Add atomic.
550 * tests/du/long-sloop: Avoid harmless `ambiguous redirect' diagnostic.
552 2006-05-10 Jim Meyering <jim@meyering.net>
554 * src/copy.c (copy_internal): Don't explicitly unlink the destination
555 when moving a symlink into the place of an existing non-directory.
556 Reported by Joshua Hudson.
557 * NEWS: mention this.
559 2006-05-07 Jim Meyering <jim@meyering.net>
561 * Makefile.maint (patch-check): Fail if patch generates any output,
562 even merely for changed offsets.
564 * src/c99-to-c89.diff: Adjust to reflect new offsets.
566 * NEWS: Mention changes affecting df, pwd, shred.
568 2006-05-06 Jim Meyering <jim@meyering.net>
570 * tests/ls/stat-vs-dirent: New test, to detect the bogus file
571 system condition where dirent.d_ino != stat.st_ino.
572 * tests/ls/Makefile.am (TESTS): Add stat-vs-dirent.
574 2006-05-06 Eric Blake <ebb9@byu.net>
576 * tests/ls/inode: Expand to test inode from readdir case.
577 * tests/ls/follow-slink: Expand to test broken links encountered
578 implicitly, favoring Solaris 9 and OpenBSD 3.4 behavior.
580 2006-05-06 Eric Blake <ebb9@byu.net>
582 * tests/mv/leak-fd: Work even on case-insensitive file system.
584 2006-05-04 Jim Meyering <jim@meyering.net>
586 * NEWS: Mention the 2006-03-19 pwd-related change that makes
587 lib/getcwd.c work around inconsistent file system dirent.d_ino data.
589 2006-05-03 Jim Meyering <jim@meyering.net>
591 * src/ls.c (DEFINE_SORT_FUNCTIONS, LIST_SORTFUNCTION_VARIANTS):
592 Use better macro parameter names: s/basename/key_name/,
593 s/basefunc/key_cmp_func. Fix typo in comment.
595 2006-04-29 Eric Blake <ebb9@byu.net>
597 * src/ls.c (main): On systems with d_type, directories_first only
598 implies format_needs_type, not format_needs_stat.
600 2006-05-03 Jim Meyering <jim@meyering.net>
602 * src/ls.c (xstrcoll_df_version, rev_xstrcoll_df_version): Add space
603 after comma in arg list, from Eric Blake.
605 2006-04-25 Paul Eggert <eggert@cs.ucla.edu>
607 * tests/misc/date (relative-3): New test, derived from a bug
608 report by John Thomas McDole.
610 2006-04-23 Francesco Montorsi <fr_m@hotmail.com>
612 New option for ls: --group-directories-first.
613 It makes ls list directories before files.
614 * NEWS [New features]: Mention it.
615 * src/ls.c (sort_type): Rearrange to use as an array index when
616 choosing sort function; added new sort_numtypes member for
618 (time_type): Add new time_numtypes member for compile-time check.
619 (directories_first): New global variable.
620 (GROUP_DIRECTORIES_FIRST_OPTION): New enum.
621 (long_options): Add --directories-first.
622 (main): Support new option.
623 (is_directory): New function.
624 (extract_dirs_from_files): Use it.
625 (DIRFIRST_CHECK, DEFINE_SORT_FUNCTIONS)
626 (LIST_SORTFUNCTION_VARIANTS): New macros.
627 (sort_functions): New global variable.
628 (sort_files): Use it.
629 (usage): Document new option.
631 2006-04-18 Paul Eggert <eggert@cs.ucla.edu>
633 * src/shred.c (fillrand): The assertion was way too weak, due to
634 what must be a typo. Strengthen it to its intended value.
635 (dopass): Don't use alloca; it's not worth the aggravation here,
636 since it's used only to get a page-aligned buffer, and page
637 alignment doesn't buy us much here. I'm suspicious that alloca
638 causes problems on some hosts, due to a recent bug report by Adam
639 Waltman: http://bugs.gentoo.org/130246.
641 2006-04-18 Jim Meyering <jim@meyering.net>
643 * tests/misc/tty-eof: Add new programs, base64, sha224sum, sha256sum,
644 sha384sum, sha512sum.
646 2006-04-17 Paul Eggert <eggert@cs.ucla.edu>
648 * src/chmod.c (describe_change): Adjust to filemode changes.
649 * src/ls.c (HAVE_ST_DM_MODE): Remove; moved to ../lib/filemode.c.
650 (print_long_format): Use (new) filemodestring rather than
651 (old) mode_string, so that we get more file types right, at least
652 in theory. Adjust to filemode changes.
653 * src/stat.c (human_access): Likewise.
655 2006-04-18 Jim Meyering <jim@meyering.net>
657 * src/ptx.c (main) [DEFAULT_IGNORE_FILE]: Remove code to use a default
658 ignore file. This has never been enabled. Reported by Eric Blake.
660 2006-04-12 Paul Eggert <eggert@cs.ucla.edu>
662 * src/ln.c (linkfunc): Remove. This method ran into a compiler/linker
663 bug in Interix. Just call symlink or link directly. All uses changed.
664 * src/setuidgid.c (main) [! HAVE_SETGROUPS]: Don't call setgroups.
665 * src/stat.c (USE_STATVFS): New macro.
666 Include <sys/statvfs.h> and use statvfs only if USE_STATVFS.
667 (NAMEMAX_FORMAT): define a bit more clearly, now that the
668 statvfs-using code is a bit more regular.
669 * src/system.h (sync) [!HAVE_SYNC]: New macro.
671 2006-04-11 Paul Eggert <eggert@cs.ucla.edu>
673 * NEWS: csplit, nl, expr now conform to POSIX better, and are
674 more-compatible with traditional Unix, with respect to regular
676 * src/csplit.c (extract_regexp): Set re_syntax_options to a
677 value that is compatible with what POSIX requires.
678 * src/nl.c (build_type_arg): Likewise.
679 * src/expr.c (docolon): Likewise. Also, don't let anchors match
680 newline; this fixes an incompatibility with tradition and with POSIX.
681 Don't warn about leading ^. POSIX says it is unspecified whether
682 ^ is a special character, which means that implementations can
683 either treat it as special or not, but either way a warning is not
684 allowed (unless the regexp is otherwise invalid). Instead, anchor
685 the expression but treat ^ as an anchor; this is the traditional
686 behavior (e.g., Solaris 10).
687 (eval4, eval3, eval2): Treat non-numeric args, division by zero,
688 and the like as invalid expressions (exit status 2), not as
689 failure of 'expr' (exit status 3). This is more consistent with
691 * tests/expr/basic (fail-a): Adjust exit status to match new expr
692 behavior, for status 2 versus 3.
694 (bre1, bre2, bre3, bre4, bre5, bre6, bre7, bre8, bre9, bre10):
695 (bre11, bre12, bre13, bre14, bre15, bre16, bre17, bre18, bre19, bre20):
696 (bre21, bre22, bre23, bre24, bre25, bre26, bre27, bre28, bre29, bre30):
697 (bre31, bre32, bre33, bre34, bre35, bre36, bre37, bre38, bre39, bre40):
698 (bre41, bre42, bre43, bre44, bre45, bre46, bre47, bre48, bre49, bre50):
699 (bre51, bre52, bre53, bre54, bre55, bre56, bre57, bre58, bre59, bre60):
700 (bre61, bre62): New tests.
701 * tests/misc/csplit: Use \{...\} in test RE, to test that we're
705 * tests/du/long-from-unreachable: Solaris 8 sh doesn't understand
706 "if !". Do not assume that 'sed' can handle long, newline-free input.
707 * tests/du/long-sloop: Likewise. Evaluate expr once, not $n times.
709 2006-04-10 Paul Eggert <eggert@cs.ucla.edu>
711 Adjust to new regex.h API (with new fastmap type), and clean
712 up the regex storage allocation a bit.
714 * src/csplit.c (struct control): Put re_compiled member at the
715 end, since it's large. Change regexpr member from char * to bool;
716 all uses changed. Add new member fastmap.
717 (extract_regexp): regexp arg is now char const *, not char *.
718 Don't bother duplicating the regular expression; it's not needed.
719 Set fastmap from new fastmap member. Don't bother allocating
720 a buffer, as the regexp code does a better job than we do.
721 * src/expr.c (docolon): Allocate and use a fastmap.
722 Don't bother allocating a buffer.
723 * src/nl.c (body_fastmap, header_fastmap, footer_fastmap):
725 (build_type_arg): New fastmap arg. All uses changed.
726 Don't bother allocating a buffer, but set a fastmap.
727 * src/ptx.c (context_regex_string, word_regex_string): Remove.
728 (context_regex, word_regex): New vars, replacing the above.
730 (struct regex_data): New type.
731 (compile_regex): Renamed from alloc_and_compile_regex, since
732 we no longer allocate storage. Arg is now a struct regex_data *,
733 not a const char *. All uses changed. Don't allocate the fastmap;
734 instead, take it from the caller. Don't convert size_t to int,
735 to avoid arithmetic overflow problems. Don't bother freeing
736 storage afterwards; it's not worth the aggravation.
737 * src/tac.c (compiled_separator_fastmap): New ver.
738 (main): Use it. Don't bother allocating a buffer.
740 2006-03-30 Jim Meyering <jim@meyering.net>
742 * src/dd.c (iwrite): Remove assignment without effect.
743 Reported by Felix Rauch Valenti.
745 2006-03-22 Eric Blake <ebb9@byu.net>
747 * src/ptx.c (usage): Remove mention of --copyright/-C.
748 (main): Alias --copyright to --version plus a deprecation warning.
749 * NEWS: Mention this.
751 2006-03-27 Jim Meyering <jim@meyering.net>
753 * src/Makefile.am (uptime_LDADD): Add $(POW_LIB), for uptime's
754 use of strtod. Tiny patch from Nickolai Zeldovich.
756 2006-03-11 Eric Blake <ebb9@byu.net>
758 * tests/misc/dirname: New file.
759 * tests/basename/Makefile.am: Delete.
760 * tests/basename/basic: Move to...
761 * tests/misc/basename: ... this new file. Add some tests,
762 including fixed behavior for //.
763 * tests/misc/Makefile.am (TESTS): Sort. Add basename, dirname.
764 * tests/Makefile.am (SUBDIRS): Remove basename.
765 * configure.ac (AC_CONFIG_FILES): Remove tests/basename.
767 Improvements to dirname/basename handling on platforms like
768 cygwin with distinct // and with drive letters.
769 * NEWS: Document new behavior.
770 * src/basename.c (main): Don't strip suffix from file system
772 * src/cp.c (target_directory_operand): Use new last_component.
773 (ASSIGN_BASENAME_STRDUPA): Likewise. Reduce time spent
774 traversing the string.
775 * src/dircolors.c (guess_shell_syntax): Use new last_component.
776 * src/install.c (target_directory_operand, install_file_in_dir):
778 * src/ln.c (target_directory_operand, main): Likewise.
779 * src/ls.c (basename_is_dot_or_dotdot): Likewise.
780 * src/mv.c (target_directory_operand, movefile): Likewise.
781 * src/remove.c (rm_1): Likewise.
782 * src/shred.c (wipename): Likewise.
783 * src/split.c (next_file_name): Likewise.
784 * src/su.c (log_su, run_shell): Likewise.
786 2006-03-23 Paul Eggert <eggert@cs.ucla.edu>
788 * NEWS: nohup diagnostics are now more precise, and nohup now
789 redirects stderr to nohup.out if stdout is closed and stderr is a tty.
790 * src/nohup.c (main): Implement this.
791 * tests/misc/nohup: Test the new behavior.
793 2006-03-12 Jim Meyering <jim@meyering.net>
795 * src/copy.c (set_author): Rename function, from preserve_author.
797 * src/remove.c (AD_pop_and_chdir): Use new macro,
798 CYCLE_CHECK_REFLECT_CHDIR_UP, rather than open-coding it.
800 * src/system.h (SAME_INODE): Remove definition.
801 Include "same-inode.h", instead.
803 2006-03-11 Eric Blake <ebb9@byu.net>
805 * src/pwd.c (robust_getcwd): Prepend only one slash, not two.
807 2006-03-10 Jim Meyering <jim@meyering.net>
809 Fix a bug whereby a user with write access to a directory being removed
810 could cause the removal of that directory to fail with an erroneous
811 diagnostic about a directory cycle. Reported by Vineet Chadha.
813 * NEWS: Mention this.
814 * src/remove.c (AD_pop_and_chdir): If the directory we're about to
815 leave (and try to rmdir) is the one whose dev_ino is being used to
816 detect a cycle, reset cycle_check_state.dev_ino to that of the parent.
818 2006-03-08 Paul Eggert <eggert@cs.ucla.edu>
820 * NEWS: Document dd's new 'directory' and 'nolinks' flags.
821 * src/dd.c (set_fd_flags): Handle file-creation flags on file
822 descriptors, rather than ignoring them.
823 * tests/dd/misc: Add test cases for append, nofollow, directory,
824 and nolinks flags. Simplify redirection to /dev/null in some cases.
826 * tests/dd/misc: iflags->iflag. This fixes a typo that meant the
827 noatime test never tested anything.
829 2006-03-05 Paul Eggert <eggert@cs.ucla.edu>
831 * src/dd.c (flags, usage): New flags directory, nolinks.
832 * src/system.h (O_NOLINKS): Define to 0 if not already defined.
834 * src/ls.c (usage): Mention that -f disables --color.
835 Problem reported by Niels Möller.
837 2006-03-03 Justin Pryzby <pryzbyj@justinpryzby.com>
839 * man/*.x: Add references to syscalls from utilities of the same name.
841 2006-03-05 Jim Meyering <jim@meyering.net>
843 * tests/help-version: Set SHELL, if not already set, in order to
844 avoid failure when `make check' is run through debuild; dircolors
845 would fail due to lack of $SHELL. Reported by Sven Joachim.
847 Make `base64 --wrap=N' work for N=0, and for N larger than SIZE_MAX.
848 * src/base64.c (wrap_write, do_encode, main): Change type of
849 parameters and locals, wrap_column, form size_t to uintmax_t.
850 (main): Adjust to use xstrtoumax, accordingly.
852 2006-03-03 Jim Meyering <jim@meyering.net>
854 Don't fail when run from an environment with SHELL not a Bourne
855 shell, e.g. `env SHELL=/bin/csh make check' would fail this test.
856 * tests/dircolors/simple: Invoke each non-failing test with -b.
857 Reported by Michael Stone.
859 2006-02-27 Jim Meyering <jim@meyering.net>
861 * tests/misc/base64: Derive --decode-using tests from the
864 * tests/misc/base64: Factor out a long constant string.
865 Split lines to stay within 80 columns.
867 * tests/misc/Makefile.am (TESTS): Add base64.
868 * tests/misc/base64: Test base64. From Simon Josefsson.
870 * src/base64.c (do_decode): Use correct type for parameter,
871 ignore_garbage: s/size_t/bool/.
873 * src/base64.c: Don't include .h files already included by system.h:
874 <string.h>, <stdlib.h>, <stdbool.h>, <limits.h>, <errno.h>.
875 Include "system.h" before the other lib/*.h header files.
876 Include <sys/types.h> before "system.h".
877 (wrap_write): Remove declaration of unused local, initial_column.
878 (wrap_write): Correct declaration syntax: s/size_t * V/size_t *V/.
880 * README: Add base64 to the list.
882 2006-02-17 Simon Josefsson <jas@extundo.com>
885 * AUTHORS: Mention base64.
887 * man/Makefile.am: Build base64.1.
888 * man/base64.x: New file.
889 * src/Makefile.am (bin_PROGRAMS): Add base64.
890 * src/base64.c: New file.
892 2006-02-25 Eric Blake <ebb9@byu.net>
894 In ls, avoid calling stat for --inode (-i), when possible.
895 * src/pwd.c (NOT_AN_INODE_NUMBER, D_INO): Move to ...
896 * src/system.h: ... here, for use in ...
897 * src/ls.c (main): ... here. Prefer dirent.d_ino to stat when
899 (gobble_file): Add inode argument.
900 (print_dir): Pass inode if available.
901 (usage): Remove inaccuracy.
903 2006-02-23 Jim Meyering <jim@meyering.net>
905 * TODO: Update/correct some obsolete entries.
907 2006-02-20 Paul Eggert <eggert@cs.ucla.edu>
909 * doc/coreutils.texi (join invocation): Mention `sort -k 1b,1'.
910 * src/join.c (usage): Likewise.
911 Documentation problem reported by Philip Kensche.
913 2006-02-20 Eric Blake <ebb9@byu.net>
915 * man/rm.x: Update documentation to match previous patch.
917 2006-02-18 Eric Blake <ebb9@byu.net>
919 New option for rm: --interactive=once (-I).
920 * NEWS: Document it, along with change to rm --interactive.
921 * TODO: Remove entry for implementing rm -I
922 * src/rm.c (INTERACTIVE_OPTION): New enum value.
923 (interactive_type): New enum.
924 (long_opts): Let interactive take an optional argument.
925 (interactive_args, interactive_types): New option arguments.
926 (usage): Document -I, --interactive=WHEN. Use program_name
927 instead of a basename.
928 (main): New -I option, new behavior to --interactive.
929 * tests/rm/interactive-once: New tests.
930 * tests/rm/interactive-always: Ditto.
931 * tests/rm/Makefile.am (TESTS): Run them.
933 2006-02-18 Jim Meyering <jim@meyering.net>
935 * Makefile.maint (sc_two_space_separator_in_usage): Make the regular
936 expression match more of the target lines, e.g., those that start with
937 `-S,' (short option followed by a comma) or that include `=[...]'.
938 Patch by Nicolas François.
939 Fix the four offenders thus exposed:
940 * src/join.c (usage): Use two spaces (not one) to separate the
941 --first-only option string from its description, so help2man formats
942 the derived man page properly.
943 * src/pr.c (usage): Likewise.
944 * src/uniq.c (usage): Likewise.
945 * src/install.c (usage): Likewise.
947 2006-02-15 Jim Meyering <jim@meyering.net>
949 * Makefile.maint (alpha beta major): For `make major', ensure that the
950 version string is of the form N.N[.N]*, where N is one or more digits.
952 2006-02-14 Jim Meyering <jim@meyering.net>
954 * INSTALL: Update from gnulib.
956 2006-02-13 Jim Meyering <jim@meyering.net>
958 * GNUmakefile (all): Emit diagnostics to stderr, not stdout.
960 2006-02-12 Jim Meyering <jim@meyering.net>
962 * Makefile.maint (patch-check): New target.
963 (local-checks-available): Add to the list.
965 2006-02-11 Jim Meyering <jim@meyering.net>
967 * src/c99-to-c89.diff: New file.
968 * src/Makefile.am (EXTRA_DIST): Add c99-to-c89.diff.
970 * .x-po-check: New file, with exclusions so that `make distcheck'
972 * Makefile.am (EXTRA_DIST): Add .x-po-check.
974 rm -r must remove an empty directory, even if it is inaccessible.
975 * src/remove.c (close_preserve_errno): New function.
976 (fd_to_subdirp): Don't print a diagnostic in this function.
977 Do it from the callers instead, unless rmdir succeeds.
978 (remove_cwd_entries, remove_dir): Adjust callers.
979 * tests/rm/empty-inacc: New test for the above.
980 * tests/rm/Makefile.am (TESTS): Add empty-inacc.
981 * NEWS: Mention this bug fix.
982 * tests/rm/rm2: Adjust two expected diagnostics, now that they're
983 a tiny bit less precise: cannot remove `a/1': ... instead of
984 cannot open directory `a/1': ...
986 * Makefile.maint (syntax-check-rules): Automatically derive this
987 list of sc_-prefixed rule names.
989 2006-02-10 Paul Eggert <eggert@cs.ucla.edu>
991 * Makefile.maint (CVS_LIST): Don't assume cvsu is available.
992 (CVS_LIST_EXCEPT): New macro, to simplify exception-processing.
993 Most uses of CVS_LIST changed to use CVS_LIST_EXCEPT.
994 (syntax-check-rules): Bring back sc_changelong. (Hmm, why did it
995 go away? was that an accident?)
996 (sc_cast_of_argument_to_free, sc_cast_of_x_alloc_return_value):
997 (sc_cast_of_alloca_return_value, sc_space_tab, sc_prohibit_atoi_atof):
998 (sc_error_exit_success, sc_file_system, sc_no_if_have_config_h):
999 (sc_system_h_headers, sc_sun_os_names, sc_trailing_blank):
1000 (sc_two_space_separator_in_usage, sc_unmarked_diagnostics):
1001 (sc_obsolete_symbols, sc_changelog, sc_prohibit_jm_in_m4):
1002 (sc_useless_cpp_parens, makefile-check, m4-check, po-check):
1003 (author_mark_check, makefile_path_separator_check):
1004 Output line numbers, to simplify navigation of Emacs *compilation*
1006 (sc_prohibit_atoi_atof, sc_file_system):
1007 Rework slightly so that Makefile.maint doesn't get reported as a
1008 violation of its own syntax rules.
1009 (sc_dd_max_sym_length): Use ifneq to do nothing, instead of doing
1010 it at run-time (which didn't work with Bison). Fix a makefile typo,
1011 caught by Makefile.maint itself: spaces where a tab should be.
1012 (po-check): Check lib/*.[ch] even if not in CVS; used by Bison,
1013 which copies from ../gnulib/lib/*.[ch] to lib/*.[ch].
1014 Ignore djgpp and man subdirectories, to avoid false matches with
1015 Bison and coreutils, respectively. Use sort -u to remove the
1016 resulting duplicates.
1017 * gnupload: Rework slightly to avoid bogus warning from
1018 sc_two_space_separator_in_usage.
1020 2006-02-10 Jim Meyering <jim@meyering.net>
1022 Use gzip's --rsyncable option only if it's available.
1023 * Makefile.maint (gzip_rsyncable): New variable.
1026 2006-02-08 Jim Meyering <jim@meyering.net>
1028 * Makefile.maint (local-checks-available): Define in terms of
1029 the expansion, $(syntax-check-rules), rather than the single,
1030 top-level target `syntax-check', so that it's easier to exclude
1031 individual rules (via $(local-checks-to-skip)).
1032 (tgz-md5, tgz-sha1, ...): Remove now-unused definitions.
1034 2006-02-07 Jim Meyering <jim@meyering.net>
1036 * src/system.h (!defined O_DIRECT): If O_DIRECTIO is defined (as it
1037 is on Tru64), define O_DIRECT to that. Patch From James Lemley.
1039 * tests/help-version (expected_failure_status_vdir):
1040 Redirect an expected disk-full diagnostic to /dev/null.
1042 2006-02-06 Jim Meyering <jim@meyering.net>
1044 * src/unexpand.c (usage): Use two spaces (not one) to separate the
1045 --first-only option string from its description, so help2man formats
1046 the derived man page properly.
1047 * src/rm.c (usage): Likewise for --no-preserve-root.
1048 * src/chown.c (usage): Likewise.
1049 * src/chgrp.c (usage): Likewise.
1051 Add a rule to ensure that the above doesn't happen again.
1052 * Makefile.maint (sc_two_space_separator_in_usage): New rule.
1053 (syntax-check-rules): Add it.
1054 * .x-sc_two_space_separator_in_usage: New empty file.
1055 * Makefile.am (EXTRA_DIST): Add .x-sc_two_space_separator_in_usage.
1057 2006-02-06 Jim Meyering <jim@meyering.net>
1059 * src/cp.c (usage): Use two spaces (not one) to separate each
1060 option string from its description, so help2man formats the
1061 derived man page properly.
1062 * src/mv.c (usage): Likewise.
1063 Patch from Nicolas François in http://bugs.debian.org/351601.
1065 2006-02-04 Jim Meyering <jim@meyering.net>
1067 * src/copy.c (copy_internal): cp -RL would fail when encountering
1068 the same directory more than once in the hierarchy beneath a single
1069 command-line argument. That is legitimate, e.g. when there are
1070 two or more symbolic links, each pointing to some directory that
1071 would not otherwise be copied. Reported by Christophe LYON.
1072 * tests/cp/cp-deref: New file. Test for today's fix.
1073 * tests/cp/Makefile.am (TESTS): Add cp-deref.
1074 * NEWS: Document this.
1076 2006-02-03 Jim Meyering <jim@meyering.net>
1078 * configure.ac: Require automake-1.9.6, not 1.8.3.
1080 2006-02-01 Paul Eggert <eggert@cs.ucla.edu>
1082 * src/od.c (usage): Mention that -t a ignores high order bit.
1083 Documentation problem reported by Ed Avis.
1085 2006-02-01 Jim Meyering <jim@meyering.net>
1087 * src/pwd.c (find_dir_entry): Remove unused local, `ent_sb_valid'.
1089 2006-01-30 Paul Eggert <eggert@cs.ucla.edu>
1091 * src/head.c (main): Use a better diagnostic when someone uses a
1092 trailing numeric option in an invalid way. Problem reported by
1094 * src/tail.c (parse_options): Likewise.
1096 2006-01-30 Jim Meyering <jim@meyering.net>
1098 * man/wc.x: Include `count' keyword in man page synopsis,
1099 per suggestion from http://bugs.debian.org/181585.
1101 2006-01-24 Paul Eggert <eggert@cs.ucla.edu>
1103 * src/df.c (show_dev): If the file system claims to have
1104 more available than total blocks, report the number of used
1105 blocks as being total - available (a negative number) rather
1106 than as garbage. Problem reported by Toralf Foerster.
1108 2006-01-24 Jim Meyering <jim@meyering.net>
1110 * src/tail.c (tail_forever): Don't exit-nonzero when an attempt
1111 to put a regular file in O_NONBLOCK mode fails with EPERM.
1112 That happens on Linux (up to 2.6.15) when using tail -f on a file with
1113 the append-only attribute. Reported by Dean Gaudet. For details,
1114 see http://savannah.gnu.org/bugs/?func=detailitem&item_id=15473.
1115 * NEWS: Mention this fix.
1116 * tests/tail-2/append-only: New file. Test for the above.
1117 * tests/tail-2/Makefile.am (TESTS): Add append-only.
1118 * tests/Makefile.am (check-root): Add tail-2/append-only
1120 2006-01-21 Jim Meyering <jim@meyering.net>
1122 * NEWS: Mention fts-related improvements and bug fixes.
1124 2006-01-19 Jim Meyering <jim@meyering.net>
1126 * tests/fmt/basic (pfx-1, pfx-2): New tests, to demonstrate the bug
1127 reported as http://bugs.debian.org/147577. Forwarded by Thomas Hood.
1129 2006-01-18 Jim Meyering <jim@meyering.net>
1131 * tests/du/Makefile.am (TESTS): Add long-from-unreadable.
1133 2006-01-17 Jim Meyering <jim@meyering.net>
1135 Now that fts no longer changes the current working directory, adjust
1136 its clients accordingly -- note that du.c uses fts but doesn't need
1137 any adjustment, since it doesn't operate on the actual files,
1138 but rather just uses the stat buffers provided by fts.
1140 * src/chown-core.c: Include "openat.h".
1141 Don't include "lchown.h".
1142 (restricted_chown): Accept a new parameter, CWD_FD, and use it in
1143 calling openat, lchownat, chownat, rather than open, lchown, chown.
1145 * src/chmod.c: Include "openat.h".
1146 (process_file): Use chmodat (fts->fts_cwd_fd,... in place of chmod (...
1148 * tests/du/long-from-unreadable: New test, to exercise one small
1151 2006-01-13 Jim Meyering <jim@meyering.net>
1153 * tests/Makefile.am (SUBDIRS): Add comments discouraging the
1154 addition of new directories under tests/.
1156 * tests/acl: Redirect stdin to /dev/null. Otherwise, FreeBSD 5.0's
1159 2006-01-12 Jim Meyering <jim@meyering.net>
1161 * tests/du/long-sloop: Adjust not to hard-code the expected
1162 diagnostic corresponding to ELOOP. Solaris' diagnostic differs
1163 from that of GNU libc. Reported by Paul Eggert.
1165 * tests/du/long-sloop: Create file at end of symlink chain.
1167 * tests/misc/test: New file, with a test for one of the
1168 bugs fixed by yesterday's test.c changes.
1169 * tests/misc/Makefile.am (TESTS): Add test.
1171 2006-01-11 Jim Meyering <jim@meyering.net>
1173 * tests/du/long-sloop: New file. Test for today's fts.c bug fix.
1174 That bug could make du -L, chgrp -L, or chown -L fail to diagnose
1175 a very long sequence of symbolic links (not necessarily a loop).
1176 * tests/du/Makefile.am (TESTS): Add long-sloop.
1178 2006-01-11 Paul Eggert <eggert@cs.ucla.edu>
1180 * src/test.c (test_syntax_error): Append a newline. All callers
1181 changed, except for the ones that didn't already append a newline.
1182 Bug reported by Eric Blake.
1184 2006-01-11 Jim Meyering <jim@meyering.net>
1186 * src/system.h (X2NREALLOC): Now that verify_true is no longer
1187 void, cast its result to void, to avoid gcc's warning that
1188 ``left-hand operand of comma expression has no effect''.
1189 (DECIMAL_DIGIT_ACCUMULATE, X2REALLOC): Likewise.
1191 2006-01-10 Jim Meyering <jim@meyering.net>
1193 * tests/chmod/no-x: Add a test for today's fts.c fix.
1195 2006-01-10 Jim Meyering <jim@meyering.net> (tiny change)
1197 * src/ls.c (gobble_file): Use DTTOIF only if it's defined.
1198 This is necessary for Dragonfly. Patch by Joerg Sonnenberger.
1200 2006-01-10 Paul Eggert <eggert@cs.ucla.edu>
1202 * src/system.h (X2NREALLOC, X2REALLOC, DECIMAL_DIGIT_ACCUMULATE):
1203 Use verify_true instead of verify_expr, to sync with gnulib.
1205 2006-01-08 Jim Meyering <jim@meyering.net>
1207 * src/date.c (usage): Adjust the formatting of the entries for
1208 %::z and %:::z (separate with two spaces, not one) so that help2man
1209 formats them properly. Reported by Philip Rowlands.
1211 2006-01-06 Paul Eggert <eggert@cs.ucla.edu>
1213 * configure.ac (gl_IGNORE_UNUSED_LIBRARIES): Add.
1215 2006-01-06 Jim Meyering <jim@meyering.net>
1217 * Makefile.maint (copyright-check): Use date +%Y in place of
1220 * src/remove.c (rm_1): Remove `static' attribute on local `status'.
1221 First off, the attribute should have been `volatile' (not static)
1222 to avoid longjmp-related risk of clobber. Secondly, now there is
1223 no longer any risk of a local variable being clobbered, so there's
1224 no need for any attribute at all.
1226 2006-01-05 Jim Meyering <jim@meyering.net>
1228 * src/remove.c: Give a few functions the inline attribute.
1229 (AD_pop_and_chdir): Use gotos to avoid some duplication.
1230 (AD_push): Rewrite an assertion so that the entire computation
1231 goes away when assertions are turned off.
1233 * src/tail.c (ENOSYS) [!defined ENOSYS]: Don't define here.
1234 It's already defined in "system.h".
1235 * Makefile.maint: Add a FIXME comment.
1237 2006-01-04 Jim Meyering <jim@meyering.net>
1239 * ChangeLog: Remove entries from 2005-10-22 and earlier.
1240 * ChangeLog-2005: New file, for entries up to version 5.92.
1242 2006-01-03 Jim Meyering <jim@meyering.net>
1244 * tests/du/no-x: Also allow a slightly different diagnostic -- the
1245 one you get when using openat-enabled fts.c and du (coming soon).
1246 * tests/chmod/no-x: Likewise.
1247 * tests/chgrp/no-x: Likewise.
1249 * src/system.h (O_DIRECTORY) [!defined O_DIRECTORY]: Define.
1251 2006-01-02 Paul Eggert <eggert@cs.ucla.edu>
1253 * src/chown-core.c (RC_do_ordinary_chown): New enum value.
1254 (restricted_chown): Return it, if the file cannot be accessed due
1255 to EPERM, or if no uid or gid are required, or if the file is
1256 neither a directory nor a regular file. Rewrite to avoid gotos.
1257 (change_file_owner): Handle RC_do_ordinary_chown case.
1258 Rewrite to avoid gotos.
1259 * tests/chgrp/basic: Make sure we can change the group of
1262 * src/date.c (usage): Explain %g, %G, and %V a bit better.
1264 2006-01-02 Jim Meyering <jim@meyering.net>
1266 * src/copy.c (set_owner): Correct a comment.
1268 * src/tail.c (parse_options): Change warning to say that --retry
1269 is useful `mainly' (not `only') when following by name.
1270 Reported here: http://bugs.debian.org/273781
1272 2006-01-01 Paul Eggert <eggert@cs.ucla.edu>
1274 * NEWS: Document that mkfifo and mknod -m no longer set special bits.
1275 * src/copy.c: Include lchmod.h.
1276 (copy_internal): Use lchmod rather than chmod.
1277 * src/cp.c: Include lchmod.h.
1278 (re_protect, make_dir_parents_private): Use lchmod rather than chmod.
1279 * src/mkdir.c: Include lchmod.h.
1280 (usage): Clarify -m's operation.
1281 (main): Use lchmod rather than chmod. Don't use lchmod unless the
1282 new mode contains bits outside the 777 range.
1283 * src/mkfifo.c (usage): Clarify -m's operation.
1284 (main): If -m is given, don't invoke chmod; use umask 0 instead.
1285 Report an error if -m asks for bits outside the 777 range.
1286 * src/mknod.c (usage, main): Likewise.
1288 * src/mkdir.c, src/mkfifo.c, src/mknod.c: Undo 2005-12-19 changes.
1290 2005-12-27 Jim Meyering <jim@meyering.net>
1292 * Makefile.maint (sc_obsolete_symbols): Prohibit use of O_NDELAY.
1293 (sc_prohibit_assert_without_use): New rule.
1294 (syntax-check-rules): Add it to the list.
1295 * .x-sc_prohibit_assert_without_use: New empty file.
1296 * Makefile.am (EXTRA_DIST): Add it.
1298 * Makefile.maint (CVS_LIST): Define in terms of $(srcdir).
1300 * cp.c, df.c, link.c, mknod.c, nice.c, sleep.c, unlink.c:
1301 Don't include <assert.h>; it wasn't used.
1303 2005-12-26 Paul Eggert <eggert@cs.ucla.edu>
1305 * src/chown-core.c (restricted_chown):
1306 Don't try O_WRONLY unless O_RDONLY failed wth EACCES.
1307 * src/remove.c (fd_to_subdirp): Open with O_DIRECTORY | O_NOCTTY
1308 | O_NOFOLLOW too, for consistency with other dir-openers.
1309 Use POSIX-preferred O_NONBLOCK rather than O_NDELAY.
1310 (is_empty_dir): Likewise.
1311 * src/shred.c (wipename): Likewise. Don't bother trying to open
1312 dir for writing, since POSIX prohibits it.
1314 2005-12-22 Jim Meyering <jim@meyering.net>
1316 * tests/help-version: Redirect stderr to /dev/full, to suppress
1317 write error diagnostic.
1319 2005-12-19 Jim Meyering <jim@meyering.net>
1321 * src/mkdir.c, src/mknod.c, src/mkfifo.c (main)
1322 Avoid a minor race condition when `-m MODE' is specified, by using
1323 open, fchown, and close rather than just chown. To do that reliably --
1324 even with an overly restrictive umask -- ensure that each mkdir,
1325 mknod and mkfifo call uses a mode including at least owner-read access.
1326 * src/mknod.c (main): When `-m MODE' is specified, exit nonzero if
1327 the subsequent chown (or equivalent open,fchown,close) fails.
1328 * tests/misc/mknod: New tests.
1329 * tests/misc/Makefile.am (TESTS): Add mknod.
1331 2005-12-17 Jim Meyering <jim@meyering.net>
1333 * src/remove.c (is_empty_dir): Open with O_NDELAY, so we don't hang,
1334 e.g., on a named pipe.
1335 (OPEN_NO_FOLLOW_SYMLINK): Remove definition. Use O_NOFOLLOW in
1336 place of all uses, since it is guaranteed (system.h) to be defined.
1338 2005-12-05 Andreas Gruenbacher <agruen@suse.de>
1340 Add POSIX ACL support
1341 * src/ls.c: Switch back from HAVE_ACL to USE_ACL: The acl() syscall
1342 is no requirement for ACL support; particularly, it does not exist
1343 on systems that have POSIX ACLs.
1344 * src/copy.h (cp_option_init) [umask_kill]: Remove member.
1345 * src/cp.c (umask_kill): With default acls, the umask is not to be
1346 applied. Remove umask_kill, don't change the process umask, and let
1347 the kernel apply the umask where appropriate.
1348 * src/cp.c (make_dir_parents_private): Fix logic for POSIX ACLs.
1349 * src/copy.c (get_dest_mode): Remove; it is obsolete after removing
1351 (copy_reg, copy_internal): Use copy_acl and set_acl
1352 instead of fchown/chown. Fix the logic for POSIX ACLs.
1353 (chown_succeded): Remove; we now always copy acls and
1354 preserve S_ISUID, S_ISGID, and S_ISVTX when needed, no matter if we
1355 did a chown before or not.
1356 * src/mv.c, src/install.c (cp_option_init): Don't set umask_kill member.
1357 * src/Makefile.am (dir_LDADD, ls_LDADD, vdir_LDADD, cp_LDADD,
1358 mv_LDADD, ginstall_LDADD): On systems with an ACL library, arrange
1359 to link with it via $(LIB_ACL), for the utilities that need it.
1361 2005-12-16 Paul Eggert <eggert@cs.ucla.edu>
1363 * src/remove.c (OPENAT_CWD_RESTORE__REQUIRE): Remove.
1364 (OPENAT_CWD_RESTORE__ALLOW_FAILURE): Likewise.
1365 (fd_to_subdirp): Remove openat_cwd_restore_allow_failure arg; its
1366 value is now signified by whether cwd_errno is null.
1367 (fd_to_subdirp, remove_dir, rm_1); Change cwd failure indicator from
1368 pointer-to-bool to pointer-to-errno-value. All callers changed.
1369 (rm_1): Don't bother setting a local cwd failure flag and then
1370 ORing it into the caller's. Just set the caller's.
1371 (rm): Use cwd failure errno value to print a slightly-better
1374 2005-12-15 Jim Meyering <jim@meyering.net>
1376 * src/stat.c (print_it): Properly handle a backslash at the
1377 end of a --printf format string. Reported by Paul Eggert.
1378 * tests/misc/stat-printf (end-bs): Add a test for the above.
1380 2005-12-15 Paul Eggert <eggert@cs.ucla.edu>
1382 * tests/acl: Port to pre-POSIX shells like Solaris 8 /bin/sh.
1383 Don't assume /etc/passwd contains user names; use 'id' instead.
1385 2005-12-15 Jim Meyering <jim@meyering.net>
1387 stat: revert behavior of --format=FMT (-c)
1388 stat: add new option: --printf=FMT
1389 * NEWS: Mention this.
1390 * src/stat.c (isodigit, octtobin, hextobin): Define.
1391 (PRINTF_OPTION): Define.
1392 (interpret_backslash_escapes, trailing_delim): New globals.
1393 (usage): Document them. Alphabetize on long option names.
1394 (print_esc_char): New function.
1395 (print_it): Rewrite, in order to handle backslash escapes.
1396 (main): Handle new option. Set globals for --format, too.
1398 * tests/misc/stat-printf: Test --printf and --format.
1399 * tests/misc/Makefile.am (TESTS): Add stat-printf.
1401 2005-12-14 Paul Eggert <eggert@cs.ucla.edu>
1403 * NEWS: sort now reports incompatible options.
1404 * src/sort.c (incompatible_options, check_ordering_compatibility):
1406 (main): Use them. Don't bother with a usage message for
1407 "sort -c a b", for consistency with other error diagnostics.
1408 * tests/sort/Test.pm (incompat1, incompat2, incompat3, incompat4):
1411 * src/cat.c (main): Undo previous change. close_stdout already
1412 does the check, so the previous change wasn't necessary.
1414 2005-12-13 Paul Eggert <eggert@cs.ucla.edu>
1416 * src/cat.c (main): Check for close (STDOUT_FILENO) failure.
1418 2005-12-12 Paul Eggert <eggert@cs.ucla.edu>
1420 Install a more-conservative approach for sort -R. It's the
1421 same basic idea as the existing code, except it uses the full ISAAC
1422 approach (called the "more kosher" approach in the existing comments).
1423 This makes "sort -R" quite a bit slower (about a factor of 2 on my
1424 little tests involving 10000 lines on a 2.4 GHz P4), but I think it's
1425 better to be conservative here at first, and review any performance
1426 improvements carefully.
1427 * .x-sc_require_config_h: Add src/rand-isaac.c.
1428 * src/rand-isaac.h: Remove. All uses now simply include rand-isaac.c.
1429 * src/Makefile.am (noinst_HEADERS): Remove rand-isaac.h.
1430 (shred_SOURCES, sort_SOURCES): Remove.
1431 (EXTRA_DIST): Add rand-isaac.c.
1432 * src/rand-isaac.c: Revert to what used to be in shred.c, without
1433 changing it to allow for varying numbers of words in the state.
1434 Alter so that we include rand-isaac.c directly rather than
1435 compiling it and linking to it. Don't include config.h or
1436 system.h; that's the includer's responsibility.
1437 Omit functions that are specific to shred.
1438 (ISAAC_LOG, ISAAC_WORDS, ISAAC_BYTES, struct isaac_state, ind):
1439 (isaac_step, struct irand_state):
1440 Resurrect these, with the same defns that used to be in shred.c.
1441 (ISAAC_SIZE, isaac_new, isaac_copy): Remove.
1442 (isaac_refill, isaac_seed_start, isaac_seed_data, irand_init, irand32):
1444 (struct isaac_state, isaac_refill, isaac_mix, isaac_init):
1445 (isaac_seed_start, isaac_seed_data, isaac_seed_finish, isaac_seed):
1446 (irand_init, irand32, irand_mod):
1447 Number of words is constant again.
1448 (struct irand_state, irand_init, irand32, irand_mod): Move to shred.c.
1449 * src/shred.c: Include rand-isaac.c rather than rand-isaac.h.
1450 * src/sort.c: Likewise.
1451 * src/shred.c (fillrand, dopass, main): Undo previous change.
1452 (struct irand_state, irand_init, irand32, irand_mod): Moved back here,
1454 * src/sort.c: Don't include md5.h; it wasn't needed.
1455 (struct keyfield): Rename random_hash to random, for consistency
1456 with the other member names. All uses changed.
1457 (usage): Tweak wording to mention STRING for --seed option.
1458 (short_options): Rorder for consistency with other programs.
1459 (rand_state): Now a struct, not a pointer to one. All uses changed.
1460 (HASH_WORDS, HASH_SIZE): Remove.
1461 (get_hash): Remove comments around resbuf size, since we can assume C89.
1462 Use a "more-kosher" (but slower) approach of invoking isaac_refill.
1463 (keycompare): Adjust to the new get_hash.
1465 (badfieldspec): Omit recently-introduced comment; it isn't needed.
1466 (main): Don't set need_random simply because gkey has it set; that
1467 doesn't necessarily mean we'll need random numbers.
1468 Redo seeding to match new get_hash approach.
1470 2005-12-10 Jim Meyering <jim@meyering.net>
1472 * src/Makefile.am (noinst_HEADERS): Add rand-isaac.h.
1474 Avoid shred segfault on 64-bit systems.
1475 * src/rand-isaac.c (isaac_refill): Don't try to negate a
1476 local of type uint32_t. Make the local an `int' instead.
1478 * NEWS: Mention sort's new options.
1480 * src/rand-isaac.c (isaac_mix): Declare to be static.
1481 Mark all other functions as `extern' so the tight-scope
1482 part of `make distcheck' passes once again.
1483 * src/rand-isaac.h (isaac_mix): Remove declaration.
1485 * src/sort.c (get_hash): Change position of `*' in parameter
1486 type to conform with convention.
1487 (main): Split a long line so it fits in 80 columns.
1488 (keycompare): Remove stray SPACE before TAB that was
1489 causing `make distcheck' to fail.
1491 * src/shred.c: Don't include gethrxtime.h. No longer needed.
1493 * tests/misc/sort-rand: New file: basic tests for the new options.
1494 * tests/misc/Makefile.am (TESTS): Add sort-rand.
1496 2005-12-10 Frederik Eaton <frederik@ofb.net>
1498 * src/Makefile.am (sort_LDADD): Add $(LIB_GETHRXTIME).
1499 (shred_SOURCES, sort_SOURCES): New macros, so we compile rand-isaac.c.
1500 * src/rand-isaac.c: New file, containing ISAAC code that was in shred.c.
1501 Make state size runtime-configurable.
1502 (isaac_new, isaac_copy): New functions.
1503 * src/rand-isaac.h: New file.
1504 * src/shred.c: Include rand-isaac.h. Move ISAAC code to rand-isaac.c.
1505 (fillrand, main): Adjust to the fact that the state size is now
1506 runtime-configurable.
1507 * src/sort.c (short_options, long_options, WORDS, keycompare, main):
1508 (usage): Add options --random-sort and --seed to implement a random
1510 Include md5.h and rand-isaac.h.
1511 (get_hash): New function.
1512 (rand_state): New var.
1513 (HASH_WORDS, HASH_SIZE): New macros.
1515 2005-12-09 Paul Eggert <eggert@cs.ucla.edu>
1517 * tests/dd/misc: Add test for dd iflags=noatime.
1519 2005-12-09 Jim Meyering <jim@meyering.net>
1521 * src/sort.c (usage): Mention white space vs -b and -t options.
1524 2005-12-09 Eric Blake <ebb9@byu.net>
1526 * src/test.c (main): Fix misleading comment.
1528 2005-12-07 Paul Eggert <eggert@cs.ucla.edu>
1530 * NEWS: Mention dd's new noatime flag.
1531 * src/system.h (O_NOATIME): Define to 0 if not already defined.
1532 * src/dd.c (flags, usage): Add support for noatime flag.
1534 2005-12-07 Jim Meyering <jim@meyering.net>
1536 Distribute the cvsu script, used only by `make syntax-check'.
1537 * Makefile.am (EXTRA_DIST): Add build-aux/cvsu.
1538 * Makefile.maint (CVS_LIST): Use build-aux/cvsu, now that we
1539 distribute a copy of this script.
1540 * .x-sc_unmarked_diagnostics: Add build-aux/cvsu.
1542 * tests/mv/acl: exit-77 before the trap, not after, if we fail
1543 to create a temporary directory on another partition.
1544 From Andreas Gruenbacher.
1546 2005-12-06 Tomas Pospisek <tpo@sourcepole.ch> (tiny change)
1548 * man/basename.x: Cross-reference to dirname and readlink.
1549 * man/dirname.x: Cross-reference to basename and readlink.
1551 2005-12-05 Andreas Gruenbacher
1553 * src/copy.c [!HAVE_FCHOWN]: Define fchown(...) to -1.
1554 (set_owner, preserve_author): New functions, factored out of copy_reg.
1555 (copy_reg): Use them.
1556 (copy_internal): Use them here, too.
1558 2005-12-04 Jim Meyering <jim@meyering.net>
1560 * src/sleep.c (usage): Say what happens with two or more arguments.
1561 Suggested by Justin Pryzby.
1563 * src/uptime.c (print_uptime): Move decl of `upsecs' into scope
1566 2005-12-03 Jim Meyering <jim@meyering.net>
1568 * src/rm.c (long_opts): Change the name of each undocumented, for-
1569 testing-only option to start with `-', so that it cannot render
1570 ambiguous any prefix it happens to share with some other option name.
1571 Problem reported by Eric Blake.
1572 * src/head.c (long_options): Likewise.
1573 * src/tail.c (long_options): Likewise.
1575 * tests/misc/head-elide-tail: Update uses of undocumented, for-
1576 testing-only --presume* options to start with `---'.
1577 * tests/rm/dangling-symlink: Likewise.
1578 * tests/rm/dir-no-w: Likewise.
1579 * tests/rm/isatty: Likewise.
1581 2005-11-30 Jim Meyering <jim@meyering.net>
1583 * Makefile.maint: Add a comment about cvsu.
1585 2005-11-25 Paul Eggert <eggert@cs.ucla.edu>
1587 * NEWS: df updates for "none", "proc", inaccessible file systems.
1588 * src/df.c (show_point): Ignore inaccessible file systems.
1589 (usage): -a includes dummy file systems, not size-0 file systems.
1591 * src/od.c (unsigned_long_long_int): Renamed from ulonglong_t,
1592 to avoid collision with POSIX name space. All uses changed.
1594 2005-11-24 Jim Meyering <jim@meyering.net>
1596 * tests/Makefile.am (EXTRA_DIST): Add acl to the list.
1597 * tests/acl: Add `$0: ' prefix to diagnostics.
1599 * .x-sc_require_config_h: Add lib/buffer-lcm.c to the list.
1601 2005-11-23 Paul Eggert <eggert@cs.ucla.edu>
1603 * src/copy.c: Improve performance a bit by optimizing away
1604 unnecessary system calls and going to a block size of at least
1605 8192 (on normal hosts, anyway). This improved performance 5% on my
1606 Debian stable host (2.4.27 kernel, x86, copying from root
1607 ext3 file system to itself).
1608 Include "buffer-lcm.h".
1609 (copy_reg): Omit last argument. All callers changed.
1610 Use xmalloc to allocate rather than trusting alloca
1611 (which is unwise with large block sizes).
1612 Declare locals more locally, if possible.
1613 Use uintptr_t words instead of int words, for a bit more speed
1614 when looking for null blocks on 64-bit hosts.
1615 Optimize away reads of zero bytes on regular files.
1616 In the typical case, insist on 8 KiB buffers, at least.
1617 Avoid unnecessary extra call to fstat when checking for sparse files.
1618 Avoid now-unnecessary cast to off_t, and "0L".
1619 Avoid unnecessary test of *new_dst when checking for same owner
1622 2005-11-22 Paul Eggert <eggert@cs.ucla.edu>
1624 * src/remove.c (rm): Don't assume C99 for-loop syntax.
1626 2005-11-22 Jim Meyering <jim@meyering.net>
1628 * src/remove.c (AD_push): Remove debugging cruft.
1630 * tests/rm/unread2 (rm): Change expected diagnostic,
1631 `cannot open directory' to `cannot remove', to align with
1633 * tests/rm/rm2: Ensure that rm now continues removing entries
1634 even after certain types of failure.
1636 * src/remove.c: Rewrite. Now, this module is reentrant on systems
1637 that provide openat (Solaris), and on systems like Linux+procfs
1638 where our openat emulation code is reentrant. This also fixes a
1639 few low-probability leaks and eliminates some code that could,
1640 in very unusual circumstances, cause rm() (via a callee) to exit.
1641 * NEWS: Mention this.
1643 * configure.ac: Put copyright dates all on one line so the
1644 emacs function that updates them works properly.
1646 2005-11-18 Paul Eggert <eggert@cs.ucla.edu>
1648 * configure.ac (AM_PROG_CC_C_O): Add. Needed for CVS Automake.
1649 Problem reported by Eric Blake.
1650 (AC_PROG_CC_STDC): Use this instead of AC_PROG_CC, so that
1651 we get a standard-conforming compiler. This relies on the new
1652 m4/c.m4 file. Note that it's a bit tricky, since c.m4 doesn't
1653 define AC_PROG_CC_STDC; we are relying on Autoconf 2.59 internals.
1654 m4/c.m4 can go away with Autoconf 2.60 comes out.
1656 2005-11-17 Jim Meyering <jim@meyering.net>
1658 * src/remove.c (AD_mark_helper): Make a `char *' parameter `const'.
1659 (AD_mark_current_as_unremovable): Likewise, but for a local.
1662 * tests/mv/acl: Let traps handle removing temporary directories.
1664 Expect acl-related tests to fail, until the corresponding
1665 patches are committed.
1666 * tests/mv/Makefile.am (XFAIL_TESTS): Add acl.
1667 * tests/cp/Makefile.am (XFAIL_TESTS): Likewise.
1669 ACL tests, from Andreas Gruenbacher.
1670 * tests/acl, tests/mv/acl, tests/cp/acl: New files.
1671 * tests/mv/Makefile.am (TESTS): Add acl.
1672 * tests/cp/Makefile.am (TESTS): Add acl.
1674 * src/ls.c (basename_is_dot_or_dotdot): Correct wording in comment.
1676 2005-11-16 Paul Eggert <eggert@cs.ucla.edu>
1678 * NEWS: Improve quality of ln's diagnostics.
1679 * src/ln.c (do_link, usage): Likewise.
1680 (do_link): Don't use alloca on a buffer of unbounded size.
1682 2005-11-16 Jim Meyering <jim@meyering.net>
1684 * tests/cp/fail-perm: Accommodate HPUX. It appears to fail
1685 with EACCES rather than EPERM. Reported by Peter O'Gorman here:
1686 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/5766
1687 This also affects AIX 4.3.3, according to Ralf Wildenhues, in
1688 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
1690 2005-11-14 Jim Meyering <jim@meyering.net>
1692 * NEWS (sort): Mention consequences of today's mkstemp-safer.c fix.
1694 2005-11-13 Jim Meyering <jim@meyering.net>
1696 * announce-gen: Accept new option, --gpg-key-id=ID and
1697 emit a blurb telling how to use the .sig files.
1698 * Makefile.cfg (gpg_key_ID): Define.
1699 * Makefile.maint (announcement): Use new option and key.
1701 Require that most .c files include <config.h>.
1702 * Makefile.maint (sc_require_config_h): New rule.
1703 (syntax-check-rules): Add it.
1704 * .x-sc_require_config_h: New file listing exceptions to the
1705 above rule. Some are legit, others are simply grandfathered in.
1706 * Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h here, too.
1708 2005-11-12 Jim Meyering <jim@meyering.net>
1710 * src/checksum.h, src/md5.c, src/sha1sum.c: Remove now-unused files.
1712 2005-11-11 Jim Meyering <jim@meyering.net>
1714 * NEWS: Mention `readlink -f' bug fix in 5.3.0 news.
1715 Mention new readlink options in 5.3.0's `New features' section.
1716 Spotted by Thomas Hood.
1718 2005-11-08 Jim Meyering <jim@meyering.net>
1720 * NEWS: Merge in changes from b5_9x branch.
1722 2005-11-08 Paul Eggert <eggert@cs.ucla.edu>
1724 * NEWS: ls now defaults to --time-style='locale', which in turn acts
1725 like --time-style='posix-long-iso' if the locale settings are messed up.
1726 * src/ls.c (decode_switches): Implement this.
1728 2005-11-08 Jim Meyering <jim@meyering.net>
1730 * tests/du/2g: s/expensive/very expensive/ in a comment.
1733 2005-10-17 Eric Blake <ebb9@byu.net>
1735 * src/ls.c (usage): Fix descriptions of --sort, --time.
1736 Reported by Vitaly A. Ostanin.
1738 2005-11-04 Paul Eggert <eggert@cs.ucla.edu>
1740 * src/ln.c: Include filenamecat.c.
1741 (FILE_BASENAME_CONCAT): Remove.
1742 (do_link): Remove last arg DEST_IS_DIR. All callers changed.
1743 (main): Use file_name_concat, base_name, and strip_trailing_slashes
1744 instead of FILE_BASENAME_CONCAT. This simplifies the code, and avoids
1747 2005-11-04 Jim Meyering <jim@meyering.net>
1749 * src/du.c (process_file): Don't overflow for files of size >= 2^31
1750 on systems with stat.st_blocks of a signed 32-bit type.
1751 This bug causes trouble on some AIX 5.1 systems.
1752 Report and trivial patch from Paul Townsend:
1753 <http://lists.gnu.org/archive/html/bug-coreutils/2005-11/msg00033.html>
1754 * NEWS: Mention this.
1756 * tests/du/2g: New (very-expensive) test for the above-fixed bug.
1757 * tests/du/Makefile.am (TESTS): Add it here.
1758 * tests/very-expensive: New file.
1759 * tests/Makefile.am (EXTRA_DIST): Add it here.
1760 * tests/cp/perm: Mark this test as `very-expensive', too.
1762 2005-11-02 Paul Eggert <eggert@cs.ucla.edu>
1764 * NEWS: Mention that rm -d and maybe ln -d are scheduled for
1766 * src/remove.h (struct rm_options): Remove unlink_dirs. All uses
1768 * src/rm.c (usage): Don't mention rm -d.
1770 2005-11-02 Jim Meyering <jim@meyering.net>
1772 * tests/dd/skip-seek: Fix typo in comment: s/fileutils/coreutils.
1773 From Andreas Schwab.
1775 * tests/dd/unblock-sync: Redirect stderr to /dev/null so the
1776 `M+N records in/out' lines don't pollute `make check' output.
1778 * tests/dd/skip-seek (sk-seek4): New test, to exercise the bug
1779 fixed on 2005-10-31. This test uses the new, IN_PIPE specifier.
1780 * tests/Coreutils.pm: Accept a new type of input specifier: IN_PIPE,
1781 to indicate that the input file should be piped into the command
1782 under test (via `cat FILE | $prog ...').
1784 * src/remove.c (remove_entry): Emit a better diagnostic when rm
1785 (without -r) fails to remove a directory on a non-Linux system.
1786 This change affects only newer Solaris systems (with priv_*
1787 functions like priv_allocset). Reported by Keith Thompson.
1789 * tests/rm/dir-nonrecur: New file/test for the above fix.
1790 * tests/rm/Makefile.am (TESTS): Add dir-nonrecur.
1792 2005-11-01 Paul Eggert <eggert@cs.ucla.edu>
1794 * NEWS: "tail -c 2 FILE" and "touch 0101000000" now operate as
1795 POSIX 1002.1-2001 requires.
1796 * src/tail.c (parse_obsolete_option): Implement this.
1797 Problem reported by Vincent Lefevre.
1798 * src/touch.c (main): Pass PDS_PRE_2000 to posixtime.
1799 * tests/tail/Test.pm (c-2, c-2-minus, c2, c2-minus): New tests.
1800 (test_vector): Add special cases for _POSIX2_VERSION, and
1801 regularize the old ones a bit.
1802 * tests/touch/obsolescent: Add y2000 test.
1804 2005-10-31 Paul Eggert <eggert@cs.ucla.edu>
1806 * src/dd.c (skip): Fix off-by-one error reported by
1807 Theodoros V. Kalamatianos.
1809 2005-10-30 Paul Eggert <eggert@cs.ucla.edu>
1811 * tests/mkdir/p-3: Require that the test be run as non-root.
1812 Problem and trivial fix reported by Theodoros V. Kalamatianos.
1814 2005-10-28 Paul Eggert <eggert@cs.ucla.edu>
1816 * src/ln.c (FILE_BASENAME_CONCAT): Omit unnecessary slashes in the
1817 boundary between DEST and SOURCE in the result.
1819 2005-10-26 Dmitry V. Levin <ldv@altlinux.org>
1821 * src/md5sum.c (main) [!O_BINARY]: Changed default read mode
1822 back to text, to sync with documentation and for backwards
1825 2005-10-25 Jim Meyering <jim@meyering.net>
1827 * tests/dircolors/simple (other-wr): Add an explicit test for
1828 the dircolors bug (NULL-dereference) fixed yesterday.
1830 2005-10-24 Jim Meyering <jim@meyering.net>
1832 * src/tac.c (tac_file): When determining whether a file is seekable,
1833 also test whether it is a tty. Using only the lseek-based test would
1834 give a false positive on Solaris. Reported by Peter Fales.
1836 2005-10-24 Dmitry V. Levin <ldv@altlinux.org>
1838 * tests/install/d-slashdot: New test, for "install -d" failure.
1839 * tests/install/Makefile.am (TESTS): Add d-slashdot.
1840 * tests/mkdir/p-slashdot: New test, for "mkdir -p" failure.
1841 * tests/mkdir/Makefile.am (TESTS): Add p-slashdot.
1843 2005-10-24 Jim Meyering <jim@meyering.net>
1845 * src/dircolors.c (ls_codes): Add missing comma.
1846 Anonymous report and patch from
1847 http://savannah.gnu.org/bugs/?func=detailitem&item_id=14849
1849 * src/dircolors.c: Add compile-time assertion that the slack_codes
1850 and ls_codes arrays have the same number of elements. This would
1851 have prevented the above-fixed bug.
1853 * src/expand.c (parse_tab_stops): Add a comment to make this function
1854 identical to the one in unexpand.c.
1855 * src/unexpand.c (parse_tab_stops): Adjust syntax to make this function
1856 identical to the one in expand.c.
1858 * src/expand.c (next_file): Don't assume fopen cannot return stdin.
1860 2005-10-23 Jim Meyering <jim@meyering.net>
1862 * src/md5sum.c (digest_check, main): Use ptr_align rather than
1863 a dangerous pointer-value-to-`unsigned' cast.
1864 * NEWS: mention the new sha* programs.
1865 * AUTHORS: Add new sha* programs.
1867 2005-08-28 David Madore <david.madore@ens.fr>
1869 Add new programs: sha224sum, sha256sum, sha384sum, sha512sum.
1870 * README: Add their names to the list.
1871 * src/md5sum.c: Provide framework for computing sha-2 hashes.
1872 * src/Makefile.am (sha224sum, sha256sum, sha384sum, sha512sum):
1873 Rules for compiling sha-2 utilities
1874 (noinst_HEADERS): Remove checksum.h.
1875 * man/sha512sum.x, man/sha384sum.x, man/sha256sum.x, man/sha224sum.x:
1877 * man/Makefile.am (dist_man_MANS): Add the corresponding .1 names.
1878 (sha224sum.1, sha256sum.1, sha384sum.1, sha512sum.1): New dependencies.
1879 * tests/misc/sha224sum, tests/misc/sha256sum: New files.
1880 * tests/misc/sha384sum, tests/misc/sha512sum: New files.
1881 * tests/misc/Makefile.am (TESTS): Add new sha224sum, sha256sum,
1882 sha384sum, sha512sum test scripts here rather that each in its
1885 2005-08-28 David Madore <david.madore@ens.fr>
1887 * tests/sha1sum/basic-1 (million-a): Add the "million a's" test (one
1888 of the FIPS test vectors).
1890 2005-10-23 Jim Meyering <jim@meyering.net>
1892 * configure.ac: Use 6.0-cvs as the version string.
1893 * NEWS: Adjust accordingly.