1 2006-06-11 Paul Eggert <eggert@cs.ucla.edu>
3 * tests/cp/same-file: Execute 'ls' in the C locale, so that it
4 uses POSIX time stamp formats. Problem reported by John Nixon in
5 <http://lists.gnu.org/archive/html/bug-coreutils/2006-06/msg00062.html>.
7 2006-06-10 Jim Meyering <jim@meyering.net>
9 * NEWS: Mention the AIX-strndup-bug vs. dircolors workaround.
11 Require a "Version N.M" line at the top of the ChangeLog
12 file only when making the actual release, not when running
14 * Makefile.maint (maintainer-distcheck): Don't depend on
16 (alpha beta major): Depend on it here, instead.
18 2006-06-08 Jim Meyering <jim@meyering.net>
20 Ensure that cat works with any of the options, -A -v -e -E -T,
21 when applied to files in /proc and /sys, even when the FIONREAD
22 ioctl produces nonsensical results. Before this change, cat would
23 produce no output (or truncated output), for some linux kernels.
25 * src/cat.c (write_pending): New function, factored out of cat.
26 (cat): Also interpret a negative ioctl/FIONREAD count as indicating
27 that there are bytes to read. Some versions of linux-2.6.16 do that.
28 Write any pending output before returning.
29 Reported by Dan Jacobson in <http://bugs.debian.org/370583>.
30 * NEWS: Mention this bug fix.
31 * tests/misc/cat-proc: New file. Test for the above.
32 * tests/misc/Makefile.am (TESTS): Add cat-proc.
34 2006-06-07 Paul Eggert <eggert@cs.ucla.edu>
36 * src/expr.c (eval4): Detect overflow properly when multiplying
39 2006-06-06 Paul Eggert <eggert@cs.ucla.edu>
41 * NEWS: The 'expr' command now detects and reports integer overflow.
42 (It would be better to use extended precision instead, but that
44 * src/expr.c (integer_overflow): New function.
45 (eval4, eval3): Check for integer overflow.
47 2006-06-05 Paul Eggert <eggert@cs.ucla.edu>
49 Fix problems when building with Solaris/SVR4/etc. make, which uses a
50 different and somewhat bogus implementation of VPATH. In the
51 directory tests/misc, rename tests whose names might appear in the
52 Automake-generated rules. For example, we can't use a test named
53 'test', since Automake generates a rule that contains the text
54 "if test -f ./$$tst; ...", and this might expand to something like
55 "if ../../../coreutils-6.0/tests/misc/test -f ./$$test; ...",
56 which executes the 'test' script rather than the 'test' command.
57 * tests/misc/false-status: Renamed from tests/misc/false.
58 * tests/misc/pwd-long: Renamed from tests/misc/pwd.
59 * tests/misc/sort-merge: Renamed from tests/misc/sort.
60 ($prog): Set to 'sort' rather than to $PROG.
61 * tests/misc/test-diag: Renamed from tests/misc/test.
62 * tests/misc/Makefile.am (PROG): Take the basename of $$tst,
63 in case Solaris make has prepended the directory.
64 (TESTS): Adjust to above renamings.
65 * tests/misc/expand: Don't assign to PROG; no longer needed
66 now that Makefile.am sets PROG to the basename.
67 * tests/misc/fold: Likewise.
69 2006-06-03 Jim Meyering <jim@meyering.net>
71 Make `cp --link --no-dereference' work also on systems where the
72 link system call cannot create a hard link to a symbolic link.
73 * src/copy.c (copy_internal) [LINK_FOLLOWS_SYMLINKS]: Don't use
74 the link syscall on a symlink when it would do the wrong thing.
75 Based on the patch by Aurelien Jarno: <http://bugs.debian.org/329451>
76 * tests/cp/link-no-deref: New file/test for the above.
77 * tests/cp/Makefile.am (TESTS): Add link-no-deref.
78 * NEWS: Mention the change (doesn't affect Linux).
80 2006-06-01 Paul Eggert <eggert@cs.ucla.edu>
82 Fix some porting problems in the test cases reported by
83 Ralf Wildenhues for HP-UX 11.23 in:
84 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00238.html
85 * tests/help-version: Don't assume that \< \> works in sed.
86 * tests/misc/close-stdout: Don't assume that >&- works.
88 * tests/touch/no-create-missing: Don't assume that >&- works.
90 2006-05-30 Jim Meyering <jim@meyering.net>
92 * src/ls.c (usage): Add `v' to the list of sorting-related options.
95 2006-05-28 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
97 * tests/cp/fail-perm: source lang-default.
98 * tests/rm/inaccessible: Likewise.
100 2006-05-28 Jim Meyering <jim@meyering.net>
102 * tests/rm/inaccessible: AIX 4.3.3 gives a different diagnostic.
103 Recognize it, too. Reported by Ralf Wildenhues, in
104 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
106 2006-05-27 Jim Meyering <jim@meyering.net>
108 * src/chgrp.c: Support new options: --preserve-root and
109 --no-preserve-root. Somehow this program was skipped when those
110 options were added to chown, chmod, and rm. Reported by
111 vaqflabuopac@spammotel.com in <http://bugs.debian.org/365656>.
112 * NEWS: Mention this.
114 2006-05-25 Paul Eggert <eggert@cs.ucla.edu>
116 * NEWS: Remove mention of --seed. We'll replace it with something
117 better, and don't want to indicate that it is supported.
118 * src/sort.c (usage): Likewise.
120 2006-05-20 Jim Meyering <jim@meyering.net>
122 * src/chmod.c (main): Use FTS_PHYSICAL here, too.
124 * src/du.c (main): Rename local, s/symlink_deref_bit/symlink_deref_bits/
125 and arrange for -D to set fts' FTS_PHYSICAL bit as well as
126 FTS_COMFOLLOW. Spotted by Justin Pryzby.
128 * gnupload: Merge changes from automake, retaining the ""--to...
129 kludge to placate overzealous `make distcheck' check.
131 2006-05-19 Jim Meyering <jim@meyering.net>
133 * src/du.c (main): Don't let -D, -L, or -P turn off the internal
134 FTS_TIGHT_CYCLE_CHECK directory traversal option.
135 Reported by Justin Pryzby in http://bugs.debian.org/367691
137 2006-05-15 Jim Meyering <jim@meyering.net>
139 * src/cp.c (usage): Correct description of -a: s/-dpR/-dpPR/.
142 2006-05-13 Jim Meyering <jim@meyering.net>
144 * tests/mv/no-target-dir: Test two more cases.
146 2006-05-11 Jim Meyering <jim@meyering.net>
148 mv -T DIR EMPTY_DIR no longer fails unconditionally
149 * src/copy.c (copy_internal): Don't manually prohibit a move where
150 the destination is an existing directory. Sometimes doing that is
151 valid. Let the rename system call enforce the rules. That is
152 allowed only when the source is a directory and the destination
153 directory (to be replaced) is empty. Reported by Eric Blake.
154 * tests/mv/no-target-dir: New file/test for this.
155 * tests/mv/Makefile.am (TESTS): Add no-target-dir.
156 * NEWS: Mention this.
158 * tests/mv/atomic: New file/test for yesterday's fix.
159 * tests/mv/Makefile.am (TESTS): Add atomic.
161 * tests/du/long-sloop: Avoid harmless `ambiguous redirect' diagnostic.
163 2006-05-10 Jim Meyering <jim@meyering.net>
165 * src/copy.c (copy_internal): Don't explicitly unlink the destination
166 when moving a symlink into the place of an existing non-directory.
167 Reported by Joshua Hudson.
168 * NEWS: mention this.
170 2006-05-07 Jim Meyering <jim@meyering.net>
172 * Makefile.maint (patch-check): Fail if patch generates any output,
173 even merely for changed offsets.
175 * src/c99-to-c89.diff: Adjust to reflect new offsets.
177 * NEWS: Mention changes affecting df, pwd, shred.
179 2006-05-06 Jim Meyering <jim@meyering.net>
181 * tests/ls/stat-vs-dirent: New test, to detect the bogus file
182 system condition where dirent.d_ino != stat.st_ino.
183 * tests/ls/Makefile.am (TESTS): Add stat-vs-dirent.
185 2006-05-06 Eric Blake <ebb9@byu.net>
187 * tests/ls/inode: Expand to test inode from readdir case.
188 * tests/ls/follow-slink: Expand to test broken links encountered
189 implicitly, favoring Solaris 9 and OpenBSD 3.4 behavior.
191 2006-05-06 Eric Blake <ebb9@byu.net>
193 * tests/mv/leak-fd: Work even on case-insensitive file system.
195 2006-05-04 Jim Meyering <jim@meyering.net>
197 * NEWS: Mention the 2006-03-19 pwd-related change that makes
198 lib/getcwd.c work around inconsistent file system dirent.d_ino data.
200 2006-05-03 Jim Meyering <jim@meyering.net>
202 * src/ls.c (DEFINE_SORT_FUNCTIONS, LIST_SORTFUNCTION_VARIANTS):
203 Use better macro parameter names: s/basename/key_name/,
204 s/basefunc/key_cmp_func. Fix typo in comment.
206 2006-04-29 Eric Blake <ebb9@byu.net>
208 * src/ls.c (main): On systems with d_type, directories_first only
209 implies format_needs_type, not format_needs_stat.
211 2006-05-03 Jim Meyering <jim@meyering.net>
213 * src/ls.c (xstrcoll_df_version, rev_xstrcoll_df_version): Add space
214 after comma in arg list, from Eric Blake.
216 2006-04-25 Paul Eggert <eggert@cs.ucla.edu>
218 * tests/misc/date (relative-3): New test, derived from a bug
219 report by John Thomas McDole.
221 2006-04-23 Francesco Montorsi <fr_m@hotmail.com>
223 New option for ls: --group-directories-first.
224 It makes ls list directories before files.
225 * NEWS [New features]: Mention it.
226 * src/ls.c (sort_type): Rearrange to use as an array index when
227 choosing sort function; added new sort_numtypes member for
229 (time_type): Add new time_numtypes member for compile-time check.
230 (directories_first): New global variable.
231 (GROUP_DIRECTORIES_FIRST_OPTION): New enum.
232 (long_options): Add --directories-first.
233 (main): Support new option.
234 (is_directory): New function.
235 (extract_dirs_from_files): Use it.
236 (DIRFIRST_CHECK, DEFINE_SORT_FUNCTIONS)
237 (LIST_SORTFUNCTION_VARIANTS): New macros.
238 (sort_functions): New global variable.
239 (sort_files): Use it.
240 (usage): Document new option.
242 2006-04-18 Paul Eggert <eggert@cs.ucla.edu>
244 * src/shred.c (fillrand): The assertion was way too weak, due to
245 what must be a typo. Strengthen it to its intended value.
246 (dopass): Don't use alloca; it's not worth the aggravation here,
247 since it's used only to get a page-aligned buffer, and page
248 alignment doesn't buy us much here. I'm suspicious that alloca
249 causes problems on some hosts, due to a recent bug report by Adam
250 Waltman: http://bugs.gentoo.org/130246.
252 2006-04-18 Jim Meyering <jim@meyering.net>
254 * tests/misc/tty-eof: Add new programs, base64, sha224sum, sha256sum,
255 sha384sum, sha512sum.
257 2006-04-17 Paul Eggert <eggert@cs.ucla.edu>
259 * src/chmod.c (describe_change): Adjust to filemode changes.
260 * src/ls.c (HAVE_ST_DM_MODE): Remove; moved to ../lib/filemode.c.
261 (print_long_format): Use (new) filemodestring rather than
262 (old) mode_string, so that we get more file types right, at least
263 in theory. Adjust to filemode changes.
264 * src/stat.c (human_access): Likewise.
266 2006-04-18 Jim Meyering <jim@meyering.net>
268 * src/ptx.c (main) [DEFAULT_IGNORE_FILE]: Remove code to use a default
269 ignore file. This has never been enabled. Reported by Eric Blake.
271 2006-04-12 Paul Eggert <eggert@cs.ucla.edu>
273 * src/ln.c (linkfunc): Remove. This method ran into a compiler/linker
274 bug in Interix. Just call symlink or link directly. All uses changed.
275 * src/setuidgid.c (main) [! HAVE_SETGROUPS]: Don't call setgroups.
276 * src/stat.c (USE_STATVFS): New macro.
277 Include <sys/statvfs.h> and use statvfs only if USE_STATVFS.
278 (NAMEMAX_FORMAT): define a bit more clearly, now that the
279 statvfs-using code is a bit more regular.
280 * src/system.h (sync) [!HAVE_SYNC]: New macro.
282 2006-04-11 Paul Eggert <eggert@cs.ucla.edu>
284 * NEWS: csplit, nl, expr now conform to POSIX better, and are
285 more-compatible with traditional Unix, with respect to regular
287 * src/csplit.c (extract_regexp): Set re_syntax_options to a
288 value that is compatible with what POSIX requires.
289 * src/nl.c (build_type_arg): Likewise.
290 * src/expr.c (docolon): Likewise. Also, don't let anchors match
291 newline; this fixes an incompatibility with tradition and with POSIX.
292 Don't warn about leading ^. POSIX says it is unspecified whether
293 ^ is a special character, which means that implementations can
294 either treat it as special or not, but either way a warning is not
295 allowed (unless the regexp is otherwise invalid). Instead, anchor
296 the expression but treat ^ as an anchor; this is the traditional
297 behavior (e.g., Solaris 10).
298 (eval4, eval3, eval2): Treat non-numeric args, division by zero,
299 and the like as invalid expressions (exit status 2), not as
300 failure of 'expr' (exit status 3). This is more consistent with
302 * tests/expr/basic (fail-a): Adjust exit status to match new expr
303 behavior, for status 2 versus 3.
305 (bre1, bre2, bre3, bre4, bre5, bre6, bre7, bre8, bre9, bre10):
306 (bre11, bre12, bre13, bre14, bre15, bre16, bre17, bre18, bre19, bre20):
307 (bre21, bre22, bre23, bre24, bre25, bre26, bre27, bre28, bre29, bre30):
308 (bre31, bre32, bre33, bre34, bre35, bre36, bre37, bre38, bre39, bre40):
309 (bre41, bre42, bre43, bre44, bre45, bre46, bre47, bre48, bre49, bre50):
310 (bre51, bre52, bre53, bre54, bre55, bre56, bre57, bre58, bre59, bre60):
311 (bre61, bre62): New tests.
312 * tests/misc/csplit: Use \{...\} in test RE, to test that we're
316 * tests/du/long-from-unreachable: Solaris 8 sh doesn't understand
317 "if !". Do not assume that 'sed' can handle long, newline-free input.
318 * tests/du/long-sloop: Likewise. Evaluate expr once, not $n times.
320 2006-04-10 Paul Eggert <eggert@cs.ucla.edu>
322 Adjust to new regex.h API (with new fastmap type), and clean
323 up the regex storage allocation a bit.
325 * src/csplit.c (struct control): Put re_compiled member at the
326 end, since it's large. Change regexpr member from char * to bool;
327 all uses changed. Add new member fastmap.
328 (extract_regexp): regexp arg is now char const *, not char *.
329 Don't bother duplicating the regular expression; it's not needed.
330 Set fastmap from new fastmap member. Don't bother allocating
331 a buffer, as the regexp code does a better job than we do.
332 * src/expr.c (docolon): Allocate and use a fastmap.
333 Don't bother allocating a buffer.
334 * src/nl.c (body_fastmap, header_fastmap, footer_fastmap):
336 (build_type_arg): New fastmap arg. All uses changed.
337 Don't bother allocating a buffer, but set a fastmap.
338 * src/ptx.c (context_regex_string, word_regex_string): Remove.
339 (context_regex, word_regex): New vars, replacing the above.
341 (struct regex_data): New type.
342 (compile_regex): Renamed from alloc_and_compile_regex, since
343 we no longer allocate storage. Arg is now a struct regex_data *,
344 not a const char *. All uses changed. Don't allocate the fastmap;
345 instead, take it from the caller. Don't convert size_t to int,
346 to avoid arithmetic overflow problems. Don't bother freeing
347 storage afterwards; it's not worth the aggravation.
348 * src/tac.c (compiled_separator_fastmap): New ver.
349 (main): Use it. Don't bother allocating a buffer.
351 2006-03-30 Jim Meyering <jim@meyering.net>
353 * src/dd.c (iwrite): Remove assignment without effect.
354 Reported by Felix Rauch Valenti.
356 2006-03-22 Eric Blake <ebb9@byu.net>
358 * src/ptx.c (usage): Remove mention of --copyright/-C.
359 (main): Alias --copyright to --version plus a deprecation warning.
360 * NEWS: Mention this.
362 2006-03-27 Jim Meyering <jim@meyering.net>
364 * src/Makefile.am (uptime_LDADD): Add $(POW_LIB), for uptime's
365 use of strtod. Tiny patch from Nickolai Zeldovich.
367 2006-03-11 Eric Blake <ebb9@byu.net>
369 * tests/misc/dirname: New file.
370 * tests/basename/Makefile.am: Delete.
371 * tests/basename/basic: Move to...
372 * tests/misc/basename: ... this new file. Add some tests,
373 including fixed behavior for //.
374 * tests/misc/Makefile.am (TESTS): Sort. Add basename, dirname.
375 * tests/Makefile.am (SUBDIRS): Remove basename.
376 * configure.ac (AC_CONFIG_FILES): Remove tests/basename.
378 Improvements to dirname/basename handling on platforms like
379 cygwin with distinct // and with drive letters.
380 * NEWS: Document new behavior.
381 * src/basename.c (main): Don't strip suffix from file system
383 * src/cp.c (target_directory_operand): Use new last_component.
384 (ASSIGN_BASENAME_STRDUPA): Likewise. Reduce time spent
385 traversing the string.
386 * src/dircolors.c (guess_shell_syntax): Use new last_component.
387 * src/install.c (target_directory_operand, install_file_in_dir):
389 * src/ln.c (target_directory_operand, main): Likewise.
390 * src/ls.c (basename_is_dot_or_dotdot): Likewise.
391 * src/mv.c (target_directory_operand, movefile): Likewise.
392 * src/remove.c (rm_1): Likewise.
393 * src/shred.c (wipename): Likewise.
394 * src/split.c (next_file_name): Likewise.
395 * src/su.c (log_su, run_shell): Likewise.
397 2006-03-23 Paul Eggert <eggert@cs.ucla.edu>
399 * NEWS: nohup diagnostics are now more precise, and nohup now
400 redirects stderr to nohup.out if stdout is closed and stderr is a tty.
401 * src/nohup.c (main): Implement this.
402 * tests/misc/nohup: Test the new behavior.
404 2006-03-12 Jim Meyering <jim@meyering.net>
406 * src/copy.c (set_author): Rename function, from preserve_author.
408 * src/remove.c (AD_pop_and_chdir): Use new macro,
409 CYCLE_CHECK_REFLECT_CHDIR_UP, rather than open-coding it.
411 * src/system.h (SAME_INODE): Remove definition.
412 Include "same-inode.h", instead.
414 2006-03-11 Eric Blake <ebb9@byu.net>
416 * src/pwd.c (robust_getcwd): Prepend only one slash, not two.
418 2006-03-10 Jim Meyering <jim@meyering.net>
420 Fix a bug whereby a user with write access to a directory being removed
421 could cause the removal of that directory to fail with an erroneous
422 diagnostic about a directory cycle. Reported by Vineet Chadha.
424 * NEWS: Mention this.
425 * src/remove.c (AD_pop_and_chdir): If the directory we're about to
426 leave (and try to rmdir) is the one whose dev_ino is being used to
427 detect a cycle, reset cycle_check_state.dev_ino to that of the parent.
429 2006-03-08 Paul Eggert <eggert@cs.ucla.edu>
431 * NEWS: Document dd's new 'directory' and 'nolinks' flags.
432 * src/dd.c (set_fd_flags): Handle file-creation flags on file
433 descriptors, rather than ignoring them.
434 * tests/dd/misc: Add test cases for append, nofollow, directory,
435 and nolinks flags. Simplify redirection to /dev/null in some cases.
437 * tests/dd/misc: iflags->iflag. This fixes a typo that meant the
438 noatime test never tested anything.
440 2006-03-05 Paul Eggert <eggert@cs.ucla.edu>
442 * src/dd.c (flags, usage): New flags directory, nolinks.
443 * src/system.h (O_NOLINKS): Define to 0 if not already defined.
445 * src/ls.c (usage): Mention that -f disables --color.
446 Problem reported by Niels Möller.
448 2006-03-03 Justin Pryzby <pryzbyj@justinpryzby.com>
450 * man/*.x: Add references to syscalls from utilities of the same name.
452 2006-03-05 Jim Meyering <jim@meyering.net>
454 * tests/help-version: Set SHELL, if not already set, in order to
455 avoid failure when `make check' is run through debuild; dircolors
456 would fail due to lack of $SHELL. Reported by Sven Joachim.
458 Make `base64 --wrap=N' work for N=0, and for N larger than SIZE_MAX.
459 * src/base64.c (wrap_write, do_encode, main): Change type of
460 parameters and locals, wrap_column, form size_t to uintmax_t.
461 (main): Adjust to use xstrtoumax, accordingly.
463 2006-03-03 Jim Meyering <jim@meyering.net>
465 Don't fail when run from an environment with SHELL not a Bourne
466 shell, e.g. `env SHELL=/bin/csh make check' would fail this test.
467 * tests/dircolors/simple: Invoke each non-failing test with -b.
468 Reported by Michael Stone.
470 2006-02-27 Jim Meyering <jim@meyering.net>
472 * tests/misc/base64: Derive --decode-using tests from the
475 * tests/misc/base64: Factor out a long constant string.
476 Split lines to stay within 80 columns.
478 * tests/misc/Makefile.am (TESTS): Add base64.
479 * tests/misc/base64: Test base64. From Simon Josefsson.
481 * src/base64.c (do_decode): Use correct type for parameter,
482 ignore_garbage: s/size_t/bool/.
484 * src/base64.c: Don't include .h files already included by system.h:
485 <string.h>, <stdlib.h>, <stdbool.h>, <limits.h>, <errno.h>.
486 Include "system.h" before the other lib/*.h header files.
487 Include <sys/types.h> before "system.h".
488 (wrap_write): Remove declaration of unused local, initial_column.
489 (wrap_write): Correct declaration syntax: s/size_t * V/size_t *V/.
491 * README: Add base64 to the list.
493 2006-02-17 Simon Josefsson <jas@extundo.com>
496 * AUTHORS: Mention base64.
498 * man/Makefile.am: Build base64.1.
499 * man/base64.x: New file.
500 * src/Makefile.am (bin_PROGRAMS): Add base64.
501 * src/base64.c: New file.
503 2006-02-25 Eric Blake <ebb9@byu.net>
505 In ls, avoid calling stat for --inode (-i), when possible.
506 * src/pwd.c (NOT_AN_INODE_NUMBER, D_INO): Move to ...
507 * src/system.h: ... here, for use in ...
508 * src/ls.c (main): ... here. Prefer dirent.d_ino to stat when
510 (gobble_file): Add inode argument.
511 (print_dir): Pass inode if available.
512 (usage): Remove inaccuracy.
514 2006-02-23 Jim Meyering <jim@meyering.net>
516 * TODO: Update/correct some obsolete entries.
518 2006-02-20 Paul Eggert <eggert@cs.ucla.edu>
520 * doc/coreutils.texi (join invocation): Mention `sort -k 1b,1'.
521 * src/join.c (usage): Likewise.
522 Documentation problem reported by Philip Kensche.
524 2006-02-20 Eric Blake <ebb9@byu.net>
526 * man/rm.x: Update documentation to match previous patch.
528 2006-02-18 Eric Blake <ebb9@byu.net>
530 New option for rm: --interactive=once (-I).
531 * NEWS: Document it, along with change to rm --interactive.
532 * TODO: Remove entry for implementing rm -I
533 * src/rm.c (INTERACTIVE_OPTION): New enum value.
534 (interactive_type): New enum.
535 (long_opts): Let interactive take an optional argument.
536 (interactive_args, interactive_types): New option arguments.
537 (usage): Document -I, --interactive=WHEN. Use program_name
538 instead of a basename.
539 (main): New -I option, new behavior to --interactive.
540 * tests/rm/interactive-once: New tests.
541 * tests/rm/interactive-always: Ditto.
542 * tests/rm/Makefile.am (TESTS): Run them.
544 2006-02-18 Jim Meyering <jim@meyering.net>
546 * Makefile.maint (sc_two_space_separator_in_usage): Make the regular
547 expression match more of the target lines, e.g., those that start with
548 `-S,' (short option followed by a comma) or that include `=[...]'.
549 Patch by Nicolas François.
550 Fix the four offenders thus exposed:
551 * src/join.c (usage): Use two spaces (not one) to separate the
552 --first-only option string from its description, so help2man formats
553 the derived man page properly.
554 * src/pr.c (usage): Likewise.
555 * src/uniq.c (usage): Likewise.
556 * src/install.c (usage): Likewise.
558 2006-02-15 Jim Meyering <jim@meyering.net>
560 * Makefile.maint (alpha beta major): For `make major', ensure that the
561 version string is of the form N.N[.N]*, where N is one or more digits.
563 2006-02-14 Jim Meyering <jim@meyering.net>
565 * INSTALL: Update from gnulib.
567 2006-02-13 Jim Meyering <jim@meyering.net>
569 * GNUmakefile (all): Emit diagnostics to stderr, not stdout.
571 2006-02-12 Jim Meyering <jim@meyering.net>
573 * Makefile.maint (patch-check): New target.
574 (local-checks-available): Add to the list.
576 2006-02-11 Jim Meyering <jim@meyering.net>
578 * src/c99-to-c89.diff: New file.
579 * src/Makefile.am (EXTRA_DIST): Add c99-to-c89.diff.
581 * .x-po-check: New file, with exclusions so that `make distcheck'
583 * Makefile.am (EXTRA_DIST): Add .x-po-check.
585 rm -r must remove an empty directory, even if it is inaccessible.
586 * src/remove.c (close_preserve_errno): New function.
587 (fd_to_subdirp): Don't print a diagnostic in this function.
588 Do it from the callers instead, unless rmdir succeeds.
589 (remove_cwd_entries, remove_dir): Adjust callers.
590 * tests/rm/empty-inacc: New test for the above.
591 * tests/rm/Makefile.am (TESTS): Add empty-inacc.
592 * NEWS: Mention this bug fix.
593 * tests/rm/rm2: Adjust two expected diagnostics, now that they're
594 a tiny bit less precise: cannot remove `a/1': ... instead of
595 cannot open directory `a/1': ...
597 * Makefile.maint (syntax-check-rules): Automatically derive this
598 list of sc_-prefixed rule names.
600 2006-02-10 Paul Eggert <eggert@cs.ucla.edu>
602 * Makefile.maint (CVS_LIST): Don't assume cvsu is available.
603 (CVS_LIST_EXCEPT): New macro, to simplify exception-processing.
604 Most uses of CVS_LIST changed to use CVS_LIST_EXCEPT.
605 (syntax-check-rules): Bring back sc_changelong. (Hmm, why did it
606 go away? was that an accident?)
607 (sc_cast_of_argument_to_free, sc_cast_of_x_alloc_return_value):
608 (sc_cast_of_alloca_return_value, sc_space_tab, sc_prohibit_atoi_atof):
609 (sc_error_exit_success, sc_file_system, sc_no_if_have_config_h):
610 (sc_system_h_headers, sc_sun_os_names, sc_trailing_blank):
611 (sc_two_space_separator_in_usage, sc_unmarked_diagnostics):
612 (sc_obsolete_symbols, sc_changelog, sc_prohibit_jm_in_m4):
613 (sc_useless_cpp_parens, makefile-check, m4-check, po-check):
614 (author_mark_check, makefile_path_separator_check):
615 Output line numbers, to simplify navigation of Emacs *compilation*
617 (sc_prohibit_atoi_atof, sc_file_system):
618 Rework slightly so that Makefile.maint doesn't get reported as a
619 violation of its own syntax rules.
620 (sc_dd_max_sym_length): Use ifneq to do nothing, instead of doing
621 it at run-time (which didn't work with Bison). Fix a makefile typo,
622 caught by Makefile.maint itself: spaces where a tab should be.
623 (po-check): Check lib/*.[ch] even if not in CVS; used by Bison,
624 which copies from ../gnulib/lib/*.[ch] to lib/*.[ch].
625 Ignore djgpp and man subdirectories, to avoid false matches with
626 Bison and coreutils, respectively. Use sort -u to remove the
627 resulting duplicates.
628 * gnupload: Rework slightly to avoid bogus warning from
629 sc_two_space_separator_in_usage.
631 2006-02-10 Jim Meyering <jim@meyering.net>
633 Use gzip's --rsyncable option only if it's available.
634 * Makefile.maint (gzip_rsyncable): New variable.
637 2006-02-08 Jim Meyering <jim@meyering.net>
639 * Makefile.maint (local-checks-available): Define in terms of
640 the expansion, $(syntax-check-rules), rather than the single,
641 top-level target `syntax-check', so that it's easier to exclude
642 individual rules (via $(local-checks-to-skip)).
643 (tgz-md5, tgz-sha1, ...): Remove now-unused definitions.
645 2006-02-07 Jim Meyering <jim@meyering.net>
647 * src/system.h (!defined O_DIRECT): If O_DIRECTIO is defined (as it
648 is on Tru64), define O_DIRECT to that. Patch From James Lemley.
650 * tests/help-version (expected_failure_status_vdir):
651 Redirect an expected disk-full diagnostic to /dev/null.
653 2006-02-06 Jim Meyering <jim@meyering.net>
655 * src/unexpand.c (usage): Use two spaces (not one) to separate the
656 --first-only option string from its description, so help2man formats
657 the derived man page properly.
658 * src/rm.c (usage): Likewise for --no-preserve-root.
659 * src/chown.c (usage): Likewise.
660 * src/chgrp.c (usage): Likewise.
662 Add a rule to ensure that the above doesn't happen again.
663 * Makefile.maint (sc_two_space_separator_in_usage): New rule.
664 (syntax-check-rules): Add it.
665 * .x-sc_two_space_separator_in_usage: New empty file.
666 * Makefile.am (EXTRA_DIST): Add .x-sc_two_space_separator_in_usage.
668 2006-02-06 Jim Meyering <jim@meyering.net>
670 * src/cp.c (usage): Use two spaces (not one) to separate each
671 option string from its description, so help2man formats the
672 derived man page properly.
673 * src/mv.c (usage): Likewise.
674 Patch from Nicolas François in http://bugs.debian.org/351601.
676 2006-02-04 Jim Meyering <jim@meyering.net>
678 * src/copy.c (copy_internal): cp -RL would fail when encountering
679 the same directory more than once in the hierarchy beneath a single
680 command-line argument. That is legitimate, e.g. when there are
681 two or more symbolic links, each pointing to some directory that
682 would not otherwise be copied. Reported by Christophe LYON.
683 * tests/cp/cp-deref: New file. Test for today's fix.
684 * tests/cp/Makefile.am (TESTS): Add cp-deref.
685 * NEWS: Document this.
687 2006-02-03 Jim Meyering <jim@meyering.net>
689 * configure.ac: Require automake-1.9.6, not 1.8.3.
691 2006-02-01 Paul Eggert <eggert@cs.ucla.edu>
693 * src/od.c (usage): Mention that -t a ignores high order bit.
694 Documentation problem reported by Ed Avis.
696 2006-02-01 Jim Meyering <jim@meyering.net>
698 * src/pwd.c (find_dir_entry): Remove unused local, `ent_sb_valid'.
700 2006-01-30 Paul Eggert <eggert@cs.ucla.edu>
702 * src/head.c (main): Use a better diagnostic when someone uses a
703 trailing numeric option in an invalid way. Problem reported by
705 * src/tail.c (parse_options): Likewise.
707 2006-01-30 Jim Meyering <jim@meyering.net>
709 * man/wc.x: Include `count' keyword in man page synopsis,
710 per suggestion from http://bugs.debian.org/181585.
712 2006-01-24 Paul Eggert <eggert@cs.ucla.edu>
714 * src/df.c (show_dev): If the file system claims to have
715 more available than total blocks, report the number of used
716 blocks as being total - available (a negative number) rather
717 than as garbage. Problem reported by Toralf Foerster.
719 2006-01-24 Jim Meyering <jim@meyering.net>
721 * src/tail.c (tail_forever): Don't exit-nonzero when an attempt
722 to put a regular file in O_NONBLOCK mode fails with EPERM.
723 That happens on Linux (up to 2.6.15) when using tail -f on a file with
724 the append-only attribute. Reported by Dean Gaudet. For details,
725 see http://savannah.gnu.org/bugs/?func=detailitem&item_id=15473.
726 * NEWS: Mention this fix.
727 * tests/tail-2/append-only: New file. Test for the above.
728 * tests/tail-2/Makefile.am (TESTS): Add append-only.
729 * tests/Makefile.am (check-root): Add tail-2/append-only
731 2006-01-21 Jim Meyering <jim@meyering.net>
733 * NEWS: Mention fts-related improvements and bug fixes.
735 2006-01-19 Jim Meyering <jim@meyering.net>
737 * tests/fmt/basic (pfx-1, pfx-2): New tests, to demonstrate the bug
738 reported as http://bugs.debian.org/147577. Forwarded by Thomas Hood.
740 2006-01-18 Jim Meyering <jim@meyering.net>
742 * tests/du/Makefile.am (TESTS): Add long-from-unreadable.
744 2006-01-17 Jim Meyering <jim@meyering.net>
746 Now that fts no longer changes the current working directory, adjust
747 its clients accordingly -- note that du.c uses fts but doesn't need
748 any adjustment, since it doesn't operate on the actual files,
749 but rather just uses the stat buffers provided by fts.
751 * src/chown-core.c: Include "openat.h".
752 Don't include "lchown.h".
753 (restricted_chown): Accept a new parameter, CWD_FD, and use it in
754 calling openat, lchownat, chownat, rather than open, lchown, chown.
756 * src/chmod.c: Include "openat.h".
757 (process_file): Use chmodat (fts->fts_cwd_fd,... in place of chmod (...
759 * tests/du/long-from-unreadable: New test, to exercise one small
762 2006-01-13 Jim Meyering <jim@meyering.net>
764 * tests/Makefile.am (SUBDIRS): Add comments discouraging the
765 addition of new directories under tests/.
767 * tests/acl: Redirect stdin to /dev/null. Otherwise, FreeBSD 5.0's
770 2006-01-12 Jim Meyering <jim@meyering.net>
772 * tests/du/long-sloop: Adjust not to hard-code the expected
773 diagnostic corresponding to ELOOP. Solaris' diagnostic differs
774 from that of GNU libc. Reported by Paul Eggert.
776 * tests/du/long-sloop: Create file at end of symlink chain.
778 * tests/misc/test: New file, with a test for one of the
779 bugs fixed by yesterday's test.c changes.
780 * tests/misc/Makefile.am (TESTS): Add test.
782 2006-01-11 Jim Meyering <jim@meyering.net>
784 * tests/du/long-sloop: New file. Test for today's fts.c bug fix.
785 That bug could make du -L, chgrp -L, or chown -L fail to diagnose
786 a very long sequence of symbolic links (not necessarily a loop).
787 * tests/du/Makefile.am (TESTS): Add long-sloop.
789 2006-01-11 Paul Eggert <eggert@cs.ucla.edu>
791 * src/test.c (test_syntax_error): Append a newline. All callers
792 changed, except for the ones that didn't already append a newline.
793 Bug reported by Eric Blake.
795 2006-01-11 Jim Meyering <jim@meyering.net>
797 * src/system.h (X2NREALLOC): Now that verify_true is no longer
798 void, cast its result to void, to avoid gcc's warning that
799 ``left-hand operand of comma expression has no effect''.
800 (DECIMAL_DIGIT_ACCUMULATE, X2REALLOC): Likewise.
802 2006-01-10 Jim Meyering <jim@meyering.net>
804 * tests/chmod/no-x: Add a test for today's fts.c fix.
806 2006-01-10 Jim Meyering <jim@meyering.net> (tiny change)
808 * src/ls.c (gobble_file): Use DTTOIF only if it's defined.
809 This is necessary for Dragonfly. Patch by Joerg Sonnenberger.
811 2006-01-10 Paul Eggert <eggert@cs.ucla.edu>
813 * src/system.h (X2NREALLOC, X2REALLOC, DECIMAL_DIGIT_ACCUMULATE):
814 Use verify_true instead of verify_expr, to sync with gnulib.
816 2006-01-08 Jim Meyering <jim@meyering.net>
818 * src/date.c (usage): Adjust the formatting of the entries for
819 %::z and %:::z (separate with two spaces, not one) so that help2man
820 formats them properly. Reported by Philip Rowlands.
822 2006-01-06 Paul Eggert <eggert@cs.ucla.edu>
824 * configure.ac (gl_IGNORE_UNUSED_LIBRARIES): Add.
826 2006-01-06 Jim Meyering <jim@meyering.net>
828 * Makefile.maint (copyright-check): Use date +%Y in place of
831 * src/remove.c (rm_1): Remove `static' attribute on local `status'.
832 First off, the attribute should have been `volatile' (not static)
833 to avoid longjmp-related risk of clobber. Secondly, now there is
834 no longer any risk of a local variable being clobbered, so there's
835 no need for any attribute at all.
837 2006-01-05 Jim Meyering <jim@meyering.net>
839 * src/remove.c: Give a few functions the inline attribute.
840 (AD_pop_and_chdir): Use gotos to avoid some duplication.
841 (AD_push): Rewrite an assertion so that the entire computation
842 goes away when assertions are turned off.
844 * src/tail.c (ENOSYS) [!defined ENOSYS]: Don't define here.
845 It's already defined in "system.h".
846 * Makefile.maint: Add a FIXME comment.
848 2006-01-04 Jim Meyering <jim@meyering.net>
850 * ChangeLog: Remove entries from 2005-10-22 and earlier.
851 * ChangeLog-2005: New file, for entries up to version 5.92.
853 2006-01-03 Jim Meyering <jim@meyering.net>
855 * tests/du/no-x: Also allow a slightly different diagnostic -- the
856 one you get when using openat-enabled fts.c and du (coming soon).
857 * tests/chmod/no-x: Likewise.
858 * tests/chgrp/no-x: Likewise.
860 * src/system.h (O_DIRECTORY) [!defined O_DIRECTORY]: Define.
862 2006-01-02 Paul Eggert <eggert@cs.ucla.edu>
864 * src/chown-core.c (RC_do_ordinary_chown): New enum value.
865 (restricted_chown): Return it, if the file cannot be accessed due
866 to EPERM, or if no uid or gid are required, or if the file is
867 neither a directory nor a regular file. Rewrite to avoid gotos.
868 (change_file_owner): Handle RC_do_ordinary_chown case.
869 Rewrite to avoid gotos.
870 * tests/chgrp/basic: Make sure we can change the group of
873 * src/date.c (usage): Explain %g, %G, and %V a bit better.
875 2006-01-02 Jim Meyering <jim@meyering.net>
877 * src/copy.c (set_owner): Correct a comment.
879 * src/tail.c (parse_options): Change warning to say that --retry
880 is useful `mainly' (not `only') when following by name.
881 Reported here: http://bugs.debian.org/273781
883 2006-01-01 Paul Eggert <eggert@cs.ucla.edu>
885 * NEWS: Document that mkfifo and mknod -m no longer set special bits.
886 * src/copy.c: Include lchmod.h.
887 (copy_internal): Use lchmod rather than chmod.
888 * src/cp.c: Include lchmod.h.
889 (re_protect, make_dir_parents_private): Use lchmod rather than chmod.
890 * src/mkdir.c: Include lchmod.h.
891 (usage): Clarify -m's operation.
892 (main): Use lchmod rather than chmod. Don't use lchmod unless the
893 new mode contains bits outside the 777 range.
894 * src/mkfifo.c (usage): Clarify -m's operation.
895 (main): If -m is given, don't invoke chmod; use umask 0 instead.
896 Report an error if -m asks for bits outside the 777 range.
897 * src/mknod.c (usage, main): Likewise.
899 * src/mkdir.c, src/mkfifo.c, src/mknod.c: Undo 2005-12-19 changes.
901 2005-12-27 Jim Meyering <jim@meyering.net>
903 * Makefile.maint (sc_obsolete_symbols): Prohibit use of O_NDELAY.
904 (sc_prohibit_assert_without_use): New rule.
905 (syntax-check-rules): Add it to the list.
906 * .x-sc_prohibit_assert_without_use: New empty file.
907 * Makefile.am (EXTRA_DIST): Add it.
909 * Makefile.maint (CVS_LIST): Define in terms of $(srcdir).
911 * cp.c, df.c, link.c, mknod.c, nice.c, sleep.c, unlink.c:
912 Don't include <assert.h>; it wasn't used.
914 2005-12-26 Paul Eggert <eggert@cs.ucla.edu>
916 * src/chown-core.c (restricted_chown):
917 Don't try O_WRONLY unless O_RDONLY failed wth EACCES.
918 * src/remove.c (fd_to_subdirp): Open with O_DIRECTORY | O_NOCTTY
919 | O_NOFOLLOW too, for consistency with other dir-openers.
920 Use POSIX-preferred O_NONBLOCK rather than O_NDELAY.
921 (is_empty_dir): Likewise.
922 * src/shred.c (wipename): Likewise. Don't bother trying to open
923 dir for writing, since POSIX prohibits it.
925 2005-12-22 Jim Meyering <jim@meyering.net>
927 * tests/help-version: Redirect stderr to /dev/full, to suppress
928 write error diagnostic.
930 2005-12-19 Jim Meyering <jim@meyering.net>
932 * src/mkdir.c, src/mknod.c, src/mkfifo.c (main)
933 Avoid a minor race condition when `-m MODE' is specified, by using
934 open, fchown, and close rather than just chown. To do that reliably --
935 even with an overly restrictive umask -- ensure that each mkdir,
936 mknod and mkfifo call uses a mode including at least owner-read access.
937 * src/mknod.c (main): When `-m MODE' is specified, exit nonzero if
938 the subsequent chown (or equivalent open,fchown,close) fails.
939 * tests/misc/mknod: New tests.
940 * tests/misc/Makefile.am (TESTS): Add mknod.
942 2005-12-17 Jim Meyering <jim@meyering.net>
944 * src/remove.c (is_empty_dir): Open with O_NDELAY, so we don't hang,
945 e.g., on a named pipe.
946 (OPEN_NO_FOLLOW_SYMLINK): Remove definition. Use O_NOFOLLOW in
947 place of all uses, since it is guaranteed (system.h) to be defined.
949 2005-12-05 Andreas Gruenbacher <agruen@suse.de>
951 Add POSIX ACL support
952 * src/ls.c: Switch back from HAVE_ACL to USE_ACL: The acl() syscall
953 is no requirement for ACL support; particularly, it does not exist
954 on systems that have POSIX ACLs.
955 * src/copy.h (cp_option_init) [umask_kill]: Remove member.
956 * src/cp.c (umask_kill): With default acls, the umask is not to be
957 applied. Remove umask_kill, don't change the process umask, and let
958 the kernel apply the umask where appropriate.
959 * src/cp.c (make_dir_parents_private): Fix logic for POSIX ACLs.
960 * src/copy.c (get_dest_mode): Remove; it is obsolete after removing
962 (copy_reg, copy_internal): Use copy_acl and set_acl
963 instead of fchown/chown. Fix the logic for POSIX ACLs.
964 (chown_succeded): Remove; we now always copy acls and
965 preserve S_ISUID, S_ISGID, and S_ISVTX when needed, no matter if we
966 did a chown before or not.
967 * src/mv.c, src/install.c (cp_option_init): Don't set umask_kill member.
968 * src/Makefile.am (dir_LDADD, ls_LDADD, vdir_LDADD, cp_LDADD,
969 mv_LDADD, ginstall_LDADD): On systems with an ACL library, arrange
970 to link with it via $(LIB_ACL), for the utilities that need it.
972 2005-12-16 Paul Eggert <eggert@cs.ucla.edu>
974 * src/remove.c (OPENAT_CWD_RESTORE__REQUIRE): Remove.
975 (OPENAT_CWD_RESTORE__ALLOW_FAILURE): Likewise.
976 (fd_to_subdirp): Remove openat_cwd_restore_allow_failure arg; its
977 value is now signified by whether cwd_errno is null.
978 (fd_to_subdirp, remove_dir, rm_1); Change cwd failure indicator from
979 pointer-to-bool to pointer-to-errno-value. All callers changed.
980 (rm_1): Don't bother setting a local cwd failure flag and then
981 ORing it into the caller's. Just set the caller's.
982 (rm): Use cwd failure errno value to print a slightly-better
985 2005-12-15 Jim Meyering <jim@meyering.net>
987 * src/stat.c (print_it): Properly handle a backslash at the
988 end of a --printf format string. Reported by Paul Eggert.
989 * tests/misc/stat-printf (end-bs): Add a test for the above.
991 2005-12-15 Paul Eggert <eggert@cs.ucla.edu>
993 * tests/acl: Port to pre-POSIX shells like Solaris 8 /bin/sh.
994 Don't assume /etc/passwd contains user names; use 'id' instead.
996 2005-12-15 Jim Meyering <jim@meyering.net>
998 stat: revert behavior of --format=FMT (-c)
999 stat: add new option: --printf=FMT
1000 * NEWS: Mention this.
1001 * src/stat.c (isodigit, octtobin, hextobin): Define.
1002 (PRINTF_OPTION): Define.
1003 (interpret_backslash_escapes, trailing_delim): New globals.
1004 (usage): Document them. Alphabetize on long option names.
1005 (print_esc_char): New function.
1006 (print_it): Rewrite, in order to handle backslash escapes.
1007 (main): Handle new option. Set globals for --format, too.
1009 * tests/misc/stat-printf: Test --printf and --format.
1010 * tests/misc/Makefile.am (TESTS): Add stat-printf.
1012 2005-12-14 Paul Eggert <eggert@cs.ucla.edu>
1014 * NEWS: sort now reports incompatible options.
1015 * src/sort.c (incompatible_options, check_ordering_compatibility):
1017 (main): Use them. Don't bother with a usage message for
1018 "sort -c a b", for consistency with other error diagnostics.
1019 * tests/sort/Test.pm (incompat1, incompat2, incompat3, incompat4):
1022 * src/cat.c (main): Undo previous change. close_stdout already
1023 does the check, so the previous change wasn't necessary.
1025 2005-12-13 Paul Eggert <eggert@cs.ucla.edu>
1027 * src/cat.c (main): Check for close (STDOUT_FILENO) failure.
1029 2005-12-12 Paul Eggert <eggert@cs.ucla.edu>
1031 Install a more-conservative approach for sort -R. It's the
1032 same basic idea as the existing code, except it uses the full ISAAC
1033 approach (called the "more kosher" approach in the existing comments).
1034 This makes "sort -R" quite a bit slower (about a factor of 2 on my
1035 little tests involving 10000 lines on a 2.4 GHz P4), but I think it's
1036 better to be conservative here at first, and review any performance
1037 improvements carefully.
1038 * .x-sc_require_config_h: Add src/rand-isaac.c.
1039 * src/rand-isaac.h: Remove. All uses now simply include rand-isaac.c.
1040 * src/Makefile.am (noinst_HEADERS): Remove rand-isaac.h.
1041 (shred_SOURCES, sort_SOURCES): Remove.
1042 (EXTRA_DIST): Add rand-isaac.c.
1043 * src/rand-isaac.c: Revert to what used to be in shred.c, without
1044 changing it to allow for varying numbers of words in the state.
1045 Alter so that we include rand-isaac.c directly rather than
1046 compiling it and linking to it. Don't include config.h or
1047 system.h; that's the includer's responsibility.
1048 Omit functions that are specific to shred.
1049 (ISAAC_LOG, ISAAC_WORDS, ISAAC_BYTES, struct isaac_state, ind):
1050 (isaac_step, struct irand_state):
1051 Resurrect these, with the same defns that used to be in shred.c.
1052 (ISAAC_SIZE, isaac_new, isaac_copy): Remove.
1053 (isaac_refill, isaac_seed_start, isaac_seed_data, irand_init, irand32):
1055 (struct isaac_state, isaac_refill, isaac_mix, isaac_init):
1056 (isaac_seed_start, isaac_seed_data, isaac_seed_finish, isaac_seed):
1057 (irand_init, irand32, irand_mod):
1058 Number of words is constant again.
1059 (struct irand_state, irand_init, irand32, irand_mod): Move to shred.c.
1060 * src/shred.c: Include rand-isaac.c rather than rand-isaac.h.
1061 * src/sort.c: Likewise.
1062 * src/shred.c (fillrand, dopass, main): Undo previous change.
1063 (struct irand_state, irand_init, irand32, irand_mod): Moved back here,
1065 * src/sort.c: Don't include md5.h; it wasn't needed.
1066 (struct keyfield): Rename random_hash to random, for consistency
1067 with the other member names. All uses changed.
1068 (usage): Tweak wording to mention STRING for --seed option.
1069 (short_options): Rorder for consistency with other programs.
1070 (rand_state): Now a struct, not a pointer to one. All uses changed.
1071 (HASH_WORDS, HASH_SIZE): Remove.
1072 (get_hash): Remove comments around resbuf size, since we can assume C89.
1073 Use a "more-kosher" (but slower) approach of invoking isaac_refill.
1074 (keycompare): Adjust to the new get_hash.
1076 (badfieldspec): Omit recently-introduced comment; it isn't needed.
1077 (main): Don't set need_random simply because gkey has it set; that
1078 doesn't necessarily mean we'll need random numbers.
1079 Redo seeding to match new get_hash approach.
1081 2005-12-10 Jim Meyering <jim@meyering.net>
1083 * src/Makefile.am (noinst_HEADERS): Add rand-isaac.h.
1085 Avoid shred segfault on 64-bit systems.
1086 * src/rand-isaac.c (isaac_refill): Don't try to negate a
1087 local of type uint32_t. Make the local an `int' instead.
1089 * NEWS: Mention sort's new options.
1091 * src/rand-isaac.c (isaac_mix): Declare to be static.
1092 Mark all other functions as `extern' so the tight-scope
1093 part of `make distcheck' passes once again.
1094 * src/rand-isaac.h (isaac_mix): Remove declaration.
1096 * src/sort.c (get_hash): Change position of `*' in parameter
1097 type to conform with convention.
1098 (main): Split a long line so it fits in 80 columns.
1099 (keycompare): Remove stray SPACE before TAB that was
1100 causing `make distcheck' to fail.
1102 * src/shred.c: Don't include gethrxtime.h. No longer needed.
1104 * tests/misc/sort-rand: New file: basic tests for the new options.
1105 * tests/misc/Makefile.am (TESTS): Add sort-rand.
1107 2005-12-10 Frederik Eaton <frederik@ofb.net>
1109 * src/Makefile.am (sort_LDADD): Add $(LIB_GETHRXTIME).
1110 (shred_SOURCES, sort_SOURCES): New macros, so we compile rand-isaac.c.
1111 * src/rand-isaac.c: New file, containing ISAAC code that was in shred.c.
1112 Make state size runtime-configurable.
1113 (isaac_new, isaac_copy): New functions.
1114 * src/rand-isaac.h: New file.
1115 * src/shred.c: Include rand-isaac.h. Move ISAAC code to rand-isaac.c.
1116 (fillrand, main): Adjust to the fact that the state size is now
1117 runtime-configurable.
1118 * src/sort.c (short_options, long_options, WORDS, keycompare, main):
1119 (usage): Add options --random-sort and --seed to implement a random
1121 Include md5.h and rand-isaac.h.
1122 (get_hash): New function.
1123 (rand_state): New var.
1124 (HASH_WORDS, HASH_SIZE): New macros.
1126 2005-12-09 Paul Eggert <eggert@cs.ucla.edu>
1128 * tests/dd/misc: Add test for dd iflags=noatime.
1130 2005-12-09 Jim Meyering <jim@meyering.net>
1132 * src/sort.c (usage): Mention white space vs -b and -t options.
1135 2005-12-09 Eric Blake <ebb9@byu.net>
1137 * src/test.c (main): Fix misleading comment.
1139 2005-12-07 Paul Eggert <eggert@cs.ucla.edu>
1141 * NEWS: Mention dd's new noatime flag.
1142 * src/system.h (O_NOATIME): Define to 0 if not already defined.
1143 * src/dd.c (flags, usage): Add support for noatime flag.
1145 2005-12-07 Jim Meyering <jim@meyering.net>
1147 Distribute the cvsu script, used only by `make syntax-check'.
1148 * Makefile.am (EXTRA_DIST): Add build-aux/cvsu.
1149 * Makefile.maint (CVS_LIST): Use build-aux/cvsu, now that we
1150 distribute a copy of this script.
1151 * .x-sc_unmarked_diagnostics: Add build-aux/cvsu.
1153 * tests/mv/acl: exit-77 before the trap, not after, if we fail
1154 to create a temporary directory on another partition.
1155 From Andreas Gruenbacher.
1157 2005-12-06 Tomas Pospisek <tpo@sourcepole.ch> (tiny change)
1159 * man/basename.x: Cross-reference to dirname and readlink.
1160 * man/dirname.x: Cross-reference to basename and readlink.
1162 2005-12-05 Andreas Gruenbacher
1164 * src/copy.c [!HAVE_FCHOWN]: Define fchown(...) to -1.
1165 (set_owner, preserve_author): New functions, factored out of copy_reg.
1166 (copy_reg): Use them.
1167 (copy_internal): Use them here, too.
1169 2005-12-04 Jim Meyering <jim@meyering.net>
1171 * src/sleep.c (usage): Say what happens with two or more arguments.
1172 Suggested by Justin Pryzby.
1174 * src/uptime.c (print_uptime): Move decl of `upsecs' into scope
1177 2005-12-03 Jim Meyering <jim@meyering.net>
1179 * src/rm.c (long_opts): Change the name of each undocumented, for-
1180 testing-only option to start with `-', so that it cannot render
1181 ambiguous any prefix it happens to share with some other option name.
1182 Problem reported by Eric Blake.
1183 * src/head.c (long_options): Likewise.
1184 * src/tail.c (long_options): Likewise.
1186 * tests/misc/head-elide-tail: Update uses of undocumented, for-
1187 testing-only --presume* options to start with `---'.
1188 * tests/rm/dangling-symlink: Likewise.
1189 * tests/rm/dir-no-w: Likewise.
1190 * tests/rm/isatty: Likewise.
1192 2005-11-30 Jim Meyering <jim@meyering.net>
1194 * Makefile.maint: Add a comment about cvsu.
1196 2005-11-25 Paul Eggert <eggert@cs.ucla.edu>
1198 * NEWS: df updates for "none", "proc", inaccessible file systems.
1199 * src/df.c (show_point): Ignore inaccessible file systems.
1200 (usage): -a includes dummy file systems, not size-0 file systems.
1202 * src/od.c (unsigned_long_long_int): Renamed from ulonglong_t,
1203 to avoid collision with POSIX name space. All uses changed.
1205 2005-11-24 Jim Meyering <jim@meyering.net>
1207 * tests/Makefile.am (EXTRA_DIST): Add acl to the list.
1208 * tests/acl: Add `$0: ' prefix to diagnostics.
1210 * .x-sc_require_config_h: Add lib/buffer-lcm.c to the list.
1212 2005-11-23 Paul Eggert <eggert@cs.ucla.edu>
1214 * src/copy.c: Improve performance a bit by optimizing away
1215 unnecessary system calls and going to a block size of at least
1216 8192 (on normal hosts, anyway). This improved performance 5% on my
1217 Debian stable host (2.4.27 kernel, x86, copying from root
1218 ext3 file system to itself).
1219 Include "buffer-lcm.h".
1220 (copy_reg): Omit last argument. All callers changed.
1221 Use xmalloc to allocate rather than trusting alloca
1222 (which is unwise with large block sizes).
1223 Declare locals more locally, if possible.
1224 Use uintptr_t words instead of int words, for a bit more speed
1225 when looking for null blocks on 64-bit hosts.
1226 Optimize away reads of zero bytes on regular files.
1227 In the typical case, insist on 8 KiB buffers, at least.
1228 Avoid unnecessary extra call to fstat when checking for sparse files.
1229 Avoid now-unnecessary cast to off_t, and "0L".
1230 Avoid unnecessary test of *new_dst when checking for same owner
1233 2005-11-22 Paul Eggert <eggert@cs.ucla.edu>
1235 * src/remove.c (rm): Don't assume C99 for-loop syntax.
1237 2005-11-22 Jim Meyering <jim@meyering.net>
1239 * src/remove.c (AD_push): Remove debugging cruft.
1241 * tests/rm/unread2 (rm): Change expected diagnostic,
1242 `cannot open directory' to `cannot remove', to align with
1244 * tests/rm/rm2: Ensure that rm now continues removing entries
1245 even after certain types of failure.
1247 * src/remove.c: Rewrite. Now, this module is reentrant on systems
1248 that provide openat (Solaris), and on systems like Linux+procfs
1249 where our openat emulation code is reentrant. This also fixes a
1250 few low-probability leaks and eliminates some code that could,
1251 in very unusual circumstances, cause rm() (via a callee) to exit.
1252 * NEWS: Mention this.
1254 * configure.ac: Put copyright dates all on one line so the
1255 emacs function that updates them works properly.
1257 2005-11-18 Paul Eggert <eggert@cs.ucla.edu>
1259 * configure.ac (AM_PROG_CC_C_O): Add. Needed for CVS Automake.
1260 Problem reported by Eric Blake.
1261 (AC_PROG_CC_STDC): Use this instead of AC_PROG_CC, so that
1262 we get a standard-conforming compiler. This relies on the new
1263 m4/c.m4 file. Note that it's a bit tricky, since c.m4 doesn't
1264 define AC_PROG_CC_STDC; we are relying on Autoconf 2.59 internals.
1265 m4/c.m4 can go away with Autoconf 2.60 comes out.
1267 2005-11-17 Jim Meyering <jim@meyering.net>
1269 * src/remove.c (AD_mark_helper): Make a `char *' parameter `const'.
1270 (AD_mark_current_as_unremovable): Likewise, but for a local.
1273 * tests/mv/acl: Let traps handle removing temporary directories.
1275 Expect acl-related tests to fail, until the corresponding
1276 patches are committed.
1277 * tests/mv/Makefile.am (XFAIL_TESTS): Add acl.
1278 * tests/cp/Makefile.am (XFAIL_TESTS): Likewise.
1280 ACL tests, from Andreas Gruenbacher.
1281 * tests/acl, tests/mv/acl, tests/cp/acl: New files.
1282 * tests/mv/Makefile.am (TESTS): Add acl.
1283 * tests/cp/Makefile.am (TESTS): Add acl.
1285 * src/ls.c (basename_is_dot_or_dotdot): Correct wording in comment.
1287 2005-11-16 Paul Eggert <eggert@cs.ucla.edu>
1289 * NEWS: Improve quality of ln's diagnostics.
1290 * src/ln.c (do_link, usage): Likewise.
1291 (do_link): Don't use alloca on a buffer of unbounded size.
1293 2005-11-16 Jim Meyering <jim@meyering.net>
1295 * tests/cp/fail-perm: Accommodate HPUX. It appears to fail
1296 with EACCES rather than EPERM. Reported by Peter O'Gorman here:
1297 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/5766
1298 This also affects AIX 4.3.3, according to Ralf Wildenhues, in
1299 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
1301 2005-11-14 Jim Meyering <jim@meyering.net>
1303 * NEWS (sort): Mention consequences of today's mkstemp-safer.c fix.
1305 2005-11-13 Jim Meyering <jim@meyering.net>
1307 * announce-gen: Accept new option, --gpg-key-id=ID and
1308 emit a blurb telling how to use the .sig files.
1309 * Makefile.cfg (gpg_key_ID): Define.
1310 * Makefile.maint (announcement): Use new option and key.
1312 Require that most .c files include <config.h>.
1313 * Makefile.maint (sc_require_config_h): New rule.
1314 (syntax-check-rules): Add it.
1315 * .x-sc_require_config_h: New file listing exceptions to the
1316 above rule. Some are legit, others are simply grandfathered in.
1317 * Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h here, too.
1319 2005-11-12 Jim Meyering <jim@meyering.net>
1321 * src/checksum.h, src/md5.c, src/sha1sum.c: Remove now-unused files.
1323 2005-11-11 Jim Meyering <jim@meyering.net>
1325 * NEWS: Mention `readlink -f' bug fix in 5.3.0 news.
1326 Mention new readlink options in 5.3.0's `New features' section.
1327 Spotted by Thomas Hood.
1329 2005-11-08 Jim Meyering <jim@meyering.net>
1331 * NEWS: Merge in changes from b5_9x branch.
1333 2005-11-08 Paul Eggert <eggert@cs.ucla.edu>
1335 * NEWS: ls now defaults to --time-style='locale', which in turn acts
1336 like --time-style='posix-long-iso' if the locale settings are messed up.
1337 * src/ls.c (decode_switches): Implement this.
1339 2005-11-08 Jim Meyering <jim@meyering.net>
1341 * tests/du/2g: s/expensive/very expensive/ in a comment.
1344 2005-10-17 Eric Blake <ebb9@byu.net>
1346 * src/ls.c (usage): Fix descriptions of --sort, --time.
1347 Reported by Vitaly A. Ostanin.
1349 2005-11-04 Paul Eggert <eggert@cs.ucla.edu>
1351 * src/ln.c: Include filenamecat.c.
1352 (FILE_BASENAME_CONCAT): Remove.
1353 (do_link): Remove last arg DEST_IS_DIR. All callers changed.
1354 (main): Use file_name_concat, base_name, and strip_trailing_slashes
1355 instead of FILE_BASENAME_CONCAT. This simplifies the code, and avoids
1358 2005-11-04 Jim Meyering <jim@meyering.net>
1360 * src/du.c (process_file): Don't overflow for files of size >= 2^31
1361 on systems with stat.st_blocks of a signed 32-bit type.
1362 This bug causes trouble on some AIX 5.1 systems.
1363 Report and trivial patch from Paul Townsend:
1364 <http://lists.gnu.org/archive/html/bug-coreutils/2005-11/msg00033.html>
1365 * NEWS: Mention this.
1367 * tests/du/2g: New (very-expensive) test for the above-fixed bug.
1368 * tests/du/Makefile.am (TESTS): Add it here.
1369 * tests/very-expensive: New file.
1370 * tests/Makefile.am (EXTRA_DIST): Add it here.
1371 * tests/cp/perm: Mark this test as `very-expensive', too.
1373 2005-11-02 Paul Eggert <eggert@cs.ucla.edu>
1375 * NEWS: Mention that rm -d and maybe ln -d are scheduled for
1377 * src/remove.h (struct rm_options): Remove unlink_dirs. All uses
1379 * src/rm.c (usage): Don't mention rm -d.
1381 2005-11-02 Jim Meyering <jim@meyering.net>
1383 * tests/dd/skip-seek: Fix typo in comment: s/fileutils/coreutils.
1384 From Andreas Schwab.
1386 * tests/dd/unblock-sync: Redirect stderr to /dev/null so the
1387 `M+N records in/out' lines don't pollute `make check' output.
1389 * tests/dd/skip-seek (sk-seek4): New test, to exercise the bug
1390 fixed on 2005-10-31. This test uses the new, IN_PIPE specifier.
1391 * tests/Coreutils.pm: Accept a new type of input specifier: IN_PIPE,
1392 to indicate that the input file should be piped into the command
1393 under test (via `cat FILE | $prog ...').
1395 * src/remove.c (remove_entry): Emit a better diagnostic when rm
1396 (without -r) fails to remove a directory on a non-Linux system.
1397 This change affects only newer Solaris systems (with priv_*
1398 functions like priv_allocset). Reported by Keith Thompson.
1400 * tests/rm/dir-nonrecur: New file/test for the above fix.
1401 * tests/rm/Makefile.am (TESTS): Add dir-nonrecur.
1403 2005-11-01 Paul Eggert <eggert@cs.ucla.edu>
1405 * NEWS: "tail -c 2 FILE" and "touch 0101000000" now operate as
1406 POSIX 1002.1-2001 requires.
1407 * src/tail.c (parse_obsolete_option): Implement this.
1408 Problem reported by Vincent Lefevre.
1409 * src/touch.c (main): Pass PDS_PRE_2000 to posixtime.
1410 * tests/tail/Test.pm (c-2, c-2-minus, c2, c2-minus): New tests.
1411 (test_vector): Add special cases for _POSIX2_VERSION, and
1412 regularize the old ones a bit.
1413 * tests/touch/obsolescent: Add y2000 test.
1415 2005-10-31 Paul Eggert <eggert@cs.ucla.edu>
1417 * src/dd.c (skip): Fix off-by-one error reported by
1418 Theodoros V. Kalamatianos.
1420 2005-10-30 Paul Eggert <eggert@cs.ucla.edu>
1422 * tests/mkdir/p-3: Require that the test be run as non-root.
1423 Problem and trivial fix reported by Theodoros V. Kalamatianos.
1425 2005-10-28 Paul Eggert <eggert@cs.ucla.edu>
1427 * src/ln.c (FILE_BASENAME_CONCAT): Omit unnecessary slashes in the
1428 boundary between DEST and SOURCE in the result.
1430 2005-10-26 Dmitry V. Levin <ldv@altlinux.org>
1432 * src/md5sum.c (main) [!O_BINARY]: Changed default read mode
1433 back to text, to sync with documentation and for backwards
1436 2005-10-25 Jim Meyering <jim@meyering.net>
1438 * tests/dircolors/simple (other-wr): Add an explicit test for
1439 the dircolors bug (NULL-dereference) fixed yesterday.
1441 2005-10-24 Jim Meyering <jim@meyering.net>
1443 * src/tac.c (tac_file): When determining whether a file is seekable,
1444 also test whether it is a tty. Using only the lseek-based test would
1445 give a false positive on Solaris. Reported by Peter Fales.
1447 2005-10-24 Dmitry V. Levin <ldv@altlinux.org>
1449 * tests/install/d-slashdot: New test, for "install -d" failure.
1450 * tests/install/Makefile.am (TESTS): Add d-slashdot.
1451 * tests/mkdir/p-slashdot: New test, for "mkdir -p" failure.
1452 * tests/mkdir/Makefile.am (TESTS): Add p-slashdot.
1454 2005-10-24 Jim Meyering <jim@meyering.net>
1456 * src/dircolors.c (ls_codes): Add missing comma.
1457 Anonymous report and patch from
1458 http://savannah.gnu.org/bugs/?func=detailitem&item_id=14849
1460 * src/dircolors.c: Add compile-time assertion that the slack_codes
1461 and ls_codes arrays have the same number of elements. This would
1462 have prevented the above-fixed bug.
1464 * src/expand.c (parse_tab_stops): Add a comment to make this function
1465 identical to the one in unexpand.c.
1466 * src/unexpand.c (parse_tab_stops): Adjust syntax to make this function
1467 identical to the one in expand.c.
1469 * src/expand.c (next_file): Don't assume fopen cannot return stdin.
1471 2005-10-23 Jim Meyering <jim@meyering.net>
1473 * src/md5sum.c (digest_check, main): Use ptr_align rather than
1474 a dangerous pointer-value-to-`unsigned' cast.
1475 * NEWS: mention the new sha* programs.
1476 * AUTHORS: Add new sha* programs.
1478 2005-08-28 David Madore <david.madore@ens.fr>
1480 Add new programs: sha224sum, sha256sum, sha384sum, sha512sum.
1481 * README: Add their names to the list.
1482 * src/md5sum.c: Provide framework for computing sha-2 hashes.
1483 * src/Makefile.am (sha224sum, sha256sum, sha384sum, sha512sum):
1484 Rules for compiling sha-2 utilities
1485 (noinst_HEADERS): Remove checksum.h.
1486 * man/sha512sum.x, man/sha384sum.x, man/sha256sum.x, man/sha224sum.x:
1488 * man/Makefile.am (dist_man_MANS): Add the corresponding .1 names.
1489 (sha224sum.1, sha256sum.1, sha384sum.1, sha512sum.1): New dependencies.
1490 * tests/misc/sha224sum, tests/misc/sha256sum: New files.
1491 * tests/misc/sha384sum, tests/misc/sha512sum: New files.
1492 * tests/misc/Makefile.am (TESTS): Add new sha224sum, sha256sum,
1493 sha384sum, sha512sum test scripts here rather that each in its
1496 2005-08-28 David Madore <david.madore@ens.fr>
1498 * tests/sha1sum/basic-1 (million-a): Add the "million a's" test (one
1499 of the FIPS test vectors).
1501 2005-10-23 Jim Meyering <jim@meyering.net>
1503 * configure.ac: Use 6.0-cvs as the version string.
1504 * NEWS: Adjust accordingly.