1 2003-02-17 Anders Carlsson <andersca@codefactory.se>
3 * doc/dbus-specification.sgml:
6 2003-02-17 Anders Carlsson <andersca@codefactory.se>
8 * bus/activation.c: (bus_activation_init), (child_setup),
9 (bus_activation_activate_service):
12 Set DBUS_ADDRESS environment variable.
14 * dbus/dbus-errors.c: (dbus_set_error):
15 Don't use va_copy since that's a C99 feature.
17 * dbus/dbus-sysdeps.c: (_dbus_setenv), (do_exec),
19 * dbus/dbus-sysdeps.h:
20 Add child_setup_func to _dbus_spawn_async.
22 * doc/dbus-specification.sgml:
25 * test/spawn-test.c: (setup_func), (main):
28 2003-02-17 Alexander Larsson <alexl@redhat.com>
30 * dbus/dbus-connection.c (_dbus_connection_handler_destroyed_locked):
33 2003-02-17 Anders Carlsson <andersca@codefactory.se>
37 * doc/dbus-test-plan.sgml:
38 Add test plan document.
43 2003-02-17 Anders Carlsson <andersca@codefactory.se>
45 * dbus/dbus-message.c: (decode_header_data),
46 (_dbus_message_loader_return_buffer):
47 Set the header padding amount when loading a message.
49 2003-02-16 Anders Carlsson <andersca@codefactory.se>
51 * bus/dispatch.c: (send_one_message):
52 Only send broadcast messages to registered connections.
54 * dbus/dbus-message.c: (dbus_message_name_is):
55 * dbus/dbus-message.h:
56 New convenience function.
58 * dbus/dbus-transport-debug.c: (do_reading):
59 Only dispatch one message per run.
62 * test/bus-test.c: (new_connection_callback), (die),
63 (test_hello_client1_handler), (test_hello_client2_handler),
64 (test_hello_replies), (main):
66 * test/bus-test-loop.[ch]:
69 2003-02-16 Havoc Pennington <hp@pobox.com>
71 * dbus/dbus-connection.c (dbus_connection_dispatch_message): fix
74 2003-02-16 Alexander Larsson <alexl@redhat.com>
76 * dbus/dbus-connection.c:
77 Implement sent_message_with_reply. (with_reply_and block is still
79 Made dispatch_message not lose message if OOM.
82 Add NoReply error (for reply timeouts).
84 2003-02-16 Alexander Larsson <alexl@redhat.com>
86 * dbus/dbus-hash.c (_dbus_hash_table_unref):
87 Actually free keys and values when destroying hashtable.
89 2003-02-16 Anders Carlsson <andersca@codefactory.se>
91 * dbus/dbus-auth.c: (client_try_next_mechanism):
94 * dbus/dbus-threads.c: (dbus_condvar_wait_timeout):
95 Return TRUE if there's no thread implementation around.
97 * glib/dbus-gmain.c: (free_source),
98 (dbus_connection_hookup_with_g_main):
99 Make sure to remove the GSource when the connection is finalized.
101 2003-02-16 Anders Carlsson <andersca@codefactory.se>
103 * bus/dispatch.c: (bus_dispatch_message_handler):
104 * dbus/dbus-errors.h:
105 Return an error if someone tries to send a message to a service
108 2003-02-16 Anders Carlsson <andersca@codefactory.se>
110 * bus/activation.c: (load_directory), (bus_activation_init),
111 (bus_activation_activate_service):
114 (bus_driver_handle_activate_service), (bus_driver_handle_message):
115 More work on the activation handling.
117 * dbus/dbus-errors.h:
118 Add some error messages
120 * dbus/dbus-message.c: (dbus_message_new_error_reply):
121 * dbus/dbus-message.h:
122 New function that creates an error message.
124 * dbus/dbus-protocol.h:
125 Add ACTIVATE_SERVER message.
127 * dbus/dbus-server-unix.c: (unix_handle_watch),
128 (_dbus_server_new_for_domain_socket):
129 Call _dbus_fd_set_close_on_exec.
131 * dbus/dbus-sysdeps.c: (make_pipe), (do_exec),
132 (_dbus_spawn_async), (_dbus_disable_sigpipe),
133 (_dbus_fd_set_close_on_exec):
134 * dbus/dbus-sysdeps.h:
135 Add _dbus_fd_set_close_on exec function. Also add function that checks
136 that all open fds are set to close-on-exec and warns otherwise.
138 * dbus/dbus-transport-unix.c:
139 (_dbus_transport_new_for_domain_socket):
140 Call _dbus_fd_set_close_on_exec.
142 2003-02-16 Havoc Pennington <hp@pobox.com>
144 * dbus/dbus-connection.c (dbus_connection_set_change_sigpipe):
145 allow people to avoid setting SIGPIPE to SIG_IGN
146 (_dbus_connection_new_for_transport): disable SIGPIPE unless
147 we've been asked not to
149 2003-02-15 Anders Carlsson <andersca@codefactory.se>
151 * dbus/dbus-list.c: (_dbus_list_append_link),
152 (_dbus_list_prepend_link):
153 * dbus/dbus-memory.c: (dbus_malloc), (dbus_malloc0),
157 2003-02-15 Anders Carlsson <andersca@codefactory.se>
160 * bus/activation.c: (bus_activation_entry_free),
161 (add_desktop_file_entry), (load_directory), (bus_activation_init):
163 * bus/main.c: (main):
164 Add simple activation support, doesn't work yet though.
166 2003-02-15 Zack Rusin <zack@kde.org>
168 * qt/dbus-qthread.cpp: small casting fix
170 2003-02-15 Anders Carlsson <andersca@codefactory.se>
172 * dbus/dbus-errors.c: (dbus_set_error):
173 * dbus/dbus-errors.h:
174 Add a few errors and make dbus_set_error void.
176 * dbus/dbus-sysdeps.c:
177 (_dbus_errno_to_string), (close_and_invalidate), (make_pipe),
178 (write_err_and_exit), (read_ints), (do_exec), (_dbus_spawn_async):
179 * dbus/dbus-sysdeps.h:
180 Add _dbus_spawn_async.
182 * test/spawn-test.c: (main):
183 Test for _dbus_spawn_async.
185 2003-02-15 Anders Carlsson <andersca@codefactory.se>
187 * dbus/dbus-internals.h:
188 Fix build without tests.
190 * dbus/dbus-list.c: (alloc_link):
191 Fix a segfault when a malloc fails.
193 * dbus/dbus-memory.c: (initialize_malloc_debug), (dbus_malloc),
194 (dbus_malloc0), (dbus_realloc):
195 Add support for malloc debugging.
197 2003-02-15 Alexander Larsson <alexl@redhat.com>
199 * dbus/dbus-threads.c:
200 * dbus/dbus-threads.h:
201 Add condvars. Remove static mutext from API.
202 Implement static mutexes by initializing them from threads_init.
204 * glib/dbus-gthread.c:
205 * qt/dbus-qthread.cpp:
206 Update with the thread api changes.
211 Turn StaticMutex into normal mutex + init function.
212 Export new functions _dbus_list_alloc_link, _dbus_list_free_link,
213 _dbus_list_append_link, _dbus_list_prepend_link
216 * dbus/dbus-sysdeps.c:
217 * dbus/dbus-sysdeps.h:
218 New type dbus_atomic_t, and new functions _dbus_atomic_inc,
219 _dbus_atomic_dec. Only slow fallback implementation at the moment.
221 * dbus/dbus-protocol.h:
222 Add DBUS_MESSAGE_LOCAL_DISCONNECT define
224 * dbus/dbus-message.c:
225 Make ref/unref atomic.
228 * dbus/dbus-connection-internal.h:
229 * dbus/dbus-connection.c:
230 * dbus/dbus-connection.h:
232 Change _peek to _borrow,_return & _steal_borrowed.
233 Change disconnect callback to event.
234 Make dbus_connection_dispatch_messages reentrant.
236 * dbus/dbus-transport.c:
237 Don't ref the connection on calls to the transport
240 * dbus/dbus-message-handler.c:
244 Don't use peek_message anymore
247 * test/debug-thread.c:
248 * test/debug-thread.h:
249 Simple thread implementation that asserts() on deadlocks in
250 single-threaded code.
253 (main) Call debug_threads_init.
256 Use disconnect message instead of disconnect callback.
260 Don't call dbus_connection_set_disconnect_function. Instead export
261 bus_connection_disconnect.
264 Call bus_connection_disconnect when we get a disconnected message.
266 2003-02-15 Havoc Pennington <hp@pobox.com>
268 * dbus/dbus-message.c (dbus_message_new): fool around with the
271 2003-02-14 Havoc Pennington <hp@pobox.com>
273 * dbus/dbus-mempool.c: fail if the debug functions so indicate
275 * dbus/dbus-memory.c: fail if the debug functions indicate we
278 * dbus/dbus-internals.c (_dbus_set_fail_alloc_counter)
279 (_dbus_decrement_fail_alloc_counter): debug functions to
280 simulate memory allocation failures
282 2003-02-14 Havoc Pennington <hp@pobox.com>
284 * dbus/dbus-errors.h (struct DBusError): add a word of padding
287 2003-02-13 Anders Carlsson <andersca@codefactory.se>
289 * bus/driver.c: (bus_driver_handle_hello):
291 * bus/services.c: (bus_service_lookup):
292 Reorder message sending so we get a more sane order.
294 * test/bus-test.c: (message_handler):
297 2003-02-13 Anders Carlsson <andersca@codefactory.se>
299 * bus/driver.c: (bus_driver_send_service_deleted),
300 (bus_driver_send_service_created), (bus_driver_send_service_lost),
301 (bus_driver_send_service_acquired), (bus_driver_handle_hello),
302 (bus_driver_send_welcome_message),
303 (bus_driver_handle_list_services),
304 (bus_driver_handle_acquire_service),
305 (bus_driver_handle_service_exists):
306 * dbus/dbus-bus.c: (dbus_bus_register_client),
307 (dbus_bus_acquire_service), (dbus_bus_service_exists):
308 * dbus/dbus-errors.c: (dbus_result_to_string):
309 * dbus/dbus-errors.h:
310 * dbus/dbus-message.c: (dbus_message_append_args),
311 (dbus_message_append_args_valist), (dbus_message_get_args),
312 (dbus_message_get_args_valist), (dbus_message_get_args_iter),
313 (dbus_message_iter_get_arg_type), (dbus_message_iter_get_string),
314 (dbus_message_iter_get_byte_array),
315 (dbus_message_iter_get_string_array), (message_iter_test),
316 (check_message_handling), (_dbus_message_test):
317 * dbus/dbus-message.h:
318 * test/bus-test.c: (main):
319 Change fields to arguments in messages, so that they won't be
320 confused with header fields.
322 * glib/test-dbus-glib.c: (main):
323 Remove append_fields from hello message.
325 2003-02-13 Anders Carlsson <andersca@codefactory.se>
327 * dbus/dbus-errors.c:
328 * dbus/dbus-message.c:
329 * dbus/dbus-string.c:
332 2003-02-13 Anders Carlsson <andersca@codefactory.se>
334 * glib/dbus-gmain.c: (timeout_handler), (add_timeout),
336 Implement support for timeouts in dbus-glib.
338 2003-02-13 Anders Carlsson <andersca@codefactory.se>
340 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
341 * dbus/dbus-message.c: (process_test_subdir):
342 * test/break-loader.c: (find_breaks_based_on):
343 Plug some memory leaks.
345 2003-02-13 Richard Hult <rhult@codefactory.se>
347 * bus/main.c: Fix build.
349 * dbus/dbus-errors.h:
350 * dbus/dbus-errors.c: Fix copyright for Anders.
352 2003-02-13 Anders Carlsson <andersca@codefactory.se>
357 * bus/connection.c: (bus_connection_foreach):
360 * bus/desktop-file.c: (grow_lines_in_section), (grow_sections),
361 (unescape_string), (new_section), (parse_section_start),
362 (parse_key_value), (report_error), (bus_desktop_file_load),
363 (bus_desktop_file_get_string):
364 * bus/desktop-file.h:
365 Use DBusError for error reporting.
367 * bus/dispatch.c: (send_one_message),
368 (bus_dispatch_message_handler):
369 * bus/driver.c: (bus_driver_send_service_deleted),
370 (bus_driver_send_service_created), (bus_driver_send_service_lost),
371 (bus_driver_send_service_acquired), (bus_driver_handle_hello),
372 (bus_driver_send_welcome_message),
373 (bus_driver_handle_list_services),
374 (bus_driver_handle_acquire_service),
375 (bus_driver_handle_service_exists):
376 * bus/loop.c: (bus_loop_run):
378 Use BUS_HANDLE_OOM instead of _DBUS_HANDLE_OOM.
380 * bus/utils.c: (bus_wait_for_memory):
382 New files with general utility functions.
384 * dbus/dbus-internals.h:
385 Remove _DBUS_HANDLE_OOM.
387 2003-02-13 Anders Carlsson <andersca@codefactory.se>
389 * dbus/dbus-errors.c: (dbus_result_to_string), (dbus_error_init),
390 (dbus_error_free), (dbus_set_error_const), (dbus_set_error):
391 * dbus/dbus-errors.h:
392 Add DBusError structure.
394 2003-02-13 Anders Carlsson <andersca@codefactory.se>
396 * test/data/valid-messages/standard-acquire-service.message:
397 * test/data/valid-messages/standard-hello.message:
398 * test/data/valid-messages/standard-list-services.message:
399 * test/data/valid-messages/standard-service-exists.message:
400 Add some standard messages.
402 2003-02-13 Anders Carlsson <andersca@codefactory.se>
404 * bus/driver.c: (bus_driver_send_welcome_message),
405 (bus_driver_handle_list_services),
406 (bus_driver_handle_acquire_service),
407 (bus_driver_handle_service_exists), (bus_driver_handle_message):
408 Update for API changes in libdbus.
410 * dbus/dbus-message.c: (dbus_message_new_reply):
411 * dbus/dbus-message.h:
412 Remove the name argument. The spec states that replies shouldn't
415 2003-02-13 Anders Carlsson <andersca@codefactory.se>
417 * bus/desktop-file.c: (parse_section_start), (parse_key_value),
418 (report_error), (bus_desktop_file_load), (lookup_section),
419 (lookup_line), (bus_desktop_file_get_raw),
420 (bus_desktop_file_get_string):
421 * bus/desktop-file.h:
422 Some fixes, and new functions for getting a key value from a section.
424 2003-02-13 Havoc Pennington <hp@pobox.com>
426 * test/data/auth/fail-after-n-attempts.auth-script: new test
428 * dbus/dbus-auth.c (send_rejected): shutdown_mech() when we
431 2003-02-13 Havoc Pennington <hp@pobox.com>
433 * dbus/dbus-auth.c (handle_server_data_external_mech): args to
434 dbus_credentials_match were backward
436 * dbus/dbus-auth-script.c (_dbus_auth_script_run): support
437 NO_CREDENTIALS and ROOT_CREDENTIALS
439 * dbus/dbus-auth.c (_dbus_auth_do_work): move get_state() routine
440 into here. Never process more commands after we've reached an
441 end state; store further data as unused bytes.
443 * test/data/auth/*: add more auth tests
445 * dbus/dbus-auth-script.c (_dbus_auth_script_run): support EXPECT
446 command to match exact string and EXPECT_UNUSED to match unused
449 * test/Makefile.am (dist-hook): fix to dist all the test stuff
451 2003-02-12 Havoc Pennington <hp@pobox.com>
453 * dbus/dbus-string.c (_dbus_string_pop_line): fix to also strip
454 \r off of popped lines
456 * dbus/dbus-auth.c (_dbus_auth_test): write code to run auth
459 * dbus/dbus-auth-script.c (_dbus_auth_script_run): when doing a
462 2003-02-12 Havoc Pennington <hp@pobox.com>
464 * dbus/Makefile.am: remove break-loader from the build, since it
467 * configure.in: add --enable-gcov to turn on coverage profiling
468 flags and disable optimization
470 2003-02-10 Havoc Pennington <hp@pobox.com>
472 * dbus/dbus-auth-script.c, dbus/dbus-auth-script.h: sync
473 initial cut at test framework for DBusAuth from laptop.
474 Doesn't quite work yet but it compiles and I need to get
475 it off the 266mhz laptop. ;-)
477 * dbus/dbus-server-debug.c (_dbus_server_debug_accept_transport):
478 fix a memleak in error case
480 2003-02-12 Anders Carlsson <andersca@codefactory.se>
483 * bus/desktop-file.c:
484 * bus/desktop-file.h:
485 Add a desktop file parser.
487 2003-02-11 Zack Rusin <zack@kde.org>
489 * qt/message.[h|cpp]: sample implementation
490 of the KDE wrapper for DBusMessage
492 2003-02-09 Zack Rusin <zack@kde.org>
494 * test/bus-test.c: make_it_compile
495 * doc/dbus-specification.sgml: minimal semantic fix
497 2003-02-06 Anders Carlsson <andersca@codefactory.se>
503 2003-02-06 Anders Carlsson <andersca@codefactory.se>
506 * dbus/dbus-break-loader.c:
508 * test/break-loader.c:
509 Move dbus-break-loader to test/ and rename it to break-loader.
511 2003-02-02 Havoc Pennington <hp@pobox.com>
513 * dbus/dbus-keyring.c, dbus/dbus-keyring.h: template files
514 for code to manage cookies in your home directory
516 * dbus/dbus-sysdeps.c (_dbus_generate_random_bytes): new function
518 * dbus/dbus-auth.c (get_state): impose a maximum number of tries
519 to authenticate, then disconnect the client.
521 2003-02-03 Alexander Larsson <alexl@redhat.com>
523 * dbus/dbus-message.c (dbus_message_append_fields):
526 2003-02-02 Anders Carlsson <andersca@codefactory.se>
528 * doc/dbus-specification.sgml:
529 Update address format section.
531 2003-02-02 Anders Carlsson <andersca@codefactory.se>
534 * test/bus-test.c: (get_time), (add_timeout), (remove_timeout),
535 (message_handler), (new_connection_callback), (loop_quit),
539 2003-02-02 Anders Carlsson <andersca@codefactory.se>
541 * bus/driver.c: (bus_driver_handle_service_exists):
542 Simplify the code a bit.
544 * dbus/dbus-bus.c: (dbus_bus_service_exists):
547 2003-02-02 Anders Carlsson <andersca@codefactory.se>
550 Add libdbus-daemon.la and link to it.
552 2003-02-01 James Willcox <jwillcox@gnome.org>
554 * bus/driver.c: (bus_driver_handle_own_service):
555 Actually include the service reply code in the message.
557 2003-02-02 Anders Carlsson <andersca@codefactory.se>
559 * bus/driver.c: (bus_driver_handle_service_exists):
560 Don't unref the incoming message.
562 2003-02-02 Anders Carlsson <andersca@codefactory.se>
564 * dbus/dbus.h: Add dbus-address.h and dbus-bus.h
566 2003-02-02 Anders Carlsson <andersca@codefactory.se>
568 * dbus/dbus-server.c: (dbus_server_listen):
569 * dbus/dbus-transport.c: (_dbus_transport_open):
570 ifdef out the calls to the debug transport and server.
572 2003-02-02 Alexander Larsson <alexl@redhat.com>
574 * dbus/dbus-watch.c (dbus_watch_get_flags):
575 Add note in the docs that ERROR or HANGUP won't be returned
576 and are assumed always on.
578 * glib/dbus-gmain.c (add_watch):
579 Always add IO_ERR | IO_HUP
581 * dbus/dbus-message.h:
582 Add semicolon after dbus_message_iter_get_string_array().
583 Makes qt code build again
585 2003-02-01 Anders Carlsson <andersca@codefactory.se>
587 * bus/driver.c: (create_unique_client_name),
588 (bus_driver_handle_hello):
589 Don't take a name, just use a numeric id to identify
593 * dbus/dbus-bus.c: (dbus_bus_register_client),
594 (dbus_bus_acquire_service), (dbus_bus_service_exists):
596 Add new convenience functions for communicating with the bus.
598 * dbus/dbus-message.h:
600 * dbus/dbus-protocol.h:
603 2003-02-01 Alexander Larsson <alexl@redhat.com>
605 * dbus/dbus-message.c (dbus_message_append_fields):
606 Add some more doc comments.
608 2003-02-01 Havoc Pennington <hp@pobox.com>
610 * dbus/dbus-break-loader.c (randomly_modify_length): change
611 a 4-byte value in the message as if it were a length
613 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): don't set
614 execute bit on saved files
616 2003-02-01 Havoc Pennington <hp@pobox.com>
618 * dbus/dbus-break-loader.c (main): new program to find messages
619 that break the loader.
621 * dbus/dbus-sysdeps.c (_dbus_string_append_uint): new function
622 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): new function
624 * dbus/dbus-string.c (_dbus_string_set_byte): new
626 2003-01-31 Havoc Pennington <hp@pobox.com>
628 * dbus/dbus-message.c: refactor the test code to be more general,
629 in preparation for writing a "randomly permute test cases to
630 try to break the loader" program.
632 2003-01-31 Havoc Pennington <hp@pobox.com>
634 * doc/dbus-specification.sgml: work on the specification
636 * dbus/dbus-message.c (_dbus_message_loader_return_buffer): check
637 the protocol version of the message.
639 * dbus/dbus-protocol.h: drop special _REPLY names, the spec
640 no longer specifies that.
641 (DBUS_SERVICE_REPLY_SERVICE_EXISTS): fix flags (1/2/4/8 not
644 * dbus/dbus-marshal.c (_dbus_marshal_get_arg_end_pos): add missing
645 "break" for DBUS_TYPE_NIL, remove @todo
647 2003-01-31 Havoc Pennington <hp@pobox.com>
649 * dbus/dbus-message.c (dbus_message_set_is_error_reply): rename
650 just set_is_error/get_is_error as this is a commonly-used
651 function, and write docs.
653 2003-01-31 Anders Carlsson <andersca@codefactory.se>
655 * dbus/dbus-address.c: (dbus_address_entry_free):
656 Free key and value lists.
658 * dbus/dbus-internals.c: (_dbus_type_to_string):
659 Add the types we didn't have.
661 * dbus/dbus-marshal.c: (_dbus_marshal_get_arg_end_pos),
662 (_dbus_marshal_validate_arg):
665 * dbus/dbus-message.c: (dbus_message_set_sender):
666 Remove todo about being able to set sender to NULL.
668 (dbus_message_set_is_error_reply),
669 (dbus_message_get_is_error_reply):
670 * dbus/dbus-message.h:
673 * dbus/dbus-protocol.h:
674 Add error reply flag.
676 * test/data/valid-messages/opposite-endian.message:
677 Add NIL type to test.
679 2003-01-31 Havoc Pennington <hp@pobox.com>
681 * doc/dbus-specification.sgml: fully specify the header. Add
682 flags and major protocol version, and change header/body len to
685 * dbus/dbus-message-builder.c (append_saved_length): append length
688 * dbus/dbus-message.c (dbus_message_create_header): change header
689 length and body length to unsigned. Add the new fields from the
691 (_dbus_message_loader_return_buffer): unsigned header/body len
693 2003-01-30 Havoc Pennington <hp@pobox.com>
695 * dbus/dbus-auth.c: rework to use only REJECTED, no
698 * doc/dbus-sasl-profile.txt: drop MECHANISMS and just
699 use REJECTED, suggested by Mark McLoughlin
701 2003-01-30 Havoc Pennington <hp@pobox.com>
703 * dbus/dbus-server.c (dbus_server_listen): @todo about how we need
704 a better way to report errors here. e.g. "unix address lacks
705 path" or something. also "no such file" when the path doesn't
708 * dbus/dbus-address.c (dbus_address_entries_free): add @todo about
710 (dbus_parse_address): add @todo about documenting address format,
711 and allowing , and ; to be escaped
713 2003-01-30 Anders Carlsson <andersca@codefactory.se>
716 Add dbus-address.[ch]
718 * dbus/dbus-address.c: (dbus_address_entry_free),
719 (dbus_address_entries_free), (create_entry),
720 (dbus_address_entry_get_method), (dbus_address_entry_get_value),
721 (dbus_parse_address), (_dbus_address_test):
722 * dbus/dbus-address.h:
723 New files for dealing with address parsing.
725 * dbus/dbus-connection.c:
726 Document timeout functions.
728 * dbus/dbus-message.c:
729 Document dbus_message_new_from_message.
731 * dbus/dbus-server-debug.c:
734 * dbus/dbus-server.c: (dbus_server_listen):
735 Parse address and use correct server implementation.
737 * dbus/dbus-string.c: (_dbus_string_find_to), (_dbus_string_test):
738 * dbus/dbus-string.h:
739 New function with test.
741 * dbus/dbus-test.c: (dbus_internal_symbol_do_not_use_run_tests):
745 * dbus/dbus-transport-debug.c:
748 * dbus/dbus-transport.c: (_dbus_transport_open):
749 Parse address and use correct transport implementation.
751 2003-01-30 Havoc Pennington <hp@pobox.com>
753 * dbus/dbus-message.c: use message->byte_order instead of
754 DBUS_COMPILER_BYTE_ORDER throughout.
755 (dbus_message_create_header): pad header to align the
756 start of the body of the message to 8-byte boundary
758 * dbus/dbus-marshal.h: make all the demarshalers take const
759 DBusString arguments.
761 * dbus/dbus-message.c (_dbus_message_loader_return_buffer):
762 validate message args here, so we don't have to do slow validation
763 later, and so we catch bad messages as they are incoming. Also add
764 better checks on header_len and body_len. Also fill in
767 * dbus/dbus-string.c (_dbus_string_validate_utf8): new (not
768 implemented properly)
769 (_dbus_string_validate_nul): new function to check all-nul
771 * dbus/dbus-marshal.c (_dbus_marshal_get_field_end_pos): rename
772 get_arg_end_pos and remove all validation
773 (_dbus_marshal_validate_arg): actually do validation here.
775 2003-01-29 Havoc Pennington <hp@pobox.com>
777 * dbus/dbus-message.c (check_message_handling): fix assertion
778 failure on set_client_serial
780 2003-01-28 Havoc Pennington <hp@pobox.com>
782 * dbus/dbus-server-debug.c: Add doc section comments
784 * dbus/dbus-transport-debug.c: add doc section comments
786 2003-01-28 Havoc Pennington <hp@redhat.com>
788 * dbus/dbus-string.c (_dbus_string_base64_decode): append bytes in
789 the reverse order from how I had it
790 (_dbus_string_base64_encode): reverse encoding order. I was
791 basically byteswapping everything during encoding.
793 2003-01-28 Anders Carlsson <andersca@codefactory.se>
795 * dbus/dbus-connection-internal.h:
796 * dbus/dbus-connection.c: (_dbus_connection_add_timeout),
797 (_dbus_connection_remove_timeout):
798 Add functions for adding and removing timeouts.
800 * dbus/dbus-message.c: (dbus_message_new_from_message):
801 Add new function that takes a message and creates an exact
802 copy of it, but with the refcount set to 1.
803 (check_message_handling):
806 * dbus/dbus-server-protected.h:
807 * dbus/dbus-server.c: (_dbus_server_init_base),
808 (_dbus_server_finalize_base), (_dbus_server_add_timeout),
809 (dbus_server_set_timeout_functions):
810 (_dbus_server_remove_timeout):
811 New functions so that a server can add and remove timeouts.
813 (dbus_server_listen):
814 Add commented out call to dbus_server_debug_new.
816 * dbus/dbus-timeout.c: (_dbus_timeout_new):
817 Actually set the handler, doh.
819 * dbus/dbus-transport.c: (_dbus_transport_open):
820 Add commented out call to dbus_transport_debug_client_new.
823 Add dbus-transport-debug.[ch] and dbus-server-debug.[ch]
825 2003-01-28 Havoc Pennington <hp@pobox.com>
827 * dbus/dbus-message.c (check_message_handling): function to check
828 on the loaded message, iterates over it etc.
830 2003-01-28 Havoc Pennington <hp@pobox.com>
832 * test/Makefile.am (dist-hook): fix make distdir
834 * dbus/Makefile.am (TESTS_ENVIRONMENT): fix make check
836 2003-01-27 Havoc Pennington <hp@pobox.com>
838 * dbus/dbus-mempool.c (time_for_size): replace printf with
841 * dbus/dbus-message-builder.c (_dbus_message_data_load): allow
842 empty lines; fix the SAVE_LENGTH stuff to be
843 START_LENGTH/END_LENGTH so it actually works; couple other
846 * test/Makefile.am (dist-hook): add dist-hook for .message files
848 * dbus/dbus-string.c (DBUS_STRING_COPY_PREAMBLE): source of a copy
849 can be constant or locked.
850 (_dbus_string_free): allow freeing a const string as
853 * dbus/dbus-sysdeps.c (_dbus_concat_dir_and_file): utility
855 * dbus/dbus-test-main.c (main): take an argument which is the
856 directory containing test data
858 * dbus/dbus-message.c (_dbus_message_test): pass a test_data_dir
859 argument to this and load all the messages in test/data/
860 checking that they can be loaded or not loaded as appropriate.
862 2003-01-27 Anders Carlsson <andersca@codefactory.se>
864 * bus/dispatch.c: (bus_dispatch_message_handler):
865 Dispatch messages sent to services.
867 * bus/driver.c: (bus_driver_send_service_deleted),
868 (bus_driver_send_service_created), (bus_driver_send_service_lost),
869 (bus_driver_send_service_acquired):
870 Add helper functions for sending service related messages.
872 (bus_driver_send_welcome_message):
873 Send HELLO_REPLY instead of WELCOME.
875 (bus_driver_handle_list_services):
876 Send LIST_SERVICES_REPLY instead of SERVICES.
878 (bus_driver_handle_own_service),
879 (bus_driver_handle_service_exists):
880 New message handlers.
882 (bus_driver_handle_message):
883 Invoke new message handlers.
885 (bus_driver_remove_connection):
886 Don't remove any services here since that's done automatically
887 by bus_service_remove_owner now.
890 New function signatures.
892 * bus/services.c: (bus_service_add_owner):
893 Send ServiceAcquired message if we're the only primary owner.
895 (bus_service_remove_owner):
896 Send ServiceAcquired/ServiceLost messages.
898 (bus_service_set_prohibit_replacement),
899 (bus_service_get_prohibit_replacement):
900 Functions for setting prohibit replacement.
902 (bus_service_has_owner):
903 New function that checks if a connection is in the owner queue of
907 Add new function signatures.
909 * dbus/dbus-list.c: (_dbus_list_test):
910 Add tests for _dbus_list_remove_last and traversing the list backwards.
913 Fix a typo in _dbus_list_get_prev_link, if we're at the first element we can't
914 go any further, so return NULL then.
916 * dbus/dbus-protocol.h:
917 Add new messages, service flags and service replies.
919 2003-01-26 Havoc Pennington <hp@pobox.com>
921 * dbus/dbus-message-builder.c: implement, completely untested.
923 * test/data/*: add data to be used in testing.
924 ".message" files are our simple loadable text format.
925 ".message-raw" will be binary dumps of messages.
927 * dbus/dbus-string.c (_dbus_string_starts_with_c_str): new
929 2003-01-26 Havoc Pennington <hp@pobox.com>
931 * dbus/dbus-sysdeps.c (_dbus_file_get_contents): new function
933 * dbus/dbus-errors.c (dbus_result_to_string): add
936 * dbus/dbus-message-builder.c: new file, will contain code to load
937 up messages from files. Not implemented yet.
939 2003-01-26 Havoc Pennington <hp@pobox.com>
941 * dbus/dbus-message.c (dbus_message_set_sender): support deleting
942 the sender by setting to NULL
944 2003-01-26 Havoc Pennington <hp@pobox.com>
946 The unit tests pass, but otherwise untested. If it breaks, the
947 tests should have been better. ;-)
949 * bus/driver.c (bus_driver_handle_hello): return if we disconnect
952 * dbus/dbus-message.c: redo everything so we maintain
953 message->header as the only copy of the various fields.
954 This avoids the possibility of out-of-memory in some cases,
955 for example dbus_message_lock() can't run out of memory anymore,
956 and avoids extra copying. Figured I may as well go ahead and do
957 this since it was busted for dbus_message_lock to not return
958 failure on OOM, and dbus_message_write_header was totally
959 unchecked for OOM. Also fixed some random other bugs.
961 * dbus/dbus-marshal.c (_dbus_marshal_get_field_end_pos): verify
962 that strings are nul-terminated. Also, end_pos can be equal
963 to string length just not greater than, I think.
964 (_dbus_marshal_set_int32): new function
965 (_dbus_marshal_set_uint32): new function
966 (_dbus_marshal_set_string): new function
968 * dbus/dbus-connection.c (_dbus_connection_new_for_transport): fix
969 a warning, init timeout_list to NULL
970 (dbus_connection_send_message): don't use uninitialized variable
973 * dbus/dbus-string.c (_dbus_string_replace_len): new function
975 2003-01-26 Anders Carlsson <andersca@codefactory.se>
977 * bus/driver.c: (bus_driver_handle_hello),
978 (bus_driver_send_welcome_message):
981 2003-01-26 Anders Carlsson <andersca@codefactory.se>
983 * dbus/dbus-auth.c: (process_auth), (_dbus_auth_unref):
984 * dbus/dbus-connection.c: (_dbus_connection_new_for_transport),
985 (dbus_connection_unref):
986 * dbus/dbus-marshal.c: (_dbus_marshal_test):
987 * dbus/dbus-message.c: (dbus_message_unref),
990 (dbus_message_get_fields):
991 Remove debugging printout.
993 (_dbus_message_loader_return_buffer):
994 Don't store the header string.
996 (_dbus_message_test):
999 2003-01-26 Richard Hult <rhult@codefactory.se>
1001 * glib/dbus-gmain.c (dbus_connection_dispatch): Traverse a copy of
1002 the file descriptor list, since it can change under us.
1004 2003-01-25 Anders Carlsson <andersca@codefactory.se>
1006 * glib/dbus-gmain.c: (dbus_connection_prepare),
1007 (dbus_connection_check), (dbus_connection_dispatch), (add_watch),
1008 (remove_watch), (dbus_connection_hookup_with_g_main):
1009 Rewrite the glib handling to use its own GSource instead of a
1010 GIOChannel so we can catch messages put in the queue while waiting
1013 2003-01-25 Anders Carlsson <andersca@codefactory.se>
1016 * bus/connection.c: (connection_disconnect_handler),
1017 (connection_watch_callback), (bus_connection_setup):
1018 * bus/dispatch.c: (send_one_message),
1019 (bus_dispatch_broadcast_message), (bus_dispatch_message_handler),
1020 (bus_dispatch_add_connection), (bus_dispatch_remove_connection):
1022 * bus/driver.c: (bus_driver_send_service_deleted),
1023 (bus_driver_send_service_created), (bus_driver_handle_hello),
1024 (bus_driver_send_welcome_message),
1025 (bus_driver_handle_list_services), (bus_driver_remove_connection),
1026 (bus_driver_handle_message):
1028 Refactor code, put the message dispatching in its own file. Use
1029 _DBUS_HANDLE_OOM. Also send ServiceDeleted messages when a client
1032 2003-01-25 Anders Carlsson <andersca@codefactory.se>
1034 * dbus/dbus-internals.h:
1035 Add _DBUS_HANDLE_OOM macro, it doesn't do anything currently.
1037 * dbus/dbus-message.c: (dbus_message_get_sender):
1038 * dbus/dbus-message.h:
1039 Implement dbus_message_get_sender.
1041 * dbus/dbus-protocol.h:
1042 Add message and service defines.
1044 2003-01-25 Anders Carlsson <andersca@codefactory.se>
1046 * dbus/dbus-connection.c: (dbus_connection_send_message):
1047 * dbus/dbus-message-internal.h:
1048 * dbus/dbus-message.c: (_dbus_message_get_client_serial),
1049 (dbus_message_write_header):
1050 Remove _dbus_messag_unlock and don't set the client serial on a
1051 message if one already exists.
1053 2003-01-24 Havoc Pennington <hp@pobox.com>
1055 * dbus/dbus-list.c (alloc_link): put a thread lock on the global
1058 * bus/driver.c (bus_driver_handle_list_services): fix a leak
1061 2003-01-25 Anders Carlsson <andersca@codefactory.se>
1063 * dbus/dbus-list.c: (alloc_link), (free_link):
1064 Use a memory pool for the links.
1066 2003-01-25 Anders Carlsson <andersca@codefactory.se>
1068 * bus/connection.c: (bus_connection_foreach):
1070 Add new bus_connection_foreach function.
1072 * bus/driver.c: (send_one_message), (bus_driver_broadcast_message):
1073 Add function that broadcasts a message to all clients.
1075 (bus_driver_send_service_created), (bus_driver_handle_hello),
1076 (bus_driver_send_welcome_message),
1077 (bus_driver_handle_list_services), (bus_driver_message_handler):
1078 Implement functions that take care of listing services, and notifying
1079 clients when new services are created.
1081 * bus/services.c: (bus_services_list):
1083 Add new function that returns an array of strings with the currently
1084 registered services.
1087 * glib/dbus-gmain.c:
1088 Update copyright year.
1090 2003-01-25 Anders Carlsson <andersca@codefactory.se>
1092 * dbus/dbus-connection.c: (dbus_connection_send_message):
1093 Unlock the message in case it was sent earlier.
1095 (dbus_connection_send_message_with_reply_and_block):
1096 Remove the reply message from the list.
1098 * dbus/dbus-marshal.c: (_dbus_demarshal_string_array):
1099 Set array_len and new_pos correctly.
1101 (_dbus_marshal_test):
1102 Remove debug output.
1104 * dbus/dbus-message-internal.h:
1105 * dbus/dbus-message.c: (_dbus_message_get_reply_serial):
1106 New function that returns the reply serial.
1108 (_dbus_message_unlock):
1109 New function that unlocks a message and resets its header.
1111 (dbus_message_append_string_array),
1112 (dbus_message_get_fields_valist),
1113 (dbus_message_iter_get_field_type),
1114 (dbus_message_iter_get_string_array),
1115 (dbus_message_get_fields),
1116 (dbus_message_append_fields_valist):
1117 Handle string arrays.
1119 (dbus_message_set_sender):
1120 Make this function public since the bus daemon needs it.
1122 (decode_header_data):
1123 Set the reply serial to -1 initially.
1125 * dbus/dbus-message.h:
1126 Add dbus_message_set_sender.
1128 2003-01-24 Havoc Pennington <hp@pobox.com>
1130 * doc/dbus-specification.sgml: add some stuff
1132 2003-01-22 Havoc Pennington <hp@pobox.com>
1134 * doc/dbus-specification.sgml: Start to document the protocol.
1136 2003-01-22 Havoc Pennington <hp@pobox.com>
1138 * dbus/dbus-connection.c
1139 (dbus_connection_send_message_with_reply_and_block): add some @todo
1141 * bus/driver.c (bus_driver_add_connection): add a FIXME about memleak
1143 2003-01-21 Havoc Pennington <hp@pobox.com>
1145 (patch untested because can't compile)
1147 * bus/driver.c (create_unique_client_name): make this function
1148 never recycle client names. Also, caller should initialize
1151 * dbus/dbus-sysdeps.c (_dbus_get_current_time): new function
1153 2003-01-21 Anders Carlsson <andersca@codefactory.se>
1155 * dbus/dbus-marshal.c: (_dbus_marshal_double),
1156 (_dbus_marshal_int32), (_dbus_marshal_uint32),
1157 (_dbus_marshal_int32_array), (_dbus_marshal_uint32_array),
1158 (_dbus_marshal_double_array), (_dbus_marshal_string_array),
1159 (_dbus_demarshal_int32_array), (_dbus_demarshal_uint32_array),
1160 (_dbus_demarshal_double_array), (_dbus_demarshal_string_array),
1161 (_dbus_marshal_get_field_end_pos), (_dbus_marshal_test):
1162 * dbus/dbus-marshal.h:
1163 * dbus/dbus-protocol.h:
1164 Add support for marshalling and demarshalling integer, double
1167 2003-01-21 Anders Carlsson <andersca@codefactory.se>
1172 * bus/connection.c: (connection_disconnect_handler):
1173 Remove the connection from the bus driver's list.
1175 (connection_watch_callback): Dispatch messages.
1177 (free_connection_data): Free connection name.
1179 (bus_connection_setup): Add connection to the bus driver's list.
1180 (bus_connection_remove_owned_service):
1181 (bus_connection_set_name), (bus_connection_get_name):
1182 Add functions for setting and getting the connection's name.
1185 Add function headers.
1187 * bus/driver.c: (create_unique_client_name),
1188 (bus_driver_handle_hello_message),
1189 (bus_driver_send_welcome_message), (bus_driver_message_handler),
1190 (bus_driver_add_connection), (bus_driver_remove_connection):
1193 * bus/services.c: (bus_service_free):
1195 New file that handles communication and registreation with the bus
1198 2003-01-21 Anders Carlsson <andersca@codefactory.se>
1200 * dbus/dbus-connection.c: (dbus_connection_send_message):
1201 Add a new client_serial parameter.
1203 (dbus_connection_send_message_with_reply):
1204 Remove a @todo since we've implemented the blocking function.
1206 (dbus_connection_send_message_with_reply_and_block):
1207 New function that sends a message and waits for a reply and
1208 then returns the reply.
1210 * dbus/dbus-connection.h:
1213 * dbus/dbus-errors.c: (dbus_result_to_string):
1214 * dbus/dbus-errors.h:
1215 Add new DBUS_RESULT.
1217 * dbus/dbus-message-internal.h:
1218 * dbus/dbus-message.c: (_dbus_message_get_reply_serial),
1219 (_dbus_message_set_sender), (dbus_message_write_header),
1220 (dbus_message_new_reply), (decode_header_data),
1221 (_dbus_message_loader_return_buffer), (_dbus_message_test):
1222 * dbus/dbus-message.h:
1223 Add new functions that set the reply serial and sender.
1224 Also marshal and demarshal them correctly and add test.
1226 * dbus/dbus-protocol.h:
1227 Add new DBUS_MESSAGE_TYPE_SENDER.
1230 * glib/dbus-gmain.c: (watch_callback), (free_callback_data),
1231 (add_watch), (remove_watch), (add_timeout), (remove_timeout),
1232 (dbus_connection_hookup_with_g_main):
1233 * glib/test-dbus-glib.c: (main):
1234 Rewrite to use GIOChannel and remove the GSource crack.
1236 * test/echo-client.c: (main):
1237 * test/watch.c: (check_messages):
1238 Update for changed APIs
1240 2003-01-19 Anders Carlsson <andersca@codefactory.se>
1242 * dbus/Makefile.am: Add dbus-timeout.[cħ]
1244 * dbus/dbus-connection.c: (_dbus_connection_new_for_transport):
1245 Create a DBusTimeoutList.
1246 (dbus_connection_set_timeout_functions): Add new function to
1247 set timeout callbacks
1249 * dbus/dbus-connection.h: Add public DBusTimeout API.
1251 * dbus/dbus-message.c: (dbus_message_get_service):
1252 * dbus/dbus-message.h: New function.
1254 * dbus/dbus-server.c: Fix small doc typo.
1256 * dbus/dbus-timeout.[ch]: New files for mainloop timeouts.
1258 2003-01-19 Anders Carlsson <andersca@codefactory.se>
1260 * dbus/dbus-string.c (_dbus_string_move_len): Don't delete all
1261 of the string, just as long as specified.
1263 2003-01-19 Havoc Pennington <hp@pobox.com>
1265 * dbus/dbus-connection.c (dbus_connection_get_is_authenticated):
1268 * dbus/dbus-server.c (dbus_server_set_max_connections)
1269 (dbus_server_get_max_connections, dbus_server_get_n_connections):
1270 keep track of current number of connections, and add API for
1271 setting a max (but haven't implemented enforcing the max yet)
1273 2003-01-18 Havoc Pennington <hp@pobox.com>
1275 * dbus/dbus-transport-unix.c (unix_do_iteration): only do the
1276 reading/writing if read_watch != NULL or write_watch != NULL.
1278 * dbus/dbus-message.c (_dbus_message_loader_return_buffer): fix
1279 the message loader code to actually load message->header and
1280 message->body into the newly-created message.
1282 * dbus/dbus-transport-unix.c (check_write_watch): fix a mem leak
1285 * dbus/dbus-connection.c (dbus_connection_set_max_message_size)
1286 (dbus_connection_get_max_message_size)
1287 (dbus_connection_set_max_live_messages_size)
1288 (dbus_connection_get_max_live_messages_size): implement some
1289 resource limitation functions
1291 * dbus/dbus-resources.c: new file implementing some of the
1292 resource limits stuff
1294 * dbus/dbus-message.c (dbus_message_iter_get_byte_array): add
1295 missing docs, add @todo to handle OOM etc.
1297 * dbus/dbus-marshal.c (_dbus_demarshal_byte_array): add missing
1300 2003-01-18 Havoc Pennington <hp@pobox.com>
1302 * dbus/dbus-connection.c (dbus_connection_unref): disconnect the
1303 connection if it hasn't been already.
1305 * dbus/dbus-connection.h: kill off the idea of an ErrorFunction,
1306 replace with DisconnectFunction.
1308 2003-01-18 Havoc Pennington <hp@pobox.com>
1310 Building --disable-verbose-mode --disable-asserts --disable-tests
1311 cuts the library from 112K to 45K or so
1313 * configure.in: check for varargs macro support,
1314 add --enable-verbose-mode, --enable-asserts.
1316 * dbus/dbus-internals.h (_dbus_assert): support
1318 (_dbus_verbose): support DBUS_ENABLE_VERBOSE_MODE
1320 2003-01-18 Havoc Pennington <hp@pobox.com>
1322 * dbus/dbus-test.c: include config.h so that tests actually run
1324 * dbus/dbus-string.c: add assertions that stuff is 8-byte aligned,
1325 so the failure mode when that assumption fails will be plenty
1328 2003-01-18 Havoc Pennington <hp@pobox.com>
1330 * configure.in: default --enable-tests to $USE_MAINTAINER_MODE
1332 * dbus/Makefile.am: fix it up so dubs-test-main.c is included in
1335 * test/Makefile.am: don't use special variable "TESTS" for echo-*
1336 since we don't want to use those in make check
1338 2003-01-15 Havoc Pennington <hp@redhat.com>
1344 2003-01-15 Havoc Pennington <hp@redhat.com>
1346 * test/Makefile.am: fix so that test source code ends up in the
1347 distribution on make distcheck
1349 2003-01-15 Havoc Pennington <hp@redhat.com>
1355 2003-01-15 Havoc Pennington <hp@redhat.com>
1357 * dbus/dbus-test.c (dbus_internal_symbol_do_not_use_run_tests):
1358 fix build when --disable-tests
1360 * Makefile.am (EXTRA_DIST): put HACKING in here
1362 * HACKING: document procedure for making a tarball release.
1364 2003-01-14 Anders Carlsson <andersca@codefactory.se>
1366 * bus/connection.c: (connection_error_handler),
1367 (bus_connection_setup):
1368 * bus/main.c: (main):
1369 Make sure that the DBusConnectionData struct is NULLed
1370 out to prevent a segfault.
1372 * dbus/dbus-errors.c: (dbus_result_to_string):
1373 * dbus/dbus-errors.h:
1374 * dbus/dbus-message.c: (dbus_message_get_fields),
1375 (dbus_message_get_fields_valist), (_dbus_message_test):
1376 * dbus/dbus-message.h:
1377 Make dbus_message_get_fields return a result code so we can
1378 track invalid fields as well as oom.
1380 2003-01-11 Havoc Pennington <hp@pobox.com>
1382 * configure.in: change --enable-test/--enable-ansi action-if-given
1383 to enable_foo=$enableval instead of enable_foo=yes
1385 2003-01-08 Havoc Pennington <hp@pobox.com>
1387 * dbus/dbus-string.c (_dbus_string_align_length): new function
1389 * dbus/dbus-test-main.c: move main() for test app here
1391 (dbus_internal_symbol_do_not_use_run_tests): we have to export a
1392 symbol to run tests, because dbus-test isn't in the main
1395 Code review nitpicks.
1397 * dbus/dbus-message.c (dbus_message_write_header): add newlines
1398 for people with narrow emacs ;-). Assert client_serial was filled
1399 in. Assert message->name != NULL.
1400 (dbus_message_append_fields): have "first_field_type" arg separate
1401 from va list, needed for C++ binding that also uses varargs IIRC
1402 and helps with type safety
1403 (dbus_message_new): add @todo about using DBusString to store
1404 service/name internally
1405 (dbus_message_new): don't leak ->service and ->name on OOM later
1407 (dbus_message_unref): free the service name
1408 (dbus_message_get_fields): same change to varargs
1409 i.e. first_field_type
1410 (_dbus_message_loader_return_buffer): assert that the message data
1411 is aligned (if not it's a bug in our code). Put in verbose griping
1412 about why we set corrupted = TRUE.
1413 (decode_header_data): add FIXME that char* is evil. Was going to
1414 add FIXME about evil locale-specific string.h strncmp, but just
1415 switched to wacky string-as-uint32 optimization. Move check for
1416 "no room for field name" above get_const_data_len() to avoid
1417 assertion failure in get_const_data_len if we have trailing 2
1418 bytes or the like. Check for service and name fields being
1419 provided twice. Don't leak service/name on error. Require field
1420 names to be aligned to 4 bytes.
1422 * dbus/dbus-marshal.c: move byte swap stuff to header
1423 (_dbus_pack_int32): uscore-prefix
1424 (_dbus_unpack_int32): uscore-prefix
1425 (_dbus_unpack_uint32): export
1426 (_dbus_demarshal_string): add @todo complaining about use of
1428 (_dbus_marshal_get_field_end_pos): add @todo about bad error
1429 handling allowing corrupt data to go unchecked
1431 2003-01-08 Havoc Pennington <hp@redhat.com>
1433 * dbus/dbus-transport-unix.c (unix_do_iteration): add read/write
1434 to the select() as needed for authentication. (should be using
1435 _dbus_poll() not select, but for another day)
1437 * dbus/dbus.h: include dbus/dbus-protocol.h
1439 2003-01-08 Anders Carlsson <andersca@codefactory.se>
1441 * dbus/Makefile.am (dbusinclude_HEADERS): Install
1444 2003-01-08 Anders Carlsson <andersca@codefactory.se>
1446 * dbus/dbus-internals.c: (_dbus_type_to_string):
1447 New function that returns a string describing a type.
1449 * dbus/dbus-marshal.c: (_dbus_demarshal_byte_array):
1450 * dbus/dbus-marshal.h:
1451 * dbus/dbus-message.c: (dbus_message_get_fields_valist),
1452 (dbus_message_iter_get_field_type), (dbus_message_iter_get_double),
1453 (dbus_message_iter_get_byte_array):
1454 * dbus/dbus-message.h:
1455 Add new convenience functions for appending and getting message fields.
1456 Also add demarshalling routines for byte arrays.
1458 2003-01-07 Anders Carlsson <andersca@codefactory.se>
1460 * dbus/dbus-connection-internal.h:
1461 * dbus/dbus-connection.c: (_dbus_connection_new_for_transport),
1462 (_dbus_connection_get_next_client_serial),
1463 (dbus_connection_send_message):
1464 * dbus/dbus-internals.h:
1465 * dbus/dbus-marshal.c: (unpack_uint32), (dbus_unpack_int32),
1466 (dbus_pack_int32), (_dbus_marshal_double), (_dbus_marshal_int32),
1467 (_dbus_marshal_uint32), (_dbus_demarshal_double),
1468 (_dbus_demarshal_int32), (_dbus_demarshal_uint32),
1469 (_dbus_demarshal_string), (_dbus_marshal_get_field_end_pos),
1470 (_dbus_verbose_bytes), (_dbus_marshal_test):
1471 * dbus/dbus-marshal.h:
1472 * dbus/dbus-message-internal.h:
1473 * dbus/dbus-message.c: (_dbus_message_set_client_serial),
1474 (dbus_message_write_header), (_dbus_message_lock),
1475 (dbus_message_new), (dbus_message_ref), (dbus_message_unref),
1476 (dbus_message_get_name), (dbus_message_append_int32),
1477 (dbus_message_append_uint32), (dbus_message_append_double),
1478 (dbus_message_append_string), (dbus_message_append_byte_array),
1479 (dbus_message_get_fields_iter), (dbus_message_iter_ref),
1480 (dbus_message_iter_unref), (dbus_message_iter_has_next),
1481 (dbus_message_iter_next), (dbus_message_iter_get_field_type),
1482 (dbus_message_iter_get_string), (dbus_message_iter_get_int32),
1483 (dbus_message_iter_get_uint32), (dbus_message_iter_get_double),
1484 (decode_header_data), (_dbus_message_loader_return_buffer),
1485 (message_iter_test), (_dbus_message_test):
1486 * dbus/dbus-message.h:
1487 * dbus/dbus-protocol.h:
1488 * dbus/dbus-test.c: (main):
1490 * glib/test-dbus-glib.c: (message_handler), (main):
1491 * test/echo-client.c: (main):
1492 * test/watch.c: (check_messages):
1493 Make messages sendable and receivable for real.
1495 2003-01-07 Anders Carlsson <andersca@codefactory.se>
1497 * dbus/dbus-marshal.c: (_dbus_marshal_double),
1498 (_dbus_marshal_string), (_dbus_marshal_byte_array):
1499 * dbus/dbus-message.c: (dbus_message_append_int32),
1500 (dbus_message_append_uint32), (dbus_message_append_double),
1501 (dbus_message_append_string), (dbus_message_append_byte_array):
1502 Handle OOM restoration.
1504 2003-01-07 Anders Carlsson <andersca@codefactory.se>
1506 * dbus/dbus-marshal.c: (_dbus_marshal_string),
1507 (_dbus_demarshal_string), (_dbus_marshal_test):
1508 * dbus/dbus-marshal.h:
1509 * dbus/dbus-message.c: (dbus_message_get_name),
1510 Document these functions.
1512 (dbus_message_append_int32), (dbus_message_append_uint32),
1513 (dbus_message_append_double), (dbus_message_append_string),
1514 (dbus_message_append_byte_array):
1515 * dbus/dbus-message.h:
1516 Add functions for adding message fields of different types.
1518 * dbus/dbus-protocol.h:
1519 Add the different types.
1521 2003-01-05 Havoc Pennington <hp@pobox.com>
1523 * bus/connection.c: implement routines for handling connections,
1524 first thing is keeping a list of owned services on each connection
1525 and setting up watches etc.
1527 * bus/services.c: implement a mapping from service names to lists
1530 * dbus/dbus-hash.c: add DBUS_HASH_POINTER
1532 * dbus/dbus-threads.c (dbus_static_mutex_lock): add functions
1533 to use static mutexes for global data
1535 * dbus/dbus-connection.c (dbus_connection_set_data): add new
1536 collection of functions to set/get application-specific data
1537 on the DBusConnection.
1539 2003-01-04 Havoc Pennington <hp@pobox.com>
1541 * dbus/dbus-sysdeps.c (_dbus_sleep_milliseconds): new function
1542 (_dbus_poll): new function
1544 * dbus/dbus-internals.h (_DBUS_STRUCT_OFFSET): new macro
1547 * bus/loop.c: initial code for the daemon main loop
1549 2003-01-04 Havoc Pennington <hp@pobox.com>
1551 * test/watch.c (error_handler): make it safe if the error handler
1552 is called multiple times (if we s/error handler/disconnect
1553 handler/ we should just guarantee it's called only once)
1555 * dbus/dbus-transport.c (_dbus_transport_disconnect): call the
1556 error handler on disconnect (it's quite possible we should
1557 just change the error handler to a "disconnect handler," I'm
1558 not sure we have any other meaningful errors)
1560 * configure.in: check for getpwnam_r
1562 * dbus/dbus-transport.c, dbus/dbus-transport-unix.c,
1563 dbus/dbus-auth.c: add credentials support, add EXTERNAL auth
1564 mechanism as in SASL spec, using socket credentials
1566 * dbus/dbus-sysdeps.c (_dbus_read_credentials_unix_socket): new function
1567 (_dbus_send_credentials_unix_socket): new function
1569 * dbus/dbus-sysdeps.c (_dbus_accept_unix_socket): rename just
1571 (_dbus_write): only check errno if <0 returned
1572 (_dbus_write_two): ditto
1574 2003-01-02 Anders Carlsson <andersca@codefactory.se>
1576 * dbus/dbus-marshal.c: (_dbus_marshal_utf8_string),
1577 (_dbus_marshal_byte_array), (_dbus_demarshal_utf8_string),
1578 (_dbus_marshal_test):
1579 * dbus/dbus-marshal.h:
1580 Add _dbus_marshal_byte_array and rename _dbus_marshal_string
1581 to _dbus_marshal_utf8_string. Also fix some tests.
1583 2002-12-28 Harri Porten <porten@kde.org>
1585 * configure.in: added check for C++ compiler and a very cheesy
1586 check for the Qt integration
1588 * Makefile.am (SUBDIRS): compile qt subdir if support is enabled
1590 * qt/Makefile.am: added
1592 * qt/.cvsignore: added
1594 * qt/dbus-qthread.cc, qt/dbus-qthread.cpp: renamed former to
1595 latter, added #ifdef QT_THREAD_SUPPORT guard.
1597 * dbus/Makefile.am: added missing headers for make dist
1599 2002-12-28 Kristian Rietveld <kris@gtk.org>
1601 * dbus/Makefile.am: fixup export-symbols-regex.
1603 2002-12-27 Anders Carlsson <andersca@codefactory.se>
1605 * acinclude.m4: Add this file and put the
1606 PKG_CHECK_MODULE macro in it.
1608 2002-12-27 Anders Carlsson <andersca@codefactory.se>
1610 * dbus/dbus-marshal.c: (_dbus_marshal_string),
1611 (_dbus_demarshal_double), (_dbus_demarshal_int32),
1612 (_dbus_demarshal_uint32), (_dbus_demarshal_string),
1613 (_dbus_marshal_test):
1614 Make the demarshalling routines align the pos argument.
1615 Add string marshalling tests and fix the obvious bugs
1618 2002-12-26 Havoc Pennington <hp@pobox.com>
1620 * dbus/dbus-auth.c: fixes fixes fixes
1622 * dbus/dbus-transport-unix.c: wire up support for
1623 encoding/decoding data on the wire
1625 * dbus/dbus-auth.c (_dbus_auth_encode_data)
1626 (_dbus_auth_decode_data): append to target string
1627 instead of nuking it.
1629 2002-12-26 Havoc Pennington <hp@pobox.com>
1631 * dbus/dbus-marshal.h (DBUS_COMPILER_BYTE_ORDER): #ifdef
1632 WORDS_BIGENDIAN then compiler byte order is DBUS_BIG_ENDIAN,
1635 * dbus/dbus-marshal.c: Add macros to do int swapping in-place and
1636 avoid swap_bytes() overhead (ignoring possible assembly stuff for
1637 now). Main point is because I wanted unpack_uint32 to implement
1639 (_dbus_verbose_bytes): new function
1641 * dbus/dbus-string.c (_dbus_string_validate_ascii): new function
1643 * dbus/dbus-message.c (_dbus_message_loader_get_is_corrupted): add
1644 mechanism to handle a corrupt message stream
1645 (_dbus_message_loader_new): fix preallocation to only prealloc,
1648 * dbus/dbus-string.c (_dbus_string_skip_blank): fix this function
1649 (_dbus_string_test): enhance tests for copy/move and fix the
1652 * dbus/dbus-transport-unix.c: Hold references in more places to
1653 avoid reentrancy problems
1655 * dbus/dbus-transport.c: ditto
1657 * dbus/dbus-connection.c (dbus_connection_dispatch_message): don't
1658 leak reference count in no-message case
1660 * test/watch.c (do_mainloop): handle adding/removing watches
1661 during iteration over the watches. Also, ref the connection/server
1662 stored on a watch, so we don't try to mangle a destroyed one.
1664 * dbus/dbus-transport-unix.c (do_authentication): perform
1667 * dbus/dbus-auth.c (get_state): add a state
1668 AUTHENTICATED_WITH_UNUSED_BYTES and return it if required
1669 (_dbus_auth_get_unused_bytes): append the unused bytes
1670 to the passed in string, rather than prepend
1672 * dbus/dbus-transport.c (_dbus_transport_init_base): create
1673 the auth conversation DBusAuth
1675 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_fd)
1676 (_dbus_transport_new_for_domain_socket): when creating a
1677 transport, pass in whether it's a client-side or server-side
1678 transport so we know which DBusAuth to create
1680 2002-12-03 Havoc Pennington <hp@pobox.com>
1682 * dbus/dbus-transport-unix.c (unix_finalize): finalize base
1683 _after_ finalizing the derived members
1684 (unix_connection_set): unref watch if we fail to add it
1686 * dbus/dbus-connection.c (dbus_connection_unref): delete the
1687 transport first, so that the connection owned by the
1688 transport will be valid as the transport finalizes.
1690 * dbus/dbus-transport-unix.c (unix_finalize): free the write_watch
1691 if necessary, and remove watches from the connection.
1693 * dbus/dbus-watch.c (_dbus_watch_list_free): improve a comment
1695 2002-12-26 Anders Carlsson <andersca@codefactory.se>
1697 * dbus/dbus-marshal.c: (_dbus_marshal_string),
1698 (_dbus_demarshal_double), (_dbus_demarshal_int32),
1699 (_dbus_demarshal_uint32), (_dbus_demarshal_string),
1700 (_dbus_marshal_test):
1701 * dbus/dbus-marshal.h:
1702 Add string marshal functions and have the demarshal functions
1703 return the new position.
1705 2002-12-25 Havoc Pennington <hp@pobox.com>
1707 * doc/dbus-sasl-profile.txt: docs on the authentication protocol,
1708 it is a simple protocol that just maps directly to SASL.
1710 * dbus/dbus-auth.h, dbus/dbus-auth.c: authentication protocol
1711 initial implementation, not actually used yet.
1713 * dbus/dbus-string.c (_dbus_string_find): new function
1714 (_dbus_string_equal): new function
1715 (_dbus_string_base64_encode): new function
1716 (_dbus_string_base64_decode): new function
1718 2002-12-25 Anders Carlsson <andersca@codefactory.se>
1721 * dbus/dbus-marshal.c: (swap_bytes), (_dbus_marshal_double),
1722 (_dbus_marshal_int32), (_dbus_marshal_uint32),
1723 (_dbus_demarshal_double), (_dbus_demarshal_int32),
1724 (_dbus_demarshal_uint32), (_dbus_marshal_test):
1725 * dbus/dbus-marshal.h:
1726 * dbus/dbus-protocol.h:
1727 * dbus/dbus-test.c: (main):
1729 Add un-optimized marshalling/demarshalling routines.
1731 2002-12-25 Harri Porten <porten@kde.org>
1733 * qt/dbus-qt.h: adjusted ctor and getter to KDE/Qt conventions
1735 2002-12-24 Zack Rusin <zack@kde.org>
1737 * qt/dbus-qthread.cc: adding - integrates QMutex into Dbus
1738 * qt/dbus-qt.h: skeleton with two sample implemenatation of the
1741 2002-12-24 Havoc Pennington <hp@pobox.com>
1743 * glib/dbus-gthread.c: fix include
1745 * glib/dbus-glib.h: rename DBusMessageHandler for now.
1746 I think glib API needs to change, though, as you don't
1747 want to use DBusMessageFunction, you want to use the
1748 DBusMessageHandler object. Probably
1749 dbus_connection_open_with_g_main_loop()
1750 and dbus_connection_setup_g_main_loop() or something like that
1751 (but think of better names...) that just create a connection
1752 that has watch/timeout functions etc. already set up.
1754 * dbus/dbus-connection.c
1755 (dbus_connection_send_message_with_reply): new function just to
1756 show how the message handler helps us deal with replies.
1758 * dbus/dbus-list.c (_dbus_list_remove_last): new function
1760 * dbus/dbus-string.c (_dbus_string_test): free a string that
1763 * dbus/dbus-hash.c: use memory pools for the hash entries
1764 (rebuild_table): be more paranoid about overflow, and
1765 shrink table when we can
1766 (_dbus_hash_test): reduce number of sprintfs and write
1767 valid C89. Add tests for case where we grow and then
1768 shrink the hash table.
1770 * dbus/dbus-mempool.h, dbus/dbus-mempool.c: memory pools
1772 * dbus/dbus-connection.c (dbus_connection_register_handler)
1773 (dbus_connection_unregister_handler): new functions
1775 * dbus/dbus-message.c (dbus_message_get_name): new
1777 * dbus/dbus-list.c: fix docs typo
1779 * dbus/dbus-message-handler.h, dbus/dbus-message-handler.c:
1780 an object representing a handler for messages.
1782 2002-12-16 Anders Carlsson <andersca@codefactory.se>
1785 * glib/dbus-gthread.c: (dbus_gthread_init):
1786 Don't use the gdbus prefix for public functions.
1788 2002-12-16 Anders Carlsson <andersca@codefactory.se>
1792 Add GLib checks and fixup .pc files
1796 * glib/dbus-gmain.c: (gdbus_connection_prepare),
1797 (gdbus_connection_check), (gdbus_connection_dispatch),
1798 (gdbus_add_connection_watch), (gdbus_remove_connection_watch),
1799 (dbus_connection_gsource_new):
1800 * glib/dbus-gthread.c: (dbus_gmutex_new), (dbus_gmutex_free),
1801 (dbus_gmutex_lock), (dbus_gmutex_unlock), (dbus_gthread_init):
1802 * glib/test-dbus-glib.c: (message_handler), (main):
1805 2002-12-15 Harri Porten <porten@kde.org>
1807 * autogen.sh: check for libtoolize before attempting to use it
1809 * dbus/dbus-transport-unix.c: include <sys/time.h> for timeval
1812 * .cvsignore: ignore more stamp files
1814 * dbus/dbus-watch.c (_dbus_watch_list_new): fixed doc error
1816 * test/Makefile.am: added -I$(top_srcdir) to be able to compile
1817 without make install.
1819 2002-12-15 Havoc Pennington <hp@pobox.com>
1821 * dbus/dbus-threads.c: add thread stubs that a higher library
1822 layer can fill in. e.g. the GLib wrapper might fill them in with
1823 GThread stuff. We still need to use this thread API to
1824 thread-safe-ize the library.
1826 2002-12-12 Havoc Pennington <hp@pobox.com>
1828 * dbus/dbus-transport-unix.c, dbus/dbus-server-unix.c: use the
1829 below new interfaces and include fewer system headers.
1831 * dbus/dbus-sysdeps.c (_dbus_read): new function
1832 (_dbus_write): new function
1833 (_dbus_write_two): new function
1834 (_dbus_connect_unix_socket): new function
1835 (_dbus_listen_unix_socket): new function
1837 * dbus/dbus-message-internal.h: change interfaces to use
1840 2002-12-11 Havoc Pennington <hp@pobox.com>
1842 * dbus/dbus-types.h: add dbus_unichar
1844 * dbus/dbus-internals.c (_dbus_verbose): use _dbus_getenv
1846 * dbus/dbus-connection.c (dbus_connection_send_message): return
1849 * dbus/dbus-transport.c: include dbus-watch.h
1851 * dbus/dbus-connection.c: include dbus-message-internal.h
1853 * HACKING: add file with coding guidelines stuff.
1855 * dbus/dbus-string.h, dbus/dbus-string.c: Encapsulate all string
1856 handling here, for security purposes (as in vsftpd). Not actually
1857 using this class yet.
1859 * dbus/dbus-sysdeps.h, dbus/dbus-sysdeps.c: Encapsulate all
1860 system/libc usage here, as in vsftpd, for ease of auditing (and
1861 should also simplify portability). Haven't actually moved all the
1862 system/libc usage into here yet.
1864 2002-11-25 Havoc Pennington <hp@pobox.com>
1866 * dbus/dbus-internals.c (_dbus_verbose): fix to not
1867 always print the first verbose message.
1869 2002-11-24 Havoc Pennington <hp@pobox.com>
1871 * test/echo-client.c, test/echo-server.c: cheesy test
1874 * configure.in (AC_CHECK_FUNCS): check for writev
1876 * dbus/dbus-message.c (_dbus_message_get_network_data): new
1879 * dbus/dbus-list.c (_dbus_list_foreach): new function
1881 * dbus/dbus-internals.c (_dbus_verbose): new function
1883 * dbus/dbus-server.c, dbus/dbus-server.h: public object
1884 representing a server that listens for connections.
1886 * dbus/.cvsignore: create
1888 * dbus/dbus-errors.h, dbus/dbus-errors.c:
1889 public API for reporting errors
1891 * dbus/dbus-connection.h, dbus/dbus-connection.c:
1892 public object representing a connection that
1893 sends/receives messages. (Same object used for
1894 both client and server.)
1896 * dbus/dbus-transport.h, dbus/dbus-transport.c:
1897 Basic abstraction for different kinds of stream
1898 that we might read/write messages from.
1900 2002-11-23 Havoc Pennington <hp@pobox.com>
1902 * dbus/dbus-internals.h (_DBUS_INT_MAX): add _DBUS_INT_MIN
1905 * dbus/dbus-test.c (main): add list test, and include
1906 dbus-test.h as intended
1908 * dbus/dbus-hash.c (_dbus_hash_table_remove_string)
1909 (_dbus_hash_table_remove_int): return value indicates
1910 whether the entry existed to remove
1912 * dbus/dbus-list.c: add linked list utility class,
1915 * dbus/dbus-hash.c: add TODO item about shrinking the hash bucket
1918 2002-11-23 Havoc Pennington <hp@pobox.com>
1920 * Doxyfile.in (INCLUDE_FILE_PATTERNS): expand DBUS_BEGIN_DECLS/
1921 DBUS_END_DECLS to nothing, that should fix this once and for all
1923 * Doxyfile.in (JAVADOC_AUTOBRIEF): set to YES
1925 * dbus/dbus-message.c, dbus/dbus-hash.c:
1926 add some missing @brief
1928 2002-11-23 Havoc Pennington <hp@pobox.com>
1930 * dbus/dbus-message.h: put semicolons after DEBUG_BEGIN_DECLS
1931 to avoid confusing Doxygen
1933 * dbus/dbus-hash.c: @} not }@
1935 * dbus/dbus-message.c (struct DBusMessage): split out
1938 2002-11-23 Havoc Pennington <hp@pobox.com>
1940 * configure.in: pile on more warning flags if using gcc
1942 * Doxyfile.in (EXTRACT_STATIC): set to NO, so we don't have
1943 to document static functions
1945 * configure.in: add summary to end of configure so it
1946 looks nice and attractive
1948 * dbus/dbus-hash.c: finish implementation and write unit
1951 * configure.in: add --enable-tests to enable unit tests
1953 * dbus/dbus-test.c: test program to run unit tests
1954 for all files in dbus/*, initially runs a test for
1957 * dbus/dbus-internals.h: file to hold some internal utility stuff
1959 2002-11-22 Havoc Pennington <hp@redhat.com>
1961 * dbus/dbus-hash.c: copy in Tcl hash table, not yet
1962 "ported" away from Tcl
1964 * dbus/dbus-types.h: header for types such as dbus_bool_t
1966 2002-11-22 Havoc Pennington <hp@redhat.com>
1968 * dbus/dbus.h: fixups for doc warnings
1970 * Doxyfile.in (FILE_PATTERNS): we need to scan .h to pick up
1972 (QUIET): make it quiet so we can see warnings
1974 * dbus/dbus-memory.c: teach D-BUS to allocate and free memory
1976 2002-11-22 Havoc Pennington <hp@redhat.com>
1978 * Makefile.am: include "Doxyfile" target in all-local
1980 * configure.in: generate the Doxyfile
1982 * Doxyfile.in: move Doxyfile here, so we can use
1983 configure to generate a Doxyfile with the right
1986 2002-11-22 Havoc Pennington <hp@redhat.com>
1988 * dbus/dbus-message.c: move inline docs into .c file
1990 * Doxyfile (OUTPUT_DIRECTORY): move output to doc/api
1991 so all docs are under doc/
1992 (MAN_EXTENSION): generate man pages. Use extension
1993 ".3dbus" which matches ".3qt" on my system,
1994 I guess this is OK, I don't know really.
1995 (FILE_PATTERNS): look for .c files not .h, makes sense
1998 2002-11-22 Havoc Pennington <hp@pobox.com>
2000 * Makefile.am (SUBDIRS): rename subdir "server" to "bus"
2001 because any app can be a server, and any app can be a client,
2002 the bus is a special kind of server.
2004 Thu Nov 21 23:35:31 2002 Zack Rusin <zack@kde.org>
2006 * Doxyfile : adding. Still needs Makefile rules to be generated
2007 automatically (just run "doxygen" in the toplevel dir for now to
2010 * dbus/dbus-message.h : Adding sample docs (javadoc since
2011 resembles gtk-doc a little more)
2013 * dbus/dbus.h : Adding sample docs
2015 2002-11-21 Havoc Pennington <hp@redhat.com>
2017 * dbus/Makefile.am (INCLUDES): define DBUS_COMPILATION
2018 so we can allow ourselves to include files directly,
2019 instead of having to use dbus.h
2021 * dbus/dbus.h: fill in
2023 * dbus/dbus-message.h: sketch out a sample header file.
2024 Include griping if you include it directly instead of
2027 * dbus/dbus-macros.h: new file with macros for extern "C",
2028 TRUE/FALSE, NULL, etc.
2030 * doc/file-boilerplate.c: put include guards in here
2032 2002-11-21 Havoc Pennington <hp@redhat.com>
2034 * doc/file-boilerplate.c: include both AFL and GPL boilerplate.
2036 * COPYING: include the GPL as well, and license code
2037 under both AFL and GPL.
2039 2002-11-21 Havoc Pennington <hp@redhat.com>
2041 * acconfig.h: get rid of this
2043 * autogen.sh (run_configure): add --no-configure option
2045 * configure.in: remove AC_ARG_PROGRAM to make
2046 autoconf complain less. add AC_PREREQ.
2047 add AC_DEFINE third arg.
2049 2002-11-21 Anders Carlsson <andersca@codefactory.se>
2052 Fix references so we can distcheck.
2054 2002-11-21 Havoc Pennington <hp@redhat.com>
2056 * Initial module creation