1 2006-03-05 Jim Meyering <jim@meyering.net>
5 * tests/help-version: Set SHELL, if not already set, in order to
6 avoid failure when `make check' is run through debuild; dircolors
7 would fail due to lack of $SHELL. Reported by Sven Joachim.
9 Make `base64 --wrap=N' work for N=0, and for N larger than SIZE_MAX.
10 * src/base64.c (wrap_write, do_encode, main): Change type of
11 parameters and locals, wrap_column, form size_t to uintmax_t.
12 (main): Adjust to use xstrtoumax, accordingly.
14 2006-03-03 Jim Meyering <jim@meyering.net>
16 Don't fail when run from an environment with SHELL not a Bourne
17 shell, e.g. `env SHELL=/bin/csh make check' would fail this test.
18 * tests/dircolors/simple: Invoke each non-failing test with -b.
19 Reported by Michael Stone.
21 2006-02-27 Jim Meyering <jim@meyering.net>
23 * tests/misc/base64: Derive --decode-using tests from the
26 * tests/misc/base64: Factor out a long constant string.
27 Split lines to stay within 80 columns.
29 * tests/misc/Makefile.am (TESTS): Add base64.
30 * tests/misc/base64: Test base64. From Simon Josefsson.
32 * src/base64.c (do_decode): Use correct type for parameter,
33 ignore_garbage: s/size_t/bool/.
35 * src/base64.c: Don't include .h files already included by system.h:
36 <string.h>, <stdlib.h>, <stdbool.h>, <limits.h>, <errno.h>.
37 Include "system.h" before the other lib/*.h header files.
38 Include <sys/types.h> before "system.h".
39 (wrap_write): Remove declaration of unused local, initial_column.
40 (wrap_write): Correct declaration syntax: s/size_t * V/size_t *V/.
42 * README: Add base64 to the list.
44 2006-02-17 Simon Josefsson <jas@extundo.com>
47 * AUTHORS: Mention base64.
49 * man/Makefile.am: Build base64.1.
50 * man/base64.x: New file.
51 * src/Makefile.am (bin_PROGRAMS): Add base64.
52 * src/base64.c: New file.
54 2006-02-25 Eric Blake <ebb9@byu.net>
56 In ls, avoid calling stat for --inode (-i), when possible.
57 * src/pwd.c (NOT_AN_INODE_NUMBER, D_INO): Move to ...
58 * src/system.h: ... here, for use in ...
59 * src/ls.c (main): ... here. Prefer dirent.d_ino to stat when
61 (gobble_file): Add inode argument.
62 (print_dir): Pass inode if available.
63 (usage): Remove inaccuracy.
65 2006-02-23 Jim Meyering <jim@meyering.net>
67 * TODO: Update/correct some obsolete entries.
69 2006-02-20 Paul Eggert <eggert@cs.ucla.edu>
71 * doc/coreutils.texi (join invocation): Mention `sort -k 1b,1'.
72 * src/join.c (usage): Likewise.
73 Documentation problem reported by Philip Kensche.
75 2006-02-20 Eric Blake <ebb9@byu.net>
77 * man/rm.x: Update documentation to match previous patch.
79 2006-02-18 Eric Blake <ebb9@byu.net>
81 New option for rm: --interactive=once (-I).
82 * NEWS: Document it, along with change to rm --interactive.
83 * TODO: Remove entry for implementing rm -I
84 * src/rm.c (INTERACTIVE_OPTION): New enum value.
85 (interactive_type): New enum.
86 (long_opts): Let interactive take an optional argument.
87 (interactive_args, interactive_types): New option arguments.
88 (usage): Document -I, --interactive=WHEN. Use program_name
89 instead of a basename.
90 (main): New -I option, new behavior to --interactive.
91 * tests/rm/interactive-once: New tests.
92 * tests/rm/interactive-always: Ditto.
93 * tests/rm/Makefile.am (TESTS): Run them.
95 2006-02-18 Jim Meyering <jim@meyering.net>
97 * Makefile.maint (sc_two_space_separator_in_usage): Make the regular
98 expression match more of the target lines, e.g., those that start with
99 `-S,' (short option followed by a comma) or that include `=[...]'.
100 Patch by Nicolas François.
101 Fix the four offenders thus exposed:
102 * src/join.c (usage): Use two spaces (not one) to separate the
103 --first-only option string from its description, so help2man formats
104 the derived man page properly.
105 * src/pr.c (usage): Likewise.
106 * src/uniq.c (usage): Likewise.
107 * src/install.c (usage): Likewise.
109 2006-02-15 Jim Meyering <jim@meyering.net>
111 * Makefile.maint (alpha beta major): For `make major', ensure that the
112 version string is of the form N.N[.N]*, where N is one or more digits.
114 2006-02-14 Jim Meyering <jim@meyering.net>
116 * INSTALL: Update from gnulib.
118 2006-02-13 Jim Meyering <jim@meyering.net>
120 * GNUmakefile (all): Emit diagnostics to stderr, not stdout.
122 2006-02-12 Jim Meyering <jim@meyering.net>
124 * Makefile.maint (patch-check): New target.
125 (local-checks-available): Add to the list.
127 2006-02-11 Jim Meyering <jim@meyering.net>
129 * src/c99-to-c89.diff: New file.
130 * src/Makefile.am (EXTRA_DIST): Add c99-to-c89.diff.
132 * .x-po-check: New file, with exclusions so that `make distcheck'
134 * Makefile.am (EXTRA_DIST): Add .x-po-check.
136 rm -r must remove an empty directory, even if it is inaccessible.
137 * src/remove.c (close_preserve_errno): New function.
138 (fd_to_subdirp): Don't print a diagnostic in this function.
139 Do it from the callers instead, unless rmdir succeeds.
140 (remove_cwd_entries, remove_dir): Adjust callers.
141 * tests/rm/empty-inacc: New test for the above.
142 * tests/rm/Makefile.am (TESTS): Add empty-inacc.
143 * NEWS: Mention this bug fix.
144 * tests/rm/rm2: Adjust two expected diagnostics, now that they're
145 a tiny bit less precise: cannot remove `a/1': ... instead of
146 cannot open directory `a/1': ...
148 * Makefile.maint (syntax-check-rules): Automatically derive this
149 list of sc_-prefixed rule names.
151 2006-02-10 Paul Eggert <eggert@cs.ucla.edu>
153 * Makefile.maint (CVS_LIST): Don't assume cvsu is available.
154 (CVS_LIST_EXCEPT): New macro, to simplify exception-processing.
155 Most uses of CVS_LIST changed to use CVS_LIST_EXCEPT.
156 (syntax-check-rules): Bring back sc_changelong. (Hmm, why did it
157 go away? was that an accident?)
158 (sc_cast_of_argument_to_free, sc_cast_of_x_alloc_return_value):
159 (sc_cast_of_alloca_return_value, sc_space_tab, sc_prohibit_atoi_atof):
160 (sc_error_exit_success, sc_file_system, sc_no_if_have_config_h):
161 (sc_system_h_headers, sc_sun_os_names, sc_trailing_blank):
162 (sc_two_space_separator_in_usage, sc_unmarked_diagnostics):
163 (sc_obsolete_symbols, sc_changelog, sc_prohibit_jm_in_m4):
164 (sc_useless_cpp_parens, makefile-check, m4-check, po-check):
165 (author_mark_check, makefile_path_separator_check):
166 Output line numbers, to simplify navigation of Emacs *compilation*
168 (sc_prohibit_atoi_atof, sc_file_system):
169 Rework slightly so that Makefile.maint doesn't get reported as a
170 violation of its own syntax rules.
171 (sc_dd_max_sym_length): Use ifneq to do nothing, instead of doing
172 it at run-time (which didn't work with Bison). Fix a makefile typo,
173 caught by Makefile.maint itself: spaces where a tab should be.
174 (po-check): Check lib/*.[ch] even if not in CVS; used by Bison,
175 which copies from ../gnulib/lib/*.[ch] to lib/*.[ch].
176 Ignore djgpp and man subdirectories, to avoid false matches with
177 Bison and coreutils, respectively. Use sort -u to remove the
178 resulting duplicates.
179 * gnupload: Rework slightly to avoid bogus warning from
180 sc_two_space_separator_in_usage.
182 2006-02-10 Jim Meyering <jim@meyering.net>
184 Use gzip's --rsyncable option only if it's available.
185 * Makefile.maint (gzip_rsyncable): New variable.
188 2006-02-08 Jim Meyering <jim@meyering.net>
190 * Makefile.maint (local-checks-available): Define in terms of
191 the expansion, $(syntax-check-rules), rather than the single,
192 top-level target `syntax-check', so that it's easier to exclude
193 individual rules (via $(local-checks-to-skip)).
194 (tgz-md5, tgz-sha1, ...): Remove now-unused definitions.
196 2006-02-07 Jim Meyering <jim@meyering.net>
198 * src/system.h (!defined O_DIRECT): If O_DIRECTIO is defined (as it
199 is on Tru64), define O_DIRECT to that. Patch From James Lemley.
201 * tests/help-version (expected_failure_status_vdir):
202 Redirect an expected disk-full diagnostic to /dev/null.
204 2006-02-06 Jim Meyering <jim@meyering.net>
206 * src/unexpand.c (usage): Use two spaces (not one) to separate the
207 --first-only option string from its description, so help2man formats
208 the derived man page properly.
209 * src/rm.c (usage): Likewise for --no-preserve-root.
210 * src/chown.c (usage): Likewise.
211 * src/chgrp.c (usage): Likewise.
213 Add a rule to ensure that the above doesn't happen again.
214 * Makefile.maint (sc_two_space_separator_in_usage): New rule.
215 (syntax-check-rules): Add it.
216 * .x-sc_two_space_separator_in_usage: New empty file.
217 * Makefile.am (EXTRA_DIST): Add .x-sc_two_space_separator_in_usage.
219 2006-02-06 Jim Meyering <jim@meyering.net>
221 * src/cp.c (usage): Use two spaces (not one) to separate each
222 option string from its description, so help2man formats the
223 derived man page properly.
224 * src/mv.c (usage): Likewise.
225 Patch from Nicolas François in http://bugs.debian.org/351601.
227 2006-02-04 Jim Meyering <jim@meyering.net>
229 * src/copy.c (copy_internal): cp -RL would fail when encountering
230 the same directory more than once in the hierarchy beneath a single
231 command-line argument. That is legitimate, e.g. when there are
232 two or more symbolic links, each pointing to some directory that
233 would not otherwise be copied. Reported by Christophe LYON.
234 * tests/cp/cp-deref: New file. Test for today's fix.
235 * tests/cp/Makefile.am (TESTS): Add cp-deref.
236 * NEWS: Document this.
238 2006-02-03 Jim Meyering <jim@meyering.net>
240 * configure.ac: Require automake-1.9.6, not 1.8.3.
242 2006-02-01 Paul Eggert <eggert@cs.ucla.edu>
244 * src/od.c (usage): Mention that -t a ignores high order bit.
245 Documentation problem reported by Ed Avis.
247 2006-02-01 Jim Meyering <jim@meyering.net>
249 * src/pwd.c (find_dir_entry): Remove unused local, `ent_sb_valid'.
251 2006-01-30 Paul Eggert <eggert@cs.ucla.edu>
253 * src/head.c (main): Use a better diagnostic when someone uses a
254 trailing numeric option in an invalid way. Problem reported by
256 * src/tail.c (parse_options): Likewise.
258 2006-01-30 Jim Meyering <jim@meyering.net>
260 * man/wc.x: Include `count' keyword in man page synopsis,
261 per suggestion from http://bugs.debian.org/181585.
263 2006-01-24 Paul Eggert <eggert@cs.ucla.edu>
265 * src/df.c (show_dev): If the file system claims to have
266 more available than total blocks, report the number of used
267 blocks as being total - available (a negative number) rather
268 than as garbage. Problem reported by Toralf Foerster.
270 2006-01-24 Jim Meyering <jim@meyering.net>
272 * src/tail.c (tail_forever): Don't exit-nonzero when an attempt
273 to put a regular file in O_NONBLOCK mode fails with EPERM.
274 That happens on Linux (up to 2.6.15) when using tail -f on a file with
275 the append-only attribute. Reported by Dean Gaudet. For details,
276 see http://savannah.gnu.org/bugs/?func=detailitem&item_id=15473.
277 * NEWS: Mention this fix.
278 * tests/tail-2/append-only: New file. Test for the above.
279 * tests/tail-2/Makefile.am (TESTS): Add append-only.
280 * tests/Makefile.am (check-root): Add tail-2/append-only
282 2006-01-21 Jim Meyering <jim@meyering.net>
284 * NEWS: Mention fts-related improvements and bug fixes.
286 2006-01-19 Jim Meyering <jim@meyering.net>
288 * tests/fmt/basic (pfx-1, pfx-2): New tests, to demonstrate the bug
289 reported as http://bugs.debian.org/147577. Forwarded by Thomas Hood.
291 2006-01-18 Jim Meyering <jim@meyering.net>
293 * tests/du/Makefile.am (TESTS): Add long-from-unreadable.
295 2006-01-17 Jim Meyering <jim@meyering.net>
297 Now that fts no longer changes the current working directory, adjust
298 its clients accordingly -- note that du.c uses fts but doesn't need
299 any adjustment, since it doesn't operate on the actual files,
300 but rather just uses the stat buffers provided by fts.
302 * src/chown-core.c: Include "openat.h".
303 Don't include "lchown.h".
304 (restricted_chown): Accept a new parameter, CWD_FD, and use it in
305 calling openat, lchownat, chownat, rather than open, lchown, chown.
307 * src/chmod.c: Include "openat.h".
308 (process_file): Use chmodat (fts->fts_cwd_fd,... in place of chmod (...
310 * tests/du/long-from-unreadable: New test, to exercise one small
313 2006-01-13 Jim Meyering <jim@meyering.net>
315 * tests/Makefile.am (SUBDIRS): Add comments discouraging the
316 addition of new directories under tests/.
318 * tests/acl: Redirect stdin to /dev/null. Otherwise, FreeBSD 5.0's
321 2006-01-12 Jim Meyering <jim@meyering.net>
323 * tests/du/long-sloop: Adjust not to hard-code the expected
324 diagnostic corresponding to ELOOP. Solaris' diagnostic differs
325 from that of GNU libc. Reported by Paul Eggert.
327 * tests/du/long-sloop: Create file at end of symlink chain.
329 * tests/misc/test: New file, with a test for one of the
330 bugs fixed by yesterday's test.c changes.
331 * tests/misc/Makefile.am (TESTS): Add test.
333 2006-01-11 Jim Meyering <jim@meyering.net>
335 * tests/du/long-sloop: New file. Test for today's fts.c bug fix.
336 That bug could make du -L, chgrp -L, or chown -L fail to diagnose
337 a very long sequence of symbolic links (not necessarily a loop).
338 * tests/du/Makefile.am (TESTS): Add long-sloop.
340 2006-01-11 Paul Eggert <eggert@cs.ucla.edu>
342 * src/test.c (test_syntax_error): Append a newline. All callers
343 changed, except for the ones that didn't already append a newline.
344 Bug reported by Eric Blake.
346 2006-01-11 Jim Meyering <jim@meyering.net>
348 * src/system.h (X2NREALLOC): Now that verify_true is no longer
349 void, cast its result to void, to avoid gcc's warning that
350 ``left-hand operand of comma expression has no effect''.
351 (DECIMAL_DIGIT_ACCUMULATE, X2REALLOC): Likewise.
353 2006-01-10 Jim Meyering <jim@meyering.net>
355 * tests/chmod/no-x: Add a test for today's fts.c fix.
357 2006-01-10 Jim Meyering <jim@meyering.net> (tiny change)
359 * src/ls.c (gobble_file): Use DTTOIF only if it's defined.
360 This is necessary for Dragonfly. Patch by Joerg Sonnenberger.
362 2006-01-10 Paul Eggert <eggert@cs.ucla.edu>
364 * src/system.h (X2NREALLOC, X2REALLOC, DECIMAL_DIGIT_ACCUMULATE):
365 Use verify_true instead of verify_expr, to sync with gnulib.
367 2006-01-08 Jim Meyering <jim@meyering.net>
369 * src/date.c (usage): Adjust the formatting of the entries for
370 %::z and %:::z (separate with two spaces, not one) so that help2man
371 formats them properly. Reported by Philip Rowlands.
373 2006-01-06 Paul Eggert <eggert@cs.ucla.edu>
375 * configure.ac (gl_IGNORE_UNUSED_LIBRARIES): Add.
377 2006-01-06 Jim Meyering <jim@meyering.net>
379 * Makefile.maint (copyright-check): Use date +%Y in place of
382 * src/remove.c (rm_1): Remove `static' attribute on local `status'.
383 First off, the attribute should have been `volatile' (not static)
384 to avoid longjmp-related risk of clobber. Secondly, now there is
385 no longer any risk of a local variable being clobbered, so there's
386 no need for any attribute at all.
388 2006-01-05 Jim Meyering <jim@meyering.net>
390 * src/remove.c: Give a few functions the inline attribute.
391 (AD_pop_and_chdir): Use gotos to avoid some duplication.
392 (AD_push): Rewrite an assertion so that the entire computation
393 goes away when assertions are turned off.
395 * src/tail.c (ENOSYS) [!defined ENOSYS]: Don't define here.
396 It's already defined in "system.h".
397 * Makefile.maint: Add a FIXME comment.
399 2006-01-04 Jim Meyering <jim@meyering.net>
401 * ChangeLog: Remove entries from 2005-10-22 and earlier.
402 * ChangeLog-2005: New file, for entries up to version 5.92.
404 2006-01-03 Jim Meyering <jim@meyering.net>
406 * tests/du/no-x: Also allow a slightly different diagnostic -- the
407 one you get when using openat-enabled fts.c and du (coming soon).
408 * tests/chmod/no-x: Likewise.
409 * tests/chgrp/no-x: Likewise.
411 * src/system.h (O_DIRECTORY) [!defined O_DIRECTORY]: Define.
413 2006-01-02 Paul Eggert <eggert@cs.ucla.edu>
415 * src/chown-core.c (RC_do_ordinary_chown): New enum value.
416 (restricted_chown): Return it, if the file cannot be accessed due
417 to EPERM, or if no uid or gid are required, or if the file is
418 neither a directory nor a regular file. Rewrite to avoid gotos.
419 (change_file_owner): Handle RC_do_ordinary_chown case.
420 Rewrite to avoid gotos.
421 * tests/chgrp/basic: Make sure we can change the group of
424 * src/date.c (usage): Explain %g, %G, and %V a bit better.
426 2006-01-02 Jim Meyering <jim@meyering.net>
428 * src/copy.c (set_owner): Correct a comment.
430 * src/tail.c (parse_options): Change warning to say that --retry
431 is useful `mainly' (not `only') when following by name.
432 Reported here: http://bugs.debian.org/273781
434 2006-01-01 Paul Eggert <eggert@cs.ucla.edu>
436 * NEWS: Document that mkfifo and mknod -m no longer set special bits.
437 * src/copy.c: Include lchmod.h.
438 (copy_internal): Use lchmod rather than chmod.
439 * src/cp.c: Include lchmod.h.
440 (re_protect, make_dir_parents_private): Use lchmod rather than chmod.
441 * src/mkdir.c: Include lchmod.h.
442 (usage): Clarify -m's operation.
443 (main): Use lchmod rather than chmod. Don't use lchmod unless the
444 new mode contains bits outside the 777 range.
445 * src/mkfifo.c (usage): Clarify -m's operation.
446 (main): If -m is given, don't invoke chmod; use umask 0 instead.
447 Report an error if -m asks for bits outside the 777 range.
448 * src/mknod.c (usage, main): Likewise.
450 * src/mkdir.c, src/mkfifo.c, src/mknod.c: Undo 2005-12-19 changes.
452 2005-12-27 Jim Meyering <jim@meyering.net>
454 * Makefile.maint (sc_obsolete_symbols): Prohibit use of O_NDELAY.
455 (sc_prohibit_assert_without_use): New rule.
456 (syntax-check-rules): Add it to the list.
457 * .x-sc_prohibit_assert_without_use: New empty file.
458 * Makefile.am (EXTRA_DIST): Add it.
460 * Makefile.maint (CVS_LIST): Define in terms of $(srcdir).
462 * cp.c, df.c, link.c, mknod.c, nice.c, sleep.c, unlink.c:
463 Don't include <assert.h>; it wasn't used.
465 2005-12-26 Paul Eggert <eggert@cs.ucla.edu>
467 * src/chown-core.c (restricted_chown):
468 Don't try O_WRONLY unless O_RDONLY failed wth EACCES.
469 * src/remove.c (fd_to_subdirp): Open with O_DIRECTORY | O_NOCTTY
470 | O_NOFOLLOW too, for consistency with other dir-openers.
471 Use POSIX-preferred O_NONBLOCK rather than O_NDELAY.
472 (is_empty_dir): Likewise.
473 * src/shred.c (wipename): Likewise. Don't bother trying to open
474 dir for writing, since POSIX prohibits it.
476 2005-12-22 Jim Meyering <jim@meyering.net>
478 * tests/help-version: Redirect stderr to /dev/full, to suppress
479 write error diagnostic.
481 2005-12-19 Jim Meyering <jim@meyering.net>
483 * src/mkdir.c, src/mknod.c, src/mkfifo.c (main)
484 Avoid a minor race condition when `-m MODE' is specified, by using
485 open, fchown, and close rather than just chown. To do that reliably --
486 even with an overly restrictive umask -- ensure that each mkdir,
487 mknod and mkfifo call uses a mode including at least owner-read access.
488 * src/mknod.c (main): When `-m MODE' is specified, exit nonzero if
489 the subsequent chown (or equivalent open,fchown,close) fails.
490 * tests/misc/mknod: New tests.
491 * tests/misc/Makefile.am (TESTS): Add mknod.
493 2005-12-17 Jim Meyering <jim@meyering.net>
495 * src/remove.c (is_empty_dir): Open with O_NDELAY, so we don't hang,
496 e.g., on a named pipe.
497 (OPEN_NO_FOLLOW_SYMLINK): Remove definition. Use O_NOFOLLOW in
498 place of all uses, since it is guaranteed (system.h) to be defined.
500 2005-12-05 Andreas Gruenbacher <agruen@suse.de>
502 Add POSIX ACL support
503 * src/ls.c: Switch back from HAVE_ACL to USE_ACL: The acl() syscall
504 is no requirement for ACL support; particularly, it does not exist
505 on systems that have POSIX ACLs.
506 * src/copy.h (cp_option_init) [umask_kill]: Remove member.
507 * src/cp.c (umask_kill): With default acls, the umask is not to be
508 applied. Remove umask_kill, don't change the process umask, and let
509 the kernel apply the umask where appropriate.
510 * src/cp.c (make_dir_parents_private): Fix logic for POSIX ACLs.
511 * src/copy.c (get_dest_mode): Remove; it is obsolete after removing
513 (copy_reg, copy_internal): Use copy_acl and set_acl
514 instead of fchown/chown. Fix the logic for POSIX ACLs.
515 (chown_succeded): Remove; we now always copy acls and
516 preserve S_ISUID, S_ISGID, and S_ISVTX when needed, no matter if we
517 did a chown before or not.
518 * src/mv.c, src/install.c (cp_option_init): Don't set umask_kill member.
519 * src/Makefile.am (dir_LDADD, ls_LDADD, vdir_LDADD, cp_LDADD,
520 mv_LDADD, ginstall_LDADD): On systems with an ACL library, arrange
521 to link with it via $(LIB_ACL), for the utilities that need it.
523 2005-12-16 Paul Eggert <eggert@cs.ucla.edu>
525 * src/remove.c (OPENAT_CWD_RESTORE__REQUIRE): Remove.
526 (OPENAT_CWD_RESTORE__ALLOW_FAILURE): Likewise.
527 (fd_to_subdirp): Remove openat_cwd_restore_allow_failure arg; its
528 value is now signified by whether cwd_errno is null.
529 (fd_to_subdirp, remove_dir, rm_1); Change cwd failure indicator from
530 pointer-to-bool to pointer-to-errno-value. All callers changed.
531 (rm_1): Don't bother setting a local cwd failure flag and then
532 ORing it into the caller's. Just set the caller's.
533 (rm): Use cwd failure errno value to print a slightly-better
536 2005-12-15 Jim Meyering <jim@meyering.net>
538 * src/stat.c (print_it): Properly handle a backslash at the
539 end of a --printf format string. Reported by Paul Eggert.
540 * tests/misc/stat-printf (end-bs): Add a test for the above.
542 2005-12-15 Paul Eggert <eggert@cs.ucla.edu>
544 * tests/acl: Port to pre-POSIX shells like Solaris 8 /bin/sh.
545 Don't assume /etc/passwd contains user names; use 'id' instead.
547 2005-12-15 Jim Meyering <jim@meyering.net>
549 stat: revert behavior of --format=FMT (-c)
550 stat: add new option: --printf=FMT
551 * NEWS: Mention this.
552 * src/stat.c (isodigit, octtobin, hextobin): Define.
553 (PRINTF_OPTION): Define.
554 (interpret_backslash_escapes, trailing_delim): New globals.
555 (usage): Document them. Alphabetize on long option names.
556 (print_esc_char): New function.
557 (print_it): Rewrite, in order to handle backslash escapes.
558 (main): Handle new option. Set globals for --format, too.
560 * tests/misc/stat-printf: Test --printf and --format.
561 * tests/misc/Makefile.am (TESTS): Add stat-printf.
563 2005-12-14 Paul Eggert <eggert@cs.ucla.edu>
565 * NEWS: sort now reports incompatible options.
566 * src/sort.c (incompatible_options, check_ordering_compatibility):
568 (main): Use them. Don't bother with a usage message for
569 "sort -c a b", for consistency with other error diagnostics.
570 * tests/sort/Test.pm (incompat1, incompat2, incompat3, incompat4):
573 * src/cat.c (main): Undo previous change. close_stdout already
574 does the check, so the previous change wasn't necessary.
576 2005-12-13 Paul Eggert <eggert@cs.ucla.edu>
578 * src/cat.c (main): Check for close (STDOUT_FILENO) failure.
580 2005-12-12 Paul Eggert <eggert@cs.ucla.edu>
582 Install a more-conservative approach for sort -R. It's the
583 same basic idea as the existing code, except it uses the full ISAAC
584 approach (called the "more kosher" approach in the existing comments).
585 This makes "sort -R" quite a bit slower (about a factor of 2 on my
586 little tests involving 10000 lines on a 2.4 GHz P4), but I think it's
587 better to be conservative here at first, and review any performance
588 improvements carefully.
589 * .x-sc_require_config_h: Add src/rand-isaac.c.
590 * src/rand-isaac.h: Remove. All uses now simply include rand-isaac.c.
591 * src/Makefile.am (noinst_HEADERS): Remove rand-isaac.h.
592 (shred_SOURCES, sort_SOURCES): Remove.
593 (EXTRA_DIST): Add rand-isaac.c.
594 * src/rand-isaac.c: Revert to what used to be in shred.c, without
595 changing it to allow for varying numbers of words in the state.
596 Alter so that we include rand-isaac.c directly rather than
597 compiling it and linking to it. Don't include config.h or
598 system.h; that's the includer's responsibility.
599 Omit functions that are specific to shred.
600 (ISAAC_LOG, ISAAC_WORDS, ISAAC_BYTES, struct isaac_state, ind):
601 (isaac_step, struct irand_state):
602 Resurrect these, with the same defns that used to be in shred.c.
603 (ISAAC_SIZE, isaac_new, isaac_copy): Remove.
604 (isaac_refill, isaac_seed_start, isaac_seed_data, irand_init, irand32):
606 (struct isaac_state, isaac_refill, isaac_mix, isaac_init):
607 (isaac_seed_start, isaac_seed_data, isaac_seed_finish, isaac_seed):
608 (irand_init, irand32, irand_mod):
609 Number of words is constant again.
610 (struct irand_state, irand_init, irand32, irand_mod): Move to shred.c.
611 * src/shred.c: Include rand-isaac.c rather than rand-isaac.h.
612 * src/sort.c: Likewise.
613 * src/shred.c (fillrand, dopass, main): Undo previous change.
614 (struct irand_state, irand_init, irand32, irand_mod): Moved back here,
616 * src/sort.c: Don't include md5.h; it wasn't needed.
617 (struct keyfield): Rename random_hash to random, for consistency
618 with the other member names. All uses changed.
619 (usage): Tweak wording to mention STRING for --seed option.
620 (short_options): Rorder for consistency with other programs.
621 (rand_state): Now a struct, not a pointer to one. All uses changed.
622 (HASH_WORDS, HASH_SIZE): Remove.
623 (get_hash): Remove comments around resbuf size, since we can assume C89.
624 Use a "more-kosher" (but slower) approach of invoking isaac_refill.
625 (keycompare): Adjust to the new get_hash.
627 (badfieldspec): Omit recently-introduced comment; it isn't needed.
628 (main): Don't set need_random simply because gkey has it set; that
629 doesn't necessarily mean we'll need random numbers.
630 Redo seeding to match new get_hash approach.
632 2005-12-10 Jim Meyering <jim@meyering.net>
634 * src/Makefile.am (noinst_HEADERS): Add rand-isaac.h.
636 Avoid shred segfault on 64-bit systems.
637 * src/rand-isaac.c (isaac_refill): Don't try to negate a
638 local of type uint32_t. Make the local an `int' instead.
640 * NEWS: Mention sort's new options.
642 * src/rand-isaac.c (isaac_mix): Declare to be static.
643 Mark all other functions as `extern' so the tight-scope
644 part of `make distcheck' passes once again.
645 * src/rand-isaac.h (isaac_mix): Remove declaration.
647 * src/sort.c (get_hash): Change position of `*' in parameter
648 type to conform with convention.
649 (main): Split a long line so it fits in 80 columns.
650 (keycompare): Remove stray SPACE before TAB that was
651 causing `make distcheck' to fail.
653 * src/shred.c: Don't include gethrxtime.h. No longer needed.
655 * tests/misc/sort-rand: New file: basic tests for the new options.
656 * tests/misc/Makefile.am (TESTS): Add sort-rand.
658 2005-12-10 Frederik Eaton <frederik@ofb.net>
660 * src/Makefile.am (sort_LDADD): Add $(LIB_GETHRXTIME).
661 (shred_SOURCES, sort_SOURCES): New macros, so we compile rand-isaac.c.
662 * src/rand-isaac.c: New file, containing ISAAC code that was in shred.c.
663 Make state size runtime-configurable.
664 (isaac_new, isaac_copy): New functions.
665 * src/rand-isaac.h: New file.
666 * src/shred.c: Include rand-isaac.h. Move ISAAC code to rand-isaac.c.
667 (fillrand, main): Adjust to the fact that the state size is now
668 runtime-configurable.
669 * src/sort.c (short_options, long_options, WORDS, keycompare, main):
670 (usage): Add options --random-sort and --seed to implement a random
672 Include md5.h and rand-isaac.h.
673 (get_hash): New function.
674 (rand_state): New var.
675 (HASH_WORDS, HASH_SIZE): New macros.
677 2005-12-09 Paul Eggert <eggert@cs.ucla.edu>
679 * tests/dd/misc: Add test for dd iflags=noatime.
681 2005-12-09 Jim Meyering <jim@meyering.net>
683 * src/sort.c (usage): Mention white space vs -b and -t options.
686 2005-12-09 Eric Blake <ebb9@byu.net>
688 * src/test.c (main): Fix misleading comment.
690 2005-12-07 Paul Eggert <eggert@cs.ucla.edu>
692 * NEWS: Mention dd's new noatime flag.
693 * src/system.h (O_NOATIME): Define to 0 if not already defined.
694 * src/dd.c (flags, usage): Add support for noatime flag.
696 2005-12-07 Jim Meyering <jim@meyering.net>
698 Distribute the cvsu script, used only by `make syntax-check'.
699 * Makefile.am (EXTRA_DIST): Add build-aux/cvsu.
700 * Makefile.maint (CVS_LIST): Use build-aux/cvsu, now that we
701 distribute a copy of this script.
702 * .x-sc_unmarked_diagnostics: Add build-aux/cvsu.
704 * tests/mv/acl: exit-77 before the trap, not after, if we fail
705 to create a temporary directory on another partition.
706 From Andreas Gruenbacher.
708 2005-12-06 Tomas Pospisek <tpo@sourcepole.ch> (tiny change)
710 * man/basename.x: Cross-reference to dirname and readlink.
711 * man/dirname.x: Cross-reference to basename and readlink.
713 2005-12-05 Andreas Gruenbacher
715 * src/copy.c [!HAVE_FCHOWN]: Define fchown(...) to -1.
716 (set_owner, preserve_author): New functions, factored out of copy_reg.
717 (copy_reg): Use them.
718 (copy_internal): Use them here, too.
720 2005-12-04 Jim Meyering <jim@meyering.net>
722 * src/sleep.c (usage): Say what happens with two or more arguments.
723 Suggested by Justin Pryzby.
725 * src/uptime.c (print_uptime): Move decl of `upsecs' into scope
728 2005-12-03 Jim Meyering <jim@meyering.net>
730 * src/rm.c (long_opts): Change the name of each undocumented, for-
731 testing-only option to start with `-', so that it cannot render
732 ambiguous any prefix it happens to share with some other option name.
733 Problem reported by Eric Blake.
734 * src/head.c (long_options): Likewise.
735 * src/tail.c (long_options): Likewise.
737 * tests/misc/head-elide-tail: Update uses of undocumented, for-
738 testing-only --presume* options to start with `---'.
739 * tests/rm/dangling-symlink: Likewise.
740 * tests/rm/dir-no-w: Likewise.
741 * tests/rm/isatty: Likewise.
743 2005-11-30 Jim Meyering <jim@meyering.net>
745 * Makefile.maint: Add a comment about cvsu.
747 2005-11-25 Paul Eggert <eggert@cs.ucla.edu>
749 * NEWS: df updates for "none", "proc", inaccessible file systems.
750 * src/df.c (show_point): Ignore inaccessible file systems.
751 (usage): -a includes dummy file systems, not size-0 file systems.
753 * src/od.c (unsigned_long_long_int): Renamed from ulonglong_t,
754 to avoid collision with POSIX name space. All uses changed.
756 2005-11-24 Jim Meyering <jim@meyering.net>
758 * tests/Makefile.am (EXTRA_DIST): Add acl to the list.
759 * tests/acl: Add `$0: ' prefix to diagnostics.
761 * .x-sc_require_config_h: Add lib/buffer-lcm.c to the list.
763 2005-11-23 Paul Eggert <eggert@cs.ucla.edu>
765 * src/copy.c: Improve performance a bit by optimizing away
766 unnecessary system calls and going to a block size of at least
767 8192 (on normal hosts, anyway). This improved performance 5% on my
768 Debian stable host (2.4.27 kernel, x86, copying from root
769 ext3 file system to itself).
770 Include "buffer-lcm.h".
771 (copy_reg): Omit last argument. All callers changed.
772 Use xmalloc to allocate rather than trusting alloca
773 (which is unwise with large block sizes).
774 Declare locals more locally, if possible.
775 Use uintptr_t words instead of int words, for a bit more speed
776 when looking for null blocks on 64-bit hosts.
777 Optimize away reads of zero bytes on regular files.
778 In the typical case, insist on 8 KiB buffers, at least.
779 Avoid unnecessary extra call to fstat when checking for sparse files.
780 Avoid now-unnecessary cast to off_t, and "0L".
781 Avoid unnecessary test of *new_dst when checking for same owner
784 2005-11-22 Paul Eggert <eggert@cs.ucla.edu>
786 * src/remove.c (rm): Don't assume C99 for-loop syntax.
788 2005-11-22 Jim Meyering <jim@meyering.net>
790 * src/remove.c (AD_push): Remove debugging cruft.
792 * tests/rm/unread2 (rm): Change expected diagnostic,
793 `cannot open directory' to `cannot remove', to align with
795 * tests/rm/rm2: Ensure that rm now continues removing entries
796 even after certain types of failure.
798 * src/remove.c: Rewrite. Now, this module is reentrant on systems
799 that provide openat (Solaris), and on systems like Linux+procfs
800 where our openat emulation code is reentrant. This also fixes a
801 few low-probability leaks and eliminates some code that could,
802 in very unusual circumstances, cause rm() (via a callee) to exit.
803 * NEWS: Mention this.
805 * configure.ac: Put copyright dates all on one line so the
806 emacs function that updates them works properly.
808 2005-11-18 Paul Eggert <eggert@cs.ucla.edu>
810 * configure.ac (AM_PROG_CC_C_O): Add. Needed for CVS Automake.
811 Problem reported by Eric Blake.
812 (AC_PROG_CC_STDC): Use this instead of AC_PROG_CC, so that
813 we get a standard-conforming compiler. This relies on the new
814 m4/c.m4 file. Note that it's a bit tricky, since c.m4 doesn't
815 define AC_PROG_CC_STDC; we are relying on Autoconf 2.59 internals.
816 m4/c.m4 can go away with Autoconf 2.60 comes out.
818 2005-11-17 Jim Meyering <jim@meyering.net>
820 * src/remove.c (AD_mark_helper): Make a `char *' parameter `const'.
821 (AD_mark_current_as_unremovable): Likewise, but for a local.
824 * tests/mv/acl: Let traps handle removing temporary directories.
826 Expect acl-related tests to fail, until the corresponding
827 patches are committed.
828 * tests/mv/Makefile.am (XFAIL_TESTS): Add acl.
829 * tests/cp/Makefile.am (XFAIL_TESTS): Likewise.
831 ACL tests, from Andreas Gruenbacher.
832 * tests/acl, tests/mv/acl, tests/cp/acl: New files.
833 * tests/mv/Makefile.am (TESTS): Add acl.
834 * tests/cp/Makefile.am (TESTS): Add acl.
836 * src/ls.c (basename_is_dot_or_dotdot): Correct wording in comment.
838 2005-11-16 Paul Eggert <eggert@cs.ucla.edu>
840 * NEWS: Improve quality of ln's diagnostics.
841 * src/ln.c (do_link, usage): Likewise.
842 (do_link): Don't use alloca on a buffer of unbounded size.
844 2005-11-16 Jim Meyering <jim@meyering.net>
846 * tests/cp/fail-perm: Accommodate HPUX. It appears to fail
847 with EACCES rather than EPERM. Reported by Peter O'Gorman here:
848 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/5766
850 2005-11-14 Jim Meyering <jim@meyering.net>
852 * NEWS (sort): Mention consequences of today's mkstemp-safer.c fix.
854 2005-11-13 Jim Meyering <jim@meyering.net>
856 * announce-gen: Accept new option, --gpg-key-id=ID and
857 emit a blurb telling how to use the .sig files.
858 * Makefile.cfg (gpg_key_ID): Define.
859 * Makefile.maint (announcement): Use new option and key.
861 Require that most .c files include <config.h>.
862 * Makefile.maint (sc_require_config_h): New rule.
863 (syntax-check-rules): Add it.
864 * .x-sc_require_config_h: New file listing exceptions to the
865 above rule. Some are legit, others are simply grandfathered in.
866 * Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h here, too.
868 2005-11-12 Jim Meyering <jim@meyering.net>
870 * src/checksum.h, src/md5.c, src/sha1sum.c: Remove now-unused files.
872 2005-11-11 Jim Meyering <jim@meyering.net>
874 * NEWS: Mention `readlink -f' bug fix in 5.3.0 news.
875 Mention new readlink options in 5.3.0's `New features' section.
876 Spotted by Thomas Hood.
878 2005-11-08 Jim Meyering <jim@meyering.net>
880 * NEWS: Merge in changes from b5_9x branch.
882 2005-11-08 Paul Eggert <eggert@cs.ucla.edu>
884 * NEWS: ls now defaults to --time-style='locale', which in turn acts
885 like --time-style='posix-long-iso' if the locale settings are messed up.
886 * src/ls.c (decode_switches): Implement this.
888 2005-11-08 Jim Meyering <jim@meyering.net>
890 * tests/du/2g: s/expensive/very expensive/ in a comment.
893 2005-10-17 Eric Blake <ebb9@byu.net>
895 * src/ls.c (usage): Fix descriptions of --sort, --time.
896 Reported by Vitaly A. Ostanin.
898 2005-11-04 Paul Eggert <eggert@cs.ucla.edu>
900 * src/ln.c: Include filenamecat.c.
901 (FILE_BASENAME_CONCAT): Remove.
902 (do_link): Remove last arg DEST_IS_DIR. All callers changed.
903 (main): Use file_name_concat, base_name, and strip_trailing_slashes
904 instead of FILE_BASENAME_CONCAT. This simplifies the code, and avoids
907 2005-11-04 Jim Meyering <jim@meyering.net>
909 * src/du.c (process_file): Don't overflow for files of size >= 2^31
910 on systems with stat.st_blocks of a signed 32-bit type.
911 This bug causes trouble on some AIX 5.1 systems.
912 Report and trivial patch from Paul Townsend:
913 <http://lists.gnu.org/archive/html/bug-coreutils/2005-11/msg00033.html>
914 * NEWS: Mention this.
916 * tests/du/2g: New (very-expensive) test for the above-fixed bug.
917 * tests/du/Makefile.am (TESTS): Add it here.
918 * tests/very-expensive: New file.
919 * tests/Makefile.am (EXTRA_DIST): Add it here.
920 * tests/cp/perm: Mark this test as `very-expensive', too.
922 2005-11-02 Paul Eggert <eggert@cs.ucla.edu>
924 * NEWS: Mention that rm -d and maybe ln -d are scheduled for
926 * src/remove.h (struct rm_options): Remove unlink_dirs. All uses
928 * src/rm.c (usage): Don't mention rm -d.
930 2005-11-02 Jim Meyering <jim@meyering.net>
932 * tests/dd/skip-seek: Fix typo in comment: s/fileutils/coreutils.
935 * tests/dd/unblock-sync: Redirect stderr to /dev/null so the
936 `M+N records in/out' lines don't pollute `make check' output.
938 * tests/dd/skip-seek (sk-seek4): New test, to exercise the bug
939 fixed on 2005-10-31. This test uses the new, IN_PIPE specifier.
940 * tests/Coreutils.pm: Accept a new type of input specifier: IN_PIPE,
941 to indicate that the input file should be piped into the command
942 under test (via `cat FILE | $prog ...').
944 * src/remove.c (remove_entry): Emit a better diagnostic when rm
945 (without -r) fails to remove a directory on a non-Linux system.
946 This change affects only newer Solaris systems (with priv_*
947 functions like priv_allocset). Reported by Keith Thompson.
949 * tests/rm/dir-nonrecur: New file/test for the above fix.
950 * tests/rm/Makefile.am (TESTS): Add dir-nonrecur.
952 2005-11-01 Paul Eggert <eggert@cs.ucla.edu>
954 * NEWS: "tail -c 2 FILE" and "touch 0101000000" now operate as
955 POSIX 1002.1-2001 requires.
956 * src/tail.c (parse_obsolete_option): Implement this.
957 Problem reported by Vincent Lefevre.
958 * src/touch.c (main): Pass PDS_PRE_2000 to posixtime.
959 * tests/tail/Test.pm (c-2, c-2-minus, c2, c2-minus): New tests.
960 (test_vector): Add special cases for _POSIX2_VERSION, and
961 regularize the old ones a bit.
962 * tests/touch/obsolescent: Add y2000 test.
964 2005-10-31 Paul Eggert <eggert@cs.ucla.edu>
966 * src/dd.c (skip): Fix off-by-one error reported by
967 Theodoros V. Kalamatianos.
969 2005-10-30 Paul Eggert <eggert@cs.ucla.edu>
971 * tests/mkdir/p-3: Require that the test be run as non-root.
972 Problem and trivial fix reported by Theodoros V. Kalamatianos.
974 2005-10-28 Paul Eggert <eggert@cs.ucla.edu>
976 * src/ln.c (FILE_BASENAME_CONCAT): Omit unnecessary slashes in the
977 boundary between DEST and SOURCE in the result.
979 2005-10-26 Dmitry V. Levin <ldv@altlinux.org>
981 * src/md5sum.c (main) [!O_BINARY]: Changed default read mode
982 back to text, to sync with documentation and for backwards
985 2005-10-25 Jim Meyering <jim@meyering.net>
987 * tests/dircolors/simple (other-wr): Add an explicit test for
988 the dircolors bug (NULL-dereference) fixed yesterday.
990 2005-10-24 Jim Meyering <jim@meyering.net>
992 * src/tac.c (tac_file): When determining whether a file is seekable,
993 also test whether it is a tty. Using only the lseek-based test would
994 give a false positive on Solaris. Reported by Peter Fales.
996 2005-10-24 Dmitry V. Levin <ldv@altlinux.org>
998 * tests/install/d-slashdot: New test, for "install -d" failure.
999 * tests/install/Makefile.am (TESTS): Add d-slashdot.
1000 * tests/mkdir/p-slashdot: New test, for "mkdir -p" failure.
1001 * tests/mkdir/Makefile.am (TESTS): Add p-slashdot.
1003 2005-10-24 Jim Meyering <jim@meyering.net>
1005 * src/dircolors.c (ls_codes): Add missing comma.
1006 Anonymous report and patch from
1007 http://savannah.gnu.org/bugs/?func=detailitem&item_id=14849
1009 * src/dircolors.c: Add compile-time assertion that the slack_codes
1010 and ls_codes arrays have the same number of elements. This would
1011 have prevented the above-fixed bug.
1013 * src/expand.c (parse_tab_stops): Add a comment to make this function
1014 identical to the one in unexpand.c.
1015 * src/unexpand.c (parse_tab_stops): Adjust syntax to make this function
1016 identical to the one in expand.c.
1018 * src/expand.c (next_file): Don't assume fopen cannot return stdin.
1020 2005-10-23 Jim Meyering <jim@meyering.net>
1022 * src/md5sum.c (digest_check, main): Use ptr_align rather than
1023 a dangerous pointer-value-to-`unsigned' cast.
1024 * NEWS: mention the new sha* programs.
1025 * AUTHORS: Add new sha* programs.
1027 2005-08-28 David Madore <david.madore@ens.fr>
1029 Add new programs: sha224sum, sha256sum, sha384sum, sha512sum.
1030 * README: Add their names to the list.
1031 * src/md5sum.c: Provide framework for computing sha-2 hashes.
1032 * src/Makefile.am (sha224sum, sha256sum, sha384sum, sha512sum):
1033 Rules for compiling sha-2 utilities
1034 (noinst_HEADERS): Remove checksum.h.
1035 * man/sha512sum.x, man/sha384sum.x, man/sha256sum.x, man/sha224sum.x:
1037 * man/Makefile.am (dist_man_MANS): Add the corresponding .1 names.
1038 (sha224sum.1, sha256sum.1, sha384sum.1, sha512sum.1): New dependencies.
1039 * tests/misc/sha224sum, tests/misc/sha256sum: New files.
1040 * tests/misc/sha384sum, tests/misc/sha512sum: New files.
1041 * tests/misc/Makefile.am (TESTS): Add new sha224sum, sha256sum,
1042 sha384sum, sha512sum test scripts here rather that each in its
1045 2005-08-28 David Madore <david.madore@ens.fr>
1047 * tests/sha1sum/basic-1 (million-a): Add the "million a's" test (one
1048 of the FIPS test vectors).
1050 2005-10-23 Jim Meyering <jim@meyering.net>
1052 * configure.ac: Use 6.0-cvs as the version string.
1053 * NEWS: Adjust accordingly.