1 2006-02-11 Jim Meyering <jim@meyering.net>
5 * src/c99-to-c89.diff: New file.
6 * src/Makefile.am (EXTRA_DIST): Add c99-to-c89.diff.
8 * .x-po-check: New file, with exclusions so that `make distcheck'
10 * Makefile.am (EXTRA_DIST): Add .x-po-check.
12 rm -r must remove an empty directory, even if it is inaccessible.
13 * src/remove.c (close_preserve_errno): New function.
14 (fd_to_subdirp): Don't print a diagnostic in this function.
15 Do it from the callers instead, unless rmdir succeeds.
16 (remove_cwd_entries, remove_dir): Adjust callers.
17 * tests/rm/empty-inacc: New test for the above.
18 * tests/rm/Makefile.am (TESTS): Add empty-inacc.
19 * NEWS: Mention this bug fix.
20 * tests/rm/rm2: Adjust two expected diagnostics, now that they're
21 a tiny bit less precise: cannot remove `a/1': ... instead of
22 cannot open directory `a/1': ...
24 * Makefile.maint (syntax-check-rules): Automatically derive this
25 list of sc_-prefixed rule names.
27 2006-02-10 Paul Eggert <eggert@cs.ucla.edu>
29 * Makefile.maint (CVS_LIST): Don't assume cvsu is available.
30 (CVS_LIST_EXCEPT): New macro, to simplify exception-processing.
31 Most uses of CVS_LIST changed to use CVS_LIST_EXCEPT.
32 (syntax-check-rules): Bring back sc_changelong. (Hmm, why did it
33 go away? was that an accident?)
34 (sc_cast_of_argument_to_free, sc_cast_of_x_alloc_return_value):
35 (sc_cast_of_alloca_return_value, sc_space_tab, sc_prohibit_atoi_atof):
36 (sc_error_exit_success, sc_file_system, sc_no_if_have_config_h):
37 (sc_system_h_headers, sc_sun_os_names, sc_trailing_blank):
38 (sc_two_space_separator_in_usage, sc_unmarked_diagnostics):
39 (sc_obsolete_symbols, sc_changelog, sc_prohibit_jm_in_m4):
40 (sc_useless_cpp_parens, makefile-check, m4-check, po-check):
41 (author_mark_check, makefile_path_separator_check):
42 Output line numbers, to simplify navigation of Emacs *compilation*
44 (sc_prohibit_atoi_atof, sc_file_system):
45 Rework slightly so that Makefile.maint doesn't get reported as a
46 violation of its own syntax rules.
47 (sc_dd_max_sym_length): Use ifneq to do nothing, instead of doing
48 it at run-time (which didn't work with Bison). Fix a makefile typo,
49 caught by Makefile.maint itself: spaces where a tab should be.
50 (po-check): Check lib/*.[ch] even if not in CVS; used by Bison,
51 which copies from ../gnulib/lib/*.[ch] to lib/*.[ch].
52 Ignore djgpp and man subdirectories, to avoid false matches with
53 Bison and coreutils, respectively. Use sort -u to remove the
55 * gnupload: Rework slightly to avoid bogus warning from
56 sc_two_space_separator_in_usage.
58 2006-02-10 Jim Meyering <jim@meyering.net>
60 Use gzip's --rsyncable option only if it's available.
61 * Makefile.maint (gzip_rsyncable): New variable.
64 2006-02-08 Jim Meyering <jim@meyering.net>
66 * Makefile.maint (local-checks-available): Define in terms of
67 the expansion, $(syntax-check-rules), rather than the single,
68 top-level target `syntax-check', so that it's easier to exclude
69 individual rules (via $(local-checks-to-skip)).
70 (tgz-md5, tgz-sha1, ...): Remove now-unused definitions.
72 2006-02-07 Jim Meyering <jim@meyering.net>
74 * src/system.h (!defined O_DIRECT): If O_DIRECTIO is defined (as it
75 is on Tru64), define O_DIRECT to that. Patch From James Lemley.
77 * tests/help-version (expected_failure_status_vdir):
78 Redirect an expected disk-full diagnostic to /dev/null.
80 2006-02-06 Jim Meyering <jim@meyering.net>
82 * src/unexpand.c (usage): Use two spaces (not one) to separate the
83 --first-only option string from its description, so help2man formats
84 the derived man page properly.
85 * src/rm.c (usage): Likewise for --no-preserve-root.
86 * src/chown.c (usage): Likewise.
87 * src/chgrp.c (usage): Likewise.
89 Add a rule to ensure that the above doesn't happen again.
90 * Makefile.maint (sc_two_space_separator_in_usage): New rule.
91 (syntax-check-rules): Add it.
92 * .x-sc_two_space_separator_in_usage: New empty file.
93 * Makefile.am (EXTRA_DIST): Add .x-sc_two_space_separator_in_usage.
95 2006-02-06 Jim Meyering <jim@meyering.net>
97 * src/cp.c (usage): Use two spaces (not one) to separate each
98 option string from its description, so help2man formats the
99 derived man page properly.
100 * src/mv.c (usage): Likewise.
101 Patch from Nicolas François in http://bugs.debian.org/351601.
103 2006-02-04 Jim Meyering <jim@meyering.net>
105 * src/copy.c (copy_internal): cp -RL would fail when encountering
106 the same directory more than once in the hierarchy beneath a single
107 command-line argument. That is legitimate, e.g. when there are
108 two or more symbolic links, each pointing to some directory that
109 would not otherwise be copied. Reported by Christophe LYON.
110 * tests/cp/cp-deref: New file. Test for today's fix.
111 * tests/cp/Makefile.am (TESTS): Add cp-deref.
112 * NEWS: Document this.
114 2006-02-03 Jim Meyering <jim@meyering.net>
116 * configure.ac: Require automake-1.9.6, not 1.8.3.
118 2006-02-01 Paul Eggert <eggert@cs.ucla.edu>
120 * src/od.c (usage): Mention that -t a ignores high order bit.
121 Documentation problem reported by Ed Avis.
123 2006-02-01 Jim Meyering <jim@meyering.net>
125 * src/pwd.c (find_dir_entry): Remove unused local, `ent_sb_valid'.
127 2006-01-30 Paul Eggert <eggert@cs.ucla.edu>
129 * src/head.c (main): Use a better diagnostic when someone uses a
130 trailing numeric option in an invalid way. Problem reported by
132 * src/tail.c (parse_options): Likewise.
134 2006-01-30 Jim Meyering <jim@meyering.net>
136 * man/wc.x: Include `count' keyword in man page synopsis,
137 per suggestion from http://bugs.debian.org/181585.
139 2006-01-24 Paul Eggert <eggert@cs.ucla.edu>
141 * src/df.c (show_dev): If the file system claims to have
142 more available than total blocks, report the number of used
143 blocks as being total - available (a negative number) rather
144 than as garbage. Problem reported by Toralf Foerster.
146 2006-01-24 Jim Meyering <jim@meyering.net>
148 * src/tail.c (tail_forever): Don't exit-nonzero when an attempt
149 to put a regular file in O_NONBLOCK mode fails with EPERM.
150 That happens on Linux (up to 2.6.15) when using tail -f on a file with
151 the append-only attribute. Reported by Dean Gaudet. For details,
152 see http://savannah.gnu.org/bugs/?func=detailitem&item_id=15473.
153 * NEWS: Mention this fix.
154 * tests/tail-2/append-only: New file. Test for the above.
155 * tests/tail-2/Makefile.am (TESTS): Add append-only.
156 * tests/Makefile.am (check-root): Add tail-2/append-only
158 2006-01-21 Jim Meyering <jim@meyering.net>
160 * NEWS: Mention fts-related improvements and bug fixes.
162 2006-01-19 Jim Meyering <jim@meyering.net>
164 * tests/fmt/basic (pfx-1, pfx-2): New tests, to demonstrate the bug
165 reported as http://bugs.debian.org/147577. Forwarded by Thomas Hood.
167 2006-01-18 Jim Meyering <jim@meyering.net>
169 * tests/du/Makefile.am (TESTS): Add long-from-unreadable.
171 2006-01-17 Jim Meyering <jim@meyering.net>
173 Now that fts no longer changes the current working directory, adjust
174 its clients accordingly -- note that du.c uses fts but doesn't need
175 any adjustment, since it doesn't operate on the actual files,
176 but rather just uses the stat buffers provided by fts.
178 * src/chown-core.c: Include "openat.h".
179 Don't include "lchown.h".
180 (restricted_chown): Accept a new parameter, CWD_FD, and use it in
181 calling openat, lchownat, chownat, rather than open, lchown, chown.
183 * src/chmod.c: Include "openat.h".
184 (process_file): Use chmodat (fts->fts_cwd_fd,... in place of chmod (...
186 * tests/du/long-from-unreadable: New test, to exercise one small
189 2006-01-13 Jim Meyering <jim@meyering.net>
191 * tests/Makefile.am (SUBDIRS): Add comments discouraging the
192 addition of new directories under tests/.
194 * tests/acl: Redirect stdin to /dev/null. Otherwise, FreeBSD 5.0's
197 2006-01-12 Jim Meyering <jim@meyering.net>
199 * tests/du/long-sloop: Adjust not to hard-code the expected
200 diagnostic corresponding to ELOOP. Solaris' diagnostic differs
201 from that of GNU libc. Reported by Paul Eggert.
203 * tests/du/long-sloop: Create file at end of symlink chain.
205 * tests/misc/test: New file, with a test for one of the
206 bugs fixed by yesterday's test.c changes.
207 * tests/misc/Makefile.am (TESTS): Add test.
209 2006-01-11 Jim Meyering <jim@meyering.net>
211 * tests/du/long-sloop: New file. Test for today's fts.c bug fix.
212 That bug could make du -L, chgrp -L, or chown -L fail to diagnose
213 a very long sequence of symbolic links (not necessarily a loop).
214 * tests/du/Makefile.am (TESTS): Add long-sloop.
216 2006-01-11 Paul Eggert <eggert@cs.ucla.edu>
218 * src/test.c (test_syntax_error): Append a newline. All callers
219 changed, except for the ones that didn't already append a newline.
220 Bug reported by Eric Blake.
222 2006-01-11 Jim Meyering <jim@meyering.net>
224 * src/system.h (X2NREALLOC): Now that verify_true is no longer
225 void, cast its result to void, to avoid gcc's warning that
226 ``left-hand operand of comma expression has no effect''.
227 (DECIMAL_DIGIT_ACCUMULATE, X2REALLOC): Likewise.
229 2006-01-10 Jim Meyering <jim@meyering.net>
231 * tests/chmod/no-x: Add a test for today's fts.c fix.
233 2006-01-10 Jim Meyering <jim@meyering.net> (tiny change)
235 * src/ls.c (gobble_file): Use DTTOIF only if it's defined.
236 This is necessary for Dragonfly. Patch by Joerg Sonnenberger.
238 2006-01-10 Paul Eggert <eggert@cs.ucla.edu>
240 * src/system.h (X2NREALLOC, X2REALLOC, DECIMAL_DIGIT_ACCUMULATE):
241 Use verify_true instead of verify_expr, to sync with gnulib.
243 2006-01-08 Jim Meyering <jim@meyering.net>
245 * src/date.c (usage): Adjust the formatting of the entries for
246 %::z and %:::z (separate with two spaces, not one) so that help2man
247 formats them properly. Reported by Philip Rowlands.
249 2006-01-06 Paul Eggert <eggert@cs.ucla.edu>
251 * configure.ac (gl_IGNORE_UNUSED_LIBRARIES): Add.
253 2006-01-06 Jim Meyering <jim@meyering.net>
255 * Makefile.maint (copyright-check): Use date +%Y in place of
258 * src/remove.c (rm_1): Remove `static' attribute on local `status'.
259 First off, the attribute should have been `volatile' (not static)
260 to avoid longjmp-related risk of clobber. Secondly, now there is
261 no longer any risk of a local variable being clobbered, so there's
262 no need for any attribute at all.
264 2006-01-05 Jim Meyering <jim@meyering.net>
266 * src/remove.c: Give a few functions the inline attribute.
267 (AD_pop_and_chdir): Use gotos to avoid some duplication.
268 (AD_push): Rewrite an assertion so that the entire computation
269 goes away when assertions are turned off.
271 * src/tail.c (ENOSYS) [!defined ENOSYS]: Don't define here.
272 It's already defined in "system.h".
273 * Makefile.maint: Add a FIXME comment.
275 2006-01-04 Jim Meyering <jim@meyering.net>
277 * ChangeLog: Remove entries from 2005-10-22 and earlier.
278 * ChangeLog-2005: New file, for entries up to version 5.92.
280 2006-01-03 Jim Meyering <jim@meyering.net>
282 * tests/du/no-x: Also allow a slightly different diagnostic -- the
283 one you get when using openat-enabled fts.c and du (coming soon).
284 * tests/chmod/no-x: Likewise.
285 * tests/chgrp/no-x: Likewise.
287 * src/system.h (O_DIRECTORY) [!defined O_DIRECTORY]: Define.
289 2006-01-02 Paul Eggert <eggert@cs.ucla.edu>
291 * src/chown-core.c (RC_do_ordinary_chown): New enum value.
292 (restricted_chown): Return it, if the file cannot be accessed due
293 to EPERM, or if no uid or gid are required, or if the file is
294 neither a directory nor a regular file. Rewrite to avoid gotos.
295 (change_file_owner): Handle RC_do_ordinary_chown case.
296 Rewrite to avoid gotos.
297 * tests/chgrp/basic: Make sure we can change the group of
300 * src/date.c (usage): Explain %g, %G, and %V a bit better.
302 2006-01-02 Jim Meyering <jim@meyering.net>
304 * src/copy.c (set_owner): Correct a comment.
306 * src/tail.c (parse_options): Change warning to say that --retry
307 is useful `mainly' (not `only') when following by name.
308 Reported here: http://bugs.debian.org/273781
310 2006-01-01 Paul Eggert <eggert@cs.ucla.edu>
312 * NEWS: Document that mkfifo and mknod -m no longer set special bits.
313 * src/copy.c: Include lchmod.h.
314 (copy_internal): Use lchmod rather than chmod.
315 * src/cp.c: Include lchmod.h.
316 (re_protect, make_dir_parents_private): Use lchmod rather than chmod.
317 * src/mkdir.c: Include lchmod.h.
318 (usage): Clarify -m's operation.
319 (main): Use lchmod rather than chmod. Don't use lchmod unless the
320 new mode contains bits outside the 777 range.
321 * src/mkfifo.c (usage): Clarify -m's operation.
322 (main): If -m is given, don't invoke chmod; use umask 0 instead.
323 Report an error if -m asks for bits outside the 777 range.
324 * src/mknod.c (usage, main): Likewise.
326 * src/mkdir.c, src/mkfifo.c, src/mknod.c: Undo 2005-12-19 changes.
328 2005-12-27 Jim Meyering <jim@meyering.net>
330 * Makefile.maint (sc_obsolete_symbols): Prohibit use of O_NDELAY.
331 (sc_prohibit_assert_without_use): New rule.
332 (syntax-check-rules): Add it to the list.
333 * .x-sc_prohibit_assert_without_use: New empty file.
334 * Makefile.am (EXTRA_DIST): Add it.
336 * Makefile.maint (CVS_LIST): Define in terms of $(srcdir).
338 * cp.c, df.c, link.c, mknod.c, nice.c, sleep.c, unlink.c:
339 Don't include <assert.h>; it wasn't used.
341 2005-12-26 Paul Eggert <eggert@cs.ucla.edu>
343 * src/chown-core.c (restricted_chown):
344 Don't try O_WRONLY unless O_RDONLY failed wth EACCES.
345 * src/remove.c (fd_to_subdirp): Open with O_DIRECTORY | O_NOCTTY
346 | O_NOFOLLOW too, for consistency with other dir-openers.
347 Use POSIX-preferred O_NONBLOCK rather than O_NDELAY.
348 (is_empty_dir): Likewise.
349 * src/shred.c (wipename): Likewise. Don't bother trying to open
350 dir for writing, since POSIX prohibits it.
352 2005-12-22 Jim Meyering <jim@meyering.net>
354 * tests/help-version: Redirect stderr to /dev/full, to suppress
355 write error diagnostic.
357 2005-12-19 Jim Meyering <jim@meyering.net>
359 * src/mkdir.c, src/mknod.c, src/mkfifo.c (main)
360 Avoid a minor race condition when `-m MODE' is specified, by using
361 open, fchown, and close rather than just chown. To do that reliably --
362 even with an overly restrictive umask -- ensure that each mkdir,
363 mknod and mkfifo call uses a mode including at least owner-read access.
364 * src/mknod.c (main): When `-m MODE' is specified, exit nonzero if
365 the subsequent chown (or equivalent open,fchown,close) fails.
366 * tests/misc/mknod: New tests.
367 * tests/misc/Makefile.am (TESTS): Add mknod.
369 2005-12-17 Jim Meyering <jim@meyering.net>
371 * src/remove.c (is_empty_dir): Open with O_NDELAY, so we don't hang,
372 e.g., on a named pipe.
373 (OPEN_NO_FOLLOW_SYMLINK): Remove definition. Use O_NOFOLLOW in
374 place of all uses, since it is guaranteed (system.h) to be defined.
376 2005-12-05 Andreas Gruenbacher <agruen@suse.de>
378 Add POSIX ACL support
379 * src/ls.c: Switch back from HAVE_ACL to USE_ACL: The acl() syscall
380 is no requirement for ACL support; particularly, it does not exist
381 on systems that have POSIX ACLs.
382 * src/copy.h (cp_option_init) [umask_kill]: Remove member.
383 * src/cp.c (umask_kill): With default acls, the umask is not to be
384 applied. Remove umask_kill, don't change the process umask, and let
385 the kernel apply the umask where appropriate.
386 * src/cp.c (make_dir_parents_private): Fix logic for POSIX ACLs.
387 * src/copy.c (get_dest_mode): Remove; it is obsolete after removing
389 (copy_reg, copy_internal): Use copy_acl and set_acl
390 instead of fchown/chown. Fix the logic for POSIX ACLs.
391 (chown_succeded): Remove; we now always copy acls and
392 preserve S_ISUID, S_ISGID, and S_ISVTX when needed, no matter if we
393 did a chown before or not.
394 * src/mv.c, src/install.c (cp_option_init): Don't set umask_kill member.
395 * src/Makefile.am (dir_LDADD, ls_LDADD, vdir_LDADD, cp_LDADD,
396 mv_LDADD, ginstall_LDADD): On systems with an ACL library, arrange
397 to link with it via $(LIB_ACL), for the utilities that need it.
399 2005-12-16 Paul Eggert <eggert@cs.ucla.edu>
401 * src/remove.c (OPENAT_CWD_RESTORE__REQUIRE): Remove.
402 (OPENAT_CWD_RESTORE__ALLOW_FAILURE): Likewise.
403 (fd_to_subdirp): Remove openat_cwd_restore_allow_failure arg; its
404 value is now signified by whether cwd_errno is null.
405 (fd_to_subdirp, remove_dir, rm_1); Change cwd failure indicator from
406 pointer-to-bool to pointer-to-errno-value. All callers changed.
407 (rm_1): Don't bother setting a local cwd failure flag and then
408 ORing it into the caller's. Just set the caller's.
409 (rm): Use cwd failure errno value to print a slightly-better
412 2005-12-15 Jim Meyering <jim@meyering.net>
414 * src/stat.c (print_it): Properly handle a backslash at the
415 end of a --printf format string. Reported by Paul Eggert.
416 * tests/misc/stat-printf (end-bs): Add a test for the above.
418 2005-12-15 Paul Eggert <eggert@cs.ucla.edu>
420 * tests/acl: Port to pre-POSIX shells like Solaris 8 /bin/sh.
421 Don't assume /etc/passwd contains user names; use 'id' instead.
423 2005-12-15 Jim Meyering <jim@meyering.net>
425 stat: revert behavior of --format=FMT (-c)
426 stat: add new option: --printf=FMT
427 * NEWS: Mention this.
428 * src/stat.c (isodigit, octtobin, hextobin): Define.
429 (PRINTF_OPTION): Define.
430 (interpret_backslash_escapes, trailing_delim): New globals.
431 (usage): Document them. Alphabetize on long option names.
432 (print_esc_char): New function.
433 (print_it): Rewrite, in order to handle backslash escapes.
434 (main): Handle new option. Set globals for --format, too.
436 * tests/misc/stat-printf: Test --printf and --format.
437 * tests/misc/Makefile.am (TESTS): Add stat-printf.
439 2005-12-14 Paul Eggert <eggert@cs.ucla.edu>
441 * NEWS: sort now reports incompatible options.
442 * src/sort.c (incompatible_options, check_ordering_compatibility):
444 (main): Use them. Don't bother with a usage message for
445 "sort -c a b", for consistency with other error diagnostics.
446 * tests/sort/Test.pm (incompat1, incompat2, incompat3, incompat4):
449 * src/cat.c (main): Undo previous change. close_stdout already
450 does the check, so the previous change wasn't necessary.
452 2005-12-13 Paul Eggert <eggert@cs.ucla.edu>
454 * src/cat.c (main): Check for close (STDOUT_FILENO) failure.
456 2005-12-12 Paul Eggert <eggert@cs.ucla.edu>
458 Install a more-conservative approach for sort -R. It's the
459 same basic idea as the existing code, except it uses the full ISAAC
460 approach (called the "more kosher" approach in the existing comments).
461 This makes "sort -R" quite a bit slower (about a factor of 2 on my
462 little tests involving 10000 lines on a 2.4 GHz P4), but I think it's
463 better to be conservative here at first, and review any performance
464 improvements carefully.
465 * .x-sc_require_config_h: Add src/rand-isaac.c.
466 * src/rand-isaac.h: Remove. All uses now simply include rand-isaac.c.
467 * src/Makefile.am (noinst_HEADERS): Remove rand-isaac.h.
468 (shred_SOURCES, sort_SOURCES): Remove.
469 (EXTRA_DIST): Add rand-isaac.c.
470 * src/rand-isaac.c: Revert to what used to be in shred.c, without
471 changing it to allow for varying numbers of words in the state.
472 Alter so that we include rand-isaac.c directly rather than
473 compiling it and linking to it. Don't include config.h or
474 system.h; that's the includer's responsibility.
475 Omit functions that are specific to shred.
476 (ISAAC_LOG, ISAAC_WORDS, ISAAC_BYTES, struct isaac_state, ind):
477 (isaac_step, struct irand_state):
478 Resurrect these, with the same defns that used to be in shred.c.
479 (ISAAC_SIZE, isaac_new, isaac_copy): Remove.
480 (isaac_refill, isaac_seed_start, isaac_seed_data, irand_init, irand32):
482 (struct isaac_state, isaac_refill, isaac_mix, isaac_init):
483 (isaac_seed_start, isaac_seed_data, isaac_seed_finish, isaac_seed):
484 (irand_init, irand32, irand_mod):
485 Number of words is constant again.
486 (struct irand_state, irand_init, irand32, irand_mod): Move to shred.c.
487 * src/shred.c: Include rand-isaac.c rather than rand-isaac.h.
488 * src/sort.c: Likewise.
489 * src/shred.c (fillrand, dopass, main): Undo previous change.
490 (struct irand_state, irand_init, irand32, irand_mod): Moved back here,
492 * src/sort.c: Don't include md5.h; it wasn't needed.
493 (struct keyfield): Rename random_hash to random, for consistency
494 with the other member names. All uses changed.
495 (usage): Tweak wording to mention STRING for --seed option.
496 (short_options): Rorder for consistency with other programs.
497 (rand_state): Now a struct, not a pointer to one. All uses changed.
498 (HASH_WORDS, HASH_SIZE): Remove.
499 (get_hash): Remove comments around resbuf size, since we can assume C89.
500 Use a "more-kosher" (but slower) approach of invoking isaac_refill.
501 (keycompare): Adjust to the new get_hash.
503 (badfieldspec): Omit recently-introduced comment; it isn't needed.
504 (main): Don't set need_random simply because gkey has it set; that
505 doesn't necessarily mean we'll need random numbers.
506 Redo seeding to match new get_hash approach.
508 2005-12-10 Jim Meyering <jim@meyering.net>
510 * src/Makefile.am (noinst_HEADERS): Add rand-isaac.h.
512 Avoid shred segfault on 64-bit systems.
513 * src/rand-isaac.c (isaac_refill): Don't try to negate a
514 local of type uint32_t. Make the local an `int' instead.
516 * NEWS: Mention sort's new options.
518 * src/rand-isaac.c (isaac_mix): Declare to be static.
519 Mark all other functions as `extern' so the tight-scope
520 part of `make distcheck' passes once again.
521 * src/rand-isaac.h (isaac_mix): Remove declaration.
523 * src/sort.c (get_hash): Change position of `*' in parameter
524 type to conform with convention.
525 (main): Split a long line so it fits in 80 columns.
526 (keycompare): Remove stray SPACE before TAB that was
527 causing `make distcheck' to fail.
529 * src/shred.c: Don't include gethrxtime.h. No longer needed.
531 * tests/misc/sort-rand: New file: basic tests for the new options.
532 * tests/misc/Makefile.am (TESTS): Add sort-rand.
534 2005-12-10 Frederik Eaton <frederik@ofb.net>
536 * src/Makefile.am (sort_LDADD): Add $(LIB_GETHRXTIME).
537 (shred_SOURCES, sort_SOURCES): New macros, so we compile rand-isaac.c.
538 * src/rand-isaac.c: New file, containing ISAAC code that was in shred.c.
539 Make state size runtime-configurable.
540 (isaac_new, isaac_copy): New functions.
541 * src/rand-isaac.h: New file.
542 * src/shred.c: Include rand-isaac.h. Move ISAAC code to rand-isaac.c.
543 (fillrand, main): Adjust to the fact that the state size is now
544 runtime-configurable.
545 * src/sort.c (short_options, long_options, WORDS, keycompare, main):
546 (usage): Add options --random-sort and --seed to implement a random
548 Include md5.h and rand-isaac.h.
549 (get_hash): New function.
550 (rand_state): New var.
551 (HASH_WORDS, HASH_SIZE): New macros.
553 2005-12-09 Paul Eggert <eggert@cs.ucla.edu>
555 * tests/dd/misc: Add test for dd iflags=noatime.
557 2005-12-09 Jim Meyering <jim@meyering.net>
559 * src/sort.c (usage): Mention white space vs -b and -t options.
562 2005-12-09 Eric Blake <ebb9@byu.net>
564 * src/test.c (main): Fix misleading comment.
566 2005-12-07 Paul Eggert <eggert@cs.ucla.edu>
568 * NEWS: Mention dd's new noatime flag.
569 * src/system.h (O_NOATIME): Define to 0 if not already defined.
570 * src/dd.c (flags, usage): Add support for noatime flag.
572 2005-12-07 Jim Meyering <jim@meyering.net>
574 Distribute the cvsu script, used only by `make syntax-check'.
575 * Makefile.am (EXTRA_DIST): Add build-aux/cvsu.
576 * Makefile.maint (CVS_LIST): Use build-aux/cvsu, now that we
577 distribute a copy of this script.
578 * .x-sc_unmarked_diagnostics: Add build-aux/cvsu.
580 * tests/mv/acl: exit-77 before the trap, not after, if we fail
581 to create a temporary directory on another partition.
582 From Andreas Gruenbacher.
584 2005-12-06 Tomas Pospisek <tpo@sourcepole.ch> (tiny change)
586 * man/basename.x: Cross-reference to dirname and readlink.
587 * man/dirname.x: Cross-reference to basename and readlink.
589 2005-12-05 Andreas Gruenbacher
591 * src/copy.c [!HAVE_FCHOWN]: Define fchown(...) to -1.
592 (set_owner, preserve_author): New functions, factored out of copy_reg.
593 (copy_reg): Use them.
594 (copy_internal): Use them here, too.
596 2005-12-04 Jim Meyering <jim@meyering.net>
598 * src/sleep.c (usage): Say what happens with two or more arguments.
599 Suggested by Justin Pryzby.
601 * src/uptime.c (print_uptime): Move decl of `upsecs' into scope
604 2005-12-03 Jim Meyering <jim@meyering.net>
606 * src/rm.c (long_opts): Change the name of each undocumented, for-
607 testing-only option to start with `-', so that it cannot render
608 ambiguous any prefix it happens to share with some other option name.
609 Problem reported by Eric Blake.
610 * src/head.c (long_options): Likewise.
611 * src/tail.c (long_options): Likewise.
613 * tests/misc/head-elide-tail: Update uses of undocumented, for-
614 testing-only --presume* options to start with `---'.
615 * tests/rm/dangling-symlink: Likewise.
616 * tests/rm/dir-no-w: Likewise.
617 * tests/rm/isatty: Likewise.
619 2005-11-30 Jim Meyering <jim@meyering.net>
621 * Makefile.maint: Add a comment about cvsu.
623 2005-11-25 Paul Eggert <eggert@cs.ucla.edu>
625 * NEWS: df updates for "none", "proc", inaccessible file systems.
626 * src/df.c (show_point): Ignore inaccessible file systems.
627 (usage): -a includes dummy file systems, not size-0 file systems.
629 * src/od.c (unsigned_long_long_int): Renamed from ulonglong_t,
630 to avoid collision with POSIX name space. All uses changed.
632 2005-11-24 Jim Meyering <jim@meyering.net>
634 * tests/Makefile.am (EXTRA_DIST): Add acl to the list.
635 * tests/acl: Add `$0: ' prefix to diagnostics.
637 * .x-sc_require_config_h: Add lib/buffer-lcm.c to the list.
639 2005-11-23 Paul Eggert <eggert@cs.ucla.edu>
641 * src/copy.c: Improve performance a bit by optimizing away
642 unnecessary system calls and going to a block size of at least
643 8192 (on normal hosts, anyway). This improved performance 5% on my
644 Debian stable host (2.4.27 kernel, x86, copying from root
645 ext3 file system to itself).
646 Include "buffer-lcm.h".
647 (copy_reg): Omit last argument. All callers changed.
648 Use xmalloc to allocate rather than trusting alloca
649 (which is unwise with large block sizes).
650 Declare locals more locally, if possible.
651 Use uintptr_t words instead of int words, for a bit more speed
652 when looking for null blocks on 64-bit hosts.
653 Optimize away reads of zero bytes on regular files.
654 In the typical case, insist on 8 KiB buffers, at least.
655 Avoid unnecessary extra call to fstat when checking for sparse files.
656 Avoid now-unnecessary cast to off_t, and "0L".
657 Avoid unnecessary test of *new_dst when checking for same owner
660 2005-11-22 Paul Eggert <eggert@cs.ucla.edu>
662 * src/remove.c (rm): Don't assume C99 for-loop syntax.
664 2005-11-22 Jim Meyering <jim@meyering.net>
666 * src/remove.c (AD_push): Remove debugging cruft.
668 * tests/rm/unread2 (rm): Change expected diagnostic,
669 `cannot open directory' to `cannot remove', to align with
671 * tests/rm/rm2: Ensure that rm now continues removing entries
672 even after certain types of failure.
674 * src/remove.c: Rewrite. Now, this module is reentrant on systems
675 that provide openat (Solaris), and on systems like Linux+procfs
676 where our openat emulation code is reentrant. This also fixes a
677 few low-probability leaks and eliminates some code that could,
678 in very unusual circumstances, cause rm() (via a callee) to exit.
679 * NEWS: Mention this.
681 * configure.ac: Put copyright dates all on one line so the
682 emacs function that updates them works properly.
684 2005-11-18 Paul Eggert <eggert@cs.ucla.edu>
686 * configure.ac (AM_PROG_CC_C_O): Add. Needed for CVS Automake.
687 Problem reported by Eric Blake.
688 (AC_PROG_CC_STDC): Use this instead of AC_PROG_CC, so that
689 we get a standard-conforming compiler. This relies on the new
690 m4/c.m4 file. Note that it's a bit tricky, since c.m4 doesn't
691 define AC_PROG_CC_STDC; we are relying on Autoconf 2.59 internals.
692 m4/c.m4 can go away with Autoconf 2.60 comes out.
694 2005-11-17 Jim Meyering <jim@meyering.net>
696 * src/remove.c (AD_mark_helper): Make a `char *' parameter `const'.
697 (AD_mark_current_as_unremovable): Likewise, but for a local.
700 * tests/mv/acl: Let traps handle removing temporary directories.
702 Expect acl-related tests to fail, until the corresponding
703 patches are committed.
704 * tests/mv/Makefile.am (XFAIL_TESTS): Add acl.
705 * tests/cp/Makefile.am (XFAIL_TESTS): Likewise.
707 ACL tests, from Andreas Gruenbacher.
708 * tests/acl, tests/mv/acl, tests/cp/acl: New files.
709 * tests/mv/Makefile.am (TESTS): Add acl.
710 * tests/cp/Makefile.am (TESTS): Add acl.
712 * src/ls.c (basename_is_dot_or_dotdot): Correct wording in comment.
714 2005-11-16 Paul Eggert <eggert@cs.ucla.edu>
716 * NEWS: Improve quality of ln's diagnostics.
717 * src/ln.c (do_link, usage): Likewise.
718 (do_link): Don't use alloca on a buffer of unbounded size.
720 2005-11-16 Jim Meyering <jim@meyering.net>
722 * tests/cp/fail-perm: Accommodate HPUX. It appears to fail
723 with EACCES rather than EPERM. Reported by Peter O'Gorman here:
724 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/5766
726 2005-11-14 Jim Meyering <jim@meyering.net>
728 * NEWS (sort): Mention consequences of today's mkstemp-safer.c fix.
730 2005-11-13 Jim Meyering <jim@meyering.net>
732 * announce-gen: Accept new option, --gpg-key-id=ID and
733 emit a blurb telling how to use the .sig files.
734 * Makefile.cfg (gpg_key_ID): Define.
735 * Makefile.maint (announcement): Use new option and key.
737 Require that most .c files include <config.h>.
738 * Makefile.maint (sc_require_config_h): New rule.
739 (syntax-check-rules): Add it.
740 * .x-sc_require_config_h: New file listing exceptions to the
741 above rule. Some are legit, others are simply grandfathered in.
742 * Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h here, too.
744 2005-11-12 Jim Meyering <jim@meyering.net>
746 * src/checksum.h, src/md5.c, src/sha1sum.c: Remove now-unused files.
748 2005-11-11 Jim Meyering <jim@meyering.net>
750 * NEWS: Mention `readlink -f' bug fix in 5.3.0 news.
751 Mention new readlink options in 5.3.0's `New features' section.
752 Spotted by Thomas Hood.
754 2005-11-08 Jim Meyering <jim@meyering.net>
756 * NEWS: Merge in changes from b5_9x branch.
758 2005-11-08 Paul Eggert <eggert@cs.ucla.edu>
760 * NEWS: ls now defaults to --time-style='locale', which in turn acts
761 like --time-style='posix-long-iso' if the locale settings are messed up.
762 * src/ls.c (decode_switches): Implement this.
764 2005-11-08 Jim Meyering <jim@meyering.net>
766 * tests/du/2g: s/expensive/very expensive/ in a comment.
769 2005-10-17 Eric Blake <ebb9@byu.net>
771 * src/ls.c (usage): Fix descriptions of --sort, --time.
772 Reported by Vitaly A. Ostanin.
774 2005-11-04 Paul Eggert <eggert@cs.ucla.edu>
776 * src/ln.c: Include filenamecat.c.
777 (FILE_BASENAME_CONCAT): Remove.
778 (do_link): Remove last arg DEST_IS_DIR. All callers changed.
779 (main): Use file_name_concat, base_name, and strip_trailing_slashes
780 instead of FILE_BASENAME_CONCAT. This simplifies the code, and avoids
783 2005-11-04 Jim Meyering <jim@meyering.net>
785 * src/du.c (process_file): Don't overflow for files of size >= 2^31
786 on systems with stat.st_blocks of a signed 32-bit type.
787 This bug causes trouble on some AIX 5.1 systems.
788 Report and trivial patch from Paul Townsend:
789 <http://lists.gnu.org/archive/html/bug-coreutils/2005-11/msg00033.html>
790 * NEWS: Mention this.
792 * tests/du/2g: New (very-expensive) test for the above-fixed bug.
793 * tests/du/Makefile.am (TESTS): Add it here.
794 * tests/very-expensive: New file.
795 * tests/Makefile.am (EXTRA_DIST): Add it here.
796 * tests/cp/perm: Mark this test as `very-expensive', too.
798 2005-11-02 Paul Eggert <eggert@cs.ucla.edu>
800 * NEWS: Mention that rm -d and maybe ln -d are scheduled for
802 * src/remove.h (struct rm_options): Remove unlink_dirs. All uses
804 * src/rm.c (usage): Don't mention rm -d.
806 2005-11-02 Jim Meyering <jim@meyering.net>
808 * tests/dd/skip-seek: Fix typo in comment: s/fileutils/coreutils.
811 * tests/dd/unblock-sync: Redirect stderr to /dev/null so the
812 `M+N records in/out' lines don't pollute `make check' output.
814 * tests/dd/skip-seek (sk-seek4): New test, to exercise the bug
815 fixed on 2005-10-31. This test uses the new, IN_PIPE specifier.
816 * tests/Coreutils.pm: Accept a new type of input specifier: IN_PIPE,
817 to indicate that the input file should be piped into the command
818 under test (via `cat FILE | $prog ...').
820 * src/remove.c (remove_entry): Emit a better diagnostic when rm
821 (without -r) fails to remove a directory on a non-Linux system.
822 This change affects only newer Solaris systems (with priv_*
823 functions like priv_allocset). Reported by Keith Thompson.
825 * tests/rm/dir-nonrecur: New file/test for the above fix.
826 * tests/rm/Makefile.am (TESTS): Add dir-nonrecur.
828 2005-11-01 Paul Eggert <eggert@cs.ucla.edu>
830 * NEWS: "tail -c 2 FILE" and "touch 0101000000" now operate as
831 POSIX 1002.1-2001 requires.
832 * src/tail.c (parse_obsolete_option): Implement this.
833 Problem reported by Vincent Lefevre.
834 * src/touch.c (main): Pass PDS_PRE_2000 to posixtime.
835 * tests/tail/Test.pm (c-2, c-2-minus, c2, c2-minus): New tests.
836 (test_vector): Add special cases for _POSIX2_VERSION, and
837 regularize the old ones a bit.
838 * tests/touch/obsolescent: Add y2000 test.
840 2005-10-31 Paul Eggert <eggert@cs.ucla.edu>
842 * src/dd.c (skip): Fix off-by-one error reported by
843 Theodoros V. Kalamatianos.
845 2005-10-30 Paul Eggert <eggert@cs.ucla.edu>
847 * tests/mkdir/p-3: Require that the test be run as non-root.
848 Problem and trivial fix reported by Theodoros V. Kalamatianos.
850 2005-10-28 Paul Eggert <eggert@cs.ucla.edu>
852 * src/ln.c (FILE_BASENAME_CONCAT): Omit unnecessary slashes in the
853 boundary between DEST and SOURCE in the result.
855 2005-10-26 Dmitry V. Levin <ldv@altlinux.org>
857 * src/md5sum.c (main) [!O_BINARY]: Changed default read mode
858 back to text, to sync with documentation and for backwards
861 2005-10-25 Jim Meyering <jim@meyering.net>
863 * tests/dircolors/simple (other-wr): Add an explicit test for
864 the dircolors bug (NULL-dereference) fixed yesterday.
866 2005-10-24 Jim Meyering <jim@meyering.net>
868 * src/tac.c (tac_file): When determining whether a file is seekable,
869 also test whether it is a tty. Using only the lseek-based test would
870 give a false positive on Solaris. Reported by Peter Fales.
872 2005-10-24 Dmitry V. Levin <ldv@altlinux.org>
874 * tests/install/d-slashdot: New test, for "install -d" failure.
875 * tests/install/Makefile.am (TESTS): Add d-slashdot.
876 * tests/mkdir/p-slashdot: New test, for "mkdir -p" failure.
877 * tests/mkdir/Makefile.am (TESTS): Add p-slashdot.
879 2005-10-24 Jim Meyering <jim@meyering.net>
881 * src/dircolors.c (ls_codes): Add missing comma.
882 Anonymous report and patch from
883 http://savannah.gnu.org/bugs/?func=detailitem&item_id=14849
885 * src/dircolors.c: Add compile-time assertion that the slack_codes
886 and ls_codes arrays have the same number of elements. This would
887 have prevented the above-fixed bug.
889 * src/expand.c (parse_tab_stops): Add a comment to make this function
890 identical to the one in unexpand.c.
891 * src/unexpand.c (parse_tab_stops): Adjust syntax to make this function
892 identical to the one in expand.c.
894 * src/expand.c (next_file): Don't assume fopen cannot return stdin.
896 2005-10-23 Jim Meyering <jim@meyering.net>
898 * src/md5sum.c (digest_check, main): Use ptr_align rather than
899 a dangerous pointer-value-to-`unsigned' cast.
900 * NEWS: mention the new sha* programs.
901 * AUTHORS: Add new sha* programs.
903 2005-08-28 David Madore <david.madore@ens.fr>
905 Add new programs: sha224sum, sha256sum, sha384sum, sha512sum.
906 * README: Add their names to the list.
907 * src/md5sum.c: Provide framework for computing sha-2 hashes.
908 * src/Makefile.am (sha224sum, sha256sum, sha384sum, sha512sum):
909 Rules for compiling sha-2 utilities
910 (noinst_HEADERS): Remove checksum.h.
911 * man/sha512sum.x, man/sha384sum.x, man/sha256sum.x, man/sha224sum.x:
913 * man/Makefile.am (dist_man_MANS): Add the corresponding .1 names.
914 (sha224sum.1, sha256sum.1, sha384sum.1, sha512sum.1): New dependencies.
915 * tests/misc/sha224sum, tests/misc/sha256sum: New files.
916 * tests/misc/sha384sum, tests/misc/sha512sum: New files.
917 * tests/misc/Makefile.am (TESTS): Add new sha224sum, sha256sum,
918 sha384sum, sha512sum test scripts here rather that each in its
921 2005-08-28 David Madore <david.madore@ens.fr>
923 * tests/sha1sum/basic-1 (million-a): Add the "million a's" test (one
924 of the FIPS test vectors).
926 2005-10-23 Jim Meyering <jim@meyering.net>
928 * configure.ac: Use 6.0-cvs as the version string.
929 * NEWS: Adjust accordingly.