1 2006-06-28 Paul Eggert <eggert@cs.ucla.edu>
3 * src/system.h (CLOSEDIR): Remove. All uses changed to closedir.
4 Autoconf 2.60 says this stuff was obsolete.
6 2006-06-28 Jim Meyering <jim@meyering.net>
8 * src/c99-to-c89.diff: Regenerate, to remove fuzz.
10 2006-06-28 Bob Proulx <bob@proulx.com> (tiny change)
12 * tests/mv/i-link-no: Work around HP-UX /bin/sh tracing problem
13 (set -x when VERBOSE=yes) when stderr is redirected before stdout
14 causing shell tracing of the stdout redirection to be written to
15 the stderr file. Avoid problem and test failure on HP-UX by
16 redirecting stderr last.
17 * tests/dd/unblock-sync: Order shell file redirections for
18 stderr and stdout in the common style.
21 2006-06-27 Jim Meyering <jim@meyering.net>
23 * tests/misc/cat-proc: Try to avoid any spurious numeric
24 differences in frequently-changing /proc/cpuinfo.
25 Reported by Nelson Beebe.
27 2006-06-26 Jim Meyering <jim@meyering.net>
29 Attempt rmdir (actually, unlinkat-with-AT_REMOVEDIR) upon any
30 fd_to_subdirp failure, not just when errno == EACCES.
31 * src/remove.c (remove_dir): Use unlinkat-with-AT_REMOVEDIR, not
32 rmdir, here, even though rmdir may happen to be adequate.
34 * NEWS: rm no longer fails to remove an empty, unreadable directory
35 * src/remove.c (remove_cwd_entries): If we can't open a directory,
36 and the failure is not being ignored, try to remove the directory
37 with rmdir (aka unlinkat-with-AT_REMOVEDIR), in case it's empty.
38 Problem report and test case from Paul Eggert in
39 <http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/7425>.
41 * tests/rm/empty-inacc: New test, for the above.
43 Avoid a segfault for wc --files0=- < /dev/null.
44 * src/wc.c (compute_number_width): Return right away if nfiles == 0.
46 2006-06-25 Jim Meyering <jim@meyering.net>
48 * NEWS: wc accepts a new option --files0-from=FILE, where FILE
49 contains a list of NUL-separated file names.
51 * src/wc.c: Include "readtokens.h".
52 (usage): Describe the new option, and adjust the `Usage':
53 with this option, no FILE may be specified on the command line.
54 (main): Handle the new option.
55 * tests/misc/wc-files0: New tests, for the above.
56 * tests/misc/wc-files0-from: Likewise.
57 * tests/misc/Makefile.am (TESTS): Add wc-files0.
59 2006-06-24 Jim Meyering <jim@meyering.net>
61 * src/md5sum.c (DIGEST_BUFFER): Remove now-unused definitions.
63 2006-06-22 Jim Meyering <jim@meyering.net>
65 * src/tee.c (tee_files): Rename from tee, to avoid conflict with
66 the function in glibc's <fcntl.h>. Reported by Andreas Schwab.
68 2006-06-19 Jim Meyering <jim@meyering.net>
70 * Makefile.cfg (local-checks-to-skip): Add changelog-check,
71 so this check is not run as part of "make distcheck".
73 2006-06-18 Bob Proulx <bob@proulx.com> (tiny change)
75 * tests/misc/pwd-long: Fix typo (s/neq/ne/) in previous change.
77 2006-06-18 Jim Meyering <jim@meyering.net>
79 * tests/misc/pwd-long: Make error output a little clearer.
81 2006-06-17 Jim Meyering <jim@meyering.net>
83 * tests/rm/inaccessible: Skip this test on systems without openat
84 support. Reported by Bob Proulx.
86 2006-06-15 Bob Proulx <bob@proulx.com> (tiny change)
88 * tests/misc/mknod: Improve permission checks to handle
89 running mkdir test in set-gid directories.
91 2006-06-14 Jim Meyering <jim@meyering.net>
93 * tests/du/basic: Revamp not to hard-code file system block sizes.
95 2006-06-12 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
97 * tests/du/Makefile.am (TESTS_ENVIRONMENT): Pass $(PERL), for
100 2006-06-11 Jim Meyering <jim@meyering.net>
102 * .gitignore: New file.
103 * Makefile.am (EXTRA_DIST): Add .gitignore.
105 Setting TIME_STYLE=long-iso in the environment would make the
106 cp/same-file test fail.
107 * tests/envvar-check (vars): Add TIME_STYLE to the list.
108 * tests/cp/same-file: Revert last change.
109 Source the envvar-check script, to ensure that TIME_STYLE
110 settings don't affect these tests.
112 2006-06-11 Paul Eggert <eggert@cs.ucla.edu>
114 * tests/cp/same-file: Execute 'ls' in the C locale, so that it
115 uses POSIX time stamp formats. Problem reported by John Nixon in
116 <http://lists.gnu.org/archive/html/bug-coreutils/2006-06/msg00062.html>.
118 2006-06-10 Jim Meyering <jim@meyering.net>
120 * NEWS: Mention the AIX-strndup-bug vs. dircolors workaround.
122 Require a "Version N.M" line at the top of the ChangeLog
123 file only when making the actual release, not when running
125 * Makefile.maint (maintainer-distcheck): Don't depend on
127 (alpha beta major): Depend on it here, instead.
129 2006-06-08 Jim Meyering <jim@meyering.net>
131 Ensure that cat works with any of the options, -A -v -e -E -T,
132 when applied to files in /proc and /sys, even when the FIONREAD
133 ioctl produces nonsensical results. Before this change, cat would
134 produce no output (or truncated output), for some linux kernels.
136 * src/cat.c (write_pending): New function, factored out of cat.
137 (cat): Also interpret a negative ioctl/FIONREAD count as indicating
138 that there are bytes to read. Some versions of linux-2.6.16 do that.
139 Write any pending output before returning.
140 Reported by Dan Jacobson in <http://bugs.debian.org/370583>.
141 * NEWS: Mention this bug fix.
142 * tests/misc/cat-proc: New file. Test for the above.
143 * tests/misc/Makefile.am (TESTS): Add cat-proc.
145 2006-06-07 Paul Eggert <eggert@cs.ucla.edu>
147 * src/expr.c (eval4): Detect overflow properly when multiplying
150 2006-06-06 Paul Eggert <eggert@cs.ucla.edu>
152 * NEWS: The 'expr' command now detects and reports integer overflow.
153 (It would be better to use extended precision instead, but that
155 * src/expr.c (integer_overflow): New function.
156 (eval4, eval3): Check for integer overflow.
158 2006-06-05 Paul Eggert <eggert@cs.ucla.edu>
160 Fix problems when building with Solaris/SVR4/etc. make, which uses a
161 different and somewhat bogus implementation of VPATH. In the
162 directory tests/misc, rename tests whose names might appear in the
163 Automake-generated rules. For example, we can't use a test named
164 'test', since Automake generates a rule that contains the text
165 "if test -f ./$$tst; ...", and this might expand to something like
166 "if ../../../coreutils-6.0/tests/misc/test -f ./$$test; ...",
167 which executes the 'test' script rather than the 'test' command.
168 * tests/misc/false-status: Renamed from tests/misc/false.
169 * tests/misc/pwd-long: Renamed from tests/misc/pwd.
170 * tests/misc/sort-merge: Renamed from tests/misc/sort.
171 ($prog): Set to 'sort' rather than to $PROG.
172 * tests/misc/test-diag: Renamed from tests/misc/test.
173 * tests/misc/Makefile.am (PROG): Take the basename of $$tst,
174 in case Solaris make has prepended the directory.
175 (TESTS): Adjust to above renamings.
176 * tests/misc/expand: Don't assign to PROG; no longer needed
177 now that Makefile.am sets PROG to the basename.
178 * tests/misc/fold: Likewise.
180 2006-06-03 Jim Meyering <jim@meyering.net>
182 Make `cp --link --no-dereference' work also on systems where the
183 link system call cannot create a hard link to a symbolic link.
184 * src/copy.c (copy_internal) [LINK_FOLLOWS_SYMLINKS]: Don't use
185 the link syscall on a symlink when it would do the wrong thing.
186 Based on the patch by Aurelien Jarno: <http://bugs.debian.org/329451>
187 * tests/cp/link-no-deref: New file/test for the above.
188 * tests/cp/Makefile.am (TESTS): Add link-no-deref.
189 * NEWS: Mention the change (doesn't affect Linux).
191 2006-06-01 Paul Eggert <eggert@cs.ucla.edu>
193 Fix some porting problems in the test cases reported by
194 Ralf Wildenhues for HP-UX 11.23 in:
195 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00238.html
196 * tests/help-version: Don't assume that \< \> works in sed.
197 * tests/misc/close-stdout: Don't assume that >&- works.
198 Add a /dev/full test.
199 * tests/touch/no-create-missing: Don't assume that >&- works.
201 2006-05-30 Jim Meyering <jim@meyering.net>
203 * src/ls.c (usage): Add `v' to the list of sorting-related options.
206 2006-05-28 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
208 * tests/cp/fail-perm: source lang-default.
209 * tests/rm/inaccessible: Likewise.
211 2006-05-28 Jim Meyering <jim@meyering.net>
213 * tests/rm/inaccessible: AIX 4.3.3 gives a different diagnostic.
214 Recognize it, too. Reported by Ralf Wildenhues, in
215 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
217 2006-05-27 Jim Meyering <jim@meyering.net>
219 * src/chgrp.c: Support new options: --preserve-root and
220 --no-preserve-root. Somehow this program was skipped when those
221 options were added to chown, chmod, and rm. Reported by
222 vaqflabuopac@spammotel.com in <http://bugs.debian.org/365656>.
223 * NEWS: Mention this.
225 2006-05-25 Paul Eggert <eggert@cs.ucla.edu>
227 * NEWS: Remove mention of --seed. We'll replace it with something
228 better, and don't want to indicate that it is supported.
229 * src/sort.c (usage): Likewise.
231 2006-05-20 Jim Meyering <jim@meyering.net>
233 * src/chmod.c (main): Use FTS_PHYSICAL here, too.
235 * src/du.c (main): Rename local, s/symlink_deref_bit/symlink_deref_bits/
236 and arrange for -D to set fts' FTS_PHYSICAL bit as well as
237 FTS_COMFOLLOW. Spotted by Justin Pryzby.
239 * gnupload: Merge changes from automake, retaining the ""--to...
240 kludge to placate overzealous `make distcheck' check.
242 2006-05-19 Jim Meyering <jim@meyering.net>
244 * src/du.c (main): Don't let -D, -L, or -P turn off the internal
245 FTS_TIGHT_CYCLE_CHECK directory traversal option.
246 Reported by Justin Pryzby in http://bugs.debian.org/367691
248 2006-05-15 Jim Meyering <jim@meyering.net>
250 * src/cp.c (usage): Correct description of -a: s/-dpR/-dpPR/.
253 2006-05-13 Jim Meyering <jim@meyering.net>
255 * tests/mv/no-target-dir: Test two more cases.
257 2006-05-11 Jim Meyering <jim@meyering.net>
259 mv -T DIR EMPTY_DIR no longer fails unconditionally
260 * src/copy.c (copy_internal): Don't manually prohibit a move where
261 the destination is an existing directory. Sometimes doing that is
262 valid. Let the rename system call enforce the rules. That is
263 allowed only when the source is a directory and the destination
264 directory (to be replaced) is empty. Reported by Eric Blake.
265 * tests/mv/no-target-dir: New file/test for this.
266 * tests/mv/Makefile.am (TESTS): Add no-target-dir.
267 * NEWS: Mention this.
269 * tests/mv/atomic: New file/test for yesterday's fix.
270 * tests/mv/Makefile.am (TESTS): Add atomic.
272 * tests/du/long-sloop: Avoid harmless `ambiguous redirect' diagnostic.
274 2006-05-10 Jim Meyering <jim@meyering.net>
276 * src/copy.c (copy_internal): Don't explicitly unlink the destination
277 when moving a symlink into the place of an existing non-directory.
278 Reported by Joshua Hudson.
279 * NEWS: mention this.
281 2006-05-07 Jim Meyering <jim@meyering.net>
283 * Makefile.maint (patch-check): Fail if patch generates any output,
284 even merely for changed offsets.
286 * src/c99-to-c89.diff: Adjust to reflect new offsets.
288 * NEWS: Mention changes affecting df, pwd, shred.
290 2006-05-06 Jim Meyering <jim@meyering.net>
292 * tests/ls/stat-vs-dirent: New test, to detect the bogus file
293 system condition where dirent.d_ino != stat.st_ino.
294 * tests/ls/Makefile.am (TESTS): Add stat-vs-dirent.
296 2006-05-06 Eric Blake <ebb9@byu.net>
298 * tests/ls/inode: Expand to test inode from readdir case.
299 * tests/ls/follow-slink: Expand to test broken links encountered
300 implicitly, favoring Solaris 9 and OpenBSD 3.4 behavior.
302 2006-05-06 Eric Blake <ebb9@byu.net>
304 * tests/mv/leak-fd: Work even on case-insensitive file system.
306 2006-05-04 Jim Meyering <jim@meyering.net>
308 * NEWS: Mention the 2006-03-19 pwd-related change that makes
309 lib/getcwd.c work around inconsistent file system dirent.d_ino data.
311 2006-05-03 Jim Meyering <jim@meyering.net>
313 * src/ls.c (DEFINE_SORT_FUNCTIONS, LIST_SORTFUNCTION_VARIANTS):
314 Use better macro parameter names: s/basename/key_name/,
315 s/basefunc/key_cmp_func. Fix typo in comment.
317 2006-04-29 Eric Blake <ebb9@byu.net>
319 * src/ls.c (main): On systems with d_type, directories_first only
320 implies format_needs_type, not format_needs_stat.
322 2006-05-03 Jim Meyering <jim@meyering.net>
324 * src/ls.c (xstrcoll_df_version, rev_xstrcoll_df_version): Add space
325 after comma in arg list, from Eric Blake.
327 2006-04-25 Paul Eggert <eggert@cs.ucla.edu>
329 * tests/misc/date (relative-3): New test, derived from a bug
330 report by John Thomas McDole.
332 2006-04-23 Francesco Montorsi <fr_m@hotmail.com>
334 New option for ls: --group-directories-first.
335 It makes ls list directories before files.
336 * NEWS [New features]: Mention it.
337 * src/ls.c (sort_type): Rearrange to use as an array index when
338 choosing sort function; added new sort_numtypes member for
340 (time_type): Add new time_numtypes member for compile-time check.
341 (directories_first): New global variable.
342 (GROUP_DIRECTORIES_FIRST_OPTION): New enum.
343 (long_options): Add --directories-first.
344 (main): Support new option.
345 (is_directory): New function.
346 (extract_dirs_from_files): Use it.
347 (DIRFIRST_CHECK, DEFINE_SORT_FUNCTIONS)
348 (LIST_SORTFUNCTION_VARIANTS): New macros.
349 (sort_functions): New global variable.
350 (sort_files): Use it.
351 (usage): Document new option.
353 2006-04-18 Paul Eggert <eggert@cs.ucla.edu>
355 * src/shred.c (fillrand): The assertion was way too weak, due to
356 what must be a typo. Strengthen it to its intended value.
357 (dopass): Don't use alloca; it's not worth the aggravation here,
358 since it's used only to get a page-aligned buffer, and page
359 alignment doesn't buy us much here. I'm suspicious that alloca
360 causes problems on some hosts, due to a recent bug report by Adam
361 Waltman: http://bugs.gentoo.org/130246.
363 2006-04-18 Jim Meyering <jim@meyering.net>
365 * tests/misc/tty-eof: Add new programs, base64, sha224sum, sha256sum,
366 sha384sum, sha512sum.
368 2006-04-17 Paul Eggert <eggert@cs.ucla.edu>
370 * src/chmod.c (describe_change): Adjust to filemode changes.
371 * src/ls.c (HAVE_ST_DM_MODE): Remove; moved to ../lib/filemode.c.
372 (print_long_format): Use (new) filemodestring rather than
373 (old) mode_string, so that we get more file types right, at least
374 in theory. Adjust to filemode changes.
375 * src/stat.c (human_access): Likewise.
377 2006-04-18 Jim Meyering <jim@meyering.net>
379 * src/ptx.c (main) [DEFAULT_IGNORE_FILE]: Remove code to use a default
380 ignore file. This has never been enabled. Reported by Eric Blake.
382 2006-04-12 Paul Eggert <eggert@cs.ucla.edu>
384 * src/ln.c (linkfunc): Remove. This method ran into a compiler/linker
385 bug in Interix. Just call symlink or link directly. All uses changed.
386 * src/setuidgid.c (main) [! HAVE_SETGROUPS]: Don't call setgroups.
387 * src/stat.c (USE_STATVFS): New macro.
388 Include <sys/statvfs.h> and use statvfs only if USE_STATVFS.
389 (NAMEMAX_FORMAT): define a bit more clearly, now that the
390 statvfs-using code is a bit more regular.
391 * src/system.h (sync) [!HAVE_SYNC]: New macro.
393 2006-04-11 Paul Eggert <eggert@cs.ucla.edu>
395 * NEWS: csplit, nl, expr now conform to POSIX better, and are
396 more-compatible with traditional Unix, with respect to regular
398 * src/csplit.c (extract_regexp): Set re_syntax_options to a
399 value that is compatible with what POSIX requires.
400 * src/nl.c (build_type_arg): Likewise.
401 * src/expr.c (docolon): Likewise. Also, don't let anchors match
402 newline; this fixes an incompatibility with tradition and with POSIX.
403 Don't warn about leading ^. POSIX says it is unspecified whether
404 ^ is a special character, which means that implementations can
405 either treat it as special or not, but either way a warning is not
406 allowed (unless the regexp is otherwise invalid). Instead, anchor
407 the expression but treat ^ as an anchor; this is the traditional
408 behavior (e.g., Solaris 10).
409 (eval4, eval3, eval2): Treat non-numeric args, division by zero,
410 and the like as invalid expressions (exit status 2), not as
411 failure of 'expr' (exit status 3). This is more consistent with
413 * tests/expr/basic (fail-a): Adjust exit status to match new expr
414 behavior, for status 2 versus 3.
416 (bre1, bre2, bre3, bre4, bre5, bre6, bre7, bre8, bre9, bre10):
417 (bre11, bre12, bre13, bre14, bre15, bre16, bre17, bre18, bre19, bre20):
418 (bre21, bre22, bre23, bre24, bre25, bre26, bre27, bre28, bre29, bre30):
419 (bre31, bre32, bre33, bre34, bre35, bre36, bre37, bre38, bre39, bre40):
420 (bre41, bre42, bre43, bre44, bre45, bre46, bre47, bre48, bre49, bre50):
421 (bre51, bre52, bre53, bre54, bre55, bre56, bre57, bre58, bre59, bre60):
422 (bre61, bre62): New tests.
423 * tests/misc/csplit: Use \{...\} in test RE, to test that we're
427 * tests/du/long-from-unreachable: Solaris 8 sh doesn't understand
428 "if !". Do not assume that 'sed' can handle long, newline-free input.
429 * tests/du/long-sloop: Likewise. Evaluate expr once, not $n times.
431 2006-04-10 Paul Eggert <eggert@cs.ucla.edu>
433 Adjust to new regex.h API (with new fastmap type), and clean
434 up the regex storage allocation a bit.
436 * src/csplit.c (struct control): Put re_compiled member at the
437 end, since it's large. Change regexpr member from char * to bool;
438 all uses changed. Add new member fastmap.
439 (extract_regexp): regexp arg is now char const *, not char *.
440 Don't bother duplicating the regular expression; it's not needed.
441 Set fastmap from new fastmap member. Don't bother allocating
442 a buffer, as the regexp code does a better job than we do.
443 * src/expr.c (docolon): Allocate and use a fastmap.
444 Don't bother allocating a buffer.
445 * src/nl.c (body_fastmap, header_fastmap, footer_fastmap):
447 (build_type_arg): New fastmap arg. All uses changed.
448 Don't bother allocating a buffer, but set a fastmap.
449 * src/ptx.c (context_regex_string, word_regex_string): Remove.
450 (context_regex, word_regex): New vars, replacing the above.
452 (struct regex_data): New type.
453 (compile_regex): Renamed from alloc_and_compile_regex, since
454 we no longer allocate storage. Arg is now a struct regex_data *,
455 not a const char *. All uses changed. Don't allocate the fastmap;
456 instead, take it from the caller. Don't convert size_t to int,
457 to avoid arithmetic overflow problems. Don't bother freeing
458 storage afterwards; it's not worth the aggravation.
459 * src/tac.c (compiled_separator_fastmap): New ver.
460 (main): Use it. Don't bother allocating a buffer.
462 2006-03-30 Jim Meyering <jim@meyering.net>
464 * src/dd.c (iwrite): Remove assignment without effect.
465 Reported by Felix Rauch Valenti.
467 2006-03-22 Eric Blake <ebb9@byu.net>
469 * src/ptx.c (usage): Remove mention of --copyright/-C.
470 (main): Alias --copyright to --version plus a deprecation warning.
471 * NEWS: Mention this.
473 2006-03-27 Jim Meyering <jim@meyering.net>
475 * src/Makefile.am (uptime_LDADD): Add $(POW_LIB), for uptime's
476 use of strtod. Tiny patch from Nickolai Zeldovich.
478 2006-03-11 Eric Blake <ebb9@byu.net>
480 * tests/misc/dirname: New file.
481 * tests/basename/Makefile.am: Delete.
482 * tests/basename/basic: Move to...
483 * tests/misc/basename: ... this new file. Add some tests,
484 including fixed behavior for //.
485 * tests/misc/Makefile.am (TESTS): Sort. Add basename, dirname.
486 * tests/Makefile.am (SUBDIRS): Remove basename.
487 * configure.ac (AC_CONFIG_FILES): Remove tests/basename.
489 Improvements to dirname/basename handling on platforms like
490 cygwin with distinct // and with drive letters.
491 * NEWS: Document new behavior.
492 * src/basename.c (main): Don't strip suffix from file system
494 * src/cp.c (target_directory_operand): Use new last_component.
495 (ASSIGN_BASENAME_STRDUPA): Likewise. Reduce time spent
496 traversing the string.
497 * src/dircolors.c (guess_shell_syntax): Use new last_component.
498 * src/install.c (target_directory_operand, install_file_in_dir):
500 * src/ln.c (target_directory_operand, main): Likewise.
501 * src/ls.c (basename_is_dot_or_dotdot): Likewise.
502 * src/mv.c (target_directory_operand, movefile): Likewise.
503 * src/remove.c (rm_1): Likewise.
504 * src/shred.c (wipename): Likewise.
505 * src/split.c (next_file_name): Likewise.
506 * src/su.c (log_su, run_shell): Likewise.
508 2006-03-23 Paul Eggert <eggert@cs.ucla.edu>
510 * NEWS: nohup diagnostics are now more precise, and nohup now
511 redirects stderr to nohup.out if stdout is closed and stderr is a tty.
512 * src/nohup.c (main): Implement this.
513 * tests/misc/nohup: Test the new behavior.
515 2006-03-12 Jim Meyering <jim@meyering.net>
517 * src/copy.c (set_author): Rename function, from preserve_author.
519 * src/remove.c (AD_pop_and_chdir): Use new macro,
520 CYCLE_CHECK_REFLECT_CHDIR_UP, rather than open-coding it.
522 * src/system.h (SAME_INODE): Remove definition.
523 Include "same-inode.h", instead.
525 2006-03-11 Eric Blake <ebb9@byu.net>
527 * src/pwd.c (robust_getcwd): Prepend only one slash, not two.
529 2006-03-10 Jim Meyering <jim@meyering.net>
531 Fix a bug whereby a user with write access to a directory being removed
532 could cause the removal of that directory to fail with an erroneous
533 diagnostic about a directory cycle. Reported by Vineet Chadha.
535 * NEWS: Mention this.
536 * src/remove.c (AD_pop_and_chdir): If the directory we're about to
537 leave (and try to rmdir) is the one whose dev_ino is being used to
538 detect a cycle, reset cycle_check_state.dev_ino to that of the parent.
540 2006-03-08 Paul Eggert <eggert@cs.ucla.edu>
542 * NEWS: Document dd's new 'directory' and 'nolinks' flags.
543 * src/dd.c (set_fd_flags): Handle file-creation flags on file
544 descriptors, rather than ignoring them.
545 * tests/dd/misc: Add test cases for append, nofollow, directory,
546 and nolinks flags. Simplify redirection to /dev/null in some cases.
548 * tests/dd/misc: iflags->iflag. This fixes a typo that meant the
549 noatime test never tested anything.
551 2006-03-05 Paul Eggert <eggert@cs.ucla.edu>
553 * src/dd.c (flags, usage): New flags directory, nolinks.
554 * src/system.h (O_NOLINKS): Define to 0 if not already defined.
556 * src/ls.c (usage): Mention that -f disables --color.
557 Problem reported by Niels Möller.
559 2006-03-03 Justin Pryzby <pryzbyj@justinpryzby.com>
561 * man/*.x: Add references to syscalls from utilities of the same name.
563 2006-03-05 Jim Meyering <jim@meyering.net>
565 * tests/help-version: Set SHELL, if not already set, in order to
566 avoid failure when `make check' is run through debuild; dircolors
567 would fail due to lack of $SHELL. Reported by Sven Joachim.
569 Make `base64 --wrap=N' work for N=0, and for N larger than SIZE_MAX.
570 * src/base64.c (wrap_write, do_encode, main): Change type of
571 parameters and locals, wrap_column, form size_t to uintmax_t.
572 (main): Adjust to use xstrtoumax, accordingly.
574 2006-03-03 Jim Meyering <jim@meyering.net>
576 Don't fail when run from an environment with SHELL not a Bourne
577 shell, e.g. `env SHELL=/bin/csh make check' would fail this test.
578 * tests/dircolors/simple: Invoke each non-failing test with -b.
579 Reported by Michael Stone.
581 2006-02-27 Jim Meyering <jim@meyering.net>
583 * tests/misc/base64: Derive --decode-using tests from the
586 * tests/misc/base64: Factor out a long constant string.
587 Split lines to stay within 80 columns.
589 * tests/misc/Makefile.am (TESTS): Add base64.
590 * tests/misc/base64: Test base64. From Simon Josefsson.
592 * src/base64.c (do_decode): Use correct type for parameter,
593 ignore_garbage: s/size_t/bool/.
595 * src/base64.c: Don't include .h files already included by system.h:
596 <string.h>, <stdlib.h>, <stdbool.h>, <limits.h>, <errno.h>.
597 Include "system.h" before the other lib/*.h header files.
598 Include <sys/types.h> before "system.h".
599 (wrap_write): Remove declaration of unused local, initial_column.
600 (wrap_write): Correct declaration syntax: s/size_t * V/size_t *V/.
602 * README: Add base64 to the list.
604 2006-02-17 Simon Josefsson <jas@extundo.com>
607 * AUTHORS: Mention base64.
609 * man/Makefile.am: Build base64.1.
610 * man/base64.x: New file.
611 * src/Makefile.am (bin_PROGRAMS): Add base64.
612 * src/base64.c: New file.
614 2006-02-25 Eric Blake <ebb9@byu.net>
616 In ls, avoid calling stat for --inode (-i), when possible.
617 * src/pwd.c (NOT_AN_INODE_NUMBER, D_INO): Move to ...
618 * src/system.h: ... here, for use in ...
619 * src/ls.c (main): ... here. Prefer dirent.d_ino to stat when
621 (gobble_file): Add inode argument.
622 (print_dir): Pass inode if available.
623 (usage): Remove inaccuracy.
625 2006-02-23 Jim Meyering <jim@meyering.net>
627 * TODO: Update/correct some obsolete entries.
629 2006-02-20 Paul Eggert <eggert@cs.ucla.edu>
631 * doc/coreutils.texi (join invocation): Mention `sort -k 1b,1'.
632 * src/join.c (usage): Likewise.
633 Documentation problem reported by Philip Kensche.
635 2006-02-20 Eric Blake <ebb9@byu.net>
637 * man/rm.x: Update documentation to match previous patch.
639 2006-02-18 Eric Blake <ebb9@byu.net>
641 New option for rm: --interactive=once (-I).
642 * NEWS: Document it, along with change to rm --interactive.
643 * TODO: Remove entry for implementing rm -I
644 * src/rm.c (INTERACTIVE_OPTION): New enum value.
645 (interactive_type): New enum.
646 (long_opts): Let interactive take an optional argument.
647 (interactive_args, interactive_types): New option arguments.
648 (usage): Document -I, --interactive=WHEN. Use program_name
649 instead of a basename.
650 (main): New -I option, new behavior to --interactive.
651 * tests/rm/interactive-once: New tests.
652 * tests/rm/interactive-always: Ditto.
653 * tests/rm/Makefile.am (TESTS): Run them.
655 2006-02-18 Jim Meyering <jim@meyering.net>
657 * Makefile.maint (sc_two_space_separator_in_usage): Make the regular
658 expression match more of the target lines, e.g., those that start with
659 `-S,' (short option followed by a comma) or that include `=[...]'.
660 Patch by Nicolas François.
661 Fix the four offenders thus exposed:
662 * src/join.c (usage): Use two spaces (not one) to separate the
663 --first-only option string from its description, so help2man formats
664 the derived man page properly.
665 * src/pr.c (usage): Likewise.
666 * src/uniq.c (usage): Likewise.
667 * src/install.c (usage): Likewise.
669 2006-02-15 Jim Meyering <jim@meyering.net>
671 * Makefile.maint (alpha beta major): For `make major', ensure that the
672 version string is of the form N.N[.N]*, where N is one or more digits.
674 2006-02-14 Jim Meyering <jim@meyering.net>
676 * INSTALL: Update from gnulib.
678 2006-02-13 Jim Meyering <jim@meyering.net>
680 * GNUmakefile (all): Emit diagnostics to stderr, not stdout.
682 2006-02-12 Jim Meyering <jim@meyering.net>
684 * Makefile.maint (patch-check): New target.
685 (local-checks-available): Add to the list.
687 2006-02-11 Jim Meyering <jim@meyering.net>
689 * src/c99-to-c89.diff: New file.
690 * src/Makefile.am (EXTRA_DIST): Add c99-to-c89.diff.
692 * .x-po-check: New file, with exclusions so that `make distcheck'
694 * Makefile.am (EXTRA_DIST): Add .x-po-check.
696 rm -r must remove an empty directory, even if it is inaccessible.
697 * src/remove.c (close_preserve_errno): New function.
698 (fd_to_subdirp): Don't print a diagnostic in this function.
699 Do it from the callers instead, unless rmdir succeeds.
700 (remove_cwd_entries, remove_dir): Adjust callers.
701 * tests/rm/empty-inacc: New test for the above.
702 * tests/rm/Makefile.am (TESTS): Add empty-inacc.
703 * NEWS: Mention this bug fix.
704 * tests/rm/rm2: Adjust two expected diagnostics, now that they're
705 a tiny bit less precise: cannot remove `a/1': ... instead of
706 cannot open directory `a/1': ...
708 * Makefile.maint (syntax-check-rules): Automatically derive this
709 list of sc_-prefixed rule names.
711 2006-02-10 Paul Eggert <eggert@cs.ucla.edu>
713 * Makefile.maint (CVS_LIST): Don't assume cvsu is available.
714 (CVS_LIST_EXCEPT): New macro, to simplify exception-processing.
715 Most uses of CVS_LIST changed to use CVS_LIST_EXCEPT.
716 (syntax-check-rules): Bring back sc_changelong. (Hmm, why did it
717 go away? was that an accident?)
718 (sc_cast_of_argument_to_free, sc_cast_of_x_alloc_return_value):
719 (sc_cast_of_alloca_return_value, sc_space_tab, sc_prohibit_atoi_atof):
720 (sc_error_exit_success, sc_file_system, sc_no_if_have_config_h):
721 (sc_system_h_headers, sc_sun_os_names, sc_trailing_blank):
722 (sc_two_space_separator_in_usage, sc_unmarked_diagnostics):
723 (sc_obsolete_symbols, sc_changelog, sc_prohibit_jm_in_m4):
724 (sc_useless_cpp_parens, makefile-check, m4-check, po-check):
725 (author_mark_check, makefile_path_separator_check):
726 Output line numbers, to simplify navigation of Emacs *compilation*
728 (sc_prohibit_atoi_atof, sc_file_system):
729 Rework slightly so that Makefile.maint doesn't get reported as a
730 violation of its own syntax rules.
731 (sc_dd_max_sym_length): Use ifneq to do nothing, instead of doing
732 it at run-time (which didn't work with Bison). Fix a makefile typo,
733 caught by Makefile.maint itself: spaces where a tab should be.
734 (po-check): Check lib/*.[ch] even if not in CVS; used by Bison,
735 which copies from ../gnulib/lib/*.[ch] to lib/*.[ch].
736 Ignore djgpp and man subdirectories, to avoid false matches with
737 Bison and coreutils, respectively. Use sort -u to remove the
738 resulting duplicates.
739 * gnupload: Rework slightly to avoid bogus warning from
740 sc_two_space_separator_in_usage.
742 2006-02-10 Jim Meyering <jim@meyering.net>
744 Use gzip's --rsyncable option only if it's available.
745 * Makefile.maint (gzip_rsyncable): New variable.
748 2006-02-08 Jim Meyering <jim@meyering.net>
750 * Makefile.maint (local-checks-available): Define in terms of
751 the expansion, $(syntax-check-rules), rather than the single,
752 top-level target `syntax-check', so that it's easier to exclude
753 individual rules (via $(local-checks-to-skip)).
754 (tgz-md5, tgz-sha1, ...): Remove now-unused definitions.
756 2006-02-07 Jim Meyering <jim@meyering.net>
758 * src/system.h (!defined O_DIRECT): If O_DIRECTIO is defined (as it
759 is on Tru64), define O_DIRECT to that. Patch From James Lemley.
761 * tests/help-version (expected_failure_status_vdir):
762 Redirect an expected disk-full diagnostic to /dev/null.
764 2006-02-06 Jim Meyering <jim@meyering.net>
766 * src/unexpand.c (usage): Use two spaces (not one) to separate the
767 --first-only option string from its description, so help2man formats
768 the derived man page properly.
769 * src/rm.c (usage): Likewise for --no-preserve-root.
770 * src/chown.c (usage): Likewise.
771 * src/chgrp.c (usage): Likewise.
773 Add a rule to ensure that the above doesn't happen again.
774 * Makefile.maint (sc_two_space_separator_in_usage): New rule.
775 (syntax-check-rules): Add it.
776 * .x-sc_two_space_separator_in_usage: New empty file.
777 * Makefile.am (EXTRA_DIST): Add .x-sc_two_space_separator_in_usage.
779 2006-02-06 Jim Meyering <jim@meyering.net>
781 * src/cp.c (usage): Use two spaces (not one) to separate each
782 option string from its description, so help2man formats the
783 derived man page properly.
784 * src/mv.c (usage): Likewise.
785 Patch from Nicolas François in http://bugs.debian.org/351601.
787 2006-02-04 Jim Meyering <jim@meyering.net>
789 * src/copy.c (copy_internal): cp -RL would fail when encountering
790 the same directory more than once in the hierarchy beneath a single
791 command-line argument. That is legitimate, e.g. when there are
792 two or more symbolic links, each pointing to some directory that
793 would not otherwise be copied. Reported by Christophe LYON.
794 * tests/cp/cp-deref: New file. Test for today's fix.
795 * tests/cp/Makefile.am (TESTS): Add cp-deref.
796 * NEWS: Document this.
798 2006-02-03 Jim Meyering <jim@meyering.net>
800 * configure.ac: Require automake-1.9.6, not 1.8.3.
802 2006-02-01 Paul Eggert <eggert@cs.ucla.edu>
804 * src/od.c (usage): Mention that -t a ignores high order bit.
805 Documentation problem reported by Ed Avis.
807 2006-02-01 Jim Meyering <jim@meyering.net>
809 * src/pwd.c (find_dir_entry): Remove unused local, `ent_sb_valid'.
811 2006-01-30 Paul Eggert <eggert@cs.ucla.edu>
813 * src/head.c (main): Use a better diagnostic when someone uses a
814 trailing numeric option in an invalid way. Problem reported by
816 * src/tail.c (parse_options): Likewise.
818 2006-01-30 Jim Meyering <jim@meyering.net>
820 * man/wc.x: Include `count' keyword in man page synopsis,
821 per suggestion from http://bugs.debian.org/181585.
823 2006-01-24 Paul Eggert <eggert@cs.ucla.edu>
825 * src/df.c (show_dev): If the file system claims to have
826 more available than total blocks, report the number of used
827 blocks as being total - available (a negative number) rather
828 than as garbage. Problem reported by Toralf Foerster.
830 2006-01-24 Jim Meyering <jim@meyering.net>
832 * src/tail.c (tail_forever): Don't exit-nonzero when an attempt
833 to put a regular file in O_NONBLOCK mode fails with EPERM.
834 That happens on Linux (up to 2.6.15) when using tail -f on a file with
835 the append-only attribute. Reported by Dean Gaudet. For details,
836 see http://savannah.gnu.org/bugs/?func=detailitem&item_id=15473.
837 * NEWS: Mention this fix.
838 * tests/tail-2/append-only: New file. Test for the above.
839 * tests/tail-2/Makefile.am (TESTS): Add append-only.
840 * tests/Makefile.am (check-root): Add tail-2/append-only
842 2006-01-21 Jim Meyering <jim@meyering.net>
844 * NEWS: Mention fts-related improvements and bug fixes.
846 2006-01-19 Jim Meyering <jim@meyering.net>
848 * tests/fmt/basic (pfx-1, pfx-2): New tests, to demonstrate the bug
849 reported as http://bugs.debian.org/147577. Forwarded by Thomas Hood.
851 2006-01-18 Jim Meyering <jim@meyering.net>
853 * tests/du/Makefile.am (TESTS): Add long-from-unreadable.
855 2006-01-17 Jim Meyering <jim@meyering.net>
857 Now that fts no longer changes the current working directory, adjust
858 its clients accordingly -- note that du.c uses fts but doesn't need
859 any adjustment, since it doesn't operate on the actual files,
860 but rather just uses the stat buffers provided by fts.
862 * src/chown-core.c: Include "openat.h".
863 Don't include "lchown.h".
864 (restricted_chown): Accept a new parameter, CWD_FD, and use it in
865 calling openat, lchownat, chownat, rather than open, lchown, chown.
867 * src/chmod.c: Include "openat.h".
868 (process_file): Use chmodat (fts->fts_cwd_fd,... in place of chmod (...
870 * tests/du/long-from-unreadable: New test, to exercise one small
873 2006-01-13 Jim Meyering <jim@meyering.net>
875 * tests/Makefile.am (SUBDIRS): Add comments discouraging the
876 addition of new directories under tests/.
878 * tests/acl: Redirect stdin to /dev/null. Otherwise, FreeBSD 5.0's
881 2006-01-12 Jim Meyering <jim@meyering.net>
883 * tests/du/long-sloop: Adjust not to hard-code the expected
884 diagnostic corresponding to ELOOP. Solaris' diagnostic differs
885 from that of GNU libc. Reported by Paul Eggert.
887 * tests/du/long-sloop: Create file at end of symlink chain.
889 * tests/misc/test: New file, with a test for one of the
890 bugs fixed by yesterday's test.c changes.
891 * tests/misc/Makefile.am (TESTS): Add test.
893 2006-01-11 Jim Meyering <jim@meyering.net>
895 * tests/du/long-sloop: New file. Test for today's fts.c bug fix.
896 That bug could make du -L, chgrp -L, or chown -L fail to diagnose
897 a very long sequence of symbolic links (not necessarily a loop).
898 * tests/du/Makefile.am (TESTS): Add long-sloop.
900 2006-01-11 Paul Eggert <eggert@cs.ucla.edu>
902 * src/test.c (test_syntax_error): Append a newline. All callers
903 changed, except for the ones that didn't already append a newline.
904 Bug reported by Eric Blake.
906 2006-01-11 Jim Meyering <jim@meyering.net>
908 * src/system.h (X2NREALLOC): Now that verify_true is no longer
909 void, cast its result to void, to avoid gcc's warning that
910 ``left-hand operand of comma expression has no effect''.
911 (DECIMAL_DIGIT_ACCUMULATE, X2REALLOC): Likewise.
913 2006-01-10 Jim Meyering <jim@meyering.net>
915 * tests/chmod/no-x: Add a test for today's fts.c fix.
917 2006-01-10 Jim Meyering <jim@meyering.net> (tiny change)
919 * src/ls.c (gobble_file): Use DTTOIF only if it's defined.
920 This is necessary for Dragonfly. Patch by Joerg Sonnenberger.
922 2006-01-10 Paul Eggert <eggert@cs.ucla.edu>
924 * src/system.h (X2NREALLOC, X2REALLOC, DECIMAL_DIGIT_ACCUMULATE):
925 Use verify_true instead of verify_expr, to sync with gnulib.
927 2006-01-08 Jim Meyering <jim@meyering.net>
929 * src/date.c (usage): Adjust the formatting of the entries for
930 %::z and %:::z (separate with two spaces, not one) so that help2man
931 formats them properly. Reported by Philip Rowlands.
933 2006-01-06 Paul Eggert <eggert@cs.ucla.edu>
935 * configure.ac (gl_IGNORE_UNUSED_LIBRARIES): Add.
937 2006-01-06 Jim Meyering <jim@meyering.net>
939 * Makefile.maint (copyright-check): Use date +%Y in place of
942 * src/remove.c (rm_1): Remove `static' attribute on local `status'.
943 First off, the attribute should have been `volatile' (not static)
944 to avoid longjmp-related risk of clobber. Secondly, now there is
945 no longer any risk of a local variable being clobbered, so there's
946 no need for any attribute at all.
948 2006-01-05 Jim Meyering <jim@meyering.net>
950 * src/remove.c: Give a few functions the inline attribute.
951 (AD_pop_and_chdir): Use gotos to avoid some duplication.
952 (AD_push): Rewrite an assertion so that the entire computation
953 goes away when assertions are turned off.
955 * src/tail.c (ENOSYS) [!defined ENOSYS]: Don't define here.
956 It's already defined in "system.h".
957 * Makefile.maint: Add a FIXME comment.
959 2006-01-04 Jim Meyering <jim@meyering.net>
961 * ChangeLog: Remove entries from 2005-10-22 and earlier.
962 * ChangeLog-2005: New file, for entries up to version 5.92.
964 2006-01-03 Jim Meyering <jim@meyering.net>
966 * tests/du/no-x: Also allow a slightly different diagnostic -- the
967 one you get when using openat-enabled fts.c and du (coming soon).
968 * tests/chmod/no-x: Likewise.
969 * tests/chgrp/no-x: Likewise.
971 * src/system.h (O_DIRECTORY) [!defined O_DIRECTORY]: Define.
973 2006-01-02 Paul Eggert <eggert@cs.ucla.edu>
975 * src/chown-core.c (RC_do_ordinary_chown): New enum value.
976 (restricted_chown): Return it, if the file cannot be accessed due
977 to EPERM, or if no uid or gid are required, or if the file is
978 neither a directory nor a regular file. Rewrite to avoid gotos.
979 (change_file_owner): Handle RC_do_ordinary_chown case.
980 Rewrite to avoid gotos.
981 * tests/chgrp/basic: Make sure we can change the group of
984 * src/date.c (usage): Explain %g, %G, and %V a bit better.
986 2006-01-02 Jim Meyering <jim@meyering.net>
988 * src/copy.c (set_owner): Correct a comment.
990 * src/tail.c (parse_options): Change warning to say that --retry
991 is useful `mainly' (not `only') when following by name.
992 Reported here: http://bugs.debian.org/273781
994 2006-01-01 Paul Eggert <eggert@cs.ucla.edu>
996 * NEWS: Document that mkfifo and mknod -m no longer set special bits.
997 * src/copy.c: Include lchmod.h.
998 (copy_internal): Use lchmod rather than chmod.
999 * src/cp.c: Include lchmod.h.
1000 (re_protect, make_dir_parents_private): Use lchmod rather than chmod.
1001 * src/mkdir.c: Include lchmod.h.
1002 (usage): Clarify -m's operation.
1003 (main): Use lchmod rather than chmod. Don't use lchmod unless the
1004 new mode contains bits outside the 777 range.
1005 * src/mkfifo.c (usage): Clarify -m's operation.
1006 (main): If -m is given, don't invoke chmod; use umask 0 instead.
1007 Report an error if -m asks for bits outside the 777 range.
1008 * src/mknod.c (usage, main): Likewise.
1010 * src/mkdir.c, src/mkfifo.c, src/mknod.c: Undo 2005-12-19 changes.
1012 2005-12-27 Jim Meyering <jim@meyering.net>
1014 * Makefile.maint (sc_obsolete_symbols): Prohibit use of O_NDELAY.
1015 (sc_prohibit_assert_without_use): New rule.
1016 (syntax-check-rules): Add it to the list.
1017 * .x-sc_prohibit_assert_without_use: New empty file.
1018 * Makefile.am (EXTRA_DIST): Add it.
1020 * Makefile.maint (CVS_LIST): Define in terms of $(srcdir).
1022 * cp.c, df.c, link.c, mknod.c, nice.c, sleep.c, unlink.c:
1023 Don't include <assert.h>; it wasn't used.
1025 2005-12-26 Paul Eggert <eggert@cs.ucla.edu>
1027 * src/chown-core.c (restricted_chown):
1028 Don't try O_WRONLY unless O_RDONLY failed wth EACCES.
1029 * src/remove.c (fd_to_subdirp): Open with O_DIRECTORY | O_NOCTTY
1030 | O_NOFOLLOW too, for consistency with other dir-openers.
1031 Use POSIX-preferred O_NONBLOCK rather than O_NDELAY.
1032 (is_empty_dir): Likewise.
1033 * src/shred.c (wipename): Likewise. Don't bother trying to open
1034 dir for writing, since POSIX prohibits it.
1036 2005-12-22 Jim Meyering <jim@meyering.net>
1038 * tests/help-version: Redirect stderr to /dev/full, to suppress
1039 write error diagnostic.
1041 2005-12-19 Jim Meyering <jim@meyering.net>
1043 * src/mkdir.c, src/mknod.c, src/mkfifo.c (main)
1044 Avoid a minor race condition when `-m MODE' is specified, by using
1045 open, fchown, and close rather than just chown. To do that reliably --
1046 even with an overly restrictive umask -- ensure that each mkdir,
1047 mknod and mkfifo call uses a mode including at least owner-read access.
1048 * src/mknod.c (main): When `-m MODE' is specified, exit nonzero if
1049 the subsequent chown (or equivalent open,fchown,close) fails.
1050 * tests/misc/mknod: New tests.
1051 * tests/misc/Makefile.am (TESTS): Add mknod.
1053 2005-12-17 Jim Meyering <jim@meyering.net>
1055 * src/remove.c (is_empty_dir): Open with O_NDELAY, so we don't hang,
1056 e.g., on a named pipe.
1057 (OPEN_NO_FOLLOW_SYMLINK): Remove definition. Use O_NOFOLLOW in
1058 place of all uses, since it is guaranteed (system.h) to be defined.
1060 2005-12-05 Andreas Gruenbacher <agruen@suse.de>
1062 Add POSIX ACL support
1063 * src/ls.c: Switch back from HAVE_ACL to USE_ACL: The acl() syscall
1064 is no requirement for ACL support; particularly, it does not exist
1065 on systems that have POSIX ACLs.
1066 * src/copy.h (cp_option_init) [umask_kill]: Remove member.
1067 * src/cp.c (umask_kill): With default acls, the umask is not to be
1068 applied. Remove umask_kill, don't change the process umask, and let
1069 the kernel apply the umask where appropriate.
1070 * src/cp.c (make_dir_parents_private): Fix logic for POSIX ACLs.
1071 * src/copy.c (get_dest_mode): Remove; it is obsolete after removing
1073 (copy_reg, copy_internal): Use copy_acl and set_acl
1074 instead of fchown/chown. Fix the logic for POSIX ACLs.
1075 (chown_succeded): Remove; we now always copy acls and
1076 preserve S_ISUID, S_ISGID, and S_ISVTX when needed, no matter if we
1077 did a chown before or not.
1078 * src/mv.c, src/install.c (cp_option_init): Don't set umask_kill member.
1079 * src/Makefile.am (dir_LDADD, ls_LDADD, vdir_LDADD, cp_LDADD,
1080 mv_LDADD, ginstall_LDADD): On systems with an ACL library, arrange
1081 to link with it via $(LIB_ACL), for the utilities that need it.
1083 2005-12-16 Paul Eggert <eggert@cs.ucla.edu>
1085 * src/remove.c (OPENAT_CWD_RESTORE__REQUIRE): Remove.
1086 (OPENAT_CWD_RESTORE__ALLOW_FAILURE): Likewise.
1087 (fd_to_subdirp): Remove openat_cwd_restore_allow_failure arg; its
1088 value is now signified by whether cwd_errno is null.
1089 (fd_to_subdirp, remove_dir, rm_1); Change cwd failure indicator from
1090 pointer-to-bool to pointer-to-errno-value. All callers changed.
1091 (rm_1): Don't bother setting a local cwd failure flag and then
1092 ORing it into the caller's. Just set the caller's.
1093 (rm): Use cwd failure errno value to print a slightly-better
1096 2005-12-15 Jim Meyering <jim@meyering.net>
1098 * src/stat.c (print_it): Properly handle a backslash at the
1099 end of a --printf format string. Reported by Paul Eggert.
1100 * tests/misc/stat-printf (end-bs): Add a test for the above.
1102 2005-12-15 Paul Eggert <eggert@cs.ucla.edu>
1104 * tests/acl: Port to pre-POSIX shells like Solaris 8 /bin/sh.
1105 Don't assume /etc/passwd contains user names; use 'id' instead.
1107 2005-12-15 Jim Meyering <jim@meyering.net>
1109 stat: revert behavior of --format=FMT (-c)
1110 stat: add new option: --printf=FMT
1111 * NEWS: Mention this.
1112 * src/stat.c (isodigit, octtobin, hextobin): Define.
1113 (PRINTF_OPTION): Define.
1114 (interpret_backslash_escapes, trailing_delim): New globals.
1115 (usage): Document them. Alphabetize on long option names.
1116 (print_esc_char): New function.
1117 (print_it): Rewrite, in order to handle backslash escapes.
1118 (main): Handle new option. Set globals for --format, too.
1120 * tests/misc/stat-printf: Test --printf and --format.
1121 * tests/misc/Makefile.am (TESTS): Add stat-printf.
1123 2005-12-14 Paul Eggert <eggert@cs.ucla.edu>
1125 * NEWS: sort now reports incompatible options.
1126 * src/sort.c (incompatible_options, check_ordering_compatibility):
1128 (main): Use them. Don't bother with a usage message for
1129 "sort -c a b", for consistency with other error diagnostics.
1130 * tests/sort/Test.pm (incompat1, incompat2, incompat3, incompat4):
1133 * src/cat.c (main): Undo previous change. close_stdout already
1134 does the check, so the previous change wasn't necessary.
1136 2005-12-13 Paul Eggert <eggert@cs.ucla.edu>
1138 * src/cat.c (main): Check for close (STDOUT_FILENO) failure.
1140 2005-12-12 Paul Eggert <eggert@cs.ucla.edu>
1142 Install a more-conservative approach for sort -R. It's the
1143 same basic idea as the existing code, except it uses the full ISAAC
1144 approach (called the "more kosher" approach in the existing comments).
1145 This makes "sort -R" quite a bit slower (about a factor of 2 on my
1146 little tests involving 10000 lines on a 2.4 GHz P4), but I think it's
1147 better to be conservative here at first, and review any performance
1148 improvements carefully.
1149 * .x-sc_require_config_h: Add src/rand-isaac.c.
1150 * src/rand-isaac.h: Remove. All uses now simply include rand-isaac.c.
1151 * src/Makefile.am (noinst_HEADERS): Remove rand-isaac.h.
1152 (shred_SOURCES, sort_SOURCES): Remove.
1153 (EXTRA_DIST): Add rand-isaac.c.
1154 * src/rand-isaac.c: Revert to what used to be in shred.c, without
1155 changing it to allow for varying numbers of words in the state.
1156 Alter so that we include rand-isaac.c directly rather than
1157 compiling it and linking to it. Don't include config.h or
1158 system.h; that's the includer's responsibility.
1159 Omit functions that are specific to shred.
1160 (ISAAC_LOG, ISAAC_WORDS, ISAAC_BYTES, struct isaac_state, ind):
1161 (isaac_step, struct irand_state):
1162 Resurrect these, with the same defns that used to be in shred.c.
1163 (ISAAC_SIZE, isaac_new, isaac_copy): Remove.
1164 (isaac_refill, isaac_seed_start, isaac_seed_data, irand_init, irand32):
1166 (struct isaac_state, isaac_refill, isaac_mix, isaac_init):
1167 (isaac_seed_start, isaac_seed_data, isaac_seed_finish, isaac_seed):
1168 (irand_init, irand32, irand_mod):
1169 Number of words is constant again.
1170 (struct irand_state, irand_init, irand32, irand_mod): Move to shred.c.
1171 * src/shred.c: Include rand-isaac.c rather than rand-isaac.h.
1172 * src/sort.c: Likewise.
1173 * src/shred.c (fillrand, dopass, main): Undo previous change.
1174 (struct irand_state, irand_init, irand32, irand_mod): Moved back here,
1176 * src/sort.c: Don't include md5.h; it wasn't needed.
1177 (struct keyfield): Rename random_hash to random, for consistency
1178 with the other member names. All uses changed.
1179 (usage): Tweak wording to mention STRING for --seed option.
1180 (short_options): Rorder for consistency with other programs.
1181 (rand_state): Now a struct, not a pointer to one. All uses changed.
1182 (HASH_WORDS, HASH_SIZE): Remove.
1183 (get_hash): Remove comments around resbuf size, since we can assume C89.
1184 Use a "more-kosher" (but slower) approach of invoking isaac_refill.
1185 (keycompare): Adjust to the new get_hash.
1187 (badfieldspec): Omit recently-introduced comment; it isn't needed.
1188 (main): Don't set need_random simply because gkey has it set; that
1189 doesn't necessarily mean we'll need random numbers.
1190 Redo seeding to match new get_hash approach.
1192 2005-12-10 Jim Meyering <jim@meyering.net>
1194 * src/Makefile.am (noinst_HEADERS): Add rand-isaac.h.
1196 Avoid shred segfault on 64-bit systems.
1197 * src/rand-isaac.c (isaac_refill): Don't try to negate a
1198 local of type uint32_t. Make the local an `int' instead.
1200 * NEWS: Mention sort's new options.
1202 * src/rand-isaac.c (isaac_mix): Declare to be static.
1203 Mark all other functions as `extern' so the tight-scope
1204 part of `make distcheck' passes once again.
1205 * src/rand-isaac.h (isaac_mix): Remove declaration.
1207 * src/sort.c (get_hash): Change position of `*' in parameter
1208 type to conform with convention.
1209 (main): Split a long line so it fits in 80 columns.
1210 (keycompare): Remove stray SPACE before TAB that was
1211 causing `make distcheck' to fail.
1213 * src/shred.c: Don't include gethrxtime.h. No longer needed.
1215 * tests/misc/sort-rand: New file: basic tests for the new options.
1216 * tests/misc/Makefile.am (TESTS): Add sort-rand.
1218 2005-12-10 Frederik Eaton <frederik@ofb.net>
1220 * src/Makefile.am (sort_LDADD): Add $(LIB_GETHRXTIME).
1221 (shred_SOURCES, sort_SOURCES): New macros, so we compile rand-isaac.c.
1222 * src/rand-isaac.c: New file, containing ISAAC code that was in shred.c.
1223 Make state size runtime-configurable.
1224 (isaac_new, isaac_copy): New functions.
1225 * src/rand-isaac.h: New file.
1226 * src/shred.c: Include rand-isaac.h. Move ISAAC code to rand-isaac.c.
1227 (fillrand, main): Adjust to the fact that the state size is now
1228 runtime-configurable.
1229 * src/sort.c (short_options, long_options, WORDS, keycompare, main):
1230 (usage): Add options --random-sort and --seed to implement a random
1232 Include md5.h and rand-isaac.h.
1233 (get_hash): New function.
1234 (rand_state): New var.
1235 (HASH_WORDS, HASH_SIZE): New macros.
1237 2005-12-09 Paul Eggert <eggert@cs.ucla.edu>
1239 * tests/dd/misc: Add test for dd iflags=noatime.
1241 2005-12-09 Jim Meyering <jim@meyering.net>
1243 * src/sort.c (usage): Mention white space vs -b and -t options.
1246 2005-12-09 Eric Blake <ebb9@byu.net>
1248 * src/test.c (main): Fix misleading comment.
1250 2005-12-07 Paul Eggert <eggert@cs.ucla.edu>
1252 * NEWS: Mention dd's new noatime flag.
1253 * src/system.h (O_NOATIME): Define to 0 if not already defined.
1254 * src/dd.c (flags, usage): Add support for noatime flag.
1256 2005-12-07 Jim Meyering <jim@meyering.net>
1258 Distribute the cvsu script, used only by `make syntax-check'.
1259 * Makefile.am (EXTRA_DIST): Add build-aux/cvsu.
1260 * Makefile.maint (CVS_LIST): Use build-aux/cvsu, now that we
1261 distribute a copy of this script.
1262 * .x-sc_unmarked_diagnostics: Add build-aux/cvsu.
1264 * tests/mv/acl: exit-77 before the trap, not after, if we fail
1265 to create a temporary directory on another partition.
1266 From Andreas Gruenbacher.
1268 2005-12-06 Tomas Pospisek <tpo@sourcepole.ch> (tiny change)
1270 * man/basename.x: Cross-reference to dirname and readlink.
1271 * man/dirname.x: Cross-reference to basename and readlink.
1273 2005-12-05 Andreas Gruenbacher
1275 * src/copy.c [!HAVE_FCHOWN]: Define fchown(...) to -1.
1276 (set_owner, preserve_author): New functions, factored out of copy_reg.
1277 (copy_reg): Use them.
1278 (copy_internal): Use them here, too.
1280 2005-12-04 Jim Meyering <jim@meyering.net>
1282 * src/sleep.c (usage): Say what happens with two or more arguments.
1283 Suggested by Justin Pryzby.
1285 * src/uptime.c (print_uptime): Move decl of `upsecs' into scope
1288 2005-12-03 Jim Meyering <jim@meyering.net>
1290 * src/rm.c (long_opts): Change the name of each undocumented, for-
1291 testing-only option to start with `-', so that it cannot render
1292 ambiguous any prefix it happens to share with some other option name.
1293 Problem reported by Eric Blake.
1294 * src/head.c (long_options): Likewise.
1295 * src/tail.c (long_options): Likewise.
1297 * tests/misc/head-elide-tail: Update uses of undocumented, for-
1298 testing-only --presume* options to start with `---'.
1299 * tests/rm/dangling-symlink: Likewise.
1300 * tests/rm/dir-no-w: Likewise.
1301 * tests/rm/isatty: Likewise.
1303 2005-11-30 Jim Meyering <jim@meyering.net>
1305 * Makefile.maint: Add a comment about cvsu.
1307 2005-11-25 Paul Eggert <eggert@cs.ucla.edu>
1309 * NEWS: df updates for "none", "proc", inaccessible file systems.
1310 * src/df.c (show_point): Ignore inaccessible file systems.
1311 (usage): -a includes dummy file systems, not size-0 file systems.
1313 * src/od.c (unsigned_long_long_int): Renamed from ulonglong_t,
1314 to avoid collision with POSIX name space. All uses changed.
1316 2005-11-24 Jim Meyering <jim@meyering.net>
1318 * tests/Makefile.am (EXTRA_DIST): Add acl to the list.
1319 * tests/acl: Add `$0: ' prefix to diagnostics.
1321 * .x-sc_require_config_h: Add lib/buffer-lcm.c to the list.
1323 2005-11-23 Paul Eggert <eggert@cs.ucla.edu>
1325 * src/copy.c: Improve performance a bit by optimizing away
1326 unnecessary system calls and going to a block size of at least
1327 8192 (on normal hosts, anyway). This improved performance 5% on my
1328 Debian stable host (2.4.27 kernel, x86, copying from root
1329 ext3 file system to itself).
1330 Include "buffer-lcm.h".
1331 (copy_reg): Omit last argument. All callers changed.
1332 Use xmalloc to allocate rather than trusting alloca
1333 (which is unwise with large block sizes).
1334 Declare locals more locally, if possible.
1335 Use uintptr_t words instead of int words, for a bit more speed
1336 when looking for null blocks on 64-bit hosts.
1337 Optimize away reads of zero bytes on regular files.
1338 In the typical case, insist on 8 KiB buffers, at least.
1339 Avoid unnecessary extra call to fstat when checking for sparse files.
1340 Avoid now-unnecessary cast to off_t, and "0L".
1341 Avoid unnecessary test of *new_dst when checking for same owner
1344 2005-11-22 Paul Eggert <eggert@cs.ucla.edu>
1346 * src/remove.c (rm): Don't assume C99 for-loop syntax.
1348 2005-11-22 Jim Meyering <jim@meyering.net>
1350 * src/remove.c (AD_push): Remove debugging cruft.
1352 * tests/rm/unread2 (rm): Change expected diagnostic,
1353 `cannot open directory' to `cannot remove', to align with
1355 * tests/rm/rm2: Ensure that rm now continues removing entries
1356 even after certain types of failure.
1358 * src/remove.c: Rewrite. Now, this module is reentrant on systems
1359 that provide openat (Solaris), and on systems like Linux+procfs
1360 where our openat emulation code is reentrant. This also fixes a
1361 few low-probability leaks and eliminates some code that could,
1362 in very unusual circumstances, cause rm() (via a callee) to exit.
1363 * NEWS: Mention this.
1365 * configure.ac: Put copyright dates all on one line so the
1366 emacs function that updates them works properly.
1368 2005-11-18 Paul Eggert <eggert@cs.ucla.edu>
1370 * configure.ac (AM_PROG_CC_C_O): Add. Needed for CVS Automake.
1371 Problem reported by Eric Blake.
1372 (AC_PROG_CC_STDC): Use this instead of AC_PROG_CC, so that
1373 we get a standard-conforming compiler. This relies on the new
1374 m4/c.m4 file. Note that it's a bit tricky, since c.m4 doesn't
1375 define AC_PROG_CC_STDC; we are relying on Autoconf 2.59 internals.
1376 m4/c.m4 can go away with Autoconf 2.60 comes out.
1378 2005-11-17 Jim Meyering <jim@meyering.net>
1380 * src/remove.c (AD_mark_helper): Make a `char *' parameter `const'.
1381 (AD_mark_current_as_unremovable): Likewise, but for a local.
1384 * tests/mv/acl: Let traps handle removing temporary directories.
1386 Expect acl-related tests to fail, until the corresponding
1387 patches are committed.
1388 * tests/mv/Makefile.am (XFAIL_TESTS): Add acl.
1389 * tests/cp/Makefile.am (XFAIL_TESTS): Likewise.
1391 ACL tests, from Andreas Gruenbacher.
1392 * tests/acl, tests/mv/acl, tests/cp/acl: New files.
1393 * tests/mv/Makefile.am (TESTS): Add acl.
1394 * tests/cp/Makefile.am (TESTS): Add acl.
1396 * src/ls.c (basename_is_dot_or_dotdot): Correct wording in comment.
1398 2005-11-16 Paul Eggert <eggert@cs.ucla.edu>
1400 * NEWS: Improve quality of ln's diagnostics.
1401 * src/ln.c (do_link, usage): Likewise.
1402 (do_link): Don't use alloca on a buffer of unbounded size.
1404 2005-11-16 Jim Meyering <jim@meyering.net>
1406 * tests/cp/fail-perm: Accommodate HPUX. It appears to fail
1407 with EACCES rather than EPERM. Reported by Peter O'Gorman here:
1408 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/5766
1409 This also affects AIX 4.3.3, according to Ralf Wildenhues, in
1410 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
1412 2005-11-14 Jim Meyering <jim@meyering.net>
1414 * NEWS (sort): Mention consequences of today's mkstemp-safer.c fix.
1416 2005-11-13 Jim Meyering <jim@meyering.net>
1418 * announce-gen: Accept new option, --gpg-key-id=ID and
1419 emit a blurb telling how to use the .sig files.
1420 * Makefile.cfg (gpg_key_ID): Define.
1421 * Makefile.maint (announcement): Use new option and key.
1423 Require that most .c files include <config.h>.
1424 * Makefile.maint (sc_require_config_h): New rule.
1425 (syntax-check-rules): Add it.
1426 * .x-sc_require_config_h: New file listing exceptions to the
1427 above rule. Some are legit, others are simply grandfathered in.
1428 * Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h here, too.
1430 2005-11-12 Jim Meyering <jim@meyering.net>
1432 * src/checksum.h, src/md5.c, src/sha1sum.c: Remove now-unused files.
1434 2005-11-11 Jim Meyering <jim@meyering.net>
1436 * NEWS: Mention `readlink -f' bug fix in 5.3.0 news.
1437 Mention new readlink options in 5.3.0's `New features' section.
1438 Spotted by Thomas Hood.
1440 2005-11-08 Jim Meyering <jim@meyering.net>
1442 * NEWS: Merge in changes from b5_9x branch.
1444 2005-11-08 Paul Eggert <eggert@cs.ucla.edu>
1446 * NEWS: ls now defaults to --time-style='locale', which in turn acts
1447 like --time-style='posix-long-iso' if the locale settings are messed up.
1448 * src/ls.c (decode_switches): Implement this.
1450 2005-11-08 Jim Meyering <jim@meyering.net>
1452 * tests/du/2g: s/expensive/very expensive/ in a comment.
1455 2005-10-17 Eric Blake <ebb9@byu.net>
1457 * src/ls.c (usage): Fix descriptions of --sort, --time.
1458 Reported by Vitaly A. Ostanin.
1460 2005-11-04 Paul Eggert <eggert@cs.ucla.edu>
1462 * src/ln.c: Include filenamecat.c.
1463 (FILE_BASENAME_CONCAT): Remove.
1464 (do_link): Remove last arg DEST_IS_DIR. All callers changed.
1465 (main): Use file_name_concat, base_name, and strip_trailing_slashes
1466 instead of FILE_BASENAME_CONCAT. This simplifies the code, and avoids
1469 2005-11-04 Jim Meyering <jim@meyering.net>
1471 * src/du.c (process_file): Don't overflow for files of size >= 2^31
1472 on systems with stat.st_blocks of a signed 32-bit type.
1473 This bug causes trouble on some AIX 5.1 systems.
1474 Report and trivial patch from Paul Townsend:
1475 <http://lists.gnu.org/archive/html/bug-coreutils/2005-11/msg00033.html>
1476 * NEWS: Mention this.
1478 * tests/du/2g: New (very-expensive) test for the above-fixed bug.
1479 * tests/du/Makefile.am (TESTS): Add it here.
1480 * tests/very-expensive: New file.
1481 * tests/Makefile.am (EXTRA_DIST): Add it here.
1482 * tests/cp/perm: Mark this test as `very-expensive', too.
1484 2005-11-02 Paul Eggert <eggert@cs.ucla.edu>
1486 * NEWS: Mention that rm -d and maybe ln -d are scheduled for
1488 * src/remove.h (struct rm_options): Remove unlink_dirs. All uses
1490 * src/rm.c (usage): Don't mention rm -d.
1492 2005-11-02 Jim Meyering <jim@meyering.net>
1494 * tests/dd/skip-seek: Fix typo in comment: s/fileutils/coreutils.
1495 From Andreas Schwab.
1497 * tests/dd/unblock-sync: Redirect stderr to /dev/null so the
1498 `M+N records in/out' lines don't pollute `make check' output.
1500 * tests/dd/skip-seek (sk-seek4): New test, to exercise the bug
1501 fixed on 2005-10-31. This test uses the new, IN_PIPE specifier.
1502 * tests/Coreutils.pm: Accept a new type of input specifier: IN_PIPE,
1503 to indicate that the input file should be piped into the command
1504 under test (via `cat FILE | $prog ...').
1506 * src/remove.c (remove_entry): Emit a better diagnostic when rm
1507 (without -r) fails to remove a directory on a non-Linux system.
1508 This change affects only newer Solaris systems (with priv_*
1509 functions like priv_allocset). Reported by Keith Thompson.
1511 * tests/rm/dir-nonrecur: New file/test for the above fix.
1512 * tests/rm/Makefile.am (TESTS): Add dir-nonrecur.
1514 2005-11-01 Paul Eggert <eggert@cs.ucla.edu>
1516 * NEWS: "tail -c 2 FILE" and "touch 0101000000" now operate as
1517 POSIX 1002.1-2001 requires.
1518 * src/tail.c (parse_obsolete_option): Implement this.
1519 Problem reported by Vincent Lefevre.
1520 * src/touch.c (main): Pass PDS_PRE_2000 to posixtime.
1521 * tests/tail/Test.pm (c-2, c-2-minus, c2, c2-minus): New tests.
1522 (test_vector): Add special cases for _POSIX2_VERSION, and
1523 regularize the old ones a bit.
1524 * tests/touch/obsolescent: Add y2000 test.
1526 2005-10-31 Paul Eggert <eggert@cs.ucla.edu>
1528 * src/dd.c (skip): Fix off-by-one error reported by
1529 Theodoros V. Kalamatianos.
1531 2005-10-30 Paul Eggert <eggert@cs.ucla.edu>
1533 * tests/mkdir/p-3: Require that the test be run as non-root.
1534 Problem and trivial fix reported by Theodoros V. Kalamatianos.
1536 2005-10-28 Paul Eggert <eggert@cs.ucla.edu>
1538 * src/ln.c (FILE_BASENAME_CONCAT): Omit unnecessary slashes in the
1539 boundary between DEST and SOURCE in the result.
1541 2005-10-26 Dmitry V. Levin <ldv@altlinux.org>
1543 * src/md5sum.c (main) [!O_BINARY]: Changed default read mode
1544 back to text, to sync with documentation and for backwards
1547 2005-10-25 Jim Meyering <jim@meyering.net>
1549 * tests/dircolors/simple (other-wr): Add an explicit test for
1550 the dircolors bug (NULL-dereference) fixed yesterday.
1552 2005-10-24 Jim Meyering <jim@meyering.net>
1554 * src/tac.c (tac_file): When determining whether a file is seekable,
1555 also test whether it is a tty. Using only the lseek-based test would
1556 give a false positive on Solaris. Reported by Peter Fales.
1558 2005-10-24 Dmitry V. Levin <ldv@altlinux.org>
1560 * tests/install/d-slashdot: New test, for "install -d" failure.
1561 * tests/install/Makefile.am (TESTS): Add d-slashdot.
1562 * tests/mkdir/p-slashdot: New test, for "mkdir -p" failure.
1563 * tests/mkdir/Makefile.am (TESTS): Add p-slashdot.
1565 2005-10-24 Jim Meyering <jim@meyering.net>
1567 * src/dircolors.c (ls_codes): Add missing comma.
1568 Anonymous report and patch from
1569 http://savannah.gnu.org/bugs/?func=detailitem&item_id=14849
1571 * src/dircolors.c: Add compile-time assertion that the slack_codes
1572 and ls_codes arrays have the same number of elements. This would
1573 have prevented the above-fixed bug.
1575 * src/expand.c (parse_tab_stops): Add a comment to make this function
1576 identical to the one in unexpand.c.
1577 * src/unexpand.c (parse_tab_stops): Adjust syntax to make this function
1578 identical to the one in expand.c.
1580 * src/expand.c (next_file): Don't assume fopen cannot return stdin.
1582 2005-10-23 Jim Meyering <jim@meyering.net>
1584 * src/md5sum.c (digest_check, main): Use ptr_align rather than
1585 a dangerous pointer-value-to-`unsigned' cast.
1586 * NEWS: mention the new sha* programs.
1587 * AUTHORS: Add new sha* programs.
1589 2005-08-28 David Madore <david.madore@ens.fr>
1591 Add new programs: sha224sum, sha256sum, sha384sum, sha512sum.
1592 * README: Add their names to the list.
1593 * src/md5sum.c: Provide framework for computing sha-2 hashes.
1594 * src/Makefile.am (sha224sum, sha256sum, sha384sum, sha512sum):
1595 Rules for compiling sha-2 utilities
1596 (noinst_HEADERS): Remove checksum.h.
1597 * man/sha512sum.x, man/sha384sum.x, man/sha256sum.x, man/sha224sum.x:
1599 * man/Makefile.am (dist_man_MANS): Add the corresponding .1 names.
1600 (sha224sum.1, sha256sum.1, sha384sum.1, sha512sum.1): New dependencies.
1601 * tests/misc/sha224sum, tests/misc/sha256sum: New files.
1602 * tests/misc/sha384sum, tests/misc/sha512sum: New files.
1603 * tests/misc/Makefile.am (TESTS): Add new sha224sum, sha256sum,
1604 sha384sum, sha512sum test scripts here rather that each in its
1607 2005-08-28 David Madore <david.madore@ens.fr>
1609 * tests/sha1sum/basic-1 (million-a): Add the "million a's" test (one
1610 of the FIPS test vectors).
1612 2005-10-23 Jim Meyering <jim@meyering.net>
1614 * configure.ac: Use 6.0-cvs as the version string.
1615 * NEWS: Adjust accordingly.