1 2003-10-02 Havoc Pennington <hp@redhat.com>
3 * doc/dbus-tutorial.xml: write some stuff
5 2003-09-29 Havoc Pennington <hp@pobox.com>
7 * configure.in: split checks for Doxygen from XML docs, check for
10 * doc/Makefile.am: XML-ify all the docs, and add a blank
13 2003-09-29 Havoc Pennington <hp@pobox.com>
15 * Merge dbus-object-names branch. To see the entire patch
16 do cvs diff -r DBUS_OBJECT_NAMES_BRANCHPOINT -r dbus-object-names,
18 To revert, I tagged DBUS_BEFORE_OBJECT_NAMES_MERGE.
20 2003-09-28 Havoc Pennington <hp@pobox.com>
22 * HACKING: update to reflect new server
24 2003-09-26 Seth Nickell <seth@gnome.org>
27 * python/examples/example-signals.py:
29 Start implementing some notions of signals. The API
30 is really terrible, but they sort of work (with the
31 exception of being able to filter by service, and to
32 transmit signals *as* a particular service). Need to
33 figure out how to make messages come from the service
36 * python/dbus_bindings.pyx.in:
38 Removed duplicate message_handler callbacks.
40 2003-09-25 Havoc Pennington <hp@redhat.com>
42 * bus/session.conf.in: fix my mess
44 2003-09-25 Havoc Pennington <hp@pobox.com>
46 * bus/session.conf.in: fix security policy, reported by Seth Nickell
48 2003-09-25 Seth Nickell <seth@gnome.org>
50 * python/examples/example-service.py:
52 Johan notices complete wrong code in example-service, but
53 completely wrong in a way that works exactly the same (!).
54 Johan is confused, how could this possibly work? Example
55 code fails to serve purpose of making things clear.
58 2003-09-25 Mark McLoughlin <mark@skynet.ie>
60 * doc/dbus-specification.sgml: don't require header fields
61 to be 4-byte aligned and specify that fields should be
62 distinguished from padding by the fact that zero is not
65 * doc/TODO: remove re-alignment item and add item to doc
68 * dbus/dbus-message.c:
69 (HeaderField): rename the original member to value_offset
70 and introduce a name_offset member to keep track of where
71 the field actually begins.
72 (adjust_field_offsets): remove.
73 (append_int_field), (append_uint_field),
74 (append_string_field): don't align the start of the header
75 field to a 4-byte boundary.
76 (get_next_field): impl finding the next marhsalled field
78 (re_align_field_recurse): impl re-aligning a number of
79 already marshalled fields.
80 (delete_field): impl deleting a field of any type and
81 re-aligning any following fields.
82 (delete_int_or_uint_field), (delete_string_field): remove.
83 (set_int_field), (set_uint_field): no need to re-check
84 that we have the correct type for the field.
85 (set_string_field): ditto and impl re-aligning any
87 (decode_header_data): update to take into account that
88 the fields aren't 4-byte aligned any more and the new
89 way to distinguish padding from header fields. Also,
90 don't exit when there is too much header padding.
91 (process_test_subdir): print the directory.
92 (_dbus_message_test): add test to make sure a following
93 field is re-aligned correctly after field deletion.
95 * dbus/dbus-string.[ch]:
96 (_dbus_string_insert_bytes): rename from insert_byte and
97 allow the insert of multiple bytes.
98 (_dbus_string_test): test inserting multiple bytes.
100 * dbus/dbus-marshal.c: (_dbus_marshal_set_string): add
101 warning note to docs about having to re-align any
102 marshalled values following the string.
104 * dbus/dbus-message-builder.c:
105 (append_string_field), (_dbus_message_data_load):
106 don't align the header field.
108 * dbus/dbus-auth.c: (process_test_subdir): print the
111 * test/break-loader.c: (randomly_add_one_byte): upd. for
114 * test/data/invalid-messages/bad-header-field-alignment.message:
117 * test/data/valid-messages/unknown-header-field.message: shove
118 a dict in the unknown field.
120 2003-09-25 Seth Nickell <seth@gnome.org>
123 * python/dbus_bindings.pyx.in:
125 Handle return values.
127 * python/examples/example-client.py:
128 * python/examples/example-service.py:
130 Pass back return values from the service to the client.
132 2003-09-24 Seth Nickell <seth@gnome.org>
136 Connect Object methods (when you are sharing an object) up... pass
137 in a list of methods to be shared. Sharing all the methods just
138 worked out too weird. You can now create nice Services over the
141 * python/dbus_bindings.pyx.in:
143 Keep references to user_data tuples passed into C functions so
144 Python doesn't garbage collect on us.
146 Implement MethodReturn and Error subclasses of Message for creating
147 DBusMessage's of those types.
149 * python/examples/example-client.py:
150 * python/examples/example-service.py:
152 Simple example code showing both how create DBus services and objects,
155 2003-09-23 Havoc Pennington <hp@pobox.com>
157 * glib/dbus-gproxy.c (dbus_gproxy_manager_filter): implement
159 2003-09-23 Havoc Pennington <hp@redhat.com>
161 * glib/dbus-gproxy.c (dbus_gproxy_connect_signal): implement
162 (dbus_gproxy_disconnect_signal): implement
163 (dbus_gproxy_manager_remove_signal_match): implement
164 (dbus_gproxy_manager_add_signal_match): implement
165 (dbus_gproxy_oneway_call): implement
167 2003-09-23 Havoc Pennington <hp@pobox.com>
169 * glib/dbus-gproxy.c (struct DBusGProxy): convert to a GObject
170 subclass. This means dropping the transparent thread safety of the
171 proxy; you now need a separate proxy per-thread, or your own
172 locking on the proxy. Probably right anyway.
173 (dbus_gproxy_ref, dbus_gproxy_unref): nuke, just use g_object_ref
175 2003-09-22 Havoc Pennington <hp@redhat.com>
177 * glib/dbus-gproxy.c (dbus_gproxy_manager_get): implement
179 2003-09-21 Seth Nickell <seth@gnome.org>
181 First checkin of the Python bindings.
184 * python/Makefile.am:
185 * python/dbus_bindings.pyx.in:
186 * python/dbus_h_wrapper.h:
188 Pieces for Pyrex to operate on, building a dbus_bindings.so
189 python module for low-level access to the DBus APIs.
193 High-level Python module for accessing DBus objects.
198 Build stuff for the python bindings.
202 Extra macro needed for finding the Python C header files.
204 2003-09-21 Havoc Pennington <hp@pobox.com>
206 * glib/dbus-gproxy.c (dbus_gproxy_manager_new): start
207 implementing the proxy manager, didn't get very far.
209 * dbus/dbus-bus.c (dbus_bus_add_match): new
210 (dbus_bus_remove_match): new
212 * glib/dbus-gproxy.c (dbus_gproxy_new_for_service): add a
213 path_name argument; adjust the other not-yet-implemented
214 gproxy constructors to be what I think they should be.
216 2003-09-21 Havoc Pennington <hp@pobox.com>
218 * dbus/dbus-bus.c (dbus_bus_get): set exit_on_disconnect to TRUE
219 by default for message bus connections.
221 * dbus/dbus-connection.c (dbus_connection_dispatch): exit if
222 exit_on_disconnect flag is set and we process the disconnected
224 (dbus_connection_set_exit_on_disconnect): new function
226 2003-09-21 Havoc Pennington <hp@pobox.com>
228 Get matching rules mostly working in the bus; only actually
229 parsing the rule text remains. However, the client side of
230 "signal connections" hasn't been started, this patch is only the
233 * dbus/dispatch.c: fix for the matching rules changes
235 * bus/driver.c (bus_driver_handle_remove_match)
236 (bus_driver_handle_add_match): send an ack reply from these
239 * glib/dbus-gproxy.c (dbus_gproxy_begin_call): fix order of
240 arguments, reported by Seth Nickell
242 * bus/config-parser.c (append_rule_from_element): support
243 eavesdrop=true|false attribute on policies so match rules
244 can be prevented from snooping on the system bus.
246 * bus/dbus-daemon-1.1.in: consistently use terminology "sender"
247 and "destination" in attribute names; fix some docs bugs;
248 add eavesdrop=true|false attribute
250 * bus/driver.c (bus_driver_handle_add_match)
251 (bus_driver_handle_remove_match): handle AddMatch, RemoveMatch
254 * dbus/dbus-protocol.h (DBUS_SERVICE_ORG_FREEDESKTOP_BROADCAST): get
255 rid of broadcast service concept, signals are just always broadcast
257 * bus/signals.c, bus/dispatch.c, bus/connection.c, bus/bus.c:
258 mostly implement matching rules stuff (currently only exposed as signal
261 2003-09-21 Mark McLoughlin <mark@skynet.ie>
263 * doc/dbus-specification.sgml: Change the header field name
264 to be an enum and update the rest of the spec to reference
265 the fields using the conventinal name.
267 * dbus/dbus-protocol.h: update to reflect the spec.
269 * doc/TODO: add item to remove the 4 byte alignment requirement.
271 * dbus/dbus-message.c: Remove the code to generalise the
272 header/body length and serial number header fields as named
273 header fields so we can reference field names using the
275 (append_int_field), (append_uint_field), (append_string_field):
276 Append the field name as a byte rather than four chars.
277 (delete_int_or_uint_field), (delete_string_field): reflect the
278 fact that the field name and typecode now occupy 4 bytes instead
280 (decode_string_field), (decode_header_data): update to reflect
281 protocol changes and move the field specific encoding from
282 decode_string_field() back into decode_header_data().
284 * dbus/dbus-internals.[ch]: (_dbus_header_field_to_string):
285 Add utility to aid debugging.
287 * dbus/dbus-message-builder.c:
288 (append_string_field), (_dbus_message_data_load): Update to
289 reflect protocol changes; Change the FIELD_NAME directive
290 to HEADER_FIELD and allow it to take the field's conventional
291 name rather than the actual value.
293 * test/data/*/*.message: Update to use HEADER_FIELD instead
294 of FIELD_NAME; Always align the header on an 8 byte boundary
295 *before* updating the header length.
297 2003-09-15 Havoc Pennington <hp@pobox.com>
299 * dbus/dbus-pending-call.c: add the get/set object data
300 boilerplate as for DBusConnection, etc. Use generic object data
301 for the notify callback.
303 * glib/dbus-gparser.c (parse_node): parse child nodes
305 * tools/dbus-viewer.c: more hacking on the dbus-viewer
307 * glib/dbus-gutils.c (_dbus_gutils_split_path): add a file to
308 contain functions shared between the convenience lib and the
311 * glib/Makefile.am (libdbus_glib_1_la_LDFLAGS): add
312 -export-symbols-regex to the GLib library
314 * dbus/dbus-object-tree.c (_dbus_object_tree_dispatch_and_unlock):
315 fix the locking in here, and add a default handler for
316 Introspect() that just returns sub-nodes.
318 2003-09-14 Havoc Pennington <hp@pobox.com>
320 * glib/dbus-gthread.c (dbus_g_thread_init): rename to make g_foo
321 rather than gfoo consistent
323 * glib/dbus-gproxy.h: delete for now, move contents to
324 dbus-glib.h, because the include files don't work right since we
325 aren't in the dbus/ subdir.
327 * glib/dbus-gproxy.c (dbus_gproxy_send): finish implementing
328 (dbus_gproxy_end_call): finish
329 (dbus_gproxy_begin_call): finish
331 * glib/dbus-gmain.c (dbus_set_g_error): new
333 * glib/dbus-gobject.c (handle_introspect): include information
334 about child nodes in the introspection
336 * dbus/dbus-connection.c (dbus_connection_list_registered): new
337 function to help in implementation of introspection
339 * dbus/dbus-object-tree.c
340 (_dbus_object_tree_list_registered_and_unlock): new function
342 2003-09-12 Havoc Pennington <hp@pobox.com>
344 * glib/dbus-gidl.h: add common base class for all the foo_info
347 * tools/dbus-viewer.c: add GTK-based introspection UI thingy
350 * test/Makefile.am: try test srcdir -ef . in addition to test
351 srcdir = ., one of them should work (yeah lame)
353 * glib/Makefile.am: build the "idl" parser stuff as a convenience
356 * glib/dbus-gparser.h: make description_load routines return
357 NodeInfo* not Parser*
359 * Makefile.am (SUBDIRS): build test dir after all library dirs
361 * configure.in: add GTK+ detection
363 2003-09-07 Havoc Pennington <hp@pobox.com>
365 * Make Doxygen contented.
367 2003-09-07 Havoc Pennington <hp@pobox.com>
369 * doc/dbus-specification.sgml: more updates
371 2003-09-06 Havoc Pennington <hp@pobox.com>
373 * doc/dbus-specification.sgml: partial updates
375 * bus/dbus-daemon-1.1.in: fix the config file docs for the
376 zillionth time; hopefully I edited the right file this time.
378 * bus/config-parser.c (append_rule_from_element): support
379 send_type, send_path, receive_type, receive_path
381 * bus/policy.c: add message type and path to the list of things
382 that can be "firewalled"
384 2003-09-06 Havoc Pennington <hp@pobox.com>
386 * dbus/dbus-connection.c (dbus_connection_register_fallback): add this
387 (dbus_connection_register_object_path): make this not handle
388 messages to paths below the given path
390 2003-09-03 Havoc Pennington <hp@pobox.com>
392 * test/glib/Makefile.am: add this with random glib-linked test
395 * glib/Makefile.am: remove the random test programs from here,
396 leave only the unit tests
398 * glib/dbus-gobject.c (_dbus_gobject_test): add test for
399 uscore/javacaps conversion, and fix
400 (get_object_property, set_object_property): change to .NET
401 convention for mapping props to methods, set_FooBar/get_FooBar,
402 since one language has such a convention we may as well copy it.
403 Plus real methods in either getFooBar or get_foo_bar style won't
404 collide with this convention.
406 2003-09-01 Havoc Pennington <hp@pobox.com>
408 * glib/dbus-gparser.c: implement
410 * glib/dbus-gobject.c: start implementing skeletons support
412 * configure.in: when disabling checks/assert, also define
413 G_DISABLE_ASSERT and G_DISABLE_CHECKS
415 2003-09-01 Havoc Pennington <hp@pobox.com>
417 * glib/Makefile.am: rearrange a bunch of files and get "make
418 check" framework set up
420 2003-08-31 Havoc Pennington <hp@pobox.com>
422 * fix build with --disable-tests
424 2003-08-30 Havoc Pennington <hp@pobox.com>
426 * dbus/dbus-connection.c: purge DBusMessageHandler
428 * dbus/dbus-message-handler.c: remove DBusMessageHandler, just
429 use callbacks everywhere
431 2003-08-30 Havoc Pennington <hp@pobox.com>
433 * test/data/valid-config-files/system.d/test.conf: change to
434 root for the user so warnings don't get printed
436 * dbus/dbus-message.c: add dbus_message_get_path,
437 dbus_message_set_path
439 * dbus/dbus-object-tree.c (do_test_dispatch): add test of
440 dispatching to a path
442 * dbus/dbus-string.c (_dbus_string_validate_path): add
444 * dbus/dbus-marshal.c (_dbus_demarshal_object_path): implement
445 (_dbus_marshal_object_path): implement
447 * dbus/dbus-protocol.h (DBUS_HEADER_FIELD_PATH): new header field
448 to contain the path to the target object
449 (DBUS_HEADER_FIELD_SENDER_SERVICE): rename
450 DBUS_HEADER_FIELD_SENDER to explicitly say it's the sender service
452 2003-08-30 Havoc Pennington <hp@pobox.com>
454 * dbus/dbus-object-tree.c: write tests and fix the discovered bugs
456 2003-08-29 Havoc Pennington <hp@pobox.com>
458 * dbus/dbus-object-tree.c: modify to allow overlapping paths to be
460 (struct DBusObjectSubtree): shrink this
461 a lot, since we may have a lot of them
462 (_dbus_object_tree_free_all_unlocked): implement
463 (_dbus_object_tree_dispatch_and_unlock): implement
465 2003-08-29 Havoc Pennington <hp@pobox.com>
467 * dbus/dbus-internals.h: fix _DBUS_N_GLOBAL_LOCKS
469 2003-08-28 Havoc Pennington <hp@pobox.com>
473 * dbus/dbus-connection.c: port to no ObjectID, create a
474 DBusObjectTree, rename ObjectTree to ObjectPath in public API
476 * dbus/dbus-connection.h (struct DBusObjectTreeVTable): delete
477 everything except UnregisterFunction and MessageFunction
479 * dbus/dbus-marshal.c: port away from DBusObjectID,
480 add DBUS_TYPE_OBJECT_PATH
482 * dbus/dbus-object-registry.[hc], dbus/dbus-object.[hc],
483 dbus/dbus-objectid.[hc]: remove these, we are moving to
484 path-based object IDs
486 2003-08-25 Havoc Pennington <hp@pobox.com>
488 Just noticed that dbus_message_test is hosed, I wonder when I
489 broke that. I thought make check was passing earlier...
491 * dbus/dbus-object-tree.c: add new "object tree" to match DCOP
492 container tree, will replace most of dbus-object-registry
494 * dbus/dbus-string.c (_dbus_string_append_printf_valist): fix C99
497 2003-08-19 Havoc Pennington <hp@pobox.com>
499 * dbus/dbus-message.c (decode_string_field): support FIELD_SENDER
500 (dbus_message_is_error): fix this function
502 * bus/dbus-daemon-1.1: clarify logic on when <deny>/<allow> rules
505 * bus/policy.c (bus_client_policy_check_can_receive): fix code to
506 reflect clarified man page
507 (bus_client_policy_check_can_send): ditto
509 * bus/session.conf.in: fixup
511 * bus/system.conf.in: fixup
513 2003-08-18 Havoc Pennington <hp@redhat.com>
515 * dbus/dbus-hash.c (_dbus_hash_table_insert_two_strings): fix
517 * dbus/dbus-message.c (_dbus_message_loader_queue_messages): fix
518 dumb bug created earlier (wrong order of args to
519 decode_header_data())
521 * tools/dbus-send.c: port
523 * tools/dbus-print-message.c (print_message): port
525 * test/data/*messages: port all messages over
527 * dbus/dbus-message-builder.c: support including
530 * bus/driver.c: port over
532 * bus/dispatch.c: port over to new stuff
534 * dbus/dbus-connection.c (_dbus_connection_new_for_transport):
535 rename disconnect signal to "Disconnected"
537 2003-08-17 Havoc Pennington <hp@pobox.com>
539 This doesn't compile yet, but syncing up so I can hack on it from
540 work. What are branches for if not broken code? ;-)
542 * dbus/dbus-protocol.h: remove DBUS_HEADER_FIELD_NAME, add
543 DBUS_HEADER_FIELD_INTERFACE, DBUS_HEADER_FIELD_MEMBER,
544 DBUS_HEADER_FIELD_ERROR_NAME
546 * dbus/dbus-hash.c: Introduce DBUS_HASH_TWO_STRINGS as hack to use
547 for the interface+member pairs
548 (string_hash): change to use g_str_hash algorithm
549 (find_direct_function, find_string_function): refactor these to
552 * dbus/dbus-message.c: port all of this over to support
553 interface/member fields instead of name field
555 * dbus/dbus-object-registry.c: port over
557 * dbus/dbus-string.c (_dbus_string_validate_interface): rename
558 from _dbus_string_validate_name
560 * bus/dbus-daemon-1.1: change file format for the
561 <deny>/<allow> stuff to match new message naming scheme
563 * bus/policy.c: port over
565 * bus/config-parser.c: parse new format
567 2003-08-16 Havoc Pennington <hp@pobox.com>
569 * dbus/dbus-object-registry.c (add_and_remove_objects): remove
572 * glib/dbus-gproxy.c: some hacking
574 2003-08-15 Havoc Pennington <hp@redhat.com>
576 * dbus/dbus-pending-call.c (dbus_pending_call_block): implement
578 * dbus/dbus-connection.c
579 (dbus_connection_send_with_reply_and_block): factor out internals;
580 change to convert any error replies to DBusError instead of
581 returning them as a message
583 2003-08-15 Havoc Pennington <hp@pobox.com>
585 * dbus/dbus-connection.c,
586 dbus/dbus-pending-call.c: Finish the pending call stuff
588 2003-08-14 Havoc Pennington <hp@redhat.com>
590 * dbus/dbus-pending-call.c: start on new object that will replace
591 DBusMessageHandler and ReplyHandlerData for tracking outstanding
594 * dbus/dbus-gproxy.c: start on proxy object used to communicate
595 with remote interfaces
597 * dbus/dbus-gidl.c: do the boring boilerplate in here
599 2003-08-12 Havoc Pennington <hp@pobox.com>
601 * bus/dispatch.c (bus_dispatch): make this return proper
602 DBusHandlerResult to avoid DBUS_ERROR_UNKNOWN_METHOD
604 * dbus/dbus-errors.c (dbus_set_error): use
605 _dbus_string_append_printf_valist
607 * dbus/dbus-string.c (_dbus_string_append_printf_valist)
608 (_dbus_string_append_printf): new
610 * dbus/dbus-errors.h (DBUS_ERROR_UNKNOWN_MESSAGE): change to
613 * dbus/dbus-connection.c (dbus_connection_dispatch): handle
614 DBUS_HANDLER_RESULT_NEED_MEMORY; send default error reply if a
615 message is unhandled.
617 2003-08-11 Havoc Pennington <hp@pobox.com>
619 * bus/test.c (client_disconnect_handler): change to return
620 HANDLED (would have been REMOVE_MESSAGE)
622 * dbus/dbus-object.h (enum DBusHandlerResult): rename to
623 HANDLED/NOT_YET_HANDLED instead of
624 REMOVE_MESSAGE/ALLOW_MORE_HANDLERS to make it clearer how it
627 2003-08-10 Havoc Pennington <hp@pobox.com>
629 * tools/dbus-send.c (main): add --type argument, for now
630 supporting only method_call and signal types.
632 * tools/dbus-print-message.c: print message type
634 * dbus/dbus-connection.c (_dbus_connection_new_for_transport):
635 init connection->objects
637 * doc/dbus-specification.sgml: fix sgml
639 * bus/*.c: port over to object-instance API changes
641 * test/test-service.c: ditto
643 * dbus/dbus-message.c (dbus_message_create_header): allow #NULL
644 name, we will have to fix up the rest of the code to also handle
646 (dbus_message_new): generic message-creation call
647 (set_string_field): allow appending name field
649 2003-08-06 Havoc Pennington <hp@pobox.com>
651 * dbus/dbus-object-registry.c: implement signal connection
654 * dbus/dbus-connection.c (_dbus_connection_unref_unlocked): new
656 * dbus/dbus-internals.c (_dbus_memdup): new function
658 2003-08-02 Havoc Pennington <hp@pobox.com>
660 * dbus/dbus-message.c (dbus_message_get_no_reply)
661 (dbus_message_set_no_reply): add these and remove
662 set_is_error/get_is_error
664 * dbus/dbus-protocol.h, doc/dbus-specification.sgml:
665 remove the ERROR flag, since there's now an ERROR type
667 2003-08-01 Havoc Pennington <hp@pobox.com>
669 * dbus/dbus-object-registry.c (_dbus_object_registry_handle_and_unlock):
672 * dbus/dbus-message.c (dbus_message_get_type): new function
674 * doc/dbus-specification.sgml: add "type" byte to messages
676 2003-08-01 Havoc Pennington <hp@pobox.com>
678 * dbus/dbus-protocol.h (DBUS_MESSAGE_TYPE_*): introduce
679 a message type enum to distinguish kinds of message
680 (DBUS_HEADER_FLAG_NO_REPLY_EXPECTED): flag for a message
681 that need not be replied to
683 2003-08-01 Havoc Pennington <hp@pobox.com>
685 * dbus/dbus-marshal.c: adapt to DBusObjectID changes
686 (unpack_8_octets): fix no-64-bit-int bug
688 * dbus/dbus-object-registry.c (validate_id): validate the
689 connection ID bits, not just the instance ID.
691 * dbus/dbus-connection.c (_dbus_connection_init_id): initialize
692 the connection-global 33 bits of the object ID
694 * dbus/dbus-object-registry.c (info_from_entry): fill in
695 object ID in the new way
697 * dbus/dbus-objectid.h: rather than high/low bits, specifically
698 define server/client/instance bits.
700 2003-07-30 Havoc Pennington <hp@pobox.com>
702 * dbus/dbus-connection.c (dbus_connection_register_object): fix
705 2003-07-13 Havoc Pennington <hp@pobox.com>
707 * dbus/dbus-object.h (struct DBusObjectVTable): add padding
708 fields to DBusObjectVTable and DBusObjectInfo
710 2003-07-12 Havoc Pennington <hp@pobox.com>
712 * dbus/dbus-object-registry.c: implement unit test,
713 fix bugs discovered in process
715 * dbus/dbus-connection.c: remove handler_table and
716 register_handler(), add DBusObjectRegistry usage
718 * dbus/dbus-objectid.c (dbus_object_id_is_null)
719 (dbus_object_id_set_null): new functions
721 2003-07-08 Havoc Pennington <hp@pobox.com>
723 * dbus/dbus-object.c: implement some of this
725 * dbus/dbus-object-registry.c
726 (_dbus_object_registry_add_and_unlock): fill in the object_id out
728 (_dbus_object_registry_new): handle OOM
730 2003-07-08 Havoc Pennington <hp@pobox.com>
732 * dbus/dbus-object.h: sketch out an API for registering objects
733 with a connection, that allows us to use as little as 24 bytes
734 per object and lets application code represent an object in
737 * dbus/dbus-object-registry.c: implement the hard bits of the
738 DBusConnection aspect of object API. Not yet wired up.
740 2003-07-06 Havoc Pennington <hp@pobox.com>
742 * dbus/dbus-marshal.c (_dbus_marshal_set_object_id): new function
743 (_dbus_marshal_object_id): new
744 (_dbus_demarshal_object_id): new
745 (_dbus_marshal_get_arg_end_pos): support object ID type, and
746 consolidate identical switch cases. Don't conditionalize handling
747 of DBUS_TYPE_UINT64, need to handle the type always.
748 (_dbus_marshal_validate_arg): consolidate identical cases, and
749 handle DBUS_TYPE_OBJECT_ID
751 * dbus/dbus-objectid.c: new file with DBusObjectID data type.
753 * dbus/dbus-protocol.h: add DBUS_TYPE_OBJECT_ID
755 2003-09-28 Havoc Pennington <hp@pobox.com>
759 2003-09-28 Havoc Pennington <hp@pobox.com>
761 * doc/Makefile.am (dbus-specification.html): testing a funky hack
762 to work with Debian db2html
764 2003-09-28 Havoc Pennington <hp@pobox.com>
768 * doc/Makefile.am (dbus-test-plan.html): accept nonexistence of
769 stylesheet-images for benefit of Debian
771 Change back to using filesystem-linked sockets for the system
772 bus, so only root can create the default system bus address.
774 * bus/system.conf.in: change to use
775 DBUS_SYSTEM_BUS_DEFAULT_ADDRESS
777 * dbus/Makefile.am (INCLUDES): remove DBUS_SYSTEM_BUS_PATH define
780 * configure.in: define DBUS_SYSTEM_BUS_DEFAULT_ADDRESS
781 here, and AC_DEFINE DBUS_SYSTEM_PATH
783 2003-08-09 Anders Carlsson <andersca@codefactory.se>
789 2003-08-09 Anders Carlsson <andersca@codefactory.se>
791 * doc/dbus-specification.sgml:
792 Add activation reply values.
794 2003-08-05 Havoc Pennington <hp@redhat.com>
798 2003-08-05 Anders Carlsson <andersca@codefactory.se>
800 * glib/dbus-gmain.c: (watch_fd_new), (watch_fd_ref),
801 (watch_fd_unref), (dbus_gsource_check), (dbus_gsource_dispatch),
802 (add_watch), (remove_watch), (create_source):
803 Refcount fds, fixes some reentrancy issues.
805 2003-07-30 Havoc Pennington <hp@redhat.com>
807 * dbus/dbus-bus.c (init_connections_unlocked): fix default system
808 bus address to be abstract if we have abstract sockets
812 2003-07-28 Havoc Pennington <hp@redhat.com>
814 * bus/messagebus.in: fix to avoid processname/servicename
815 confusion, from Michael Kearey
816 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=100965
818 2003-07-23 Havoc Pennington <hp@pobox.com>
820 * dbus/dbus-message.c (dbus_message_iter_get_named):
821 fix from Andy Hanton to remove broken "+1"
823 2003-07-16 Havoc Pennington <hp@pobox.com>
825 * tools/dbus-launch.c (babysit): close stdout/stderr in the
826 babysitter process, as suggested by Thomas Leonard, so
827 an "eval `dbus-launch --exit-with-session`" will actually
830 2003-07-16 Havoc Pennington <hp@pobox.com>
832 * configure.in: print out EXPANDED_* variables in the summary at
833 the end; clean up the code that computes EXPANDED_ variables and
834 get the ones using exec_prefix right. Should make things work
835 when you build without --prefix
837 2003-06-29 Havoc Pennington <hp@pobox.com>
839 * mono/Test.cs (class Test): fire up a main loop and run it
841 * mono/DBus.cs (DBus): don't g_thread_init since it can only be
842 done once, the app has to do it
844 2003-06-26 Havoc Pennington <hp@pobox.com>
846 * mono/Connection.cs: set up connection with the glib main loop
848 2003-07-01 Havoc Pennington <hp@redhat.com>
850 * doc/dbus-specification.sgml: clarify the format of a type code,
851 change suggested by Jim Blandy
853 2003-06-29 Miloslav Trmac <mitr@volny.cz>
856 * tools/Makefile.am: Don't assume srcdir == builddir.
858 * dbus/dbus-memory.c (dbus_realloc): Don't check guards after shrinking
860 (_dbus_memory_test): New function.
861 * dbus/dbus-test.h: Add _dbus_memory_test ().
862 * dbus/dbus-test.c (dbus_internal_do_not_use_run_tests): Call it.
864 * dbus/dbus-message.c (decode_header_data): Use %.4s instead
866 (dbus_message_new): Remove obsolete @todo.
868 * dbus/dbus-marshal.c (_dbus_marshal_set_int64)
869 (_dbus_marshal_set_uint64): Fix comment.
871 * dbus/dbus-message.c (append_int_field, append_uint_field): Don't
872 hardcode FIELD_REPLY_SERIAL.
874 * dbus/dbus-mainloop.c (_dbus_loop_remove_watch)
875 (_dbus_loop_remove_timeout): Cast function pointers to (void *) for %p
877 * configure.in: Add -D_POSIX_C_SOURCE=199309L -DBSD_SOURCE to CFLAGS
878 and disable DBUS_USE_ATOMIC_INT_486 when --enable-ansi is used
880 2003-06-24 Havoc Pennington <hp@pobox.com>
882 * mono/*.cs: Use IntPtr.Zero instead of ((IntPtr) 0)
884 2003-06-23 Anders Carlsson <andersca@codefactory.se>
890 * gcj/TestMessage.java: (TestMessage), (TestMessage.main):
891 * gcj/org/.cvsignore:
892 * gcj/org/Makefile.am:
893 * gcj/org/freedesktop/.cvsignore:
894 * gcj/org/freedesktop/Makefile.am:
895 * gcj/org/freedesktop/dbus/.cvsignore:
896 * gcj/org/freedesktop/dbus/Makefile.am:
897 * gcj/org/freedesktop/dbus/Message.java: (Message),
899 * gcj/org/freedesktop/dbus/natMessage.cc:
900 Fix the build system.
902 2003-06-22 Havoc Pennington <hp@pobox.com>
904 * mono/Connection.cs: add more bindings
906 * dbus/dbus-threads.c (dbus_threads_init): allow calling this
909 2003-06-22 Havoc Pennington <hp@pobox.com>
911 * mono/Connection.cs, mono/DBus.cs, mono/Error.cs:
912 Start wrapping more stuff.
914 2003-06-22 Havoc Pennington <hp@pobox.com>
916 * mono/Message.cs: implement Message.Wrap() that ensures we only
917 have a single C# wrapper per DBusMessage, assuming it works which
920 * dbus/dbus-message.c (dbus_message_allocate_data_slot): new
921 (dbus_message_free_data_slot): new
922 (dbus_message_set_data): new
923 (dbus_message_get_data): new
925 2003-06-22 Havoc Pennington <hp@pobox.com>
927 * dbus/dbus-dataslot.c (_dbus_data_slot_allocator_unref)
928 (_dbus_data_slot_allocator_alloc): rework these to keep a
929 reference count on each slot and automatically manage a global
930 slot ID variable passed in by address
932 * bus/bus.c: convert to new dataslot API
934 * dbus/dbus-bus.c: convert to new dataslot API
936 * dbus/dbus-connection.c: convert to new dataslot API
938 * dbus/dbus-server.c: convert to new dataslot API
940 * glib/dbus-gmain.c: ditto
944 * bus/connection.c: ditto
946 2003-06-22 Anders Carlsson <andersca@codefactory.se>
948 * configure.in: Add AM_PROG_GCJ and move AM_PROG_LIBTOOL
949 after the gcj checks so that the correct configuration tags
950 will be added to libtool.
952 * dbus-glib-1.pc.in: No need to specify any includes since
953 dbus-1.pc.in has those.
955 2003-06-22 Havoc Pennington <hp@pobox.com>
957 * mono/*, gcj/*, configure.in, Makefile.am:
958 Check in makefiles and subdirs for mono and gcj bindings.
959 Neither binding actually exists, just trying to get through
960 all the build and other boring bits.
962 2003-06-21 Philip Blundell <philb@gnu.org>
964 * tools/dbus-monitor.1: Updated.
966 * tools/dbus-send.1: Likewise.
968 2003-06-20 Anders Carlsson <andersca@codefactory.se>
970 * dbus/dbus-transport-unix.c (unix_handle_watch): Check
971 for hangup and error after checking read so we won't discard
972 pending data if both hangup and read are set.
974 2003-06-19 Philip Blundell <philb@gnu.org>
976 * tools/dbus-print-message.c (print_message): Handle BOOLEAN.
978 * tools/dbus-send.c: Accept both --system and --session.
980 * tools/dbus-monitor.c: Same here.
982 2003-06-19 Anders Carlsson <andersca@codefactory.se>
984 * glib/dbus-glib.h: Fix so that dbus-glib.h can be used
985 from C++ (Patch by Miloslav Trmac).
987 2003-06-15 Joe Shaw <joe@assbarn.com>
989 * configure.in: Check for socklen_t.
991 * dbus/dbus-sysdeps.c: Define socklen_t if it's not defined.
993 * test/test-segfault.c: Add #include <sys/time.h>
995 * tools/Makefile.am: Add DBUS_X_CFLAGS to the INCLUDES since
996 dbus-launch needs it.
998 2003-06-09 Havoc Pennington <hp@redhat.com>
1000 * dbus/dbus-sysdeps.c (_dbus_listen_unix_socket): don't use
1001 SUN_LEN, it breaks abstract socket usage
1003 * dbus/dbus-internals.c (_dbus_verbose_real): only print PID at
1006 2003-06-04 Havoc Pennington <hp@pobox.com>
1008 * dbus/dbus-server.c (dbus_server_listen): allow abstract sockets
1009 using unix:abstract=/foo, and when listening in a tmpdir
1010 i.e. unix:tmpdir=/tmp, always use abstract sockets if we can.
1012 * dbus/dbus-transport.c (_dbus_transport_open): support
1015 * dbus/dbus-server-unix.c (_dbus_server_new_for_domain_socket):
1016 support abstract sockets
1018 * dbus/dbus-transport-unix.c
1019 (_dbus_transport_new_for_domain_socket): support abstract sockets
1021 * dbus/dbus-sysdeps.c (_dbus_connect_unix_socket): add "abstract"
1022 toggle as an argument, implement abstract namespace support
1023 (_dbus_listen_unix_socket): ditto
1025 * configure.in: add --enable-abstract-sockets and implement
1026 a configure check for autodetection of the right value.
1028 2003-06-01 Havoc Pennington <hp@pobox.com>
1030 * tools/dbus-cleanup-sockets.c: add utility to clean up sockets
1031 in /tmp (though on Linux this will end up being useless,
1032 when we add abstract namespace support)
1034 * configure.in: define DBUS_SESSION_SOCKET_DIR in addition to
1037 2003-05-28 Colin Walters <walters@verbum.org>
1039 * tools/dbus-monitor.c (main): Fix silly typo (s/--session/--system/).
1041 2003-05-18 Anders Carlsson <andersca@codefactory.se>
1043 * dbus/dbus-message.c (dbus_message_new): Remove @todo.
1045 2003-05-17 Colin Walters <walters@gnu.org>
1047 * tools/dbus-send.c: Don't exit with an error code if --help was
1048 passed. Default to using the session bus instead of the system
1051 * tools/dbus-launch.c: Ditto.
1053 * tools/dbus-monitor.c: Ditto.
1055 * tools/dbus-send.1: Update with new arguments.
1057 * tools/dbus-launch.c: Emit code to export variables. New
1058 arguments -s and -c to specify shell syntax, and a bit of code to
1059 autodetect syntax. Also, allow specifying a program to run.
1061 * tools/dbus-launch.1: Update with new arguments.
1063 * tools/dbus-send.1: Ditto.
1065 * tools/dbus-monitor.1: Ditto.
1067 2003-05-17 Havoc Pennington <hp@pobox.com>
1069 * bus/config-parser.c (merge_included): merge in policies from
1070 child configuration file.
1072 * bus/policy.c (bus_policy_merge): function to merge two policies
1075 2003-05-16 Havoc Pennington <hp@redhat.com>
1077 * dbus/dbus-connection.c: disable verbose lock spew
1079 * tools/dbus-send.c: add --print-reply command line option
1081 * tools/dbus-print-message.h (print_message): new util function
1082 shared by dbus-send and dbus-monitor
1084 * tools/dbus-monitor.c (handler_func): exit on disconnect
1086 * dbus/dbus-transport-unix.c (do_reading): if the transport is
1087 disconnected, don't try to use the read_watch
1089 * dbus/dbus-watch.c (dbus_watch_get_enabled): assert watch != NULL
1090 so we can find this bug more easily
1092 2003-05-16 Havoc Pennington <hp@redhat.com>
1094 * bus/policy.c (free_rule_list_func): avoid a crash when passed
1095 NULL as DBusHashTable is annoyingly likely to do.
1097 2003-05-16 Colin Walters <walters@verbum.org>
1099 * tools/dbus-monitor.c: Add --session argument and usage()
1102 * tools/dbus-monitor.1: Update with new --session arg.
1104 * bus/Makefile.am (install-data-hook): Create
1105 $(libdir)/dbus-1.0/services so that the session bus is happy.
1107 2003-05-15 Havoc Pennington <hp@redhat.com>
1109 * dbus/dbus-sysdeps.c (_dbus_atomic_dec, _dbus_atomic_inc): work
1110 on non-x86. ifdef's are evil.
1112 2003-05-15 Havoc Pennington <hp@redhat.com>
1114 * configure.in: 0.11
1118 * bus/Makefile.am (initddir): apparently we are supposed to put
1119 init scripts in /etc/rc.d/init.d not /etc/init.d
1121 * bus/Makefile.am: remove the "you must --enable-tests to make
1122 check" as it broke distcheck
1124 * bus/Makefile.am (install-data-hook): create /etc/dbus-1/system.d
1126 2003-05-13 James Willcox <jwillcox@gnome.org>
1129 * bus/activation.c: (bus_activation_service_created),
1130 (bus_activation_activate_service):
1131 * bus/driver.c: (bus_driver_send_service_deleted),
1132 (bus_driver_send_service_created), (bus_driver_send_service_lost),
1133 (bus_driver_send_service_acquired),
1134 (bus_driver_send_welcome_message),
1135 (bus_driver_handle_list_services):
1136 * bus/session.conf.in:
1137 * dbus/dbus-bus.c: (dbus_bus_acquire_service),
1138 (dbus_bus_service_exists), (dbus_bus_activate_service):
1141 Add some convenience API which lets you activate a service, and did a
1142 bunch of s/0/DBUS_TYPE_INVALID/ in calls to dbus_message_append_args()
1143 and dbus_message_get_args()
1145 2003-05-11 Havoc Pennington <hp@pobox.com>
1147 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): fix to avoid
1148 calling _dbus_marshal_validate_arg() for every byte in a byte
1151 * dbus/dbus-message-handler.c: use atomic reference counting to
1152 reduce number of locks slightly; the global lock in here sucks
1154 * dbus/dbus-connection.c
1155 (_dbus_connection_update_dispatch_status_and_unlock): variant of
1156 update_dispatch_status that can be called with lock held; then use
1157 in a couple places to reduce locking/unlocking
1158 (dbus_connection_send): hold the lock over the whole function
1159 instead of acquiring it twice.
1161 * dbus/dbus-timeout.c (_dbus_timeout_new): handle OOM
1163 * bus/connection.c (bus_connections_setup_connection): fix access
1164 to already-freed memory.
1166 * dbus/dbus-connection.c: keep a little cache of linked list
1167 nodes, to avoid using the global linked list alloc lock in the
1168 normal send-message case. Instead we just use the connection lock
1169 that we already have to take.
1171 * dbus/dbus-list.c (_dbus_list_find_last): new function
1173 * dbus/dbus-sysdeps.c (_dbus_atomic_inc, _dbus_atomic_dec):
1174 change to use a struct for the atomic type; fix docs,
1175 they return value before increment, not after increment.
1177 * dbus/dbus-string.c (_dbus_string_append_4_aligned)
1178 (_dbus_string_append_8_aligned): new functions to try to
1179 microoptimize this operation.
1180 (reallocate_for_length): break this out of set_length(), to
1181 improve profile info, and also so we can consider inlining the
1184 * dbus/dbus-message.c (dbus_message_new_empty_header): init data
1185 strings with some preallocation, cuts down on our calls to realloc
1186 a fair bit. Though if we can get the "move entire string to empty
1187 string" optimization below to kick in here, it would be better.
1189 * dbus/dbus-string.c (_dbus_string_move): just call
1190 _dbus_string_move_len
1191 (_dbus_string_move_len): add a special case for moving
1192 an entire string into an empty string; we can just
1193 swap the string data instead of doing any reallocs.
1194 (_dbus_string_init_preallocated): new function
1196 2003-05-11 Havoc Pennington <hp@pobox.com>
1198 Write a "test-profile" that does echo client-server with threads;
1199 profile reveals lock contention, memcpy/realloc of buffers, and
1200 UTF-8 validation as hot spots. 20% of lock contention eliminated
1201 with dbus_atomic_inc/dec implementation on x86. Much remaining
1202 contention is global mempool locks for GList and DBusList.
1204 * dbus/dbus-sysdeps.c (_dbus_atomic_inc, _dbus_atomic_dec): add
1207 * dbus/dbus-connection.c (struct DBusConnection): use
1208 dbus_atomic_t for the reference count
1210 * dbus/dbus-message.c (struct DBusMessage): declare
1211 dbus_atomic_t values as volatile
1213 * configure.in: code to detect ability to use atomic integer
1214 operations in assembly, from GLib patch
1216 * dbus/dbus-internals.c (_dbus_verbose_real): call getpid every
1217 time, tired of it being wrong in threads and forked processes
1219 * glib/test-profile.c: a little program to bounce messages back
1220 and forth between threads and eat CPU
1222 * dbus/dbus-connection.c: add debug spew macros for debugging
1223 thread locks; include config.h at top; fix deadlock in
1224 dbus_connection_flush()
1226 2003-05-08 Havoc Pennington <hp@pobox.com>
1228 * dbus/dbus-spawn.c: s/_exit/exit/ because it was keeping gcov
1229 data from getting written, and there wasn't a good reason to
1232 * test/decode-gcov.c (mark_inside_dbus_build_tests): don't count
1233 dbus_verbose lines in test coverage
1234 (main): add list of functions sorted by # of untested blocks
1235 to the coverage report
1237 * dbus/dbus-mempool.c: put some test-only code in DBUS_BUILD_TESTS
1239 * dbus/dbus-marshal.c (_dbus_marshal_test): extend test coverage
1241 * dbus/dbus-message-handler.c (_dbus_message_handler_test):
1242 extend test coverage
1244 * test/data/auth/cancel.auth-script: test canceling an
1247 * dbus/Makefile.am: remove dbus-server-debug.[hc] for now, as they
1248 aren't used. in CVS history if we end up needing them.
1250 2003-05-04 Havoc Pennington <hp@pobox.com>
1252 * dbus/dbus-message-handler.c (_dbus_message_handler_test): add
1255 * dbus/dbus-marshal.c (_dbus_demarshal_string_array): fix this
1256 function, which assumed length was in # of strings, not bytes
1258 * dbus/dbus-message.c (_dbus_message_test): add tests for some
1261 * dbus/dbus-connection.c
1262 (_dbus_connection_queue_received_message): disable function for
1263 now, we are only using it in test mode
1265 * dbus/dbus-message.c (_dbus_message_loader_queue_messages):
1266 remove a mistaken FIXME
1268 2003-05-04 Havoc Pennington <hp@pobox.com>
1270 * dbus/dbus-connection.c (dbus_connection_preallocate_send):
1271 unlock mutex on successful return, patch from Anders Gustafsson
1273 2003-05-04 Havoc Pennington <hp@pobox.com>
1275 * dbus-glib-1.pc.in (Requires): fix dependencies, from
1278 2003-05-04 Havoc Pennington <hp@pobox.com>
1280 * tools/dbus-launch.c: implement
1282 * bus/main.c (main), bus/bus.c (bus_context_new):
1283 implement --print-pid and --fork
1285 2003-05-03 Havoc Pennington <hp@redhat.com>
1287 * dbus/dbus-address.c (dbus_parse_address): fix bug when a key in
1288 the address had no value, and add to test suite. Fix and
1289 regression test from Miloslav Trmac
1291 2003-05-03 Havoc Pennington <hp@pobox.com>
1293 * dbus/dbus-watch.c (dbus_watch_handle): warn and return if a
1294 watch is invalid when handled
1296 * tools/Makefile.am, tools/dbus-launch.c, tools/dbus-launch.1: add
1297 dbus-launch utility to launch the bus from a shell script. Didn't
1298 actually implement dbus-launch yet, it's just a placeholder still.
1300 2003-05-03 Havoc Pennington <hp@pobox.com>
1302 * bus/Makefile.am, bus/dbus-daemon-1.1.in: man page for the
1303 daemon; also documents daemon config file, so replaces
1304 doc/config-file.txt. Corrected some stuff from config-file.txt in
1305 the process of moving it.
1307 2003-05-03 Havoc Pennington <hp@pobox.com>
1309 * tools/Makefile.am, tools/dbus-send.1, tools/dbus-monitor.1:
1312 2003-05-03 Colin Walters <walters@verbum.org>
1314 * dbus/dbus-sysdeps.c (fill_user_info): Test against
1315 DBUS_UID_UNSET to determine whether to do a uid lookup or not.
1317 * Makefile.am: Update to use new .pc versioning scheme.
1319 2003-05-02 Havoc Pennington <hp@redhat.com>
1321 * bus/system.conf.in: allow send/receive to/from message bus
1324 2003-04-30 Havoc Pennington <hp@redhat.com>
1326 * configure.in: print a note when building with unit tests and
1329 2003-04-30 Havoc Pennington <hp@redhat.com>
1331 * Makefile.am: add a check-local that complains if you didn't
1332 configure with --enable-tests
1334 2003-04-29 Havoc Pennington <hp@redhat.com>
1336 * glib/dbus-gmain.c: docs cleanups
1338 * dbus/dbus-types.h: add docs on int64 types
1340 * dbus/dbus-memory.c: fix docs to avoid putting private API in
1341 public API docs section
1343 2003-04-29 Havoc Pennington <hp@redhat.com>
1345 * dbus-1.pc.in, dbus-glib-1.pc.in: rename these from
1346 dbus-1.0.pc.in, dbus-glib-1.0.pc.in. As these change with the
1347 parallel install API version, not with the D-BUS package version.
1349 * HACKING: move some of README over here
1351 * README: updates, and document API/ABI policy
1353 * configure.in: reindentation
1355 2003-04-29 Havoc Pennington <hp@redhat.com>
1357 * dbus/dbus.h: add "you have to define DBUS_API_SUBJECT_TO_CHANGE
1358 to use this library" to be sure people have the right
1361 2003-04-28 Havoc Pennington <hp@redhat.com>
1363 * configure.in: add --enable-docs which by default is auto yes if
1364 doxygen and db2html found, no otherwise; but can be forced on/off
1366 * doc/Makefile.am: conditionalize whether to build docs on
1369 2003-04-28 Havoc Pennington <hp@redhat.com>
1371 * configure.in: 0.10
1375 * bus/system.conf.in: add <includedir>system.d</includedir>
1377 * dbus/dbus-userdb.c (_dbus_user_database_lookup): fix bug when
1378 username was provided but not uid
1380 * bus/config-parser.c (struct BusConfigParser): keep track of
1381 whether the parser is toplevel or was included; change some
1382 of the error handling if it's included.
1384 2003-04-27 Havoc Pennington <hp@pobox.com>
1388 * dbus/dbus-transport.c (_dbus_transport_get_dispatch_status):
1389 report correct status if we finish processing authentication
1390 inside this function.
1392 * bus/activation.c (try_send_activation_failure): use
1393 bus_transaction_send_error_reply
1395 * bus/connection.c (bus_connection_get_groups): return an error
1396 explaining the problem
1398 * bus/bus.c (bus_context_check_security_policy): implement
1399 restriction here that inactive connections can only send the
1400 hello message. Also, allow bus driver to send anything to
1403 * bus/connection.c (bus_connection_complete): create the
1404 BusClientPolicy here instead of on-demand.
1405 (bus_connection_get_policy): don't return an error
1407 * dbus/dbus-message.c (dbus_message_new_error_reply): allow NULL
1408 sender field in message being replied to
1410 * bus/bus.c (bus_context_check_security_policy): fix silly typo
1411 causing it to return FALSE always
1413 * bus/policy.c (bus_client_policy_check_can_send): fix bug where
1414 we checked sender rather than destination
1416 2003-04-25 Havoc Pennington <hp@redhat.com>
1418 test suite is slightly hosed at the moment, will fix soon
1420 * bus/connection.c (bus_connections_expire_incomplete): fix to
1421 properly disable the timeout when required
1422 (bus_connection_set_name): check whether we can remove incomplete
1423 connections timeout after we complete each connection.
1425 * dbus/dbus-mainloop.c (check_timeout): fix this up a bit,
1426 probably still broken.
1428 * bus/services.c (bus_registry_acquire_service): implement max
1429 number of services owned, and honor allow/deny rules on which
1430 services a connection can own.
1432 * bus/connection.c (bus_connection_get_policy): report errors here
1434 * bus/activation.c: implement limit on number of pending
1437 2003-04-25 Havoc Pennington <hp@redhat.com>
1439 * dbus/dbus-transport.c (_dbus_transport_get_unix_user): fix bug
1440 where we used >= 0 instead of != DBUS_UID_UNSET.
1442 2003-04-25 Havoc Pennington <hp@redhat.com>
1444 * glib/dbus-gmain.c (remove_watch): fix for a crash when watches
1445 were toggled without add/remove, fix from Anders Gustafsson
1447 2003-04-24 Havoc Pennington <hp@redhat.com>
1449 * test/data/valid-config-files/basic.conf: add <limit> tags to
1452 * bus/config-parser.h, bus/config-parser.c, bus/bus.c: Implement
1453 <limit> tag in configuration file.
1455 2003-04-24 Havoc Pennington <hp@redhat.com>
1457 * bus/dispatch.c: somehow missed some name_is
1459 * dbus/dbus-timeout.c (_dbus_timeout_set_enabled)
1460 (_dbus_timeout_set_interval): new
1462 * bus/connection.c (bus_connections_setup_connection): record time
1463 when each connection is first set up, and expire them after the
1464 auth timeout passes.
1466 2003-04-24 Havoc Pennington <hp@redhat.com>
1468 * dbus/dbus-message.c (dbus_message_name_is): rename
1469 (dbus_message_service_is): rename
1470 (dbus_message_sender_is): rename
1471 (dbus_message_get_service): rename
1473 2003-04-24 Havoc Pennington <hp@redhat.com>
1475 * configure.in: add --enable-checks
1477 * dbus/dbus-message.c (dbus_message_new): reverse name/service arguments
1479 * dbus/dbus-connection.c (dbus_connection_preallocate_send): fix
1480 to use thread locks.
1481 (_dbus_connection_handler_destroyed_locked): move some private
1482 functions into proper docs group
1484 * dbus/dbus-internals.h: add _dbus_return_if_fail,
1485 _dbus_return_val_if_fail
1487 Throughout: use dbus_return_if_fail
1489 2003-04-23 James Willcox <jwillcox@gnome.org>
1492 * glib/dbus-gmain.c: (add_timeout), (wakeup_main), (create_source),
1493 (dbus_connection_setup_with_g_main),
1494 (dbus_server_setup_with_g_main):
1495 * glib/test-dbus-glib.c: (main):
1496 * glib/test-thread-client.c: (main):
1497 * glib/test-thread-server.c: (new_connection_callback), (main):
1498 * tools/dbus-monitor.c: (main):
1500 Added a GMainContext argument to dbus_connection_setup_with_g_main()
1501 and dbus_server_setup_with_g_main().
1503 2003-04-20 Havoc Pennington <hp@pobox.com>
1505 * doc/dbus-specification.sgml: document the restrictions on
1506 message and service names
1508 2003-04-22 Havoc Pennington <hp@redhat.com>
1510 * dbus/dbus-message.c, dbus/dbus-marshal.c: add 64-bit integer
1511 support, and do some code cleanups to share more code and
1512 speed up array marshal/demarshal.
1514 * dbus-1.0.pc.in (Cflags): put libdir include file in cflags
1516 * configure.in: generate dbus-arch-deps.h
1518 * dbus/dbus-protocol.h (DBUS_TYPE_INT64, DBUS_TYPE_UINT64): add
1521 2003-04-22 Havoc Pennington <hp@redhat.com>
1523 * test/data/valid-messages/opposite-endian.message: fix test
1524 to use proper type for rply field
1526 * test/data/invalid-messages: add tests for below validation
1528 * dbus/dbus-message.c (decode_header_data): validate field types,
1529 and validate that named fields are valid names
1530 (decode_name_field): consider messages in the
1531 org.freedesktop.Local. namespace to be invalid.
1533 * dbus/dbus-string.c (_dbus_string_validate_name): new
1535 2003-04-19 Havoc Pennington <hp@pobox.com>
1537 * bus/driver.c (bus_driver_handle_hello): check limits and
1538 return an error if they are exceeded.
1540 * bus/connection.c: maintain separate lists of active and inactive
1541 connections, and a count of each. Maintain count of completed
1542 connections per user. Implement code to check connection limits.
1544 * dbus/dbus-list.c (_dbus_list_unlink): export
1546 * bus/bus.c (bus_context_check_security_policy): enforce a maximum
1547 number of bytes in the message queue for a connection
1549 2003-04-18 Havoc Pennington <hp@pobox.com>
1551 * dbus/dbus-auth.c (record_mechanisms): memleak fixes
1553 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): fix some
1556 * dbus/dbus-keyring.c (add_new_key): fix a memleak, and
1557 on realloc be sure to update the pointer in the keyring
1559 * dbus/dbus-string.c (_dbus_string_zero): compensate for align
1560 offset to avoid writing to unallocated memory
1562 * dbus/dbus-auth.c (process_rejected): return FALSE if we fail to
1563 try the next mechanism, so we properly handle OOM
1565 * dbus/dbus-keyring.c (_dbus_keyring_new_homedir): fix double-free
1567 (_dbus_keyring_new): fix OOM bug
1568 (_dbus_keyring_new_homedir): always set error; impose a maximum
1569 number of keys we'll load from the file, mostly to speed up the
1570 test suite and make its OOM checks more useful, but also for
1573 * dbus/dbus-auth.c (process_error_server): reject authentication
1574 if we get an error from the client
1575 (process_cancel): on cancel, send REJECTED, per the spec
1576 (process_error_client): send CANCEL if we get an error from the
1579 2003-04-18 Havoc Pennington <hp@pobox.com>
1581 * dbus/dbus-mainloop.c (_dbus_loop_iterate): fix UMR in verbose
1584 * dbus/dbus-auth.c (handle_client_data_cookie_sha1_mech): fix OOM
1587 * dbus/dbus-keyring.c (_dbus_keyring_new_homedir): only whine
1588 about DBUS_TEST_HOMEDIR once
1590 * bus/Makefile.am (TESTS_ENVIRONMENT): put DBUS_TEST_HOMEDIR in
1593 * bus/dispatch.c (bus_dispatch_sha1_test): actually load sha1
1594 config file so we test the right thing
1596 Throughout: assorted docs improvements
1598 2003-04-18 Havoc Pennington <hp@pobox.com>
1600 * glib/dbus-gmain.c: adapt to watch changes
1602 * bus/bus.c, bus/activation.c, etc.: adjust to watch changes
1604 * dbus/dbus-server.h: remove dbus_server_handle_watch
1606 * dbus/dbus-connection.h: remove dbus_connection_handle_watch
1608 * dbus/dbus-watch.c (dbus_watch_handle): change DBusWatch to work
1609 like DBusTimeout, so we don't need dbus_connection_handle_watch
1612 2003-04-17 Havoc Pennington <hp@redhat.com>
1614 * dbus/dbus-userdb.c, dbus/dbus-sysdeps.c: redo all the passwd
1615 database usage so it all goes via the DBusUserDatabase cache.
1617 2003-04-17 Havoc Pennington <hp@redhat.com>
1619 * dbus/dbus-mainloop.c (_dbus_loop_iterate): fix logic so that if
1620 there was an OOM watch we skipped, we always return TRUE so we
1621 iterate again to have a look at it again. Fixes test suite hang.
1622 Code rearrangement also lets us lose some memset and only iterate
1623 over callbacks once.
1625 * bus/driver.c (bus_driver_handle_message): sense of test for
1628 2003-04-16 Havoc Pennington <hp@pobox.com>
1630 * doc/dbus-specification.sgml: make spec say serials are unsigned
1632 * dbus/dbus-message.h: change message serials to unsigned
1634 * dbus/dbus-connection.c: adapt to message serials being unsigned
1636 2003-04-15 Havoc Pennington <hp@pobox.com>
1638 * bus/bus.c: create and keep around a shared DBusUserDatabase
1641 * bus/connection.c (bus_connection_get_groups): don't cache
1642 groups for user in the connection object, since user database
1643 object now does that.
1645 2003-04-16 Havoc Pennington <hp@redhat.com>
1647 * dbus/dbus-message.c (_dbus_message_add_size_counter): keep a
1648 list of size counters
1649 (_dbus_message_loader_putback_message_link): put back a popped link
1651 * dbus/dbus-connection.c
1652 (dbus_connection_set_max_live_messages_size): rename
1654 (dbus_connection_get_outgoing_size): get size of outgoing
1656 (_dbus_connection_set_connection_counter): remove this cruft
1658 2003-04-14 Havoc Pennington <hp@redhat.com>
1660 * dbus/dbus-userdb.c: user database abstraction, mostly to get
1661 caching, but at some point we might want to be able to use a
1664 * bus/dispatch.c (bus_dispatch_sha1_test): add a test that uses
1665 SHA1 conf file to test the sha1 auth mechanism, since the regular
1666 test always uses EXTERNAL when available.
1669 test/data/valid-config-files/debug-allow-all-sha1.conf.in:
1670 add conf file that requires use of sha1 auth
1672 2003-04-13 Havoc Pennington <hp@pobox.com>
1674 * tools/dbus-send.c, tools/dbus-monitor.c: two utility programs
1675 from Philip Blundell to send messages and monitor them.
1677 2003-04-13 Havoc Pennington <hp@pobox.com>
1679 * dbus/dbus-mainloop.c: fix some reentrancy issues by refcounting
1682 * test/data/valid-config-files/debug-allow-all.conf.in: allow all
1685 * dbus/dbus-transport.c (_dbus_transport_get_dispatch_status):
1686 fix to only recover unused bytes if we're already authenticated
1687 (_dbus_transport_get_is_authenticated): fix to still mark us
1688 authenticated if there are unused bytes.
1690 * bus/dispatch.c: implement security policy checking
1692 * bus/connection.c (bus_transaction_send_from_driver): new
1694 * bus/bus.c (bus_context_check_security_policy): new
1696 * bus/dispatch.c (send_service_nonexistent_error): delete this,
1697 now we just set the DBusError and it gets converted to an error
1700 * bus/connection.c (allow_user_function): enable code using actual
1701 data from the config file
1703 * bus/policy.c (list_allows_user): handle wildcard rules for
1704 user/group connection perms
1706 2003-04-13 Havoc Pennington <hp@pobox.com>
1708 * bus/config-parser.c: Load up the BusPolicy and BusPolicyRules
1710 * dbus/dbus-sysdeps.c (_dbus_get_user_id): new function
1712 * bus/policy.c (bus_policy_append_mandatory_rule)
1713 (bus_policy_append_default_rule, bus_policy_append_user_rule)
1714 (bus_policy_append_group_rule): new functions
1716 2003-04-12 Havoc Pennington <hp@pobox.com>
1718 * bus/config-parser.c (bus_config_parser_new): fix a memleak
1720 * dbus/dbus-sysdeps.c: change DBusCredentials to use longs for
1721 the pid/gid/uid, just for paranoia.
1723 * test/break-loader.c (randomly_do_n_things): find a byte
1724 containing a type code, and randomly change it to a different
1727 2003-04-12 Havoc Pennington <hp@pobox.com>
1729 * bus/policy.h: change BusPolicy to be the thing from the config
1730 file, and rename old BusPolicy to BusClientPolicy
1732 * bus/bus.c, bus/connection.c, bus/config-parser.c: change to
1733 match change in how policy works
1735 * dbus/dbus-internals.h: mark assert_not_reached as
1736 __attribute((noreturn))__
1738 2003-04-11 Havoc Pennington <hp@redhat.com>
1740 * doc/dbus-specification.sgml: fix a spot with the wrong name for
1741 the broadcast service. Use boolean return for ServiceExists.
1743 2003-04-11 Havoc Pennington <hp@redhat.com>
1745 * configure.in: add another directory to look for qt in.
1747 2003-04-11 Havoc Pennington <hp@redhat.com>
1749 * AUTHORS: add Colin Walters
1751 2003-04-11 Havoc Pennington <hp@redhat.com>
1757 2003-04-11 Havoc Pennington <hp@redhat.com>
1759 * bus/messagebus.in: remove pid file when stopping the
1760 message bus, since the bus won't have privileges to remove it
1763 2003-04-11 Havoc Pennington <hp@redhat.com>
1765 * bus/bus.c (bus_context_new): move credentials change after
1768 2003-04-11 Havoc Pennington <hp@pobox.com>
1770 * test/decode-gcov.c: add "below average functions" to the
1771 coverage report, and change how some of the code works.
1773 * bus/test-main.c: bracket some stuff in DBUS_BUILD_TESTS so it's
1774 not in the coverage stats.
1776 * test/test-service.c (main): use _dbus_verbose not fprintf in a
1777 couple places so running the test suite doesn't result in megaspam.
1779 2003-04-11 Havoc Pennington <hp@pobox.com>
1781 * bus/dispatch.c (check_existent_service_activation): accept a no
1782 memory error in a place we didn't before
1784 * bus/test.c (bus_test_run_everything): remove hacky "do it twice
1785 in case the first one failed," since the test suite is less
1788 2003-04-10 Havoc Pennington <hp@pobox.com>
1790 * bus/dispatch.c (check_segfault_service_activation): add test
1791 for launching an executable that just crashes.
1793 * test/test-segfault.c (main): try setting coredumpsize to 0 so we
1794 don't leave a million cores. We'll see how portable this is.
1796 2003-04-10 Havoc Pennington <hp@pobox.com>
1798 * dbus/dbus-spawn.c (_dbus_spawn_async_with_babysitter): move all
1799 the possible parent failures before we fork, so that we don't
1800 fail to create a babysitter after creating the child.
1802 * bus/activation.c (bus_activation_activate_service): kill child
1803 if we don't successfully complete the activation.
1805 2003-04-10 Havoc Pennington <hp@redhat.com>
1807 * dbus/dbus-connection.c (dbus_connection_flush): don't spin on
1808 the connection if it's disconnected
1810 * bus/activation.c (bus_activation_service_created): use new
1811 transaction features to roll back removal of pending activation if
1812 we don't successfully create the service after all. Don't remove
1813 pending activation if the function fails.
1815 * dbus/dbus-list.c (_dbus_list_insert_before_link)
1816 (_dbus_list_insert_after_link): new code to facilitate
1819 * dbus/dbus-hash.c (_dbus_hash_table_insert_string_preallocated):
1820 new functionality, so we can preallocate the ability to insert
1823 * bus/connection.c (bus_transaction_add_cancel_hook): new function
1824 allowing us to put custom hooks in a transaction to be used for
1825 cancelling said transaction
1827 * doc/dbus-specification.sgml: add some discussion of secondary
1828 service owners, and disallow zero-length service names
1830 * bus/services.c (bus_registry_acquire_service): new function,
1831 splits out part of bus_driver_handle_acquire_service() and fixes
1832 a bug where we didn't remove the service doing the acquiring
1833 from the secondary queue if we failed to remove the current owner
1834 from the front of the queue.
1836 2003-04-10 Alexander Larsson <alexl@redhat.com>
1838 * doc/dbus-specification.sgml:
1839 s/org.freedesktop.Broadcast/org.freedesktop.DBus.Broadcast/
1841 2003-04-10 Alexander Larsson <alexl@redhat.com>
1846 Added files to cvsignore
1848 * dbus/dbus-message.h:
1849 * dbus/dbus-message.c: (dbus_message_iter_get_named):
1850 Make get_named() take two out argument and return a boolean.
1851 (dbus_message_iter_get_args_valist):
1852 Update usage of get_named().
1853 (dbus_message_iter_append_byte):
1855 (dbus_message_iter_append_named)
1857 (message_iter_test), (check_message_handling_type), (_dbus_message_test):
1860 2003-04-10 Alexander Larsson <alexl@redhat.com>
1862 * dbus/dbus-marshal.[ch]:
1863 Add array_type_pos argument to _dbus_marshal_validate_arg.
1864 Let you pass a NULL end_pos to _dbus_marshal_validate_type.
1866 * dbus/dbus-message.[ch]:
1867 Multi-dimensional arrays have full type specification in the
1868 outermost array. Iter code re-arranged to handle this.
1869 Added some more iter tests.
1871 * doc/dbus-specification.sgml:
1874 Update new array encoding description.
1875 Correct DBUS_SERVICE_FLAGS_REPLACE_EXISTING description.
1877 * test/data/invalid-messages/array-with-mixed-types.message:
1878 * test/data/valid-messages/array-of-array-of-uint32.message:
1879 Change to the new array format.
1881 * test/data/invalid-messages/too-short-dict.message:
1884 * test/data/valid-messages/recursive-types.message:
1885 Fix up and extend test.
1887 2003-04-10 Havoc Pennington <hp@pobox.com>
1889 * bus/dispatch.c: lots of fixes
1891 * dbus/dbus-mainloop.c (_dbus_loop_dispatch): export
1892 (_dbus_loop_iterate): remove old "quit if no callbacks" code,
1893 that was crack, broke the test service.
1895 * dbus/dbus-transport.c (_dbus_transport_open): fix error
1896 handling to avoid piling up errors if we get a failure on the
1899 * dbus/dbus-internals.c (_dbus_real_assert_not_reached): include
1900 pid in assertion failures.
1902 * dbus/dbus-mainloop.c (_dbus_loop_iterate): use static arrays up
1903 to some fixed size of file descriptor array. Don't return TRUE
1904 anytime a timeout exists, that led to lots of busy loop silliness
1907 2003-04-09 Havoc Pennington <hp@redhat.com>
1909 * dbus/dbus-mainloop.c (check_timeout): fix timeouts, I thought
1910 I'd checked this in earlier but hadn't.
1912 2003-04-09 Havoc Pennington <hp@redhat.com>
1914 * bus/dispatch.c (bus_dispatch_test): get a bit further through
1915 the activation test (man this is getting old!)
1917 2003-04-09 Havoc Pennington <hp@redhat.com>
1919 * test/test-utils.c: use dispatch status function to fix this up
1921 * bus/connection.c (connection_watch_callback): don't dispatch
1923 (connection_timeout_callback): don't dispatch from here
1924 (bus_connections_setup_connection): set the dispatch status function
1925 (bus_connection_disconnected): unset it
1927 * dbus/dbus-mainloop.c (_dbus_loop_queue_dispatch): new function
1928 used to add a connection to be dispatched
1929 (_dbus_loop_iterate): do the dispatching at the end of each
1932 * dbus/dbus-connection.c
1933 (dbus_connection_set_dispatch_status_function): new function
1934 allowing us to fix up main loop usage
1935 (_dbus_connection_last_unref): free all the various function
1937 (dbus_connection_dispatch): call the DispatchStatusFunction
1938 whenever this function returns
1939 (dbus_connection_handle_watch): call DispatchStatusFunction
1940 (dbus_connection_send_with_reply_and_block): call DispatchStatusFunction
1941 (reply_handler_timeout): call DispatchStatusFunction
1942 (dbus_connection_flush): call DispatchStatusFunction
1944 2003-04-09 Havoc Pennington <hp@redhat.com>
1946 * dbus/dbus-bus.c (dbus_bus_register): fix up error handling and
1949 * bus/dispatch.c (check_service_activated): fix bug in test
1951 * dbus/dbus-mainloop.c (check_timeout): fix this up
1953 * dbus/dbus-internals.c (_dbus_verbose_real): include PID in
1954 verbose output so we can sort out output from different processes,
1955 e.g. in the activation case.
1957 2003-04-08 Colin Walters <walters@gnu.org>
1959 * bus/bus.c (struct BusContext) [pidfile]: New member, to store
1961 (bus_context_new): Set it.
1962 (bus_context_unref): Use it to delete the pid file.
1964 2003-04-08 Havoc Pennington <hp@redhat.com>
1966 * test/data/invalid-messages/array-with-mixed-types.message:
1967 regression test that fails for the moment
1969 * dbus/dbus-test.c (dbus_internal_do_not_use_run_tests): reorder
1970 tests for convenience
1972 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): don't allow
1973 array of nil, it broke things.
1975 * test/data/invalid-messages/array-of-nil.message: regression test
1977 * test/data/valid-messages/array-of-array-of-uint32.message:
1978 happened to write this so added it to suite
1980 2003-04-08 Havoc Pennington <hp@redhat.com>
1982 * bus/driver.c (bus_driver_handle_acquire_service): init
1983 retval/reply before checking name
1985 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): add a
1986 recursion depth argument
1988 * dbus/dbus-message.h (struct DBusMessageIter): put some padding
1989 in the public struct for future extension
1991 * dbus/dbus-message-builder.c (_dbus_message_data_load): fix
1994 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): fix a verbose
1997 * doc/dbus-specification.sgml: fix typo
1999 2003-04-08 Alexander Larsson <alexl@redhat.com>
2001 Implemented recursive types, named types and new-style iters
2004 * glib/test-thread-client.c: (thread_func):
2005 * glib/test-thread-server.c: (handle_test_message):
2006 * test/test-service.c: (handle_echo):
2015 * dbus/dbus-internals.c: (_dbus_type_to_string):
2016 Update for new types.
2018 * dbus/dbus-marshal.[ch]:
2019 Implement recursive types and the new marshalling format.
2020 Remove hardcoded dict marshalling.
2021 Marshal named types.
2023 * dbus/dbus-message-builder.c:
2025 Remove references to old types
2027 * dbus/dbus-message.[ch]:
2028 New non-refcounted iter API that supports recursive iters.
2029 Use iters for appending, including support for recursive
2031 Add byte and named type support.
2032 Update everything to new marshalling formats.
2033 Add tests for new API.
2035 * dbus/dbus-protocol.h:
2036 Remove old array types.
2037 Add types: BYTE, ARRAY, DICT, NAMED
2039 * dbus/dbus-string.c:
2040 * dbus/dbus-sysdeps.c:
2041 Make parse_double locale safe.
2043 * dbus/dbus-test-main.c:
2049 * doc/dbus-specification.sgml:
2052 * test/data/incomplete-messages/missing-body.message:
2053 * test/data/invalid-messages/bad-boolean.message:
2054 * test/data/invalid-messages/bad-boolean-array.message:
2055 * test/data/invalid-messages/boolean-array-length-too-long.message-raw:
2056 * test/data/invalid-messages/boolean-has-no-value.message-raw:
2057 * test/data/invalid-messages/too-short-dict.message:
2058 * test/data/valid-messages/dict-simple.message:
2059 * test/data/valid-messages/dict.message:
2060 * test/data/valid-messages/emptiness.message:
2061 * test/data/valid-messages/lots-of-arguments.message:
2062 * test/data/valid-messages/no-padding.message:
2063 * test/data/valid-messages/recursive-types.message:
2064 Add missing NAME fields
2065 Fix up dicts & arrays
2067 * test/data/invalid-messages/dict-with-nil-value.message:
2068 Removed, this is not invalid anymore.
2070 * test/data/valid-messages/recursive-types.message:
2071 Add new test for deeply recursive types.
2073 2003-04-07 Havoc Pennington <hp@pobox.com>
2075 * bus/driver.c (bus_driver_handle_acquire_service): return an
2076 error if you try to acquire a service that starts with ':'
2078 2003-04-07 Havoc Pennington <hp@redhat.com>
2080 * doc/dbus-specification.sgml: require that base service names
2081 start with ':' and that the base service is created/deleted
2082 as first and last things a connection does on the bus
2084 * bus/dispatch.c (check_existent_service_activation): lots more
2085 work on the activation test; it doesn't fully pass yet...
2087 * test/test-service.c (main): fix so we don't memleak the
2088 connection to the message bus
2089 (filter_func): accept a message asking us to exit
2091 2003-04-06 Havoc Pennington <hp@pobox.com>
2093 * qt/Makefile.am (dbusinclude_HEADERS): install dbus-qt.h,
2096 * configure.in: fixes to Qt detection from Colin Walters
2098 * doc/Makefile.am: Only remove generated docbook dirs if they
2099 exist, from Colin Walters
2101 * dbus/dbus-bus.c: change how we set well-known connections to
2102 NULL, so that it works if a single connection is stored in
2103 two well-known array slots.
2105 * test/Makefile.am: remove a lot of stuff that isn't immediately
2106 useful, it's in CVS history if we want it.
2108 * test/test-service.c: use dbus-mainloop instead of that
2111 2003-04-06 Havoc Pennington <hp@pobox.com>
2113 * dbus/Makefile.am: split lists of sources into stuff that goes in
2114 the library, util functions that go in the lib and are also used
2115 elsewhere, and util functions that are used in tests/daemon but
2116 don't go in the lib.
2118 * dbus/dbus-mainloop.h, dbus/dbus-mainloop.c: move bus/loop.[hc]
2119 here so it can be used in test binaries also
2121 2003-04-06 Havoc Pennington <hp@pobox.com>
2123 * dbus/dbus-sysdeps.c (_dbus_become_daemon): write the pidfile
2124 here in the parent process, so we can return an error if it
2125 fails. Also, move some of the code into the child so the parent
2126 is less hosed if we fail midway through.
2128 * bus/bus.c (bus_context_new): move pidfile detection further up
2129 in the function, before we start overwriting sockets and such.
2131 * bus/messagebus.in: adjust this a bit, not sure if it will work.
2133 * configure.in: add --with-system-pid-file and --with-system-socket
2135 2003-04-06 Colin Walters <walters@verbum.org>
2137 * configure.in (DBUS_SYSTEM_PID_FILE): New variable.
2139 * bus/system.conf.in: Declare a pidfile.
2141 * bus/bus.c (bus_context_new): Test for an existing pid file, and
2142 create one (if appropriate).
2144 * bus/config-parser.c (enum ElementType) [ELEMENT_PIDFILE]: New.
2145 (struct BusConfigParser) [pidfile]: New.
2146 (element_type_to_name, merge_included, start_busconfig_child)
2147 (bus_config_parser_end_element, bus_config_parser_content): Handle it.
2148 (bus_config_parser_unref): Free it.
2149 (bus_config_parser_get_pidfile): New function.
2151 * bus/config-parser.h (_dbus_write_pid_file): Prototype.
2153 * dbus/dbus-errors.h (DBUS_ERROR_PIDFILE_EXISTS): New error.
2155 * dbus/dbus-sysdeps.c (_dbus_write_pid_file): New function.
2157 * dbus/dbus-sysdeps.h: Prototype it.
2159 2003-04-06 Havoc Pennington <hp@pobox.com>
2161 * bus/bus.c (bus_context_new): print the address in here, rather
2162 than in main(), because we need to do it before forking the daemon
2164 * bus/dispatch.c (send_service_nonexistent_error): set the sender
2165 on the service nonexistent error
2167 * bus/driver.c (bus_driver_handle_acquire_service): set the
2168 sender on the AcquireService reply
2170 * test/data/valid-config-files/debug-allow-all.conf.in: Make test
2171 server also listen on a UNIX socket so services can connect to it.
2173 2003-04-06 Havoc Pennington <hp@pobox.com>
2175 * dbus/dbus-threads.c: Redo how the fake debug mutexes are done
2176 so it detects deadlocks and also we actually init threads when
2179 2003-04-06 Havoc Pennington <hp@pobox.com>
2181 * dbus/dbus-server-unix.c (_dbus_server_new_for_domain_socket):
2182 save the domain socket name, and unlink it when we disconnect the
2183 server. Means that at least when we exit normally, we won't leave
2184 a bunch of junk in /tmp
2186 * dbus/dbus-transport-unix.c
2187 (_dbus_transport_new_for_domain_socket): code cleanup (nicer
2188 memory management). (I was making a real change here but then
2191 2003-04-06 Havoc Pennington <hp@pobox.com>
2193 * bus/bus.c (bus_context_new): fix wrong handling of
2194 server_data_slot_unref() in the error case.
2196 * dbus/dbus-internals.h (_dbus_assert): change so it passes
2197 "(condition) != 0" to _dbus_real_assert so that
2198 "_dbus_assert (pointer)" doesn't cause a warning
2200 * bus/main.c (main): accept --print-address option to print out
2201 the message bus address
2203 * dbus/dbus-sysdeps.c (_dbus_generate_random_ascii): export this
2205 * dbus/dbus-transport.c (_dbus_transport_open): special error for
2206 "tmpdir" option to unix: address on client side
2208 * dbus/dbus-server.c (dbus_server_listen): handle "tmpdir" option
2211 * configure.in (TEST_SOCKET_DIR): locate a temporary directory
2212 we can use to create sockets in the test suite.
2214 * bus/main.c (signal_handler): on SIGTERM, exit the daemon
2215 cleanly. To be used for testing.
2217 * dbus/dbus-spawn.c (babysit): use _dbus_set_signal_handler()
2219 * dbus/dbus-sysdeps.c (_dbus_set_signal_handler): new
2221 * dbus/dbus-server-debug-pipe.c (_dbus_transport_debug_pipe_new):
2222 handle trying to call this when there's no servers active
2224 2003-04-05 Havoc Pennington <hp@pobox.com>
2230 2003-04-05 Havoc Pennington <hp@pobox.com>
2232 * bus/bus.c (setup_server): fix this so dbus-daemon-1 doesn't
2233 crash on startup. Need to get "try starting the daemon"
2234 in the test suite I guess. ;-)
2236 * dbus/dbus-server.h, dbus/dbus-server.c: remove the stuff that
2237 tracked the number of open connections; it's better done in
2238 application-specific code as you want it to span all servers etc.
2240 2003-04-05 Havoc Pennington <hp@pobox.com>
2242 * bus/Makefile.am (install-data-hook): add missing DESTDIR,
2243 patch from Colin Walters
2245 2003-04-05 Havoc Pennington <hp@pobox.com>
2247 * doc/config-file.txt (Elements): fix docs of <auth> to reflect
2248 reality; in fact multiple mechanisms are allowed.
2250 * dbus/dbus-internals.c (_dbus_real_assert)
2251 (_dbus_real_assert_not_reached): move guts of _dbus_assert() and
2252 _dbus_assert_not_reached() into functions, so that they don't show
2253 up in basic block counts for test coverage, and don't use up as
2254 much disk space. Does mean slower execution speed though, so
2255 assumes --disable-asserts is the normal production case.
2257 2003-04-05 Havoc Pennington <hp@pobox.com>
2259 * test/Makefile.am (dist-hook): also dist *.in files
2265 2003-04-05 Havoc Pennington <hp@pobox.com>
2267 * dbus/dbus-string.c: docs warning
2269 * dbus/dbus-spawn.c: missing docs
2271 * dbus/dbus-memory.c (struct ShutdownClosure): missing docs
2273 2003-04-05 Havoc Pennington <hp@pobox.com>
2275 * bus/loop.c (bus_loop_iterate): fix the timeout code, using
2278 * dbus/dbus-spawn.c (_dbus_babysitter_unref): set sitter_pid
2279 to -1 once we've reaped the babysitter
2280 (_dbus_babysitter_handle_watch): do as much work as we can, not
2283 * bus/activation.c: add code using DBusBabysitter so that we
2284 handle it when a service fails to start up properly.
2285 (bus_activation_service_created): don't remove the activation
2286 entries as we go, just let them get removed when we free the pending
2287 activation. Unref reply messages after sending them.
2289 2003-04-05 Havoc Pennington <hp@pobox.com>
2291 * test/decode-gcov.c (main): print per-directory stats in the report
2293 * Makefile.am (coverage-report.txt): don't include test/* in gcov stats
2295 2003-04-05 Havoc Pennington <hp@pobox.com>
2297 * Makefile.am (coverage-report.txt): add target "coverage-report.txt"
2299 * test/decode-gcov.c: hack up a little program to suck data
2300 out of gcov files. Yes this is sort of silly.
2302 * configure.in: define something in config.h and do an
2303 AM_CONDITIONAL when gcov is enabled
2305 2003-04-04 Havoc Pennington <hp@redhat.com>
2307 * dbus/dbus-spawn.c, dbus/dbus-spawn.h: Change dbus_spawn to
2308 return a "babysitter" object that is used to monitor the status of
2309 the spawned process and reap it when required.
2311 * test/test-segfault.c, test/test-exit.c,
2312 test/test-sleep-forever.c: binaries that do various lame things,
2313 used in the test suite.
2315 * dbus/dbus-sysdeps.c: kill _dbus_errno_to_string()
2317 2003-04-03 Havoc Pennington <hp@pobox.com>
2319 * dbus/dbus-spawn.c: Move dbus-spawn into a separate file
2320 in preparation for modifying it, dbus-sysdeps is getting
2323 2003-04-03 Havoc Pennington <hp@redhat.com>
2325 * bus/loop.h, bus/loop.c: make the mainloop an object so we can
2328 * bus/*.[hc]: adapt to mainloop change
2330 2003-04-03 Havoc Pennington <hp@redhat.com>
2332 * bus/activation.c (load_directory): fix up memleaks
2333 (bus_activation_entry_free): free the entry
2335 * dbus/dbus-bus.c (dbus_bus_acquire_service): return an error if
2336 we get one from the message bus; fix memleaks.
2338 * dbus/dbus-message.c (dbus_set_error_from_message): new function
2340 2003-04-03 Havoc Pennington <hp@pobox.com>
2342 * bus/config-parser.c (bus_config_parser_unref): free
2343 list of mechanisms, bug discovered by test suite enhancements
2344 (putting system.conf and session.conf into suite)
2346 * test/Makefile.am, test/test-service.c: add placeholder for a
2347 test service that we'll activate as part of test suite. Doesn't
2350 * dbus/dbus-sysdeps.c (_dbus_setenv): support unsetenv by
2351 setting NULL value, and use system malloc not dbus_malloc()
2352 when we have unavoidable memleakage.
2354 * dbus/dbus-bus.c (dbus_bus_get): fix bug where bus type of 0
2355 didn't work, and support DBUS_BUS_ACTIVATION.
2357 * bus/activation.c (child_setup): pass our well-known bus type to
2360 * bus/config-parser.c: support <type> to specify well-known type
2362 * doc/dbus-specification.sgml: document the env variables to
2363 locate well-known buses and find service activator
2365 2003-04-02 Havoc Pennington <hp@redhat.com>
2367 * test/Makefile.am (all-local): add a rule to copy tests to
2368 builddir, so we can have generated tests. Use this to remove the
2369 silly hack for testing system.conf and session.conf. Will use this
2370 shortly to generate .service files pointing to test binaries.
2372 2003-04-02 Havoc Pennington <hp@redhat.com>
2374 * dbus/dbus-string.c (set_length): fix a bug - we allocated max of
2375 current alloc and needed new length, not max of the doubled
2376 allocation and needed new length. Also, when building tests,
2377 don't do the double-allocation stuff, just realloc every time.
2379 2003-04-02 Havoc Pennington <hp@redhat.com>
2381 * dbus/dbus-sysdeps.c (_dbus_file_get_contents): include filenames
2383 (_dbus_string_get_dirname): new
2384 (_dbus_sysdeps_test): new
2385 (_dbus_directory_open): include dirnames in error messages
2387 * bus/config-parser.c: interpret <include> and <includedir> and
2388 <servicedir> relative to config file location if the given
2389 filename is not absolute.
2391 * dbus/dbus-string.c (_dbus_string_find_byte_backward): new
2393 2003-04-02 Havoc Pennington <hp@redhat.com>
2395 * bus/connection.c (bus_transaction_send_error_reply): set sender
2396 service for the error, and unref the reply on success
2398 * bus/activation.c: convert to use BusTransaction so OOM can be
2400 (bus_activation_service_created): set sender of the message
2402 2003-04-01 Havoc Pennington <hp@redhat.com>
2404 * bus/config-parser.c, bus/bus.c: implement <servicedir> and
2405 <includedir> (at least mostly)
2407 * dbus/dbus-sysdeps.c (_dbus_change_identity): set the group ID
2408 first, then the user ID
2410 2003-04-01 Havoc Pennington <hp@pobox.com>
2412 * dbus/dbus-server.c (dbus_server_set_auth_mechanisms): new
2415 * dbus/dbus-auth.c (_dbus_auth_set_mechanisms): new
2417 * dbus/dbus-internals.c (_dbus_dup_string_array): new function
2419 * dbus/dbus-sysdeps.c (_dbus_listen_unix_socket): chmod the
2420 socket 0777, and unlink any existing socket.
2422 * bus/bus.c (bus_context_new): change our UID/GID and fork if
2423 the configuration file so specifies; set up auth mechanism
2426 * bus/config-parser.c (bus_config_parser_content): add support
2427 for <fork> option and fill in code for <auth>
2429 * bus/system.conf.in: add <fork/> to default configuration,
2430 and limit auth mechanisms to EXTERNAL
2432 * doc/config-file.txt (Elements): add <fork>
2434 * dbus/dbus-sysdeps.c (_dbus_become_daemon): new function
2435 (_dbus_change_identity): new function
2437 2003-03-31 Havoc Pennington <hp@redhat.com>
2439 * dbus/dbus-sysdeps.c (_dbus_connect_unix_socket)
2440 (_dbus_listen_unix_socket): fix off-by-one error in null
2441 termination spotted by Nalin
2443 2003-03-31 Havoc Pennington <hp@redhat.com>
2445 * dbus/dbus-keyring.c (_dbus_keyring_new_homedir): allow setting
2446 DBUS_TEST_HOMEDIR when tests are enabled, so we can test without
2447 having a real home directory available.
2449 2003-03-31 Havoc Pennington <hp@redhat.com>
2451 * bus/Makefile.am (install-data-hook): create /var/run/dbus
2453 * bus/messagebus.in: add init script for Red Hat /etc/init.d
2455 * configure.in: add support for specifying a style of init script
2458 2003-03-31 Havoc Pennington <hp@redhat.com>
2460 Fix some annoying DBusString API and fix all affected code.
2462 * dbus/dbus-string.c (_dbus_string_init): get rid of annoying
2464 (_dbus_string_get_data): change to return string instead of using
2466 (_dbus_string_get_const_data): ditto
2467 (_dbus_string_get_data_len): ditto
2468 (_dbus_string_get_const_data_len): ditto
2470 2003-03-31 Havoc Pennington <hp@redhat.com>
2472 * bus/main.c (main): fix up the command line arguments to be nicer
2474 2003-03-31 Havoc Pennington <hp@redhat.com>
2476 * dbus/Makefile.am (INCLUDES): use EXPANDED_LOCALSTATEDIR to
2477 define DBUS_SYSTEM_BUS_PATH as we want to compile in the same
2478 final location that lands in the config file
2480 * bus/config-loader-expat.c (bus_config_load): fix type of
2483 * doc/TODO: remove TODO item for dbus_bus_get()
2485 * dbus/dbus-bus.c (bus_data_free): add missing lock/unlock
2487 2003-03-31 Havoc Pennington <hp@pobox.com>
2489 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_domain_socket)
2490 (_dbus_transport_new_for_tcp_socket): these didn't need the "server"
2491 argument since they are always client side
2493 * dbus/dbus-server.c (dbus_server_get_address): new function
2495 * bus/main.c (main): take the configuration file as an argument.
2497 * test/data/valid-config-files/debug-allow-all.conf: new file to
2498 use with dispatch.c tests for example
2500 * bus/test-main.c (main): require test data dir
2502 * bus/bus.c (bus_context_new): change this to take a
2503 configuration file name as argument
2505 * doc/config-file.txt (Elements): add <servicedir>
2507 * bus/system.conf, bus/session.conf: new files
2509 * dbus/dbus-bus.c (dbus_bus_get): look for system bus on
2510 well-known socket if none set
2512 * configure.in: create system.conf and session.conf
2514 2003-03-30 Havoc Pennington <hp@pobox.com>
2516 * bus/config-parser.c: hacking
2518 * dbus/dbus-memory.c: don't use DBusList for the list of stuff
2519 to shut down, since it could cause weirdness with the DBusList
2522 * dbus/dbus-list.c (_dbus_list_test): add tests for the
2523 link-oriented stack routines
2524 (alloc_link): free the mempool if the first alloc from it fails
2526 * dbus/dbus-mempool.c (struct DBusMemBlock): fix alignment issue
2528 * dbus/dbus-string.c (UNICODE_VALID): sync new version of this
2530 (_dbus_string_skip_white): new
2532 * doc/config-file.txt (Elements): add <includedir>
2534 2003-03-28 Havoc Pennington <hp@pobox.com>
2536 * dbus/dbus-string.c (_dbus_string_copy_data_len)
2537 (_dbus_string_copy_data): new functions
2539 2003-03-28 Anders Carlsson <andersca@codefactory.se>
2541 * dbus/dbus-bus.c: (bus_data_free), (dbus_bus_get):
2545 * dbus/dbus-memory.c:
2548 2003-03-28 Havoc Pennington <hp@pobox.com>
2550 * bus/test.c (bus_test_flush_bus): remove the sleep from here,
2551 I think it may have just been superstition. Not sure.
2553 * dbus/dbus-string.c (_dbus_string_base64_decode): catch some OOM
2554 failures that were not being handled.
2556 * dbus/dbus-auth.c (process_auth): fix a memleak in OOM handling
2558 * dbus/dbus-memory.c: add ability to set number of mallocs in a
2559 row that will fail on out-of-memory.
2561 * dbus/dbus-internals.c (_dbus_test_oom_handling): convenience
2562 function for testing out-of-memory handling.
2564 * bus/config-loader-expat.c (memsuite): don't wrap the dbus
2565 allocation functions, they do map exactly to the expat ones.
2567 2003-03-27 Havoc Pennington <hp@redhat.com>
2569 * bus/config-loader-libxml.c (bus_config_load): add another error
2572 2003-03-26 Anders Carlsson <andersca@codefactory.se>
2575 Add note about automatic service activation.
2577 * doc/dbus-specification.sgml:
2578 Rename the specification and clarify a few things.
2580 2003-03-26 Anders Carlsson <andersca@codefactory.se>
2583 * dbus/dbus-address.c:
2585 * dbus/dbus-marshal.c:
2586 * dbus/dbus-server-debug-pipe.c:
2587 * dbus/dbus-transport-unix.c:
2588 Fix documentation warnings.
2590 2003-03-26 Havoc Pennington <hp@pobox.com>
2592 * bus/test-main.c, dbus/dbus-test.c (main): check memleaks
2593 after every test so it's quick and easy to see which leaked, and
2594 so we test multiple dbus_shutdown() calls
2596 * configure.in: change configure.in XML stuff to also support
2599 * config-loader-libxml.c: some hacking
2601 * config-loader-expat.c: some hacking
2603 * config-parser.c: some hacking, plus tests
2605 2003-03-25 Havoc Pennington <hp@redhat.com>
2607 * throughout - add more _DBUS_ASSERT_ERROR_IS_CLEAR
2609 * configure.in: add --with-xml option to specify XML library,
2610 right now only libxml is supported.
2612 * bus/config-loader-libxml.c, config-parser.c: sync some minor
2613 nonworking code between home and work, still just stubs
2615 2003-03-24 Havoc Pennington <hp@redhat.com>
2617 * dbus/dbus-sysdeps.c (_dbus_set_fd_nonblocking): move to this
2620 * dbus/dbus-errors.c (dbus_set_error, dbus_set_error_const): allow
2621 NULL argument for "message" if the error is a well-known one,
2622 fill in a generic message in this case.
2624 * dbus/dbus-errors.h (DBusResultCode): Kill DBusResultCode in
2627 * bus/test.c (bus_test_flush_bus): add
2629 * bus/policy.c (bus_policy_test): test code stub
2631 2003-03-24 Havoc Pennington <hp@pobox.com>
2633 * bus/connection.c (bus_connections_setup_connection): set up
2634 the "can this user connect" function, but it always returns
2635 TRUE until we have a config file parser so we can have a config
2636 file that allows connections.
2638 2003-03-23 Havoc Pennington <hp@pobox.com>
2640 * dbus/dbus-threads.c (dbus_mutex_new, dbus_condvar_new): with
2641 DBUS_BUILD_TESTS, actually alloc/free a block of memory for
2642 the mutex, so we can check for proper memory management
2645 * dbus/dbus-dataslot.c: remove the mutex from
2646 DBusDataSlotAllocator and lock it manually when using it,
2647 to simplify fitting it into the global slots framework.
2649 * dbus/dbus-threads.c (init_static_locks): rework how we're
2650 handling global locks so they are easily shut down.
2652 * bus/policy.c (bus_policy_append_rule): fix
2654 * bus/test-main.c (main): check for memleaks
2656 * dbus/dbus-test.c (dbus_internal_do_not_use_run_tests): make
2657 test suite check for memleaks
2659 * dbus/dbus-memory.c: add support in test mode for tracking
2660 number of outstanding blocks
2662 2003-03-23 Havoc Pennington <hp@pobox.com>
2664 * bus/policy.c, bus/bus.c, bus/connection.c: implement allow/deny
2667 * dbus/dbus-hash.h: add ULONG hash keys
2669 * dbus/dbus-sysdeps.c (_dbus_get_groups): new
2670 (_dbus_get_group_id): new function
2672 2003-03-20 Havoc Pennington <hp@redhat.com>
2674 * dbus/dbus-connection.c (dbus_connection_set_unix_user_function):
2676 (dbus_connection_get_unix_user): new function
2678 2003-03-20 Havoc Pennington <hp@pobox.com>
2680 * bus/connection.c (bus_connection_send_oom_error): assert that
2681 message has a sender
2682 (connection_execute_transaction): ditto
2683 (bus_connection_preallocate_oom_error): fix to set the sender, and
2684 set recipient to the destination service, not the bus driver
2686 * bus/policy.c: hacking
2688 * dbus/dbus-message.c (dbus_message_service_is): new function
2689 (dbus_message_sender_is): new
2691 2003-03-19 Havoc Pennington <hp@redhat.com>
2693 * bus/policy.c: start sketching code for policy restrictions on
2694 what connections can do.
2696 2003-03-18 Havoc Pennington <hp@redhat.com>
2698 * doc/TODO: some notes on high-level todo items. Little nitpick
2699 stuff is all in @todo, so no need to add it here.
2701 * doc/config-file.txt: some notes on how config file might look
2703 2003-03-18 Anders Carlsson <andersca@codefactory.se>
2709 2003-03-17 Havoc Pennington <hp@redhat.com>
2711 * dbus/dbus-internals.h: add gcc attributes so that
2712 our printf-style functions warn on bad arguments to
2715 * dbus/dbus-sysdeps.c (_dbus_connect_tcp_socket): fix printf
2718 * dbus/dbus-message.c (_dbus_message_loader_queue_messages): fix
2721 2003-03-17 Havoc Pennington <hp@redhat.com>
2723 * bus/test-main.c (main): make it print something as it runs
2724 so make check doesn't look stuck
2726 * doc/negotiation.txt, doc/dbus-sasl-profile.txt: remove
2727 from CVS, now obsolete
2729 2003-03-17 Anders Carlsson <andersca@codefactory.se>
2731 * bus/dispatch.c: (bus_dispatch):
2732 Refetch the service name since it may have been reallocated
2733 when dbus_message_set_sender was called.
2735 * dbus/dbus-sysdeps.c: (_dbus_accept):
2736 Add address and address length variables and use them to stop
2737 valgrind from complaining.
2739 2003-03-17 Havoc Pennington <hp@pobox.com>
2741 All tests pass, no memleaks, no valgrind complaints.
2743 * bus/test.c: refcount handler_slot
2745 * bus/connection.c (bus_connections_new): refcount
2746 connection_data_slot
2748 * dbus/dbus-auth-script.c (_dbus_auth_script_run): delete unused
2749 bytes so that auth scripts pass.
2751 * bus/dispatch.c: init message_handler_slot so it gets allocated
2754 * bus/dispatch.c (message_handler_slot_ref): fix memleak
2756 * dbus/dbus-server-debug-pipe.c (_dbus_server_debug_pipe_new):
2757 dealloc server_pipe_hash when no longer used for benefit of
2760 * dbus/dbus-auth.c (process_command): memleak fix
2762 * bus/dispatch.c (check_hello_message): memleak fix
2764 2003-03-16 Havoc Pennington <hp@pobox.com>
2766 * dbus/dbus-bus.c (ensure_bus_data): fix double-unref of the data slot
2768 2003-03-17 Anders Carlsson <andersca@codefactory.se>
2770 * bus/activation.c (bus_activation_activate_service): Append
2771 the pending activation entry to the list of pending activations.
2773 2003-03-16 Havoc Pennington <hp@pobox.com>
2775 * bus/dispatch.c (bus_dispatch_test): remove double-unrefs of
2778 * dbus/dbus-address.c (create_entry): fix OOM handling when
2779 failing to alloc entry->method
2781 2003-03-16 Havoc Pennington <hp@pobox.com>
2783 * dbus/dbus-watch.c (_dbus_watch_new): handle failure to malloc
2786 * dbus/dbus-server-debug-pipe.c (_dbus_transport_debug_pipe_new):
2787 add some missing dbus_set_result
2789 * bus/dispatch.c (bus_dispatch_add_connection): handle failure to
2790 alloc the DBusMessageHandler
2792 * dbus/dbus-transport.c (_dbus_transport_disconnect): don't ref
2793 the transport here, since we call this from the finalizer; it
2794 resulted in a double-finalize.
2796 * dbus/dbus-transport.c (_dbus_transport_disconnect): fix a bug
2797 where we tried to use transport->connection that was NULL,
2798 happened when transport was disconnected early on due to OOM
2800 * bus/*.c: adapt to handle OOM for watches/timeouts
2802 * dbus/dbus-transport-unix.c: port to handle OOM during
2805 * dbus/dbus-auth.c (_dbus_auth_get_unused_bytes): return a
2806 reference to unused bytes instead of a copy
2808 * dbus/dbus-server.c (dbus_server_handle_watch): return FALSE for
2811 * dbus/dbus-connection.c (dbus_connection_handle_watch): return
2814 * dbus/dbus-timeout.c (dbus_timeout_handle): return FALSE for out
2817 2003-03-16 Anders Carlsson <andersca@codefactory.se>
2819 * doc/dbus-specification.sgml:
2820 Document reply message for ActivateService.
2822 2003-03-16 Anders Carlsson <andersca@codefactory.se>
2824 * bus/activation.c: (bus_pending_activation_entry_free),
2825 (bus_pending_activation_free), (bus_activation_new),
2826 (bus_activation_unref), (bus_activation_service_created),
2827 (bus_activation_activate_service):
2829 * bus/bus.c: (bus_context_new):
2830 * bus/desktop-file.c: (new_section):
2831 * bus/driver.c: (bus_driver_send_service_deleted),
2832 (bus_driver_handle_activate_service):
2833 * bus/services.c: (bus_registry_new), (bus_registry_ensure):
2835 * dbus/dbus-connection.c:
2836 (dbus_connection_send_with_reply_and_block):
2837 * dbus/dbus-message.c: (dbus_message_append_args_valist):
2838 * dbus/dbus-protocol.h:
2839 Make activation work better. Now pending activations will be queued
2840 and the daemon won't try to activate services that are already registered.
2842 2003-03-16 Havoc Pennington <hp@pobox.com>
2844 * dbus/dbus-bus.c (ensure_bus_data): handle failure to set
2847 * dbus/dbus-memory.c (_dbus_initialize_malloc_debug): support
2848 DBUS_MALLOC_BACKTRACES to print trace when failing an alloc
2850 2003-03-16 Havoc Pennington <hp@pobox.com>
2852 * dbus/dbus-string.c (_dbus_string_validate_utf8): oops, unbreak
2853 this. always run the test suite before commit...
2855 * bus/*: adapt to DBusConnection API changes
2857 * glib/dbus-gmain.c: adapt to DBusConnection API changes,
2858 requires renaming stuff to avoid dbus_connection_dispatch name
2861 * dbus/dbus-transport.c (_dbus_transport_queue_messages): new
2864 * dbus/dbus-message.c (_dbus_message_loader_queue_messages):
2865 separate from _dbus_message_loader_return_buffer()
2867 * dbus/dbus-connection.c (dbus_connection_get_n_messages): remove
2868 this, because it's now always broken to use; the number of
2869 messages in queue vs. the number still buffered by the message
2870 loader is undefined/meaningless. Should use
2871 dbus_connection_get_dispatch_state().
2872 (dbus_connection_dispatch): rename from
2873 dbus_connection_dispatch_message
2875 2003-03-16 Havoc Pennington <hp@pobox.com>
2877 * dbus/dbus-string.c (_dbus_string_validate_utf8): copy in a real
2880 2003-03-16 Anders Carlsson <andersca@codefactory.se>
2882 * dbus/dbus-connection.c:
2883 (dbus_connection_send_with_reply_and_block):
2884 Decrease connection->n_incoming when removing an entry
2886 * dbus/dbus-dict.c: (dbus_dict_entry_free),
2887 (dbus_dict_set_boolean_array), (dbus_dict_set_int32_array),
2888 (dbus_dict_set_uint32_array), (dbus_dict_set_double_array),
2889 (dbus_dict_set_byte_array), (dbus_dict_set_string_array),
2890 (dbus_dict_get_boolean_array), (dbus_dict_get_double_array),
2891 (dbus_dict_get_byte_array):
2892 Handle NULL arrays and strings. Also add support for byte arrays.
2894 * dbus/dbus-marshal.c: (_dbus_marshal_byte_array),
2895 (_dbus_marshal_dict), (_dbus_demarshal_byte_array),
2896 (_dbus_demarshal_int32_array), (_dbus_demarshal_uint32_array),
2897 (_dbus_demarshal_double_array), (_dbus_demarshal_string_array),
2898 (_dbus_demarshal_dict), (demarshal_and_validate_len),
2899 (_dbus_marshal_validate_arg), (_dbus_marshal_test):
2900 * dbus/dbus-marshal.h:
2901 Add support for marshalling and demarshalling empty arrays and strings.
2903 * dbus/dbus-message.c: (dbus_message_append_args_valist),
2904 (dbus_message_append_string_array),
2905 (dbus_message_iter_get_boolean),
2906 (dbus_message_iter_get_boolean_array),
2907 (dbus_message_iter_get_int32_array),
2908 (dbus_message_iter_get_uint32_array),
2909 (dbus_message_iter_get_double_array),
2910 (dbus_message_iter_get_byte_array),
2911 (dbus_message_iter_get_string_array), (dbus_message_iter_get_dict),
2912 (check_message_handling):
2913 Add support for getting empty arrays and dicts.
2915 * dbus/dbus-string.c: (_dbus_string_validate_utf8):
2916 Don't do any validation at all for now, that's better than just checking
2919 * test/data/valid-messages/emptiness.message:
2920 New test message with lots of empty arrays.
2922 2003-03-16 Havoc Pennington <hp@pobox.com>
2924 * dbus/dbus-connection.c
2925 (_dbus_connection_queue_received_message_link): new function that
2926 can't fail due to OOM
2928 * dbus/dbus-message.c (_dbus_message_loader_pop_message_link):
2929 new function pops a message together with a list link
2932 * dbus/dbus-transport-unix.c (queue_messages): use new link-based
2933 message queuing functions to avoid needing to alloc memory
2935 2003-03-16 Havoc Pennington <hp@pobox.com>
2937 Oops - test code was only testing failure of around 30 of the
2938 mallocs in the test path, but it turns out there are 500+
2939 mallocs. I believe this was due to misguided linking setup such
2940 that there was one copy of dbus_malloc etc. in the daemon and one
2941 in the shared lib, and only daemon mallocs were tested. In any
2942 case, the test case now tests all 500+ mallocs, and doesn't pass
2943 yet, though there are lots of fixes in this patch.
2945 * dbus/dbus-connection.c (dbus_connection_dispatch_message): fix
2946 this so that it doesn't need to allocate memory, since it
2947 has no way of indicating failure due to OOM (and would be
2948 annoying if it did).
2950 * dbus/dbus-list.c (_dbus_list_pop_first_link): new function
2952 * bus/Makefile.am: rearrange to create two self-contained
2953 libraries, to avoid having libraries with overlapping symbols.
2954 that was resulting in weirdness, e.g. I'm pretty sure there
2955 were two copies of global static variables.
2957 * dbus/dbus-internals.c: move the malloc debug stuff to
2960 * dbus/dbus-list.c (free_link): free list mempool if it becomes
2963 * dbus/dbus-memory.c (_dbus_disable_mem_pools): new function
2965 * dbus/dbus-address.c (dbus_parse_address): free list nodes
2968 * bus/dispatch.c (bus_dispatch_add_connection): free
2969 message_handler_slot when no longer using it, so
2970 memory leak checkers are happy for the test suite.
2972 * dbus/dbus-server-debug-pipe.c (debug_finalize): free server name
2974 * bus/bus.c (new_connection_callback): disconnect in here if
2975 bus_connections_setup_connection fails.
2977 * bus/connection.c (bus_connections_unref): fix to free the
2979 (bus_connections_setup_connection): if this fails, don't
2980 disconnect the connection, just be sure there are no side
2983 * dbus/dbus-string.c (undo_alignment): unbreak this
2985 * dbus/dbus-auth.c (_dbus_auth_unref): free some stuff we were
2987 (_dbus_auth_new): fix the order in which we free strings
2990 * bus/connection.c (bus_connection_disconnected): fix to
2991 not send ServiceDeleted multiple times in case of memory
2994 * dbus/dbus-bus.c (dbus_bus_get_base_service): new function to
2995 get the base service name
2996 (dbus_bus_register_client): don't return base service name,
2997 instead store it on the DBusConnection and have an accessor
2999 (dbus_bus_register_client): rename dbus_bus_register()
3001 * bus/dispatch.c (check_hello_message): verify that other
3002 connections on the bus also got the correct results, not
3003 just the one sending hello
3005 2003-03-15 Havoc Pennington <hp@pobox.com>
3007 Make it pass the Hello handling test including all OOM codepaths.
3008 Now to do other messages...
3010 * bus/services.c (bus_service_remove_owner): fix crash when
3011 removing owner from an empty list of owners
3012 (bus_registry_ensure): don't leave service in the list of
3013 a connection's owned services if we fail to put the service
3016 * bus/connection.c (bus_connection_preallocate_oom_error): set
3017 error flag on the OOM error.
3019 * dbus/dbus-connection.c (_dbus_connection_new_for_transport):
3020 handle _dbus_transport_set_connection failure
3022 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_fd): modify
3023 to create watches up front and simply enable/disable them as
3025 (unix_connection_set): this can now fail on OOM
3027 * dbus/dbus-timeout.c, dbus/dbus-watch.c: add concept
3028 of enabling/disabling a watch or timeout.
3030 * bus/loop.c (bus_loop_iterate): don't touch disabled
3033 * glib/dbus-gmain.c: adapt to enable/disable watches and timeouts
3035 2003-03-15 Havoc Pennington <hp@pobox.com>
3037 * bus/dispatch.c (bus_dispatch_test): OK, now finally actually
3038 write useful test code, after all that futzing around ;-)
3040 Test does not yet pass because we can't handle OOM in
3041 _dbus_transport_messages_pending (basically,
3042 dbus_connection_preallocate_send() does not prealloc the write
3043 watch). To fix this, I think we need to add new stuff to
3044 set_watch_functions, namely a SetEnabled function so we can alloc
3045 the watch earlier, then enable it later.
3047 * dbus/Makefile.am (libdbus_convenience_la_SOURCES): move
3048 dbus-memory.c to the convenience lib
3050 * bus/test.c: rename some static functions to keep them clearly
3051 distinct from stuff in connection.c. Handle client disconnection.
3053 2003-03-14 Havoc Pennington <hp@pobox.com>
3055 * bus/dispatch.c (bus_dispatch_test): do test using debug-pipe
3056 transport, tests more of the real codepath. Set up clients
3057 with bus_setup_debug_client.
3059 * bus/test.c (bus_setup_debug_client): function to set up debug
3060 "clients" on the main loop
3062 * dbus/dbus-transport.c (_dbus_transport_open): add debug-pipe
3065 * dbus/dbus-server.c (dbus_server_listen): add debug-pipe
3068 * dbus/dbus-server-debug.c: support a debug server based on pipes
3070 * dbus/dbus-sysdeps.c (_dbus_full_duplex_pipe): new function
3071 (_dbus_close): new function
3073 * configure.in: check for socketpair
3075 2003-03-14 Havoc Pennington <hp@redhat.com>
3077 * dbus/dbus-memory.c: add a "detect buffer overwrites on free"
3080 * dbus/dbus-transport-debug.c: rework this a good bit to be
3081 less complicated. hopefully still works.
3083 * dbus/dbus-server-debug.c (handle_new_client): remove timeout
3086 * glib/dbus-gmain.c (timeout_handler): don't remove timeout
3089 * dbus/dbus-message.c (dbus_message_copy): rename from
3090 dbus_message_new_from_message, fix it up to copy
3091 all the message fields, add test case
3093 * bus/dispatch.c (bus_dispatch_test): add some more test code,
3094 not quite passing yet
3096 2003-03-14 Havoc Pennington <hp@pobox.com>
3098 * bus/loop.c (bus_loop_iterate): add this so we can "run loop
3099 until no work remains" in test code. (the large diff here
3100 is just code movement, no actual changes)
3102 * dbus/dbus-server-debug.c (DEFAULT_INTERVAL): change interval to
3103 1, no point waiting around for test code.
3104 (_dbus_server_debug_accept_transport): unref the timeout
3105 after adding it (right?)
3107 * dbus/dbus-transport-debug.c (DEFAULT_INTERVAL): ditto
3109 2003-03-13 Havoc Pennington <hp@redhat.com>
3111 * dbus/dbus-timeout.c (_dbus_timeout_list_set_functions): handle
3114 * dbus/dbus-watch.c (_dbus_watch_list_set_functions): handle out
3117 * dbus/dbus-connection.h: Make AddWatchFunction and
3118 AddTimeoutFunction return a bool so they can fail on out-of-memory
3120 * bus/bus.c (bus_context_new): set up timeout handlers
3122 * bus/connection.c (bus_connections_setup_connection): set up
3125 * glib/dbus-gmain.c: adapt to the fact that set_functions stuff
3128 * bus/bus.c (bus_context_new): adapt to changes
3130 * bus/connection.c: adapt to changes
3132 * test/watch.c: adapt to DBusWatch changes
3134 * bus/dispatch.c (bus_dispatch_test): started adding this but
3137 2003-03-14 Anders Carlsson <andersca@codefactory.se>
3139 * bus/dispatch.c (send_service_nonexistent_error): Fix typo.
3141 2003-03-13 Havoc Pennington <hp@pobox.com>
3143 * bus/test.c, bus/test.h, bus/Makefile.am, bus/test-main.c:
3144 set up a test framework as for the library
3146 2003-03-12 Havoc Pennington <hp@pobox.com>
3148 Throughout: purge global variables, introduce BusActivation,
3149 BusConnections, BusRegistry, etc. objects instead.
3151 * bus/bus.h, bus/bus.c: introduce BusContext as a global
3154 * test/Makefile.am (TEST_BINARIES): disable bus-test for now,
3155 going to redo this a bit differently I think
3157 2003-03-12 Havoc Pennington <hp@redhat.com>
3159 Mega-patch that gets the message bus daemon initially handling
3160 out-of-memory. Work still needed. Also lots of random
3161 moving stuff to DBusError instead of ResultCode.
3163 * dbus/dbus-list.c (_dbus_list_length_is_one): new function
3165 * dbus/dbus-connection.c
3166 (dbus_connection_send_with_reply_and_block): use DBusError
3168 * dbus/dbus-bus.c: adapt to API changes, make it use DBusError not
3171 * dbus/dbus-connection.c (dbus_connection_send): drop the result
3172 code here, as the only failure possible is OOM.
3174 * bus/connection.c (bus_connection_disconnect):
3175 rename bus_connection_disconnected as it's a notification only
3177 * bus/driver.c (bus_driver_handle_acquire_service): don't free
3178 "name" on get_args failure, should be done by get_args;
3179 don't disconnect client for bad args, just return an error.
3180 (bus_driver_handle_service_exists): ditto
3182 * bus/services.c (bus_services_list): NULL-terminate returned array
3184 * bus/driver.c (bus_driver_send_service_lost)
3185 (bus_driver_send_service_acquired): send messages from driver to a
3186 specific client to the client's unique name, not to the broadcast
3189 * dbus/dbus-message.c (decode_header_data): reject messages that
3190 contain no name field
3191 (_dbus_message_get_client_serial): rename to
3192 dbus_message_get_serial and make public
3193 (_dbus_message_set_serial): rename from set_client_serial
3194 (_dbus_message_set_reply_serial): make public
3195 (_dbus_message_get_reply_serial): make public
3197 * bus/connection.c (bus_connection_foreach): allow stopping
3198 iteration by returning FALSE from foreach function.
3200 * dbus/dbus-connection.c (dbus_connection_send_preallocated)
3201 (dbus_connection_free_preallocated_send)
3202 (dbus_connection_preallocate_send): new API for sending a message
3203 without possibility of malloc failure.
3204 (dbus_connection_send_message): rename to just
3205 dbus_connection_send (and same for whole function family)
3207 * dbus/dbus-errors.c (dbus_error_free): make this reinit the error
3209 * dbus/dbus-sysdeps.c (_dbus_exit): new function
3211 * bus/activation.c: handle/return errors
3213 * dbus/dbus-errors.h: add more DBUS_ERROR #define
3215 * dbus/dbus-sysdeps.c (_dbus_directory_open) (_dbus_file_get_contents)
3216 (_dbus_directory_get_next_file): use DBusError instead of DBusResultCode
3217 (_dbus_result_from_errno): move to this file
3219 2003-03-10 Anders Carlsson <andersca@codefactory.se>
3221 * dbus/dbus-marshal.c:
3222 (_dbus_marshal_set_string):
3223 Take a length argument so we can marshal the correct string
3226 (_dbus_marshal_dict), (_dbus_demarshal_dict),
3227 (_dbus_marshal_get_arg_end_pos), (_dbus_marshal_validate_arg),
3228 (_dbus_marshal_test):
3229 * dbus/dbus-marshal.h:
3230 Add support for marshalling and demarshalling dicts.
3232 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
3233 Add support for TYPE DICT.
3235 * dbus/dbus-message.c: (set_string_field):
3236 Adjust header padding.
3238 (dbus_message_append_args_valist), (dbus_message_append_dict),
3239 (dbus_message_get_args_valist), (dbus_message_iter_get_arg_type),
3240 (dbus_message_iter_get_dict), (_dbus_message_loader_return_buffer),
3241 (check_message_handling), (check_have_valid_message):
3242 * dbus/dbus-message.h:
3243 Add functions for setting and getting dicts.
3245 * dbus/dbus-protocol.h:
3251 * doc/dbus-specification.sgml:
3252 Add information about how dicts are marshalled.
3254 * test/data/invalid-messages/dict-with-nil-value.message:
3255 * test/data/invalid-messages/too-short-dict.message:
3256 * test/data/valid-messages/dict-simple.message:
3257 * test/data/valid-messages/dict.message:
3258 Add sample messages containing dicts.
3260 2003-03-08 Anders Carlsson <andersca@codefactory.se>
3262 * dbus/dbus-dict.h: Add DBUS_END_DECLS.
3264 2003-03-07 Anders Carlsson <andersca@codefactory.se>
3267 * dbus/dbus-dict.c: (dbus_dict_entry_free), (dbus_dict_new),
3268 (dbus_dict_get_keys), (insert_entry), (dbus_dict_set_boolean),
3269 (dbus_dict_set_int32), (dbus_dict_set_uint32),
3270 (dbus_dict_set_double), (dbus_dict_set_string),
3271 (dbus_dict_set_boolean_array), (dbus_dict_set_int32_array),
3272 (dbus_dict_set_uint32_array), (dbus_dict_set_double_array),
3273 (dbus_dict_set_string_array), (_dbus_dict_test):
3275 Fix according to comments from Havoc.
3277 2003-03-06 Michael Meeks <michael@server.home>
3279 * configure.in: if we don't have kde-config, disable have_qt.
3281 2003-03-07 Anders Carlsson <andersca@codefactory.se>
3286 * dbus/dbus-dict.c: (dbus_dict_entry_free), (dbus_dict_new),
3287 (dbus_dict_ref), (dbus_dict_unref), (dbus_dict_contains),
3288 (dbus_dict_remove), (dbus_dict_get_value_type),
3289 (dbus_dict_get_keys), (dbus_dict_put_boolean),
3290 (dbus_dict_put_int32), (dbus_dict_put_uint32),
3291 (dbus_dict_put_double), (dbus_dict_put_string),
3292 (dbus_dict_put_boolean_array), (dbus_dict_put_int32_array),
3293 (dbus_dict_put_uint32_array), (dbus_dict_put_double_array),
3294 (dbus_dict_put_string_array), (dbus_dict_get_boolean),
3295 (dbus_dict_get_int32), (dbus_dict_get_uint32),
3296 (dbus_dict_get_double), (dbus_dict_get_string),
3297 (dbus_dict_get_boolean_array), (dbus_dict_get_int32_array),
3298 (dbus_dict_get_uint32_array), (dbus_dict_get_double_array),
3299 (dbus_dict_get_string_array), (_dbus_dict_test):
3301 Add DBusDict implementation
3303 * dbus/dbus-test.c: (dbus_internal_do_not_use_run_tests):
3307 2003-03-04 Havoc Pennington <hp@pobox.com>
3309 * test/data/auth/*: adapt to changes
3311 * dbus/dbus-auth-script.c (_dbus_auth_script_run): add
3312 USERID_BASE64 and change USERNAME_BASE64 to put in username not
3315 * dbus/dbus-keyring.c (_dbus_keyring_validate_context): prevent
3316 more stuff from being in a context name, to make the protocol
3317 simpler to deal with
3319 * dbus/dbus-errors.c (dbus_error_has_name): new function
3320 (dbus_error_is_set): new function
3322 * dbus/dbus-auth.c: replace DBUS_STUPID_TEST_MECH auth
3323 with DBUS_COOKIE_SHA1, implement DBUS_COOKIE_SHA1
3325 * dbus/dbus-connection.c (dbus_connection_flush): also read
3326 messages during a flush operation
3328 * dbus/Makefile.am: remove dbus-md5 since it isn't currently used.
3330 2003-03-05 Anders Carlsson <andersca@codefactory.se>
3332 * configure.in: Check for gethostbyname on Solaris.
3334 * dbus/dbus-transport.c: (_dbus_transport_open):
3335 Remove duplicate "tcp" entry.
3337 * doc/dbus-specification.sgml:
3338 Clarify some things.
3340 2003-03-05 Anders Carlsson <andersca@codefactory.se>
3342 * dbus/dbus-auth.c: (send_rejected), (process_test_subdir):
3343 * dbus/dbus-keyring.c: (_dbus_keyring_new_homedir),
3344 (_dbus_keyring_test):
3345 * dbus/dbus-md5.c: (_dbus_md5_compute):
3346 * dbus/dbus-sha.c: (_dbus_sha_compute):
3349 2003-03-05 Anders Carlsson <andersca@codefactory.se>
3351 * README: Add some things.
3353 2003-03-04 Anders Carlsson <andersca@codefactory.se>
3355 * dbus/dbus-message.c (dbus_message_append_args_valist): Add a break;
3356 after case DBUS_TYPE_BOOELAN.
3358 2003-03-02 Havoc Pennington <hp@pobox.com>
3360 * test/break-loader.c (randomly_set_extreme_ints): add test that
3361 sets really huge and small integers
3363 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): add check
3364 that length of boolean array fits in the string, and that
3365 string has room for boolean value in single-bool case.
3367 * dbus/dbus-message-builder.c (_dbus_message_data_load): add
3368 optional value to "ALIGN" command which is what to fill the
3371 * test/data/valid-messages/no-padding.message: add regression
3372 test for the message padding problem
3374 2003-03-02 Havoc Pennington <hp@pobox.com>
3376 * dbus/dbus-message.c (decode_header_data): fix to always init
3377 message_padding, from Benjamin Dauvergne
3379 2003-03-02 Havoc Pennington <hp@pobox.com>
3385 2003-03-01 Joe Shaw <joe@assbarn.com>
3387 * configure.in: Check for "struct cmsgcred" and try to access its
3388 members for BSD-like unices.
3390 * dbus/dbus-sysdeps.c (read_credentials_byte): Fold this back into
3391 _dbus_read_credentials_unix_socket().
3392 (_dbus_read_credentials_unix_socket): Use recvmsg() instead of
3393 read() for reading the credential byte off the unix socket. Use
3394 struct cmsgcred on systems that support it.
3396 2003-02-27 Alexander Larsson <alexl@redhat.com>
3400 Make gthreads-2.0 dependency optional. Don't build thread test if
3403 2003-02-27 Havoc Pennington <hp@pobox.com>
3405 * dbus/dbus-connection.c
3406 (dbus_connection_send_message_with_reply_and_block): fix doh!
3407 doh! doh! bug that resulted in never removing a reply from the
3408 queue, no wonder we called get_reply_serial so much ;-)
3410 * dbus/dbus-message.c (struct DBusMessage): cache reply serial
3411 and client serial instead of demarshaling them every time
3413 2003-02-27 Havoc Pennington <hp@pobox.com>
3415 * dbus/dbus-marshal.c (_dbus_demarshal_int32): rewrite to be much
3416 more inlined, using dbus-string-private.h, speeds things up
3419 * dbus/dbus-string.c (_dbus_string_free): apply align offset
3420 when freeing the string
3421 (_dbus_string_steal_data): fix for align offset
3422 (undo_alignment): new function
3424 2003-02-26 Havoc Pennington <hp@redhat.com>
3426 All kinds of audit fixes from Owen, plus initial attempt to
3427 handle unaligned memory returned from malloc.
3429 * dbus/dbus-string.c (_dbus_string_init): clamp max length to
3430 leave room for align_offset and nul byte
3431 (fixup_alignment): function to track an align_offset and
3432 ensure real->str is aligned
3433 (DBUS_GENERIC_STRING_PREAMBLE): len must be less than allocated,
3434 to allow a nul byte plus align offset
3435 (_dbus_string_lock): fix overflow issue
3436 (_dbus_string_init_const_len): add assertions on sanity of len,
3437 assign allocated to be ALLOCATION_PADDING larger than len
3438 (set_length): fixup the overflow handling
3439 (_dbus_string_get_data_len): fix overflow in assertion
3440 (open_gap): detect overflow in size of gap to be opened
3441 (_dbus_string_lengthen): add overflow check
3442 (_dbus_string_align_length): fix overflow with _DBUS_ALIGN_VALUE
3443 (_dbus_string_append): add overflow check
3444 (_dbus_string_append_unichar): overflow
3445 (_dbus_string_delete): fix overflow in assertion
3446 (_dbus_string_copy_len): overflow in assertion
3447 (_dbus_string_replace_len): overflows in assertions
3448 (_dbus_string_find): change to implement in terms of
3449 _dbus_string_find_to
3450 (_dbus_string_find_to): assorted fixage
3451 (_dbus_string_equal_c_str): assert c_str != NULL,
3452 fix logic so the function works
3453 (_dbus_string_ends_with_c_str): fix overflow thingy
3454 (_dbus_string_base64_encode): overflow fix
3455 (_dbus_string_validate_ascii): overflow
3456 (_dbus_string_validate_nul): overflow
3458 2003-02-26 Havoc Pennington <hp@redhat.com>
3460 * dbus/dbus-marshal.c (_dbus_marshal_test): fix to work with DISABLE_ASSERTS
3462 2003-02-26 Alexander Larsson <alexl@redhat.com>
3465 Set DBUS_GLIB_THREADS_LIBS for apps using gthread-2.0
3467 * dbus/dbus-connection.c:
3468 * dbus/dbus-connection.h:
3469 Fix _dbus_connection_acquire_io_path and _dbus_connection_acquire_dispatch.
3470 Add dbus_connection_set_wakeup_main_function and use it when queueing
3471 incoming and outgoing messages.
3474 * dbus/dbus-dataslot.c:
3475 Threadsafe usage of DBusDataSlotAllocator
3477 * dbus/dbus-message.c: (dbus_message_get_args_iter):
3480 * dbus/dbus-server-unix.c:
3483 * glib/dbus-gmain.c:
3484 Implement the new wakeup functions for glib.
3487 * glib/test-thread-client.c:
3488 * glib/test-thread-server.c:
3489 * glib/test-thread.h:
3490 Initial cut at some thread test code. Not really done yet.
3492 2003-02-26 Havoc Pennington <hp@pobox.com>
3494 * dbus/dbus-connection.c
3495 (dbus_connection_send_message_with_reply_and_block): fix crash
3496 where we ref'd the outgoing message instead of the returned reply
3498 * dbus/dbus-transport-unix.c (do_authentication): check read watch
3499 at the end of this function, so if we didn't need to read for
3500 authentication, we reinstall it for receiving messages
3502 * dbus/dbus-message.c (dbus_message_new_reply): allow replies to
3503 a NULL sender for peer-to-peer case
3505 * dbus/dbus-transport-unix.c (check_read_watch): handle
3506 !authenticated case correctly
3508 * glib/dbus-gmain.c: add support for DBusServer
3510 * dbus/dbus-server.c: add data slot support
3512 * glib/dbus-gmain.c (dbus_connection_setup_with_g_main): check
3513 return values and handle errors
3515 * dbus/dbus-dataslot.c: factor out the data slot stuff from
3518 * Doxyfile.in (INPUT): add glib subdir
3520 * glib/dbus-gmain.c (dbus_connection_setup_with_g_main): rename
3521 setup_with_g_main instead of hookup_with_g_main; write docs
3523 2003-02-24 Anders Carlsson <andersca@codefactory.se>
3525 * dbus/dbus-marshal.c: (_dbus_marshal_validate_arg):
3526 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
3527 * dbus/dbus-message.c: (dbus_message_append_boolean),
3528 (dbus_message_append_boolean_array),
3529 (dbus_message_get_args_valist), (_dbus_message_test):
3530 * dbus/dbus-message.h:
3531 * doc/dbus-specification.sgml:
3532 Various fixes as pointed out by Havoc.
3534 * test/data/invalid-messages/bad-boolean-array.message:
3535 * test/data/invalid-messages/bad-boolean.message:
3536 Add invalid boolean value test cases.
3538 2003-02-24 Anders Carlsson <andersca@codefactory.se>
3540 * dbus/dbus-internals.c: (_dbus_type_to_string):
3541 * dbus/dbus-marshal.c: (_dbus_marshal_get_arg_end_pos),
3542 (_dbus_marshal_validate_arg):
3543 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
3544 * dbus/dbus-message.c: (dbus_message_append_args_valist),
3545 (dbus_message_append_boolean), (dbus_message_append_boolean_array),
3546 (dbus_message_get_args_valist), (dbus_message_iter_get_boolean),
3547 (dbus_message_iter_get_int32), (dbus_message_iter_get_uint32),
3548 (dbus_message_iter_get_double),
3549 (dbus_message_iter_get_boolean_array), (message_iter_test):
3550 * dbus/dbus-message.h:
3551 * dbus/dbus-protocol.h:
3552 * doc/dbus-specification.sgml:
3553 * test/data/valid-messages/lots-of-arguments.message:
3554 Add support for boolean and boolean array types.
3556 2003-02-23 Havoc Pennington <hp@pobox.com>
3558 * dbus/dbus-keyring.c: finish most of this implementation and
3561 * dbus/dbus-errors.c (dbus_set_error_const, dbus_set_error): make
3562 these barf if the error isn't cleared to NULL
3564 * dbus/dbus-sysdeps.c (_dbus_delete_file): set error on failure
3565 (_dbus_create_directory): new function
3567 * dbus/dbus-errors.c (dbus_set_error): fix warning
3569 * dbus/dbus-string.c (_dbus_string_hex_encode): new function
3570 (_dbus_string_hex_decode): new function
3571 (test_hex_roundtrip): test code
3573 * dbus/dbus-sha.c (_dbus_sha_compute): use dbus_string_hex_encode
3575 * dbus/dbus-md5.c (_dbus_md5_compute): use dbus_string_hex_encode
3577 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): make this use
3578 the save-to-temp/rename trick to atomically write the new file
3579 (_dbus_string_parse_uint): new function
3581 2003-02-22 Havoc Pennington <hp@pobox.com>
3583 * test/Makefile.am (dist-hook): fix dist for test/data/sha-1
3585 2003-02-22 Havoc Pennington <hp@pobox.com>
3587 * dbus/dbus-message.c (dbus_message_iter_get_string_array):
3588 (dbus_message_iter_get_byte_array): Fix up doxygen warnings
3590 * dbus/dbus-sha.c: add implementation of SHA-1 algorithm
3592 * dbus/test/data/sha-1: add US government test suite for SHA-1
3594 2003-02-21 Anders Carlsson <andersca@codefactory.se>
3596 * dbus/dbus-marshal.c: (_dbus_demarshal_string_array):
3597 Make string arrays NULL-terminated.
3599 * dbus/dbus-memory.c: (dbus_free_string_array):
3600 * dbus/dbus-memory.h:
3601 New function for freeing NULL-terminated string arrays.
3603 * dbus/dbus-message-builder.c: (append_quoted_string),
3604 (_dbus_message_data_load):
3605 Add support for array types.
3607 * dbus/dbus-message.c: (check_message_handling):
3608 Add more types as test cases.
3610 * dbus/dbus-sysdeps.c: (_dbus_string_parse_int),
3611 (_dbus_string_parse_double):
3612 Add the start offset to the end offset.
3614 * test/data/valid-messages/lots-of-arguments.message:
3615 New test message with lots of arguments.
3617 2003-02-21 Anders Carlsson <andersca@codefactory.se>
3619 * dbus/dbus-message.c: (dbus_message_append_nil),
3620 (dbus_message_append_int32), (dbus_message_append_uint32),
3621 (dbus_message_append_double), (dbus_message_append_string),
3622 (dbus_message_append_int32_array),
3623 (dbus_message_append_uint32_array),
3624 (dbus_message_append_double_array),
3625 (dbus_message_append_byte_array),
3626 (dbus_message_append_string_array):
3627 Fix all out-of-memory handling in these functions.
3629 2003-02-21 Anders Carlsson <andersca@codefactory.se>
3631 * dbus/dbus-message.c: (dbus_message_append_nil):
3634 2003-02-21 Anders Carlsson <andersca@codefactory.se>
3636 * dbus/dbus-message.c: (dbus_message_append_args_valist),
3637 (dbus_message_append_nil), (dbus_message_append_int32_array),
3638 (dbus_message_append_uint32_array),
3639 (dbus_message_append_double_array),
3640 (dbus_message_append_byte_array),
3641 (dbus_message_append_string_array), (dbus_message_get_args_valist),
3642 (dbus_message_iter_get_int32_array),
3643 (dbus_message_iter_get_uint32_array),
3644 (dbus_message_iter_get_double_array),
3645 (dbus_message_iter_get_byte_array),
3646 (dbus_message_iter_get_string_array):
3648 * dbus/dbus-message.h:
3649 Add functions for appending and getting arrays.
3651 2003-02-21 Anders Carlsson <andersca@codefactory.se>
3653 * dbus/dbus-mempool.c (_dbus_mem_pool_new): Make the
3654 element size at least 8 bytes, fixes mempool tests on
3657 2003-02-20 Alexander Larsson <alexl@redhat.com>
3659 * dbus/dbus-transport-unix.c (unix_do_iteration):
3660 Unlock the connection mutex during a blocking select call.
3661 Add todo about how we need a way to wake up the select.
3663 * dbus/dbus-connection-internal.h:
3664 * dbus/dbus-connection.c:
3665 Add _dbus_connection_lock and _dbus_connection_unlock.
3667 2003-02-19 Havoc Pennington <hp@pobox.com>
3669 * Doxyfile.in (PREDEFINED): put DOXYGEN_SHOULD_SKIP_THIS in
3670 Doxyfile.in, not Doxyfile
3672 * dbus/dbus-keyring.c: do some hacking on this
3674 * dbus/dbus-sysdeps.c (_dbus_delete_file): new
3676 * dbus/dbus-errors.c (dbus_set_error_const): do not call
3678 (dbus_set_error): remove dbus_error_init, check for message ==
3679 NULL *before* we sprintf into it, and add @todo about including
3680 system headers in this file
3682 * dbus/dbus-sysdeps.c (_dbus_create_file_exclusively): new
3684 * dbus/dbus-errors.h (DBUS_ERROR_FAILED): add
3686 * dbus/dbus-sysdeps.c (get_user_info): break this function out to
3687 get various bits of user information based on either username
3689 (_dbus_homedir_from_username): new function
3691 2003-02-19 Anders Carlsson <andersca@codefactory.se>
3694 Add check for nonposix getpwnam_r
3696 * dbus/dbus-mempool.c: (_dbus_mem_pool_new):
3697 Align the pool element size to a sizeof (void *) boundary.
3699 * dbus/dbus-sysdeps.c: (_dbus_setenv), (_dbus_connect_unix_socket),
3700 (_dbus_listen_unix_socket), (_dbus_credentials_from_username):
3701 General Solaris fixes.
3703 * test/data/valid-messages/simplest-manual.message:
3704 Explicitly state that we want little-endian packing.
3706 2003-02-19 Mikael Hallendal <micke@codefactory.se>
3708 * dbus/dbus-server.c (dbus_server_listen): Support tcp: addresses.
3710 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_tcp_socket):
3711 Added to create a transport connecting using a tcp/ip socket.
3713 * dbus/dbus-sysdeps.c (_dbus_connect_tcp_socket): Added to connect
3714 to a tcp socket at given host and port.
3715 (_dbus_listen_tcp_socket): added to listen on tcp socket for given
3718 * dbus/dbus-server.c (dbus_server_listen): Support tcp: addresses.
3720 * dbus/dbus-server-unix.c (_dbus_server_new_for_tcp_socket):
3721 Added to create a server listening on a TCP/IP socket.
3723 2003-02-19 Havoc Pennington <hp@pobox.com>
3725 Throughout: mop up all the Doxygen warnings and undocumented
3728 * dbus/dbus-sysdeps.c (do_exec): do not use execvp, we don't want
3729 to search any paths.
3731 * dbus/dbus-threads.c: move global mutex initializers to
3732 dbus-internals.h, multiple prototypes was confusing doxygen
3733 besides being kind of ugly
3735 * Doxyfile (PREDEFINED): have Doxygen define
3736 DOXYGEN_SHOULD_SKIP_THIS so we can exclude things from
3737 docs with #ifndef DOXYGEN_SHOULD_SKIP_THIS
3738 (do not abuse the feature! it's for stuff like the autogenerated
3739 macros in dbus-md5.c, not just for things you don't feel like
3742 2003-02-18 Havoc Pennington <hp@pobox.com>
3744 * dbus/dbus-string.c (_dbus_string_zero): new function
3746 * dbus/dbus-md5.c: include MD5 implementation by L. Peter Deutsch,
3747 wrap it in some dbus-friendly API
3749 * dbus/dbus-types.h: add 16-bit types
3751 2003-02-18 Joe Shaw <joe@assbarn.com>
3753 * dbus/dbus-auth.c (handle_server_data_stupid_test_mech): Just get
3754 credentials from our currently running process.
3755 (get_word): Fix a buglet where we were copying the entire length
3756 instead of relative to our position.
3758 * dbus/dbus-hash.c (_dbus_hash_test): Don't try to allocate the
3759 keys on the stack... it's 640k of data.
3761 * dbus/dbus-sysdeps.c (_dbus_read_credentials_unix_socket): Always
3762 read the credentials byte off the socket, even if we don't have
3764 (_dbus_poll): Implement poll() using select() for systems which
3767 * glib/test-dbus-glib.c (main): Print out an error if no
3768 parameters are given.
3770 * test/data/auth/fallback.auth-script: Added. Tests that a client
3771 can fallback to a secondary auth mechanism if the first fails.
3773 2003-02-18 Havoc Pennington <hp@pobox.com>
3777 2003-02-17 Havoc Pennington <hp@pobox.com>
3779 * doc/dbus-specification.sgml: lots of cosmetic
3780 cleanups/rearrangement, add assorted FIXME, change DBUS_ADDRESS
3781 env variable to DBUS_BUS_ADDRESS, s/client/application/,
3782 s/server/bus/ (except in authentication section). Add a section
3783 "Message Bus Message Routing"
3785 2003-02-17 Anders Carlsson <andersca@codefactory.se.>
3791 2003-02-17 Anders Carlsson <andersca@codefactory.se>
3793 * doc/dbus-specification.sgml:
3794 Specification updates.
3796 2003-02-17 Anders Carlsson <andersca@codefactory.se>
3798 * bus/activation.c: (bus_activation_init), (child_setup),
3799 (bus_activation_activate_service):
3801 * bus/main.c: (main):
3802 Set DBUS_ADDRESS environment variable.
3804 * dbus/dbus-errors.c: (dbus_set_error):
3805 Don't use va_copy since that's a C99 feature.
3807 * dbus/dbus-sysdeps.c: (_dbus_setenv), (do_exec),
3808 (_dbus_spawn_async):
3809 * dbus/dbus-sysdeps.h:
3810 Add child_setup_func to _dbus_spawn_async.
3812 * doc/dbus-specification.sgml:
3813 Update specification.
3815 * test/spawn-test.c: (setup_func), (main):
3818 2003-02-17 Alexander Larsson <alexl@redhat.com>
3820 * dbus/dbus-connection.c (_dbus_connection_handler_destroyed_locked):
3823 2003-02-17 Anders Carlsson <andersca@codefactory.se>
3827 * doc/dbus-test-plan.sgml:
3828 Add test plan document.
3833 2003-02-17 Anders Carlsson <andersca@codefactory.se>
3835 * dbus/dbus-message.c: (decode_header_data),
3836 (_dbus_message_loader_return_buffer):
3837 Set the header padding amount when loading a message.
3839 2003-02-16 Anders Carlsson <andersca@codefactory.se>
3841 * bus/dispatch.c: (send_one_message):
3842 Only send broadcast messages to registered connections.
3844 * dbus/dbus-message.c: (dbus_message_name_is):
3845 * dbus/dbus-message.h:
3846 New convenience function.
3848 * dbus/dbus-transport-debug.c: (do_reading):
3849 Only dispatch one message per run.
3852 * test/bus-test.c: (new_connection_callback), (die),
3853 (test_hello_client1_handler), (test_hello_client2_handler),
3854 (test_hello_replies), (main):
3856 * test/bus-test-loop.[ch]:
3859 2003-02-16 Havoc Pennington <hp@pobox.com>
3861 * dbus/dbus-connection.c (dbus_connection_dispatch_message): fix
3862 backward conditional
3864 2003-02-16 Alexander Larsson <alexl@redhat.com>
3866 * dbus/dbus-connection.c:
3867 Implement sent_message_with_reply. (with_reply_and block is still
3869 Made dispatch_message not lose message if OOM.
3871 * dbus/dbus-errors.h:
3872 Add NoReply error (for reply timeouts).
3874 2003-02-16 Alexander Larsson <alexl@redhat.com>
3876 * dbus/dbus-hash.c (_dbus_hash_table_unref):
3877 Actually free keys and values when destroying hashtable.
3879 2003-02-16 Anders Carlsson <andersca@codefactory.se>
3881 * dbus/dbus-auth.c: (client_try_next_mechanism):
3884 * dbus/dbus-threads.c: (dbus_condvar_wait_timeout):
3885 Return TRUE if there's no thread implementation around.
3887 * glib/dbus-gmain.c: (free_source),
3888 (dbus_connection_hookup_with_g_main):
3889 Make sure to remove the GSource when the connection is finalized.
3891 2003-02-16 Anders Carlsson <andersca@codefactory.se>
3893 * bus/dispatch.c: (bus_dispatch_message_handler):
3894 * dbus/dbus-errors.h:
3895 Return an error if someone tries to send a message to a service
3898 2003-02-16 Anders Carlsson <andersca@codefactory.se>
3900 * bus/activation.c: (load_directory), (bus_activation_init),
3901 (bus_activation_activate_service):
3904 (bus_driver_handle_activate_service), (bus_driver_handle_message):
3905 More work on the activation handling.
3907 * dbus/dbus-errors.h:
3908 Add some error messages
3910 * dbus/dbus-message.c: (dbus_message_new_error_reply):
3911 * dbus/dbus-message.h:
3912 New function that creates an error message.
3914 * dbus/dbus-protocol.h:
3915 Add ACTIVATE_SERVER message.
3917 * dbus/dbus-server-unix.c: (unix_handle_watch),
3918 (_dbus_server_new_for_domain_socket):
3919 Call _dbus_fd_set_close_on_exec.
3921 * dbus/dbus-sysdeps.c: (make_pipe), (do_exec),
3922 (_dbus_spawn_async), (_dbus_disable_sigpipe),
3923 (_dbus_fd_set_close_on_exec):
3924 * dbus/dbus-sysdeps.h:
3925 Add _dbus_fd_set_close_on exec function. Also add function that checks
3926 that all open fds are set to close-on-exec and warns otherwise.
3928 * dbus/dbus-transport-unix.c:
3929 (_dbus_transport_new_for_domain_socket):
3930 Call _dbus_fd_set_close_on_exec.
3932 2003-02-16 Havoc Pennington <hp@pobox.com>
3934 * dbus/dbus-connection.c (dbus_connection_set_change_sigpipe):
3935 allow people to avoid setting SIGPIPE to SIG_IGN
3936 (_dbus_connection_new_for_transport): disable SIGPIPE unless
3937 we've been asked not to
3939 2003-02-15 Anders Carlsson <andersca@codefactory.se>
3941 * dbus/dbus-list.c: (_dbus_list_append_link),
3942 (_dbus_list_prepend_link):
3943 * dbus/dbus-memory.c: (dbus_malloc), (dbus_malloc0),
3947 2003-02-15 Anders Carlsson <andersca@codefactory.se>
3950 * bus/activation.c: (bus_activation_entry_free),
3951 (add_desktop_file_entry), (load_directory), (bus_activation_init):
3953 * bus/main.c: (main):
3954 Add simple activation support, doesn't work yet though.
3956 2003-02-15 Zack Rusin <zack@kde.org>
3958 * qt/dbus-qthread.cpp: small casting fix
3960 2003-02-15 Anders Carlsson <andersca@codefactory.se>
3962 * dbus/dbus-errors.c: (dbus_set_error):
3963 * dbus/dbus-errors.h:
3964 Add a few errors and make dbus_set_error void.
3966 * dbus/dbus-sysdeps.c:
3967 (_dbus_errno_to_string), (close_and_invalidate), (make_pipe),
3968 (write_err_and_exit), (read_ints), (do_exec), (_dbus_spawn_async):
3969 * dbus/dbus-sysdeps.h:
3970 Add _dbus_spawn_async.
3972 * test/spawn-test.c: (main):
3973 Test for _dbus_spawn_async.
3975 2003-02-15 Anders Carlsson <andersca@codefactory.se>
3977 * dbus/dbus-internals.h:
3978 Fix build without tests.
3980 * dbus/dbus-list.c: (alloc_link):
3981 Fix a segfault when a malloc fails.
3983 * dbus/dbus-memory.c: (initialize_malloc_debug), (dbus_malloc),
3984 (dbus_malloc0), (dbus_realloc):
3985 Add support for malloc debugging.
3987 2003-02-15 Alexander Larsson <alexl@redhat.com>
3989 * dbus/dbus-threads.c:
3990 * dbus/dbus-threads.h:
3991 Add condvars. Remove static mutext from API.
3992 Implement static mutexes by initializing them from threads_init.
3994 * glib/dbus-gthread.c:
3995 * qt/dbus-qthread.cpp:
3996 Update with the thread api changes.
4001 Turn StaticMutex into normal mutex + init function.
4002 Export new functions _dbus_list_alloc_link, _dbus_list_free_link,
4003 _dbus_list_append_link, _dbus_list_prepend_link
4006 * dbus/dbus-sysdeps.c:
4007 * dbus/dbus-sysdeps.h:
4008 New type dbus_atomic_t, and new functions _dbus_atomic_inc,
4009 _dbus_atomic_dec. Only slow fallback implementation at the moment.
4011 * dbus/dbus-protocol.h:
4012 Add DBUS_MESSAGE_LOCAL_DISCONNECT define
4014 * dbus/dbus-message.c:
4015 Make ref/unref atomic.
4018 * dbus/dbus-connection-internal.h:
4019 * dbus/dbus-connection.c:
4020 * dbus/dbus-connection.h:
4022 Change _peek to _borrow,_return & _steal_borrowed.
4023 Change disconnect callback to event.
4024 Make dbus_connection_dispatch_messages reentrant.
4026 * dbus/dbus-transport.c:
4027 Don't ref the connection on calls to the transport
4030 * dbus/dbus-message-handler.c:
4033 * glib/dbus-gmain.c:
4034 Don't use peek_message anymore
4037 * test/debug-thread.c:
4038 * test/debug-thread.h:
4039 Simple thread implementation that asserts() on deadlocks in
4040 single-threaded code.
4043 (main) Call debug_threads_init.
4046 Use disconnect message instead of disconnect callback.
4050 Don't call dbus_connection_set_disconnect_function. Instead export
4051 bus_connection_disconnect.
4054 Call bus_connection_disconnect when we get a disconnected message.
4056 2003-02-15 Havoc Pennington <hp@pobox.com>
4058 * dbus/dbus-message.c (dbus_message_new): fool around with the
4061 2003-02-14 Havoc Pennington <hp@pobox.com>
4063 * dbus/dbus-mempool.c: fail if the debug functions so indicate
4065 * dbus/dbus-memory.c: fail if the debug functions indicate we
4068 * dbus/dbus-internals.c (_dbus_set_fail_alloc_counter)
4069 (_dbus_decrement_fail_alloc_counter): debug functions to
4070 simulate memory allocation failures
4072 2003-02-14 Havoc Pennington <hp@pobox.com>
4074 * dbus/dbus-errors.h (struct DBusError): add a word of padding
4077 2003-02-13 Anders Carlsson <andersca@codefactory.se>
4079 * bus/driver.c: (bus_driver_handle_hello):
4081 * bus/services.c: (bus_service_lookup):
4082 Reorder message sending so we get a more sane order.
4084 * test/bus-test.c: (message_handler):
4087 2003-02-13 Anders Carlsson <andersca@codefactory.se>
4089 * bus/driver.c: (bus_driver_send_service_deleted),
4090 (bus_driver_send_service_created), (bus_driver_send_service_lost),
4091 (bus_driver_send_service_acquired), (bus_driver_handle_hello),
4092 (bus_driver_send_welcome_message),
4093 (bus_driver_handle_list_services),
4094 (bus_driver_handle_acquire_service),
4095 (bus_driver_handle_service_exists):
4096 * dbus/dbus-bus.c: (dbus_bus_register_client),
4097 (dbus_bus_acquire_service), (dbus_bus_service_exists):
4098 * dbus/dbus-errors.c: (dbus_result_to_string):
4099 * dbus/dbus-errors.h:
4100 * dbus/dbus-message.c: (dbus_message_append_args),
4101 (dbus_message_append_args_valist), (dbus_message_get_args),
4102 (dbus_message_get_args_valist), (dbus_message_get_args_iter),
4103 (dbus_message_iter_get_arg_type), (dbus_message_iter_get_string),
4104 (dbus_message_iter_get_byte_array),
4105 (dbus_message_iter_get_string_array), (message_iter_test),
4106 (check_message_handling), (_dbus_message_test):
4107 * dbus/dbus-message.h:
4108 * test/bus-test.c: (main):
4109 Change fields to arguments in messages, so that they won't be
4110 confused with header fields.
4112 * glib/test-dbus-glib.c: (main):
4113 Remove append_fields from hello message.
4115 2003-02-13 Anders Carlsson <andersca@codefactory.se>
4117 * dbus/dbus-errors.c:
4118 * dbus/dbus-message.c:
4119 * dbus/dbus-string.c:
4120 Documentation fixes.
4122 2003-02-13 Anders Carlsson <andersca@codefactory.se>
4124 * glib/dbus-gmain.c: (timeout_handler), (add_timeout),
4126 Implement support for timeouts in dbus-glib.
4128 2003-02-13 Anders Carlsson <andersca@codefactory.se>
4130 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
4131 * dbus/dbus-message.c: (process_test_subdir):
4132 * test/break-loader.c: (find_breaks_based_on):
4133 Plug some memory leaks.
4135 2003-02-13 Richard Hult <rhult@codefactory.se>
4137 * bus/main.c: Fix build.
4139 * dbus/dbus-errors.h:
4140 * dbus/dbus-errors.c: Fix copyright for Anders.
4142 2003-02-13 Anders Carlsson <andersca@codefactory.se>
4147 * bus/connection.c: (bus_connection_foreach):
4150 * bus/desktop-file.c: (grow_lines_in_section), (grow_sections),
4151 (unescape_string), (new_section), (parse_section_start),
4152 (parse_key_value), (report_error), (bus_desktop_file_load),
4153 (bus_desktop_file_get_string):
4154 * bus/desktop-file.h:
4155 Use DBusError for error reporting.
4157 * bus/dispatch.c: (send_one_message),
4158 (bus_dispatch_message_handler):
4159 * bus/driver.c: (bus_driver_send_service_deleted),
4160 (bus_driver_send_service_created), (bus_driver_send_service_lost),
4161 (bus_driver_send_service_acquired), (bus_driver_handle_hello),
4162 (bus_driver_send_welcome_message),
4163 (bus_driver_handle_list_services),
4164 (bus_driver_handle_acquire_service),
4165 (bus_driver_handle_service_exists):
4166 * bus/loop.c: (bus_loop_run):
4168 Use BUS_HANDLE_OOM instead of _DBUS_HANDLE_OOM.
4170 * bus/utils.c: (bus_wait_for_memory):
4172 New files with general utility functions.
4174 * dbus/dbus-internals.h:
4175 Remove _DBUS_HANDLE_OOM.
4177 2003-02-13 Anders Carlsson <andersca@codefactory.se>
4179 * dbus/dbus-errors.c: (dbus_result_to_string), (dbus_error_init),
4180 (dbus_error_free), (dbus_set_error_const), (dbus_set_error):
4181 * dbus/dbus-errors.h:
4182 Add DBusError structure.
4184 2003-02-13 Anders Carlsson <andersca@codefactory.se>
4186 * test/data/valid-messages/standard-acquire-service.message:
4187 * test/data/valid-messages/standard-hello.message:
4188 * test/data/valid-messages/standard-list-services.message:
4189 * test/data/valid-messages/standard-service-exists.message:
4190 Add some standard messages.
4192 2003-02-13 Anders Carlsson <andersca@codefactory.se>
4194 * bus/driver.c: (bus_driver_send_welcome_message),
4195 (bus_driver_handle_list_services),
4196 (bus_driver_handle_acquire_service),
4197 (bus_driver_handle_service_exists), (bus_driver_handle_message):
4198 Update for API changes in libdbus.
4200 * dbus/dbus-message.c: (dbus_message_new_reply):
4201 * dbus/dbus-message.h:
4202 Remove the name argument. The spec states that replies shouldn't
4205 2003-02-13 Anders Carlsson <andersca@codefactory.se>
4207 * bus/desktop-file.c: (parse_section_start), (parse_key_value),
4208 (report_error), (bus_desktop_file_load), (lookup_section),
4209 (lookup_line), (bus_desktop_file_get_raw),
4210 (bus_desktop_file_get_string):
4211 * bus/desktop-file.h:
4212 Some fixes, and new functions for getting a key value from a section.
4214 2003-02-13 Havoc Pennington <hp@pobox.com>
4216 * test/data/auth/fail-after-n-attempts.auth-script: new test
4218 * dbus/dbus-auth.c (send_rejected): shutdown_mech() when we
4221 2003-02-13 Havoc Pennington <hp@pobox.com>
4223 * dbus/dbus-auth.c (handle_server_data_external_mech): args to
4224 dbus_credentials_match were backward
4226 * dbus/dbus-auth-script.c (_dbus_auth_script_run): support
4227 NO_CREDENTIALS and ROOT_CREDENTIALS
4229 * dbus/dbus-auth.c (_dbus_auth_do_work): move get_state() routine
4230 into here. Never process more commands after we've reached an
4231 end state; store further data as unused bytes.
4233 * test/data/auth/*: add more auth tests
4235 * dbus/dbus-auth-script.c (_dbus_auth_script_run): support EXPECT
4236 command to match exact string and EXPECT_UNUSED to match unused
4239 * test/Makefile.am (dist-hook): fix to dist all the test stuff
4241 2003-02-12 Havoc Pennington <hp@pobox.com>
4243 * dbus/dbus-string.c (_dbus_string_pop_line): fix to also strip
4244 \r off of popped lines
4246 * dbus/dbus-auth.c (_dbus_auth_test): write code to run auth
4249 * dbus/dbus-auth-script.c (_dbus_auth_script_run): when doing a
4252 2003-02-12 Havoc Pennington <hp@pobox.com>
4254 * dbus/Makefile.am: remove break-loader from the build, since it
4257 * configure.in: add --enable-gcov to turn on coverage profiling
4258 flags and disable optimization
4260 2003-02-10 Havoc Pennington <hp@pobox.com>
4262 * dbus/dbus-auth-script.c, dbus/dbus-auth-script.h: sync
4263 initial cut at test framework for DBusAuth from laptop.
4264 Doesn't quite work yet but it compiles and I need to get
4265 it off the 266mhz laptop. ;-)
4267 * dbus/dbus-server-debug.c (_dbus_server_debug_accept_transport):
4268 fix a memleak in error case
4270 2003-02-12 Anders Carlsson <andersca@codefactory.se>
4273 * bus/desktop-file.c:
4274 * bus/desktop-file.h:
4275 Add a desktop file parser.
4277 2003-02-11 Zack Rusin <zack@kde.org>
4279 * qt/message.[h|cpp]: sample implementation
4280 of the KDE wrapper for DBusMessage
4282 2003-02-09 Zack Rusin <zack@kde.org>
4284 * test/bus-test.c: make_it_compile
4285 * doc/dbus-specification.sgml: minimal semantic fix
4287 2003-02-06 Anders Carlsson <andersca@codefactory.se>
4293 2003-02-06 Anders Carlsson <andersca@codefactory.se>
4296 * dbus/dbus-break-loader.c:
4298 * test/break-loader.c:
4299 Move dbus-break-loader to test/ and rename it to break-loader.
4301 2003-02-02 Havoc Pennington <hp@pobox.com>
4303 * dbus/dbus-keyring.c, dbus/dbus-keyring.h: template files
4304 for code to manage cookies in your home directory
4306 * dbus/dbus-sysdeps.c (_dbus_generate_random_bytes): new function
4308 * dbus/dbus-auth.c (get_state): impose a maximum number of tries
4309 to authenticate, then disconnect the client.
4311 2003-02-03 Alexander Larsson <alexl@redhat.com>
4313 * dbus/dbus-message.c (dbus_message_append_fields):
4316 2003-02-02 Anders Carlsson <andersca@codefactory.se>
4318 * doc/dbus-specification.sgml:
4319 Update address format section.
4321 2003-02-02 Anders Carlsson <andersca@codefactory.se>
4324 * test/bus-test.c: (get_time), (add_timeout), (remove_timeout),
4325 (message_handler), (new_connection_callback), (loop_quit),
4329 2003-02-02 Anders Carlsson <andersca@codefactory.se>
4331 * bus/driver.c: (bus_driver_handle_service_exists):
4332 Simplify the code a bit.
4334 * dbus/dbus-bus.c: (dbus_bus_service_exists):
4337 2003-02-02 Anders Carlsson <andersca@codefactory.se>
4340 Add libdbus-daemon.la and link to it.
4342 2003-02-01 James Willcox <jwillcox@gnome.org>
4344 * bus/driver.c: (bus_driver_handle_own_service):
4345 Actually include the service reply code in the message.
4347 2003-02-02 Anders Carlsson <andersca@codefactory.se>
4349 * bus/driver.c: (bus_driver_handle_service_exists):
4350 Don't unref the incoming message.
4352 2003-02-02 Anders Carlsson <andersca@codefactory.se>
4354 * dbus/dbus.h: Add dbus-address.h and dbus-bus.h
4356 2003-02-02 Anders Carlsson <andersca@codefactory.se>
4358 * dbus/dbus-server.c: (dbus_server_listen):
4359 * dbus/dbus-transport.c: (_dbus_transport_open):
4360 ifdef out the calls to the debug transport and server.
4362 2003-02-02 Alexander Larsson <alexl@redhat.com>
4364 * dbus/dbus-watch.c (dbus_watch_get_flags):
4365 Add note in the docs that ERROR or HANGUP won't be returned
4366 and are assumed always on.
4368 * glib/dbus-gmain.c (add_watch):
4369 Always add IO_ERR | IO_HUP
4371 * dbus/dbus-message.h:
4372 Add semicolon after dbus_message_iter_get_string_array().
4373 Makes qt code build again
4375 2003-02-01 Anders Carlsson <andersca@codefactory.se>
4377 * bus/driver.c: (create_unique_client_name),
4378 (bus_driver_handle_hello):
4379 Don't take a name, just use a numeric id to identify
4383 * dbus/dbus-bus.c: (dbus_bus_register_client),
4384 (dbus_bus_acquire_service), (dbus_bus_service_exists):
4386 Add new convenience functions for communicating with the bus.
4388 * dbus/dbus-message.h:
4390 * dbus/dbus-protocol.h:
4393 2003-02-01 Alexander Larsson <alexl@redhat.com>
4395 * dbus/dbus-message.c (dbus_message_append_fields):
4396 Add some more doc comments.
4398 2003-02-01 Havoc Pennington <hp@pobox.com>
4400 * dbus/dbus-break-loader.c (randomly_modify_length): change
4401 a 4-byte value in the message as if it were a length
4403 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): don't set
4404 execute bit on saved files
4406 2003-02-01 Havoc Pennington <hp@pobox.com>
4408 * dbus/dbus-break-loader.c (main): new program to find messages
4409 that break the loader.
4411 * dbus/dbus-sysdeps.c (_dbus_string_append_uint): new function
4412 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): new function
4414 * dbus/dbus-string.c (_dbus_string_set_byte): new
4416 2003-01-31 Havoc Pennington <hp@pobox.com>
4418 * dbus/dbus-message.c: refactor the test code to be more general,
4419 in preparation for writing a "randomly permute test cases to
4420 try to break the loader" program.
4422 2003-01-31 Havoc Pennington <hp@pobox.com>
4424 * doc/dbus-specification.sgml: work on the specification
4426 * dbus/dbus-message.c (_dbus_message_loader_return_buffer): check
4427 the protocol version of the message.
4429 * dbus/dbus-protocol.h: drop special _REPLY names, the spec
4430 no longer specifies that.
4431 (DBUS_SERVICE_REPLY_SERVICE_EXISTS): fix flags (1/2/4/8 not
4434 * dbus/dbus-marshal.c (_dbus_marshal_get_arg_end_pos): add missing
4435 "break" for DBUS_TYPE_NIL, remove @todo
4437 2003-01-31 Havoc Pennington <hp@pobox.com>
4439 * dbus/dbus-message.c (dbus_message_set_is_error_reply): rename
4440 just set_is_error/get_is_error as this is a commonly-used
4441 function, and write docs.
4443 2003-01-31 Anders Carlsson <andersca@codefactory.se>
4445 * dbus/dbus-address.c: (dbus_address_entry_free):
4446 Free key and value lists.
4448 * dbus/dbus-internals.c: (_dbus_type_to_string):
4449 Add the types we didn't have.
4451 * dbus/dbus-marshal.c: (_dbus_marshal_get_arg_end_pos),
4452 (_dbus_marshal_validate_arg):
4455 * dbus/dbus-message.c: (dbus_message_set_sender):
4456 Remove todo about being able to set sender to NULL.
4458 (dbus_message_set_is_error_reply),
4459 (dbus_message_get_is_error_reply):
4460 * dbus/dbus-message.h:
4463 * dbus/dbus-protocol.h:
4464 Add error reply flag.
4466 * test/data/valid-messages/opposite-endian.message:
4467 Add NIL type to test.
4469 2003-01-31 Havoc Pennington <hp@pobox.com>
4471 * doc/dbus-specification.sgml: fully specify the header. Add
4472 flags and major protocol version, and change header/body len to
4475 * dbus/dbus-message-builder.c (append_saved_length): append length
4478 * dbus/dbus-message.c (dbus_message_create_header): change header
4479 length and body length to unsigned. Add the new fields from the
4481 (_dbus_message_loader_return_buffer): unsigned header/body len
4483 2003-01-30 Havoc Pennington <hp@pobox.com>
4485 * dbus/dbus-auth.c: rework to use only REJECTED, no
4488 * doc/dbus-sasl-profile.txt: drop MECHANISMS and just
4489 use REJECTED, suggested by Mark McLoughlin
4491 2003-01-30 Havoc Pennington <hp@pobox.com>
4493 * dbus/dbus-server.c (dbus_server_listen): @todo about how we need
4494 a better way to report errors here. e.g. "unix address lacks
4495 path" or something. also "no such file" when the path doesn't
4498 * dbus/dbus-address.c (dbus_address_entries_free): add @todo about
4500 (dbus_parse_address): add @todo about documenting address format,
4501 and allowing , and ; to be escaped
4503 2003-01-30 Anders Carlsson <andersca@codefactory.se>
4506 Add dbus-address.[ch]
4508 * dbus/dbus-address.c: (dbus_address_entry_free),
4509 (dbus_address_entries_free), (create_entry),
4510 (dbus_address_entry_get_method), (dbus_address_entry_get_value),
4511 (dbus_parse_address), (_dbus_address_test):
4512 * dbus/dbus-address.h:
4513 New files for dealing with address parsing.
4515 * dbus/dbus-connection.c:
4516 Document timeout functions.
4518 * dbus/dbus-message.c:
4519 Document dbus_message_new_from_message.
4521 * dbus/dbus-server-debug.c:
4524 * dbus/dbus-server.c: (dbus_server_listen):
4525 Parse address and use correct server implementation.
4527 * dbus/dbus-string.c: (_dbus_string_find_to), (_dbus_string_test):
4528 * dbus/dbus-string.h:
4529 New function with test.
4531 * dbus/dbus-test.c: (dbus_internal_symbol_do_not_use_run_tests):
4535 * dbus/dbus-transport-debug.c:
4538 * dbus/dbus-transport.c: (_dbus_transport_open):
4539 Parse address and use correct transport implementation.
4541 2003-01-30 Havoc Pennington <hp@pobox.com>
4543 * dbus/dbus-message.c: use message->byte_order instead of
4544 DBUS_COMPILER_BYTE_ORDER throughout.
4545 (dbus_message_create_header): pad header to align the
4546 start of the body of the message to 8-byte boundary
4548 * dbus/dbus-marshal.h: make all the demarshalers take const
4549 DBusString arguments.
4551 * dbus/dbus-message.c (_dbus_message_loader_return_buffer):
4552 validate message args here, so we don't have to do slow validation
4553 later, and so we catch bad messages as they are incoming. Also add
4554 better checks on header_len and body_len. Also fill in
4557 * dbus/dbus-string.c (_dbus_string_validate_utf8): new (not
4558 implemented properly)
4559 (_dbus_string_validate_nul): new function to check all-nul
4561 * dbus/dbus-marshal.c (_dbus_marshal_get_field_end_pos): rename
4562 get_arg_end_pos and remove all validation
4563 (_dbus_marshal_validate_arg): actually do validation here.
4565 2003-01-29 Havoc Pennington <hp@pobox.com>
4567 * dbus/dbus-message.c (check_message_handling): fix assertion
4568 failure on set_client_serial
4570 2003-01-28 Havoc Pennington <hp@pobox.com>
4572 * dbus/dbus-server-debug.c: Add doc section comments
4574 * dbus/dbus-transport-debug.c: add doc section comments
4576 2003-01-28 Havoc Pennington <hp@redhat.com>
4578 * dbus/dbus-string.c (_dbus_string_base64_decode): append bytes in
4579 the reverse order from how I had it
4580 (_dbus_string_base64_encode): reverse encoding order. I was
4581 basically byteswapping everything during encoding.
4583 2003-01-28 Anders Carlsson <andersca@codefactory.se>
4585 * dbus/dbus-connection-internal.h:
4586 * dbus/dbus-connection.c: (_dbus_connection_add_timeout),
4587 (_dbus_connection_remove_timeout):
4588 Add functions for adding and removing timeouts.
4590 * dbus/dbus-message.c: (dbus_message_new_from_message):
4591 Add new function that takes a message and creates an exact
4592 copy of it, but with the refcount set to 1.
4593 (check_message_handling):
4596 * dbus/dbus-server-protected.h:
4597 * dbus/dbus-server.c: (_dbus_server_init_base),
4598 (_dbus_server_finalize_base), (_dbus_server_add_timeout),
4599 (dbus_server_set_timeout_functions):
4600 (_dbus_server_remove_timeout):
4601 New functions so that a server can add and remove timeouts.
4603 (dbus_server_listen):
4604 Add commented out call to dbus_server_debug_new.
4606 * dbus/dbus-timeout.c: (_dbus_timeout_new):
4607 Actually set the handler, doh.
4609 * dbus/dbus-transport.c: (_dbus_transport_open):
4610 Add commented out call to dbus_transport_debug_client_new.
4613 Add dbus-transport-debug.[ch] and dbus-server-debug.[ch]
4615 2003-01-28 Havoc Pennington <hp@pobox.com>
4617 * dbus/dbus-message.c (check_message_handling): function to check
4618 on the loaded message, iterates over it etc.
4620 2003-01-28 Havoc Pennington <hp@pobox.com>
4622 * test/Makefile.am (dist-hook): fix make distdir
4624 * dbus/Makefile.am (TESTS_ENVIRONMENT): fix make check
4626 2003-01-27 Havoc Pennington <hp@pobox.com>
4628 * dbus/dbus-mempool.c (time_for_size): replace printf with
4631 * dbus/dbus-message-builder.c (_dbus_message_data_load): allow
4632 empty lines; fix the SAVE_LENGTH stuff to be
4633 START_LENGTH/END_LENGTH so it actually works; couple other
4636 * test/Makefile.am (dist-hook): add dist-hook for .message files
4638 * dbus/dbus-string.c (DBUS_STRING_COPY_PREAMBLE): source of a copy
4639 can be constant or locked.
4640 (_dbus_string_free): allow freeing a const string as
4643 * dbus/dbus-sysdeps.c (_dbus_concat_dir_and_file): utility
4645 * dbus/dbus-test-main.c (main): take an argument which is the
4646 directory containing test data
4648 * dbus/dbus-message.c (_dbus_message_test): pass a test_data_dir
4649 argument to this and load all the messages in test/data/
4650 checking that they can be loaded or not loaded as appropriate.
4652 2003-01-27 Anders Carlsson <andersca@codefactory.se>
4654 * bus/dispatch.c: (bus_dispatch_message_handler):
4655 Dispatch messages sent to services.
4657 * bus/driver.c: (bus_driver_send_service_deleted),
4658 (bus_driver_send_service_created), (bus_driver_send_service_lost),
4659 (bus_driver_send_service_acquired):
4660 Add helper functions for sending service related messages.
4662 (bus_driver_send_welcome_message):
4663 Send HELLO_REPLY instead of WELCOME.
4665 (bus_driver_handle_list_services):
4666 Send LIST_SERVICES_REPLY instead of SERVICES.
4668 (bus_driver_handle_own_service),
4669 (bus_driver_handle_service_exists):
4670 New message handlers.
4672 (bus_driver_handle_message):
4673 Invoke new message handlers.
4675 (bus_driver_remove_connection):
4676 Don't remove any services here since that's done automatically
4677 by bus_service_remove_owner now.
4680 New function signatures.
4682 * bus/services.c: (bus_service_add_owner):
4683 Send ServiceAcquired message if we're the only primary owner.
4685 (bus_service_remove_owner):
4686 Send ServiceAcquired/ServiceLost messages.
4688 (bus_service_set_prohibit_replacement),
4689 (bus_service_get_prohibit_replacement):
4690 Functions for setting prohibit replacement.
4692 (bus_service_has_owner):
4693 New function that checks if a connection is in the owner queue of
4697 Add new function signatures.
4699 * dbus/dbus-list.c: (_dbus_list_test):
4700 Add tests for _dbus_list_remove_last and traversing the list backwards.
4703 Fix a typo in _dbus_list_get_prev_link, if we're at the first element we can't
4704 go any further, so return NULL then.
4706 * dbus/dbus-protocol.h:
4707 Add new messages, service flags and service replies.
4709 2003-01-26 Havoc Pennington <hp@pobox.com>
4711 * dbus/dbus-message-builder.c: implement, completely untested.
4713 * test/data/*: add data to be used in testing.
4714 ".message" files are our simple loadable text format.
4715 ".message-raw" will be binary dumps of messages.
4717 * dbus/dbus-string.c (_dbus_string_starts_with_c_str): new
4719 2003-01-26 Havoc Pennington <hp@pobox.com>
4721 * dbus/dbus-sysdeps.c (_dbus_file_get_contents): new function
4723 * dbus/dbus-errors.c (dbus_result_to_string): add
4726 * dbus/dbus-message-builder.c: new file, will contain code to load
4727 up messages from files. Not implemented yet.
4729 2003-01-26 Havoc Pennington <hp@pobox.com>
4731 * dbus/dbus-message.c (dbus_message_set_sender): support deleting
4732 the sender by setting to NULL
4734 2003-01-26 Havoc Pennington <hp@pobox.com>
4736 The unit tests pass, but otherwise untested. If it breaks, the
4737 tests should have been better. ;-)
4739 * bus/driver.c (bus_driver_handle_hello): return if we disconnect
4742 * dbus/dbus-message.c: redo everything so we maintain
4743 message->header as the only copy of the various fields.
4744 This avoids the possibility of out-of-memory in some cases,
4745 for example dbus_message_lock() can't run out of memory anymore,
4746 and avoids extra copying. Figured I may as well go ahead and do
4747 this since it was busted for dbus_message_lock to not return
4748 failure on OOM, and dbus_message_write_header was totally
4749 unchecked for OOM. Also fixed some random other bugs.
4751 * dbus/dbus-marshal.c (_dbus_marshal_get_field_end_pos): verify
4752 that strings are nul-terminated. Also, end_pos can be equal
4753 to string length just not greater than, I think.
4754 (_dbus_marshal_set_int32): new function
4755 (_dbus_marshal_set_uint32): new function
4756 (_dbus_marshal_set_string): new function
4758 * dbus/dbus-connection.c (_dbus_connection_new_for_transport): fix
4759 a warning, init timeout_list to NULL
4760 (dbus_connection_send_message): don't use uninitialized variable
4763 * dbus/dbus-string.c (_dbus_string_replace_len): new function
4765 2003-01-26 Anders Carlsson <andersca@codefactory.se>
4767 * bus/driver.c: (bus_driver_handle_hello),
4768 (bus_driver_send_welcome_message):
4771 2003-01-26 Anders Carlsson <andersca@codefactory.se>
4773 * dbus/dbus-auth.c: (process_auth), (_dbus_auth_unref):
4774 * dbus/dbus-connection.c: (_dbus_connection_new_for_transport),
4775 (dbus_connection_unref):
4776 * dbus/dbus-marshal.c: (_dbus_marshal_test):
4777 * dbus/dbus-message.c: (dbus_message_unref),
4780 (dbus_message_get_fields):
4781 Remove debugging printout.
4783 (_dbus_message_loader_return_buffer):
4784 Don't store the header string.
4786 (_dbus_message_test):
4789 2003-01-26 Richard Hult <rhult@codefactory.se>
4791 * glib/dbus-gmain.c (dbus_connection_dispatch): Traverse a copy of
4792 the file descriptor list, since it can change under us.
4794 2003-01-25 Anders Carlsson <andersca@codefactory.se>
4796 * glib/dbus-gmain.c: (dbus_connection_prepare),
4797 (dbus_connection_check), (dbus_connection_dispatch), (add_watch),
4798 (remove_watch), (dbus_connection_hookup_with_g_main):
4799 Rewrite the glib handling to use its own GSource instead of a
4800 GIOChannel so we can catch messages put in the queue while waiting
4803 2003-01-25 Anders Carlsson <andersca@codefactory.se>
4806 * bus/connection.c: (connection_disconnect_handler),
4807 (connection_watch_callback), (bus_connection_setup):
4808 * bus/dispatch.c: (send_one_message),
4809 (bus_dispatch_broadcast_message), (bus_dispatch_message_handler),
4810 (bus_dispatch_add_connection), (bus_dispatch_remove_connection):
4812 * bus/driver.c: (bus_driver_send_service_deleted),
4813 (bus_driver_send_service_created), (bus_driver_handle_hello),
4814 (bus_driver_send_welcome_message),
4815 (bus_driver_handle_list_services), (bus_driver_remove_connection),
4816 (bus_driver_handle_message):
4818 Refactor code, put the message dispatching in its own file. Use
4819 _DBUS_HANDLE_OOM. Also send ServiceDeleted messages when a client
4822 2003-01-25 Anders Carlsson <andersca@codefactory.se>
4824 * dbus/dbus-internals.h:
4825 Add _DBUS_HANDLE_OOM macro, it doesn't do anything currently.
4827 * dbus/dbus-message.c: (dbus_message_get_sender):
4828 * dbus/dbus-message.h:
4829 Implement dbus_message_get_sender.
4831 * dbus/dbus-protocol.h:
4832 Add message and service defines.
4834 2003-01-25 Anders Carlsson <andersca@codefactory.se>
4836 * dbus/dbus-connection.c: (dbus_connection_send_message):
4837 * dbus/dbus-message-internal.h:
4838 * dbus/dbus-message.c: (_dbus_message_get_client_serial),
4839 (dbus_message_write_header):
4840 Remove _dbus_messag_unlock and don't set the client serial on a
4841 message if one already exists.
4843 2003-01-24 Havoc Pennington <hp@pobox.com>
4845 * dbus/dbus-list.c (alloc_link): put a thread lock on the global
4848 * bus/driver.c (bus_driver_handle_list_services): fix a leak
4851 2003-01-25 Anders Carlsson <andersca@codefactory.se>
4853 * dbus/dbus-list.c: (alloc_link), (free_link):
4854 Use a memory pool for the links.
4856 2003-01-25 Anders Carlsson <andersca@codefactory.se>
4858 * bus/connection.c: (bus_connection_foreach):
4860 Add new bus_connection_foreach function.
4862 * bus/driver.c: (send_one_message), (bus_driver_broadcast_message):
4863 Add function that broadcasts a message to all clients.
4865 (bus_driver_send_service_created), (bus_driver_handle_hello),
4866 (bus_driver_send_welcome_message),
4867 (bus_driver_handle_list_services), (bus_driver_message_handler):
4868 Implement functions that take care of listing services, and notifying
4869 clients when new services are created.
4871 * bus/services.c: (bus_services_list):
4873 Add new function that returns an array of strings with the currently
4874 registered services.
4877 * glib/dbus-gmain.c:
4878 Update copyright year.
4880 2003-01-25 Anders Carlsson <andersca@codefactory.se>
4882 * dbus/dbus-connection.c: (dbus_connection_send_message):
4883 Unlock the message in case it was sent earlier.
4885 (dbus_connection_send_message_with_reply_and_block):
4886 Remove the reply message from the list.
4888 * dbus/dbus-marshal.c: (_dbus_demarshal_string_array):
4889 Set array_len and new_pos correctly.
4891 (_dbus_marshal_test):
4892 Remove debug output.
4894 * dbus/dbus-message-internal.h:
4895 * dbus/dbus-message.c: (_dbus_message_get_reply_serial):
4896 New function that returns the reply serial.
4898 (_dbus_message_unlock):
4899 New function that unlocks a message and resets its header.
4901 (dbus_message_append_string_array),
4902 (dbus_message_get_fields_valist),
4903 (dbus_message_iter_get_field_type),
4904 (dbus_message_iter_get_string_array),
4905 (dbus_message_get_fields),
4906 (dbus_message_append_fields_valist):
4907 Handle string arrays.
4909 (dbus_message_set_sender):
4910 Make this function public since the bus daemon needs it.
4912 (decode_header_data):
4913 Set the reply serial to -1 initially.
4915 * dbus/dbus-message.h:
4916 Add dbus_message_set_sender.
4918 2003-01-24 Havoc Pennington <hp@pobox.com>
4920 * doc/dbus-specification.sgml: add some stuff
4922 2003-01-22 Havoc Pennington <hp@pobox.com>
4924 * doc/dbus-specification.sgml: Start to document the protocol.
4926 2003-01-22 Havoc Pennington <hp@pobox.com>
4928 * dbus/dbus-connection.c
4929 (dbus_connection_send_message_with_reply_and_block): add some @todo
4931 * bus/driver.c (bus_driver_add_connection): add a FIXME about memleak
4933 2003-01-21 Havoc Pennington <hp@pobox.com>
4935 (patch untested because can't compile)
4937 * bus/driver.c (create_unique_client_name): make this function
4938 never recycle client names. Also, caller should initialize
4941 * dbus/dbus-sysdeps.c (_dbus_get_current_time): new function
4943 2003-01-21 Anders Carlsson <andersca@codefactory.se>
4945 * dbus/dbus-marshal.c: (_dbus_marshal_double),
4946 (_dbus_marshal_int32), (_dbus_marshal_uint32),
4947 (_dbus_marshal_int32_array), (_dbus_marshal_uint32_array),
4948 (_dbus_marshal_double_array), (_dbus_marshal_string_array),
4949 (_dbus_demarshal_int32_array), (_dbus_demarshal_uint32_array),
4950 (_dbus_demarshal_double_array), (_dbus_demarshal_string_array),
4951 (_dbus_marshal_get_field_end_pos), (_dbus_marshal_test):
4952 * dbus/dbus-marshal.h:
4953 * dbus/dbus-protocol.h:
4954 Add support for marshalling and demarshalling integer, double
4957 2003-01-21 Anders Carlsson <andersca@codefactory.se>
4962 * bus/connection.c: (connection_disconnect_handler):
4963 Remove the connection from the bus driver's list.
4965 (connection_watch_callback): Dispatch messages.
4967 (free_connection_data): Free connection name.
4969 (bus_connection_setup): Add connection to the bus driver's list.
4970 (bus_connection_remove_owned_service):
4971 (bus_connection_set_name), (bus_connection_get_name):
4972 Add functions for setting and getting the connection's name.
4975 Add function headers.
4977 * bus/driver.c: (create_unique_client_name),
4978 (bus_driver_handle_hello_message),
4979 (bus_driver_send_welcome_message), (bus_driver_message_handler),
4980 (bus_driver_add_connection), (bus_driver_remove_connection):
4983 * bus/services.c: (bus_service_free):
4985 New file that handles communication and registreation with the bus
4988 2003-01-21 Anders Carlsson <andersca@codefactory.se>
4990 * dbus/dbus-connection.c: (dbus_connection_send_message):
4991 Add a new client_serial parameter.
4993 (dbus_connection_send_message_with_reply):
4994 Remove a @todo since we've implemented the blocking function.
4996 (dbus_connection_send_message_with_reply_and_block):
4997 New function that sends a message and waits for a reply and
4998 then returns the reply.
5000 * dbus/dbus-connection.h:
5003 * dbus/dbus-errors.c: (dbus_result_to_string):
5004 * dbus/dbus-errors.h:
5005 Add new DBUS_RESULT.
5007 * dbus/dbus-message-internal.h:
5008 * dbus/dbus-message.c: (_dbus_message_get_reply_serial),
5009 (_dbus_message_set_sender), (dbus_message_write_header),
5010 (dbus_message_new_reply), (decode_header_data),
5011 (_dbus_message_loader_return_buffer), (_dbus_message_test):
5012 * dbus/dbus-message.h:
5013 Add new functions that set the reply serial and sender.
5014 Also marshal and demarshal them correctly and add test.
5016 * dbus/dbus-protocol.h:
5017 Add new DBUS_MESSAGE_TYPE_SENDER.
5020 * glib/dbus-gmain.c: (watch_callback), (free_callback_data),
5021 (add_watch), (remove_watch), (add_timeout), (remove_timeout),
5022 (dbus_connection_hookup_with_g_main):
5023 * glib/test-dbus-glib.c: (main):
5024 Rewrite to use GIOChannel and remove the GSource crack.
5026 * test/echo-client.c: (main):
5027 * test/watch.c: (check_messages):
5028 Update for changed APIs
5030 2003-01-19 Anders Carlsson <andersca@codefactory.se>
5032 * dbus/Makefile.am: Add dbus-timeout.[cħ]
5034 * dbus/dbus-connection.c: (_dbus_connection_new_for_transport):
5035 Create a DBusTimeoutList.
5036 (dbus_connection_set_timeout_functions): Add new function to
5037 set timeout callbacks
5039 * dbus/dbus-connection.h: Add public DBusTimeout API.
5041 * dbus/dbus-message.c: (dbus_message_get_service):
5042 * dbus/dbus-message.h: New function.
5044 * dbus/dbus-server.c: Fix small doc typo.
5046 * dbus/dbus-timeout.[ch]: New files for mainloop timeouts.
5048 2003-01-19 Anders Carlsson <andersca@codefactory.se>
5050 * dbus/dbus-string.c (_dbus_string_move_len): Don't delete all
5051 of the string, just as long as specified.
5053 2003-01-19 Havoc Pennington <hp@pobox.com>
5055 * dbus/dbus-connection.c (dbus_connection_get_is_authenticated):
5058 * dbus/dbus-server.c (dbus_server_set_max_connections)
5059 (dbus_server_get_max_connections, dbus_server_get_n_connections):
5060 keep track of current number of connections, and add API for
5061 setting a max (but haven't implemented enforcing the max yet)
5063 2003-01-18 Havoc Pennington <hp@pobox.com>
5065 * dbus/dbus-transport-unix.c (unix_do_iteration): only do the
5066 reading/writing if read_watch != NULL or write_watch != NULL.
5068 * dbus/dbus-message.c (_dbus_message_loader_return_buffer): fix
5069 the message loader code to actually load message->header and
5070 message->body into the newly-created message.
5072 * dbus/dbus-transport-unix.c (check_write_watch): fix a mem leak
5075 * dbus/dbus-connection.c (dbus_connection_set_max_message_size)
5076 (dbus_connection_get_max_message_size)
5077 (dbus_connection_set_max_live_messages_size)
5078 (dbus_connection_get_max_live_messages_size): implement some
5079 resource limitation functions
5081 * dbus/dbus-resources.c: new file implementing some of the
5082 resource limits stuff
5084 * dbus/dbus-message.c (dbus_message_iter_get_byte_array): add
5085 missing docs, add @todo to handle OOM etc.
5087 * dbus/dbus-marshal.c (_dbus_demarshal_byte_array): add missing
5090 2003-01-18 Havoc Pennington <hp@pobox.com>
5092 * dbus/dbus-connection.c (dbus_connection_unref): disconnect the
5093 connection if it hasn't been already.
5095 * dbus/dbus-connection.h: kill off the idea of an ErrorFunction,
5096 replace with DisconnectFunction.
5098 2003-01-18 Havoc Pennington <hp@pobox.com>
5100 Building --disable-verbose-mode --disable-asserts --disable-tests
5101 cuts the library from 112K to 45K or so
5103 * configure.in: check for varargs macro support,
5104 add --enable-verbose-mode, --enable-asserts.
5106 * dbus/dbus-internals.h (_dbus_assert): support
5108 (_dbus_verbose): support DBUS_ENABLE_VERBOSE_MODE
5110 2003-01-18 Havoc Pennington <hp@pobox.com>
5112 * dbus/dbus-test.c: include config.h so that tests actually run
5114 * dbus/dbus-string.c: add assertions that stuff is 8-byte aligned,
5115 so the failure mode when that assumption fails will be plenty
5118 2003-01-18 Havoc Pennington <hp@pobox.com>
5120 * configure.in: default --enable-tests to $USE_MAINTAINER_MODE
5122 * dbus/Makefile.am: fix it up so dubs-test-main.c is included in
5125 * test/Makefile.am: don't use special variable "TESTS" for echo-*
5126 since we don't want to use those in make check
5128 2003-01-15 Havoc Pennington <hp@redhat.com>
5134 2003-01-15 Havoc Pennington <hp@redhat.com>
5136 * test/Makefile.am: fix so that test source code ends up in the
5137 distribution on make distcheck
5139 2003-01-15 Havoc Pennington <hp@redhat.com>
5145 2003-01-15 Havoc Pennington <hp@redhat.com>
5147 * dbus/dbus-test.c (dbus_internal_symbol_do_not_use_run_tests):
5148 fix build when --disable-tests
5150 * Makefile.am (EXTRA_DIST): put HACKING in here
5152 * HACKING: document procedure for making a tarball release.
5154 2003-01-14 Anders Carlsson <andersca@codefactory.se>
5156 * bus/connection.c: (connection_error_handler),
5157 (bus_connection_setup):
5158 * bus/main.c: (main):
5159 Make sure that the DBusConnectionData struct is NULLed
5160 out to prevent a segfault.
5162 * dbus/dbus-errors.c: (dbus_result_to_string):
5163 * dbus/dbus-errors.h:
5164 * dbus/dbus-message.c: (dbus_message_get_fields),
5165 (dbus_message_get_fields_valist), (_dbus_message_test):
5166 * dbus/dbus-message.h:
5167 Make dbus_message_get_fields return a result code so we can
5168 track invalid fields as well as oom.
5170 2003-01-11 Havoc Pennington <hp@pobox.com>
5172 * configure.in: change --enable-test/--enable-ansi action-if-given
5173 to enable_foo=$enableval instead of enable_foo=yes
5175 2003-01-08 Havoc Pennington <hp@pobox.com>
5177 * dbus/dbus-string.c (_dbus_string_align_length): new function
5179 * dbus/dbus-test-main.c: move main() for test app here
5181 (dbus_internal_symbol_do_not_use_run_tests): we have to export a
5182 symbol to run tests, because dbus-test isn't in the main
5185 Code review nitpicks.
5187 * dbus/dbus-message.c (dbus_message_write_header): add newlines
5188 for people with narrow emacs ;-). Assert client_serial was filled
5189 in. Assert message->name != NULL.
5190 (dbus_message_append_fields): have "first_field_type" arg separate
5191 from va list, needed for C++ binding that also uses varargs IIRC
5192 and helps with type safety
5193 (dbus_message_new): add @todo about using DBusString to store
5194 service/name internally
5195 (dbus_message_new): don't leak ->service and ->name on OOM later
5197 (dbus_message_unref): free the service name
5198 (dbus_message_get_fields): same change to varargs
5199 i.e. first_field_type
5200 (_dbus_message_loader_return_buffer): assert that the message data
5201 is aligned (if not it's a bug in our code). Put in verbose griping
5202 about why we set corrupted = TRUE.
5203 (decode_header_data): add FIXME that char* is evil. Was going to
5204 add FIXME about evil locale-specific string.h strncmp, but just
5205 switched to wacky string-as-uint32 optimization. Move check for
5206 "no room for field name" above get_const_data_len() to avoid
5207 assertion failure in get_const_data_len if we have trailing 2
5208 bytes or the like. Check for service and name fields being
5209 provided twice. Don't leak service/name on error. Require field
5210 names to be aligned to 4 bytes.
5212 * dbus/dbus-marshal.c: move byte swap stuff to header
5213 (_dbus_pack_int32): uscore-prefix
5214 (_dbus_unpack_int32): uscore-prefix
5215 (_dbus_unpack_uint32): export
5216 (_dbus_demarshal_string): add @todo complaining about use of
5218 (_dbus_marshal_get_field_end_pos): add @todo about bad error
5219 handling allowing corrupt data to go unchecked
5221 2003-01-08 Havoc Pennington <hp@redhat.com>
5223 * dbus/dbus-transport-unix.c (unix_do_iteration): add read/write
5224 to the select() as needed for authentication. (should be using
5225 _dbus_poll() not select, but for another day)
5227 * dbus/dbus.h: include dbus/dbus-protocol.h
5229 2003-01-08 Anders Carlsson <andersca@codefactory.se>
5231 * dbus/Makefile.am (dbusinclude_HEADERS): Install
5234 2003-01-08 Anders Carlsson <andersca@codefactory.se>
5236 * dbus/dbus-internals.c: (_dbus_type_to_string):
5237 New function that returns a string describing a type.
5239 * dbus/dbus-marshal.c: (_dbus_demarshal_byte_array):
5240 * dbus/dbus-marshal.h:
5241 * dbus/dbus-message.c: (dbus_message_get_fields_valist),
5242 (dbus_message_iter_get_field_type), (dbus_message_iter_get_double),
5243 (dbus_message_iter_get_byte_array):
5244 * dbus/dbus-message.h:
5245 Add new convenience functions for appending and getting message fields.
5246 Also add demarshalling routines for byte arrays.
5248 2003-01-07 Anders Carlsson <andersca@codefactory.se>
5250 * dbus/dbus-connection-internal.h:
5251 * dbus/dbus-connection.c: (_dbus_connection_new_for_transport),
5252 (_dbus_connection_get_next_client_serial),
5253 (dbus_connection_send_message):
5254 * dbus/dbus-internals.h:
5255 * dbus/dbus-marshal.c: (unpack_uint32), (dbus_unpack_int32),
5256 (dbus_pack_int32), (_dbus_marshal_double), (_dbus_marshal_int32),
5257 (_dbus_marshal_uint32), (_dbus_demarshal_double),
5258 (_dbus_demarshal_int32), (_dbus_demarshal_uint32),
5259 (_dbus_demarshal_string), (_dbus_marshal_get_field_end_pos),
5260 (_dbus_verbose_bytes), (_dbus_marshal_test):
5261 * dbus/dbus-marshal.h:
5262 * dbus/dbus-message-internal.h:
5263 * dbus/dbus-message.c: (_dbus_message_set_client_serial),
5264 (dbus_message_write_header), (_dbus_message_lock),
5265 (dbus_message_new), (dbus_message_ref), (dbus_message_unref),
5266 (dbus_message_get_name), (dbus_message_append_int32),
5267 (dbus_message_append_uint32), (dbus_message_append_double),
5268 (dbus_message_append_string), (dbus_message_append_byte_array),
5269 (dbus_message_get_fields_iter), (dbus_message_iter_ref),
5270 (dbus_message_iter_unref), (dbus_message_iter_has_next),
5271 (dbus_message_iter_next), (dbus_message_iter_get_field_type),
5272 (dbus_message_iter_get_string), (dbus_message_iter_get_int32),
5273 (dbus_message_iter_get_uint32), (dbus_message_iter_get_double),
5274 (decode_header_data), (_dbus_message_loader_return_buffer),
5275 (message_iter_test), (_dbus_message_test):
5276 * dbus/dbus-message.h:
5277 * dbus/dbus-protocol.h:
5278 * dbus/dbus-test.c: (main):
5280 * glib/test-dbus-glib.c: (message_handler), (main):
5281 * test/echo-client.c: (main):
5282 * test/watch.c: (check_messages):
5283 Make messages sendable and receivable for real.
5285 2003-01-07 Anders Carlsson <andersca@codefactory.se>
5287 * dbus/dbus-marshal.c: (_dbus_marshal_double),
5288 (_dbus_marshal_string), (_dbus_marshal_byte_array):
5289 * dbus/dbus-message.c: (dbus_message_append_int32),
5290 (dbus_message_append_uint32), (dbus_message_append_double),
5291 (dbus_message_append_string), (dbus_message_append_byte_array):
5292 Handle OOM restoration.
5294 2003-01-07 Anders Carlsson <andersca@codefactory.se>
5296 * dbus/dbus-marshal.c: (_dbus_marshal_string),
5297 (_dbus_demarshal_string), (_dbus_marshal_test):
5298 * dbus/dbus-marshal.h:
5299 * dbus/dbus-message.c: (dbus_message_get_name),
5300 Document these functions.
5302 (dbus_message_append_int32), (dbus_message_append_uint32),
5303 (dbus_message_append_double), (dbus_message_append_string),
5304 (dbus_message_append_byte_array):
5305 * dbus/dbus-message.h:
5306 Add functions for adding message fields of different types.
5308 * dbus/dbus-protocol.h:
5309 Add the different types.
5311 2003-01-05 Havoc Pennington <hp@pobox.com>
5313 * bus/connection.c: implement routines for handling connections,
5314 first thing is keeping a list of owned services on each connection
5315 and setting up watches etc.
5317 * bus/services.c: implement a mapping from service names to lists
5320 * dbus/dbus-hash.c: add DBUS_HASH_POINTER
5322 * dbus/dbus-threads.c (dbus_static_mutex_lock): add functions
5323 to use static mutexes for global data
5325 * dbus/dbus-connection.c (dbus_connection_set_data): add new
5326 collection of functions to set/get application-specific data
5327 on the DBusConnection.
5329 2003-01-04 Havoc Pennington <hp@pobox.com>
5331 * dbus/dbus-sysdeps.c (_dbus_sleep_milliseconds): new function
5332 (_dbus_poll): new function
5334 * dbus/dbus-internals.h (_DBUS_STRUCT_OFFSET): new macro
5337 * bus/loop.c: initial code for the daemon main loop
5339 2003-01-04 Havoc Pennington <hp@pobox.com>
5341 * test/watch.c (error_handler): make it safe if the error handler
5342 is called multiple times (if we s/error handler/disconnect
5343 handler/ we should just guarantee it's called only once)
5345 * dbus/dbus-transport.c (_dbus_transport_disconnect): call the
5346 error handler on disconnect (it's quite possible we should
5347 just change the error handler to a "disconnect handler," I'm
5348 not sure we have any other meaningful errors)
5350 * configure.in: check for getpwnam_r
5352 * dbus/dbus-transport.c, dbus/dbus-transport-unix.c,
5353 dbus/dbus-auth.c: add credentials support, add EXTERNAL auth
5354 mechanism as in SASL spec, using socket credentials
5356 * dbus/dbus-sysdeps.c (_dbus_read_credentials_unix_socket): new function
5357 (_dbus_send_credentials_unix_socket): new function
5359 * dbus/dbus-sysdeps.c (_dbus_accept_unix_socket): rename just
5361 (_dbus_write): only check errno if <0 returned
5362 (_dbus_write_two): ditto
5364 2003-01-02 Anders Carlsson <andersca@codefactory.se>
5366 * dbus/dbus-marshal.c: (_dbus_marshal_utf8_string),
5367 (_dbus_marshal_byte_array), (_dbus_demarshal_utf8_string),
5368 (_dbus_marshal_test):
5369 * dbus/dbus-marshal.h:
5370 Add _dbus_marshal_byte_array and rename _dbus_marshal_string
5371 to _dbus_marshal_utf8_string. Also fix some tests.
5373 2002-12-28 Harri Porten <porten@kde.org>
5375 * configure.in: added check for C++ compiler and a very cheesy
5376 check for the Qt integration
5378 * Makefile.am (SUBDIRS): compile qt subdir if support is enabled
5380 * qt/Makefile.am: added
5382 * qt/.cvsignore: added
5384 * qt/dbus-qthread.cc, qt/dbus-qthread.cpp: renamed former to
5385 latter, added #ifdef QT_THREAD_SUPPORT guard.
5387 * dbus/Makefile.am: added missing headers for make dist
5389 2002-12-28 Kristian Rietveld <kris@gtk.org>
5391 * dbus/Makefile.am: fixup export-symbols-regex.
5393 2002-12-27 Anders Carlsson <andersca@codefactory.se>
5395 * acinclude.m4: Add this file and put the
5396 PKG_CHECK_MODULE macro in it.
5398 2002-12-27 Anders Carlsson <andersca@codefactory.se>
5400 * dbus/dbus-marshal.c: (_dbus_marshal_string),
5401 (_dbus_demarshal_double), (_dbus_demarshal_int32),
5402 (_dbus_demarshal_uint32), (_dbus_demarshal_string),
5403 (_dbus_marshal_test):
5404 Make the demarshalling routines align the pos argument.
5405 Add string marshalling tests and fix the obvious bugs
5408 2002-12-26 Havoc Pennington <hp@pobox.com>
5410 * dbus/dbus-auth.c: fixes fixes fixes
5412 * dbus/dbus-transport-unix.c: wire up support for
5413 encoding/decoding data on the wire
5415 * dbus/dbus-auth.c (_dbus_auth_encode_data)
5416 (_dbus_auth_decode_data): append to target string
5417 instead of nuking it.
5419 2002-12-26 Havoc Pennington <hp@pobox.com>
5421 * dbus/dbus-marshal.h (DBUS_COMPILER_BYTE_ORDER): #ifdef
5422 WORDS_BIGENDIAN then compiler byte order is DBUS_BIG_ENDIAN,
5425 * dbus/dbus-marshal.c: Add macros to do int swapping in-place and
5426 avoid swap_bytes() overhead (ignoring possible assembly stuff for
5427 now). Main point is because I wanted unpack_uint32 to implement
5429 (_dbus_verbose_bytes): new function
5431 * dbus/dbus-string.c (_dbus_string_validate_ascii): new function
5433 * dbus/dbus-message.c (_dbus_message_loader_get_is_corrupted): add
5434 mechanism to handle a corrupt message stream
5435 (_dbus_message_loader_new): fix preallocation to only prealloc,
5438 * dbus/dbus-string.c (_dbus_string_skip_blank): fix this function
5439 (_dbus_string_test): enhance tests for copy/move and fix the
5442 * dbus/dbus-transport-unix.c: Hold references in more places to
5443 avoid reentrancy problems
5445 * dbus/dbus-transport.c: ditto
5447 * dbus/dbus-connection.c (dbus_connection_dispatch_message): don't
5448 leak reference count in no-message case
5450 * test/watch.c (do_mainloop): handle adding/removing watches
5451 during iteration over the watches. Also, ref the connection/server
5452 stored on a watch, so we don't try to mangle a destroyed one.
5454 * dbus/dbus-transport-unix.c (do_authentication): perform
5457 * dbus/dbus-auth.c (get_state): add a state
5458 AUTHENTICATED_WITH_UNUSED_BYTES and return it if required
5459 (_dbus_auth_get_unused_bytes): append the unused bytes
5460 to the passed in string, rather than prepend
5462 * dbus/dbus-transport.c (_dbus_transport_init_base): create
5463 the auth conversation DBusAuth
5465 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_fd)
5466 (_dbus_transport_new_for_domain_socket): when creating a
5467 transport, pass in whether it's a client-side or server-side
5468 transport so we know which DBusAuth to create
5470 2002-12-03 Havoc Pennington <hp@pobox.com>
5472 * dbus/dbus-transport-unix.c (unix_finalize): finalize base
5473 _after_ finalizing the derived members
5474 (unix_connection_set): unref watch if we fail to add it
5476 * dbus/dbus-connection.c (dbus_connection_unref): delete the
5477 transport first, so that the connection owned by the
5478 transport will be valid as the transport finalizes.
5480 * dbus/dbus-transport-unix.c (unix_finalize): free the write_watch
5481 if necessary, and remove watches from the connection.
5483 * dbus/dbus-watch.c (_dbus_watch_list_free): improve a comment
5485 2002-12-26 Anders Carlsson <andersca@codefactory.se>
5487 * dbus/dbus-marshal.c: (_dbus_marshal_string),
5488 (_dbus_demarshal_double), (_dbus_demarshal_int32),
5489 (_dbus_demarshal_uint32), (_dbus_demarshal_string),
5490 (_dbus_marshal_test):
5491 * dbus/dbus-marshal.h:
5492 Add string marshal functions and have the demarshal functions
5493 return the new position.
5495 2002-12-25 Havoc Pennington <hp@pobox.com>
5497 * doc/dbus-sasl-profile.txt: docs on the authentication protocol,
5498 it is a simple protocol that just maps directly to SASL.
5500 * dbus/dbus-auth.h, dbus/dbus-auth.c: authentication protocol
5501 initial implementation, not actually used yet.
5503 * dbus/dbus-string.c (_dbus_string_find): new function
5504 (_dbus_string_equal): new function
5505 (_dbus_string_base64_encode): new function
5506 (_dbus_string_base64_decode): new function
5508 2002-12-25 Anders Carlsson <andersca@codefactory.se>
5511 * dbus/dbus-marshal.c: (swap_bytes), (_dbus_marshal_double),
5512 (_dbus_marshal_int32), (_dbus_marshal_uint32),
5513 (_dbus_demarshal_double), (_dbus_demarshal_int32),
5514 (_dbus_demarshal_uint32), (_dbus_marshal_test):
5515 * dbus/dbus-marshal.h:
5516 * dbus/dbus-protocol.h:
5517 * dbus/dbus-test.c: (main):
5519 Add un-optimized marshalling/demarshalling routines.
5521 2002-12-25 Harri Porten <porten@kde.org>
5523 * qt/dbus-qt.h: adjusted ctor and getter to KDE/Qt conventions
5525 2002-12-24 Zack Rusin <zack@kde.org>
5527 * qt/dbus-qthread.cc: adding - integrates QMutex into Dbus
5528 * qt/dbus-qt.h: skeleton with two sample implemenatation of the
5531 2002-12-24 Havoc Pennington <hp@pobox.com>
5533 * glib/dbus-gthread.c: fix include
5535 * glib/dbus-glib.h: rename DBusMessageHandler for now.
5536 I think glib API needs to change, though, as you don't
5537 want to use DBusMessageFunction, you want to use the
5538 DBusMessageHandler object. Probably
5539 dbus_connection_open_with_g_main_loop()
5540 and dbus_connection_setup_g_main_loop() or something like that
5541 (but think of better names...) that just create a connection
5542 that has watch/timeout functions etc. already set up.
5544 * dbus/dbus-connection.c
5545 (dbus_connection_send_message_with_reply): new function just to
5546 show how the message handler helps us deal with replies.
5548 * dbus/dbus-list.c (_dbus_list_remove_last): new function
5550 * dbus/dbus-string.c (_dbus_string_test): free a string that
5553 * dbus/dbus-hash.c: use memory pools for the hash entries
5554 (rebuild_table): be more paranoid about overflow, and
5555 shrink table when we can
5556 (_dbus_hash_test): reduce number of sprintfs and write
5557 valid C89. Add tests for case where we grow and then
5558 shrink the hash table.
5560 * dbus/dbus-mempool.h, dbus/dbus-mempool.c: memory pools
5562 * dbus/dbus-connection.c (dbus_connection_register_handler)
5563 (dbus_connection_unregister_handler): new functions
5565 * dbus/dbus-message.c (dbus_message_get_name): new
5567 * dbus/dbus-list.c: fix docs typo
5569 * dbus/dbus-message-handler.h, dbus/dbus-message-handler.c:
5570 an object representing a handler for messages.
5572 2002-12-16 Anders Carlsson <andersca@codefactory.se>
5575 * glib/dbus-gthread.c: (dbus_gthread_init):
5576 Don't use the gdbus prefix for public functions.
5578 2002-12-16 Anders Carlsson <andersca@codefactory.se>
5582 Add GLib checks and fixup .pc files
5586 * glib/dbus-gmain.c: (gdbus_connection_prepare),
5587 (gdbus_connection_check), (gdbus_connection_dispatch),
5588 (gdbus_add_connection_watch), (gdbus_remove_connection_watch),
5589 (dbus_connection_gsource_new):
5590 * glib/dbus-gthread.c: (dbus_gmutex_new), (dbus_gmutex_free),
5591 (dbus_gmutex_lock), (dbus_gmutex_unlock), (dbus_gthread_init):
5592 * glib/test-dbus-glib.c: (message_handler), (main):
5595 2002-12-15 Harri Porten <porten@kde.org>
5597 * autogen.sh: check for libtoolize before attempting to use it
5599 * dbus/dbus-transport-unix.c: include <sys/time.h> for timeval
5602 * .cvsignore: ignore more stamp files
5604 * dbus/dbus-watch.c (_dbus_watch_list_new): fixed doc error
5606 * test/Makefile.am: added -I$(top_srcdir) to be able to compile
5607 without make install.
5609 2002-12-15 Havoc Pennington <hp@pobox.com>
5611 * dbus/dbus-threads.c: add thread stubs that a higher library
5612 layer can fill in. e.g. the GLib wrapper might fill them in with
5613 GThread stuff. We still need to use this thread API to
5614 thread-safe-ize the library.
5616 2002-12-12 Havoc Pennington <hp@pobox.com>
5618 * dbus/dbus-transport-unix.c, dbus/dbus-server-unix.c: use the
5619 below new interfaces and include fewer system headers.
5621 * dbus/dbus-sysdeps.c (_dbus_read): new function
5622 (_dbus_write): new function
5623 (_dbus_write_two): new function
5624 (_dbus_connect_unix_socket): new function
5625 (_dbus_listen_unix_socket): new function
5627 * dbus/dbus-message-internal.h: change interfaces to use
5630 2002-12-11 Havoc Pennington <hp@pobox.com>
5632 * dbus/dbus-types.h: add dbus_unichar
5634 * dbus/dbus-internals.c (_dbus_verbose): use _dbus_getenv
5636 * dbus/dbus-connection.c (dbus_connection_send_message): return
5639 * dbus/dbus-transport.c: include dbus-watch.h
5641 * dbus/dbus-connection.c: include dbus-message-internal.h
5643 * HACKING: add file with coding guidelines stuff.
5645 * dbus/dbus-string.h, dbus/dbus-string.c: Encapsulate all string
5646 handling here, for security purposes (as in vsftpd). Not actually
5647 using this class yet.
5649 * dbus/dbus-sysdeps.h, dbus/dbus-sysdeps.c: Encapsulate all
5650 system/libc usage here, as in vsftpd, for ease of auditing (and
5651 should also simplify portability). Haven't actually moved all the
5652 system/libc usage into here yet.
5654 2002-11-25 Havoc Pennington <hp@pobox.com>
5656 * dbus/dbus-internals.c (_dbus_verbose): fix to not
5657 always print the first verbose message.
5659 2002-11-24 Havoc Pennington <hp@pobox.com>
5661 * test/echo-client.c, test/echo-server.c: cheesy test
5664 * configure.in (AC_CHECK_FUNCS): check for writev
5666 * dbus/dbus-message.c (_dbus_message_get_network_data): new
5669 * dbus/dbus-list.c (_dbus_list_foreach): new function
5671 * dbus/dbus-internals.c (_dbus_verbose): new function
5673 * dbus/dbus-server.c, dbus/dbus-server.h: public object
5674 representing a server that listens for connections.
5676 * dbus/.cvsignore: create
5678 * dbus/dbus-errors.h, dbus/dbus-errors.c:
5679 public API for reporting errors
5681 * dbus/dbus-connection.h, dbus/dbus-connection.c:
5682 public object representing a connection that
5683 sends/receives messages. (Same object used for
5684 both client and server.)
5686 * dbus/dbus-transport.h, dbus/dbus-transport.c:
5687 Basic abstraction for different kinds of stream
5688 that we might read/write messages from.
5690 2002-11-23 Havoc Pennington <hp@pobox.com>
5692 * dbus/dbus-internals.h (_DBUS_INT_MAX): add _DBUS_INT_MIN
5695 * dbus/dbus-test.c (main): add list test, and include
5696 dbus-test.h as intended
5698 * dbus/dbus-hash.c (_dbus_hash_table_remove_string)
5699 (_dbus_hash_table_remove_int): return value indicates
5700 whether the entry existed to remove
5702 * dbus/dbus-list.c: add linked list utility class,
5705 * dbus/dbus-hash.c: add TODO item about shrinking the hash bucket
5708 2002-11-23 Havoc Pennington <hp@pobox.com>
5710 * Doxyfile.in (INCLUDE_FILE_PATTERNS): expand DBUS_BEGIN_DECLS/
5711 DBUS_END_DECLS to nothing, that should fix this once and for all
5713 * Doxyfile.in (JAVADOC_AUTOBRIEF): set to YES
5715 * dbus/dbus-message.c, dbus/dbus-hash.c:
5716 add some missing @brief
5718 2002-11-23 Havoc Pennington <hp@pobox.com>
5720 * dbus/dbus-message.h: put semicolons after DEBUG_BEGIN_DECLS
5721 to avoid confusing Doxygen
5723 * dbus/dbus-hash.c: @} not }@
5725 * dbus/dbus-message.c (struct DBusMessage): split out
5728 2002-11-23 Havoc Pennington <hp@pobox.com>
5730 * configure.in: pile on more warning flags if using gcc
5732 * Doxyfile.in (EXTRACT_STATIC): set to NO, so we don't have
5733 to document static functions
5735 * configure.in: add summary to end of configure so it
5736 looks nice and attractive
5738 * dbus/dbus-hash.c: finish implementation and write unit
5741 * configure.in: add --enable-tests to enable unit tests
5743 * dbus/dbus-test.c: test program to run unit tests
5744 for all files in dbus/*, initially runs a test for
5747 * dbus/dbus-internals.h: file to hold some internal utility stuff
5749 2002-11-22 Havoc Pennington <hp@redhat.com>
5751 * dbus/dbus-hash.c: copy in Tcl hash table, not yet
5752 "ported" away from Tcl
5754 * dbus/dbus-types.h: header for types such as dbus_bool_t
5756 2002-11-22 Havoc Pennington <hp@redhat.com>
5758 * dbus/dbus.h: fixups for doc warnings
5760 * Doxyfile.in (FILE_PATTERNS): we need to scan .h to pick up
5762 (QUIET): make it quiet so we can see warnings
5764 * dbus/dbus-memory.c: teach D-BUS to allocate and free memory
5766 2002-11-22 Havoc Pennington <hp@redhat.com>
5768 * Makefile.am: include "Doxyfile" target in all-local
5770 * configure.in: generate the Doxyfile
5772 * Doxyfile.in: move Doxyfile here, so we can use
5773 configure to generate a Doxyfile with the right
5776 2002-11-22 Havoc Pennington <hp@redhat.com>
5778 * dbus/dbus-message.c: move inline docs into .c file
5780 * Doxyfile (OUTPUT_DIRECTORY): move output to doc/api
5781 so all docs are under doc/
5782 (MAN_EXTENSION): generate man pages. Use extension
5783 ".3dbus" which matches ".3qt" on my system,
5784 I guess this is OK, I don't know really.
5785 (FILE_PATTERNS): look for .c files not .h, makes sense
5788 2002-11-22 Havoc Pennington <hp@pobox.com>
5790 * Makefile.am (SUBDIRS): rename subdir "server" to "bus"
5791 because any app can be a server, and any app can be a client,
5792 the bus is a special kind of server.
5794 Thu Nov 21 23:35:31 2002 Zack Rusin <zack@kde.org>
5796 * Doxyfile : adding. Still needs Makefile rules to be generated
5797 automatically (just run "doxygen" in the toplevel dir for now to
5800 * dbus/dbus-message.h : Adding sample docs (javadoc since
5801 resembles gtk-doc a little more)
5803 * dbus/dbus.h : Adding sample docs
5805 2002-11-21 Havoc Pennington <hp@redhat.com>
5807 * dbus/Makefile.am (INCLUDES): define DBUS_COMPILATION
5808 so we can allow ourselves to include files directly,
5809 instead of having to use dbus.h
5811 * dbus/dbus.h: fill in
5813 * dbus/dbus-message.h: sketch out a sample header file.
5814 Include griping if you include it directly instead of
5817 * dbus/dbus-macros.h: new file with macros for extern "C",
5818 TRUE/FALSE, NULL, etc.
5820 * doc/file-boilerplate.c: put include guards in here
5822 2002-11-21 Havoc Pennington <hp@redhat.com>
5824 * doc/file-boilerplate.c: include both AFL and GPL boilerplate.
5826 * COPYING: include the GPL as well, and license code
5827 under both AFL and GPL.
5829 2002-11-21 Havoc Pennington <hp@redhat.com>
5831 * acconfig.h: get rid of this
5833 * autogen.sh (run_configure): add --no-configure option
5835 * configure.in: remove AC_ARG_PROGRAM to make
5836 autoconf complain less. add AC_PREREQ.
5837 add AC_DEFINE third arg.
5839 2002-11-21 Anders Carlsson <andersca@codefactory.se>
5842 Fix references so we can distcheck.
5844 2002-11-21 Havoc Pennington <hp@redhat.com>
5846 * Initial module creation