1 2006-07-26 Jim Meyering <jim@meyering.net>
3 * src/ls.c: Correct indentation/formatting in a few places.
5 2006-07-25 Paul Eggert <eggert@cs.ucla.edu>
7 * tests/cp/fail-perm: Use "chmod 0500" rather than "chmod 500".
8 Problem report and fix from Bob Proulx.
9 * NEWS: Clarify the "chmod 0500" news, and correct the vague
10 statements about compatibility with BSD.
12 2006-07-25 Jim Meyering <jim@meyering.net>
14 * src/ls.c (gobble_file): When handling a stat-failed entry,
15 print the entry name not the absolute_name -- to be consistent
17 * tests/ls/stat-failed: Update accordingly.
19 * src/ls.c: Add parens around the new uses of ?: ternary operator.
21 * src/dircolors.hin: Mention that ORPHAN refers not just to dangling
24 Get --dired offsets right when handling stat-failed entries.
25 * src/ls.c (print_long_format): Be careful to increment P by the
26 appropriate amount, even when inode_number_width and nlink_width
28 * tests/ls/stat-failed: Test for the above.
30 * src/ls.c (gobble_file) [USE_ACL]: Don't use-uninitialized the
31 have_acl member. That would happen for a directory with both a
32 non-stat'able entry and one with an ACL.
34 * src/ls.c (gobble_file): Make it so failure to stat a
35 non-command-line file provokes an exit status of 1, not 0.
36 Say "cannot access" rather than "cannot stat".
37 * tests/ls/stat-failed: New file/test, for the above.
38 * tests/ls/Makefile.am (TESTS): Add stat-failed.
39 * tests/ls-2/tests (no-a-isdir-b): Update to reflect addition
40 of "cannot access " to diagnostic.
42 * src/ls.c: Declare stat_failed to be "bool", not "int" everywhere.
44 * src/ls.c [enum filetype] (command_line): Remove member. Not needed.
45 Replace all occurrences of "type == command_line" with the
46 equivalent, "command_line_arg".
48 * src/ls.c: Apply the stat-failed parts of Red Hat's
49 coreutils-selinux.patch. From Ulrich Drepper.
50 This makes it so files not mentioned on the command line (e.g.,
51 names read from a directory that *is* mentioned on the command
52 line) for which stat fails are still listed. With --color,
53 such files are colored just like ORPHANs (aka dangling symlinks).
55 * src/df.c (n_valid_args): Declare global to be static.
57 2006-07-24 Jim Meyering <jim@meyering.net>
59 * tests/ls/stat-dtype: Skip this test on reiserfs, since that file
60 system lacks d_type support.
62 2006-07-22 Paul Eggert <eggert@cs.ucla.edu>
64 * man/chmod.x: Update to reflect recent changes to coreutils.texi.
66 2006-07-21 Jim Meyering <jim@meyering.net>
68 * src/su.c (usage): Correct typo in --help output: s/commmand/command/
69 Reported by Tim Waugh.
70 Also remove the comment duplicating much of --help output.
72 * src/ls.c (FILE_TYPE_INDICATOR_OPTION): Reposition this new
73 name so the list remains alphabetized.
75 Fix another bug: ls --indicator-style=file-type would call
76 stat for a symlink, even though it wasn't always needed.
77 In some cases, that unnecessary stat would cause ls to fail.
78 * src/ls.c (gobble_file): Don't treat symlinks specially (in
79 requiring a stat syscall). Remove the offending exclusion.
81 * NEWS: Mention the fix.
83 * tests/ls/stat-dtype: New file/test, for the above fix.
84 Also exercises the new df feature, below.
86 * src/df.c (main): Fail and don't print the headers if no
87 file system is processed. This makes it easy to test whether
88 a specified directory is on a file system of a given type or types.
89 Otherwise, applications would have had to parse df's output.
90 E.g., is "." either ext3 or reiserfs: df -t ext3 -t reiserfs .
92 Fix a bug: ls --file-type worked like --indicator-style=slash,
93 rather than like --indicator-style=file-type.
94 * src/ls.c (FILE_TYPE_INDICATOR_OPTION): New enum member.
95 (long_options): Map "file-type" to FILE_TYPE_INDICATOR_OPTION,
97 (decode_switches): Handle new case: FILE_TYPE_INDICATOR_OPTION.
98 * NEWS: Mention the fix.
99 * tests/ls-2/tests (file-type): New test, for the above fix.
101 2006-07-19 Jim Meyering <jim@meyering.net>
103 * src/ls.c (print_dir): Give a better diagnostic for failed opendir.
105 * Makefile.am (EXTRA_DIST): Add build-aux/vc-list-files.
107 2006-07-16 Paul Eggert <eggert@cs.ucla.edu>
109 * NEWS: chmod, install, and mkdir now leave setgid and setuid bits
110 of directories alone unless you specify them explicitly.
111 install and mkdir now implement X correctly.
112 install now creates parent directories with mode 755, without
113 changing their owner or group.
114 * src/chmod.c (process_file): Adjust to mode_adjust API change.
115 * src/install.c: Include mkancesdirs.h.
116 (announce_mkdir, make_ancestor): New functions.
117 (DEFAULT_MODE): New macro, specifying initial value of 'mode'.
119 (dir_mode, dir_mode_bits): New vars.
120 (main): Set dir modes separately from nondir, so that the X
121 op of -m works correctly.
122 (main): Remove cwd_errno cruft, since make_dir_parents no longer
123 affects cwd. Adjust to new make_dir_parents API.
124 (install_file_in_file_parents): 2nd arg is now char *, not char
125 const *. Use mkancesdirs instead of rolling our own code.
126 (change_attributes): Don't worry about AFS, since that kludge
127 should not be needed any more.
128 * src/mkdir.c (struct mkdir_options): New struct.
129 (announce_mkdir, make_ancestor): New functions.
130 (main): Use them. Adjust to mode_adjust API change. Stick with
131 umask 0. Use make_dir_parents for all the work.
132 * src/mkfifo.c (main): Adjust to new mode_adjust API.
133 * src/mknod.c (main): Likewise.
134 * tests/chmod/setgid: Do the setgid test instead of bailing.
135 * tests/mkdir/p-3: Remove re_protect case that no longer applies.
136 GNU chmod now behaves like other versions of chmod.
137 * tests/mkdir/perm: Add a test for the X bug.
139 2006-07-14 Paul Eggert <eggert@cs.ucla.edu>
141 * src/base64.c (do_decode): Output to parameter OUT, not to stdout.
142 This doesn't fix any bugs, since OUT always equals stdout, but it
143 makes the code easier to understand.
145 2006-07-14 Jim Meyering <jim@meyering.net>
147 * Makefile.maint (CVS_LIST): Use new file, build-aux/vc-list-files,
148 rather than open-coding it. Now supports mercurial, too.
149 * .hgignore: New file.
150 * Makefile.am (EXTRA_DIST): Add .hgignore, which ignores nearly
151 all generated files, including ones like configure and po/*.po
152 that are currently version-controlled in cvs.
154 * Makefile.am (EXTRA_DIST): Add a few more .??* files.
155 They've been in CVS, just haven't been distributed before this.
156 Distribute ChangeLog-2005, too.
157 (MAINTAINERCLEANFILES): Add THANKS-to-translators.
159 2006-07-11 Paul Eggert <eggert@cs.ucla.edu>
161 * src/system.h: Assume <dirent.h> exists, since gnulib assumes
164 2006-07-09 Jim Meyering <jim@meyering.net>
166 * tests/mv/dir2dir: Adjust so failing with ENOTEMPTY is ok, too.
167 That happens with Linux/tmpfs.
168 * tests/mv/Makefile.am (TESTS): Add dir2dir.
170 2006-07-09 Paul Eggert <eggert@cs.ucla.edu>
172 Adjust to recent updates from gnulib.
173 * src/dd.c (apply_translations): Use toupper rather than
174 islower followed by toupper; it's simpler and typically
175 faster now that we assume at least C89 semantics. Similarly
177 * src/sort.c (inittables): Likewise.
178 * src/expand.c (expand): Don't assume that isprint etc. return
179 booleans (needed for pre-C99 hosts).
180 * src/fmt.c (check_punctuation): Likewise.
181 * src/ptx.c (initialize_regex, fix_output_parameters): Likewise.
182 * src/tr.c (is_char_class_member): Likewise.
183 * src/unexpand.c (unexpand): Likewise.
184 * src/join.c (is_blank): Remove; no longer needed. All uses
185 replaced by isblank (to_uchar (...)).
186 * src/pinky.c (create_fullname): Don't assume char is unsigned.
187 * src/printf.c (print_esc): Likewise.
188 * src/ptx.c (SKIP_NON_WHITE, SKIP_WHITE, SKIP_WHITE_BACKWARDS):
189 (copy_unescaped_string): Likewise.
190 * src/stat.c (print_it): Likewise.
191 * src/system.h (_D_EXACT_NAMELEN): Renamed from NLENGTH, for
192 convenience on GNU systems. All uses changed. Don't bother
193 looking for any dirent.h substitute other than ndir.h.
194 (D_INO): Remove unnecessary parentheses.
195 (IN_CTYPE_DOMAIN, ISGRAPH, ISPRINT, ISALNUM, ISALPHA):
196 (ISCNTRL, ISLOWER, ISPUNCT, ISSPACE, ISUPPER, ISXDIGIT):
197 (ISDIGIT_LOCALE, TOLOWER, TOUPPER): Remove. All uses changed
198 to ctype.h equivalents.
199 (isblank): Renamed from ISBLANK. Check for HAVE_DECL_ISBLANK too.
202 2006-07-08 Jim Meyering <jim@meyering.net>
204 * tests/mv/dir2dir: New file, test for 2006-07-05 fix in copy.c.
206 * Makefile.maint (sc_the_the): New rule.
208 * src/dd.c (skip): Remove one of two adjacent "the"s in a comment.
209 * tests/Coreutils.pm (run_tests): Remove one of two adjacent "then"s
212 2006-07-07 Jim Meyering <jim@meyering.net>
214 * NEWS: Mention that mv can now remove an empty destination directory,
215 and give an example. Prompted by a report from Florent Bayle.
217 2006-07-05 Jim Meyering <jim@meyering.net>
219 * src/ls.c (usage): Correct the description of -G: it is useful
220 only in a long listing. Reported by Martin Pool in
221 <https://launchpad.net/distros/ubuntu/+source/coreutils/+bug/51653>.
223 * man/chmod.x: Correct the description of the sticky bit. Reported
224 by Chris Moore via Ian Jackson in <http://bugs.debian.org/376745>.
226 * src/copy.c (copy_internal): Don't work around old NFS clients like
227 SunOS-4.1.4 and Irix 5.3 that set errno to values like EIO and
228 ENOTEMPTY upon failed rename. Otherwise, we risk misinterpreting
229 a banal failure as a recursive move-into-self failure.
230 Reported by Florent Bayle in <http://bugs.debian.org/376749>.
232 * src/c99-to-c89.diff: Regenerate, to remove fuzz.
234 2006-07-03 Jim Meyering <jim@meyering.net>
236 Plug another unusual leak.
237 (AD_mark_helper): Free malloc'd filename if hash_insert says
238 that string is already in the hash table.
240 The dev/inode of the topmost directory in each hierarchy were not
242 * src/remove.c (remove_cwd_entries): Don't call cycle_check here.
243 (AD_push): Call it from here instead.
246 * src/remove.c (AD_stack_clear): New function.
248 (AD_pop_and_chdir): Free *prev_dir just before longjmp.
250 * tests/Makefile.am, tests/*/Makefile.am: (TESTS_ENVIRONMENT):
251 Add $VG_PATH_PREFIX as a prefix to $PATH
253 * tests/envvar-check (vars): Add CDPATH and POSIXLY_CORRECT.
254 * tests/Makefile.am (evar-check): Remove rule.
255 (EXTRA_DIST): Remove .env-warn.
256 * tests/.env-warn: Remove file. No longer used.
257 Suggestion from Eric Blake.
259 2006-07-02 Paul Eggert <eggert@cs.ucla.edu>
261 * src/system.h: Include <stdint.h> unconditionally, since we
262 now assume the stdint module.
264 2006-07-01 Paul Eggert <eggert@cs.ucla.edu>
266 * NEWS: With no operand, 'tail -f' now silently ignores the '-f'
267 only if standard input is a FIFO or pipe and POSIXLY_CORRECT is set.
268 * src/tail.c (main): Implement this.
269 * tests/tail/Test.pm (f-pipe-1): Renamed from f-1.
270 (test_vector): Set POSIXLY_CORRECT for the f-pipe-* tests.
272 2006-07-01 Jim Meyering <jim@meyering.net>
274 * src/ln.c (do_link): Use new, shorter URL, for ag-review link.
276 * .x-sc_require_config_h: Add ^lib/xstrtold\.c$, so make distcheck
279 2006-06-30 Paul Eggert <eggert@cs.ucla.edu>
281 * NEWS: seq now uses long double internally rather than double.
282 It now defaults to a minimal fixed point format if possible.
283 It lets you use %a, %A, %E, %F, %G.
284 * src/Makefile.am (seq_LDADD): Remove $(SEQ_LIBM); add $(POW_LIB).
285 * src/seq.c: Don't include <math.h> or <xstrtol.h>; no longer needed.
286 (isfinite) [!defined isfinite]: New macro.
287 (separator, terminator): Now points to const.
288 (first, step, last): Remove.
289 (usage): Update to match new behavior.
290 (struct operand, operand): New type.
291 (scan_arg): Renamed from scan_double_arg, since we no longer use double.
293 Compute and return a value of type operand, not double.
294 (long_double_format): Renamed from valid_format, and now returns a
295 new format with an "L" added if needed, if the original format was
296 valid. Allow %a, %A, %E, %F, and %G formats.
297 (print_numbers): Take numeric values as args rather than from globals.
298 Print long double, not double.
299 (get_width_format): Remove.
300 (get_default_format): New function.
301 (main): Implement new way of calculating default format.
302 Don't worry about locale's representation of the decimal point, since
303 the arguments are always processed in the C locale.
304 * tests/seq/basic (neg-2): Adjust to new default format.
305 (eq-wid-1, eq-wid-2): Resurrect these tests, since the new
306 implementation should do the right thing.
308 2006-06-30 Jim Meyering <jim@meyering.net>
310 * tests/stty/basic-1: Work around an intermittent test failure
311 on HP-UX 11.11. Report and analysis from Bob Proulx.
312 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/7475
314 2006-06-28 Paul Eggert <eggert@cs.ucla.edu>
316 * NEWS: Support obsolete usages like "sort +1 -2" even when
317 conforming to POSIX 1003.1-2001, since this is a pure extension to
318 POSIX. Problem reported by Christian in:
319 http://lists.gnu.org/archive/html/bug-coreutils/2006-06/msg00220.html
320 * src/sort.c (main): Implement this.
322 * src/system.h (CLOSEDIR): Remove. All uses changed to closedir.
323 Autoconf 2.60 says this stuff was obsolete.
325 2006-06-28 Jim Meyering <jim@meyering.net>
327 * src/c99-to-c89.diff: Regenerate, to remove fuzz.
329 2006-06-28 Bob Proulx <bob@proulx.com> (tiny change)
331 * tests/mv/i-link-no: Work around HP-UX /bin/sh tracing problem
332 (set -x when VERBOSE=yes) when stderr is redirected before stdout
333 causing shell tracing of the stdout redirection to be written to
334 the stderr file. Avoid problem and test failure on HP-UX by
335 redirecting stderr last.
336 * tests/dd/unblock-sync: Order shell file redirections for
337 stderr and stdout in the common style.
340 2006-06-27 Jim Meyering <jim@meyering.net>
342 * tests/misc/cat-proc: Try to avoid any spurious numeric
343 differences in frequently-changing /proc/cpuinfo.
344 Reported by Nelson Beebe.
346 2006-06-26 Jim Meyering <jim@meyering.net>
348 Attempt rmdir (actually, unlinkat-with-AT_REMOVEDIR) upon any
349 fd_to_subdirp failure, not just when errno == EACCES.
350 * src/remove.c (remove_dir): Use unlinkat-with-AT_REMOVEDIR, not
351 rmdir, here, even though rmdir may happen to be adequate.
353 * NEWS: rm no longer fails to remove an empty, unreadable directory
354 * src/remove.c (remove_cwd_entries): If we can't open a directory,
355 and the failure is not being ignored, try to remove the directory
356 with rmdir (aka unlinkat-with-AT_REMOVEDIR), in case it's empty.
357 Problem report and test case from Paul Eggert in
358 <http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/7425>.
360 * tests/rm/empty-inacc: New test, for the above.
362 Avoid a segfault for wc --files0=- < /dev/null.
363 * src/wc.c (compute_number_width): Return right away if nfiles == 0.
365 2006-06-25 Jim Meyering <jim@meyering.net>
367 * NEWS: wc accepts a new option --files0-from=FILE, where FILE
368 contains a list of NUL-separated file names.
370 * src/wc.c: Include "readtokens.h".
371 (usage): Describe the new option, and adjust the `Usage':
372 with this option, no FILE may be specified on the command line.
373 (main): Handle the new option.
374 * tests/misc/wc-files0: New tests, for the above.
375 * tests/misc/wc-files0-from: Likewise.
376 * tests/misc/Makefile.am (TESTS): Add wc-files0.
378 2006-06-24 Jim Meyering <jim@meyering.net>
380 * src/md5sum.c (DIGEST_BUFFER): Remove now-unused definitions.
382 2006-06-22 Jim Meyering <jim@meyering.net>
384 * src/tee.c (tee_files): Rename from tee, to avoid conflict with
385 the function in glibc's <fcntl.h>. Reported by Andreas Schwab.
387 2006-06-19 Jim Meyering <jim@meyering.net>
389 * Makefile.cfg (local-checks-to-skip): Add changelog-check,
390 so this check is not run as part of "make distcheck".
392 2006-06-18 Bob Proulx <bob@proulx.com> (tiny change)
394 * tests/misc/pwd-long: Fix typo (s/neq/ne/) in previous change.
396 2006-06-18 Jim Meyering <jim@meyering.net>
398 * tests/misc/pwd-long: Make error output a little clearer.
400 2006-06-17 Jim Meyering <jim@meyering.net>
402 * tests/rm/inaccessible: Skip this test on systems without openat
403 support. Reported by Bob Proulx.
405 2006-06-15 Bob Proulx <bob@proulx.com> (tiny change)
407 * tests/misc/mknod: Improve permission checks to handle
408 running mkdir test in set-gid directories.
410 2006-06-14 Jim Meyering <jim@meyering.net>
412 * tests/du/basic: Revamp not to hard-code file system block sizes.
414 2006-06-12 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
416 * tests/du/Makefile.am (TESTS_ENVIRONMENT): Pass $(PERL), for
419 2006-06-11 Jim Meyering <jim@meyering.net>
421 * .gitignore: New file.
422 * Makefile.am (EXTRA_DIST): Add .gitignore.
424 Setting TIME_STYLE=long-iso in the environment would make the
425 cp/same-file test fail.
426 * tests/envvar-check (vars): Add TIME_STYLE to the list.
427 * tests/cp/same-file: Revert last change.
428 Source the envvar-check script, to ensure that TIME_STYLE
429 settings don't affect these tests.
431 2006-06-11 Paul Eggert <eggert@cs.ucla.edu>
433 * tests/cp/same-file: Execute 'ls' in the C locale, so that it
434 uses POSIX time stamp formats. Problem reported by John Nixon in
435 <http://lists.gnu.org/archive/html/bug-coreutils/2006-06/msg00062.html>.
437 2006-06-10 Jim Meyering <jim@meyering.net>
439 * NEWS: Mention the AIX-strndup-bug vs. dircolors workaround.
441 Require a "Version N.M" line at the top of the ChangeLog
442 file only when making the actual release, not when running
444 * Makefile.maint (maintainer-distcheck): Don't depend on
446 (alpha beta major): Depend on it here, instead.
448 2006-06-08 Jim Meyering <jim@meyering.net>
450 Ensure that cat works with any of the options, -A -v -e -E -T,
451 when applied to files in /proc and /sys, even when the FIONREAD
452 ioctl produces nonsensical results. Before this change, cat would
453 produce no output (or truncated output), for some linux kernels.
455 * src/cat.c (write_pending): New function, factored out of cat.
456 (cat): Also interpret a negative ioctl/FIONREAD count as indicating
457 that there are bytes to read. Some versions of linux-2.6.16 do that.
458 Write any pending output before returning.
459 Reported by Dan Jacobson in <http://bugs.debian.org/370583>.
460 * NEWS: Mention this bug fix.
461 * tests/misc/cat-proc: New file. Test for the above.
462 * tests/misc/Makefile.am (TESTS): Add cat-proc.
464 2006-06-07 Paul Eggert <eggert@cs.ucla.edu>
466 * src/expr.c (eval4): Detect overflow properly when multiplying
469 2006-06-06 Paul Eggert <eggert@cs.ucla.edu>
471 * NEWS: The 'expr' command now detects and reports integer overflow.
472 (It would be better to use extended precision instead, but that
474 * src/expr.c (integer_overflow): New function.
475 (eval4, eval3): Check for integer overflow.
477 2006-06-05 Paul Eggert <eggert@cs.ucla.edu>
479 Fix problems when building with Solaris/SVR4/etc. make, which uses a
480 different and somewhat bogus implementation of VPATH. In the
481 directory tests/misc, rename tests whose names might appear in the
482 Automake-generated rules. For example, we can't use a test named
483 'test', since Automake generates a rule that contains the text
484 "if test -f ./$$tst; ...", and this might expand to something like
485 "if ../../../coreutils-6.0/tests/misc/test -f ./$$test; ...",
486 which executes the 'test' script rather than the 'test' command.
487 * tests/misc/false-status: Renamed from tests/misc/false.
488 * tests/misc/pwd-long: Renamed from tests/misc/pwd.
489 * tests/misc/sort-merge: Renamed from tests/misc/sort.
490 ($prog): Set to 'sort' rather than to $PROG.
491 * tests/misc/test-diag: Renamed from tests/misc/test.
492 * tests/misc/Makefile.am (PROG): Take the basename of $$tst,
493 in case Solaris make has prepended the directory.
494 (TESTS): Adjust to above renamings.
495 * tests/misc/expand: Don't assign to PROG; no longer needed
496 now that Makefile.am sets PROG to the basename.
497 * tests/misc/fold: Likewise.
499 2006-06-03 Jim Meyering <jim@meyering.net>
501 Make `cp --link --no-dereference' work also on systems where the
502 link system call cannot create a hard link to a symbolic link.
503 * src/copy.c (copy_internal) [LINK_FOLLOWS_SYMLINKS]: Don't use
504 the link syscall on a symlink when it would do the wrong thing.
505 Based on the patch by Aurelien Jarno: <http://bugs.debian.org/329451>
506 * tests/cp/link-no-deref: New file/test for the above.
507 * tests/cp/Makefile.am (TESTS): Add link-no-deref.
508 * NEWS: Mention the change (doesn't affect Linux).
510 2006-06-01 Paul Eggert <eggert@cs.ucla.edu>
512 Fix some porting problems in the test cases reported by
513 Ralf Wildenhues for HP-UX 11.23 in:
514 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00238.html
515 * tests/help-version: Don't assume that \< \> works in sed.
516 * tests/misc/close-stdout: Don't assume that >&- works.
517 Add a /dev/full test.
518 * tests/touch/no-create-missing: Don't assume that >&- works.
520 2006-05-30 Jim Meyering <jim@meyering.net>
522 * src/ls.c (usage): Add `v' to the list of sorting-related options.
525 2006-05-28 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
527 * tests/cp/fail-perm: source lang-default.
528 * tests/rm/inaccessible: Likewise.
530 2006-05-28 Jim Meyering <jim@meyering.net>
532 * tests/rm/inaccessible: AIX 4.3.3 gives a different diagnostic.
533 Recognize it, too. Reported by Ralf Wildenhues, in
534 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
536 2006-05-27 Jim Meyering <jim@meyering.net>
538 * src/chgrp.c: Support new options: --preserve-root and
539 --no-preserve-root. Somehow this program was skipped when those
540 options were added to chown, chmod, and rm. Reported by
541 vaqflabuopac@spammotel.com in <http://bugs.debian.org/365656>.
542 * NEWS: Mention this.
544 2006-05-25 Paul Eggert <eggert@cs.ucla.edu>
546 * NEWS: Remove mention of --seed. We'll replace it with something
547 better, and don't want to indicate that it is supported.
548 * src/sort.c (usage): Likewise.
550 2006-05-20 Jim Meyering <jim@meyering.net>
552 * src/chmod.c (main): Use FTS_PHYSICAL here, too.
554 * src/du.c (main): Rename local, s/symlink_deref_bit/symlink_deref_bits/
555 and arrange for -D to set fts' FTS_PHYSICAL bit as well as
556 FTS_COMFOLLOW. Spotted by Justin Pryzby.
558 * gnupload: Merge changes from automake, retaining the ""--to...
559 kludge to placate overzealous `make distcheck' check.
561 2006-05-19 Jim Meyering <jim@meyering.net>
563 * src/du.c (main): Don't let -D, -L, or -P turn off the internal
564 FTS_TIGHT_CYCLE_CHECK directory traversal option.
565 Reported by Justin Pryzby in http://bugs.debian.org/367691
567 2006-05-15 Jim Meyering <jim@meyering.net>
569 * src/cp.c (usage): Correct description of -a: s/-dpR/-dpPR/.
572 2006-05-13 Jim Meyering <jim@meyering.net>
574 * tests/mv/no-target-dir: Test two more cases.
576 2006-05-11 Jim Meyering <jim@meyering.net>
578 mv -T DIR EMPTY_DIR no longer fails unconditionally
579 * src/copy.c (copy_internal): Don't manually prohibit a move where
580 the destination is an existing directory. Sometimes doing that is
581 valid. Let the rename system call enforce the rules. That is
582 allowed only when the source is a directory and the destination
583 directory (to be replaced) is empty. Reported by Eric Blake.
584 * tests/mv/no-target-dir: New file/test for this.
585 * tests/mv/Makefile.am (TESTS): Add no-target-dir.
586 * NEWS: Mention this.
588 * tests/mv/atomic: New file/test for yesterday's fix.
589 * tests/mv/Makefile.am (TESTS): Add atomic.
591 * tests/du/long-sloop: Avoid harmless `ambiguous redirect' diagnostic.
593 2006-05-10 Jim Meyering <jim@meyering.net>
595 * src/copy.c (copy_internal): Don't explicitly unlink the destination
596 when moving a symlink into the place of an existing non-directory.
597 Reported by Joshua Hudson.
598 * NEWS: mention this.
600 2006-05-07 Jim Meyering <jim@meyering.net>
602 * Makefile.maint (patch-check): Fail if patch generates any output,
603 even merely for changed offsets.
605 * src/c99-to-c89.diff: Adjust to reflect new offsets.
607 * NEWS: Mention changes affecting df, pwd, shred.
609 2006-05-06 Jim Meyering <jim@meyering.net>
611 * tests/ls/stat-vs-dirent: New test, to detect the bogus file
612 system condition where dirent.d_ino != stat.st_ino.
613 * tests/ls/Makefile.am (TESTS): Add stat-vs-dirent.
615 2006-05-06 Eric Blake <ebb9@byu.net>
617 * tests/ls/inode: Expand to test inode from readdir case.
618 * tests/ls/follow-slink: Expand to test broken links encountered
619 implicitly, favoring Solaris 9 and OpenBSD 3.4 behavior.
621 2006-05-06 Eric Blake <ebb9@byu.net>
623 * tests/mv/leak-fd: Work even on case-insensitive file system.
625 2006-05-04 Jim Meyering <jim@meyering.net>
627 * NEWS: Mention the 2006-03-19 pwd-related change that makes
628 lib/getcwd.c work around inconsistent file system dirent.d_ino data.
630 2006-05-03 Jim Meyering <jim@meyering.net>
632 * src/ls.c (DEFINE_SORT_FUNCTIONS, LIST_SORTFUNCTION_VARIANTS):
633 Use better macro parameter names: s/basename/key_name/,
634 s/basefunc/key_cmp_func. Fix typo in comment.
636 2006-04-29 Eric Blake <ebb9@byu.net>
638 * src/ls.c (main): On systems with d_type, directories_first only
639 implies format_needs_type, not format_needs_stat.
641 2006-05-03 Jim Meyering <jim@meyering.net>
643 * src/ls.c (xstrcoll_df_version, rev_xstrcoll_df_version): Add space
644 after comma in arg list, from Eric Blake.
646 2006-04-25 Paul Eggert <eggert@cs.ucla.edu>
648 * tests/misc/date (relative-3): New test, derived from a bug
649 report by John Thomas McDole.
651 2006-04-23 Francesco Montorsi <fr_m@hotmail.com>
653 New option for ls: --group-directories-first.
654 It makes ls list directories before files.
655 * NEWS [New features]: Mention it.
656 * src/ls.c (sort_type): Rearrange to use as an array index when
657 choosing sort function; added new sort_numtypes member for
659 (time_type): Add new time_numtypes member for compile-time check.
660 (directories_first): New global variable.
661 (GROUP_DIRECTORIES_FIRST_OPTION): New enum.
662 (long_options): Add --directories-first.
663 (main): Support new option.
664 (is_directory): New function.
665 (extract_dirs_from_files): Use it.
666 (DIRFIRST_CHECK, DEFINE_SORT_FUNCTIONS)
667 (LIST_SORTFUNCTION_VARIANTS): New macros.
668 (sort_functions): New global variable.
669 (sort_files): Use it.
670 (usage): Document new option.
672 2006-04-18 Paul Eggert <eggert@cs.ucla.edu>
674 * src/shred.c (fillrand): The assertion was way too weak, due to
675 what must be a typo. Strengthen it to its intended value.
676 (dopass): Don't use alloca; it's not worth the aggravation here,
677 since it's used only to get a page-aligned buffer, and page
678 alignment doesn't buy us much here. I'm suspicious that alloca
679 causes problems on some hosts, due to a recent bug report by Adam
680 Waltman: http://bugs.gentoo.org/130246.
682 2006-04-18 Jim Meyering <jim@meyering.net>
684 * tests/misc/tty-eof: Add new programs, base64, sha224sum, sha256sum,
685 sha384sum, sha512sum.
687 2006-04-17 Paul Eggert <eggert@cs.ucla.edu>
689 * src/chmod.c (describe_change): Adjust to filemode changes.
690 * src/ls.c (HAVE_ST_DM_MODE): Remove; moved to ../lib/filemode.c.
691 (print_long_format): Use (new) filemodestring rather than
692 (old) mode_string, so that we get more file types right, at least
693 in theory. Adjust to filemode changes.
694 * src/stat.c (human_access): Likewise.
696 2006-04-18 Jim Meyering <jim@meyering.net>
698 * src/ptx.c (main) [DEFAULT_IGNORE_FILE]: Remove code to use a default
699 ignore file. This has never been enabled. Reported by Eric Blake.
701 2006-04-12 Paul Eggert <eggert@cs.ucla.edu>
703 * src/ln.c (linkfunc): Remove. This method ran into a compiler/linker
704 bug in Interix. Just call symlink or link directly. All uses changed.
705 * src/setuidgid.c (main) [! HAVE_SETGROUPS]: Don't call setgroups.
706 * src/stat.c (USE_STATVFS): New macro.
707 Include <sys/statvfs.h> and use statvfs only if USE_STATVFS.
708 (NAMEMAX_FORMAT): define a bit more clearly, now that the
709 statvfs-using code is a bit more regular.
710 * src/system.h (sync) [!HAVE_SYNC]: New macro.
712 2006-04-11 Paul Eggert <eggert@cs.ucla.edu>
714 * NEWS: csplit, nl, expr now conform to POSIX better, and are
715 more-compatible with traditional Unix, with respect to regular
717 * src/csplit.c (extract_regexp): Set re_syntax_options to a
718 value that is compatible with what POSIX requires.
719 * src/nl.c (build_type_arg): Likewise.
720 * src/expr.c (docolon): Likewise. Also, don't let anchors match
721 newline; this fixes an incompatibility with tradition and with POSIX.
722 Don't warn about leading ^. POSIX says it is unspecified whether
723 ^ is a special character, which means that implementations can
724 either treat it as special or not, but either way a warning is not
725 allowed (unless the regexp is otherwise invalid). Instead, anchor
726 the expression but treat ^ as an anchor; this is the traditional
727 behavior (e.g., Solaris 10).
728 (eval4, eval3, eval2): Treat non-numeric args, division by zero,
729 and the like as invalid expressions (exit status 2), not as
730 failure of 'expr' (exit status 3). This is more consistent with
732 * tests/expr/basic (fail-a): Adjust exit status to match new expr
733 behavior, for status 2 versus 3.
735 (bre1, bre2, bre3, bre4, bre5, bre6, bre7, bre8, bre9, bre10):
736 (bre11, bre12, bre13, bre14, bre15, bre16, bre17, bre18, bre19, bre20):
737 (bre21, bre22, bre23, bre24, bre25, bre26, bre27, bre28, bre29, bre30):
738 (bre31, bre32, bre33, bre34, bre35, bre36, bre37, bre38, bre39, bre40):
739 (bre41, bre42, bre43, bre44, bre45, bre46, bre47, bre48, bre49, bre50):
740 (bre51, bre52, bre53, bre54, bre55, bre56, bre57, bre58, bre59, bre60):
741 (bre61, bre62): New tests.
742 * tests/misc/csplit: Use \{...\} in test RE, to test that we're
746 * tests/du/long-from-unreachable: Solaris 8 sh doesn't understand
747 "if !". Do not assume that 'sed' can handle long, newline-free input.
748 * tests/du/long-sloop: Likewise. Evaluate expr once, not $n times.
750 2006-04-10 Paul Eggert <eggert@cs.ucla.edu>
752 Adjust to new regex.h API (with new fastmap type), and clean
753 up the regex storage allocation a bit.
755 * src/csplit.c (struct control): Put re_compiled member at the
756 end, since it's large. Change regexpr member from char * to bool;
757 all uses changed. Add new member fastmap.
758 (extract_regexp): regexp arg is now char const *, not char *.
759 Don't bother duplicating the regular expression; it's not needed.
760 Set fastmap from new fastmap member. Don't bother allocating
761 a buffer, as the regexp code does a better job than we do.
762 * src/expr.c (docolon): Allocate and use a fastmap.
763 Don't bother allocating a buffer.
764 * src/nl.c (body_fastmap, header_fastmap, footer_fastmap):
766 (build_type_arg): New fastmap arg. All uses changed.
767 Don't bother allocating a buffer, but set a fastmap.
768 * src/ptx.c (context_regex_string, word_regex_string): Remove.
769 (context_regex, word_regex): New vars, replacing the above.
771 (struct regex_data): New type.
772 (compile_regex): Renamed from alloc_and_compile_regex, since
773 we no longer allocate storage. Arg is now a struct regex_data *,
774 not a const char *. All uses changed. Don't allocate the fastmap;
775 instead, take it from the caller. Don't convert size_t to int,
776 to avoid arithmetic overflow problems. Don't bother freeing
777 storage afterwards; it's not worth the aggravation.
778 * src/tac.c (compiled_separator_fastmap): New ver.
779 (main): Use it. Don't bother allocating a buffer.
781 2006-03-30 Jim Meyering <jim@meyering.net>
783 * src/dd.c (iwrite): Remove assignment without effect.
784 Reported by Felix Rauch Valenti.
786 2006-03-22 Eric Blake <ebb9@byu.net>
788 * src/ptx.c (usage): Remove mention of --copyright/-C.
789 (main): Alias --copyright to --version plus a deprecation warning.
790 * NEWS: Mention this.
792 2006-03-27 Jim Meyering <jim@meyering.net>
794 * src/Makefile.am (uptime_LDADD): Add $(POW_LIB), for uptime's
795 use of strtod. Tiny patch from Nickolai Zeldovich.
797 2006-03-11 Eric Blake <ebb9@byu.net>
799 * tests/misc/dirname: New file.
800 * tests/basename/Makefile.am: Delete.
801 * tests/basename/basic: Move to...
802 * tests/misc/basename: ... this new file. Add some tests,
803 including fixed behavior for //.
804 * tests/misc/Makefile.am (TESTS): Sort. Add basename, dirname.
805 * tests/Makefile.am (SUBDIRS): Remove basename.
806 * configure.ac (AC_CONFIG_FILES): Remove tests/basename.
808 Improvements to dirname/basename handling on platforms like
809 cygwin with distinct // and with drive letters.
810 * NEWS: Document new behavior.
811 * src/basename.c (main): Don't strip suffix from file system
813 * src/cp.c (target_directory_operand): Use new last_component.
814 (ASSIGN_BASENAME_STRDUPA): Likewise. Reduce time spent
815 traversing the string.
816 * src/dircolors.c (guess_shell_syntax): Use new last_component.
817 * src/install.c (target_directory_operand, install_file_in_dir):
819 * src/ln.c (target_directory_operand, main): Likewise.
820 * src/ls.c (basename_is_dot_or_dotdot): Likewise.
821 * src/mv.c (target_directory_operand, movefile): Likewise.
822 * src/remove.c (rm_1): Likewise.
823 * src/shred.c (wipename): Likewise.
824 * src/split.c (next_file_name): Likewise.
825 * src/su.c (log_su, run_shell): Likewise.
827 2006-03-23 Paul Eggert <eggert@cs.ucla.edu>
829 * NEWS: nohup diagnostics are now more precise, and nohup now
830 redirects stderr to nohup.out if stdout is closed and stderr is a tty.
831 * src/nohup.c (main): Implement this.
832 * tests/misc/nohup: Test the new behavior.
834 2006-03-12 Jim Meyering <jim@meyering.net>
836 * src/copy.c (set_author): Rename function, from preserve_author.
838 * src/remove.c (AD_pop_and_chdir): Use new macro,
839 CYCLE_CHECK_REFLECT_CHDIR_UP, rather than open-coding it.
841 * src/system.h (SAME_INODE): Remove definition.
842 Include "same-inode.h", instead.
844 2006-03-11 Eric Blake <ebb9@byu.net>
846 * src/pwd.c (robust_getcwd): Prepend only one slash, not two.
848 2006-03-10 Jim Meyering <jim@meyering.net>
850 Fix a bug whereby a user with write access to a directory being removed
851 could cause the removal of that directory to fail with an erroneous
852 diagnostic about a directory cycle. Reported by Vineet Chadha.
854 * NEWS: Mention this.
855 * src/remove.c (AD_pop_and_chdir): If the directory we're about to
856 leave (and try to rmdir) is the one whose dev_ino is being used to
857 detect a cycle, reset cycle_check_state.dev_ino to that of the parent.
859 2006-03-08 Paul Eggert <eggert@cs.ucla.edu>
861 * NEWS: Document dd's new 'directory' and 'nolinks' flags.
862 * src/dd.c (set_fd_flags): Handle file-creation flags on file
863 descriptors, rather than ignoring them.
864 * tests/dd/misc: Add test cases for append, nofollow, directory,
865 and nolinks flags. Simplify redirection to /dev/null in some cases.
867 * tests/dd/misc: iflags->iflag. This fixes a typo that meant the
868 noatime test never tested anything.
870 2006-03-05 Paul Eggert <eggert@cs.ucla.edu>
872 * src/dd.c (flags, usage): New flags directory, nolinks.
873 * src/system.h (O_NOLINKS): Define to 0 if not already defined.
875 * src/ls.c (usage): Mention that -f disables --color.
876 Problem reported by Niels Möller.
878 2006-03-03 Justin Pryzby <pryzbyj@justinpryzby.com>
880 * man/*.x: Add references to syscalls from utilities of the same name.
882 2006-03-05 Jim Meyering <jim@meyering.net>
884 * tests/help-version: Set SHELL, if not already set, in order to
885 avoid failure when `make check' is run through debuild; dircolors
886 would fail due to lack of $SHELL. Reported by Sven Joachim.
888 Make `base64 --wrap=N' work for N=0, and for N larger than SIZE_MAX.
889 * src/base64.c (wrap_write, do_encode, main): Change type of
890 parameters and locals, wrap_column, form size_t to uintmax_t.
891 (main): Adjust to use xstrtoumax, accordingly.
893 2006-03-03 Jim Meyering <jim@meyering.net>
895 Don't fail when run from an environment with SHELL not a Bourne
896 shell, e.g. `env SHELL=/bin/csh make check' would fail this test.
897 * tests/dircolors/simple: Invoke each non-failing test with -b.
898 Reported by Michael Stone.
900 2006-02-27 Jim Meyering <jim@meyering.net>
902 * tests/misc/base64: Derive --decode-using tests from the
905 * tests/misc/base64: Factor out a long constant string.
906 Split lines to stay within 80 columns.
908 * tests/misc/Makefile.am (TESTS): Add base64.
909 * tests/misc/base64: Test base64. From Simon Josefsson.
911 * src/base64.c (do_decode): Use correct type for parameter,
912 ignore_garbage: s/size_t/bool/.
914 * src/base64.c: Don't include .h files already included by system.h:
915 <string.h>, <stdlib.h>, <stdbool.h>, <limits.h>, <errno.h>.
916 Include "system.h" before the other lib/*.h header files.
917 Include <sys/types.h> before "system.h".
918 (wrap_write): Remove declaration of unused local, initial_column.
919 (wrap_write): Correct declaration syntax: s/size_t * V/size_t *V/.
921 * README: Add base64 to the list.
923 2006-02-17 Simon Josefsson <jas@extundo.com>
926 * AUTHORS: Mention base64.
928 * man/Makefile.am: Build base64.1.
929 * man/base64.x: New file.
930 * src/Makefile.am (bin_PROGRAMS): Add base64.
931 * src/base64.c: New file.
933 2006-02-25 Eric Blake <ebb9@byu.net>
935 In ls, avoid calling stat for --inode (-i), when possible.
936 * src/pwd.c (NOT_AN_INODE_NUMBER, D_INO): Move to ...
937 * src/system.h: ... here, for use in ...
938 * src/ls.c (main): ... here. Prefer dirent.d_ino to stat when
940 (gobble_file): Add inode argument.
941 (print_dir): Pass inode if available.
942 (usage): Remove inaccuracy.
944 2006-02-23 Jim Meyering <jim@meyering.net>
946 * TODO: Update/correct some obsolete entries.
948 2006-02-20 Paul Eggert <eggert@cs.ucla.edu>
950 * doc/coreutils.texi (join invocation): Mention `sort -k 1b,1'.
951 * src/join.c (usage): Likewise.
952 Documentation problem reported by Philip Kensche.
954 2006-02-20 Eric Blake <ebb9@byu.net>
956 * man/rm.x: Update documentation to match previous patch.
958 2006-02-18 Eric Blake <ebb9@byu.net>
960 New option for rm: --interactive=once (-I).
961 * NEWS: Document it, along with change to rm --interactive.
962 * TODO: Remove entry for implementing rm -I
963 * src/rm.c (INTERACTIVE_OPTION): New enum value.
964 (interactive_type): New enum.
965 (long_opts): Let interactive take an optional argument.
966 (interactive_args, interactive_types): New option arguments.
967 (usage): Document -I, --interactive=WHEN. Use program_name
968 instead of a basename.
969 (main): New -I option, new behavior to --interactive.
970 * tests/rm/interactive-once: New tests.
971 * tests/rm/interactive-always: Ditto.
972 * tests/rm/Makefile.am (TESTS): Run them.
974 2006-02-18 Jim Meyering <jim@meyering.net>
976 * Makefile.maint (sc_two_space_separator_in_usage): Make the regular
977 expression match more of the target lines, e.g., those that start with
978 `-S,' (short option followed by a comma) or that include `=[...]'.
979 Patch by Nicolas François.
980 Fix the four offenders thus exposed:
981 * src/join.c (usage): Use two spaces (not one) to separate the
982 --first-only option string from its description, so help2man formats
983 the derived man page properly.
984 * src/pr.c (usage): Likewise.
985 * src/uniq.c (usage): Likewise.
986 * src/install.c (usage): Likewise.
988 2006-02-15 Jim Meyering <jim@meyering.net>
990 * Makefile.maint (alpha beta major): For `make major', ensure that the
991 version string is of the form N.N[.N]*, where N is one or more digits.
993 2006-02-14 Jim Meyering <jim@meyering.net>
995 * INSTALL: Update from gnulib.
997 2006-02-13 Jim Meyering <jim@meyering.net>
999 * GNUmakefile (all): Emit diagnostics to stderr, not stdout.
1001 2006-02-12 Jim Meyering <jim@meyering.net>
1003 * Makefile.maint (patch-check): New target.
1004 (local-checks-available): Add to the list.
1006 2006-02-11 Jim Meyering <jim@meyering.net>
1008 * src/c99-to-c89.diff: New file.
1009 * src/Makefile.am (EXTRA_DIST): Add c99-to-c89.diff.
1011 * .x-po-check: New file, with exclusions so that `make distcheck'
1013 * Makefile.am (EXTRA_DIST): Add .x-po-check.
1015 rm -r must remove an empty directory, even if it is inaccessible.
1016 * src/remove.c (close_preserve_errno): New function.
1017 (fd_to_subdirp): Don't print a diagnostic in this function.
1018 Do it from the callers instead, unless rmdir succeeds.
1019 (remove_cwd_entries, remove_dir): Adjust callers.
1020 * tests/rm/empty-inacc: New test for the above.
1021 * tests/rm/Makefile.am (TESTS): Add empty-inacc.
1022 * NEWS: Mention this bug fix.
1023 * tests/rm/rm2: Adjust two expected diagnostics, now that they're
1024 a tiny bit less precise: cannot remove `a/1': ... instead of
1025 cannot open directory `a/1': ...
1027 * Makefile.maint (syntax-check-rules): Automatically derive this
1028 list of sc_-prefixed rule names.
1030 2006-02-10 Paul Eggert <eggert@cs.ucla.edu>
1032 * Makefile.maint (CVS_LIST): Don't assume cvsu is available.
1033 (CVS_LIST_EXCEPT): New macro, to simplify exception-processing.
1034 Most uses of CVS_LIST changed to use CVS_LIST_EXCEPT.
1035 (syntax-check-rules): Bring back sc_changelong. (Hmm, why did it
1036 go away? was that an accident?)
1037 (sc_cast_of_argument_to_free, sc_cast_of_x_alloc_return_value):
1038 (sc_cast_of_alloca_return_value, sc_space_tab, sc_prohibit_atoi_atof):
1039 (sc_error_exit_success, sc_file_system, sc_no_if_have_config_h):
1040 (sc_system_h_headers, sc_sun_os_names, sc_trailing_blank):
1041 (sc_two_space_separator_in_usage, sc_unmarked_diagnostics):
1042 (sc_obsolete_symbols, sc_changelog, sc_prohibit_jm_in_m4):
1043 (sc_useless_cpp_parens, makefile-check, m4-check, po-check):
1044 (author_mark_check, makefile_path_separator_check):
1045 Output line numbers, to simplify navigation of Emacs *compilation*
1047 (sc_prohibit_atoi_atof, sc_file_system):
1048 Rework slightly so that Makefile.maint doesn't get reported as a
1049 violation of its own syntax rules.
1050 (sc_dd_max_sym_length): Use ifneq to do nothing, instead of doing
1051 it at run-time (which didn't work with Bison). Fix a makefile typo,
1052 caught by Makefile.maint itself: spaces where a tab should be.
1053 (po-check): Check lib/*.[ch] even if not in CVS; used by Bison,
1054 which copies from ../gnulib/lib/*.[ch] to lib/*.[ch].
1055 Ignore djgpp and man subdirectories, to avoid false matches with
1056 Bison and coreutils, respectively. Use sort -u to remove the
1057 resulting duplicates.
1058 * gnupload: Rework slightly to avoid bogus warning from
1059 sc_two_space_separator_in_usage.
1061 2006-02-10 Jim Meyering <jim@meyering.net>
1063 Use gzip's --rsyncable option only if it's available.
1064 * Makefile.maint (gzip_rsyncable): New variable.
1067 2006-02-08 Jim Meyering <jim@meyering.net>
1069 * Makefile.maint (local-checks-available): Define in terms of
1070 the expansion, $(syntax-check-rules), rather than the single,
1071 top-level target `syntax-check', so that it's easier to exclude
1072 individual rules (via $(local-checks-to-skip)).
1073 (tgz-md5, tgz-sha1, ...): Remove now-unused definitions.
1075 2006-02-07 Jim Meyering <jim@meyering.net>
1077 * src/system.h (!defined O_DIRECT): If O_DIRECTIO is defined (as it
1078 is on Tru64), define O_DIRECT to that. Patch From James Lemley.
1080 * tests/help-version (expected_failure_status_vdir):
1081 Redirect an expected disk-full diagnostic to /dev/null.
1083 2006-02-06 Jim Meyering <jim@meyering.net>
1085 * src/unexpand.c (usage): Use two spaces (not one) to separate the
1086 --first-only option string from its description, so help2man formats
1087 the derived man page properly.
1088 * src/rm.c (usage): Likewise for --no-preserve-root.
1089 * src/chown.c (usage): Likewise.
1090 * src/chgrp.c (usage): Likewise.
1092 Add a rule to ensure that the above doesn't happen again.
1093 * Makefile.maint (sc_two_space_separator_in_usage): New rule.
1094 (syntax-check-rules): Add it.
1095 * .x-sc_two_space_separator_in_usage: New empty file.
1096 * Makefile.am (EXTRA_DIST): Add .x-sc_two_space_separator_in_usage.
1098 2006-02-06 Jim Meyering <jim@meyering.net>
1100 * src/cp.c (usage): Use two spaces (not one) to separate each
1101 option string from its description, so help2man formats the
1102 derived man page properly.
1103 * src/mv.c (usage): Likewise.
1104 Patch from Nicolas François in http://bugs.debian.org/351601.
1106 2006-02-04 Jim Meyering <jim@meyering.net>
1108 * src/copy.c (copy_internal): cp -RL would fail when encountering
1109 the same directory more than once in the hierarchy beneath a single
1110 command-line argument. That is legitimate, e.g. when there are
1111 two or more symbolic links, each pointing to some directory that
1112 would not otherwise be copied. Reported by Christophe LYON.
1113 * tests/cp/cp-deref: New file. Test for today's fix.
1114 * tests/cp/Makefile.am (TESTS): Add cp-deref.
1115 * NEWS: Document this.
1117 2006-02-03 Jim Meyering <jim@meyering.net>
1119 * configure.ac: Require automake-1.9.6, not 1.8.3.
1121 2006-02-01 Paul Eggert <eggert@cs.ucla.edu>
1123 * src/od.c (usage): Mention that -t a ignores high order bit.
1124 Documentation problem reported by Ed Avis.
1126 2006-02-01 Jim Meyering <jim@meyering.net>
1128 * src/pwd.c (find_dir_entry): Remove unused local, `ent_sb_valid'.
1130 2006-01-30 Paul Eggert <eggert@cs.ucla.edu>
1132 * src/head.c (main): Use a better diagnostic when someone uses a
1133 trailing numeric option in an invalid way. Problem reported by
1135 * src/tail.c (parse_options): Likewise.
1137 2006-01-30 Jim Meyering <jim@meyering.net>
1139 * man/wc.x: Include `count' keyword in man page synopsis,
1140 per suggestion from http://bugs.debian.org/181585.
1142 2006-01-24 Paul Eggert <eggert@cs.ucla.edu>
1144 * src/df.c (show_dev): If the file system claims to have
1145 more available than total blocks, report the number of used
1146 blocks as being total - available (a negative number) rather
1147 than as garbage. Problem reported by Toralf Foerster.
1149 2006-01-24 Jim Meyering <jim@meyering.net>
1151 * src/tail.c (tail_forever): Don't exit-nonzero when an attempt
1152 to put a regular file in O_NONBLOCK mode fails with EPERM.
1153 That happens on Linux (up to 2.6.15) when using tail -f on a file with
1154 the append-only attribute. Reported by Dean Gaudet. For details,
1155 see http://savannah.gnu.org/bugs/?func=detailitem&item_id=15473.
1156 * NEWS: Mention this fix.
1157 * tests/tail-2/append-only: New file. Test for the above.
1158 * tests/tail-2/Makefile.am (TESTS): Add append-only.
1159 * tests/Makefile.am (check-root): Add tail-2/append-only
1161 2006-01-21 Jim Meyering <jim@meyering.net>
1163 * NEWS: Mention fts-related improvements and bug fixes.
1165 2006-01-19 Jim Meyering <jim@meyering.net>
1167 * tests/fmt/basic (pfx-1, pfx-2): New tests, to demonstrate the bug
1168 reported as http://bugs.debian.org/147577. Forwarded by Thomas Hood.
1170 2006-01-18 Jim Meyering <jim@meyering.net>
1172 * tests/du/Makefile.am (TESTS): Add long-from-unreadable.
1174 2006-01-17 Jim Meyering <jim@meyering.net>
1176 Now that fts no longer changes the current working directory, adjust
1177 its clients accordingly -- note that du.c uses fts but doesn't need
1178 any adjustment, since it doesn't operate on the actual files,
1179 but rather just uses the stat buffers provided by fts.
1181 * src/chown-core.c: Include "openat.h".
1182 Don't include "lchown.h".
1183 (restricted_chown): Accept a new parameter, CWD_FD, and use it in
1184 calling openat, lchownat, chownat, rather than open, lchown, chown.
1186 * src/chmod.c: Include "openat.h".
1187 (process_file): Use chmodat (fts->fts_cwd_fd,... in place of chmod (...
1189 * tests/du/long-from-unreadable: New test, to exercise one small
1192 2006-01-13 Jim Meyering <jim@meyering.net>
1194 * tests/Makefile.am (SUBDIRS): Add comments discouraging the
1195 addition of new directories under tests/.
1197 * tests/acl: Redirect stdin to /dev/null. Otherwise, FreeBSD 5.0's
1200 2006-01-12 Jim Meyering <jim@meyering.net>
1202 * tests/du/long-sloop: Adjust not to hard-code the expected
1203 diagnostic corresponding to ELOOP. Solaris' diagnostic differs
1204 from that of GNU libc. Reported by Paul Eggert.
1206 * tests/du/long-sloop: Create file at end of symlink chain.
1208 * tests/misc/test: New file, with a test for one of the
1209 bugs fixed by yesterday's test.c changes.
1210 * tests/misc/Makefile.am (TESTS): Add test.
1212 2006-01-11 Jim Meyering <jim@meyering.net>
1214 * tests/du/long-sloop: New file. Test for today's fts.c bug fix.
1215 That bug could make du -L, chgrp -L, or chown -L fail to diagnose
1216 a very long sequence of symbolic links (not necessarily a loop).
1217 * tests/du/Makefile.am (TESTS): Add long-sloop.
1219 2006-01-11 Paul Eggert <eggert@cs.ucla.edu>
1221 * src/test.c (test_syntax_error): Append a newline. All callers
1222 changed, except for the ones that didn't already append a newline.
1223 Bug reported by Eric Blake.
1225 2006-01-11 Jim Meyering <jim@meyering.net>
1227 * src/system.h (X2NREALLOC): Now that verify_true is no longer
1228 void, cast its result to void, to avoid gcc's warning that
1229 ``left-hand operand of comma expression has no effect''.
1230 (DECIMAL_DIGIT_ACCUMULATE, X2REALLOC): Likewise.
1232 2006-01-10 Jim Meyering <jim@meyering.net>
1234 * tests/chmod/no-x: Add a test for today's fts.c fix.
1236 2006-01-10 Jim Meyering <jim@meyering.net> (tiny change)
1238 * src/ls.c (gobble_file): Use DTTOIF only if it's defined.
1239 This is necessary for Dragonfly. Patch by Joerg Sonnenberger.
1241 2006-01-10 Paul Eggert <eggert@cs.ucla.edu>
1243 * src/system.h (X2NREALLOC, X2REALLOC, DECIMAL_DIGIT_ACCUMULATE):
1244 Use verify_true instead of verify_expr, to sync with gnulib.
1246 2006-01-08 Jim Meyering <jim@meyering.net>
1248 * src/date.c (usage): Adjust the formatting of the entries for
1249 %::z and %:::z (separate with two spaces, not one) so that help2man
1250 formats them properly. Reported by Philip Rowlands.
1252 2006-01-06 Paul Eggert <eggert@cs.ucla.edu>
1254 * configure.ac (gl_IGNORE_UNUSED_LIBRARIES): Add.
1256 2006-01-06 Jim Meyering <jim@meyering.net>
1258 * Makefile.maint (copyright-check): Use date +%Y in place of
1261 * src/remove.c (rm_1): Remove `static' attribute on local `status'.
1262 First off, the attribute should have been `volatile' (not static)
1263 to avoid longjmp-related risk of clobber. Secondly, now there is
1264 no longer any risk of a local variable being clobbered, so there's
1265 no need for any attribute at all.
1267 2006-01-05 Jim Meyering <jim@meyering.net>
1269 * src/remove.c: Give a few functions the inline attribute.
1270 (AD_pop_and_chdir): Use gotos to avoid some duplication.
1271 (AD_push): Rewrite an assertion so that the entire computation
1272 goes away when assertions are turned off.
1274 * src/tail.c (ENOSYS) [!defined ENOSYS]: Don't define here.
1275 It's already defined in "system.h".
1276 * Makefile.maint: Add a FIXME comment.
1278 2006-01-04 Jim Meyering <jim@meyering.net>
1280 * ChangeLog: Remove entries from 2005-10-22 and earlier.
1281 * ChangeLog-2005: New file, for entries up to version 5.92.
1283 2006-01-03 Jim Meyering <jim@meyering.net>
1285 * tests/du/no-x: Also allow a slightly different diagnostic -- the
1286 one you get when using openat-enabled fts.c and du (coming soon).
1287 * tests/chmod/no-x: Likewise.
1288 * tests/chgrp/no-x: Likewise.
1290 * src/system.h (O_DIRECTORY) [!defined O_DIRECTORY]: Define.
1292 2006-01-02 Paul Eggert <eggert@cs.ucla.edu>
1294 * src/chown-core.c (RC_do_ordinary_chown): New enum value.
1295 (restricted_chown): Return it, if the file cannot be accessed due
1296 to EPERM, or if no uid or gid are required, or if the file is
1297 neither a directory nor a regular file. Rewrite to avoid gotos.
1298 (change_file_owner): Handle RC_do_ordinary_chown case.
1299 Rewrite to avoid gotos.
1300 * tests/chgrp/basic: Make sure we can change the group of
1303 * src/date.c (usage): Explain %g, %G, and %V a bit better.
1305 2006-01-02 Jim Meyering <jim@meyering.net>
1307 * src/copy.c (set_owner): Correct a comment.
1309 * src/tail.c (parse_options): Change warning to say that --retry
1310 is useful `mainly' (not `only') when following by name.
1311 Reported here: http://bugs.debian.org/273781
1313 2006-01-01 Paul Eggert <eggert@cs.ucla.edu>
1315 * NEWS: Document that mkfifo and mknod -m no longer set special bits.
1316 * src/copy.c: Include lchmod.h.
1317 (copy_internal): Use lchmod rather than chmod.
1318 * src/cp.c: Include lchmod.h.
1319 (re_protect, make_dir_parents_private): Use lchmod rather than chmod.
1320 * src/mkdir.c: Include lchmod.h.
1321 (usage): Clarify -m's operation.
1322 (main): Use lchmod rather than chmod. Don't use lchmod unless the
1323 new mode contains bits outside the 777 range.
1324 * src/mkfifo.c (usage): Clarify -m's operation.
1325 (main): If -m is given, don't invoke chmod; use umask 0 instead.
1326 Report an error if -m asks for bits outside the 777 range.
1327 * src/mknod.c (usage, main): Likewise.
1329 * src/mkdir.c, src/mkfifo.c, src/mknod.c: Undo 2005-12-19 changes.
1331 2005-12-27 Jim Meyering <jim@meyering.net>
1333 * Makefile.maint (sc_obsolete_symbols): Prohibit use of O_NDELAY.
1334 (sc_prohibit_assert_without_use): New rule.
1335 (syntax-check-rules): Add it to the list.
1336 * .x-sc_prohibit_assert_without_use: New empty file.
1337 * Makefile.am (EXTRA_DIST): Add it.
1339 * Makefile.maint (CVS_LIST): Define in terms of $(srcdir).
1341 * cp.c, df.c, link.c, mknod.c, nice.c, sleep.c, unlink.c:
1342 Don't include <assert.h>; it wasn't used.
1344 2005-12-26 Paul Eggert <eggert@cs.ucla.edu>
1346 * src/chown-core.c (restricted_chown):
1347 Don't try O_WRONLY unless O_RDONLY failed wth EACCES.
1348 * src/remove.c (fd_to_subdirp): Open with O_DIRECTORY | O_NOCTTY
1349 | O_NOFOLLOW too, for consistency with other dir-openers.
1350 Use POSIX-preferred O_NONBLOCK rather than O_NDELAY.
1351 (is_empty_dir): Likewise.
1352 * src/shred.c (wipename): Likewise. Don't bother trying to open
1353 dir for writing, since POSIX prohibits it.
1355 2005-12-22 Jim Meyering <jim@meyering.net>
1357 * tests/help-version: Redirect stderr to /dev/full, to suppress
1358 write error diagnostic.
1360 2005-12-19 Jim Meyering <jim@meyering.net>
1362 * src/mkdir.c, src/mknod.c, src/mkfifo.c (main)
1363 Avoid a minor race condition when `-m MODE' is specified, by using
1364 open, fchown, and close rather than just chown. To do that reliably --
1365 even with an overly restrictive umask -- ensure that each mkdir,
1366 mknod and mkfifo call uses a mode including at least owner-read access.
1367 * src/mknod.c (main): When `-m MODE' is specified, exit nonzero if
1368 the subsequent chown (or equivalent open,fchown,close) fails.
1369 * tests/misc/mknod: New tests.
1370 * tests/misc/Makefile.am (TESTS): Add mknod.
1372 2005-12-17 Jim Meyering <jim@meyering.net>
1374 * src/remove.c (is_empty_dir): Open with O_NDELAY, so we don't hang,
1375 e.g., on a named pipe.
1376 (OPEN_NO_FOLLOW_SYMLINK): Remove definition. Use O_NOFOLLOW in
1377 place of all uses, since it is guaranteed (system.h) to be defined.
1379 2005-12-05 Andreas Gruenbacher <agruen@suse.de>
1381 Add POSIX ACL support
1382 * src/ls.c: Switch back from HAVE_ACL to USE_ACL: The acl() syscall
1383 is no requirement for ACL support; particularly, it does not exist
1384 on systems that have POSIX ACLs.
1385 * src/copy.h (cp_option_init) [umask_kill]: Remove member.
1386 * src/cp.c (umask_kill): With default acls, the umask is not to be
1387 applied. Remove umask_kill, don't change the process umask, and let
1388 the kernel apply the umask where appropriate.
1389 * src/cp.c (make_dir_parents_private): Fix logic for POSIX ACLs.
1390 * src/copy.c (get_dest_mode): Remove; it is obsolete after removing
1392 (copy_reg, copy_internal): Use copy_acl and set_acl
1393 instead of fchown/chown. Fix the logic for POSIX ACLs.
1394 (chown_succeded): Remove; we now always copy acls and
1395 preserve S_ISUID, S_ISGID, and S_ISVTX when needed, no matter if we
1396 did a chown before or not.
1397 * src/mv.c, src/install.c (cp_option_init): Don't set umask_kill member.
1398 * src/Makefile.am (dir_LDADD, ls_LDADD, vdir_LDADD, cp_LDADD,
1399 mv_LDADD, ginstall_LDADD): On systems with an ACL library, arrange
1400 to link with it via $(LIB_ACL), for the utilities that need it.
1402 2005-12-16 Paul Eggert <eggert@cs.ucla.edu>
1404 * src/remove.c (OPENAT_CWD_RESTORE__REQUIRE): Remove.
1405 (OPENAT_CWD_RESTORE__ALLOW_FAILURE): Likewise.
1406 (fd_to_subdirp): Remove openat_cwd_restore_allow_failure arg; its
1407 value is now signified by whether cwd_errno is null.
1408 (fd_to_subdirp, remove_dir, rm_1); Change cwd failure indicator from
1409 pointer-to-bool to pointer-to-errno-value. All callers changed.
1410 (rm_1): Don't bother setting a local cwd failure flag and then
1411 ORing it into the caller's. Just set the caller's.
1412 (rm): Use cwd failure errno value to print a slightly-better
1415 2005-12-15 Jim Meyering <jim@meyering.net>
1417 * src/stat.c (print_it): Properly handle a backslash at the
1418 end of a --printf format string. Reported by Paul Eggert.
1419 * tests/misc/stat-printf (end-bs): Add a test for the above.
1421 2005-12-15 Paul Eggert <eggert@cs.ucla.edu>
1423 * tests/acl: Port to pre-POSIX shells like Solaris 8 /bin/sh.
1424 Don't assume /etc/passwd contains user names; use 'id' instead.
1426 2005-12-15 Jim Meyering <jim@meyering.net>
1428 stat: revert behavior of --format=FMT (-c)
1429 stat: add new option: --printf=FMT
1430 * NEWS: Mention this.
1431 * src/stat.c (isodigit, octtobin, hextobin): Define.
1432 (PRINTF_OPTION): Define.
1433 (interpret_backslash_escapes, trailing_delim): New globals.
1434 (usage): Document them. Alphabetize on long option names.
1435 (print_esc_char): New function.
1436 (print_it): Rewrite, in order to handle backslash escapes.
1437 (main): Handle new option. Set globals for --format, too.
1439 * tests/misc/stat-printf: Test --printf and --format.
1440 * tests/misc/Makefile.am (TESTS): Add stat-printf.
1442 2005-12-14 Paul Eggert <eggert@cs.ucla.edu>
1444 * NEWS: sort now reports incompatible options.
1445 * src/sort.c (incompatible_options, check_ordering_compatibility):
1447 (main): Use them. Don't bother with a usage message for
1448 "sort -c a b", for consistency with other error diagnostics.
1449 * tests/sort/Test.pm (incompat1, incompat2, incompat3, incompat4):
1452 * src/cat.c (main): Undo previous change. close_stdout already
1453 does the check, so the previous change wasn't necessary.
1455 2005-12-13 Paul Eggert <eggert@cs.ucla.edu>
1457 * src/cat.c (main): Check for close (STDOUT_FILENO) failure.
1459 2005-12-12 Paul Eggert <eggert@cs.ucla.edu>
1461 Install a more-conservative approach for sort -R. It's the
1462 same basic idea as the existing code, except it uses the full ISAAC
1463 approach (called the "more kosher" approach in the existing comments).
1464 This makes "sort -R" quite a bit slower (about a factor of 2 on my
1465 little tests involving 10000 lines on a 2.4 GHz P4), but I think it's
1466 better to be conservative here at first, and review any performance
1467 improvements carefully.
1468 * .x-sc_require_config_h: Add src/rand-isaac.c.
1469 * src/rand-isaac.h: Remove. All uses now simply include rand-isaac.c.
1470 * src/Makefile.am (noinst_HEADERS): Remove rand-isaac.h.
1471 (shred_SOURCES, sort_SOURCES): Remove.
1472 (EXTRA_DIST): Add rand-isaac.c.
1473 * src/rand-isaac.c: Revert to what used to be in shred.c, without
1474 changing it to allow for varying numbers of words in the state.
1475 Alter so that we include rand-isaac.c directly rather than
1476 compiling it and linking to it. Don't include config.h or
1477 system.h; that's the includer's responsibility.
1478 Omit functions that are specific to shred.
1479 (ISAAC_LOG, ISAAC_WORDS, ISAAC_BYTES, struct isaac_state, ind):
1480 (isaac_step, struct irand_state):
1481 Resurrect these, with the same defns that used to be in shred.c.
1482 (ISAAC_SIZE, isaac_new, isaac_copy): Remove.
1483 (isaac_refill, isaac_seed_start, isaac_seed_data, irand_init, irand32):
1485 (struct isaac_state, isaac_refill, isaac_mix, isaac_init):
1486 (isaac_seed_start, isaac_seed_data, isaac_seed_finish, isaac_seed):
1487 (irand_init, irand32, irand_mod):
1488 Number of words is constant again.
1489 (struct irand_state, irand_init, irand32, irand_mod): Move to shred.c.
1490 * src/shred.c: Include rand-isaac.c rather than rand-isaac.h.
1491 * src/sort.c: Likewise.
1492 * src/shred.c (fillrand, dopass, main): Undo previous change.
1493 (struct irand_state, irand_init, irand32, irand_mod): Moved back here,
1495 * src/sort.c: Don't include md5.h; it wasn't needed.
1496 (struct keyfield): Rename random_hash to random, for consistency
1497 with the other member names. All uses changed.
1498 (usage): Tweak wording to mention STRING for --seed option.
1499 (short_options): Rorder for consistency with other programs.
1500 (rand_state): Now a struct, not a pointer to one. All uses changed.
1501 (HASH_WORDS, HASH_SIZE): Remove.
1502 (get_hash): Remove comments around resbuf size, since we can assume C89.
1503 Use a "more-kosher" (but slower) approach of invoking isaac_refill.
1504 (keycompare): Adjust to the new get_hash.
1506 (badfieldspec): Omit recently-introduced comment; it isn't needed.
1507 (main): Don't set need_random simply because gkey has it set; that
1508 doesn't necessarily mean we'll need random numbers.
1509 Redo seeding to match new get_hash approach.
1511 2005-12-10 Jim Meyering <jim@meyering.net>
1513 * src/Makefile.am (noinst_HEADERS): Add rand-isaac.h.
1515 Avoid shred segfault on 64-bit systems.
1516 * src/rand-isaac.c (isaac_refill): Don't try to negate a
1517 local of type uint32_t. Make the local an `int' instead.
1519 * NEWS: Mention sort's new options.
1521 * src/rand-isaac.c (isaac_mix): Declare to be static.
1522 Mark all other functions as `extern' so the tight-scope
1523 part of `make distcheck' passes once again.
1524 * src/rand-isaac.h (isaac_mix): Remove declaration.
1526 * src/sort.c (get_hash): Change position of `*' in parameter
1527 type to conform with convention.
1528 (main): Split a long line so it fits in 80 columns.
1529 (keycompare): Remove stray SPACE before TAB that was
1530 causing `make distcheck' to fail.
1532 * src/shred.c: Don't include gethrxtime.h. No longer needed.
1534 * tests/misc/sort-rand: New file: basic tests for the new options.
1535 * tests/misc/Makefile.am (TESTS): Add sort-rand.
1537 2005-12-10 Frederik Eaton <frederik@ofb.net>
1539 * src/Makefile.am (sort_LDADD): Add $(LIB_GETHRXTIME).
1540 (shred_SOURCES, sort_SOURCES): New macros, so we compile rand-isaac.c.
1541 * src/rand-isaac.c: New file, containing ISAAC code that was in shred.c.
1542 Make state size runtime-configurable.
1543 (isaac_new, isaac_copy): New functions.
1544 * src/rand-isaac.h: New file.
1545 * src/shred.c: Include rand-isaac.h. Move ISAAC code to rand-isaac.c.
1546 (fillrand, main): Adjust to the fact that the state size is now
1547 runtime-configurable.
1548 * src/sort.c (short_options, long_options, WORDS, keycompare, main):
1549 (usage): Add options --random-sort and --seed to implement a random
1551 Include md5.h and rand-isaac.h.
1552 (get_hash): New function.
1553 (rand_state): New var.
1554 (HASH_WORDS, HASH_SIZE): New macros.
1556 2005-12-09 Paul Eggert <eggert@cs.ucla.edu>
1558 * tests/dd/misc: Add test for dd iflags=noatime.
1560 2005-12-09 Jim Meyering <jim@meyering.net>
1562 * src/sort.c (usage): Mention white space vs -b and -t options.
1565 2005-12-09 Eric Blake <ebb9@byu.net>
1567 * src/test.c (main): Fix misleading comment.
1569 2005-12-07 Paul Eggert <eggert@cs.ucla.edu>
1571 * NEWS: Mention dd's new noatime flag.
1572 * src/system.h (O_NOATIME): Define to 0 if not already defined.
1573 * src/dd.c (flags, usage): Add support for noatime flag.
1575 2005-12-07 Jim Meyering <jim@meyering.net>
1577 Distribute the cvsu script, used only by `make syntax-check'.
1578 * Makefile.am (EXTRA_DIST): Add build-aux/cvsu.
1579 * Makefile.maint (CVS_LIST): Use build-aux/cvsu, now that we
1580 distribute a copy of this script.
1581 * .x-sc_unmarked_diagnostics: Add build-aux/cvsu.
1583 * tests/mv/acl: exit-77 before the trap, not after, if we fail
1584 to create a temporary directory on another partition.
1585 From Andreas Gruenbacher.
1587 2005-12-06 Tomas Pospisek <tpo@sourcepole.ch> (tiny change)
1589 * man/basename.x: Cross-reference to dirname and readlink.
1590 * man/dirname.x: Cross-reference to basename and readlink.
1592 2005-12-05 Andreas Gruenbacher
1594 * src/copy.c [!HAVE_FCHOWN]: Define fchown(...) to -1.
1595 (set_owner, preserve_author): New functions, factored out of copy_reg.
1596 (copy_reg): Use them.
1597 (copy_internal): Use them here, too.
1599 2005-12-04 Jim Meyering <jim@meyering.net>
1601 * src/sleep.c (usage): Say what happens with two or more arguments.
1602 Suggested by Justin Pryzby.
1604 * src/uptime.c (print_uptime): Move decl of `upsecs' into scope
1607 2005-12-03 Jim Meyering <jim@meyering.net>
1609 * src/rm.c (long_opts): Change the name of each undocumented, for-
1610 testing-only option to start with `-', so that it cannot render
1611 ambiguous any prefix it happens to share with some other option name.
1612 Problem reported by Eric Blake.
1613 * src/head.c (long_options): Likewise.
1614 * src/tail.c (long_options): Likewise.
1616 * tests/misc/head-elide-tail: Update uses of undocumented, for-
1617 testing-only --presume* options to start with `---'.
1618 * tests/rm/dangling-symlink: Likewise.
1619 * tests/rm/dir-no-w: Likewise.
1620 * tests/rm/isatty: Likewise.
1622 2005-11-30 Jim Meyering <jim@meyering.net>
1624 * Makefile.maint: Add a comment about cvsu.
1626 2005-11-25 Paul Eggert <eggert@cs.ucla.edu>
1628 * NEWS: df updates for "none", "proc", inaccessible file systems.
1629 * src/df.c (show_point): Ignore inaccessible file systems.
1630 (usage): -a includes dummy file systems, not size-0 file systems.
1632 * src/od.c (unsigned_long_long_int): Renamed from ulonglong_t,
1633 to avoid collision with POSIX name space. All uses changed.
1635 2005-11-24 Jim Meyering <jim@meyering.net>
1637 * tests/Makefile.am (EXTRA_DIST): Add acl to the list.
1638 * tests/acl: Add `$0: ' prefix to diagnostics.
1640 * .x-sc_require_config_h: Add lib/buffer-lcm.c to the list.
1642 2005-11-23 Paul Eggert <eggert@cs.ucla.edu>
1644 * src/copy.c: Improve performance a bit by optimizing away
1645 unnecessary system calls and going to a block size of at least
1646 8192 (on normal hosts, anyway). This improved performance 5% on my
1647 Debian stable host (2.4.27 kernel, x86, copying from root
1648 ext3 file system to itself).
1649 Include "buffer-lcm.h".
1650 (copy_reg): Omit last argument. All callers changed.
1651 Use xmalloc to allocate rather than trusting alloca
1652 (which is unwise with large block sizes).
1653 Declare locals more locally, if possible.
1654 Use uintptr_t words instead of int words, for a bit more speed
1655 when looking for null blocks on 64-bit hosts.
1656 Optimize away reads of zero bytes on regular files.
1657 In the typical case, insist on 8 KiB buffers, at least.
1658 Avoid unnecessary extra call to fstat when checking for sparse files.
1659 Avoid now-unnecessary cast to off_t, and "0L".
1660 Avoid unnecessary test of *new_dst when checking for same owner
1663 2005-11-22 Paul Eggert <eggert@cs.ucla.edu>
1665 * src/remove.c (rm): Don't assume C99 for-loop syntax.
1667 2005-11-22 Jim Meyering <jim@meyering.net>
1669 * src/remove.c (AD_push): Remove debugging cruft.
1671 * tests/rm/unread2 (rm): Change expected diagnostic,
1672 `cannot open directory' to `cannot remove', to align with
1674 * tests/rm/rm2: Ensure that rm now continues removing entries
1675 even after certain types of failure.
1677 * src/remove.c: Rewrite. Now, this module is reentrant on systems
1678 that provide openat (Solaris), and on systems like Linux+procfs
1679 where our openat emulation code is reentrant. This also fixes a
1680 few low-probability leaks and eliminates some code that could,
1681 in very unusual circumstances, cause rm() (via a callee) to exit.
1682 * NEWS: Mention this.
1684 * configure.ac: Put copyright dates all on one line so the
1685 emacs function that updates them works properly.
1687 2005-11-18 Paul Eggert <eggert@cs.ucla.edu>
1689 * configure.ac (AM_PROG_CC_C_O): Add. Needed for CVS Automake.
1690 Problem reported by Eric Blake.
1691 (AC_PROG_CC_STDC): Use this instead of AC_PROG_CC, so that
1692 we get a standard-conforming compiler. This relies on the new
1693 m4/c.m4 file. Note that it's a bit tricky, since c.m4 doesn't
1694 define AC_PROG_CC_STDC; we are relying on Autoconf 2.59 internals.
1695 m4/c.m4 can go away with Autoconf 2.60 comes out.
1697 2005-11-17 Jim Meyering <jim@meyering.net>
1699 * src/remove.c (AD_mark_helper): Make a `char *' parameter `const'.
1700 (AD_mark_current_as_unremovable): Likewise, but for a local.
1703 * tests/mv/acl: Let traps handle removing temporary directories.
1705 Expect acl-related tests to fail, until the corresponding
1706 patches are committed.
1707 * tests/mv/Makefile.am (XFAIL_TESTS): Add acl.
1708 * tests/cp/Makefile.am (XFAIL_TESTS): Likewise.
1710 ACL tests, from Andreas Gruenbacher.
1711 * tests/acl, tests/mv/acl, tests/cp/acl: New files.
1712 * tests/mv/Makefile.am (TESTS): Add acl.
1713 * tests/cp/Makefile.am (TESTS): Add acl.
1715 * src/ls.c (basename_is_dot_or_dotdot): Correct wording in comment.
1717 2005-11-16 Paul Eggert <eggert@cs.ucla.edu>
1719 * NEWS: Improve quality of ln's diagnostics.
1720 * src/ln.c (do_link, usage): Likewise.
1721 (do_link): Don't use alloca on a buffer of unbounded size.
1723 2005-11-16 Jim Meyering <jim@meyering.net>
1725 * tests/cp/fail-perm: Accommodate HPUX. It appears to fail
1726 with EACCES rather than EPERM. Reported by Peter O'Gorman here:
1727 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/5766
1728 This also affects AIX 4.3.3, according to Ralf Wildenhues, in
1729 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
1731 2005-11-14 Jim Meyering <jim@meyering.net>
1733 * NEWS (sort): Mention consequences of today's mkstemp-safer.c fix.
1735 2005-11-13 Jim Meyering <jim@meyering.net>
1737 * announce-gen: Accept new option, --gpg-key-id=ID and
1738 emit a blurb telling how to use the .sig files.
1739 * Makefile.cfg (gpg_key_ID): Define.
1740 * Makefile.maint (announcement): Use new option and key.
1742 Require that most .c files include <config.h>.
1743 * Makefile.maint (sc_require_config_h): New rule.
1744 (syntax-check-rules): Add it.
1745 * .x-sc_require_config_h: New file listing exceptions to the
1746 above rule. Some are legit, others are simply grandfathered in.
1747 * Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h here, too.
1749 2005-11-12 Jim Meyering <jim@meyering.net>
1751 * src/checksum.h, src/md5.c, src/sha1sum.c: Remove now-unused files.
1753 2005-11-11 Jim Meyering <jim@meyering.net>
1755 * NEWS: Mention `readlink -f' bug fix in 5.3.0 news.
1756 Mention new readlink options in 5.3.0's `New features' section.
1757 Spotted by Thomas Hood.
1759 2005-11-08 Jim Meyering <jim@meyering.net>
1761 * NEWS: Merge in changes from b5_9x branch.
1763 2005-11-08 Paul Eggert <eggert@cs.ucla.edu>
1765 * NEWS: ls now defaults to --time-style='locale', which in turn acts
1766 like --time-style='posix-long-iso' if the locale settings are messed up.
1767 * src/ls.c (decode_switches): Implement this.
1769 2005-11-08 Jim Meyering <jim@meyering.net>
1771 * tests/du/2g: s/expensive/very expensive/ in a comment.
1774 2005-10-17 Eric Blake <ebb9@byu.net>
1776 * src/ls.c (usage): Fix descriptions of --sort, --time.
1777 Reported by Vitaly A. Ostanin.
1779 2005-11-04 Paul Eggert <eggert@cs.ucla.edu>
1781 * src/ln.c: Include filenamecat.c.
1782 (FILE_BASENAME_CONCAT): Remove.
1783 (do_link): Remove last arg DEST_IS_DIR. All callers changed.
1784 (main): Use file_name_concat, base_name, and strip_trailing_slashes
1785 instead of FILE_BASENAME_CONCAT. This simplifies the code, and avoids
1788 2005-11-04 Jim Meyering <jim@meyering.net>
1790 * src/du.c (process_file): Don't overflow for files of size >= 2^31
1791 on systems with stat.st_blocks of a signed 32-bit type.
1792 This bug causes trouble on some AIX 5.1 systems.
1793 Report and trivial patch from Paul Townsend:
1794 <http://lists.gnu.org/archive/html/bug-coreutils/2005-11/msg00033.html>
1795 * NEWS: Mention this.
1797 * tests/du/2g: New (very-expensive) test for the above-fixed bug.
1798 * tests/du/Makefile.am (TESTS): Add it here.
1799 * tests/very-expensive: New file.
1800 * tests/Makefile.am (EXTRA_DIST): Add it here.
1801 * tests/cp/perm: Mark this test as `very-expensive', too.
1803 2005-11-02 Paul Eggert <eggert@cs.ucla.edu>
1805 * NEWS: Mention that rm -d and maybe ln -d are scheduled for
1807 * src/remove.h (struct rm_options): Remove unlink_dirs. All uses
1809 * src/rm.c (usage): Don't mention rm -d.
1811 2005-11-02 Jim Meyering <jim@meyering.net>
1813 * tests/dd/skip-seek: Fix typo in comment: s/fileutils/coreutils.
1814 From Andreas Schwab.
1816 * tests/dd/unblock-sync: Redirect stderr to /dev/null so the
1817 `M+N records in/out' lines don't pollute `make check' output.
1819 * tests/dd/skip-seek (sk-seek4): New test, to exercise the bug
1820 fixed on 2005-10-31. This test uses the new, IN_PIPE specifier.
1821 * tests/Coreutils.pm: Accept a new type of input specifier: IN_PIPE,
1822 to indicate that the input file should be piped into the command
1823 under test (via `cat FILE | $prog ...').
1825 * src/remove.c (remove_entry): Emit a better diagnostic when rm
1826 (without -r) fails to remove a directory on a non-Linux system.
1827 This change affects only newer Solaris systems (with priv_*
1828 functions like priv_allocset). Reported by Keith Thompson.
1830 * tests/rm/dir-nonrecur: New file/test for the above fix.
1831 * tests/rm/Makefile.am (TESTS): Add dir-nonrecur.
1833 2005-11-01 Paul Eggert <eggert@cs.ucla.edu>
1835 * NEWS: "tail -c 2 FILE" and "touch 0101000000" now operate as
1836 POSIX 1002.1-2001 requires.
1837 * src/tail.c (parse_obsolete_option): Implement this.
1838 Problem reported by Vincent Lefevre.
1839 * src/touch.c (main): Pass PDS_PRE_2000 to posixtime.
1840 * tests/tail/Test.pm (c-2, c-2-minus, c2, c2-minus): New tests.
1841 (test_vector): Add special cases for _POSIX2_VERSION, and
1842 regularize the old ones a bit.
1843 * tests/touch/obsolescent: Add y2000 test.
1845 2005-10-31 Paul Eggert <eggert@cs.ucla.edu>
1847 * src/dd.c (skip): Fix off-by-one error reported by
1848 Theodoros V. Kalamatianos.
1850 2005-10-30 Paul Eggert <eggert@cs.ucla.edu>
1852 * tests/mkdir/p-3: Require that the test be run as non-root.
1853 Problem and trivial fix reported by Theodoros V. Kalamatianos.
1855 2005-10-28 Paul Eggert <eggert@cs.ucla.edu>
1857 * src/ln.c (FILE_BASENAME_CONCAT): Omit unnecessary slashes in the
1858 boundary between DEST and SOURCE in the result.
1860 2005-10-26 Dmitry V. Levin <ldv@altlinux.org>
1862 * src/md5sum.c (main) [!O_BINARY]: Changed default read mode
1863 back to text, to sync with documentation and for backwards
1866 2005-10-25 Jim Meyering <jim@meyering.net>
1868 * tests/dircolors/simple (other-wr): Add an explicit test for
1869 the dircolors bug (NULL-dereference) fixed yesterday.
1871 2005-10-24 Jim Meyering <jim@meyering.net>
1873 * src/tac.c (tac_file): When determining whether a file is seekable,
1874 also test whether it is a tty. Using only the lseek-based test would
1875 give a false positive on Solaris. Reported by Peter Fales.
1877 2005-10-24 Dmitry V. Levin <ldv@altlinux.org>
1879 * tests/install/d-slashdot: New test, for "install -d" failure.
1880 * tests/install/Makefile.am (TESTS): Add d-slashdot.
1881 * tests/mkdir/p-slashdot: New test, for "mkdir -p" failure.
1882 * tests/mkdir/Makefile.am (TESTS): Add p-slashdot.
1884 2005-10-24 Jim Meyering <jim@meyering.net>
1886 * src/dircolors.c (ls_codes): Add missing comma.
1887 Anonymous report and patch from
1888 http://savannah.gnu.org/bugs/?func=detailitem&item_id=14849
1890 * src/dircolors.c: Add compile-time assertion that the slack_codes
1891 and ls_codes arrays have the same number of elements. This would
1892 have prevented the above-fixed bug.
1894 * src/expand.c (parse_tab_stops): Add a comment to make this function
1895 identical to the one in unexpand.c.
1896 * src/unexpand.c (parse_tab_stops): Adjust syntax to make this function
1897 identical to the one in expand.c.
1899 * src/expand.c (next_file): Don't assume fopen cannot return stdin.
1901 2005-10-23 Jim Meyering <jim@meyering.net>
1903 * src/md5sum.c (digest_check, main): Use ptr_align rather than
1904 a dangerous pointer-value-to-`unsigned' cast.
1905 * NEWS: mention the new sha* programs.
1906 * AUTHORS: Add new sha* programs.
1908 2005-08-28 David Madore <david.madore@ens.fr>
1910 Add new programs: sha224sum, sha256sum, sha384sum, sha512sum.
1911 * README: Add their names to the list.
1912 * src/md5sum.c: Provide framework for computing sha-2 hashes.
1913 * src/Makefile.am (sha224sum, sha256sum, sha384sum, sha512sum):
1914 Rules for compiling sha-2 utilities
1915 (noinst_HEADERS): Remove checksum.h.
1916 * man/sha512sum.x, man/sha384sum.x, man/sha256sum.x, man/sha224sum.x:
1918 * man/Makefile.am (dist_man_MANS): Add the corresponding .1 names.
1919 (sha224sum.1, sha256sum.1, sha384sum.1, sha512sum.1): New dependencies.
1920 * tests/misc/sha224sum, tests/misc/sha256sum: New files.
1921 * tests/misc/sha384sum, tests/misc/sha512sum: New files.
1922 * tests/misc/Makefile.am (TESTS): Add new sha224sum, sha256sum,
1923 sha384sum, sha512sum test scripts here rather that each in its
1926 2005-08-28 David Madore <david.madore@ens.fr>
1928 * tests/sha1sum/basic-1 (million-a): Add the "million a's" test (one
1929 of the FIPS test vectors).
1931 2005-10-23 Jim Meyering <jim@meyering.net>
1933 * configure.ac: Use 6.0-cvs as the version string.
1934 * NEWS: Adjust accordingly.