1 2005-06-16 Jim Meyering <jim@meyering.net>
5 Don't embed `this'-style quotes in format strings.
6 * src/tr.c: Rather than this: error (..., "...`%s'...", arg);
7 do this: error (..., "...%s...", quote (arg));
8 * src/od.c, src/tr.c, src/csplit.c, src/date.c, src/hostname.c:
9 * src/join.c, src/ptx.c, src/seq.c, src/sort.c, src/split.c:
10 * src/split.c, src/tail.c: Likewise.
12 * src/sleep.c: Include "quote.h". Remove hard-coded quotes, as above.
13 * src/nice.c, src/printf.c, src/fold.c, src/pr.c: Likewise.
14 * src/factor.c, src/cat.c, src/expr.c, src/stty.c: Likewise.
16 * src/mv.c: Finally remove support for --version-control=S (-V).
17 It was deprecated nearly 6 years ago and has been warning
18 users to switch to --backup=S since fileutils-4.0j.
19 * src/cp.c, src/install.c, src/ln.c: Likewise.
21 2005-06-15 Jim Meyering <jim@meyering.net>
23 * src/install.c (main): Fix my typo: s/argv[optind]/file[i]/.
24 * tests/install/basic-1: Ensure that each `-d'-specified directory
25 is created. Ensure that rel-named dirs are not created when
28 * tests/mkdir/p-3: Add a test for just-fixed bug in mkdir-p.c.
30 2005-06-14 Paul Eggert <eggert@cs.ucla.edu>
32 Improve diagnostics for restore_cwd failure.
33 * src/install.c (main): Standardize on a diagnostic for
34 restore_cwd failure, and report errno.
35 (install_file_in_file_parents): Fail if restore_cwd fails and
36 one of the files is relative. This fixes a bug (albeit unlikely).
37 * src/mkdir.c (create_parents): Remove static var (now local to 'main').
38 (main): Standardize on a diagnostic for restore_cwd failure,
40 Don't bother to check cwd_errno unless create_parents.
41 Use mkdir rather than make_dir; it's simpler.
43 * src/install.c (main): Adjust to new make_dir_parents convention.
44 * src/mkdir.c (main): Likewise.
46 2005-06-14 Jim Meyering <jim@meyering.net>
48 * tests/mkdir/p-3: Ensure mkdir succeeds if the following argument
49 is an absolute directory name.
51 * Makefile.maint (my-distcheck): Add -Wall to the list of options that
52 are used with -Werror. This target is not intended for general use.
54 2005-06-13 Jim Meyering <jim@meyering.net>
56 * src/mkdir.c (main): Give a diagnostic for -- and skip -- each
57 relative directory name after make_dir_parents fails to restore
58 the working directory. Before, `mkdir -p' could create directories
59 in the wrong place in unusual circumstances.
60 * src/install.c (main): Likewise.
61 (install_file_in_file_parents): Update make_dir_parents caller.
62 * tests/mkdir/p-3: New test for today's mkdir.c/mkdir-p.c bug fixes.
63 * tests/mkdir/Makefile.am (TESTS): Add p-3.
65 2005-06-10 Paul Eggert <eggert@cs.ucla.edu>
67 Act on the Austin Group's response yesterday to XCU ERN 63; see
68 <http://www.opengroup.org/austin/docs/austin_260.txt>.
69 * NEWS: ls no longer outputs an extra space between mode and link count.
70 * doc/coreutils.texi: Remove the extra spaces in "ls -l" output.
71 * src/ls.c (any_has_acl): New var.
72 (clear_files): Clear it.
73 (gobble_file): Set it if a file has an ACL.
74 (print_long_format): Omit needless space unless some file has an ACL.
76 2005-06-10 Jim Meyering <jim@meyering.net>
78 * src/system.h (VERIFY_W_TYPEOF): Add parentheses.
80 2005-06-02 Jim Meyering <jim@meyering.net>
82 * src/sort.c (usage): Put `Ordering options:' line where it belongs.
84 2005-06-01 Paul Eggert <eggert@cs.ucla.edu>
86 Use "file name" when talking about file names, instead of "filename"
87 or "path", as per the GNU coding standards.
88 * src/basename.c: Don't use "path" or "filename".
89 * src/copy.c: Likewise.
90 * src/copy.h: Likewise.
91 * src/cp-hash.c: Likewise.
94 * src/install.c: Likewise.
96 * src/pinky.c: Likewise.
98 * src/pwd.c: Likewise.
99 * src/remove.c: Likewise.
100 * src/rmdir.c: Likewise.
101 * src/sort.c: Likewise.
102 * src/system.h: Likewise.
103 * src/tty.c: Likewise.
104 * src/who.c: Likewise.
105 * src/cp.c (parents_option): Renamed from flag_path. All uses changed.
106 (make_dir_parents_private): Renamed from make_path_private.
108 * src/cp.c (usage): Don't use "path" to describe a file name.
109 * src/readlink.c (usage): Likewise.
110 * src/rmdir.c (usage): Likewise.
111 * src/df.c: Don't include "path-concat.h"; not needed.
112 * src/install.c (install_file_in_file_parents): Renamed from
113 install_file_to_path. All uses changed.
114 * src/ln.c (FILE_BASENAME_CONCAT): Renamed from PATH_BASENAME_CONCAT.
116 * src/ls.c (make_link_name): Renamed from make_link_path.
118 * src/pwd.c (struct file_name): Renamed from struct Path.
120 (file_name_free): Renamed from path_free. All uses changed.
121 (file_name_init): Renamed from path_init. All uses changed.
122 (file_name_prepend): Renamed from path_prepend. All uses changed.
123 * src/rmdir.c (remove_empty_parents): Renamed from empty_paths.
125 (longopts): Add comment that --path is deprecated.
127 2005-05-31 Jim Meyering <jim@meyering.net>
129 * src/copy.c (chown_privileges, chown_failure_ok): Mark as `extern'.
130 This is a crutch so that `make distcheck's sc_tight_scope rule
131 knows that they really are deliberately declared that way.
133 2005-05-30 Paul Eggert <eggert@cs.ucla.edu>
135 Port to Solaris 10's rules for whether programs can chown files.
136 * src/copy.c [HAVE_PRIV_H]: Include <priv.h>.
137 (DO_CHOWN): Remove. Replaced by chown_failure_ok. All callers
139 (copy_internal): If chown failed, don't worry about what happened
140 to the mode bits; they can't have changed.
141 (chown_privileges, chown_failure_ok): New functions.
142 * src/copy.h: Add copyright notice.
143 (struct cp_options): Remove myeuid member. Add chown_privileges
145 (chown_privileges, chown_failure_ok): New function decls.
146 * src/cp.c (re_protect): Remove unnecessary call to geteuid.
147 Use chown_failure_ok rather than our own code.
148 * src/cp.c (cp_options_init): Use chown_privileges rather than geteuid.
149 * src/install.c (cp_option_init): Likewise.
150 * src/mv.c (cp_option_init): Likewise.
152 2005-05-29 Paul Eggert <eggert@cs.ucla.edu>
154 * src/chgrp.c (getgrnam) [!defined _POSIX_VERSION]: Remove decl.
155 * src/chown-core.c (getgrnam, getgrgid) [!defined _POSIX_VERSION]:
157 * src/cp.c (geteuid) [!defined _POSIX_VERSION]: Remove decl.
158 * src/id.c (getpwuid, getgrgid, getuid, getgid, geteuid, getegid)
159 [!defined _POSIX_VERSION]: Remove decls.
160 * src/install.c (getpwnam, getgrnam): Remove decl.
161 (getuid, getgid) [!defined _POSIX_VERSION]: Remove decls.
162 * src/md5sum.c (OPENOPTS, TEXT1T01, TEXTCNVT): Remove.
163 (digest_file): Use O_BINARY-using expr instead of OPENOPTS.
164 * src/system.h: Don't bother mentioning _POSIX_VERSION in comment.
165 * src/test.c: Include sys/param.h if it exists, not if _POSIX_VERSION
167 Don't include <sys/file.h>; no longer needed.
168 (getegid, geteuid): Remove no-longer-necessary decls.
170 * src/pathchk.c (_POSIX_PATH_MAX) [!defined _POSIX_PATH_MAX]:
171 Define to 256, not 255, as per modern POSIX.
173 2005-05-27 Paul Eggert <eggert@cs.ucla.edu>
175 * NEWS: dd seek=N now conforms to POSIX if the output isn't seekable.
176 * src/dd.c (skip): Return the number of records that were not
177 skipped due to encountering EOF.
178 (dd_copy): If the file wasn't seekable and EOF was encountered,
179 write zeros past EOF until the desired offset is reached.
181 * NEWS: expr and test now correctly compare integers of unlimited size.
182 (Also, correct a comment that claimed that expr detects integer
183 overflow; it does so only when converting from strings.)
184 * src/expr.c: Include strnumcmp.h, xstrtol.h.
185 (looks_like_integer): New function.
186 (toarith): Use it. Also, use xstrtoimax rather than rolling our
188 (eval2): Don't look for trouble if !evaluate; this simplifies things.
189 Compare numbers using string comparison, so that overflow is
191 * src/sort.c: Refactor so that others can use large-integer
192 comparison functions.
193 Include "strnumcmp.h".
194 (NEGATION_SIGN, NUMERIC_ZERO, fraccompare):
195 Remove; moved to strnumcmp.
196 (decimal_point): Now int, to simplify converison overhead with
197 new API. All uses changed.
198 (thousands_sep): Now -1 if there isn't one, as per new API.
200 (numcompare): Move contents to strnumcmp module, except for
202 * src/test.c: Include inttostr.h, strnumcmp.h.
203 (whitespace, digit, digit_value, integer_expected_error): Remove.
204 (is_int): Remove; replaced by...
205 (find_int): New function.
206 (binary_operator): Don't let integers overflow in comparisons;
207 return the correct answer instead. Simplify the code.
208 (unary_operator): Convert the integer ourself, since find_int
210 * tests/expr/basic (bigcmp): New test.
211 * tests/test/Test.pm (eq-6, gt-5, lt-5): New tests.
213 2005-05-26 Paul Eggert <eggert@cs.ucla.edu>
215 * NEWS: nohup now redirects a tty stdin to an unreadable fd
216 instead of closing it.
217 * doc/coreutils.texi (nohup invocation): Document this.
218 * src/nohup.c (main): Implement this.
220 2005-05-26 Jim Meyering <jim@meyering.net>
222 * src/expr.c (toarith): Fix a sign error introduced on 2005-01-14.
223 Reported by David Alan Gilbert.
224 * tests/expr/basic: Add tests using arithmetic on negative integers.
226 2005-05-19 Jim Meyering <jim@meyering.net>
228 * src/remove.c (AD_mark_helper, AD_mark_current_as_unremovable):
229 Remove inaccurate-but-harmless `const' attributes.
231 * src/join.c (decode_field_spec): Add an abort after
232 `error (EXIT_FAILURE, ...' to avoid a gcc warning in caller,
233 about variables being used uninitialized.
235 2005-05-18 Paul Eggert <eggert@cs.ucla.edu>
237 * configure.ac: Add copyright notice. gl_LIB_CHECK -> cu_LIB_CHECK.
238 * src/Makefile.am: Add copyright notice.
239 (factor_LDADD): Remove, as factor no longer needs sqrt.
240 * src/hostname.c: Remove test for HAVE_LIMITS_H; we can assume
241 it's always true now.
243 2005-05-16 Paul Eggert <eggert@cs.ucla.edu>
245 Fix Cygwin porting problem reported by Eric Blake.
246 * src/remove.c (DT_IS_DIR): Remove.
247 (DT_IS_KNOWN, DT_MUST_BE): New macros.
248 (remove_entry): Use them.
250 2005-05-14 Paul Eggert <eggert@cs.ucla.edu>
252 * src/remove.c: Include unlinkdir.h.
253 (UNLINK_CAN_UNLINK_DIRS): Remove.
254 (remove_entry): Use cannot_unlink_dirs () rather than
255 UNLINK_CAN_UNLINK_DIRS.
257 2005-05-14 Jim Meyering <jim@meyering.net>
259 Update FSF postal mail address.
260 * Makefile.maint, Makefile.cfg, gnupload
261 * src/basename.c, src/cat.c, src/checksum.h, src/chgrp.c
262 * src/chmod.c, src/chown-core.c, src/chown-core.h, src/chown.c
263 * src/chroot.c, src/cksum.c, src/comm.c, src/copy.c, src/copy.h
264 * src/cp-hash.c, src/cp-hash.h, src/cp.c, src/csplit.c, src/cut.c
265 * src/date.c, src/dcgen, src/dd.c, src/df.c, src/dircolors.c
266 * src/dirname.c, src/du.c, src/echo.c, src/env.c, src/expand.c
267 * src/expr.c, src/factor.c, src/fmt.c, src/fold.c, src/fs.h
268 * src/groups.sh, src/head.c, src/hostid.c, src/hostname.c, src/id.c
269 * src/install.c, src/join.c, src/kill.c, src/lbracket.c, src/link.c
270 * src/ln.c, src/logname.c, src/ls-dir.c, src/ls-ls.c, src/ls-vdir.c
271 * src/ls.c, src/ls.h, src/md5.c, src/md5sum.c, src/mkdir.c
272 * src/mkfifo.c, src/mknod.c, src/mv.c, src/nice.c, src/nl.c
273 * src/nohup.c, src/od.c, src/paste.c, src/pathchk.c, src/pinky.c
274 * src/pr.c, src/printenv.c, src/printf.c, src/ptx.c, src/pwd.c
275 * src/readlink.c, src/remove.c, src/remove.h, src/rm.c, src/rmdir.c
276 * src/seq.c, src/setuidgid.c, src/sha1sum.c, src/shred.c
277 * src/sleep.c, src/sort.c, src/split.c, src/stat.c, src/stty.c
278 * src/su.c, src/sum.c, src/sync.c, src/system.h, src/tac-pipe.c
279 * src/tac.c, src/tail.c, src/tee.c, src/test.c, src/touch.c
280 * src/tr.c, src/true.c, src/tsort.c, src/tty.c, src/uname.c
281 * src/unexpand.c, src/uniq.c, src/unlink.c, src/uptime.c
282 * src/users.c, src/wc.c, src/who.c, src/whoami.c, src/yes.c
284 2005-05-13 Jim Meyering <jim@meyering.net>
286 * NEWS: `rm -r' now removes all of the files it should, even on
287 systems with a buggy readdir affecting file systems inaccessible
290 In some unusual circumstances `rm -r' would fail to remove --
291 or even consider -- all entries in a directory with more than 254
292 (SunOS) or 338 (Darwin) entries. This could cause trouble even on
293 other types of systems when using an affected file system via e.g.,
294 NFS. The underlying cause was a bug in readdir on those systems.
295 Coreutils-5.2.1 and earlier used a configure-time test designed
296 to detect precisely those problem systems, but it would detect
297 the problem and enable remove.c's work-around code only when its
298 configure-time test was run on a losing file system. Obviously,
299 it couldn't detect a problem if the offending file system wasn't
300 tested or even mounted at coreutils configure time. Now, rm itself
301 performs a minimal-cost run-time test to detect the problem.
303 * src/remove.c (CONSECUTIVE_READDIR_UNLINK_THRESHOLD): Define.
304 (remove_cwd_entries): When readdir returns NULL for a directory from
305 which we've removed more than CONSECUTIVE_READDIR_UNLINK_THRESHOLD
306 entries, call rewinddir and then resume the readdir/unlink loop.
307 (UNLINK_CAN_UNLINK_DIRS): Rename from ROOT_CAN_UNLINK_DIRS.
309 2005-05-12 Paul Eggert <eggert@cs.ucla.edu>
311 * NEWS: nohup now closes stdin if it is a terminal, unless
312 POSIXLY_CORRECT is set. This fixes a glitch noted by Wayne Pollock in
313 <https://www.opengroup.org/sophocles/show_mail.tpl?
314 source=L&listname=austin-group-l&id=8341>.
315 * doc/coreutils.texi (nohup invocation): Document this.
316 * src/nohup.c (main): Implement this.
318 2005-05-12 Jim Meyering <jim@meyering.net>
320 * src/date.c: Assume `free (NULL)' works.
321 * src/dd.c: Likewise.
323 * src/dircolors.c:Likewise.
324 * src/head.c: Likewise.
325 * src/ls.c: Likewise.
326 * src/md5sum.c: Likewise.
327 * src/pr.c: Likewise.
328 * src/sort.c: Likewise.
330 2005-05-10 Jim Meyering <jim@meyering.net>
332 * tests/touch/not-owner: Skip this test if the user running it
333 owns `/' or has write access to it.
335 * src/copy.c (abandon_move): Remove erroneous UNWRITABLE check.
336 This makes `mv -i --reply=no f1 f2' work as expected (in not
337 performing the move operation). But note that specifying `-i'
338 after `--reply=no' does *not* work.
339 Tiny patch from Vlada Macek.
341 * tests/mv/reply-no: New file. Test for the above fix.
342 * tests/mv/Makefile.am (TESTS): Add reply-no.
344 * tests/ls-2/tests: Don't print PATH to stderr.
346 2005-05-08 Paul Eggert <eggert@cs.ucla.edu>
348 * NEWS: cp, ln, mv, rm no longer discard white space when intepreting
351 2005-05-06 Paul Eggert <eggert@cs.ucla.edu>
353 * NEWS: dd has new iflag= and oflag= flags "binary" and "text".
354 * src/dd.c (flags, usage): Add support for "binary" and "text".
356 2005-05-04 Paul Eggert <eggert@cs.ucla.edu>
358 * NEWS: chmod -w now complains if it differs from chmod a-w.
359 * src/chmod.c: Include quotearg.h.
360 (diagnose_surprises): New var.
361 (process_file): Diagnose surprises. Simplify the logic a bit,
363 (main): Prepare to diagnose surprises. Remove useless code for
365 * tests/chmod/Makefile.am (TESTS): Add umask-x.
366 * tests/chmod/umask-x: New file.
368 2005-05-02 Paul Eggert <eggert@cs.ucla.edu>
370 * NEWS: ls --indicator-style=directory renamed to ls
371 --indicator-style=slash, to avoid confusion with ls --directory.
372 * src/ls.c (usage): Likewise.
373 (slash): Renamed from directory_only. All uses changed.
375 2005-05-01 Paul Eggert <eggert@cs.ucla.edu>
377 * NEWS: "chmod +1 foo" is now diagnosed.
379 2005-04-29 Paul Eggert <eggert@cs.ucla.edu>
381 * NEWS: ls -p now marks only directories. New option
382 --indicator-style=directory equivalent to -p.
383 * doc/coreutils.texi (ls invocation): Document this.
384 Also, mention ">" is for doors.
385 * src/ls.c (enum indicator_style): New constant directory_only,
387 (indicator_style_args, indicator_style_types): Set it appropriately.
388 (decode_switches, gobble_file, print_type_indicator):
389 (length_of_file_name_and_frills):
390 Implement the change described in NEWS.
391 (decode_switches): Quote ">", too.
392 (usage): Update to match the new behavior. Describe ">".
393 * tests/ls/file-type: Test for new behavior. Omit -1 option.
394 The "ls --color" test wasn't being checked; add a check for
395 "ls --color=auto" instead.
397 * tests/head/Test.pm: Don't set _POSIX2_VERSION; no longer needed.
398 * tests/misc/split-fail: Likewise.
399 * tests/pr/Test.pm: Likewise.
400 * tests/sort/Test.pm: Fix comment to match new behavior of "sort".
401 * tests/tail/Test.pm (tv): Rename tests from obs to obs-plus
402 if they use file names starting with +.
403 (test_vector): Don't set _POSIX2_VERSION if obs but not obs-plus.
404 * tests/uniq/Test.pm (tv, test_vector): Likewise.
406 The following was partly derived from a tiny change by Eric Blake:
407 * tests/misc/nice: Don't use 'set -'. It's not portable to strict
408 POSIX 1003.1-2001 hosts. Also, don't set _POSIX2_VERSION.
409 * tests/mkdir/perm: Don't use 'set -'. Simplify test construction.
410 Work even if the underyling system attaches ACLs to new dirs.
411 * tests/mv/part-hardlink: Don't use 'set -'.
412 * tests/stty/row-col-1: Don't use 'set -'.
414 2005-04-28 Paul Eggert <eggert@cs.ucla.edu>
416 * NEWS: Document fixes described below.
417 * src/chmod.c (change, umask_value): New static vars.
418 (reference_file): Move this static var to inside "main".
419 (process_file, process_files): Remove CHANGES arg; now taken from
420 static var. All uses changed.
421 (usage): Fix incorrect description of MODE operand.
422 (main): For invalid mode usages, output a brief usage message.
423 Adjust to new modechange API.
424 * install.c (main): Adjust to new modechange API.
425 Also, free the mode_change object when done.
426 * mkdir.c (main): Likewise.
427 * mkfifo.c (main): Likewise.
428 * mknod.c (main): Likewise.
429 * tests/chmod/equal-X: Check for =xX bug.
430 * tests/chmod/equals: Check for =u bug.
431 * tests/chmod/usage: Check for u+gr and ug,+x bugs.
433 2005-04-26 Paul Eggert <eggert@cs.ucla.edu>
435 Restore support for usages like "head -1" and "tail -1",
436 even when conforming to POSIX 1003.1-2001.
437 Fix bug with "POSIXLY_CORRECT=1 fold file -3".
438 join now supports a NUL field separator, e.g., "join -t '\0'".
439 join now detects and reports incompatible options, e.g.,
441 * NEWS: Document this.
442 * src/date.c: Remove posixver.h and its uses.
443 (COMMON_SHORT_OPTIONS): Remove.
444 (short_options): New constant.
445 (short_options, usage): -I now always takes an optional arg.
446 * src/expand.c: Remove posixver.h and its uses.
447 (shortopts): New constant. -DIGIT now always takes an optional arg.
448 (main): Revamp parsing of -DIGIT to let parse_tab_stops handle it.
449 Don't complain about -DIGIT.
450 * src/fold.c: Remove posixver.h and its uses.
451 (shortopts): New constant. -DIGIT now always takes an optional arg.
452 (main): Don't preprocess arg list; that was buggy. Use method
454 * src/head.c: Remove posixver.h and its uses.
455 (header_mode_option): Remove.
456 (main): Don't complain about obsolete -NUM args.
457 * src/join.c: Remove posixver.h and its uses.
458 (obsolete_usage): Remove.
459 (join_field_1, join_field_2): Initialize to SIZE_MAX to indicate
460 they haven't been set yet.
461 (tab): Now int, not char. Initialize to -1 to indicate white space
462 separates columns, so that we can use NUL as a separator.
464 (OBSOLETE_LONG_OPTIONS, get_option): Remove.
465 (string_to_join_field): Remove ERR_MSG_FMT arg; a single format
466 suffices. Use xstrtoul for sizes; it suffices.
467 (decode_field_spec): Report an error and exit on failure. Return void,
469 (add_field_list): Likewise.
470 (set_join_field): New function.
471 (enum operand_status): New enum.
472 (add_file_name): New args OPERAND_STATUS, JOPTION_COUNT,
473 PREV_OPTC_STATUS, OPTC_STATUS to handle the bewildering array of
474 possibilities with obsolete option parsing.
475 (main): Use it. Do not depend on POSIX version.
476 Check for conflicting options. Parse obsolete options -j1 and -j2
477 so that it is a pure extension to POSIX 1003.1-2001.
478 Allow '-t\0' to specify a NUL tab, stealing the code from 'sort'.
479 * src/nice.c: Remove posixver.h and its uses.
480 (main): Always support -NUM option.
481 * src/od.c: Remove posixver.h and its uses.
482 (short_options): New constant, which always supports -w[num].
483 (COMMON_SHORT_OPTIONS): Remove.
484 * src/pr.c: Remove posixver.h and its uses.
485 (short_options): New constant, which always supports -S[string].
486 (COMMON_SHORT_OPTIONS): Remove.
487 * src/sort.c: Remove posixver.h and its uses.
488 (short_options): New constant, which always supports -y arg.
489 (COMMON_SHORT_OPTIONS): Remove.
490 (main): Redo workaround for Solaris compatibility with -y.
491 This change isn't visible to the user; it just cleans up the
492 code so that we don't need posixver.h.
493 * src/split.c: Remove posixver.h and its uses.
494 (main): Don't complain about -NUM option.
495 * src/tail.c (parse_obsolete_option): Don't complain about -NUM.
496 * src/unexpand.c: Remove posixver.h and its uses.
497 (main): Don't complain about -TAB.
498 * src/uniq.c (main): Don't complain about -NUM.
500 2005-04-22 Paul Eggert <eggert@cs.ucla.edu>
502 * src/nohup.c (main): If getopt fails, exit with status 127,
503 not status 1. POSIX requires this.
504 * NEWS: Document this.
506 * src/nice.c (main): Report proper program name when getopt finds
507 trouble. Problem reported by Behdad Esfahbod.
509 * NEWS: Fix bug with "mkdir -m =+x dir"; the umask was being ignored
510 when the "+x" was being evaluated.
511 * mkdir.c (main): Compile mode with MODE_MASK_ALL and initial umask.
512 * mkfifo.c (main): Likewise.
513 * mknod.c (main): Likewise.
514 * tests/mkdir/perm: Test for the above bug.
516 2005-04-20 Paul Eggert <eggert@cs.ucla.edu>
518 Port test cases to Microsoft-Windows-related environments,
519 following suggestions from Eric Blake.
520 * tests/install/Makefile.am (TESTS_ENVIRONMENT): Add EXEEXT.
521 * tests/install/basic-1: Undo previous change.
522 (dd, dd2): New vars, which use $EXEEXT. All uses of dd and dd2 changed.
523 * tests/install/trap: Undo previous change.
524 (sig): New var. Use it insted of "trap '' CHLD".
525 Append $EXEEXT to executable name.
527 "fetish" -> "coreutils" in more places.
528 * tests/Coreutils.pm: Renamed from tests/Fetish.pm.
529 (package Coreutils): Renamed from package Fetish. All uses changed.
530 * tests/Makefile.am (EXTRA_DIST): Add Coreutils.pm and
533 2005-04-19 Paul Eggert <eggert@cs.ucla.edu>
535 * tests/mv/setup (dot_mount_point): Use stat -L, in case the
536 directory is actually a symbolic link. Problem reported by
539 * tests/mv/mv-special-1: Use test -p to test for fifos, rather
540 than the (incorrect) test -f and the (inadequate) ls. ls is
541 inadequate because on some hosts a buggy mv will create a file of
542 the wrong type (problem reported by Eric Blake). Skip this test
543 if test -p doesn't work.
545 * tests/chmod/setgid: Use numeric group ids, not symbolic group names,
546 since the latter can have shell metacharacters in them (e.g., spaces).
547 This follows up to the 2005-01-17 patch, which missed this occurrence.
549 2005-04-18 Paul Eggert <eggert@cs.ucla.edu>
551 "fetish" -> "coreutils" in several places.
552 * Makefile.cfg (ftp): Remove fetish.sf.net.
553 * Makefile.maint (emit_upload_commands): Likewise.
554 * src/Makefile.am (LDADD, $(PROGRAMS)): fetish -> coreutils.
555 * tests/group-names (COREUTILS_GROUPS): Renamed from FETISH_GROUPS.
556 * tests/chmod/setgid (FETISH_GROUP): Renamed from COREUTILS_GROUP.
558 * tests/install/basic-1: Use "cat", not "test", to test for
559 ../../src/dd. Problem reported by Eric Blake.
561 2005-04-18 Jim Meyering <jim@meyering.net>
563 * src/dd.c: Don't include stat-macros.h directly. system.h does that.
565 2005-04-17 Paul Eggert <eggert@cs.ucla.edu>
567 Work around a couple of "make check" failures reported for Cygwin
568 and ash by Eric Blake.
569 * tests/install/basic-1: Skip this test if ../../src/dd isn't readable.
570 * tests/install/trap: Skip this test if "trap '' CHLD" doesn't work.
572 2005-04-16 Jim Meyering <jim@meyering.net>
574 * src/dd.c (S_TYPEISSHM): Remove definition.
575 Get the definition by including "stat-macros.h", instead.
577 2005-04-14 Paul Eggert <eggert@cs.ucla.edu>
579 Fix test suite problems reported by Eric Blake on Cygwin.
580 * tests/mv/mv-special-1: Ignore chatter about when files are removed,
581 since POSIX doesn't require rename to fail across file systems.
582 * tests/mv/setup (dot_mount_point): Use stat rather than df, as
584 (other_partition_tmpdir): Remove df from name as that would be
587 2005-04-14 Jim Meyering <jim@meyering.net>
589 * src/chown-core.c: Correct typo, fchmod -> fchown, in a comment.
591 2005-04-12 Paul Eggert <eggert@cs.ucla.edu>
593 * src/ls.c (usage): "uid" -> "user ID".
595 2005-04-12 Jim Meyering <jim@meyering.net>
597 * src/tsort.c (tsort): Use "%s" as the format string,
598 rather than a diagnostic or a file name.
600 * src/comm.c (compare_files): Remove declaration of unused local.
602 * src/chown-core.c (chopt_free): Mark parameter as unused.
604 2005-04-11 Paul Eggert <eggert@cs.ucla.edu>
606 * man/chown.x: Reword to match user manual.
607 * man/id.x: Likewise.
608 * src/setuidgid.c (usage): Use "user ID", not "UID", and similarly
610 * src/whoami.c (usage, main): Likewise.
612 Add bulletproofing for cases where stdin, stdout, or stderr are closed.
613 * src/comm.c: Include stdio-safer.h.
614 (compare_files): Exit right away on I/O error rather than continuing
615 and producing confusing output and error messages.
616 Return void, not int; all callers changed.
617 Use fopen_safer to avoid confusion with file descriptors.
618 * src/copy.c: Include unistd-safer.h.
619 (copy_reg): Use fd_safer.
620 * src/csplit.c: Include stdio-safer.h.
621 (input_desc): Remove unnecessary static initialization.
622 (set_input_file): Use STDIN_FILENO, not 0.
623 (create_output_file): Use fopen_safer.
624 * src/dircolors.c (dc_parse_file): Don't assume fopen does not
626 * src/head.c (head_file): Don't assume open does not return 0.
627 * src/join.c: Include stdio-safer.h.
628 (main): Use fopen_safer. Simplify the resulting code.
629 * src/md5sum.c (digest_file, digest_check):
630 Don't assume that fopen does not return stdin.
631 * src/nohup.c: Include unistd-safer.h.
632 (main): Don't dup stderr to stdin or stdout by mistake.
633 * src/od.c (check_and_close): Don't assume fopen does not return stdin.
634 * src/paste.c (paste_serial): Likewise.
635 * src/pr.c: Include stdio-safer.h.
636 (open_file): Use fopen_safer.
637 (close_file): Don't assume fopen does not return stdin.
638 * src/ptx.c (main): Don't assume fopen returns stdout after closing
639 stdout. Use freopen instead.
640 * src/shred.c: Include unistd-safer.h.
641 (wipename): Use fd_safer on directory file descriptor.
642 (wipefile): Remove special case for /dev/fd/* on older hosts.
643 It didn't work in general, and wasn't documented.
645 * src/sort.c: Include unistd-safer.h.
646 (create_temp_file): Use fd_safer.
647 (xfclose): Don't assume fileno (stdin) == STDIN_FILENO, etc.
648 * src/split.c: Include unistd-safer.h.
649 (cwrite): Use fd_safer. Replace mystery constant 0666 with symbolic
650 version, as POSIX requires.
651 * src/sum.c (bsd_sum_file, sysv_sym_file):
652 Use same pattern as elsewhere for checking for stdin.
653 * src/tac.c: Include unistd-safer.h.
654 (copy_to_temp): Use fd_safer.
655 (tac_file): Don't assume fopen cannot return stdin.
656 * src/tail.c: Include unistd-safer.h rather than fcntl-safer.h.
657 (recheck, tail_file): Use fd_safer rather than open_safer.
658 * src/tee.c: Include stdio-safer.h.
659 (tee): Use fopen_safer.
660 * src/touch.c: Include unistd-safer.h.
661 (touch): Use fd_safer.
662 * src/tsort.c (have_read_stdin): Remove; no longer needed. All uses
664 (tsort): Do not assume fopen can't return stdin.
665 Close stdin before returning. All uses changed.
666 * src/unexpand.c (next_file): Don't assume fopen cannot return stdin.
667 * src/uniq.c: Include stdio_safer.h.
668 (check_file): Don't assume fopen cannot return stdin or stdout.
670 2005-04-09 Jim Meyering <jim@meyering.net>
672 * src/dd.c (quit): Define with ATTRIBUTE_NORETURN.
674 Now that close_stdout closes standard output unconditionally,
675 these workarounds for dd and cat are no longer necessary.
676 * src/dd.c (close_stdout_wrapper): Remove function.
677 (main): Call atexit with close_stdout, instead.
678 * src/cat.c (close_stdout_wrapper): Likewise.
679 Don't close STDOUT_FILENO explicitly; close_stdout does it.
681 * src/system.h (__attribute__): Readability nit:
683 # define __attribute__(x)
685 # define __attribute__(x) /* empty */
687 2005-04-09 Jim Meyering <jim@meyering.net>
689 * src/rm.c (usage): Mention that --recursive removes listed
690 directories too, not just their contents.
691 Say that by default, rm does not remove directories.
693 * src/pr.c: Don't include "timespec.h". system.h does that.
694 * Makefile.maint (sc_system_h_headers): Propagate exit status
697 2005-04-08 Paul Eggert <eggert@cs.ucla.edu>
699 * NEWS: Document that dd no longer treats QUIT or PIPE specially,
700 and when conforming to POSIX no longer treats USR1 specially.
701 Document that dd no longer dumps core when handling signals.
702 * src/system.h (RETSIGTYPE): Remove; no longer needed. All uses
704 * src/csplit.c (SA_NOCLDSTOP): Define to 0 if not defined.
706 (siginterrupt) [!HAVE_SIGINTERRUPT]: New macro.
707 (delete_all_files): New arg IN_SIGNAL_HANDLER, to avoid undefined
708 behavior when called from a signal handler. All uses changed.
709 (main) [!defined SA_NOCLDSTOP]:
710 Use siginterrupt to specify that system calls should be interrupted.
711 * src/dd.c: Do not include safe-read.h or full-write.h; no longer needed.
712 (process_signals): Add forward decl.
713 (SA_NOCLDSTOP, sigprocmask, sigset_t) [!defined SA_NOCLDSTOP]:
715 (siginterrupt) [! HAVE_SIGINTERRUPT]: New macro.
716 (SA_NODEFER) [!defined SA_NODEFER]: New macro.
717 (SA_RESETHAND) [!defined SA_RESETHAND]: New macro.
718 (caught_signals, interrupt_signal, info_signal_count, catch_siginfo):
720 (usage): Mention -USR1 versus -INFO.
721 (cleanup): Don't invoke print_stats; the caller must do it now.
723 (quit): Process signals just before exiting.
724 (interrupt_handler): Simply record the signal and return.
725 (siginfo_handler): Simply increment the signal counter and return.
726 (install_handler): Remove, replacing with:
727 (install_signal_handlers, process_signals, iread, iwrite):
728 New functions. All callers to safe_read and full_write replaced
729 by iread and iwrite. All callers to install_handler replaced by
731 * src/ls.c (SA_NOCLDSTOP): Define to 0 if not defined.
733 (siginterrupt) [! HAVE_SIGINTERRUPT]: New macro.
734 (main) [! SA_NOCLDSTOP]: Use it.
735 * src/shred.c: Remove all uses of signals; modern hosts have
736 /dev/random and don't need this gorp.
737 Do not include signal.h.
738 (env, sigill_handler, isaac_seed_machdep): Remove. All uses removed.
739 * src/sort.c (SA_NOCLDSTOP): Define to 0 if not defined.
741 (siginterrupt) [! HAVE_SIGINTERRUPT]: New macro.
742 (main) [! SA_NOCLDSTOP]: Use it.
744 * src/dd.c: Do not include inttostr.h, no longer needed.
745 (print_stats, main): Rewrite and simplify formats to use PRIuMAX
746 instead of umaxtostr.
747 (print_stats): Work even in languages that have special
748 forms for two of things, for r_truncate and w_bytes. We can't
749 fix delta_s in this way, since ngettext doesn't support floating-point.
750 (main): Rewrite to avoid casts.
752 2005-04-07 Jim Meyering <jim@meyering.net>
754 Placate gcc-4's -Wuninitialized.
755 * src/md5sum.c (digest_check) [lint]: Initialize hex_digest to NULL.
756 * src/test.c (binary_operator) [lint]: Initialize lt and rt to 0.
758 * src/test.c (is_int, age_of, binop): Declare `char *' parameters to
760 (binop): Move function definition to precede first use so we can...
761 (binop): ...remove prototype.
763 2005-04-05 Paul Eggert <eggert@cs.ucla.edu>
765 * man/Makefile.am (.x.1): Remove "COMMAND.td/" from examples.
766 * src/basename.c (usage): Add examples.
767 * src/cat.c (usage): Likewise.
768 * src/chgrp.c (usage): Likewise.
769 * src/chown.c (usage): Likewise.
770 * src/dirname.c (usage): Likewise.
772 2005-04-05 Jim Meyering <jim@meyering.net>
774 * src/nice.c (usage): Mention that some shells provide a
775 built-in function by the same name.
776 * src/nohup.c (usage): Likewise.
777 * src/printenv.c (usage):Likewise.
779 2005-04-04 Dmitry V. Levin <ldv@altlinux.org>
781 * src/tee.c (tee): When closing files, do not close stdout,
782 leave this job to close_stdout() instead.
783 * configure.ac (AC_CONFIG_FILES): Add tests/tee/Makefile.
784 * tests/Makefile.am (SUBDIRS): Add tee.
785 * tests/tee/Makefile.am: New file.
786 * tests/tee/.cvsignore: Likewise.
787 * tests/tee/{basic,dash}: New tee tests.
789 2005-04-04 Jim Meyering <jim@meyering.net>
791 * src/echo.c (usage): Mention that some shells provide a
792 built-in function by the same name.
793 * src/kill.c (usage): Likewise
794 * src/printf.c (usage): Likewise.
795 * src/pwd.c (usage): Likewise.
796 * src/stat.c (usage): Likewise.
797 * src/test.c (usage): Likewise.
798 * src/true.c (usage):
799 * src/system.h (USAGE_BUILTIN_WARNING): New macro.
801 * man/echo.x: Remove `DESCRIPTION' section, now that --help includes it.
802 * man/printf.x: Likewise.
803 * man/pwd.x: Likewise.
805 2005-04-03 Jim Meyering <jim@meyering.net>
807 * src/pr.c (main): Fix off-by-one error.
808 pr -$(perl -e 'print "0"x63 . 1') would write one byte beyond the
809 end of a malloc'd buffer.
811 2005-04-01 Jim Meyering <jim@meyering.net>
813 * src/pr.c (main): Free column_count_string when done with it.
815 Don't let pr treat +1:-1 like +1:18446744073709551615.
816 * src/pr.c (strtoumax): Remove declaration.
817 (first_last_page): Use xstrtoumax in place of strtoumax,
818 so we don't interpret a negative page number (e.g., in an option
819 like --pages=1:-1) as valid.
820 * tests/pr/Test.pm (neg-page): Add a test for this.
822 2005-03-30 Paul Eggert <eggert@cs.ucla.edu>
824 * src/pinky.c (short_pinky): Adjust to read_utmp signature change.
825 * src/uptime.c (uptime): New arg OPTIONS. All uses changed.
826 * src/users.c (users): Likewise.
827 * src/who.c (who): Likewise.
828 * src/uptime.c (main): Check PIDs when invoked with zero arguments.
829 * src/users.c (main): Likewise.
830 * src/who.c (main): Likewise. Also with two arguments.
831 Omit duplicate code in 2-arg case.
832 (UT_PID): Moved to ../lib/readutmp.h.
834 2005-03-29 Jim Meyering <jim@meyering.net>
836 * src/system.h (ptr_align): Declare `ptr' parameter to be a
837 `const' pointer, since this function never writes through it.
839 * src/uname.c: Indent cpp directives to reflect nesting.
841 2005-03-28 Jim Meyering <jim@meyering.net>
843 * src/seq.c (get_width_format) [HAVE_RINT && HAVE_MODF && HAVE_FLOOR]:
844 Add `void' to make this an ANSI-style function declaration.
845 * src/remove.c (ds_init): Likewise.
846 * src/pr.c (print_sep_string): Likewise.
848 * src/stty.c (speeds): Declare this array to be static.
849 * src/Makefile.am (sc_tight_scope): Adjust to catch any
850 new declarations like that of stty.c's `speeds'.
852 * src/system.h (GETOPT_HELP_OPTION_DECL): Use NULL, not `0'.
853 (GETOPT_VERSION_OPTION_DECL): Likewise.
854 * src/chown.c (long_options): Likewise.
855 * src/chgrp.c (long_options): Likewise.
856 * src/chmod.c (long_options): Likewise.
857 * src/cp.c (sparse_type_string, reply_args, decode_preserve_arg):
859 * src/chown-core.c (chopt_init): Likewise.
860 * src/comm.c (long_options): Likewise.
861 * src/copy.c (copy_reg): Likewise.
862 * src/csplit.c (extract_regexp): Likewise.
863 * src/cut.c (longopts): Likewise.
864 * src/date.c (time_spec_string): Likewise.
865 * src/df.c (find_mount_point, show_point): Likewise.
866 * src/expr.c (docolon): Likewise.
867 * src/fmt.c (long_options): Likewise.
868 * src/ls.c (time_style_args, indicator_style_args, long_options)
869 (format_args, sort_args, time_args, decode_switches)
870 (gobble_file): Likewise.
871 * src/md5sum.c (long_options): Likewise.
872 * src/mv.c (reply_args): Likewise.
873 * src/paste.c (longopts): Likewise.
874 * src/pinky.c (print_entry): Likewise.
875 * src/pr.c (long_options): Likewise.
876 * src/ptx.c (long_options, format_args): Likewise.
877 * src/readlink.c (longopts): Likewise.
878 * src/sort.c (long_options, mergefps): Likewise.
879 * src/stat.c (long_options): Likewise.
880 * src/tac.c (main): Likewise.
881 * src/tail.c (follow_mode_string): Likewise.
882 * src/touch.c (longopts, time_args): Likewise.
883 * src/uniq.c (delimit_method_string): Likewise.
884 * src/uptime.c (print_uptime): Likewise.
885 * src/who.c (print_user): Likewise.
887 2005-03-27 Jim Meyering <jim@meyering.net>
889 * src/dcgen: Simplify further, clean up.
890 Add a standard-output-closing global destructor.
892 * src/wheel-gen.pl: Use the same global destructor as dcgen.
894 2005-03-26 Paul Eggert <eggert@cs.ucla.edu>
896 * src/dcgen: Squeeze multiple blanks into one. Output a simple
897 array of adjacent strings rather than a more complicated data
898 structure; this saves space in the dircolors executable.
899 * src/dircolors.c (parse_line): Use char *, not unsigned char *.
901 (dc_parse_stream, main): Avoid casts.
902 Adjust to simpler data structure generated by new dcgen.
904 2005-03-25 Eric Blake <ebb9@byu.net> (tiny change)
906 * src/ls.c (usage): Document usage of LS_COLORS.
908 2005-03-25 Paul Eggert <eggert@cs.ucla.edu>
910 * src/dircolors.hin: Add "TERM cygwin".
912 2005-03-25 Jim Meyering <jim@meyering.net>
914 * src/system.h (DECIMAL_DIGIT_ACCUMULATE): Reverse the sense of
915 the return value, and update callers:
916 * src/cut.c (set_fields): Update use of DECIMAL_DIGIT_ACCUMULATE.
917 * src/expand.c (parse_tab_stops, main): Likewise.
918 * src/split.c (main): Likewise.
919 * src/unexpand.c (parse_tab_stops, main): Likewise.
920 * src/uniq.c (main): Likewise.
922 2005-03-22 Jim Meyering <jim@meyering.net>
924 * build-aux: New directory. Renamed from config.
925 * configure.ac: Reflect renaming: config -> build-aux.
926 * Makefile.am (dist-hook): Likewise.
927 * Makefile.maint: Likewise.
928 * Makefile.cfg (cvs_files): Likewise.
929 * .x-sc_sun_os_names: Likewise.
930 * .x-sc_trailing_blank: Likewise.
932 * src/ls.c (get_funky_string): Use '\a', rather than 7, for
933 portability to EBCDIC hosts.
935 2005-03-20 Jim Meyering <jim@meyering.net>
937 * src/pr.c (init_header): Add missing `%' in new format string.
938 (init_header): Use zero-filled `.%09d' format, not space-filled `.%9d'.
940 2005-03-19 Jim Meyering <jim@meyering.net>
942 * src/Makefile.am (pr_LDADD): Now that pr uses gettime, add
943 $(LIB_CLOCK_GETTIME) to get the required -lrt on newer Linux systems.
945 2005-03-18 Paul Eggert <eggert@cs.ucla.edu>
947 * NEWS: pr -D "FORMAT" now accepts the same formats that
949 * src/pr.c: Include strftime.h, timespec.h.
950 (init_header): Obtain and format nanosecond part of time stamp.
952 * NEWS: nohup now ignores the umask when creating nohup.out.
953 nohup now closes stderr if it is a terminal and stdout is closed.
954 * src/nohup.c (main): Likewise. Be a little more paranoid about
955 return values; e.g., check for any negative return from open.
956 Assume free (NULL) works.
957 Close file descriptor leak when redirecting standard output to a file.
959 2005-03-17 Jim Meyering <jim@meyering.net>
961 * src/cut.c (set_fields): Use DECIMAL_DIGIT_ACCUMULATE macro,
962 in place of functionally-equivalent code.
963 * src/expand.c (parse_tab_stops, main): Likewise.
964 * src/split.c (main): Likewise.
965 * src/unexpand.c (parse_tab_stops, main): Likewise.
966 * src/uniq.c (main): Likewise.
967 * src/od.c: Use VERIFY macro in place of an equivalent open-coded
969 * src/system.h (VERIFY, VERIFY_EXPR, DECIMAL_DIGIT_ACCUMULATE):
972 Before, this command would make uniq skip 11 fields and print
974 $ _POSIX2_VERSION=1 ./uniq -f1 -1 <(seq --format='1 %g' 2)
977 * src/uniq.c (main): Interpret `uniq -f1 -1' like `uniq -f1',
978 not like `uniq -f11'.
980 2005-03-15 Jim Meyering <jim@meyering.net>
982 Both `pr -0' and e.g., `pr -03' would evoke `column count too large'.
983 `pr -0' should give a better diagnostic and `pr -03' should be
984 equivalent to `pr -3'.
985 * src/pr.c (parse_column_count): Change return type to void.
986 Call error (EXIT_FAILURE, ... for an invalid string.
987 (main): Allocate space for column_count_string using malloc.
988 Accumulate all old-style column-count digits before converting.
989 When the number of columns is specified via both old-style,
990 (e.g., -3), and a long option (--columns=5), ensure that only
991 the last one specified takes effect.
992 * tests/pr/Test.pm: Add tests for the above.
994 2005-03-15 Corinna Vinschen <corinna@vinschen.de> (tiny change)
996 * src/copy.c (copy_reg): Copy regular files in binary mode.
998 2005-03-14 Paul Eggert <eggert@cs.ucla.edu>
1000 * NEWS: Restate why ls limits time stamp lengths.
1002 2005-03-12 Jim Meyering <jim@meyering.net>
1004 Add a little infrastructure to help prevent future bugs like the
1006 * src/stat.c (xstrcat): New function.
1007 (print_statfs, print_stat): Add buf_len parameter and convert all
1008 uses of strcat to xstrcat. Update callers.
1009 (print_it): Call print_func with buf_len parameter.
1011 Invoking stat -c FMT with a lone format directive of %s, %f, %h, %s,
1012 could cause a buffer overrun error.
1013 * src/stat.c (print_it): Allocate 2 more bytes, to accommodate our
1014 conversion of the stat %s format string to the longer printf %llu one.
1015 Patch from Guochun Shi.
1017 2005-03-11 Paul Eggert <eggert@cs.ucla.edu>
1019 * src/ls.c (TIME_STAMP_LEN_MAXIMUM): New constant.
1020 (long_time_expected_width, print_long_format): Use it, to avoid
1021 some possible denial-of-service attacks.
1022 * NEWS: Document this.
1024 2005-03-11 Jim Meyering <jim@meyering.net>
1026 Prompt once again for `mv -i A B' when A and B are hard links
1027 to the same file. This fixes a bug introduced by my 2003-04-04
1028 (coreutils-5.0.1) change. Reported by Thomas Wolff via Eric Blake.
1029 * src/copy.c (abandon_move): New function, factored out of
1030 copy_internal, now that this code is being used from two places.
1031 (copy_internal): Perform the same interactive-related test for
1032 whether it's alright to proceed and (usually) overwrite the
1034 * tests/mv/i-4: Add tests for the above.
1036 Don't segfault for a very long date format string, e.g.,
1037 ls -ld --time-style=+%99999999H .
1038 * src/ls.c (long_time_expected_width): Use x2nrealloc, not alloca,
1039 so format string abuse cannot provoke stack overflow.
1040 (print_long_format): Likewise.
1042 Don't segfault for a long header date string, e.g.,
1043 echo a|pr -D +%9999999A
1044 * src/pr.c (init_header): Use x2nrealloc, rather than alloca.
1045 Don't bother with fixed-sized initial buffer; always use x*alloc.
1047 * src/pr.c (init_header): Use slightly clearer INT_BUFSIZE_BOUND
1048 in place of equivalent INT_STRLEN_BOUND + 1.
1049 * src/expr.c (tostring, printv): Likewise.
1051 2005-03-09 Paul Eggert <eggert@cs.ucla.edu>
1053 * src/system.h: Include intprops.h.
1054 (TYPE_SIGNED, TYPE_MINIMUM, TYPE_MAXIMUM, INT_STRLEN_BOUND): Remove;
1055 they are now defined in intprops.h.
1057 2005-03-09 Jim Meyering <jim@meyering.net>
1059 * TODO: Remove entry about named pipes. It was fixed in 5.3.0.
1061 2005-03-08 Paul Eggert <eggert@cs.ucla.edu>
1063 * src/date.c (usage): Redo to match recent documentation changes.
1064 Don't bother documenting which usages are GNU extensions; the list
1065 wasn't correct, and is better left to the printed manual anyway.
1067 2005-03-06 Jim Meyering <jim@meyering.net>
1069 Factor out column-count processing.
1070 * src/pr.c: Include "inttostr.h".
1071 (parse_column_count): New function.
1072 (main): Use the new function for both old-style, -9, and long,
1073 --columns=-9, options.
1075 * src/cksum.c: Remove `register' keyword.
1076 * src/cut.c: Likewise.
1077 * src/dd.c: Likewise.
1078 * src/env.c: Likewise.
1079 * src/factor.c: Likewise.
1080 * src/fmt.c: Likewise.
1081 * src/fold.c: Likewise.
1082 * src/id.c: Likewise.
1083 * src/logname.c: Likewise.
1084 * src/ls.c: Likewise.
1085 * src/pr.c: Likewise.
1086 * src/printf.c: Likewise.
1087 * src/shred.c: Likewise.
1088 * src/sort.c: Likewise.
1089 * src/sum.c: Likewise.
1090 * src/test.c: Likewise.
1091 * src/tsort.c: Likewise.
1092 * src/uniq.c: Likewise.
1093 * src/wc.c: Likewise.
1094 * src/whoami.c: Likewise.
1096 2005-03-01 Paul Eggert <eggert@cs.ucla.edu>
1098 * src/Makefile.am (nanosec_libs): Remove $(LIB_XANOSLEEP); no
1101 2005-03-01 Jim Meyering <jim@meyering.net>
1103 * src/copy.c (copy_internal): Change test of source type from
1104 !S_ISREG to S_ISLNK. Reported by Paul Eggert in
1105 http://lists.gnu.org/archive/html/bug-coreutils/2004-10/msg00050.html.
1107 2005-02-28 Jim Meyering <jim@meyering.net>
1109 * NEWS: Mention that xnanosleep fixes sleep failure on linux-2.6.8.1.
1111 2005-02-21 Paul Eggert <eggert@cs.ucla.edu>
1113 * src/Makefile.am (dd_LDADD, shred_LDADD): Add $(LIB_GETHRXTIME).
1114 (nanosec_libs): Add $(LIB_XNANOSLEEP). Needed for newer GNU/Linux
1115 hosts with clock_gettime.
1117 2005-02-20 Paul Eggert <eggert@cs.ucla.edu>
1119 * NEWS: Describe user-visible change to dd.
1120 * src/Makefile.am (dd_LDADD, shred_LDADD, nanosec_libs):
1121 Remove $(LIB_CLOCK_GETTIME). These functions now use
1123 * src/dd.c: Include gethrxtime.h, xtime.h.
1124 (start_time): Now of type xtime_t, not struct timespec.
1125 (print_stats, main): Use gethrxtime rather than gettime.
1126 * src/ls.c (time): Remove obsolete decl.
1127 (get_current_time): gettimeofday always returns 0, so don't
1129 * src/shred.c: Include gethrxtime.h.
1130 (isaac_seed): Use gethrxtime rather than a mishmash.
1131 * src/touch.c (time): Remove obsolete decl.
1133 * tests/misc/split-fail: Don't assume that the current host
1134 supports integers wider than 32 bits. Fix comment typo.
1135 * tests/od/x8: Likewise.
1137 * src/chown-core.c (enum RCH_status): Remove trailing comma,
1138 as it's not valid in standard C89.
1140 2005-02-15 Jim Meyering <jim@meyering.net>
1142 * src/stat.c (human_fstype): Add case/definition for S_MAGIC_XFS
1143 so that file systems of type `xfs' are recognized as such.
1144 * src/fs.h: Regenerate.
1145 Reported by Bernd Eckenfels.
1146 * src/stat.c (human_fstype): Likewise for S_MAGIC_JFS/jfs.
1147 * src/fs.h: Regenerate.
1148 Reported by Andreas Schwab.
1150 * src/nice.c (NZERO) [NZERO == 0]: Undefine and define to 20,
1151 to work around the invalid definition from Darwin 7.7.0.
1152 Test failure reported by Sébastien Maret.
1154 2005-02-14 Paul Eggert <eggert@cs.ucla.edu>
1156 * src/sort.c (mergefps): Use binary search rather than linear one
1157 when comparing new line to lines already in main memory.
1158 Idea suggested by James Lemley.
1160 2005-02-09 Jim Meyering <jim@meyering.net>
1162 * src/copy.c (valid_options): Add an assertion that
1163 not both hard_link and symbolic_link are set.
1165 2005-02-08 Paul Eggert <eggert@cs.ucla.edu>
1167 * NEWS: Document stat -f -c %S, plus changes to default formats.
1168 * doc/coreutils.texi (stat invocation): Normalize terminology,
1169 capitalization, and sort order to match --help output. Mention %c
1170 for file systems. Add new -f -c format %S, and document %s versus %S;
1171 problem reported by Jeroen van Wolffelaar.
1172 * src/stat.c (usage): Likewise.
1173 (STATFS_FRSIZE): New macro.
1174 (print_statfs): Use it, for stat -f -c %S.
1175 (do_statfs): Change default formats to output %S.
1177 2005-02-03 Paul Eggert <eggert@cs.ucla.edu>
1179 * src/system.h: Include "memrchr.h".
1180 (memrchr) [!HAVE_DECL_MEMRCHR]: Remove decl.
1182 2005-02-02 Jim Meyering <jim@meyering.net>
1184 * tests/du/8gb: Also adjust the test (s/64/128/) to detect
1185 systems that don't support sparse files.
1186 Check for $2 -ge 128, rather than $2 = 128, in case
1187 there is a file system type that doesn't support sparse files,
1188 yet for which metadata takes up additional space.
1189 Both reported by Andreas Schwab.
1191 2005-02-01 Eric Blake <ebb9@byu.net> (tiny change)
1193 * tests/du/8gb: Create a larger test file, so we properly
1194 detect that sparse files can be created on NTFS under cygwin.
1196 2005-01-30 Jim Meyering <jim@meyering.net>
1198 * src/head.c (elide_tail_bytes_pipe): Correct wording in diagnostic.
1200 * src/stty.c: Remove unnecessary parentheses in all #if directives.
1202 2005-01-29 Eric Blake <ebb9@byu.net> (tiny change)
1204 * .cvsignore: Ignore config.cache and config.status.lineno.
1205 * src/stty.c [VSWTCH]: Some systems, like Cygwin, use VSWTC
1206 instead of VSWTCH, for use with CSWTCH.
1208 2005-01-29 Eric Blake <ebb9@byu.net> (tiny change)
1210 * tests/Makefile.am (.PHONY): Add check-root and root-hint.
1211 * tests/rwx-to-mode: Ignore ACL designation.
1212 * tests/setgid-check: Likewise.
1213 * tests/chown/separator: Quote user and group names.
1215 2005-01-24 Jim Meyering <jim@meyering.net>
1217 * src/cp.c (usage): Merge the descriptions of --no-dereference and -P.
1218 Suggestion from Johan Boule.
1220 2005-01-17 Eric Blake <ebb9@byu.net> (tiny change)
1222 * src/Makefile.am (all_programs.list): Strip $(EXEEXT) and remove
1224 * man/Makefile.am (all_programs): Revert previous patch; updated
1225 all_programs.list fixes this.
1226 (.x.1): No need to add $(EXEEXT).
1228 2005-01-03 Corinna Vinschen <corinna@vinschen.de> (tiny change)
1230 * src/system.h: Use S_BLKSIZE value for ST_NBLOCKSIZE where
1233 2005-01-22 Jim Meyering <jim@meyering.net>
1235 * Makefile.maint (v_etc_file): The version string has moved to
1236 version-etc-fsf.c, search that new file, not version-etc.c.
1238 2005-01-17 Paul Eggert <eggert@cs.ucla.edu>
1240 * tests/group-names: Use numeric group ids, not symbolic group names,
1241 since the latter can have shell metacharacters in them (e.g., spaces).
1242 Problem reported by Eric Blake.
1243 * tests/chgrp/basic: Assume groups are numeric, not symbolic.
1244 * tests/chgrp/deref: Likewise.
1245 * tests/chgrp/posix-H: Likewise.
1246 * tests/chgrp/recurse: Likewise.
1248 2005-01-15 Jim Meyering <jim@meyering.net>
1250 * src/shred.c (isaac_seed) [HAVE_GETHRTIME]: #if-0 this block,
1251 because just calling gethrtime evokes an `illegal instruction'
1252 failure when compiled with Sun's c89 on Solaris 8 and 9.
1253 Reported by Nelson Beebe.
1255 * src/shred.c (isaac_seed) [HAVE_GETHRTIME]: Don't call ISAAC_SEED
1256 twice with the same value of `t'.
1257 Replace nested #if-#else blocks with #if-#elif-#elif chain.
1259 2005-01-14 Jim Meyering <jim@meyering.net>
1261 The test, tests/tail/f-1, failed on powerpc-apple-darwin7.7.0.
1262 * src/tail.c (IS_TAILABLE_FILE_TYPE): Adjust definition also to include
1263 sockets, since that's what you get when reading from a command-line-
1264 supplied pipe on Darwin 7.7.
1265 (IS_PIPE_LIKE_FILE_TYPE): Define.
1266 (main): Use new IS_PIPE_LIKE_FILE_TYPE rather than simply S_ISFIFO.
1267 Reported by Nelson Beebe.
1268 This same change is also required on NetBSD/sparc-1.5.
1269 Reported by Adrian Bunk.
1271 * src/expr.c (toarith): Rewrite to detect/diagnose integer overflow,
1272 rather than suffering silently.
1273 Before, expr would silently overflow and wrap around:
1274 $ expr 9223372036854775808 = 0 # $(echo 2^63|bc)
1276 Now it detects the problem and exits nonzero:
1277 $ ./expr $(echo 2^63|bc) = 0
1278 ./expr: 9223372036854775808: integer is too large
1280 * tests/chown/separator (id_gn): Exit 77, not 1, for a test-framework
1281 failure, so that doesn't cause `make check' to stop. Nelson Beebe
1282 reported that this test would fail with the diagnostic,
1283 `cannot find name for group ID 10', on one of his systems.
1285 2005-01-13 Jim Meyering <jim@meyering.net>
1287 * src/test.c (is_int): Don't overflow when evaluating integer
1288 constants. Before, ./test $(echo 2^64|bc) -eq 0 && echo FAIL
1291 * tests/Fetish.pm (run_tests): Add code (if-0'd out) to detect
1292 names of temporary files that would clash on 8.3 file systems.
1293 * tests/mk-script (validate): Likewise.
1295 2005-01-12 Jim Meyering <jim@meyering.net>
1297 * tests/dd/skip-seek: Shorten test names to accommodate 8.3 systems.
1299 * tests/tr/Test.pm (repeat-xC): Change test name from
1300 `repeat-Compl', to avoid 8.3 conflict with `repeat-compl'.
1301 Reported by Eric Blake.
1302 (repeat-000): Rename to `repeat-zeros' for the same reason.
1304 2005-01-11 Jim Meyering <jim@meyering.net>
1306 * configure.ac: Update version to 5.3.1.
1308 2005-01-11 Eric Blake <ebb9@byu.net>
1310 * src/Makefile.am (check-README, check-AUTHORS): Account for $(EXEEXT).
1311 * man/Makefile.am (all_programs): Account for $(EXEEXT).
1313 2005-01-11 Jim Meyering <jim@meyering.net>
1315 * src/unexpand.c (add_tab_stop): Properly diagnose a tabstop list
1316 with decreasing values.
1318 * src/expand.c (main): Likewise.
1319 * src/unexpand.c (main): Check for overflow in tabstop values
1320 specified via the obsolete form. E.g., now this command fails:
1321 _POSIX2_VERSION=1 ./unexpand -$(echo '2^64+1'|bc)
1322 Before it would act like `_POSIX2_VERSION=1 ./unexpand -1'.
1323 * tests/unexpand/basic-1 (obs-ovflo): New test for this.
1325 2005-01-10 Paul Eggert <eggert@cs.ucla.edu>
1327 Respond to POSIX interpretations about pathchk -p dated 2005-01-06.
1328 * NEWS: Document the changes.
1329 * doc/coreutils.texi (pathchk invocation): Likewise.
1330 * src/pathchk.c (PORTABILITY_OPTION): New constant.
1331 (longopts, usage, main, validate_file_name):
1332 Add support for new -P option.
1333 Reject empty file names (unless -p is not specified and the
1334 current system allows empty file names).
1335 Change --portability so that is now equivalent to -p -P.
1336 Don't test whether file name is too long, if it is known to exist.
1337 (no_leading_hyphen): New function.
1338 * tests/misc/pathchk1: Add tests for empty file names and
1341 2005-01-08 Jim Meyering <jim@meyering.net>
1345 `pr --columns=N' was not equivalent to `pr -N' when also using
1348 * src/pr.c (main): Set `explicit_columns' for --columns=N,
1349 not just for -N. This bug has existed since the introduction
1350 of the --columns=N option on 1998-08-15.
1351 * NEWS: Document this.
1352 * tests/pr/Test.pm (test_vector): For each -N test, automatically
1353 create a new test vector using --columns=N.
1355 2005-01-07 Paul Eggert <eggert@twinsun.com>
1357 * src/pr.c (main): Check for column count overflow with
1358 usages like "pr -2147483648".
1360 2005-01-07 Jim Meyering <jim@meyering.net>
1362 * src/pr.c (init_fps): Use xnmalloc, rather than xmalloc.
1364 2005-01-06 Jim Meyering <jim@meyering.net>
1366 * README: List the precise HP-UX version numbers that are affected.
1367 Suggestion from Bob Proulx.
1369 * Makefile.maint (sc_changelog): Specify find's `-maxdepth 2'
1370 predicate before `-name ChangeLog' to avoid a harmless warning
1373 2005-01-05 Jim Meyering <jim@meyering.net>
1375 * tests/help-version: Punt on the uptime test, since it fails when
1376 it can't get boot time, and I don't want that to stop `make check'.
1378 * src/du.c (process_file): Evaluate exclusion rules against
1379 the entire file name, not just the last component.
1380 Reported by Robert Lindgren.
1381 * tests/du/exclude: Test for this.
1382 * NEWS: Document this.
1384 Ensure that tests/Makefile.am's check-root actions stay up to date.
1385 * Makefile.maint (sc_root_tests): New rule.
1386 (syntax-check-rules): Add it to the list.
1388 2005-01-04 Jim Meyering <jim@meyering.net>
1390 * man/shred.x: Change one-line summary to reflect that shred does
1391 not remove files by default. Suggestion from Helen Faulkner in
1392 http://bugs.debian.org/288552
1394 * README: Request VERBOSE=yes output when reporting test failures.
1395 Other minor changes.
1397 * tests/Makefile.am (check-root): Update.
1399 2005-01-03 Paul Eggert <eggert@cs.ucla.edu>
1401 * src/system.h: Undo previous change; we now use Autoconf.
1403 2005-01-03 Jim Meyering <jim@meyering.net>
1405 * tests/stty/row-col-1: Don't set rows or columns to zero, to avoid
1406 a bug in the TIOCGWINSZ ioctl on at least Solaris5.9 systems. Setting
1407 either (or both) to zero would succeed, but subsequent `stty size'
1408 would say `no size information for this device' due to the ioctl
1409 failing with EINVAL.
1411 * src/system.h: If PRIdMAX, PRIoMAX, PRIuMAX, and PRIxMAX are
1412 not all defined and either ULONG_MAX or ULLONG_MAX is not defined,
1413 then fail at compile-time rather than let tools like od produce
1414 invalid results at run time.
1416 2004-12-21 Jim Meyering <jim@meyering.net>
1418 * src/csplit.c (usage): Say the default names are `xx00, xx01, ...',
1419 not `xx01, xx02, ...'.
1420 Reported by Matt Kraai in http://bugs.debian.org/286605
1422 * tests/misc/split-fail: Avoid spurious failure on x86 Solaris5.9
1425 2004-12-20 Paul Eggert <eggert@cs.ucla.edu>
1427 * src/split.c (usage): Mention default size. Suggested by Dan Jacobson.
1429 2004-12-19 Paul Eggert <eggert@cs.ucla.edu>
1431 * NEWS: Mention that one should eval "`dircolors`" rather than
1434 2004-12-17 Jim Meyering <jim@meyering.net>
1436 * tests/mv/hard-link-1: Rearrange to use newer trap-handling code,
1437 so temporary directories aren't left behind upon e.g., interrupt.
1439 2004-12-16 Paul Eggert <eggert@cs.ucla.edu>
1441 * src/ls.c (print_dir): Use "%s: not listing already-listed
1442 directory", not "not listing already-listed directory: %s", to
1443 format already-listed directories, to be consistent with other
1444 diagnostics involving file names and colons.
1446 2004-12-15 Jim Meyering <jim@meyering.net>
1448 * src/Makefile.am (__LDADD): Define, so that building `[' on
1449 Solaris still uses the -lgen library that it requires in order
1450 to get a definition of eaccess.
1452 2004-12-14 Jim Meyering <jim@meyering.net>
1454 tac would exit immediately upon I/O or temp-file creation failure.
1455 Now it continues on, processing any remaining command line arguments.
1457 * src/tac.c: Include quotearg.h.
1458 Use quotearg_colon in most diagnostics.
1459 (copy_to_temp): Rewrite not to exit upon I/O or temp-file-creation
1460 failure. Before, this command (with /full/tmp being a full partition)
1461 TMPDIR=/full/tmp ./tac /proc/modules tac.c
1462 would exit immediately upon the write error while trying to copy
1463 non-seekable /proc/modules to the full partition. Now it still
1464 reports the failure but continues on with the remaining file.
1465 (tac_nonseekable): Return false also if copy_to_temp fails.
1466 [DONT_UNLINK_WHILE_OPEN]: Add a FIXME comment explaining that
1467 using atexit like this is wrong.
1468 * NEWS: Document this.
1469 * tests/misc/tac-continue: New test for this.
1470 * tests/misc/Makefile.am (TESTS): Add tac-continue.
1472 * tests/chown/basic: Add a few more tests.
1474 2004-12-13 Paul Eggert <eggert@cs.ucla.edu>
1476 * src/ls.c (gobble_file): Change arg name to be command_line_arg
1477 rather than explicit_arg, for consistency with copy.c.
1478 (extract_dirs_from_files): Remove ignore_dot_and_dot_dot arg, since
1479 it is deducible from dirname arg. All callers changed.
1480 (extract_dirs_from_files, print_dir, queue_directory):
1481 Add command_line_arg arg. All callers changed.
1482 (struct pending): Add command_line_arg member.
1483 (main): Use NULL rather than 0 when appropriate.
1484 (set_exit_status, file_failure): New functions.
1485 (queue_directory): Store command_line_arg into new structure.
1486 (print_dir, gobble_file, get_link_name):
1487 Use file_failure to report problems in accessing files,
1488 so that the exit status is set consistently.
1489 (print_dir): Simplify readdir failure code yet again.
1490 If closedir fails, report "closing directory" rather than "reading
1492 (xstrcoll): Use set_exit_status to set status on failure.
1493 * tests/ls-2/tests (no-a-isdir-b): This now exits with status 2,
1496 2004-12-11 Jim Meyering <jim@meyering.net>
1498 Avoid a race condition vulnerability in chown, when used with
1499 --from=O:G and without the (-h) --no-dereference option.
1500 * src/chown-core.c (restricted_chown): New function.
1501 (change_file_owner): Call it.
1502 Reported by Ulrich Drepper.
1503 * NEWS: Mention this.
1505 2004-12-09 Paul Eggert <eggert@cs.ucla.edu>
1507 * ls now exits with status 1 on minor problems, 2 if serious trouble.
1508 * NEWS: Document this.
1509 * src/ls.c (LS_MINOR_PROBLEM, LS_FAILURE): New constants.
1510 All uses of EXIT_FAILURE replaced with LS_FAILURE, unless
1512 (main): Initialize exit failure to LS_FAILURE.
1513 (print_dir, gobble_file, get_link_name, xstrcoll):
1514 Set exit status to LS_MINOR_PROBLEM if the failure is minor.
1515 (print_dir): Do not give up on entire directory merely because readdir
1517 (usage): Explain exit status.
1518 * tests/help-version: ls and variants now exit with status 2
1521 2004-12-08 Paul Eggert <eggert@cs.ucla.edu>
1523 * NEWS: Document new UTC+HH:MM date syntax, and put date changes
1526 2004-12-07 Paul Eggert <eggert@cs.ucla.edu>
1528 * src/factor.c (factor): Don't list 1 as a factor of 1.
1529 Problem reported by Thomas Folz-Donahue.
1531 2004-12-06 Jim Meyering <jim@meyering.net>
1533 * tests/du/files0-from: Sanitize environment.
1534 Otherwise, e.g., BLOCKSIZE=k would cause a failure, and that
1535 setting is the default (exported from /etc/profile) on at least one
1537 * tests/du/no-deref: Likewise.
1538 * tests/cp/symlink-slash: Likewise.
1539 * tests/ls/symlink-slash: Likewise
1541 2004-12-05 Jim Meyering <jim@meyering.net>
1543 * tests/tail/Test.pm (err-6) ["tail -c"]: Avoid test failure when
1544 _POSIX2_VERSION=199209 is in the environment, or when building on
1547 2004-12-04 Jim Meyering <jim@meyering.net>
1549 * NEWS: Mention cut's new --complement option.
1551 2004-10-01 Paolo Bonzini <bonzini@gnu.org>
1553 * cut.c (complement, COMPLEMENT_OPTION): New.
1554 (longopts): Add --complement.
1555 (usage): Say not that -b, -c, and -f `print' fields,
1556 but rather that they `select' fields for printing.
1557 Describe the new --complement option.
1558 (mark_range_start): Extracted from set_fields.
1559 (print_kth): Support --complement.
1560 (compare_ranges): New function.
1561 (set_fields): Rewrite the part that populates range_start_ht,
1562 merging it with the part that populates printable_field.
1563 (main): Handle --complement.
1565 2004-12-03 Paul Eggert <eggert@cs.ucla.edu>
1567 * src/tail.c (tail_file): Set errnum to -1 if the initial "tail"
1568 failed. This works around an assertion failure reported by
1570 http://lists.gnu.org/archive/html/bug-coreutils/2004-12/msg00012.html
1572 2004-12-02 Jim Meyering <jim@meyering.net>
1574 With using --color and with LS_COLORS saying not to color
1575 executables, don't stat every file.
1576 * src/ls.c (is_colored): New function.
1577 (gobble_file): Use it.
1578 (main): Use it here, in place of too-strict tests against NULL:
1579 if either ORPHAN or MISSING was set to 0 from LS_COLORS, the
1580 old test would fail.
1582 2004-12-01 Paul Eggert <eggert@cs.ucla.edu>
1584 * src/comm.c (compare_files): Assume setlocale exists.
1585 * src/join.c (keycmp): Likewise.
1586 * src/seq.c (decimal_point): Treat like sort. Now char.
1588 (main): Assume localeconv exists. Use same code as sort.
1589 * src/sort.c (C_DECIMAL_POINT): Remove. Use changed to '.'.
1590 Assume setlocale exists.
1591 (thousands_sep): Renamed from th_sep.
1592 (IS_THOUSANDS_SEP): Remove. All uses replaced by comparisons.
1593 (NONZERO): Parenthesize use of arg.
1594 (numcompare): Avoid duplicate loads. Use ISDIGIT as boolean, for
1595 consistency. Avoid unnecessary negation by reversing
1597 (main): Rewrite localeconv call to match seq.c.
1598 * src/system.h: Assume locale.h exists.
1599 (HAVE_SETLOCALE): Remove.
1600 * src/uniq.c (different): Assume setlocale exists.
1602 * src/ls.c (sort_files): Minor cleanup. Remove an unnecessary
1603 'volatile' on a local variable. Rewrite to avoid unnecessary
1604 double-assignment to 'func' in the usual case where strcoll does
1607 2004-11-30 Paul Eggert <eggert@cs.ucla.edu>
1609 * src/pinky.c (gethostname): Remove decl.
1610 (scan_entries): Use IS_USER_PROCESS instead of by-hand code.
1611 * src/uptime.c (print_uptime): Use IS_USER_PROCESS and
1612 UT_TYPE_BOOT_TIME instead of by-hand code.
1613 * src/users.c (list_entries_users): Use IS_USER_PROCESS
1614 instead of by-hand code.
1615 * src/who.c (USER_PROCESS, RUN_LVL, INIT_PROCESS, LOGIN_PROCESS,
1616 DEAD_PROCESS, BOOT_TIME, NEW_TIME, UT_TYPE_UNDEF, UT_TYPE): Remove.
1617 (IS_USER_PROCESS): Move to ../lib/readutmp.h.
1618 (UT_TYPE_RUN_LVL, UT_TYPE_INIT_PROCESS, UT_TYPE_LOGIN_PROCESS,
1619 UT_TYPE_DEAD_PROCESS, UT_TYPE_NEW_TIME): New macros.
1620 (gethostname): Remove decl.
1621 (list_entries_who, scan_entries): Use the new macros defined above,
1622 for consistency with pinky, uptime, and users.
1624 2004-11-25 Paul Eggert <eggert@cs.ucla.edu>
1626 Fix problem reported by Scott S. Tinsley for HP-UX 11.11 using
1627 HP's ANSI C compiler. Declaring int functions causes warnings on
1628 some modern systems and shouldn't be needed to compile on ancient
1630 * src/copy.h (stat, lstat, rename): Remove decls.
1631 * src/install.c (stat): Remove decl.
1632 * src/ln.c (link, symlink): Remove decls.
1634 2004-11-25 Jim Meyering <jim@meyering.net>
1636 * man/help2man: Import help2man-1.35.1.
1637 * man/Makefile.am (.x.1): Remove now-unnecessary use of
1638 locally-added --program-name=NAME option. Now, help2man gets
1639 the name from the [NAME] section (i.e. from our .x file).
1640 * man/install.x: Use `install', not `ginstall' in the one-line
1641 description. Reported by Brendan O'Dea.
1642 * man/sha1sum.x: Use `sha1sum', not `shasum'.
1644 2004-11-24 Jim Meyering <jim@meyering.net>
1646 Since the changes of 2004-05-22, the u.saved_cwd member at
1647 the bottom of the active-directory stack was no longer
1648 strictly necessary. This change removes that member and uses
1649 the newer cwd_state parameter for the final restore_cwd.
1651 * src/remove.c (struct AD_ent) [u]: Remove now-unnecessary union.
1652 [dev_ino]: Rename from `a'.
1653 (AD_pop_and_chdir): Add a parameter to play the role of just-removed
1654 bottom-of-stack cwd-state member.
1655 (AD_pop_and_chdir): No longer return boolean. Adjust caller.
1656 (AD_push_initial): Remove CWD parameter. Adjust caller.
1658 2004-11-23 Paul Eggert <eggert@cs.ucla.edu>
1660 Minor performance improvements and cleanups for "touch".
1661 * src/touch.c (posix_date): Remove; not needed as a static var.
1663 (touch): Use new futimens function to operate more efficiently
1664 in some cases. Don't stat/fstat existing file when
1665 (!amtime_now && change_times == (CH_ATIME | CH_MTIME)); the
1666 old time stamps aren't needed in that case.
1667 (main): change_times is int, not bool. Simplify test for
1670 2004-11-20 Paul Eggert <eggert@cs.ucla.edu>
1672 * src/install.c (usage): Avoid usage that runs afoul of Docbook
1673 translation. Problem reported by Eric S. Raymond.
1675 Restore dd's noctty flag, reverting the change of 2004-04-08.
1676 POSIX does not allow "dd" to use O_NOCTTY by default.
1677 * NEWS: Add noctty flag to dd.
1678 * doc/coreutils.texi (dd invocation): Likewise.
1679 * src/dd.c (flags, usage, main): Likewise.
1681 2004-11-19 Alfred M. Szmidt <ams@gnu.org>
1683 * src/ls.c (usage): Clarified description of --no-group (-G),
1684 --human-readable (-h), --inode (-i), --size (-s), --time,
1687 2004-11-19 Jim Meyering <jim@meyering.net>
1689 * src/ls.c (usage): Clarify description of --author.
1690 Tweak indentation so that help2man creates better nroff.
1691 Reported by Dan Jacobson.
1693 * src/uniq.c (check_file): Don't check stdout for errors here.
1695 * src/pwd.c (find_dir_entry): Update comment to match reality.
1697 2004-11-18 Jim Meyering <jim@meyering.net>
1699 * src/pwd.c (robust_getcwd): Correct the comment: this function
1700 constructs the directory name. The caller prints it.
1702 2004-11-16 Paul Eggert <eggert@cs.ucla.edu>
1704 * src/stat.c (STATFS): New macro, for portability to Solaris 9.
1705 (do_statfs): Use it.
1707 * src/basename.c, src/chroot.c, src/cksum.c, src/dd.c, src/dirname.c,
1708 src/factor.c, src/hostid.c, src/hostname.c, src/link.c, src/logname.c,
1709 src/nohup.c, src/printenv.c, src/pwd.c, src/setuidgid.c, src/sleep.c,
1710 src/sync.c, src/tsort.c, src/unlink.c, src/uptime.c, src/users.c,
1711 src/whoami.c, src/yes.c (main): Use getopt_long rather than getopt.
1712 * src/readlink.c (main): argv is not const.
1714 * src/cut.c (usage): Improve documentation along the lines suggested
1716 * src/echo.c (usage): Likewise.
1717 * src/expr.c (usage): Likewise.
1719 * src/dircolors.hin: Add putty, screen-bce.
1721 * src/pinky.c (print_entry): Fix memory leak.
1722 * src/who.c (print_user): Likewise.
1724 2004-11-15 Paul Eggert <eggert@cs.ucla.edu>
1726 * NEWS: New dd operand "status=noxfer".
1727 * src/dd.c (C_ASCII, C_EBCDIC, C_IBM, C_BLOCK, C_UNBLOCK,
1728 C_LCASE, C_UCASE, C_SWAB, C_NOERROR, C_NOTRUNC, C_SYNC, C_TWOBUFS,
1729 C_NOCREAT, C_EXCL, C_FDATASYNC, C_FSYNC): Now constants, not
1731 (STATUS_NOXFER, statuses): New constants.
1732 (usage, print_stats, scanargs): Add support for status=noxfer.
1733 (usage): Update status output to match new behavior.
1734 (print_stats): Always output complete byte count.
1735 Put space between numbers and units, as SI requires.
1736 Use ngettext so that i18n can use plurals for "byte" and "second".
1737 Don't multiply by 1e-9 (inexact); divide by 1e9 (which is exact).
1738 (iflag_error_msgid, oflag_error_msgid): Remove; replace uses by
1740 * tests/dd/skip-seek (@Tests): Use status=noxfer to avoid
1741 problems with regression testing.
1743 2004-11-14 Paul Eggert <eggert@cs.ucla.edu>
1745 * NEWS: dd now outputs total bytes, seconds, and bytes per second.
1746 * src/Makefile.am (dd_LDADD): Add $(LIB_CLOCK_GETTIME).
1747 * src/dd.c: Include "human.h".
1748 (w_bytes, start_time): New vars.
1749 (usage): Document new I/O statistics output
1750 (print_stats): Output new I/O statistics.
1751 (cleanup): Do statistics after closing stdin and stdout, so that
1752 the times are more accurate.
1753 (write_output, dd_copy): Count output bytes.
1754 (main): Get initial value of clock.
1756 2004-11-14 Jim Meyering <jim@meyering.net>
1758 Backslash-escape `-'s in email addresses, so that they are
1759 rendered properly in UTF-locales.
1760 * man/help2man (escape_hyphens): New function.
1761 (main): Call it on email addresses.
1763 * src/sort.c (zaptemp): Mark new diagnostic for translation.
1765 * tests/misc/close-stdout: New file. Test today's closeout.c change.
1766 * tests/misc/Makefile.am (TESTS): Add close-stdout.
1768 2004-11-13 Jim Meyering <jim@meyering.net>
1770 * src/test.c (usage): Put the description of `[-n] STRING'
1771 on two lines, one for `-n STRING' and one for `STRING' so that
1772 help2man properly escapes the `-'. Otherwise, the hyphen is
1773 rendered inappropriately in UTF-8 locales.
1774 Reported by Uwe Zeisberger in http://bugs.debian.org/281069.
1776 2004-11-12 Paul Eggert <eggert@cs.ucla.edu>
1778 * NEWS: Document the following changes.
1780 * src/sort.c: Avoid O(N**2) behavior when there are many temporary
1782 (temptail): New variable, so that we can easily append to list.
1783 (create_temp_file): Create new files at end of list, so that
1784 searching the list has O(N*NMERGE) behavior instead of O(N**2).
1785 (zaptemp): Update temptail if needed.
1786 (mergefps, merge): Accept new arg that counts temp files, and keep it
1787 up to date as we create and remove temporaries. This is for
1788 efficiency, so that we don't call zaptemp so often.
1789 All callers changed.
1790 (sort): Don't create array in reverse order, since the list of
1791 temporaries is now in the correct order.
1793 (zaptemp): Protect against race condition: if 'sort' is
1794 interrupted in the middle of zaptemp, it might unlink the
1795 temporary file twice, and the second time this happens the file
1796 might already have been created by some other process.
1798 (zaptemp): Warn if a temporary file is not removed.
1800 (create_temp_file): Use offsetof for clarity.
1801 (die): Move it up earlier, to clean up the code a bit.
1803 * src/pr.c (strtoumax): Declare if not declared.
1804 (skip_to_page, first_page_number, last_page_number, page_number,
1805 first_last_page, print_header):
1806 Use uintmax_t for page numbers.
1807 (first_last_page): Remove unnecessary forward declaration.
1808 Do not modify arg (it is now a const pointer).
1809 Return a true if successful, false (without print a diagnostic)
1811 (main): If +XXX does not specify a valid page range, treat it
1812 as a file name. This follows the response to Open Group XCU ERN 41
1813 <http://www.opengroup.org/sophocles/show_mail.tpl?source=L&listname=austin-group-l&id=7717>,
1814 which says the behavior is allowed.
1815 (skip_to_page): When starting page number exceeds page count,
1816 print both numbers in the diagnostic.
1817 (print_header): Detect page number overflow.
1819 2004-11-07 Jim Meyering <jim@meyering.net>
1821 * src/uname.c [__APPLE__]: Include <mach/machine.h> and <mach-o/arch.h>.
1822 (main) [__APPLE__]: Get the processor type via syscall rather than
1823 hard-coding "powerpc". From Toby Peterson.
1825 * src/sort.c (merge): Remove declarations of now-unused variables.
1827 2004-11-06 Paul Eggert <eggert@cs.ucla.edu>
1829 * src/sort.c (first_same_file): Remove. Move most of the code to....
1830 (avoid_trashing_input): New function.
1831 (merge): Avoid some silly merges, e.g., copying a single file to
1832 a temporary file when there are exactly 17 input files to merge.
1833 Take a count of temporary files rather than a max_merge arg.
1836 2004-11-06 Jim Meyering <jim@meyering.net>
1838 * src/sort.c (xfclose): Don't close stdout here (just flush it),
1839 since close_stdout now closes stdout unconditionally.
1841 2004-11-05 Paul Eggert <eggert@cs.ucla.edu>
1843 * src/sort.c (inittables, sort_buffer_size, getmonth, mergefps,
1844 first_same_file, merge, sort, main): Use size_t for indexes to arrays.
1845 This fixes some unlikely havoc-wreaking bugs (e.g., more than INT_MAX
1847 (getmonth, keycompare, compare): Rewrite to avoid need for alloca,
1848 thus avoiding unchecked stack overflow in some cases. As a side
1849 effect this improve the performance of "sort -M" by a factor of 4
1852 2004-11-03 Paul Eggert <eggert@cs.ucla.edu>
1854 * src/stty.c: Include "vasprintf.h" since we use vasprintf now.
1856 * src/Makefile.am (check-AUTHORS): Don't assume \? works in a sed
1857 expression; it's not portable. Problem reported by Albert Chin.
1858 Don't invoke a program more than once.
1859 * src/groups.sh (version): New variable, containing author info,
1860 for benefit of AUTHORS check. Use it when acting on --version option.
1861 * AUTHORS: Remove duplicate lines. Remove bogus "chroot:"
1864 * src/system.h: Don't #define and #undef getopt around <stdlib.h>,
1865 as this breaks the new regime that does "#define getopt rpl_getopt".
1866 Problem reported by Albert Chin for Solaris 9 with Sun cc in:
1867 http://lists.gnu.org/archive/html/bug-gnulib/2004-11/msg00019.html
1868 I suppose this may cause problems on ancient hosts with
1869 incompatible getopt declarations, but we'll cross that bridge if
1870 the problem gets reported to us by someone who can test the fix.
1872 2004-11-03 Jim Meyering <jim@meyering.net>
1874 * src/tac.c: quote(...) file names in diagnostics.
1876 2004-10-29 Paul Eggert <eggert@cs.ucla.edu>
1878 * NEWS: Document getdate changes.
1880 2004-10-29 Jim Meyering <jim@meyering.net>
1882 * src/tac.c (tac_file): Remove temporary prototype and move this
1883 function `down' so that it precedes definition of tac_nonseekable.
1885 `tac /proc/modules' would print nothing
1886 Reported by Harald Dunkel in http://bugs.debian.org/278604.
1888 * src/tac.c (copy_to_temp): Renamed from save_stdin, since
1889 now it copies a general file descriptor, not just stdin.
1890 (tac_nonseekable): Renamed/adapted from tac_stdin.
1891 (tac_file): Get fd via `open' directly rather than via fopen/fileno,
1892 since we never used the stream. Perform "-" to stdin mapping here
1893 rather than in main. Determine whether a file is seekable,
1894 by trying to `lseek' to its end, and dispatch to tac_seekable or
1895 tac_nonseekable accordingly.
1896 (main): Rewrite argument handling now that it uses only tac_file.
1897 * NEWS: Mention it here.
1899 2004-10-21 Jim Meyering <jim@meyering.net>
1901 * tests/mv/leak-fd: New file.
1902 * tests/mv/Makefile.am (TESTS): Add it.
1903 * tests/rm/dot-rel: New file.
1904 * tests/rm/Makefile.am (TESTS): Add it.
1906 Correct my patch of 2004-10-18.
1907 * src/remove.c (rm): Destroy the saved_cwd here (via cwd_state),
1908 if necessary, not in remove_dir. Otherwise, removing multiple
1909 `.'-relative nonempty directories no longer worked.
1911 2004-10-20 Paul Eggert <eggert@cs.ucla.edu>
1913 * src/fmt.c (usage): Improve description of --prefix.
1914 Problem reported by Edward Welbourne.
1916 * man/uniq.x: Change summary so that it doesn't imply that
1917 uniq writes to its input file. Problem reported by
1920 2004-10-18 Jim Meyering <jim@meyering.net>
1922 Plug a leak that would cause a cross-device mv to fail when
1923 operating on too many command-line-specified nonempty directories.
1924 * src/remove.c (remove_dir): Destroy the `struct saved_cwd' on the
1925 top of the stack before returning. This usually closes the file
1926 descriptor that was used to return to the original working directory.
1927 Reported by Cyril Bouthors in
1928 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/3048
1929 * NEWS: Mention it here.
1931 * src/pathchk.c (validate_file_name): Give a more descriptive
1932 diagnostic when pathconf fails. This also avoids an unwarranted
1933 warning from gcc-3.3.5 about a format not being a string literal.
1935 * src/sleep.c (main): Remove declaration of unused local, c.
1936 * src/printenv.c (main): Likewise.
1937 * src/logname.c (main): Likewise.
1938 * src/uptime.c (main): Likewise, for optc.
1939 * src/tsort.c (main): Likewise, for opt.
1941 2004-10-17 Paul Eggert <eggert@cs.ucla.edu>
1943 * AUTHORS: Add self to pathchk.
1944 * src/pathchk.c (AUTHORS): Add self.
1945 Change "path" to "file name" whenever possible.
1946 Remove usage comment, as it was a duplication of the code or doc.
1947 Include <wchar.h> if available.
1948 (mbrlen, mbstate_t) [! (HAVE_MBRLEN && HAVE_MBSTATE_T)]: Define.
1949 (NEED_PATHCONF_WRAPPER, PATH_MAX, PATH_MAX_FOR, NAME_MAX,
1950 pathconf_wrapper, portable_chars, dir_ok): Remove.
1951 (NAME_MAX_MINIMUM, PATH_MAX_MINIMUM): New macros.
1952 (pathconf, _PC_NAME_MAX, _PC_PATH_MAX): Define if nonexistent.
1953 (portable_chars_only): New arg FILELEN.
1954 Don't assume ASCII; we might be on an EBCDIC host.
1955 Don't assume unibyte locale in diagnostic.
1956 (component_start, component_len): New functions.
1957 (validate_file_name): Renamed from validate_path. All uses changed.
1958 Pretty much a complete rewrite.
1959 Don't make copy of file arg. Always append trailing slash to
1960 pathconf arg, just in case it's a symlink (this is pure paranoia;
1961 we don't know of any hosts where the trailing slash is required).
1962 Use size_t instead of long int when possible.
1963 Avoid need to call pathconf in most practical cases.
1964 Don't use euidaccess several times to test searchability;
1965 just use lstat once. Reword diagnostic to put the (often very long)
1968 2004-10-15 Paul Eggert <eggert@cs.ucla.edu>
1970 * src/printf.c (usage): Mention Unicode, and use H for hex digits.
1972 2004-10-13 Jim Meyering <jim@meyering.net>
1974 * NEWS: Mention today's fts.c fix.
1976 2004-10-13 Paul Eggert <eggert@cs.ucla.edu>
1978 * tests/stty/row-col-1: Set LC_ALL=C.
1980 2004-10-12 Jim Meyering <jim@meyering.net>
1982 * src/dircolors.hin: Add .flac and .mpc as audio suffixes.
1983 From Jesus Climent in http://bugs.debian.org/276149.
1985 2004-10-05 Paul Eggert <eggert@cs.ucla.edu>
1987 * src/ls.c (ignore_mode): Renamed from ignore, to avoid shadowing
1988 problems. All uses changed.
1990 2004-10-05 Jim Meyering <jim@meyering.net>
1992 * .x-sc_trailing_blank: Add an exclusion for config/texinfo.tex,
1993 since Karl says its trailing blanks are there to stay :-)
1995 2004-10-04 Paul Eggert <eggert@cs.ucla.edu>
1997 * src/expr.c (NEW, OLD): Remove, partly to avoid
1998 reference to obsolescent macro XMALLOC.
1999 All uses replaced by xmalloc and free.
2001 2004-09-28 Jim Meyering <jim@meyering.net>
2003 * src/tail.c (usage): Clarify: --retry works only with --follow=name.
2004 Reported by Nik A. Melchior in http://bugs.debian.org/273781.
2006 2004-09-27 Paul Eggert <eggert@cs.ucla.edu>
2008 * src/od.c (format_address_paren): c is optional, so don't output
2011 2004-09-26 Paul Eggert <eggert@cs.ucla.edu>
2013 Add support for ls --hide. Idea suggested by Bardur Arantsson.
2014 * NEWS: Document this.
2015 * src/ls.c (file_ignored): Renamed from file_interesting, with
2016 inverted return value. Accept the file name, not a struct dirent *.
2017 All uses changed. Avoid the expense of calling fnmatch if the
2018 file is ignorable due to leading '.'.
2019 (all_files, really_all_files): Removed; replaced by:
2020 (ignore): New variable. All uses changed.
2021 (IGNORE_DEFAULT, IGNORE_DOT_AND_DOTDOT, IGNORE_MINIMAL, HIDE_OPTION):
2023 (hide_patterns): New variable.
2024 (long_options, decode_switches, file_ignored, usage):
2025 Add support for --hide.
2026 (patterns_match): New function.
2027 (usage): Replace "hide" with "ignore" in explanation, to avoid
2030 2004-09-25 Paul Eggert <eggert@cs.ucla.edu>
2032 * src/ls.c (gobble_file, print_long_format): Don't assume that
2033 human-readable output has a byte count equal to its column width;
2034 this isn't always true in locales where the radix character is not
2036 (format_user_or_group): Revamp code to match the above fix;
2037 this avoids the (very faint) possibility of integer overflow.
2039 2004-09-24 Paul Eggert <eggert@cs.ucla.edu>
2041 * NEWS: Mention that "chmod -r -w x" now works as expected.
2042 * src/chmod.c (main): Revamp option processing to support this.
2043 * tests/chmod/Makefile.am (TESTS): Add 'usage'.
2044 * tests/chmod/usage: New set of tests for usage like that.
2046 2004-09-24 Jim Meyering <jim@meyering.net>
2048 * Makefile.maint (CVS_LIST): Use --types=AFGM option so that
2049 it lists only cvs-controlled regular files.
2051 * src/csplit.c (xalloc_die): Declare to be `extern', not `static'
2052 to avoid a warning from gcc-3.4.1. Reported by Paul Eggert.
2054 2004-09-23 Paul Eggert <eggert@cs.ucla.edu>
2056 * Makefile.maint (CVS_LIST): New macro.
2057 (sc_space_tab, sc_prohibit_atoi_atof, sc_file_system,
2058 sc_prohibit_jm_in_m4, sc_system_h_headers, sc_sun_os_names,
2059 sc_trailing_blank, po-check): Use it instead of the
2060 nonstandard "cvsu --list".
2062 * src/tail.c (parse_obsolete_option): Bring back support
2063 for obsolete option followed by non-obsolete, or by more
2064 than one file. When obsolete, conform to SUSv2 rather than
2065 original POSIX 1003.2-1992, as SUSv2 corrected the case of
2066 "tail -c". Add support for the SUSv2 "b" modifier.
2067 * NEWS: Mention the above.
2068 * tests/tail/Test.pm: New test case obs-b to check the above.
2069 err-[134] no longer need _POSIX2_VERSION=199209.
2070 Fix comments to match revised behavior.
2072 2004-09-22 Jim Meyering <jim@meyering.net>
2074 * Use automake-1.9.2. Regenerate dependent files.
2076 * src/remove.c (struct dirstack_state) [current_arg_jumpbuf]:
2077 Improve the comment.
2079 Clean up scoping etc. so that some make `distcheck' tests pass.
2080 * src/csplit.c (xalloc_die): Declare to be static.
2081 * src/chown-core.c (chown_files): Declare as `extern'.
2082 * src/cp-hash.c (remember_created): Likewise.
2083 * src/copy.c (copy): Likewise.
2084 * src/checksum.h (enum) [ALG_MD5]: Define to be 1, not 0.
2086 * src/id.c, src/nl.c, src/expand.c: Remove trailing blanks.
2087 * src/unexpand.c: Likewise.
2089 * src/Makefile.am (check-AUTHORS): New rule.
2090 (check): Depend on it.
2093 * Makefile.maint (syntax-check-rules): Remove duplicate sc_tight_scope.
2094 (sc_system_h_headers): Also exclude copy.h; it includes <stdbool.h>.
2096 2004-09-22 Paul Eggert <eggert@cs.ucla.edu>
2098 * src/ls.c (decode_switches): Don't compare a short value
2099 to SIZE_MAX: GCC sometimes complains.
2101 2004-09-21 Paul Eggert <eggert@cs.ucla.edu>
2103 * NEWS: The following commands now reject unknown options:
2104 basename dirname factor hostname link nohup sync unlink yes
2105 Also, pathchk no longer accepts trailing options.
2107 * src/basename.c: Include <getopt.h>.
2108 * src/chroot.c: Likewise.
2109 * src/dirname.c: Likewise.
2110 * src/factor.c: Likewise.
2111 * src/hostid.c: Likewise.
2112 * src/hostname.c: Likewise.
2113 * src/nohup.c: Likewise.
2114 * src/pwd.c: Likewise.
2115 * src/setuidgid.c: Likewise.
2116 * src/sync.c: Likewise.
2118 * src/basename.c (main): Reject unknown options.
2119 * src/dirname.c (main): Likewise.
2120 * src/factor.c (main): Likewise.
2121 * src/hostid.c (main): Likewise.
2122 * src/hostname.c (main): Likewise.
2123 * src/link.c (main): Likewise.
2124 * src/nohup.c (main): Likewise.
2125 * src/pwd.c (main): Likewise.
2126 * src/setuidgid.c (main): Likewise.
2127 * src/sync.c (main): Likewise.
2128 * src/unlink.c (main): Likewise.
2129 * src/yes.c (main): Likewise.
2131 * src/cat.c (main): Remove unused "case 0".
2132 * src/chgrp.c (main): Likewise.
2133 * src/chmod.c (main): Likewise.
2134 * src/chown.c (main): Likewise.
2135 * src/comm.c (main): Likewise.
2136 * src/cp.c (main): Likewise.
2137 * src/csplit.c (main): Likewise.
2138 * src/cut.c (main): Likewise.
2139 * src/date.c (main): Likewise.
2140 * src/df.c (main): Likewise.
2141 * src/du.c (main): Likewise.
2142 * src/env.c (main): Likewise.
2143 * src/expand.c (main): Likewise.
2144 * src/fold.c (main): Likewise.
2145 * src/head.c (main): Likewise.
2146 * src/id.c (main): Likewise.
2147 * src/install.c (main): Likewise.
2148 * src/join.c (main): Likewise.
2149 * src/ln.c (main): Likewise.
2150 * src/ls.c (decode_switches): Likewise.
2151 * src/mkdir.c (main): Likewise.
2152 * src/mkfifo.c (main): Likewise.
2153 * src/mknode.c (main): Likewise.
2154 * src/mv.c (main): Likewise.
2155 * src/nl.c (main): Likewise.
2156 * src/paste.c (main): Likewise.
2157 * src/pinky.c (main): Likewise.
2158 * src/pr.c (main): Likewise.
2159 * src/ptx.c (main): Likewise.
2160 * src/readlink.c (main): Likewise.
2161 * src/rm.c (main): Likewise.
2162 * src/rmdir.c (main): Likewise.
2163 * src/seq.c (main): Likewise.
2164 * src/shred.c (main): Likewise.
2165 * src/split.c (main): Likewise.
2166 * src/sum.c (main): Likewise.
2167 * src/tac.c (main): Likewise.
2168 * src/tail.c (main): Likewise.
2169 * src/tee.c (main): Likewise.
2170 * src/touch.c (main): Likewise.
2171 * src/tr.c (main): Likewise.
2172 * src/tty.c (main): Likewise.
2173 * src/uname.c (main): Likewise.
2174 * src/unexpand.c (main): Likewise.
2175 * src/wc.c (main): Likewise.
2176 * src/who.c (main): Likewise.
2178 * src/chroot.c (main): Use getopt where it suffices, not getopt_long.
2179 * src/cksum.c (main): Likewise.
2180 * src/dd.c (main): Likewise.
2181 * src/logname.c (main): Likewise.
2182 * src/printenv.c (main): Likewise.
2183 * src/sleep.c (main): Likewise.
2184 * src/tsort.c (main): Likewise.
2185 * src/uptime.c (main): Likewise.
2186 * src/users.c (main): Likewise.
2187 * src/whoami.c (main): Likewise.
2189 * src/du.c (long_options): Standardize on NULL vs 0.
2190 * src/rm.c (long_opts): Likewise.
2192 * src/logname.c (long_options): Remove.
2193 * src/printenv.c (long_options): Likewise.
2194 * src/sleep.c (long_options): Likewise.
2195 * src/tsort.c (long_options): Likewise.
2196 * src/uptime.c (longopts): Likewise.
2197 * src/users.c (longopts): Likewise.
2198 * src/whoami.c (long_options): Likewise.
2200 * src/pathchk.c (longopts): Add --help, --version.
2201 (main): Use longopts rather than parse_long_options.
2202 * src/stty.c (longpts, main): Likewise.
2204 * src/pathchk.c (main): Don't reorder arguments, so that
2205 we can check weird file names.
2207 * src/readlink.c: Don't include "long-options.h".
2208 * src/sort.c: Likewise.
2209 * src/stty.c: Likewise.
2211 * src/split.c (verbose): Now bool, not int.
2212 (VERBOSE_OPTION): New enum.
2213 (longopts, main): Use it.
2215 * tests/factor/basic: Adjust to new wording in diagnostic
2216 that results from the above changes.
2218 2004-09-21 Jim Meyering <jim@meyering.net>
2220 * man/rm.x: Say "the response is affirmative" rather than "the
2221 response begins with y or Y", so that the documentation is
2222 accurate in non-English locales. Problem reported by Munzir Taha.
2224 2004-09-19 Paul Eggert <eggert@cs.ucla.edu>
2226 * src/echo.c (main): Don't pass NULL to strcmp when
2227 POSIXLY_CORRECT and given no arguments.
2229 * src/md5sum.c (STRING_OPTION): Remove.
2230 (long_options, main): Remove support for undocumented and
2231 obsolete --string option, as suggested in the 1996-09-26 patch.
2232 * NEWS: Document this.
2234 * tests/rm/fail-eperm: Don't try to remove writeable files in a
2235 sticky /tmp directory, as SVR4-like systems (e.g., Solaris 9) let
2236 you remove such files. Problem reported by Bert Fischer in:
2237 http://lists.gnu.org/archive/html/bug-coreutils/2004-09/msg00074.html
2239 2004-09-18 Paul Eggert <eggert@cs.ucla.edu>
2241 * src/md5sum.c (STATUS_OPTION, STRING_OPTION): New enums.
2242 (long_options, main): Use them instead of magic numbers 2 and 1.
2243 For --string, optarg can't possibly be NULL.
2245 * src/dd.c (usage): Distinguish between options and operands.
2246 (scanargs): Don't mess with argc, argv; getopt_long handles this now.
2247 Say "operands" for operands, not "options".
2248 (main): Use getopt_long, so that "dd --" works as POSIX requires.
2249 * tests/dd/misc: Check for "dd --".
2251 * src/chroot.c (main): Reject unknown options instead of
2252 interpreting them as a directory to chroot to.
2254 * src/cksum.c: Remove obsolete comment about POSIX 1003.2/D11.2.
2255 The current standard (POSIX 1003.1-2004) is correct.
2256 (crc_remainder) [defined CRCTAB]: Renamed from "remainder" to avoid
2257 collision with builtin function.
2258 (main) [defined CRCTAB]: Output in lowercase hexadecimal, and
2259 output the first 0 as 8 digits, to make it easier to compare to
2260 the text of the standard. Output crctab to be a const array.
2261 (crctab): Use result of above changes.
2262 (long_options): Remove; not needed if empty.
2263 (main): getopt_long can't return 0 here, so simplify the code.
2265 2004-09-13 Jim Meyering <jim@meyering.net>
2267 * src/Makefile.am (localedir.h): Don't redirect directly to target.
2269 2004-09-13 Paul Eggert <eggert@cs.ucla.edu>
2271 * src/id.c (print_full_info): Don't exit with failure status simply
2272 because a user or group number can't be turned into a name.
2273 Problem reported by Felipe Kellermann in:
2274 http://lists.gnu.org/archive/html/bug-coreutils/2004-09/msg00081.html
2276 2004-09-12 Jim Meyering <jim@meyering.net>
2278 * Makefile.maint (my-distcheck): When building with -Werror, also
2281 2004-09-10 Paul Eggert <eggert@cs.ucla.edu>
2283 * NEWS: "tail" now handles obscure POSIX 1003.2-1992 cases better.
2284 * src/tail.c (parse_obsolete_option): Renamed from
2285 parse_obsolescent_option, since the options are obsolete now.
2286 Remove bool *arg; just exit if there's an error. Revamp to follow
2287 POSIX 1003.2-1992 more precisely, to handle cases like "tail -
2288 file" and "tail -10 -- file" correctly when we are conforming to
2290 (main): Adjust to this change.
2291 * tests/tail/Test.pm (test_vector): minus-* requires
2292 _POSIX2_VERSION=199209 now, to work correctly if there is
2293 an input file. err-1 and err-3 no longer errors if there
2296 2004-09-09 Paul Eggert <eggert@cs.ucla.edu>
2298 * src/test.c (usage): Document -r, -w, -x more carefully.
2300 2004-09-08 Paul Eggert <eggert@cs.ucla.edu>
2302 * src/test.c (usage): Document "test" (with no args) and "[ ]".
2303 Document that -h and -L don't dereference.
2305 * NEWS: Document that "tr xy -z" now works as per POSIX.
2306 Sort the descriptions.
2307 * src/tr.c (main): Don't reorder options.
2308 * tests/tr/Test.pm (fowler-1): New test case.
2310 2004-09-06 Paul Eggert <eggert@cs.ucla.edu>
2312 * src/touch.c (main): Fix POSIX-conformance bug: "touch --
2313 MMDDhhmm file" must be treated like "touch MMDDhhmm file" when
2314 conforming to pre-2001 POSIX.
2315 * NEWS: Document this.
2316 * tests/touch/obsolescent: Test for this bug. Also, set
2317 _POSIX2_VERSION=199209 and POSIXLY_CORRECT=1 so that it's
2318 a better test for obsolescent features.
2320 * src/sort.c (main): Emulate Solaris 8 and 9 "sort -y", so that
2321 "sort -y abc" is like "sort abc" whereas "sort -y 100" is like
2324 * src/od.c: Several changes for POSIX and FreeBSD compatibility.
2325 (COMMON_SHORT_OPTIONS): Add -B, -D, -e, -F, -H, -I, -L, -O, -s, -X.
2326 (long_options, main): --strings is now -S, not -s.
2327 (usage): Reflect the usage changes.
2328 (parse_old_offset): Do not issue a diagnostic on failure;
2329 callers now do this as necessary.
2330 (main): Support POSIX syntax. Remove unused case 0 from getopt_long.
2331 Add support for new short options (many undocumented) for
2332 compatibility with FreeBSD. Remove FIXME for -s; it's now
2333 POSIX-compatible. Default format is now oS, not o2.
2334 * NEWS: Describe the above.
2336 2004-09-05 Paul Eggert <eggert@cs.ucla.edu>
2338 * src/stty.c (valid_options): Remove.
2339 (main): Fix some bugs in handling invalid option-combinations
2341 (recover_mode): Arg is now char const *, not char *.
2342 (main): Use STDIN_FILENO, not 0.
2343 Simplify option-parsing code a tad.
2344 * tests/stty/basic-1: Check for the fixed bugs.
2346 2004-09-03 Paul Eggert <eggert@cs.ucla.edu>
2348 * src/stat.c (HAVE_STRUCT_STATXFS_F_TYPE): Fix typo that prevented
2349 it from ever being nonzero. Reported by Pozsar Balazs in:
2350 http://lists.gnu.org/archive/html/bug-coreutils/2004-08/msg00189.html
2351 (human_fstype): Add ramfs, squashfs, sysfs.
2352 Reported by Pozsar Balazs in:
2353 http://lists.gnu.org/archive/html/bug-coreutils/2004-08/msg00188.html
2354 (human_fstype): Return char const *, not char *.
2355 Simplify internals a bit, and avoid casts.
2357 * src/dd.c (usage): "alternated EBCDIC" -> "alternate EBCDIC".
2358 (bit_count): Remove. All uses changed to....
2359 (multiple_bits_set): New function.
2360 (scanargs): Use it, and check separately for each set of
2361 incompatible options, to improve diagnostics.
2363 (apply_translations): Move checks for incompatible options
2364 to scanargs, so that they're done consistently.
2366 2004-09-02 Paul Eggert <eggert@cs.ucla.edu>
2368 Output correct errno-related diagnostic on "paste" I/O errors.
2369 * src/paste.c (write_error, xputchar): New functions.
2370 (paste_parallel): Use correct errno value after input error.
2371 (paste_parallel, paste_serial): Report errno value after output error.
2373 Port to diet libc. Problem reported by Felix von Leitner in:
2374 http://lists.gnu.org/archive/html/bug-coreutils/2004-08/msg00171.html
2375 * src/paste.c (dummy_closed, CLOSED, dummy_endlist, ENDLIST): Remove;
2376 it's not portable C to assume FILE is a complete type.
2377 (paste_parallel): Use index test instead of ENDLIST, and NULL
2380 2004-08-24 Paul Eggert <eggert@cs.ucla.edu>
2382 POSIX-conformance fixes for "expand" and "unexpand".
2383 Also, consistently use "tab stop" rather than "tabstop".
2384 * NEWS: Document fixes.
2385 * src/expand.c: Revamp to resemble the new unexpand.c better.
2386 (usage): -i does not convert tabs after non-tabs.
2387 (add_tab_stop): Renamed from add_tabstop. All uses changed.
2388 (parse_tab_stop): Renamed from parse_tabstop. All uses changed.
2389 (validate_tab_stop): Renamed from validate_tabstop. All uses changed.
2390 (next_file, main): Check fclose against 0, not EOF.
2391 (expand): Remove unnecessary casts.
2392 Add another loop nesting level, for lines, so that per-line variables
2393 are initialized cleanly.
2394 Revamp tab checking. Check for write error immediately, rather
2395 than just once at the end of the program.
2396 * src/unexpand.c: Lkewise (for the expand.c changes).
2397 (TAB_STOP_SENTINEL): Remove.
2398 (tab_size): Now size_t, not uintmax_t, since we need to store
2399 the sequences of blanks.
2400 (max_column_width): New var.
2401 (usage): Say "blank" where POSIX requires this.
2402 (add_tab_stop): Calculate maximum column width.
2403 (unexpand): Store the pending blanks, instead of merely counting them.
2404 Follow POSIX's rules about -a requiring two blanks before a tab stop.
2405 Get rid of internal label and goto.
2406 * tests/unexpand/basic-1: Fix infloop-3 to match POSIX.
2407 Add blanks-1 through blanks-13.
2409 2004-08-19 Paul Eggert <eggert@cs.ucla.edu>
2411 * NEWS: "chown : file", "chown '' file", and "chgrp '' file" now
2412 succeed without changing the uid and gid, like FreeBSD.
2413 * src/chgrp.c (parse_group): Return gid_t rather than storing it
2414 through a pointer. Treat "chgrp '' file" as a no-op change,
2416 (main): Set chopt.group_name to NULL if the group is the empty
2418 * src/chown-core.c (describe_change): Describe changes to -1:-1
2419 without using "to OWNERSHIP" phrase.
2420 * src/chown.c (usage): "chown '' file" is now allowed.
2421 (main): Do not set user name to the empty string if the group
2423 * tests/chgrp/basic: Test "chgrp '' file".
2424 * tests/chown/Makefile.am (TESTS): Add separator.
2425 * tests/chown/separator: New file, partly taken from
2426 Dmitry V. Levin's suggestion in
2427 <http://lists.gnu.org/archive/html/bug-coreutils/2004-08/msg00102.html>
2429 2004-08-11 Paul Eggert <eggert@cs.ucla.edu>
2431 * tests/install/basic-1: Test for the -d regression.
2433 2004-08-11 Dmitry V. Levin <ldv@altlinux.org>
2435 * src/install.c (main): Fix -d regression introduced with
2436 --target-directory support at 2004-06-25.
2438 2004-08-11 Paul Eggert <eggert@cs.ucla.edu>
2440 * src/copy.c (copy_internal): When preserving links, unlink
2441 a destination with link count greater than one. This is so
2442 that commands like "cp -a" don't get confused when copying into
2443 a destination that already contains many hard links. Problem
2444 reported by Tim Waugh in:
2445 http://lists.gnu.org/archive/html/bug-coreutils/2004-08/msg00053.html
2447 2004-08-10 Paul Eggert <eggert@cs.ucla.edu>
2449 Convert all files to UTF-8.
2450 * tests/fmt/basic (8-bit-pfx): Use UTF-8, not Latin-1.
2451 * tests/sort/Test.pm (16a): Likewise.
2452 * tests/uniq/Test.pm (8): Likewise.
2453 * tests/misc/printf-hex: Use ASCII, not Latin-1.
2455 * NEWS: Document "sort -o -" and "tee -" POSIX-conformance fixes.
2456 * src/shred.c (usage): "-" is an operand, not an option.
2457 * src/sort.c (die, xfopen, mergefps, first_same_file, merge):
2458 A null file arg means standard output.
2459 (main): "-o -" means to write to a file named "-",
2460 not to standard output.
2461 * src/tee.c (usage, tee): "tee -" writes to standard output, not
2462 to a file named "-".
2464 2004-08-10 Dmitry V. Levin <ldv@altlinux.org>
2466 * src/install.c (change_timestamps): Fix int->bool conversion
2467 bugs introduced on 2004-07-29.
2469 2004-08-09 Paul Eggert <eggert@cs.ucla.edu>
2471 * src/shred.c (wipename): Work even if the directory is writeable
2472 and not readable. Prefer write access, since this should work
2473 better with fdatasync.
2475 * src/csplit.c (xalloc_die): New function.
2476 (main): Remove now-obsolete initialization of xalloc_fail_func.
2478 * src/md5sum.c: Adjust to sha->sha1 renaming.
2480 2004-08-08 Dmitry V. Levin <ldv@altlinux.org>
2483 * src/readlink.c (canonicalize_fname): Remove unneeded proxy function.
2484 (can_mode): Make variable local.
2486 2004-08-07 Paul Eggert <eggert@cs.ucla.edu>
2488 * src/system.h (O_BINARY) [!O_BINARY && defined O_BINARY]:
2489 Do not define, to avoid annoying compiler messages on QNX 6.3.
2490 Problem reported by Johan in:
2491 http://lists.gnu.org/archive/html/bug-coreutils/2004-08/msg00050.html
2493 2004-08-04 Paul Eggert <eggert@cs.ucla.edu>
2495 * src/system.h (PRIdMAX, PRIoMAX, PRIuMAX, PRIxMAX):
2496 Define to a concatenation of string literals, not to an expression;
2497 needed for concatenation contexts.
2498 (INTMAX_MAX, INTMAX_MIN): New macros.
2500 * src/stat.c (print_stat): Don't assume st_ino / st_dev fits in
2501 unsigned long; this isn't true for st_ino on Solaris 9.
2503 2004-08-03 Paul Eggert <eggert@cs.ucla.edu>
2505 * src/uname.c: Do not depend on HAVE_SYSCTL when deciding
2506 whether to include files. Include <sys/param.h> if
2507 HAVE_SYS_PARAM_H (not HAVE_SYSCTL).
2508 (main) [defined __POWERPC__]: Add a kludge to work around a
2509 Mac OS X bug, so that uname -p defaults to "powerpc" if
2510 sysctl ((int[]) {CTL_HW, HW_MACHINE_ARCH}, 2, buffer, &bufsize, 0, 0)
2511 fails. Problem reported by Petter Reinholdtsen in:
2512 http://lists.gnu.org/archive/html/bug-gnu-utils/2003-02/msg00201.html
2514 * src/uniq.c (hard_LC_COLLATE, ignore_case, different, check_file,
2515 main): Use bool for booleans.
2516 (writeline, check_file): Use uintmax_t for line counts.
2517 (check_file): Check for and report line number overflow,
2519 * src/wc.c (iswspace, wc): Use to_uchar rather than a cast.
2520 (print_lines, print_words, print_chars, print_bytes, print_linelength,
2521 have_read_stdin, wc, wc_file, main):
2522 Use bool for booleans.
2523 (exit_status): Remove.
2524 (wc, wc_file): Return bool status. All callers changed.
2525 * src/who.c (scan_entries): 0 -> STDIN_FILENO.
2526 * src/whoami.c (main): Print uids using unsigned long int, not
2529 * src/unexpand.c: Int cleanup and minor reorganization to be more
2531 Include quote.h, xstrndup.h.
2532 (TAB_STOP_SENTINEL): Increase from INT_MAX to INTMAX_MAX.
2533 (convert_entire_line, have_read_stdin, parse_tabstops, next_file,
2535 Use bool for booleans.
2536 (tab_size, tab_list, add_tabstop, validate_tabstops, unexpand):
2537 Use uintmax_t for column counts.
2538 (first_free_tab, validate_tabstops, unexpand): Use size_t for sizes.
2539 (add_tabstop, parse_tabstops, main): Don't reserve UINTMAX_MAX
2541 (parse_tabstops): Don't use ISBLANK on possibly-signed char.
2542 Detect overflow in tab stop string.
2543 (next_file, main): Use EXIT_FAILURE/EXIT_SUCCESS instead of 1/0.
2544 (unexpand): Concatenate input files the same way expand does.
2546 * src/touch.c (no_create, use_ref, posix_date, amtime_now,
2547 touch, main): Use bool for booleans.
2548 (main): Avoid integer overflow when given more than INT_MAX
2550 * src/tsort.c (struct item, n_strings): Use size_t for sizes.
2551 (have_read_stdin, count_items, scan_zeros, detect_loop,
2552 recurse_tree, walk_tree, tsort, main):
2553 Use bool for booleans.
2554 (exit_status): Remove.
2555 (tsort): Return a success flag instead of storing into a global.
2557 * src/tty.c (silent, main): Use bool for booleans.
2558 (main): 0 -> STDIN_FILENO.
2559 * src/uname.c (print_element): Use bool for booleans.
2561 * src/test.c (TRUE, FALSE, SHELL_BOOLEAN, TRUTH_OR, TRUTH_AND):
2562 Remove. All uses replaced by C99 boolean primitives.
2563 (TEST_TRUE, TEST_FALSE): New constants, for readability.
2564 (test_unop, binop, unary_operator, binary_operator, two_arguments,
2565 three_arguments, posixtest, expr, term, and, or, is_int, age_of,
2566 one_argument, main): Use bool for booleans.
2567 (advance, unary_advance): Now inline procedures rather than a macros.
2568 (is_int): Renamed from isint, to avoid namespace clash with ctype.h.
2569 (term, and, or): When it's easy, loop instead of recursing.
2570 (term): Avoid integer overflow if there are INT_MAX-3 args (!).
2571 (binary_operator, unary_operator): Simplify by systematically rewriting
2572 true==FOO to FOO (where FOO is a boolean).
2573 (unary_operator): Don't consider a file to be a regular file
2574 merely because its mode&S_IFMT is zero. Just use S_ISREG.
2575 Remove unnecessary casts. Remove ifdefs for things like
2576 S_ISSOCK that are no longer needed, since stat-macros.h always
2579 * src/tac-pipe.c (buf_init_from_stdin, find_bol, tac_mem):
2580 Use bool for booleans.
2581 (buf_init_from_stdin, buf_free, find_bol, print_line):
2582 Use size_t for sizes.
2583 * src/tac.c (separator_ends_record, tac_seekable, tac_file,
2584 tac_stdin, tac_stdin_to_mem, main): Use bool for booleans.
2585 (match_length, G_buffer_size, tac_seekable, main): Use size_t for sizes.
2586 (tac_seekable): Use ptrdiff_t for pointer subtraction.
2587 Report an error if the result is out of range.
2588 (tac_seekable, main): Check for integer overflow in buffer size
2590 (main): Remove unnecessary casts.
2592 * src/su.c (run_shell): Pass a new n_additional_args arg, so that
2593 the callee doesn't have to count 'em. All callers changed.
2594 Don't allocate more space for the arg vector than we'll need.
2595 Use memcpy to copy the args rather than rolling our own loop.
2596 Use size_t for sizes.
2597 (fast_startup, simulate_login, change_environment, log_su,
2598 correct_password, restricted_shell, main): Use bool for booleans.
2599 (longopts): Don't assume change_environment is an int.
2600 Use NULL, not 0, for pointers.
2601 (xsetenv): New function, replacing xputenv and concat.
2602 All callers changed.
2603 (elements): Remove; no longer needed.
2604 (log_su, correct_passwd, main): Prefer !x to x==NULL.
2605 (log_su): 2 -> STDERR_FILENO.
2606 (modify_environment, main): Don't assume that getenv's returned value
2607 has an indefinite lifetime.
2608 (modify_environment): Allocate a larger environ.
2609 (main): Remove an impossible 'case 0'; if it happens now, it'll
2610 get diagnosed. Don't assume getpwnam results outlive endpwent.
2611 Check for null or empty pw_name, pw_dir and for null pw_passwd.
2613 * src/stty.c (VA_START): Remove. All callers now use va_start.
2614 (_POSIX_VDISABLE): Remove unnecessary cast.
2615 (struct control_info, visible): Use cc_t for control chars.
2616 (struct control_info): Use size_t for sizes.
2617 (recover_mode, set_mode, display_speed, display_window_size,
2618 valid_options, main, display_changed):
2619 Use bool for booleans.
2620 (integer_arg): Return unsigned long int, not long int.
2621 Accept new max arg; all callers changed, to specify a maximum
2622 value for integer parameters instead of silently overflowing.
2623 (wrap): Do not overrun the stack buffer if the output contains
2624 more than 1024 bytes. Instead, malloc a buffer.
2625 (main): Remove a "what is this?!?" FIXME. Nobody knows what it is.
2626 Remove unnecessary casts.
2627 (set_control_char): Allow int values only up to cc_t range.
2628 (screen_columns): Don't reject INT_MAX.
2629 (display_changed, display_all, display_speed, recover_mode):
2630 Don't assume cc_t fits in int.
2632 * src/remove.h: Add copyright notice.
2633 (struct rm_options): Use bool for booleans.
2634 * src/rmdir.c (empty_paths, ignore_fail_on_non_empty, verbose,
2635 errno_rmdir_non_empty, remove_parents, main): Likewise.
2636 * src/sum.c (have_read_stdin, bsd_sum_file, sysv_sum_file,
2638 (main): Don't dump core if invoked with argv[0]==NULL.
2639 * src/tee.c (tee, append, ignore_interrupts, main, tee):
2640 Use bool for booleans.
2641 (tee): Use ssize_t for read returns.
2643 * src/ptx.c: Add a FIXME mentioning that there are many
2644 unchecked integer overflows in this file.
2645 (gnu_extensions, auto_reference, input_reference, right_reference,
2646 ignore_case, initialize_regex, fix_output_parameters,
2647 output_one_roff_line, output_one_text_line, output_one_dumb_line, main):
2648 Use bool for booleans.
2649 (SKIP_SOMETHING, compare_words, digest_break_file,
2650 find_occurs_in_text, fix_output_parameters):
2651 Use to_uchar instead of a caset.
2652 (print_field): Rewrite to avoid cast.
2654 * src/printf.c (posixly_correct): Use bool for booleans.
2655 (verify, main): Use EXIT_FAILURE/EXIT_SUCCESS instead of 1/0.
2656 (STRTOX): Rewrite to avoid casts.
2657 (print_esc_char): Arg is char, not int.
2658 * src/readlink.c (canonicalize): Remove. All uses now merely inspect
2660 (no_newline, verbose): Use bool for booleans.
2661 (can_mode): Now of type int; use -1 to denote otherwise-uninitialized.
2662 * src/shred.c (struct Options, main): Use bool for booleans.
2663 (isaac_seed_data, fillpattern, wipefile): Rewrite to avoid casts.
2664 * src/split.c (cwrite, bytes_split, lines_split, line_bytes_split):
2665 Use bool for booleans.
2666 * src/stat.c (G_fail): Remove.
2667 (print_statfs): Print various gotta-be-nonnegative values using
2668 unsigned long int, not long int or int.
2669 (do_statfs, do_stat): Return a boolean success flag.
2670 (do_stat, main): Use bool for booleans.
2672 * src/pr.c: Add a FIXME mentioning that there are many
2673 unchecked integer overflows in this file.
2674 (TRUE, FALSE): Remove. All uses replaced by true and false.
2675 (struct COLUMN, read_line, print_page, print_stored, open_file,
2676 skip_to_page, init_fps, parallel_files, align_empty_cols,
2677 empty_line, FF_only, explicit_columns, extremities, keep_FF,
2678 print_a_FF, print_a_header, use_form_feed, have_read_stdin,
2679 print_across_flag, storing_columns, balance_columns,
2680 truncate_lines, join_lines, untabify_input, failed_opens,
2681 numbered_lines, skip_count, use_esc_sequence, use_cntrl_prefix,
2682 double_space, ignore_failed_opens, use_col_separator,
2683 pad_vertically, last_line, main, init_parameters, skip_read,
2684 read_line, print_stored):
2685 Use bool for booleans.
2686 (struct COLUMN, char_to_clump, store_char, print_char):
2688 (clump_buff, print_clump): Use char[], not int[], for an array whose
2689 elements are always chars.
2690 (first_last_page, main, getoptarg, balance, add_line_number,
2691 char_to_uclump): Remove unnecessary casts.
2692 (init_parameters): Allocate chars, not ints, for clump_buff.
2693 (print_char): Use to_uchar before invoking ISPRINT.
2694 (char_to_clump): Convert to unsigned char before invoking ISPRINT.
2696 * src/nohup.c (main): Use bool for booleans.
2697 * src/paste.c (paste_parallel, paste_serial, main): Likewise.
2698 * src/pathchk.c (validate-path, main, portable_chars_only): Likewise.
2699 (portable_chars_only): Use to_uchar rather than a cast.
2700 * src/printenv.c (main): Use bool for booleans.
2701 Do not assume that the environ has at most one matching entry
2702 for each option (integer overflow was possible otherwise).
2704 * src/od.c (FMT_BYTES_ALLOCATED): Now an enum, not a decimal
2705 constant. Do not assume PRIdMAX etc. are strings of length 3 or
2707 (struct tspec): Use it. fmt_string is now an array, not
2708 a pointer, as there's little point to the indirection here.
2709 (struct tspec, flag_dump_strings,
2710 traditional, flag_pseudo_start, limit_bytes_to_format,
2711 abbreviate_duplicate_blocks, have_read_stdin, simple_strtoul,
2712 decode_one_format, open_next_file, check_and_close,
2713 decode_format_string, skip, write_block, read_char, read_block,
2714 parse_old_offset, dump, dump_strings, main):
2715 Use bool for booleans.
2716 (struct tspec): Use void *, not char *, for generic pointers.
2717 (bytes_to_oct_digits, bytes_to_signed_dec_digits,
2718 bytes_to_unsigned_dec_digits, bytes_to_hex_digits):
2719 Use char, not unsigned int, since char suffices.
2720 (print_s_char, print_char, print_s_short, print_short,
2721 print_int, print_long, print_long_long, print_float,
2722 print_double, print_long_double): Rewrite to avoid casts.
2723 These now take void * arguments, instead of char *.
2724 Use the same body for all functions, except for the choice
2725 of type. Assume C89 to simplify handling of signed char.
2726 (dump_hexl_mode_trailer, print_named_ascii, print_ascii):
2727 Rewrite to avoid casts.
2728 (print_named_ascii, print_ascii): Now takes void *, not char *.
2729 (decode_one_format): Use int for printf field widths, not
2730 unsigned int. Pass void * to subsidiary printers,
2731 not char *. Simplify handling of floating-point formats
2732 by factoring out common code dealing with precision and field width.
2733 (decode_format_string): Avoid need for temporary copy of
2734 each decoded struct tspec.
2735 (get_lcm): Remove unnecessary cast.
2736 (main): Fix bug where more than INT_MAX failed decodes were ignored.
2738 2004-08-02 Paul Eggert <eggert@cs.ucla.edu>
2740 * src/nl.c (TRUE, FALSE): Remove; all uses changed to true, false.
2741 (enum number_format): Remove.
2742 (FORMAT_RIGHT_NOLZ, FORMAT_RIGHT_LZ, FORMAT_LEFT): Now strings,
2744 (DEFAULT_SECTION_DELIMITERS): Now an array constant, not a macro.
2745 (section_del): Now const.
2746 (print_fmt): Remove.
2747 (starting_line_number, page_incr, blank_join, line_no,
2748 print_lineno, proc_text, main):
2749 Use intmax_t for line numbers.
2750 (reset_numbers, have_read_stdin, build_type_arg, nl_file, main):
2751 Use bool for booleans.
2752 (lineno_format): Now a string, not an enum value.
2753 (build_print_fmt): Remove. All calls removed. This work is
2754 now done within print_lineno.
2755 (build_type_arg): Use size_t for sizes.
2756 (print_lineno): Check for line number overflow.
2757 (proc_text, main): Remove unnecessary cast.
2759 * src/ln.c (symbolic_link, interactive, remove_existing_files,
2760 verbose, hard_dir_link, dereference_dest_dir_symlinks,
2761 do_link, main): Use bool for booleans.
2763 * src/ls.c (struct fileinfo, file_interesting,
2764 extract_dirs_from_files, color_symlink_as_referent,
2765 FILE_OR_LINK_MODE, sort_reverse, print_owner, print_group,
2766 numeric_ids, print_block_size, dired, print_with_color,
2767 check_symlink_color, print_inode, recursive, immediate_dirs,
2768 all_files, really_all_files, qmark_funny_chars,
2769 print_dir_name, format_needs_stat, format_needs_type, visit_dir,
2770 main, decode_switches, parse_ls_color, print_dir, file_interesting,
2771 gobble_file, make_link_path, basename_is_dot_or_dotdot,
2772 extract_dirs_from_files, print_long_format):
2773 Use bool for booleans.
2774 (dir_defaulted): Remove; no longer needed.
2775 (main): Use int to count files, since it suffices for argv.
2776 Rewrite to avoid need for dir_defaulted.
2777 (main, print_dir, gobble_file, get_link_name,
2779 Set exit status to EXIT_SUCCES/EXIT_FAILURE rather than 0/1.
2780 (decode_switches): Put back check for ws.ws_col <= SIZE_MAX.
2781 Remove unnecessary cast to int. Use int instead of unsigned
2782 int to count from 0 to 1.
2783 (get_funky_string, print_type_indicator): Use char for bytes, not int.
2784 (make_link_path): Use NULL for null pointers.
2785 (quote_name): Use to_uchar instead of cast.
2787 * src/id.c (use_name, main, print_user, xgetgroups, print_group_list,
2788 print_full_info): Use bool for booleans.
2789 (problems): Remove, replacing with....
2790 (ok): New var (inverted from old sense).
2791 (print_user, print_group, print_full_info):
2792 Print uids/gids with %lu, not %u.
2793 (xgetgroups): Don't run out of memory if getgroups or getugroups
2795 * src/setuidgid.c (main): Print uids/gids with %lu, not %ld.
2797 * src/factor.c (wheel_tab): Use unsigned char instead of unsigned
2798 int, since it suffices.
2799 (factor, print_factors): Use size_t for sizes.
2800 (print_factors, do_stdin, main): Use bool for booleans.
2801 * src/fold.c (TAB_WIDTH): New macro; use it instead of "8".
2802 (fold_file, main): Use bool for booleans.
2803 (fold_file, main): Use size_t for sizes.
2804 (main): Allow -w options up to SIZE_MAX - TAB_WIDTH - 1, instead
2805 of prohibiting widths greater than INT_MAX.
2806 * src/head.c (presume_input_pipe, print_headers, have_read_stdin,
2807 write_header, elide_tail_bytes_pipe, elide_tail_bytes_file,
2808 elide_tail_lines_pipe, elide_tail_lines_seekable,
2809 elide_tail_lines_file, head_bytes, head_lines, head, head_file,
2810 string_to_integer, main):
2811 Use bool for booleans.
2812 (main): Rewrite to avoid cast.
2814 * src/csplit.c (struct line): Use size_t for sizes.
2815 (main): Remove unnecessary cast.
2816 * src/cut.c (cut_fields): Use to_uchar rather than a cast.
2817 * src/cut.c (cut_file, main): Use bool for booleans.
2818 * src/date.c (show_date, rfc_format, batch_convert, main): Likewise.
2819 * src/env.c (main): Likewise.
2820 * src/expr.c (nextarg): Likewise.
2821 * src/env.c (main): Remove unused and nonstandard envp arg.
2823 * src/fmt.c (COST, MAXWORDS): Add a comment describing some of
2824 fmt's arbitrary limits.
2825 (TRUE, FALSE): Remove; all uses changed to (true, false).
2826 (main): Use bool for booleans.
2827 Limit maximum width to MAXCHARS / 2. Use xstrtoul, not xstrtol,
2829 (copy_rest): Remove unnecessary cast.
2830 (get_prefix): Rewrite to avoid cast.
2831 (check_punctuation): Use char *, not unsigned char *; C89 requires
2832 this. Avoid off-by-one buffer read overrun when line is empty.
2833 (flush_paragraph): Don't assume wptr-parabuf is <= INT_MAX.
2834 Remove unnecessary casts.
2835 * tests/fmt/basic (wide-1, wide-2, bad-suffix): Adjust to above
2838 * src/expand.c (convert_entire_line, have_read_stdin, parse_tabstops,
2839 next_file, expand, main):
2840 Use bool for booleans.
2841 (tab_size, tab_list, add_tabstop, parse_tabstops, validate_tabstops,
2843 Use uintmax_t for column counts.
2844 (add_tabstop): Don't reserve -1 (now UINTMAX_MAX) as a special value.
2845 All callers changed.
2846 (parse_tabstops): Don't pass a negative char to isblank.
2847 Avoid memory leak with large tab stops.
2848 (validate_tabstops, expand): Don't assume number of tab stops is
2850 (next_file, main): Use EXIT_SUCCESS/EXIT_FAILURE rather than 0/1 when
2851 storing values into exit_status.
2852 (expand): Use same pattern as unexpand for reading chars.
2853 Report an error when input line is too long, instead of silently
2854 screwing up. Do not mishandle tab stops when backspacing left
2857 * src/dircolors.c (have_read_stdin, append_quoted,
2858 dc_parse_stream, dc_parse_file, main): Use bool for booleans.
2859 (dc_parse_stream): Use enum for state, rather than int.
2860 Use ssize_t to store getline result.
2862 * src/dd.c (translation_needed, parse_integer, scanargs,
2863 apply_translations, char_is_saved, swab_buffer, skip_via_lseek):
2864 Use bool for booleans.
2865 (translate_buffer): Use to_uchar rather than a cast.
2866 (swab_buffer, copy_simple, copy_with_unblock):
2867 Use size_t for sizes.
2869 * src/seq.c (equal_width, valid_format, main): Use bool for booleans.
2870 * src/sleep.c (apply_suffix): Likewise.
2871 * src/tail.c (struct File_spec, reopen_inaccessible_files, count_lines,
2872 forever, from_start, print_headers, have_read_stdin, valid_file_spec,
2873 write_header, file_lines, pipe_lines, pipe_bytes, recheck,
2874 tail_forever, tail_bytes, tail_lines, tail, tail_file,
2875 parse_obsolescent_option, parse_options, main): Likewise.
2876 * src/sleep.c (apply_suffix): Invert sense of result.
2877 Use int (not unsigned int) for multiplier, as this generates better
2878 code with some compilers. Simplify code a bit.
2879 * src/tail.c (struct File_spec, max_n_unchanged_stats_between_opens,
2880 parse_options): Use uintmax_t, not unsigned int or unsigned long int,
2882 (tail_bytes, tail_lines): Redo test of return value (-1, 0, 1) to
2883 make it a bit clearer.
2885 * src/hostname.c: Include "xgethostname.h".
2886 (xgethostname): Remove decl; xgethostname.h has it.
2887 (sethostname) [!defined(HAVE_SETHOSTNAME) && defined(HAVE_SYSINFO)
2888 && defined (HAVE_SYS_SYSTEMINFO_H) && defined(HAVE_LIMITS_H)]: Use
2889 prototypes rather than K&R form. Assume any negative value from
2890 sysinfo denotes failure, not just -1.
2891 (main): Simplify use of sethostname.
2893 * src/pinky.c (include_idle, include_heading, include_fullname,
2894 include_project, include_plan, include_home_and_shell, do_short_format,
2895 include_where, main): Use bool for booleans.
2896 (count_ampersands, create_fullname, scan_entries, short_pinky):
2897 Use size_t for sizes.
2898 (create_fullname): Check for overflow in size calculations.
2899 (idle_string): Don't assume that the number of idle days
2900 is less than 10**8 and/or INT_MAX/(24*60*60).
2901 (main): No need to pass a non-NULL last arg to getopt_long.
2902 * src/uptime.c (print_uptime, uptime): Use size_t for sizes.
2903 (print_uptime): Remove unused local variable.
2904 (main): No need to pass a non-NULL last arg to getopt_long.
2905 * src/users.c (list_entries_users, users): Use size_t for sizes.
2906 (list_entries_users): Use char for bytes.
2907 (main): No need to pass a non-NULL last arg to getopt_long.
2908 * src/who.c (do_lookup, short_list, short_output, include_idle,
2909 include_heading, include_mesg, include_exit, need_boottime,
2910 need_deadprocs, need_login, need_initspawn, need_clockchange,
2911 need_runlevel, need_users, my_line_only, main): Use bool for booleans.
2912 (print_runlevel): Use unsigned char for bytes.
2913 (list_entries_who, scan_entries, who): Use size_t for sizes.
2914 (main): No need to pass a non-NULL last arg to getopt_long.
2916 * src/install.c (isdir): Remove decl.
2917 (install_file_to_path): Rely on make_path to fail if the destination
2918 is not a directory, by passing preserve_existing==true to it.
2919 Hence we no longer need to call isdir.
2920 Free dest_dir immediately when it's no longer needed, rather than
2921 waiting until the end of the function.
2922 (copy_file): Don't bother calling isdir, as copy will do the
2923 right thing if the destination is a directory.
2925 * src/du.c (fts_debug, opt_all, apparent_size, opt_count_all,
2926 print_grand_total, opt_separate_dirs, hash_ins, process_file, main):
2927 Use bool for booleans.
2928 (max_depth): Now size_t, not int, to avoid an arbitrary limit
2929 of INT_MAX on depth.
2930 (G_fail): Remove: no longer needed, now that the relevant
2931 functions return bool.
2932 (process_file): Use return value to signal success rather than
2933 setting a global. Remove first_call static var; not needed, since
2934 we can look at n_alloc. Use size_t for depths. Remove FIXME
2935 about size_t casts, as it's now fixed. Use xnrealloc rather
2936 than the obsolescent XREALLOC. Don't bother to check whether
2937 reallocation is needed unless level > prev_level.
2938 (du_files): Invert sense of result, for consistency with
2939 other coreutils code. All callers changed.
2940 (main): Allow --max-depth values up to SIZE_MAX.
2942 * src/df.c (inode_format, show_all_fs, show_local_fs,
2943 show_listed_fs, posix_format, require_sync, print_type,
2944 selected_fstype, excluded_fstype, show_dev, show_point, main):
2945 Use bool for booleans.
2946 (df_readable, show_dev): Use UINTMAX_MAX instead of -1.
2947 (show_dev, show_point, main):
2948 Use EXIT_SUCCESS/EXIT_FAILURE instead of 0/1.
2949 Don't assume disk name lengths are <= INT_MAX.
2950 Rewrite pct calculation to avoid cast.
2951 (show_point): Don't assume resolved length is <= SSIZE_MAX.
2953 * src/cut.c (hash_int) [!defined UINTPTR_MAX]: Use size_t
2954 instead of uintptr_t.
2955 * src/shred.c (UINT_MAX_32_BITS): Remove.
2956 (word32): Remove. All uses changed to uint32_t.
2957 (isaac_seed_data): Remove unnecessary cast.
2958 * src/system.h (ptr_align): Use size_t; in practice, this is just as
2959 good as uintptr_t in checking for alignments, and has fewer
2960 configuration hassles.
2962 * src/Makefile.am (localedir.h): Make it readonly; this
2963 undoes part of the 2004-07-27 patch.
2965 2004-07-30 Paul Eggert <eggert@cs.ucla.edu>
2967 * src/sort.c (UCHAR): Remove; all uses changed to to_uchar.
2968 (IS_THOUSANDS_SEP): Use bool when appropriate.
2969 (numcompare, main): Use char, not int, when the value is always a char.
2970 (numcompare): Remove "register"; compilers are smart enough these days.
2971 * src/system.h (errno, CHAR_BIT): Remove decls;
2972 no longer needed now we assume C89 or better.
2973 Include <inttypes.h> before <stdint.h>, as it's the
2974 Autoconf-recommended pattern.
2975 (to_uchar): New inline function, moved here from tr.c.
2976 Use full names for int types, e.g. "long int" rather than "long".
2977 * src/tr.c (to_uchar): Remove; now in system.h.
2978 (is_char_class_member): Use bool when appropriate.
2980 * src/mkdir.c (create_parents, main): Use bool when appropriate.
2981 (main): Use EXIT_SUCCESS/EXIT_FAILURE instead of 0/1.
2983 2004-07-29 Paul Eggert <eggert@cs.ucla.edu>
2985 * src/mkfifo.c (main): Use EXIT_SUCCESS and EXIT_FAILURE, not 0 and 1.
2987 * src/chmod.c (recurse, force_silent, process_file, process_files,
2988 main): Use bool when appropriate.
2989 * src/cksum.c (cksum, main): Likewise.
2990 * src/comm.c (hard_LC_COLLATE, only_file_1, only_file_2, both,
2991 compare_files, main): Likewise.
2993 * src/copy.h (struct cp_options): Likewise.
2994 * src/copy.c (copy_internal, is_ancestor, copy_dir, copy_reg,
2995 same_file_ok, seen_file, copy_internal, valid_options, copy): Likewise.
2996 * src/cp-hash.h (remember_created): Likewise.
2997 * src/cp-hash.c (remember_created): Likewise.
2998 * src/cp.c (struct dir_attr, flag_path, remove_trailing_slashes,
2999 re_protect, make_path_private, target_directory_operand, do_copy,
3000 cp_option_init, decode_preserve_arg, main): Likewise.
3001 * src/install.c (isdir, change_timestamps, change_attributes,
3002 copy_file, install_file_to_path, install_file_in_dir,
3003 install_file_in_file, strip_files, dir_arg, cp_option_init, main,
3004 change_attributes, change_timestamps): Likewise.
3005 * src/mv.c (remove_trailing_slashes, rm_option_init,
3006 cp_option_init, do_move, movefile, main): Likewise.
3007 * src/remove.c (right_justify), full_filename_, AD_pop_and_chdir,
3008 AD_push, prompt, remove_dir): Likewise.
3009 * src/rm.c (rm_option_init, main): Likewise.
3011 * src/remove.c (top_dir, pop_dir, full_filename_):
3012 Use size_t for sizes.
3013 * src/cp.c (target_directory_operand): Do not clear *NEW_DST if stat
3014 succeeds. It's not necessary in that case, as *NEW_DST is always
3016 (do_copy): Rewrite slightly to avoid need for "unreachable" comment.
3017 (main): Use EXIT_SUCCESS, EXIT_FAILURE instead of 0, 1.
3018 * src/rm.c (main): Likewise.
3020 md5sum, sha1sum integer cleanups.
3022 * src/checksum.h: Don't include config.h, sys/types.h, stdio.h:
3024 (ALG_UNSPECIFIED): Remove.
3025 (ALG_MDT): Don't make it equal to CHAR_MAX + 1; this isn't necessary.
3026 * src/md5.c: Don't include any files other than checksum.h.
3027 * src/sha1sum.c: Likewise.
3028 * src/md5sum.c (OPENOPTS, have_read_stdin, status_only, warn,
3029 bsd_split_3, split_3, hex_digits, digest_file, digest_check, main):
3030 Use bool when appropriate.
3031 (digest_check): Increase limit of number of input lines to
3032 UINTMAX_MAX from INT_MAX. Diagnose any overflows of this counter.
3033 Use ngettext instead of hard-to-i18nize hardcoded stuff for plurals.
3035 2004-07-28 Paul Eggert <eggert@cs.ucla.edu>
3037 * src/cat.c (exit_status): Remove. Now done by passing a boolean
3039 (simple_cat, cat): Return true if successful. All callers changed.
3040 (simple_cat, cat, main): Use bool for booleans.
3041 (simple_cat): Use size_t for sizes.
3042 (cat, main): Use the same names for parameters that we use for
3043 long options, to avoid confusion. This inverts the sense of the
3044 show_tabs (formerly output_tabs) and number_nonblank
3045 (formerly numbers_at_empty_lines) variables.
3046 (main): Don't mess up (due to integer overflow) if we are given
3047 INT_MAX - INT_MIN + 1 options.
3048 [O_BINARY]: Don't invoke isatty unless the other options require it.
3049 (main): When deciding whether to use simple_cat, don't worry
3050 about binary option; it's irrelevant.
3052 * src/dcgen: Remove comments, trailing white space, and empty
3053 lines from the output strings, to save space.
3054 Use a narrower type like 'unsigned char' for line lengths, if
3056 Make the output variables static, not extern.
3058 * src/chgrp.c (parse_group): Require base 10 when parsing
3060 (main): int -> bool when appropriate.
3061 * src/chown.c (main): Likewise.
3062 * src/chown-core.c: Include inttostr.h.
3063 (UINT_MAX_DECIMAL_DIGITS, uint_to_string): Remove.
3064 (gid_to_name, uid_to_name): Use imaxtostr/umaxtostr
3065 instead of uint_to_string).
3066 (describe_change): Instead of an int flag, use a char *
3067 auxiliary; this avoids the need for casts.
3068 Assume free (NULL) works.
3069 (change_file_owner): Return true/false, not 0/-1, since
3070 we don't set errno. All callers changed.
3071 Use bool when appropriate.
3072 (chown_files): Likewise.
3073 * src/chown-core.h (chown_files): Likewise.
3075 * tests/chown/basic: Test for proper handling of uids like
3076 "010", which must be parsed as decimal.
3078 * tests/misc/pwd: Don't assume that Perl's getpwd agrees with our
3079 pwd when there are multiple names for the working directory
3080 (which can happen with an automounter, sigh).
3082 * src/Makefile.am ($(SCRIPTS)): Don't depend on Makefile;
3083 this causes Solaris 8 'make' to refuse to build "groups".
3084 (localedir.h): Don't depend on Makefile: this causes Solaris
3085 8 'make' to build localedir.h unnecessarily. The dependence
3086 on Makefile is ineffective anyway, since $(localedir) might
3087 change even if Makefile hasn't.
3089 * src/remove.c (remove_dir): If we can't save the state of the
3090 working directory, pretend we started from "/", not ".".
3091 This avoids a bug on hosts like Solaris that don't let you
3092 remove the working directory.
3094 2004-07-27 Paul Eggert <eggert@cs.ucla.edu>
3096 * src/printf.c (strtiomax, strtoumax): Declare if not already
3097 declared: this fixes a portability bug with Solaris 8 + GCC.
3098 (STRTOX): Parenthesize use of macro arg as expression.
3099 (vstrtoimax, vstrtoumax, vstrtold): Remove now-unnecessary
3101 * configure.ac: Check for declaration of strtoumax, for
3104 * src/Makefile.am (cp_LDADD, ginstall_LDADD, mv_LDADD,
3105 pathchk_LDADD, rm_LDADD, test_LDADD): New vars, for eaccess.
3107 * tests/readlink/can-e: Don't assume that we can remove the
3108 working directory: this isn't possible under Solaris 8, say.
3109 * tests/readlink/can-f: Likewise.
3110 * tests/readlink/can-m: Likewise.
3112 * src/copy.c (copy_internal): find_backup_file_name no longer
3113 returns NULL, so don't bother to check for this.
3114 * src/cp.c (do_copy): Likewise.
3115 * src/ln.c (do_link): Likewise.
3117 2004-07-25 Paul Eggert <eggert@cs.ucla.edu>
3119 * src/nice.c (GET_NICE_VALUE): Renamed from GET_PRIORITY.
3121 (NZERO): New macro, if system doesn't define it already.
3122 (usage): Distinguish priorities from nice values.
3123 Don't assume NZERO is 20.
3124 (main): Use bool instead of int where appropriate.
3125 If user specifies an adjustment out of range, always truncate it
3126 to an inrange value instead of sometimes giving an error message
3128 Do not assume that -1 is an error return from "nice" or
3129 "getpriority", as it might be the current nice value minus NZERO.
3130 If nice/setpriority fails with errno == EPERM, go ahead and run
3131 the command anyway; POSIX requires this.
3133 * src/pathchk.c: Include euidaccess.h.
3134 (dir_ok): Use euidaccess, not access.
3135 * src/test.c (R_OK, W_OK, X_OK, FOK): Remove; system.h defines them.
3136 (eaccess): Remove. All users changed to use euidaccess instead.
3138 2004-07-24 Paul Eggert <eggert@cs.ucla.edu>
3140 * src/uptime.c (print_uptime) [defined BOOT_MSG]:
3141 Don't assume ut_line is null-terminated.
3142 * src/who.c (print_line): New arguments USERLEN and LINELEN,
3143 since USER and LINE might not be null terminated. All callers
3146 2004-07-23 Paul Eggert <eggert@cs.ucla.edu>
3148 Fix bug with "tail -f" reported by Rob Holland in
3149 <http://lists.gnu.org/archive/html/bug-coreutils/2004-07/msg00054.html>.
3150 Also, remove the undocumented and unsupported-since-2000
3151 --max-consecutive-size-changes options. Fix another related bug:
3152 "tail" got confused if stdin, stdout, or stderr were closed.
3153 Also, use output buffering even with "tail -f".
3155 * NEWS: Document this, plus yesterday's patch.
3156 * doc/coreutils.texi (tail invocation): "size has remained the same"
3157 -> "file has not changed", which is more accurate for fifos.
3158 * src/tail.c: Include fcntl-safer.h.
3159 (COPY_TO_EOF): Set to UINTMAX_MAX, not OFF_T_MAX (which was wrong).
3160 (COPY_A_BUFFER): New macro.
3161 (struct File_spec): New members mtime, mode, blocking.
3162 Remove member n_consecutive_size_changes.
3163 (DEFAULT_MAX_N_CONSECUTIVE_SIZE_CHANGES,
3164 max_n_consecutive_size_changes_between_opens,
3165 MAX_CONSECUTIVE_SIZE_CHANGES_OPTION): Remove.
3166 (long_options, tail_forever, parse_options):
3167 Remove (non-)support for --max-consecutive-size-changes.
3168 (record_open_fd): New function.
3169 (recheck, tail_file): Use it. Don't assume that stdin is open.
3170 (dump_remainder): Add support for new COPY_A_BUFFER special value.
3171 Treat errno==EAGAIN like EOF, since it might be a nonblocking read.
3172 (recheck): New arg BLOCKING, specifying whether to use blocking reads.
3174 (n_live_files): Remove, replacing with...
3175 (any_live_files): New function. All uses changed.
3176 (tail_forever): Use nonblocking I/O unless we know that blocking I/O
3177 is safe; this avoids some hangs when reading from a fifo.
3178 Avoid invoking fstat or sleep when using blocking I/O.
3179 Do not check for changes to size if the file is not a regular file,
3180 as the size is undefined in that case.
3181 Check for changes to mtime or mode, too; this works for non-regular
3183 (tail_forever, main): Redo fflush strategy to work even when input
3184 is nonblocking. Don't use unbuffered output; just flush when needed.
3186 2004-07-22 Paul Eggert <eggert@cs.ucla.edu>
3188 * src/tail.c (main): Ignore -f if no file operand is specified
3189 and standard input is a pipe.
3190 * doc/coreutils.texi (tail invocation): Do not ignore -f for
3191 all pipes, just for when standard input is a pipe and no
3192 file operand is specified.
3193 * tests/tail/Test.pm: Reinstate f-1 test, since we now pass.
3194 Add a new commented-out f-2 test, which we still fail.
3195 (test_vector): All f-* tests are special cases, not just f-1.
3197 2004-07-12 Paul Eggert <eggert@cs.ucla.edu>
3199 * src/uptime.c: Include c-strtod.h.
3200 (print_uptime): Use c_strtod instead of setlocale and sscanf.
3201 Use long int rather than int to count days (for 64-bit hosts),
3202 and check for arithmetic overflow when converting double to time_t.
3204 2004-07-11 Paul Eggert <eggert@cs.ucla.edu>
3206 * src/printf.c (vstrtold): Renamed from vstrtod.
3207 Now returns long double. All uses changed.
3208 (print_direc): Use "L" length modifier when printing floating point
3209 numbers, since we're now printing long double.
3211 2004-07-06 Paul Eggert <eggert@cs.ucla.edu>
3213 printf cleanup, to avoid undefined behavior, to add support for
3214 formats that Bash supports, and to support wide integers like
3217 * NEWS: Document this.
3218 * src/printf.c (UNSPECIFIED): Remove. All uses now replaced by
3219 booleans, so that we don't reserve any values for precision or
3221 (STRTOX): Use prototype, not K&R-style definition.
3222 (vstrtoimax): Renamed from xstrtol (to avoid confusion with xstrtol
3223 in ../lib), with type change to intmax_t.
3225 (vstrtoumax): Renamed from xstrtoul, with type change to uintmax_t.
3227 (vstrtod): Renamed from xstrtod. All uses changed.
3228 (print_direc): Use boolean arg instead of special value to indicate
3229 a missing precision or width. LENGTH no longer includes
3230 length modifiers or conversion character. New arg CONVERSION
3231 now specifies conversion character.
3232 Use intmax_t-width formatting for integers (like Bash).
3233 Add support for C99 %a, %A, %F (like Bash).
3234 Add support for field width with %c (POSIX requires this).
3235 Add a FIXME for lack of support for field width and precision
3237 Add support for '\'', '0' flags.
3238 Check for invalid combinations of flags, field width, precision,
3239 and conversion, to prevent use of undefined behavior.
3240 Allow multiple length modifiers, for formats like "%lld" (like Bash).
3241 Add support for C99 'j', 't', 'z' length modifiers (like Bash).
3242 In error message, output entire invalid conversion specification,
3243 instead of merely outputting % followed by the conversion char.
3244 * tests/misc/printf: Add tests for the above.
3246 2004-04-03 Dmitry V. Levin <ldv@altlinux.org>
3248 Change "readlink -f" to be more compatible with prior implementations.
3249 Add more canonicalize options, -e and -m.
3250 Add comprehensive tests for all readlink modes.
3252 * m4/canonicalize.m4 (AC_FUNC_CANONICALIZE_FILE_NAME):
3253 Do not add canonicalize.c here.
3255 * src/readlink.c (longopts): Add new options.
3256 (usage): Document them.
3257 (canonicalize_fname): New proxy function.
3258 (main): Handle new options.
3259 * doc/coreutils.texi (readlink invocation): Document new
3260 "readlink -f" behaviour and new canonicalize options, -e and -m.
3262 * configure.ac (AC_CONFIG_FILES): Add tests/readlink/Makefile.
3263 * tests/Makefile.am (SUBDIRS): Add readlink.
3264 * tests/readlink/Makefile.am: New file.
3265 * tests/readlink/{rl-1,can-e,can-f,can-m}: New readlink tests.
3266 * tests/misc/Makefile.am (TESTS): Remove basic readlink test.
3267 * tests/misc/readlink: Remove file.
3269 2004-07-04 Jim Meyering <jim@meyering.net>
3271 * src/copy.c (copy_internal): Add a FIXME comment.
3273 2004-07-02 Paul Eggert <eggert@cs.ucla.edu>
3275 * src/copy.c (copy_dir): Assume path_concat returns non-NULL.
3276 * src/cp.c (do_copy): Likewise.
3277 * src/mv.c (movefile): Likewise.
3279 * src/cp.c (make_path_private): 2nd arg is now size_t, not int,
3280 to avoid problem when path_concat dir name is longer than 2 GiB (!).
3282 * src/nohup.c (main): Don't pass NULL first argument to path_concat.
3283 This cleans up the semantics a bit, as we no longer try to open the
3286 2004-07-01 Paul Eggert <eggert@cs.ucla.edu>
3288 * NEWS: Add short names -t and -T for --target-directory
3289 and --no-target-directory options, respectively.
3291 * src/cp.c (NO_TARGET_DIRECTORY_OPTION, TARGET_DIRECTORY_OPTION):
3292 Remove. All uses changed to 'T' and 't', respectively.
3293 * src/install.c, src/ln.c, src/mv.c: Likewise.
3295 * src/cp.c (long_opts, usage, do_copy, main): Add -t and -T as
3296 aliases for --target-directory and --no-target-directory,
3298 * src/install.c (long_options, main, usage): Likewise.
3299 * src/ln.c, src/mv.c: Likewise.
3301 2004-07-01 Jim Meyering <jim@meyering.net>
3303 * Makefile.maint (sc_file_system): New target.
3304 (syntax-check-rules): Add it.
3305 .x-sc_file_system: New file.
3306 * Makefile.am (EXTRA_DIST): Add it.
3308 * man/sync.x: Use "file system" rather than "filesystem".
3309 * man/stat.x, man/df.x: Likewise.
3311 2004-06-30 Paul Eggert <eggert@cs.ucla.edu>
3313 * src/df.c (usage, main): Output "file system" rather than
3315 * src/du.c (usage): Likewise.
3316 * src/shred.c (usage): Likewise.
3317 * src/stat.c (usage): Likewise.
3318 * src/stat.c (long_options, usage): Rename "--filesystem" to
3319 "--file-system". But keep the old name around, for compatibility
3322 2004-06-29 Paul Eggert <eggert@cs.ucla.edu>
3324 Add support for --no-target-directory option.
3326 * NEWS: Document it.
3327 * doc/coreutils.texi (Common options, Target directory, cp
3328 invocation, install invocation, mv invocation, ln invocation):
3330 (link invocation): Explain how to rewrite link using ln now
3331 that we have --no-target-directory.
3332 (ln invocation): Explain that --no-target-directory subsumes
3334 (unlink invocation): Modify wording to match new wording in
3337 * src/cp.c (NO_TARGET_DIRECTORY_OPTION): New constant.
3338 (long_opts, usage, do_copy, main): Add support for
3339 --no-target-directory,
3340 * src/install.c (NO_TARGET_DIRECTORY_OPTION, long_options, main,
3342 * src/ln.c (NO_TARGET_DIRECTORY_OPTION, long_options, usage,
3344 * src/mv.c (NO_TARGET_DIRECTORY_OPTION, long_options, usage,
3346 * src/mv.c (enum): Sort values.
3348 2004-06-29 Jim Meyering <jim@meyering.net>
3350 Don't let verbose-mode output from a subshell obscure actual differences.
3351 * tests/rm/inaccessible: Turn off command-echoing just before
3352 invoking subshell, then turn it back on if VERBOSE=yes afterward.
3354 2004-06-25 Paul Eggert <eggert@cs.ucla.edu>
3356 Add support for 'install --target-directory', an option
3357 that has been documented for years but not implemented (!).
3358 * doc/coreutils.texi (install invocation): Document
3359 --target-directory in synopsis, too.
3360 * src/install.c (TARGET_DIRECTORY_OPTION): New var.
3361 (long_options, main, usage): Add --target-directory.
3362 (target_directory_operand): New function, stolen from mv.c.
3363 (main): Use it. Check for -d and --target-directory.
3364 Alter wording of diagnostics to match other programs.
3366 2004-06-28 Jim Meyering <jim@meyering.net>
3368 * src/cp.c (usage): Fix copy+paste error in description of
3369 --target-directory: s/move/copy/. From Paul Jarc.
3371 2004-06-27 Paul Eggert <eggert@cs.ucla.edu>
3373 Use more-consistent rules among cp, ln, and mv when dealing with
3374 last operands that are (or look like) directories.
3376 * src/cp.c (target_directory_operand): New, nearly-common function,
3377 It reports an error if the destination appears to be a directory
3378 (e.g., because it has a trailing slash) but is not.
3379 * src/ln.c, src/mv.c: Likewise.
3380 * src/cp.c (do_copy): Use it.
3381 * src/ln.c (main): Likewise.
3382 * src/mv.c (main): Likewise.
3384 * src/cp.c (do_copy): Don't assume argc is positive.
3385 Don't bother to lstat dest, since copy() will do that for us.
3386 Use "const" to avoid the need for cast.
3388 * src/cp.c (do_copy): Don't output a usage message because of file
3389 problems (e.g., an operand is not a directory). Use it only for
3390 syntax. Standardize on "target %s is not a directory" for the
3392 * src/ln.c (main): Likewise.
3393 * src/mv.c (main): Likewise.
3395 * src/cp.c (do_copy): Remove test for trailing slash, since
3396 target_directory_operand now does this.
3397 * src/ln.c (main): Likewise.
3398 * src/mv.c (movefile): Likewise.
3400 * src/cp.c (main): Reject multiple target directories.
3401 Check whether a specified target is a directory when parsing the
3402 options, using stat. This gives more-accurate diagnostics.
3403 * src/ln.c (main): Likewise.
3405 * src/ln.c (isdir): Remove decl; no longer needed.
3406 * src/mv.c (isdir, lstat): Likewise.
3408 * src/ln.c (do_link): New arg dest_is_dir. All uses changed.
3409 Don't check the destination ourself; rely on dest_is_dir.
3410 This way we can avoid lstatting the destination in the
3411 usual case, and in the worst case we lstat 1, not 3 times.
3412 Don't bother to unlink unless link failed; this saves a syscall.
3413 Remove unnecessary backup_succeeded flag;
3414 it was identical to "dest_backup != NULL".
3416 * src/ln.c (main): Use int to count to argc, not unsigned int.
3417 This handles negative operand counts.
3418 * src/mv.c (main): Likewise.
3420 * src/mv.c (do_move): Don't call hash_init; expect the caller to
3421 do it, for consistency with cp.c and ln.c. All callers changed.
3422 (movefile): dest_is_dir parameter is now bool, not int.
3423 (main): Standardize on "missing destination file operand after %s"
3424 for the diagnostic, for consistency with cp.c.
3426 * tests/mv/diag: Don't assume "mv --target=nonexistentdir"
3427 will complain about the arg count.
3428 Adjust to new (briefer) diagnostics.
3429 * tests/cp/fail-perm: Add a test to verify that we get the new
3430 diagnostic when failing to copy through a symlink-to-inaccessible-dir.
3432 2004-06-27 Paul Eggert <eggert@cs.ucla.edu>
3434 Fix a bug: formerly, if d/x was a directory and x a file, "ln x
3435 d/" incorrectly created a link d/x/x. It also saves some system
3438 * NEWS: Document the fix.
3440 * src/ln.c (main): Don't append basename to dest if this
3441 results in an existing directory name.
3442 * tests/ln/misc: See whether a trailing slash is followed too far.
3444 2004-06-26 Jim Meyering <jim@meyering.net>
3446 * src/printf.c (main): When given no arguments, print the standard
3447 "missing operand\nTry printf --help..." message -- to be consistent.
3449 2004-06-26 Jim Meyering <jim@meyering.net>
3451 * src/mknod.c (main): Add \n at the end of message output via fprintf.
3453 2004-06-25 Jim Meyering <jim@meyering.net>
3455 * tests/ln/misc: Add test for ln subscript error.
3457 2004-06-23 Paul Eggert <eggert@cs.ucla.edu>
3459 * src/ln.c (do_link): Remove unnecessary call to lstat.
3460 (main): Avoid subscript error when the destination is "".
3462 2004-06-23 Jim Meyering <jim@meyering.net>
3464 * tests/*: Replace all occurrences of `(exit N); exit' with
3465 `(exit N); exit N'. Otherwise, those many tests could exit with
3466 improper exit status when exiting via e.g., a trapped interrupt.
3467 Thanks to a report from Bob Proulx.
3469 2004-06-22 Paul Eggert <eggert@cs.ucla.edu>
3471 * src/who.c (idle_string, print_user): New arg boottime,
3472 specifying the most recent boot time. All uses changed.
3473 (idle_string) Consider a line to be "old" if it hasn't been used
3474 since the last boot time. Watch out for overflow when computing
3475 times, and for times in the future.
3476 (idle_string): Record latest boot time.
3478 2004-06-22 Jim Meyering <jim@meyering.net>
3480 * src/test.c (usage): Correct description of `-t FD'. The file
3481 descriptor, FD, is no longer optional. Reported by Ton Nijkes.
3483 2004-06-21 Paul Eggert <eggert@cs.ucla.edu>
3485 The 2004-06-19 fix for who and pinky was incomplete, as ctime
3486 has undefined behavior if the year precedes -999 or follows 9999.
3487 Since we have to stop using ctime anyway, we might as well use
3488 strftime and fix the FIXME, and support internationalized dates.
3490 * NEWS: Document the new behavior.
3491 * src/who.c: Include "hard-locale.h".
3492 (time_format, time_format_width): New vars.
3493 (time_string, print_line): Use them.
3495 (time_string): Use localtime + strftime instead of
3496 ctime, to avoid problems with years before -999 or after 9999.
3497 * src/pinky.c: Likewise.
3499 2004-06-21 Paul Eggert <eggert@cs.ucla.edu>
3501 Fix bug: GNU 'ls' didn't count columns correctly if user or group
3502 names contained multibyte characters where the column count
3503 differed from the byte count. This patch also corrects
3506 * src/ls.c (format_user_or_group): New function, which counts
3508 (format_user, format_group): Use it.
3509 (format_user_or_group_width): New function, which counts columns
3511 (format_user_width, format_group_width): Use it.
3513 2004-06-21 Jim Meyering <jim@meyering.net>
3515 * tests/priv-check: Quote "$PATH" in PATH=$PATH.
3516 Suggestion from Andreas Schwab.
3518 * tests/priv-check: When running as root, be sure to propagate
3519 PATH through to the process we exec as non-root.
3520 Reported by michael@aplatform.com.
3522 * src/mknod.c (main): Don't segfault when calculating the
3523 expected number of operands for `mknod NAME'.
3525 2004-06-20 Jim Meyering <jim@meyering.net>
3527 * src/dd.c (input_seek_errno): Declare file-scoped variable as static.
3529 2004-06-20 Paul Eggert <eggert@cs.ucla.edu>
3531 * src/basename.c (main):
3532 Standardize on the diagnostics given when someone gives
3533 too few operands ("missing operand after `xxx'") or
3534 too many operands ("extra operand `xxx'").
3535 Include "quote.h" and/or "error.h" if it wasn't already being included.
3536 * src/chgrp.c (main): Likewise.
3537 * src/chmod.c (main): Likewise.
3538 * src/chown.c (main): Likewise.
3539 * src/chroot.c (main): Likewise.
3540 * src/comm.c (main): Likewise.
3541 * src/cp.c (do_copy): Likewise.
3542 * src/csplit.c (main): Likewise.
3543 * src/date.c (main): Likewise.
3544 * src/dircolors.c (main): Likewise.
3545 * src/dirname.c (main): Likewise.
3546 * src/du.c (main): Likewise.
3547 * src/expr.c (main): Likewise.
3548 * src/hostid.c (main): Likewise.
3549 * src/hostname.c (main): Likewise.
3550 * src/id.c (main): Likewise.
3551 * src/install.c (main): Likewise.
3552 * src/join.c (add_file_name, main): Likewise.
3553 * src/link.c (main): Likewise.
3554 * src/ln.c (main): Likewise.
3555 * src/logname.c (main): Likewise.
3556 * src/md5sum.c (main): Likewise.
3557 * src/mkdir.c (main): Likewise.
3558 * src/mkfifo.c (main): Likewise.
3559 * src/mknod.c (main): Likewise.
3560 * src/mv.c (main): Likewise.
3561 * src/nohup.c (main): Likewise.
3562 * src/od.c (main): Likewise.
3563 * src/pathchk.c (main): Likewise.
3564 * src/ptx.c (main): Likewise.
3565 * src/readlink.c (main): Likewise.
3566 * src/rm.c (main): Likewise.
3567 * src/rmdir.c (main): Likewise.
3568 * src/seq.c (main): Likewise.
3569 * src/setuidgid.c (main): Likewise.
3570 * src/shred.c (main): Likewise.
3571 * src/sleep.c (main): Likewise.
3572 * src/sort.c (main): Likewise.
3573 * src/split.c (main): Likewise.
3574 * src/stat.c (main): Likewise.
3575 * src/test.c (beyond, main): Likewise.
3576 * src/touch.c (main): Likewise.
3577 * src/tr.c (main): Likewise.
3578 * src/tsort.c (main): Likewise.
3579 * src/tty.c (main): Likewise.
3580 * src/uname.c (main): Likewise.
3581 * src/uniq.c (main): Likewise.
3582 * src/unlink.c (main): Likewise.
3583 * src/uptime.c (main): Likewise.
3584 * src/users.c (main): Likewise.
3585 * src/who.c (main): Likewise.
3586 * src/whoami.c (main): Likewise.
3588 * tests/basename/basic: Adjust to new diagnostics.
3589 * tests/du/files0-from: Likewise.
3590 * tests/expr/basic: Likewise.
3591 * tests/mv/diag: Likewise.
3592 * tests/tsort/basic-1: Likewise.
3594 2004-06-20 Jim Meyering <jim@meyering.net>
3596 * src/ln.c: Remove declaration of yesno.
3597 Instead, include yesno.h.
3598 * src/copy.c: Likewise.
3600 * src/remove.c: Remove declaration of yesno.
3601 Instead, include yesno.h.
3602 (top_dir): Remove now-unnecessary cast of obstack_base.
3603 (pop_dir): Likewise.
3604 (full_filename_): Likewise.
3606 2004-06-19 Paul Eggert <eggert@cs.ucla.edu>
3608 Don't dump core if ctime returns NULL; this is possible on
3609 hosts with 64-bit time_t and 32-bit int.
3610 * src/who.c: Include "inttostr.h".
3611 (time_string): If ctime fails, print the raw time as an integer
3612 instead of dumping core.
3613 * src/pinky.c: Likewise, as follows:
3614 Include "inttostr.h".
3615 (time_string): New function, copied from who.c.
3616 (print_entry): Use it.
3618 2004-06-19 Paul Eggert <eggert@cs.ucla.edu>
3620 * src/who.c (print_line): Don't truncate user names at 8 bytes.
3621 Problem reported by Guido Leenders in:
3622 http://lists.gnu.org/archive/html/bug-coreutils/2004-06/msg00056.html
3623 * NEWS: document this.
3625 2004-06-19 Jim Meyering <jim@meyering.net>
3627 * src/system.h (case_GETOPT_VERSION_CHAR): Switch back to
3628 using GNU_PACKAGE (from PACKAGE) once again. This restores
3629 `GNU' to the parenthesized package name in --version output.
3630 Before, the first argument from AC_INIT, `GNU coreutils', would
3631 be propagated to the PACKAGE variable. Now, `GNU ' is trimmed.
3632 Reported by Richard Stallman.
3634 2004-06-17 Jim Meyering <jim@meyering.net>
3636 * src/tr.c (to_uchar): Rename function from `uchar'. The latter
3637 would clash with a typedef in Tru64's <sys/types.h>. From Albert Chin.
3639 2004-06-15 Paul Eggert <eggert@cs.ucla.edu>
3641 * NEWS: Remove more special cases for POSIXLY_CORRECT when POSIX
3642 allows the GNU behavior. "--" is now supported by chroot, hostid,
3643 hosname, pwd, sync, yes.
3644 * doc/coreutils.texi (yes invocation, false invocation,
3645 true invocation): Document this.
3646 * src/chroot.c (main): Handle "--".
3647 * src/hostid.c (main): Likewise.
3648 * src/hostname.c (main): Likewise.
3649 * src/pwd.c (main): Likewise.
3650 * src/sync.c (main): Likewise.
3651 * src/yes.c (main): Likewise.
3652 * src/true.c (main): Recognize --help and --version even if
3653 POSIXLY_CORRECT is set.
3654 * src/yes.c (main): Likewise.
3656 2004-06-09 Paul Eggert <eggert@cs.ucla.edu>
3658 * NEWS: Remove special cases for POSIXLY_CORRECT when POSIX allows
3660 * doc/coreutils.texi (pr invocation, unlink invocation): Document this.
3661 * src/ls.c (decode_switches): Pay attention to TABSIZE even if
3662 POSIXLY_CORRECT is set. POSIX reserves upper-case environment
3663 variables to the implementation, so it's OK for ls to depend on
3665 * src/pr.c: Include "hard-locale.h".
3666 (main): When in a non-POSIX locale, ignore POSIXLY_CORRECT, since
3667 POSIX specifies the behavior only in the POSIX locale.
3668 * src/printf.c (print_esc): Support \x, \u, \U even if POSIXLY_CORRECT,
3669 since POSIX says the behavior is unspecified here.
3670 * src/tail.c (parse_obsolescent_option): Support multiple file operands
3671 even if POSIXLY_CORRECT, since POSIX does not require a diagnostic.
3672 * src/printf.c (main): Recognize --help, --version even if
3673 POSIXLY_CORRECT. POSIX does not specify any options, but it
3674 does not prohibit options either, so "printf" is like "expr" here.
3675 * src/unlink.c (main): Likewise.
3676 * tests/misc/printf: Adjust to the new semantics for \x if
3679 2004-06-14 Jim Meyering <jim@meyering.net>
3681 * tests/misc/pwd: New test, for fix of 2004-04-19.
3682 * tests/misc/Makefile.am (TESTS): Add pwd.
3683 (BUILD_SRC_DIR): Define BUILD_SRC_DIR.
3685 * src/copy.c: Remove declaration of euidaccess.
3686 Instead, include "euidaccess.h".
3688 2004-06-13 Paul Eggert <eggert@cs.ucla.edu>
3690 * src/who.c (PIDSTR_DECL_AND_INIT): Don't assume pid_t fits in int.
3691 (UT_ID) [!HAVE_STRUCT_XTMP_UT_ID]: Remove bogus comment,
3692 as (sizeof "??") reliably returns 3.
3693 (print_line): Guard against idle and pid being too long
3694 (which is possible when printing headers).
3695 (print_user): Allocate enough bytes for idlestr. Use IDLESTR_LEN.
3696 Avoid unnecessary cast of sizeof to int.
3697 (make_id_equals_comment): Do not assume that UT_ID returns
3698 a string; it might return a non-null-terminated array.
3699 Use strncat instead. It's not very often where strncat is
3700 exactly what you want, but this is one of those rare cases.
3702 2004-06-11 Paul Eggert <eggert@cs.ucla.edu>
3704 * src/who.c (list_entries_who): Don't output a trailing space.
3706 2004-06-09 Jim Meyering <jim@meyering.net>
3708 * src/touch.c (usage): Improve wording in description of the
3709 --time=WORD option. Reported by Dan Jacobson.
3711 * src/chown-core.c (change_file_owner): Change names of parameters
3712 old_uid and old_gid to required_uid and required_gid respectively.
3714 * src/chmod.c (mode_changed): Return false, not 0, now that the
3715 function returns `bool'.
3717 2004-06-08 Paul Eggert <eggert@cs.ucla.edu>
3719 Adjust chmod and chown to be similar if -c or -v are given. In
3720 particular, a no-op chown is no longer reported as a change; this
3721 reverts to previous behavior. Also, fix both commands so that -v
3722 report failures even if the failure is not due to the chmod or
3725 * src/chmod.c (CH_NOT_APPLIED): New constant.
3726 (describe_change): Handle it.
3727 (process_file): Use it, if a symlink wasn't changed.
3728 (mode_changed): Return bool, not int. Accept new argument
3729 NEW_MODE; all callers changed. This lets us avoid statting the
3730 file unless the new mode has unusual bits.
3731 (process_file): Return -1 on error. With -v, report all errors
3732 verbosely, not just some.
3734 * src/chown-core.c (change_file_owner): Return -1 on error, not
3735 1 sometimes and -1 on others. Our caller ORs together our results,
3736 and (-1 | 1) == 0 on ones-complement hosts.
3737 With -v report all errors verbosely, not just some.
3738 Fix bug when chopt->root_dev_ino && !chopt->affect_symlink_referent:
3739 file_stats wasn't set properly in that case.
3741 * tests/chgrp/basic: Adjust to above changes.
3743 2004-05-20 Paul Eggert <eggert@cs.ucla.edu>
3745 * tests/chgrp/basic: Test that chgrp -h does not fail on
3746 symlinks, even on hosts where that's not supported.
3747 Test that if -R is specified without -H or L, -h is assumed.
3748 Test that chown() is not optimized away.
3750 2004-05-18 Paul Eggert <eggert@cs.ucla.edu>
3752 Several fixes to chgrp and chown for compatibility with POSIX and BSD:
3754 Check for incompatible options. When -R and --dereference are
3755 both used, then either -H or -L must also be used. When -R and -h
3756 are both used, then -P must be in effect.
3758 -H, -L, and -P have no effect unless -R is also specified.
3759 If -P and -R are both specified, -h is assumed.
3761 Do not optimize away the chown() system call when the file's owner
3762 and group already have the desired value. This optimization was
3763 incorrect, as it failed to updated the last-changed time and reset
3764 special permission bits, as POSIX requires.
3766 Do not report an error if the owner or group of a
3767 recursively-encountered symbolic link cannot be updated because
3768 the file system does not support it.
3770 * NEWS: Document the above.
3772 * src/chgrp.c (main): Check for incompatible options. -R --dereference
3773 requires either -H or -L, and -R -h requires -P. If -H, specify
3774 FTS_PHYSICAL as well as FTS_COMFOLLOW; this is faster. Make this
3775 file as much like chown.c as possible.
3776 * src/chown.c (main): Likewise.
3778 * src/chown-core.c (change_file_owner): Use ent->fts_statp only if
3779 needed. Chown a directory only after chowning its children; this
3780 avoids problems if the new directory ownership doesn't permit
3781 access to the children. Dereference symlinks before doing
3782 ROOT_DEV_INO_CHECK, not after, so that we catch symlinks to /.
3783 Do not optimize away the chown() system call when the file's owner
3784 and group already have the desired value. POSIX does not permit
3785 this optimization. Rely on chown and lchown to do the right
3786 thing with symlinks and/or -1 arguments, now that we have wrappers
3787 to do this. Use ENOTSUPP not ENOSYS, and ignore all ENOTSUPP
3788 errors, not just command-line errors.
3789 (chown_files): Pass FTS_NOSTAT to xfts_open if we don't need file status.
3791 * src/system.h (ENOTSUP): Remove.
3793 * tests/chgrp/basic: Use chown --from to discover whether the
3794 group changed, since chgrp now changes unconditionally. This
3795 complicates the sed script a bit. Do not specify --dereference,
3796 since it's the default (and we want to test this). Adjust output
3797 to match the fact that chgrp no longer optimizes the case of
3798 changing a file's group to the same value as before.
3799 * tests/chgrp/posix-H: Do not attempt to combine -h and -H; these
3800 options are incompatible, and their behavior is undefined with POSIX.
3801 (changed, not_changed): Adjust to match the fact that -h is no longer
3802 specified. Sort names.
3803 * tests/chown/deref: Adjust error-diagnostic spelling to match new
3806 2004-06-07 Paul Eggert <eggert@cs.ucla.edu>
3808 * src/uname.c (main): Fix typo introduced on 2003-05-10 that
3809 prevented a diagnostic of any operands.
3811 2004-06-08 Jim Meyering <jim@meyering.net>
3813 * src/shred.c (direct_mode): Turn it on/off with directio, too.
3815 2004-06-07 Jim Meyering <jim@meyering.net>
3817 Enable direct-mode I/O (bypassing the buffer cache), if possible.
3818 Prompted by a suggestion from Kalle Olavi Niemitalo
3819 in http://bugs.debian.org/207035.
3820 * src/shred.c (direct_mode): New function.
3821 (do_wipefd): Turn on direct-mode I/O.
3822 (dopass): If a file's first write fails with EINVAL,
3823 turn off direct-mode I/O and retry the write.
3825 2004-06-05 Paul Eggert <eggert@cs.ucla.edu>
3827 * src/tr.c (main): "tr -d a b" is now a fatal error even if
3828 POSIXLY_CORRECT is set. The POSIX SYNOPSIS does not allow this
3831 2004-06-04 Paul Eggert <eggert@cs.ucla.edu>
3833 * src/shred.c (dopass): Don't subtract 1 from the offset after
3834 a write error. Problem reported by Jon Peatfield in:
3835 http://lists.gnu.org/archive/html/bug-coreutils/2004-06/msg00020.html
3837 2004-06-02 Paul Eggert <eggert@cs.ucla.edu>
3839 Fix bug reported by Buciuman Adrian in
3840 <http://mail.gnu.org/archive/html/bug-coreutils/2003-08/msg00105.html>
3841 where 'dd' created a file that was too large. The bug was that dd
3842 assumed that the input file offset does not advance after a failed
3843 read; but POSIX says that the input file offset is undefined after
3846 * src/dd.c (MAX_BLOCKSIZE): New macro.
3847 (input_seekable, input_seek_errno, input_offset,
3848 input_offset_overflow): New vars.
3849 (scanargs): Reject block sizes greater than MAX_BLOCKSIZE.
3850 (advance_input_offset): New function.
3851 (skip_via_lseek): Set errno to zero when reporting our failure,
3852 so that we don't report based on garbage errno.
3853 (skip): If fdesc is standard input, advance the input offset.
3854 Do not quit if reading, and if noerror was specified;
3855 POSIX seems to require this.
3856 If read fails on output file, report the earlier lseek failure
3857 instead; this fixes a FIXME in dd_copy.
3858 (advance_input_after_read_error): New function.
3859 (dd_copy): Use it, instead of assuming that failed reads
3860 do not advance the file pointer. Advance input offset
3861 after nonfailed reads. Advance only a partial block if
3862 the previous read (before the failed read) succeeded, and
3863 do not generate an output block of zeros in this case.
3864 (main): Determine initial input offset, seekability of input,
3865 and error if it wasn't seekable.
3867 2004-06-02 Jim Meyering <jim@meyering.net>
3869 rm (without -f) could hang unnecessarily when attempting to
3870 remove a symlink to a file on an off-line NFS-mounted partition.
3871 Reported by David Howells in https://bugzilla.redhat.com/124699.
3872 * src/remove.c (write_protected_non_symlink): New function.
3873 Don't invoke euidaccess on symlinks.
3874 (prompt): Use write_protected_non_symlink rather than using
3875 euidaccess directly, being careful not to call lstat twice for a file.
3877 Fix a bug in how the --output-delimiter=D option works with
3878 abutting byte or character ranges. Reported by David Krider in
3879 http://lists.gnu.org/archive/html/bug-coreutils/2004-05/msg00132.html
3880 * src/cut.c (print_kth): Remove special case for open-ended range.
3881 (set_fields): Record the range start index for an interval even
3882 when it abuts another interval on its low side.
3883 Also record the range start index of the longest right-open-interval.
3884 * tests/cut/Test.pm: Add tests of --output-delimiter=S with
3885 abutting and overlapping byte ranges.
3887 2004-06-01 Paul Eggert <eggert@cs.ucla.edu>
3889 Some POSIX-conformance cleanups for tr.
3891 * src/tr.c (posix_pedantic): Remove; no longer needed since
3892 we need to test this in just one place now.
3893 (usage): Mention -C.
3894 (unquote): Note that \055, \n, etc are escaped.
3895 Do not worry about POSIXLY_CORRECT when warning about ambiguous
3897 \ at end of string stands for itself.
3898 Do not diagnose invalid backslash escapes: POSIX says the behavior
3899 is unspecified in this case, so we don't need to diagnose it.
3900 (main): Add support for -C (currently an alias for -c).
3901 Do not diagnose 'tr [:upper:] [:upper:], as POSIX does not require
3903 * tests/tr/Test.pm: New tests bs-055, bs-at-end, repeat-Compl.
3904 Fix comment for range-a-a.
3906 2004-05-25 Paul Eggert <eggert@cs.ucla.edu>
3908 Improve the efficiency (and in one case, correctness) of code
3909 that reads symlinks.
3911 * src/copy.c (copy_internal): Don't use alloca, as it can mess up
3912 royally if the link length is long (e.g., GNU/Hurd). Use
3913 xreadlink instead, it's safer. Don't bother to read the link if
3914 it's the wrong size. Add a FIXME because this area is a bit murky
3916 * src/ls.c (get_link_name): Update use of xreadlink.
3917 * src/readlink.c (main): Likewise.
3918 * src/stat.c (print_stat): Likewise.
3920 2004-06-01 Jim Meyering <jim@meyering.net>
3922 * src/env.c (main): Prefer the notation `STREQ (a, b)'
3923 over `!strcmp (a, b)'.
3924 * src/sort.c (main, sort_buffer_size): Prefer the notation
3925 `STREQ (a, b)' over `strcmp (a, b) == 0'.
3926 * src/date.c (batch_convert): Likewise.
3927 * src/expr.c (nextarg): Likewise.
3928 * src/su.c (correct_password, restricted_shell, main): Likewise.
3929 * src/ptx.c (swallow_file_in_memory, main): Likewise.
3930 * src/test.c (binary_operator, and, or, main): Likewise.
3932 2004-05-13 Paul Eggert <eggert@cs.ucla.edu>
3934 * NEWS: echo compatibility cleanup.
3935 * doc/coreutils.texi (echo invocation): Document the changes.
3936 * src/echo.c (V9_ECHO): Remove; always enabled.
3937 (DEFAULT_ECHO_TO_XPG): Renamed from V9_DEFAULT, so that
3938 we use the same naming convention as bash. Now an enum,
3940 (usage): Reword to mention -e/-E more accurately.
3941 Mention \0NNN (the POSIX syntax) rather than \NNN (nonstandard).
3942 (hextobin): New function.
3943 (main): Use bool rather than int for local vars when appropriate.
3944 Do not allow options if POSIXLY_CORRECT, unless we are using
3945 BSD semantics and the first argument is "-n".
3946 Don't pass unnecessary extra arg to parse_long_options.
3947 do_v9 now defaults to DEFAULT_ECHO_TO_XPG, not to allow_options.
3948 Do not look for options if !allow_options.
3949 Use size_t rather than int when appropriate.
3950 Open-code option test rather than using strrchr.
3951 Use faster test for "-".
3952 Avoid redundant argc test.
3953 Add support for \x, for Bash compatibility.
3954 Use e.g. '\a' rather than '\007', for portability to EBCDIC hosts.
3955 When '\c' is encountered, stop printing immediately, as POSIX
3957 Add support for \xhh syntax.
3958 Add support for \0ooo syntax; POSIX requires this.
3960 2004-06-01 Jim Meyering <jim@meyering.net>
3962 * Use automake-1.8b. Regenerate dependent files.
3964 2004-05-31 Jim Meyering <jim@meyering.net>
3966 * tests/Makefile.am.in (TESTS_ENVIRONMENT): Define PATH to include
3967 the build src/ directory -- at the front.
3968 ($(srcdir)/$x-tests): Depend on Makefile.am.
3969 Use $x as the program name, except when it would be `test' (test is
3970 the sole program tested via mk-script that is also a shell built-in).
3971 In that case, use the old ../../src/$x.
3973 2004-05-30 Jim Meyering <jim@meyering.net>
3975 Work around HPUX /bin/cc compiler bug that is exposed, now that
3976 sets are arrays of type `bool'. More details here:
3977 http://lists.gnu.org/archive/html/bug-gnulib/2004-05/msg00094.html
3978 FIXME: verify that the above URL points to the right message
3980 * src/tr.c (card_of_complement): Use cleaner `sizeof in_set'
3981 rather than `N_CHARS * sizeof(in_set[0])'. Using HPUX's /bin/cc
3982 (aC++/ANSI C B3910B A.05.55 [Dec 04 2003]) on an ia64-hp-hpux11.22
3983 system, those two expressions are not the same (256 vs. 1024).
3984 The effect of this problem was that `tr -c x y' would fail:
3985 tr: when not truncating set1, string2 must be non-empty
3986 (set_initialize): Remove unnecessary initialization of the `in_set'
3987 buffer; that initialization triggered the same compiler bug as above.
3989 2004-05-29 Paul Eggert <eggert@cs.ucla.edu>
3991 tr cleanup, mostly having to do with integer type ranges.
3994 * tests/tr/Test.pm: Add a few tests for the below. Alas, most of
3995 the test cases wouldn't be portable, or would take too much CPU
3998 * src/tr.c (N_CHARS, N_CHAR_CLASSES): Now an enum, not a macro.
3999 This is safe since the code already assumes N_CHARS fits in int.
4000 (Filter): Remove: we want to prototype everything.
4001 (ORD, CHR): Remove. All uses removed. Some replaced with:
4002 (uchar): New function. All places where a char must be converted
4003 to an unsigned char are now done this way, not by ad-hoc methods.
4004 (count): New type. Use it whenever counts or states are needed.
4005 (BEGIN_STATE): Increase from INT_MAX - 1 (which was bogus, anyway,
4006 since we used it in an unsigned int context) to UINTMAX_MAX - 1.
4007 (REPEAT_COUNT_MAXIMUM): New macro. Use it in place of BEGIN_STATE
4008 whenever appropriate.
4009 (NOT_A_CHAR): Remove global macro; now a local enum.
4010 (UL_LOWER, UL_UPPER, UL_NONE): No longer specify values, since
4011 the rest of the code no longer depends on them.
4012 (class_ok): Remove; all uses changed to use inline comparisons.
4013 (RE_NO_TYPE): Remove; wasn't used or needed.
4014 (struct List_element): normal_char and equiv_code are now unsigned
4016 first_char, last_char, and the_repeated_char are now unsigned char,
4017 not unsigned int. repeat_count is now count, not size_t.
4019 (struct Spec_list): state is now count, not unsigned int.
4020 lengthis now count, not size_t.
4021 n_indefinite_repeats is now size_t, not int.
4022 has_equiv_class, has_char_class, and has_restricted_char_class
4023 are now bool, not int. All uses changed.
4024 (struct E_string): s is now char *, not unsigned char *.
4025 escaped is now bool *, not int *. All uses changed.
4026 (ES_MATCH): Remove macro, replacing with:
4027 (es_match): New inline function. All uses changed.
4028 (squeeze_repeats, complement, posix_pedantic, truncate_set1,
4029 translating): Now bool, not int.
4030 (io_buf): Now char array, not unsigned char.
4031 (SET_TYPE): Remove. All uses replaced with bool.
4032 (is_equiv_class_member, unquote, append_range, append_char_class,
4033 append_equiv_class, find_closing_delim, star_digits_closebracket,
4034 build_spec_list, parse_str, homogeneous_spec_list):
4035 Now returns bool, not int. All uses changed.
4036 (is_equiv_class_member): Now inline.
4037 (is_equiv_class_member, is_char_class_member, make_printable_str,
4038 append_normal_char, append_range, append_repeated_char,
4040 Args are now of proper integer type.
4041 (unquote, look_up_char_class, make_printable_str,
4042 append_equiv_class, build_spec_list, squeeze_filter):
4043 Avoid unsigned char *p; gently convert *p to unsigned char instead.
4044 (unquote, get_spec_stats): Do not jump past declarations and then
4045 use them; C doesn't allow this in portable programs.
4046 (make_printable_str): Check for overflow in size calculations.
4047 (xmemdup): Remove. All uses rewritten.
4048 (find_bracketed_repeat): Args are now of proper pointer-to-integer
4049 type. Do not reject [c*0]. Use xstrtoumax, not xstrtoul.
4050 (find_bracketed_repeat, star_digits_closebracket): Check that the
4051 digits are not escaped.
4052 (build_spec_list): Don't bother to copy opnd_str; not needed.
4053 (build_spec_list, get_next): Simplify internal logic a bit.
4054 (card_of_complement): Fix bug due to char overflow.
4055 (get_spec_stats): Don't assume len fits into int.
4056 Check for integer overflow. Use abort() rather than assert(0).
4057 (string2_extend): Fix subscript error: is_char_class_member (..., 255)
4059 (squeeze_filter): READER is never null now; simplify code.
4060 READER arg now has a simpler type. Remove unnecessary casts.
4061 (squeeze_filter, main): Calls to fwrite improperly checked result
4062 against zero, rather than against requested size.
4063 (plain_read): New function.
4064 (read_and_delete, read_and_xlate):
4065 Remove unused filter arg, and don't worry about hit_eof.
4066 Simplify by using plain_read.
4067 (set_initialize): Args are bool and bool *, not int and SET_TYPE *.
4068 (main): Always pass a non-null procedure to squeeze_filter.
4069 Rewrite so that class_ok isn't needed.
4071 2004-05-29 Paul Eggert <eggert@cs.ucla.edu>
4073 * src/shred.c (dosync): Ignore EBADF errors, as IRIX 6.5
4074 fdatasync reports EBADF when syncing (unwritable) directories.
4075 Problem reported by Albert Chin-A-Young in:
4076 http://lists.gnu.org/archive/html/bug-coreutils/2004-05/msg00165.html
4078 2004-05-29 Jim Meyering <jim@meyering.net>
4080 * tests/chown/deref: Fix typo: use ls -ldo, not ls -ldg.
4081 Patch from Albert Chin.
4083 * src/ptx.c (text_buffer_maxend): Remove declaration of unused variable.
4085 * src/remove.c (push_dir): Merge declaration and adjacent assignment
4086 into a single statement.
4088 2004-05-28 Jim Meyering <jim@meyering.net>
4090 * src/remove.c (AD_mark_helper): Eliminate an unnecessary comparison.
4092 2004-05-22 Jim Meyering <jim@meyering.net>
4094 rm -r would get a failed assertion when run from an inaccessible
4095 directory and with two or more command line arguments including an
4096 absolute-named directory followed by a relative-named directory.
4098 * src/remove.h (struct rm_options) [require_restore_cwd]: New member.
4099 * src/remove.c (struct cwd_state): Define.
4100 (AD_pop_and_chdir): Redesign interface so that a restore_cwd failure
4101 can be detected by the caller. Instead of returning a malloc'd
4102 directory name, communicate it to caller via a new parameter, and
4103 return an indication of whether restore_cwd failed. Update caller.
4104 Eliminate an unnecessary call to AC_stack_top.
4105 (remove_dir): Change type of cwd_state parameter to `struct cwd_state'
4106 so we can now communicate to caller whether/how functions like
4107 restore_cwd have failed. Update caller.
4108 (rm_1): Fail if we've failed to restore the working directory
4109 and the name of the next file to remove is `.'-relative.
4110 (rm): Fail if the require_restore_cwd flag is true and we've
4111 failed to restore the working directory.
4112 * src/mv.c (rm_option_init): Initialize new member,
4113 x->require_restore_cwd.
4114 * src/rm.c (rm_option_init): Likewise.
4116 2004-05-21 Jim Meyering <jim@meyering.net>
4118 * tests/rm/inaccessible: New test for the above fix.
4119 * tests/rm/Makefile.am (TESTS): Add inaccessible.
4121 * src/remove.c (rm): Use free rather than XFREE.
4122 (remove_dir): Use xmalloc, not XMALLOC.
4123 (ds_init): Likewise.
4125 2004-05-20 Jim Meyering <jim@meyering.net>
4127 * Makefile.maint (sc_unmarked_diagnostics): Now that the unmarked
4128 diagnostics in shred.c have been fixed, don't exempt shred.c from
4131 * src/shred.c: Use translatable diagnostics, e.g.
4132 change "%s: remove" to _("%s: failed to remove") and
4133 change "%s: close" to _("%s: failed to close").
4135 2004-05-17 Paul Eggert <eggert@cs.ucla.edu>
4137 * src/shred.c (names): Bring back lower-case letters, "_", and
4138 ".". But continue to omit +, =, %, @, #, as they're either
4139 shell metacharacters (for some shells) or are not in some
4140 character sets, or (in the case of '%') must be a
4141 metacharacter somewhere.
4143 2004-05-16 Paul Eggert <eggert@cs.ucla.edu>
4145 * src/cut.c (cut_fields): Adjust to new signature of getndelim2.
4147 2004-05-17 Jim Meyering <jim@meyering.net>
4149 * src/shred.c (incname): Decrement `len' only once per loop iteration.
4151 chgrp and chown now dereference symlinks by default, per POSIX.
4152 Reported by Michal Politowski as http://bugs.debian.org/249177.
4154 * src/chown-core.c (chopt_init): Affect each symlink referent by default.
4155 * src/chown.c (usage): Update to reflect this.
4156 * src/chgrp.c (usage): Likewise.
4157 * NEWS: Describe the change.
4158 Adapt tests accordingly.
4159 * tests/chgrp/basic: Use -h where necessary to retain semantics.
4160 * tests/chgrp/deref: Likewise.
4161 * tests/chgrp/posix-H: Likewise.
4163 2004-05-15 Paul Eggert <eggert@cs.ucla.edu>
4165 In shred, check for errors from fdatasync more carefully. If
4166 fdatasync fails with errno==EINVAL, it means this implementation
4167 does not support synchronized I/O for this file. Do not report
4168 this as an error, as (for example) AIX 5.2 fdatasync reports it
4169 for raw disk devices. Problem reported by Albert Chin in
4170 <http://mail.gnu.org/archive/html/bug-gnu-utils/2004-05/msg00028.html>.
4172 Check for write errors, though: the old code ignored them.
4173 Improve error checking in a few other cases, too (e.g., close of a
4176 Also, change several 'int' values to 'bool', so that the error
4177 checking is a bit clearer. Similarly, change unsigned values
4178 to size_t where appropriate.
4180 * src/shred.c: Include "dirname.h".
4181 (datasync) [!HAVE_FDATASYNC]: Remove.
4182 (dosync): New function.
4183 (dopass): Use it. Return 1 on write error, -1 on other error.
4184 All callers changed. Report write error if dosync does.
4185 (do_wipefd, wipefd, wipename, wipefile): Return bool (true/false),
4186 not int (0/-1). All callers changed. Return false if there's a
4188 (incname): Return bool (true/false), not int (0/1). Accept
4189 size_t length, not unsigned. All callers changed. Do not
4190 bother checking for non-digits; it can't happen. Replace
4191 recursion with iteration.
4192 (wipename): Use dir_name, base_name, etc. instead of assuming
4193 Unix file names. Use size_t for length, not unsigned.
4194 Report error if unlink or close fails.
4195 (wipename, main): Use bool for booleans.
4197 (names): Use only digits and uppercase letters, for greater
4200 2004-05-16 Jim Meyering <jim@meyering.net>
4202 * tests/chown/deref: New test for the yesterday's change.
4203 * tests/chown/Makefile.am (TESTS): Add deref.
4205 2004-05-15 Jim Meyering <jim@meyering.net>
4207 chown --dereference did nothing when the owner/group of a
4208 symlink matched the desired owner/group. Reported by David Malone.
4209 Also reported in 1999 as http://bugs.debian.org/39642.
4211 * src/chown-core.c (change_file_owner): When --dereference has
4212 been specified, and when processing a symlink, stat it to get the
4213 owner and group of the referent.
4215 2004-05-14 Jim Meyering <jim@meyering.net>
4217 * man/pwd.x, man/echo.x, man/printf.x: Fix typo:
4218 s/supercede/supersede/ reported by Andrew Fabbro.
4220 2004-05-13 Paul Eggert <eggert@cs.ucla.edu>
4222 Improve performance of `sort -m' on large files, at the cost of
4223 making some contrived examples unsafe. POSIX allows this
4224 optimization. Performance problem reported by Jonathan Baker in
4225 <http://mail.gnu.org/archive/html/bug-coreutils/2004-05/msg00071.html>.
4227 * src/sort.c (first_same_file): Do not treat input pipes
4228 differently from other files.
4229 * doc/coreutils.texi (sort invocation): Document that "sort -m -o F"
4230 might write F before reading all the input.
4233 2004-05-12 Paul Eggert <eggert@cs.ucla.edu>
4235 * src/od.c (print_ascii, dump_strings): Use e.g. '\a' rather than
4236 '\007', for portability to EBCDIC hosts.
4237 * src/printf.c (print_esc_char): Likewise.
4238 * src/tr.c (unquote, make_printable_str): Likewise.
4240 2004-05-12 Jim Meyering <jim@meyering.net>
4242 * src/remove.c (AD_pop_and_chdir): Move lstat-`.' into if-block
4243 where the result is used. This avoids one unnecessary lstat call
4244 per command line argument.
4246 2004-05-12 Paul Eggert <eggert@cs.ucla.edu>
4248 Don't assume that "make -C" works; Solaris "make" doesn't have -C.
4250 * src/Makefile.am (all_programs.list): New rule, copied from
4251 man/Makefile.am and tests/Makefile.am, except that we use the
4252 system tr rather than ./tr and we don't use tr -s.
4253 * tests/Makefile.am (all_programs): Use it.
4254 * man/Makefile.am (all_programs): Likewise. Renamed from programs,
4255 for consistency. All uses changed.
4257 2004-05-11 Jim Meyering <jim@meyering.net>
4259 * tests/rm/unread3: New test, for the above fix and today's
4260 lib/save-cwd.c improvement.
4261 * tests/rm/Makefile.am (TESTS): Add unread3.
4263 * src/rm.c: Don't include "save-cwd.h". It's no longer used.
4265 2004-05-10 Jim Meyering <jim@meyering.net>
4267 * tests/install/trap: New file. Test for bug fix of 2004-04-18.
4268 * tests/install/Makefile.am (TESTS): Add trap.
4270 * src/remove.c (AD_push): Don't use errno in diagnostic about
4273 Remove these generated files from CVS.
4274 * tests/cut/cut-tests, tests/date/date-tests, tests/join/join-tests:
4275 * tests/ls/ls-tests, tests/pr/pr-tests, tests/tac/tac-tests:
4276 * tests/tail/tail-tests, tests/test/test-tests, tests/tr/range-tests:
4277 * tests/tr/tr-tests, tests/wc/wc-tests:
4279 2004-05-09 Jim Meyering <jim@meyering.net>
4281 * src/tr.c (unquote): Use xcalloc rather than xmalloc and
4282 a loop initializing the just-allocated memory to zero.
4284 2004-05-08 Jim Meyering <jim@meyering.net>
4286 * tests/rm/no-give-up: New file; check for today's fix.
4287 * tests/rm/Makefile.am (TESTS): Add no-give-up.
4289 2004-05-08 Paul Eggert <eggert@cs.ucla.edu>
4291 Fix bug where "rm" gave up too easily, reported by Dan Jacobsen in
4292 <http://mail.gnu.org/archive/html/bug-coreutils/2004-05/msg00013.html>.
4294 * src/remove.c (remove_entry): Check for errno values like ENOENT
4295 that show the file cannot be directory, instead of for errno
4296 values like EPERM that show the file might be a directory. This
4297 is necessary because, when a single unlink() call has multiple
4298 reasons to fail, it can set errno to any of those reasons; it's
4299 only the rare errno value like ENOENT that excludes all the other
4300 possible reasons to fail even when the file is a directory.
4301 (remove_cwd_entries): Don't attempt chdir if the file is known
4302 to not be a directory.
4303 (remove_dir): Use the same method that remove_cwd_entries uses
4304 (for some reason they differed). Don't assert that saved_errno
4305 must be EPERM; it might be just about anything.
4307 2004-05-06 Jim Meyering <jim@meyering.net>
4309 * src/id.c (xgetgroups): Use xnmalloc, rather than xmalloc.
4310 Don't add `1' to the buffer size (it was to protect against malloc
4311 implementations that fail to allocate a buffer of size zero).
4312 That is no longer necessary, since we use a malloc wrapper
4315 * src/wc.c (get_input_fstatus): Use xnmalloc, rather than xmalloc.
4316 * src/head.c (elide_tail_bytes_pipe): Likewise.
4317 * src/df.c (main): Likewise.
4318 * src/shred.c (do_wipefd): Likewise.
4319 * src/users.c (list_entries_users): Likewise.
4320 * src/tail.c (main): Likewise.
4321 * src/md5sum.c (main): Likewise.
4323 2004-04-29 Paul Eggert <eggert@cs.ucla.edu>
4325 * src/df.c (show_disk, show_point): If several filesystems are
4326 mounted on the same mount point, prefer the last one, not the first.
4327 Problem reported by Christian Jones in
4328 <http://mail.gnu.org/archive/html/bug-coreutils/2004-04/msg00200.html>.
4329 (show_disk): Remove unused statp arg. Return bool, not int.
4330 (show_point): Rewrite to avoid gotos. Use the same algorithm
4331 for lofs and dummies for each pass through the mount table,
4332 rather than subtly different algorithms (which are probably
4335 2004-05-03 Jim Meyering <jim@meyering.net>
4337 * Makefile.am (EXTRA_DIST): Add m4/ChangeLog, now that we no longer
4340 2004-05-01 Jim Meyering <jim@meyering.net>
4342 When chown or chgrp is modifying the referent of a symlink,
4343 use the chown(2) function, if possible.
4344 * src/chown-core.c (change_file_owner): Don't hard-code the
4345 open/fchown/close kludge here. Use `chown' instead.
4346 The chown function works just fine on conforming systems.
4347 Other systems now go through the new chown wrapper that
4348 resorts to the old kludge.
4350 * src/chown-core.c (change_file_owner): Add a comment.
4352 2004-04-27 Jim Meyering <jim@meyering.net>
4354 * src/ptx.c: Make over 40 global extern variables `static'.
4355 (syntax_table, re_syntax_table): Remove declarations of two unused
4356 variables (they were exposed by the above change).
4358 * src/du.c (G_fail, opt_nul_terminate_output): Declare `static'.
4359 * src/ln.c (backup_type): Likewise.
4361 * src/remove.c (rm): Add `extern' keyword.
4362 * src/cp-hash.c (forget_created, remember_created)
4363 (src_to_dest_lookup, remember_copied, hash_init, forget_all): Likewise.
4364 * src/copy.c (dest_info_init, src_info_init, copy): Likewise.
4365 * src/chown-core.c (chopt_init, chopt_free, gid_to_name)
4366 (uid_to_name, chown_files): Likewise.
4368 * src/Makefile.am (sc_tight_scope): New rule.
4369 * Makefile.maint (sc_tight_scope): New rule.
4370 (syntax-check-rules): Add it.
4372 2004-04-26 Jim Meyering <jim@meyering.net>
4374 * Use automake-1.8.4. Regenerate dependent files.
4376 * src/sort.c (limfield): Make a comment clearer.
4378 2004-04-25 Paul Eggert <eggert@twinsun.com>
4380 Fix POSIX-conformance bug: "sort -k 3,3.5b" is supposed to skip
4381 leading blanks when computing the location of the field end;
4382 it is not supposed to skip trailing blanks. Solaris 8 "sort"
4383 does conform to POSIX. Also fix the documentation to clarify
4384 this and related issues.
4386 * doc/coreutils.texi (sort invocation): Mention -k earlier, so
4387 that the options are in alphabetical order. Describe how -b works
4388 more-accurately; this involves fixing some examples, too. Mention
4389 what happens if the start field falls after an end field or after
4390 a line end. Warn about using -k without -b, -g, -M, -n, or -t.
4391 Add an example of how to sort IPv4 addresses and Apache Common
4392 Log Format dates. Remove a duplicate example.
4393 (Putting the tools together): Use separate options rather
4394 than agglomerating them.
4395 * src/sort.c (limfield): Use skipeblanks, not skipsblanks, to
4396 decode whether to skip leading blanks.
4397 (trailing_blanks): Remove.
4398 (fillbuf, getmonth, keycompare): Don't trim trailing blanks.
4400 * tests/pr/Test.pm: Fix typo in env_default comment.
4401 * tests/sort/Test.pm: Likewise.
4402 (18c, 18d): Reverse the order of output lines, so that the
4403 test cases conform to POSIX.
4405 2004-04-22 Paul Eggert <eggert@twinsun.com>
4407 More signal-handling cleanup for ls.c. Do not allow signals to
4408 happen between arbitrary output bytes, as the
4409 restore-default-color sequence can bollix up multibyte chars or
4410 color-change sequences in the ordinary output. Instead, process
4411 signals only between printing a file name and changing the color
4412 back to non_filename_text color. That way, if the signal handler
4413 changes the color (to the default), 'ls' will change it back when
4414 'ls' continues (after being suspended).
4416 Also, do not bother with signal-handling unless stdout is a
4417 controlling terminal; this lets stdio buffer better when "ls
4418 --color" is piped or sent to a file.
4420 * src/ls.c (sigprocmask, sigset_t) [!defined SA_NOCLDSTOP]: New macros.
4421 Do not include "full-write.h"; no longer needed.
4422 (tcgetpgrp) [! HAVE_TCGETPGRP]: New macro.
4423 (put_indicator_direct): Remove. All callers changed to use
4425 (caught_signals, interrupt_signal, stop_signal_count): New vars.
4426 (restore_default_color): Don't bother checking for put_indicator
4428 (sighandler): Don't handle SIGTSTP; that's another handler now.
4429 Simply set interrupt_signal to the signal, then exit.
4430 (stophandler, process_signals): New functions.
4431 (main): Don't output any color changes until _after_ the signal
4432 handlers are set up. This fixes a race condition where 'ls'
4433 could be interrupted while initializing colors, and leaving the
4434 terminal in an undesirable state.
4435 Don't mess with signal-handling if standard output is not a
4436 controlling terminal.
4437 When exiting, restore the default color, then restore the
4438 default signal handling, then act on any signals that weren't
4440 Do not print //DIRED// etc. in colors; this avoids the need
4441 to catch signals when printing them.
4442 (print_name_with_quoting): Process signals just before switching
4443 color back to non_filename_text.
4445 2004-04-23 Jim Meyering <jim@meyering.net>
4447 Avoid segfault on systems for which SIZE_MAX != (size_t) -1.
4448 * src/ls.c (quote_name): Use SIZE_MAX, not -1, in calls
4449 of quotearg_buffer. Patch by Mikulas Patocka.
4451 2004-04-18 Paul Eggert <eggert@twinsun.com>
4453 tee ignored SIGPIPE, but POSIX doesn't allow this.
4455 * src/tee.c (main): Do not ignore SIGPIPE, as POSIX 1003.1-2001
4456 does not allow this. This undoes the 1996-10-24 patch.
4458 2004-04-18 Paul Eggert <eggert@twinsun.com>
4460 Signal-handling cleanup for coreutils. Here are the highlights:
4462 - csplit sometimes failed to remove files when interrupted.
4463 - csplit didn't clean up if two signals arrived nearly simultaneously.
4464 - install -s would infloop on System V if SIGCHLD was ignored.
4465 - ls could incorrectly restore color if multiple signals
4466 arrived nearly simultaneously.
4468 * src/csplit.c (sigprocmask, sigset_t) [!defined SA_NOCLDSTOP]:
4470 (filename_space, prefix, suffix, digits, files_created, remove_files):
4472 (caught_signals): New var.
4473 (cleanup): Block signals while deleting all files.
4474 (cleanup_fatal, handle_line_error, regexp_error):
4475 Mark with ATTRIBUTE_NORETURN.
4476 (create_output_file, close_output_file, interrupt_handler):
4477 Block signals while changing the number of output files,
4478 to fix some race conditions.
4479 (delete_all_files): Do nothing if remove_files is zero.
4480 Clear files_created.
4481 (main): Don't mess with signals until after argument processing
4484 * src/csplit.c (main): Rewrite signal-catching code to make it
4485 similar to other coreutils programs. When processing signals,
4486 block all signals that we catch, but do not block signals that we
4487 don't catch. Avoid problems with unsigned int warnings.
4488 * src/ls.c (main): Likewise.
4489 * src/sort.c (main): Likewise.
4491 * src/csplit.c (interrupt_handler):
4492 Use void, not (obsolete) RETSIGTYPE.
4493 * src/shred.c (sigill_handler, isaac_seed_machdep): Likewise.
4495 * src/csplit.c (interrupt_handler) [defined SA_NOCLDSTOP]:
4496 Use simpler "signal (sig, SIG_DFL)" rather than sigaction equivalent.
4497 * src/ls.c (sighandler) [defined SA_NOCLDSTOP]: Likewise.
4498 * src/sort.c (sighandler) [defined SA_NOCLDSTOP]: Likewise.
4499 * src/nohup.c (main) [!defined _POSIX_SOURCE]: Likewise, except
4501 * src/tee.c (main) [!defined _POSIX_SOURCE]: Likewise.
4503 * src/install.c: Include <signal.h>.
4504 (main) [defined SIGCHLD]: Set SIGCHLD handler to the default, if -s is
4505 given, since System V fork+wait does not work if SIGCHLD is ignored.
4507 * src/ls.c (sighandler) [!defined SA_NOCLDSTOP]: Reset signal
4508 handler to self, not to SIG_IGN, since SIGTSTP can be received
4510 (main): Use SA_RESTART, as that is simpler than checking for EINTR
4511 failures all over the place.
4513 2004-04-20 Jim Meyering <jim@meyering.net>
4515 * src/remove.c (is_empty_dir): Clarify comment.
4517 * man/help2man: Accept new option: --program-name=NAME, so that we
4518 can override the one in --version output. This is needed solely
4519 so that test.1 doesn't refer to `[' as the program name.
4520 Reported by Benjamin Cutler as http://bugs.debian.org/205251.
4521 * man/Makefile.am (.x.1): Use help2man's new --program-name option.
4523 * src/pwd.c: Don't include pathmax.h; system.h already does it.
4525 * src/cut.c (cut_fields): Free buffer upon getndelim2 failure.
4527 2004-04-19 Jim Meyering <jim@meyering.net>
4529 * src/shred.c (isaac_seed_start) [AVOID_USED_UNINITIALIZED_WARNINGS]:
4530 Initialize a buffer to avoid warnings from tools like valgrind.
4532 * Makefile.maint (sc_trailing_blank): New rule.
4533 (syntax-check-rules): Add it.
4534 * .x-sc_trailing_blank: New file.
4536 Make pwd work even if the resulting name is so long that getcwd fails.
4537 * src/pwd.c: (path_free, path_init, path_prepend): New functions.
4538 (nth_parent, find_dir_entry, robust_getcwd): New functions.
4539 (main): First try getcwd, then, upon failure, robust_getcwd.
4541 2004-04-18 Jim Meyering <jim@meyering.net>
4543 * src/who.c (print_user): Use xrealloc here, rather than
4544 unchecked realloc. Remove anachronistic casts.
4546 * src/remove.c (full_filename_): Don't leak upon failed realloc.
4548 * src/system.h (readdir_ignoring_dot_and_dotdot): New inline function,
4550 * src/remove.c (readdir_ignoring_dotdirs): Move function to system.h,
4551 renaming it. Update uses.
4553 2004-04-17 Jim Meyering <jim@meyering.net>
4555 * configure.ac: Depend on automake-1.8.3.
4557 * src/join.c (add_file_name): Declare function to be `static'.
4558 (string_to_join_field): Likewise.
4559 * src/remove.c (ds_init, ds_free): Likewise.
4561 * Makefile.maint (sc_prohibit_jm_in_m4): New rule.
4562 (syntax-check-rules): Add to the list.
4564 2004-04-13 Paul Eggert <eggert@twinsun.com>
4566 Use page-aligned buffers whenever we bother to do I/O using buffer
4567 sizes that are tailored for the files.
4569 * src/cat.c: Include getpagesize.h.
4570 * src/copy.c: Likewise.
4571 * src/shred.c: Likewise.
4572 * src/split.c: Likewise.
4573 * src/cat.c (main): Align I/O buffers to page boundaries.
4574 * src/copy.c (copy_reg): Likewise.
4575 * src/shred.c (dopass): Likewise.
4576 * src/split.c (main): Likewise.
4577 * src/dd.c (ROUND_UP_OFFSET, PTR_ALIGN): Remove.
4578 All uses replaced by ptr_align.
4579 * src/od.c (gcd, lcm): Remove; now in system.h.
4580 * src/system.h (gcd, lcm, ptr_align): New functions, moved from od.c.
4582 2004-04-14 Jim Meyering <jim@meyering.net>
4584 Remove m4/Makefile.am: it's no longer needed, with newer automake
4585 * configure.ac (AC_CONFIG_FILES): Remove m4/Makefile.in from the list.
4586 * Makefile.am (SUBDIRS): Remove `m4' from the list.
4588 2004-04-13 Jim Meyering <jim@meyering.net>
4590 * configure.ac: Change `jm_' in AC_DEFINE'd names to `gl_'.
4592 2004-03-27 Paul Eggert <eggert@twinsun.com>
4594 * NEWS: cp -pu and mv -u (when copying) now take the destination
4595 file system time stamp resolution into account.
4596 * doc/coreutils.texi (mv invocation): Document this.
4597 (cp invocation): Document -u (it was missing!) with new behavior.
4599 * src/copy.c: Include "utimecmp.h".
4600 (copy_internal): Compare time stamps using utimecmp rather than
4603 2004-04-09 Jim Meyering <jim@meyering.net>
4605 * Makefile.maint (.re-list): New rule/file, to replace
4606 hard-coded list of header file names.
4607 (sc_system_h_headers): Use the new file.
4608 Don't look for sys2.h anymore.
4610 * src/system.h: Include new "stat-macros.h" rather than hard-coding
4611 all of its macro definitions -- the list was slightly out of date.
4612 Suggestion from Dmitry V. Levin.
4614 2004-04-08 Paul Eggert <eggert@cs.ucla.edu>
4616 * NEWS: Remove noctty flag from dd. Suggested by Philippe Troin.
4617 * doc/coreutils.texi (dd invocation): Likewise.
4618 * src/shred.c (O_NOCTTY): Remove redundant decl.
4619 * src/dd.c (flags, usage): Remove noctty flag.
4620 (main): Always use O_NOCTTY when opening files.
4622 2004-04-08 Jim Meyering <jim@meyering.net>
4624 * src/dd.c (dd_copy): Mark two diagnostics for translations.
4625 (set_fd_flags): Undo part of today's change: it's a little
4626 cleaner -- and more efficient in the common case -- to go
4627 ahead and OR in the -1 when fcntl fails.
4629 * Makefile.maint (sc_dd_max_sym_length): New target.
4630 (syntax-check-rules): Add it.
4632 * src/md5sum.c (PROGRAM_NAME) [algorithm == ALG_SHA1]:
4633 Correct spelling: s/shasum/sha1sum. Reported by Jesse Kornblum.
4635 * src/dd.c (set_fd_flags): Don't OR in -1 when fcntl fails.
4636 Rename parameter, flags, to avoid shadowing global.
4637 (LONGEST_SYMBOL): Tweak comment.
4639 2004-04-07 Paul Eggert <eggert@twinsun.com>
4641 * NEWS: New dd conv= symbols nocreat, excl, fdatasync, fsync,
4642 and new dd options iflag= and oflag=.
4643 * src/dd.c (usage): Likewise.
4644 * src/Makefile.am (dd_LDADD, shred_LDADD): Add fdatasync's lib.
4645 * src/dd.c (fdatasync) [!HAVE_FDATASYNC]: New macro.
4646 (C_NOCREAT, C_EXCL, C_FDATASYNC, C_FSYNC): New macros.
4647 (input_flags, output_flags): New vars.
4648 (LONGEST_SYMBOL): New macro.
4649 (struct symbol_value): Renamed from struct conversion. Members
4650 symbol and value renamed from convname and conversion. The
4651 symbol value is now an array instead of a pointer; this saves
4652 a bit of space and time in practice. All uses changed.
4653 (conversions): Add nocreat, excl, fdatasync, fsync. Now const.
4654 (flags): New constant array.
4655 (iflag_error_msgid, oflag_error_msgid): New constants.
4656 (parse_symbols): Renamed from parse_conversion and generalized
4657 to handle either conversion or flag symbols.
4658 (scanargs): Adjust uses of parse_symbols accodingly. Add
4659 support for iflag= and oflag=. Reject attempts to use
4660 both excl and nocreat.
4661 (set_fd_flags): New function.
4662 (dd_copy): Just return X rather than calling quit (X), since our
4663 caller invokes quit with the returned value. Add support for
4664 fdatasync and fsync.
4665 (main): Add support for iflag=, oflag=, and new conv= symbols.
4666 * src/system.h (O_DIRECT, O_DSYNC, O_NDELAY, O_NOFOLLOW,
4667 O_RSYNC, O_SYNC): Define to 0 if not already defined.
4669 * NEWS: Remove duplicate mention of BLOCKSIZE.
4671 2004-04-02 Andreas Schwab <schwab@suse.de>
4673 * src/stty.c: Add support for IUTF8 input flag.
4675 2004-04-06 Jim Meyering <jim@meyering.net>
4677 * src/system.h (makedev) [mkdev && !makedev]: Define in terms of mkdev.
4678 Interix spells it `mkdev'. Reported by Mark Funkenhauser.
4680 2004-04-04 Jim Meyering <jim@meyering.net>
4682 A specified format is no longer automatically newline terminated.
4683 If you want a newline at the end of your format, use `\n'.
4684 * src/stat.c (print_it): Don't print a newline at the end of
4686 (do_statfs): Add a newline at end of each default format string.
4688 2004-03-30 Paul Eggert <eggert@twinsun.com>
4690 * src/nohup.c (main): Adjust to new calling convention
4691 for set_cloexec_flag.
4693 2004-03-31 Jim Meyering <jim@meyering.net>
4695 * tests/Fetish.pm (run_tests): Remove `.orig' file.
4696 Remove debugging diagnostic.
4698 Specifying an invalid --width=N (-w) or --gap-size=N (-g)
4699 would not elicit an error.
4700 * src/ptx.c: Include "xstrtol.h" and "quotearg.h".
4701 (main): Don't use atoi. Use xstrtoul instead.
4703 2004-03-30 Jim Meyering <jim@meyering.net>
4705 * Makefile.maint (sc_prohibit_atoi_atof): New rule.
4706 (syntax-check-rules): Add it.
4707 * .x-sc_prohibit_atoi_atof: New file.
4709 2004-03-29 Jim Meyering <jim@meyering.net>
4711 * tests/du/files0-from: Use new OUT_SUBST directive, so that this
4712 test is not sensitive to system-dependent block size differences.
4713 Prompted by a report of Solaris 8 differences from Paul Eggert.
4715 * tests/Fetish.pm: Accept new directives: OUT_SUBST, ERR_SUBST.
4716 Rename `%tmp' to `%actual'. Reverse order of last two args to
4717 _compare_files (to $actual, $expected) so as to match declaration.
4719 2004-03-28 Paul Eggert <eggert@twinsun.com>
4721 Fix some gotchas encountered when porting to Solaris 8, using
4722 the Forte 6u2 compiler.
4724 * src/hostname.c [HAVE_SETHOSTNAME && !defined sethostname]:
4725 Declare sethostname, since no Solaris header does it.
4726 * src/who.c: Include "vasprintf.h", for asprintf.
4728 2004-03-28 Jim Meyering <jim@meyering.net>
4731 * src/du.c (process_file): Don't record dev/inode for directories.
4733 Under some circumstances, without -c, du would mistakenly count the
4734 space of hard-linked files, not just the first one it encountered.
4735 Reported by Anthony Thyssen.
4736 * src/du.c (du_files): Don't ever clear the set of `seen' dev/inodes.
4738 * src/du.c: Rename global `print_totals' to `print_grand_total'.
4740 * src/du.c (main): Rearrange filtering loop to be a tiny bit
4743 * src/chown-core.c: Don't include savedir.h -- no longer needed.
4744 * src/chmod.c: Likewise.
4746 2004-03-25 Jim Meyering <jim@meyering.net>
4748 * src/du.c (main): Remove now-unused declaration of `i'.
4750 2004-03-24 Paul Eggert <eggert@twinsun.com>
4752 * src/du.c (main): Filter out file names of length zero before
4753 invoking fts, so that they don't cause fatal errors.
4755 2004-03-25 Jim Meyering <jim@meyering.net>
4757 * tests/du/files0-from (zero-len): Add a test for the above.
4759 2004-02-25 Paul Eggert <eggert@twinsun.com>
4761 * NEWS: New environment var BLOCKSIZE.
4762 * lib/human.c (humblock): Support BLOCKSIZE as well as BLOCK_SIZE.
4763 * tests/envvar-check: Test for it. Factor the code to simplify it.
4765 2004-03-23 Paul Eggert <eggert@twinsun.com>
4767 * NEWS: Shorten the du --files0-from announcement, and say
4768 "NUL-terminated" rather than "NUL-separated".
4769 * src/du.c (EXPECTED_BYTES_PER_FILE_NAME, DEFAULT_PROJECTED_N_FILES):
4771 (usage): Say "NUL-terminated", not "NUL-separated".
4772 (main): Check for I/O error when istream is closed.
4773 Allow --files0-from=F even if F is empty; this specifies no files.
4774 (du_files): Now that we allow the list of files to be empty,
4776 * tests/du/files0-from: Adjust to above changes to src/du.c.
4778 2004-03-24 Jim Meyering <jim@meyering.net>
4780 * tests/tail-2/assert: Avoid race condition that could cause
4781 spurious failure. Based on a patch from Andreas Schwab.
4783 2004-03-23 Jim Meyering <jim@meyering.net>
4785 * src/du.c (main): Free the hash table, too.
4787 2004-03-22 Jim Meyering <jim@meyering.net>
4789 * man/Makefile.am (.x.1): Remove --info-page= option, reverting
4790 the change of 2004-01-22. I can no longer reproduce the problem
4791 that prompted that change, and `info coreutils pr' would display the
4792 `printing text' section of the manual, not the one on `pr invocation'.
4794 * tests/du/files0-from (nul-1, nul-2): Adjust expected diagnostics
4795 to match corrected output.
4797 * src/du.c: Include "readtokens0.h" rather than "readtokens.h".
4798 (main): Use readtoken0 functions rather than readtokens.
4799 Don't use errno when diagnosing readtokens0 failure.
4800 Fix off-by-one error in the token number reported in a diagnostic.
4801 (du_files): Return bool, rather than int.
4802 (main): Call readtokens0_free.
4804 2004-03-21 Jim Meyering <jim@meyering.net>
4806 * src/remove.c (ds_free): Plug a small leak.
4808 * tests/Fetish.pm: Fix typo in comment.
4810 2004-03-07 Jim Meyering <jim@meyering.net>
4812 * NEWS: du accepts a new option --files0-from=FILE, where FILE
4813 contains a list of NUL-separated file names.
4815 * src/du.c: Include "readtokens.h".
4816 (usage): Describe the new option, and adjust the `Usage':
4817 with this option, no FILE may be specified on the command line.
4818 (main): Handle the new option.
4820 * tests/du/files0-from: New tests, for the above.
4821 * tests/du/Makefile.am (TESTS): Add files0-from.
4823 * src/factor.c (do_stdin): Reflect changes in use of readtoken.
4824 * src/tsort.c (tsort): Likewise.
4826 2004-02-29 Paul Eggert <eggert@twinsun.com>
4828 * NEWS: Add support for a new notation @N to get_date to represent
4829 the time stamp with numeric value N. Improve support for
4830 fractional time stamps. date's -d and -f options now accept them.
4831 Likewise for touch -t. date has a new option --iso-8601=ns.
4833 * doc/coreutils.texi (touch invocation):
4834 Describe use of fractional seconds.
4835 (date invocation, Options for date): Likewise.
4836 * doc/getdate.texi (General date syntax, Time of day items): Likewise.
4837 * doc/coreutils.texi (date invocation): Mention effect of LC_TIME.
4838 (Options for date): Describe new --iso-8601=ns option.
4840 * doc/getdate.texi: Add copyright notice. Change getdate to
4841 get_date when talking about the function name.
4842 (Seconds since the Epoch): New section, containing the time_t
4843 info moved from Date input formats section, along with new
4844 info about the @ syntax. Mention negative time stamps,
4845 fractional time stamps, and leap seconds.
4846 (General date syntax): Modernize examples a bit to reflect new
4848 (General date syntax, Relative items in date strings):
4849 Use ' rather than " to quote formats.
4850 (Time of day items): Add an example with fractional seconds.
4851 Describe fractional-second syntax.
4853 * src/Makefile.am (touch_LDADD): New macro, since `touch' now
4854 needs clock_gettime.
4856 * src/date.c (enum Time_spec): New enum TIME_SPEC_NS.
4857 (time_spec_string, time_spec, show_date): Support it.
4858 (usage): Remove description of -ITIMESPEC, as it's obsolete and
4859 confusing. Mention --iso-8601=ns.
4860 (batch_convert): getline returns ssize_t, not int.
4862 * src/touch.c (newtime): Now an array of two timespecs, one
4863 for access and one for modification.
4864 (ref_stats): Remove.
4865 (get_reldate): Use get_date's parameter profile.
4866 (touch, main): Adjust to above changes.
4867 (main): Work even if tm_year == INT_MAX (so long as long int is wider).
4868 Use gettime instead of gettimeofday, for new get_date signature.
4870 * tests/date/Test.pm (test_vector): New tests epoch, ns-10, ns-max32,
4873 2004-03-15 Jim Meyering <jim@meyering.net>
4875 * Makefile.maint (alpha beta major): `Make' the emit_upload_commands
4876 target before updating $(prev_version_file).
4878 * tests/misc/date-sec: New file, to test for just-fixed bug in date.
4879 See today's change in lib/getdate.y.
4880 * tests/misc/Makefile.am (TESTS): Add date-sec.
4882 2004-03-14 Jim Meyering <jim@meyering.net>
4884 * announce-gen (print_changelog_deltas): Use `.sig' suffix for
4885 signature files, not `.asc'. Reported by angico@yahoo.com.
4887 2004-03-13 Jim Meyering <jim@meyering.net>
4889 * src/cp.c (do_copy): Tweak wording in a diagnostic.
4890 Suggestion from Karl Berry.
4891 Include "quoatearg.h".
4892 (do_copy): Use quotearg_colon (not quote) for diagnostics
4893 that begin with `"%s:'.
4895 * src/nl.c (usage): Specify that nl uses _basic_ regular expressions.
4896 Suggestion from Dan Jacobson.
4898 2004-03-12 Jim Meyering <jim@meyering.net>
4902 Sometimes, when source and destination partition are different,
4903 mv mistakenly fails to preserve a hard link. Reported by IIDA Yosiaki.
4905 * src/copy.c: When moving a set of N hard-linked files between
4906 partitions, via two or more command line arguments where the
4907 command line argument containing the Nth link contains no other
4908 link to that same file, mv would mistakenly copy the file, rather
4909 than hard-linking it to the other(s). That happens because when the
4910 final link is processed, its link count has been reduced to 1 since
4911 the other links have been `copied' to the destination partition
4912 and the source links have been removed.
4913 (copy_internal): When in move mode, use the source dev/inode
4914 pair to look up destination name even when st_nlink == 1.
4915 * src/cp-hash.c (src_to_dest_lookup): New function.
4916 * src/cp-hash.h (src_to_dest_lookup): Add prototype.
4917 * tests/mv/part-hardlink: New file. Test for the above fix.
4918 * tests/mv/Makefile.am (TESTS): Add part-hardlink.
4920 * announce-gen: Sync with autoconf.
4922 * tests/ls/time-1: Exit 77 (not 1) if we can't set up for the test.
4923 This was triggered on a Linux-2.2.19 system using a file system
4924 NFS-mounted from some sort of Sun.
4926 2004-03-11 Jim Meyering <jim@meyering.net>
4928 * Use automake-1.8.3. Regenerate dependent files.
4930 2004-03-10 Jim Meyering <jim@meyering.net>
4932 * tests/du/deref-args: Also convert sizes in the 70-79 kB range,
4933 so that this test works with SELinux-enabled systems.
4934 Based on a patch from Tim Waugh.
4936 `join -1 x' would give a misleading diagnostic
4937 * src/join.c (string_to_join_field): Report that a non-numeric field
4938 number is invalid, rather than `so large that it is not representable'.
4939 * tests/join/Test.pm (invalid-j): New partial test for the above fix.
4941 2004-03-06 Jim Meyering <jim@meyering.net>
4943 cp --sparse=always sparse-image-file.img /dev/hda1 could
4944 produce an invalid copy on the destination device.
4946 * src/copy.c (copy_reg): Even with --sparse=always, try to
4947 make `holes' only if the destination is a regular file.
4948 Reported by Szakacsits Szabolcs.
4950 2004-03-03 Paul Eggert <eggert@twinsun.com>
4952 * src/nohup.c (main): Don't invoke set_cloexec_flag with
4953 a file descriptor of -1.
4955 2004-03-02 Dmitry V. Levin <ldv@altlinux.org>
4957 * src/nohup.c: Include "cloexec.h".
4958 (main): Set the copy of stderr to close on exec.
4960 2004-03-01 Paul Eggert <eggert@twinsun.com>
4962 * configure.ac: Include <signal.h> when checking for strsignal,
4963 sys_siglist, and friends. Problem reported by Tony Leneis in
4964 <http://mail.gnu.org/archive/html/bug-coreutils/2004-02/msg00136.html>.
4966 2004-02-25 Paul Eggert <eggert@twinsun.com>
4968 * tests/du/deref-args, tests/du/exclude, tests/du/slash:
4969 * tests/du/trailing-slash: Run envvar-check in case BLOCK_SIZE
4972 2004-02-23 Paul Eggert <eggert@twinsun.com>
4974 * NEWS: Document how chown's USER.GROUP argument is now parsed.
4976 2004-02-23 Jim Meyering <jim@meyering.net>
4978 * src/seq.c (usage): Remove stray space after \n in --help output.
4980 2004-02-22 Jim Meyering <jim@meyering.net>
4982 * src/du.c (usage): Separate -H and --si. Say that the meaning
4983 of -H will soon change to that of --dereference-args (-D).
4985 2004-02-21 Jim Meyering <jim@meyering.net>
4987 * src/comm.c (usage): Tell what comm does when there are no options.
4988 Reword in terms of FILE1 and FILE2 rather than `left file' and
4989 `right file'. Suggestion from Dan Jacobson.
4991 2004-02-15 Paul Eggert <eggert@twinsun.com>
4993 Fix some POSIX-conformance bugs in expr.
4995 * NEWS: document the following changes to src/expr.c.
4996 * doc/coreutils.texi (expr invocation): Likewise.
4997 Document what forms integers may take, and say "integer"
4998 consistently instead of "number". Warn about operands
4999 that "expr" can misinterpret, and how to work around the
5001 * src/expr.c (eval, eval7, eval6, eval5, eval4, eval3, eval2, eval1):
5002 Accept a bool argument specifying whether to evaluate the
5003 expression. This is to allow short-circuit evaluation. All
5005 (null): Report that a string is zero even if it has
5006 a form like "-0" or "00".
5007 (eval1, eval): Use short-circuit evaluation for | and &.
5008 (eval): Return 0 if both arguments are null or zero, instead
5009 of returning the first argument.
5010 * tests/expr/basic: Add some tests for the above.
5012 2004-02-17 Jim Meyering <jim@meyering.net>
5016 `make check' from a build inside a chroot environment would fail
5017 * tests/help-version: Specify an argument (`/') for df, in the
5018 unusual event that there is no valid entry in /etc/mtab.
5019 Likewise for id: add the -u option, so we don't get spurious
5020 failures when there are no user or group names.
5023 * src/sort.c (usage) [-u]: Add punctuation so that the description in
5024 the help2man-generated (line-joined) man page is more readable.
5025 Reported by Tim Waugh.
5026 [-T]: Add a semicolon, for the same reason.
5028 2004-02-15 Jim Meyering <jim@meyering.net>
5030 * Makefile.am (dist-hook): Qualify target with $(srcdir)/ prefix.
5032 2004-02-11 Jim Meyering <jim@meyering.net>
5034 * tests/Makefile.am.in ($(srcdir)/Makefile.am): Use more portable
5035 $(srcdir)/../Makefile.am.in, rather than $<.
5036 Suggestion from Michael Elizabeth Chastain.
5038 2004-02-10 Jim Meyering <jim@meyering.net>
5040 * config/install-sh: Make this script executable.
5041 * Makefile.am (dist-hook): New target, to ensure that config/install-sh
5042 is executable. Otherwise, on systems that lack a suitable install
5043 binary, `make install' would fail, because of the way this script
5044 is invoked (without `$SHELL ' prefix).
5045 Reported by Bob Proulx.
5047 2004-02-08 Jim Meyering <jim@meyering.net>
5051 * tests/rm/rm5: Avoid triggering a bug in OSF/Tru64's sed
5052 that would cause an unwarranted test failure.
5053 * tests/rm/rm3: Likewise.
5055 2004-02-07 Jim Meyering <jim@meyering.net>
5057 Remove xstat function pointer member. The way it was used was not
5058 portable, since some systems (OSF V5.1, Solaris 2.5.1) provide static
5059 inline `stat' and `lstat' functions, thus making the tests of
5060 `xstat == lstat' in copy.c always fail.
5061 * src/copy.h (struct cp_options) [xstat]: Remove member.
5063 * src/copy.c (copy_dir): Set `.dereference' member, not .xstat.
5064 (copy_internal): Use `XSTAT (x, ...)' in place of `*(x->xstat) (...)'.
5065 Use `x->dereference == DEREF_NEVER' in place of `x->xstat == lstat'.
5066 (valid_options): Remove now-obsolete FIXME comments.
5068 * src/cp.c (re_protect): Use `XSTAT (x, ...)' in place of
5069 `*(x->xstat) (...)'.
5070 (do_copy): Declare/use local xstat rather than x->xstat.
5071 (main): Remove code that set x.xstat.
5072 * src/mv.c (cp_option_init): Don't initialize xstat member.
5073 * src/install.c (cp_option_init): Likewise.
5075 * Makefile.cfg (gnu_ftp_host-alpha, etc.): Un-factor .gnu.org suffix,
5076 so that emit_upload_commands can use these variables, too.
5078 2004-02-06 Jim Meyering <jim@meyering.net>
5080 * tests/rm/deep-1: Remove `du' stack space test.
5081 Apparently, `ulimit -s N' isn't portable enough.
5082 This test will be restored (with a guard against losing ulimit)
5083 in its own file later.
5085 * tests/rm/deep-1 (deep): Remove progress-style diagnostics,
5086 since this test doesn't take long enough to merit them.
5087 Run du on $tmp (the containing dir), not $deep, the full path to leaf.
5089 * Makefile.maint (signatures): Remove definition.
5090 Now, automake's gnupload handles this.
5091 (%.sig: %): Remove now-unused rule.
5092 (rel-files): Use automake's $(DIST_ARCHIVES), rather than
5093 `$(distdir).tar.bz2 $(distdir).tar.gz'.
5094 (emit-upload-commands): Adjust to use gnupload.
5096 2004-02-05 Jim Meyering <jim@meyering.net>
5098 * src/system.h (ST_TIME_CMP_NS, ST_TIME_CMP): Remove definitions.
5099 (ATIME_CMP, CTIME_CMP, MTIME_CMP, TIMESPEC_NS): Likewise.
5100 Now, those are all defined in timespec.h.
5103 * src/date.c: Don't include timespec.h, now that system.h does it.
5105 2004-02-02 Paul Eggert <eggert@twinsun.com>
5107 Don't dump core if localtime returns NULL (possible on
5108 hosts with 64-bit time_t and 32-bit int).
5109 * src/date.c: Include "inttostr.h".
5110 (batch_convert, main):
5111 If time conversion fails, exit with nonzero status.
5112 (show_date): Return int to report conversion failure.
5113 Print the time as an int if localtime fails.
5114 * src/uptime.c: Print "??" if the current clock can't
5115 be converted by localtime. This won't happen until the year
5116 2*31 + 1900, but we don't want to dump core even if the current
5117 clock has the wrong value.
5119 * src/stat.c: Include "inttostr.h".
5120 (human_time): Print the date/time as a number of seconds since the
5121 epoch if it can't be converted by localtime. This is better than
5122 just saying "invalid", and is consistent with what "ls" does.
5123 Don't dump core if the year has more than 48 digits; this isn't
5124 possible on any contemporary host, but we might as well do it right.
5126 2004-01-31 Paul Eggert <eggert@twinsun.com>
5128 * src/stat.c (human_time): Accept time rather than
5129 pointer-to-const-time parameter, for clarity. All callers changed.
5131 2004-02-02 Jim Meyering <jim@meyering.net>
5133 * src/stat.c (do_stat): Remove extra trailing newline from
5134 default formats. Reported by Nelson H. F. Beebe.
5136 Print actual fractional seconds in time stamps, not just `.00000000'.
5137 * src/stat.c (human_time): Add and use new parameter, t_ns.
5138 (print_stat): Update callers.
5139 * src/ls.c (TIMESPEC_NS): Remove definition.
5140 * src/system.h (TIMESPEC_NS): Define here, instead, now that stat.c
5141 also uses this macro.
5142 Nelson H. F. Beebe noticed that ls --full-time printed nonzero
5143 fractional seconds for files on an XFS file system, but that stat's
5144 fractional seconds were always zero.
5146 2004-01-28 Paul Eggert <eggert@twinsun.com>
5148 * src/seq.c (print_numbers): Use 'double' for loop index, not
5149 'int', to avoid problems with integer overflow. On almost all
5150 machines 'double' works in every case where 'int' works, and
5151 it works on other cases besides.
5153 2004-01-27 Jim Meyering <jim@meyering.net>
5155 * src/seq.c (usage): Mention that if INCREMENT is omitted,
5156 it defaults to 1, even when FIRST is larger than LAST.
5157 Reword so as not to exclude the possibility that INCREMENT be zero.
5159 2004-01-25 Jim Meyering <jim@meyering.net>
5163 * Makefile.maint (signatures): Comment out definition.
5165 2004-01-23 Jim Meyering <jim@meyering.net>
5167 * Makefile.maint (header_regexp): Add exitfail.
5169 * man/Makefile.am (EXTRA_DIST): Add help2man.
5170 Reported by Nelson H. F. Beebe.
5172 * man/Makefile.am (.x.1): Prefix help2man invocation with `$(PERL) --'
5173 so it works on systems with Perl installed somewhere other than in
5176 * src/paste.c (paste_parallel): Declare local, chr, to be of type
5177 `int', not `char', since it must hold EOF. This bug would make
5178 paste infloop on some systems. Test failures reported by
5179 Nelson H. F. Beebe and Christian Krackowizer.
5181 2004-01-22 Jim Meyering <jim@meyering.net>
5183 * tests/rmdir/fail-perm: New file. Test for just-fixed rmdir bug.
5184 * tests/rmdir/Makefile.am (TESTS): Add fail-perm.
5186 * man/help2man: Fix it so using --info-page='coreutils PROG' works.
5187 * man/Makefile.am (.x.1): Invoke our own (tweaked) copy of help2man.
5188 Use --info-page='coreutils PROG' option.
5189 Now, readlink.1 refers the user to `info coreutils readlink'
5190 rather than to `info readlink'. Reported by Matt Swift.
5192 2004-01-21 Paul Eggert <eggert@twinsun.com>
5194 Exit status cleanup.
5196 * src/basename.c (usage): Use EXIT_SUCCESS, not 0, for clarity.
5197 * src/cat.c, src/chgrp.c, src/chmod.c, src/chown.c, src/chroot.c,
5198 * src/cksum.c, src/comm.c, src/cp.c, src/csplit.c, src/cut.c,
5199 * src/date.c, src/dd.c, src/df.c, src/dircolors.c, src/dirname.c,
5200 * src/du.c, src/echo.c, src/env.c, src/expand.c, src/expr.c,
5201 * src/factor.c, src/fmt.c, src/fold.c, src/head.c, src/hostid.c,
5202 * src/hostname.c, src/id.c, src/install.c, src/join.c, src/kill.c,
5203 * src/link.c, src/ln.c, src/logname.c, src/ls.c, src/md5sum.c,
5204 * src/mkdir.c, src/mkfifo.c, src/mknod.c, src/mv.c, src/nice.c,
5205 * src/nl.c, src/nohup.c, src/od.c, src/paste.c, src/pathchk.c,
5206 * src/pinky.c, src/pr.c, src/printenv.c, src/printf.c, src/pwd.c,
5207 * src/rm.c, src/rmdir.c, src/seq.c, src/setuidgid.c, src/shred.c,
5208 * src/sleep.c, src/sort.c, src/split.c, src/stat.c, src/stty.c,
5209 * src/su.c, src/sum.c, src/sync.c, src/tac.c, src/tail.c, src/tee.c,
5210 * src/test.c, src/touch.c, src/tr.c, src/tsort.c, src/tty.c,
5211 * src/uname.c, src/unexpand.c, src/uniq.c, src/unlink.c, src/uptime.c,
5212 * src/users.c, src/wc.c, src/who.c, src/whoami.c, src/yes.c: Likewise.
5214 * src/cat.c (usage): Don't bother normalizing exit status
5215 since the arg is already the correct exit status now.
5216 * src/cksum.c, src/comm.c, src/csplit.c, src/cut.c,
5217 * src/dircolors.c, src/expand.c, src/fmt.c, src/fold.c, src/head.c,
5218 * src/join.c, src/md5sum.c, src/nl.c, src/od.c, src/paste.c,
5219 * src/pr.c, src/split.c, src/sum.c, src/tac.c, src/tail.c, src/tr.c,
5220 * src/tsort.c, unexpand.c, src/src/uniq.c, src/src/wc.c: Likewise.
5222 * src/chown.c (main): Removed unused local 'fail'.
5224 * src/chroot.c (CHROOT_FOUND_BUT_CANNOT_INVOKE, CHROOT_FAILURE):
5227 * src/chroot.c (main): Initialize exit_failure to EXIT_FAIL.
5228 * src/env.c, src/nice.c, src/su.c: Likewise.
5229 * src/nohup.c (main): Likewise, to NOHUP_FAILURE.
5230 * src/setuidgid.c (main): Likewise, to SETUIDGID_FAILURE.
5231 * src/expr.c (main): Use initialize_exit_failure rather than
5232 setting exit_failure directly; this optimizes away redundant
5234 * src/printenv.c, src/sort.c, src/test.c, src/tty.c: Likewise.
5236 * src/chroot.c (main): Exit with status 1 rather than 127
5237 if chroot itself fails, as per documentation.
5239 * src/chroot.c (main): Use EXIT_ENOENT and EXIT_CANNOT_INVOKE
5240 rather than roll-your-own symbols or integers.
5241 * src/env.c (main): Likewise.
5242 * src/nohup.c (main): Likewise.
5243 * src/su.c (run_shell): Likewise.
5245 * src/cp.c (exit_status): Remove static var....
5246 (main): Making it local here instead. Use =, not |=, to set it.
5248 * src/cut.c (FATAL_ERROR, main): Exit with status EXIT_FAILURE,
5250 * src/date.c (batch_convert, main): Likewise.
5251 * src/dd.c (dd_copy): Likewise.
5252 * src/pr.c (first_last_page, main, getoptarg): Likewise.
5253 * src/tr.c (main): Likewise.
5254 * src/date.c (main): Don't assume EXIT_FAILURE == 1, as
5255 POSIX doesn't require it.
5256 * src/dd.c (write_output, skip, dd_copy): Likewise.
5257 * src/df.c (main): Likewise.
5258 * src/id.c (main): Likewise.
5259 * src/install.c (main): Likewise.
5260 * src/ln.c (main): Likewise.
5261 * src/ls.c (main): Likewise.
5262 * src/mv.c (main): Likewise.
5263 * src/shred.c (main): Likewise.
5265 * src/env.c (main): Exit with status 1, not 2, on errors detected
5267 * src/hostname.c (main): Likewise.
5268 * src/nl.c (main): Likewise.
5269 * src/stty.c (main): Likewise.
5271 * src/expr.c (EXPR_FAILURE): Renamed from EXPR_ERROR, for
5272 consistency with the other programs' naming conventions.
5275 * src/factor.c (main): Do not report a usage error simply
5276 because stdin has bad numbers.
5278 * src/id.c (problems): Now a boolean int, not a counter,
5279 so that we don't have to worry about int overflow. All uses changed.
5280 * src/touch.c (err): Likewise.
5282 * src/md5sum.c (main): Use int, not size_t, to store boolean int.
5284 * src/mkfifo.c (main): Exit with status 1, not 4, if not implemented.
5285 * src/mknod.c: Likewise.
5287 * src/nice.c (main): Exit with status EXIT_FAIL, not EXIT_FAILURE,
5288 on error; this is in case EXIT_FAILURE is unusual.
5289 * src/su.c (main): Likewise.
5291 * src/nohup.c (NOHUP_FOUND_BUT_CANNOT_INVOKE): Remove; all uses
5292 changed to EXIT_CANNOT_INVOKE.
5294 * src/printenv.c (PRINTENV_FAILURE): New constant.
5295 (main): Exit with status PRINTENV_FAILURE, not EXIT_FAILURE, on
5296 command-line syntax problems.
5298 * src/rmdir.c (remove_parents): Don't set 'fail' to a negative number.
5299 (main): Avoid integer overflow when seeing whether errors occurred.
5301 * src/seq.c (print_numbers): Now returns void, not (zero) int.
5302 All callers changed.
5303 (main): Remove unused local variable 'errs'. Always exit successfully
5304 if we reach the end.
5306 * src/setuidgid.c (SETUIDGID_FAILURE): Renamed from FAIL_STATUS,
5307 for consistency with other programs here. All uses changed.
5308 (main): Use 'error' to exit rather than invoking 'exit' here.
5310 * src/sort.c: Don't include <assert.h>.
5311 (SORT_OUT_OF_ORDER, SORT_FAILURE): Now enums, not macros.
5312 (usage): Don't use 'assert'.
5313 (main): Remove redundant assignment to exit_failure.
5315 * src/system.h (EXIT_FAIL, EXIT_CANNOT_INVOKE, EXIT_ENOENT):
5317 (initialize_exit_failure): New inline function.
5318 Include exitfail.h here, since we refer to exit_failure.
5319 All callers changed to not include exitfail.h.
5321 * src/tty.c (TTY_FAILURE, TTY_WRITE_ERROR): New enum values;
5322 substitute them for the corresponding integer constants.
5324 * tests/help-version (expected_failure_status_date): Remove, as
5325 'date' is now normal.
5326 (expected_failure_status_nohup): New var.
5328 2004-01-21 Jim Meyering <jim@meyering.net>
5330 * tests/touch/relative: Remove `command' syntax.
5331 Thanks to Nelson H. F. Beebe and Paul Eggert.
5333 * tests/touch/relative: Test only year/month/day, not hours/min/sec,
5334 so as to avoid problems with systems using TAI clocks.
5335 Although it's no longer necessary, set TZ=UTC0 also for the
5336 initial touch command. Reported by Paul Jarc here:
5337 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/1504
5339 2004-01-20 Diego Biurrun <diego@biurrun.de>
5341 * src/dircolors.hin: Add .mov to the list of media files.
5343 2004-01-19 Paul Eggert <eggert@twinsun.com>
5345 * tests/touch/relative: Use TZ=UTC0, not TZ=utc (which isn't
5346 portable). Problem reported by Christian Krackowizer. Also, use
5347 +0000 rather than +0 to specify a time zone, as the documentation
5348 requires four digits.
5350 2004-01-19 Jim Meyering <jim@meyering.net>
5352 * tests/mv/hard-4: Run envvar-check in case SIMPLE_BACKUP_SUFFIX is set.
5353 * tests/mv/backup-is-src: Likewise.
5354 Problem reported by Peter Horst
5356 2004-01-17 Jim Meyering <jim@meyering.net>
5358 * announce-gen (print_changelog_deltas): Use .sig suffix, not .asc.
5362 2003-12-15 Paul Eggert <eggert@twinsun.com>
5364 * NEWS, doc/coreutils.texi: touch -r and -d can now both be specified,
5365 with -r specifying the origin for -d.
5366 * src/touch.c (flexible_date): Remove static var.
5367 (get_reldate): New function.
5368 (main): Use it, to implement this new behavior.
5370 2004-01-16 Jim Meyering <jim@meyering.net>
5372 * tests/touch/relative: New test for the above.
5373 * tests/touch/Makefile.am (TESTS): Add relative.
5375 2004-01-13 Jim Meyering <jim@meyering.net>
5377 * src/system.h: Include contents of sys2.h.
5378 * src/sys2.h: Remove file.
5379 * src/Makefile.am (noinst_HEADERS): Remove sys2.h.
5381 * Use automake-1.8.2. Regenerate dependent files.
5383 * Update to gettext-0.13.1.
5384 * configure.ac: Use gettext-0.13.1.
5385 * .x-sc_space_tab: Add m4/po.m4 to the list of exceptions.
5387 2004-01-12 Jim Meyering <jim@meyering.net>
5389 * Makefile.maint (%.sig): Use .sig suffix rather than .asc.
5391 * Makefile.maint (po-check): Ensure that cvsu works before using it.
5392 Reported by Alexandre Duret-Lutz.
5394 * src/tail.c (main): Warn about following stdin only when it's a tty.
5396 * configure.ac: Use gl_DEFAULT_POSIX2_VERSION.
5398 2004-01-10 Jim Meyering <jim@meyering.net>
5400 * tests/misc/stat-fmt: Use backticks, not `$()' notation.
5402 2004-01-09 Jim Meyering <jim@meyering.net>
5404 * configure.ac: Quote underquoted `jm_DUMMY_1' to avoid new warning.
5406 2004-01-08 Jim Meyering <jim@meyering.net>
5408 * src/stat.c (human_fstype): Use %lx, not %x format for `unsigned long'.
5409 From Andreas Schwab.
5411 * tests/Makefile.am (TESTS_ENVIRONMENT): Remove `/vg' (prerelease test
5412 remnant) from PATH component. That would cause tests in this directory
5413 not to run the just-built binaries, but rather whatever happened
5414 to be in one's PATH. Reported by Christian Krackowizer.
5416 2004-01-04 Jim Meyering <jim@meyering.net>
5418 * src/csplit.c (new_control_record): Use x2nrealloc
5419 rather than xrealloc.
5421 * src/cp.c (re_protect): Use ASSIGN_STRDUPA rather than
5423 (make_path_private): Likewise.
5425 2004-01-03 Jim Meyering <jim@meyering.net>
5427 * src/paste.c: Use `bool' (not int) as the type for a few
5429 (collapse_escapes): Rewrite to set globals rather than modifying
5431 Use size_t (not int) for all counters and related index variables.
5432 (paste_parallel): Remove needless complexity of
5433 using xrealloc in the loop; just allocate the buffers up front.
5434 Free the two temporary buffers.
5435 Move declarations of locals `down' into scope where used.
5436 (paste_serial): Remove `register' attributes.
5437 (main): Simplify delim-related code.
5438 Free `delims', now that it's malloc'd.
5440 2004-01-02 Jim Meyering <jim@meyering.net>
5442 * src/chroot.c: Include "quote.h".
5443 (CHROOT_FOUND_BUT_CANNOT_INVOKE, CHROOT_FAILURE): Define.
5444 (main): Exit with status of 127, not 1, for too-few-args,
5445 chroot failure, or chdir failure.
5446 Give a better diagnostic upon execvp failure.
5448 * src/du.c (usage): Mention that, with its current meaning,
5451 * src/tail.c (main): Warn about following stdin when it's a tty.
5452 Fail when following by name but no names are specified.
5454 2003-12-30 Jim Meyering <jim@meyering.net>
5456 * src/fold.c (main): Use memcpy, not strcpy.
5458 * src/copy.c (copy_internal): Use ASSIGN_STRDUPA rather than
5461 2003-12-28 Jim Meyering <jim@meyering.net>
5463 * src/unexpand.c (n_tabs_allocated): New global.
5464 (add_tabstop): Use x2nrealloc rather than xrealloc.
5465 * src/expand.c: Likewise.
5467 * tests/misc/expand: New file.
5468 * tests/misc/Makefile.am (TESTS): Add expand.
5470 * src/sort.c (add_temp_dir): Use x2nrealloc rather than xrealloc.
5471 (fillbuf): Use x2nrealloc rather than xrealloc.
5472 (sort): Use xnmalloc rather than xmalloc.
5475 2003-12-27 Jim Meyering <jim@meyering.net>
5477 * src/tee.c (tee): Use xnmalloc rather than xmalloc.
5479 2003-12-29 Paul Eggert <eggert@twinsun.com>
5481 * NEWS: Remove support for join -j1 FIELD, -j2 FIELD, and -o LIST1
5482 LIST2 in POSIX 1003.1-2001 hosts, as required by POSIX.
5484 * doc/coreutils.texi (join invocation): Remove documentation
5485 accordingly. Document that -t makes all separators significant.
5487 * src/join.c: Include posixver.h.
5488 (obsolete_usage): New var.
5489 (longopts): Put obsolete options first.
5490 (OBSOLETE_LONG_OPTIONS): New constant.
5491 (get_option, add_file_name): New functions.
5492 (main): Use them to support new behavior.
5493 (usage): Remove documentation for -j1 FIELD and -j2 FIELD.
5494 Do not mark -j FIELD as obsolescent; it is longstanding
5495 UNIX tradition and is a valid extension to POSIX.
5497 * tests/join/Test.pm (tv): Avoid obsolete -o usage.
5499 2003-12-28 Paul Eggert <eggert@twinsun.com>
5501 * src/join.c (add_field_list): Don't use alloca with unbounded
5502 size; just modify the argument, which is no longer const *.
5504 Various other minor cleanups, mostly to avoid the need for casts.
5506 (extract_field): Renamed from ADD_FIELD, as it's now a function.
5508 (struct field.beg): Now char *, not unsigned char const *. All
5509 uses changed. It shouldn't be const since xmemcoll writes on its
5511 (extract_field): Likewise, for 2nd arg.
5512 (keycmp): Remove now-unnecessary cast of xmemcoll args.
5514 (is_blank): New function, to avoid need to cast arg to unsigned char.
5515 (extract_field): Use it.
5517 (xfields): Rewrite pretty much from scratch.
5519 (hard_LC_COLLATE): Now bool, not int.
5520 (get_line, getseq, add_field_list): Now returns bool, not int.
5521 (decode_field_spec, add_field_list): Return true on success (not
5522 false), for consistency with the rest of the code. All uses changed.
5524 (tab): Now char, not unsigned char. This wasn't 100% necessary
5525 but is slightly cleaner.
5526 (prjoin): Hoist (tab ? tab : ' ') expression, to help the compiler.
5528 (empty_filler): Now const *.
5530 (make_blank): Remove; wasn't needed. Remove all calls.
5531 (main): Don't set uni_blank.nfields; zero is fine.
5533 2003-12-27 Jim Meyering <jim@meyering.net>
5535 * src/join.c: Include "quote.h".
5536 (min, max): Remove definitions.
5537 Make a few function parameters and corresponding
5538 locals `const'. Use bool for boolean variables.
5539 Use size_t (not int) for all counters and related index variables.
5540 (prjoin): Remove now-useless assertion.
5541 (string_to_join_field): New function.
5542 (main): Accept join fields as large as SIZE_MAX.
5543 (keycmp): Rename `min' to MIN and max to MAX.
5545 2003-12-26 Jim Meyering <jim@meyering.net>
5547 fold -s didn't work on e.g., alpha-based systems.
5548 * src/fold.c (fold_file): Adjust types (int->size_t) so that using
5549 x2nrealloc works properly on systems with differing sizes for int
5550 and size_t. Reported by Nelson Beebe.
5552 * src/fold.c: Use `bool' (not int) as the type for a few
5555 2003-12-23 Paul Eggert <eggert@twinsun.com>
5557 * src/ls.c (length_of_file_names_and_frills):
5558 Remove forward decl; not needed.
5559 (print_file_name_and_frills, length_of_file_name_and_frills):
5560 With -m, don't output spaces before inum or size.
5561 (print_with_commas): Don't output space just before newline.
5563 2003-12-24 Jim Meyering <jim@meyering.net>
5565 * tests/ls/Makefile.am (TESTS): Add m-option.
5566 * tests/ls/m-option: New file. Test for above fixes.
5568 2003-12-20 Jim Meyering <jim@meyering.net>
5572 * src/pr.c: Change type of global, buff_allocated, to size_t.
5574 * src/join.c [struct seq]: Change types of members count and alloc
5575 from `int' to `size_t'.
5577 * tests/Makefile.am (root-hint): Tweak wording.
5579 * src/du.c: Accept new option (-0, --null) that makes it so each
5580 output line is NUL-terminated rather than newline-terminated.
5582 * src/dd.c (apply_translations): Don't prohibit conv=unblock,sync.
5583 Reported by Volker Paul.
5584 * tests/dd/Makefile.am (TESTS): Add unblock-sync.
5585 * tests/dd/unblock-sync: New test for the above.
5587 2003-12-19 Jim Meyering <jim@meyering.net>
5589 * tests/misc/nohup: Double quote back-ticked expression,
5590 in case it ends up having an unexpected value.
5592 * tests/ls/no-arg: Use ls's -1 option in both runs.
5594 * src/du.c (fts_debug): New global.
5595 (FTS_CROSS_CHECK, DEBUG_OPT): Define.
5596 (main): Make fts use FTS_TIGHT_CYCLE_CHECK.
5597 (main) [DU_DEBUG]: Accept -d option.
5599 2003-12-18 Jim Meyering <jim@meyering.net>
5601 * src/ls.c (format_user): Increment dired_pos via two statements,
5602 `dired_pos += width; dired_pos++;' rather than one,
5603 `dired_pos += width + 1;' since the latter could conceivably overflow.
5604 (format_group): Likewise.
5607 * configure.ac: Require automake-1.8.
5609 2003-12-12 Jim Meyering <jim@meyering.net>
5611 * Use automake-1.8. Regenerate dependent files.
5613 2003-12-08 Jim Meyering <jim@meyering.net>
5615 * Makefile.maint (news-date-check): New rule.
5616 (alpha beta major): Depend on it.
5618 2003-12-03 Paul Eggert <eggert@twinsun.com>
5620 * NEWS: ls -l (and similar options) now adjust all columns to
5621 fit the data. Generalized from a suggestion by Leah Q for file sizes.
5622 * src/ls.c (INODE_DIGITS, LOGIN_NAME_MAX, ID_LENGTH_MAX): Remove.
5623 (format_user_width, format_group_width, unsigned_file_size,
5624 format_group): New functions.
5625 (block_size_width): Renamed from block_size_size.
5626 (inode_number_width, nlink_width, owner_width, group_width,
5627 author_width, major_device_number_width, minor_device_number_width,
5628 file_size_width): New vars.
5629 (clear_files): Initialize them.
5630 (gobble_file): Set them. Don't ceiling block_size_width to 7.
5631 (print_long_file): Use them.
5632 (gobble_file): Use a new local variable 'f' to make the code
5633 smaller and more consistent with other functions.
5634 (format_user): Output to stdout, not to a buffer, so that we
5635 don't have to worry about buffer overrun. Update dired_pos.
5636 (print_long_file): Don't put owner, group, author into buffer;
5637 just print them directly. Don't assume link counts and
5638 major and minor numbers fit into unsigned long int.
5639 * tests/cp/same-file, tests/mv/part-symlink: Don't assume that
5640 'ls' output is fixed-width.
5642 2003-12-02 Jim Meyering <jim@meyering.net>
5644 * src/md5sum.c: Include sha1.h (reflect renaming: sha.h -> sha1.h.
5646 2003-11-27 Jim Meyering <jim@meyering.net>
5648 * Use automake-1.7f. Regenerate dependent files.
5650 2003-11-24 Paul Eggert <eggert@twinsun.com>
5652 Parse floating-point operands and options in the C locale.
5653 POSIX requires this for printf, and we might as well be
5654 consistent elsewhere (tail, sleep, seq).
5656 * src/printf.c: Remove decls of strtod, strtol, strtoul; no longer
5657 needed now that we assume C89. Include "c-strtod.h".
5658 (xstrtod): Call c_strtod, not strtod.
5659 * src/sleep.c: Include "c-strtod.h".
5660 (main): Update xstrtod call to include new argument, c_strtod.
5661 * src/seq.c (scan_double_arg): Likewise.
5662 * src/tail.c (parse_options): Likewise.
5664 2003-11-24 Jim Meyering <jim@meyering.net>
5666 * tests/rm/fail-2eperm: Handle another errno variant (HPUX, EPERM).
5667 Reported by Mark Conty.
5669 2003-11-22 Jim Meyering <jim@meyering.net>
5671 * Makefile.maint (sc_xalloc_h_in_src): Remove rule. Subsumed by...
5672 (sc_system_h_headers): Do this test only if sys2.h exists.
5674 2003-11-20 Jim Meyering <jim@meyering.net>
5676 * tests/help-version: Ensure that the bug-reporting address is
5677 included in the --help output for every program.
5678 * tests/Makefile.am (TESTS_ENVIRONMENT): Add $PACKAGE_BUGREPORT.
5680 * src/ptx.c (usage): Output bug-reporting address.
5681 Reported by Dan Jacobson.
5683 2003-11-19 Jim Meyering <jim@meyering.net>
5685 * src/join.c (usage): Mention that FILE1 and FILE2 must be sorted
5686 on the join fields. Suggestion from Bruce Robertson.
5688 2003-11-18 Jim Meyering <jim@meyering.net>
5690 `od -c -w9999999' could segfault
5691 * src/od.c (dump): Use xnmalloc/free, not alloca.
5693 2003-11-16 Jim Meyering <jim@meyering.net>
5695 * Use autoconf-2.59. Regenerate dependent files.
5697 * tests/du/hard-link: Minor tweak: use mkdir -p.
5699 Fix read-from-free'd-buffer error detected by valgrind.
5700 * src/csplit.c (remove_line): Don't return a pointer to data in
5701 a freed buffer. Instead, arrange to free the buffer on the
5704 * tests/misc/csplit: New test for above fix.
5706 2003-11-11 Jim Meyering <jim@meyering.net>
5708 * src/ls.c (extract_dirs_from_files): Avoid useless copy operations.
5709 This avoids a warning from valgrind about memcpy with overlapping
5710 source and destination.
5712 * configure.ac: Require automake-1.7.8.
5714 2003-11-09 Jim Meyering <jim@meyering.net>
5716 * Use automake-1.7.9. Regenerate dependent files.
5718 * src/rm.c: Support new options: --preserve-root and --no-preserve-root.
5719 * src/chown.c: Likewise.
5721 * src/chown-core.c: Include "root-dev-ino.h".
5722 (chopt_init): Initialize new member.
5723 (change_file_owner): Support rm's new --preserve-root option.
5725 * src/remove.c: Include "root-dev-ino.h".
5726 (remove_cwd_entries): Remove now-obsolete FIXME comment.
5727 (remove_dir): Support rm's new --preserve-root option.
5729 * src/chown.c: Include "root-dev-ino.h".
5730 Add new options: --preserve-root and --no-preserve-root.
5732 * src/chmod.c: Include "root-dev-ino.h".
5733 (process_file): Use newly-factored-out ROOT_DEV_INO_CHECK and
5734 ROOT_DEV_INO_WARN macros.
5735 (get_root_dev_ino): Remove function definition, now that it's
5736 been moved to a separate file.
5737 (usage): Describe new options.
5739 * src/mv.c (rm_option_init): Initialized new member.
5741 * src/remove.h: Include "dev-ino.h".
5742 (struct rm_options): Add new member: root_dev_ino.
5743 * src/chown-core.h: Include "dev-ino.h".
5744 (struct Chown_option): Add new member: root_dev_ino.
5746 2003-11-06 Jim Meyering <jim@meyering.net>
5748 * src/paste.c (paste_parallel): Use `sizeof *var' rather than
5749 hard-coding `sizeof FILE*'.
5751 2003-11-05 Dennis Smit <ds@nerds-incorporated.org>
5753 * src/wc.c (main): Free `fstatus' so there is no confusion about
5754 whether it's leaked or not.
5755 * src/who.c (who): Likewise for `utmp_buf'.
5757 2003-11-05 Paul Eggert <eggert@twinsun.com>
5759 Fix 'cut' problems with size_t overflow and unsigned int.
5760 More generally, resize integer variables to fit use more precisely.
5761 * src/cut.c (ADD_RANGE_PAIR): Remove unnecessary parens.
5762 (struct range_pair): Make members to be of type size_t, not unsigned.
5763 (max_range_endpoint, eol_range_start): Now size_t, not unsigned.
5764 (suppress_non_delimited, output_delimiter_specified,
5765 have_read_stdin, print_kth, set_fields): Now bool, nt int.
5766 (delim): Now unsigned char, not int.
5767 (mark_printable_field, is_printable_field, is_range_start_index,
5768 set_fields, set_fields, cut_bytes, cut_fields):
5769 Use size_t, not unsigned, for field and byte counts.
5770 (hash_int): Use uintptr_t, not unsigned, for pointers converted
5771 to integers. This squeezes more info out of them.
5772 (set_fields, cut_bytes, cut_fields, main):
5773 Use bool, not int, for booleans.
5774 (set_fields): Allocate zeroed byte array with xzalloc, not xcalloc.
5776 2003-11-05 Paul Eggert <eggert@twinsun.com>
5778 * man/Makefile.am (check-programs-vs-x):
5779 Work even if $(programs) contains '$'.
5780 Work even if 'missing=1' in environment.
5781 Don't report an error simply because $(programs) outputs nothing.
5783 2003-11-05 Jim Meyering <jim@meyering.net>
5785 * Use autoconf-2.58. Regenerate dependent files.
5787 * src/tr.c (spec_init): Fix typo in last change.
5789 * src/sys2.h (case_GETOPT_VERSION_CHAR): Cast NULL to `(char *)' in
5790 call to variadic version_etc function, so that it works even on systems
5791 for which sizeof char* != sizeof int.
5792 * src/true.c (main): Likewise.
5793 * basename.c, chroot.c, cksum.c, dd.c, dirname.c, echo.c, expr.c:
5794 * factor.c, hostid.c, hostname.c, link.c, logname.c, nice.c, nohup.c:
5795 * pathchk.c, printenv.c, printf.c, pwd.c, setuidgid.c, sleep.c, stty.c:
5796 * sync.c, test.c, tsort.c, unlink.c, uptime.c, users.c, whoami.c, yes.c:
5797 Similarly, cast NULL to `(char *)' in call to variadic function,
5798 parse_long_options, so that it works even on systems for which
5799 sizeof char* != sizeof int.
5800 A similar problem was reported by Harti Brandt in
5801 http://mail.gnu.org/archive/html/bug-gnu-utils/2003-10/msg00320.html.
5803 * src/users.c (users): Free `utmp_buf' explicitly so that people
5804 don't mistake this for a real leak.
5805 Patch by Dennis Smit <ds@nerds-incorporated.org.
5807 2003-11-04 Paul Eggert <eggert@twinsun.com>
5809 * README: Document _POSIX2_VERSION.
5811 2003-11-04 Jim Meyering <jim@meyering.net>
5813 * src/tac.c (memrchr): Remove #if-0'd function.
5814 (tac_stdin_to_mem): Clean up #if-0'd code.
5816 * src/od.c (decode_format_string): Remove unnecessary casts.
5817 Use more maintainable `sizeof *var'.
5818 (main): Call decode_format_string rather than decode_one_format,
5819 now that `spec' may be NULL.
5821 * src/chmod.c (AUTHORS): Add my name.
5823 * src/split.c (next_file_name): Use `sizeof *var' rather than
5824 hard-coding `sizeof size_t'.
5826 * src/sort.c (new_key): Use xzalloc, not xcalloc (1, ...).
5828 * src/cut.c (ADD_RANGE_PAIR): Use x2nrealloc rather than xrealloc,
5829 to avoid potential overflow in pointer arithmetic.
5830 (set_fields): Use not `1', but rather `sizeof *printable_field' as
5831 second argument to xcalloc.
5832 * src/od.c (decode_format_string, dump_strings): Use x2nrealloc
5833 rather than xrealloc.
5834 * src/date.c (show_date): Likewise.
5835 * src/join.c (ADD_FIELD, initseq, getseq): Likewise.
5836 * src/pr.c (store_char): Likewise.
5837 * src/fold.c (fold_file): Likewise.
5839 * src/copy.c (triple_hash, triple_hash_no_name): Adjust to reflect
5840 type changes (unsigned int -> size_t) in hash.c.
5841 * src/cp-hash.c (src_to_dest_hash): Likewise.
5842 * src/du.c (entry_hash): Likewise.
5843 * src/ls.c (dev_ino_hash): Likewise.
5844 * src/cut.c (hash_int): Likewise. Declare function as static.
5846 2003-11-03 Jim Meyering <jim@meyering.net>
5848 * tests/misc/Makefile.am (TESTS_ENVIRONMENT): Define PACKAGE_VERSION.
5849 * tests/misc/fold: Fail the test immediately if we're not running
5850 the expected version of fold.
5852 2003-11-02 Jim Meyering <jim@meyering.net>
5854 * src/tr.c (append_normal_char, append_range, append_char_class)
5855 (append_repeated_char, append_equiv_class, spec_init): Use `sizeof *var'
5856 rather than `sizeof EXPLICIT_TYPE'. The former is more maintainable
5857 and usually shorter.
5858 * src/copy.c (copy_internal): Likewise.
5859 * src/join.c (initseq, add_field, make_blank): Likewise.
5860 * src/od.c (main): Likewise.
5861 * src/cp.c (make_path_private): Likewise.
5862 * src/tsort.c (new_item, record_relation): Likewise.
5864 * src/df.c (add_fs_type, add_excluded_fs_type, main): Likewise.
5865 (main): Also remove anachronistic cast of xmalloc return value.
5866 * src/ptx.c (alloc_and_compile_regex, main): Likewise.
5867 (main): Also remove anachronistic cast of xmalloc return value.
5868 * src/sort.c (inittables): Likewise.
5869 (sort): Also Split a long line.
5871 2003-10-25 Jim Meyering <jim@meyering.net>
5873 * src/copy.c (triple_hash, triple_hash_no_name): Adjust to reflect
5874 type changes (unsigned int -> size_t) in hash.c.
5875 * src/cp-hash.c (src_to_dest_hash): Likewise.
5876 * src/du.c (entry_hash): Likewise.
5877 * src/ls.c (dev_ino_hash): Likewise.
5878 * src/cut.c (hash_int): Likewise. Declare function as static.
5880 2003-10-21 Jim Meyering <jim@meyering.net>
5882 Don't fail when run with VERBOSE=yes.
5883 * tests/chgrp/basic: Do `set +x' before starting the subshell
5884 from which we invoke chgrp. Otherwise, the output from the
5885 VERBOSE=yes-induced `set -x' would result in spurious differences.
5886 Reported by Russel Coker via Michael Stone.
5888 2003-10-19 Jim Meyering <jim@meyering.net>
5890 chmod now uses fts to perform a directory traversal when -R is
5891 specified. Before, it operated on full path names, and as such
5892 would encounter the PATH_MAX (often 4096) limit.
5894 * src/chmod.c: Include "xfts.h".
5895 (process_file): Rename from change_file_mode.
5896 Adapt to be used with fts.
5897 (process_files): New function.
5899 2003-10-18 Jim Meyering <jim@meyering.net>
5901 * tests/du/deref-args: Ensure that du -D now dereferences all
5902 symlinks specified on the command line, not just those that
5903 reference directories.
5905 * basename.c, cat.c, chroot.c, cksum.c, comm.c, cp.c, csplit.c, cut.c:
5906 * dd.c, df.c, dirname.c, du.c, echo.c, env.c, expr.c, factor.c, head.c:
5907 * hostid.c, hostname.c, id.c, link.c, ln.c, logname.c, ls.c, md5sum.c:
5908 * mv.c, nice.c, nl.c, nohup.c, paste.c, pathchk.c, pinky.c, pr.c:
5909 * printenv.c, printf.c, pwd.c, rm.c, setuidgid.c, sleep.c, sort.c:
5910 * split.c, stty.c, sum.c, sync.c, tac.c, tail.c, tee.c, test.c:
5911 * touch.c, tsort.c, uniq.c, unlink.c, uptime.c, users.c, wc.c:
5912 * who.c, whoami.c, yes.c (AUTHORS): Revert the WRITTEN_BY/AUTHORS change
5913 of 2003-09-19. Now, AUTHORS is a comma-separated list of strings.
5914 Update the call to parse_long_options so that `AUTHORS, NULL' are the
5916 * src/true.c (main): Append NULL to version_etc argument list.
5917 * src/sys2.h (case_GETOPT_VERSION_CHAR): Likewise.
5919 2003-10-17 Andreas Schwab <schwab@suse.de>
5921 * tests/mk-script: Get $srcdir from first parameter instead of
5923 (main): Update usage.
5925 * tests/Makefile.am.in ($(srcdir)/$x-tests): Pass $(srcdir) as
5926 first argument of mk-script.
5927 ($(srcdir)/Makefile.am): Likewise. Prepend $(srcdir) to target.
5929 2003-10-17 Jim Meyering <jim@meyering.net>
5931 * src/mv.c (usage): Tweak descriptions of -i and -f so that the
5932 generated `man' page is more readable. Suggestion from Dan Jacobson.
5934 * src/chown-core.c (change_file_owner): Handle the cases in
5935 which fts_info indicates an error with the given entry.
5937 * src/du.c (main): Simply assign to bit_flags.
5938 Don't bother with bit arithmetic.
5940 * tests/chmod/no-x: New file.
5941 * tests/chgrp/no-x: New file.
5942 * tests/chmod/Makefile.am (TESTS): Add no-x.
5943 * tests/chgrp/Makefile.am (TESTS): Likewise.
5945 * src/du.c: Include "xfts.h".
5946 (du_files): Use xfts_open, rather than fts_open.
5947 * src/chown-core.c (chown_files): Likewise.
5949 2003-10-16 Jim Meyering <jim@meyering.net>
5951 * src/chgrp.c (main): Simply assign to bit_flags.
5952 Don't bother with bit arithmetic.
5953 * src/chown.c (main): Likewise.
5954 Rename a couple of local variables.
5955 Remove unnecessary casts.
5957 * src/tail.c (start_bytes): Rename local, remainder, to avoid
5958 gcc's warning about shadowing a global.
5960 2003-10-15 Jim Meyering <jim@meyering.net>
5962 chown and chgrp now accept POSIX-mandated -H, -L, -P options and
5963 use fts to perform a directory traversal when -R is specified.
5964 Before, they operated on full path names, and as such would
5965 encounter the PATH_MAX (often 4096) limit.
5966 They are more efficient. For example, before, chgrp -R would
5967 take almost 5 seconds to change about 2000 directories and fail
5968 (with `File name too long'), while now it succeeds on a hierarchy
5969 of depth 20,000 in 1/10 the time.
5971 * src/chown.c: Include "userspec.h" and "fts_.h".
5972 (WRITTEN_BY): Add my name.
5973 (getpwnam, getgrnam, getgrgid): Remove declarations.
5974 (endpwent): Remove definition.
5976 (main): Handle new options.
5977 Call new function, chown_files rather than change_file_owner.
5979 * src/chgrp.c: Include "fts_.h".
5980 (WRITTEN_BY): Add my name.
5981 (MAXUID, MAXGID): Remove definitions. Use GID_T_MAX instead of
5984 (main): Handle new options.
5985 Call new function, chown_files rather than change_file_owner.
5987 Rewrite to iterate through hierarchies using fts rather than
5988 via explicit recursion.
5989 * src/chown-core.c: Include "fts_.h"
5990 (change_file_owner): Rewrite to use FTS* and FTSENT* and to operate
5991 on a single file at a time.
5992 (chown_files): New function.
5993 * src/chown-core.h [enum Dereference_symlink]: Remove declaration.
5994 [struct Chown_option] (recurse, force_silent): Change type to `bool'.
5995 [struct Chown_option] (dereference): Remove member with ambiguous name.
5996 [struct Chown_option] (affect_symlink_referent): New member.
5997 (chown_files): New prototype.
5999 * tests/chgrp/recurse: Update tests accordingly.
6000 * tests/chgrp/posix-H: New tests for the above.
6001 * tests/chgrp/Makefile.am (TESTS): Add posix-H.
6003 * src/ln.c (usage): Clarify that --directory, -d, -F probably won't
6004 work even for superuser. Suggestion from Dan Jacobson.
6006 2003-10-14 Paul Eggert <eggert@twinsun.com>
6008 Fix some number-parsing bugs, e.g., "head -n 100k@" wasn't
6010 * lib/human.c, lib/xstrtoimax.c, lib/xstrtol.c, lib/xstrtol.h,
6011 lib/xstrtoul.c, lib/xstrtoumax.c: Sync with gnulib.
6012 * src/sort.c (parse_field_count): Handle the case where overflow
6013 and invalid suffix char are both reported.
6015 2003-10-14 Jim Meyering <jim@meyering.net>
6017 * src/ls.c (decode_switches) [TIOCGWINSZ]: Comment out the
6018 warning-inducing test, ws.ws_col <= SIZE_MAX, since it was always
6021 2003-10-13 Paul Eggert <eggert@twinsun.com>
6023 Fix to avoid a denial-of-service attack if the display width is
6024 enormous. Also, clean up the code a bit by removing duplicate code.
6026 * src/ls.c (init_column_info): Remove forward decl; no longer needed.
6027 (calculate_columns): New function, that contains code that used
6028 to be common to print_many_per_line and print_horizontal.
6029 (print_many_per_line, print_horizontal): Use it.
6030 (decode_switches): Set max_idx here, not in calculate_columns.
6031 (print_current_files): Don't call init_column_info; calculate_columns
6033 (init_column_info): Don't allocate a lot more space than is needed
6034 to represent the current set of files. Allocate all the new
6035 size_t cells in one call to xnmalloc, rather than a row at a time.
6037 2003-10-13 Jim Meyering <jim@meyering.net>
6039 * src/ls.c (init_column_info): Add another FIXME comment.
6041 2003-10-13 Paul Eggert <eggert@twinsun.com>
6043 Fix address-arithmetic bug in 'ls', reported by Georgi Guninski.
6044 Remove several arbitrary limits on hosts where int cannot represent
6047 * src/ls.c (struct bin_str.len, length_of_file_name_and_frills, indent,
6048 nfiles, files_index, tabsize, line_length, struct column_info.line_len,
6049 struct column_info.col_arr[0], max_idx):
6050 Now size_t, not int.
6051 (get_funky_string): Return bool indicating success, instead of
6052 a negative count to indicate failure. Store number of columns
6053 through new parameter OUTPUT_COUNT; that way, they can never
6054 go negative. Change equals_end from int to bool. All uses
6056 (struct column_info.valid_len): Now bool, not int. All uses changed.
6057 (dired_dump_obstack, get_funky_string, clear_files,
6058 extract_dirs_from_files, print_current_files,
6059 print_many_per_line, print_horizontal, init_column_info,
6060 put_indicator, length_of_file_name_and_frills,
6061 print_with_commas): Use size_t, not int, for local variables
6063 (decode_switches): Decode sizes using xstrtoul, not xstrtol.
6064 Check for TIOCGWINSZ returing negative values (or values greater
6066 (visit_dir, main, parse_ls_color, queue_directory, add_ignore_pattern,
6068 Use xmalloc and xnmalloc, not XMALLOC.
6069 (gobble_file): Use xnrealloc, not XREALLOC.
6070 (print_color_indicator): Remove now-unnecessary cast to size_t.
6072 2003-10-12 Paul Eggert <eggert@twinsun.com>
6074 * tests/du/no-x: Change wording of diagnostic to match latest du.c.
6075 * tests/sort/sort-tests: Remove from CVS; assume that people
6076 brave enough to check coreutils out from CVS can rebuild it.
6078 2003-10-12 Jim Meyering <jim@meyering.net>
6080 New options: --preserve-root and --no-preserve-root.
6081 * src/chmod.c (change_file_mode): Honor new option.
6082 (change_file_mode): Strip trailing slashes on directory
6083 argument passed to change_dir_mode.
6084 (get_root_dev_ino): New function.
6085 (main): Initialize global, root_dev_ino.
6087 * src/copy.c (copy_internal): Don't #ifdef-out simple uses of
6088 S_ISLNK or S_ISSOCK. The S_IS* macros are guaranteed to be defined
6090 * src/chmod.c (change_file_mode): Likewise.
6092 2003-10-08 Jim Meyering <jim@meyering.net>
6094 * src/csplit.c (main): Remove obsolete FIXME.
6096 2003-10-07 Jim Meyering <jim@meyering.net>
6098 * Use automake-1.7.8. Regenerate dependent files.
6100 2003-09-29 Paul Eggert <eggert@twinsun.com>
6104 * doc/coreutils.texi (csplit invocation):
6105 The regexp offset need not have a sign; POSIX requires support
6106 for signless offets.
6108 Be more careful about int widths. For example, remove some
6109 arbitrary limits by replacing 'unsigned' with 'size_t',
6110 'uintmax_t', etc. Use standard bool rather than a homegrown type.
6111 * lib/Makefile.am (libfetish_a_SOURCES): Add xstrtoimax.c.
6112 * src/csplit.c (FALSE, TRUE, boolean): Remove. All uses changed
6113 to <stdbool.h> usage.
6114 (struct control): offset is now intmax_t, not int.
6115 repeat_forever is now bool, not int.
6116 (struct cstring): len is now size_t, not unsigned int.
6117 (struct buffer_record): bytes_alloc, bytes_used, num_lines are now
6118 size_t, not unsigned. start_line, first_available are now
6119 uintmax_t, not unsigned.
6120 (hold_count, control_used): Now size_t, not unsigned.
6121 (last_line_number, current_line, bytes_written):
6122 Now uintmax_t, not unsigned.
6123 (save_to_hold_area, red_input, keep_new_line, record_line_starts,
6124 create_new_buffer, get_new_buffer, load_buffer, find_line,
6125 process_regexp, split_file, new_control_record, extract_regexp,
6126 get_format_width, get_format_prec, max_out):
6127 size args, locals, and returned values are now size_t, not unsigned
6129 (get_first_line_in_buffer, find_line, write_to_file,
6130 handle_line_error, process_line_count, regexp_error, process_regexp,
6132 File line, byte, and repetition counts are now uintmax_t, not unsigned.
6133 (check_for_offset): Don't require a sign before the offset.
6134 Use xstrtoimax to do the real work.
6135 (extract_regexp): Remove harmful cast of size to unsigned.
6136 256 -> 1<<CHAR_BIT, for clarity.
6137 (get_format_flags): Return at most 3, to avoid worries about overflow.
6139 (bytes_to_octal_digits): Remove.
6141 (cleanup): Don't check whether output_stream is NULL, since
6142 close_output_file does that for us.
6144 (new_line_control, create_new_buffer): Use "foo *p = xmalloc
6145 (sizeof *p);" instead of the more long-winded alternatives.
6147 (get_new_buffer): Use O(1) algorithm for resizing a buffer
6148 to a much larger size, instead of an O(N) algorithm.
6150 (process_regexp): Use plain NULL rather than casted 0.
6152 (make_filename): Use %u, not %d, to format unsigned file number.
6154 (new_control_record): Use xrealloc exclusively, since it handles
6157 (extract_regexp): Change misspelled word in diagnostic.
6159 (get_format_width): Even if a minimum field width is specified,
6160 allow room for enough octal digits to represent the value of
6161 the maximum representible integer. This fixes a potential
6162 buffer overrun. Calculate this room at compile-time, not
6163 at run-time; this removes the need for bytes_to_octal_digits.
6164 Check for overflow; this removes a FIXME.
6166 (get_format_prec): Don't allow precision to be signed; it's
6167 not ANSI. Check for overflow. Remove hardcoded "11" as
6168 default precision; this fixes a potential buffer overrun
6169 on hosts with wider size_t.
6171 (get_format_conv_type): Change local variable to be of type
6172 unsigned char, not int; this removes a potential subscript
6173 violation on hosts where char is signed.
6175 (max_out): Replace "for (;*p;)" with more-standard "while (*p)".
6176 Allow "%%" in format. Don't overflow when
6177 counting lots of percents.
6179 (usage): Default sprintf format is %02u, not %d.
6181 2003-10-05 Jim Meyering <jim@meyering.net>
6183 * src/chown-core.c (change_file_owner): Remove set-but-not-used local.
6185 * src/du.c (du_files): Mark diagnostic for translation.
6187 2003-10-04 Jim Meyering <jim@meyering.net>
6189 * src/du.c (du_files): Ignore any failure of fts_close.
6190 Give better diagnostics for failed fts_open.
6192 * src/du.c (MAX_N_DESCRIPTORS): Remove now-unused definition.
6194 Deprecate existing use of -H (aka --si).
6195 * src/du.c (enum) [HUMAN_SI_OPTION]: New member.
6196 [long_options]: Use HUMAN_SI_OPTION, not 'H'.
6197 (main): Warn that the meaning of -H will soon change to be
6200 2003-10-03 Jim Meyering <jim@meyering.net>
6202 * src/du.c: Accept --no-dereference (-P).
6204 2003-10-02 Jim Meyering <jim@meyering.net>
6206 * tests/du/trailing-slash: Adjust for slightly different output.
6208 Rewrite du.c to use fts.
6209 * src/du.c: Include "fts_.h", not ftw.h.
6210 (opt_dereference_arguments, arg_length, suffix_length): Remove globals.
6211 (IS_FTW_DIR_TYPE): Remove definition.
6212 (IS_DIR_TYPE): Define.
6213 (is_symlink_to_dir): Remove now-unnecessary function.
6214 (process_file, du_files): Rewrite to use fts.
6216 * tests/du/inaccessible-cwd: Ensure that even when run from an
6217 inaccessible directory, du can still operate on accessible
6218 directories elsewhere.
6219 * tests/du/Makefile.am (TESTS): Add inaccessible-cwd.
6221 * tests/rm/deep-1: Ensure that du can process a hierarchy
6222 of depth 400 while using no more than 50KB of stack space.
6224 2003-10-01 Akim Demaille <akim@epita.fr>
6226 * announce-gen (print_news_deltas): New function, extracted from main.
6227 (main): Make `news_file' an array.
6228 Use '...=s' => \@var for --news and --url-directory specs.
6229 Before there were a couple of portability problems.
6231 2003-09-28 Jim Meyering <jim@meyering.net>
6233 * Makefile.maint (sc_cast_of_alloca_return_value): New rule.
6234 (syntax-check-rules): Add it.
6236 * src/copy.c: Remove unnecessary cast of alloca, since now it's
6237 guaranteed to be (void *).
6238 * src/cp.c: Likewise.
6239 * src/join.c: Likewise.
6240 * src/ln.c: Likewise.
6241 * src/ls.c: Likewise.
6242 * src/od.c: Likewise.
6243 * src/sys2.h (ASSIGN_STRDUPA): Likewise.
6245 2003-09-27 Jim Meyering <jim@meyering.net>
6247 Don't exhaust virtual memory when processing large inputs.
6248 Fix this by removing csplit's internal free-list management;
6249 instead rely on malloc for that.
6251 * src/csplit.c (free_list): Remove global.
6252 (clear_all_line_control): Remove function.
6253 (get_new_buffer): Always use create_new_buffer to obtain a
6254 new buffer, rather than searching free_list.
6255 (free_buffer): Just call free.
6256 Reported by Nikola Milutinovic.
6258 2003-09-26 Jim Meyering <jim@meyering.net>
6260 * man/rm.x: Also list `chattr' in SEE ALSO section.
6261 Suggestion from Mark Hubbart.
6263 2003-09-25 Jim Meyering <jim@meyering.net>
6265 * configure.ac: Don't invoke AC_AIX or AC_MINIX explicitly, now
6266 that we use gl_USE_SYSTEM_EXTENSIONS, since it AC_REQUIREs them.
6268 * Use autoconf-2.57d. Regenerate dependent files.
6270 2003-09-24 Jim Meyering <jim@meyering.net>
6272 Minor efficiency tweak.
6273 * src/ln.c (PATH_BASENAME_CONCAT): Use memcpy rather than strcpy.
6274 (do_link): Likewise.
6276 2003-09-23 Jim Meyering <jim@meyering.net>
6278 * src/paste.c (paste_serial): Save errno after input error,
6279 to report proper errno value.
6280 Based on a patch from Paul Eggert.
6282 * src/tee.c (tee): Adjust fwrite arguments so that the return
6283 value is the number of bytes written.
6285 2003-09-16 Paul Eggert <eggert@twinsun.com>
6287 Don't assume ferror sets errno. Bug reported by Bruno Haible.
6289 * src/comm.c (compare_files): Save errno after input error,
6290 to report proper errno value.
6291 * src/fold.c (fold_file): Likewise.
6292 * src/od.c (check_and_close, skip, read_char, read_block): Likewise.
6293 * src/unexpand.c (unexpand): Likewise.
6295 * src/csplit.c (close_output_file): Don't report bogus errno value
6296 after ferror discovers an output error. We don't know the proper
6297 errno value, since it might have been caused by any of a whole
6298 bunch of calls, and it might have been trashed in the meantime.
6299 Fixing this problem will require much more extensive changes;
6300 in the meantime just say "write error".
6301 * src/od.c (check_and_close, dump, dump_strings): Likewise.
6302 * src/uniq.c (check_file): Likewise.
6304 * src/join.c (get_line): Report error right away if I/O fails,
6305 so that the proper errno value is used.
6306 * src/tac.c (tac_seekable, tac_file, save_stdin): Likewise.
6307 * src/tee.c (tee): Likewise.
6308 * src/uniq.c (check_file): Likewise.
6310 * src/od.c (skip): If a read fails, don't retry it later, so
6311 that we report the proper errno.
6313 * src/tac.c (tac_mem): Don't return a value; nobody uses it.
6315 * src/tee.c (tee): Once a write failure has occurred, don't bother
6316 writing anything more to that stream.
6318 * src/uniq.c (check_file): Check for ferror (stdout) even if
6321 * src/yes.c (UNROLL): Remove.
6322 (main): Exit immediately when write failure is detected.
6323 Simplify code by assigning to argv when argc == 1.
6325 2003-09-21 Paul Eggert <eggert@twinsun.com>
6327 * src/ptx.c: Switch encoding from Latin-1 to UTF-8.
6328 (WRITTEN_BY): Change "Franc,ois" (actually using
6329 c-with-cedilla in Latin-1) to "F.", so that it's ASCII, as
6332 2003-09-19 Jim Meyering <jim@meyering.net>
6334 `du -D symlink-to-dir' would mistakenly omit the slash in
6335 lines like this: 24 symlink-to-dir/subdir
6336 * src/du.c (process_file): Fix offset calculation.
6337 Reported by Jeff Sheinberg as Debian bug #211591;
6338 http://bugs.debian.org/205251
6340 * tests/du/deref-args: New file/test for the above.
6341 * tests/du/Makefile.am (TESTS): Add deref-args.
6343 * src/du.c (process_file): Remove useless disjunct.
6345 * src/sys2.h (case_GETOPT_VERSION_CHAR): Rename parameter, Authors,
6347 * nearly all src/*.c files (WRITTEN_BY): Rename from AUTHORS.
6348 Begin each WRITTEN_BY string with `Written by ' and end it with `.'.
6349 Mark each WRITTEN_BY string as translatable.
6351 * basename.c, cat.c, chroot.c, cksum.c, comm.c, cp.c, csplit.c, cut.c:
6352 * dd.c, df.c, dirname.c, du.c, echo.c, env.c, expr.c, factor.c, head.c:
6353 * hostid.c, hostname.c, id.c, link.c, ln.c, logname.c, ls.c, md5sum.c:
6354 * mv.c, nice.c, nl.c, nohup.c, paste.c, pathchk.c, pinky.c, pr.c:
6355 * printenv.c, printf.c, pwd.c, rm.c, setuidgid.c, sleep.c, sort.c:
6356 * split.c, stty.c, sum.c, sync.c, tac.c, tail.c, tee.c, test.c:
6357 * touch.c, tsort.c, uniq.c, unlink.c, uptime.c, users.c, wc.c:
6358 * who.c, whoami.c, yes.c: Revert yesterday's changes.
6359 Instead, a subsequent change will embed `Written by ' in
6360 each string along with the author names.
6362 * src/true.c: Revert yesterday's changes.
6363 * src/sys2.h: Likewise.
6365 2003-09-18 Jim Meyering <jim@meyering.net>
6367 * basename.c, cat.c, chroot.c, cksum.c, comm.c, cp.c, csplit.c, cut.c:
6368 * dd.c, df.c, dirname.c, du.c, echo.c, env.c, expr.c, factor.c, head.c:
6369 * hostid.c, hostname.c, id.c, link.c, ln.c, logname.c, ls.c, md5sum.c:
6370 * mv.c, nice.c, nl.c, nohup.c, paste.c, pathchk.c, pinky.c, pr.c:
6371 * printenv.c, printf.c, pwd.c, rm.c, setuidgid.c, sleep.c, sort.c:
6372 * split.c, stty.c, sum.c, sync.c, tac.c, tail.c, tee.c, test.c:
6373 * touch.c, tsort.c, uniq.c, unlink.c, uptime.c, users.c, wc.c:
6374 * who.c, whoami.c, yes.c: Update AUTHORS definition to be a
6375 comma-separated list of strings and/or update the call to
6376 parse_long_options so that `AUTHORS, NULL' are the last parameters.
6377 * src/true.c (main): Append NULL to version_etc argument list.
6378 * src/sys2.h (case_GETOPT_VERSION_CHAR): Likewise.
6380 * src/sort.c (numcompare): Rename local, logb, to log_b to avoid
6381 shadowing the math function name. Also rename loga to log_a.
6383 2003-09-14 Jim Meyering <jim@meyering.net>
6385 * src/factor.c (print_factors): Give a separate diagnostic
6386 for numbers that are too large, but otherwise valid.
6387 Reported by Dániel Varga.
6389 2003-09-10 Jim Meyering <jim@meyering.net>
6391 * Use automake-1.7.7. Regenerate dependent files.
6393 * tests/Makefile.am (all_programs): Use ../src/tr -s ' ' '\n' in place
6394 of `fmt -1'. Using the just-built tr is a little cleaner.
6395 Christian Krackowizer reported that HPUX 10.20 doesn't have fmt.
6396 * man/Makefile.am (programs, check-x-vs-1): Likewise.
6398 2003-09-09 Jim Meyering <jim@meyering.net>
6400 * src/copy.c: Alphabetize includes.
6401 Remove duplicate inclusion of "same.h".
6403 2003-09-08 Jim Meyering <jim@meyering.net>
6405 * Makefile.maint (GZIP_ENV): Remove --rsyncable.
6406 Didn't give enough of a benefit, mainly because it's not yet
6411 * man/Makefile.am (programs): Use ../src, not $(srcdir)/../src.
6412 (check-programs-vs-x): Fail if $(programs) is empty.
6414 * src/remove.c: Add a comment.
6416 2003-09-07 Jim Meyering <jim@meyering.net>
6418 * src/remove.c (D_INO, ENABLE_CYCLE_CHECK) [D_INO_IN_DIRENT]:
6419 Don't define. These symbols are no longer used.
6421 * tests/misc/tty-eof: Write ^D as \cD.
6422 Complete the change of 2003-08-02.
6424 * Makefile.maint (po-check): Use cvsu, so that a temporary source
6425 file in lib/ or src/ doesn't induce an unwarranted failure.
6426 Add a kludge to filter out the sole generated source file that
6427 also has translatable messages: src/false.c.
6429 2003-09-06 Jim Meyering <jim@meyering.net>
6431 * src/tail.c (enum): Add ALLOW_MISSING_OPTION.
6432 (parse_options): Give a diagnostic for (but still accept) the
6433 deprecated --allow-missing option.
6435 2003-09-04 Paul Eggert <eggert@twinsun.com>
6437 Don't ignore -S if input is a pipe. Bug report by Michael McFarland in
6438 <http://mail.gnu.org/archive/html/bug-coreutils/2003-09/msg00008.html>.
6440 * src/sort.c (sort_buffer_size): Omit SIZE_BOUND arg. Compute the
6441 size_bound ourselves. if an input file is a pipe and the user
6442 specified a size, use that size instead of trying to guess the
6443 pipe size. This has the beneficial side effect of avoiding the
6444 overhead of default_sort_size in that case. All callers changed.
6445 (sort): Remove static var size; now done by sort_buffer_size.
6447 2003-09-05 Jim Meyering <jim@meyering.net>
6449 * Use automake-1.7.6b and autoconf-2.57b. Regenerate dependent files.
6451 * tests/tail-2/tail-n0f: Wait .5 seconds for backgrounded process
6452 to start, rather than just .1. Upon failure, print unexpected state.
6454 2003-09-04 Paul Eggert <eggert@twinsun.com>
6456 * src/head.c (elide_tail_lines_pipe): Don't assign 0 or
6457 SAFE_READ_ERROR to tmp->nbytes.
6458 * src/tail.c (pipe_lines, pipe_bytes): Likewise.
6460 * src/head.c (struct linebuffer): Change nbytes and nlines
6461 from unsigned int to size_t. unsigned int is safe (after the
6462 2003-09-03 patch) but size_t is cleaner.
6463 * src/tail.c (struct linebuffer, struct charbuffer): Likewise.
6464 (pipe_bytes): Likewise for local variable 'i', which was 'int'.
6466 Standardize on BUFSIZ as opposed to other macro names and values.
6467 * src/head.c (BUFSIZE): Remove. All uses changed to BUFSIZ.
6468 * src/tail.c (BUFSIZ) [!defined BUFSIZ]: Remove.
6469 stdio.h has always defined it,
6470 and other code already assumes it's defined.
6471 * src/tr.c (BUFSIZ) [!defined BUFSIZ]: Likewise.
6472 (IO_BUF_SIZE): Remove; replace all uses with sizeof io_buf.
6473 (io_buf): IO_BUF_SIZE -> BUFSIZ.
6475 2003-09-04 Paul Eggert <eggert@twinsun.com>
6477 * src/seq.c (step): Default to 1.
6478 (print_numbers): Allow the output to be empty.
6479 (main): The default step is 1, even if LAST < FIRST;
6480 as per documentation.
6481 * tests/seq/basic (onearg-2): Output should be empty.
6483 2003-09-05 Jim Meyering <jim@meyering.net>
6485 * Makefile.cfg (wget_files): Temporarily disable, until master
6486 versions are restored to ftp.gnu.org.
6488 * configure.ac (AM_INIT_AUTOMAKE): Specify automake-1.7.6.
6490 Make seq's --width (-w) option work properly even when the
6491 endpoint requiring the larger width is negative and smaller than
6493 * src/seq.c (get_width_format): Include `-' in the set of bytes
6494 allowed in a `simple' number (no decimal point, no exponent).
6495 Reported by Patrick Mauritz.
6497 2003-09-02 Paul Eggert <eggert@twinsun.com>
6499 * NEWS: sort -t '\0' now uses a NUL tab.
6500 sort option order no longer matters, unless POSIX requires it.
6501 * src/sort.c (usage): Say "blanks" instead of "whitespace",
6502 Similar fixes for many comments.
6503 (TAB_DEFAULT): New constant, so that we can support NUL as
6504 the field separator.
6505 (tab): Now int, not char. Initialize to TAB_DEFAULT.
6506 (specify_sort_size): If multiple sizes are specified, use the largest.
6507 (begfield, limfield): Support NUL tab char.
6508 (set_ordering): Do not let -i override -d.
6509 (main): Report an error if incompatible -o or -t options are given.
6510 Report an error for "-t ''". Allow "-t '\0'" to specify a NUL tab.
6512 2003-09-05 Jim Meyering <jim@meyering.net>
6514 * tests/sort/Test.pm [o2, nul-tab]: New tests for the above.
6516 2003-09-03 Andreas Schwab <schwab@suse.de>
6518 Bug report and patch here:
6519 <http://mail.gnu.org/archive/html/bug-coreutils/2003-09/msg00009.html>
6520 * src/tail.c (pipe_lines): Don't truncate return value from safe_read.
6521 * src/head.c (elide_tail_lines_pipe): Likewise.
6523 2003-09-03 Jim Meyering <jim@meyering.net>
6525 * src/du.c (AUTHORS): Remove Larry McVoy's name, since the relatively
6526 small amount of code from him was first moved to lib/human.c, and was
6527 subsequently rewritten entirely.
6528 * src/df.c (AUTHORS): Likewise.
6530 2003-08-22 Lawrence Teo <lcteo@uncc.edu>
6532 * src/md5sum.c (split_3): Accept the BSD format for generic
6533 message digest modes. Currently works with BSD's MD5 and SHA1
6534 formats since these are the two algorithms presently used in
6535 coreutils. Updated comments to reflect this change.
6536 (bsd_split_3): Updated comments.
6538 * tests/md5sum/basic-1: New test to make sure that
6539 `md5sum --check' doesn't accept the BSD SHA1 format (adapted
6540 from `check-bsd' test in tests/sha1sum/basic-1).
6542 * tests/sha1sum/basic-1 (check-bsd2, check-bsd3): New tests for
6543 --check exit status and BSD SHA1 format (adapted from tests
6544 in tests/md5sum/basic-1).
6546 2003-08-30 Jim Meyering <jim@meyering.net>
6548 * src/ln.c (do_link): Use SAME_INODE rather than open-coding it.
6550 When source and destination arguments refer to the same file, reside
6551 on a partition (e.g. VFAT) on which distinct names may refer to the
6552 same directory entry (often due to variations in case), and when the
6553 link count for the file is 1, mv no longer unlinks the file. Instead,
6554 it gives the expected diagnostic that the source and destination are
6555 the same. WARNING: this is an incomplete fix. If the file happens
6556 to have a link count of 2 or greater, such an erroneous mv command
6557 will still unlink it.
6558 Although that is not possible on vfat or umsdos, it is possible on
6559 other file system types, e.g., ntfs, and hpfs.
6560 * src/copy.c (same_file_ok): Invoke same_name (which might still
6561 return false for names that refer to the same directory entry)
6562 only if the link count is 2 or more.
6563 * tests/mv/vfat: Show how to demonstrate the above problem.
6564 This test is not run.
6565 * tests/mv/Makefile.am (EXTRA_DIST): Add vfat.
6567 2003-08-27 Jim Meyering <jim@meyering.net>
6569 * src/who.c: Change meaning of -l from --lookup to --login, per POSIX.
6570 who's -l option has been eliciting an unconditional warning about
6571 this impending change since sh-utils-2.0.12 (April 2002).
6573 * src/paste.c (paste_parallel): Don't output `EOF' (aka -1) as a `char'.
6574 This would happen for nonempty files not ending with a newline.
6575 Reported by Dan Jacobson.
6576 * tests/misc/paste-no-nl: New file. Test for above-fixed bug.
6577 * tests/misc/Makefile.am (TESTS): Add paste-no-nl.
6579 * src/stat.c (print_it): Avoid buffer overrun that would
6580 occur when the user-specified format string ends with `%'.
6581 Patch by Tommi Kyntola.
6582 * tests/misc/stat-fmt: New file. Test for above-fixed bug.
6583 * tests/misc/Makefile.am (TESTS): Add stat-fmt.
6585 2003-08-26 Jim Meyering <jim@meyering.net>
6587 Apply changes from bison.
6588 * GNUmakefile (SHELL): Define to `sh', if necessary.
6590 * Makefile.maint (WGETFLAGS): Define to `-C off'.
6591 Update all uses of $(WGET).
6593 2003-08-22 Akim Demaille <akim@epita.fr>
6595 * Makefile.cfg (local-checks-to-skip): New.
6596 * Makefile.maint (local-check): Rename as...
6597 (local-checks-available): this.
6600 2003-08-26 Akim Demaille <akim@epita.fr>
6602 * announce-gen (print_changelog_deltas): Neutralize "<#" as
6603 "<\#" to avoid magic from Gnus when posting parts of this script.
6605 2003-08-25 Jim Meyering <jim@meyering.net>
6607 * src/stat.c (main): Warn about use of deprecated `-l' option.
6609 2003-08-22 Jim Meyering <jim@meyering.net>
6611 * src/stat.c (do_stat): For link count at end of line, use %h format,
6612 instead of %-5h. The latter would make stat emit trailing spaces.
6613 Reported by Dan Jacobson.
6615 2003-08-20 Jim Meyering <jim@meyering.net>
6617 * Makefile.am (EXTRA_DIST): Add .x-sc_space_tab .x-sc_sun_os_names
6619 2003-08-19 Jim Meyering <jim@meyering.net>
6621 * src/system.h: Include stdlib.h unconditionally,
6622 as we're now assuming that part of hosted C89.
6624 2003-08-18 Jim Meyering <jim@meyering.net>
6626 * src/sys2.h (textdomain, bindtextdomain) [! ENABLE_NLS]: Define away,
6627 to avoid warnings from gcc.
6629 2003-08-17 Jim Meyering <jim@meyering.net>
6631 Avoid unnecessary and sometimes time-consuming hostname lookups.
6632 * src/who.c (print_user): Use strchr, not strrchr.
6633 * src/pinky.c (print_entry): Likewise.
6634 Patch by Michael Stone.
6635 This fixes a typo I introduced in who-users.c on 1996-02-23.
6637 * Makefile.maint (makefile-check): Add 0-9 to the range of characters
6638 disallowed between `@...@'.
6640 2003-08-16 Paul Eggert <eggert@twinsun.com>
6642 * configure.ac (fu_cv_sys_truncating_statfs): Remove; now
6643 done by gnulib .m4 files.
6644 (jm_DUMMY_1): Require gl_READUTMP, not jm_PREREQ_READUTMP.
6645 * src/sys2.h (strtoull): Remove unused declaration.
6647 2003-08-16 Jim Meyering <jim@meyering.net>
6649 * man/Makefile.am (.x.1): Ensure that generated PROGRAM.1 files
6652 * src/tail.c (tail_lines): Fix a potential (but very hard to exercise)
6653 race condition bug. The bug would be triggered when tailing a file
6654 with file pointer not at beginning of file, and where the file was
6655 truncated to have a length of less than the initial offset at just
6656 the right moment (between the two lseek calls in this function).
6658 An invalid initial value for *read_pos would result in
6659 `tail -n0 -f FILE' and `tail -c0 -f FILE' doing what amounted to a
6660 busy-wait rather than sleeping between iterations. The bug manifests
6661 itself only when tailing regular files that are initially nonempty.
6662 * src/tail.c (tail_bytes): Set *read_pos to new file offset after
6664 (tail_lines): Likewise, after lseek calls.
6665 Reported by Nick Estes. See http://bugs.debian.org/205251 for details.
6666 * tests/tail-2/tail-n0f: New file. Test for above fix.
6667 * tests/tail-2/Makefile.am (TESTS): Add tail-n0f.
6669 2003-08-15 Jim Meyering <jim@meyering.net>
6671 * Makefile.maint (sc_space_tab): Use exclusion list in separate file.
6672 (sc_sun_os_names): Likewise.
6673 * .x-sc_space_tab, .x-sc_sun_os_names: New files.
6675 * man/help2man: Remove some SPACEs before TAB.
6677 2003-08-14 Paul Eggert <eggert@twinsun.com>
6679 * Makefile.maint (LC_ALL): Set to C.
6680 * man/Makefile.am (ASSORT): New var.
6681 (check-x-vs-1, programs): Use it.
6682 * src/Makefile.am (ASSORT, check-README, ../AUTHORS): Likewise.
6683 * tests/Makefile.am (ASSORT, all_programs): Likewise.
6685 2003-08-11 Jim Meyering <jim@meyering.net>
6687 fold -s -wN would infloop for N < 8 with TABs in the input.
6688 E.g., this would not terminate: printf 'a\tb' | fold -w2 -s
6689 * src/fold.c (fold_file): Move contents of `else'-block
6690 out of conditional so it's used also for --spaces (-s).
6691 * tests/misc/fold: Test for the above fix.
6692 * tests/misc/Makefile.am (TESTS): Add fold.
6694 2003-08-10 Jim Meyering <jim@meyering.net>
6696 * src/nice.c [!NICE_PRIORITY]: Include <sys/resource.h> after
6697 system.h so the types from time.h and sys/time.h are available.
6698 It appears that this is necessary for OpenBSD, NetBSD, and
6699 Darwin 6.5 (MacOS 10.2.5). Reported by Nelson Beebe.
6701 2003-08-06 Paul Eggert <eggert@twinsun.com>
6703 * NEWS: Add support for setting file timestamps to microsecond
6704 resolution, on hosts that support this.
6705 * src/copy.c, src/cp.c, src/install.c, src/touch.c: Include utimens.h.
6706 * src/copy.c (copy_internal):
6707 Set file timestamps with utimens, not utime.
6708 * src/cp.c (re_protect): Likewise.
6709 * src/install.c (change_timestamps): Likewise.
6710 * src/touch.c (newtime, touch, main): Likewise.
6712 2003-08-09 Jim Meyering <jim@meyering.net>
6714 * Makefile.maint (sc_sun_os_names): New rule based on a regexp
6716 (syntax-check-rules): Add it.
6718 * src/tail.c (main): Tweak Solaris OS version number in comment.
6719 * src/wc.c (wc): Likewise
6720 * tests/tail-2/fflush: Likewise.
6722 * src/tail.c: Add new undocumented option, --presume-input-pipe.
6723 (pipe_lines): Use memchr to skip lines, rather than an explicit loop.
6725 2003-08-08 Paul Eggert <eggert@twinsun.com>
6727 Use new gnulib 'extensions' module.
6728 * configure.ac: Invoke gl_USE_SYSTEM_EXTENSIONS instead of
6731 2003-08-08 Paul Eggert <eggert@twinsun.com>
6733 * tests/du/basic: Ensure that a/b/F has at least 65 bytes too.
6735 2003-08-09 Jim Meyering <jim@meyering.net>
6737 * tests/misc/split-fail: Reflect that `split -a 0' is now accepted.
6738 For tests of obsolete behavior, don't presume that unsetting
6739 _POSIX2_VERSION is equivalent to _POSIX2_VERSION=199209.
6741 2003-08-07 Paul Eggert <eggert@twinsun.com>
6743 * doc/coreutils.texi (split invocation):
6744 Add -d or --numeric-suffixes option to 'split'.
6745 From a suggestion by Jesse Kornblum.
6746 * src/split.c (suffix_alphabet): New var.
6747 (longopts, usage, next_file_name, main): Support -d.
6748 (next_file_name, main): Allow -a0, as POSIX requires.
6749 (next_file_name): Don't assume ASCII-like encoding;
6750 'a' through 'z' are not contiguous in EBCDIC.
6752 2003-08-05 Paul Eggert <eggert@twinsun.com>
6754 Merge getline from gnulib.
6755 * lib/getline.h, lib/getline.c, m4/getline.m4: Merge from gnulib.
6756 * lib/getndelim2.h, lib/getndelim2.c, m4/getndelim2.m4, m4/ssize_t.m4:
6757 New files, from gnulib.
6758 * lib/getdelim2.c, lib/getdelim2.h: Remove.
6759 * lib/Makefile.am (libfetish_a_SOURCES): Change getdelim2.c and
6760 getdelim2.h to getndelim2.c and getndelim2.h.
6761 * m4/jm-macros.m4 (jm_MACROS): Use gl_GETNDELIM2 rather than
6762 checking for getdelim.
6763 (jm_CHECK_ALL_TYPES): Use gt_TYPE_SSIZE_T for ssize_t rather
6764 than rolling our own.
6765 * src/cut.c: Include getndelim2.h rather than getdelim2.h.
6766 (cut_fields): Invoke getndelim2 rather than getdelim2.
6768 2003-08-04 Jim Meyering <jim@meyering.net>
6770 * src/sort.c (main): Use unsigned int instead of int for `nsigs'
6771 and for the indices to iterate through nsigs.
6773 2003-08-02 Paul Eggert <eggert@twinsun.com>
6775 * src/sort.c: Minor code cleanups, mostly to use more accurate
6776 types and to remove unnecessary casts.
6777 (min, max): Remove. All uses changed to MIN and MAX.
6778 (hard_lc_collate, hard_LC_TIME, struct buffer.eof, struct
6779 keyfield.skipsblanks, struct keyfield.skipeblanks, struct
6780 keyfield.numeric, struct keyfield.general_numeric, struct
6781 keyfield.month, struct keyfield.reverse, reverse, unique,
6782 have_read_stdin): Now bool, not int. All uses changed.
6783 (eolchar): Now char, not int.
6784 (struct keyfield.ignore): Now bool const *, not int *.
6785 (struct keyfield.translate): Now char const *, not char *.
6786 (struct month.name): Likewise.
6787 (blanks, nonprinting, nondictionary): Now bool[], not int[].
6788 (cleanup, inittables, keycompare, check, mergefps, first_same_file,
6789 check, sort, main): Use const * pointers when possible.
6790 (month_cmp): Rewrite to avoid casts.
6791 (inittables): Initialize tables unconditionally, to avoid branches.
6792 (fillbuf): Return bool, not int. All uses changed.
6793 (fillbuf, keycompare, new_key, main):
6794 Use SIZE_MAX rather than (size_t) -1.
6795 (trailing_blanks): Renamed from trim_trailing_blanks.
6796 Return the number of blanks to trim. All uses changed.
6797 (getmonth): Use trailing_blanks rather than open code.
6798 (keycompare): Do not cast char * to unsigned char *; not needed.
6799 CMP_WITH_IGNORE converts args to UCHAR, so no need to convert it
6801 (compare, main): Use | rather than || to avoid jumps.
6802 Replace "diff = NONZERO (alen)" with "diff = 1", since alen must
6804 (check, first_same_file, sort, main):
6805 Use bool instead of int local vars when possible.
6806 (check): Merge the old 'checkfp' and 'check' into a single function,
6807 that returns a boolean (true if the file was ordered).
6809 (main): Use int instead of unsigned for iterating through nsigs.
6810 Rename local var "posix_pedantic" to "posixly_correct".
6812 2003-08-02 Jim Meyering <jim@meyering.net>
6814 * src/nice.c [!NICE_PRIORITY]: Include <time.h> before <sys/resource.h>
6815 to avoid compilation error on Ultrix. Reported by Christian Krackowizer.
6817 * src/cut.c (cut_fields): Don't read again after encountering an
6818 initial EOF. E.g., `cut -f2' would do so.
6819 * tests/misc/tty-eof: Add a test for the above fix.
6821 * src/sort.c (sortlines): Add description and references.
6824 * tests/Makefile.am (TESTS_ENVIRONMENT): Set PATH so that
6825 the tests in help-version will use the just-built binaries.
6826 Reported by Christian Krackowizer.
6828 2003-07-31 Paul Eggert <eggert@twinsun.com>
6830 * NEWS: Add --rfc-2822 option to GNU date.
6831 * doc/coreutils.texi (Time directives, Options for date, Examples
6833 * src/date.c (long_options, usage, main): Likewise.
6834 * doc/getdate.texi (General date syntax): Likewise.
6835 * doc/coreutils.texi (Options for date): Fix a typo in format:
6836 it's now %d not %_d. Add URLs.
6838 2003-08-01 Jim Meyering <jim@meyering.net>
6840 * tests/shred/remove: Ensure that $? is 0 for the final `exit 0'.
6841 Otherwise, with at least the /bin/sh from HPUX 10.20,
6842 the trap code would end up converting that to exit 1 and thus an
6843 unexpected test failure. Reported by Christian Krackowizer.
6845 2003-07-31 Paul Eggert <eggert@twinsun.com>
6847 * src/ptx.c: Do not include bumpalloc.h.
6848 (WORD_TABLE): New member alloc.
6849 (ALLOC_NEW_WORD): Remove.
6850 (occurs_alloc): New var.
6851 (digest_word_file, find_occurs_in_text): Check for arithmetic
6852 overflow when computing table size. Use xrealloc rather than
6853 bumpalloc primitives.
6855 2003-07-29 Jim Meyering <jim@meyering.net>
6859 * README: When running tests as root, suggest using
6860 sudo with NON_ROOT_USERNAME=$USER.
6862 * tests/Makefile.am (all_programs): Makefile is in ../src, not
6865 2003-07-28 Jim Meyering <jim@meyering.net>
6867 * Makefile.maint (GZIP_ENV): Try Debian/gzip's new --rsyncable option.
6869 2003-07-28 Paul Eggert <eggert@twinsun.com>
6871 * lib/stdbool.hin (_Bool): Make it signed char, instead of
6872 an enum type, so that it's guaranteed to promote to int.
6873 * src/sort.c (sortlines_temp): Undo previous change.
6875 2003-07-28 Jim Meyering <jim@meyering.net>
6877 * src/sort.c (sortlines_temp): Declare local `swap' to be `int', not
6878 `bool'. Otherwise, at least one buggy compiler (alpha gcc-2.95.4)
6879 would cause lines[-1 - swap] (with swap = false) to evaluate to
6882 2003-07-27 Jim Meyering <jim@meyering.net>
6884 * tests/priv-check (my_uid): Use `!', not `^' in case pattern `[!0-9]',
6885 since /bin/sh of at least NetBSD 1.6 and OpenBSD 3.2 don't accept `^'.
6887 * src/remove.c (prompt) [! recursive]: Don't prompt about unwritable
6888 directories, as required by POSIX. Reported by Karl Berry.
6889 * tests/rm/dir-no-w: New file. Test for the above fix.
6890 * tests/rm/Makefile.am (TESTS): Add dir-no-w.
6892 * tests/mk-script: Emit `$xx', not its expansion.
6894 2003-07-27 Paul Eggert <eggert@twinsun.com>
6896 This change was inspired by a similar proposal by Stepan Kasal.
6897 * src/sort.c (mergelines, sortlines_temp): New functions.
6898 (sortlines): Use them, to reduce the number of times that
6899 we need to copy 'struct line' values. This improved CPU
6900 performance by about 30% on one 18 MB test.
6901 (sort): Don't invoke sortlines unless we have 2 or more lines.
6903 2003-07-26 Stepan Kasal <kasal@ucw.cz>
6905 * src/sort.c (sort): Don't require two `struct line's per text line,
6906 the new sort algorithm requires just 1.5.
6908 2003-07-27 Jim Meyering <jim@meyering.net>
6910 * src/pathchk.c (validate_path): Use %lu, not %ld.
6912 * src/cut.c (is_printable_field): Simplify bit arithmetic.
6914 * src/ls.c (sort_files): Put `volatile' in the right place.
6917 2003-07-26 Jim Meyering <jim@meyering.net>
6919 Use only one bit per field/offset in array, not one `int'.
6920 * src/cut.c (printable_field): Change type to `unsigned char'.
6921 (mark_printable_field, is_printable_field): New functions.
6922 Use them in place of all direct accesses of `printable_field'.
6924 * src/expand.c (parse_tabstops): Detect overflow properly.
6925 * src/cut.c (set_fields): Likewise.
6927 * src/rm.c: Include "dirname.h".
6928 (usage): Use base_name (program_name) in body of --help output.
6930 * man/Makefile.am (.x.1): ...back out the kludge of 2003-07-22.
6931 Idea from Brendan O'Dea, who suggested using
6932 `program_name = basename (argv[0]);' everywhere --
6933 can't do that, but using base_name works just fine here.
6935 * src/Makefile.am (AM_INSTALLCHECK_STD_OPTIONS_EXEMPT): Exempt test.
6937 2003-07-24 Paul Eggert <eggert@twinsun.com>
6939 Fix some POSIX-compliance problems with 'test'. This makes
6940 'test' more compatible with Bash.
6942 * NEWS, doc/coreutils.texi: Document the following.
6943 * src/test.c: Include exitfail.h.
6944 (TEST_FAILURE): New constant, used for exit status if 'test' fails.
6945 (test-syntax_error): Use it.
6946 (binary_operator): Now takes bool arg specifying whether left operand
6947 is -l ARG, so that caller determines this rather than us.
6949 (term): Use posixtest to evaluate parenthesized subexpressions.
6950 (unary_operator, one_argument): Remove support for -t without operand.
6951 (one_argument): Take argument from argv[pos].
6952 (one_argument, two_arguments, three_arguments): Advance pos.
6953 All callers changed.
6954 (three_arguments): Look for binary ops before "!". Then look
6955 for parenthesized one_argument expressions, instead of trusting
6956 expr () to do the right thing.
6957 (posixtest): Now takes number of args. All callers changed.
6958 Treat "( A B )" like "A B".
6959 (main): Set exit_failure to TEST_FAILURE. Don't depend on
6960 POSIXLY_CORRECT, as we now conform to POSIX by default.
6961 (main) [!LBRACKET]: Do not recognize "--help" or "--verbose" unless.
6962 * tests/test/Test.pm (test_vector): Add several tests to check
6963 the above. Syntax errors now exit with status 2, not 1.
6964 * man/Makefile.am (mapped_name): Use `../src/[' binary to create test.1.
6966 2003-07-26 Jim Meyering <jim@meyering.net>
6968 * tests/help-version: Adjust for above change in test behavior:
6969 `[' exits with 2, not 1, and test doesn't accept --help or --version.
6971 * Makefile.maint (ME): Don't use trick suggested in Make manual.
6972 It doesn't work for make-3.79.1. Reported by Christian Krackowizer.
6974 * Makefile.maint (sc_system_h_headers): Another syntax check.
6975 (syntax-check-rules): Add it to the list.
6977 * src/pathchk.c (validate_path): Cast strlen value to `unsigned long'
6978 so it matches `%ld' format even on 32-bit systems.
6980 * src/fmt.c (flush_paragraph): Cast field width to `int' to
6981 avoid warning on 64-bit systems.
6983 * src/ls.c (sort_files): Make `func' volatile, so it can't be
6984 clobbered by a `longjmp' into this function.
6986 2003-07-25 Jim Meyering <jim@meyering.net>
6988 * src/pathchk.c (validate_path): Use %ld format (not %d) for size_t
6991 * tests/misc/split-fail: Disable the --line-bytes=$_4gb test,
6992 because it'd evoke spurious failure on 64-bit systems.
6994 2003-07-24 Jim Meyering <jim@meyering.net>
6996 * src/dd.c (usage): Document the fact that SIGUSR1 makes dd
6997 output its current record counts. Reported by Jurriaan.
6999 * tests/wc/Test.pm (test_vector): Disable the `PIPE' tests when running
7000 `wc' with no options. This goes along with the change of 2003-07-20.
7002 2003-07-23 Jim Meyering <jim@meyering.net>
7004 Don't include headers already included by system.h:
7005 * src/tr.c: Don't include errno.h.
7006 * src/true.c: Don't include version-etc.h.
7007 * src/test.c: Don't include limits.h or error.h.
7008 * src/stat.c: Don't include unistd.h or time.h.
7009 * src/readlink.c: Don't include stdlib.h, unistd.h, or limits.h.
7010 * src/pr.c: Don't include time.h.
7011 * src/pathchk.c: Don't include errno.h.
7012 * src/nice.c: Don't include sys/time.h.
7013 * src/ls.c: Don't include stdlib.h.
7015 * basename.c, cat.c, chroot.c, cksum.c, comm.c, csplit.c, cut.c, date.c:
7016 * dd.c, dirname.c, echo.c, env.c, expand.c, expr.c, factor.c, fmt.c:
7017 * fold.c, head.c, hostid.c, hostname.c, id.c, join.c, kill.c, logname.c:
7018 * md5sum.c, nice.c, nl.c, nohup.c, od.c, paste.c, pathchk.c, pinky.c:
7019 * pr.c, printenv.c, printf.c, ptx.c, pwd.c, seq.c, setuidgid.c, shred.c:
7020 * sleep.c, sort.c, split.c, stat.c, stty.c, su.c, sum.c, tac.c, tail.c:
7021 * tee.c, test.c, tr.c, true.c, tsort.c, tty.c, uname.c, unexpand.c:
7022 * uniq.c, uptime.c, users.c, wc.c, who.c, whoami.c, yes.c:
7023 Don't include closeout.h.
7025 * tests/rm/fail-2eperm: Add a check for whether $NON_ROOT_USERNAME
7026 can access the required version of rm.
7027 * tests/rm/Makefile.am (TESTS_ENVIRONMENT): Define PACKAGE_VERSION.
7029 * tests/cut/Test.pm (out-delim3a): New test.
7031 * man/help2man: Update to version 1.33.
7033 * src/expand.c (parse_tabstops): Detect overflow in tabstop sizes.
7035 * src/dircolors.c: Include xstrndup.h.
7036 (xstrndup): Remove function, now that it's been factored out into
7039 2003-07-22 Paul Eggert <eggert@twinsun.com>
7041 * src/wc.c (wc): Fix typo in computation of file from file_x,
7042 which caused the former to be used uninitialized if file_x was
7045 2003-07-22 Jim Meyering <jim@meyering.net>
7047 * src/cut.c (set_fields): Use xcalloc in place of xmalloc+memset.
7049 * man/Makefile.am (.x.1): Substitute 's,$t/$*,$*,' on output of
7050 help2man, to avoid having `rm.td/rm' appear in rm.1. Reported by
7051 Thomas Luzat. See http://bugs.debian.org/202413 for details.
7053 * src/cut.c (main) [lint]: Initialize spec_list_string to avoid warning.
7055 * src/hostid.c: Don't include <unistd.h>. system.h already does that.
7057 * src/cut.c (set_fields): Mark all selected indices before trying to
7058 determine range endpoints.
7059 * tests/cut/Test.pm: New test for the above fix.
7061 Begin to address this comment: What if someone wants to
7062 extract the 1,000,000-th field of some huge input file?
7063 The first step is to rearrange things so that the values
7064 in the printable_field array are all 0/1 rather than 0/1/2.
7065 * src/cut.c (RANGE_START_SENTINEL): Remove.
7066 Store range-start indices in a hash table, rather than
7067 overloading the `printable_field' array.
7068 (range_start_ht): New global.
7069 (hash_int, hash_compare_ints, is_range_start_index): New functions.
7070 (print_kth): Use is_range_start_index; don't test printable_field.
7071 (set_fields): Detect overflow.
7072 (set_fields): Insert each range-start index into range_start_ht.
7073 (main): Call set_fields only once, and only after
7074 output_delimiter_specified and (if required) range_start_ht have
7077 2003-07-20 Paul Eggert <eggert@twinsun.com>
7079 * src/wc.c (get_input_fstatus): Fix typo: `stat' was being
7080 invoked with a null pointer when there were no file arguments.
7082 2003-07-20 Jim Meyering <jim@meyering.net>
7084 * Makefile.maint (sc_changelog): Add another nit-picky check.
7086 * src/wc.c (write_counts): Add a comment.
7087 (wc): Rename `file' parameter.
7088 Set new local, `file', to be the file name, or (when it's NULL)
7089 _("standard output") so that all uses of `file' use the proper value.
7090 Use STREQ, not strcmp.
7092 2003-07-20 Paul Eggert <eggert@twinsun.com>
7094 wc count field widths now are heuristically adjusted depending
7095 on the input size, if known. If only one count is printed, it
7096 is guaranteed to be printed without leading spaces.
7098 Previously, wc did not align the count fields if
7099 POSIXLY_CORRECT was set, but POSIX did not actually require
7100 this undesirable behavior, so it has been removed.
7102 * NEWS: Document this.
7103 * doc/coreutils.texi (wc invocation): Likewise.
7105 * src/wc.c (number_width): New var.
7106 (posixly_correct): Remove.
7107 (struct fstatus): New struct.
7108 (write_counts): Output fields of width number_width.
7109 Do not worry about POSIXLY_CORRECT.
7110 Use null file, not empty-string file, to denote stdin,
7111 since "" is a valid file name on some hosts.
7112 (wc, wc_file): New arg fstatus. Use it to avoid invoking fstat
7114 (wc): Avoid problems if end_pos - current_pos overflows.
7115 Do not print odd message if stdin has a read error.
7116 (get_input_fstatus, compute_number_width): New functions.
7117 (main): Use them to implement the new behavior.
7118 Ignore POSIXLY_CORRECT.
7120 * tests/wc/Test.pm: Adjust to the new output widths.
7122 2003-07-19 Jim Meyering <jim@meyering.net>
7124 * tests/rm/fail-eperm: Don't create temporary directory --
7127 * tests/shred/remove: Don't open-code test for UID != 0.
7128 Use priv-check's require-non-root instead.
7129 Update to use newer framework.
7131 * tests/help-version (expected_failure_status_expr): Record that
7132 expr exits with status of 3 for e.g., a write error.
7134 * tests/priv-check: Use `id -u' to see if we're running as root,
7135 rather than trying go write to an write-protected file.
7136 When running as root, ensure $NON_ROOT_USERNAME is valid.
7137 When running as root with `require-non-root', ensure that `.'
7138 is writable by $NON_ROOT_USERNAME, then reinvoke $0 set-user-ID
7139 to $NON_ROOT_USERNAME. If `.' is not writable, then skip the test.
7141 * src/printenv.c: Include "exitfail.h".
7142 (main): Set exit_failure rather than calling close_stdout_set_status.
7143 * src/date.c: Likewise.
7144 * src/sort.c: Likewise.
7145 * src/tty.c: Likewise.
7147 2003-07-18 Jim Meyering <jim@meyering.net>
7149 * tests/touch/not-owner: Update to use newer framework.
7151 * tests/rm/fail-eperm: Use $srcdir/../priv-check, create a temporary
7152 directory, and remove Perl-coded `you may not run as root' test.
7153 * tests/cp/fail-perm: Use $srcdir/../priv-check, rather than
7154 hard-coding something not quite equivalent.
7155 Paul Jarc reported the inconsistent diagnostics.
7157 * src/sort.c (main): Use close_stdout via atexit.
7158 Now `sort --version' and `sort --help' fail, as they should
7159 when their output is redirected to /dev/full.
7161 * src/su.c (usage): Don't call close_stdout here.
7162 (main): Use close_stdout via atexit.
7163 Now `su --version > /dev/full' fails, as it should.
7164 Somehow, the change of 2000-05-07 that purports to fix this
7167 * tests/help-version (--help/--version vs. /dev/full): Special-case
7168 `[' to protect it from expected_failure_status-`eval'.
7170 * src/uniq.c (writeline): Use a SPACE, not a TAB between the
7171 count and the corresponding line, as required by POSIX.
7172 Reported by Clement Wang.
7173 * tests/uniq/Test.pm (101, 102): Update tests of -c accordingly.
7175 * tests/expr/basic: Add tests for when exit status is 2.
7177 * src/nohup.c (NOHUP_FOUND_BUT_CANNOT_INVOKE, NOHUP_FAILURE):
7178 Use an anonymous `enum', rather than #define.
7180 2003-07-17 Paul Eggert <eggert@twinsun.com>
7182 * src/expr.c: Include "exitfail.h", "quotearg.h".
7183 (EXPR_INVALID, EXPR_ERROR): New constants.
7184 (nomoreargs, null, toarith, nextarg): Return bool, not int.
7185 (syntax_error): New function, exiting with status 2. Use it
7186 insteading of printing "syntax error" ourselves.
7187 (main): Initialize exit_failure to EXPR_ERROR.
7188 Exit with EXPR_INVALID on syntax error (too few arguments).
7189 (nextarg): Use strcmp, not strcoll; strcoll might return
7190 an undesirable 0, or might fail.
7191 (docolon, eval4, eval3): Exit with status 3 on invalid argument type
7192 or other such error.
7193 (eval2): Report an error if strcoll fails in a string comparison.
7194 * src/sort.c: Include "exitfail.h".
7195 (main): Set exit_failure, not xalloc_exit_failure and
7196 xmemcoll_exit_failure.
7197 * tests/expr/basic: Invalid value exits with status 3, not 2.
7199 2003-07-16 Jim Meyering <jim@meyering.net>
7201 * configure.ac (AC_INIT): Use 5.0.90 as the version, rather than 5.0.2,
7202 per GNU maintainer guidelines. The next non-beta release will be 5.1.
7204 This script would have caught at least two recent bugs:
7205 those in [ and kill.
7206 * tests/help-version: Revive this script.
7207 It wasn't doing anything useful, since $all_programs wasn't being
7208 defined by the invoking Makefile.am.
7209 Reflect that nohup is no longer a script, so don't exclude it.
7210 Add framework to handle the programs added since it was last run:
7211 kill, stat, unlink, [, link, readlink.
7212 Fix path-related problems deriving from the move of this script
7213 from src/ to its present location.
7214 * tests/Makefile.am (all_programs): Define.
7215 (TESTS_ENVIRONMENT): Use it.
7217 * src/kill.c (main): Fix bug introduced on 2003-05-10 (for 5.0.1)
7218 whereby kill would always attempt to operate on argv[0] and fail.
7220 * src/test.c (integer_expected_error): Improve diagnostic -- now,
7221 it also matches the one from bash's builtin test.
7222 (binary_operator): Add \n at end of diagnostic.
7224 * tests/rm/fail-2eperm: Remove setuidgid-related code. Move it to ...
7225 * tests/priv-check: Move setuidgid-related and
7226 NON_ROOT_USERNAME-checking code to this file.
7228 * README: Update section on testing as `root'.
7229 Suggestion from Paul Jarc.
7231 * src/test.c (AUTHORS): Replace 3-letter usernames with the actual
7232 names of authors that I just found in bash's builtins/test.def.
7234 Running `[' with no arguments would evoke a segfault.
7235 * src/test.c (main) [LBRACKET]: Move initialization of argv to
7236 precede potential use via test_syntax_error.
7238 * src/Makefile.am (AM_CPPFLAGS): Rename from `INCLUDES', to avoid
7239 warning from automake -Wall.
7241 2003-07-15 Jim Meyering <jim@meyering.net>
7245 * Makefile.maint (%.asc): Remove target first, so gpg doesn't
7248 * announce-gen (print_changelog_deltas): Relax tests for matching
7249 version-number line in NEWS.
7250 Change the .sig suffix to .asc here, too.
7252 2003-07-14 Jim Meyering <jim@meyering.net>
7254 * Makefile.maint (%.asc): Renamed from %.sig.
7255 Generate and use ascii-armored signatures.
7256 Use gpg's -o option.
7258 2003-07-13 Jim Meyering <jim@meyering.net>
7260 * src/nohup.c (NOHUP_FAILURE, NOHUP_FOUND_BUT_CANNOT_INVOKE): Define.
7263 * Makefile.maint (syntax-check): Move each individual check into
7265 (syntax-check-rules): This is the list of syntax-check targets.
7266 (sc_unmarked_diagnostics, sc_cast_of_argument_to_free):
7267 (sc_cast_of_x_alloc_return_value, sc_space_tab):
7268 (sc_error_exit_success, sc_xalloc_h_in_src): New targets.
7270 2003-07-12 Jim Meyering <jim@meyering.net>
7272 * configure.ac: Remove uses of OPTIONAL_BIN_ZCRIPTS and last
7273 traces of the nohup script.
7275 * src/Makefile.am (bin_SCRIPTS): Remove use of just-removed
7276 $(OPTIONAL_BIN_ZCRIPTS).
7278 * src/Makefile.am (localedir.h): Put the `2>&1' after the redirect
7279 target, not before the `>'.
7281 * src/remove.c (remove_dir): Give a diagnostic upon failed save_cwd,
7282 now that that function no longer calls `error'.
7284 * src/df.c (find_mount_point): Emit a diagnostic for each
7285 failed syscall, rather than relying on caller to do that.
7286 The caller couldn't do a good job, anyhow -- too many different
7287 ways to fail (each with a different referent).
7288 Give a diagnostic upon failed save_cwd, now that that function
7289 no longer calls `error'.
7290 (show_point): Don't diagnose find_mount_point's errors, now that
7291 it handles them itself.
7293 * src/df.c (find_mount_point): Don't let free clobber errno upon
7296 * src/sys2.h: Remove alloca-related block.
7297 * src/system.h: Include <alloca.h> here, instead.
7299 It appears that the `#pragma alloca' included via "system.h" is
7300 adequate, since join.c uses alloca, yet lacked an in-file #pragma.
7301 * src/copy.c, src/cp.c, src/df.c, src/install.c, src/ln.c:
7302 * src/ls.c, src/mv.c, src/remove.c: Remove `#pragma alloca'.
7304 * src/chown-core.c (change_file_owner): Do not restore any special
7305 permission bits (e.g., set-user-ID, set-group-ID) that are reset
7306 by chown(2) on some systems. Suggestion and insistence :-) from
7309 * tests/input-tty: Also check `test -t 1'.
7310 This is necessary on linux-2.4.21. Otherwise, the stty/basic-1
7311 test would block when run in the background.
7313 2003-07-11 Jim Meyering <jim@meyering.net>
7315 * tests/sample-test: Also fail if cat-to-create-expected-output
7316 fails. Otherwise, if both `exp' and `out' were to end up empty
7317 because of e.g., a full disk, they would mistakenly compare equal.
7319 * src/nohup.c: New file. Rewrite of nohup.sh in C.
7320 This solves a portability problem: on at least Solaris systems,
7321 when nohup.sh used the vendor /bin/sh, it would exit with status
7322 of `1' rather than the required 126 or 127 upon failure to exec
7323 the specified program.
7325 * src/Makefile.am (EXTRA_SCRIPTS): Remove definition.
7326 (bin_PROGRAMS): Add nohup.
7327 (EXTRA_DIST): Remove nohup.sh.
7328 (all_programs): Remove use of $(EXTRA_SCRIPTS).
7329 * src/nohup.sh: Remove file.
7330 * man/Makefile.am (nohup.1): Depend on nohup.c, rather than nohup.sh.
7332 * tests/misc/nohup: Tests for the above.
7333 * tests/misc/Makefile.am (TESTS): Add nohup.
7335 * src/head.c (diagnose_copy_fd_failure): New function, renamed from
7336 the macro, COPY_FD_DIAGNOSE.
7337 (diagnose_copy_fd_failure): Enclose diagnostic in _(...).
7338 (head_file): Likewise.
7340 * src/date.c: Include "quote.h".
7341 (batch_convert): Use the quote function rather than using literal `...'
7344 * src/setuidgid.c (main): Enclose diagnostic in _(...).
7345 * src/fmt.c (main): Likewise.
7346 * src/mknod.c (main): Likewise.
7347 * src/tac.c (tac_seekable): Likewise.
7348 * src/yes.c (main): Likewise.
7349 * src/od.c (main): Likewise.
7350 * src/install.c (change_attributes): Likewise.
7352 2003-07-10 Jim Meyering <jim@meyering.net>
7354 * src/head.c (usage): Use 1024*1024 in place of 1048576.
7355 * src/tail.c (usage): Likewise.
7357 * tests/rm/fail-2eperm: Now that we have setuidgid, use it in
7358 place of the kludge in this test. Suggestion from Paul Jarc.
7360 * src/Makefile.am (noinst_PROGRAMS): Define to setuidgid.
7361 * src/setuidgid.c: New program, solely for testing (not installed).
7363 * src/chown-core.c (change_file_owner): Don't leak file descriptors
7364 when dereferencing symlinks.
7366 2003-07-09 Jim Meyering <jim@meyering.net>
7368 * tests/du/slash: New file/test for today's lib/ftw.c fix.
7369 * tests/du/Makefile.am (TESTS): Add slash
7371 * src/tail.c (xlseek): Avoid warning about ``return without value
7372 from function returning non-void''.
7374 2003-07-08 Jim Meyering <jim@meyering.net>
7376 * man/help2man: Update to version 1.29.
7378 * man/help2man: Add END handler to close STDOUT and check for errors.
7380 2003-06-30 Paul Eggert <eggert@twinsun.com>
7382 Add support for a "[" that conforms to the GNU coding standards,
7383 i.e., that does not depend on its name.
7384 * src/lbracket.c: New file.
7386 * man/Makefile.am (programs): Ignore "[", since it doesn't have
7387 a separate man page.
7388 * src/Makefile.am (bin_PROGRAMS): Add "[".
7389 (__SOURCES): New var.
7390 * src/test.c (LBRACKET): Define to 0 if not defined.
7391 (main): Use LBRACKET rather than argv[0].
7393 * src/test.c (one_argument): Do not check for -t if POSIXLY_CORRECT.
7394 Reported by Paul Jarc and Dan Jacobson.
7396 * src/test.c (main): Do not recognize --help or --version if
7397 POSIXLY_CORRECT, when invoked as "test". Handle "[ ]" correctly.
7398 Do not bother testing that margv[margc] is non-null.
7400 2003-07-04 Jim Meyering <jim@meyering.net>
7402 * src/who.c (print_line): Rewrite to use asprintf, in order to be
7403 able to avoid emitting trailing spaces. Reported by Dan Jacobson.
7405 * tests/misc/head-elide-tail: Add tests of head's new --lines=-N
7406 option, and perform the +1600 invocations of head IFF the envvar
7407 RUN_EXPENSIVE_TESTS is set.
7409 2003-07-03 Jim Meyering <jim@meyering.net>
7411 * src/cp.c (do_copy): Give a better diagnostic when failing due
7412 to nonexistent destination directory. Reported by Dmitry Rutsky.
7413 See http://bugs.debian.org/199730 for details.
7415 2003-06-27 Jim Meyering <jim@meyering.net>
7417 split's --verbose option did nothing [broken in 4.5.10 and 5.0]
7418 * src/split.c (longopts): Use `1', not `0' as the value for
7419 for &verbose. Reported by Keith Thompson.
7421 Test for the above fix.
7422 * tests/misc/split-a: Also use --verbose and compare stderr
7423 output with what we'd expect.
7425 2003-06-20 Jim Meyering <jim@meyering.net>
7427 * src/copy.c (copy_internal) [HAVE_STRUCT_STAT_ST_AUTHOR]:
7428 Use `error_t' (rather than int) as type for local `err'.
7429 From Alfred M. Szmidt.
7431 2003-06-19 Marcus Brinkmann <marcus@gnu.org>
7433 * src/copy.c (copy_internal) [HAVE_STRUCT_STAT_ST_AUTHOR]:
7434 Fix author preservation code.
7436 2003-06-19 Jim Meyering <jim@meyering.net>
7438 * src/ln.c (ENABLE_HARD_LINK_TO_SYMLINK_WARNING): Define to 0.
7439 (do_link): Don't warn about hard link to symlink.
7441 2003-06-18 Jim Meyering <jim@meyering.net>
7443 * src/cut.c: Include "getdelim2.h", not "getstr.h".
7444 Reflect renaming: getstr -> getdelim2.
7446 * src/comm.c, src/join.c, src/nl.c, src/uniq.c: Reflect renaming:
7447 readline -> readlinebuffer.
7449 2003-06-09 John David Anglin <dave.anglin@nrc-cnrc.gc.ca>
7451 * src/readlink.c: Include <sys/types.h> before system.h (because
7452 the latter includes <sys/stat.h>). Required on Ultrix 4.3.
7454 2003-06-17 Jim Meyering <jim@meyering.net>
7456 * src/system.h (initialize_main): Define.
7457 Use it in every `main'. Applied via this:
7458 p='initialize_main (&argc, &argv);'
7459 perl -ni -e '/program_name.=.argv.0/ and print " '"$p"'\n"; print' \
7460 $(grep -l program_name.=.argv.0 *.c)
7461 test.c uses margc/margv, so I made the change manually for that file.
7462 Based on a patch from Bernard Giroud.
7464 2003-06-09 John David Anglin <dave.anglin@nrc-cnrc.gc.ca>
7466 Fix for build failure on Ultrix 4.3.
7467 * src/stat.c: Include sys/statvfs.h in preference to sys/vfs.h.
7468 Include sys/param.h and sys/mount.h on ultrix.
7470 2003-06-16 Jim Meyering <jim@meyering.net>
7472 * src/touch.c (O_NDELAY, O_NONBLOCK, O_NOCTTY, EISDIR): Remove
7474 * src/system.h (O_NDELAY, O_NONBLOCK, O_NOCTTY, EISDIR): Define
7475 them here instead, but with one change: define EISDIR to -1, not 0.
7477 * src/cat.c (cat): Remove `#ifndef ENOSYS', now that it's
7478 guaranteed to be defined.
7479 * src/system.h (ENOSYS, ENOTSUP): Define to -1 if not defined.
7481 * README: Mention the CVS repository.
7482 Encourage addition of test cases.
7484 2003-06-12 Jim Meyering <jim@meyering.net>
7486 * src/touch.c (touch): Call close only if necessary.
7489 * src/wc.c (usage): Correct wording: wc prints counts in the order
7490 `newline, word, byte'. Reported by Keith M. Briggs.
7491 * man/wc.x: Fix it here, too. And change `lines' to `newlines'.
7493 2003-06-10 Jim Meyering <jim@meyering.net>
7495 * tests/date/Test.pm: Add a test for the new format, e.g., May-23-2003.
7497 2003-06-07 Jim Meyering <jim@meyering.net>
7499 * Makefile.maint (syntax-check): Add commented-out (over-aggressive)
7502 2003-06-06 Jim Meyering <jim@meyering.net>
7504 * src/extract-magic (main): Avoid newer 3-arg form of open,
7505 so this script works also with e.g., perl5.005_03.
7506 Patch by John David Anglin.
7508 2003-06-04 Paul Eggert <eggert@twinsun.com>
7510 * src/system.h: Include <stdbool.h> unconditionally.
7512 2003-06-04 Jim Meyering <jim@meyering.net>
7514 * man/Makefile.am (check-programs-vs-x): Rename target
7515 from check-programs-vs-1. Adjust rule to check for the
7516 primary (.x) file, not the generated one (.1).
7518 2003-06-03 Tim Mooney <mooney@dogbert.cc.ndsu.NoDak.edu>
7520 * man/kill.x: New file.
7521 * man/Makefile.am (dist_man_MANS): Add kill.1.
7524 2003-06-04 Jim Meyering <jim@meyering.net>
7526 Ensure that the .x file for a new program is never forgotten again.
7527 * man/Makefile.am (programs): Define.
7528 (check-programs-vs-1): New phony target.
7529 (check-local): Depend on it.
7531 2003-06-03 Jim Meyering <jim@meyering.net>
7533 Avoid unnecessary copying of environment.
7534 * src/env.c (main): Rather than clearing the environment and --
7535 unless told to ignore environment -- copying all settings from
7536 the saved, original environment, clear the environment only when
7537 that is requested. Suggested by Jens Elkner.
7539 2003-06-02 Jim Meyering <jim@meyering.net>
7541 * src/system.h: Always include <string.h>, since we assume C89.
7542 Include <limits.h> without checking for HAVE_LIMITS_H.
7544 * src/test.c [!TEST_STANDALONE]: Remove #if-0'd block.
7545 (STREQ, S_IXUGO): Remove redundant (in system.h) definitions.
7547 2003-06-01 Jim Meyering <jim@meyering.net>
7549 Avoid a race condition in `tail -f' described by Ken Raeburn in
7550 http://mail.gnu.org/archive/html/bug-textutils/2003-05/msg00007.html
7551 * src/tail.c (file_lines): Add new parameter, *read_pos, and set it.
7552 (pipe_lines, pipe_bytes, start_bytes, start_lines): Likewise.
7553 (tail_bytes, tail_lines, tail): Likewise.
7554 (tail_file): Use the new `read_pos' value as the size,
7555 rather than stats.st_size from the fstat call.
7557 2003-05-28 Jim Meyering <jim@meyering.net>
7559 * src/extract-magic: Allow expansion of `$file' in the here-
7560 document corresponding to the comment at the top of fs.h.
7562 2003-05-26 Jim Meyering <jim@meyering.net>
7564 * src/stat.c: Fix portability problem on FreeBSD5.0: don't include
7565 <sys/statvfs.h> on systems without HAVE_STRUCT_STATVFS_F_BASETYPE.
7566 Use #if/#elif/... cascade so we get only one set of include files.
7567 Reported by Nelson Beebe.
7569 2003-05-24 Jim Meyering <jim@meyering.net>
7571 * src/md5sum.c (split_3): Accept the BSD format only when in MD5 mode.
7572 * tests/sha1sum/basic-1: Make sure `sha1sum --check' doesn't
7573 accept the BSD format.
7575 2003-03-28 Joe Orton <jorton@redhat.com>
7577 * src/md5sum.c (bsd_split_3): New function.
7578 (split_3): Detect checksums from BSD 'md5' command and handle them
7581 * tests/md5sum/basic-1: New tests for --check exit status, and for
7582 BSD-style checksum files.
7584 2003-05-21 Jim Meyering <jim@meyering.net>
7586 * src/head.c (elide_tail_lines_pipe): Fix a thinko.
7587 This sort of thing is why it'd be *Really Good* to factor
7588 out the common code used here and in tail.c.
7590 2003-05-14 Jim Meyering <jim@meyering.net>
7592 * src/head.c (usage): Document new feature: --bytes=-N and --lines=-N.
7594 * tests/du/slink: Skip this test if `.' is on an XFS file system.
7596 * tests/du/fd-leak: New file. Test for the bug in du that
7597 was fixed by the 2003-05-12 change to lib/ftw.c.
7598 * tests/du/Makefile.am (TESTS): Add fd-leak.
7600 * src/head.c (AUTHORS): Enclose string in N_(...), now that it
7601 includes a translatable word, `and'.
7603 * src/dd.c (usage): Don't use `,' as the thousands separator
7604 in e.g. 1,000,000 and 1,048,576. Instead, do this:
7605 `SIZE may be ..., MB 1000*1000, M 1024*1024 and so on...'
7606 * src/df.c (usage): Likewise.
7607 * src/du.c (usage): Likewise.
7608 * src/ls.c (usage): Likewise.
7610 * Makefile.maint (syntax-check): Add another check.
7612 2003-05-13 Paul Eggert <eggert@twinsun.com>
7614 Fix uniq to conform to POSIX, which requires that "uniq -d -u"
7615 must output nothing. Problem reported by Josh Hyman.
7617 * src/uniq.c (enum output_mode, mode): Remove, replacing with:
7618 (output_unique, output_first_repeated, output_later_repeated):
7619 New vars. All uses of "mode" changed to use these variables,
7620 which are not mutually exclusive as "mode" was.
7621 (writeline): New arg "match", used to control whether to
7622 obey output_first_repeated or output_later_repeated.
7623 All callers changed.
7624 (check_file, main): Adjust to above changes.
7626 * tests/uniq/Test.pm: Test that 'uniq -d -u' outputs nothing.
7628 2003-05-14 Jim Meyering <jim@meyering.net>
7630 * tests/rm/rm3: Use tr's \n notation rather than \012.
7631 This package can afford to do that, since its tests are guaranteed use
7632 GNU tr, which has accepted the more modern notation for 10 years.
7633 * tests/rm/rm5: Likewise.
7634 * tests/cp/same-file: Likewise.
7635 * tests/stty/row-col-1: Likewise.
7636 * tests/stty/basic-1: Likewise.
7637 * tests/rm/deep-1: Likewise.
7638 * tests/mv/part-symlink: Likewise.
7639 * tests/mkdir/perm: Likewise.
7640 * tests/misc/nice: Likewise.
7642 2003-05-13 Jim Meyering <jim@meyering.net>
7644 * src/copy.c (struct F_triple) [name]: Remove const attribute.
7645 (triple_free): Don't apply cast to argument of free.
7646 (seen_file): Add cast here instead.
7648 * src/cp-hash.c (struct Src_to_dest) [name]: Remove const attribute.
7649 (src_to_dest_free): Don't apply cast to argument of free.
7651 * src/sort.c (zaptemp): Don't apply cast to argument of free.
7652 * src/pr.c (init_fps, init_store_cols): Likewise.
7653 * src/join.c (delseq, freeline): Likewise.
7654 * src/expr.c (OLD): Likewise.
7655 * src/sort.c (sort): Likewise.
7656 * src/head.c (elide_tail_lines_pipe): Likewise.
7658 * src/tail.c: Include "quote.h".
7659 Use quote in diagnostics. Change many error format strings
7660 from just `%s' to e.g., `error reading %s'.
7661 (pipe_lines): Change type of parameter, n_lines, to uintmax_t.
7662 Rewrite newline-counting loop to use memchr.
7664 * src/head.c (elide_tail_lines_pipe): Use `if', not assert.
7665 Now that assert is no longer used, don't include <assert.h>.
7667 2003-05-12 Jim Meyering <jim@meyering.net>
7669 * src/head.c: Include <assert.h>.
7670 (AUTHORS): Add my name.
7671 (elide_tail_lines_pipe): New function.
7673 2003-05-10 Jim Meyering <jim@meyering.net>
7675 * Makefile.maint (syntax-check): Check for `error (EXIT_SUCCESS,'.
7677 * src/readlink.c (main): Set program_name before first use.
7678 Remove that (redundant) first use.
7679 Don't exit successfully just because --verbose was specified.
7680 Pass 0, not EXIT_SUCCESS, as first argument to error; when that
7681 parameter is 0, error does not exit.
7683 * src/uname.c (main): When failing due to too many arguments, also say
7684 that, rather than just "Try `uname --help' for more information.".
7685 * src/comm.c (main): Likewise, but for too few arguments.
7686 * src/logname.c: Include error.h.
7687 (main): Say why we're failing.
7689 * src/uniq.c (main): Don't segfault when argc < optind.
7690 * src/who.c (main): Handle argc < optind.
7691 * src/df.c (main): Likewise.
7692 * src/install.c (main): Likewise.
7693 * src/mv.c (main): Likewise.
7694 * src/pwd.c (main): Likewise.
7695 * src/tty.c (main): Likewise.
7696 * src/chroot.c (main): Likewise.
7697 * src/hostname.c: Likewise.
7698 * src/du.c (main): Likewise.
7699 * src/expand.c (main): Likewise.
7700 * src/env.c (main): Likewise.
7701 * src/unexpand.c (main): Likewise.
7702 * src/printenv.c (main): Likewise.
7703 * src/sync.c (main): Handle argc == 0.
7704 * src/expr.c (main): Likewise.
7705 * src/printf.c (main): Likewise.
7706 * src/basename.c (main): Likewise.
7707 * src/ln.c (main): Test for `missing argument' before computing n_files.
7708 * src/tail.c (main): Test for the case of no arguments before
7711 * src/kill.c (send_signals): Don't check command line arguments here.
7712 (main): Check them here instead. Handle argc < optind.
7714 * src/logname.c (main): Use error, rather than fprintf, for the sake
7717 * src/rm.c (main): Don't overrun array bound if argc is 0.
7719 2003-05-09 Jim Meyering <jim@meyering.net>
7721 * src/sort.c (main): Don't overrun array bound if argc is 0.
7722 That would happen when invoked via: execl ("/usr/bin/sort", NULL);
7723 Reported by Wartan Hachaturow.
7725 2003-05-07 Jim Meyering <jim@meyering.net>
7727 Implement support so that `head --lines=-N' works on seekable files.
7728 * src/head.c (enum Copy_fd_status): Define.
7729 (COPY_FD_DIAGNOSE): New macro.
7730 (elide_tail_lines_seekable): New funtion.
7731 (elide_tail_lines_file): Call it here.
7733 2003-05-06 Jim Meyering <jim@meyering.net>
7735 * src/sys2.h (CHAR_BIT): Remove duplicate definition.
7737 2003-05-04 Jim Meyering <jim@meyering.net>
7739 * tests/head/Test.pm: Remove tests of --bytes=-N; using that framework
7740 caused the addition of thousands of small files to the tar archive.
7741 * tests/misc/head-elide-tail: New file. Add them here instead.
7742 * tests/misc/Makefile.am (TESTS): Add head-elide-tail.
7744 2003-05-04 Paul Eggert <eggert@twinsun.com>
7746 * src/remove.c (HAVE_WORKING_READDIR): Define to 0 if not defined.
7747 (IF_READDIR_NEEDS_REWINDDIR): Remove.
7748 (remove_cwd_entries): Rewrite to avoid IF_READDIR_NEEDS_REWINDDIR,
7749 which was a bit weird because it couldn't be emulated by a function.
7751 2003-05-03 Jim Meyering <jim@meyering.net>
7753 Extend head to accept --lines=-N (--bytes=-N) and to print all
7754 but the N lines (bytes) at the end of the file.
7755 * src/head.c: Include full-write.h, full-read.h, inttostr.h, quote.h.
7756 Use quote() in diagnostics, rather than literal `' marks.
7757 (copy_fd, elide_tail_bytes_pipe, elide_tail_bytes_file):
7759 (elide_tail_lines_pipe, elide_tail_lines_file): New functions.
7760 (head_file): Reorganize so as to call head from only one place.
7761 (main): Likewise, for head_file.
7762 Handle new, undocumented option, --presume-input-pipe.
7763 Handle negative line and byte counts.
7764 * tests/head/Test.pm: Add lots of tests to exercise --bytes=-N.
7766 * tests/du/8gb: Skip test if the file system of `.' doesn't support
7767 sparse files -- otherwise it'd create a file of size 8GB.
7769 2003-05-02 Jim Meyering <jim@meyering.net>
7771 * src/fmt.c (usage): Don't mention obsolescent -WIDTH option.
7772 Instead explain about `-' and standard input.
7773 (main): Give a proper diagnostic for e.g., `fmt -c -72'.
7774 Reported by Keith Thompson.
7775 * tests/fmt/basic: Add test for the above fix.
7777 * src/fmt.c: Include "quote.h".
7778 Use quote() in diagnostics, rather than literal `' marks.
7779 (main): Exit nonzero when unable to open an input file.
7780 * tests/fmt/basic: Add test for the above fix.
7782 * src/fmt.c (main): Diagnose invalid suffix on obsolescent width
7783 specifications like `-72x'.
7784 * tests/fmt/basic: Add test for the above fix.
7786 Work around nasty readdir bug on Darwin6.5.
7787 * src/remove.c (IF_READDIR_NEEDS_REWINDDIR): Define.
7788 [! HAVE_WORKING_READDIR] (remove_cwd_entries): If readdir has just
7789 returned NULL and there has been at least one successful unlink or
7790 rmdir call since the opendir or previous rewinddir, then call
7791 rewinddir and reiterate the loop.
7793 Factor out common code.
7794 * src/remove.c (readdir_ignoring_dotdirs): New function.
7795 (is_empty_dir): Use it here.
7796 (remove_cwd_entries): Use it here.
7798 2003-05-01 Jim Meyering <jim@meyering.net>
7800 * tests/rm/r-3: Create 500 rather than just 300 files.
7801 There's a bug in Darwin6.5's readdir that shows up only with
7803 Fix a bug in this test: `cd $pwd' (not to `..'), now that $tmp
7807 Change type of n_units, n_bytes, n_lines to be `uintmax_t'.
7808 (dump_remainder): Move two declarations `down' into the scope
7809 where they are used.
7810 (xlseek): Return the resulting offset.
7811 (file_lines): Rename parameter, file_length, to end_pos.
7812 (pipe_lines): Don't coerce safe_read return value to `int'.
7813 Adapt tests accordingly.
7814 (pipe_bytes) [struct charbuffer] (nbytes): Change type from `int'
7816 Change type of `total_bytes' from `int' to `size_t',
7817 since the former wouldn't always be wide enough.
7818 Don't coerce safe_read return value to `int',
7819 and adapt tests accordingly.
7820 Now that testing for a read error no longer involves
7821 using `tmp', handle that case *after* freeing `tmp'.
7822 (start_bytes): Clean up.
7823 (tail_bytes): Now that `n_bytes' may be larger than
7824 OFF_T_MAX, test for that condition and, if it's true, don't
7825 use lseek optimizations.
7826 (parse_options): Don't fail just because N_UNITS is larger than
7827 the maximum size of a file -- tail may be applied to an input
7828 stream (e.g., a pipe) with more data than that.
7830 * Makefile.maint (syntax-check): Rename from alloc-check.
7831 Also check for SPACE-TAB sequences.
7832 Also check for malloc/calloc/realloc casts.
7834 2003-05-01 Jim Meyering <jim@meyering.net>
7836 * src/tail.c (start_lines): Rewrite to use memchr. Clean up.
7838 2003-04-28 Jim Meyering <jim@meyering.net>
7840 * tests/misc/tty-eof: Send two tokens, not just one, so we don't
7841 make the now-more-picky tsort fail.
7843 2003-04-24 Jim Meyering <jim@meyering.net>
7845 * src/tsort.c (tsort): Remove unnecessary test of have_read_stdin.
7846 (main): Minor syntactic clean-up.
7848 * src/tsort.c (tsort): Fail if the input contains an odd number of
7849 tokens. Reported by junkio@cox.net.
7851 * tests/tsort/basic-1: Test for the above fix.
7853 2003-04-21 Jim Meyering <jim@meyering.net>
7855 * tests/misc/printf: Add tests for the printf fixes below.
7857 * Makefile.cfg (cvs_files): Add $(srcdir)/config/depcomp to the list.
7859 2003-04-20 Paul Eggert <eggert@twinsun.com>
7861 Fix printf POSIX compatibility bug reported by Ben Harris in
7862 <http://mail.gnu.org/archive/html/bug-coreutils/2003-04/msg00070.html>.
7863 * doc/coreutils.texi (printf invocation): It's \NNN in the format,
7864 \0NNN in the %b operand.
7865 * src/printf.c (usage): Likewise.
7866 (print_esc): New arg OCTAL0 to specify whether \0NNN or \NNN
7867 is desired. All uses changed. Behave like Bash printf if %b
7868 operand uses \NNN where the initial N is not 0.
7870 2003-04-17 Jim Meyering <jim@meyering.net>
7872 * src/stty.c: Remove uses of PROTOTYPE macro.
7874 2003-04-15 Jim Meyering <jim@meyering.net>
7876 * Makefile.maint: Remove (or replace-with-TAB(s) to retain alignment)
7877 each sequence of spaces before a TAB character.
7879 2003-04-13 Jim Meyering <jim@meyering.net>
7881 * src/remove.c (is_empty_dir): Don't closedir (NULL).
7883 2003-04-12 Jim Meyering <jim@meyering.net>
7885 Giving nl an invalid STYLE argument (in --header-numbering=STYLE (-h),
7886 --body-numbering=STYLE (-b), or --footer-numbering=STYLE (-f)) or
7887 FORMAT (--number-format=FORMAT (-n)) would not give a useful diagnostic.
7888 * src/nl.c (main): Fix those problems and remove literal quote marks
7889 (e.g., "`%s'") from format string; instead use "%s" in each format
7890 string and `quote (optarg)' as the corresponding argument.
7891 Also, diagnose all invalid command line options before failing.
7893 * src/nl.c (proc_text): Fix a bug that would make nl output extra
7894 newlines in some cases. Details here: http://bugs.debian.org/177256.
7895 This bug was introduced on 2001-11-10 for textutils-2.0.17.
7896 * tests/misc/nl: Add test for the above-fixed bug.
7898 * tests/misc/readlink: New file. Test the --canonicalize option.
7899 * tests/misc/Makefile.am (TESTS): Add readlink.
7901 2003-04-11 Jim Meyering <jim@meyering.net>
7904 * src/chown.c, src/cp.c, src/dircolors.hin, src/du.c, src/ln.c:
7905 * src/mkfifo.c, src/ptx.c, src/spline.c, src/stty.c, src/tail.c:
7906 * src/test.c, src/unexpand.c: Remove (or replace-with-TAB(s) to
7907 retain alignment) each sequence of spaces before a TAB character.
7909 * src/ls.c: Include <stdlib.h> unconditionally.
7911 * Makefile.maint (xalloc-check): Rename from header-check.
7913 * src/yes.c: Include error.h after system.h, not before.
7916 * src/copy.c, src/cp-hash.c, src/cp.c, src/csplit.c, src/cut.c:
7917 * src/date.c, src/df.c, src/du.c, src/expand.c, src/expr.c, src/id.c:
7918 * src/join.c, src/md5sum.c, src/nl.c, src/od.c, src/paste.c, src/pr.c:
7919 * src/ptx.c, src/sort.c, src/split.c, src/su.c, src/tail.c, src/tee.c:
7920 * src/tr.c: * src/unexpand.c, src/users.c:
7921 Remove anachronistic casts of xmalloc, xrealloc, and xcalloc
7922 return values and of xrealloc's first argument.
7923 Fix the former with this:
7924 perl -pi -e 's/\([^(]*?\*\) *(x(m|c|re)alloc)\b/$1/'
7926 2003-04-10 Jim Meyering <jim@meyering.net>
7928 * src/stty.c (wrapf): Declare with format attribute.
7930 The S_MAGIC_... names shouldn't be maintained in two places (prior
7931 to this change, one would have to keep stat.c and fs.h in sync).
7932 This change makes it so those names and the corresponding
7933 hexadecimal constants all reside in stat.c. fs.h is now generated.
7934 * src/Makefile.am (fs.h): New rule to generate fs.h from stat.c.
7935 (BUILT_SOURCES): Add fs.h, now that it's generated.
7936 (EXTRA_DIST): Add extract-magic.
7937 * src/extract-magic: New script to extract fs.h definitions from stat.c.
7938 * src/stat.c (human_fstype) [__linux__]: Append each hex constant from
7939 fs.h in a comment after the corresponding `case S_MAGIC_...:' statement.
7941 * tests/tail-2/big-4gb: Skip this test (don't fail) if creating a
7942 file with nominal length > 4GB fails. Reported by Michael Deutschmann.
7944 * man/unexpand.x: Add `SEE ALSO' reference to expand.
7945 * man/expand.x: Add `SEE ALSO' reference to unexpand.
7946 Suggestion from Dan Jacobson.
7948 2003-04-10 Maciej W. Rozycki <macro@ds2.pg.gda.pl>
7950 * src/fs.h (S_MAGIC_DEVPTS): New magic for Linux's devpts.
7951 * src/stat.c (human_fstype): Handle Linux's devpts.
7953 2003-04-09 Paul Eggert <eggert@twinsun.com>
7955 * src/split.c (line_bytes_split): Arg is of type size_t, since
7956 that's all that is supported for now.
7957 (main): Check for overflow in obsolescent line count option.
7959 2003-04-09 Jim Meyering <jim@meyering.net>
7961 * tests/misc/split-fail: Add a new test for the above fix.
7963 * src/split.c (bytes_split): Use size_t temporary (rather than
7964 uintmax_t original) in remaining computations. From Paul Eggert.
7966 Handle command line option arguments larger than 2^31.
7967 This allows e.g., splitting into files of size 2GB and larger,
7968 and running split --lines=N with N=2^31 or more.
7969 But for --line-bytes=N, the restriction that N <= SIZE_MAX
7970 remains (for now), due to the way it is implemented.
7972 * src/split.c: Include "inttostr.h".
7973 (bytes_split, lines_split, line_bytes_split, main):
7974 Use uintmax_t, not size_t, for file sizes.
7975 (main): Give a better diagnostic for option arguments == 0.
7976 Use umaxtostr to print file sizes.
7977 Reported by Luke Hassell.
7979 2003-04-08 Jim Meyering <jim@meyering.net>
7981 * src/rm.c (usage): Mention that --directory (-d) works only
7982 on some systems. Suggestion from Samuel Tardieu.
7984 * tests/basename/basic: Run $PERL to see if it is available,
7985 rather than testing its value.
7986 * tests/sum/sysv, tests/tsort/basic-1, tests/unexpand/basic-1:
7987 * tests/basename/basic, tests/dd/skip-seek, tests/dircolors/simple:
7988 * tests/expr/basic, tests/factor/basic, tests/fmt/basic:
7989 * tests/ls-2/tests, tests/md5sum/basic-1, tests/md5sum/newline-1:
7990 * tests/misc/sort, tests/misc/tty-eof, tests/mv/i-1:
7991 * tests/rm/empty-name, tests/rm/fail-eperm, tests/rm/unreadable:
7992 * tests/seq/basic, tests/sha1sum/basic-1, tests/sha1sum/sample-vec:
7993 * tests/sum/basic-1, tests/seq/basic: Likewise.
7995 * tests/misc/Makefile.am (TESTS): Add split-fail.
7996 * tests/misc/split-fail: New file.
7998 * src/split.c: Rename local variables: nchars -> n_bytes.
7999 (lines_split): Rename local, nlines -> n_lines.
8000 (main): Rename local variable: s/accum/n_units/.
8001 (main): Use STDIN_FILENO, not literal `0'.
8003 2003-04-07 Jim Meyering <jim@meyering.net>
8005 * src/stat.c: Add #include directives for Ultrix 4.4.
8006 Based on a suggested change from Bert Deknuydt.
8008 2003-04-06 Jim Meyering <jim@meyering.net>
8010 * Makefile.maint (makefile-check): New rule.
8011 (local-check): Add it.
8013 2003-04-05 Jim Meyering <jim@meyering.net>
8015 * Makefile.am (nearly all of them):
8016 Use $(VAR) rather than @VAR@, now that we can rely on automake to
8017 emit a definition for each substituted variable.
8018 * tests/Makefile.am.in: Likewise.
8020 * tests/rm/rm5: Add a comment explaining why this test fails when
8021 using Tru64's broken sed.
8022 * tests/rm/rm3: Likewise.
8024 Make `kill -t' output signal descriptions (not `?') on Tru64.
8025 * src/kill.c (sys_siglist): Also check for __sys_siglist.
8026 Patch by Tony Leneis.
8027 * configure.ac: Also check for declaration of __sys_siglist.
8028 Required for Tru64 4.0D, 4.0F, and 5.1.
8029 Reported by Tony Leneis.
8031 2003-04-04 Jim Meyering <jim@meyering.net>
8033 * src/Makefile.am (PERL): Remove unnecessary definition.
8035 Because of inappropriate (but POSIX-mandated) behavior of rename,
8036 `mv a b' would not remove `a' in some unusual cases. Work around
8037 this by unlinking `a' when necessary.
8039 * src/copy.c (same_file_ok): Add an output parameter.
8040 Set it in the offending case.
8041 (copy_internal): When necessary, unlink SRC_PATH and inform caller.
8042 Reported by Ed Avis.
8043 * tests/mv/hard-4: New test for the above.
8044 * tests/mv/Makefile.am (TESTS): Add hard-4.
8046 Clean up rules for automatically generated sources:
8047 * src/Makefile.am (dircolors.h, wheel-size.h, wheel.h, false.c):
8048 Make each generated file be read-only.
8049 Add each file name to BUILT_SOURCES separately.
8050 (MAINTAINERCLEANFILES): Set to $(BUILT_SOURCES).
8052 Put LOCALEDIR macro definition in new file: localedir.h.
8053 * src/Makefile.am (DEFS): Remove definition.
8054 (localedir.h): New rule.
8055 (BUILT_SOURCES, DISTCLEANFILES): Add localedir.h.
8056 * src/system.h: Include "localedir.h".
8058 2003-04-02 Jim Meyering <jim@meyering.net>
8062 * tests/misc/Makefile.am (TESTS): Add false.
8064 * Makefile.maint (TMPDIR): Make sure it's defined.
8065 (my-distcheck): Build in $(TMPDIR), not `.'.
8067 * src/Makefile.am (false.c): Change all occurrences of
8068 `(EXIT_SUCCESS)' to `(EXIT_FAILURE)' so that false exits
8069 unsuccessfully also with --help. Reported by Paul Jarc,
8070 * tests/misc/false: New test for the above.
8072 2003-03-30 Jim Meyering <jim@meyering.net>
8074 * NEWS: Note the location of older NEWS files.
8076 * src/remove.c (is_empty_dir): Don't let a failing closedir
8077 clobber errno. Spotted by Arnold Robbins.
8079 * src/env.c: Fix typo in comment. From Arnold Robbins.
8081 2003-03-29 Jim Meyering <jim@meyering.net>
8085 * README: Note to expect build problems for stat.c on Ultrix 4.3.
8086 Note that there are some harmless test failures when running
8087 `make check' as root on some systems.
8089 2003-03-28 Jim Meyering <jim@meyering.net>
8091 * tests/stty/row-col-1: Skip this test if stty can't get window size.
8092 This happens when connecting to sparc-solaris5.7 via ssh from within
8093 emacs. Reported by Karl Berry.
8095 * tests/du/basic: Use seq, not `yes' to generate 4KB of data.
8096 Otherwise, on systems (DJGPP) that emulate pipes using files,
8097 this test would never complete, waiting for `yes' to terminate.
8098 * tests/du/slink: As above, use seq, not `yes' to generate link target.
8099 * tests/rm/hash: As above, use seq, not `yes' to generate dir name.
8100 Reported by Rich Dawe.
8102 2003-03-27 Jim Meyering <jim@meyering.net>
8104 * src/id.c: Remove Arnold Robbins' obsolete e-mail address
8105 from `written by...' comment, at his request.
8107 2003-03-24 Paul Eggert <eggert@twinsun.com>
8109 Fix buffer overrun problem reported by TAKAI Kousuke, along
8110 with some other POSIX incompatibilities.
8112 * src/printf.c (print_esc): Do not treat \x specially if
8113 POSIXLY_CORRECT. Avoid buffer overrun if the format ends
8114 in backslash. Treat incomplete escape sequences as strings
8115 of characters, as POSIX requires.
8116 (print_formatted): Allow multiple flags. Avoid buffer overrun
8117 if the format is incomplete.
8119 2003-03-24 Jim Meyering <jim@meyering.net>
8121 * tests/misc/printf: Add tests for the above fixes and changes.
8123 2003-03-26 Jim Meyering <jim@meyering.net>
8125 * src/copy.h (struct cp_options): Add a comment.
8127 2003-03-23 Jim Meyering <jim@meyering.net>
8129 * README: Describe problem with 64-bit mode on HPUX 11.x,
8130 with patch for /usr/include/inttypes.h.
8131 * TODO: Plan to add an autoconf test to work around the bug.
8133 2003-03-22 Jim Meyering <jim@meyering.net>
8135 * src/stat.c: Don't include <sys/sysmacros.h>.
8136 That is already done via system.h. Otherwise, the multiple
8137 inclusion would evoke redefinition warnings from Cray's /bin/cc,
8138 aka Cray Standard C Version 4.0.3 (057126) Mar 22 2003 22:02:28.
8139 (human_fstype): Factor some directives `up', out of this function.
8140 Cast away `const' to avoid error from Cray's /bin/cc.
8142 2003-03-20 Jim Meyering <jim@meyering.net>
8144 * announce-gen (print_changelog_deltas): Ensure that a newline
8145 precedes each row of `*'s.
8147 2003-03-20 Jim Meyering <jim@meyering.net>
8151 * src/seq.c (valid_format): Also accept ` ' and `'' as valid
8152 format flag characters.
8153 Do not require that a field width be specified.
8154 Do not fail when given a field width of `0'.
8155 Reported by Dan Jacobson.
8156 * tests/seq/basic: Add new tests for the above-fixed bug.
8158 * src/Makefile.am (all-local): Append $(EXEEXT) to use of `su'
8159 (install-root): Likewise.
8160 (install-exec-local): Likewise.
8161 Based on a patch from Richard Dawe.
8163 2003-03-19 Jim Meyering <jim@meyering.net>
8165 * man/Makefile.am (.x.1): Use $(LN_S) instead of 'ln -s',
8166 because the DJGPP 2.03 port of 'ln -s' doesn't work.
8167 Include $(EXEEXT) in program names.
8168 Since $(LN_S) may degenerate to `cp -p', be careful
8169 to invoke it from the destination directory.
8170 Mostly from Richard Dawe.
8171 * configure.ac: Use AC_PROG_LN_S.
8173 * tests/mv/part-symlink: Unset CDPATH. Otherwise, having the
8174 CDPATH shell variable set could cause this test to fail.
8175 Reported by Karl Berry.
8177 2003-03-18 Jim Meyering <jim@meyering.net>
8179 * src/fmt.c [struct Word] (paren, period, punct, final): Change the
8180 type of each member from bool <MEMBER>:1 to unsigned int <MEMBER>:1.
8181 AIX 5.1's xlc could not compile the former.
8182 Patch by Petter Reinholdtsen. Also reported by Mike Jetzer.
8184 2003-03-17 Richard Dawe <rich@phekda.freeserve.co.uk>
8186 * configure.ac: Include $(EXEEXT) in OPTIONAL_BIN_PROGS'
8187 program names, since automake only adds $(EXEEXT) to programs
8190 2003-03-16 Jim Meyering <jim@meyering.net>
8192 * src/remove.c (rm): Put two local variables in static storage,
8193 so they can't be clobbered by the potential longjmp.
8195 2003-03-15 Jim Meyering <jim@meyering.net>
8197 * Makefile.cfg (gnu_rel_host): Fix code to match the comment
8198 so that a version number with a two-digit component can still count
8199 as an alpha release. Reported by Richard A Downing.
8200 (gnu_rel_host): Define in terms of $(RELEASE_TYPE) instead.
8202 2003-03-14 Jim Meyering <jim@meyering.net>
8204 * src/ansi2knr.c: Remove no-longer-used file.
8205 * src/ansi2knr.1: Likewise.
8207 * Makefile.maint (prev_version_file): Don't use ?= for this particular
8208 assignment, since it causes trouble with old versions of GNU make
8209 (e.g. 3.76.1). The other uses of `?=' are inoffensive. Details here.
8210 http://mail.gnu.org/archive/html/bug-coreutils/2003-03/msg00028.html
8211 Patch from Alexandre Duret-Lutz.
8213 * Use patched automake-1.7.3. Regenerate Makefile.in files in
8214 subdirectories so that each includes a definition of ACLOCAL_M4.
8216 * announce-gen (main): Label the compressed source URLs.
8220 * tests/du/slink: Relax the test for the `local'ness of a file system,
8221 so that now it works also for tmpfs.
8223 * tests/du/hard-link: Transform output from first du, so that this
8224 test doesn't fail on file systems like tmpfs that order directory
8225 entries differently.
8227 2003-03-13 Jim Meyering <jim@meyering.net>
8229 * tests/du/8gb: Work around what appears to be an NFS failure that
8230 would make this test fail on some systems.
8232 2003-03-11 Jim Meyering <jim@meyering.net>
8234 * tests/du/basic: Make the test file exactly 4k bytes long.
8236 * src/split.c (longopts): Don't hard-code `2' here.
8237 Instead, just specify `&verbose', and ...
8238 (main): ... remove the `case 2:' block for --verbose.
8240 * tests/du/basic: Make the test file larger than 64 bytes, so that
8241 we don't immediately disqualify file systems (e.g., NetApp) on which
8242 smaller files take up zero disk blocks. Reported by Vin Shelton.
8244 2003-03-10 Jim Meyering <jim@meyering.net>
8246 Don't segfault for a negative field width or precision in format string.
8247 Note that this is just a stopgap fix. The longer term solution may
8248 involve adapting bash's builtins/printf.def.
8250 * src/printf.c: (UNSPECIFIED): Define.
8251 (print_direc): Use the special value, UNSPECIFIED, to indicate
8252 that field_width or precision has not been specified.
8253 (print_formatted): Fail if field_width or precision is the
8254 special value, UNSPECIFIED.
8255 Reported by Oliver Kiddle <okiddle@yahoo.co.uk>
8257 * src/sys2.h (INT_MIN): Define, if necessary.
8258 * tests/misc/printf: Add a test for the above-fixed bug.
8260 2003-03-09 Jim Meyering <jim@meyering.net>
8262 * src/remove.c (AD_stack_pop): Cast sizeof... to int before
8263 changing its sign. This avoids a warning from gcc on 64-bit systems.
8264 Reported by Bob Proulx.
8265 (pop_dir): Reverse order of sign change and cast, to be consistent
8268 2003-03-08 Jim Meyering <jim@meyering.net>
8270 * tests/Makefile.am (evar-check): Check for POSIXLY_CORRECT not as a
8271 shell variable, but only in the environment. With /bin/sh->bash, the
8272 shell variable is set to `y', and that would cause a spurious warning.
8273 Reported by Bob Proulx.
8275 * tests/Makefile.am (check-root): Remove touch/fifo.
8276 It doesn't appear to have to be run as root.
8278 * tests/rm/fail-2eperm: Rather than simply using the first non-root
8279 user name, make sure that the selected user name has a usable shell.
8280 Reported by Paul Jarc.
8282 Before, when using shred on a device, one had to specify --exact,
8283 or be careful to choose a size that would not be rounded up and
8284 exceed the maximum value; that could result in a failure of
8286 * src/shred.c (do_wipefd): --exact is now the default for non-regular
8287 files. Suggestion from Ben Elliston.
8290 * tests/misc/tty-eof: Require at least version 1.11 of Expect.pm.
8291 Old versions of Expect.pm (e.g., 1.07) lack the log_user function.
8292 Patch by Bob Proulx.
8294 * src/Makefile.am (check-misc): Check for use of `defined' in
8296 Change to $(srcdir) before running grep.
8298 * src/sleep.c: Remove now-unused #include and #define directives.
8300 * src/du.c (process_file): If a file's size is not being counted
8301 e.g., because it's a hard link to a file we've already counted,
8302 then don't print a line for it.
8304 * tests/du/hard-link: New test for the above-fixed bug.
8305 * tests/du/Makefile.am (TESTS): Add hard-link.
8308 * src/du.c: Revert most of the `reorganization' change of 2003-02-20,
8309 and make the two-array approach work.
8311 * tests/du/basic: Correct/add tests for the above fix.
8312 Set LC_ALL, etc., now that we use sort.
8313 Check the block/size of a small file, too.
8314 Correct expected results for simple dir1/dir2/file case.
8315 Add another test of du -S.
8317 2003-03-07 John David Anglin <dave.anglin@nrc-cnrc.gc.ca>
8319 Avoid build failure with gcc on hppa1.1-hp-hpux10.20 (see GCC PR
8320 middle-end/9986). As one of GCC's optimizations, it transforms a
8321 fputs_unlocked call to a fputc_unlocked call when the string is
8322 one character long. However, hpux doesn't have fputc_unlocked.
8324 * expr.c (usage): Use putchar, not fputs, to output a single character.
8325 * ls.c (dired_dump_obstack): Likewise.
8326 * ptx.c (output_one_tex_line, output_one_dumb_line): Likewise.
8327 * stat.c (print_it): Likewise.
8329 2003-03-07 Jim Meyering <jim@meyering.net>
8331 * src/cp.c: Remove everything associated with mmap-stack.c.
8332 This reverts the two changes of 2003-02-21.
8333 * src/du.c: Remove everything associated with mmap-stack.c.
8334 This reverts the change of 2003-02-19.
8336 2003-03-06 Jim Meyering <jim@meyering.net>
8338 * tests/cp/same-file: Unset CDPATH. Otherwise, having the
8339 CDPATH shell variable set could cause this test to fail.
8340 Reported by Karl Berry.
8342 2003-03-05 Jim Meyering <jim@meyering.net>
8346 * src/printf.c (print_esc): Remove pointless comparison of unsigned
8347 integer with zero, to avoid a warning from Intel's ecc.
8348 Reported by Nelson Beebe.
8350 * src/du.c (process_file): Sizes must all be of type uintmax_t.
8351 Otherwise, for files or totals that are too big, numbers would
8352 be truncated. Patch mostly by Michael Stone.
8353 Reported by Ingo Saitz as Debian bug #183210.
8355 * tests/du/8gb: New test for the above-fixed bug.
8356 * tests/du/Makefile.am (TESTS): Add 8gb.
8358 * src/du.c (MAX_N_DESCRIPTORS): Use 3 * UTILS_OPEN_MAX / 4
8359 rather than UTILS_OPEN_MAX - 10.
8361 2003-03-04 Jim Meyering <jim@meyering.net>
8363 * README: Refer new feature discussion to bug-coreutils@gnu.org,
8364 rather than bug-gnu-utils, now that the former is better known.
8365 Suggestion from Göran Uddeborg.
8367 * src/stat.c (usage): Capitalize consistently.
8368 Reported by Göran Uddeborg.
8370 * Makefile.maint (rel-files): Include $(signatures), so that
8371 those files are also copied into $(release_archive_dir).
8373 * src/df.c (find_mount_point): Call error here, now that restore_cwd
8375 * src/remove.c (AD_pop_and_chdir): Likewise.
8377 * tests/Makefile.am (check-root): Add fail-2eperm.
8379 2003-03-03 Jim Meyering <jim@meyering.net>
8381 * src/remove.c (remove_cwd_entries): Include the full filename of
8382 the offending file, not just the basename.
8384 * tests/misc/tty-eof: Set $ME properly.
8386 * Makefile.maint (THIS_VERSION_REGEXP, PREV_VERSION_REGEXP):
8387 Remove now-unused variables.
8388 (tag-prev-version, prev-cvs-tag): Likewise.
8390 * src/remove.c (remove_cwd_entries) [!ROOT_CAN_UNLINK_DIRS]: Give an
8391 accurate diagnostic when failing to remove a file owned by some other
8392 user. Reported by Ivo Timmermans via Michael Stone.
8393 This fixes Debian bug# 178471.
8395 * tests/rm/Makefile.am (TESTS): Add fail-2eperm.
8396 * tests/rm/fail-2eperm: New test, for the above-fixed bug.
8397 Based on a report from Ivo Timmermans.
8399 2003-03-02 Jim Meyering <jim@meyering.net>
8401 * src/copy.c (copy_internal) [un_backup]: When recovering from a
8402 failure to create a hard link, do not remove the entry associating
8403 the source dev/ino with the destination file name.
8404 * tests/mv/Makefile.am (TESTS): Add hard-3.
8405 * tests/mv/hard-3: New test, for the above-fixed bug.
8406 Inspired by a report from Iida Yosiaki.
8408 2003-03-01 Jim Meyering <jim@meyering.net>
8410 * src/df.c (print_header): Don't embed spaces in a separate `Type'
8411 header string. Instead, put `Filesystem' and `Type' headers in the
8412 same string, so translators can use horizontal space as needed.
8413 Reported by Jean Charles Delepine.
8415 2003-02-28 Jim Meyering <jim@meyering.net>
8417 * src/copy.c (copy_internal): When link fails because of an
8418 existing destination file, unlink that file and try again.
8419 Reported by Iida Yosiaki.
8421 * tests/mv/Makefile.am (TESTS): Add hard-2.
8422 * tests/mv/hard-2: New test for the above-fixed bug.
8423 Based on a test case from Iida Yosiaki.
8425 2003-02-26 Jim Meyering <jim@meyering.net>
8427 * tests/du/basic: Don't test du's -b option here. Directory byte
8428 counts are smaller (512 rather than 4096) on at least OSF/1 5.1
8429 and IBM AIX 4.2. Reported by Nelson Beebe.
8431 2003-02-25 Jim Meyering <jim@meyering.net>
8433 * Makefile.maint (announcement): Now that ChangeLog entries
8434 are output by announce-gen, don't do it here.
8435 * announce-gen (print_changelog_deltas): New function.
8438 2003-02-22 Jim Meyering <jim@meyering.net>
8440 * announce-gen: New option: --release-type=TYPE
8441 * Makefile.maint (beta, major): New targets. Remove `release'.
8442 Put them all together on a line.
8443 Pass the release type (via RELEASE_TYPE envvar) to the MAKE
8444 invocation of `announcement'.
8445 (announcement): Invoke announce-gen with --release-type=$RELEASE_TYPE.
8447 * announce-gen: New option: --news=NEWS_FILE.
8448 Extract NEWS entries here, not via rules in Makefile.maint.
8449 * Makefile.maint (announcement): Now that NEWS entries are
8450 extracted by announce-gen, don't do it here.
8451 (news-r1, news-r2): Remove now-unused definitions.
8453 2003-02-21 Jim Meyering <jim@meyering.net>
8457 Merge in changes from autoconf's version of this file.
8458 * Makefile.maint (www-gnu): Define.
8459 (standards.texi-url_prefix): Use $(www-gnu).
8460 (make-stds.texi-url_prefix): Likewise.
8462 * src/cp.c: Include "mmap-stack.h".
8463 (main): Invoke `run' through a macro that (when possible) runs it
8464 with a large, mmap'd stack.
8466 * src/cp.c (run): New function, preparing for the above.
8467 Exit from this function, not from main
8470 * src/du.c: New option: --apparent-size.
8471 (enum) [APPARENT_SIZE_OPTION]: New member.
8472 (long_options): Add it.
8473 (usage): Describe it.
8475 ['b']: Set apparent_size.
8476 David Eisner reported that the behavior of --bytes had changed.
8477 Paul Eggert proposed the use of a new option, --apparent-size.
8479 * src/du.c (apparent_size): New global.
8480 (print_only_size): Reflect the fact that we're printing byte counts,
8481 not ST_NBLOCKSIZE-byte-block counts.
8482 (print_size): Call print_only_size rather than duplicating its code.
8483 (process_file): Accumulate byte counts, rather than block counts.
8485 * src/du.c (process_file): Always reset size_to_propagate_to_parent
8486 for --separate-dirs (-S).
8488 2003-02-20 Jim Meyering <jim@meyering.net>
8490 * Use automake-1.7.3. Regenerate dependent files.
8492 * src/stat.c (print_stat): New format: %B (to print ST_NBLOCKSIZE).
8493 This makes %b (number of ST_NBLOCKSIZE-byte blocks) more useful.
8494 (usage) [%B]: Describe it.
8497 * src/du.c (process_file): Reorganize the code to use only
8498 one `sum' array, and change how -S works back to the way it was
8499 before 2003-01-31. Patch by Bruno Haible.
8501 * tests/du/basic: New test.
8502 * tests/du/Makefile.am (TESTS): Add basic.
8504 * tests/envvar-check: Add checks for the following:
8505 BLOCK_SIZE, DU_BLOCK_SIZE, DF_BLOCK_SIZE, LS_BLOCK_SIZE.
8507 * tests/Makefile.am: Rename phony target envvar-check to evar-check
8508 so as not to conflict with the distributed file by the same name.
8510 * src/du.c (process_file): Set info->skip before any possible return.
8512 Report correct usage for directories, not 0.
8513 * src/du.c (process_file): Return for `file_type == FTW_DPRE'
8514 _before_ recording the dev/ino of a directory.
8515 Reported by Bruno Haible.
8517 Now, df always displays the device file name corresponding to the
8518 listed mount point under `Filesystem'. Before, for an unmounted
8519 block- or character-special file argument, it would display the
8520 command-line argument instead.
8521 * src/df.c (show_disk): Return a value indicating whether
8522 there was a match. Don't try to find a mount point here.
8523 (show_entry): If show_disk doesn't find a match, call show_point.
8525 2003-02-19 Jim Meyering <jim@meyering.net>
8527 * src/du.c: Include "mmap-stack.h".
8528 (du_files): Add prototype with ATTRIBUTE_NORETURN.
8529 Exit from this function, not from...
8531 Instead, if possible, invoke du_files through a macro that
8532 runs it with a large, mmap'd stack.
8534 * src/join.c (usage): Change wording in --help output:
8535 use FILENUM instead of `SIDE' and say what FILENUM means.
8536 Reported by Bernhard Gabler.
8538 * src/df.c (print_header): Rather than using a hard-coded literal
8539 string of spaces matching the length of the English `...Type' header,
8540 output the right number of spaces to match the selected translation.
8541 Reported by Yann Dirson and Jean Charles Delepine as Debian bug 131113.
8543 * src/split.c (bytes_split): Remove unnecessary `else' after break.
8544 (lines_split): Likewise. and correct misleading indentation.
8546 * src/split.c: Include "full-read.h".
8547 (bytes_split, lines_split, line_bytes_split): Use full_read,
8548 not safe_read. The way split was using the latter, a short read
8549 could cause split to terminate before EOF.
8551 * tests/misc/tty-eof: Test all programs that can read stdin,
8552 requiring no arguments and that write to standard output.
8554 * tests/misc/tty-eof: New file. Renamed from ...
8555 * tests/misc/cat-tty-eof: Remove file. Rename to tty-eof.
8556 * tests/misc/Makefile.am (TESTS): Reflect renaming.
8558 2003-02-18 Jim Meyering <jim@meyering.net>
8560 cksum would perform an extra read after encountering EOF
8561 * src/cksum.c (cksum): Exit the loop upon EOF, too.
8562 Patch by Michael Bacarella.
8564 Test for the bug fixed today in cksum, md5sum, and sha1sum.
8565 * tests/misc/cat-tty-eof: Generalize, clean-up, and test for
8566 cat, cksum, md5sum, and sha1sum all in the same loop.
8568 2003-02-14 Jim Meyering <jim@meyering.net>
8570 * src/remove.c: Include "euidaccess.h".
8571 Remove declaration of euidaccess.
8573 2003-02-12 Jim Meyering <jim@meyering.net>
8575 * src/pathchk.c (portable_chars_only): Remove unnecessary `const'
8576 in cast to avoid warning from icc. Reported by Alexandre Duret-Lutz.
8578 2003-02-10 Jim Meyering <jim@meyering.net>
8580 * src/test.c: Don't include group-member.h.
8581 Include euidaccess.h.
8582 (eaccess): Rewrite function to set the real uid and gid temporarily
8583 to the effective uid and gid, then invoke 'access', and then set the
8584 real uid and gid back. On systems that lack setreuid or setregid,
8585 fall back on the kludges in euidaccess. Before, it would not work
8586 for e.g., files with ACLs, files that were marked immutable,
8587 or on file systems mounted read-only. Nelson Beebe raised the issue.
8588 Paul Eggert suggested the new implementation.
8590 2003-02-09 Jim Meyering <jim@meyering.net>
8592 * src/test.c (test_stat): Remove function. It's job is done (only
8593 when necessary) by the wrapper in lib/stat.c. Adjust all uses.
8595 2003-02-08 Jim Meyering <jim@meyering.net>
8599 * tests/mv/part-symlink: Don't assume that the file owner username
8600 length is less than 9 in ls output: instead, omit that field
8601 altogether. Reported by, and suggested fix from, Ferdinand.
8603 * tests/du/restore-wd: New test for just-fixed bug in ftw.c.
8604 * tests/du/Makefile.am (TESTS): Add restore-wd.
8606 * src/rm.c: Correct now-invalid comment about cycle-detection.
8608 2003-02-06 Jim Meyering <jim@meyering.net>
8610 * NEWS: Add entries from old/*/NEWS
8611 from fileutils-4.1 through 4.1.11 and
8612 from sh-utils-2.0 through 2.0.15. Suggestion from Karl Berry.
8616 * src/du.c (process_file): Don't return early for excluded files
8617 or for files whose dev/inode we've already seen.
8619 2003-02-05 Jim Meyering <jim@meyering.net>
8621 * tests/du/exclude: New file.
8622 * tests/du/Makefile.am (TESTS): Add exclude.
8624 2003-02-04 Dmitry V. Levin <ldv@altlinux.org>
8626 * src/who.c (print_boottime, print_deadprocs, print_runlevel):
8627 Fix memory allocation arithmetic.
8629 2003-02-04 Jim Meyering <jim@meyering.net>
8631 `df /dev/block-or-char-device-file--not-mounted' now reports
8632 the name of the file system on which the file resides, usually `/'.
8633 Before, it would leave the `Mounted on' field blank.
8634 * src/df.c (show_disk): Move function to precede find_mount_point.
8635 (show_disk): Add parameter: STATP.
8636 If we don't find a matching device name, then resort to calling
8637 find_mount_point. Reported by Bob Proulx.
8639 2003-02-03 Andreas Schwab <schwab@suse.de>
8641 * tests/rm/cycle: Require non-root.
8642 * tests/rm/isatty: Likewise.
8644 2003-02-02 Jim Meyering <jim@meyering.net>
8648 * man/Makefile.am (check-x-vs-1): Use @PATH_SEPARATOR@, not `:'.
8650 Ensure that there are no offending uses of `:'.
8651 * Makefile.maint (makefile_path_separator_check): New rule.
8652 (local-check): Add it to the list.
8654 2003-02-01 Jim Meyering <jim@meyering.net>
8656 * src/du.c (MAX_N_DESCRIPTORS): Define.
8658 * src/stat.c (G_fail): New global.
8659 (human_time): Diagnose failed localtime, not failed nstrftime.
8660 (main): Fail if G_fail is set.
8662 2003-01-31 Richard Dawe <rich@phekda.freeserve.co.uk>
8664 * tests/basename/Makefile.am: Use @PATH_SEPARATOR@ instead of
8665 hard-coding the path-separator. Also double-quote the new PATH,
8666 to avoid problems when the path-separator is a semi-colon or when
8667 `pwd` contains e.g. a space.
8668 * tests/chgrp/Makefile.am: Likewise.
8669 * tests/chmod/Makefile.am: Likewise.
8670 * tests/chown/Makefile.am: Likewise.
8671 * tests/cp/Makefile.am: Likewise.
8672 * tests/dd/Makefile.am: Likewise.
8673 * tests/dircolors/Makefile.am: Likewise.
8674 * tests/du/Makefile.am: Likewise.
8675 * tests/expr/Makefile.am: Likewise.
8676 * tests/factor/Makefile.am: Likewise.
8677 * tests/fmt/Makefile.am: Likewise.
8678 * tests/install/Makefile.am: Likewise.
8679 * tests/ln/Makefile.am: Likewise.
8680 * tests/ls/Makefile.am: Likewise.
8681 * tests/ls-2/Makefile.am: Likewise.
8682 * tests/md5sum/Makefile.am: Likewise.
8683 * tests/misc/Makefile.am: Likewise.
8684 * tests/mkdir/Makefile.am: Likewise.
8685 * tests/mv/Makefile.am: Likewise.
8686 * tests/od/Makefile.am: Likewise.
8687 * tests/rm/Makefile.am: Likewise.
8688 * tests/rmdir/Makefile.am: Likewise.
8689 * tests/seq/Makefile.am: Likewise.
8690 * tests/sha1sum/Makefile.am: Likewise.
8691 * tests/shred/Makefile.am: Likewise.
8692 * tests/stty/Makefile.am: Likewise.
8693 * tests/sum/Makefile.am: Likewise.
8694 * tests/tail-2/Makefile.am: Likewise.
8695 * tests/touch/Makefile.am: Likewise.
8696 * tests/tsort/Makefile.am: Likewise.
8697 * tests/unexpand/Makefile.am: Likewise.
8699 2003-01-31 Jim Meyering <jim@meyering.net>
8701 * src/stat.c: Include "file-type.h"
8702 (print_human_type): Remove function.
8703 (human_access): Rename from print_human_access. Return a string.
8704 (human_time): Rename from print_human_time. Return a string.
8705 (print_stat): Arrange so that field width and an alignment specifier
8706 are honored for the %A, %F, %x, %y, and %z formats.
8707 [%F]: Use file_type; this gives slightly different file type strings,
8708 e.g., `directory' instead of `Directory' and `regular file' or
8709 `regular empty file' instead of `Regular file'.
8710 Prompted by a report from Richard Dawe that the uses of
8711 S_IFSOCK and S_IFIFO in print_human_time were not portable
8712 to systems using e.g., DJGPP.
8714 2003-01-31 Richard Dawe <rich@phekda.freeserve.co.uk>
8716 * src/stat.c (print_stat): Use S_ISLNK rather than an explicit
8717 test using S_IFMT and S_IFLNK. S_IFLNK may not be defined.
8719 2003-01-31 Jim Meyering <jim@meyering.net>
8721 * src/du.c (main): Upon processing an invalid option or an invalid
8722 --exclude-from or --max-depth option argument, don't exit right away,
8723 in case there are others. Rather record the failure and exit after
8724 processing other options.
8726 * GNUmakefile (TAR_OPTIONS): Set and export, in order to make
8727 tar archive easier to reproduce.
8729 Rewrite to perform directory traversal using nftw.
8731 * src/du.c: Include "dirname.h", "ftw.h", and "quotearg.h".
8732 (AUTHORS): Add self.
8733 (opt_one_file_system): Move global into `main'.
8734 (path, xstat, exit_status): Remove declarations.
8735 (arg_length, suffix_length): New globals.
8736 (G_fail): New global, sort of like the old `exit_status'.
8737 (IS_FTW_DIR_TYPE): Define.
8738 (print_only_size): New function.
8739 (process_file): New function.
8740 (str_init, ensure_space, str_copyc, str_concatc): Remove functions.
8741 (str_trunc, pop_dir, count_entry): Likewise.
8742 (du_files): Rewrite to use nftw.
8744 2003-01-30 Jim Meyering <jim@meyering.net>
8746 * tests/du/trailing-slash: Ensure that du/ftw follows a command-line
8747 symlink-to-directory with -L, even without the trailing slash.
8749 2003-01-27 Jim Meyering <jim@meyering.net>
8751 * src/Makefile.am (check-misc): Check for st_blocks, too.
8753 * src/stat.c (print_stat): Use ST_NBLOCKS rather than `->st_blocks'.
8754 Reported by Richard Dawe.
8756 2003-01-27 Andreas Schwab <schwab@suse.de>
8758 * src/ls.c (quote_name): Add fourth parameter, width, into which to
8759 store the screen columns, and return the number of bytes instead.
8760 (print_dir): Pass NULL as fourth parameter of quote_name.
8761 (print_name_with_quoting): Likewise.
8762 (length_of_file_name_and_frills): Get the width from the fourth
8763 parameter of quote_name instead of return value.
8765 2003-01-27 Jim Meyering <jim@meyering.net>
8767 * src/ls.c (decode_switches): If `dired' is set without
8768 `format == long_format', then silently reset dired. This doesn't
8769 change the behavior of ls (all prior uses of dired were protected
8770 by `&& format == long_format'), and lets us...
8771 (DIRED_INDENT): ... remove the `format == long_format' conjunct.
8772 (PUSH_CURRENT_DIRED_POS): Likewise.
8775 2003-01-22 Jim Meyering <jim@meyering.net>
8777 * tests/du/no-x: New test, for functionality added to lib/ftw.c.
8778 * tests/du/Makefile.am (TESTS): Add no-x.
8780 2003-01-21 Jim Meyering <jim@meyering.net>
8782 * src/remove.c (remove_entry) [ROOT_CAN_UNLINK_DIRS
8783 && HAVE_STRUCT_DIRENT_D_TYPE]: If a file has d_type == DT_UNKNOWN
8784 it may still be a directory -- or not (e.g., with FreeBSD on an
8785 NFS-mounted file system), so resort to calling lstat to find out.
8786 Based on a patch by Michael van Elst.
8788 * tests/cp/same-file: Don't assume that the file owner username
8789 length is less than 9 in ls output: instead, omit that field
8790 altogether. Reported by, and suggested fix from, Ferdinand.
8792 2003-01-20 Jim Meyering <jim@meyering.net>
8794 * tests/date/Test.pm (wide-fmt): New test to demonstrate that
8795 large format widths no longer cause strftime to infloop.
8797 * Makefile.maint (mail_gpg_sign_cookie): Remove now-unused definition.
8799 2003-01-19 Jim Meyering <jim@meyering.net>
8801 * src/readlink.c: Include "canonicalize.h".
8803 2003-01-18 Jim Meyering <jim@meyering.net>
8805 * src/ls.c (Dereference_symlink) [DEREF_COMMAND_LINE_SYMLINK_TO_DIR]:
8807 (enum) [DEREFERENCE_COMMAND_LINE_SYMLINK_TO_DIR_OPTION]: New member.
8808 (long_options): Add option --dereference-command-line-symlink-to-dir.
8809 (main): Make DEREF_COMMAND_LINE_SYMLINK_TO_DIR be the default,
8810 rather than DEREF_COMMAND_LINE_ARGUMENTS, when none of the
8811 -d, -F, -l options is specified.
8812 (decode_switches): Handle --dereference-command-line-symlink-to-dir.
8813 (gobble_file): Honor DEREF_COMMAND_LINE_SYMLINK_TO_DIR.
8814 Change --dereference-command-line (-H) to dereference *all*
8815 command line arguments, including broken symlinks.
8817 2003-01-15 Paul Eggert <eggert@twinsun.com>
8819 Change ls -H back to the way it was yesterday, since this is
8820 compatible with FreeBSD and the POSIX spec is confusing
8821 and somewhat contradictory.
8823 * src/ls.c (DEREF_COMMAND_LINE_ARGUMENTS): Change name back
8824 from DEREF_COMMAND_LINE_SYMLINK_TO_DIR, updating all uses.
8825 (long_options): Change the long option name back.
8826 (usage): Change the usage back.
8827 (gobble_file): When -H is specified, dereference a top-level
8828 arg even if it points to a non-directory.
8830 2003-01-15 Jim Meyering <jim@meyering.net>
8832 * src/ls.c (gobble_file): Fall back on using lstat when required:
8833 when --dereference (-L) is not specified, and
8834 - when operating on a dangling symlink
8835 - when operating on command-line-symlink-to-directories
8836 This fixes numerous problems. Here are examples:
8837 - `ls dangling-symlink' would fail with `no such file...'
8838 Now it prints `dangling-symlink'.
8839 - `ls -i symlink' would mistakenly print the inode of the referent.
8840 Now it prints the inode of the symlink. Likewise for --size (-s).
8841 Based on a patch from Michael Stone.
8842 Reported by Deepak Goel as Debian bug #173793.
8844 Rename ls's --dereference-command-line (-H)
8845 option to --dereference-command-line-symlink-to-dir.
8846 * src/ls.c [enum Dereference_symlink]
8847 (DEREF_COMMAND_LINE_SYMLINK_TO_DIR): Rename from
8848 DEREF_COMMAND_LINE_ARGUMENTS. Update all uses.
8849 (long_options): Rename the long option.
8850 (usage): Say that --dereference-... changes how ls treats
8851 only symlinks to directories specified on the command line.
8853 2003-01-14 Jim Meyering <jim@meyering.net>
8855 * tests/ls/dangle: New file/test, for the above fix.
8856 * tests/ls/inode: Another new file/test, for the above fix.
8857 * tests/ls/Makefile.am (TESTS): Add dangle and inode.
8859 * src/ls.c (gobble_file): Fix a bug introduced in 4.5.4 that made it
8860 so that ls --color would no longer highlight the names of files with
8861 the execute bit set when not specified on the command line.
8862 Patch by Michael Stone. Reported by Stephen Depooter as
8865 * tests/ls-2/tests (color-exe): New test, for the above fix.
8867 2003-01-13 Jim Meyering <jim@meyering.net>
8869 * tests/shred/exact: Also test for just fixed bug with --zero.
8871 * src/shred.c (long_opts): --zero does not require an argument.
8872 Patch by Michael Stone. Reported by Roland Turner as Debian bug 172019.
8874 2003-01-12 Jim Meyering <jim@meyering.net>
8876 * Makefile.maint (cvs-update): Skip any file with local modifications.
8878 * src/unexpand.c (usage): Document --first-only and mention that
8879 --tabs=N (-t) enables --all (-a). Reported by wiregauze@yahoo.com.
8881 2002-12-01 Dmitry V. Levin <ldv@altlinux.org>
8883 * src/df.c: Include "canonicalize.h".
8884 Use canonicalize_file_name unconditionally.
8886 2003-01-09 Jim Meyering <jim@meyering.net>
8888 * README: Add readlink.
8890 2002-11-30 Dmitry V. Levin <ldv@altlinux.org>
8892 * src/df.c: Include "xgetcwd.h".
8893 * src/pwd.c: Likewise.
8895 2002-11-30 Dmitry V. Levin <ldv@altlinux.org>
8897 * src/shred.c: Remove declaration of xstrdup.
8898 We already get it via xalloc.h which is included via system.h.
8900 2002-08-27 Dmitry V. Levin <ldv@altlinux.org>
8902 New program: readlink.
8904 * src/Makefile.am (bin_PROGRAMS): Add readlink.
8905 * src/readlink.c: New file.
8907 * man/readlink.x: New file.
8908 * man/Makefile.am (dist_man_MANS): Add readlink.1.
8909 (readlink.1): New rule.
8911 2003-01-09 Jim Meyering <jim@meyering.net>
8913 When selecting ranges of byte offsets (as opposed to ranges of fields)
8914 and when --output-delimiter=STRING is specified, output STRING between
8915 ranges of selected bytes.
8916 * src/cut.c (RANGE_START_SENTINEL): Define.
8917 (output_delimiter_specified): New global.
8918 (print_kth): Add parameter. Adjust all callers.
8919 (set_fields): Mark each range-start index with RANGE_START_SENTINEL.
8920 (cut_bytes): When requested, output STRING between ranges of
8922 (main): Make a diagnostic a little clearer.
8923 Based on a patch from Jan Nieuwenhuizen.
8925 * tests/cut/Test.pm: New tests for the above.
8927 * src/cut.c (set_fields): Make code agree with comment:
8928 Don't merge abutting ranges like 4- and 2-3. This makes no
8929 difference currently, but is required to support an upcoming change.
8931 2003-01-07 Jim Meyering <jim@meyering.net>
8933 * src/cut.c (set_fields): Fix typo in comment.
8935 * tests/touch/not-owner: New test, mostly extracted from fail-diag.
8936 * tests/touch/Makefile.am (TESTS): Add not-owner.
8937 * tests/touch/fail-diag: Remove the test for non-owner diagnostic.
8938 Now, this tests only the nonexistent-directory diagnostic.
8939 Suggestion from Michael Stone.
8941 * tests/touch/fail-diag: Fix typo: s/ld/ls/.
8943 2003-01-04 Jim Meyering <jim@meyering.net>
8945 * src/copy.h: Remove use of PARAMS.
8946 * src/remove.h: Likewise.
8947 * src/chown-core.h: Likewise.
8949 rm could be tricked into mistakenly reporting a cycle.
8950 * src/remove.c: [cycle_check_state]: New global.
8951 (remove_cwd_entries): Adapt to new semantics of cycle_check.
8952 (rm): Call cycle_check_init and cycle_check_free for each file.
8953 * tests/rm/cycle (rm): New test, for the above fix.
8954 * tests/rm/Makefile.am (TESTS): Add cycle.
8956 When rm detects a cycle, don't abort the entire command,
8957 but rather just the affected command line argument.
8958 * src/remove.c: Include <setjmp.h>
8959 (struct dirstack_state) [current_arg_jumpbuf]: New member.
8960 (remove_cwd_entries): Call longjmp if we detect a cycle.
8961 (rm): Call setjmp here.
8963 * src/remove.c (cycle_check, is_power_of_two): Remove functions.
8964 Instead, include cycle-check.h and use it.
8966 * src/remove.h (struct dev_ino): Remove declaration.
8968 * src/remove.c (remove_cwd_entries): Fix typos in comment.
8970 Don't include trailing /. in diagnostics about directories.
8971 * src/remove.c (full_filename_): When FILENAME is just `.'
8972 and there is a nonempty directory-name part, don't append `/.'.
8973 * tests/rm/unread2: Remove trailing /. from diagnostic.
8974 * tests/rm/rm2: Likewise.
8976 * src/remove.c (struct dirstack_state): Define.
8977 To be used in place of these file-scoped globals ...
8978 (dir_stack, len_stack, Active_dir): Remove globals.
8979 (ds_init, ds_free): New functions.
8980 (full_filename): Define.
8981 (full_filename_): Rename from full_filename.
8983 Begin to make AD_* functions more generic.
8984 * src/remove.c (AD_push_initial): Don't set status to RM_OK here.
8985 (AD_push): Likewise.
8986 (AD_INIT_OTHER_MEMBERS): Define.
8987 (remove_dir): Define the `status' member manually after each
8988 call to AD_push or AD_push_initial.
8990 * src/Makefile.am (check-misc): New rule, to ensure that no more
8991 S_IS* macro definitions sneak into the code.
8992 (check): Depend on check-misc.
8994 * src/remove.c [S_ISLNK]: Don't define. It's already defined in sys2.h.
8995 * src/du.c (count_entry) [S_ISLNK]: Don't define.
8996 * src/shred.c [S_ISLNK, S_ISFIFO, S_ISSOCK]: Don't define.
8998 2003-01-03 Jim Meyering <jim@meyering.net>
9000 * src/true.c: Add copyright.
9001 (AUTHORS): I suppose I've written it.
9003 * src/Makefile.am (false.c): Make the generated file be read-only.
9005 2003-01-04 Jim Meyering <jim@meyering.net>
9007 * src/ls.c: Include "dev-ino.h".
9008 [struct dev_ino]: Remove declaration.
9010 2003-01-02 Jim Meyering <jim@meyering.net>
9012 * src/cp.c (do_copy): Tweak diagnostic to be consistent with the one
9013 from mv: s/missing file arguments/missing file argument/.
9014 With --target-directory=DIR, cp and mv work with a single file argument.
9015 Reported by Karl Berry.
9017 * tests/rm/isatty: Enable this test.
9019 2002-12-31 Jim Meyering <jim@meyering.net>
9021 * src/remove.c (AD_push_initial): Don't set status to RM_OK here.
9022 (AD_push): Likewise.
9023 (AD_INIT_OTHER_MEMBERS): Define.
9024 (remove_dir): Define the `status' member manually after each
9025 call to AD_push or AD_push_initial.
9027 * src/ls.c [struct dev_ino]: Remove definition.
9028 Include "dev-ino.h" instead.
9030 2002-12-28 Jim Meyering <jim@meyering.net>
9032 * tests/du/Makefile.am (TESTS): Add no-deref.
9033 * tests/du/no-deref: New script.
9035 2002-12-23 Jim Meyering <jim@meyering.net>
9037 * src/remove.c (remove_cwd_entries): Fix typo in comment.
9039 2002-12-21 Jim Meyering <jim@meyering.net>
9041 * announce-gen: Generate MML-formatted announcement.
9042 This makes it a *lot* harder to send stale MD5/SHA1 signatures.
9044 2002-12-20 Jim Meyering <jim@meyering.net>
9046 * src/touch.c (touch): Change the wording of a diagnostic so
9047 that it makes sense both when the file exists and when it doesn't.
9048 Suggestion from Michael Stone.
9050 2002-12-18 Jim Meyering <jim@meyering.net>
9052 * src/stty.c (valid_options): Declare to be static.
9054 2002-12-15 Jim Meyering <jim@meyering.net>
9056 * Makefile.cfg: Remove rules related to generating m4/jm-glibc-io.m4.
9058 * src/chmod.c, src/copy.c, src/copy.h, src/cp-hash.h, src/csplit.c:
9059 * src/date.c, src/expr.c, src/fmt.c, src/id.c, src/install.c:
9060 * src/ls.c, src/od.c, src/pathchk.c, src/pr.c, src/remove.c:
9061 * src/shred.c, src/sort.c, src/stat.c, src/stty.c, src/sum.c:
9062 * src/tee.c, src/test.c: Remove all uses of `PARAMS'.
9064 * src/remove.c (PARAMS): Remove definition.
9065 * src/sys2.h: Likewise.
9067 * src/ls.c, src/stat.c, src/date.c: Remove declaration of nstrftime.
9068 Include strftime.h instead.
9070 2002-12-14 Jim Meyering <jim@meyering.net>
9072 * Makefile.cfg ($(url_dir_list)): Use .../coreutils, not .../fetish.
9074 * src/system.h [! HAVE_DECL_MEMRCHR]: Declare memrchr.
9075 This is necessary at least for Irix6.5 when using c89.
9076 Reported by Nelson Beebe.
9078 * tests/misc/Makefile.am (TESTS): Add cat-tty-eof.
9080 * tests/misc/cat-tty-eof: New test.
9082 * src/mknod.c (usage): Specify how major and minor mode numbers
9083 are interpreted. Report forwarded by Kristin E Thomas.
9084 * src/mknod.c: Remove now-redundant usage-specifying comment.
9086 2002-12-13 Jim Meyering <jim@meyering.net>
9090 * tests/du/trailing-slash: Allow for a directory of size `0'.
9091 That happens at least on file systems of type tmpfs on linux-2.4.18.
9093 * announce-gen: New script to begin replacing the commands
9094 associated with the rule here...
9095 * Makefile.maint (announcement): Invoke announce-gen.
9096 * Makefile.am (EXTRA_DIST): Add announce-gen.
9098 * tests/cp/preserve-2: New file/test, for latest fix.
9099 * tests/cp/Makefile.am (TESTS): Add preserve-2.
9101 2002-12-11 TAKAI Kousuke <takai@vlsi.kuee.kyoto-u.ac.jp>
9103 Fix a bug whereby cp would fail to parse an option like
9104 --preserve=mode,ownership.
9105 * src/cp.c (decode_preserve_arg): Advance `comma' to
9106 point the character following the comma.
9108 2002-12-11 Jim Meyering <jim@meyering.net>
9110 * src/pathchk.c (NEED_PATHCONF_WRAPPER): Undefine before defining,
9111 in case it's already defined.
9113 2002-12-09 Jim Meyering <jim@meyering.net>
9115 * tests/touch/fail-diag: Don't get a test failure if /no exists.
9116 Instead, evoke a framework failure if /no-$$ exists.
9117 Reported by Michael Stone.
9119 2002-12-08 Jim Meyering <jim@meyering.net>
9121 * src/du.c (lstat) [! LSTAT_FOLLOWS_SLASHED_SYMLINK]:
9122 Define to rpl_lstat, so that even on systems like Solaris 5.8,
9123 du honors (per POSIX) the trailing slash on an argument referring
9124 to a symlink-to-directory.
9126 2002-12-06 Jim Meyering <jim@meyering.net>
9128 * Use autoconf-2.57. Regenerate dependent files.
9129 * Use automake-1.7.2. Regenerate dependent files.
9131 * src/ls.c (gobble_file): Also stat the file if it's a
9132 regular file and --indicator-style=classify (aka -F).
9133 Thanks to Ed Santiago for opening my eyes.
9135 * tests/ls/file-type: New file. Test for the above.
9136 A test to contrast ls -F and ls --indicator-style=file-type.
9137 * tests/ls/Makefile.am (TESTS): Add file-type.
9139 2002-12-04 Jim Meyering <jim@meyering.net>
9141 * tests/ls/follow-slink: Make sure the symlink was created.
9142 Richard Dawe reported that `ln -s link link' succeeds, but creates
9143 no file on systems running some version of the DJGPP libc.
9145 2002-12-03 Jim Meyering <jim@meyering.net>
9147 * src/Makefile.am (AUTOMAKE_OPTIONS): Remove definition (to ansi2knr)
9148 since this package no longer panders to K&R compilers.
9150 2002-12-02 Jim Meyering <jim@meyering.net>
9152 * tests/du/slink: Skip this test if `.' is on a non-local file system.
9154 * tests/Fetish.pm (_at_replace): Do the substitution only if there's
9155 something to replace.
9157 2002-12-01 Jim Meyering <jim@meyering.net>
9159 * src/stat.c: Don't include <string.h> or <ctype.h>.
9160 That's already done via system.h.
9161 * src/dircolors.c: Don't include <ctype.h>.
9163 2002-11-30 Jim Meyering <jim@meyering.net>
9165 * ls.c (gobble_file): Remove the block of code that caused
9166 `ls --color -F symlink-to-dir' to list the files in
9167 `symlink-to-dir/.'. Now, it prints `symlink-to-dir@', (just
9168 like `ls -F symlink-to-dir') but with the addition of highlighting.
9169 Similarly, `ls --color -dF symlink-to-dir' would print
9170 `symlink-to-dir/'; now it prints `symlink-to-dir@'.
9171 Reported by Jeff Sheinberg as Debian bug #168203.
9172 * tests/ls-2/tests (sl-F-color, sl-dF-color): New tests for the above.
9174 ls is now more efficient: with certain options, it no longer needs
9175 to stat each directory entry on systems with valid dirent.d_type.
9176 * src/ls.c (print_dir): Add DT_LNK and DT_REG.
9177 (main): Make --recursive set format_needs_type, not format_needs_stat.
9178 (gobble_file): Remove a FIXME comment, now that it's fixed.
9180 2002-11-24 Jim Meyering <jim@meyering.net>
9182 * src/du.c (du_files): Don't strip any trailing slash.
9183 Rewrite so that `/' is no longer represented internally as
9185 (count_entry): When appending a file name component,
9186 account for the fact that the current path may end in `/'.
9187 François Pinard reported that `du symlink-to-dir/' was not
9188 equivalent to `du symlink-to-dir/.'. Now it is.
9189 * tests/du/trailing-slash: New file/test, for the above fix.
9190 * tests/du/Makefile.am (TESTS): Add trailing-slash.
9192 2002-11-23 Jim Meyering <jim@meyering.net>
9194 * src/tac.c (output): Declare some local variables to be of type size_t,
9195 rather than `int' to avoid warnings from gcc.
9197 2002-11-21 Paul Eggert <eggert@twinsun.com>
9199 * src/ls.c (decode_switches): Use case-sensitive matching to
9200 decode the QUOTING_STYLE environment variable. This is more
9201 consistent with the documentation, and with --quoting-style.
9203 2002-11-21 Martin Buck <martin.buck@ascom.ch
9205 * src/stty.c (struct speeds): Add support for all baud rates defined
9208 2002-11-19 Jim Meyering <jim@meyering.net>
9210 * tests/sum/sysv: Export LC_ALL=C, to avoid failure when
9211 run in a UTF locale. Report and suggested fix by Bruno Haible.
9212 * tests/fmt/basic: Likewise.
9214 2002-11-17 Jim Meyering <jim@meyering.net>
9216 * configure.ac: Update via autoupdate.
9217 Add `AM_GNU_GETTEXT_VERSION(0.11.5)'.
9219 * src/mv.c (movefile): Don't remove trailing slashes from SOURCE.
9220 Reported by Hans Ginzel.
9222 2002-11-15 Jim Meyering <jim@meyering.net>
9224 * Makefile.cfg (gnu_rel_host): Define.
9225 (url_dir_list): Choose from (alpha|ftp).gnu.org depending
9226 on whether $(VERSION) looks like a major release number.
9228 * Makefile.maint (mail_gpg_sign_cookie): Backslash-escape `#'.
9229 (release): Rename from `alpha'.
9230 (alpha): Depend on release.
9232 * Makefile.maint (signatures): Define with ?=, so it's easy to override.
9234 2002-11-14 Jim Meyering <jim@meyering.net>
9236 * Makefile.maint (mail_gpg_sign_cookie): Make optional.
9237 (announcement): Use the new variable.
9239 * Makefile.maint: Sync with Bison, i.e.:
9240 (po-check): Scan .l and .y files instead of the
9241 .c and the .h files that they generate. This fixes the bug
9242 reported by Tim Van Holder in:
9243 <http://mail.gnu.org/pipermail/bison-patches/2002-November/001352.html>
9244 Look for N_ as well as for _. Try to avoid matching #define for
9248 2002-11-12 Jim Meyering <jim@meyering.net>
9250 * src/ls.c (HAVE_SYMLINKS): Remove unnecessary macro definition.
9251 Replace sole use with equivalent `#ifdef S_ISLNK'.
9252 Inconsistency reported by Dmitry V. Levin.
9254 2002-11-11 Jim Meyering <jim@meyering.net>
9256 * src/stat.c (usage): Transform --help items output via s/ - / /,
9257 so that help2man produces properly formatted man pages.
9258 Reported by Herbert Xu as Debian bug #168400.
9260 2002-11-10 Jim Meyering <jim@meyering.net>
9262 * src/ls.c (sighandler): Handle SIGTSTP specially.
9263 Based on suggestions from Solar Designer and Dmitry V. Levin.
9266 * Makefile.cfg (cvs_files): Define. From autoconf.
9267 (local_updates): Likewise.
9269 * src/ls.c (restore_default_color_handler, sigtstp_handler):
9271 (sighandler): New function, based on the one in sort.c.
9272 (main): Use sigaction, if possible; otherwise signal.
9273 Handle these signals:
9274 SIGHUP, SIGINT, SIGPIPE, SIGQUIT, SIGTERM, SIGTSTP.
9275 Don't register our handler if the signal is already being ignored.
9277 * src/dd.c (interrupt_handler): Use raise, rather than kill+getpid.
9278 * src/csplit.c (interrupt_handler): Likewise.
9279 * src/sort.c (sighandler): Likewise.
9280 (main): Declare `i' and `nsigs' to be unsigned, not int.
9282 2002-11-09 Jim Meyering <jim@meyering.net>
9284 ls --color: restore terminal text color upon signal.
9285 * src/ls.c: Include "full-write.h" and <signal.h>.
9286 (restore_default_color, restore_default_color_handler): New functions.
9287 (sigtstp_handler, put_indicator_direct): New functions.
9288 (main) [print_with_color]: Register signal handlers.
9289 Patch mostly by Solar Designer and Stanislav Ievlev.
9291 Update from autoconf.
9292 * Makefile.maint (AMTAR): Remove definition.
9293 (update, cvs-update, po-update, do-po-update): New rules.
9294 (wget-update): Update (thus renaming to cvs-update).
9295 (automake_repo): Use anoncvs@sources.redhat.com.
9297 2002-11-06 Jim Meyering <jim@meyering.net>
9299 * tests/misc/Makefile.am (TESTS): Add printf-hex.
9301 * tests/misc/printf: Be careful to test the code in this package,
9302 not the shell built-in function.
9304 * src/printf.c (print_esc): A hexadecimal escape sequence has
9305 at most two hex. digits, not three. Reported by Padraig Brady.
9306 (usage): Update description.
9307 * tests/misc/printf-hex: New file/test, for the above fix.
9309 2002-10-07 Paul Eggert <eggert@twinsun.com>
9311 Add support for locale-specific size indications (e.g.,
9312 thousands-separators) and for explicit size suffixes on output.
9314 * doc/coreutils.texi (Block size): Say that:
9315 This affects display format as well as block size.
9316 Fractional block counts are rounded up.
9317 ls file size blocksize defaults to 1.
9318 A block size spec preceded by ' generates thousands separators.
9319 A suffix without a preceding integer generates suffixes.
9320 (tail invocation): 32k -> 32 KiB.
9321 (What information is listed): ls -h is now equivalent to
9322 ls --block-size=human, and ls -H is now equivalent to
9323 ls --block-size=si. Displayed file size is now always affected by
9326 * lib/inttostr.c, lib/inttostr.h, lib/imaxtostr.c, lib/offtostr.c,
9327 lib/umaxtostr.c: New files, taken from GNU tar.
9329 * lib/Makefile.am (libfetish_a_SOURCES): Add imaxtostr.c, offtostr.c,
9331 (EXTRA_DIST): Add inttostr.c.
9333 * lib/human.c, lib/human.h: Rewrite to support locale-specific
9334 notations like thousands separators.
9335 Specify what includer of include.h must include beforehand.
9336 (human_group_digits, human_suppress_point_zero, human_autoscale,
9337 human_base_1024, human_SI, human_B): New enum values.
9338 (human_readable): Rename from human_readable_inexact; put the
9339 options before the sizes. All uses changed. The old human_readable
9340 function has been removed; use inttostr.h instead.
9341 (human_options): Renamed from human_block_size, with new signature
9342 that allows block sizes up to UINTMAX_MAX. All callers changed.
9344 * m4/prereq.m4 (jm_PREREQ_HUMAN): Check for locale.h, localeconv,
9345 AC_HEADER_STDBOOL. No need to check for limits.h since it's in
9346 freestanding C89. No need to check for stdlib.h or string.h since
9347 autoconf does this now.
9349 * src/cksum.c (cksum): Use primitives from inttostr.h, not
9350 human.h, to print large numbers simply.
9351 * src/csplit.c (handle_line_error, parse_patterns): Likewise.
9352 * src/dd.c (print_stats, main): Likewise.
9353 * src/df.c (print_header): Likewise.
9354 * src/factor.c (print_factors): Likewise.
9355 * src/ls.c (print_long_format, print_file_name_and_frills): Likewise.
9356 * src/shred.c (dopass): Likewise.
9357 * src/sort.c (checkfp): Likewise.
9358 * src/sum.c (bsd_sum_file, sysv_sym_file): Likewise.
9359 * src/tail.c (xlseek): Likewise.
9360 * src/wc.c (write_counts, wc): Likewise.
9362 * src/df.c (human_output_opts): New var.
9363 (output_block_size): Now uintmax_t, not int, to handle larger
9364 block sizes. All uses changed.
9365 * src/du.c: Likewise.
9366 * src/ls.c: Likewise.
9368 * src/df.c (print_header): In the header line, prefer SI to human
9369 representation if it's shorter; if neither is shorter, try to
9370 intuit what the user would prefer.
9372 * src/expr.c (inttostr): Remove; use new imaxtostr library
9375 * src/ls.c (file_output_block_size): New var, to distinguish
9376 file sizes from other sizes.
9377 (decode_switches): Set it.
9379 * src/shred.c (OUTPUT_BLOCK_SIZE): remove.
9380 (dopass): When printing progress, use floor for what has been done
9381 so far (since we should be conservative there), and ceiling for
9382 what needs to be done (since that's what other programs use).
9384 2002-10-19 Jim Meyering <jim@meyering.net>
9386 * src/pinky.c (print_heading): Align TTY and Name headings.
9387 Reported by Karl Eichwalder.
9389 2002-10-18 Jim Meyering <jim@meyering.net>
9391 * src/split.c (cwrite): Change type of `bytes' parameter to size_t
9392 Remove now-useless cast.
9393 (stdread): Remove function.
9394 (bytes_split): Use size_t instead of int.
9395 Use safe_read, not stdread.
9396 (lines_split): Likewise.
9397 Use memchr rather than a `while' loop.
9398 (line_bytes_split): Use size_t instead of int.
9399 Use safe_read, not stdread.
9400 (main): Add some FIXME comments to remind me to remove casts.
9402 * src/system.h (ST_BLKSIZE): Correct comment describing how to
9403 reproduce HPUX-11 cat failure. From Petter Reinholdtsen.
9405 2002-10-17 Jim Meyering <jim@meyering.net>
9407 Fix a problem that could make e.g., `cat' misbehave on systems which
9408 give invalid (unreasonably large) values for stat.st_blksize.
9409 * src/system.h (ST_BLKSIZE): Ensure that the result is in [1..4MB].
9410 Reported by Petter Reinholdtsen.
9412 2002-10-14 Jim Meyering <jim@meyering.net>
9414 Specifying a printf conversion specifer as nl's separator string
9415 could cause nl to segfault.
9416 * src/nl.c (build_print_fmt): Don't include separator string
9417 in the printf format; it might contain `%'.
9418 Use a better bound on the length of the print_fmt buffer.
9419 (print_lineno): Print the separator here instead.
9420 Reported by Doug Coleman.
9422 * tests/misc/nl: New file/tests, including a test for the above.
9423 * tests/misc/Makefile.am (TESTS): Add nl.
9425 * tests/misc/split-l: New test, to make sure `split --lines=N' works.
9426 * tests/misc/Makefile.am (TESTS): Add split-l.
9428 2002-10-13 Jim Meyering <jim@meyering.net>
9432 * src/du.c (usage): Tweak description of --dereference-args/-D.
9434 * src/du.c (count_entry): Also save cwd when dereferencing (via
9435 --dereference-args, -D) a command-line argument.
9436 Reported by Michal Svec. Based on a patch by Andreas Schwab.
9438 * src/Makefile.am (../AUTHORS): New target/rule.
9440 2002-10-12 Jim Meyering <jim@meyering.net>
9442 * src/paste.c (paste_parallel): Declare local, `delims_saved', to be
9443 of type size_t, since that's the way it's used and avoids a warning.
9445 * src/csplit.c (struct cstring) [len]: Declare to be unsigned int,
9446 since that's how it's always used and avoids a new warning from gcc.
9447 (read_input): Adapt to new safe_read ABI.
9449 * src/cut.c (cut_fields): Add a temporary size_t variable, n_bytes,
9452 * src/pinky.c (print_long_entry): fread returns size_t.
9453 Declare local `bytes' accordingly, to avoid warning.
9455 tail -c +N would perform an extra read after encountering EOF
9456 [this change is analogous (bytes vs. lines) to the one of 2002-01-27]
9457 * src/tail.c (start_bytes): Detect EOF, inform caller.
9458 (tail_bytes): Upon EOF in start_bytes, return immediately.
9459 (file_lines): Reorganize to use memrchr rather than an explicit loop.
9460 Adapt to new safe_read ABI.
9462 2002-10-11 Jim Meyering <jim@meyering.net>
9464 * tests/du/deref: New file/test, for the above fix.
9465 * tests/du/Makefile.am (TESTS): Add deref.
9467 2002-10-10 Jim Meyering <jim@meyering.net>
9469 * tests/ln/Makefile.am (TESTS): Add target-1.
9470 * tests/ln/target-1: New file/test, for the fix on 2002-10-08.
9472 2002-10-09 Jim Meyering <jim@meyering.net>
9474 * tests/cp/backup-is-src: Ensure that certain environment variables
9475 are not set (e.g., SIMPLE_BACKUP_SUFFIX). Reported by Duncan Roe.
9477 * tests/tail-2/big-4gb: Mark this as an expensive test; it would
9478 consume 4GB of disk space on systems without support for sparse files.
9479 Fix a logic error that'd make it `cat err' even though dd didn't fail.
9481 * src/dircolors.hin (.jar): Fix typo: s/;3$/;31/.
9482 Patch by steven@magelico.net, forwarded by Michael Stone.
9484 * tests/ls/dired: Ensure that ls produces English messages.
9485 Patch by Alexey Vyskubov, forwarded by Michael Stone.
9487 2002-10-08 Dmitry V. Levin <ldv@altlinux.org>
9489 * src/ln.c (main): Fix target_directory parsing when n_files == 1.
9491 2002-10-08 Jim Meyering <jim@meyering.net>
9493 * tests/tail-2/big-4gb: Use double quotes around diagnostic.
9494 Fix syntax in test: use =, not ==.
9495 Reported by Bob Proulx.
9496 Change all the rest like this: grep -lR "testing framework'" .\
9497 |xargs perl -pi -e 's/'\''(\$0: failure in testing framework)'\''/"$1"/'
9499 * src/sum.c (sysv_sum_file): Adapt to new safe_read ABI.
9500 * src/tr.c (squeeze_filter, read_and_delete, read_and_xlate): Likewise.
9501 * src/tac.c (save_stdin, tac_stdin_to_mem): Likewise.
9502 * src/wc.c (wc): Likewise.
9504 2002-10-07 Paul Eggert <eggert@twinsun.com>
9507 Don't advance the write pointer past the end of the write buffer.
9508 * src/sort.c (begfield, limfield): Likewise.
9510 2002-10-07 Jim Meyering <jim@meyering.net>
9512 * src/cat.c (simple_cat, cat): Adapt to new safe_read ABI.
9513 * src/head.c (head_bytes, head_lines): Likewise.
9515 2002-10-06 Jim Meyering <jim@meyering.net>
9517 * src/dd.c (scanargs): Ensure that specified block sizes (specified
9518 via ibs=N, obs=N, and bs=N) are no larger than SSIZE_MAX.
9519 (skip, dd_copy): Adapt to new safe_read ABI.
9521 * Makefile.maint (signatures): Define.
9523 (announcement): Depend on $(signatures).
9525 * Makefile.maint (announcement): Output all URLs for detached
9526 signatures, not just the last one from the previous loop.
9528 2002-10-05 Jim Meyering <jim@meyering.net>
9532 * src/remove.c (remove_entry) [ROOT_CAN_UNLINK_DIRS]: With `rm -i DIR',
9533 don't recurse into directory, DIR. Prompted by a report from
9536 * tests/rm/i-no-r: New file/test, for the above fix.
9537 * tests/rm/Makefile.am (TESTS): Add i-no-r.
9539 * tests/tail-2/big-4gb: New file/test, for the fix of 2002-09-27.
9540 * tests/tail-2/Makefile.am (TESTS): Add big-4gb.
9542 2002-10-03 Jim Meyering <jim@meyering.net>
9544 * src/rm.c (AUTHORS): Mark translatable string with `N_ (...)'.
9545 * src/df.c (AUTHORS): Likewise.
9546 * src/du.c (AUTHORS): Likewise.
9547 * src/tail.c (AUTHORS): Likewise.
9548 * src/touch.c (AUTHORS): Likewise.
9550 2002-10-02 Jim Meyering <jim@meyering.net>
9552 * Makefile.am (SUBDIRS): Remove `old'.
9553 (EXTRA_DIST): List the files in old/.
9554 * configure.ac (AC_CONFIG_FILES): Remove old/* names.
9555 Suggestion from Akim Demaille.
9557 2002-10-01 Jim Meyering <jim@meyering.net>
9559 * src/sys2.h (SSIZE_MAX): Define.
9561 2002-09-30 Jim Meyering <jim@meyering.net>
9563 * src/csplit.c: Don't include stdlib.h here. It's already included
9566 2002-09-29 Jim Meyering <jim@meyering.net>
9568 * src/tr.c (find_bracketed_repeat): Rearrange pointer/integer
9569 expression to avoid bogus warning from gcc.
9571 * src/cat.c (simple_cat): Use a temporary to avoid bogus warnings.
9572 (cat): Declare insize and outsize to be of type size_t, not int.
9573 Rearrange pointer/integer expressions to avoid bogus warnings.
9574 (main): Declare insize and outsize to be of type size_t, not int.
9576 * src/tail.c (parse_options): Give a sensible diagnostic for
9577 an invalid byte or line count. Reported by Mikko Tuumanen.
9579 * src/touch.c (main): Split a long line.
9581 * tests/du/Makefile.am (TESTS): Add slink.
9582 * tests/du/slink: New test for system.h change of 2002-08-31.
9584 In move mode, always first try to rename. Before, upon failure to
9585 rename a directory, this code would never attempt to rename any
9586 other file in that directory, but would thenceforth always copy.
9587 On some systems (e.g., NetApp's OnTap-6.4), renaming a directory
9588 may fail with EXDEV, yet renaming files within that directory to
9589 a newly-created destination directory succeeds.
9590 * src/copy.c (copy_internal): Remove local, move_mode;
9591 use x->move_mode instead. Based on a patch from Tom Haynes.
9593 2002-09-28 Jim Meyering <jim@meyering.net>
9595 * src/split.c (FAIL_ONLY_ONE_WAY): New macro.
9596 Factor out some duplication.
9598 [case 'a']: Use strtoul rather than strtol to avoid compiler warnings.
9600 * src/sort.c (begfield, limfield): Rearrange comparisons to avoid
9602 (fillbuf, keycompare): Cast literal `-1' to size_t in comparisons,
9603 to avoid compiler warnings.
9605 * src/shred.c (dopass): Use a uintmax_t temporary to avoid bogus
9608 Fix things so `mkdir -p' can create very deep directories, e.g.,
9609 mkdir -p $(perl -e 'print "a/" x 40000') now works.
9610 * src/mkdir.c (main): For --parents (-p), call make_path with the
9611 entire directory name, so we don't ever require that file operations
9612 like stat or chmod be performed on the entire command line argument.
9613 * makepath.c (make_path): Restore umask *before* creating the final
9616 2002-09-27 Andreas Schwab <schwab@suse.de>
9618 * src/tail.c (tail_bytes): Change type of bytes_remaining to off_t
9619 to avoid overflow. Reported by Hans Lermen.
9621 2002-09-26 Jim Meyering <jim@meyering.net>
9623 * src/install.c (get_ids): Use strtoul, not strtol. Remove some casts.
9625 2002-09-25 Jim Meyering <jim@meyering.net>
9627 * src/test.c (eaccess): Change type of local `euid' from int to uid_t
9628 and add a cast, to avoid a warning about `signed and unsigned type in
9629 conditional expression'.
9631 2002-09-22 Jim Meyering <jim@meyering.net>
9633 * src/rmdir.c: Include "dirname.h", for declaration of
9634 strip_trailing_slashes.
9636 * src/stat.c (PRIdMAX, PRIuMAX): Remove definitions.
9637 Now they're defined through system.h.
9639 * src/cp-hash.c, src/dd.c, src/df.c, src/du.c, src/ls.c,
9640 * src/stat.c, src/wc.c: Remove all inclusions of inttypes.h,
9641 since it's already included from sys2.h via system.h.
9643 * Use automake-1.6f. Regenerate dependent files.
9645 * src/Makefile.am (PERL): Remove duplicate definition.
9647 fmt's -s, -t, -c options didn't work properly for long lines.
9648 Since get_line may end up calling put_paragraph (for long lines),
9649 be sure to set global, `other_indent', before it is used there.
9651 * src/fmt.c (set_other_indent): New function, factored out of...
9652 (get_paragraph): ... here. Call it.
9653 (get_line): Call set_other_indent before calling flush_paragraph,
9654 which calls fmt_paragraph, which in turn calls put_paragraph,
9655 which uses other_indent.
9657 * tests/fmt/Makefile.am (TESTS): Add long-line.
9658 * tests/fmt/long-line: New file/test, for the above fix.
9660 2002-09-21 Jim Meyering <jim@meyering.net>
9662 * src/od.c: No longer include deprecated <values.h>.
9663 It was required solely for now-removed reference to BITSPERBYTE.
9664 * src/install.c: Likewise.
9665 Suggestion from Bruno Haible.
9667 2002-09-06 Andreas Schwab <schwab@suse.de>
9669 `rmdir -p dir-specified-with-trailing-slash/' would fail.
9670 * src/rmdir.c (remove_parents): Strip trailing slashes.
9672 2002-09-20 Jim Meyering <jim@meyering.net>
9674 * tests/rmdir/t-slash: New file/test, for the above fix.
9675 * tests/rmdir/Makefile.am (TESTS): Add t-slash.
9677 * Makefile.maint (announcement): Arrange to gpg-sign the message.
9678 Add a URL for each detached signature file.
9680 2002-09-07 Bruno Haible <bruno@clisp.org>
9682 * configure.ac: Add need-ngettext to AM_GNU_GETTEXT invocation.
9684 2002-09-18 Jim Meyering <jim@meyering.net>
9686 `od -t x8' used the wrong (`l'-prefixed) printf format.
9687 Likewise for the o8 and u8 formats.
9688 * src/od.c (ISPEC_TO_FORMAT): Define macro.
9689 (decode_one_format): Use PRIdMAX, PRIoMAX, etc. for LONG_LONG.
9690 Reported by Arun Sharma.
9692 2002-09-17 Jim Meyering <jim@meyering.net>
9694 * src/sys2.h (PRIdMAX, PRIoMAX, PRIuMAX, PRIxMAX): Define if necessary.
9695 From gettext's intl/loadmsgcat.c.
9697 * tests/od/x8: New file/test, for the above fix.
9698 * tests/od/Makefile.am (TESTS): Add x8.
9700 2002-09-15 Jim Meyering <jim@meyering.net>
9702 * Use autoconf-2.54. Regenerate dependent files.
9704 * src/csplit.c (get_format_width): Add cast to avoid
9705 warning about `signed and unsigned type in conditional expression'.
9707 2002-09-14 Jim Meyering <jim@meyering.net>
9709 * src/who.c (print_user): Change type of local to size_t
9710 to avoid warnings about `comparison between signed and unsigned'.
9711 * src/ptx.c (generate_all_output): Likewise.
9713 * src/dd.c (main, skip): Add casts to avoid warnings about
9714 `comparison between signed and unsigned'.
9716 * src/id.c (print_full_info, print_group_list): Add casts to avoid
9717 warnings about `signed and unsigned type in conditional expression'.
9719 * src/md5sum.c: Change type of global, digest_hex_bytes, to size_t
9720 to avoid warnings about `comparison between signed and unsigned'.
9721 (split_3): Change parameter names to be readable and add comment.
9722 Clean up the test for whether a line may be ignored.
9724 2002-09-13 Jim Meyering <jim@meyering.net>
9726 * src/printf.c (main): Handle leading command line argument of `--'.
9727 Reported by Raul: DervishD <raul@pleyades.net>
9728 * tests/misc/printf: New file: test for the above.
9729 * tests/misc/Makefile.am (TESTS): Add printf.
9731 * src/date.c (usage): Explain that %S's range of [0..60] is required --
9732 rather than 0..59 -- to accommodate the occasional positive leap second.
9733 Reported by Richard Neill.
9735 2002-09-12 Jim Meyering <jim@meyering.net>
9737 * src/Makefile.am (nanosec_libs): Define.
9738 (sleep_LDADD, tail_LDADD): Use it here.
9740 Factor nanosleep-related code into ../lib/xnanosleep.c.
9741 * src/sleep.c: Include xnanosleep.h.
9742 Factor out fenv.h-related code.
9743 (timespec_subtract): Remove function.
9744 (main): Remove code that deals with computing start and stop times
9745 as well as the loop around nanosleep. Now that's in xnanosleep.c.
9747 Allow S (in --sleep-interval=S) to be a floating point value.
9748 * src/tail.c: Include xnanosleep.h and xstrtod.h.
9749 Move declaration of global variable, sleep_interval, to ...
9751 (usage): Update description of --sleep-interval option.
9752 (tail_forever): New parameter, sleep_interval. Update caller.
9753 Use xnanosleep, rather than sleep.
9754 (parse_options): New parameter, sleep_interval. Update caller.
9755 Use xstrtod, now that we accept floating point values.
9756 Prompted by a patch from Augey Mikus.
9758 2002-09-06 Jim Meyering <jim@meyering.net>
9760 * src/remove.c (prompt): Change comment to give a better note to
9761 translators. From Michael Piefel.
9763 2002-09-02 Jim Meyering <jim@meyering.net>
9765 * README: A good problem report/patch includes diffs against
9766 the most recent test release.
9768 * src/pathchk.c (NEED_PATHCONF_WRAPPER): Define.
9769 (pathconf_wrapper): Define only if NEED_PATHCONF_WRAPPER is set.
9771 * src/kill.c (print_table_row): Use an unsigned type for widths
9772 to avoid warning about comparison between signed and unsigned.
9773 (list_signals): Likewise.
9775 * src/od.c (skip): Add a cast to avoid warning about comparison
9776 between signed and unsigned.
9777 * src/install.c (get_ids): Likewise. Also rearrange range-checking
9778 comparisons to make them more readable.
9780 2002-09-01 Jim Meyering <jim@meyering.net>
9784 2002-08-31 Jim Meyering <jim@meyering.net>
9786 Symlinks were always reported as using 0 blocks.
9787 * src/system.h (ST_NBLOCKS): Don't depend on file type.
9788 This reverts the change of 2000-01-30.
9789 Based on a report and patch from Neil Brown via Michael Stone.
9790 This fixes Debian Bug#156358.
9792 * Most files: Change `exit (0)' to `exit (EXIT_SUCCESS)',
9793 `exit (1)' to `exit (EXIT_FAILURE)', and
9794 `usage (1)' to `usage (EXIT_FAILURE)'.
9796 * chgrp.c, chmod.c, chown.c, chroot.c, cp.c, date.c, dd.c, du.c,
9797 * hostname.c, id.c, install.c, ln.c, mkdir.c, mkfifo.c, mknod.c,
9798 * nice.c, pinky.c, printf.c, pwd.c, shred.c, sleep.c, stty.c,
9799 * su.c, tac-pipe.c, tail.c, tee.c, touch.c, uname.c, uptime.c,
9800 * users.c, who.c: Change `error (1, ...' to `error (EXIT_FAILURE, ...'.
9801 But don't change `error (0, ...' to `error (EXIT_SUCCESS, ...', since
9802 error never exits successfully.
9804 2002-08-29 Jim Meyering <jim@meyering.net>
9806 * src/remove.c (remove_cwd_entries): Use closedir (not CLOSEDIR)
9807 when ignoring any return value.
9809 * src/remove.c (remove_cwd_entries): Detect and diagnose readdir
9810 failures. On some systems (at least EMC Celerra and Solaris5.8),
9811 this appears to be necessary.
9812 (is_empty_dir): Likewise. Also, always close directory handle.
9813 * src/ls.c (print_dir): Likewise.
9814 (print_dir): Rename local variable: reading -> dirp.
9815 Reported by Mike Coleman.
9817 2002-08-28 Jim Meyering <jim@meyering.net>
9819 * src/remove.c (remove_cwd_entries): Use CLOSEDIR, not closedir.
9820 Give a diagnostic and fail if closedir fails.
9822 2002-08-26 Jim Meyering <jim@meyering.net>
9824 * Makefile.am (THANKS-to-translators): New rule.
9825 (EXTRA_DIST): Add both THANKS-to-translators and THANKStt.in.
9826 * THANKStt.in: New file.
9828 * src/cat.c (close_stdout_wrapper): New, kludgey, function and
9830 (main): Register it with atexit.
9831 Close STDOUT_FILENO, to avoid a problem when writing to
9832 /dev/audio on at least Solaris 5.7 and 5.8 systems.
9833 Reported by Shing-Shong Shei.
9835 2002-08-25 Jim Meyering <jim@meyering.net>
9837 * src/cat.c (main): Close STDIN_FILENO rather than a literal `0'.
9838 * src/tac.c (main): Likewise.
9839 * src/tail.c (main): Likewise.
9840 * src/tee.c (main): Likewise.
9841 * src/tr.c (main): Likewise.
9842 * src/wc.c (main): Likewise.
9844 2002-08-20 Jim Meyering <jim@meyering.net>
9846 * tests/mv/setup: Rewrite not to use `: ${VAR=not_set}' paradigm.
9848 2002-08-10 Paul Eggert <eggert@twinsun.com>
9850 * src/nohup.sh: Don't use "exec --"; it's not portable and
9851 shouldn't be needed.
9853 2002-08-09 Jim Meyering <jim@meyering.net>
9855 * src/pr.c (main): Don't ignore -COLUMN if it's the last option.
9856 (usage): Clarify help text for the -COLUMN option.
9857 Patch by Padraig Brady.
9858 * tests/pr/Test.pm [col-last]: New test for the above.
9860 * configure.ac: Start with version 4.5.1, chosen so that it's larger
9861 than the latest version numbers of the component packages.
9863 * man/Makefile.am (check-x-vs-1): Set and export PATH so we use
9866 2002-08-08 Jim Meyering <jim@meyering.net>
9868 * src/date.c: Guard inclusion of <langinfo.h> with
9869 `#if HAVE_LANGINFO_CODESET', not `#if HAVE_LANGINFO_H'.
9870 * src/sort.c: Likewise.
9871 Patch by GOTO Masanori.
9873 2002-08-05 Paul Eggert <eggert@twinsun.com>
9875 Fix some minor time-related bugs with POSIX time arguments.
9876 Some valid time stamps were being rejected (notably -1, and
9877 time stamps before 1900 on 64-bit hosts). And some invalid
9878 time stamps were being accepted, e.g. September 31.
9880 * src/date.c (main): Adjust to posixtime signature change.
9881 * src/touch.c (main): Likewise. Remove unnecessary initialization.
9882 Use localtime, not posixtm, to warn about obsolete "touch".
9884 2002-08-05 Jim Meyering <jim@meyering.net>
9886 * tests/misc/Makefile.am (TESTS): Add nice and pathchk1.
9888 2002-08-04 Jim Meyering <jim@meyering.net>
9890 * src/Makefile.am (check-README): New target/rule.
9891 (check): Depend on it.
9893 * configure.ac (AC_CONFIG_FILES): Add old/Makefile and old/*/Makefile.
9895 2002-08-03 Jim Meyering <jim@meyering.net>
9897 * Makefile.am (SUBDIRS): Add old.
9898 * old/: New directory, containing legacy ChangeLog* and NEWS files
9899 from the fileutils, sh-utils, and textutils packages.
9901 * src/Makefile.am (AM_INSTALLCHECK_STD_OPTIONS_EXEMPT): Set to false.
9903 2002-08-02 Paul Eggert <eggert@twinsun.com>
9905 * NEWS, doc/coreutils.texi: uniq now obeys LC_COLLATE.
9907 * src/uniq.c: Include hard-locale.h, xmemcoll.h.
9908 (hard_LC_COLLATE): New var.
9909 (different): Args are now char *, not const char *.
9910 Use xmemcoll instead of memcmp to compare lines, so that
9911 LC_COLLATE has effect. However, use memcmp if it is an
9913 (check_file): Do not include newline in comparison, so that
9914 xmemcoll has a byte to stomp on temporarily.
9915 (main): Set hard_LC_COLLATE.
9917 2002-07-29 Jim Meyering <jim@meyering.net>
9919 * Makefile.am (SUBDIRS): Remove djgpp, for now.
9921 2002-07-20 Jim Meyering <jim@meyering.net>
9923 * Makefile.am (false.c): Convert only the final EXIT_SUCCESS
9924 into EXIT_FAILURE. Otherwise, false --help and false --version
9927 2002-07-08 Jim Meyering <jim@meyering.net>
9929 * src/Makefile.am (uninstall-local): Search for @GNU_PACKAGE@,
9930 rather than the hard-coded `sh-utils'.
9932 2002-07-01 Jim Meyering <jim@meyering.net>
9934 * configure.ac: Merge the three files from fileutils,
9935 textutils, and sh-utils.
9936 * Makefile.am: Likewise.
9937 * src/Makefile.am: Likewise.
projects / platform / upstream / coreutils.git / blob