1 2003-04-15 Havoc Pennington <hp@pobox.com>
3 * bus/bus.c: create and keep around a shared DBusUserDatabase
6 * bus/connection.c (bus_connection_get_groups): don't cache
7 groups for user in the connection object, since user database
10 2003-04-16 Havoc Pennington <hp@redhat.com>
12 * dbus/dbus-message.c (_dbus_message_add_size_counter): keep a
14 (_dbus_message_loader_putback_message_link): put back a popped link
16 * dbus/dbus-connection.c
17 (dbus_connection_set_max_live_messages_size): rename
19 (dbus_connection_get_outgoing_size): get size of outgoing
21 (_dbus_connection_set_connection_counter): remove this cruft
23 2003-04-14 Havoc Pennington <hp@redhat.com>
25 * dbus/dbus-userdb.c: user database abstraction, mostly to get
26 caching, but at some point we might want to be able to use a
29 * bus/dispatch.c (bus_dispatch_sha1_test): add a test that uses
30 SHA1 conf file to test the sha1 auth mechanism, since the regular
31 test always uses EXTERNAL when available.
34 test/data/valid-config-files/debug-allow-all-sha1.conf.in:
35 add conf file that requires use of sha1 auth
37 2003-04-13 Havoc Pennington <hp@pobox.com>
39 * tools/dbus-send.c, tools/dbus-monitor.c: two utility programs
40 from Philip Blundell to send messages and monitor them.
42 2003-04-13 Havoc Pennington <hp@pobox.com>
44 * dbus/dbus-mainloop.c: fix some reentrancy issues by refcounting
47 * test/data/valid-config-files/debug-allow-all.conf.in: allow all
50 * dbus/dbus-transport.c (_dbus_transport_get_dispatch_status):
51 fix to only recover unused bytes if we're already authenticated
52 (_dbus_transport_get_is_authenticated): fix to still mark us
53 authenticated if there are unused bytes.
55 * bus/dispatch.c: implement security policy checking
57 * bus/connection.c (bus_transaction_send_from_driver): new
59 * bus/bus.c (bus_context_check_security_policy): new
61 * bus/dispatch.c (send_service_nonexistent_error): delete this,
62 now we just set the DBusError and it gets converted to an error
65 * bus/connection.c (allow_user_function): enable code using actual
66 data from the config file
68 * bus/policy.c (list_allows_user): handle wildcard rules for
69 user/group connection perms
71 2003-04-13 Havoc Pennington <hp@pobox.com>
73 * bus/config-parser.c: Load up the BusPolicy and BusPolicyRules
75 * dbus/dbus-sysdeps.c (_dbus_get_user_id): new function
77 * bus/policy.c (bus_policy_append_mandatory_rule)
78 (bus_policy_append_default_rule, bus_policy_append_user_rule)
79 (bus_policy_append_group_rule): new functions
81 2003-04-12 Havoc Pennington <hp@pobox.com>
83 * bus/config-parser.c (bus_config_parser_new): fix a memleak
85 * dbus/dbus-sysdeps.c: change DBusCredentials to use longs for
86 the pid/gid/uid, just for paranoia.
88 * test/break-loader.c (randomly_do_n_things): find a byte
89 containing a type code, and randomly change it to a different
92 2003-04-12 Havoc Pennington <hp@pobox.com>
94 * bus/policy.h: change BusPolicy to be the thing from the config
95 file, and rename old BusPolicy to BusClientPolicy
97 * bus/bus.c, bus/connection.c, bus/config-parser.c: change to
98 match change in how policy works
100 * dbus/dbus-internals.h: mark assert_not_reached as
101 __attribute((noreturn))__
103 2003-04-11 Havoc Pennington <hp@redhat.com>
105 * doc/dbus-specification.sgml: fix a spot with the wrong name for
106 the broadcast service. Use boolean return for ServiceExists.
108 2003-04-11 Havoc Pennington <hp@redhat.com>
110 * configure.in: add another directory to look for qt in.
112 2003-04-11 Havoc Pennington <hp@redhat.com>
114 * AUTHORS: add Colin Walters
116 2003-04-11 Havoc Pennington <hp@redhat.com>
122 2003-04-11 Havoc Pennington <hp@redhat.com>
124 * bus/messagebus.in: remove pid file when stopping the
125 message bus, since the bus won't have privileges to remove it
128 2003-04-11 Havoc Pennington <hp@redhat.com>
130 * bus/bus.c (bus_context_new): move credentials change after
133 2003-04-11 Havoc Pennington <hp@pobox.com>
135 * test/decode-gcov.c: add "below average functions" to the
136 coverage report, and change how some of the code works.
138 * bus/test-main.c: bracket some stuff in DBUS_BUILD_TESTS so it's
139 not in the coverage stats.
141 * test/test-service.c (main): use _dbus_verbose not fprintf in a
142 couple places so running the test suite doesn't result in megaspam.
144 2003-04-11 Havoc Pennington <hp@pobox.com>
146 * bus/dispatch.c (check_existent_service_activation): accept a no
147 memory error in a place we didn't before
149 * bus/test.c (bus_test_run_everything): remove hacky "do it twice
150 in case the first one failed," since the test suite is less
153 2003-04-10 Havoc Pennington <hp@pobox.com>
155 * bus/dispatch.c (check_segfault_service_activation): add test
156 for launching an executable that just crashes.
158 * test/test-segfault.c (main): try setting coredumpsize to 0 so we
159 don't leave a million cores. We'll see how portable this is.
161 2003-04-10 Havoc Pennington <hp@pobox.com>
163 * dbus/dbus-spawn.c (_dbus_spawn_async_with_babysitter): move all
164 the possible parent failures before we fork, so that we don't
165 fail to create a babysitter after creating the child.
167 * bus/activation.c (bus_activation_activate_service): kill child
168 if we don't successfully complete the activation.
170 2003-04-10 Havoc Pennington <hp@redhat.com>
172 * dbus/dbus-connection.c (dbus_connection_flush): don't spin on
173 the connection if it's disconnected
175 * bus/activation.c (bus_activation_service_created): use new
176 transaction features to roll back removal of pending activation if
177 we don't successfully create the service after all. Don't remove
178 pending activation if the function fails.
180 * dbus/dbus-list.c (_dbus_list_insert_before_link)
181 (_dbus_list_insert_after_link): new code to facilitate
184 * dbus/dbus-hash.c (_dbus_hash_table_insert_string_preallocated):
185 new functionality, so we can preallocate the ability to insert
188 * bus/connection.c (bus_transaction_add_cancel_hook): new function
189 allowing us to put custom hooks in a transaction to be used for
190 cancelling said transaction
192 * doc/dbus-specification.sgml: add some discussion of secondary
193 service owners, and disallow zero-length service names
195 * bus/services.c (bus_registry_acquire_service): new function,
196 splits out part of bus_driver_handle_acquire_service() and fixes
197 a bug where we didn't remove the service doing the acquiring
198 from the secondary queue if we failed to remove the current owner
199 from the front of the queue.
201 2003-04-10 Alexander Larsson <alexl@redhat.com>
203 * doc/dbus-specification.sgml:
204 s/org.freedesktop.Broadcast/org.freedesktop.DBus.Broadcast/
206 2003-04-10 Alexander Larsson <alexl@redhat.com>
211 Added files to cvsignore
213 * dbus/dbus-message.h:
214 * dbus/dbus-message.c: (dbus_message_iter_get_named):
215 Make get_named() take two out argument and return a boolean.
216 (dbus_message_iter_get_args_valist):
217 Update usage of get_named().
218 (dbus_message_iter_append_byte):
220 (dbus_message_iter_append_named)
222 (message_iter_test), (check_message_handling_type), (_dbus_message_test):
225 2003-04-10 Alexander Larsson <alexl@redhat.com>
227 * dbus/dbus-marshal.[ch]:
228 Add array_type_pos argument to _dbus_marshal_validate_arg.
229 Let you pass a NULL end_pos to _dbus_marshal_validate_type.
231 * dbus/dbus-message.[ch]:
232 Multi-dimensional arrays have full type specification in the
233 outermost array. Iter code re-arranged to handle this.
234 Added some more iter tests.
236 * doc/dbus-specification.sgml:
239 Update new array encoding description.
240 Correct DBUS_SERVICE_FLAGS_REPLACE_EXISTING description.
242 * test/data/invalid-messages/array-with-mixed-types.message:
243 * test/data/valid-messages/array-of-array-of-uint32.message:
244 Change to the new array format.
246 * test/data/invalid-messages/too-short-dict.message:
249 * test/data/valid-messages/recursive-types.message:
250 Fix up and extend test.
252 2003-04-10 Havoc Pennington <hp@pobox.com>
254 * bus/dispatch.c: lots of fixes
256 * dbus/dbus-mainloop.c (_dbus_loop_dispatch): export
257 (_dbus_loop_iterate): remove old "quit if no callbacks" code,
258 that was crack, broke the test service.
260 * dbus/dbus-transport.c (_dbus_transport_open): fix error
261 handling to avoid piling up errors if we get a failure on the
264 * dbus/dbus-internals.c (_dbus_real_assert_not_reached): include
265 pid in assertion failures.
267 * dbus/dbus-mainloop.c (_dbus_loop_iterate): use static arrays up
268 to some fixed size of file descriptor array. Don't return TRUE
269 anytime a timeout exists, that led to lots of busy loop silliness
272 2003-04-09 Havoc Pennington <hp@redhat.com>
274 * dbus/dbus-mainloop.c (check_timeout): fix timeouts, I thought
275 I'd checked this in earlier but hadn't.
277 2003-04-09 Havoc Pennington <hp@redhat.com>
279 * bus/dispatch.c (bus_dispatch_test): get a bit further through
280 the activation test (man this is getting old!)
282 2003-04-09 Havoc Pennington <hp@redhat.com>
284 * test/test-utils.c: use dispatch status function to fix this up
286 * bus/connection.c (connection_watch_callback): don't dispatch
288 (connection_timeout_callback): don't dispatch from here
289 (bus_connections_setup_connection): set the dispatch status function
290 (bus_connection_disconnected): unset it
292 * dbus/dbus-mainloop.c (_dbus_loop_queue_dispatch): new function
293 used to add a connection to be dispatched
294 (_dbus_loop_iterate): do the dispatching at the end of each
297 * dbus/dbus-connection.c
298 (dbus_connection_set_dispatch_status_function): new function
299 allowing us to fix up main loop usage
300 (_dbus_connection_last_unref): free all the various function
302 (dbus_connection_dispatch): call the DispatchStatusFunction
303 whenever this function returns
304 (dbus_connection_handle_watch): call DispatchStatusFunction
305 (dbus_connection_send_with_reply_and_block): call DispatchStatusFunction
306 (reply_handler_timeout): call DispatchStatusFunction
307 (dbus_connection_flush): call DispatchStatusFunction
309 2003-04-09 Havoc Pennington <hp@redhat.com>
311 * dbus/dbus-bus.c (dbus_bus_register): fix up error handling and
314 * bus/dispatch.c (check_service_activated): fix bug in test
316 * dbus/dbus-mainloop.c (check_timeout): fix this up
318 * dbus/dbus-internals.c (_dbus_verbose_real): include PID in
319 verbose output so we can sort out output from different processes,
320 e.g. in the activation case.
322 2003-04-08 Colin Walters <walters@gnu.org>
324 * bus/bus.c (struct BusContext) [pidfile]: New member, to store
326 (bus_context_new): Set it.
327 (bus_context_unref): Use it to delete the pid file.
329 2003-04-08 Havoc Pennington <hp@redhat.com>
331 * test/data/invalid-messages/array-with-mixed-types.message:
332 regression test that fails for the moment
334 * dbus/dbus-test.c (dbus_internal_do_not_use_run_tests): reorder
335 tests for convenience
337 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): don't allow
338 array of nil, it broke things.
340 * test/data/invalid-messages/array-of-nil.message: regression test
342 * test/data/valid-messages/array-of-array-of-uint32.message:
343 happened to write this so added it to suite
345 2003-04-08 Havoc Pennington <hp@redhat.com>
347 * bus/driver.c (bus_driver_handle_acquire_service): init
348 retval/reply before checking name
350 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): add a
351 recursion depth argument
353 * dbus/dbus-message.h (struct DBusMessageIter): put some padding
354 in the public struct for future extension
356 * dbus/dbus-message-builder.c (_dbus_message_data_load): fix
359 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): fix a verbose
362 * doc/dbus-specification.sgml: fix typo
364 2003-04-08 Alexander Larsson <alexl@redhat.com>
366 Implemented recursive types, named types and new-style iters
369 * glib/test-thread-client.c: (thread_func):
370 * glib/test-thread-server.c: (handle_test_message):
371 * test/test-service.c: (handle_echo):
380 * dbus/dbus-internals.c: (_dbus_type_to_string):
381 Update for new types.
383 * dbus/dbus-marshal.[ch]:
384 Implement recursive types and the new marshalling format.
385 Remove hardcoded dict marshalling.
388 * dbus/dbus-message-builder.c:
390 Remove references to old types
392 * dbus/dbus-message.[ch]:
393 New non-refcounted iter API that supports recursive iters.
394 Use iters for appending, including support for recursive
396 Add byte and named type support.
397 Update everything to new marshalling formats.
398 Add tests for new API.
400 * dbus/dbus-protocol.h:
401 Remove old array types.
402 Add types: BYTE, ARRAY, DICT, NAMED
404 * dbus/dbus-string.c:
405 * dbus/dbus-sysdeps.c:
406 Make parse_double locale safe.
408 * dbus/dbus-test-main.c:
414 * doc/dbus-specification.sgml:
417 * test/data/incomplete-messages/missing-body.message:
418 * test/data/invalid-messages/bad-boolean.message:
419 * test/data/invalid-messages/bad-boolean-array.message:
420 * test/data/invalid-messages/boolean-array-length-too-long.message-raw:
421 * test/data/invalid-messages/boolean-has-no-value.message-raw:
422 * test/data/invalid-messages/too-short-dict.message:
423 * test/data/valid-messages/dict-simple.message:
424 * test/data/valid-messages/dict.message:
425 * test/data/valid-messages/emptiness.message:
426 * test/data/valid-messages/lots-of-arguments.message:
427 * test/data/valid-messages/no-padding.message:
428 * test/data/valid-messages/recursive-types.message:
429 Add missing NAME fields
430 Fix up dicts & arrays
432 * test/data/invalid-messages/dict-with-nil-value.message:
433 Removed, this is not invalid anymore.
435 * test/data/valid-messages/recursive-types.message:
436 Add new test for deeply recursive types.
438 2003-04-07 Havoc Pennington <hp@pobox.com>
440 * bus/driver.c (bus_driver_handle_acquire_service): return an
441 error if you try to acquire a service that starts with ':'
443 2003-04-07 Havoc Pennington <hp@redhat.com>
445 * doc/dbus-specification.sgml: require that base service names
446 start with ':' and that the base service is created/deleted
447 as first and last things a connection does on the bus
449 * bus/dispatch.c (check_existent_service_activation): lots more
450 work on the activation test; it doesn't fully pass yet...
452 * test/test-service.c (main): fix so we don't memleak the
453 connection to the message bus
454 (filter_func): accept a message asking us to exit
456 2003-04-06 Havoc Pennington <hp@pobox.com>
458 * qt/Makefile.am (dbusinclude_HEADERS): install dbus-qt.h,
461 * configure.in: fixes to Qt detection from Colin Walters
463 * doc/Makefile.am: Only remove generated docbook dirs if they
464 exist, from Colin Walters
466 * dbus/dbus-bus.c: change how we set well-known connections to
467 NULL, so that it works if a single connection is stored in
468 two well-known array slots.
470 * test/Makefile.am: remove a lot of stuff that isn't immediately
471 useful, it's in CVS history if we want it.
473 * test/test-service.c: use dbus-mainloop instead of that
476 2003-04-06 Havoc Pennington <hp@pobox.com>
478 * dbus/Makefile.am: split lists of sources into stuff that goes in
479 the library, util functions that go in the lib and are also used
480 elsewhere, and util functions that are used in tests/daemon but
483 * dbus/dbus-mainloop.h, dbus/dbus-mainloop.c: move bus/loop.[hc]
484 here so it can be used in test binaries also
486 2003-04-06 Havoc Pennington <hp@pobox.com>
488 * dbus/dbus-sysdeps.c (_dbus_become_daemon): write the pidfile
489 here in the parent process, so we can return an error if it
490 fails. Also, move some of the code into the child so the parent
491 is less hosed if we fail midway through.
493 * bus/bus.c (bus_context_new): move pidfile detection further up
494 in the function, before we start overwriting sockets and such.
496 * bus/messagebus.in: adjust this a bit, not sure if it will work.
498 * configure.in: add --with-system-pid-file and --with-system-socket
500 2003-04-06 Colin Walters <walters@verbum.org>
502 * configure.in (DBUS_SYSTEM_PID_FILE): New variable.
504 * bus/system.conf.in: Declare a pidfile.
506 * bus/bus.c (bus_context_new): Test for an existing pid file, and
507 create one (if appropriate).
509 * bus/config-parser.c (enum ElementType) [ELEMENT_PIDFILE]: New.
510 (struct BusConfigParser) [pidfile]: New.
511 (element_type_to_name, merge_included, start_busconfig_child)
512 (bus_config_parser_end_element, bus_config_parser_content): Handle it.
513 (bus_config_parser_unref): Free it.
514 (bus_config_parser_get_pidfile): New function.
516 * bus/config-parser.h (_dbus_write_pid_file): Prototype.
518 * dbus/dbus-errors.h (DBUS_ERROR_PIDFILE_EXISTS): New error.
520 * dbus/dbus-sysdeps.c (_dbus_write_pid_file): New function.
522 * dbus/dbus-sysdeps.h: Prototype it.
524 2003-04-06 Havoc Pennington <hp@pobox.com>
526 * bus/bus.c (bus_context_new): print the address in here, rather
527 than in main(), because we need to do it before forking the daemon
529 * bus/dispatch.c (send_service_nonexistent_error): set the sender
530 on the service nonexistent error
532 * bus/driver.c (bus_driver_handle_acquire_service): set the
533 sender on the AcquireService reply
535 * test/data/valid-config-files/debug-allow-all.conf.in: Make test
536 server also listen on a UNIX socket so services can connect to it.
538 2003-04-06 Havoc Pennington <hp@pobox.com>
540 * dbus/dbus-threads.c: Redo how the fake debug mutexes are done
541 so it detects deadlocks and also we actually init threads when
544 2003-04-06 Havoc Pennington <hp@pobox.com>
546 * dbus/dbus-server-unix.c (_dbus_server_new_for_domain_socket):
547 save the domain socket name, and unlink it when we disconnect the
548 server. Means that at least when we exit normally, we won't leave
549 a bunch of junk in /tmp
551 * dbus/dbus-transport-unix.c
552 (_dbus_transport_new_for_domain_socket): code cleanup (nicer
553 memory management). (I was making a real change here but then
556 2003-04-06 Havoc Pennington <hp@pobox.com>
558 * bus/bus.c (bus_context_new): fix wrong handling of
559 server_data_slot_unref() in the error case.
561 * dbus/dbus-internals.h (_dbus_assert): change so it passes
562 "(condition) != 0" to _dbus_real_assert so that
563 "_dbus_assert (pointer)" doesn't cause a warning
565 * bus/main.c (main): accept --print-address option to print out
566 the message bus address
568 * dbus/dbus-sysdeps.c (_dbus_generate_random_ascii): export this
570 * dbus/dbus-transport.c (_dbus_transport_open): special error for
571 "tmpdir" option to unix: address on client side
573 * dbus/dbus-server.c (dbus_server_listen): handle "tmpdir" option
576 * configure.in (TEST_SOCKET_DIR): locate a temporary directory
577 we can use to create sockets in the test suite.
579 * bus/main.c (signal_handler): on SIGTERM, exit the daemon
580 cleanly. To be used for testing.
582 * dbus/dbus-spawn.c (babysit): use _dbus_set_signal_handler()
584 * dbus/dbus-sysdeps.c (_dbus_set_signal_handler): new
586 * dbus/dbus-server-debug-pipe.c (_dbus_transport_debug_pipe_new):
587 handle trying to call this when there's no servers active
589 2003-04-05 Havoc Pennington <hp@pobox.com>
595 2003-04-05 Havoc Pennington <hp@pobox.com>
597 * bus/bus.c (setup_server): fix this so dbus-daemon-1 doesn't
598 crash on startup. Need to get "try starting the daemon"
599 in the test suite I guess. ;-)
601 * dbus/dbus-server.h, dbus/dbus-server.c: remove the stuff that
602 tracked the number of open connections; it's better done in
603 application-specific code as you want it to span all servers etc.
605 2003-04-05 Havoc Pennington <hp@pobox.com>
607 * bus/Makefile.am (install-data-hook): add missing DESTDIR,
608 patch from Colin Walters
610 2003-04-05 Havoc Pennington <hp@pobox.com>
612 * doc/config-file.txt (Elements): fix docs of <auth> to reflect
613 reality; in fact multiple mechanisms are allowed.
615 * dbus/dbus-internals.c (_dbus_real_assert)
616 (_dbus_real_assert_not_reached): move guts of _dbus_assert() and
617 _dbus_assert_not_reached() into functions, so that they don't show
618 up in basic block counts for test coverage, and don't use up as
619 much disk space. Does mean slower execution speed though, so
620 assumes --disable-asserts is the normal production case.
622 2003-04-05 Havoc Pennington <hp@pobox.com>
624 * test/Makefile.am (dist-hook): also dist *.in files
630 2003-04-05 Havoc Pennington <hp@pobox.com>
632 * dbus/dbus-string.c: docs warning
634 * dbus/dbus-spawn.c: missing docs
636 * dbus/dbus-memory.c (struct ShutdownClosure): missing docs
638 2003-04-05 Havoc Pennington <hp@pobox.com>
640 * bus/loop.c (bus_loop_iterate): fix the timeout code, using
643 * dbus/dbus-spawn.c (_dbus_babysitter_unref): set sitter_pid
644 to -1 once we've reaped the babysitter
645 (_dbus_babysitter_handle_watch): do as much work as we can, not
648 * bus/activation.c: add code using DBusBabysitter so that we
649 handle it when a service fails to start up properly.
650 (bus_activation_service_created): don't remove the activation
651 entries as we go, just let them get removed when we free the pending
652 activation. Unref reply messages after sending them.
654 2003-04-05 Havoc Pennington <hp@pobox.com>
656 * test/decode-gcov.c (main): print per-directory stats in the report
658 * Makefile.am (coverage-report.txt): don't include test/* in gcov stats
660 2003-04-05 Havoc Pennington <hp@pobox.com>
662 * Makefile.am (coverage-report.txt): add target "coverage-report.txt"
664 * test/decode-gcov.c: hack up a little program to suck data
665 out of gcov files. Yes this is sort of silly.
667 * configure.in: define something in config.h and do an
668 AM_CONDITIONAL when gcov is enabled
670 2003-04-04 Havoc Pennington <hp@redhat.com>
672 * dbus/dbus-spawn.c, dbus/dbus-spawn.h: Change dbus_spawn to
673 return a "babysitter" object that is used to monitor the status of
674 the spawned process and reap it when required.
676 * test/test-segfault.c, test/test-exit.c,
677 test/test-sleep-forever.c: binaries that do various lame things,
678 used in the test suite.
680 * dbus/dbus-sysdeps.c: kill _dbus_errno_to_string()
682 2003-04-03 Havoc Pennington <hp@pobox.com>
684 * dbus/dbus-spawn.c: Move dbus-spawn into a separate file
685 in preparation for modifying it, dbus-sysdeps is getting
688 2003-04-03 Havoc Pennington <hp@redhat.com>
690 * bus/loop.h, bus/loop.c: make the mainloop an object so we can
693 * bus/*.[hc]: adapt to mainloop change
695 2003-04-03 Havoc Pennington <hp@redhat.com>
697 * bus/activation.c (load_directory): fix up memleaks
698 (bus_activation_entry_free): free the entry
700 * dbus/dbus-bus.c (dbus_bus_acquire_service): return an error if
701 we get one from the message bus; fix memleaks.
703 * dbus/dbus-message.c (dbus_set_error_from_message): new function
705 2003-04-03 Havoc Pennington <hp@pobox.com>
707 * bus/config-parser.c (bus_config_parser_unref): free
708 list of mechanisms, bug discovered by test suite enhancements
709 (putting system.conf and session.conf into suite)
711 * test/Makefile.am, test/test-service.c: add placeholder for a
712 test service that we'll activate as part of test suite. Doesn't
715 * dbus/dbus-sysdeps.c (_dbus_setenv): support unsetenv by
716 setting NULL value, and use system malloc not dbus_malloc()
717 when we have unavoidable memleakage.
719 * dbus/dbus-bus.c (dbus_bus_get): fix bug where bus type of 0
720 didn't work, and support DBUS_BUS_ACTIVATION.
722 * bus/activation.c (child_setup): pass our well-known bus type to
725 * bus/config-parser.c: support <type> to specify well-known type
727 * doc/dbus-specification.sgml: document the env variables to
728 locate well-known buses and find service activator
730 2003-04-02 Havoc Pennington <hp@redhat.com>
732 * test/Makefile.am (all-local): add a rule to copy tests to
733 builddir, so we can have generated tests. Use this to remove the
734 silly hack for testing system.conf and session.conf. Will use this
735 shortly to generate .service files pointing to test binaries.
737 2003-04-02 Havoc Pennington <hp@redhat.com>
739 * dbus/dbus-string.c (set_length): fix a bug - we allocated max of
740 current alloc and needed new length, not max of the doubled
741 allocation and needed new length. Also, when building tests,
742 don't do the double-allocation stuff, just realloc every time.
744 2003-04-02 Havoc Pennington <hp@redhat.com>
746 * dbus/dbus-sysdeps.c (_dbus_file_get_contents): include filenames
748 (_dbus_string_get_dirname): new
749 (_dbus_sysdeps_test): new
750 (_dbus_directory_open): include dirnames in error messages
752 * bus/config-parser.c: interpret <include> and <includedir> and
753 <servicedir> relative to config file location if the given
754 filename is not absolute.
756 * dbus/dbus-string.c (_dbus_string_find_byte_backward): new
758 2003-04-02 Havoc Pennington <hp@redhat.com>
760 * bus/connection.c (bus_transaction_send_error_reply): set sender
761 service for the error, and unref the reply on success
763 * bus/activation.c: convert to use BusTransaction so OOM can be
765 (bus_activation_service_created): set sender of the message
767 2003-04-01 Havoc Pennington <hp@redhat.com>
769 * bus/config-parser.c, bus/bus.c: implement <servicedir> and
770 <includedir> (at least mostly)
772 * dbus/dbus-sysdeps.c (_dbus_change_identity): set the group ID
773 first, then the user ID
775 2003-04-01 Havoc Pennington <hp@pobox.com>
777 * dbus/dbus-server.c (dbus_server_set_auth_mechanisms): new
780 * dbus/dbus-auth.c (_dbus_auth_set_mechanisms): new
782 * dbus/dbus-internals.c (_dbus_dup_string_array): new function
784 * dbus/dbus-sysdeps.c (_dbus_listen_unix_socket): chmod the
785 socket 0777, and unlink any existing socket.
787 * bus/bus.c (bus_context_new): change our UID/GID and fork if
788 the configuration file so specifies; set up auth mechanism
791 * bus/config-parser.c (bus_config_parser_content): add support
792 for <fork> option and fill in code for <auth>
794 * bus/system.conf.in: add <fork/> to default configuration,
795 and limit auth mechanisms to EXTERNAL
797 * doc/config-file.txt (Elements): add <fork>
799 * dbus/dbus-sysdeps.c (_dbus_become_daemon): new function
800 (_dbus_change_identity): new function
802 2003-03-31 Havoc Pennington <hp@redhat.com>
804 * dbus/dbus-sysdeps.c (_dbus_connect_unix_socket)
805 (_dbus_listen_unix_socket): fix off-by-one error in null
806 termination spotted by Nalin
808 2003-03-31 Havoc Pennington <hp@redhat.com>
810 * dbus/dbus-keyring.c (_dbus_keyring_new_homedir): allow setting
811 DBUS_TEST_HOMEDIR when tests are enabled, so we can test without
812 having a real home directory available.
814 2003-03-31 Havoc Pennington <hp@redhat.com>
816 * bus/Makefile.am (install-data-hook): create /var/run/dbus
818 * bus/messagebus.in: add init script for Red Hat /etc/init.d
820 * configure.in: add support for specifying a style of init script
823 2003-03-31 Havoc Pennington <hp@redhat.com>
825 Fix some annoying DBusString API and fix all affected code.
827 * dbus/dbus-string.c (_dbus_string_init): get rid of annoying
829 (_dbus_string_get_data): change to return string instead of using
831 (_dbus_string_get_const_data): ditto
832 (_dbus_string_get_data_len): ditto
833 (_dbus_string_get_const_data_len): ditto
835 2003-03-31 Havoc Pennington <hp@redhat.com>
837 * bus/main.c (main): fix up the command line arguments to be nicer
839 2003-03-31 Havoc Pennington <hp@redhat.com>
841 * dbus/Makefile.am (INCLUDES): use EXPANDED_LOCALSTATEDIR to
842 define DBUS_SYSTEM_BUS_PATH as we want to compile in the same
843 final location that lands in the config file
845 * bus/config-loader-expat.c (bus_config_load): fix type of
848 * doc/TODO: remove TODO item for dbus_bus_get()
850 * dbus/dbus-bus.c (bus_data_free): add missing lock/unlock
852 2003-03-31 Havoc Pennington <hp@pobox.com>
854 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_domain_socket)
855 (_dbus_transport_new_for_tcp_socket): these didn't need the "server"
856 argument since they are always client side
858 * dbus/dbus-server.c (dbus_server_get_address): new function
860 * bus/main.c (main): take the configuration file as an argument.
862 * test/data/valid-config-files/debug-allow-all.conf: new file to
863 use with dispatch.c tests for example
865 * bus/test-main.c (main): require test data dir
867 * bus/bus.c (bus_context_new): change this to take a
868 configuration file name as argument
870 * doc/config-file.txt (Elements): add <servicedir>
872 * bus/system.conf, bus/session.conf: new files
874 * dbus/dbus-bus.c (dbus_bus_get): look for system bus on
875 well-known socket if none set
877 * configure.in: create system.conf and session.conf
879 2003-03-30 Havoc Pennington <hp@pobox.com>
881 * bus/config-parser.c: hacking
883 * dbus/dbus-memory.c: don't use DBusList for the list of stuff
884 to shut down, since it could cause weirdness with the DBusList
887 * dbus/dbus-list.c (_dbus_list_test): add tests for the
888 link-oriented stack routines
889 (alloc_link): free the mempool if the first alloc from it fails
891 * dbus/dbus-mempool.c (struct DBusMemBlock): fix alignment issue
893 * dbus/dbus-string.c (UNICODE_VALID): sync new version of this
895 (_dbus_string_skip_white): new
897 * doc/config-file.txt (Elements): add <includedir>
899 2003-03-28 Havoc Pennington <hp@pobox.com>
901 * dbus/dbus-string.c (_dbus_string_copy_data_len)
902 (_dbus_string_copy_data): new functions
904 2003-03-28 Anders Carlsson <andersca@codefactory.se>
906 * dbus/dbus-bus.c: (bus_data_free), (dbus_bus_get):
910 * dbus/dbus-memory.c:
913 2003-03-28 Havoc Pennington <hp@pobox.com>
915 * bus/test.c (bus_test_flush_bus): remove the sleep from here,
916 I think it may have just been superstition. Not sure.
918 * dbus/dbus-string.c (_dbus_string_base64_decode): catch some OOM
919 failures that were not being handled.
921 * dbus/dbus-auth.c (process_auth): fix a memleak in OOM handling
923 * dbus/dbus-memory.c: add ability to set number of mallocs in a
924 row that will fail on out-of-memory.
926 * dbus/dbus-internals.c (_dbus_test_oom_handling): convenience
927 function for testing out-of-memory handling.
929 * bus/config-loader-expat.c (memsuite): don't wrap the dbus
930 allocation functions, they do map exactly to the expat ones.
932 2003-03-27 Havoc Pennington <hp@redhat.com>
934 * bus/config-loader-libxml.c (bus_config_load): add another error
937 2003-03-26 Anders Carlsson <andersca@codefactory.se>
940 Add note about automatic service activation.
942 * doc/dbus-specification.sgml:
943 Rename the specification and clarify a few things.
945 2003-03-26 Anders Carlsson <andersca@codefactory.se>
948 * dbus/dbus-address.c:
950 * dbus/dbus-marshal.c:
951 * dbus/dbus-server-debug-pipe.c:
952 * dbus/dbus-transport-unix.c:
953 Fix documentation warnings.
955 2003-03-26 Havoc Pennington <hp@pobox.com>
957 * bus/test-main.c, dbus/dbus-test.c (main): check memleaks
958 after every test so it's quick and easy to see which leaked, and
959 so we test multiple dbus_shutdown() calls
961 * configure.in: change configure.in XML stuff to also support
964 * config-loader-libxml.c: some hacking
966 * config-loader-expat.c: some hacking
968 * config-parser.c: some hacking, plus tests
970 2003-03-25 Havoc Pennington <hp@redhat.com>
972 * throughout - add more _DBUS_ASSERT_ERROR_IS_CLEAR
974 * configure.in: add --with-xml option to specify XML library,
975 right now only libxml is supported.
977 * bus/config-loader-libxml.c, config-parser.c: sync some minor
978 nonworking code between home and work, still just stubs
980 2003-03-24 Havoc Pennington <hp@redhat.com>
982 * dbus/dbus-sysdeps.c (_dbus_set_fd_nonblocking): move to this
985 * dbus/dbus-errors.c (dbus_set_error, dbus_set_error_const): allow
986 NULL argument for "message" if the error is a well-known one,
987 fill in a generic message in this case.
989 * dbus/dbus-errors.h (DBusResultCode): Kill DBusResultCode in
992 * bus/test.c (bus_test_flush_bus): add
994 * bus/policy.c (bus_policy_test): test code stub
996 2003-03-24 Havoc Pennington <hp@pobox.com>
998 * bus/connection.c (bus_connections_setup_connection): set up
999 the "can this user connect" function, but it always returns
1000 TRUE until we have a config file parser so we can have a config
1001 file that allows connections.
1003 2003-03-23 Havoc Pennington <hp@pobox.com>
1005 * dbus/dbus-threads.c (dbus_mutex_new, dbus_condvar_new): with
1006 DBUS_BUILD_TESTS, actually alloc/free a block of memory for
1007 the mutex, so we can check for proper memory management
1010 * dbus/dbus-dataslot.c: remove the mutex from
1011 DBusDataSlotAllocator and lock it manually when using it,
1012 to simplify fitting it into the global slots framework.
1014 * dbus/dbus-threads.c (init_static_locks): rework how we're
1015 handling global locks so they are easily shut down.
1017 * bus/policy.c (bus_policy_append_rule): fix
1019 * bus/test-main.c (main): check for memleaks
1021 * dbus/dbus-test.c (dbus_internal_do_not_use_run_tests): make
1022 test suite check for memleaks
1024 * dbus/dbus-memory.c: add support in test mode for tracking
1025 number of outstanding blocks
1027 2003-03-23 Havoc Pennington <hp@pobox.com>
1029 * bus/policy.c, bus/bus.c, bus/connection.c: implement allow/deny
1032 * dbus/dbus-hash.h: add ULONG hash keys
1034 * dbus/dbus-sysdeps.c (_dbus_get_groups): new
1035 (_dbus_get_group_id): new function
1037 2003-03-20 Havoc Pennington <hp@redhat.com>
1039 * dbus/dbus-connection.c (dbus_connection_set_unix_user_function):
1041 (dbus_connection_get_unix_user): new function
1043 2003-03-20 Havoc Pennington <hp@pobox.com>
1045 * bus/connection.c (bus_connection_send_oom_error): assert that
1046 message has a sender
1047 (connection_execute_transaction): ditto
1048 (bus_connection_preallocate_oom_error): fix to set the sender, and
1049 set recipient to the destination service, not the bus driver
1051 * bus/policy.c: hacking
1053 * dbus/dbus-message.c (dbus_message_service_is): new function
1054 (dbus_message_sender_is): new
1056 2003-03-19 Havoc Pennington <hp@redhat.com>
1058 * bus/policy.c: start sketching code for policy restrictions on
1059 what connections can do.
1061 2003-03-18 Havoc Pennington <hp@redhat.com>
1063 * doc/TODO: some notes on high-level todo items. Little nitpick
1064 stuff is all in @todo, so no need to add it here.
1066 * doc/config-file.txt: some notes on how config file might look
1068 2003-03-18 Anders Carlsson <andersca@codefactory.se>
1074 2003-03-17 Havoc Pennington <hp@redhat.com>
1076 * dbus/dbus-internals.h: add gcc attributes so that
1077 our printf-style functions warn on bad arguments to
1080 * dbus/dbus-sysdeps.c (_dbus_connect_tcp_socket): fix printf
1083 * dbus/dbus-message.c (_dbus_message_loader_queue_messages): fix
1086 2003-03-17 Havoc Pennington <hp@redhat.com>
1088 * bus/test-main.c (main): make it print something as it runs
1089 so make check doesn't look stuck
1091 * doc/negotiation.txt, doc/dbus-sasl-profile.txt: remove
1092 from CVS, now obsolete
1094 2003-03-17 Anders Carlsson <andersca@codefactory.se>
1096 * bus/dispatch.c: (bus_dispatch):
1097 Refetch the service name since it may have been reallocated
1098 when dbus_message_set_sender was called.
1100 * dbus/dbus-sysdeps.c: (_dbus_accept):
1101 Add address and address length variables and use them to stop
1102 valgrind from complaining.
1104 2003-03-17 Havoc Pennington <hp@pobox.com>
1106 All tests pass, no memleaks, no valgrind complaints.
1108 * bus/test.c: refcount handler_slot
1110 * bus/connection.c (bus_connections_new): refcount
1111 connection_data_slot
1113 * dbus/dbus-auth-script.c (_dbus_auth_script_run): delete unused
1114 bytes so that auth scripts pass.
1116 * bus/dispatch.c: init message_handler_slot so it gets allocated
1119 * bus/dispatch.c (message_handler_slot_ref): fix memleak
1121 * dbus/dbus-server-debug-pipe.c (_dbus_server_debug_pipe_new):
1122 dealloc server_pipe_hash when no longer used for benefit of
1125 * dbus/dbus-auth.c (process_command): memleak fix
1127 * bus/dispatch.c (check_hello_message): memleak fix
1129 2003-03-16 Havoc Pennington <hp@pobox.com>
1131 * dbus/dbus-bus.c (ensure_bus_data): fix double-unref of the data slot
1133 2003-03-17 Anders Carlsson <andersca@codefactory.se>
1135 * bus/activation.c (bus_activation_activate_service): Append
1136 the pending activation entry to the list of pending activations.
1138 2003-03-16 Havoc Pennington <hp@pobox.com>
1140 * bus/dispatch.c (bus_dispatch_test): remove double-unrefs of
1143 * dbus/dbus-address.c (create_entry): fix OOM handling when
1144 failing to alloc entry->method
1146 2003-03-16 Havoc Pennington <hp@pobox.com>
1148 * dbus/dbus-watch.c (_dbus_watch_new): handle failure to malloc
1151 * dbus/dbus-server-debug-pipe.c (_dbus_transport_debug_pipe_new):
1152 add some missing dbus_set_result
1154 * bus/dispatch.c (bus_dispatch_add_connection): handle failure to
1155 alloc the DBusMessageHandler
1157 * dbus/dbus-transport.c (_dbus_transport_disconnect): don't ref
1158 the transport here, since we call this from the finalizer; it
1159 resulted in a double-finalize.
1161 * dbus/dbus-transport.c (_dbus_transport_disconnect): fix a bug
1162 where we tried to use transport->connection that was NULL,
1163 happened when transport was disconnected early on due to OOM
1165 * bus/*.c: adapt to handle OOM for watches/timeouts
1167 * dbus/dbus-transport-unix.c: port to handle OOM during
1170 * dbus/dbus-auth.c (_dbus_auth_get_unused_bytes): return a
1171 reference to unused bytes instead of a copy
1173 * dbus/dbus-server.c (dbus_server_handle_watch): return FALSE for
1176 * dbus/dbus-connection.c (dbus_connection_handle_watch): return
1179 * dbus/dbus-timeout.c (dbus_timeout_handle): return FALSE for out
1182 2003-03-16 Anders Carlsson <andersca@codefactory.se>
1184 * doc/dbus-specification.sgml:
1185 Document reply message for ActivateService.
1187 2003-03-16 Anders Carlsson <andersca@codefactory.se>
1189 * bus/activation.c: (bus_pending_activation_entry_free),
1190 (bus_pending_activation_free), (bus_activation_new),
1191 (bus_activation_unref), (bus_activation_service_created),
1192 (bus_activation_activate_service):
1194 * bus/bus.c: (bus_context_new):
1195 * bus/desktop-file.c: (new_section):
1196 * bus/driver.c: (bus_driver_send_service_deleted),
1197 (bus_driver_handle_activate_service):
1198 * bus/services.c: (bus_registry_new), (bus_registry_ensure):
1200 * dbus/dbus-connection.c:
1201 (dbus_connection_send_with_reply_and_block):
1202 * dbus/dbus-message.c: (dbus_message_append_args_valist):
1203 * dbus/dbus-protocol.h:
1204 Make activation work better. Now pending activations will be queued
1205 and the daemon won't try to activate services that are already registered.
1207 2003-03-16 Havoc Pennington <hp@pobox.com>
1209 * dbus/dbus-bus.c (ensure_bus_data): handle failure to set
1212 * dbus/dbus-memory.c (_dbus_initialize_malloc_debug): support
1213 DBUS_MALLOC_BACKTRACES to print trace when failing an alloc
1215 2003-03-16 Havoc Pennington <hp@pobox.com>
1217 * dbus/dbus-string.c (_dbus_string_validate_utf8): oops, unbreak
1218 this. always run the test suite before commit...
1220 * bus/*: adapt to DBusConnection API changes
1222 * glib/dbus-gmain.c: adapt to DBusConnection API changes,
1223 requires renaming stuff to avoid dbus_connection_dispatch name
1226 * dbus/dbus-transport.c (_dbus_transport_queue_messages): new
1229 * dbus/dbus-message.c (_dbus_message_loader_queue_messages):
1230 separate from _dbus_message_loader_return_buffer()
1232 * dbus/dbus-connection.c (dbus_connection_get_n_messages): remove
1233 this, because it's now always broken to use; the number of
1234 messages in queue vs. the number still buffered by the message
1235 loader is undefined/meaningless. Should use
1236 dbus_connection_get_dispatch_state().
1237 (dbus_connection_dispatch): rename from
1238 dbus_connection_dispatch_message
1240 2003-03-16 Havoc Pennington <hp@pobox.com>
1242 * dbus/dbus-string.c (_dbus_string_validate_utf8): copy in a real
1245 2003-03-16 Anders Carlsson <andersca@codefactory.se>
1247 * dbus/dbus-connection.c:
1248 (dbus_connection_send_with_reply_and_block):
1249 Decrease connection->n_incoming when removing an entry
1251 * dbus/dbus-dict.c: (dbus_dict_entry_free),
1252 (dbus_dict_set_boolean_array), (dbus_dict_set_int32_array),
1253 (dbus_dict_set_uint32_array), (dbus_dict_set_double_array),
1254 (dbus_dict_set_byte_array), (dbus_dict_set_string_array),
1255 (dbus_dict_get_boolean_array), (dbus_dict_get_double_array),
1256 (dbus_dict_get_byte_array):
1257 Handle NULL arrays and strings. Also add support for byte arrays.
1259 * dbus/dbus-marshal.c: (_dbus_marshal_byte_array),
1260 (_dbus_marshal_dict), (_dbus_demarshal_byte_array),
1261 (_dbus_demarshal_int32_array), (_dbus_demarshal_uint32_array),
1262 (_dbus_demarshal_double_array), (_dbus_demarshal_string_array),
1263 (_dbus_demarshal_dict), (demarshal_and_validate_len),
1264 (_dbus_marshal_validate_arg), (_dbus_marshal_test):
1265 * dbus/dbus-marshal.h:
1266 Add support for marshalling and demarshalling empty arrays and strings.
1268 * dbus/dbus-message.c: (dbus_message_append_args_valist),
1269 (dbus_message_append_string_array),
1270 (dbus_message_iter_get_boolean),
1271 (dbus_message_iter_get_boolean_array),
1272 (dbus_message_iter_get_int32_array),
1273 (dbus_message_iter_get_uint32_array),
1274 (dbus_message_iter_get_double_array),
1275 (dbus_message_iter_get_byte_array),
1276 (dbus_message_iter_get_string_array), (dbus_message_iter_get_dict),
1277 (check_message_handling):
1278 Add support for getting empty arrays and dicts.
1280 * dbus/dbus-string.c: (_dbus_string_validate_utf8):
1281 Don't do any validation at all for now, that's better than just checking
1284 * test/data/valid-messages/emptiness.message:
1285 New test message with lots of empty arrays.
1287 2003-03-16 Havoc Pennington <hp@pobox.com>
1289 * dbus/dbus-connection.c
1290 (_dbus_connection_queue_received_message_link): new function that
1291 can't fail due to OOM
1293 * dbus/dbus-message.c (_dbus_message_loader_pop_message_link):
1294 new function pops a message together with a list link
1297 * dbus/dbus-transport-unix.c (queue_messages): use new link-based
1298 message queuing functions to avoid needing to alloc memory
1300 2003-03-16 Havoc Pennington <hp@pobox.com>
1302 Oops - test code was only testing failure of around 30 of the
1303 mallocs in the test path, but it turns out there are 500+
1304 mallocs. I believe this was due to misguided linking setup such
1305 that there was one copy of dbus_malloc etc. in the daemon and one
1306 in the shared lib, and only daemon mallocs were tested. In any
1307 case, the test case now tests all 500+ mallocs, and doesn't pass
1308 yet, though there are lots of fixes in this patch.
1310 * dbus/dbus-connection.c (dbus_connection_dispatch_message): fix
1311 this so that it doesn't need to allocate memory, since it
1312 has no way of indicating failure due to OOM (and would be
1313 annoying if it did).
1315 * dbus/dbus-list.c (_dbus_list_pop_first_link): new function
1317 * bus/Makefile.am: rearrange to create two self-contained
1318 libraries, to avoid having libraries with overlapping symbols.
1319 that was resulting in weirdness, e.g. I'm pretty sure there
1320 were two copies of global static variables.
1322 * dbus/dbus-internals.c: move the malloc debug stuff to
1325 * dbus/dbus-list.c (free_link): free list mempool if it becomes
1328 * dbus/dbus-memory.c (_dbus_disable_mem_pools): new function
1330 * dbus/dbus-address.c (dbus_parse_address): free list nodes
1333 * bus/dispatch.c (bus_dispatch_add_connection): free
1334 message_handler_slot when no longer using it, so
1335 memory leak checkers are happy for the test suite.
1337 * dbus/dbus-server-debug-pipe.c (debug_finalize): free server name
1339 * bus/bus.c (new_connection_callback): disconnect in here if
1340 bus_connections_setup_connection fails.
1342 * bus/connection.c (bus_connections_unref): fix to free the
1344 (bus_connections_setup_connection): if this fails, don't
1345 disconnect the connection, just be sure there are no side
1348 * dbus/dbus-string.c (undo_alignment): unbreak this
1350 * dbus/dbus-auth.c (_dbus_auth_unref): free some stuff we were
1352 (_dbus_auth_new): fix the order in which we free strings
1355 * bus/connection.c (bus_connection_disconnected): fix to
1356 not send ServiceDeleted multiple times in case of memory
1359 * dbus/dbus-bus.c (dbus_bus_get_base_service): new function to
1360 get the base service name
1361 (dbus_bus_register_client): don't return base service name,
1362 instead store it on the DBusConnection and have an accessor
1364 (dbus_bus_register_client): rename dbus_bus_register()
1366 * bus/dispatch.c (check_hello_message): verify that other
1367 connections on the bus also got the correct results, not
1368 just the one sending hello
1370 2003-03-15 Havoc Pennington <hp@pobox.com>
1372 Make it pass the Hello handling test including all OOM codepaths.
1373 Now to do other messages...
1375 * bus/services.c (bus_service_remove_owner): fix crash when
1376 removing owner from an empty list of owners
1377 (bus_registry_ensure): don't leave service in the list of
1378 a connection's owned services if we fail to put the service
1381 * bus/connection.c (bus_connection_preallocate_oom_error): set
1382 error flag on the OOM error.
1384 * dbus/dbus-connection.c (_dbus_connection_new_for_transport):
1385 handle _dbus_transport_set_connection failure
1387 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_fd): modify
1388 to create watches up front and simply enable/disable them as
1390 (unix_connection_set): this can now fail on OOM
1392 * dbus/dbus-timeout.c, dbus/dbus-watch.c: add concept
1393 of enabling/disabling a watch or timeout.
1395 * bus/loop.c (bus_loop_iterate): don't touch disabled
1398 * glib/dbus-gmain.c: adapt to enable/disable watches and timeouts
1400 2003-03-15 Havoc Pennington <hp@pobox.com>
1402 * bus/dispatch.c (bus_dispatch_test): OK, now finally actually
1403 write useful test code, after all that futzing around ;-)
1405 Test does not yet pass because we can't handle OOM in
1406 _dbus_transport_messages_pending (basically,
1407 dbus_connection_preallocate_send() does not prealloc the write
1408 watch). To fix this, I think we need to add new stuff to
1409 set_watch_functions, namely a SetEnabled function so we can alloc
1410 the watch earlier, then enable it later.
1412 * dbus/Makefile.am (libdbus_convenience_la_SOURCES): move
1413 dbus-memory.c to the convenience lib
1415 * bus/test.c: rename some static functions to keep them clearly
1416 distinct from stuff in connection.c. Handle client disconnection.
1418 2003-03-14 Havoc Pennington <hp@pobox.com>
1420 * bus/dispatch.c (bus_dispatch_test): do test using debug-pipe
1421 transport, tests more of the real codepath. Set up clients
1422 with bus_setup_debug_client.
1424 * bus/test.c (bus_setup_debug_client): function to set up debug
1425 "clients" on the main loop
1427 * dbus/dbus-transport.c (_dbus_transport_open): add debug-pipe
1430 * dbus/dbus-server.c (dbus_server_listen): add debug-pipe
1433 * dbus/dbus-server-debug.c: support a debug server based on pipes
1435 * dbus/dbus-sysdeps.c (_dbus_full_duplex_pipe): new function
1436 (_dbus_close): new function
1438 * configure.in: check for socketpair
1440 2003-03-14 Havoc Pennington <hp@redhat.com>
1442 * dbus/dbus-memory.c: add a "detect buffer overwrites on free"
1445 * dbus/dbus-transport-debug.c: rework this a good bit to be
1446 less complicated. hopefully still works.
1448 * dbus/dbus-server-debug.c (handle_new_client): remove timeout
1451 * glib/dbus-gmain.c (timeout_handler): don't remove timeout
1454 * dbus/dbus-message.c (dbus_message_copy): rename from
1455 dbus_message_new_from_message, fix it up to copy
1456 all the message fields, add test case
1458 * bus/dispatch.c (bus_dispatch_test): add some more test code,
1459 not quite passing yet
1461 2003-03-14 Havoc Pennington <hp@pobox.com>
1463 * bus/loop.c (bus_loop_iterate): add this so we can "run loop
1464 until no work remains" in test code. (the large diff here
1465 is just code movement, no actual changes)
1467 * dbus/dbus-server-debug.c (DEFAULT_INTERVAL): change interval to
1468 1, no point waiting around for test code.
1469 (_dbus_server_debug_accept_transport): unref the timeout
1470 after adding it (right?)
1472 * dbus/dbus-transport-debug.c (DEFAULT_INTERVAL): ditto
1474 2003-03-13 Havoc Pennington <hp@redhat.com>
1476 * dbus/dbus-timeout.c (_dbus_timeout_list_set_functions): handle
1479 * dbus/dbus-watch.c (_dbus_watch_list_set_functions): handle out
1482 * dbus/dbus-connection.h: Make AddWatchFunction and
1483 AddTimeoutFunction return a bool so they can fail on out-of-memory
1485 * bus/bus.c (bus_context_new): set up timeout handlers
1487 * bus/connection.c (bus_connections_setup_connection): set up
1490 * glib/dbus-gmain.c: adapt to the fact that set_functions stuff
1493 * bus/bus.c (bus_context_new): adapt to changes
1495 * bus/connection.c: adapt to changes
1497 * test/watch.c: adapt to DBusWatch changes
1499 * bus/dispatch.c (bus_dispatch_test): started adding this but
1502 2003-03-14 Anders Carlsson <andersca@codefactory.se>
1504 * bus/dispatch.c (send_service_nonexistent_error): Fix typo.
1506 2003-03-13 Havoc Pennington <hp@pobox.com>
1508 * bus/test.c, bus/test.h, bus/Makefile.am, bus/test-main.c:
1509 set up a test framework as for the library
1511 2003-03-12 Havoc Pennington <hp@pobox.com>
1513 Throughout: purge global variables, introduce BusActivation,
1514 BusConnections, BusRegistry, etc. objects instead.
1516 * bus/bus.h, bus/bus.c: introduce BusContext as a global
1519 * test/Makefile.am (TEST_BINARIES): disable bus-test for now,
1520 going to redo this a bit differently I think
1522 2003-03-12 Havoc Pennington <hp@redhat.com>
1524 Mega-patch that gets the message bus daemon initially handling
1525 out-of-memory. Work still needed. Also lots of random
1526 moving stuff to DBusError instead of ResultCode.
1528 * dbus/dbus-list.c (_dbus_list_length_is_one): new function
1530 * dbus/dbus-connection.c
1531 (dbus_connection_send_with_reply_and_block): use DBusError
1533 * dbus/dbus-bus.c: adapt to API changes, make it use DBusError not
1536 * dbus/dbus-connection.c (dbus_connection_send): drop the result
1537 code here, as the only failure possible is OOM.
1539 * bus/connection.c (bus_connection_disconnect):
1540 rename bus_connection_disconnected as it's a notification only
1542 * bus/driver.c (bus_driver_handle_acquire_service): don't free
1543 "name" on get_args failure, should be done by get_args;
1544 don't disconnect client for bad args, just return an error.
1545 (bus_driver_handle_service_exists): ditto
1547 * bus/services.c (bus_services_list): NULL-terminate returned array
1549 * bus/driver.c (bus_driver_send_service_lost)
1550 (bus_driver_send_service_acquired): send messages from driver to a
1551 specific client to the client's unique name, not to the broadcast
1554 * dbus/dbus-message.c (decode_header_data): reject messages that
1555 contain no name field
1556 (_dbus_message_get_client_serial): rename to
1557 dbus_message_get_serial and make public
1558 (_dbus_message_set_serial): rename from set_client_serial
1559 (_dbus_message_set_reply_serial): make public
1560 (_dbus_message_get_reply_serial): make public
1562 * bus/connection.c (bus_connection_foreach): allow stopping
1563 iteration by returning FALSE from foreach function.
1565 * dbus/dbus-connection.c (dbus_connection_send_preallocated)
1566 (dbus_connection_free_preallocated_send)
1567 (dbus_connection_preallocate_send): new API for sending a message
1568 without possibility of malloc failure.
1569 (dbus_connection_send_message): rename to just
1570 dbus_connection_send (and same for whole function family)
1572 * dbus/dbus-errors.c (dbus_error_free): make this reinit the error
1574 * dbus/dbus-sysdeps.c (_dbus_exit): new function
1576 * bus/activation.c: handle/return errors
1578 * dbus/dbus-errors.h: add more DBUS_ERROR #define
1580 * dbus/dbus-sysdeps.c (_dbus_directory_open) (_dbus_file_get_contents)
1581 (_dbus_directory_get_next_file): use DBusError instead of DBusResultCode
1582 (_dbus_result_from_errno): move to this file
1584 2003-03-10 Anders Carlsson <andersca@codefactory.se>
1586 * dbus/dbus-marshal.c:
1587 (_dbus_marshal_set_string):
1588 Take a length argument so we can marshal the correct string
1591 (_dbus_marshal_dict), (_dbus_demarshal_dict),
1592 (_dbus_marshal_get_arg_end_pos), (_dbus_marshal_validate_arg),
1593 (_dbus_marshal_test):
1594 * dbus/dbus-marshal.h:
1595 Add support for marshalling and demarshalling dicts.
1597 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
1598 Add support for TYPE DICT.
1600 * dbus/dbus-message.c: (set_string_field):
1601 Adjust header padding.
1603 (dbus_message_append_args_valist), (dbus_message_append_dict),
1604 (dbus_message_get_args_valist), (dbus_message_iter_get_arg_type),
1605 (dbus_message_iter_get_dict), (_dbus_message_loader_return_buffer),
1606 (check_message_handling), (check_have_valid_message):
1607 * dbus/dbus-message.h:
1608 Add functions for setting and getting dicts.
1610 * dbus/dbus-protocol.h:
1616 * doc/dbus-specification.sgml:
1617 Add information about how dicts are marshalled.
1619 * test/data/invalid-messages/dict-with-nil-value.message:
1620 * test/data/invalid-messages/too-short-dict.message:
1621 * test/data/valid-messages/dict-simple.message:
1622 * test/data/valid-messages/dict.message:
1623 Add sample messages containing dicts.
1625 2003-03-08 Anders Carlsson <andersca@codefactory.se>
1627 * dbus/dbus-dict.h: Add DBUS_END_DECLS.
1629 2003-03-07 Anders Carlsson <andersca@codefactory.se>
1632 * dbus/dbus-dict.c: (dbus_dict_entry_free), (dbus_dict_new),
1633 (dbus_dict_get_keys), (insert_entry), (dbus_dict_set_boolean),
1634 (dbus_dict_set_int32), (dbus_dict_set_uint32),
1635 (dbus_dict_set_double), (dbus_dict_set_string),
1636 (dbus_dict_set_boolean_array), (dbus_dict_set_int32_array),
1637 (dbus_dict_set_uint32_array), (dbus_dict_set_double_array),
1638 (dbus_dict_set_string_array), (_dbus_dict_test):
1640 Fix according to comments from Havoc.
1642 2003-03-06 Michael Meeks <michael@server.home>
1644 * configure.in: if we don't have kde-config, disable have_qt.
1646 2003-03-07 Anders Carlsson <andersca@codefactory.se>
1651 * dbus/dbus-dict.c: (dbus_dict_entry_free), (dbus_dict_new),
1652 (dbus_dict_ref), (dbus_dict_unref), (dbus_dict_contains),
1653 (dbus_dict_remove), (dbus_dict_get_value_type),
1654 (dbus_dict_get_keys), (dbus_dict_put_boolean),
1655 (dbus_dict_put_int32), (dbus_dict_put_uint32),
1656 (dbus_dict_put_double), (dbus_dict_put_string),
1657 (dbus_dict_put_boolean_array), (dbus_dict_put_int32_array),
1658 (dbus_dict_put_uint32_array), (dbus_dict_put_double_array),
1659 (dbus_dict_put_string_array), (dbus_dict_get_boolean),
1660 (dbus_dict_get_int32), (dbus_dict_get_uint32),
1661 (dbus_dict_get_double), (dbus_dict_get_string),
1662 (dbus_dict_get_boolean_array), (dbus_dict_get_int32_array),
1663 (dbus_dict_get_uint32_array), (dbus_dict_get_double_array),
1664 (dbus_dict_get_string_array), (_dbus_dict_test):
1666 Add DBusDict implementation
1668 * dbus/dbus-test.c: (dbus_internal_do_not_use_run_tests):
1672 2003-03-04 Havoc Pennington <hp@pobox.com>
1674 * test/data/auth/*: adapt to changes
1676 * dbus/dbus-auth-script.c (_dbus_auth_script_run): add
1677 USERID_BASE64 and change USERNAME_BASE64 to put in username not
1680 * dbus/dbus-keyring.c (_dbus_keyring_validate_context): prevent
1681 more stuff from being in a context name, to make the protocol
1682 simpler to deal with
1684 * dbus/dbus-errors.c (dbus_error_has_name): new function
1685 (dbus_error_is_set): new function
1687 * dbus/dbus-auth.c: replace DBUS_STUPID_TEST_MECH auth
1688 with DBUS_COOKIE_SHA1, implement DBUS_COOKIE_SHA1
1690 * dbus/dbus-connection.c (dbus_connection_flush): also read
1691 messages during a flush operation
1693 * dbus/Makefile.am: remove dbus-md5 since it isn't currently used.
1695 2003-03-05 Anders Carlsson <andersca@codefactory.se>
1697 * configure.in: Check for gethostbyname on Solaris.
1699 * dbus/dbus-transport.c: (_dbus_transport_open):
1700 Remove duplicate "tcp" entry.
1702 * doc/dbus-specification.sgml:
1703 Clarify some things.
1705 2003-03-05 Anders Carlsson <andersca@codefactory.se>
1707 * dbus/dbus-auth.c: (send_rejected), (process_test_subdir):
1708 * dbus/dbus-keyring.c: (_dbus_keyring_new_homedir),
1709 (_dbus_keyring_test):
1710 * dbus/dbus-md5.c: (_dbus_md5_compute):
1711 * dbus/dbus-sha.c: (_dbus_sha_compute):
1714 2003-03-05 Anders Carlsson <andersca@codefactory.se>
1716 * README: Add some things.
1718 2003-03-04 Anders Carlsson <andersca@codefactory.se>
1720 * dbus/dbus-message.c (dbus_message_append_args_valist): Add a break;
1721 after case DBUS_TYPE_BOOELAN.
1723 2003-03-02 Havoc Pennington <hp@pobox.com>
1725 * test/break-loader.c (randomly_set_extreme_ints): add test that
1726 sets really huge and small integers
1728 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): add check
1729 that length of boolean array fits in the string, and that
1730 string has room for boolean value in single-bool case.
1732 * dbus/dbus-message-builder.c (_dbus_message_data_load): add
1733 optional value to "ALIGN" command which is what to fill the
1736 * test/data/valid-messages/no-padding.message: add regression
1737 test for the message padding problem
1739 2003-03-02 Havoc Pennington <hp@pobox.com>
1741 * dbus/dbus-message.c (decode_header_data): fix to always init
1742 message_padding, from Benjamin Dauvergne
1744 2003-03-02 Havoc Pennington <hp@pobox.com>
1750 2003-03-01 Joe Shaw <joe@assbarn.com>
1752 * configure.in: Check for "struct cmsgcred" and try to access its
1753 members for BSD-like unices.
1755 * dbus/dbus-sysdeps.c (read_credentials_byte): Fold this back into
1756 _dbus_read_credentials_unix_socket().
1757 (_dbus_read_credentials_unix_socket): Use recvmsg() instead of
1758 read() for reading the credential byte off the unix socket. Use
1759 struct cmsgcred on systems that support it.
1761 2003-02-27 Alexander Larsson <alexl@redhat.com>
1765 Make gthreads-2.0 dependency optional. Don't build thread test if
1768 2003-02-27 Havoc Pennington <hp@pobox.com>
1770 * dbus/dbus-connection.c
1771 (dbus_connection_send_message_with_reply_and_block): fix doh!
1772 doh! doh! bug that resulted in never removing a reply from the
1773 queue, no wonder we called get_reply_serial so much ;-)
1775 * dbus/dbus-message.c (struct DBusMessage): cache reply serial
1776 and client serial instead of demarshaling them every time
1778 2003-02-27 Havoc Pennington <hp@pobox.com>
1780 * dbus/dbus-marshal.c (_dbus_demarshal_int32): rewrite to be much
1781 more inlined, using dbus-string-private.h, speeds things up
1784 * dbus/dbus-string.c (_dbus_string_free): apply align offset
1785 when freeing the string
1786 (_dbus_string_steal_data): fix for align offset
1787 (undo_alignment): new function
1789 2003-02-26 Havoc Pennington <hp@redhat.com>
1791 All kinds of audit fixes from Owen, plus initial attempt to
1792 handle unaligned memory returned from malloc.
1794 * dbus/dbus-string.c (_dbus_string_init): clamp max length to
1795 leave room for align_offset and nul byte
1796 (fixup_alignment): function to track an align_offset and
1797 ensure real->str is aligned
1798 (DBUS_GENERIC_STRING_PREAMBLE): len must be less than allocated,
1799 to allow a nul byte plus align offset
1800 (_dbus_string_lock): fix overflow issue
1801 (_dbus_string_init_const_len): add assertions on sanity of len,
1802 assign allocated to be ALLOCATION_PADDING larger than len
1803 (set_length): fixup the overflow handling
1804 (_dbus_string_get_data_len): fix overflow in assertion
1805 (open_gap): detect overflow in size of gap to be opened
1806 (_dbus_string_lengthen): add overflow check
1807 (_dbus_string_align_length): fix overflow with _DBUS_ALIGN_VALUE
1808 (_dbus_string_append): add overflow check
1809 (_dbus_string_append_unichar): overflow
1810 (_dbus_string_delete): fix overflow in assertion
1811 (_dbus_string_copy_len): overflow in assertion
1812 (_dbus_string_replace_len): overflows in assertions
1813 (_dbus_string_find): change to implement in terms of
1814 _dbus_string_find_to
1815 (_dbus_string_find_to): assorted fixage
1816 (_dbus_string_equal_c_str): assert c_str != NULL,
1817 fix logic so the function works
1818 (_dbus_string_ends_with_c_str): fix overflow thingy
1819 (_dbus_string_base64_encode): overflow fix
1820 (_dbus_string_validate_ascii): overflow
1821 (_dbus_string_validate_nul): overflow
1823 2003-02-26 Havoc Pennington <hp@redhat.com>
1825 * dbus/dbus-marshal.c (_dbus_marshal_test): fix to work with DISABLE_ASSERTS
1827 2003-02-26 Alexander Larsson <alexl@redhat.com>
1830 Set DBUS_GLIB_THREADS_LIBS for apps using gthread-2.0
1832 * dbus/dbus-connection.c:
1833 * dbus/dbus-connection.h:
1834 Fix _dbus_connection_acquire_io_path and _dbus_connection_acquire_dispatch.
1835 Add dbus_connection_set_wakeup_main_function and use it when queueing
1836 incoming and outgoing messages.
1839 * dbus/dbus-dataslot.c:
1840 Threadsafe usage of DBusDataSlotAllocator
1842 * dbus/dbus-message.c: (dbus_message_get_args_iter):
1845 * dbus/dbus-server-unix.c:
1848 * glib/dbus-gmain.c:
1849 Implement the new wakeup functions for glib.
1852 * glib/test-thread-client.c:
1853 * glib/test-thread-server.c:
1854 * glib/test-thread.h:
1855 Initial cut at some thread test code. Not really done yet.
1857 2003-02-26 Havoc Pennington <hp@pobox.com>
1859 * dbus/dbus-connection.c
1860 (dbus_connection_send_message_with_reply_and_block): fix crash
1861 where we ref'd the outgoing message instead of the returned reply
1863 * dbus/dbus-transport-unix.c (do_authentication): check read watch
1864 at the end of this function, so if we didn't need to read for
1865 authentication, we reinstall it for receiving messages
1867 * dbus/dbus-message.c (dbus_message_new_reply): allow replies to
1868 a NULL sender for peer-to-peer case
1870 * dbus/dbus-transport-unix.c (check_read_watch): handle
1871 !authenticated case correctly
1873 * glib/dbus-gmain.c: add support for DBusServer
1875 * dbus/dbus-server.c: add data slot support
1877 * glib/dbus-gmain.c (dbus_connection_setup_with_g_main): check
1878 return values and handle errors
1880 * dbus/dbus-dataslot.c: factor out the data slot stuff from
1883 * Doxyfile.in (INPUT): add glib subdir
1885 * glib/dbus-gmain.c (dbus_connection_setup_with_g_main): rename
1886 setup_with_g_main instead of hookup_with_g_main; write docs
1888 2003-02-24 Anders Carlsson <andersca@codefactory.se>
1890 * dbus/dbus-marshal.c: (_dbus_marshal_validate_arg):
1891 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
1892 * dbus/dbus-message.c: (dbus_message_append_boolean),
1893 (dbus_message_append_boolean_array),
1894 (dbus_message_get_args_valist), (_dbus_message_test):
1895 * dbus/dbus-message.h:
1896 * doc/dbus-specification.sgml:
1897 Various fixes as pointed out by Havoc.
1899 * test/data/invalid-messages/bad-boolean-array.message:
1900 * test/data/invalid-messages/bad-boolean.message:
1901 Add invalid boolean value test cases.
1903 2003-02-24 Anders Carlsson <andersca@codefactory.se>
1905 * dbus/dbus-internals.c: (_dbus_type_to_string):
1906 * dbus/dbus-marshal.c: (_dbus_marshal_get_arg_end_pos),
1907 (_dbus_marshal_validate_arg):
1908 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
1909 * dbus/dbus-message.c: (dbus_message_append_args_valist),
1910 (dbus_message_append_boolean), (dbus_message_append_boolean_array),
1911 (dbus_message_get_args_valist), (dbus_message_iter_get_boolean),
1912 (dbus_message_iter_get_int32), (dbus_message_iter_get_uint32),
1913 (dbus_message_iter_get_double),
1914 (dbus_message_iter_get_boolean_array), (message_iter_test):
1915 * dbus/dbus-message.h:
1916 * dbus/dbus-protocol.h:
1917 * doc/dbus-specification.sgml:
1918 * test/data/valid-messages/lots-of-arguments.message:
1919 Add support for boolean and boolean array types.
1921 2003-02-23 Havoc Pennington <hp@pobox.com>
1923 * dbus/dbus-keyring.c: finish most of this implementation and
1926 * dbus/dbus-errors.c (dbus_set_error_const, dbus_set_error): make
1927 these barf if the error isn't cleared to NULL
1929 * dbus/dbus-sysdeps.c (_dbus_delete_file): set error on failure
1930 (_dbus_create_directory): new function
1932 * dbus/dbus-errors.c (dbus_set_error): fix warning
1934 * dbus/dbus-string.c (_dbus_string_hex_encode): new function
1935 (_dbus_string_hex_decode): new function
1936 (test_hex_roundtrip): test code
1938 * dbus/dbus-sha.c (_dbus_sha_compute): use dbus_string_hex_encode
1940 * dbus/dbus-md5.c (_dbus_md5_compute): use dbus_string_hex_encode
1942 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): make this use
1943 the save-to-temp/rename trick to atomically write the new file
1944 (_dbus_string_parse_uint): new function
1946 2003-02-22 Havoc Pennington <hp@pobox.com>
1948 * test/Makefile.am (dist-hook): fix dist for test/data/sha-1
1950 2003-02-22 Havoc Pennington <hp@pobox.com>
1952 * dbus/dbus-message.c (dbus_message_iter_get_string_array):
1953 (dbus_message_iter_get_byte_array): Fix up doxygen warnings
1955 * dbus/dbus-sha.c: add implementation of SHA-1 algorithm
1957 * dbus/test/data/sha-1: add US government test suite for SHA-1
1959 2003-02-21 Anders Carlsson <andersca@codefactory.se>
1961 * dbus/dbus-marshal.c: (_dbus_demarshal_string_array):
1962 Make string arrays NULL-terminated.
1964 * dbus/dbus-memory.c: (dbus_free_string_array):
1965 * dbus/dbus-memory.h:
1966 New function for freeing NULL-terminated string arrays.
1968 * dbus/dbus-message-builder.c: (append_quoted_string),
1969 (_dbus_message_data_load):
1970 Add support for array types.
1972 * dbus/dbus-message.c: (check_message_handling):
1973 Add more types as test cases.
1975 * dbus/dbus-sysdeps.c: (_dbus_string_parse_int),
1976 (_dbus_string_parse_double):
1977 Add the start offset to the end offset.
1979 * test/data/valid-messages/lots-of-arguments.message:
1980 New test message with lots of arguments.
1982 2003-02-21 Anders Carlsson <andersca@codefactory.se>
1984 * dbus/dbus-message.c: (dbus_message_append_nil),
1985 (dbus_message_append_int32), (dbus_message_append_uint32),
1986 (dbus_message_append_double), (dbus_message_append_string),
1987 (dbus_message_append_int32_array),
1988 (dbus_message_append_uint32_array),
1989 (dbus_message_append_double_array),
1990 (dbus_message_append_byte_array),
1991 (dbus_message_append_string_array):
1992 Fix all out-of-memory handling in these functions.
1994 2003-02-21 Anders Carlsson <andersca@codefactory.se>
1996 * dbus/dbus-message.c: (dbus_message_append_nil):
1999 2003-02-21 Anders Carlsson <andersca@codefactory.se>
2001 * dbus/dbus-message.c: (dbus_message_append_args_valist),
2002 (dbus_message_append_nil), (dbus_message_append_int32_array),
2003 (dbus_message_append_uint32_array),
2004 (dbus_message_append_double_array),
2005 (dbus_message_append_byte_array),
2006 (dbus_message_append_string_array), (dbus_message_get_args_valist),
2007 (dbus_message_iter_get_int32_array),
2008 (dbus_message_iter_get_uint32_array),
2009 (dbus_message_iter_get_double_array),
2010 (dbus_message_iter_get_byte_array),
2011 (dbus_message_iter_get_string_array):
2013 * dbus/dbus-message.h:
2014 Add functions for appending and getting arrays.
2016 2003-02-21 Anders Carlsson <andersca@codefactory.se>
2018 * dbus/dbus-mempool.c (_dbus_mem_pool_new): Make the
2019 element size at least 8 bytes, fixes mempool tests on
2022 2003-02-20 Alexander Larsson <alexl@redhat.com>
2024 * dbus/dbus-transport-unix.c (unix_do_iteration):
2025 Unlock the connection mutex during a blocking select call.
2026 Add todo about how we need a way to wake up the select.
2028 * dbus/dbus-connection-internal.h:
2029 * dbus/dbus-connection.c:
2030 Add _dbus_connection_lock and _dbus_connection_unlock.
2032 2003-02-19 Havoc Pennington <hp@pobox.com>
2034 * Doxyfile.in (PREDEFINED): put DOXYGEN_SHOULD_SKIP_THIS in
2035 Doxyfile.in, not Doxyfile
2037 * dbus/dbus-keyring.c: do some hacking on this
2039 * dbus/dbus-sysdeps.c (_dbus_delete_file): new
2041 * dbus/dbus-errors.c (dbus_set_error_const): do not call
2043 (dbus_set_error): remove dbus_error_init, check for message ==
2044 NULL *before* we sprintf into it, and add @todo about including
2045 system headers in this file
2047 * dbus/dbus-sysdeps.c (_dbus_create_file_exclusively): new
2049 * dbus/dbus-errors.h (DBUS_ERROR_FAILED): add
2051 * dbus/dbus-sysdeps.c (get_user_info): break this function out to
2052 get various bits of user information based on either username
2054 (_dbus_homedir_from_username): new function
2056 2003-02-19 Anders Carlsson <andersca@codefactory.se>
2059 Add check for nonposix getpwnam_r
2061 * dbus/dbus-mempool.c: (_dbus_mem_pool_new):
2062 Align the pool element size to a sizeof (void *) boundary.
2064 * dbus/dbus-sysdeps.c: (_dbus_setenv), (_dbus_connect_unix_socket),
2065 (_dbus_listen_unix_socket), (_dbus_credentials_from_username):
2066 General Solaris fixes.
2068 * test/data/valid-messages/simplest-manual.message:
2069 Explicitly state that we want little-endian packing.
2071 2003-02-19 Mikael Hallendal <micke@codefactory.se>
2073 * dbus/dbus-server.c (dbus_server_listen): Support tcp: addresses.
2075 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_tcp_socket):
2076 Added to create a transport connecting using a tcp/ip socket.
2078 * dbus/dbus-sysdeps.c (_dbus_connect_tcp_socket): Added to connect
2079 to a tcp socket at given host and port.
2080 (_dbus_listen_tcp_socket): added to listen on tcp socket for given
2083 * dbus/dbus-server.c (dbus_server_listen): Support tcp: addresses.
2085 * dbus/dbus-server-unix.c (_dbus_server_new_for_tcp_socket):
2086 Added to create a server listening on a TCP/IP socket.
2088 2003-02-19 Havoc Pennington <hp@pobox.com>
2090 Throughout: mop up all the Doxygen warnings and undocumented
2093 * dbus/dbus-sysdeps.c (do_exec): do not use execvp, we don't want
2094 to search any paths.
2096 * dbus/dbus-threads.c: move global mutex initializers to
2097 dbus-internals.h, multiple prototypes was confusing doxygen
2098 besides being kind of ugly
2100 * Doxyfile (PREDEFINED): have Doxygen define
2101 DOXYGEN_SHOULD_SKIP_THIS so we can exclude things from
2102 docs with #ifndef DOXYGEN_SHOULD_SKIP_THIS
2103 (do not abuse the feature! it's for stuff like the autogenerated
2104 macros in dbus-md5.c, not just for things you don't feel like
2107 2003-02-18 Havoc Pennington <hp@pobox.com>
2109 * dbus/dbus-string.c (_dbus_string_zero): new function
2111 * dbus/dbus-md5.c: include MD5 implementation by L. Peter Deutsch,
2112 wrap it in some dbus-friendly API
2114 * dbus/dbus-types.h: add 16-bit types
2116 2003-02-18 Joe Shaw <joe@assbarn.com>
2118 * dbus/dbus-auth.c (handle_server_data_stupid_test_mech): Just get
2119 credentials from our currently running process.
2120 (get_word): Fix a buglet where we were copying the entire length
2121 instead of relative to our position.
2123 * dbus/dbus-hash.c (_dbus_hash_test): Don't try to allocate the
2124 keys on the stack... it's 640k of data.
2126 * dbus/dbus-sysdeps.c (_dbus_read_credentials_unix_socket): Always
2127 read the credentials byte off the socket, even if we don't have
2129 (_dbus_poll): Implement poll() using select() for systems which
2132 * glib/test-dbus-glib.c (main): Print out an error if no
2133 parameters are given.
2135 * test/data/auth/fallback.auth-script: Added. Tests that a client
2136 can fallback to a secondary auth mechanism if the first fails.
2138 2003-02-18 Havoc Pennington <hp@pobox.com>
2142 2003-02-17 Havoc Pennington <hp@pobox.com>
2144 * doc/dbus-specification.sgml: lots of cosmetic
2145 cleanups/rearrangement, add assorted FIXME, change DBUS_ADDRESS
2146 env variable to DBUS_BUS_ADDRESS, s/client/application/,
2147 s/server/bus/ (except in authentication section). Add a section
2148 "Message Bus Message Routing"
2150 2003-02-17 Anders Carlsson <andersca@codefactory.se.>
2156 2003-02-17 Anders Carlsson <andersca@codefactory.se>
2158 * doc/dbus-specification.sgml:
2159 Specification updates.
2161 2003-02-17 Anders Carlsson <andersca@codefactory.se>
2163 * bus/activation.c: (bus_activation_init), (child_setup),
2164 (bus_activation_activate_service):
2166 * bus/main.c: (main):
2167 Set DBUS_ADDRESS environment variable.
2169 * dbus/dbus-errors.c: (dbus_set_error):
2170 Don't use va_copy since that's a C99 feature.
2172 * dbus/dbus-sysdeps.c: (_dbus_setenv), (do_exec),
2173 (_dbus_spawn_async):
2174 * dbus/dbus-sysdeps.h:
2175 Add child_setup_func to _dbus_spawn_async.
2177 * doc/dbus-specification.sgml:
2178 Update specification.
2180 * test/spawn-test.c: (setup_func), (main):
2183 2003-02-17 Alexander Larsson <alexl@redhat.com>
2185 * dbus/dbus-connection.c (_dbus_connection_handler_destroyed_locked):
2188 2003-02-17 Anders Carlsson <andersca@codefactory.se>
2192 * doc/dbus-test-plan.sgml:
2193 Add test plan document.
2198 2003-02-17 Anders Carlsson <andersca@codefactory.se>
2200 * dbus/dbus-message.c: (decode_header_data),
2201 (_dbus_message_loader_return_buffer):
2202 Set the header padding amount when loading a message.
2204 2003-02-16 Anders Carlsson <andersca@codefactory.se>
2206 * bus/dispatch.c: (send_one_message):
2207 Only send broadcast messages to registered connections.
2209 * dbus/dbus-message.c: (dbus_message_name_is):
2210 * dbus/dbus-message.h:
2211 New convenience function.
2213 * dbus/dbus-transport-debug.c: (do_reading):
2214 Only dispatch one message per run.
2217 * test/bus-test.c: (new_connection_callback), (die),
2218 (test_hello_client1_handler), (test_hello_client2_handler),
2219 (test_hello_replies), (main):
2221 * test/bus-test-loop.[ch]:
2224 2003-02-16 Havoc Pennington <hp@pobox.com>
2226 * dbus/dbus-connection.c (dbus_connection_dispatch_message): fix
2227 backward conditional
2229 2003-02-16 Alexander Larsson <alexl@redhat.com>
2231 * dbus/dbus-connection.c:
2232 Implement sent_message_with_reply. (with_reply_and block is still
2234 Made dispatch_message not lose message if OOM.
2236 * dbus/dbus-errors.h:
2237 Add NoReply error (for reply timeouts).
2239 2003-02-16 Alexander Larsson <alexl@redhat.com>
2241 * dbus/dbus-hash.c (_dbus_hash_table_unref):
2242 Actually free keys and values when destroying hashtable.
2244 2003-02-16 Anders Carlsson <andersca@codefactory.se>
2246 * dbus/dbus-auth.c: (client_try_next_mechanism):
2249 * dbus/dbus-threads.c: (dbus_condvar_wait_timeout):
2250 Return TRUE if there's no thread implementation around.
2252 * glib/dbus-gmain.c: (free_source),
2253 (dbus_connection_hookup_with_g_main):
2254 Make sure to remove the GSource when the connection is finalized.
2256 2003-02-16 Anders Carlsson <andersca@codefactory.se>
2258 * bus/dispatch.c: (bus_dispatch_message_handler):
2259 * dbus/dbus-errors.h:
2260 Return an error if someone tries to send a message to a service
2263 2003-02-16 Anders Carlsson <andersca@codefactory.se>
2265 * bus/activation.c: (load_directory), (bus_activation_init),
2266 (bus_activation_activate_service):
2269 (bus_driver_handle_activate_service), (bus_driver_handle_message):
2270 More work on the activation handling.
2272 * dbus/dbus-errors.h:
2273 Add some error messages
2275 * dbus/dbus-message.c: (dbus_message_new_error_reply):
2276 * dbus/dbus-message.h:
2277 New function that creates an error message.
2279 * dbus/dbus-protocol.h:
2280 Add ACTIVATE_SERVER message.
2282 * dbus/dbus-server-unix.c: (unix_handle_watch),
2283 (_dbus_server_new_for_domain_socket):
2284 Call _dbus_fd_set_close_on_exec.
2286 * dbus/dbus-sysdeps.c: (make_pipe), (do_exec),
2287 (_dbus_spawn_async), (_dbus_disable_sigpipe),
2288 (_dbus_fd_set_close_on_exec):
2289 * dbus/dbus-sysdeps.h:
2290 Add _dbus_fd_set_close_on exec function. Also add function that checks
2291 that all open fds are set to close-on-exec and warns otherwise.
2293 * dbus/dbus-transport-unix.c:
2294 (_dbus_transport_new_for_domain_socket):
2295 Call _dbus_fd_set_close_on_exec.
2297 2003-02-16 Havoc Pennington <hp@pobox.com>
2299 * dbus/dbus-connection.c (dbus_connection_set_change_sigpipe):
2300 allow people to avoid setting SIGPIPE to SIG_IGN
2301 (_dbus_connection_new_for_transport): disable SIGPIPE unless
2302 we've been asked not to
2304 2003-02-15 Anders Carlsson <andersca@codefactory.se>
2306 * dbus/dbus-list.c: (_dbus_list_append_link),
2307 (_dbus_list_prepend_link):
2308 * dbus/dbus-memory.c: (dbus_malloc), (dbus_malloc0),
2312 2003-02-15 Anders Carlsson <andersca@codefactory.se>
2315 * bus/activation.c: (bus_activation_entry_free),
2316 (add_desktop_file_entry), (load_directory), (bus_activation_init):
2318 * bus/main.c: (main):
2319 Add simple activation support, doesn't work yet though.
2321 2003-02-15 Zack Rusin <zack@kde.org>
2323 * qt/dbus-qthread.cpp: small casting fix
2325 2003-02-15 Anders Carlsson <andersca@codefactory.se>
2327 * dbus/dbus-errors.c: (dbus_set_error):
2328 * dbus/dbus-errors.h:
2329 Add a few errors and make dbus_set_error void.
2331 * dbus/dbus-sysdeps.c:
2332 (_dbus_errno_to_string), (close_and_invalidate), (make_pipe),
2333 (write_err_and_exit), (read_ints), (do_exec), (_dbus_spawn_async):
2334 * dbus/dbus-sysdeps.h:
2335 Add _dbus_spawn_async.
2337 * test/spawn-test.c: (main):
2338 Test for _dbus_spawn_async.
2340 2003-02-15 Anders Carlsson <andersca@codefactory.se>
2342 * dbus/dbus-internals.h:
2343 Fix build without tests.
2345 * dbus/dbus-list.c: (alloc_link):
2346 Fix a segfault when a malloc fails.
2348 * dbus/dbus-memory.c: (initialize_malloc_debug), (dbus_malloc),
2349 (dbus_malloc0), (dbus_realloc):
2350 Add support for malloc debugging.
2352 2003-02-15 Alexander Larsson <alexl@redhat.com>
2354 * dbus/dbus-threads.c:
2355 * dbus/dbus-threads.h:
2356 Add condvars. Remove static mutext from API.
2357 Implement static mutexes by initializing them from threads_init.
2359 * glib/dbus-gthread.c:
2360 * qt/dbus-qthread.cpp:
2361 Update with the thread api changes.
2366 Turn StaticMutex into normal mutex + init function.
2367 Export new functions _dbus_list_alloc_link, _dbus_list_free_link,
2368 _dbus_list_append_link, _dbus_list_prepend_link
2371 * dbus/dbus-sysdeps.c:
2372 * dbus/dbus-sysdeps.h:
2373 New type dbus_atomic_t, and new functions _dbus_atomic_inc,
2374 _dbus_atomic_dec. Only slow fallback implementation at the moment.
2376 * dbus/dbus-protocol.h:
2377 Add DBUS_MESSAGE_LOCAL_DISCONNECT define
2379 * dbus/dbus-message.c:
2380 Make ref/unref atomic.
2383 * dbus/dbus-connection-internal.h:
2384 * dbus/dbus-connection.c:
2385 * dbus/dbus-connection.h:
2387 Change _peek to _borrow,_return & _steal_borrowed.
2388 Change disconnect callback to event.
2389 Make dbus_connection_dispatch_messages reentrant.
2391 * dbus/dbus-transport.c:
2392 Don't ref the connection on calls to the transport
2395 * dbus/dbus-message-handler.c:
2398 * glib/dbus-gmain.c:
2399 Don't use peek_message anymore
2402 * test/debug-thread.c:
2403 * test/debug-thread.h:
2404 Simple thread implementation that asserts() on deadlocks in
2405 single-threaded code.
2408 (main) Call debug_threads_init.
2411 Use disconnect message instead of disconnect callback.
2415 Don't call dbus_connection_set_disconnect_function. Instead export
2416 bus_connection_disconnect.
2419 Call bus_connection_disconnect when we get a disconnected message.
2421 2003-02-15 Havoc Pennington <hp@pobox.com>
2423 * dbus/dbus-message.c (dbus_message_new): fool around with the
2426 2003-02-14 Havoc Pennington <hp@pobox.com>
2428 * dbus/dbus-mempool.c: fail if the debug functions so indicate
2430 * dbus/dbus-memory.c: fail if the debug functions indicate we
2433 * dbus/dbus-internals.c (_dbus_set_fail_alloc_counter)
2434 (_dbus_decrement_fail_alloc_counter): debug functions to
2435 simulate memory allocation failures
2437 2003-02-14 Havoc Pennington <hp@pobox.com>
2439 * dbus/dbus-errors.h (struct DBusError): add a word of padding
2442 2003-02-13 Anders Carlsson <andersca@codefactory.se>
2444 * bus/driver.c: (bus_driver_handle_hello):
2446 * bus/services.c: (bus_service_lookup):
2447 Reorder message sending so we get a more sane order.
2449 * test/bus-test.c: (message_handler):
2452 2003-02-13 Anders Carlsson <andersca@codefactory.se>
2454 * bus/driver.c: (bus_driver_send_service_deleted),
2455 (bus_driver_send_service_created), (bus_driver_send_service_lost),
2456 (bus_driver_send_service_acquired), (bus_driver_handle_hello),
2457 (bus_driver_send_welcome_message),
2458 (bus_driver_handle_list_services),
2459 (bus_driver_handle_acquire_service),
2460 (bus_driver_handle_service_exists):
2461 * dbus/dbus-bus.c: (dbus_bus_register_client),
2462 (dbus_bus_acquire_service), (dbus_bus_service_exists):
2463 * dbus/dbus-errors.c: (dbus_result_to_string):
2464 * dbus/dbus-errors.h:
2465 * dbus/dbus-message.c: (dbus_message_append_args),
2466 (dbus_message_append_args_valist), (dbus_message_get_args),
2467 (dbus_message_get_args_valist), (dbus_message_get_args_iter),
2468 (dbus_message_iter_get_arg_type), (dbus_message_iter_get_string),
2469 (dbus_message_iter_get_byte_array),
2470 (dbus_message_iter_get_string_array), (message_iter_test),
2471 (check_message_handling), (_dbus_message_test):
2472 * dbus/dbus-message.h:
2473 * test/bus-test.c: (main):
2474 Change fields to arguments in messages, so that they won't be
2475 confused with header fields.
2477 * glib/test-dbus-glib.c: (main):
2478 Remove append_fields from hello message.
2480 2003-02-13 Anders Carlsson <andersca@codefactory.se>
2482 * dbus/dbus-errors.c:
2483 * dbus/dbus-message.c:
2484 * dbus/dbus-string.c:
2485 Documentation fixes.
2487 2003-02-13 Anders Carlsson <andersca@codefactory.se>
2489 * glib/dbus-gmain.c: (timeout_handler), (add_timeout),
2491 Implement support for timeouts in dbus-glib.
2493 2003-02-13 Anders Carlsson <andersca@codefactory.se>
2495 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
2496 * dbus/dbus-message.c: (process_test_subdir):
2497 * test/break-loader.c: (find_breaks_based_on):
2498 Plug some memory leaks.
2500 2003-02-13 Richard Hult <rhult@codefactory.se>
2502 * bus/main.c: Fix build.
2504 * dbus/dbus-errors.h:
2505 * dbus/dbus-errors.c: Fix copyright for Anders.
2507 2003-02-13 Anders Carlsson <andersca@codefactory.se>
2512 * bus/connection.c: (bus_connection_foreach):
2515 * bus/desktop-file.c: (grow_lines_in_section), (grow_sections),
2516 (unescape_string), (new_section), (parse_section_start),
2517 (parse_key_value), (report_error), (bus_desktop_file_load),
2518 (bus_desktop_file_get_string):
2519 * bus/desktop-file.h:
2520 Use DBusError for error reporting.
2522 * bus/dispatch.c: (send_one_message),
2523 (bus_dispatch_message_handler):
2524 * bus/driver.c: (bus_driver_send_service_deleted),
2525 (bus_driver_send_service_created), (bus_driver_send_service_lost),
2526 (bus_driver_send_service_acquired), (bus_driver_handle_hello),
2527 (bus_driver_send_welcome_message),
2528 (bus_driver_handle_list_services),
2529 (bus_driver_handle_acquire_service),
2530 (bus_driver_handle_service_exists):
2531 * bus/loop.c: (bus_loop_run):
2533 Use BUS_HANDLE_OOM instead of _DBUS_HANDLE_OOM.
2535 * bus/utils.c: (bus_wait_for_memory):
2537 New files with general utility functions.
2539 * dbus/dbus-internals.h:
2540 Remove _DBUS_HANDLE_OOM.
2542 2003-02-13 Anders Carlsson <andersca@codefactory.se>
2544 * dbus/dbus-errors.c: (dbus_result_to_string), (dbus_error_init),
2545 (dbus_error_free), (dbus_set_error_const), (dbus_set_error):
2546 * dbus/dbus-errors.h:
2547 Add DBusError structure.
2549 2003-02-13 Anders Carlsson <andersca@codefactory.se>
2551 * test/data/valid-messages/standard-acquire-service.message:
2552 * test/data/valid-messages/standard-hello.message:
2553 * test/data/valid-messages/standard-list-services.message:
2554 * test/data/valid-messages/standard-service-exists.message:
2555 Add some standard messages.
2557 2003-02-13 Anders Carlsson <andersca@codefactory.se>
2559 * bus/driver.c: (bus_driver_send_welcome_message),
2560 (bus_driver_handle_list_services),
2561 (bus_driver_handle_acquire_service),
2562 (bus_driver_handle_service_exists), (bus_driver_handle_message):
2563 Update for API changes in libdbus.
2565 * dbus/dbus-message.c: (dbus_message_new_reply):
2566 * dbus/dbus-message.h:
2567 Remove the name argument. The spec states that replies shouldn't
2570 2003-02-13 Anders Carlsson <andersca@codefactory.se>
2572 * bus/desktop-file.c: (parse_section_start), (parse_key_value),
2573 (report_error), (bus_desktop_file_load), (lookup_section),
2574 (lookup_line), (bus_desktop_file_get_raw),
2575 (bus_desktop_file_get_string):
2576 * bus/desktop-file.h:
2577 Some fixes, and new functions for getting a key value from a section.
2579 2003-02-13 Havoc Pennington <hp@pobox.com>
2581 * test/data/auth/fail-after-n-attempts.auth-script: new test
2583 * dbus/dbus-auth.c (send_rejected): shutdown_mech() when we
2586 2003-02-13 Havoc Pennington <hp@pobox.com>
2588 * dbus/dbus-auth.c (handle_server_data_external_mech): args to
2589 dbus_credentials_match were backward
2591 * dbus/dbus-auth-script.c (_dbus_auth_script_run): support
2592 NO_CREDENTIALS and ROOT_CREDENTIALS
2594 * dbus/dbus-auth.c (_dbus_auth_do_work): move get_state() routine
2595 into here. Never process more commands after we've reached an
2596 end state; store further data as unused bytes.
2598 * test/data/auth/*: add more auth tests
2600 * dbus/dbus-auth-script.c (_dbus_auth_script_run): support EXPECT
2601 command to match exact string and EXPECT_UNUSED to match unused
2604 * test/Makefile.am (dist-hook): fix to dist all the test stuff
2606 2003-02-12 Havoc Pennington <hp@pobox.com>
2608 * dbus/dbus-string.c (_dbus_string_pop_line): fix to also strip
2609 \r off of popped lines
2611 * dbus/dbus-auth.c (_dbus_auth_test): write code to run auth
2614 * dbus/dbus-auth-script.c (_dbus_auth_script_run): when doing a
2617 2003-02-12 Havoc Pennington <hp@pobox.com>
2619 * dbus/Makefile.am: remove break-loader from the build, since it
2622 * configure.in: add --enable-gcov to turn on coverage profiling
2623 flags and disable optimization
2625 2003-02-10 Havoc Pennington <hp@pobox.com>
2627 * dbus/dbus-auth-script.c, dbus/dbus-auth-script.h: sync
2628 initial cut at test framework for DBusAuth from laptop.
2629 Doesn't quite work yet but it compiles and I need to get
2630 it off the 266mhz laptop. ;-)
2632 * dbus/dbus-server-debug.c (_dbus_server_debug_accept_transport):
2633 fix a memleak in error case
2635 2003-02-12 Anders Carlsson <andersca@codefactory.se>
2638 * bus/desktop-file.c:
2639 * bus/desktop-file.h:
2640 Add a desktop file parser.
2642 2003-02-11 Zack Rusin <zack@kde.org>
2644 * qt/message.[h|cpp]: sample implementation
2645 of the KDE wrapper for DBusMessage
2647 2003-02-09 Zack Rusin <zack@kde.org>
2649 * test/bus-test.c: make_it_compile
2650 * doc/dbus-specification.sgml: minimal semantic fix
2652 2003-02-06 Anders Carlsson <andersca@codefactory.se>
2658 2003-02-06 Anders Carlsson <andersca@codefactory.se>
2661 * dbus/dbus-break-loader.c:
2663 * test/break-loader.c:
2664 Move dbus-break-loader to test/ and rename it to break-loader.
2666 2003-02-02 Havoc Pennington <hp@pobox.com>
2668 * dbus/dbus-keyring.c, dbus/dbus-keyring.h: template files
2669 for code to manage cookies in your home directory
2671 * dbus/dbus-sysdeps.c (_dbus_generate_random_bytes): new function
2673 * dbus/dbus-auth.c (get_state): impose a maximum number of tries
2674 to authenticate, then disconnect the client.
2676 2003-02-03 Alexander Larsson <alexl@redhat.com>
2678 * dbus/dbus-message.c (dbus_message_append_fields):
2681 2003-02-02 Anders Carlsson <andersca@codefactory.se>
2683 * doc/dbus-specification.sgml:
2684 Update address format section.
2686 2003-02-02 Anders Carlsson <andersca@codefactory.se>
2689 * test/bus-test.c: (get_time), (add_timeout), (remove_timeout),
2690 (message_handler), (new_connection_callback), (loop_quit),
2694 2003-02-02 Anders Carlsson <andersca@codefactory.se>
2696 * bus/driver.c: (bus_driver_handle_service_exists):
2697 Simplify the code a bit.
2699 * dbus/dbus-bus.c: (dbus_bus_service_exists):
2702 2003-02-02 Anders Carlsson <andersca@codefactory.se>
2705 Add libdbus-daemon.la and link to it.
2707 2003-02-01 James Willcox <jwillcox@gnome.org>
2709 * bus/driver.c: (bus_driver_handle_own_service):
2710 Actually include the service reply code in the message.
2712 2003-02-02 Anders Carlsson <andersca@codefactory.se>
2714 * bus/driver.c: (bus_driver_handle_service_exists):
2715 Don't unref the incoming message.
2717 2003-02-02 Anders Carlsson <andersca@codefactory.se>
2719 * dbus/dbus.h: Add dbus-address.h and dbus-bus.h
2721 2003-02-02 Anders Carlsson <andersca@codefactory.se>
2723 * dbus/dbus-server.c: (dbus_server_listen):
2724 * dbus/dbus-transport.c: (_dbus_transport_open):
2725 ifdef out the calls to the debug transport and server.
2727 2003-02-02 Alexander Larsson <alexl@redhat.com>
2729 * dbus/dbus-watch.c (dbus_watch_get_flags):
2730 Add note in the docs that ERROR or HANGUP won't be returned
2731 and are assumed always on.
2733 * glib/dbus-gmain.c (add_watch):
2734 Always add IO_ERR | IO_HUP
2736 * dbus/dbus-message.h:
2737 Add semicolon after dbus_message_iter_get_string_array().
2738 Makes qt code build again
2740 2003-02-01 Anders Carlsson <andersca@codefactory.se>
2742 * bus/driver.c: (create_unique_client_name),
2743 (bus_driver_handle_hello):
2744 Don't take a name, just use a numeric id to identify
2748 * dbus/dbus-bus.c: (dbus_bus_register_client),
2749 (dbus_bus_acquire_service), (dbus_bus_service_exists):
2751 Add new convenience functions for communicating with the bus.
2753 * dbus/dbus-message.h:
2755 * dbus/dbus-protocol.h:
2758 2003-02-01 Alexander Larsson <alexl@redhat.com>
2760 * dbus/dbus-message.c (dbus_message_append_fields):
2761 Add some more doc comments.
2763 2003-02-01 Havoc Pennington <hp@pobox.com>
2765 * dbus/dbus-break-loader.c (randomly_modify_length): change
2766 a 4-byte value in the message as if it were a length
2768 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): don't set
2769 execute bit on saved files
2771 2003-02-01 Havoc Pennington <hp@pobox.com>
2773 * dbus/dbus-break-loader.c (main): new program to find messages
2774 that break the loader.
2776 * dbus/dbus-sysdeps.c (_dbus_string_append_uint): new function
2777 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): new function
2779 * dbus/dbus-string.c (_dbus_string_set_byte): new
2781 2003-01-31 Havoc Pennington <hp@pobox.com>
2783 * dbus/dbus-message.c: refactor the test code to be more general,
2784 in preparation for writing a "randomly permute test cases to
2785 try to break the loader" program.
2787 2003-01-31 Havoc Pennington <hp@pobox.com>
2789 * doc/dbus-specification.sgml: work on the specification
2791 * dbus/dbus-message.c (_dbus_message_loader_return_buffer): check
2792 the protocol version of the message.
2794 * dbus/dbus-protocol.h: drop special _REPLY names, the spec
2795 no longer specifies that.
2796 (DBUS_SERVICE_REPLY_SERVICE_EXISTS): fix flags (1/2/4/8 not
2799 * dbus/dbus-marshal.c (_dbus_marshal_get_arg_end_pos): add missing
2800 "break" for DBUS_TYPE_NIL, remove @todo
2802 2003-01-31 Havoc Pennington <hp@pobox.com>
2804 * dbus/dbus-message.c (dbus_message_set_is_error_reply): rename
2805 just set_is_error/get_is_error as this is a commonly-used
2806 function, and write docs.
2808 2003-01-31 Anders Carlsson <andersca@codefactory.se>
2810 * dbus/dbus-address.c: (dbus_address_entry_free):
2811 Free key and value lists.
2813 * dbus/dbus-internals.c: (_dbus_type_to_string):
2814 Add the types we didn't have.
2816 * dbus/dbus-marshal.c: (_dbus_marshal_get_arg_end_pos),
2817 (_dbus_marshal_validate_arg):
2820 * dbus/dbus-message.c: (dbus_message_set_sender):
2821 Remove todo about being able to set sender to NULL.
2823 (dbus_message_set_is_error_reply),
2824 (dbus_message_get_is_error_reply):
2825 * dbus/dbus-message.h:
2828 * dbus/dbus-protocol.h:
2829 Add error reply flag.
2831 * test/data/valid-messages/opposite-endian.message:
2832 Add NIL type to test.
2834 2003-01-31 Havoc Pennington <hp@pobox.com>
2836 * doc/dbus-specification.sgml: fully specify the header. Add
2837 flags and major protocol version, and change header/body len to
2840 * dbus/dbus-message-builder.c (append_saved_length): append length
2843 * dbus/dbus-message.c (dbus_message_create_header): change header
2844 length and body length to unsigned. Add the new fields from the
2846 (_dbus_message_loader_return_buffer): unsigned header/body len
2848 2003-01-30 Havoc Pennington <hp@pobox.com>
2850 * dbus/dbus-auth.c: rework to use only REJECTED, no
2853 * doc/dbus-sasl-profile.txt: drop MECHANISMS and just
2854 use REJECTED, suggested by Mark McLoughlin
2856 2003-01-30 Havoc Pennington <hp@pobox.com>
2858 * dbus/dbus-server.c (dbus_server_listen): @todo about how we need
2859 a better way to report errors here. e.g. "unix address lacks
2860 path" or something. also "no such file" when the path doesn't
2863 * dbus/dbus-address.c (dbus_address_entries_free): add @todo about
2865 (dbus_parse_address): add @todo about documenting address format,
2866 and allowing , and ; to be escaped
2868 2003-01-30 Anders Carlsson <andersca@codefactory.se>
2871 Add dbus-address.[ch]
2873 * dbus/dbus-address.c: (dbus_address_entry_free),
2874 (dbus_address_entries_free), (create_entry),
2875 (dbus_address_entry_get_method), (dbus_address_entry_get_value),
2876 (dbus_parse_address), (_dbus_address_test):
2877 * dbus/dbus-address.h:
2878 New files for dealing with address parsing.
2880 * dbus/dbus-connection.c:
2881 Document timeout functions.
2883 * dbus/dbus-message.c:
2884 Document dbus_message_new_from_message.
2886 * dbus/dbus-server-debug.c:
2889 * dbus/dbus-server.c: (dbus_server_listen):
2890 Parse address and use correct server implementation.
2892 * dbus/dbus-string.c: (_dbus_string_find_to), (_dbus_string_test):
2893 * dbus/dbus-string.h:
2894 New function with test.
2896 * dbus/dbus-test.c: (dbus_internal_symbol_do_not_use_run_tests):
2900 * dbus/dbus-transport-debug.c:
2903 * dbus/dbus-transport.c: (_dbus_transport_open):
2904 Parse address and use correct transport implementation.
2906 2003-01-30 Havoc Pennington <hp@pobox.com>
2908 * dbus/dbus-message.c: use message->byte_order instead of
2909 DBUS_COMPILER_BYTE_ORDER throughout.
2910 (dbus_message_create_header): pad header to align the
2911 start of the body of the message to 8-byte boundary
2913 * dbus/dbus-marshal.h: make all the demarshalers take const
2914 DBusString arguments.
2916 * dbus/dbus-message.c (_dbus_message_loader_return_buffer):
2917 validate message args here, so we don't have to do slow validation
2918 later, and so we catch bad messages as they are incoming. Also add
2919 better checks on header_len and body_len. Also fill in
2922 * dbus/dbus-string.c (_dbus_string_validate_utf8): new (not
2923 implemented properly)
2924 (_dbus_string_validate_nul): new function to check all-nul
2926 * dbus/dbus-marshal.c (_dbus_marshal_get_field_end_pos): rename
2927 get_arg_end_pos and remove all validation
2928 (_dbus_marshal_validate_arg): actually do validation here.
2930 2003-01-29 Havoc Pennington <hp@pobox.com>
2932 * dbus/dbus-message.c (check_message_handling): fix assertion
2933 failure on set_client_serial
2935 2003-01-28 Havoc Pennington <hp@pobox.com>
2937 * dbus/dbus-server-debug.c: Add doc section comments
2939 * dbus/dbus-transport-debug.c: add doc section comments
2941 2003-01-28 Havoc Pennington <hp@redhat.com>
2943 * dbus/dbus-string.c (_dbus_string_base64_decode): append bytes in
2944 the reverse order from how I had it
2945 (_dbus_string_base64_encode): reverse encoding order. I was
2946 basically byteswapping everything during encoding.
2948 2003-01-28 Anders Carlsson <andersca@codefactory.se>
2950 * dbus/dbus-connection-internal.h:
2951 * dbus/dbus-connection.c: (_dbus_connection_add_timeout),
2952 (_dbus_connection_remove_timeout):
2953 Add functions for adding and removing timeouts.
2955 * dbus/dbus-message.c: (dbus_message_new_from_message):
2956 Add new function that takes a message and creates an exact
2957 copy of it, but with the refcount set to 1.
2958 (check_message_handling):
2961 * dbus/dbus-server-protected.h:
2962 * dbus/dbus-server.c: (_dbus_server_init_base),
2963 (_dbus_server_finalize_base), (_dbus_server_add_timeout),
2964 (dbus_server_set_timeout_functions):
2965 (_dbus_server_remove_timeout):
2966 New functions so that a server can add and remove timeouts.
2968 (dbus_server_listen):
2969 Add commented out call to dbus_server_debug_new.
2971 * dbus/dbus-timeout.c: (_dbus_timeout_new):
2972 Actually set the handler, doh.
2974 * dbus/dbus-transport.c: (_dbus_transport_open):
2975 Add commented out call to dbus_transport_debug_client_new.
2978 Add dbus-transport-debug.[ch] and dbus-server-debug.[ch]
2980 2003-01-28 Havoc Pennington <hp@pobox.com>
2982 * dbus/dbus-message.c (check_message_handling): function to check
2983 on the loaded message, iterates over it etc.
2985 2003-01-28 Havoc Pennington <hp@pobox.com>
2987 * test/Makefile.am (dist-hook): fix make distdir
2989 * dbus/Makefile.am (TESTS_ENVIRONMENT): fix make check
2991 2003-01-27 Havoc Pennington <hp@pobox.com>
2993 * dbus/dbus-mempool.c (time_for_size): replace printf with
2996 * dbus/dbus-message-builder.c (_dbus_message_data_load): allow
2997 empty lines; fix the SAVE_LENGTH stuff to be
2998 START_LENGTH/END_LENGTH so it actually works; couple other
3001 * test/Makefile.am (dist-hook): add dist-hook for .message files
3003 * dbus/dbus-string.c (DBUS_STRING_COPY_PREAMBLE): source of a copy
3004 can be constant or locked.
3005 (_dbus_string_free): allow freeing a const string as
3008 * dbus/dbus-sysdeps.c (_dbus_concat_dir_and_file): utility
3010 * dbus/dbus-test-main.c (main): take an argument which is the
3011 directory containing test data
3013 * dbus/dbus-message.c (_dbus_message_test): pass a test_data_dir
3014 argument to this and load all the messages in test/data/
3015 checking that they can be loaded or not loaded as appropriate.
3017 2003-01-27 Anders Carlsson <andersca@codefactory.se>
3019 * bus/dispatch.c: (bus_dispatch_message_handler):
3020 Dispatch messages sent to services.
3022 * bus/driver.c: (bus_driver_send_service_deleted),
3023 (bus_driver_send_service_created), (bus_driver_send_service_lost),
3024 (bus_driver_send_service_acquired):
3025 Add helper functions for sending service related messages.
3027 (bus_driver_send_welcome_message):
3028 Send HELLO_REPLY instead of WELCOME.
3030 (bus_driver_handle_list_services):
3031 Send LIST_SERVICES_REPLY instead of SERVICES.
3033 (bus_driver_handle_own_service),
3034 (bus_driver_handle_service_exists):
3035 New message handlers.
3037 (bus_driver_handle_message):
3038 Invoke new message handlers.
3040 (bus_driver_remove_connection):
3041 Don't remove any services here since that's done automatically
3042 by bus_service_remove_owner now.
3045 New function signatures.
3047 * bus/services.c: (bus_service_add_owner):
3048 Send ServiceAcquired message if we're the only primary owner.
3050 (bus_service_remove_owner):
3051 Send ServiceAcquired/ServiceLost messages.
3053 (bus_service_set_prohibit_replacement),
3054 (bus_service_get_prohibit_replacement):
3055 Functions for setting prohibit replacement.
3057 (bus_service_has_owner):
3058 New function that checks if a connection is in the owner queue of
3062 Add new function signatures.
3064 * dbus/dbus-list.c: (_dbus_list_test):
3065 Add tests for _dbus_list_remove_last and traversing the list backwards.
3068 Fix a typo in _dbus_list_get_prev_link, if we're at the first element we can't
3069 go any further, so return NULL then.
3071 * dbus/dbus-protocol.h:
3072 Add new messages, service flags and service replies.
3074 2003-01-26 Havoc Pennington <hp@pobox.com>
3076 * dbus/dbus-message-builder.c: implement, completely untested.
3078 * test/data/*: add data to be used in testing.
3079 ".message" files are our simple loadable text format.
3080 ".message-raw" will be binary dumps of messages.
3082 * dbus/dbus-string.c (_dbus_string_starts_with_c_str): new
3084 2003-01-26 Havoc Pennington <hp@pobox.com>
3086 * dbus/dbus-sysdeps.c (_dbus_file_get_contents): new function
3088 * dbus/dbus-errors.c (dbus_result_to_string): add
3091 * dbus/dbus-message-builder.c: new file, will contain code to load
3092 up messages from files. Not implemented yet.
3094 2003-01-26 Havoc Pennington <hp@pobox.com>
3096 * dbus/dbus-message.c (dbus_message_set_sender): support deleting
3097 the sender by setting to NULL
3099 2003-01-26 Havoc Pennington <hp@pobox.com>
3101 The unit tests pass, but otherwise untested. If it breaks, the
3102 tests should have been better. ;-)
3104 * bus/driver.c (bus_driver_handle_hello): return if we disconnect
3107 * dbus/dbus-message.c: redo everything so we maintain
3108 message->header as the only copy of the various fields.
3109 This avoids the possibility of out-of-memory in some cases,
3110 for example dbus_message_lock() can't run out of memory anymore,
3111 and avoids extra copying. Figured I may as well go ahead and do
3112 this since it was busted for dbus_message_lock to not return
3113 failure on OOM, and dbus_message_write_header was totally
3114 unchecked for OOM. Also fixed some random other bugs.
3116 * dbus/dbus-marshal.c (_dbus_marshal_get_field_end_pos): verify
3117 that strings are nul-terminated. Also, end_pos can be equal
3118 to string length just not greater than, I think.
3119 (_dbus_marshal_set_int32): new function
3120 (_dbus_marshal_set_uint32): new function
3121 (_dbus_marshal_set_string): new function
3123 * dbus/dbus-connection.c (_dbus_connection_new_for_transport): fix
3124 a warning, init timeout_list to NULL
3125 (dbus_connection_send_message): don't use uninitialized variable
3128 * dbus/dbus-string.c (_dbus_string_replace_len): new function
3130 2003-01-26 Anders Carlsson <andersca@codefactory.se>
3132 * bus/driver.c: (bus_driver_handle_hello),
3133 (bus_driver_send_welcome_message):
3136 2003-01-26 Anders Carlsson <andersca@codefactory.se>
3138 * dbus/dbus-auth.c: (process_auth), (_dbus_auth_unref):
3139 * dbus/dbus-connection.c: (_dbus_connection_new_for_transport),
3140 (dbus_connection_unref):
3141 * dbus/dbus-marshal.c: (_dbus_marshal_test):
3142 * dbus/dbus-message.c: (dbus_message_unref),
3145 (dbus_message_get_fields):
3146 Remove debugging printout.
3148 (_dbus_message_loader_return_buffer):
3149 Don't store the header string.
3151 (_dbus_message_test):
3154 2003-01-26 Richard Hult <rhult@codefactory.se>
3156 * glib/dbus-gmain.c (dbus_connection_dispatch): Traverse a copy of
3157 the file descriptor list, since it can change under us.
3159 2003-01-25 Anders Carlsson <andersca@codefactory.se>
3161 * glib/dbus-gmain.c: (dbus_connection_prepare),
3162 (dbus_connection_check), (dbus_connection_dispatch), (add_watch),
3163 (remove_watch), (dbus_connection_hookup_with_g_main):
3164 Rewrite the glib handling to use its own GSource instead of a
3165 GIOChannel so we can catch messages put in the queue while waiting
3168 2003-01-25 Anders Carlsson <andersca@codefactory.se>
3171 * bus/connection.c: (connection_disconnect_handler),
3172 (connection_watch_callback), (bus_connection_setup):
3173 * bus/dispatch.c: (send_one_message),
3174 (bus_dispatch_broadcast_message), (bus_dispatch_message_handler),
3175 (bus_dispatch_add_connection), (bus_dispatch_remove_connection):
3177 * bus/driver.c: (bus_driver_send_service_deleted),
3178 (bus_driver_send_service_created), (bus_driver_handle_hello),
3179 (bus_driver_send_welcome_message),
3180 (bus_driver_handle_list_services), (bus_driver_remove_connection),
3181 (bus_driver_handle_message):
3183 Refactor code, put the message dispatching in its own file. Use
3184 _DBUS_HANDLE_OOM. Also send ServiceDeleted messages when a client
3187 2003-01-25 Anders Carlsson <andersca@codefactory.se>
3189 * dbus/dbus-internals.h:
3190 Add _DBUS_HANDLE_OOM macro, it doesn't do anything currently.
3192 * dbus/dbus-message.c: (dbus_message_get_sender):
3193 * dbus/dbus-message.h:
3194 Implement dbus_message_get_sender.
3196 * dbus/dbus-protocol.h:
3197 Add message and service defines.
3199 2003-01-25 Anders Carlsson <andersca@codefactory.se>
3201 * dbus/dbus-connection.c: (dbus_connection_send_message):
3202 * dbus/dbus-message-internal.h:
3203 * dbus/dbus-message.c: (_dbus_message_get_client_serial),
3204 (dbus_message_write_header):
3205 Remove _dbus_messag_unlock and don't set the client serial on a
3206 message if one already exists.
3208 2003-01-24 Havoc Pennington <hp@pobox.com>
3210 * dbus/dbus-list.c (alloc_link): put a thread lock on the global
3213 * bus/driver.c (bus_driver_handle_list_services): fix a leak
3216 2003-01-25 Anders Carlsson <andersca@codefactory.se>
3218 * dbus/dbus-list.c: (alloc_link), (free_link):
3219 Use a memory pool for the links.
3221 2003-01-25 Anders Carlsson <andersca@codefactory.se>
3223 * bus/connection.c: (bus_connection_foreach):
3225 Add new bus_connection_foreach function.
3227 * bus/driver.c: (send_one_message), (bus_driver_broadcast_message):
3228 Add function that broadcasts a message to all clients.
3230 (bus_driver_send_service_created), (bus_driver_handle_hello),
3231 (bus_driver_send_welcome_message),
3232 (bus_driver_handle_list_services), (bus_driver_message_handler):
3233 Implement functions that take care of listing services, and notifying
3234 clients when new services are created.
3236 * bus/services.c: (bus_services_list):
3238 Add new function that returns an array of strings with the currently
3239 registered services.
3242 * glib/dbus-gmain.c:
3243 Update copyright year.
3245 2003-01-25 Anders Carlsson <andersca@codefactory.se>
3247 * dbus/dbus-connection.c: (dbus_connection_send_message):
3248 Unlock the message in case it was sent earlier.
3250 (dbus_connection_send_message_with_reply_and_block):
3251 Remove the reply message from the list.
3253 * dbus/dbus-marshal.c: (_dbus_demarshal_string_array):
3254 Set array_len and new_pos correctly.
3256 (_dbus_marshal_test):
3257 Remove debug output.
3259 * dbus/dbus-message-internal.h:
3260 * dbus/dbus-message.c: (_dbus_message_get_reply_serial):
3261 New function that returns the reply serial.
3263 (_dbus_message_unlock):
3264 New function that unlocks a message and resets its header.
3266 (dbus_message_append_string_array),
3267 (dbus_message_get_fields_valist),
3268 (dbus_message_iter_get_field_type),
3269 (dbus_message_iter_get_string_array),
3270 (dbus_message_get_fields),
3271 (dbus_message_append_fields_valist):
3272 Handle string arrays.
3274 (dbus_message_set_sender):
3275 Make this function public since the bus daemon needs it.
3277 (decode_header_data):
3278 Set the reply serial to -1 initially.
3280 * dbus/dbus-message.h:
3281 Add dbus_message_set_sender.
3283 2003-01-24 Havoc Pennington <hp@pobox.com>
3285 * doc/dbus-specification.sgml: add some stuff
3287 2003-01-22 Havoc Pennington <hp@pobox.com>
3289 * doc/dbus-specification.sgml: Start to document the protocol.
3291 2003-01-22 Havoc Pennington <hp@pobox.com>
3293 * dbus/dbus-connection.c
3294 (dbus_connection_send_message_with_reply_and_block): add some @todo
3296 * bus/driver.c (bus_driver_add_connection): add a FIXME about memleak
3298 2003-01-21 Havoc Pennington <hp@pobox.com>
3300 (patch untested because can't compile)
3302 * bus/driver.c (create_unique_client_name): make this function
3303 never recycle client names. Also, caller should initialize
3306 * dbus/dbus-sysdeps.c (_dbus_get_current_time): new function
3308 2003-01-21 Anders Carlsson <andersca@codefactory.se>
3310 * dbus/dbus-marshal.c: (_dbus_marshal_double),
3311 (_dbus_marshal_int32), (_dbus_marshal_uint32),
3312 (_dbus_marshal_int32_array), (_dbus_marshal_uint32_array),
3313 (_dbus_marshal_double_array), (_dbus_marshal_string_array),
3314 (_dbus_demarshal_int32_array), (_dbus_demarshal_uint32_array),
3315 (_dbus_demarshal_double_array), (_dbus_demarshal_string_array),
3316 (_dbus_marshal_get_field_end_pos), (_dbus_marshal_test):
3317 * dbus/dbus-marshal.h:
3318 * dbus/dbus-protocol.h:
3319 Add support for marshalling and demarshalling integer, double
3322 2003-01-21 Anders Carlsson <andersca@codefactory.se>
3327 * bus/connection.c: (connection_disconnect_handler):
3328 Remove the connection from the bus driver's list.
3330 (connection_watch_callback): Dispatch messages.
3332 (free_connection_data): Free connection name.
3334 (bus_connection_setup): Add connection to the bus driver's list.
3335 (bus_connection_remove_owned_service):
3336 (bus_connection_set_name), (bus_connection_get_name):
3337 Add functions for setting and getting the connection's name.
3340 Add function headers.
3342 * bus/driver.c: (create_unique_client_name),
3343 (bus_driver_handle_hello_message),
3344 (bus_driver_send_welcome_message), (bus_driver_message_handler),
3345 (bus_driver_add_connection), (bus_driver_remove_connection):
3348 * bus/services.c: (bus_service_free):
3350 New file that handles communication and registreation with the bus
3353 2003-01-21 Anders Carlsson <andersca@codefactory.se>
3355 * dbus/dbus-connection.c: (dbus_connection_send_message):
3356 Add a new client_serial parameter.
3358 (dbus_connection_send_message_with_reply):
3359 Remove a @todo since we've implemented the blocking function.
3361 (dbus_connection_send_message_with_reply_and_block):
3362 New function that sends a message and waits for a reply and
3363 then returns the reply.
3365 * dbus/dbus-connection.h:
3368 * dbus/dbus-errors.c: (dbus_result_to_string):
3369 * dbus/dbus-errors.h:
3370 Add new DBUS_RESULT.
3372 * dbus/dbus-message-internal.h:
3373 * dbus/dbus-message.c: (_dbus_message_get_reply_serial),
3374 (_dbus_message_set_sender), (dbus_message_write_header),
3375 (dbus_message_new_reply), (decode_header_data),
3376 (_dbus_message_loader_return_buffer), (_dbus_message_test):
3377 * dbus/dbus-message.h:
3378 Add new functions that set the reply serial and sender.
3379 Also marshal and demarshal them correctly and add test.
3381 * dbus/dbus-protocol.h:
3382 Add new DBUS_MESSAGE_TYPE_SENDER.
3385 * glib/dbus-gmain.c: (watch_callback), (free_callback_data),
3386 (add_watch), (remove_watch), (add_timeout), (remove_timeout),
3387 (dbus_connection_hookup_with_g_main):
3388 * glib/test-dbus-glib.c: (main):
3389 Rewrite to use GIOChannel and remove the GSource crack.
3391 * test/echo-client.c: (main):
3392 * test/watch.c: (check_messages):
3393 Update for changed APIs
3395 2003-01-19 Anders Carlsson <andersca@codefactory.se>
3397 * dbus/Makefile.am: Add dbus-timeout.[cħ]
3399 * dbus/dbus-connection.c: (_dbus_connection_new_for_transport):
3400 Create a DBusTimeoutList.
3401 (dbus_connection_set_timeout_functions): Add new function to
3402 set timeout callbacks
3404 * dbus/dbus-connection.h: Add public DBusTimeout API.
3406 * dbus/dbus-message.c: (dbus_message_get_service):
3407 * dbus/dbus-message.h: New function.
3409 * dbus/dbus-server.c: Fix small doc typo.
3411 * dbus/dbus-timeout.[ch]: New files for mainloop timeouts.
3413 2003-01-19 Anders Carlsson <andersca@codefactory.se>
3415 * dbus/dbus-string.c (_dbus_string_move_len): Don't delete all
3416 of the string, just as long as specified.
3418 2003-01-19 Havoc Pennington <hp@pobox.com>
3420 * dbus/dbus-connection.c (dbus_connection_get_is_authenticated):
3423 * dbus/dbus-server.c (dbus_server_set_max_connections)
3424 (dbus_server_get_max_connections, dbus_server_get_n_connections):
3425 keep track of current number of connections, and add API for
3426 setting a max (but haven't implemented enforcing the max yet)
3428 2003-01-18 Havoc Pennington <hp@pobox.com>
3430 * dbus/dbus-transport-unix.c (unix_do_iteration): only do the
3431 reading/writing if read_watch != NULL or write_watch != NULL.
3433 * dbus/dbus-message.c (_dbus_message_loader_return_buffer): fix
3434 the message loader code to actually load message->header and
3435 message->body into the newly-created message.
3437 * dbus/dbus-transport-unix.c (check_write_watch): fix a mem leak
3440 * dbus/dbus-connection.c (dbus_connection_set_max_message_size)
3441 (dbus_connection_get_max_message_size)
3442 (dbus_connection_set_max_live_messages_size)
3443 (dbus_connection_get_max_live_messages_size): implement some
3444 resource limitation functions
3446 * dbus/dbus-resources.c: new file implementing some of the
3447 resource limits stuff
3449 * dbus/dbus-message.c (dbus_message_iter_get_byte_array): add
3450 missing docs, add @todo to handle OOM etc.
3452 * dbus/dbus-marshal.c (_dbus_demarshal_byte_array): add missing
3455 2003-01-18 Havoc Pennington <hp@pobox.com>
3457 * dbus/dbus-connection.c (dbus_connection_unref): disconnect the
3458 connection if it hasn't been already.
3460 * dbus/dbus-connection.h: kill off the idea of an ErrorFunction,
3461 replace with DisconnectFunction.
3463 2003-01-18 Havoc Pennington <hp@pobox.com>
3465 Building --disable-verbose-mode --disable-asserts --disable-tests
3466 cuts the library from 112K to 45K or so
3468 * configure.in: check for varargs macro support,
3469 add --enable-verbose-mode, --enable-asserts.
3471 * dbus/dbus-internals.h (_dbus_assert): support
3473 (_dbus_verbose): support DBUS_ENABLE_VERBOSE_MODE
3475 2003-01-18 Havoc Pennington <hp@pobox.com>
3477 * dbus/dbus-test.c: include config.h so that tests actually run
3479 * dbus/dbus-string.c: add assertions that stuff is 8-byte aligned,
3480 so the failure mode when that assumption fails will be plenty
3483 2003-01-18 Havoc Pennington <hp@pobox.com>
3485 * configure.in: default --enable-tests to $USE_MAINTAINER_MODE
3487 * dbus/Makefile.am: fix it up so dubs-test-main.c is included in
3490 * test/Makefile.am: don't use special variable "TESTS" for echo-*
3491 since we don't want to use those in make check
3493 2003-01-15 Havoc Pennington <hp@redhat.com>
3499 2003-01-15 Havoc Pennington <hp@redhat.com>
3501 * test/Makefile.am: fix so that test source code ends up in the
3502 distribution on make distcheck
3504 2003-01-15 Havoc Pennington <hp@redhat.com>
3510 2003-01-15 Havoc Pennington <hp@redhat.com>
3512 * dbus/dbus-test.c (dbus_internal_symbol_do_not_use_run_tests):
3513 fix build when --disable-tests
3515 * Makefile.am (EXTRA_DIST): put HACKING in here
3517 * HACKING: document procedure for making a tarball release.
3519 2003-01-14 Anders Carlsson <andersca@codefactory.se>
3521 * bus/connection.c: (connection_error_handler),
3522 (bus_connection_setup):
3523 * bus/main.c: (main):
3524 Make sure that the DBusConnectionData struct is NULLed
3525 out to prevent a segfault.
3527 * dbus/dbus-errors.c: (dbus_result_to_string):
3528 * dbus/dbus-errors.h:
3529 * dbus/dbus-message.c: (dbus_message_get_fields),
3530 (dbus_message_get_fields_valist), (_dbus_message_test):
3531 * dbus/dbus-message.h:
3532 Make dbus_message_get_fields return a result code so we can
3533 track invalid fields as well as oom.
3535 2003-01-11 Havoc Pennington <hp@pobox.com>
3537 * configure.in: change --enable-test/--enable-ansi action-if-given
3538 to enable_foo=$enableval instead of enable_foo=yes
3540 2003-01-08 Havoc Pennington <hp@pobox.com>
3542 * dbus/dbus-string.c (_dbus_string_align_length): new function
3544 * dbus/dbus-test-main.c: move main() for test app here
3546 (dbus_internal_symbol_do_not_use_run_tests): we have to export a
3547 symbol to run tests, because dbus-test isn't in the main
3550 Code review nitpicks.
3552 * dbus/dbus-message.c (dbus_message_write_header): add newlines
3553 for people with narrow emacs ;-). Assert client_serial was filled
3554 in. Assert message->name != NULL.
3555 (dbus_message_append_fields): have "first_field_type" arg separate
3556 from va list, needed for C++ binding that also uses varargs IIRC
3557 and helps with type safety
3558 (dbus_message_new): add @todo about using DBusString to store
3559 service/name internally
3560 (dbus_message_new): don't leak ->service and ->name on OOM later
3562 (dbus_message_unref): free the service name
3563 (dbus_message_get_fields): same change to varargs
3564 i.e. first_field_type
3565 (_dbus_message_loader_return_buffer): assert that the message data
3566 is aligned (if not it's a bug in our code). Put in verbose griping
3567 about why we set corrupted = TRUE.
3568 (decode_header_data): add FIXME that char* is evil. Was going to
3569 add FIXME about evil locale-specific string.h strncmp, but just
3570 switched to wacky string-as-uint32 optimization. Move check for
3571 "no room for field name" above get_const_data_len() to avoid
3572 assertion failure in get_const_data_len if we have trailing 2
3573 bytes or the like. Check for service and name fields being
3574 provided twice. Don't leak service/name on error. Require field
3575 names to be aligned to 4 bytes.
3577 * dbus/dbus-marshal.c: move byte swap stuff to header
3578 (_dbus_pack_int32): uscore-prefix
3579 (_dbus_unpack_int32): uscore-prefix
3580 (_dbus_unpack_uint32): export
3581 (_dbus_demarshal_string): add @todo complaining about use of
3583 (_dbus_marshal_get_field_end_pos): add @todo about bad error
3584 handling allowing corrupt data to go unchecked
3586 2003-01-08 Havoc Pennington <hp@redhat.com>
3588 * dbus/dbus-transport-unix.c (unix_do_iteration): add read/write
3589 to the select() as needed for authentication. (should be using
3590 _dbus_poll() not select, but for another day)
3592 * dbus/dbus.h: include dbus/dbus-protocol.h
3594 2003-01-08 Anders Carlsson <andersca@codefactory.se>
3596 * dbus/Makefile.am (dbusinclude_HEADERS): Install
3599 2003-01-08 Anders Carlsson <andersca@codefactory.se>
3601 * dbus/dbus-internals.c: (_dbus_type_to_string):
3602 New function that returns a string describing a type.
3604 * dbus/dbus-marshal.c: (_dbus_demarshal_byte_array):
3605 * dbus/dbus-marshal.h:
3606 * dbus/dbus-message.c: (dbus_message_get_fields_valist),
3607 (dbus_message_iter_get_field_type), (dbus_message_iter_get_double),
3608 (dbus_message_iter_get_byte_array):
3609 * dbus/dbus-message.h:
3610 Add new convenience functions for appending and getting message fields.
3611 Also add demarshalling routines for byte arrays.
3613 2003-01-07 Anders Carlsson <andersca@codefactory.se>
3615 * dbus/dbus-connection-internal.h:
3616 * dbus/dbus-connection.c: (_dbus_connection_new_for_transport),
3617 (_dbus_connection_get_next_client_serial),
3618 (dbus_connection_send_message):
3619 * dbus/dbus-internals.h:
3620 * dbus/dbus-marshal.c: (unpack_uint32), (dbus_unpack_int32),
3621 (dbus_pack_int32), (_dbus_marshal_double), (_dbus_marshal_int32),
3622 (_dbus_marshal_uint32), (_dbus_demarshal_double),
3623 (_dbus_demarshal_int32), (_dbus_demarshal_uint32),
3624 (_dbus_demarshal_string), (_dbus_marshal_get_field_end_pos),
3625 (_dbus_verbose_bytes), (_dbus_marshal_test):
3626 * dbus/dbus-marshal.h:
3627 * dbus/dbus-message-internal.h:
3628 * dbus/dbus-message.c: (_dbus_message_set_client_serial),
3629 (dbus_message_write_header), (_dbus_message_lock),
3630 (dbus_message_new), (dbus_message_ref), (dbus_message_unref),
3631 (dbus_message_get_name), (dbus_message_append_int32),
3632 (dbus_message_append_uint32), (dbus_message_append_double),
3633 (dbus_message_append_string), (dbus_message_append_byte_array),
3634 (dbus_message_get_fields_iter), (dbus_message_iter_ref),
3635 (dbus_message_iter_unref), (dbus_message_iter_has_next),
3636 (dbus_message_iter_next), (dbus_message_iter_get_field_type),
3637 (dbus_message_iter_get_string), (dbus_message_iter_get_int32),
3638 (dbus_message_iter_get_uint32), (dbus_message_iter_get_double),
3639 (decode_header_data), (_dbus_message_loader_return_buffer),
3640 (message_iter_test), (_dbus_message_test):
3641 * dbus/dbus-message.h:
3642 * dbus/dbus-protocol.h:
3643 * dbus/dbus-test.c: (main):
3645 * glib/test-dbus-glib.c: (message_handler), (main):
3646 * test/echo-client.c: (main):
3647 * test/watch.c: (check_messages):
3648 Make messages sendable and receivable for real.
3650 2003-01-07 Anders Carlsson <andersca@codefactory.se>
3652 * dbus/dbus-marshal.c: (_dbus_marshal_double),
3653 (_dbus_marshal_string), (_dbus_marshal_byte_array):
3654 * dbus/dbus-message.c: (dbus_message_append_int32),
3655 (dbus_message_append_uint32), (dbus_message_append_double),
3656 (dbus_message_append_string), (dbus_message_append_byte_array):
3657 Handle OOM restoration.
3659 2003-01-07 Anders Carlsson <andersca@codefactory.se>
3661 * dbus/dbus-marshal.c: (_dbus_marshal_string),
3662 (_dbus_demarshal_string), (_dbus_marshal_test):
3663 * dbus/dbus-marshal.h:
3664 * dbus/dbus-message.c: (dbus_message_get_name),
3665 Document these functions.
3667 (dbus_message_append_int32), (dbus_message_append_uint32),
3668 (dbus_message_append_double), (dbus_message_append_string),
3669 (dbus_message_append_byte_array):
3670 * dbus/dbus-message.h:
3671 Add functions for adding message fields of different types.
3673 * dbus/dbus-protocol.h:
3674 Add the different types.
3676 2003-01-05 Havoc Pennington <hp@pobox.com>
3678 * bus/connection.c: implement routines for handling connections,
3679 first thing is keeping a list of owned services on each connection
3680 and setting up watches etc.
3682 * bus/services.c: implement a mapping from service names to lists
3685 * dbus/dbus-hash.c: add DBUS_HASH_POINTER
3687 * dbus/dbus-threads.c (dbus_static_mutex_lock): add functions
3688 to use static mutexes for global data
3690 * dbus/dbus-connection.c (dbus_connection_set_data): add new
3691 collection of functions to set/get application-specific data
3692 on the DBusConnection.
3694 2003-01-04 Havoc Pennington <hp@pobox.com>
3696 * dbus/dbus-sysdeps.c (_dbus_sleep_milliseconds): new function
3697 (_dbus_poll): new function
3699 * dbus/dbus-internals.h (_DBUS_STRUCT_OFFSET): new macro
3702 * bus/loop.c: initial code for the daemon main loop
3704 2003-01-04 Havoc Pennington <hp@pobox.com>
3706 * test/watch.c (error_handler): make it safe if the error handler
3707 is called multiple times (if we s/error handler/disconnect
3708 handler/ we should just guarantee it's called only once)
3710 * dbus/dbus-transport.c (_dbus_transport_disconnect): call the
3711 error handler on disconnect (it's quite possible we should
3712 just change the error handler to a "disconnect handler," I'm
3713 not sure we have any other meaningful errors)
3715 * configure.in: check for getpwnam_r
3717 * dbus/dbus-transport.c, dbus/dbus-transport-unix.c,
3718 dbus/dbus-auth.c: add credentials support, add EXTERNAL auth
3719 mechanism as in SASL spec, using socket credentials
3721 * dbus/dbus-sysdeps.c (_dbus_read_credentials_unix_socket): new function
3722 (_dbus_send_credentials_unix_socket): new function
3724 * dbus/dbus-sysdeps.c (_dbus_accept_unix_socket): rename just
3726 (_dbus_write): only check errno if <0 returned
3727 (_dbus_write_two): ditto
3729 2003-01-02 Anders Carlsson <andersca@codefactory.se>
3731 * dbus/dbus-marshal.c: (_dbus_marshal_utf8_string),
3732 (_dbus_marshal_byte_array), (_dbus_demarshal_utf8_string),
3733 (_dbus_marshal_test):
3734 * dbus/dbus-marshal.h:
3735 Add _dbus_marshal_byte_array and rename _dbus_marshal_string
3736 to _dbus_marshal_utf8_string. Also fix some tests.
3738 2002-12-28 Harri Porten <porten@kde.org>
3740 * configure.in: added check for C++ compiler and a very cheesy
3741 check for the Qt integration
3743 * Makefile.am (SUBDIRS): compile qt subdir if support is enabled
3745 * qt/Makefile.am: added
3747 * qt/.cvsignore: added
3749 * qt/dbus-qthread.cc, qt/dbus-qthread.cpp: renamed former to
3750 latter, added #ifdef QT_THREAD_SUPPORT guard.
3752 * dbus/Makefile.am: added missing headers for make dist
3754 2002-12-28 Kristian Rietveld <kris@gtk.org>
3756 * dbus/Makefile.am: fixup export-symbols-regex.
3758 2002-12-27 Anders Carlsson <andersca@codefactory.se>
3760 * acinclude.m4: Add this file and put the
3761 PKG_CHECK_MODULE macro in it.
3763 2002-12-27 Anders Carlsson <andersca@codefactory.se>
3765 * dbus/dbus-marshal.c: (_dbus_marshal_string),
3766 (_dbus_demarshal_double), (_dbus_demarshal_int32),
3767 (_dbus_demarshal_uint32), (_dbus_demarshal_string),
3768 (_dbus_marshal_test):
3769 Make the demarshalling routines align the pos argument.
3770 Add string marshalling tests and fix the obvious bugs
3773 2002-12-26 Havoc Pennington <hp@pobox.com>
3775 * dbus/dbus-auth.c: fixes fixes fixes
3777 * dbus/dbus-transport-unix.c: wire up support for
3778 encoding/decoding data on the wire
3780 * dbus/dbus-auth.c (_dbus_auth_encode_data)
3781 (_dbus_auth_decode_data): append to target string
3782 instead of nuking it.
3784 2002-12-26 Havoc Pennington <hp@pobox.com>
3786 * dbus/dbus-marshal.h (DBUS_COMPILER_BYTE_ORDER): #ifdef
3787 WORDS_BIGENDIAN then compiler byte order is DBUS_BIG_ENDIAN,
3790 * dbus/dbus-marshal.c: Add macros to do int swapping in-place and
3791 avoid swap_bytes() overhead (ignoring possible assembly stuff for
3792 now). Main point is because I wanted unpack_uint32 to implement
3794 (_dbus_verbose_bytes): new function
3796 * dbus/dbus-string.c (_dbus_string_validate_ascii): new function
3798 * dbus/dbus-message.c (_dbus_message_loader_get_is_corrupted): add
3799 mechanism to handle a corrupt message stream
3800 (_dbus_message_loader_new): fix preallocation to only prealloc,
3803 * dbus/dbus-string.c (_dbus_string_skip_blank): fix this function
3804 (_dbus_string_test): enhance tests for copy/move and fix the
3807 * dbus/dbus-transport-unix.c: Hold references in more places to
3808 avoid reentrancy problems
3810 * dbus/dbus-transport.c: ditto
3812 * dbus/dbus-connection.c (dbus_connection_dispatch_message): don't
3813 leak reference count in no-message case
3815 * test/watch.c (do_mainloop): handle adding/removing watches
3816 during iteration over the watches. Also, ref the connection/server
3817 stored on a watch, so we don't try to mangle a destroyed one.
3819 * dbus/dbus-transport-unix.c (do_authentication): perform
3822 * dbus/dbus-auth.c (get_state): add a state
3823 AUTHENTICATED_WITH_UNUSED_BYTES and return it if required
3824 (_dbus_auth_get_unused_bytes): append the unused bytes
3825 to the passed in string, rather than prepend
3827 * dbus/dbus-transport.c (_dbus_transport_init_base): create
3828 the auth conversation DBusAuth
3830 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_fd)
3831 (_dbus_transport_new_for_domain_socket): when creating a
3832 transport, pass in whether it's a client-side or server-side
3833 transport so we know which DBusAuth to create
3835 2002-12-03 Havoc Pennington <hp@pobox.com>
3837 * dbus/dbus-transport-unix.c (unix_finalize): finalize base
3838 _after_ finalizing the derived members
3839 (unix_connection_set): unref watch if we fail to add it
3841 * dbus/dbus-connection.c (dbus_connection_unref): delete the
3842 transport first, so that the connection owned by the
3843 transport will be valid as the transport finalizes.
3845 * dbus/dbus-transport-unix.c (unix_finalize): free the write_watch
3846 if necessary, and remove watches from the connection.
3848 * dbus/dbus-watch.c (_dbus_watch_list_free): improve a comment
3850 2002-12-26 Anders Carlsson <andersca@codefactory.se>
3852 * dbus/dbus-marshal.c: (_dbus_marshal_string),
3853 (_dbus_demarshal_double), (_dbus_demarshal_int32),
3854 (_dbus_demarshal_uint32), (_dbus_demarshal_string),
3855 (_dbus_marshal_test):
3856 * dbus/dbus-marshal.h:
3857 Add string marshal functions and have the demarshal functions
3858 return the new position.
3860 2002-12-25 Havoc Pennington <hp@pobox.com>
3862 * doc/dbus-sasl-profile.txt: docs on the authentication protocol,
3863 it is a simple protocol that just maps directly to SASL.
3865 * dbus/dbus-auth.h, dbus/dbus-auth.c: authentication protocol
3866 initial implementation, not actually used yet.
3868 * dbus/dbus-string.c (_dbus_string_find): new function
3869 (_dbus_string_equal): new function
3870 (_dbus_string_base64_encode): new function
3871 (_dbus_string_base64_decode): new function
3873 2002-12-25 Anders Carlsson <andersca@codefactory.se>
3876 * dbus/dbus-marshal.c: (swap_bytes), (_dbus_marshal_double),
3877 (_dbus_marshal_int32), (_dbus_marshal_uint32),
3878 (_dbus_demarshal_double), (_dbus_demarshal_int32),
3879 (_dbus_demarshal_uint32), (_dbus_marshal_test):
3880 * dbus/dbus-marshal.h:
3881 * dbus/dbus-protocol.h:
3882 * dbus/dbus-test.c: (main):
3884 Add un-optimized marshalling/demarshalling routines.
3886 2002-12-25 Harri Porten <porten@kde.org>
3888 * qt/dbus-qt.h: adjusted ctor and getter to KDE/Qt conventions
3890 2002-12-24 Zack Rusin <zack@kde.org>
3892 * qt/dbus-qthread.cc: adding - integrates QMutex into Dbus
3893 * qt/dbus-qt.h: skeleton with two sample implemenatation of the
3896 2002-12-24 Havoc Pennington <hp@pobox.com>
3898 * glib/dbus-gthread.c: fix include
3900 * glib/dbus-glib.h: rename DBusMessageHandler for now.
3901 I think glib API needs to change, though, as you don't
3902 want to use DBusMessageFunction, you want to use the
3903 DBusMessageHandler object. Probably
3904 dbus_connection_open_with_g_main_loop()
3905 and dbus_connection_setup_g_main_loop() or something like that
3906 (but think of better names...) that just create a connection
3907 that has watch/timeout functions etc. already set up.
3909 * dbus/dbus-connection.c
3910 (dbus_connection_send_message_with_reply): new function just to
3911 show how the message handler helps us deal with replies.
3913 * dbus/dbus-list.c (_dbus_list_remove_last): new function
3915 * dbus/dbus-string.c (_dbus_string_test): free a string that
3918 * dbus/dbus-hash.c: use memory pools for the hash entries
3919 (rebuild_table): be more paranoid about overflow, and
3920 shrink table when we can
3921 (_dbus_hash_test): reduce number of sprintfs and write
3922 valid C89. Add tests for case where we grow and then
3923 shrink the hash table.
3925 * dbus/dbus-mempool.h, dbus/dbus-mempool.c: memory pools
3927 * dbus/dbus-connection.c (dbus_connection_register_handler)
3928 (dbus_connection_unregister_handler): new functions
3930 * dbus/dbus-message.c (dbus_message_get_name): new
3932 * dbus/dbus-list.c: fix docs typo
3934 * dbus/dbus-message-handler.h, dbus/dbus-message-handler.c:
3935 an object representing a handler for messages.
3937 2002-12-16 Anders Carlsson <andersca@codefactory.se>
3940 * glib/dbus-gthread.c: (dbus_gthread_init):
3941 Don't use the gdbus prefix for public functions.
3943 2002-12-16 Anders Carlsson <andersca@codefactory.se>
3947 Add GLib checks and fixup .pc files
3951 * glib/dbus-gmain.c: (gdbus_connection_prepare),
3952 (gdbus_connection_check), (gdbus_connection_dispatch),
3953 (gdbus_add_connection_watch), (gdbus_remove_connection_watch),
3954 (dbus_connection_gsource_new):
3955 * glib/dbus-gthread.c: (dbus_gmutex_new), (dbus_gmutex_free),
3956 (dbus_gmutex_lock), (dbus_gmutex_unlock), (dbus_gthread_init):
3957 * glib/test-dbus-glib.c: (message_handler), (main):
3960 2002-12-15 Harri Porten <porten@kde.org>
3962 * autogen.sh: check for libtoolize before attempting to use it
3964 * dbus/dbus-transport-unix.c: include <sys/time.h> for timeval
3967 * .cvsignore: ignore more stamp files
3969 * dbus/dbus-watch.c (_dbus_watch_list_new): fixed doc error
3971 * test/Makefile.am: added -I$(top_srcdir) to be able to compile
3972 without make install.
3974 2002-12-15 Havoc Pennington <hp@pobox.com>
3976 * dbus/dbus-threads.c: add thread stubs that a higher library
3977 layer can fill in. e.g. the GLib wrapper might fill them in with
3978 GThread stuff. We still need to use this thread API to
3979 thread-safe-ize the library.
3981 2002-12-12 Havoc Pennington <hp@pobox.com>
3983 * dbus/dbus-transport-unix.c, dbus/dbus-server-unix.c: use the
3984 below new interfaces and include fewer system headers.
3986 * dbus/dbus-sysdeps.c (_dbus_read): new function
3987 (_dbus_write): new function
3988 (_dbus_write_two): new function
3989 (_dbus_connect_unix_socket): new function
3990 (_dbus_listen_unix_socket): new function
3992 * dbus/dbus-message-internal.h: change interfaces to use
3995 2002-12-11 Havoc Pennington <hp@pobox.com>
3997 * dbus/dbus-types.h: add dbus_unichar
3999 * dbus/dbus-internals.c (_dbus_verbose): use _dbus_getenv
4001 * dbus/dbus-connection.c (dbus_connection_send_message): return
4004 * dbus/dbus-transport.c: include dbus-watch.h
4006 * dbus/dbus-connection.c: include dbus-message-internal.h
4008 * HACKING: add file with coding guidelines stuff.
4010 * dbus/dbus-string.h, dbus/dbus-string.c: Encapsulate all string
4011 handling here, for security purposes (as in vsftpd). Not actually
4012 using this class yet.
4014 * dbus/dbus-sysdeps.h, dbus/dbus-sysdeps.c: Encapsulate all
4015 system/libc usage here, as in vsftpd, for ease of auditing (and
4016 should also simplify portability). Haven't actually moved all the
4017 system/libc usage into here yet.
4019 2002-11-25 Havoc Pennington <hp@pobox.com>
4021 * dbus/dbus-internals.c (_dbus_verbose): fix to not
4022 always print the first verbose message.
4024 2002-11-24 Havoc Pennington <hp@pobox.com>
4026 * test/echo-client.c, test/echo-server.c: cheesy test
4029 * configure.in (AC_CHECK_FUNCS): check for writev
4031 * dbus/dbus-message.c (_dbus_message_get_network_data): new
4034 * dbus/dbus-list.c (_dbus_list_foreach): new function
4036 * dbus/dbus-internals.c (_dbus_verbose): new function
4038 * dbus/dbus-server.c, dbus/dbus-server.h: public object
4039 representing a server that listens for connections.
4041 * dbus/.cvsignore: create
4043 * dbus/dbus-errors.h, dbus/dbus-errors.c:
4044 public API for reporting errors
4046 * dbus/dbus-connection.h, dbus/dbus-connection.c:
4047 public object representing a connection that
4048 sends/receives messages. (Same object used for
4049 both client and server.)
4051 * dbus/dbus-transport.h, dbus/dbus-transport.c:
4052 Basic abstraction for different kinds of stream
4053 that we might read/write messages from.
4055 2002-11-23 Havoc Pennington <hp@pobox.com>
4057 * dbus/dbus-internals.h (_DBUS_INT_MAX): add _DBUS_INT_MIN
4060 * dbus/dbus-test.c (main): add list test, and include
4061 dbus-test.h as intended
4063 * dbus/dbus-hash.c (_dbus_hash_table_remove_string)
4064 (_dbus_hash_table_remove_int): return value indicates
4065 whether the entry existed to remove
4067 * dbus/dbus-list.c: add linked list utility class,
4070 * dbus/dbus-hash.c: add TODO item about shrinking the hash bucket
4073 2002-11-23 Havoc Pennington <hp@pobox.com>
4075 * Doxyfile.in (INCLUDE_FILE_PATTERNS): expand DBUS_BEGIN_DECLS/
4076 DBUS_END_DECLS to nothing, that should fix this once and for all
4078 * Doxyfile.in (JAVADOC_AUTOBRIEF): set to YES
4080 * dbus/dbus-message.c, dbus/dbus-hash.c:
4081 add some missing @brief
4083 2002-11-23 Havoc Pennington <hp@pobox.com>
4085 * dbus/dbus-message.h: put semicolons after DEBUG_BEGIN_DECLS
4086 to avoid confusing Doxygen
4088 * dbus/dbus-hash.c: @} not }@
4090 * dbus/dbus-message.c (struct DBusMessage): split out
4093 2002-11-23 Havoc Pennington <hp@pobox.com>
4095 * configure.in: pile on more warning flags if using gcc
4097 * Doxyfile.in (EXTRACT_STATIC): set to NO, so we don't have
4098 to document static functions
4100 * configure.in: add summary to end of configure so it
4101 looks nice and attractive
4103 * dbus/dbus-hash.c: finish implementation and write unit
4106 * configure.in: add --enable-tests to enable unit tests
4108 * dbus/dbus-test.c: test program to run unit tests
4109 for all files in dbus/*, initially runs a test for
4112 * dbus/dbus-internals.h: file to hold some internal utility stuff
4114 2002-11-22 Havoc Pennington <hp@redhat.com>
4116 * dbus/dbus-hash.c: copy in Tcl hash table, not yet
4117 "ported" away from Tcl
4119 * dbus/dbus-types.h: header for types such as dbus_bool_t
4121 2002-11-22 Havoc Pennington <hp@redhat.com>
4123 * dbus/dbus.h: fixups for doc warnings
4125 * Doxyfile.in (FILE_PATTERNS): we need to scan .h to pick up
4127 (QUIET): make it quiet so we can see warnings
4129 * dbus/dbus-memory.c: teach D-BUS to allocate and free memory
4131 2002-11-22 Havoc Pennington <hp@redhat.com>
4133 * Makefile.am: include "Doxyfile" target in all-local
4135 * configure.in: generate the Doxyfile
4137 * Doxyfile.in: move Doxyfile here, so we can use
4138 configure to generate a Doxyfile with the right
4141 2002-11-22 Havoc Pennington <hp@redhat.com>
4143 * dbus/dbus-message.c: move inline docs into .c file
4145 * Doxyfile (OUTPUT_DIRECTORY): move output to doc/api
4146 so all docs are under doc/
4147 (MAN_EXTENSION): generate man pages. Use extension
4148 ".3dbus" which matches ".3qt" on my system,
4149 I guess this is OK, I don't know really.
4150 (FILE_PATTERNS): look for .c files not .h, makes sense
4153 2002-11-22 Havoc Pennington <hp@pobox.com>
4155 * Makefile.am (SUBDIRS): rename subdir "server" to "bus"
4156 because any app can be a server, and any app can be a client,
4157 the bus is a special kind of server.
4159 Thu Nov 21 23:35:31 2002 Zack Rusin <zack@kde.org>
4161 * Doxyfile : adding. Still needs Makefile rules to be generated
4162 automatically (just run "doxygen" in the toplevel dir for now to
4165 * dbus/dbus-message.h : Adding sample docs (javadoc since
4166 resembles gtk-doc a little more)
4168 * dbus/dbus.h : Adding sample docs
4170 2002-11-21 Havoc Pennington <hp@redhat.com>
4172 * dbus/Makefile.am (INCLUDES): define DBUS_COMPILATION
4173 so we can allow ourselves to include files directly,
4174 instead of having to use dbus.h
4176 * dbus/dbus.h: fill in
4178 * dbus/dbus-message.h: sketch out a sample header file.
4179 Include griping if you include it directly instead of
4182 * dbus/dbus-macros.h: new file with macros for extern "C",
4183 TRUE/FALSE, NULL, etc.
4185 * doc/file-boilerplate.c: put include guards in here
4187 2002-11-21 Havoc Pennington <hp@redhat.com>
4189 * doc/file-boilerplate.c: include both AFL and GPL boilerplate.
4191 * COPYING: include the GPL as well, and license code
4192 under both AFL and GPL.
4194 2002-11-21 Havoc Pennington <hp@redhat.com>
4196 * acconfig.h: get rid of this
4198 * autogen.sh (run_configure): add --no-configure option
4200 * configure.in: remove AC_ARG_PROGRAM to make
4201 autoconf complain less. add AC_PREREQ.
4202 add AC_DEFINE third arg.
4204 2002-11-21 Anders Carlsson <andersca@codefactory.se>
4207 Fix references so we can distcheck.
4209 2002-11-21 Havoc Pennington <hp@redhat.com>
4211 * Initial module creation