1 2003-04-18 Havoc Pennington <hp@pobox.com>
3 * dbus/dbus-auth.c (record_mechanisms): memleak fixes
5 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): fix some
8 * dbus/dbus-keyring.c (add_new_key): fix a memleak, and
9 on realloc be sure to update the pointer in the keyring
11 * dbus/dbus-string.c (_dbus_string_zero): compensate for align
12 offset to avoid writing to unallocated memory
14 * dbus/dbus-auth.c (process_rejected): return FALSE if we fail to
15 try the next mechanism, so we properly handle OOM
17 * dbus/dbus-keyring.c (_dbus_keyring_new_homedir): fix double-free
19 (_dbus_keyring_new): fix OOM bug
20 (_dbus_keyring_new_homedir): always set error; impose a maximum
21 number of keys we'll load from the file, mostly to speed up the
22 test suite and make its OOM checks more useful, but also for
25 * dbus/dbus-auth.c (process_error_server): reject authentication
26 if we get an error from the client
27 (process_cancel): on cancel, send REJECTED, per the spec
28 (process_error_client): send CANCEL if we get an error from the
31 2003-04-18 Havoc Pennington <hp@pobox.com>
33 * dbus/dbus-mainloop.c (_dbus_loop_iterate): fix UMR in verbose
36 * dbus/dbus-auth.c (handle_client_data_cookie_sha1_mech): fix OOM
39 * dbus/dbus-keyring.c (_dbus_keyring_new_homedir): only whine
40 about DBUS_TEST_HOMEDIR once
42 * bus/Makefile.am (TESTS_ENVIRONMENT): put DBUS_TEST_HOMEDIR in
45 * bus/dispatch.c (bus_dispatch_sha1_test): actually load sha1
46 config file so we test the right thing
48 Throughout: assorted docs improvements
50 2003-04-18 Havoc Pennington <hp@pobox.com>
52 * glib/dbus-gmain.c: adapt to watch changes
54 * bus/bus.c, bus/activation.c, etc.: adjust to watch changes
56 * dbus/dbus-server.h: remove dbus_server_handle_watch
58 * dbus/dbus-connection.h: remove dbus_connection_handle_watch
60 * dbus/dbus-watch.c (dbus_watch_handle): change DBusWatch to work
61 like DBusTimeout, so we don't need dbus_connection_handle_watch
64 2003-04-17 Havoc Pennington <hp@redhat.com>
66 * dbus/dbus-userdb.c, dbus/dbus-sysdeps.c: redo all the passwd
67 database usage so it all goes via the DBusUserDatabase cache.
69 2003-04-17 Havoc Pennington <hp@redhat.com>
71 * dbus/dbus-mainloop.c (_dbus_loop_iterate): fix logic so that if
72 there was an OOM watch we skipped, we always return TRUE so we
73 iterate again to have a look at it again. Fixes test suite hang.
74 Code rearrangement also lets us lose some memset and only iterate
77 * bus/driver.c (bus_driver_handle_message): sense of test for
80 2003-04-16 Havoc Pennington <hp@pobox.com>
82 * doc/dbus-specification.sgml: make spec say serials are unsigned
84 * dbus/dbus-message.h: change message serials to unsigned
86 * dbus/dbus-connection.c: adapt to message serials being unsigned
88 2003-04-15 Havoc Pennington <hp@pobox.com>
90 * bus/bus.c: create and keep around a shared DBusUserDatabase
93 * bus/connection.c (bus_connection_get_groups): don't cache
94 groups for user in the connection object, since user database
97 2003-04-16 Havoc Pennington <hp@redhat.com>
99 * dbus/dbus-message.c (_dbus_message_add_size_counter): keep a
100 list of size counters
101 (_dbus_message_loader_putback_message_link): put back a popped link
103 * dbus/dbus-connection.c
104 (dbus_connection_set_max_live_messages_size): rename
106 (dbus_connection_get_outgoing_size): get size of outgoing
108 (_dbus_connection_set_connection_counter): remove this cruft
110 2003-04-14 Havoc Pennington <hp@redhat.com>
112 * dbus/dbus-userdb.c: user database abstraction, mostly to get
113 caching, but at some point we might want to be able to use a
116 * bus/dispatch.c (bus_dispatch_sha1_test): add a test that uses
117 SHA1 conf file to test the sha1 auth mechanism, since the regular
118 test always uses EXTERNAL when available.
121 test/data/valid-config-files/debug-allow-all-sha1.conf.in:
122 add conf file that requires use of sha1 auth
124 2003-04-13 Havoc Pennington <hp@pobox.com>
126 * tools/dbus-send.c, tools/dbus-monitor.c: two utility programs
127 from Philip Blundell to send messages and monitor them.
129 2003-04-13 Havoc Pennington <hp@pobox.com>
131 * dbus/dbus-mainloop.c: fix some reentrancy issues by refcounting
134 * test/data/valid-config-files/debug-allow-all.conf.in: allow all
137 * dbus/dbus-transport.c (_dbus_transport_get_dispatch_status):
138 fix to only recover unused bytes if we're already authenticated
139 (_dbus_transport_get_is_authenticated): fix to still mark us
140 authenticated if there are unused bytes.
142 * bus/dispatch.c: implement security policy checking
144 * bus/connection.c (bus_transaction_send_from_driver): new
146 * bus/bus.c (bus_context_check_security_policy): new
148 * bus/dispatch.c (send_service_nonexistent_error): delete this,
149 now we just set the DBusError and it gets converted to an error
152 * bus/connection.c (allow_user_function): enable code using actual
153 data from the config file
155 * bus/policy.c (list_allows_user): handle wildcard rules for
156 user/group connection perms
158 2003-04-13 Havoc Pennington <hp@pobox.com>
160 * bus/config-parser.c: Load up the BusPolicy and BusPolicyRules
162 * dbus/dbus-sysdeps.c (_dbus_get_user_id): new function
164 * bus/policy.c (bus_policy_append_mandatory_rule)
165 (bus_policy_append_default_rule, bus_policy_append_user_rule)
166 (bus_policy_append_group_rule): new functions
168 2003-04-12 Havoc Pennington <hp@pobox.com>
170 * bus/config-parser.c (bus_config_parser_new): fix a memleak
172 * dbus/dbus-sysdeps.c: change DBusCredentials to use longs for
173 the pid/gid/uid, just for paranoia.
175 * test/break-loader.c (randomly_do_n_things): find a byte
176 containing a type code, and randomly change it to a different
179 2003-04-12 Havoc Pennington <hp@pobox.com>
181 * bus/policy.h: change BusPolicy to be the thing from the config
182 file, and rename old BusPolicy to BusClientPolicy
184 * bus/bus.c, bus/connection.c, bus/config-parser.c: change to
185 match change in how policy works
187 * dbus/dbus-internals.h: mark assert_not_reached as
188 __attribute((noreturn))__
190 2003-04-11 Havoc Pennington <hp@redhat.com>
192 * doc/dbus-specification.sgml: fix a spot with the wrong name for
193 the broadcast service. Use boolean return for ServiceExists.
195 2003-04-11 Havoc Pennington <hp@redhat.com>
197 * configure.in: add another directory to look for qt in.
199 2003-04-11 Havoc Pennington <hp@redhat.com>
201 * AUTHORS: add Colin Walters
203 2003-04-11 Havoc Pennington <hp@redhat.com>
209 2003-04-11 Havoc Pennington <hp@redhat.com>
211 * bus/messagebus.in: remove pid file when stopping the
212 message bus, since the bus won't have privileges to remove it
215 2003-04-11 Havoc Pennington <hp@redhat.com>
217 * bus/bus.c (bus_context_new): move credentials change after
220 2003-04-11 Havoc Pennington <hp@pobox.com>
222 * test/decode-gcov.c: add "below average functions" to the
223 coverage report, and change how some of the code works.
225 * bus/test-main.c: bracket some stuff in DBUS_BUILD_TESTS so it's
226 not in the coverage stats.
228 * test/test-service.c (main): use _dbus_verbose not fprintf in a
229 couple places so running the test suite doesn't result in megaspam.
231 2003-04-11 Havoc Pennington <hp@pobox.com>
233 * bus/dispatch.c (check_existent_service_activation): accept a no
234 memory error in a place we didn't before
236 * bus/test.c (bus_test_run_everything): remove hacky "do it twice
237 in case the first one failed," since the test suite is less
240 2003-04-10 Havoc Pennington <hp@pobox.com>
242 * bus/dispatch.c (check_segfault_service_activation): add test
243 for launching an executable that just crashes.
245 * test/test-segfault.c (main): try setting coredumpsize to 0 so we
246 don't leave a million cores. We'll see how portable this is.
248 2003-04-10 Havoc Pennington <hp@pobox.com>
250 * dbus/dbus-spawn.c (_dbus_spawn_async_with_babysitter): move all
251 the possible parent failures before we fork, so that we don't
252 fail to create a babysitter after creating the child.
254 * bus/activation.c (bus_activation_activate_service): kill child
255 if we don't successfully complete the activation.
257 2003-04-10 Havoc Pennington <hp@redhat.com>
259 * dbus/dbus-connection.c (dbus_connection_flush): don't spin on
260 the connection if it's disconnected
262 * bus/activation.c (bus_activation_service_created): use new
263 transaction features to roll back removal of pending activation if
264 we don't successfully create the service after all. Don't remove
265 pending activation if the function fails.
267 * dbus/dbus-list.c (_dbus_list_insert_before_link)
268 (_dbus_list_insert_after_link): new code to facilitate
271 * dbus/dbus-hash.c (_dbus_hash_table_insert_string_preallocated):
272 new functionality, so we can preallocate the ability to insert
275 * bus/connection.c (bus_transaction_add_cancel_hook): new function
276 allowing us to put custom hooks in a transaction to be used for
277 cancelling said transaction
279 * doc/dbus-specification.sgml: add some discussion of secondary
280 service owners, and disallow zero-length service names
282 * bus/services.c (bus_registry_acquire_service): new function,
283 splits out part of bus_driver_handle_acquire_service() and fixes
284 a bug where we didn't remove the service doing the acquiring
285 from the secondary queue if we failed to remove the current owner
286 from the front of the queue.
288 2003-04-10 Alexander Larsson <alexl@redhat.com>
290 * doc/dbus-specification.sgml:
291 s/org.freedesktop.Broadcast/org.freedesktop.DBus.Broadcast/
293 2003-04-10 Alexander Larsson <alexl@redhat.com>
298 Added files to cvsignore
300 * dbus/dbus-message.h:
301 * dbus/dbus-message.c: (dbus_message_iter_get_named):
302 Make get_named() take two out argument and return a boolean.
303 (dbus_message_iter_get_args_valist):
304 Update usage of get_named().
305 (dbus_message_iter_append_byte):
307 (dbus_message_iter_append_named)
309 (message_iter_test), (check_message_handling_type), (_dbus_message_test):
312 2003-04-10 Alexander Larsson <alexl@redhat.com>
314 * dbus/dbus-marshal.[ch]:
315 Add array_type_pos argument to _dbus_marshal_validate_arg.
316 Let you pass a NULL end_pos to _dbus_marshal_validate_type.
318 * dbus/dbus-message.[ch]:
319 Multi-dimensional arrays have full type specification in the
320 outermost array. Iter code re-arranged to handle this.
321 Added some more iter tests.
323 * doc/dbus-specification.sgml:
326 Update new array encoding description.
327 Correct DBUS_SERVICE_FLAGS_REPLACE_EXISTING description.
329 * test/data/invalid-messages/array-with-mixed-types.message:
330 * test/data/valid-messages/array-of-array-of-uint32.message:
331 Change to the new array format.
333 * test/data/invalid-messages/too-short-dict.message:
336 * test/data/valid-messages/recursive-types.message:
337 Fix up and extend test.
339 2003-04-10 Havoc Pennington <hp@pobox.com>
341 * bus/dispatch.c: lots of fixes
343 * dbus/dbus-mainloop.c (_dbus_loop_dispatch): export
344 (_dbus_loop_iterate): remove old "quit if no callbacks" code,
345 that was crack, broke the test service.
347 * dbus/dbus-transport.c (_dbus_transport_open): fix error
348 handling to avoid piling up errors if we get a failure on the
351 * dbus/dbus-internals.c (_dbus_real_assert_not_reached): include
352 pid in assertion failures.
354 * dbus/dbus-mainloop.c (_dbus_loop_iterate): use static arrays up
355 to some fixed size of file descriptor array. Don't return TRUE
356 anytime a timeout exists, that led to lots of busy loop silliness
359 2003-04-09 Havoc Pennington <hp@redhat.com>
361 * dbus/dbus-mainloop.c (check_timeout): fix timeouts, I thought
362 I'd checked this in earlier but hadn't.
364 2003-04-09 Havoc Pennington <hp@redhat.com>
366 * bus/dispatch.c (bus_dispatch_test): get a bit further through
367 the activation test (man this is getting old!)
369 2003-04-09 Havoc Pennington <hp@redhat.com>
371 * test/test-utils.c: use dispatch status function to fix this up
373 * bus/connection.c (connection_watch_callback): don't dispatch
375 (connection_timeout_callback): don't dispatch from here
376 (bus_connections_setup_connection): set the dispatch status function
377 (bus_connection_disconnected): unset it
379 * dbus/dbus-mainloop.c (_dbus_loop_queue_dispatch): new function
380 used to add a connection to be dispatched
381 (_dbus_loop_iterate): do the dispatching at the end of each
384 * dbus/dbus-connection.c
385 (dbus_connection_set_dispatch_status_function): new function
386 allowing us to fix up main loop usage
387 (_dbus_connection_last_unref): free all the various function
389 (dbus_connection_dispatch): call the DispatchStatusFunction
390 whenever this function returns
391 (dbus_connection_handle_watch): call DispatchStatusFunction
392 (dbus_connection_send_with_reply_and_block): call DispatchStatusFunction
393 (reply_handler_timeout): call DispatchStatusFunction
394 (dbus_connection_flush): call DispatchStatusFunction
396 2003-04-09 Havoc Pennington <hp@redhat.com>
398 * dbus/dbus-bus.c (dbus_bus_register): fix up error handling and
401 * bus/dispatch.c (check_service_activated): fix bug in test
403 * dbus/dbus-mainloop.c (check_timeout): fix this up
405 * dbus/dbus-internals.c (_dbus_verbose_real): include PID in
406 verbose output so we can sort out output from different processes,
407 e.g. in the activation case.
409 2003-04-08 Colin Walters <walters@gnu.org>
411 * bus/bus.c (struct BusContext) [pidfile]: New member, to store
413 (bus_context_new): Set it.
414 (bus_context_unref): Use it to delete the pid file.
416 2003-04-08 Havoc Pennington <hp@redhat.com>
418 * test/data/invalid-messages/array-with-mixed-types.message:
419 regression test that fails for the moment
421 * dbus/dbus-test.c (dbus_internal_do_not_use_run_tests): reorder
422 tests for convenience
424 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): don't allow
425 array of nil, it broke things.
427 * test/data/invalid-messages/array-of-nil.message: regression test
429 * test/data/valid-messages/array-of-array-of-uint32.message:
430 happened to write this so added it to suite
432 2003-04-08 Havoc Pennington <hp@redhat.com>
434 * bus/driver.c (bus_driver_handle_acquire_service): init
435 retval/reply before checking name
437 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): add a
438 recursion depth argument
440 * dbus/dbus-message.h (struct DBusMessageIter): put some padding
441 in the public struct for future extension
443 * dbus/dbus-message-builder.c (_dbus_message_data_load): fix
446 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): fix a verbose
449 * doc/dbus-specification.sgml: fix typo
451 2003-04-08 Alexander Larsson <alexl@redhat.com>
453 Implemented recursive types, named types and new-style iters
456 * glib/test-thread-client.c: (thread_func):
457 * glib/test-thread-server.c: (handle_test_message):
458 * test/test-service.c: (handle_echo):
467 * dbus/dbus-internals.c: (_dbus_type_to_string):
468 Update for new types.
470 * dbus/dbus-marshal.[ch]:
471 Implement recursive types and the new marshalling format.
472 Remove hardcoded dict marshalling.
475 * dbus/dbus-message-builder.c:
477 Remove references to old types
479 * dbus/dbus-message.[ch]:
480 New non-refcounted iter API that supports recursive iters.
481 Use iters for appending, including support for recursive
483 Add byte and named type support.
484 Update everything to new marshalling formats.
485 Add tests for new API.
487 * dbus/dbus-protocol.h:
488 Remove old array types.
489 Add types: BYTE, ARRAY, DICT, NAMED
491 * dbus/dbus-string.c:
492 * dbus/dbus-sysdeps.c:
493 Make parse_double locale safe.
495 * dbus/dbus-test-main.c:
501 * doc/dbus-specification.sgml:
504 * test/data/incomplete-messages/missing-body.message:
505 * test/data/invalid-messages/bad-boolean.message:
506 * test/data/invalid-messages/bad-boolean-array.message:
507 * test/data/invalid-messages/boolean-array-length-too-long.message-raw:
508 * test/data/invalid-messages/boolean-has-no-value.message-raw:
509 * test/data/invalid-messages/too-short-dict.message:
510 * test/data/valid-messages/dict-simple.message:
511 * test/data/valid-messages/dict.message:
512 * test/data/valid-messages/emptiness.message:
513 * test/data/valid-messages/lots-of-arguments.message:
514 * test/data/valid-messages/no-padding.message:
515 * test/data/valid-messages/recursive-types.message:
516 Add missing NAME fields
517 Fix up dicts & arrays
519 * test/data/invalid-messages/dict-with-nil-value.message:
520 Removed, this is not invalid anymore.
522 * test/data/valid-messages/recursive-types.message:
523 Add new test for deeply recursive types.
525 2003-04-07 Havoc Pennington <hp@pobox.com>
527 * bus/driver.c (bus_driver_handle_acquire_service): return an
528 error if you try to acquire a service that starts with ':'
530 2003-04-07 Havoc Pennington <hp@redhat.com>
532 * doc/dbus-specification.sgml: require that base service names
533 start with ':' and that the base service is created/deleted
534 as first and last things a connection does on the bus
536 * bus/dispatch.c (check_existent_service_activation): lots more
537 work on the activation test; it doesn't fully pass yet...
539 * test/test-service.c (main): fix so we don't memleak the
540 connection to the message bus
541 (filter_func): accept a message asking us to exit
543 2003-04-06 Havoc Pennington <hp@pobox.com>
545 * qt/Makefile.am (dbusinclude_HEADERS): install dbus-qt.h,
548 * configure.in: fixes to Qt detection from Colin Walters
550 * doc/Makefile.am: Only remove generated docbook dirs if they
551 exist, from Colin Walters
553 * dbus/dbus-bus.c: change how we set well-known connections to
554 NULL, so that it works if a single connection is stored in
555 two well-known array slots.
557 * test/Makefile.am: remove a lot of stuff that isn't immediately
558 useful, it's in CVS history if we want it.
560 * test/test-service.c: use dbus-mainloop instead of that
563 2003-04-06 Havoc Pennington <hp@pobox.com>
565 * dbus/Makefile.am: split lists of sources into stuff that goes in
566 the library, util functions that go in the lib and are also used
567 elsewhere, and util functions that are used in tests/daemon but
570 * dbus/dbus-mainloop.h, dbus/dbus-mainloop.c: move bus/loop.[hc]
571 here so it can be used in test binaries also
573 2003-04-06 Havoc Pennington <hp@pobox.com>
575 * dbus/dbus-sysdeps.c (_dbus_become_daemon): write the pidfile
576 here in the parent process, so we can return an error if it
577 fails. Also, move some of the code into the child so the parent
578 is less hosed if we fail midway through.
580 * bus/bus.c (bus_context_new): move pidfile detection further up
581 in the function, before we start overwriting sockets and such.
583 * bus/messagebus.in: adjust this a bit, not sure if it will work.
585 * configure.in: add --with-system-pid-file and --with-system-socket
587 2003-04-06 Colin Walters <walters@verbum.org>
589 * configure.in (DBUS_SYSTEM_PID_FILE): New variable.
591 * bus/system.conf.in: Declare a pidfile.
593 * bus/bus.c (bus_context_new): Test for an existing pid file, and
594 create one (if appropriate).
596 * bus/config-parser.c (enum ElementType) [ELEMENT_PIDFILE]: New.
597 (struct BusConfigParser) [pidfile]: New.
598 (element_type_to_name, merge_included, start_busconfig_child)
599 (bus_config_parser_end_element, bus_config_parser_content): Handle it.
600 (bus_config_parser_unref): Free it.
601 (bus_config_parser_get_pidfile): New function.
603 * bus/config-parser.h (_dbus_write_pid_file): Prototype.
605 * dbus/dbus-errors.h (DBUS_ERROR_PIDFILE_EXISTS): New error.
607 * dbus/dbus-sysdeps.c (_dbus_write_pid_file): New function.
609 * dbus/dbus-sysdeps.h: Prototype it.
611 2003-04-06 Havoc Pennington <hp@pobox.com>
613 * bus/bus.c (bus_context_new): print the address in here, rather
614 than in main(), because we need to do it before forking the daemon
616 * bus/dispatch.c (send_service_nonexistent_error): set the sender
617 on the service nonexistent error
619 * bus/driver.c (bus_driver_handle_acquire_service): set the
620 sender on the AcquireService reply
622 * test/data/valid-config-files/debug-allow-all.conf.in: Make test
623 server also listen on a UNIX socket so services can connect to it.
625 2003-04-06 Havoc Pennington <hp@pobox.com>
627 * dbus/dbus-threads.c: Redo how the fake debug mutexes are done
628 so it detects deadlocks and also we actually init threads when
631 2003-04-06 Havoc Pennington <hp@pobox.com>
633 * dbus/dbus-server-unix.c (_dbus_server_new_for_domain_socket):
634 save the domain socket name, and unlink it when we disconnect the
635 server. Means that at least when we exit normally, we won't leave
636 a bunch of junk in /tmp
638 * dbus/dbus-transport-unix.c
639 (_dbus_transport_new_for_domain_socket): code cleanup (nicer
640 memory management). (I was making a real change here but then
643 2003-04-06 Havoc Pennington <hp@pobox.com>
645 * bus/bus.c (bus_context_new): fix wrong handling of
646 server_data_slot_unref() in the error case.
648 * dbus/dbus-internals.h (_dbus_assert): change so it passes
649 "(condition) != 0" to _dbus_real_assert so that
650 "_dbus_assert (pointer)" doesn't cause a warning
652 * bus/main.c (main): accept --print-address option to print out
653 the message bus address
655 * dbus/dbus-sysdeps.c (_dbus_generate_random_ascii): export this
657 * dbus/dbus-transport.c (_dbus_transport_open): special error for
658 "tmpdir" option to unix: address on client side
660 * dbus/dbus-server.c (dbus_server_listen): handle "tmpdir" option
663 * configure.in (TEST_SOCKET_DIR): locate a temporary directory
664 we can use to create sockets in the test suite.
666 * bus/main.c (signal_handler): on SIGTERM, exit the daemon
667 cleanly. To be used for testing.
669 * dbus/dbus-spawn.c (babysit): use _dbus_set_signal_handler()
671 * dbus/dbus-sysdeps.c (_dbus_set_signal_handler): new
673 * dbus/dbus-server-debug-pipe.c (_dbus_transport_debug_pipe_new):
674 handle trying to call this when there's no servers active
676 2003-04-05 Havoc Pennington <hp@pobox.com>
682 2003-04-05 Havoc Pennington <hp@pobox.com>
684 * bus/bus.c (setup_server): fix this so dbus-daemon-1 doesn't
685 crash on startup. Need to get "try starting the daemon"
686 in the test suite I guess. ;-)
688 * dbus/dbus-server.h, dbus/dbus-server.c: remove the stuff that
689 tracked the number of open connections; it's better done in
690 application-specific code as you want it to span all servers etc.
692 2003-04-05 Havoc Pennington <hp@pobox.com>
694 * bus/Makefile.am (install-data-hook): add missing DESTDIR,
695 patch from Colin Walters
697 2003-04-05 Havoc Pennington <hp@pobox.com>
699 * doc/config-file.txt (Elements): fix docs of <auth> to reflect
700 reality; in fact multiple mechanisms are allowed.
702 * dbus/dbus-internals.c (_dbus_real_assert)
703 (_dbus_real_assert_not_reached): move guts of _dbus_assert() and
704 _dbus_assert_not_reached() into functions, so that they don't show
705 up in basic block counts for test coverage, and don't use up as
706 much disk space. Does mean slower execution speed though, so
707 assumes --disable-asserts is the normal production case.
709 2003-04-05 Havoc Pennington <hp@pobox.com>
711 * test/Makefile.am (dist-hook): also dist *.in files
717 2003-04-05 Havoc Pennington <hp@pobox.com>
719 * dbus/dbus-string.c: docs warning
721 * dbus/dbus-spawn.c: missing docs
723 * dbus/dbus-memory.c (struct ShutdownClosure): missing docs
725 2003-04-05 Havoc Pennington <hp@pobox.com>
727 * bus/loop.c (bus_loop_iterate): fix the timeout code, using
730 * dbus/dbus-spawn.c (_dbus_babysitter_unref): set sitter_pid
731 to -1 once we've reaped the babysitter
732 (_dbus_babysitter_handle_watch): do as much work as we can, not
735 * bus/activation.c: add code using DBusBabysitter so that we
736 handle it when a service fails to start up properly.
737 (bus_activation_service_created): don't remove the activation
738 entries as we go, just let them get removed when we free the pending
739 activation. Unref reply messages after sending them.
741 2003-04-05 Havoc Pennington <hp@pobox.com>
743 * test/decode-gcov.c (main): print per-directory stats in the report
745 * Makefile.am (coverage-report.txt): don't include test/* in gcov stats
747 2003-04-05 Havoc Pennington <hp@pobox.com>
749 * Makefile.am (coverage-report.txt): add target "coverage-report.txt"
751 * test/decode-gcov.c: hack up a little program to suck data
752 out of gcov files. Yes this is sort of silly.
754 * configure.in: define something in config.h and do an
755 AM_CONDITIONAL when gcov is enabled
757 2003-04-04 Havoc Pennington <hp@redhat.com>
759 * dbus/dbus-spawn.c, dbus/dbus-spawn.h: Change dbus_spawn to
760 return a "babysitter" object that is used to monitor the status of
761 the spawned process and reap it when required.
763 * test/test-segfault.c, test/test-exit.c,
764 test/test-sleep-forever.c: binaries that do various lame things,
765 used in the test suite.
767 * dbus/dbus-sysdeps.c: kill _dbus_errno_to_string()
769 2003-04-03 Havoc Pennington <hp@pobox.com>
771 * dbus/dbus-spawn.c: Move dbus-spawn into a separate file
772 in preparation for modifying it, dbus-sysdeps is getting
775 2003-04-03 Havoc Pennington <hp@redhat.com>
777 * bus/loop.h, bus/loop.c: make the mainloop an object so we can
780 * bus/*.[hc]: adapt to mainloop change
782 2003-04-03 Havoc Pennington <hp@redhat.com>
784 * bus/activation.c (load_directory): fix up memleaks
785 (bus_activation_entry_free): free the entry
787 * dbus/dbus-bus.c (dbus_bus_acquire_service): return an error if
788 we get one from the message bus; fix memleaks.
790 * dbus/dbus-message.c (dbus_set_error_from_message): new function
792 2003-04-03 Havoc Pennington <hp@pobox.com>
794 * bus/config-parser.c (bus_config_parser_unref): free
795 list of mechanisms, bug discovered by test suite enhancements
796 (putting system.conf and session.conf into suite)
798 * test/Makefile.am, test/test-service.c: add placeholder for a
799 test service that we'll activate as part of test suite. Doesn't
802 * dbus/dbus-sysdeps.c (_dbus_setenv): support unsetenv by
803 setting NULL value, and use system malloc not dbus_malloc()
804 when we have unavoidable memleakage.
806 * dbus/dbus-bus.c (dbus_bus_get): fix bug where bus type of 0
807 didn't work, and support DBUS_BUS_ACTIVATION.
809 * bus/activation.c (child_setup): pass our well-known bus type to
812 * bus/config-parser.c: support <type> to specify well-known type
814 * doc/dbus-specification.sgml: document the env variables to
815 locate well-known buses and find service activator
817 2003-04-02 Havoc Pennington <hp@redhat.com>
819 * test/Makefile.am (all-local): add a rule to copy tests to
820 builddir, so we can have generated tests. Use this to remove the
821 silly hack for testing system.conf and session.conf. Will use this
822 shortly to generate .service files pointing to test binaries.
824 2003-04-02 Havoc Pennington <hp@redhat.com>
826 * dbus/dbus-string.c (set_length): fix a bug - we allocated max of
827 current alloc and needed new length, not max of the doubled
828 allocation and needed new length. Also, when building tests,
829 don't do the double-allocation stuff, just realloc every time.
831 2003-04-02 Havoc Pennington <hp@redhat.com>
833 * dbus/dbus-sysdeps.c (_dbus_file_get_contents): include filenames
835 (_dbus_string_get_dirname): new
836 (_dbus_sysdeps_test): new
837 (_dbus_directory_open): include dirnames in error messages
839 * bus/config-parser.c: interpret <include> and <includedir> and
840 <servicedir> relative to config file location if the given
841 filename is not absolute.
843 * dbus/dbus-string.c (_dbus_string_find_byte_backward): new
845 2003-04-02 Havoc Pennington <hp@redhat.com>
847 * bus/connection.c (bus_transaction_send_error_reply): set sender
848 service for the error, and unref the reply on success
850 * bus/activation.c: convert to use BusTransaction so OOM can be
852 (bus_activation_service_created): set sender of the message
854 2003-04-01 Havoc Pennington <hp@redhat.com>
856 * bus/config-parser.c, bus/bus.c: implement <servicedir> and
857 <includedir> (at least mostly)
859 * dbus/dbus-sysdeps.c (_dbus_change_identity): set the group ID
860 first, then the user ID
862 2003-04-01 Havoc Pennington <hp@pobox.com>
864 * dbus/dbus-server.c (dbus_server_set_auth_mechanisms): new
867 * dbus/dbus-auth.c (_dbus_auth_set_mechanisms): new
869 * dbus/dbus-internals.c (_dbus_dup_string_array): new function
871 * dbus/dbus-sysdeps.c (_dbus_listen_unix_socket): chmod the
872 socket 0777, and unlink any existing socket.
874 * bus/bus.c (bus_context_new): change our UID/GID and fork if
875 the configuration file so specifies; set up auth mechanism
878 * bus/config-parser.c (bus_config_parser_content): add support
879 for <fork> option and fill in code for <auth>
881 * bus/system.conf.in: add <fork/> to default configuration,
882 and limit auth mechanisms to EXTERNAL
884 * doc/config-file.txt (Elements): add <fork>
886 * dbus/dbus-sysdeps.c (_dbus_become_daemon): new function
887 (_dbus_change_identity): new function
889 2003-03-31 Havoc Pennington <hp@redhat.com>
891 * dbus/dbus-sysdeps.c (_dbus_connect_unix_socket)
892 (_dbus_listen_unix_socket): fix off-by-one error in null
893 termination spotted by Nalin
895 2003-03-31 Havoc Pennington <hp@redhat.com>
897 * dbus/dbus-keyring.c (_dbus_keyring_new_homedir): allow setting
898 DBUS_TEST_HOMEDIR when tests are enabled, so we can test without
899 having a real home directory available.
901 2003-03-31 Havoc Pennington <hp@redhat.com>
903 * bus/Makefile.am (install-data-hook): create /var/run/dbus
905 * bus/messagebus.in: add init script for Red Hat /etc/init.d
907 * configure.in: add support for specifying a style of init script
910 2003-03-31 Havoc Pennington <hp@redhat.com>
912 Fix some annoying DBusString API and fix all affected code.
914 * dbus/dbus-string.c (_dbus_string_init): get rid of annoying
916 (_dbus_string_get_data): change to return string instead of using
918 (_dbus_string_get_const_data): ditto
919 (_dbus_string_get_data_len): ditto
920 (_dbus_string_get_const_data_len): ditto
922 2003-03-31 Havoc Pennington <hp@redhat.com>
924 * bus/main.c (main): fix up the command line arguments to be nicer
926 2003-03-31 Havoc Pennington <hp@redhat.com>
928 * dbus/Makefile.am (INCLUDES): use EXPANDED_LOCALSTATEDIR to
929 define DBUS_SYSTEM_BUS_PATH as we want to compile in the same
930 final location that lands in the config file
932 * bus/config-loader-expat.c (bus_config_load): fix type of
935 * doc/TODO: remove TODO item for dbus_bus_get()
937 * dbus/dbus-bus.c (bus_data_free): add missing lock/unlock
939 2003-03-31 Havoc Pennington <hp@pobox.com>
941 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_domain_socket)
942 (_dbus_transport_new_for_tcp_socket): these didn't need the "server"
943 argument since they are always client side
945 * dbus/dbus-server.c (dbus_server_get_address): new function
947 * bus/main.c (main): take the configuration file as an argument.
949 * test/data/valid-config-files/debug-allow-all.conf: new file to
950 use with dispatch.c tests for example
952 * bus/test-main.c (main): require test data dir
954 * bus/bus.c (bus_context_new): change this to take a
955 configuration file name as argument
957 * doc/config-file.txt (Elements): add <servicedir>
959 * bus/system.conf, bus/session.conf: new files
961 * dbus/dbus-bus.c (dbus_bus_get): look for system bus on
962 well-known socket if none set
964 * configure.in: create system.conf and session.conf
966 2003-03-30 Havoc Pennington <hp@pobox.com>
968 * bus/config-parser.c: hacking
970 * dbus/dbus-memory.c: don't use DBusList for the list of stuff
971 to shut down, since it could cause weirdness with the DBusList
974 * dbus/dbus-list.c (_dbus_list_test): add tests for the
975 link-oriented stack routines
976 (alloc_link): free the mempool if the first alloc from it fails
978 * dbus/dbus-mempool.c (struct DBusMemBlock): fix alignment issue
980 * dbus/dbus-string.c (UNICODE_VALID): sync new version of this
982 (_dbus_string_skip_white): new
984 * doc/config-file.txt (Elements): add <includedir>
986 2003-03-28 Havoc Pennington <hp@pobox.com>
988 * dbus/dbus-string.c (_dbus_string_copy_data_len)
989 (_dbus_string_copy_data): new functions
991 2003-03-28 Anders Carlsson <andersca@codefactory.se>
993 * dbus/dbus-bus.c: (bus_data_free), (dbus_bus_get):
997 * dbus/dbus-memory.c:
1000 2003-03-28 Havoc Pennington <hp@pobox.com>
1002 * bus/test.c (bus_test_flush_bus): remove the sleep from here,
1003 I think it may have just been superstition. Not sure.
1005 * dbus/dbus-string.c (_dbus_string_base64_decode): catch some OOM
1006 failures that were not being handled.
1008 * dbus/dbus-auth.c (process_auth): fix a memleak in OOM handling
1010 * dbus/dbus-memory.c: add ability to set number of mallocs in a
1011 row that will fail on out-of-memory.
1013 * dbus/dbus-internals.c (_dbus_test_oom_handling): convenience
1014 function for testing out-of-memory handling.
1016 * bus/config-loader-expat.c (memsuite): don't wrap the dbus
1017 allocation functions, they do map exactly to the expat ones.
1019 2003-03-27 Havoc Pennington <hp@redhat.com>
1021 * bus/config-loader-libxml.c (bus_config_load): add another error
1024 2003-03-26 Anders Carlsson <andersca@codefactory.se>
1027 Add note about automatic service activation.
1029 * doc/dbus-specification.sgml:
1030 Rename the specification and clarify a few things.
1032 2003-03-26 Anders Carlsson <andersca@codefactory.se>
1035 * dbus/dbus-address.c:
1037 * dbus/dbus-marshal.c:
1038 * dbus/dbus-server-debug-pipe.c:
1039 * dbus/dbus-transport-unix.c:
1040 Fix documentation warnings.
1042 2003-03-26 Havoc Pennington <hp@pobox.com>
1044 * bus/test-main.c, dbus/dbus-test.c (main): check memleaks
1045 after every test so it's quick and easy to see which leaked, and
1046 so we test multiple dbus_shutdown() calls
1048 * configure.in: change configure.in XML stuff to also support
1051 * config-loader-libxml.c: some hacking
1053 * config-loader-expat.c: some hacking
1055 * config-parser.c: some hacking, plus tests
1057 2003-03-25 Havoc Pennington <hp@redhat.com>
1059 * throughout - add more _DBUS_ASSERT_ERROR_IS_CLEAR
1061 * configure.in: add --with-xml option to specify XML library,
1062 right now only libxml is supported.
1064 * bus/config-loader-libxml.c, config-parser.c: sync some minor
1065 nonworking code between home and work, still just stubs
1067 2003-03-24 Havoc Pennington <hp@redhat.com>
1069 * dbus/dbus-sysdeps.c (_dbus_set_fd_nonblocking): move to this
1072 * dbus/dbus-errors.c (dbus_set_error, dbus_set_error_const): allow
1073 NULL argument for "message" if the error is a well-known one,
1074 fill in a generic message in this case.
1076 * dbus/dbus-errors.h (DBusResultCode): Kill DBusResultCode in
1079 * bus/test.c (bus_test_flush_bus): add
1081 * bus/policy.c (bus_policy_test): test code stub
1083 2003-03-24 Havoc Pennington <hp@pobox.com>
1085 * bus/connection.c (bus_connections_setup_connection): set up
1086 the "can this user connect" function, but it always returns
1087 TRUE until we have a config file parser so we can have a config
1088 file that allows connections.
1090 2003-03-23 Havoc Pennington <hp@pobox.com>
1092 * dbus/dbus-threads.c (dbus_mutex_new, dbus_condvar_new): with
1093 DBUS_BUILD_TESTS, actually alloc/free a block of memory for
1094 the mutex, so we can check for proper memory management
1097 * dbus/dbus-dataslot.c: remove the mutex from
1098 DBusDataSlotAllocator and lock it manually when using it,
1099 to simplify fitting it into the global slots framework.
1101 * dbus/dbus-threads.c (init_static_locks): rework how we're
1102 handling global locks so they are easily shut down.
1104 * bus/policy.c (bus_policy_append_rule): fix
1106 * bus/test-main.c (main): check for memleaks
1108 * dbus/dbus-test.c (dbus_internal_do_not_use_run_tests): make
1109 test suite check for memleaks
1111 * dbus/dbus-memory.c: add support in test mode for tracking
1112 number of outstanding blocks
1114 2003-03-23 Havoc Pennington <hp@pobox.com>
1116 * bus/policy.c, bus/bus.c, bus/connection.c: implement allow/deny
1119 * dbus/dbus-hash.h: add ULONG hash keys
1121 * dbus/dbus-sysdeps.c (_dbus_get_groups): new
1122 (_dbus_get_group_id): new function
1124 2003-03-20 Havoc Pennington <hp@redhat.com>
1126 * dbus/dbus-connection.c (dbus_connection_set_unix_user_function):
1128 (dbus_connection_get_unix_user): new function
1130 2003-03-20 Havoc Pennington <hp@pobox.com>
1132 * bus/connection.c (bus_connection_send_oom_error): assert that
1133 message has a sender
1134 (connection_execute_transaction): ditto
1135 (bus_connection_preallocate_oom_error): fix to set the sender, and
1136 set recipient to the destination service, not the bus driver
1138 * bus/policy.c: hacking
1140 * dbus/dbus-message.c (dbus_message_service_is): new function
1141 (dbus_message_sender_is): new
1143 2003-03-19 Havoc Pennington <hp@redhat.com>
1145 * bus/policy.c: start sketching code for policy restrictions on
1146 what connections can do.
1148 2003-03-18 Havoc Pennington <hp@redhat.com>
1150 * doc/TODO: some notes on high-level todo items. Little nitpick
1151 stuff is all in @todo, so no need to add it here.
1153 * doc/config-file.txt: some notes on how config file might look
1155 2003-03-18 Anders Carlsson <andersca@codefactory.se>
1161 2003-03-17 Havoc Pennington <hp@redhat.com>
1163 * dbus/dbus-internals.h: add gcc attributes so that
1164 our printf-style functions warn on bad arguments to
1167 * dbus/dbus-sysdeps.c (_dbus_connect_tcp_socket): fix printf
1170 * dbus/dbus-message.c (_dbus_message_loader_queue_messages): fix
1173 2003-03-17 Havoc Pennington <hp@redhat.com>
1175 * bus/test-main.c (main): make it print something as it runs
1176 so make check doesn't look stuck
1178 * doc/negotiation.txt, doc/dbus-sasl-profile.txt: remove
1179 from CVS, now obsolete
1181 2003-03-17 Anders Carlsson <andersca@codefactory.se>
1183 * bus/dispatch.c: (bus_dispatch):
1184 Refetch the service name since it may have been reallocated
1185 when dbus_message_set_sender was called.
1187 * dbus/dbus-sysdeps.c: (_dbus_accept):
1188 Add address and address length variables and use them to stop
1189 valgrind from complaining.
1191 2003-03-17 Havoc Pennington <hp@pobox.com>
1193 All tests pass, no memleaks, no valgrind complaints.
1195 * bus/test.c: refcount handler_slot
1197 * bus/connection.c (bus_connections_new): refcount
1198 connection_data_slot
1200 * dbus/dbus-auth-script.c (_dbus_auth_script_run): delete unused
1201 bytes so that auth scripts pass.
1203 * bus/dispatch.c: init message_handler_slot so it gets allocated
1206 * bus/dispatch.c (message_handler_slot_ref): fix memleak
1208 * dbus/dbus-server-debug-pipe.c (_dbus_server_debug_pipe_new):
1209 dealloc server_pipe_hash when no longer used for benefit of
1212 * dbus/dbus-auth.c (process_command): memleak fix
1214 * bus/dispatch.c (check_hello_message): memleak fix
1216 2003-03-16 Havoc Pennington <hp@pobox.com>
1218 * dbus/dbus-bus.c (ensure_bus_data): fix double-unref of the data slot
1220 2003-03-17 Anders Carlsson <andersca@codefactory.se>
1222 * bus/activation.c (bus_activation_activate_service): Append
1223 the pending activation entry to the list of pending activations.
1225 2003-03-16 Havoc Pennington <hp@pobox.com>
1227 * bus/dispatch.c (bus_dispatch_test): remove double-unrefs of
1230 * dbus/dbus-address.c (create_entry): fix OOM handling when
1231 failing to alloc entry->method
1233 2003-03-16 Havoc Pennington <hp@pobox.com>
1235 * dbus/dbus-watch.c (_dbus_watch_new): handle failure to malloc
1238 * dbus/dbus-server-debug-pipe.c (_dbus_transport_debug_pipe_new):
1239 add some missing dbus_set_result
1241 * bus/dispatch.c (bus_dispatch_add_connection): handle failure to
1242 alloc the DBusMessageHandler
1244 * dbus/dbus-transport.c (_dbus_transport_disconnect): don't ref
1245 the transport here, since we call this from the finalizer; it
1246 resulted in a double-finalize.
1248 * dbus/dbus-transport.c (_dbus_transport_disconnect): fix a bug
1249 where we tried to use transport->connection that was NULL,
1250 happened when transport was disconnected early on due to OOM
1252 * bus/*.c: adapt to handle OOM for watches/timeouts
1254 * dbus/dbus-transport-unix.c: port to handle OOM during
1257 * dbus/dbus-auth.c (_dbus_auth_get_unused_bytes): return a
1258 reference to unused bytes instead of a copy
1260 * dbus/dbus-server.c (dbus_server_handle_watch): return FALSE for
1263 * dbus/dbus-connection.c (dbus_connection_handle_watch): return
1266 * dbus/dbus-timeout.c (dbus_timeout_handle): return FALSE for out
1269 2003-03-16 Anders Carlsson <andersca@codefactory.se>
1271 * doc/dbus-specification.sgml:
1272 Document reply message for ActivateService.
1274 2003-03-16 Anders Carlsson <andersca@codefactory.se>
1276 * bus/activation.c: (bus_pending_activation_entry_free),
1277 (bus_pending_activation_free), (bus_activation_new),
1278 (bus_activation_unref), (bus_activation_service_created),
1279 (bus_activation_activate_service):
1281 * bus/bus.c: (bus_context_new):
1282 * bus/desktop-file.c: (new_section):
1283 * bus/driver.c: (bus_driver_send_service_deleted),
1284 (bus_driver_handle_activate_service):
1285 * bus/services.c: (bus_registry_new), (bus_registry_ensure):
1287 * dbus/dbus-connection.c:
1288 (dbus_connection_send_with_reply_and_block):
1289 * dbus/dbus-message.c: (dbus_message_append_args_valist):
1290 * dbus/dbus-protocol.h:
1291 Make activation work better. Now pending activations will be queued
1292 and the daemon won't try to activate services that are already registered.
1294 2003-03-16 Havoc Pennington <hp@pobox.com>
1296 * dbus/dbus-bus.c (ensure_bus_data): handle failure to set
1299 * dbus/dbus-memory.c (_dbus_initialize_malloc_debug): support
1300 DBUS_MALLOC_BACKTRACES to print trace when failing an alloc
1302 2003-03-16 Havoc Pennington <hp@pobox.com>
1304 * dbus/dbus-string.c (_dbus_string_validate_utf8): oops, unbreak
1305 this. always run the test suite before commit...
1307 * bus/*: adapt to DBusConnection API changes
1309 * glib/dbus-gmain.c: adapt to DBusConnection API changes,
1310 requires renaming stuff to avoid dbus_connection_dispatch name
1313 * dbus/dbus-transport.c (_dbus_transport_queue_messages): new
1316 * dbus/dbus-message.c (_dbus_message_loader_queue_messages):
1317 separate from _dbus_message_loader_return_buffer()
1319 * dbus/dbus-connection.c (dbus_connection_get_n_messages): remove
1320 this, because it's now always broken to use; the number of
1321 messages in queue vs. the number still buffered by the message
1322 loader is undefined/meaningless. Should use
1323 dbus_connection_get_dispatch_state().
1324 (dbus_connection_dispatch): rename from
1325 dbus_connection_dispatch_message
1327 2003-03-16 Havoc Pennington <hp@pobox.com>
1329 * dbus/dbus-string.c (_dbus_string_validate_utf8): copy in a real
1332 2003-03-16 Anders Carlsson <andersca@codefactory.se>
1334 * dbus/dbus-connection.c:
1335 (dbus_connection_send_with_reply_and_block):
1336 Decrease connection->n_incoming when removing an entry
1338 * dbus/dbus-dict.c: (dbus_dict_entry_free),
1339 (dbus_dict_set_boolean_array), (dbus_dict_set_int32_array),
1340 (dbus_dict_set_uint32_array), (dbus_dict_set_double_array),
1341 (dbus_dict_set_byte_array), (dbus_dict_set_string_array),
1342 (dbus_dict_get_boolean_array), (dbus_dict_get_double_array),
1343 (dbus_dict_get_byte_array):
1344 Handle NULL arrays and strings. Also add support for byte arrays.
1346 * dbus/dbus-marshal.c: (_dbus_marshal_byte_array),
1347 (_dbus_marshal_dict), (_dbus_demarshal_byte_array),
1348 (_dbus_demarshal_int32_array), (_dbus_demarshal_uint32_array),
1349 (_dbus_demarshal_double_array), (_dbus_demarshal_string_array),
1350 (_dbus_demarshal_dict), (demarshal_and_validate_len),
1351 (_dbus_marshal_validate_arg), (_dbus_marshal_test):
1352 * dbus/dbus-marshal.h:
1353 Add support for marshalling and demarshalling empty arrays and strings.
1355 * dbus/dbus-message.c: (dbus_message_append_args_valist),
1356 (dbus_message_append_string_array),
1357 (dbus_message_iter_get_boolean),
1358 (dbus_message_iter_get_boolean_array),
1359 (dbus_message_iter_get_int32_array),
1360 (dbus_message_iter_get_uint32_array),
1361 (dbus_message_iter_get_double_array),
1362 (dbus_message_iter_get_byte_array),
1363 (dbus_message_iter_get_string_array), (dbus_message_iter_get_dict),
1364 (check_message_handling):
1365 Add support for getting empty arrays and dicts.
1367 * dbus/dbus-string.c: (_dbus_string_validate_utf8):
1368 Don't do any validation at all for now, that's better than just checking
1371 * test/data/valid-messages/emptiness.message:
1372 New test message with lots of empty arrays.
1374 2003-03-16 Havoc Pennington <hp@pobox.com>
1376 * dbus/dbus-connection.c
1377 (_dbus_connection_queue_received_message_link): new function that
1378 can't fail due to OOM
1380 * dbus/dbus-message.c (_dbus_message_loader_pop_message_link):
1381 new function pops a message together with a list link
1384 * dbus/dbus-transport-unix.c (queue_messages): use new link-based
1385 message queuing functions to avoid needing to alloc memory
1387 2003-03-16 Havoc Pennington <hp@pobox.com>
1389 Oops - test code was only testing failure of around 30 of the
1390 mallocs in the test path, but it turns out there are 500+
1391 mallocs. I believe this was due to misguided linking setup such
1392 that there was one copy of dbus_malloc etc. in the daemon and one
1393 in the shared lib, and only daemon mallocs were tested. In any
1394 case, the test case now tests all 500+ mallocs, and doesn't pass
1395 yet, though there are lots of fixes in this patch.
1397 * dbus/dbus-connection.c (dbus_connection_dispatch_message): fix
1398 this so that it doesn't need to allocate memory, since it
1399 has no way of indicating failure due to OOM (and would be
1400 annoying if it did).
1402 * dbus/dbus-list.c (_dbus_list_pop_first_link): new function
1404 * bus/Makefile.am: rearrange to create two self-contained
1405 libraries, to avoid having libraries with overlapping symbols.
1406 that was resulting in weirdness, e.g. I'm pretty sure there
1407 were two copies of global static variables.
1409 * dbus/dbus-internals.c: move the malloc debug stuff to
1412 * dbus/dbus-list.c (free_link): free list mempool if it becomes
1415 * dbus/dbus-memory.c (_dbus_disable_mem_pools): new function
1417 * dbus/dbus-address.c (dbus_parse_address): free list nodes
1420 * bus/dispatch.c (bus_dispatch_add_connection): free
1421 message_handler_slot when no longer using it, so
1422 memory leak checkers are happy for the test suite.
1424 * dbus/dbus-server-debug-pipe.c (debug_finalize): free server name
1426 * bus/bus.c (new_connection_callback): disconnect in here if
1427 bus_connections_setup_connection fails.
1429 * bus/connection.c (bus_connections_unref): fix to free the
1431 (bus_connections_setup_connection): if this fails, don't
1432 disconnect the connection, just be sure there are no side
1435 * dbus/dbus-string.c (undo_alignment): unbreak this
1437 * dbus/dbus-auth.c (_dbus_auth_unref): free some stuff we were
1439 (_dbus_auth_new): fix the order in which we free strings
1442 * bus/connection.c (bus_connection_disconnected): fix to
1443 not send ServiceDeleted multiple times in case of memory
1446 * dbus/dbus-bus.c (dbus_bus_get_base_service): new function to
1447 get the base service name
1448 (dbus_bus_register_client): don't return base service name,
1449 instead store it on the DBusConnection and have an accessor
1451 (dbus_bus_register_client): rename dbus_bus_register()
1453 * bus/dispatch.c (check_hello_message): verify that other
1454 connections on the bus also got the correct results, not
1455 just the one sending hello
1457 2003-03-15 Havoc Pennington <hp@pobox.com>
1459 Make it pass the Hello handling test including all OOM codepaths.
1460 Now to do other messages...
1462 * bus/services.c (bus_service_remove_owner): fix crash when
1463 removing owner from an empty list of owners
1464 (bus_registry_ensure): don't leave service in the list of
1465 a connection's owned services if we fail to put the service
1468 * bus/connection.c (bus_connection_preallocate_oom_error): set
1469 error flag on the OOM error.
1471 * dbus/dbus-connection.c (_dbus_connection_new_for_transport):
1472 handle _dbus_transport_set_connection failure
1474 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_fd): modify
1475 to create watches up front and simply enable/disable them as
1477 (unix_connection_set): this can now fail on OOM
1479 * dbus/dbus-timeout.c, dbus/dbus-watch.c: add concept
1480 of enabling/disabling a watch or timeout.
1482 * bus/loop.c (bus_loop_iterate): don't touch disabled
1485 * glib/dbus-gmain.c: adapt to enable/disable watches and timeouts
1487 2003-03-15 Havoc Pennington <hp@pobox.com>
1489 * bus/dispatch.c (bus_dispatch_test): OK, now finally actually
1490 write useful test code, after all that futzing around ;-)
1492 Test does not yet pass because we can't handle OOM in
1493 _dbus_transport_messages_pending (basically,
1494 dbus_connection_preallocate_send() does not prealloc the write
1495 watch). To fix this, I think we need to add new stuff to
1496 set_watch_functions, namely a SetEnabled function so we can alloc
1497 the watch earlier, then enable it later.
1499 * dbus/Makefile.am (libdbus_convenience_la_SOURCES): move
1500 dbus-memory.c to the convenience lib
1502 * bus/test.c: rename some static functions to keep them clearly
1503 distinct from stuff in connection.c. Handle client disconnection.
1505 2003-03-14 Havoc Pennington <hp@pobox.com>
1507 * bus/dispatch.c (bus_dispatch_test): do test using debug-pipe
1508 transport, tests more of the real codepath. Set up clients
1509 with bus_setup_debug_client.
1511 * bus/test.c (bus_setup_debug_client): function to set up debug
1512 "clients" on the main loop
1514 * dbus/dbus-transport.c (_dbus_transport_open): add debug-pipe
1517 * dbus/dbus-server.c (dbus_server_listen): add debug-pipe
1520 * dbus/dbus-server-debug.c: support a debug server based on pipes
1522 * dbus/dbus-sysdeps.c (_dbus_full_duplex_pipe): new function
1523 (_dbus_close): new function
1525 * configure.in: check for socketpair
1527 2003-03-14 Havoc Pennington <hp@redhat.com>
1529 * dbus/dbus-memory.c: add a "detect buffer overwrites on free"
1532 * dbus/dbus-transport-debug.c: rework this a good bit to be
1533 less complicated. hopefully still works.
1535 * dbus/dbus-server-debug.c (handle_new_client): remove timeout
1538 * glib/dbus-gmain.c (timeout_handler): don't remove timeout
1541 * dbus/dbus-message.c (dbus_message_copy): rename from
1542 dbus_message_new_from_message, fix it up to copy
1543 all the message fields, add test case
1545 * bus/dispatch.c (bus_dispatch_test): add some more test code,
1546 not quite passing yet
1548 2003-03-14 Havoc Pennington <hp@pobox.com>
1550 * bus/loop.c (bus_loop_iterate): add this so we can "run loop
1551 until no work remains" in test code. (the large diff here
1552 is just code movement, no actual changes)
1554 * dbus/dbus-server-debug.c (DEFAULT_INTERVAL): change interval to
1555 1, no point waiting around for test code.
1556 (_dbus_server_debug_accept_transport): unref the timeout
1557 after adding it (right?)
1559 * dbus/dbus-transport-debug.c (DEFAULT_INTERVAL): ditto
1561 2003-03-13 Havoc Pennington <hp@redhat.com>
1563 * dbus/dbus-timeout.c (_dbus_timeout_list_set_functions): handle
1566 * dbus/dbus-watch.c (_dbus_watch_list_set_functions): handle out
1569 * dbus/dbus-connection.h: Make AddWatchFunction and
1570 AddTimeoutFunction return a bool so they can fail on out-of-memory
1572 * bus/bus.c (bus_context_new): set up timeout handlers
1574 * bus/connection.c (bus_connections_setup_connection): set up
1577 * glib/dbus-gmain.c: adapt to the fact that set_functions stuff
1580 * bus/bus.c (bus_context_new): adapt to changes
1582 * bus/connection.c: adapt to changes
1584 * test/watch.c: adapt to DBusWatch changes
1586 * bus/dispatch.c (bus_dispatch_test): started adding this but
1589 2003-03-14 Anders Carlsson <andersca@codefactory.se>
1591 * bus/dispatch.c (send_service_nonexistent_error): Fix typo.
1593 2003-03-13 Havoc Pennington <hp@pobox.com>
1595 * bus/test.c, bus/test.h, bus/Makefile.am, bus/test-main.c:
1596 set up a test framework as for the library
1598 2003-03-12 Havoc Pennington <hp@pobox.com>
1600 Throughout: purge global variables, introduce BusActivation,
1601 BusConnections, BusRegistry, etc. objects instead.
1603 * bus/bus.h, bus/bus.c: introduce BusContext as a global
1606 * test/Makefile.am (TEST_BINARIES): disable bus-test for now,
1607 going to redo this a bit differently I think
1609 2003-03-12 Havoc Pennington <hp@redhat.com>
1611 Mega-patch that gets the message bus daemon initially handling
1612 out-of-memory. Work still needed. Also lots of random
1613 moving stuff to DBusError instead of ResultCode.
1615 * dbus/dbus-list.c (_dbus_list_length_is_one): new function
1617 * dbus/dbus-connection.c
1618 (dbus_connection_send_with_reply_and_block): use DBusError
1620 * dbus/dbus-bus.c: adapt to API changes, make it use DBusError not
1623 * dbus/dbus-connection.c (dbus_connection_send): drop the result
1624 code here, as the only failure possible is OOM.
1626 * bus/connection.c (bus_connection_disconnect):
1627 rename bus_connection_disconnected as it's a notification only
1629 * bus/driver.c (bus_driver_handle_acquire_service): don't free
1630 "name" on get_args failure, should be done by get_args;
1631 don't disconnect client for bad args, just return an error.
1632 (bus_driver_handle_service_exists): ditto
1634 * bus/services.c (bus_services_list): NULL-terminate returned array
1636 * bus/driver.c (bus_driver_send_service_lost)
1637 (bus_driver_send_service_acquired): send messages from driver to a
1638 specific client to the client's unique name, not to the broadcast
1641 * dbus/dbus-message.c (decode_header_data): reject messages that
1642 contain no name field
1643 (_dbus_message_get_client_serial): rename to
1644 dbus_message_get_serial and make public
1645 (_dbus_message_set_serial): rename from set_client_serial
1646 (_dbus_message_set_reply_serial): make public
1647 (_dbus_message_get_reply_serial): make public
1649 * bus/connection.c (bus_connection_foreach): allow stopping
1650 iteration by returning FALSE from foreach function.
1652 * dbus/dbus-connection.c (dbus_connection_send_preallocated)
1653 (dbus_connection_free_preallocated_send)
1654 (dbus_connection_preallocate_send): new API for sending a message
1655 without possibility of malloc failure.
1656 (dbus_connection_send_message): rename to just
1657 dbus_connection_send (and same for whole function family)
1659 * dbus/dbus-errors.c (dbus_error_free): make this reinit the error
1661 * dbus/dbus-sysdeps.c (_dbus_exit): new function
1663 * bus/activation.c: handle/return errors
1665 * dbus/dbus-errors.h: add more DBUS_ERROR #define
1667 * dbus/dbus-sysdeps.c (_dbus_directory_open) (_dbus_file_get_contents)
1668 (_dbus_directory_get_next_file): use DBusError instead of DBusResultCode
1669 (_dbus_result_from_errno): move to this file
1671 2003-03-10 Anders Carlsson <andersca@codefactory.se>
1673 * dbus/dbus-marshal.c:
1674 (_dbus_marshal_set_string):
1675 Take a length argument so we can marshal the correct string
1678 (_dbus_marshal_dict), (_dbus_demarshal_dict),
1679 (_dbus_marshal_get_arg_end_pos), (_dbus_marshal_validate_arg),
1680 (_dbus_marshal_test):
1681 * dbus/dbus-marshal.h:
1682 Add support for marshalling and demarshalling dicts.
1684 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
1685 Add support for TYPE DICT.
1687 * dbus/dbus-message.c: (set_string_field):
1688 Adjust header padding.
1690 (dbus_message_append_args_valist), (dbus_message_append_dict),
1691 (dbus_message_get_args_valist), (dbus_message_iter_get_arg_type),
1692 (dbus_message_iter_get_dict), (_dbus_message_loader_return_buffer),
1693 (check_message_handling), (check_have_valid_message):
1694 * dbus/dbus-message.h:
1695 Add functions for setting and getting dicts.
1697 * dbus/dbus-protocol.h:
1703 * doc/dbus-specification.sgml:
1704 Add information about how dicts are marshalled.
1706 * test/data/invalid-messages/dict-with-nil-value.message:
1707 * test/data/invalid-messages/too-short-dict.message:
1708 * test/data/valid-messages/dict-simple.message:
1709 * test/data/valid-messages/dict.message:
1710 Add sample messages containing dicts.
1712 2003-03-08 Anders Carlsson <andersca@codefactory.se>
1714 * dbus/dbus-dict.h: Add DBUS_END_DECLS.
1716 2003-03-07 Anders Carlsson <andersca@codefactory.se>
1719 * dbus/dbus-dict.c: (dbus_dict_entry_free), (dbus_dict_new),
1720 (dbus_dict_get_keys), (insert_entry), (dbus_dict_set_boolean),
1721 (dbus_dict_set_int32), (dbus_dict_set_uint32),
1722 (dbus_dict_set_double), (dbus_dict_set_string),
1723 (dbus_dict_set_boolean_array), (dbus_dict_set_int32_array),
1724 (dbus_dict_set_uint32_array), (dbus_dict_set_double_array),
1725 (dbus_dict_set_string_array), (_dbus_dict_test):
1727 Fix according to comments from Havoc.
1729 2003-03-06 Michael Meeks <michael@server.home>
1731 * configure.in: if we don't have kde-config, disable have_qt.
1733 2003-03-07 Anders Carlsson <andersca@codefactory.se>
1738 * dbus/dbus-dict.c: (dbus_dict_entry_free), (dbus_dict_new),
1739 (dbus_dict_ref), (dbus_dict_unref), (dbus_dict_contains),
1740 (dbus_dict_remove), (dbus_dict_get_value_type),
1741 (dbus_dict_get_keys), (dbus_dict_put_boolean),
1742 (dbus_dict_put_int32), (dbus_dict_put_uint32),
1743 (dbus_dict_put_double), (dbus_dict_put_string),
1744 (dbus_dict_put_boolean_array), (dbus_dict_put_int32_array),
1745 (dbus_dict_put_uint32_array), (dbus_dict_put_double_array),
1746 (dbus_dict_put_string_array), (dbus_dict_get_boolean),
1747 (dbus_dict_get_int32), (dbus_dict_get_uint32),
1748 (dbus_dict_get_double), (dbus_dict_get_string),
1749 (dbus_dict_get_boolean_array), (dbus_dict_get_int32_array),
1750 (dbus_dict_get_uint32_array), (dbus_dict_get_double_array),
1751 (dbus_dict_get_string_array), (_dbus_dict_test):
1753 Add DBusDict implementation
1755 * dbus/dbus-test.c: (dbus_internal_do_not_use_run_tests):
1759 2003-03-04 Havoc Pennington <hp@pobox.com>
1761 * test/data/auth/*: adapt to changes
1763 * dbus/dbus-auth-script.c (_dbus_auth_script_run): add
1764 USERID_BASE64 and change USERNAME_BASE64 to put in username not
1767 * dbus/dbus-keyring.c (_dbus_keyring_validate_context): prevent
1768 more stuff from being in a context name, to make the protocol
1769 simpler to deal with
1771 * dbus/dbus-errors.c (dbus_error_has_name): new function
1772 (dbus_error_is_set): new function
1774 * dbus/dbus-auth.c: replace DBUS_STUPID_TEST_MECH auth
1775 with DBUS_COOKIE_SHA1, implement DBUS_COOKIE_SHA1
1777 * dbus/dbus-connection.c (dbus_connection_flush): also read
1778 messages during a flush operation
1780 * dbus/Makefile.am: remove dbus-md5 since it isn't currently used.
1782 2003-03-05 Anders Carlsson <andersca@codefactory.se>
1784 * configure.in: Check for gethostbyname on Solaris.
1786 * dbus/dbus-transport.c: (_dbus_transport_open):
1787 Remove duplicate "tcp" entry.
1789 * doc/dbus-specification.sgml:
1790 Clarify some things.
1792 2003-03-05 Anders Carlsson <andersca@codefactory.se>
1794 * dbus/dbus-auth.c: (send_rejected), (process_test_subdir):
1795 * dbus/dbus-keyring.c: (_dbus_keyring_new_homedir),
1796 (_dbus_keyring_test):
1797 * dbus/dbus-md5.c: (_dbus_md5_compute):
1798 * dbus/dbus-sha.c: (_dbus_sha_compute):
1801 2003-03-05 Anders Carlsson <andersca@codefactory.se>
1803 * README: Add some things.
1805 2003-03-04 Anders Carlsson <andersca@codefactory.se>
1807 * dbus/dbus-message.c (dbus_message_append_args_valist): Add a break;
1808 after case DBUS_TYPE_BOOELAN.
1810 2003-03-02 Havoc Pennington <hp@pobox.com>
1812 * test/break-loader.c (randomly_set_extreme_ints): add test that
1813 sets really huge and small integers
1815 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): add check
1816 that length of boolean array fits in the string, and that
1817 string has room for boolean value in single-bool case.
1819 * dbus/dbus-message-builder.c (_dbus_message_data_load): add
1820 optional value to "ALIGN" command which is what to fill the
1823 * test/data/valid-messages/no-padding.message: add regression
1824 test for the message padding problem
1826 2003-03-02 Havoc Pennington <hp@pobox.com>
1828 * dbus/dbus-message.c (decode_header_data): fix to always init
1829 message_padding, from Benjamin Dauvergne
1831 2003-03-02 Havoc Pennington <hp@pobox.com>
1837 2003-03-01 Joe Shaw <joe@assbarn.com>
1839 * configure.in: Check for "struct cmsgcred" and try to access its
1840 members for BSD-like unices.
1842 * dbus/dbus-sysdeps.c (read_credentials_byte): Fold this back into
1843 _dbus_read_credentials_unix_socket().
1844 (_dbus_read_credentials_unix_socket): Use recvmsg() instead of
1845 read() for reading the credential byte off the unix socket. Use
1846 struct cmsgcred on systems that support it.
1848 2003-02-27 Alexander Larsson <alexl@redhat.com>
1852 Make gthreads-2.0 dependency optional. Don't build thread test if
1855 2003-02-27 Havoc Pennington <hp@pobox.com>
1857 * dbus/dbus-connection.c
1858 (dbus_connection_send_message_with_reply_and_block): fix doh!
1859 doh! doh! bug that resulted in never removing a reply from the
1860 queue, no wonder we called get_reply_serial so much ;-)
1862 * dbus/dbus-message.c (struct DBusMessage): cache reply serial
1863 and client serial instead of demarshaling them every time
1865 2003-02-27 Havoc Pennington <hp@pobox.com>
1867 * dbus/dbus-marshal.c (_dbus_demarshal_int32): rewrite to be much
1868 more inlined, using dbus-string-private.h, speeds things up
1871 * dbus/dbus-string.c (_dbus_string_free): apply align offset
1872 when freeing the string
1873 (_dbus_string_steal_data): fix for align offset
1874 (undo_alignment): new function
1876 2003-02-26 Havoc Pennington <hp@redhat.com>
1878 All kinds of audit fixes from Owen, plus initial attempt to
1879 handle unaligned memory returned from malloc.
1881 * dbus/dbus-string.c (_dbus_string_init): clamp max length to
1882 leave room for align_offset and nul byte
1883 (fixup_alignment): function to track an align_offset and
1884 ensure real->str is aligned
1885 (DBUS_GENERIC_STRING_PREAMBLE): len must be less than allocated,
1886 to allow a nul byte plus align offset
1887 (_dbus_string_lock): fix overflow issue
1888 (_dbus_string_init_const_len): add assertions on sanity of len,
1889 assign allocated to be ALLOCATION_PADDING larger than len
1890 (set_length): fixup the overflow handling
1891 (_dbus_string_get_data_len): fix overflow in assertion
1892 (open_gap): detect overflow in size of gap to be opened
1893 (_dbus_string_lengthen): add overflow check
1894 (_dbus_string_align_length): fix overflow with _DBUS_ALIGN_VALUE
1895 (_dbus_string_append): add overflow check
1896 (_dbus_string_append_unichar): overflow
1897 (_dbus_string_delete): fix overflow in assertion
1898 (_dbus_string_copy_len): overflow in assertion
1899 (_dbus_string_replace_len): overflows in assertions
1900 (_dbus_string_find): change to implement in terms of
1901 _dbus_string_find_to
1902 (_dbus_string_find_to): assorted fixage
1903 (_dbus_string_equal_c_str): assert c_str != NULL,
1904 fix logic so the function works
1905 (_dbus_string_ends_with_c_str): fix overflow thingy
1906 (_dbus_string_base64_encode): overflow fix
1907 (_dbus_string_validate_ascii): overflow
1908 (_dbus_string_validate_nul): overflow
1910 2003-02-26 Havoc Pennington <hp@redhat.com>
1912 * dbus/dbus-marshal.c (_dbus_marshal_test): fix to work with DISABLE_ASSERTS
1914 2003-02-26 Alexander Larsson <alexl@redhat.com>
1917 Set DBUS_GLIB_THREADS_LIBS for apps using gthread-2.0
1919 * dbus/dbus-connection.c:
1920 * dbus/dbus-connection.h:
1921 Fix _dbus_connection_acquire_io_path and _dbus_connection_acquire_dispatch.
1922 Add dbus_connection_set_wakeup_main_function and use it when queueing
1923 incoming and outgoing messages.
1926 * dbus/dbus-dataslot.c:
1927 Threadsafe usage of DBusDataSlotAllocator
1929 * dbus/dbus-message.c: (dbus_message_get_args_iter):
1932 * dbus/dbus-server-unix.c:
1935 * glib/dbus-gmain.c:
1936 Implement the new wakeup functions for glib.
1939 * glib/test-thread-client.c:
1940 * glib/test-thread-server.c:
1941 * glib/test-thread.h:
1942 Initial cut at some thread test code. Not really done yet.
1944 2003-02-26 Havoc Pennington <hp@pobox.com>
1946 * dbus/dbus-connection.c
1947 (dbus_connection_send_message_with_reply_and_block): fix crash
1948 where we ref'd the outgoing message instead of the returned reply
1950 * dbus/dbus-transport-unix.c (do_authentication): check read watch
1951 at the end of this function, so if we didn't need to read for
1952 authentication, we reinstall it for receiving messages
1954 * dbus/dbus-message.c (dbus_message_new_reply): allow replies to
1955 a NULL sender for peer-to-peer case
1957 * dbus/dbus-transport-unix.c (check_read_watch): handle
1958 !authenticated case correctly
1960 * glib/dbus-gmain.c: add support for DBusServer
1962 * dbus/dbus-server.c: add data slot support
1964 * glib/dbus-gmain.c (dbus_connection_setup_with_g_main): check
1965 return values and handle errors
1967 * dbus/dbus-dataslot.c: factor out the data slot stuff from
1970 * Doxyfile.in (INPUT): add glib subdir
1972 * glib/dbus-gmain.c (dbus_connection_setup_with_g_main): rename
1973 setup_with_g_main instead of hookup_with_g_main; write docs
1975 2003-02-24 Anders Carlsson <andersca@codefactory.se>
1977 * dbus/dbus-marshal.c: (_dbus_marshal_validate_arg):
1978 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
1979 * dbus/dbus-message.c: (dbus_message_append_boolean),
1980 (dbus_message_append_boolean_array),
1981 (dbus_message_get_args_valist), (_dbus_message_test):
1982 * dbus/dbus-message.h:
1983 * doc/dbus-specification.sgml:
1984 Various fixes as pointed out by Havoc.
1986 * test/data/invalid-messages/bad-boolean-array.message:
1987 * test/data/invalid-messages/bad-boolean.message:
1988 Add invalid boolean value test cases.
1990 2003-02-24 Anders Carlsson <andersca@codefactory.se>
1992 * dbus/dbus-internals.c: (_dbus_type_to_string):
1993 * dbus/dbus-marshal.c: (_dbus_marshal_get_arg_end_pos),
1994 (_dbus_marshal_validate_arg):
1995 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
1996 * dbus/dbus-message.c: (dbus_message_append_args_valist),
1997 (dbus_message_append_boolean), (dbus_message_append_boolean_array),
1998 (dbus_message_get_args_valist), (dbus_message_iter_get_boolean),
1999 (dbus_message_iter_get_int32), (dbus_message_iter_get_uint32),
2000 (dbus_message_iter_get_double),
2001 (dbus_message_iter_get_boolean_array), (message_iter_test):
2002 * dbus/dbus-message.h:
2003 * dbus/dbus-protocol.h:
2004 * doc/dbus-specification.sgml:
2005 * test/data/valid-messages/lots-of-arguments.message:
2006 Add support for boolean and boolean array types.
2008 2003-02-23 Havoc Pennington <hp@pobox.com>
2010 * dbus/dbus-keyring.c: finish most of this implementation and
2013 * dbus/dbus-errors.c (dbus_set_error_const, dbus_set_error): make
2014 these barf if the error isn't cleared to NULL
2016 * dbus/dbus-sysdeps.c (_dbus_delete_file): set error on failure
2017 (_dbus_create_directory): new function
2019 * dbus/dbus-errors.c (dbus_set_error): fix warning
2021 * dbus/dbus-string.c (_dbus_string_hex_encode): new function
2022 (_dbus_string_hex_decode): new function
2023 (test_hex_roundtrip): test code
2025 * dbus/dbus-sha.c (_dbus_sha_compute): use dbus_string_hex_encode
2027 * dbus/dbus-md5.c (_dbus_md5_compute): use dbus_string_hex_encode
2029 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): make this use
2030 the save-to-temp/rename trick to atomically write the new file
2031 (_dbus_string_parse_uint): new function
2033 2003-02-22 Havoc Pennington <hp@pobox.com>
2035 * test/Makefile.am (dist-hook): fix dist for test/data/sha-1
2037 2003-02-22 Havoc Pennington <hp@pobox.com>
2039 * dbus/dbus-message.c (dbus_message_iter_get_string_array):
2040 (dbus_message_iter_get_byte_array): Fix up doxygen warnings
2042 * dbus/dbus-sha.c: add implementation of SHA-1 algorithm
2044 * dbus/test/data/sha-1: add US government test suite for SHA-1
2046 2003-02-21 Anders Carlsson <andersca@codefactory.se>
2048 * dbus/dbus-marshal.c: (_dbus_demarshal_string_array):
2049 Make string arrays NULL-terminated.
2051 * dbus/dbus-memory.c: (dbus_free_string_array):
2052 * dbus/dbus-memory.h:
2053 New function for freeing NULL-terminated string arrays.
2055 * dbus/dbus-message-builder.c: (append_quoted_string),
2056 (_dbus_message_data_load):
2057 Add support for array types.
2059 * dbus/dbus-message.c: (check_message_handling):
2060 Add more types as test cases.
2062 * dbus/dbus-sysdeps.c: (_dbus_string_parse_int),
2063 (_dbus_string_parse_double):
2064 Add the start offset to the end offset.
2066 * test/data/valid-messages/lots-of-arguments.message:
2067 New test message with lots of arguments.
2069 2003-02-21 Anders Carlsson <andersca@codefactory.se>
2071 * dbus/dbus-message.c: (dbus_message_append_nil),
2072 (dbus_message_append_int32), (dbus_message_append_uint32),
2073 (dbus_message_append_double), (dbus_message_append_string),
2074 (dbus_message_append_int32_array),
2075 (dbus_message_append_uint32_array),
2076 (dbus_message_append_double_array),
2077 (dbus_message_append_byte_array),
2078 (dbus_message_append_string_array):
2079 Fix all out-of-memory handling in these functions.
2081 2003-02-21 Anders Carlsson <andersca@codefactory.se>
2083 * dbus/dbus-message.c: (dbus_message_append_nil):
2086 2003-02-21 Anders Carlsson <andersca@codefactory.se>
2088 * dbus/dbus-message.c: (dbus_message_append_args_valist),
2089 (dbus_message_append_nil), (dbus_message_append_int32_array),
2090 (dbus_message_append_uint32_array),
2091 (dbus_message_append_double_array),
2092 (dbus_message_append_byte_array),
2093 (dbus_message_append_string_array), (dbus_message_get_args_valist),
2094 (dbus_message_iter_get_int32_array),
2095 (dbus_message_iter_get_uint32_array),
2096 (dbus_message_iter_get_double_array),
2097 (dbus_message_iter_get_byte_array),
2098 (dbus_message_iter_get_string_array):
2100 * dbus/dbus-message.h:
2101 Add functions for appending and getting arrays.
2103 2003-02-21 Anders Carlsson <andersca@codefactory.se>
2105 * dbus/dbus-mempool.c (_dbus_mem_pool_new): Make the
2106 element size at least 8 bytes, fixes mempool tests on
2109 2003-02-20 Alexander Larsson <alexl@redhat.com>
2111 * dbus/dbus-transport-unix.c (unix_do_iteration):
2112 Unlock the connection mutex during a blocking select call.
2113 Add todo about how we need a way to wake up the select.
2115 * dbus/dbus-connection-internal.h:
2116 * dbus/dbus-connection.c:
2117 Add _dbus_connection_lock and _dbus_connection_unlock.
2119 2003-02-19 Havoc Pennington <hp@pobox.com>
2121 * Doxyfile.in (PREDEFINED): put DOXYGEN_SHOULD_SKIP_THIS in
2122 Doxyfile.in, not Doxyfile
2124 * dbus/dbus-keyring.c: do some hacking on this
2126 * dbus/dbus-sysdeps.c (_dbus_delete_file): new
2128 * dbus/dbus-errors.c (dbus_set_error_const): do not call
2130 (dbus_set_error): remove dbus_error_init, check for message ==
2131 NULL *before* we sprintf into it, and add @todo about including
2132 system headers in this file
2134 * dbus/dbus-sysdeps.c (_dbus_create_file_exclusively): new
2136 * dbus/dbus-errors.h (DBUS_ERROR_FAILED): add
2138 * dbus/dbus-sysdeps.c (get_user_info): break this function out to
2139 get various bits of user information based on either username
2141 (_dbus_homedir_from_username): new function
2143 2003-02-19 Anders Carlsson <andersca@codefactory.se>
2146 Add check for nonposix getpwnam_r
2148 * dbus/dbus-mempool.c: (_dbus_mem_pool_new):
2149 Align the pool element size to a sizeof (void *) boundary.
2151 * dbus/dbus-sysdeps.c: (_dbus_setenv), (_dbus_connect_unix_socket),
2152 (_dbus_listen_unix_socket), (_dbus_credentials_from_username):
2153 General Solaris fixes.
2155 * test/data/valid-messages/simplest-manual.message:
2156 Explicitly state that we want little-endian packing.
2158 2003-02-19 Mikael Hallendal <micke@codefactory.se>
2160 * dbus/dbus-server.c (dbus_server_listen): Support tcp: addresses.
2162 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_tcp_socket):
2163 Added to create a transport connecting using a tcp/ip socket.
2165 * dbus/dbus-sysdeps.c (_dbus_connect_tcp_socket): Added to connect
2166 to a tcp socket at given host and port.
2167 (_dbus_listen_tcp_socket): added to listen on tcp socket for given
2170 * dbus/dbus-server.c (dbus_server_listen): Support tcp: addresses.
2172 * dbus/dbus-server-unix.c (_dbus_server_new_for_tcp_socket):
2173 Added to create a server listening on a TCP/IP socket.
2175 2003-02-19 Havoc Pennington <hp@pobox.com>
2177 Throughout: mop up all the Doxygen warnings and undocumented
2180 * dbus/dbus-sysdeps.c (do_exec): do not use execvp, we don't want
2181 to search any paths.
2183 * dbus/dbus-threads.c: move global mutex initializers to
2184 dbus-internals.h, multiple prototypes was confusing doxygen
2185 besides being kind of ugly
2187 * Doxyfile (PREDEFINED): have Doxygen define
2188 DOXYGEN_SHOULD_SKIP_THIS so we can exclude things from
2189 docs with #ifndef DOXYGEN_SHOULD_SKIP_THIS
2190 (do not abuse the feature! it's for stuff like the autogenerated
2191 macros in dbus-md5.c, not just for things you don't feel like
2194 2003-02-18 Havoc Pennington <hp@pobox.com>
2196 * dbus/dbus-string.c (_dbus_string_zero): new function
2198 * dbus/dbus-md5.c: include MD5 implementation by L. Peter Deutsch,
2199 wrap it in some dbus-friendly API
2201 * dbus/dbus-types.h: add 16-bit types
2203 2003-02-18 Joe Shaw <joe@assbarn.com>
2205 * dbus/dbus-auth.c (handle_server_data_stupid_test_mech): Just get
2206 credentials from our currently running process.
2207 (get_word): Fix a buglet where we were copying the entire length
2208 instead of relative to our position.
2210 * dbus/dbus-hash.c (_dbus_hash_test): Don't try to allocate the
2211 keys on the stack... it's 640k of data.
2213 * dbus/dbus-sysdeps.c (_dbus_read_credentials_unix_socket): Always
2214 read the credentials byte off the socket, even if we don't have
2216 (_dbus_poll): Implement poll() using select() for systems which
2219 * glib/test-dbus-glib.c (main): Print out an error if no
2220 parameters are given.
2222 * test/data/auth/fallback.auth-script: Added. Tests that a client
2223 can fallback to a secondary auth mechanism if the first fails.
2225 2003-02-18 Havoc Pennington <hp@pobox.com>
2229 2003-02-17 Havoc Pennington <hp@pobox.com>
2231 * doc/dbus-specification.sgml: lots of cosmetic
2232 cleanups/rearrangement, add assorted FIXME, change DBUS_ADDRESS
2233 env variable to DBUS_BUS_ADDRESS, s/client/application/,
2234 s/server/bus/ (except in authentication section). Add a section
2235 "Message Bus Message Routing"
2237 2003-02-17 Anders Carlsson <andersca@codefactory.se.>
2243 2003-02-17 Anders Carlsson <andersca@codefactory.se>
2245 * doc/dbus-specification.sgml:
2246 Specification updates.
2248 2003-02-17 Anders Carlsson <andersca@codefactory.se>
2250 * bus/activation.c: (bus_activation_init), (child_setup),
2251 (bus_activation_activate_service):
2253 * bus/main.c: (main):
2254 Set DBUS_ADDRESS environment variable.
2256 * dbus/dbus-errors.c: (dbus_set_error):
2257 Don't use va_copy since that's a C99 feature.
2259 * dbus/dbus-sysdeps.c: (_dbus_setenv), (do_exec),
2260 (_dbus_spawn_async):
2261 * dbus/dbus-sysdeps.h:
2262 Add child_setup_func to _dbus_spawn_async.
2264 * doc/dbus-specification.sgml:
2265 Update specification.
2267 * test/spawn-test.c: (setup_func), (main):
2270 2003-02-17 Alexander Larsson <alexl@redhat.com>
2272 * dbus/dbus-connection.c (_dbus_connection_handler_destroyed_locked):
2275 2003-02-17 Anders Carlsson <andersca@codefactory.se>
2279 * doc/dbus-test-plan.sgml:
2280 Add test plan document.
2285 2003-02-17 Anders Carlsson <andersca@codefactory.se>
2287 * dbus/dbus-message.c: (decode_header_data),
2288 (_dbus_message_loader_return_buffer):
2289 Set the header padding amount when loading a message.
2291 2003-02-16 Anders Carlsson <andersca@codefactory.se>
2293 * bus/dispatch.c: (send_one_message):
2294 Only send broadcast messages to registered connections.
2296 * dbus/dbus-message.c: (dbus_message_name_is):
2297 * dbus/dbus-message.h:
2298 New convenience function.
2300 * dbus/dbus-transport-debug.c: (do_reading):
2301 Only dispatch one message per run.
2304 * test/bus-test.c: (new_connection_callback), (die),
2305 (test_hello_client1_handler), (test_hello_client2_handler),
2306 (test_hello_replies), (main):
2308 * test/bus-test-loop.[ch]:
2311 2003-02-16 Havoc Pennington <hp@pobox.com>
2313 * dbus/dbus-connection.c (dbus_connection_dispatch_message): fix
2314 backward conditional
2316 2003-02-16 Alexander Larsson <alexl@redhat.com>
2318 * dbus/dbus-connection.c:
2319 Implement sent_message_with_reply. (with_reply_and block is still
2321 Made dispatch_message not lose message if OOM.
2323 * dbus/dbus-errors.h:
2324 Add NoReply error (for reply timeouts).
2326 2003-02-16 Alexander Larsson <alexl@redhat.com>
2328 * dbus/dbus-hash.c (_dbus_hash_table_unref):
2329 Actually free keys and values when destroying hashtable.
2331 2003-02-16 Anders Carlsson <andersca@codefactory.se>
2333 * dbus/dbus-auth.c: (client_try_next_mechanism):
2336 * dbus/dbus-threads.c: (dbus_condvar_wait_timeout):
2337 Return TRUE if there's no thread implementation around.
2339 * glib/dbus-gmain.c: (free_source),
2340 (dbus_connection_hookup_with_g_main):
2341 Make sure to remove the GSource when the connection is finalized.
2343 2003-02-16 Anders Carlsson <andersca@codefactory.se>
2345 * bus/dispatch.c: (bus_dispatch_message_handler):
2346 * dbus/dbus-errors.h:
2347 Return an error if someone tries to send a message to a service
2350 2003-02-16 Anders Carlsson <andersca@codefactory.se>
2352 * bus/activation.c: (load_directory), (bus_activation_init),
2353 (bus_activation_activate_service):
2356 (bus_driver_handle_activate_service), (bus_driver_handle_message):
2357 More work on the activation handling.
2359 * dbus/dbus-errors.h:
2360 Add some error messages
2362 * dbus/dbus-message.c: (dbus_message_new_error_reply):
2363 * dbus/dbus-message.h:
2364 New function that creates an error message.
2366 * dbus/dbus-protocol.h:
2367 Add ACTIVATE_SERVER message.
2369 * dbus/dbus-server-unix.c: (unix_handle_watch),
2370 (_dbus_server_new_for_domain_socket):
2371 Call _dbus_fd_set_close_on_exec.
2373 * dbus/dbus-sysdeps.c: (make_pipe), (do_exec),
2374 (_dbus_spawn_async), (_dbus_disable_sigpipe),
2375 (_dbus_fd_set_close_on_exec):
2376 * dbus/dbus-sysdeps.h:
2377 Add _dbus_fd_set_close_on exec function. Also add function that checks
2378 that all open fds are set to close-on-exec and warns otherwise.
2380 * dbus/dbus-transport-unix.c:
2381 (_dbus_transport_new_for_domain_socket):
2382 Call _dbus_fd_set_close_on_exec.
2384 2003-02-16 Havoc Pennington <hp@pobox.com>
2386 * dbus/dbus-connection.c (dbus_connection_set_change_sigpipe):
2387 allow people to avoid setting SIGPIPE to SIG_IGN
2388 (_dbus_connection_new_for_transport): disable SIGPIPE unless
2389 we've been asked not to
2391 2003-02-15 Anders Carlsson <andersca@codefactory.se>
2393 * dbus/dbus-list.c: (_dbus_list_append_link),
2394 (_dbus_list_prepend_link):
2395 * dbus/dbus-memory.c: (dbus_malloc), (dbus_malloc0),
2399 2003-02-15 Anders Carlsson <andersca@codefactory.se>
2402 * bus/activation.c: (bus_activation_entry_free),
2403 (add_desktop_file_entry), (load_directory), (bus_activation_init):
2405 * bus/main.c: (main):
2406 Add simple activation support, doesn't work yet though.
2408 2003-02-15 Zack Rusin <zack@kde.org>
2410 * qt/dbus-qthread.cpp: small casting fix
2412 2003-02-15 Anders Carlsson <andersca@codefactory.se>
2414 * dbus/dbus-errors.c: (dbus_set_error):
2415 * dbus/dbus-errors.h:
2416 Add a few errors and make dbus_set_error void.
2418 * dbus/dbus-sysdeps.c:
2419 (_dbus_errno_to_string), (close_and_invalidate), (make_pipe),
2420 (write_err_and_exit), (read_ints), (do_exec), (_dbus_spawn_async):
2421 * dbus/dbus-sysdeps.h:
2422 Add _dbus_spawn_async.
2424 * test/spawn-test.c: (main):
2425 Test for _dbus_spawn_async.
2427 2003-02-15 Anders Carlsson <andersca@codefactory.se>
2429 * dbus/dbus-internals.h:
2430 Fix build without tests.
2432 * dbus/dbus-list.c: (alloc_link):
2433 Fix a segfault when a malloc fails.
2435 * dbus/dbus-memory.c: (initialize_malloc_debug), (dbus_malloc),
2436 (dbus_malloc0), (dbus_realloc):
2437 Add support for malloc debugging.
2439 2003-02-15 Alexander Larsson <alexl@redhat.com>
2441 * dbus/dbus-threads.c:
2442 * dbus/dbus-threads.h:
2443 Add condvars. Remove static mutext from API.
2444 Implement static mutexes by initializing them from threads_init.
2446 * glib/dbus-gthread.c:
2447 * qt/dbus-qthread.cpp:
2448 Update with the thread api changes.
2453 Turn StaticMutex into normal mutex + init function.
2454 Export new functions _dbus_list_alloc_link, _dbus_list_free_link,
2455 _dbus_list_append_link, _dbus_list_prepend_link
2458 * dbus/dbus-sysdeps.c:
2459 * dbus/dbus-sysdeps.h:
2460 New type dbus_atomic_t, and new functions _dbus_atomic_inc,
2461 _dbus_atomic_dec. Only slow fallback implementation at the moment.
2463 * dbus/dbus-protocol.h:
2464 Add DBUS_MESSAGE_LOCAL_DISCONNECT define
2466 * dbus/dbus-message.c:
2467 Make ref/unref atomic.
2470 * dbus/dbus-connection-internal.h:
2471 * dbus/dbus-connection.c:
2472 * dbus/dbus-connection.h:
2474 Change _peek to _borrow,_return & _steal_borrowed.
2475 Change disconnect callback to event.
2476 Make dbus_connection_dispatch_messages reentrant.
2478 * dbus/dbus-transport.c:
2479 Don't ref the connection on calls to the transport
2482 * dbus/dbus-message-handler.c:
2485 * glib/dbus-gmain.c:
2486 Don't use peek_message anymore
2489 * test/debug-thread.c:
2490 * test/debug-thread.h:
2491 Simple thread implementation that asserts() on deadlocks in
2492 single-threaded code.
2495 (main) Call debug_threads_init.
2498 Use disconnect message instead of disconnect callback.
2502 Don't call dbus_connection_set_disconnect_function. Instead export
2503 bus_connection_disconnect.
2506 Call bus_connection_disconnect when we get a disconnected message.
2508 2003-02-15 Havoc Pennington <hp@pobox.com>
2510 * dbus/dbus-message.c (dbus_message_new): fool around with the
2513 2003-02-14 Havoc Pennington <hp@pobox.com>
2515 * dbus/dbus-mempool.c: fail if the debug functions so indicate
2517 * dbus/dbus-memory.c: fail if the debug functions indicate we
2520 * dbus/dbus-internals.c (_dbus_set_fail_alloc_counter)
2521 (_dbus_decrement_fail_alloc_counter): debug functions to
2522 simulate memory allocation failures
2524 2003-02-14 Havoc Pennington <hp@pobox.com>
2526 * dbus/dbus-errors.h (struct DBusError): add a word of padding
2529 2003-02-13 Anders Carlsson <andersca@codefactory.se>
2531 * bus/driver.c: (bus_driver_handle_hello):
2533 * bus/services.c: (bus_service_lookup):
2534 Reorder message sending so we get a more sane order.
2536 * test/bus-test.c: (message_handler):
2539 2003-02-13 Anders Carlsson <andersca@codefactory.se>
2541 * bus/driver.c: (bus_driver_send_service_deleted),
2542 (bus_driver_send_service_created), (bus_driver_send_service_lost),
2543 (bus_driver_send_service_acquired), (bus_driver_handle_hello),
2544 (bus_driver_send_welcome_message),
2545 (bus_driver_handle_list_services),
2546 (bus_driver_handle_acquire_service),
2547 (bus_driver_handle_service_exists):
2548 * dbus/dbus-bus.c: (dbus_bus_register_client),
2549 (dbus_bus_acquire_service), (dbus_bus_service_exists):
2550 * dbus/dbus-errors.c: (dbus_result_to_string):
2551 * dbus/dbus-errors.h:
2552 * dbus/dbus-message.c: (dbus_message_append_args),
2553 (dbus_message_append_args_valist), (dbus_message_get_args),
2554 (dbus_message_get_args_valist), (dbus_message_get_args_iter),
2555 (dbus_message_iter_get_arg_type), (dbus_message_iter_get_string),
2556 (dbus_message_iter_get_byte_array),
2557 (dbus_message_iter_get_string_array), (message_iter_test),
2558 (check_message_handling), (_dbus_message_test):
2559 * dbus/dbus-message.h:
2560 * test/bus-test.c: (main):
2561 Change fields to arguments in messages, so that they won't be
2562 confused with header fields.
2564 * glib/test-dbus-glib.c: (main):
2565 Remove append_fields from hello message.
2567 2003-02-13 Anders Carlsson <andersca@codefactory.se>
2569 * dbus/dbus-errors.c:
2570 * dbus/dbus-message.c:
2571 * dbus/dbus-string.c:
2572 Documentation fixes.
2574 2003-02-13 Anders Carlsson <andersca@codefactory.se>
2576 * glib/dbus-gmain.c: (timeout_handler), (add_timeout),
2578 Implement support for timeouts in dbus-glib.
2580 2003-02-13 Anders Carlsson <andersca@codefactory.se>
2582 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
2583 * dbus/dbus-message.c: (process_test_subdir):
2584 * test/break-loader.c: (find_breaks_based_on):
2585 Plug some memory leaks.
2587 2003-02-13 Richard Hult <rhult@codefactory.se>
2589 * bus/main.c: Fix build.
2591 * dbus/dbus-errors.h:
2592 * dbus/dbus-errors.c: Fix copyright for Anders.
2594 2003-02-13 Anders Carlsson <andersca@codefactory.se>
2599 * bus/connection.c: (bus_connection_foreach):
2602 * bus/desktop-file.c: (grow_lines_in_section), (grow_sections),
2603 (unescape_string), (new_section), (parse_section_start),
2604 (parse_key_value), (report_error), (bus_desktop_file_load),
2605 (bus_desktop_file_get_string):
2606 * bus/desktop-file.h:
2607 Use DBusError for error reporting.
2609 * bus/dispatch.c: (send_one_message),
2610 (bus_dispatch_message_handler):
2611 * bus/driver.c: (bus_driver_send_service_deleted),
2612 (bus_driver_send_service_created), (bus_driver_send_service_lost),
2613 (bus_driver_send_service_acquired), (bus_driver_handle_hello),
2614 (bus_driver_send_welcome_message),
2615 (bus_driver_handle_list_services),
2616 (bus_driver_handle_acquire_service),
2617 (bus_driver_handle_service_exists):
2618 * bus/loop.c: (bus_loop_run):
2620 Use BUS_HANDLE_OOM instead of _DBUS_HANDLE_OOM.
2622 * bus/utils.c: (bus_wait_for_memory):
2624 New files with general utility functions.
2626 * dbus/dbus-internals.h:
2627 Remove _DBUS_HANDLE_OOM.
2629 2003-02-13 Anders Carlsson <andersca@codefactory.se>
2631 * dbus/dbus-errors.c: (dbus_result_to_string), (dbus_error_init),
2632 (dbus_error_free), (dbus_set_error_const), (dbus_set_error):
2633 * dbus/dbus-errors.h:
2634 Add DBusError structure.
2636 2003-02-13 Anders Carlsson <andersca@codefactory.se>
2638 * test/data/valid-messages/standard-acquire-service.message:
2639 * test/data/valid-messages/standard-hello.message:
2640 * test/data/valid-messages/standard-list-services.message:
2641 * test/data/valid-messages/standard-service-exists.message:
2642 Add some standard messages.
2644 2003-02-13 Anders Carlsson <andersca@codefactory.se>
2646 * bus/driver.c: (bus_driver_send_welcome_message),
2647 (bus_driver_handle_list_services),
2648 (bus_driver_handle_acquire_service),
2649 (bus_driver_handle_service_exists), (bus_driver_handle_message):
2650 Update for API changes in libdbus.
2652 * dbus/dbus-message.c: (dbus_message_new_reply):
2653 * dbus/dbus-message.h:
2654 Remove the name argument. The spec states that replies shouldn't
2657 2003-02-13 Anders Carlsson <andersca@codefactory.se>
2659 * bus/desktop-file.c: (parse_section_start), (parse_key_value),
2660 (report_error), (bus_desktop_file_load), (lookup_section),
2661 (lookup_line), (bus_desktop_file_get_raw),
2662 (bus_desktop_file_get_string):
2663 * bus/desktop-file.h:
2664 Some fixes, and new functions for getting a key value from a section.
2666 2003-02-13 Havoc Pennington <hp@pobox.com>
2668 * test/data/auth/fail-after-n-attempts.auth-script: new test
2670 * dbus/dbus-auth.c (send_rejected): shutdown_mech() when we
2673 2003-02-13 Havoc Pennington <hp@pobox.com>
2675 * dbus/dbus-auth.c (handle_server_data_external_mech): args to
2676 dbus_credentials_match were backward
2678 * dbus/dbus-auth-script.c (_dbus_auth_script_run): support
2679 NO_CREDENTIALS and ROOT_CREDENTIALS
2681 * dbus/dbus-auth.c (_dbus_auth_do_work): move get_state() routine
2682 into here. Never process more commands after we've reached an
2683 end state; store further data as unused bytes.
2685 * test/data/auth/*: add more auth tests
2687 * dbus/dbus-auth-script.c (_dbus_auth_script_run): support EXPECT
2688 command to match exact string and EXPECT_UNUSED to match unused
2691 * test/Makefile.am (dist-hook): fix to dist all the test stuff
2693 2003-02-12 Havoc Pennington <hp@pobox.com>
2695 * dbus/dbus-string.c (_dbus_string_pop_line): fix to also strip
2696 \r off of popped lines
2698 * dbus/dbus-auth.c (_dbus_auth_test): write code to run auth
2701 * dbus/dbus-auth-script.c (_dbus_auth_script_run): when doing a
2704 2003-02-12 Havoc Pennington <hp@pobox.com>
2706 * dbus/Makefile.am: remove break-loader from the build, since it
2709 * configure.in: add --enable-gcov to turn on coverage profiling
2710 flags and disable optimization
2712 2003-02-10 Havoc Pennington <hp@pobox.com>
2714 * dbus/dbus-auth-script.c, dbus/dbus-auth-script.h: sync
2715 initial cut at test framework for DBusAuth from laptop.
2716 Doesn't quite work yet but it compiles and I need to get
2717 it off the 266mhz laptop. ;-)
2719 * dbus/dbus-server-debug.c (_dbus_server_debug_accept_transport):
2720 fix a memleak in error case
2722 2003-02-12 Anders Carlsson <andersca@codefactory.se>
2725 * bus/desktop-file.c:
2726 * bus/desktop-file.h:
2727 Add a desktop file parser.
2729 2003-02-11 Zack Rusin <zack@kde.org>
2731 * qt/message.[h|cpp]: sample implementation
2732 of the KDE wrapper for DBusMessage
2734 2003-02-09 Zack Rusin <zack@kde.org>
2736 * test/bus-test.c: make_it_compile
2737 * doc/dbus-specification.sgml: minimal semantic fix
2739 2003-02-06 Anders Carlsson <andersca@codefactory.se>
2745 2003-02-06 Anders Carlsson <andersca@codefactory.se>
2748 * dbus/dbus-break-loader.c:
2750 * test/break-loader.c:
2751 Move dbus-break-loader to test/ and rename it to break-loader.
2753 2003-02-02 Havoc Pennington <hp@pobox.com>
2755 * dbus/dbus-keyring.c, dbus/dbus-keyring.h: template files
2756 for code to manage cookies in your home directory
2758 * dbus/dbus-sysdeps.c (_dbus_generate_random_bytes): new function
2760 * dbus/dbus-auth.c (get_state): impose a maximum number of tries
2761 to authenticate, then disconnect the client.
2763 2003-02-03 Alexander Larsson <alexl@redhat.com>
2765 * dbus/dbus-message.c (dbus_message_append_fields):
2768 2003-02-02 Anders Carlsson <andersca@codefactory.se>
2770 * doc/dbus-specification.sgml:
2771 Update address format section.
2773 2003-02-02 Anders Carlsson <andersca@codefactory.se>
2776 * test/bus-test.c: (get_time), (add_timeout), (remove_timeout),
2777 (message_handler), (new_connection_callback), (loop_quit),
2781 2003-02-02 Anders Carlsson <andersca@codefactory.se>
2783 * bus/driver.c: (bus_driver_handle_service_exists):
2784 Simplify the code a bit.
2786 * dbus/dbus-bus.c: (dbus_bus_service_exists):
2789 2003-02-02 Anders Carlsson <andersca@codefactory.se>
2792 Add libdbus-daemon.la and link to it.
2794 2003-02-01 James Willcox <jwillcox@gnome.org>
2796 * bus/driver.c: (bus_driver_handle_own_service):
2797 Actually include the service reply code in the message.
2799 2003-02-02 Anders Carlsson <andersca@codefactory.se>
2801 * bus/driver.c: (bus_driver_handle_service_exists):
2802 Don't unref the incoming message.
2804 2003-02-02 Anders Carlsson <andersca@codefactory.se>
2806 * dbus/dbus.h: Add dbus-address.h and dbus-bus.h
2808 2003-02-02 Anders Carlsson <andersca@codefactory.se>
2810 * dbus/dbus-server.c: (dbus_server_listen):
2811 * dbus/dbus-transport.c: (_dbus_transport_open):
2812 ifdef out the calls to the debug transport and server.
2814 2003-02-02 Alexander Larsson <alexl@redhat.com>
2816 * dbus/dbus-watch.c (dbus_watch_get_flags):
2817 Add note in the docs that ERROR or HANGUP won't be returned
2818 and are assumed always on.
2820 * glib/dbus-gmain.c (add_watch):
2821 Always add IO_ERR | IO_HUP
2823 * dbus/dbus-message.h:
2824 Add semicolon after dbus_message_iter_get_string_array().
2825 Makes qt code build again
2827 2003-02-01 Anders Carlsson <andersca@codefactory.se>
2829 * bus/driver.c: (create_unique_client_name),
2830 (bus_driver_handle_hello):
2831 Don't take a name, just use a numeric id to identify
2835 * dbus/dbus-bus.c: (dbus_bus_register_client),
2836 (dbus_bus_acquire_service), (dbus_bus_service_exists):
2838 Add new convenience functions for communicating with the bus.
2840 * dbus/dbus-message.h:
2842 * dbus/dbus-protocol.h:
2845 2003-02-01 Alexander Larsson <alexl@redhat.com>
2847 * dbus/dbus-message.c (dbus_message_append_fields):
2848 Add some more doc comments.
2850 2003-02-01 Havoc Pennington <hp@pobox.com>
2852 * dbus/dbus-break-loader.c (randomly_modify_length): change
2853 a 4-byte value in the message as if it were a length
2855 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): don't set
2856 execute bit on saved files
2858 2003-02-01 Havoc Pennington <hp@pobox.com>
2860 * dbus/dbus-break-loader.c (main): new program to find messages
2861 that break the loader.
2863 * dbus/dbus-sysdeps.c (_dbus_string_append_uint): new function
2864 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): new function
2866 * dbus/dbus-string.c (_dbus_string_set_byte): new
2868 2003-01-31 Havoc Pennington <hp@pobox.com>
2870 * dbus/dbus-message.c: refactor the test code to be more general,
2871 in preparation for writing a "randomly permute test cases to
2872 try to break the loader" program.
2874 2003-01-31 Havoc Pennington <hp@pobox.com>
2876 * doc/dbus-specification.sgml: work on the specification
2878 * dbus/dbus-message.c (_dbus_message_loader_return_buffer): check
2879 the protocol version of the message.
2881 * dbus/dbus-protocol.h: drop special _REPLY names, the spec
2882 no longer specifies that.
2883 (DBUS_SERVICE_REPLY_SERVICE_EXISTS): fix flags (1/2/4/8 not
2886 * dbus/dbus-marshal.c (_dbus_marshal_get_arg_end_pos): add missing
2887 "break" for DBUS_TYPE_NIL, remove @todo
2889 2003-01-31 Havoc Pennington <hp@pobox.com>
2891 * dbus/dbus-message.c (dbus_message_set_is_error_reply): rename
2892 just set_is_error/get_is_error as this is a commonly-used
2893 function, and write docs.
2895 2003-01-31 Anders Carlsson <andersca@codefactory.se>
2897 * dbus/dbus-address.c: (dbus_address_entry_free):
2898 Free key and value lists.
2900 * dbus/dbus-internals.c: (_dbus_type_to_string):
2901 Add the types we didn't have.
2903 * dbus/dbus-marshal.c: (_dbus_marshal_get_arg_end_pos),
2904 (_dbus_marshal_validate_arg):
2907 * dbus/dbus-message.c: (dbus_message_set_sender):
2908 Remove todo about being able to set sender to NULL.
2910 (dbus_message_set_is_error_reply),
2911 (dbus_message_get_is_error_reply):
2912 * dbus/dbus-message.h:
2915 * dbus/dbus-protocol.h:
2916 Add error reply flag.
2918 * test/data/valid-messages/opposite-endian.message:
2919 Add NIL type to test.
2921 2003-01-31 Havoc Pennington <hp@pobox.com>
2923 * doc/dbus-specification.sgml: fully specify the header. Add
2924 flags and major protocol version, and change header/body len to
2927 * dbus/dbus-message-builder.c (append_saved_length): append length
2930 * dbus/dbus-message.c (dbus_message_create_header): change header
2931 length and body length to unsigned. Add the new fields from the
2933 (_dbus_message_loader_return_buffer): unsigned header/body len
2935 2003-01-30 Havoc Pennington <hp@pobox.com>
2937 * dbus/dbus-auth.c: rework to use only REJECTED, no
2940 * doc/dbus-sasl-profile.txt: drop MECHANISMS and just
2941 use REJECTED, suggested by Mark McLoughlin
2943 2003-01-30 Havoc Pennington <hp@pobox.com>
2945 * dbus/dbus-server.c (dbus_server_listen): @todo about how we need
2946 a better way to report errors here. e.g. "unix address lacks
2947 path" or something. also "no such file" when the path doesn't
2950 * dbus/dbus-address.c (dbus_address_entries_free): add @todo about
2952 (dbus_parse_address): add @todo about documenting address format,
2953 and allowing , and ; to be escaped
2955 2003-01-30 Anders Carlsson <andersca@codefactory.se>
2958 Add dbus-address.[ch]
2960 * dbus/dbus-address.c: (dbus_address_entry_free),
2961 (dbus_address_entries_free), (create_entry),
2962 (dbus_address_entry_get_method), (dbus_address_entry_get_value),
2963 (dbus_parse_address), (_dbus_address_test):
2964 * dbus/dbus-address.h:
2965 New files for dealing with address parsing.
2967 * dbus/dbus-connection.c:
2968 Document timeout functions.
2970 * dbus/dbus-message.c:
2971 Document dbus_message_new_from_message.
2973 * dbus/dbus-server-debug.c:
2976 * dbus/dbus-server.c: (dbus_server_listen):
2977 Parse address and use correct server implementation.
2979 * dbus/dbus-string.c: (_dbus_string_find_to), (_dbus_string_test):
2980 * dbus/dbus-string.h:
2981 New function with test.
2983 * dbus/dbus-test.c: (dbus_internal_symbol_do_not_use_run_tests):
2987 * dbus/dbus-transport-debug.c:
2990 * dbus/dbus-transport.c: (_dbus_transport_open):
2991 Parse address and use correct transport implementation.
2993 2003-01-30 Havoc Pennington <hp@pobox.com>
2995 * dbus/dbus-message.c: use message->byte_order instead of
2996 DBUS_COMPILER_BYTE_ORDER throughout.
2997 (dbus_message_create_header): pad header to align the
2998 start of the body of the message to 8-byte boundary
3000 * dbus/dbus-marshal.h: make all the demarshalers take const
3001 DBusString arguments.
3003 * dbus/dbus-message.c (_dbus_message_loader_return_buffer):
3004 validate message args here, so we don't have to do slow validation
3005 later, and so we catch bad messages as they are incoming. Also add
3006 better checks on header_len and body_len. Also fill in
3009 * dbus/dbus-string.c (_dbus_string_validate_utf8): new (not
3010 implemented properly)
3011 (_dbus_string_validate_nul): new function to check all-nul
3013 * dbus/dbus-marshal.c (_dbus_marshal_get_field_end_pos): rename
3014 get_arg_end_pos and remove all validation
3015 (_dbus_marshal_validate_arg): actually do validation here.
3017 2003-01-29 Havoc Pennington <hp@pobox.com>
3019 * dbus/dbus-message.c (check_message_handling): fix assertion
3020 failure on set_client_serial
3022 2003-01-28 Havoc Pennington <hp@pobox.com>
3024 * dbus/dbus-server-debug.c: Add doc section comments
3026 * dbus/dbus-transport-debug.c: add doc section comments
3028 2003-01-28 Havoc Pennington <hp@redhat.com>
3030 * dbus/dbus-string.c (_dbus_string_base64_decode): append bytes in
3031 the reverse order from how I had it
3032 (_dbus_string_base64_encode): reverse encoding order. I was
3033 basically byteswapping everything during encoding.
3035 2003-01-28 Anders Carlsson <andersca@codefactory.se>
3037 * dbus/dbus-connection-internal.h:
3038 * dbus/dbus-connection.c: (_dbus_connection_add_timeout),
3039 (_dbus_connection_remove_timeout):
3040 Add functions for adding and removing timeouts.
3042 * dbus/dbus-message.c: (dbus_message_new_from_message):
3043 Add new function that takes a message and creates an exact
3044 copy of it, but with the refcount set to 1.
3045 (check_message_handling):
3048 * dbus/dbus-server-protected.h:
3049 * dbus/dbus-server.c: (_dbus_server_init_base),
3050 (_dbus_server_finalize_base), (_dbus_server_add_timeout),
3051 (dbus_server_set_timeout_functions):
3052 (_dbus_server_remove_timeout):
3053 New functions so that a server can add and remove timeouts.
3055 (dbus_server_listen):
3056 Add commented out call to dbus_server_debug_new.
3058 * dbus/dbus-timeout.c: (_dbus_timeout_new):
3059 Actually set the handler, doh.
3061 * dbus/dbus-transport.c: (_dbus_transport_open):
3062 Add commented out call to dbus_transport_debug_client_new.
3065 Add dbus-transport-debug.[ch] and dbus-server-debug.[ch]
3067 2003-01-28 Havoc Pennington <hp@pobox.com>
3069 * dbus/dbus-message.c (check_message_handling): function to check
3070 on the loaded message, iterates over it etc.
3072 2003-01-28 Havoc Pennington <hp@pobox.com>
3074 * test/Makefile.am (dist-hook): fix make distdir
3076 * dbus/Makefile.am (TESTS_ENVIRONMENT): fix make check
3078 2003-01-27 Havoc Pennington <hp@pobox.com>
3080 * dbus/dbus-mempool.c (time_for_size): replace printf with
3083 * dbus/dbus-message-builder.c (_dbus_message_data_load): allow
3084 empty lines; fix the SAVE_LENGTH stuff to be
3085 START_LENGTH/END_LENGTH so it actually works; couple other
3088 * test/Makefile.am (dist-hook): add dist-hook for .message files
3090 * dbus/dbus-string.c (DBUS_STRING_COPY_PREAMBLE): source of a copy
3091 can be constant or locked.
3092 (_dbus_string_free): allow freeing a const string as
3095 * dbus/dbus-sysdeps.c (_dbus_concat_dir_and_file): utility
3097 * dbus/dbus-test-main.c (main): take an argument which is the
3098 directory containing test data
3100 * dbus/dbus-message.c (_dbus_message_test): pass a test_data_dir
3101 argument to this and load all the messages in test/data/
3102 checking that they can be loaded or not loaded as appropriate.
3104 2003-01-27 Anders Carlsson <andersca@codefactory.se>
3106 * bus/dispatch.c: (bus_dispatch_message_handler):
3107 Dispatch messages sent to services.
3109 * bus/driver.c: (bus_driver_send_service_deleted),
3110 (bus_driver_send_service_created), (bus_driver_send_service_lost),
3111 (bus_driver_send_service_acquired):
3112 Add helper functions for sending service related messages.
3114 (bus_driver_send_welcome_message):
3115 Send HELLO_REPLY instead of WELCOME.
3117 (bus_driver_handle_list_services):
3118 Send LIST_SERVICES_REPLY instead of SERVICES.
3120 (bus_driver_handle_own_service),
3121 (bus_driver_handle_service_exists):
3122 New message handlers.
3124 (bus_driver_handle_message):
3125 Invoke new message handlers.
3127 (bus_driver_remove_connection):
3128 Don't remove any services here since that's done automatically
3129 by bus_service_remove_owner now.
3132 New function signatures.
3134 * bus/services.c: (bus_service_add_owner):
3135 Send ServiceAcquired message if we're the only primary owner.
3137 (bus_service_remove_owner):
3138 Send ServiceAcquired/ServiceLost messages.
3140 (bus_service_set_prohibit_replacement),
3141 (bus_service_get_prohibit_replacement):
3142 Functions for setting prohibit replacement.
3144 (bus_service_has_owner):
3145 New function that checks if a connection is in the owner queue of
3149 Add new function signatures.
3151 * dbus/dbus-list.c: (_dbus_list_test):
3152 Add tests for _dbus_list_remove_last and traversing the list backwards.
3155 Fix a typo in _dbus_list_get_prev_link, if we're at the first element we can't
3156 go any further, so return NULL then.
3158 * dbus/dbus-protocol.h:
3159 Add new messages, service flags and service replies.
3161 2003-01-26 Havoc Pennington <hp@pobox.com>
3163 * dbus/dbus-message-builder.c: implement, completely untested.
3165 * test/data/*: add data to be used in testing.
3166 ".message" files are our simple loadable text format.
3167 ".message-raw" will be binary dumps of messages.
3169 * dbus/dbus-string.c (_dbus_string_starts_with_c_str): new
3171 2003-01-26 Havoc Pennington <hp@pobox.com>
3173 * dbus/dbus-sysdeps.c (_dbus_file_get_contents): new function
3175 * dbus/dbus-errors.c (dbus_result_to_string): add
3178 * dbus/dbus-message-builder.c: new file, will contain code to load
3179 up messages from files. Not implemented yet.
3181 2003-01-26 Havoc Pennington <hp@pobox.com>
3183 * dbus/dbus-message.c (dbus_message_set_sender): support deleting
3184 the sender by setting to NULL
3186 2003-01-26 Havoc Pennington <hp@pobox.com>
3188 The unit tests pass, but otherwise untested. If it breaks, the
3189 tests should have been better. ;-)
3191 * bus/driver.c (bus_driver_handle_hello): return if we disconnect
3194 * dbus/dbus-message.c: redo everything so we maintain
3195 message->header as the only copy of the various fields.
3196 This avoids the possibility of out-of-memory in some cases,
3197 for example dbus_message_lock() can't run out of memory anymore,
3198 and avoids extra copying. Figured I may as well go ahead and do
3199 this since it was busted for dbus_message_lock to not return
3200 failure on OOM, and dbus_message_write_header was totally
3201 unchecked for OOM. Also fixed some random other bugs.
3203 * dbus/dbus-marshal.c (_dbus_marshal_get_field_end_pos): verify
3204 that strings are nul-terminated. Also, end_pos can be equal
3205 to string length just not greater than, I think.
3206 (_dbus_marshal_set_int32): new function
3207 (_dbus_marshal_set_uint32): new function
3208 (_dbus_marshal_set_string): new function
3210 * dbus/dbus-connection.c (_dbus_connection_new_for_transport): fix
3211 a warning, init timeout_list to NULL
3212 (dbus_connection_send_message): don't use uninitialized variable
3215 * dbus/dbus-string.c (_dbus_string_replace_len): new function
3217 2003-01-26 Anders Carlsson <andersca@codefactory.se>
3219 * bus/driver.c: (bus_driver_handle_hello),
3220 (bus_driver_send_welcome_message):
3223 2003-01-26 Anders Carlsson <andersca@codefactory.se>
3225 * dbus/dbus-auth.c: (process_auth), (_dbus_auth_unref):
3226 * dbus/dbus-connection.c: (_dbus_connection_new_for_transport),
3227 (dbus_connection_unref):
3228 * dbus/dbus-marshal.c: (_dbus_marshal_test):
3229 * dbus/dbus-message.c: (dbus_message_unref),
3232 (dbus_message_get_fields):
3233 Remove debugging printout.
3235 (_dbus_message_loader_return_buffer):
3236 Don't store the header string.
3238 (_dbus_message_test):
3241 2003-01-26 Richard Hult <rhult@codefactory.se>
3243 * glib/dbus-gmain.c (dbus_connection_dispatch): Traverse a copy of
3244 the file descriptor list, since it can change under us.
3246 2003-01-25 Anders Carlsson <andersca@codefactory.se>
3248 * glib/dbus-gmain.c: (dbus_connection_prepare),
3249 (dbus_connection_check), (dbus_connection_dispatch), (add_watch),
3250 (remove_watch), (dbus_connection_hookup_with_g_main):
3251 Rewrite the glib handling to use its own GSource instead of a
3252 GIOChannel so we can catch messages put in the queue while waiting
3255 2003-01-25 Anders Carlsson <andersca@codefactory.se>
3258 * bus/connection.c: (connection_disconnect_handler),
3259 (connection_watch_callback), (bus_connection_setup):
3260 * bus/dispatch.c: (send_one_message),
3261 (bus_dispatch_broadcast_message), (bus_dispatch_message_handler),
3262 (bus_dispatch_add_connection), (bus_dispatch_remove_connection):
3264 * bus/driver.c: (bus_driver_send_service_deleted),
3265 (bus_driver_send_service_created), (bus_driver_handle_hello),
3266 (bus_driver_send_welcome_message),
3267 (bus_driver_handle_list_services), (bus_driver_remove_connection),
3268 (bus_driver_handle_message):
3270 Refactor code, put the message dispatching in its own file. Use
3271 _DBUS_HANDLE_OOM. Also send ServiceDeleted messages when a client
3274 2003-01-25 Anders Carlsson <andersca@codefactory.se>
3276 * dbus/dbus-internals.h:
3277 Add _DBUS_HANDLE_OOM macro, it doesn't do anything currently.
3279 * dbus/dbus-message.c: (dbus_message_get_sender):
3280 * dbus/dbus-message.h:
3281 Implement dbus_message_get_sender.
3283 * dbus/dbus-protocol.h:
3284 Add message and service defines.
3286 2003-01-25 Anders Carlsson <andersca@codefactory.se>
3288 * dbus/dbus-connection.c: (dbus_connection_send_message):
3289 * dbus/dbus-message-internal.h:
3290 * dbus/dbus-message.c: (_dbus_message_get_client_serial),
3291 (dbus_message_write_header):
3292 Remove _dbus_messag_unlock and don't set the client serial on a
3293 message if one already exists.
3295 2003-01-24 Havoc Pennington <hp@pobox.com>
3297 * dbus/dbus-list.c (alloc_link): put a thread lock on the global
3300 * bus/driver.c (bus_driver_handle_list_services): fix a leak
3303 2003-01-25 Anders Carlsson <andersca@codefactory.se>
3305 * dbus/dbus-list.c: (alloc_link), (free_link):
3306 Use a memory pool for the links.
3308 2003-01-25 Anders Carlsson <andersca@codefactory.se>
3310 * bus/connection.c: (bus_connection_foreach):
3312 Add new bus_connection_foreach function.
3314 * bus/driver.c: (send_one_message), (bus_driver_broadcast_message):
3315 Add function that broadcasts a message to all clients.
3317 (bus_driver_send_service_created), (bus_driver_handle_hello),
3318 (bus_driver_send_welcome_message),
3319 (bus_driver_handle_list_services), (bus_driver_message_handler):
3320 Implement functions that take care of listing services, and notifying
3321 clients when new services are created.
3323 * bus/services.c: (bus_services_list):
3325 Add new function that returns an array of strings with the currently
3326 registered services.
3329 * glib/dbus-gmain.c:
3330 Update copyright year.
3332 2003-01-25 Anders Carlsson <andersca@codefactory.se>
3334 * dbus/dbus-connection.c: (dbus_connection_send_message):
3335 Unlock the message in case it was sent earlier.
3337 (dbus_connection_send_message_with_reply_and_block):
3338 Remove the reply message from the list.
3340 * dbus/dbus-marshal.c: (_dbus_demarshal_string_array):
3341 Set array_len and new_pos correctly.
3343 (_dbus_marshal_test):
3344 Remove debug output.
3346 * dbus/dbus-message-internal.h:
3347 * dbus/dbus-message.c: (_dbus_message_get_reply_serial):
3348 New function that returns the reply serial.
3350 (_dbus_message_unlock):
3351 New function that unlocks a message and resets its header.
3353 (dbus_message_append_string_array),
3354 (dbus_message_get_fields_valist),
3355 (dbus_message_iter_get_field_type),
3356 (dbus_message_iter_get_string_array),
3357 (dbus_message_get_fields),
3358 (dbus_message_append_fields_valist):
3359 Handle string arrays.
3361 (dbus_message_set_sender):
3362 Make this function public since the bus daemon needs it.
3364 (decode_header_data):
3365 Set the reply serial to -1 initially.
3367 * dbus/dbus-message.h:
3368 Add dbus_message_set_sender.
3370 2003-01-24 Havoc Pennington <hp@pobox.com>
3372 * doc/dbus-specification.sgml: add some stuff
3374 2003-01-22 Havoc Pennington <hp@pobox.com>
3376 * doc/dbus-specification.sgml: Start to document the protocol.
3378 2003-01-22 Havoc Pennington <hp@pobox.com>
3380 * dbus/dbus-connection.c
3381 (dbus_connection_send_message_with_reply_and_block): add some @todo
3383 * bus/driver.c (bus_driver_add_connection): add a FIXME about memleak
3385 2003-01-21 Havoc Pennington <hp@pobox.com>
3387 (patch untested because can't compile)
3389 * bus/driver.c (create_unique_client_name): make this function
3390 never recycle client names. Also, caller should initialize
3393 * dbus/dbus-sysdeps.c (_dbus_get_current_time): new function
3395 2003-01-21 Anders Carlsson <andersca@codefactory.se>
3397 * dbus/dbus-marshal.c: (_dbus_marshal_double),
3398 (_dbus_marshal_int32), (_dbus_marshal_uint32),
3399 (_dbus_marshal_int32_array), (_dbus_marshal_uint32_array),
3400 (_dbus_marshal_double_array), (_dbus_marshal_string_array),
3401 (_dbus_demarshal_int32_array), (_dbus_demarshal_uint32_array),
3402 (_dbus_demarshal_double_array), (_dbus_demarshal_string_array),
3403 (_dbus_marshal_get_field_end_pos), (_dbus_marshal_test):
3404 * dbus/dbus-marshal.h:
3405 * dbus/dbus-protocol.h:
3406 Add support for marshalling and demarshalling integer, double
3409 2003-01-21 Anders Carlsson <andersca@codefactory.se>
3414 * bus/connection.c: (connection_disconnect_handler):
3415 Remove the connection from the bus driver's list.
3417 (connection_watch_callback): Dispatch messages.
3419 (free_connection_data): Free connection name.
3421 (bus_connection_setup): Add connection to the bus driver's list.
3422 (bus_connection_remove_owned_service):
3423 (bus_connection_set_name), (bus_connection_get_name):
3424 Add functions for setting and getting the connection's name.
3427 Add function headers.
3429 * bus/driver.c: (create_unique_client_name),
3430 (bus_driver_handle_hello_message),
3431 (bus_driver_send_welcome_message), (bus_driver_message_handler),
3432 (bus_driver_add_connection), (bus_driver_remove_connection):
3435 * bus/services.c: (bus_service_free):
3437 New file that handles communication and registreation with the bus
3440 2003-01-21 Anders Carlsson <andersca@codefactory.se>
3442 * dbus/dbus-connection.c: (dbus_connection_send_message):
3443 Add a new client_serial parameter.
3445 (dbus_connection_send_message_with_reply):
3446 Remove a @todo since we've implemented the blocking function.
3448 (dbus_connection_send_message_with_reply_and_block):
3449 New function that sends a message and waits for a reply and
3450 then returns the reply.
3452 * dbus/dbus-connection.h:
3455 * dbus/dbus-errors.c: (dbus_result_to_string):
3456 * dbus/dbus-errors.h:
3457 Add new DBUS_RESULT.
3459 * dbus/dbus-message-internal.h:
3460 * dbus/dbus-message.c: (_dbus_message_get_reply_serial),
3461 (_dbus_message_set_sender), (dbus_message_write_header),
3462 (dbus_message_new_reply), (decode_header_data),
3463 (_dbus_message_loader_return_buffer), (_dbus_message_test):
3464 * dbus/dbus-message.h:
3465 Add new functions that set the reply serial and sender.
3466 Also marshal and demarshal them correctly and add test.
3468 * dbus/dbus-protocol.h:
3469 Add new DBUS_MESSAGE_TYPE_SENDER.
3472 * glib/dbus-gmain.c: (watch_callback), (free_callback_data),
3473 (add_watch), (remove_watch), (add_timeout), (remove_timeout),
3474 (dbus_connection_hookup_with_g_main):
3475 * glib/test-dbus-glib.c: (main):
3476 Rewrite to use GIOChannel and remove the GSource crack.
3478 * test/echo-client.c: (main):
3479 * test/watch.c: (check_messages):
3480 Update for changed APIs
3482 2003-01-19 Anders Carlsson <andersca@codefactory.se>
3484 * dbus/Makefile.am: Add dbus-timeout.[cħ]
3486 * dbus/dbus-connection.c: (_dbus_connection_new_for_transport):
3487 Create a DBusTimeoutList.
3488 (dbus_connection_set_timeout_functions): Add new function to
3489 set timeout callbacks
3491 * dbus/dbus-connection.h: Add public DBusTimeout API.
3493 * dbus/dbus-message.c: (dbus_message_get_service):
3494 * dbus/dbus-message.h: New function.
3496 * dbus/dbus-server.c: Fix small doc typo.
3498 * dbus/dbus-timeout.[ch]: New files for mainloop timeouts.
3500 2003-01-19 Anders Carlsson <andersca@codefactory.se>
3502 * dbus/dbus-string.c (_dbus_string_move_len): Don't delete all
3503 of the string, just as long as specified.
3505 2003-01-19 Havoc Pennington <hp@pobox.com>
3507 * dbus/dbus-connection.c (dbus_connection_get_is_authenticated):
3510 * dbus/dbus-server.c (dbus_server_set_max_connections)
3511 (dbus_server_get_max_connections, dbus_server_get_n_connections):
3512 keep track of current number of connections, and add API for
3513 setting a max (but haven't implemented enforcing the max yet)
3515 2003-01-18 Havoc Pennington <hp@pobox.com>
3517 * dbus/dbus-transport-unix.c (unix_do_iteration): only do the
3518 reading/writing if read_watch != NULL or write_watch != NULL.
3520 * dbus/dbus-message.c (_dbus_message_loader_return_buffer): fix
3521 the message loader code to actually load message->header and
3522 message->body into the newly-created message.
3524 * dbus/dbus-transport-unix.c (check_write_watch): fix a mem leak
3527 * dbus/dbus-connection.c (dbus_connection_set_max_message_size)
3528 (dbus_connection_get_max_message_size)
3529 (dbus_connection_set_max_live_messages_size)
3530 (dbus_connection_get_max_live_messages_size): implement some
3531 resource limitation functions
3533 * dbus/dbus-resources.c: new file implementing some of the
3534 resource limits stuff
3536 * dbus/dbus-message.c (dbus_message_iter_get_byte_array): add
3537 missing docs, add @todo to handle OOM etc.
3539 * dbus/dbus-marshal.c (_dbus_demarshal_byte_array): add missing
3542 2003-01-18 Havoc Pennington <hp@pobox.com>
3544 * dbus/dbus-connection.c (dbus_connection_unref): disconnect the
3545 connection if it hasn't been already.
3547 * dbus/dbus-connection.h: kill off the idea of an ErrorFunction,
3548 replace with DisconnectFunction.
3550 2003-01-18 Havoc Pennington <hp@pobox.com>
3552 Building --disable-verbose-mode --disable-asserts --disable-tests
3553 cuts the library from 112K to 45K or so
3555 * configure.in: check for varargs macro support,
3556 add --enable-verbose-mode, --enable-asserts.
3558 * dbus/dbus-internals.h (_dbus_assert): support
3560 (_dbus_verbose): support DBUS_ENABLE_VERBOSE_MODE
3562 2003-01-18 Havoc Pennington <hp@pobox.com>
3564 * dbus/dbus-test.c: include config.h so that tests actually run
3566 * dbus/dbus-string.c: add assertions that stuff is 8-byte aligned,
3567 so the failure mode when that assumption fails will be plenty
3570 2003-01-18 Havoc Pennington <hp@pobox.com>
3572 * configure.in: default --enable-tests to $USE_MAINTAINER_MODE
3574 * dbus/Makefile.am: fix it up so dubs-test-main.c is included in
3577 * test/Makefile.am: don't use special variable "TESTS" for echo-*
3578 since we don't want to use those in make check
3580 2003-01-15 Havoc Pennington <hp@redhat.com>
3586 2003-01-15 Havoc Pennington <hp@redhat.com>
3588 * test/Makefile.am: fix so that test source code ends up in the
3589 distribution on make distcheck
3591 2003-01-15 Havoc Pennington <hp@redhat.com>
3597 2003-01-15 Havoc Pennington <hp@redhat.com>
3599 * dbus/dbus-test.c (dbus_internal_symbol_do_not_use_run_tests):
3600 fix build when --disable-tests
3602 * Makefile.am (EXTRA_DIST): put HACKING in here
3604 * HACKING: document procedure for making a tarball release.
3606 2003-01-14 Anders Carlsson <andersca@codefactory.se>
3608 * bus/connection.c: (connection_error_handler),
3609 (bus_connection_setup):
3610 * bus/main.c: (main):
3611 Make sure that the DBusConnectionData struct is NULLed
3612 out to prevent a segfault.
3614 * dbus/dbus-errors.c: (dbus_result_to_string):
3615 * dbus/dbus-errors.h:
3616 * dbus/dbus-message.c: (dbus_message_get_fields),
3617 (dbus_message_get_fields_valist), (_dbus_message_test):
3618 * dbus/dbus-message.h:
3619 Make dbus_message_get_fields return a result code so we can
3620 track invalid fields as well as oom.
3622 2003-01-11 Havoc Pennington <hp@pobox.com>
3624 * configure.in: change --enable-test/--enable-ansi action-if-given
3625 to enable_foo=$enableval instead of enable_foo=yes
3627 2003-01-08 Havoc Pennington <hp@pobox.com>
3629 * dbus/dbus-string.c (_dbus_string_align_length): new function
3631 * dbus/dbus-test-main.c: move main() for test app here
3633 (dbus_internal_symbol_do_not_use_run_tests): we have to export a
3634 symbol to run tests, because dbus-test isn't in the main
3637 Code review nitpicks.
3639 * dbus/dbus-message.c (dbus_message_write_header): add newlines
3640 for people with narrow emacs ;-). Assert client_serial was filled
3641 in. Assert message->name != NULL.
3642 (dbus_message_append_fields): have "first_field_type" arg separate
3643 from va list, needed for C++ binding that also uses varargs IIRC
3644 and helps with type safety
3645 (dbus_message_new): add @todo about using DBusString to store
3646 service/name internally
3647 (dbus_message_new): don't leak ->service and ->name on OOM later
3649 (dbus_message_unref): free the service name
3650 (dbus_message_get_fields): same change to varargs
3651 i.e. first_field_type
3652 (_dbus_message_loader_return_buffer): assert that the message data
3653 is aligned (if not it's a bug in our code). Put in verbose griping
3654 about why we set corrupted = TRUE.
3655 (decode_header_data): add FIXME that char* is evil. Was going to
3656 add FIXME about evil locale-specific string.h strncmp, but just
3657 switched to wacky string-as-uint32 optimization. Move check for
3658 "no room for field name" above get_const_data_len() to avoid
3659 assertion failure in get_const_data_len if we have trailing 2
3660 bytes or the like. Check for service and name fields being
3661 provided twice. Don't leak service/name on error. Require field
3662 names to be aligned to 4 bytes.
3664 * dbus/dbus-marshal.c: move byte swap stuff to header
3665 (_dbus_pack_int32): uscore-prefix
3666 (_dbus_unpack_int32): uscore-prefix
3667 (_dbus_unpack_uint32): export
3668 (_dbus_demarshal_string): add @todo complaining about use of
3670 (_dbus_marshal_get_field_end_pos): add @todo about bad error
3671 handling allowing corrupt data to go unchecked
3673 2003-01-08 Havoc Pennington <hp@redhat.com>
3675 * dbus/dbus-transport-unix.c (unix_do_iteration): add read/write
3676 to the select() as needed for authentication. (should be using
3677 _dbus_poll() not select, but for another day)
3679 * dbus/dbus.h: include dbus/dbus-protocol.h
3681 2003-01-08 Anders Carlsson <andersca@codefactory.se>
3683 * dbus/Makefile.am (dbusinclude_HEADERS): Install
3686 2003-01-08 Anders Carlsson <andersca@codefactory.se>
3688 * dbus/dbus-internals.c: (_dbus_type_to_string):
3689 New function that returns a string describing a type.
3691 * dbus/dbus-marshal.c: (_dbus_demarshal_byte_array):
3692 * dbus/dbus-marshal.h:
3693 * dbus/dbus-message.c: (dbus_message_get_fields_valist),
3694 (dbus_message_iter_get_field_type), (dbus_message_iter_get_double),
3695 (dbus_message_iter_get_byte_array):
3696 * dbus/dbus-message.h:
3697 Add new convenience functions for appending and getting message fields.
3698 Also add demarshalling routines for byte arrays.
3700 2003-01-07 Anders Carlsson <andersca@codefactory.se>
3702 * dbus/dbus-connection-internal.h:
3703 * dbus/dbus-connection.c: (_dbus_connection_new_for_transport),
3704 (_dbus_connection_get_next_client_serial),
3705 (dbus_connection_send_message):
3706 * dbus/dbus-internals.h:
3707 * dbus/dbus-marshal.c: (unpack_uint32), (dbus_unpack_int32),
3708 (dbus_pack_int32), (_dbus_marshal_double), (_dbus_marshal_int32),
3709 (_dbus_marshal_uint32), (_dbus_demarshal_double),
3710 (_dbus_demarshal_int32), (_dbus_demarshal_uint32),
3711 (_dbus_demarshal_string), (_dbus_marshal_get_field_end_pos),
3712 (_dbus_verbose_bytes), (_dbus_marshal_test):
3713 * dbus/dbus-marshal.h:
3714 * dbus/dbus-message-internal.h:
3715 * dbus/dbus-message.c: (_dbus_message_set_client_serial),
3716 (dbus_message_write_header), (_dbus_message_lock),
3717 (dbus_message_new), (dbus_message_ref), (dbus_message_unref),
3718 (dbus_message_get_name), (dbus_message_append_int32),
3719 (dbus_message_append_uint32), (dbus_message_append_double),
3720 (dbus_message_append_string), (dbus_message_append_byte_array),
3721 (dbus_message_get_fields_iter), (dbus_message_iter_ref),
3722 (dbus_message_iter_unref), (dbus_message_iter_has_next),
3723 (dbus_message_iter_next), (dbus_message_iter_get_field_type),
3724 (dbus_message_iter_get_string), (dbus_message_iter_get_int32),
3725 (dbus_message_iter_get_uint32), (dbus_message_iter_get_double),
3726 (decode_header_data), (_dbus_message_loader_return_buffer),
3727 (message_iter_test), (_dbus_message_test):
3728 * dbus/dbus-message.h:
3729 * dbus/dbus-protocol.h:
3730 * dbus/dbus-test.c: (main):
3732 * glib/test-dbus-glib.c: (message_handler), (main):
3733 * test/echo-client.c: (main):
3734 * test/watch.c: (check_messages):
3735 Make messages sendable and receivable for real.
3737 2003-01-07 Anders Carlsson <andersca@codefactory.se>
3739 * dbus/dbus-marshal.c: (_dbus_marshal_double),
3740 (_dbus_marshal_string), (_dbus_marshal_byte_array):
3741 * dbus/dbus-message.c: (dbus_message_append_int32),
3742 (dbus_message_append_uint32), (dbus_message_append_double),
3743 (dbus_message_append_string), (dbus_message_append_byte_array):
3744 Handle OOM restoration.
3746 2003-01-07 Anders Carlsson <andersca@codefactory.se>
3748 * dbus/dbus-marshal.c: (_dbus_marshal_string),
3749 (_dbus_demarshal_string), (_dbus_marshal_test):
3750 * dbus/dbus-marshal.h:
3751 * dbus/dbus-message.c: (dbus_message_get_name),
3752 Document these functions.
3754 (dbus_message_append_int32), (dbus_message_append_uint32),
3755 (dbus_message_append_double), (dbus_message_append_string),
3756 (dbus_message_append_byte_array):
3757 * dbus/dbus-message.h:
3758 Add functions for adding message fields of different types.
3760 * dbus/dbus-protocol.h:
3761 Add the different types.
3763 2003-01-05 Havoc Pennington <hp@pobox.com>
3765 * bus/connection.c: implement routines for handling connections,
3766 first thing is keeping a list of owned services on each connection
3767 and setting up watches etc.
3769 * bus/services.c: implement a mapping from service names to lists
3772 * dbus/dbus-hash.c: add DBUS_HASH_POINTER
3774 * dbus/dbus-threads.c (dbus_static_mutex_lock): add functions
3775 to use static mutexes for global data
3777 * dbus/dbus-connection.c (dbus_connection_set_data): add new
3778 collection of functions to set/get application-specific data
3779 on the DBusConnection.
3781 2003-01-04 Havoc Pennington <hp@pobox.com>
3783 * dbus/dbus-sysdeps.c (_dbus_sleep_milliseconds): new function
3784 (_dbus_poll): new function
3786 * dbus/dbus-internals.h (_DBUS_STRUCT_OFFSET): new macro
3789 * bus/loop.c: initial code for the daemon main loop
3791 2003-01-04 Havoc Pennington <hp@pobox.com>
3793 * test/watch.c (error_handler): make it safe if the error handler
3794 is called multiple times (if we s/error handler/disconnect
3795 handler/ we should just guarantee it's called only once)
3797 * dbus/dbus-transport.c (_dbus_transport_disconnect): call the
3798 error handler on disconnect (it's quite possible we should
3799 just change the error handler to a "disconnect handler," I'm
3800 not sure we have any other meaningful errors)
3802 * configure.in: check for getpwnam_r
3804 * dbus/dbus-transport.c, dbus/dbus-transport-unix.c,
3805 dbus/dbus-auth.c: add credentials support, add EXTERNAL auth
3806 mechanism as in SASL spec, using socket credentials
3808 * dbus/dbus-sysdeps.c (_dbus_read_credentials_unix_socket): new function
3809 (_dbus_send_credentials_unix_socket): new function
3811 * dbus/dbus-sysdeps.c (_dbus_accept_unix_socket): rename just
3813 (_dbus_write): only check errno if <0 returned
3814 (_dbus_write_two): ditto
3816 2003-01-02 Anders Carlsson <andersca@codefactory.se>
3818 * dbus/dbus-marshal.c: (_dbus_marshal_utf8_string),
3819 (_dbus_marshal_byte_array), (_dbus_demarshal_utf8_string),
3820 (_dbus_marshal_test):
3821 * dbus/dbus-marshal.h:
3822 Add _dbus_marshal_byte_array and rename _dbus_marshal_string
3823 to _dbus_marshal_utf8_string. Also fix some tests.
3825 2002-12-28 Harri Porten <porten@kde.org>
3827 * configure.in: added check for C++ compiler and a very cheesy
3828 check for the Qt integration
3830 * Makefile.am (SUBDIRS): compile qt subdir if support is enabled
3832 * qt/Makefile.am: added
3834 * qt/.cvsignore: added
3836 * qt/dbus-qthread.cc, qt/dbus-qthread.cpp: renamed former to
3837 latter, added #ifdef QT_THREAD_SUPPORT guard.
3839 * dbus/Makefile.am: added missing headers for make dist
3841 2002-12-28 Kristian Rietveld <kris@gtk.org>
3843 * dbus/Makefile.am: fixup export-symbols-regex.
3845 2002-12-27 Anders Carlsson <andersca@codefactory.se>
3847 * acinclude.m4: Add this file and put the
3848 PKG_CHECK_MODULE macro in it.
3850 2002-12-27 Anders Carlsson <andersca@codefactory.se>
3852 * dbus/dbus-marshal.c: (_dbus_marshal_string),
3853 (_dbus_demarshal_double), (_dbus_demarshal_int32),
3854 (_dbus_demarshal_uint32), (_dbus_demarshal_string),
3855 (_dbus_marshal_test):
3856 Make the demarshalling routines align the pos argument.
3857 Add string marshalling tests and fix the obvious bugs
3860 2002-12-26 Havoc Pennington <hp@pobox.com>
3862 * dbus/dbus-auth.c: fixes fixes fixes
3864 * dbus/dbus-transport-unix.c: wire up support for
3865 encoding/decoding data on the wire
3867 * dbus/dbus-auth.c (_dbus_auth_encode_data)
3868 (_dbus_auth_decode_data): append to target string
3869 instead of nuking it.
3871 2002-12-26 Havoc Pennington <hp@pobox.com>
3873 * dbus/dbus-marshal.h (DBUS_COMPILER_BYTE_ORDER): #ifdef
3874 WORDS_BIGENDIAN then compiler byte order is DBUS_BIG_ENDIAN,
3877 * dbus/dbus-marshal.c: Add macros to do int swapping in-place and
3878 avoid swap_bytes() overhead (ignoring possible assembly stuff for
3879 now). Main point is because I wanted unpack_uint32 to implement
3881 (_dbus_verbose_bytes): new function
3883 * dbus/dbus-string.c (_dbus_string_validate_ascii): new function
3885 * dbus/dbus-message.c (_dbus_message_loader_get_is_corrupted): add
3886 mechanism to handle a corrupt message stream
3887 (_dbus_message_loader_new): fix preallocation to only prealloc,
3890 * dbus/dbus-string.c (_dbus_string_skip_blank): fix this function
3891 (_dbus_string_test): enhance tests for copy/move and fix the
3894 * dbus/dbus-transport-unix.c: Hold references in more places to
3895 avoid reentrancy problems
3897 * dbus/dbus-transport.c: ditto
3899 * dbus/dbus-connection.c (dbus_connection_dispatch_message): don't
3900 leak reference count in no-message case
3902 * test/watch.c (do_mainloop): handle adding/removing watches
3903 during iteration over the watches. Also, ref the connection/server
3904 stored on a watch, so we don't try to mangle a destroyed one.
3906 * dbus/dbus-transport-unix.c (do_authentication): perform
3909 * dbus/dbus-auth.c (get_state): add a state
3910 AUTHENTICATED_WITH_UNUSED_BYTES and return it if required
3911 (_dbus_auth_get_unused_bytes): append the unused bytes
3912 to the passed in string, rather than prepend
3914 * dbus/dbus-transport.c (_dbus_transport_init_base): create
3915 the auth conversation DBusAuth
3917 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_fd)
3918 (_dbus_transport_new_for_domain_socket): when creating a
3919 transport, pass in whether it's a client-side or server-side
3920 transport so we know which DBusAuth to create
3922 2002-12-03 Havoc Pennington <hp@pobox.com>
3924 * dbus/dbus-transport-unix.c (unix_finalize): finalize base
3925 _after_ finalizing the derived members
3926 (unix_connection_set): unref watch if we fail to add it
3928 * dbus/dbus-connection.c (dbus_connection_unref): delete the
3929 transport first, so that the connection owned by the
3930 transport will be valid as the transport finalizes.
3932 * dbus/dbus-transport-unix.c (unix_finalize): free the write_watch
3933 if necessary, and remove watches from the connection.
3935 * dbus/dbus-watch.c (_dbus_watch_list_free): improve a comment
3937 2002-12-26 Anders Carlsson <andersca@codefactory.se>
3939 * dbus/dbus-marshal.c: (_dbus_marshal_string),
3940 (_dbus_demarshal_double), (_dbus_demarshal_int32),
3941 (_dbus_demarshal_uint32), (_dbus_demarshal_string),
3942 (_dbus_marshal_test):
3943 * dbus/dbus-marshal.h:
3944 Add string marshal functions and have the demarshal functions
3945 return the new position.
3947 2002-12-25 Havoc Pennington <hp@pobox.com>
3949 * doc/dbus-sasl-profile.txt: docs on the authentication protocol,
3950 it is a simple protocol that just maps directly to SASL.
3952 * dbus/dbus-auth.h, dbus/dbus-auth.c: authentication protocol
3953 initial implementation, not actually used yet.
3955 * dbus/dbus-string.c (_dbus_string_find): new function
3956 (_dbus_string_equal): new function
3957 (_dbus_string_base64_encode): new function
3958 (_dbus_string_base64_decode): new function
3960 2002-12-25 Anders Carlsson <andersca@codefactory.se>
3963 * dbus/dbus-marshal.c: (swap_bytes), (_dbus_marshal_double),
3964 (_dbus_marshal_int32), (_dbus_marshal_uint32),
3965 (_dbus_demarshal_double), (_dbus_demarshal_int32),
3966 (_dbus_demarshal_uint32), (_dbus_marshal_test):
3967 * dbus/dbus-marshal.h:
3968 * dbus/dbus-protocol.h:
3969 * dbus/dbus-test.c: (main):
3971 Add un-optimized marshalling/demarshalling routines.
3973 2002-12-25 Harri Porten <porten@kde.org>
3975 * qt/dbus-qt.h: adjusted ctor and getter to KDE/Qt conventions
3977 2002-12-24 Zack Rusin <zack@kde.org>
3979 * qt/dbus-qthread.cc: adding - integrates QMutex into Dbus
3980 * qt/dbus-qt.h: skeleton with two sample implemenatation of the
3983 2002-12-24 Havoc Pennington <hp@pobox.com>
3985 * glib/dbus-gthread.c: fix include
3987 * glib/dbus-glib.h: rename DBusMessageHandler for now.
3988 I think glib API needs to change, though, as you don't
3989 want to use DBusMessageFunction, you want to use the
3990 DBusMessageHandler object. Probably
3991 dbus_connection_open_with_g_main_loop()
3992 and dbus_connection_setup_g_main_loop() or something like that
3993 (but think of better names...) that just create a connection
3994 that has watch/timeout functions etc. already set up.
3996 * dbus/dbus-connection.c
3997 (dbus_connection_send_message_with_reply): new function just to
3998 show how the message handler helps us deal with replies.
4000 * dbus/dbus-list.c (_dbus_list_remove_last): new function
4002 * dbus/dbus-string.c (_dbus_string_test): free a string that
4005 * dbus/dbus-hash.c: use memory pools for the hash entries
4006 (rebuild_table): be more paranoid about overflow, and
4007 shrink table when we can
4008 (_dbus_hash_test): reduce number of sprintfs and write
4009 valid C89. Add tests for case where we grow and then
4010 shrink the hash table.
4012 * dbus/dbus-mempool.h, dbus/dbus-mempool.c: memory pools
4014 * dbus/dbus-connection.c (dbus_connection_register_handler)
4015 (dbus_connection_unregister_handler): new functions
4017 * dbus/dbus-message.c (dbus_message_get_name): new
4019 * dbus/dbus-list.c: fix docs typo
4021 * dbus/dbus-message-handler.h, dbus/dbus-message-handler.c:
4022 an object representing a handler for messages.
4024 2002-12-16 Anders Carlsson <andersca@codefactory.se>
4027 * glib/dbus-gthread.c: (dbus_gthread_init):
4028 Don't use the gdbus prefix for public functions.
4030 2002-12-16 Anders Carlsson <andersca@codefactory.se>
4034 Add GLib checks and fixup .pc files
4038 * glib/dbus-gmain.c: (gdbus_connection_prepare),
4039 (gdbus_connection_check), (gdbus_connection_dispatch),
4040 (gdbus_add_connection_watch), (gdbus_remove_connection_watch),
4041 (dbus_connection_gsource_new):
4042 * glib/dbus-gthread.c: (dbus_gmutex_new), (dbus_gmutex_free),
4043 (dbus_gmutex_lock), (dbus_gmutex_unlock), (dbus_gthread_init):
4044 * glib/test-dbus-glib.c: (message_handler), (main):
4047 2002-12-15 Harri Porten <porten@kde.org>
4049 * autogen.sh: check for libtoolize before attempting to use it
4051 * dbus/dbus-transport-unix.c: include <sys/time.h> for timeval
4054 * .cvsignore: ignore more stamp files
4056 * dbus/dbus-watch.c (_dbus_watch_list_new): fixed doc error
4058 * test/Makefile.am: added -I$(top_srcdir) to be able to compile
4059 without make install.
4061 2002-12-15 Havoc Pennington <hp@pobox.com>
4063 * dbus/dbus-threads.c: add thread stubs that a higher library
4064 layer can fill in. e.g. the GLib wrapper might fill them in with
4065 GThread stuff. We still need to use this thread API to
4066 thread-safe-ize the library.
4068 2002-12-12 Havoc Pennington <hp@pobox.com>
4070 * dbus/dbus-transport-unix.c, dbus/dbus-server-unix.c: use the
4071 below new interfaces and include fewer system headers.
4073 * dbus/dbus-sysdeps.c (_dbus_read): new function
4074 (_dbus_write): new function
4075 (_dbus_write_two): new function
4076 (_dbus_connect_unix_socket): new function
4077 (_dbus_listen_unix_socket): new function
4079 * dbus/dbus-message-internal.h: change interfaces to use
4082 2002-12-11 Havoc Pennington <hp@pobox.com>
4084 * dbus/dbus-types.h: add dbus_unichar
4086 * dbus/dbus-internals.c (_dbus_verbose): use _dbus_getenv
4088 * dbus/dbus-connection.c (dbus_connection_send_message): return
4091 * dbus/dbus-transport.c: include dbus-watch.h
4093 * dbus/dbus-connection.c: include dbus-message-internal.h
4095 * HACKING: add file with coding guidelines stuff.
4097 * dbus/dbus-string.h, dbus/dbus-string.c: Encapsulate all string
4098 handling here, for security purposes (as in vsftpd). Not actually
4099 using this class yet.
4101 * dbus/dbus-sysdeps.h, dbus/dbus-sysdeps.c: Encapsulate all
4102 system/libc usage here, as in vsftpd, for ease of auditing (and
4103 should also simplify portability). Haven't actually moved all the
4104 system/libc usage into here yet.
4106 2002-11-25 Havoc Pennington <hp@pobox.com>
4108 * dbus/dbus-internals.c (_dbus_verbose): fix to not
4109 always print the first verbose message.
4111 2002-11-24 Havoc Pennington <hp@pobox.com>
4113 * test/echo-client.c, test/echo-server.c: cheesy test
4116 * configure.in (AC_CHECK_FUNCS): check for writev
4118 * dbus/dbus-message.c (_dbus_message_get_network_data): new
4121 * dbus/dbus-list.c (_dbus_list_foreach): new function
4123 * dbus/dbus-internals.c (_dbus_verbose): new function
4125 * dbus/dbus-server.c, dbus/dbus-server.h: public object
4126 representing a server that listens for connections.
4128 * dbus/.cvsignore: create
4130 * dbus/dbus-errors.h, dbus/dbus-errors.c:
4131 public API for reporting errors
4133 * dbus/dbus-connection.h, dbus/dbus-connection.c:
4134 public object representing a connection that
4135 sends/receives messages. (Same object used for
4136 both client and server.)
4138 * dbus/dbus-transport.h, dbus/dbus-transport.c:
4139 Basic abstraction for different kinds of stream
4140 that we might read/write messages from.
4142 2002-11-23 Havoc Pennington <hp@pobox.com>
4144 * dbus/dbus-internals.h (_DBUS_INT_MAX): add _DBUS_INT_MIN
4147 * dbus/dbus-test.c (main): add list test, and include
4148 dbus-test.h as intended
4150 * dbus/dbus-hash.c (_dbus_hash_table_remove_string)
4151 (_dbus_hash_table_remove_int): return value indicates
4152 whether the entry existed to remove
4154 * dbus/dbus-list.c: add linked list utility class,
4157 * dbus/dbus-hash.c: add TODO item about shrinking the hash bucket
4160 2002-11-23 Havoc Pennington <hp@pobox.com>
4162 * Doxyfile.in (INCLUDE_FILE_PATTERNS): expand DBUS_BEGIN_DECLS/
4163 DBUS_END_DECLS to nothing, that should fix this once and for all
4165 * Doxyfile.in (JAVADOC_AUTOBRIEF): set to YES
4167 * dbus/dbus-message.c, dbus/dbus-hash.c:
4168 add some missing @brief
4170 2002-11-23 Havoc Pennington <hp@pobox.com>
4172 * dbus/dbus-message.h: put semicolons after DEBUG_BEGIN_DECLS
4173 to avoid confusing Doxygen
4175 * dbus/dbus-hash.c: @} not }@
4177 * dbus/dbus-message.c (struct DBusMessage): split out
4180 2002-11-23 Havoc Pennington <hp@pobox.com>
4182 * configure.in: pile on more warning flags if using gcc
4184 * Doxyfile.in (EXTRACT_STATIC): set to NO, so we don't have
4185 to document static functions
4187 * configure.in: add summary to end of configure so it
4188 looks nice and attractive
4190 * dbus/dbus-hash.c: finish implementation and write unit
4193 * configure.in: add --enable-tests to enable unit tests
4195 * dbus/dbus-test.c: test program to run unit tests
4196 for all files in dbus/*, initially runs a test for
4199 * dbus/dbus-internals.h: file to hold some internal utility stuff
4201 2002-11-22 Havoc Pennington <hp@redhat.com>
4203 * dbus/dbus-hash.c: copy in Tcl hash table, not yet
4204 "ported" away from Tcl
4206 * dbus/dbus-types.h: header for types such as dbus_bool_t
4208 2002-11-22 Havoc Pennington <hp@redhat.com>
4210 * dbus/dbus.h: fixups for doc warnings
4212 * Doxyfile.in (FILE_PATTERNS): we need to scan .h to pick up
4214 (QUIET): make it quiet so we can see warnings
4216 * dbus/dbus-memory.c: teach D-BUS to allocate and free memory
4218 2002-11-22 Havoc Pennington <hp@redhat.com>
4220 * Makefile.am: include "Doxyfile" target in all-local
4222 * configure.in: generate the Doxyfile
4224 * Doxyfile.in: move Doxyfile here, so we can use
4225 configure to generate a Doxyfile with the right
4228 2002-11-22 Havoc Pennington <hp@redhat.com>
4230 * dbus/dbus-message.c: move inline docs into .c file
4232 * Doxyfile (OUTPUT_DIRECTORY): move output to doc/api
4233 so all docs are under doc/
4234 (MAN_EXTENSION): generate man pages. Use extension
4235 ".3dbus" which matches ".3qt" on my system,
4236 I guess this is OK, I don't know really.
4237 (FILE_PATTERNS): look for .c files not .h, makes sense
4240 2002-11-22 Havoc Pennington <hp@pobox.com>
4242 * Makefile.am (SUBDIRS): rename subdir "server" to "bus"
4243 because any app can be a server, and any app can be a client,
4244 the bus is a special kind of server.
4246 Thu Nov 21 23:35:31 2002 Zack Rusin <zack@kde.org>
4248 * Doxyfile : adding. Still needs Makefile rules to be generated
4249 automatically (just run "doxygen" in the toplevel dir for now to
4252 * dbus/dbus-message.h : Adding sample docs (javadoc since
4253 resembles gtk-doc a little more)
4255 * dbus/dbus.h : Adding sample docs
4257 2002-11-21 Havoc Pennington <hp@redhat.com>
4259 * dbus/Makefile.am (INCLUDES): define DBUS_COMPILATION
4260 so we can allow ourselves to include files directly,
4261 instead of having to use dbus.h
4263 * dbus/dbus.h: fill in
4265 * dbus/dbus-message.h: sketch out a sample header file.
4266 Include griping if you include it directly instead of
4269 * dbus/dbus-macros.h: new file with macros for extern "C",
4270 TRUE/FALSE, NULL, etc.
4272 * doc/file-boilerplate.c: put include guards in here
4274 2002-11-21 Havoc Pennington <hp@redhat.com>
4276 * doc/file-boilerplate.c: include both AFL and GPL boilerplate.
4278 * COPYING: include the GPL as well, and license code
4279 under both AFL and GPL.
4281 2002-11-21 Havoc Pennington <hp@redhat.com>
4283 * acconfig.h: get rid of this
4285 * autogen.sh (run_configure): add --no-configure option
4287 * configure.in: remove AC_ARG_PROGRAM to make
4288 autoconf complain less. add AC_PREREQ.
4289 add AC_DEFINE third arg.
4291 2002-11-21 Anders Carlsson <andersca@codefactory.se>
4294 Fix references so we can distcheck.
4296 2002-11-21 Havoc Pennington <hp@redhat.com>
4298 * Initial module creation