1 2004-04-12 Jon Trowbridge <trow@ximian.com>
3 * bus/config-parser.c (struct BusConfigParser): Added
5 (seen_include): Added. Checks whether or not a file has already
6 been included by any parent BusConfigParser.
7 (bus_config_parser_new): Copy the parent's included_files.
8 (include_file): Track which files have been included, and fail on
10 (process_test_valid_subdir): Changed printf to report if we are
11 testing valid or invalid conf files.
12 (all_are_equiv): Changed printf to be a bit clearer about
13 what we are actually doing.
14 (bus_config_parser_test): Test invalid configuration files.
16 2004-04-09 Jon Trowbridge <trow@ximian.com>
18 * bus/config-parser.c (bus_config_parser_new): Added a 'parent'
19 argument. If non-null, the newly-constructed BusConfigParser will
20 be initialized with the parent's BusLimits instead of the default
22 (include_file): When including a config file, pass in
23 the current parser as the parent and then copy the BusLimits
24 from the included BusConfigParser pack to the current parser.
25 (process_test_valid_subdir): Renamed from process_test_subdir.
26 (process_test_equiv_subdir): Added. Walks through a directory,
27 descending into each subdirectory and loading the config files
28 it finds there. If any subdirectory contains two config files
29 that don't produce identical BusConfigParser structs, fail.
30 For now, the BusConfigParser's BusPolicies are not compared.
31 (bus_config_parser_test): Call both process_test_valid_subdir and
32 process_test_equiv_subdir.
34 * bus/config-loader-libxml.c (bus_config_load): Take a parent
35 argument and pass it along to the call to bus_config_parser_new.
36 Also made a few small changes to allow this code to compile.
38 * bus/config-loader-expat.c (bus_config_load): Take a parent
39 argument and pass it along to the call to bus_config_parser_new.
41 * bus/bus.c (bus_context_new): Load the config file
42 with a NULL parent argument.
44 2004-03-29 Michael Meeks <michael@ximian.com>
46 * glib/dbus-gobject.c (set_object_property): split out /
47 re-work, use the property type, and not the message type(!)
48 (get_object_property): ditto.
50 * glib/dbus-gvalue.c (dbus_gvalue_demarshal),
51 (dbus_gvalue_marshal): make this code re-usable, needed
52 for signals too, also on both proxy and server side.
53 Re-write for more efficiency / readability.
55 2004-03-29 Michael Meeks <michael@ximian.com>
58 (dbus_message_new_error_printf): impl.
60 * dbus/dbus-connection.c
61 (dbus_connection_unregister_object_path): fix warning.
63 * configure.in: fix no-mono-installed situation.
65 2004-03-27 Havoc Pennington <hp@redhat.com>
67 Patch from Timo Teräs:
69 * tools/dbus-send.c (main): if --print-reply, assume type is
70 method call; support boolean type args
72 * dbus/dbus-connection.c (dbus_connection_send_with_reply): fix a
73 bunch of memleak and logic bugs
75 2004-03-23 Owen Fraser-Green <owen@discobabe.net>
78 * mono/Introspector.cs:
80 * mono/InterfaceProxy.cs:
82 * mono/ProxyBuilder.cs:
84 Added InterfaceProxy class to avoid building proxies for every
88 * dbus-message.c (dbus_message_append_args_valist)
89 (dbus_message_iter_get_object_path)
90 (dbus_message_iter_get_object_path_array)
91 (dbus_message_iter_append_object_path)
92 (dbus_message_iter_append_object_path_array):
93 Added object_path iter functions to handle OBJECT_PATH arguments
95 2004-03-23 Owen Fraser-Green <owen@discobabe.net>
97 First checkin of mono bindings.
100 Build stuff for the bindings
101 * dbus-sharp.pc.in: Added for pkgconfig
103 2004-03-21 Havoc Pennington <hp@redhat.com>
105 * test/test-service.c (main): remove debug spew
107 2004-03-21 Olivier Andrieu <oliv__a@users.sourceforge.net>
109 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): accept empty
112 * dbus/dbus-message.h, bus/dbus-message.c (dbus_message_iter_init)
113 (dbus_message_iter_init_array_iterator)
114 (dbus_message_iter_init_dict_iterator): return a dbus_bool_t to
115 indicate whether the iterator is empty
117 * dbus/dbus-pending-call.c, dbus/dbus-server.c: silence compiler
120 2004-03-19 Havoc Pennington <hp@redhat.com>
126 * doc/Makefile.am: add all XMLTO usage to DBUS_XML_DOCS_ENABLED
128 * python/Makefile.am: change to avoid dist of dbus_bindings.c so
129 you don't need pyrex to make dist
131 * qt/Makefile.am (libdbus_qt_1_la_SOURCES): add integrator.h to
134 2004-03-18 Richard Hult <richard@imendio.com>
136 * dbus/dbus-message.c (dbus_message_get_auto_activation)
137 (dbus_message_set_auto_activation): Add doxygen docs.
139 2004-03-16 Richard Hult <richard@imendio.com>
141 * bus/activation.c: (bus_activation_service_created),
142 (bus_activation_send_pending_auto_activation_messages),
143 (bus_activation_activate_service):
145 * bus/dispatch.c: (bus_dispatch),
146 (check_nonexistent_service_auto_activation),
147 (check_service_auto_activated),
148 (check_segfault_service_auto_activation),
149 (check_existent_service_auto_activation), (bus_dispatch_test):
150 * bus/driver.c: (bus_driver_handle_activate_service):
151 * bus/services.c: (bus_registry_acquire_service):
152 * dbus/dbus-message.c: (dbus_message_set_auto_activation),
153 (dbus_message_get_auto_activation):
154 * dbus/dbus-message.h:
155 * dbus/dbus-protocol.h: Implement auto-activation.
157 * doc/dbus-specification.xml: Add auto-activation to the spec.
159 2004-03-12 Olivier Andrieu <oliv__a@users.sourceforge.net>
161 * dbus/dbus-marshal.c (_dbus_marshal_get_arg_end_pos):
162 fix a bug with CUSTOM types.
164 * dbus/dbus-message.c (message_iter_test, _dbus_message_test): add
165 a unit test for this bug (used to fail).
167 2004-03-12 Mikael Hallendal <micke@imendio.com>
170 (babysitter_watch_callback): notify all pending activations waiting for
171 the same exec that the activation failed.
172 (bus_activation_activate_service): shortcut the activation if we
173 already waiting for the same executable to start up.
175 2004-03-12 Mikael Hallendal <micke@imendio.com>
178 - Added service file reloading.
179 Each service files directory is kept in an hash table in
180 BusActivation and each BusActivationEntry knows what .service-file it
181 was read from. So when you try to activate a service the bus will
182 check if it's been updated, removed or if new .service-files has
184 - Test code at the bottom for the service file reloading.
185 * bus/test-main.c: (main):
187 - added service reloading test.
188 * dbus/dbus-sysdeps.c:
189 * dbus/dbus-sysdeps.h: (_dbus_delete_directory): Added.
191 2004-03-08 Michael Meeks <michael@ximian.com>
193 * dbus/dbus-connection.c (_dbus_connection_block_for_reply):
194 bail immediately if disconnected, to avoid busy loop.
196 * dbus/dbus-message.c (dbus_message_iter_get_args_valist):
197 cleanup cut/paste/inefficiency.
199 2004-03-01 David Zeuthen <david@fubar.dk>
201 * dbus/dbus-string.c (_dbus_string_append_printf_valist): Fix a
202 bug where args were used twice. This bug resulted in a segfault
203 on a Debian/PPC system when starting the messagebus daemon. Include
204 dbus-sysdeps.h for DBUS_VA_COPY
206 * dbus/dbus-sysdeps.h: Define DBUS_VA_COPY if neccessary. From GLib
208 * configure.in: Check for va_copy; define DBUS_VA_COPY to the
209 appropriate va_copy implementation. From GLib
211 2004-02-24 Joe Shaw <joe@ximian.com>
213 * bus/services.c (bus_registry_acquire_service): We need to pass
214 in the service name to dbus_set_error() to prevent a crash.
216 2003-12-26 Anders Carlsson <andersca@gnome.org>
218 * AUTHORS: Reveal my True identity.
220 2003-12-17 Mikael Hallendal <micke@imendio.com>
222 * dbus/dbus-message.c: (dbus_message_append_args_valist):
223 - Added case for DBUS_TYPE_BYTE, patch from Johan Hedberg.
225 2003-12-13 Mikael Hallendal <micke@imendio.com>
227 * doc/TODO: Added not about better error check of configuration files.
229 2003-12-02 Richard Hult <richard@imendio.com>
231 * Update AFL version to 2.0 throughout the source files to reflect
232 the update that was done a while ago.
234 2003-12-02 Richard Hult <richard@imendio.com>
236 * dbus/dbus-message.c (dbus_message_iter_append_dict): Set
237 wrote_dict_key to FALSE on the iter that the dict is appended to,
238 just like when appending other types. Fixes a bug where a dict
239 couldn't be put inside a dict.
240 (dbus_message_iter_append_dict_key): Fix typo in warning message.
241 (message_iter_test, _dbus_message_test): Add test case for dict
244 2003-12-01 David Zeuthen <david@fubar.dk>
246 * python/dbus.py: Add the actual message when calling the reciever
247 of a signal such that parameters can be inspected. Add the method
248 remove_signal_receiver
250 2003-11-26 Mikael Hallendal <micke@imendio.com>
254 * glib/*.[ch]: Made ref functions return the pointer
256 2003-11-25 Zack Rusin <zack@kde.org>
258 * qt/integrator.h, qt/integrator.cpp: Adding handling of DBusServer,
260 * qt/server.h, qt/server.cpp, qt/Makefile.am: Adding DBusServer
263 * qt/connection.h, qt/connection.cpp: Adjusting to changes in
264 the Integrator and to better fit with the server,
266 2003-11-24 Zack Rusin <zack@kde.org>
268 * qt/connection.h, qt/connection.cpp: removing initDbus method since
269 the integrator handles it now
271 * qt/integrator.h, qt/integrator.cpp: reworking handling of timeouts,
272 since QTimer wasn't really meant to be used the way DBusTimeout is
274 2003-11-24 Zack Rusin <zack@kde.org>
276 * qt/integrator.h, qt/integrator.cpp, Makefile.am: Adding
277 Integrator class which integrates D-BUS with the Qt event loop,
279 * qt/connection.h, qt/connection.cpp: Move all the code which
280 was dealing with D-BUS integration to the Integrator class,
281 and start using Integrator,
283 2003-11-23 Zack Rusin <zack@kde.org>
285 * qt/connection.h, qt/connection.cpp: Adding the DBusConnection
288 * qt/message.h, qt/message.cpp: updating to the current D-BUS api,
289 switching namespaces to DBusQt, reworking the class,
291 * Makefile.cvs: switching dependencies so that it matches KDE
294 * qt/Makefile.am: adding connection.{h,cpp} and message.{h,cpp} to
297 2003-11-19 Havoc Pennington <hp@redhat.com>
301 * configure.in: bump version to 0.20
303 * configure.in (have_qt): add yet another place to look for qt
304 (someone hand trolltech a .pc file...)
306 2003-11-01 Havoc Pennington <hp@redhat.com>
308 * doc/dbus-specification.xml: add state machine docs on the auth
309 protocol; just a first draft, I'm sure it's wrong.
311 2003-10-28 David Zeuthen <david@fubar.dk>
313 * python/dbus_bindings.pyx.in: add get_dict to handle dictionaries
314 return types. Fixup TYPE_* to reflect changes in dbus/dbus-protocol.h
316 2003-10-28 Havoc Pennington <hp@redhat.com>
318 * dbus/dbus-message.c (get_next_field): delete unused function
320 2003-10-28 Havoc Pennington <hp@redhat.com>
322 * bus/expirelist.c (do_expiration_with_current_time): detect
323 failure of the expire_func due to OOM
325 * bus/connection.c (bus_pending_reply_expired): return FALSE on OOM
327 * bus/dispatch.c (check_send_exit_to_service): fix to handle the
328 NoReply error that's now created by the bus when the service exits
330 2003-10-28 Havoc Pennington <hp@redhat.com>
332 * dbus/dbus-message.c (_dbus_message_test): enable and fix the
333 tests for set_path, set_interface, set_member, etc.
335 * dbus/dbus-string.c (_dbus_string_insert_bytes): allow 0 bytes
337 * dbus/dbus-message.c (set_string_field): always just delete and
338 re-append the field; accept NULL for deletion
339 (re_align_fields_recurse): reimplement
341 2003-10-26 Havoc Pennington <hp@redhat.com>
343 * dbus/dbus-connection.c: fix docs to properly describe the
345 (_dbus_connection_notify_disconnected): remove this function;
346 we can't synchronously add the disconnected message, we have to
347 do it after we've queued any remaining real messages
348 (_dbus_connection_get_dispatch_status_unlocked): queue the
349 disconnect message only if the transport has finished queueing all
350 its real messages and is disconnected.
351 (dbus_connection_disconnect): update the dispatch status here
353 2003-10-22 Havoc Pennington <hp@redhat.com>
355 * bus/bus.c (bus_context_check_security_policy): fix up assertion
357 * bus/connection.c (bus_transaction_send_from_driver): set the
358 destination to the connection's base service
360 2003-10-20 Havoc Pennington <hp@redhat.com>
362 hmm, make check is currently not passing.
364 * doc/dbus-specification.xml: add requirement that custom type
365 names follow the same rules as interface names.
367 * dbus/dbus-protocol.h: change some of the byte codes, to avoid
368 duplication and allow 'c' to be 'custom'; dict is now 'm' for
371 * doc/dbus-specification.xml: update type codes to match
372 dbus-protocol.h, using the ASCII byte values. Rename type NAMED to
373 CUSTOM. Add type OBJECT_PATH to the spec.
375 2003-10-17 Havoc Pennington <hp@redhat.com>
377 * bus/driver.c (create_unique_client_name): use "." as separator
378 in base service names instead of '-'
380 * dbus/dbus-string.c (_dbus_string_get_byte): allow getting nul
381 byte at the end of the string
383 * dbus/dbus-internals.h (_DBUS_LIKELY, _DBUS_UNLIKELY): add
384 optimization macros since string validation seems to be a slow
387 * doc/dbus-specification.xml: restrict valid
388 service/interface/member/error names. Add test suite code for the
391 * dbus/dbus-string.c: limit service/interface/member/error names
394 * dbus/dbus-connection.c (dbus_connection_dispatch): add missing
395 format arg to verbose spew
397 * glib/dbus-gproxy.c (dbus_gproxy_call_no_reply): if not out of
398 memory, return instead of g_error
400 * test/test-service.c (path_message_func): support emitting a
403 * dbus/dbus-bus.c (init_connections_unlocked): only fill in
404 activation bus type if DBUS_BUS_ACTIVATION was set; default to
405 assuming the activation bus was the session bus so that services
406 started manually will still register.
407 (init_connections_unlocked): fix so that in OOM situation we get
408 the same semantics when retrying the function
410 * test/test-service.c (main): change to use path registration, to
411 test those codepaths; register with DBUS_BUS_ACTIVATION rather
412 than DBUS_BUS_SESSION
414 2003-10-16 Havoc Pennington <hp@redhat.com>
416 * glib/dbus-gtest-main.c: bracket with #ifdef DBUS_BUILD_TESTS
418 * Makefile.am (GCOV_DIRS): remove "test", we don't care about test
419 coverage of the tests
420 (coverage-report.txt): don't move the .da and .bbg files around
422 2003-10-16 Havoc Pennington <hp@redhat.com>
424 * bus/bus.c (struct BusContext): remove struct field I didn't mean
427 2003-10-16 Havoc Pennington <hp@redhat.com>
429 * bus/connection.c (bus_pending_reply_expired): either cancel or
431 (bus_connections_check_reply): use unlink, not remove_link, as we
432 don't want to free the link; fixes double free mess
434 * dbus/dbus-pending-call.c (dbus_pending_call_block): fix in case
435 where no reply was received
437 * dbus/dbus-connection.c (_dbus_pending_call_complete_and_unlock):
440 * bus/signals.c (match_rule_matches): add special cases for the
441 bus driver, so you can match on sender/destination for it.
443 * dbus/dbus-sysdeps.c (_dbus_abort): print backtrace if
444 DBUS_PRINT_BACKTRACE is set
446 * dbus/dbus-internals.c: add pid to assertion failure messages
448 * dbus/dbus-connection.c: add message type code to the debug spew
450 * glib/dbus-gproxy.c (gproxy_get_match_rule): match rules want
451 sender=foo not service=foo
453 * dbus/dbus-bus.c (dbus_bus_get): if the activation bus is the
454 session bus but DBUS_SESSION_BUS_ADDRESS isn't set, use
455 DBUS_ACTIVATION_ADDRESS instead
457 * bus/activation.c: set DBUS_SESSION_BUS_ADDRESS,
458 DBUS_SYSTEM_BUS_ADDRESS if appropriate
460 * bus/bus.c (bus_context_new): handle OOM copying bus type into
463 * dbus/dbus-message.c (dbus_message_iter_get_object_path): new function
464 (dbus_message_iter_get_object_path_array): new function (half
465 finished, disabled for the moment)
467 * glib/dbus-gproxy.c (dbus_gproxy_end_call): properly handle
468 DBUS_MESSAGE_TYPE_ERROR
470 * tools/dbus-launch.c (babysit): support DBUS_DEBUG_OUTPUT to
471 avoid redirecting stderr to /dev/null
472 (babysit): close stdin if not doing the "exit_with_session" thing
474 * dbus/dbus-sysdeps.c (_dbus_become_daemon): delete some leftover
475 debug code; change DBUS_DEBUG_OUTPUT to only enable stderr, not
476 stdout/stdin, so things don't get confused
478 * bus/system.conf.in: fix to allow replies, I modified .conf
479 instead of .conf.in again.
481 2003-10-14 David Zeuthen <david@fubar.dk>
483 * python/dbus_bindings.pyx.in (MessageIter.get): fixed typo in
484 argtype to arg_type when raising unknown arg type exception.
485 Changed type list to reflect the changes in dbus-protocol.h so
486 the bindings actually work.
488 2003-10-14 Havoc Pennington <hp@redhat.com>
490 * test/decode-gcov.c: support gcc 3.3 also, though gcc 3.3 seems
491 to have a bug keeping it from outputting the .da files sometimes
492 (string_get_string): don't append garbage nul bytes to the string.
494 2003-10-15 Seth Nickell <seth@gnome.org>
496 * python/Makefile.am:
498 Include dbus_h_wrapper.h in the dist tarball.
500 2003-10-14 Havoc Pennington <hp@redhat.com>
502 * bus/bus.c (bus_context_check_security_policy): revamp this to
503 work more sanely with new policy-based requested reply setup
505 * bus/connection.c (bus_transaction_send_from_driver): set bus
506 driver messages as no reply
508 * bus/policy.c (bus_client_policy_check_can_receive): handle a
509 requested_reply attribute on allow/deny rules
511 * bus/system.conf: add <allow requested_reply="true"/>
513 * bus/driver.c (bus_driver_handle_message): fix check for replies
514 sent to the bus driver, which was backward. How did this ever work
515 at all though? I think I'm missing something.
517 * dbus/dbus-message.c (decode_header_data): require error and
518 method return messages to have a reply serial field to be valid
519 (_dbus_message_loader_queue_messages): break up this function;
520 validate that reply serial and plain serial are nonzero;
521 clean up the OOM/error handling.
522 (get_uint_field): don't return -1 from this
523 (dbus_message_create_header): fix signed/unsigned bug
525 * bus/connection.c (bus_connections_expect_reply): save serial of
526 the incoming message, not reply serial
528 2003-10-14 Havoc Pennington <hp@redhat.com>
530 * bus/connection.c: implement pending reply tracking using
533 * bus/bus.c (bus_context_check_security_policy): verify that a
534 reply is pending in order to allow a reply to be sent. Deny
535 messages of unknown type.
537 * bus/dbus-daemon-1.1.in: update to mention new resource limits
539 * bus/bus.c (bus_context_get_max_replies_per_connection): new
540 (bus_context_get_reply_timeout): new
542 2003-10-13 Seth Nickell <seth@gnome.org>
544 * python/Makefile.am:
546 Pass "make distcheck": remove a couple files from DIST_FILES
547 that weren't included in the final version.
549 2003-10-12 Havoc Pennington <hp@pobox.com>
551 Added test code that 1) starts an actual bus daemon and 2) uses
552 DBusGProxy; fixed bugs that were revealed by the test. Lots
553 more testing possible, but this is the basic framework.
555 * glib/dbus-gproxy.c (dbus_gproxy_manager_unregister): remove
556 empty proxy lists from the proxy list hash
558 * dbus/dbus-message.c (dbus_message_iter_get_args_valist): add a
559 couple of return_if_fail checks
561 * dbus/dbus-pending-call.c (_dbus_pending_call_new): use dbus_new0
562 to allocate, so everything is cleared to NULL as it should be.
564 * glib/dbus-gmain.c (dbus_connection_setup_with_g_main): pass
565 source as data to dbus_connection_set_timeout_functions() as the
566 timeout functions expected
568 * test/glib/run-test.sh: add a little script to start up a message
569 bus and run tests using it
571 * tools/dbus-launch.1: updates
573 * tools/dbus-launch.c (main): add --config-file option
575 * tools/dbus-launch.c (main): remove confusing else if (runprog)
576 that could never be reached.
578 * dbus/dbus-message.c (dbus_message_new_method_return)
579 (dbus_message_new_error, dbus_message_new_signal): set the
580 no-reply-expected flag on all these. Redundant, but may
581 as well be consistent.
583 2003-10-11 Havoc Pennington <hp@pobox.com>
585 * test/decode-gcov.c (function_solve_graph): make broken block
586 graph a nonfatal error since it seems to be broken. Need to debug
589 * dbus/dbus-marshal.c (_dbus_type_is_valid): new function since we
590 can't just check type > INVALID < LAST anymore
592 * dbus/dbus-message.c (dbus_message_get_signature): new function
593 (dbus_message_has_signature): new function
594 (struct DBusMessage): add signature field (right now it isn't sent
595 over the wire, just generated on the fly)
596 (dbus_message_copy): copy the signature, and init strings to
597 proper length to avoid some reallocs
598 (dbus_message_iter_init_array_iterator): return void, since it
600 (dbus_message_iter_init_dict_iterator): return void since it can't fail
601 (_dbus_message_loader_queue_messages): add silly temporary hack to
602 fill in message->signature on load
604 * dbus/dbus-protocol.h: change DBUS_TYPE_* values to be ASCII
605 characters, so they are relatively human-readable.
607 2003-10-11 Havoc Pennington <hp@pobox.com>
609 * dbus/dbus-message.c (_dbus_message_test): add more test
610 coverage, but #if 0 for now since they uncover a bug
611 not fixed yet; I think in re_align_field_recurse()
612 (re_align_field_recurse): add FIXME about broken assertion
614 * dbus/dbus-sysdeps.c (_dbus_sysdeps_test): add more test coverage
616 * bus/connection.c: share a couple code bits with expirelist.c
618 * bus/expirelist.h, bus/expirelist.c: implement a generic
619 expire-items-after-N-seconds facility, was going to share between
620 expiring connections and replies, decided not to use for expiring
623 * COPYING: include AFL 2.0 (still need to change all the file headers)
625 2003-10-09 Havoc Pennington <hp@redhat.com>
627 * configure.in: define DBUS_HAVE_GCC33_GCOV if we have
628 gcc 3.3. Not that we do anything about it yet.
630 * bus/signals.c (bus_match_rule_parse): impose max length on the
633 * dbus/dbus-protocol.h: add DBUS_MAXIMUM_MATCH_RULE_LENGTH
635 2003-10-09 Havoc Pennington <hp@redhat.com>
637 Make matching rules theoretically work (add parser).
639 * bus/bus.c (bus_context_check_security_policy): fix up to handle
640 the case where destination is explicitly specified as bus driver
641 and someone else is eavesdropping.
643 * bus/policy.c (bus_client_policy_check_can_receive): fix up
644 definition of eavesdropping and assertion
646 * tools/dbus-send.c (main): use dbus_message_type_from_string
648 * bus/signals.c (bus_match_rule_parse): implement
650 * dbus/dbus-message.c (dbus_message_type_from_string): new
652 * dbus/dbus-errors.h (DBUS_ERROR_MATCH_RULE_INVALID): add
654 2003-10-02 Havoc Pennington <hp@pobox.com>
656 * glib/dbus-gproxy.c (dbus_gproxy_call_no_reply): rename from
657 dbus_gproxy_oneway_call
659 * glib/dbus-gmain.c (dbus_connection_setup_with_g_main)
660 (dbus_server_setup_with_g_main): fix to allow calling them more
661 than once on the same args
662 (dbus_bus_get_with_g_main): new function
664 2003-10-02 Havoc Pennington <hp@redhat.com>
666 * doc/dbus-tutorial.xml: write some stuff
668 2003-09-29 Havoc Pennington <hp@pobox.com>
670 * configure.in: split checks for Doxygen from XML docs, check for
673 * doc/Makefile.am: XML-ify all the docs, and add a blank
676 2003-09-29 Havoc Pennington <hp@pobox.com>
678 * Merge dbus-object-names branch. To see the entire patch
679 do cvs diff -r DBUS_OBJECT_NAMES_BRANCHPOINT -r dbus-object-names,
681 To revert, I tagged DBUS_BEFORE_OBJECT_NAMES_MERGE.
683 2003-09-28 Havoc Pennington <hp@pobox.com>
685 * HACKING: update to reflect new server
687 2003-09-26 Seth Nickell <seth@gnome.org>
690 * python/examples/example-signals.py:
692 Start implementing some notions of signals. The API
693 is really terrible, but they sort of work (with the
694 exception of being able to filter by service, and to
695 transmit signals *as* a particular service). Need to
696 figure out how to make messages come from the service
699 * python/dbus_bindings.pyx.in:
701 Removed duplicate message_handler callbacks.
703 2003-09-25 Havoc Pennington <hp@redhat.com>
705 * bus/session.conf.in: fix my mess
707 2003-09-25 Havoc Pennington <hp@pobox.com>
709 * bus/session.conf.in: fix security policy, reported by Seth Nickell
711 2003-09-25 Seth Nickell <seth@gnome.org>
713 * python/examples/example-service.py:
715 Johan notices complete wrong code in example-service, but
716 completely wrong in a way that works exactly the same (!).
717 Johan is confused, how could this possibly work? Example
718 code fails to serve purpose of making things clear.
721 2003-09-25 Mark McLoughlin <mark@skynet.ie>
723 * doc/dbus-specification.sgml: don't require header fields
724 to be 4-byte aligned and specify that fields should be
725 distinguished from padding by the fact that zero is not
728 * doc/TODO: remove re-alignment item and add item to doc
729 the OBJECT_PATH type.
731 * dbus/dbus-message.c:
732 (HeaderField): rename the original member to value_offset
733 and introduce a name_offset member to keep track of where
734 the field actually begins.
735 (adjust_field_offsets): remove.
736 (append_int_field), (append_uint_field),
737 (append_string_field): don't align the start of the header
738 field to a 4-byte boundary.
739 (get_next_field): impl finding the next marhsalled field
741 (re_align_field_recurse): impl re-aligning a number of
742 already marshalled fields.
743 (delete_field): impl deleting a field of any type and
744 re-aligning any following fields.
745 (delete_int_or_uint_field), (delete_string_field): remove.
746 (set_int_field), (set_uint_field): no need to re-check
747 that we have the correct type for the field.
748 (set_string_field): ditto and impl re-aligning any
750 (decode_header_data): update to take into account that
751 the fields aren't 4-byte aligned any more and the new
752 way to distinguish padding from header fields. Also,
753 don't exit when there is too much header padding.
754 (process_test_subdir): print the directory.
755 (_dbus_message_test): add test to make sure a following
756 field is re-aligned correctly after field deletion.
758 * dbus/dbus-string.[ch]:
759 (_dbus_string_insert_bytes): rename from insert_byte and
760 allow the insert of multiple bytes.
761 (_dbus_string_test): test inserting multiple bytes.
763 * dbus/dbus-marshal.c: (_dbus_marshal_set_string): add
764 warning note to docs about having to re-align any
765 marshalled values following the string.
767 * dbus/dbus-message-builder.c:
768 (append_string_field), (_dbus_message_data_load):
769 don't align the header field.
771 * dbus/dbus-auth.c: (process_test_subdir): print the
774 * test/break-loader.c: (randomly_add_one_byte): upd. for
777 * test/data/invalid-messages/bad-header-field-alignment.message:
780 * test/data/valid-messages/unknown-header-field.message: shove
781 a dict in the unknown field.
783 2003-09-25 Seth Nickell <seth@gnome.org>
786 * python/dbus_bindings.pyx.in:
788 Handle return values.
790 * python/examples/example-client.py:
791 * python/examples/example-service.py:
793 Pass back return values from the service to the client.
795 2003-09-24 Seth Nickell <seth@gnome.org>
799 Connect Object methods (when you are sharing an object) up... pass
800 in a list of methods to be shared. Sharing all the methods just
801 worked out too weird. You can now create nice Services over the
804 * python/dbus_bindings.pyx.in:
806 Keep references to user_data tuples passed into C functions so
807 Python doesn't garbage collect on us.
809 Implement MethodReturn and Error subclasses of Message for creating
810 DBusMessage's of those types.
812 * python/examples/example-client.py:
813 * python/examples/example-service.py:
815 Simple example code showing both how create DBus services and objects,
818 2003-09-23 Havoc Pennington <hp@pobox.com>
820 * glib/dbus-gproxy.c (dbus_gproxy_manager_filter): implement
822 2003-09-23 Havoc Pennington <hp@redhat.com>
824 * glib/dbus-gproxy.c (dbus_gproxy_connect_signal): implement
825 (dbus_gproxy_disconnect_signal): implement
826 (dbus_gproxy_manager_remove_signal_match): implement
827 (dbus_gproxy_manager_add_signal_match): implement
828 (dbus_gproxy_oneway_call): implement
830 2003-09-23 Havoc Pennington <hp@pobox.com>
832 * glib/dbus-gproxy.c (struct DBusGProxy): convert to a GObject
833 subclass. This means dropping the transparent thread safety of the
834 proxy; you now need a separate proxy per-thread, or your own
835 locking on the proxy. Probably right anyway.
836 (dbus_gproxy_ref, dbus_gproxy_unref): nuke, just use g_object_ref
838 2003-09-22 Havoc Pennington <hp@redhat.com>
840 * glib/dbus-gproxy.c (dbus_gproxy_manager_get): implement
842 2003-09-21 Seth Nickell <seth@gnome.org>
844 First checkin of the Python bindings.
847 * python/Makefile.am:
848 * python/dbus_bindings.pyx.in:
849 * python/dbus_h_wrapper.h:
851 Pieces for Pyrex to operate on, building a dbus_bindings.so
852 python module for low-level access to the DBus APIs.
856 High-level Python module for accessing DBus objects.
861 Build stuff for the python bindings.
865 Extra macro needed for finding the Python C header files.
867 2003-09-21 Havoc Pennington <hp@pobox.com>
869 * glib/dbus-gproxy.c (dbus_gproxy_manager_new): start
870 implementing the proxy manager, didn't get very far.
872 * dbus/dbus-bus.c (dbus_bus_add_match): new
873 (dbus_bus_remove_match): new
875 * glib/dbus-gproxy.c (dbus_gproxy_new_for_service): add a
876 path_name argument; adjust the other not-yet-implemented
877 gproxy constructors to be what I think they should be.
879 2003-09-21 Havoc Pennington <hp@pobox.com>
881 * dbus/dbus-bus.c (dbus_bus_get): set exit_on_disconnect to TRUE
882 by default for message bus connections.
884 * dbus/dbus-connection.c (dbus_connection_dispatch): exit if
885 exit_on_disconnect flag is set and we process the disconnected
887 (dbus_connection_set_exit_on_disconnect): new function
889 2003-09-21 Havoc Pennington <hp@pobox.com>
891 Get matching rules mostly working in the bus; only actually
892 parsing the rule text remains. However, the client side of
893 "signal connections" hasn't been started, this patch is only the
896 * dbus/dispatch.c: fix for the matching rules changes
898 * bus/driver.c (bus_driver_handle_remove_match)
899 (bus_driver_handle_add_match): send an ack reply from these
902 * glib/dbus-gproxy.c (dbus_gproxy_begin_call): fix order of
903 arguments, reported by Seth Nickell
905 * bus/config-parser.c (append_rule_from_element): support
906 eavesdrop=true|false attribute on policies so match rules
907 can be prevented from snooping on the system bus.
909 * bus/dbus-daemon-1.1.in: consistently use terminology "sender"
910 and "destination" in attribute names; fix some docs bugs;
911 add eavesdrop=true|false attribute
913 * bus/driver.c (bus_driver_handle_add_match)
914 (bus_driver_handle_remove_match): handle AddMatch, RemoveMatch
917 * dbus/dbus-protocol.h (DBUS_SERVICE_ORG_FREEDESKTOP_BROADCAST): get
918 rid of broadcast service concept, signals are just always broadcast
920 * bus/signals.c, bus/dispatch.c, bus/connection.c, bus/bus.c:
921 mostly implement matching rules stuff (currently only exposed as signal
924 2003-09-21 Mark McLoughlin <mark@skynet.ie>
926 * doc/dbus-specification.sgml: Change the header field name
927 to be an enum and update the rest of the spec to reference
928 the fields using the conventinal name.
930 * dbus/dbus-protocol.h: update to reflect the spec.
932 * doc/TODO: add item to remove the 4 byte alignment requirement.
934 * dbus/dbus-message.c: Remove the code to generalise the
935 header/body length and serial number header fields as named
936 header fields so we can reference field names using the
938 (append_int_field), (append_uint_field), (append_string_field):
939 Append the field name as a byte rather than four chars.
940 (delete_int_or_uint_field), (delete_string_field): reflect the
941 fact that the field name and typecode now occupy 4 bytes instead
943 (decode_string_field), (decode_header_data): update to reflect
944 protocol changes and move the field specific encoding from
945 decode_string_field() back into decode_header_data().
947 * dbus/dbus-internals.[ch]: (_dbus_header_field_to_string):
948 Add utility to aid debugging.
950 * dbus/dbus-message-builder.c:
951 (append_string_field), (_dbus_message_data_load): Update to
952 reflect protocol changes; Change the FIELD_NAME directive
953 to HEADER_FIELD and allow it to take the field's conventional
954 name rather than the actual value.
956 * test/data/*/*.message: Update to use HEADER_FIELD instead
957 of FIELD_NAME; Always align the header on an 8 byte boundary
958 *before* updating the header length.
960 2003-09-15 Havoc Pennington <hp@pobox.com>
962 * dbus/dbus-pending-call.c: add the get/set object data
963 boilerplate as for DBusConnection, etc. Use generic object data
964 for the notify callback.
966 * glib/dbus-gparser.c (parse_node): parse child nodes
968 * tools/dbus-viewer.c: more hacking on the dbus-viewer
970 * glib/dbus-gutils.c (_dbus_gutils_split_path): add a file to
971 contain functions shared between the convenience lib and the
974 * glib/Makefile.am (libdbus_glib_1_la_LDFLAGS): add
975 -export-symbols-regex to the GLib library
977 * dbus/dbus-object-tree.c (_dbus_object_tree_dispatch_and_unlock):
978 fix the locking in here, and add a default handler for
979 Introspect() that just returns sub-nodes.
981 2003-09-14 Havoc Pennington <hp@pobox.com>
983 * glib/dbus-gthread.c (dbus_g_thread_init): rename to make g_foo
984 rather than gfoo consistent
986 * glib/dbus-gproxy.h: delete for now, move contents to
987 dbus-glib.h, because the include files don't work right since we
988 aren't in the dbus/ subdir.
990 * glib/dbus-gproxy.c (dbus_gproxy_send): finish implementing
991 (dbus_gproxy_end_call): finish
992 (dbus_gproxy_begin_call): finish
994 * glib/dbus-gmain.c (dbus_set_g_error): new
996 * glib/dbus-gobject.c (handle_introspect): include information
997 about child nodes in the introspection
999 * dbus/dbus-connection.c (dbus_connection_list_registered): new
1000 function to help in implementation of introspection
1002 * dbus/dbus-object-tree.c
1003 (_dbus_object_tree_list_registered_and_unlock): new function
1005 2003-09-12 Havoc Pennington <hp@pobox.com>
1007 * glib/dbus-gidl.h: add common base class for all the foo_info
1010 * tools/dbus-viewer.c: add GTK-based introspection UI thingy
1013 * test/Makefile.am: try test srcdir -ef . in addition to test
1014 srcdir = ., one of them should work (yeah lame)
1016 * glib/Makefile.am: build the "idl" parser stuff as a convenience
1019 * glib/dbus-gparser.h: make description_load routines return
1020 NodeInfo* not Parser*
1022 * Makefile.am (SUBDIRS): build test dir after all library dirs
1024 * configure.in: add GTK+ detection
1026 2003-09-07 Havoc Pennington <hp@pobox.com>
1028 * Make Doxygen contented.
1030 2003-09-07 Havoc Pennington <hp@pobox.com>
1032 * doc/dbus-specification.sgml: more updates
1034 2003-09-06 Havoc Pennington <hp@pobox.com>
1036 * doc/dbus-specification.sgml: partial updates
1038 * bus/dbus-daemon-1.1.in: fix the config file docs for the
1039 zillionth time; hopefully I edited the right file this time.
1041 * bus/config-parser.c (append_rule_from_element): support
1042 send_type, send_path, receive_type, receive_path
1044 * bus/policy.c: add message type and path to the list of things
1045 that can be "firewalled"
1047 2003-09-06 Havoc Pennington <hp@pobox.com>
1049 * dbus/dbus-connection.c (dbus_connection_register_fallback): add this
1050 (dbus_connection_register_object_path): make this not handle
1051 messages to paths below the given path
1053 2003-09-03 Havoc Pennington <hp@pobox.com>
1055 * test/glib/Makefile.am: add this with random glib-linked test
1058 * glib/Makefile.am: remove the random test programs from here,
1059 leave only the unit tests
1061 * glib/dbus-gobject.c (_dbus_gobject_test): add test for
1062 uscore/javacaps conversion, and fix
1063 (get_object_property, set_object_property): change to .NET
1064 convention for mapping props to methods, set_FooBar/get_FooBar,
1065 since one language has such a convention we may as well copy it.
1066 Plus real methods in either getFooBar or get_foo_bar style won't
1067 collide with this convention.
1069 2003-09-01 Havoc Pennington <hp@pobox.com>
1071 * glib/dbus-gparser.c: implement
1073 * glib/dbus-gobject.c: start implementing skeletons support
1075 * configure.in: when disabling checks/assert, also define
1076 G_DISABLE_ASSERT and G_DISABLE_CHECKS
1078 2003-09-01 Havoc Pennington <hp@pobox.com>
1080 * glib/Makefile.am: rearrange a bunch of files and get "make
1081 check" framework set up
1083 2003-08-31 Havoc Pennington <hp@pobox.com>
1085 * fix build with --disable-tests
1087 2003-08-30 Havoc Pennington <hp@pobox.com>
1089 * dbus/dbus-connection.c: purge DBusMessageHandler
1091 * dbus/dbus-message-handler.c: remove DBusMessageHandler, just
1092 use callbacks everywhere
1094 2003-08-30 Havoc Pennington <hp@pobox.com>
1096 * test/data/valid-config-files/system.d/test.conf: change to
1097 root for the user so warnings don't get printed
1099 * dbus/dbus-message.c: add dbus_message_get_path,
1100 dbus_message_set_path
1102 * dbus/dbus-object-tree.c (do_test_dispatch): add test of
1103 dispatching to a path
1105 * dbus/dbus-string.c (_dbus_string_validate_path): add
1107 * dbus/dbus-marshal.c (_dbus_demarshal_object_path): implement
1108 (_dbus_marshal_object_path): implement
1110 * dbus/dbus-protocol.h (DBUS_HEADER_FIELD_PATH): new header field
1111 to contain the path to the target object
1112 (DBUS_HEADER_FIELD_SENDER_SERVICE): rename
1113 DBUS_HEADER_FIELD_SENDER to explicitly say it's the sender service
1115 2003-08-30 Havoc Pennington <hp@pobox.com>
1117 * dbus/dbus-object-tree.c: write tests and fix the discovered bugs
1119 2003-08-29 Havoc Pennington <hp@pobox.com>
1121 * dbus/dbus-object-tree.c: modify to allow overlapping paths to be
1123 (struct DBusObjectSubtree): shrink this
1124 a lot, since we may have a lot of them
1125 (_dbus_object_tree_free_all_unlocked): implement
1126 (_dbus_object_tree_dispatch_and_unlock): implement
1128 2003-08-29 Havoc Pennington <hp@pobox.com>
1130 * dbus/dbus-internals.h: fix _DBUS_N_GLOBAL_LOCKS
1132 2003-08-28 Havoc Pennington <hp@pobox.com>
1136 * dbus/dbus-connection.c: port to no ObjectID, create a
1137 DBusObjectTree, rename ObjectTree to ObjectPath in public API
1139 * dbus/dbus-connection.h (struct DBusObjectTreeVTable): delete
1140 everything except UnregisterFunction and MessageFunction
1142 * dbus/dbus-marshal.c: port away from DBusObjectID,
1143 add DBUS_TYPE_OBJECT_PATH
1145 * dbus/dbus-object-registry.[hc], dbus/dbus-object.[hc],
1146 dbus/dbus-objectid.[hc]: remove these, we are moving to
1147 path-based object IDs
1149 2003-08-25 Havoc Pennington <hp@pobox.com>
1151 Just noticed that dbus_message_test is hosed, I wonder when I
1152 broke that. I thought make check was passing earlier...
1154 * dbus/dbus-object-tree.c: add new "object tree" to match DCOP
1155 container tree, will replace most of dbus-object-registry
1157 * dbus/dbus-string.c (_dbus_string_append_printf_valist): fix C99
1160 2003-08-19 Havoc Pennington <hp@pobox.com>
1162 * dbus/dbus-message.c (decode_string_field): support FIELD_SENDER
1163 (dbus_message_is_error): fix this function
1165 * bus/dbus-daemon-1.1: clarify logic on when <deny>/<allow> rules
1168 * bus/policy.c (bus_client_policy_check_can_receive): fix code to
1169 reflect clarified man page
1170 (bus_client_policy_check_can_send): ditto
1172 * bus/session.conf.in: fixup
1174 * bus/system.conf.in: fixup
1176 2003-08-18 Havoc Pennington <hp@redhat.com>
1178 * dbus/dbus-hash.c (_dbus_hash_table_insert_two_strings): fix
1180 * dbus/dbus-message.c (_dbus_message_loader_queue_messages): fix
1181 dumb bug created earlier (wrong order of args to
1182 decode_header_data())
1184 * tools/dbus-send.c: port
1186 * tools/dbus-print-message.c (print_message): port
1188 * test/data/*messages: port all messages over
1190 * dbus/dbus-message-builder.c: support including
1193 * bus/driver.c: port over
1195 * bus/dispatch.c: port over to new stuff
1197 * dbus/dbus-connection.c (_dbus_connection_new_for_transport):
1198 rename disconnect signal to "Disconnected"
1200 2003-08-17 Havoc Pennington <hp@pobox.com>
1202 This doesn't compile yet, but syncing up so I can hack on it from
1203 work. What are branches for if not broken code? ;-)
1205 * dbus/dbus-protocol.h: remove DBUS_HEADER_FIELD_NAME, add
1206 DBUS_HEADER_FIELD_INTERFACE, DBUS_HEADER_FIELD_MEMBER,
1207 DBUS_HEADER_FIELD_ERROR_NAME
1209 * dbus/dbus-hash.c: Introduce DBUS_HASH_TWO_STRINGS as hack to use
1210 for the interface+member pairs
1211 (string_hash): change to use g_str_hash algorithm
1212 (find_direct_function, find_string_function): refactor these to
1215 * dbus/dbus-message.c: port all of this over to support
1216 interface/member fields instead of name field
1218 * dbus/dbus-object-registry.c: port over
1220 * dbus/dbus-string.c (_dbus_string_validate_interface): rename
1221 from _dbus_string_validate_name
1223 * bus/dbus-daemon-1.1: change file format for the
1224 <deny>/<allow> stuff to match new message naming scheme
1226 * bus/policy.c: port over
1228 * bus/config-parser.c: parse new format
1230 2003-08-16 Havoc Pennington <hp@pobox.com>
1232 * dbus/dbus-object-registry.c (add_and_remove_objects): remove
1235 * glib/dbus-gproxy.c: some hacking
1237 2003-08-15 Havoc Pennington <hp@redhat.com>
1239 * dbus/dbus-pending-call.c (dbus_pending_call_block): implement
1241 * dbus/dbus-connection.c
1242 (dbus_connection_send_with_reply_and_block): factor out internals;
1243 change to convert any error replies to DBusError instead of
1244 returning them as a message
1246 2003-08-15 Havoc Pennington <hp@pobox.com>
1248 * dbus/dbus-connection.c,
1249 dbus/dbus-pending-call.c: Finish the pending call stuff
1251 2003-08-14 Havoc Pennington <hp@redhat.com>
1253 * dbus/dbus-pending-call.c: start on new object that will replace
1254 DBusMessageHandler and ReplyHandlerData for tracking outstanding
1257 * dbus/dbus-gproxy.c: start on proxy object used to communicate
1258 with remote interfaces
1260 * dbus/dbus-gidl.c: do the boring boilerplate in here
1262 2003-08-12 Havoc Pennington <hp@pobox.com>
1264 * bus/dispatch.c (bus_dispatch): make this return proper
1265 DBusHandlerResult to avoid DBUS_ERROR_UNKNOWN_METHOD
1267 * dbus/dbus-errors.c (dbus_set_error): use
1268 _dbus_string_append_printf_valist
1270 * dbus/dbus-string.c (_dbus_string_append_printf_valist)
1271 (_dbus_string_append_printf): new
1273 * dbus/dbus-errors.h (DBUS_ERROR_UNKNOWN_MESSAGE): change to
1276 * dbus/dbus-connection.c (dbus_connection_dispatch): handle
1277 DBUS_HANDLER_RESULT_NEED_MEMORY; send default error reply if a
1278 message is unhandled.
1280 2003-08-11 Havoc Pennington <hp@pobox.com>
1282 * bus/test.c (client_disconnect_handler): change to return
1283 HANDLED (would have been REMOVE_MESSAGE)
1285 * dbus/dbus-object.h (enum DBusHandlerResult): rename to
1286 HANDLED/NOT_YET_HANDLED instead of
1287 REMOVE_MESSAGE/ALLOW_MORE_HANDLERS to make it clearer how it
1290 2003-08-10 Havoc Pennington <hp@pobox.com>
1292 * tools/dbus-send.c (main): add --type argument, for now
1293 supporting only method_call and signal types.
1295 * tools/dbus-print-message.c: print message type
1297 * dbus/dbus-connection.c (_dbus_connection_new_for_transport):
1298 init connection->objects
1300 * doc/dbus-specification.sgml: fix sgml
1302 * bus/*.c: port over to object-instance API changes
1304 * test/test-service.c: ditto
1306 * dbus/dbus-message.c (dbus_message_create_header): allow #NULL
1307 name, we will have to fix up the rest of the code to also handle
1309 (dbus_message_new): generic message-creation call
1310 (set_string_field): allow appending name field
1312 2003-08-06 Havoc Pennington <hp@pobox.com>
1314 * dbus/dbus-object-registry.c: implement signal connection
1317 * dbus/dbus-connection.c (_dbus_connection_unref_unlocked): new
1319 * dbus/dbus-internals.c (_dbus_memdup): new function
1321 2003-08-02 Havoc Pennington <hp@pobox.com>
1323 * dbus/dbus-message.c (dbus_message_get_no_reply)
1324 (dbus_message_set_no_reply): add these and remove
1325 set_is_error/get_is_error
1327 * dbus/dbus-protocol.h, doc/dbus-specification.sgml:
1328 remove the ERROR flag, since there's now an ERROR type
1330 2003-08-01 Havoc Pennington <hp@pobox.com>
1332 * dbus/dbus-object-registry.c (_dbus_object_registry_handle_and_unlock):
1335 * dbus/dbus-message.c (dbus_message_get_type): new function
1337 * doc/dbus-specification.sgml: add "type" byte to messages
1339 2003-08-01 Havoc Pennington <hp@pobox.com>
1341 * dbus/dbus-protocol.h (DBUS_MESSAGE_TYPE_*): introduce
1342 a message type enum to distinguish kinds of message
1343 (DBUS_HEADER_FLAG_NO_REPLY_EXPECTED): flag for a message
1344 that need not be replied to
1346 2003-08-01 Havoc Pennington <hp@pobox.com>
1348 * dbus/dbus-marshal.c: adapt to DBusObjectID changes
1349 (unpack_8_octets): fix no-64-bit-int bug
1351 * dbus/dbus-object-registry.c (validate_id): validate the
1352 connection ID bits, not just the instance ID.
1354 * dbus/dbus-connection.c (_dbus_connection_init_id): initialize
1355 the connection-global 33 bits of the object ID
1357 * dbus/dbus-object-registry.c (info_from_entry): fill in
1358 object ID in the new way
1360 * dbus/dbus-objectid.h: rather than high/low bits, specifically
1361 define server/client/instance bits.
1363 2003-07-30 Havoc Pennington <hp@pobox.com>
1365 * dbus/dbus-connection.c (dbus_connection_register_object): fix
1368 2003-07-13 Havoc Pennington <hp@pobox.com>
1370 * dbus/dbus-object.h (struct DBusObjectVTable): add padding
1371 fields to DBusObjectVTable and DBusObjectInfo
1373 2003-07-12 Havoc Pennington <hp@pobox.com>
1375 * dbus/dbus-object-registry.c: implement unit test,
1376 fix bugs discovered in process
1378 * dbus/dbus-connection.c: remove handler_table and
1379 register_handler(), add DBusObjectRegistry usage
1381 * dbus/dbus-objectid.c (dbus_object_id_is_null)
1382 (dbus_object_id_set_null): new functions
1384 2003-07-08 Havoc Pennington <hp@pobox.com>
1386 * dbus/dbus-object.c: implement some of this
1388 * dbus/dbus-object-registry.c
1389 (_dbus_object_registry_add_and_unlock): fill in the object_id out
1391 (_dbus_object_registry_new): handle OOM
1393 2003-07-08 Havoc Pennington <hp@pobox.com>
1395 * dbus/dbus-object.h: sketch out an API for registering objects
1396 with a connection, that allows us to use as little as 24 bytes
1397 per object and lets application code represent an object in
1398 any conceivable way.
1400 * dbus/dbus-object-registry.c: implement the hard bits of the
1401 DBusConnection aspect of object API. Not yet wired up.
1403 2003-07-06 Havoc Pennington <hp@pobox.com>
1405 * dbus/dbus-marshal.c (_dbus_marshal_set_object_id): new function
1406 (_dbus_marshal_object_id): new
1407 (_dbus_demarshal_object_id): new
1408 (_dbus_marshal_get_arg_end_pos): support object ID type, and
1409 consolidate identical switch cases. Don't conditionalize handling
1410 of DBUS_TYPE_UINT64, need to handle the type always.
1411 (_dbus_marshal_validate_arg): consolidate identical cases, and
1412 handle DBUS_TYPE_OBJECT_ID
1414 * dbus/dbus-objectid.c: new file with DBusObjectID data type.
1416 * dbus/dbus-protocol.h: add DBUS_TYPE_OBJECT_ID
1418 2003-09-28 Havoc Pennington <hp@pobox.com>
1422 2003-09-28 Havoc Pennington <hp@pobox.com>
1424 * doc/Makefile.am (dbus-specification.html): testing a funky hack
1425 to work with Debian db2html
1427 2003-09-28 Havoc Pennington <hp@pobox.com>
1429 * configure.in: 0.13
1431 * doc/Makefile.am (dbus-test-plan.html): accept nonexistence of
1432 stylesheet-images for benefit of Debian
1434 Change back to using filesystem-linked sockets for the system
1435 bus, so only root can create the default system bus address.
1437 * bus/system.conf.in: change to use
1438 DBUS_SYSTEM_BUS_DEFAULT_ADDRESS
1440 * dbus/Makefile.am (INCLUDES): remove DBUS_SYSTEM_BUS_PATH define
1443 * configure.in: define DBUS_SYSTEM_BUS_DEFAULT_ADDRESS
1444 here, and AC_DEFINE DBUS_SYSTEM_PATH
1446 2003-08-09 Anders Carlsson <andersca@codefactory.se>
1449 * doc/busconfig.dtd:
1452 2003-08-09 Anders Carlsson <andersca@codefactory.se>
1454 * doc/dbus-specification.sgml:
1455 Add activation reply values.
1457 2003-08-05 Havoc Pennington <hp@redhat.com>
1459 * configure.in: 0.12
1461 2003-08-05 Anders Carlsson <andersca@codefactory.se>
1463 * glib/dbus-gmain.c: (watch_fd_new), (watch_fd_ref),
1464 (watch_fd_unref), (dbus_gsource_check), (dbus_gsource_dispatch),
1465 (add_watch), (remove_watch), (create_source):
1466 Refcount fds, fixes some reentrancy issues.
1468 2003-07-30 Havoc Pennington <hp@redhat.com>
1470 * dbus/dbus-bus.c (init_connections_unlocked): fix default system
1471 bus address to be abstract if we have abstract sockets
1475 2003-07-28 Havoc Pennington <hp@redhat.com>
1477 * bus/messagebus.in: fix to avoid processname/servicename
1478 confusion, from Michael Kearey
1479 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=100965
1481 2003-07-23 Havoc Pennington <hp@pobox.com>
1483 * dbus/dbus-message.c (dbus_message_iter_get_named):
1484 fix from Andy Hanton to remove broken "+1"
1486 2003-07-16 Havoc Pennington <hp@pobox.com>
1488 * tools/dbus-launch.c (babysit): close stdout/stderr in the
1489 babysitter process, as suggested by Thomas Leonard, so
1490 an "eval `dbus-launch --exit-with-session`" will actually
1493 2003-07-16 Havoc Pennington <hp@pobox.com>
1495 * configure.in: print out EXPANDED_* variables in the summary at
1496 the end; clean up the code that computes EXPANDED_ variables and
1497 get the ones using exec_prefix right. Should make things work
1498 when you build without --prefix
1500 2003-06-29 Havoc Pennington <hp@pobox.com>
1502 * mono/Test.cs (class Test): fire up a main loop and run it
1504 * mono/DBus.cs (DBus): don't g_thread_init since it can only be
1505 done once, the app has to do it
1507 2003-06-26 Havoc Pennington <hp@pobox.com>
1509 * mono/Connection.cs: set up connection with the glib main loop
1511 2003-07-01 Havoc Pennington <hp@redhat.com>
1513 * doc/dbus-specification.sgml: clarify the format of a type code,
1514 change suggested by Jim Blandy
1516 2003-06-29 Miloslav Trmac <mitr@volny.cz>
1519 * tools/Makefile.am: Don't assume srcdir == builddir.
1521 * dbus/dbus-memory.c (dbus_realloc): Don't check guards after shrinking
1522 the allocated block.
1523 (_dbus_memory_test): New function.
1524 * dbus/dbus-test.h: Add _dbus_memory_test ().
1525 * dbus/dbus-test.c (dbus_internal_do_not_use_run_tests): Call it.
1527 * dbus/dbus-message.c (decode_header_data): Use %.4s instead
1529 (dbus_message_new): Remove obsolete @todo.
1531 * dbus/dbus-marshal.c (_dbus_marshal_set_int64)
1532 (_dbus_marshal_set_uint64): Fix comment.
1534 * dbus/dbus-message.c (append_int_field, append_uint_field): Don't
1535 hardcode FIELD_REPLY_SERIAL.
1537 * dbus/dbus-mainloop.c (_dbus_loop_remove_watch)
1538 (_dbus_loop_remove_timeout): Cast function pointers to (void *) for %p
1540 * configure.in: Add -D_POSIX_C_SOURCE=199309L -DBSD_SOURCE to CFLAGS
1541 and disable DBUS_USE_ATOMIC_INT_486 when --enable-ansi is used
1543 2003-06-24 Havoc Pennington <hp@pobox.com>
1545 * mono/*.cs: Use IntPtr.Zero instead of ((IntPtr) 0)
1547 2003-06-23 Anders Carlsson <andersca@codefactory.se>
1553 * gcj/TestMessage.java: (TestMessage), (TestMessage.main):
1554 * gcj/org/.cvsignore:
1555 * gcj/org/Makefile.am:
1556 * gcj/org/freedesktop/.cvsignore:
1557 * gcj/org/freedesktop/Makefile.am:
1558 * gcj/org/freedesktop/dbus/.cvsignore:
1559 * gcj/org/freedesktop/dbus/Makefile.am:
1560 * gcj/org/freedesktop/dbus/Message.java: (Message),
1562 * gcj/org/freedesktop/dbus/natMessage.cc:
1563 Fix the build system.
1565 2003-06-22 Havoc Pennington <hp@pobox.com>
1567 * mono/Connection.cs: add more bindings
1569 * dbus/dbus-threads.c (dbus_threads_init): allow calling this
1572 2003-06-22 Havoc Pennington <hp@pobox.com>
1574 * mono/Connection.cs, mono/DBus.cs, mono/Error.cs:
1575 Start wrapping more stuff.
1577 2003-06-22 Havoc Pennington <hp@pobox.com>
1579 * mono/Message.cs: implement Message.Wrap() that ensures we only
1580 have a single C# wrapper per DBusMessage, assuming it works which
1581 it probably doesn't.
1583 * dbus/dbus-message.c (dbus_message_allocate_data_slot): new
1584 (dbus_message_free_data_slot): new
1585 (dbus_message_set_data): new
1586 (dbus_message_get_data): new
1588 2003-06-22 Havoc Pennington <hp@pobox.com>
1590 * dbus/dbus-dataslot.c (_dbus_data_slot_allocator_unref)
1591 (_dbus_data_slot_allocator_alloc): rework these to keep a
1592 reference count on each slot and automatically manage a global
1593 slot ID variable passed in by address
1595 * bus/bus.c: convert to new dataslot API
1597 * dbus/dbus-bus.c: convert to new dataslot API
1599 * dbus/dbus-connection.c: convert to new dataslot API
1601 * dbus/dbus-server.c: convert to new dataslot API
1603 * glib/dbus-gmain.c: ditto
1607 * bus/connection.c: ditto
1609 2003-06-22 Anders Carlsson <andersca@codefactory.se>
1611 * configure.in: Add AM_PROG_GCJ and move AM_PROG_LIBTOOL
1612 after the gcj checks so that the correct configuration tags
1613 will be added to libtool.
1615 * dbus-glib-1.pc.in: No need to specify any includes since
1616 dbus-1.pc.in has those.
1618 2003-06-22 Havoc Pennington <hp@pobox.com>
1620 * mono/*, gcj/*, configure.in, Makefile.am:
1621 Check in makefiles and subdirs for mono and gcj bindings.
1622 Neither binding actually exists, just trying to get through
1623 all the build and other boring bits.
1625 2003-06-21 Philip Blundell <philb@gnu.org>
1627 * tools/dbus-monitor.1: Updated.
1629 * tools/dbus-send.1: Likewise.
1631 2003-06-20 Anders Carlsson <andersca@codefactory.se>
1633 * dbus/dbus-transport-unix.c (unix_handle_watch): Check
1634 for hangup and error after checking read so we won't discard
1635 pending data if both hangup and read are set.
1637 2003-06-19 Philip Blundell <philb@gnu.org>
1639 * tools/dbus-print-message.c (print_message): Handle BOOLEAN.
1641 * tools/dbus-send.c: Accept both --system and --session.
1643 * tools/dbus-monitor.c: Same here.
1645 2003-06-19 Anders Carlsson <andersca@codefactory.se>
1647 * glib/dbus-glib.h: Fix so that dbus-glib.h can be used
1648 from C++ (Patch by Miloslav Trmac).
1650 2003-06-15 Joe Shaw <joe@assbarn.com>
1652 * configure.in: Check for socklen_t.
1654 * dbus/dbus-sysdeps.c: Define socklen_t if it's not defined.
1656 * test/test-segfault.c: Add #include <sys/time.h>
1658 * tools/Makefile.am: Add DBUS_X_CFLAGS to the INCLUDES since
1659 dbus-launch needs it.
1661 2003-06-09 Havoc Pennington <hp@redhat.com>
1663 * dbus/dbus-sysdeps.c (_dbus_listen_unix_socket): don't use
1664 SUN_LEN, it breaks abstract socket usage
1666 * dbus/dbus-internals.c (_dbus_verbose_real): only print PID at
1669 2003-06-04 Havoc Pennington <hp@pobox.com>
1671 * dbus/dbus-server.c (dbus_server_listen): allow abstract sockets
1672 using unix:abstract=/foo, and when listening in a tmpdir
1673 i.e. unix:tmpdir=/tmp, always use abstract sockets if we can.
1675 * dbus/dbus-transport.c (_dbus_transport_open): support
1678 * dbus/dbus-server-unix.c (_dbus_server_new_for_domain_socket):
1679 support abstract sockets
1681 * dbus/dbus-transport-unix.c
1682 (_dbus_transport_new_for_domain_socket): support abstract sockets
1684 * dbus/dbus-sysdeps.c (_dbus_connect_unix_socket): add "abstract"
1685 toggle as an argument, implement abstract namespace support
1686 (_dbus_listen_unix_socket): ditto
1688 * configure.in: add --enable-abstract-sockets and implement
1689 a configure check for autodetection of the right value.
1691 2003-06-01 Havoc Pennington <hp@pobox.com>
1693 * tools/dbus-cleanup-sockets.c: add utility to clean up sockets
1694 in /tmp (though on Linux this will end up being useless,
1695 when we add abstract namespace support)
1697 * configure.in: define DBUS_SESSION_SOCKET_DIR in addition to
1700 2003-05-28 Colin Walters <walters@verbum.org>
1702 * tools/dbus-monitor.c (main): Fix silly typo (s/--session/--system/).
1704 2003-05-18 Anders Carlsson <andersca@codefactory.se>
1706 * dbus/dbus-message.c (dbus_message_new): Remove @todo.
1708 2003-05-17 Colin Walters <walters@gnu.org>
1710 * tools/dbus-send.c: Don't exit with an error code if --help was
1711 passed. Default to using the session bus instead of the system
1714 * tools/dbus-launch.c: Ditto.
1716 * tools/dbus-monitor.c: Ditto.
1718 * tools/dbus-send.1: Update with new arguments.
1720 * tools/dbus-launch.c: Emit code to export variables. New
1721 arguments -s and -c to specify shell syntax, and a bit of code to
1722 autodetect syntax. Also, allow specifying a program to run.
1724 * tools/dbus-launch.1: Update with new arguments.
1726 * tools/dbus-send.1: Ditto.
1728 * tools/dbus-monitor.1: Ditto.
1730 2003-05-17 Havoc Pennington <hp@pobox.com>
1732 * bus/config-parser.c (merge_included): merge in policies from
1733 child configuration file.
1735 * bus/policy.c (bus_policy_merge): function to merge two policies
1738 2003-05-16 Havoc Pennington <hp@redhat.com>
1740 * dbus/dbus-connection.c: disable verbose lock spew
1742 * tools/dbus-send.c: add --print-reply command line option
1744 * tools/dbus-print-message.h (print_message): new util function
1745 shared by dbus-send and dbus-monitor
1747 * tools/dbus-monitor.c (handler_func): exit on disconnect
1749 * dbus/dbus-transport-unix.c (do_reading): if the transport is
1750 disconnected, don't try to use the read_watch
1752 * dbus/dbus-watch.c (dbus_watch_get_enabled): assert watch != NULL
1753 so we can find this bug more easily
1755 2003-05-16 Havoc Pennington <hp@redhat.com>
1757 * bus/policy.c (free_rule_list_func): avoid a crash when passed
1758 NULL as DBusHashTable is annoyingly likely to do.
1760 2003-05-16 Colin Walters <walters@verbum.org>
1762 * tools/dbus-monitor.c: Add --session argument and usage()
1765 * tools/dbus-monitor.1: Update with new --session arg.
1767 * bus/Makefile.am (install-data-hook): Create
1768 $(libdir)/dbus-1.0/services so that the session bus is happy.
1770 2003-05-15 Havoc Pennington <hp@redhat.com>
1772 * dbus/dbus-sysdeps.c (_dbus_atomic_dec, _dbus_atomic_inc): work
1773 on non-x86. ifdef's are evil.
1775 2003-05-15 Havoc Pennington <hp@redhat.com>
1777 * configure.in: 0.11
1781 * bus/Makefile.am (initddir): apparently we are supposed to put
1782 init scripts in /etc/rc.d/init.d not /etc/init.d
1784 * bus/Makefile.am: remove the "you must --enable-tests to make
1785 check" as it broke distcheck
1787 * bus/Makefile.am (install-data-hook): create /etc/dbus-1/system.d
1789 2003-05-13 James Willcox <jwillcox@gnome.org>
1792 * bus/activation.c: (bus_activation_service_created),
1793 (bus_activation_activate_service):
1794 * bus/driver.c: (bus_driver_send_service_deleted),
1795 (bus_driver_send_service_created), (bus_driver_send_service_lost),
1796 (bus_driver_send_service_acquired),
1797 (bus_driver_send_welcome_message),
1798 (bus_driver_handle_list_services):
1799 * bus/session.conf.in:
1800 * dbus/dbus-bus.c: (dbus_bus_acquire_service),
1801 (dbus_bus_service_exists), (dbus_bus_activate_service):
1804 Add some convenience API which lets you activate a service, and did a
1805 bunch of s/0/DBUS_TYPE_INVALID/ in calls to dbus_message_append_args()
1806 and dbus_message_get_args()
1808 2003-05-11 Havoc Pennington <hp@pobox.com>
1810 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): fix to avoid
1811 calling _dbus_marshal_validate_arg() for every byte in a byte
1814 * dbus/dbus-message-handler.c: use atomic reference counting to
1815 reduce number of locks slightly; the global lock in here sucks
1817 * dbus/dbus-connection.c
1818 (_dbus_connection_update_dispatch_status_and_unlock): variant of
1819 update_dispatch_status that can be called with lock held; then use
1820 in a couple places to reduce locking/unlocking
1821 (dbus_connection_send): hold the lock over the whole function
1822 instead of acquiring it twice.
1824 * dbus/dbus-timeout.c (_dbus_timeout_new): handle OOM
1826 * bus/connection.c (bus_connections_setup_connection): fix access
1827 to already-freed memory.
1829 * dbus/dbus-connection.c: keep a little cache of linked list
1830 nodes, to avoid using the global linked list alloc lock in the
1831 normal send-message case. Instead we just use the connection lock
1832 that we already have to take.
1834 * dbus/dbus-list.c (_dbus_list_find_last): new function
1836 * dbus/dbus-sysdeps.c (_dbus_atomic_inc, _dbus_atomic_dec):
1837 change to use a struct for the atomic type; fix docs,
1838 they return value before increment, not after increment.
1840 * dbus/dbus-string.c (_dbus_string_append_4_aligned)
1841 (_dbus_string_append_8_aligned): new functions to try to
1842 microoptimize this operation.
1843 (reallocate_for_length): break this out of set_length(), to
1844 improve profile info, and also so we can consider inlining the
1847 * dbus/dbus-message.c (dbus_message_new_empty_header): init data
1848 strings with some preallocation, cuts down on our calls to realloc
1849 a fair bit. Though if we can get the "move entire string to empty
1850 string" optimization below to kick in here, it would be better.
1852 * dbus/dbus-string.c (_dbus_string_move): just call
1853 _dbus_string_move_len
1854 (_dbus_string_move_len): add a special case for moving
1855 an entire string into an empty string; we can just
1856 swap the string data instead of doing any reallocs.
1857 (_dbus_string_init_preallocated): new function
1859 2003-05-11 Havoc Pennington <hp@pobox.com>
1861 Write a "test-profile" that does echo client-server with threads;
1862 profile reveals lock contention, memcpy/realloc of buffers, and
1863 UTF-8 validation as hot spots. 20% of lock contention eliminated
1864 with dbus_atomic_inc/dec implementation on x86. Much remaining
1865 contention is global mempool locks for GList and DBusList.
1867 * dbus/dbus-sysdeps.c (_dbus_atomic_inc, _dbus_atomic_dec): add
1870 * dbus/dbus-connection.c (struct DBusConnection): use
1871 dbus_atomic_t for the reference count
1873 * dbus/dbus-message.c (struct DBusMessage): declare
1874 dbus_atomic_t values as volatile
1876 * configure.in: code to detect ability to use atomic integer
1877 operations in assembly, from GLib patch
1879 * dbus/dbus-internals.c (_dbus_verbose_real): call getpid every
1880 time, tired of it being wrong in threads and forked processes
1882 * glib/test-profile.c: a little program to bounce messages back
1883 and forth between threads and eat CPU
1885 * dbus/dbus-connection.c: add debug spew macros for debugging
1886 thread locks; include config.h at top; fix deadlock in
1887 dbus_connection_flush()
1889 2003-05-08 Havoc Pennington <hp@pobox.com>
1891 * dbus/dbus-spawn.c: s/_exit/exit/ because it was keeping gcov
1892 data from getting written, and there wasn't a good reason to
1895 * test/decode-gcov.c (mark_inside_dbus_build_tests): don't count
1896 dbus_verbose lines in test coverage
1897 (main): add list of functions sorted by # of untested blocks
1898 to the coverage report
1900 * dbus/dbus-mempool.c: put some test-only code in DBUS_BUILD_TESTS
1902 * dbus/dbus-marshal.c (_dbus_marshal_test): extend test coverage
1904 * dbus/dbus-message-handler.c (_dbus_message_handler_test):
1905 extend test coverage
1907 * test/data/auth/cancel.auth-script: test canceling an
1910 * dbus/Makefile.am: remove dbus-server-debug.[hc] for now, as they
1911 aren't used. in CVS history if we end up needing them.
1913 2003-05-04 Havoc Pennington <hp@pobox.com>
1915 * dbus/dbus-message-handler.c (_dbus_message_handler_test): add
1918 * dbus/dbus-marshal.c (_dbus_demarshal_string_array): fix this
1919 function, which assumed length was in # of strings, not bytes
1921 * dbus/dbus-message.c (_dbus_message_test): add tests for some
1924 * dbus/dbus-connection.c
1925 (_dbus_connection_queue_received_message): disable function for
1926 now, we are only using it in test mode
1928 * dbus/dbus-message.c (_dbus_message_loader_queue_messages):
1929 remove a mistaken FIXME
1931 2003-05-04 Havoc Pennington <hp@pobox.com>
1933 * dbus/dbus-connection.c (dbus_connection_preallocate_send):
1934 unlock mutex on successful return, patch from Anders Gustafsson
1936 2003-05-04 Havoc Pennington <hp@pobox.com>
1938 * dbus-glib-1.pc.in (Requires): fix dependencies, from
1941 2003-05-04 Havoc Pennington <hp@pobox.com>
1943 * tools/dbus-launch.c: implement
1945 * bus/main.c (main), bus/bus.c (bus_context_new):
1946 implement --print-pid and --fork
1948 2003-05-03 Havoc Pennington <hp@redhat.com>
1950 * dbus/dbus-address.c (dbus_parse_address): fix bug when a key in
1951 the address had no value, and add to test suite. Fix and
1952 regression test from Miloslav Trmac
1954 2003-05-03 Havoc Pennington <hp@pobox.com>
1956 * dbus/dbus-watch.c (dbus_watch_handle): warn and return if a
1957 watch is invalid when handled
1959 * tools/Makefile.am, tools/dbus-launch.c, tools/dbus-launch.1: add
1960 dbus-launch utility to launch the bus from a shell script. Didn't
1961 actually implement dbus-launch yet, it's just a placeholder still.
1963 2003-05-03 Havoc Pennington <hp@pobox.com>
1965 * bus/Makefile.am, bus/dbus-daemon-1.1.in: man page for the
1966 daemon; also documents daemon config file, so replaces
1967 doc/config-file.txt. Corrected some stuff from config-file.txt in
1968 the process of moving it.
1970 2003-05-03 Havoc Pennington <hp@pobox.com>
1972 * tools/Makefile.am, tools/dbus-send.1, tools/dbus-monitor.1:
1975 2003-05-03 Colin Walters <walters@verbum.org>
1977 * dbus/dbus-sysdeps.c (fill_user_info): Test against
1978 DBUS_UID_UNSET to determine whether to do a uid lookup or not.
1980 * Makefile.am: Update to use new .pc versioning scheme.
1982 2003-05-02 Havoc Pennington <hp@redhat.com>
1984 * bus/system.conf.in: allow send/receive to/from message bus
1987 2003-04-30 Havoc Pennington <hp@redhat.com>
1989 * configure.in: print a note when building with unit tests and
1992 2003-04-30 Havoc Pennington <hp@redhat.com>
1994 * Makefile.am: add a check-local that complains if you didn't
1995 configure with --enable-tests
1997 2003-04-29 Havoc Pennington <hp@redhat.com>
1999 * glib/dbus-gmain.c: docs cleanups
2001 * dbus/dbus-types.h: add docs on int64 types
2003 * dbus/dbus-memory.c: fix docs to avoid putting private API in
2004 public API docs section
2006 2003-04-29 Havoc Pennington <hp@redhat.com>
2008 * dbus-1.pc.in, dbus-glib-1.pc.in: rename these from
2009 dbus-1.0.pc.in, dbus-glib-1.0.pc.in. As these change with the
2010 parallel install API version, not with the D-BUS package version.
2012 * HACKING: move some of README over here
2014 * README: updates, and document API/ABI policy
2016 * configure.in: reindentation
2018 2003-04-29 Havoc Pennington <hp@redhat.com>
2020 * dbus/dbus.h: add "you have to define DBUS_API_SUBJECT_TO_CHANGE
2021 to use this library" to be sure people have the right
2024 2003-04-28 Havoc Pennington <hp@redhat.com>
2026 * configure.in: add --enable-docs which by default is auto yes if
2027 doxygen and db2html found, no otherwise; but can be forced on/off
2029 * doc/Makefile.am: conditionalize whether to build docs on
2032 2003-04-28 Havoc Pennington <hp@redhat.com>
2034 * configure.in: 0.10
2038 * bus/system.conf.in: add <includedir>system.d</includedir>
2040 * dbus/dbus-userdb.c (_dbus_user_database_lookup): fix bug when
2041 username was provided but not uid
2043 * bus/config-parser.c (struct BusConfigParser): keep track of
2044 whether the parser is toplevel or was included; change some
2045 of the error handling if it's included.
2047 2003-04-27 Havoc Pennington <hp@pobox.com>
2051 * dbus/dbus-transport.c (_dbus_transport_get_dispatch_status):
2052 report correct status if we finish processing authentication
2053 inside this function.
2055 * bus/activation.c (try_send_activation_failure): use
2056 bus_transaction_send_error_reply
2058 * bus/connection.c (bus_connection_get_groups): return an error
2059 explaining the problem
2061 * bus/bus.c (bus_context_check_security_policy): implement
2062 restriction here that inactive connections can only send the
2063 hello message. Also, allow bus driver to send anything to
2066 * bus/connection.c (bus_connection_complete): create the
2067 BusClientPolicy here instead of on-demand.
2068 (bus_connection_get_policy): don't return an error
2070 * dbus/dbus-message.c (dbus_message_new_error_reply): allow NULL
2071 sender field in message being replied to
2073 * bus/bus.c (bus_context_check_security_policy): fix silly typo
2074 causing it to return FALSE always
2076 * bus/policy.c (bus_client_policy_check_can_send): fix bug where
2077 we checked sender rather than destination
2079 2003-04-25 Havoc Pennington <hp@redhat.com>
2081 test suite is slightly hosed at the moment, will fix soon
2083 * bus/connection.c (bus_connections_expire_incomplete): fix to
2084 properly disable the timeout when required
2085 (bus_connection_set_name): check whether we can remove incomplete
2086 connections timeout after we complete each connection.
2088 * dbus/dbus-mainloop.c (check_timeout): fix this up a bit,
2089 probably still broken.
2091 * bus/services.c (bus_registry_acquire_service): implement max
2092 number of services owned, and honor allow/deny rules on which
2093 services a connection can own.
2095 * bus/connection.c (bus_connection_get_policy): report errors here
2097 * bus/activation.c: implement limit on number of pending
2100 2003-04-25 Havoc Pennington <hp@redhat.com>
2102 * dbus/dbus-transport.c (_dbus_transport_get_unix_user): fix bug
2103 where we used >= 0 instead of != DBUS_UID_UNSET.
2105 2003-04-25 Havoc Pennington <hp@redhat.com>
2107 * glib/dbus-gmain.c (remove_watch): fix for a crash when watches
2108 were toggled without add/remove, fix from Anders Gustafsson
2110 2003-04-24 Havoc Pennington <hp@redhat.com>
2112 * test/data/valid-config-files/basic.conf: add <limit> tags to
2115 * bus/config-parser.h, bus/config-parser.c, bus/bus.c: Implement
2116 <limit> tag in configuration file.
2118 2003-04-24 Havoc Pennington <hp@redhat.com>
2120 * bus/dispatch.c: somehow missed some name_is
2122 * dbus/dbus-timeout.c (_dbus_timeout_set_enabled)
2123 (_dbus_timeout_set_interval): new
2125 * bus/connection.c (bus_connections_setup_connection): record time
2126 when each connection is first set up, and expire them after the
2127 auth timeout passes.
2129 2003-04-24 Havoc Pennington <hp@redhat.com>
2131 * dbus/dbus-message.c (dbus_message_name_is): rename
2132 (dbus_message_service_is): rename
2133 (dbus_message_sender_is): rename
2134 (dbus_message_get_service): rename
2136 2003-04-24 Havoc Pennington <hp@redhat.com>
2138 * configure.in: add --enable-checks
2140 * dbus/dbus-message.c (dbus_message_new): reverse name/service arguments
2142 * dbus/dbus-connection.c (dbus_connection_preallocate_send): fix
2143 to use thread locks.
2144 (_dbus_connection_handler_destroyed_locked): move some private
2145 functions into proper docs group
2147 * dbus/dbus-internals.h: add _dbus_return_if_fail,
2148 _dbus_return_val_if_fail
2150 Throughout: use dbus_return_if_fail
2152 2003-04-23 James Willcox <jwillcox@gnome.org>
2155 * glib/dbus-gmain.c: (add_timeout), (wakeup_main), (create_source),
2156 (dbus_connection_setup_with_g_main),
2157 (dbus_server_setup_with_g_main):
2158 * glib/test-dbus-glib.c: (main):
2159 * glib/test-thread-client.c: (main):
2160 * glib/test-thread-server.c: (new_connection_callback), (main):
2161 * tools/dbus-monitor.c: (main):
2163 Added a GMainContext argument to dbus_connection_setup_with_g_main()
2164 and dbus_server_setup_with_g_main().
2166 2003-04-20 Havoc Pennington <hp@pobox.com>
2168 * doc/dbus-specification.sgml: document the restrictions on
2169 message and service names
2171 2003-04-22 Havoc Pennington <hp@redhat.com>
2173 * dbus/dbus-message.c, dbus/dbus-marshal.c: add 64-bit integer
2174 support, and do some code cleanups to share more code and
2175 speed up array marshal/demarshal.
2177 * dbus-1.0.pc.in (Cflags): put libdir include file in cflags
2179 * configure.in: generate dbus-arch-deps.h
2181 * dbus/dbus-protocol.h (DBUS_TYPE_INT64, DBUS_TYPE_UINT64): add
2184 2003-04-22 Havoc Pennington <hp@redhat.com>
2186 * test/data/valid-messages/opposite-endian.message: fix test
2187 to use proper type for rply field
2189 * test/data/invalid-messages: add tests for below validation
2191 * dbus/dbus-message.c (decode_header_data): validate field types,
2192 and validate that named fields are valid names
2193 (decode_name_field): consider messages in the
2194 org.freedesktop.Local. namespace to be invalid.
2196 * dbus/dbus-string.c (_dbus_string_validate_name): new
2198 2003-04-19 Havoc Pennington <hp@pobox.com>
2200 * bus/driver.c (bus_driver_handle_hello): check limits and
2201 return an error if they are exceeded.
2203 * bus/connection.c: maintain separate lists of active and inactive
2204 connections, and a count of each. Maintain count of completed
2205 connections per user. Implement code to check connection limits.
2207 * dbus/dbus-list.c (_dbus_list_unlink): export
2209 * bus/bus.c (bus_context_check_security_policy): enforce a maximum
2210 number of bytes in the message queue for a connection
2212 2003-04-18 Havoc Pennington <hp@pobox.com>
2214 * dbus/dbus-auth.c (record_mechanisms): memleak fixes
2216 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): fix some
2219 * dbus/dbus-keyring.c (add_new_key): fix a memleak, and
2220 on realloc be sure to update the pointer in the keyring
2222 * dbus/dbus-string.c (_dbus_string_zero): compensate for align
2223 offset to avoid writing to unallocated memory
2225 * dbus/dbus-auth.c (process_rejected): return FALSE if we fail to
2226 try the next mechanism, so we properly handle OOM
2228 * dbus/dbus-keyring.c (_dbus_keyring_new_homedir): fix double-free
2230 (_dbus_keyring_new): fix OOM bug
2231 (_dbus_keyring_new_homedir): always set error; impose a maximum
2232 number of keys we'll load from the file, mostly to speed up the
2233 test suite and make its OOM checks more useful, but also for
2236 * dbus/dbus-auth.c (process_error_server): reject authentication
2237 if we get an error from the client
2238 (process_cancel): on cancel, send REJECTED, per the spec
2239 (process_error_client): send CANCEL if we get an error from the
2242 2003-04-18 Havoc Pennington <hp@pobox.com>
2244 * dbus/dbus-mainloop.c (_dbus_loop_iterate): fix UMR in verbose
2247 * dbus/dbus-auth.c (handle_client_data_cookie_sha1_mech): fix OOM
2250 * dbus/dbus-keyring.c (_dbus_keyring_new_homedir): only whine
2251 about DBUS_TEST_HOMEDIR once
2253 * bus/Makefile.am (TESTS_ENVIRONMENT): put DBUS_TEST_HOMEDIR in
2256 * bus/dispatch.c (bus_dispatch_sha1_test): actually load sha1
2257 config file so we test the right thing
2259 Throughout: assorted docs improvements
2261 2003-04-18 Havoc Pennington <hp@pobox.com>
2263 * glib/dbus-gmain.c: adapt to watch changes
2265 * bus/bus.c, bus/activation.c, etc.: adjust to watch changes
2267 * dbus/dbus-server.h: remove dbus_server_handle_watch
2269 * dbus/dbus-connection.h: remove dbus_connection_handle_watch
2271 * dbus/dbus-watch.c (dbus_watch_handle): change DBusWatch to work
2272 like DBusTimeout, so we don't need dbus_connection_handle_watch
2275 2003-04-17 Havoc Pennington <hp@redhat.com>
2277 * dbus/dbus-userdb.c, dbus/dbus-sysdeps.c: redo all the passwd
2278 database usage so it all goes via the DBusUserDatabase cache.
2280 2003-04-17 Havoc Pennington <hp@redhat.com>
2282 * dbus/dbus-mainloop.c (_dbus_loop_iterate): fix logic so that if
2283 there was an OOM watch we skipped, we always return TRUE so we
2284 iterate again to have a look at it again. Fixes test suite hang.
2285 Code rearrangement also lets us lose some memset and only iterate
2286 over callbacks once.
2288 * bus/driver.c (bus_driver_handle_message): sense of test for
2291 2003-04-16 Havoc Pennington <hp@pobox.com>
2293 * doc/dbus-specification.sgml: make spec say serials are unsigned
2295 * dbus/dbus-message.h: change message serials to unsigned
2297 * dbus/dbus-connection.c: adapt to message serials being unsigned
2299 2003-04-15 Havoc Pennington <hp@pobox.com>
2301 * bus/bus.c: create and keep around a shared DBusUserDatabase
2304 * bus/connection.c (bus_connection_get_groups): don't cache
2305 groups for user in the connection object, since user database
2306 object now does that.
2308 2003-04-16 Havoc Pennington <hp@redhat.com>
2310 * dbus/dbus-message.c (_dbus_message_add_size_counter): keep a
2311 list of size counters
2312 (_dbus_message_loader_putback_message_link): put back a popped link
2314 * dbus/dbus-connection.c
2315 (dbus_connection_set_max_live_messages_size): rename
2317 (dbus_connection_get_outgoing_size): get size of outgoing
2319 (_dbus_connection_set_connection_counter): remove this cruft
2321 2003-04-14 Havoc Pennington <hp@redhat.com>
2323 * dbus/dbus-userdb.c: user database abstraction, mostly to get
2324 caching, but at some point we might want to be able to use a
2327 * bus/dispatch.c (bus_dispatch_sha1_test): add a test that uses
2328 SHA1 conf file to test the sha1 auth mechanism, since the regular
2329 test always uses EXTERNAL when available.
2332 test/data/valid-config-files/debug-allow-all-sha1.conf.in:
2333 add conf file that requires use of sha1 auth
2335 2003-04-13 Havoc Pennington <hp@pobox.com>
2337 * tools/dbus-send.c, tools/dbus-monitor.c: two utility programs
2338 from Philip Blundell to send messages and monitor them.
2340 2003-04-13 Havoc Pennington <hp@pobox.com>
2342 * dbus/dbus-mainloop.c: fix some reentrancy issues by refcounting
2345 * test/data/valid-config-files/debug-allow-all.conf.in: allow all
2348 * dbus/dbus-transport.c (_dbus_transport_get_dispatch_status):
2349 fix to only recover unused bytes if we're already authenticated
2350 (_dbus_transport_get_is_authenticated): fix to still mark us
2351 authenticated if there are unused bytes.
2353 * bus/dispatch.c: implement security policy checking
2355 * bus/connection.c (bus_transaction_send_from_driver): new
2357 * bus/bus.c (bus_context_check_security_policy): new
2359 * bus/dispatch.c (send_service_nonexistent_error): delete this,
2360 now we just set the DBusError and it gets converted to an error
2363 * bus/connection.c (allow_user_function): enable code using actual
2364 data from the config file
2366 * bus/policy.c (list_allows_user): handle wildcard rules for
2367 user/group connection perms
2369 2003-04-13 Havoc Pennington <hp@pobox.com>
2371 * bus/config-parser.c: Load up the BusPolicy and BusPolicyRules
2373 * dbus/dbus-sysdeps.c (_dbus_get_user_id): new function
2375 * bus/policy.c (bus_policy_append_mandatory_rule)
2376 (bus_policy_append_default_rule, bus_policy_append_user_rule)
2377 (bus_policy_append_group_rule): new functions
2379 2003-04-12 Havoc Pennington <hp@pobox.com>
2381 * bus/config-parser.c (bus_config_parser_new): fix a memleak
2383 * dbus/dbus-sysdeps.c: change DBusCredentials to use longs for
2384 the pid/gid/uid, just for paranoia.
2386 * test/break-loader.c (randomly_do_n_things): find a byte
2387 containing a type code, and randomly change it to a different
2390 2003-04-12 Havoc Pennington <hp@pobox.com>
2392 * bus/policy.h: change BusPolicy to be the thing from the config
2393 file, and rename old BusPolicy to BusClientPolicy
2395 * bus/bus.c, bus/connection.c, bus/config-parser.c: change to
2396 match change in how policy works
2398 * dbus/dbus-internals.h: mark assert_not_reached as
2399 __attribute((noreturn))__
2401 2003-04-11 Havoc Pennington <hp@redhat.com>
2403 * doc/dbus-specification.sgml: fix a spot with the wrong name for
2404 the broadcast service. Use boolean return for ServiceExists.
2406 2003-04-11 Havoc Pennington <hp@redhat.com>
2408 * configure.in: add another directory to look for qt in.
2410 2003-04-11 Havoc Pennington <hp@redhat.com>
2412 * AUTHORS: add Colin Walters
2414 2003-04-11 Havoc Pennington <hp@redhat.com>
2420 2003-04-11 Havoc Pennington <hp@redhat.com>
2422 * bus/messagebus.in: remove pid file when stopping the
2423 message bus, since the bus won't have privileges to remove it
2426 2003-04-11 Havoc Pennington <hp@redhat.com>
2428 * bus/bus.c (bus_context_new): move credentials change after
2431 2003-04-11 Havoc Pennington <hp@pobox.com>
2433 * test/decode-gcov.c: add "below average functions" to the
2434 coverage report, and change how some of the code works.
2436 * bus/test-main.c: bracket some stuff in DBUS_BUILD_TESTS so it's
2437 not in the coverage stats.
2439 * test/test-service.c (main): use _dbus_verbose not fprintf in a
2440 couple places so running the test suite doesn't result in megaspam.
2442 2003-04-11 Havoc Pennington <hp@pobox.com>
2444 * bus/dispatch.c (check_existent_service_activation): accept a no
2445 memory error in a place we didn't before
2447 * bus/test.c (bus_test_run_everything): remove hacky "do it twice
2448 in case the first one failed," since the test suite is less
2451 2003-04-10 Havoc Pennington <hp@pobox.com>
2453 * bus/dispatch.c (check_segfault_service_activation): add test
2454 for launching an executable that just crashes.
2456 * test/test-segfault.c (main): try setting coredumpsize to 0 so we
2457 don't leave a million cores. We'll see how portable this is.
2459 2003-04-10 Havoc Pennington <hp@pobox.com>
2461 * dbus/dbus-spawn.c (_dbus_spawn_async_with_babysitter): move all
2462 the possible parent failures before we fork, so that we don't
2463 fail to create a babysitter after creating the child.
2465 * bus/activation.c (bus_activation_activate_service): kill child
2466 if we don't successfully complete the activation.
2468 2003-04-10 Havoc Pennington <hp@redhat.com>
2470 * dbus/dbus-connection.c (dbus_connection_flush): don't spin on
2471 the connection if it's disconnected
2473 * bus/activation.c (bus_activation_service_created): use new
2474 transaction features to roll back removal of pending activation if
2475 we don't successfully create the service after all. Don't remove
2476 pending activation if the function fails.
2478 * dbus/dbus-list.c (_dbus_list_insert_before_link)
2479 (_dbus_list_insert_after_link): new code to facilitate
2482 * dbus/dbus-hash.c (_dbus_hash_table_insert_string_preallocated):
2483 new functionality, so we can preallocate the ability to insert
2486 * bus/connection.c (bus_transaction_add_cancel_hook): new function
2487 allowing us to put custom hooks in a transaction to be used for
2488 cancelling said transaction
2490 * doc/dbus-specification.sgml: add some discussion of secondary
2491 service owners, and disallow zero-length service names
2493 * bus/services.c (bus_registry_acquire_service): new function,
2494 splits out part of bus_driver_handle_acquire_service() and fixes
2495 a bug where we didn't remove the service doing the acquiring
2496 from the secondary queue if we failed to remove the current owner
2497 from the front of the queue.
2499 2003-04-10 Alexander Larsson <alexl@redhat.com>
2501 * doc/dbus-specification.sgml:
2502 s/org.freedesktop.Broadcast/org.freedesktop.DBus.Broadcast/
2504 2003-04-10 Alexander Larsson <alexl@redhat.com>
2509 Added files to cvsignore
2511 * dbus/dbus-message.h:
2512 * dbus/dbus-message.c: (dbus_message_iter_get_named):
2513 Make get_named() take two out argument and return a boolean.
2514 (dbus_message_iter_get_args_valist):
2515 Update usage of get_named().
2516 (dbus_message_iter_append_byte):
2518 (dbus_message_iter_append_named)
2520 (message_iter_test), (check_message_handling_type), (_dbus_message_test):
2523 2003-04-10 Alexander Larsson <alexl@redhat.com>
2525 * dbus/dbus-marshal.[ch]:
2526 Add array_type_pos argument to _dbus_marshal_validate_arg.
2527 Let you pass a NULL end_pos to _dbus_marshal_validate_type.
2529 * dbus/dbus-message.[ch]:
2530 Multi-dimensional arrays have full type specification in the
2531 outermost array. Iter code re-arranged to handle this.
2532 Added some more iter tests.
2534 * doc/dbus-specification.sgml:
2537 Update new array encoding description.
2538 Correct DBUS_SERVICE_FLAGS_REPLACE_EXISTING description.
2540 * test/data/invalid-messages/array-with-mixed-types.message:
2541 * test/data/valid-messages/array-of-array-of-uint32.message:
2542 Change to the new array format.
2544 * test/data/invalid-messages/too-short-dict.message:
2547 * test/data/valid-messages/recursive-types.message:
2548 Fix up and extend test.
2550 2003-04-10 Havoc Pennington <hp@pobox.com>
2552 * bus/dispatch.c: lots of fixes
2554 * dbus/dbus-mainloop.c (_dbus_loop_dispatch): export
2555 (_dbus_loop_iterate): remove old "quit if no callbacks" code,
2556 that was crack, broke the test service.
2558 * dbus/dbus-transport.c (_dbus_transport_open): fix error
2559 handling to avoid piling up errors if we get a failure on the
2562 * dbus/dbus-internals.c (_dbus_real_assert_not_reached): include
2563 pid in assertion failures.
2565 * dbus/dbus-mainloop.c (_dbus_loop_iterate): use static arrays up
2566 to some fixed size of file descriptor array. Don't return TRUE
2567 anytime a timeout exists, that led to lots of busy loop silliness
2570 2003-04-09 Havoc Pennington <hp@redhat.com>
2572 * dbus/dbus-mainloop.c (check_timeout): fix timeouts, I thought
2573 I'd checked this in earlier but hadn't.
2575 2003-04-09 Havoc Pennington <hp@redhat.com>
2577 * bus/dispatch.c (bus_dispatch_test): get a bit further through
2578 the activation test (man this is getting old!)
2580 2003-04-09 Havoc Pennington <hp@redhat.com>
2582 * test/test-utils.c: use dispatch status function to fix this up
2584 * bus/connection.c (connection_watch_callback): don't dispatch
2586 (connection_timeout_callback): don't dispatch from here
2587 (bus_connections_setup_connection): set the dispatch status function
2588 (bus_connection_disconnected): unset it
2590 * dbus/dbus-mainloop.c (_dbus_loop_queue_dispatch): new function
2591 used to add a connection to be dispatched
2592 (_dbus_loop_iterate): do the dispatching at the end of each
2595 * dbus/dbus-connection.c
2596 (dbus_connection_set_dispatch_status_function): new function
2597 allowing us to fix up main loop usage
2598 (_dbus_connection_last_unref): free all the various function
2600 (dbus_connection_dispatch): call the DispatchStatusFunction
2601 whenever this function returns
2602 (dbus_connection_handle_watch): call DispatchStatusFunction
2603 (dbus_connection_send_with_reply_and_block): call DispatchStatusFunction
2604 (reply_handler_timeout): call DispatchStatusFunction
2605 (dbus_connection_flush): call DispatchStatusFunction
2607 2003-04-09 Havoc Pennington <hp@redhat.com>
2609 * dbus/dbus-bus.c (dbus_bus_register): fix up error handling and
2612 * bus/dispatch.c (check_service_activated): fix bug in test
2614 * dbus/dbus-mainloop.c (check_timeout): fix this up
2616 * dbus/dbus-internals.c (_dbus_verbose_real): include PID in
2617 verbose output so we can sort out output from different processes,
2618 e.g. in the activation case.
2620 2003-04-08 Colin Walters <walters@gnu.org>
2622 * bus/bus.c (struct BusContext) [pidfile]: New member, to store
2624 (bus_context_new): Set it.
2625 (bus_context_unref): Use it to delete the pid file.
2627 2003-04-08 Havoc Pennington <hp@redhat.com>
2629 * test/data/invalid-messages/array-with-mixed-types.message:
2630 regression test that fails for the moment
2632 * dbus/dbus-test.c (dbus_internal_do_not_use_run_tests): reorder
2633 tests for convenience
2635 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): don't allow
2636 array of nil, it broke things.
2638 * test/data/invalid-messages/array-of-nil.message: regression test
2640 * test/data/valid-messages/array-of-array-of-uint32.message:
2641 happened to write this so added it to suite
2643 2003-04-08 Havoc Pennington <hp@redhat.com>
2645 * bus/driver.c (bus_driver_handle_acquire_service): init
2646 retval/reply before checking name
2648 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): add a
2649 recursion depth argument
2651 * dbus/dbus-message.h (struct DBusMessageIter): put some padding
2652 in the public struct for future extension
2654 * dbus/dbus-message-builder.c (_dbus_message_data_load): fix
2657 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): fix a verbose
2660 * doc/dbus-specification.sgml: fix typo
2662 2003-04-08 Alexander Larsson <alexl@redhat.com>
2664 Implemented recursive types, named types and new-style iters
2667 * glib/test-thread-client.c: (thread_func):
2668 * glib/test-thread-server.c: (handle_test_message):
2669 * test/test-service.c: (handle_echo):
2678 * dbus/dbus-internals.c: (_dbus_type_to_string):
2679 Update for new types.
2681 * dbus/dbus-marshal.[ch]:
2682 Implement recursive types and the new marshalling format.
2683 Remove hardcoded dict marshalling.
2684 Marshal named types.
2686 * dbus/dbus-message-builder.c:
2688 Remove references to old types
2690 * dbus/dbus-message.[ch]:
2691 New non-refcounted iter API that supports recursive iters.
2692 Use iters for appending, including support for recursive
2694 Add byte and named type support.
2695 Update everything to new marshalling formats.
2696 Add tests for new API.
2698 * dbus/dbus-protocol.h:
2699 Remove old array types.
2700 Add types: BYTE, ARRAY, DICT, NAMED
2702 * dbus/dbus-string.c:
2703 * dbus/dbus-sysdeps.c:
2704 Make parse_double locale safe.
2706 * dbus/dbus-test-main.c:
2712 * doc/dbus-specification.sgml:
2715 * test/data/incomplete-messages/missing-body.message:
2716 * test/data/invalid-messages/bad-boolean.message:
2717 * test/data/invalid-messages/bad-boolean-array.message:
2718 * test/data/invalid-messages/boolean-array-length-too-long.message-raw:
2719 * test/data/invalid-messages/boolean-has-no-value.message-raw:
2720 * test/data/invalid-messages/too-short-dict.message:
2721 * test/data/valid-messages/dict-simple.message:
2722 * test/data/valid-messages/dict.message:
2723 * test/data/valid-messages/emptiness.message:
2724 * test/data/valid-messages/lots-of-arguments.message:
2725 * test/data/valid-messages/no-padding.message:
2726 * test/data/valid-messages/recursive-types.message:
2727 Add missing NAME fields
2728 Fix up dicts & arrays
2730 * test/data/invalid-messages/dict-with-nil-value.message:
2731 Removed, this is not invalid anymore.
2733 * test/data/valid-messages/recursive-types.message:
2734 Add new test for deeply recursive types.
2736 2003-04-07 Havoc Pennington <hp@pobox.com>
2738 * bus/driver.c (bus_driver_handle_acquire_service): return an
2739 error if you try to acquire a service that starts with ':'
2741 2003-04-07 Havoc Pennington <hp@redhat.com>
2743 * doc/dbus-specification.sgml: require that base service names
2744 start with ':' and that the base service is created/deleted
2745 as first and last things a connection does on the bus
2747 * bus/dispatch.c (check_existent_service_activation): lots more
2748 work on the activation test; it doesn't fully pass yet...
2750 * test/test-service.c (main): fix so we don't memleak the
2751 connection to the message bus
2752 (filter_func): accept a message asking us to exit
2754 2003-04-06 Havoc Pennington <hp@pobox.com>
2756 * qt/Makefile.am (dbusinclude_HEADERS): install dbus-qt.h,
2759 * configure.in: fixes to Qt detection from Colin Walters
2761 * doc/Makefile.am: Only remove generated docbook dirs if they
2762 exist, from Colin Walters
2764 * dbus/dbus-bus.c: change how we set well-known connections to
2765 NULL, so that it works if a single connection is stored in
2766 two well-known array slots.
2768 * test/Makefile.am: remove a lot of stuff that isn't immediately
2769 useful, it's in CVS history if we want it.
2771 * test/test-service.c: use dbus-mainloop instead of that
2774 2003-04-06 Havoc Pennington <hp@pobox.com>
2776 * dbus/Makefile.am: split lists of sources into stuff that goes in
2777 the library, util functions that go in the lib and are also used
2778 elsewhere, and util functions that are used in tests/daemon but
2779 don't go in the lib.
2781 * dbus/dbus-mainloop.h, dbus/dbus-mainloop.c: move bus/loop.[hc]
2782 here so it can be used in test binaries also
2784 2003-04-06 Havoc Pennington <hp@pobox.com>
2786 * dbus/dbus-sysdeps.c (_dbus_become_daemon): write the pidfile
2787 here in the parent process, so we can return an error if it
2788 fails. Also, move some of the code into the child so the parent
2789 is less hosed if we fail midway through.
2791 * bus/bus.c (bus_context_new): move pidfile detection further up
2792 in the function, before we start overwriting sockets and such.
2794 * bus/messagebus.in: adjust this a bit, not sure if it will work.
2796 * configure.in: add --with-system-pid-file and --with-system-socket
2798 2003-04-06 Colin Walters <walters@verbum.org>
2800 * configure.in (DBUS_SYSTEM_PID_FILE): New variable.
2802 * bus/system.conf.in: Declare a pidfile.
2804 * bus/bus.c (bus_context_new): Test for an existing pid file, and
2805 create one (if appropriate).
2807 * bus/config-parser.c (enum ElementType) [ELEMENT_PIDFILE]: New.
2808 (struct BusConfigParser) [pidfile]: New.
2809 (element_type_to_name, merge_included, start_busconfig_child)
2810 (bus_config_parser_end_element, bus_config_parser_content): Handle it.
2811 (bus_config_parser_unref): Free it.
2812 (bus_config_parser_get_pidfile): New function.
2814 * bus/config-parser.h (_dbus_write_pid_file): Prototype.
2816 * dbus/dbus-errors.h (DBUS_ERROR_PIDFILE_EXISTS): New error.
2818 * dbus/dbus-sysdeps.c (_dbus_write_pid_file): New function.
2820 * dbus/dbus-sysdeps.h: Prototype it.
2822 2003-04-06 Havoc Pennington <hp@pobox.com>
2824 * bus/bus.c (bus_context_new): print the address in here, rather
2825 than in main(), because we need to do it before forking the daemon
2827 * bus/dispatch.c (send_service_nonexistent_error): set the sender
2828 on the service nonexistent error
2830 * bus/driver.c (bus_driver_handle_acquire_service): set the
2831 sender on the AcquireService reply
2833 * test/data/valid-config-files/debug-allow-all.conf.in: Make test
2834 server also listen on a UNIX socket so services can connect to it.
2836 2003-04-06 Havoc Pennington <hp@pobox.com>
2838 * dbus/dbus-threads.c: Redo how the fake debug mutexes are done
2839 so it detects deadlocks and also we actually init threads when
2842 2003-04-06 Havoc Pennington <hp@pobox.com>
2844 * dbus/dbus-server-unix.c (_dbus_server_new_for_domain_socket):
2845 save the domain socket name, and unlink it when we disconnect the
2846 server. Means that at least when we exit normally, we won't leave
2847 a bunch of junk in /tmp
2849 * dbus/dbus-transport-unix.c
2850 (_dbus_transport_new_for_domain_socket): code cleanup (nicer
2851 memory management). (I was making a real change here but then
2854 2003-04-06 Havoc Pennington <hp@pobox.com>
2856 * bus/bus.c (bus_context_new): fix wrong handling of
2857 server_data_slot_unref() in the error case.
2859 * dbus/dbus-internals.h (_dbus_assert): change so it passes
2860 "(condition) != 0" to _dbus_real_assert so that
2861 "_dbus_assert (pointer)" doesn't cause a warning
2863 * bus/main.c (main): accept --print-address option to print out
2864 the message bus address
2866 * dbus/dbus-sysdeps.c (_dbus_generate_random_ascii): export this
2868 * dbus/dbus-transport.c (_dbus_transport_open): special error for
2869 "tmpdir" option to unix: address on client side
2871 * dbus/dbus-server.c (dbus_server_listen): handle "tmpdir" option
2874 * configure.in (TEST_SOCKET_DIR): locate a temporary directory
2875 we can use to create sockets in the test suite.
2877 * bus/main.c (signal_handler): on SIGTERM, exit the daemon
2878 cleanly. To be used for testing.
2880 * dbus/dbus-spawn.c (babysit): use _dbus_set_signal_handler()
2882 * dbus/dbus-sysdeps.c (_dbus_set_signal_handler): new
2884 * dbus/dbus-server-debug-pipe.c (_dbus_transport_debug_pipe_new):
2885 handle trying to call this when there's no servers active
2887 2003-04-05 Havoc Pennington <hp@pobox.com>
2893 2003-04-05 Havoc Pennington <hp@pobox.com>
2895 * bus/bus.c (setup_server): fix this so dbus-daemon-1 doesn't
2896 crash on startup. Need to get "try starting the daemon"
2897 in the test suite I guess. ;-)
2899 * dbus/dbus-server.h, dbus/dbus-server.c: remove the stuff that
2900 tracked the number of open connections; it's better done in
2901 application-specific code as you want it to span all servers etc.
2903 2003-04-05 Havoc Pennington <hp@pobox.com>
2905 * bus/Makefile.am (install-data-hook): add missing DESTDIR,
2906 patch from Colin Walters
2908 2003-04-05 Havoc Pennington <hp@pobox.com>
2910 * doc/config-file.txt (Elements): fix docs of <auth> to reflect
2911 reality; in fact multiple mechanisms are allowed.
2913 * dbus/dbus-internals.c (_dbus_real_assert)
2914 (_dbus_real_assert_not_reached): move guts of _dbus_assert() and
2915 _dbus_assert_not_reached() into functions, so that they don't show
2916 up in basic block counts for test coverage, and don't use up as
2917 much disk space. Does mean slower execution speed though, so
2918 assumes --disable-asserts is the normal production case.
2920 2003-04-05 Havoc Pennington <hp@pobox.com>
2922 * test/Makefile.am (dist-hook): also dist *.in files
2928 2003-04-05 Havoc Pennington <hp@pobox.com>
2930 * dbus/dbus-string.c: docs warning
2932 * dbus/dbus-spawn.c: missing docs
2934 * dbus/dbus-memory.c (struct ShutdownClosure): missing docs
2936 2003-04-05 Havoc Pennington <hp@pobox.com>
2938 * bus/loop.c (bus_loop_iterate): fix the timeout code, using
2941 * dbus/dbus-spawn.c (_dbus_babysitter_unref): set sitter_pid
2942 to -1 once we've reaped the babysitter
2943 (_dbus_babysitter_handle_watch): do as much work as we can, not
2946 * bus/activation.c: add code using DBusBabysitter so that we
2947 handle it when a service fails to start up properly.
2948 (bus_activation_service_created): don't remove the activation
2949 entries as we go, just let them get removed when we free the pending
2950 activation. Unref reply messages after sending them.
2952 2003-04-05 Havoc Pennington <hp@pobox.com>
2954 * test/decode-gcov.c (main): print per-directory stats in the report
2956 * Makefile.am (coverage-report.txt): don't include test/* in gcov stats
2958 2003-04-05 Havoc Pennington <hp@pobox.com>
2960 * Makefile.am (coverage-report.txt): add target "coverage-report.txt"
2962 * test/decode-gcov.c: hack up a little program to suck data
2963 out of gcov files. Yes this is sort of silly.
2965 * configure.in: define something in config.h and do an
2966 AM_CONDITIONAL when gcov is enabled
2968 2003-04-04 Havoc Pennington <hp@redhat.com>
2970 * dbus/dbus-spawn.c, dbus/dbus-spawn.h: Change dbus_spawn to
2971 return a "babysitter" object that is used to monitor the status of
2972 the spawned process and reap it when required.
2974 * test/test-segfault.c, test/test-exit.c,
2975 test/test-sleep-forever.c: binaries that do various lame things,
2976 used in the test suite.
2978 * dbus/dbus-sysdeps.c: kill _dbus_errno_to_string()
2980 2003-04-03 Havoc Pennington <hp@pobox.com>
2982 * dbus/dbus-spawn.c: Move dbus-spawn into a separate file
2983 in preparation for modifying it, dbus-sysdeps is getting
2986 2003-04-03 Havoc Pennington <hp@redhat.com>
2988 * bus/loop.h, bus/loop.c: make the mainloop an object so we can
2991 * bus/*.[hc]: adapt to mainloop change
2993 2003-04-03 Havoc Pennington <hp@redhat.com>
2995 * bus/activation.c (load_directory): fix up memleaks
2996 (bus_activation_entry_free): free the entry
2998 * dbus/dbus-bus.c (dbus_bus_acquire_service): return an error if
2999 we get one from the message bus; fix memleaks.
3001 * dbus/dbus-message.c (dbus_set_error_from_message): new function
3003 2003-04-03 Havoc Pennington <hp@pobox.com>
3005 * bus/config-parser.c (bus_config_parser_unref): free
3006 list of mechanisms, bug discovered by test suite enhancements
3007 (putting system.conf and session.conf into suite)
3009 * test/Makefile.am, test/test-service.c: add placeholder for a
3010 test service that we'll activate as part of test suite. Doesn't
3013 * dbus/dbus-sysdeps.c (_dbus_setenv): support unsetenv by
3014 setting NULL value, and use system malloc not dbus_malloc()
3015 when we have unavoidable memleakage.
3017 * dbus/dbus-bus.c (dbus_bus_get): fix bug where bus type of 0
3018 didn't work, and support DBUS_BUS_ACTIVATION.
3020 * bus/activation.c (child_setup): pass our well-known bus type to
3023 * bus/config-parser.c: support <type> to specify well-known type
3025 * doc/dbus-specification.sgml: document the env variables to
3026 locate well-known buses and find service activator
3028 2003-04-02 Havoc Pennington <hp@redhat.com>
3030 * test/Makefile.am (all-local): add a rule to copy tests to
3031 builddir, so we can have generated tests. Use this to remove the
3032 silly hack for testing system.conf and session.conf. Will use this
3033 shortly to generate .service files pointing to test binaries.
3035 2003-04-02 Havoc Pennington <hp@redhat.com>
3037 * dbus/dbus-string.c (set_length): fix a bug - we allocated max of
3038 current alloc and needed new length, not max of the doubled
3039 allocation and needed new length. Also, when building tests,
3040 don't do the double-allocation stuff, just realloc every time.
3042 2003-04-02 Havoc Pennington <hp@redhat.com>
3044 * dbus/dbus-sysdeps.c (_dbus_file_get_contents): include filenames
3046 (_dbus_string_get_dirname): new
3047 (_dbus_sysdeps_test): new
3048 (_dbus_directory_open): include dirnames in error messages
3050 * bus/config-parser.c: interpret <include> and <includedir> and
3051 <servicedir> relative to config file location if the given
3052 filename is not absolute.
3054 * dbus/dbus-string.c (_dbus_string_find_byte_backward): new
3056 2003-04-02 Havoc Pennington <hp@redhat.com>
3058 * bus/connection.c (bus_transaction_send_error_reply): set sender
3059 service for the error, and unref the reply on success
3061 * bus/activation.c: convert to use BusTransaction so OOM can be
3063 (bus_activation_service_created): set sender of the message
3065 2003-04-01 Havoc Pennington <hp@redhat.com>
3067 * bus/config-parser.c, bus/bus.c: implement <servicedir> and
3068 <includedir> (at least mostly)
3070 * dbus/dbus-sysdeps.c (_dbus_change_identity): set the group ID
3071 first, then the user ID
3073 2003-04-01 Havoc Pennington <hp@pobox.com>
3075 * dbus/dbus-server.c (dbus_server_set_auth_mechanisms): new
3078 * dbus/dbus-auth.c (_dbus_auth_set_mechanisms): new
3080 * dbus/dbus-internals.c (_dbus_dup_string_array): new function
3082 * dbus/dbus-sysdeps.c (_dbus_listen_unix_socket): chmod the
3083 socket 0777, and unlink any existing socket.
3085 * bus/bus.c (bus_context_new): change our UID/GID and fork if
3086 the configuration file so specifies; set up auth mechanism
3089 * bus/config-parser.c (bus_config_parser_content): add support
3090 for <fork> option and fill in code for <auth>
3092 * bus/system.conf.in: add <fork/> to default configuration,
3093 and limit auth mechanisms to EXTERNAL
3095 * doc/config-file.txt (Elements): add <fork>
3097 * dbus/dbus-sysdeps.c (_dbus_become_daemon): new function
3098 (_dbus_change_identity): new function
3100 2003-03-31 Havoc Pennington <hp@redhat.com>
3102 * dbus/dbus-sysdeps.c (_dbus_connect_unix_socket)
3103 (_dbus_listen_unix_socket): fix off-by-one error in null
3104 termination spotted by Nalin
3106 2003-03-31 Havoc Pennington <hp@redhat.com>
3108 * dbus/dbus-keyring.c (_dbus_keyring_new_homedir): allow setting
3109 DBUS_TEST_HOMEDIR when tests are enabled, so we can test without
3110 having a real home directory available.
3112 2003-03-31 Havoc Pennington <hp@redhat.com>
3114 * bus/Makefile.am (install-data-hook): create /var/run/dbus
3116 * bus/messagebus.in: add init script for Red Hat /etc/init.d
3118 * configure.in: add support for specifying a style of init script
3121 2003-03-31 Havoc Pennington <hp@redhat.com>
3123 Fix some annoying DBusString API and fix all affected code.
3125 * dbus/dbus-string.c (_dbus_string_init): get rid of annoying
3127 (_dbus_string_get_data): change to return string instead of using
3129 (_dbus_string_get_const_data): ditto
3130 (_dbus_string_get_data_len): ditto
3131 (_dbus_string_get_const_data_len): ditto
3133 2003-03-31 Havoc Pennington <hp@redhat.com>
3135 * bus/main.c (main): fix up the command line arguments to be nicer
3137 2003-03-31 Havoc Pennington <hp@redhat.com>
3139 * dbus/Makefile.am (INCLUDES): use EXPANDED_LOCALSTATEDIR to
3140 define DBUS_SYSTEM_BUS_PATH as we want to compile in the same
3141 final location that lands in the config file
3143 * bus/config-loader-expat.c (bus_config_load): fix type of
3146 * doc/TODO: remove TODO item for dbus_bus_get()
3148 * dbus/dbus-bus.c (bus_data_free): add missing lock/unlock
3150 2003-03-31 Havoc Pennington <hp@pobox.com>
3152 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_domain_socket)
3153 (_dbus_transport_new_for_tcp_socket): these didn't need the "server"
3154 argument since they are always client side
3156 * dbus/dbus-server.c (dbus_server_get_address): new function
3158 * bus/main.c (main): take the configuration file as an argument.
3160 * test/data/valid-config-files/debug-allow-all.conf: new file to
3161 use with dispatch.c tests for example
3163 * bus/test-main.c (main): require test data dir
3165 * bus/bus.c (bus_context_new): change this to take a
3166 configuration file name as argument
3168 * doc/config-file.txt (Elements): add <servicedir>
3170 * bus/system.conf, bus/session.conf: new files
3172 * dbus/dbus-bus.c (dbus_bus_get): look for system bus on
3173 well-known socket if none set
3175 * configure.in: create system.conf and session.conf
3177 2003-03-30 Havoc Pennington <hp@pobox.com>
3179 * bus/config-parser.c: hacking
3181 * dbus/dbus-memory.c: don't use DBusList for the list of stuff
3182 to shut down, since it could cause weirdness with the DBusList
3185 * dbus/dbus-list.c (_dbus_list_test): add tests for the
3186 link-oriented stack routines
3187 (alloc_link): free the mempool if the first alloc from it fails
3189 * dbus/dbus-mempool.c (struct DBusMemBlock): fix alignment issue
3191 * dbus/dbus-string.c (UNICODE_VALID): sync new version of this
3193 (_dbus_string_skip_white): new
3195 * doc/config-file.txt (Elements): add <includedir>
3197 2003-03-28 Havoc Pennington <hp@pobox.com>
3199 * dbus/dbus-string.c (_dbus_string_copy_data_len)
3200 (_dbus_string_copy_data): new functions
3202 2003-03-28 Anders Carlsson <andersca@codefactory.se>
3204 * dbus/dbus-bus.c: (bus_data_free), (dbus_bus_get):
3208 * dbus/dbus-memory.c:
3211 2003-03-28 Havoc Pennington <hp@pobox.com>
3213 * bus/test.c (bus_test_flush_bus): remove the sleep from here,
3214 I think it may have just been superstition. Not sure.
3216 * dbus/dbus-string.c (_dbus_string_base64_decode): catch some OOM
3217 failures that were not being handled.
3219 * dbus/dbus-auth.c (process_auth): fix a memleak in OOM handling
3221 * dbus/dbus-memory.c: add ability to set number of mallocs in a
3222 row that will fail on out-of-memory.
3224 * dbus/dbus-internals.c (_dbus_test_oom_handling): convenience
3225 function for testing out-of-memory handling.
3227 * bus/config-loader-expat.c (memsuite): don't wrap the dbus
3228 allocation functions, they do map exactly to the expat ones.
3230 2003-03-27 Havoc Pennington <hp@redhat.com>
3232 * bus/config-loader-libxml.c (bus_config_load): add another error
3235 2003-03-26 Anders Carlsson <andersca@codefactory.se>
3238 Add note about automatic service activation.
3240 * doc/dbus-specification.sgml:
3241 Rename the specification and clarify a few things.
3243 2003-03-26 Anders Carlsson <andersca@codefactory.se>
3246 * dbus/dbus-address.c:
3248 * dbus/dbus-marshal.c:
3249 * dbus/dbus-server-debug-pipe.c:
3250 * dbus/dbus-transport-unix.c:
3251 Fix documentation warnings.
3253 2003-03-26 Havoc Pennington <hp@pobox.com>
3255 * bus/test-main.c, dbus/dbus-test.c (main): check memleaks
3256 after every test so it's quick and easy to see which leaked, and
3257 so we test multiple dbus_shutdown() calls
3259 * configure.in: change configure.in XML stuff to also support
3262 * config-loader-libxml.c: some hacking
3264 * config-loader-expat.c: some hacking
3266 * config-parser.c: some hacking, plus tests
3268 2003-03-25 Havoc Pennington <hp@redhat.com>
3270 * throughout - add more _DBUS_ASSERT_ERROR_IS_CLEAR
3272 * configure.in: add --with-xml option to specify XML library,
3273 right now only libxml is supported.
3275 * bus/config-loader-libxml.c, config-parser.c: sync some minor
3276 nonworking code between home and work, still just stubs
3278 2003-03-24 Havoc Pennington <hp@redhat.com>
3280 * dbus/dbus-sysdeps.c (_dbus_set_fd_nonblocking): move to this
3283 * dbus/dbus-errors.c (dbus_set_error, dbus_set_error_const): allow
3284 NULL argument for "message" if the error is a well-known one,
3285 fill in a generic message in this case.
3287 * dbus/dbus-errors.h (DBusResultCode): Kill DBusResultCode in
3290 * bus/test.c (bus_test_flush_bus): add
3292 * bus/policy.c (bus_policy_test): test code stub
3294 2003-03-24 Havoc Pennington <hp@pobox.com>
3296 * bus/connection.c (bus_connections_setup_connection): set up
3297 the "can this user connect" function, but it always returns
3298 TRUE until we have a config file parser so we can have a config
3299 file that allows connections.
3301 2003-03-23 Havoc Pennington <hp@pobox.com>
3303 * dbus/dbus-threads.c (dbus_mutex_new, dbus_condvar_new): with
3304 DBUS_BUILD_TESTS, actually alloc/free a block of memory for
3305 the mutex, so we can check for proper memory management
3308 * dbus/dbus-dataslot.c: remove the mutex from
3309 DBusDataSlotAllocator and lock it manually when using it,
3310 to simplify fitting it into the global slots framework.
3312 * dbus/dbus-threads.c (init_static_locks): rework how we're
3313 handling global locks so they are easily shut down.
3315 * bus/policy.c (bus_policy_append_rule): fix
3317 * bus/test-main.c (main): check for memleaks
3319 * dbus/dbus-test.c (dbus_internal_do_not_use_run_tests): make
3320 test suite check for memleaks
3322 * dbus/dbus-memory.c: add support in test mode for tracking
3323 number of outstanding blocks
3325 2003-03-23 Havoc Pennington <hp@pobox.com>
3327 * bus/policy.c, bus/bus.c, bus/connection.c: implement allow/deny
3330 * dbus/dbus-hash.h: add ULONG hash keys
3332 * dbus/dbus-sysdeps.c (_dbus_get_groups): new
3333 (_dbus_get_group_id): new function
3335 2003-03-20 Havoc Pennington <hp@redhat.com>
3337 * dbus/dbus-connection.c (dbus_connection_set_unix_user_function):
3339 (dbus_connection_get_unix_user): new function
3341 2003-03-20 Havoc Pennington <hp@pobox.com>
3343 * bus/connection.c (bus_connection_send_oom_error): assert that
3344 message has a sender
3345 (connection_execute_transaction): ditto
3346 (bus_connection_preallocate_oom_error): fix to set the sender, and
3347 set recipient to the destination service, not the bus driver
3349 * bus/policy.c: hacking
3351 * dbus/dbus-message.c (dbus_message_service_is): new function
3352 (dbus_message_sender_is): new
3354 2003-03-19 Havoc Pennington <hp@redhat.com>
3356 * bus/policy.c: start sketching code for policy restrictions on
3357 what connections can do.
3359 2003-03-18 Havoc Pennington <hp@redhat.com>
3361 * doc/TODO: some notes on high-level todo items. Little nitpick
3362 stuff is all in @todo, so no need to add it here.
3364 * doc/config-file.txt: some notes on how config file might look
3366 2003-03-18 Anders Carlsson <andersca@codefactory.se>
3372 2003-03-17 Havoc Pennington <hp@redhat.com>
3374 * dbus/dbus-internals.h: add gcc attributes so that
3375 our printf-style functions warn on bad arguments to
3378 * dbus/dbus-sysdeps.c (_dbus_connect_tcp_socket): fix printf
3381 * dbus/dbus-message.c (_dbus_message_loader_queue_messages): fix
3384 2003-03-17 Havoc Pennington <hp@redhat.com>
3386 * bus/test-main.c (main): make it print something as it runs
3387 so make check doesn't look stuck
3389 * doc/negotiation.txt, doc/dbus-sasl-profile.txt: remove
3390 from CVS, now obsolete
3392 2003-03-17 Anders Carlsson <andersca@codefactory.se>
3394 * bus/dispatch.c: (bus_dispatch):
3395 Refetch the service name since it may have been reallocated
3396 when dbus_message_set_sender was called.
3398 * dbus/dbus-sysdeps.c: (_dbus_accept):
3399 Add address and address length variables and use them to stop
3400 valgrind from complaining.
3402 2003-03-17 Havoc Pennington <hp@pobox.com>
3404 All tests pass, no memleaks, no valgrind complaints.
3406 * bus/test.c: refcount handler_slot
3408 * bus/connection.c (bus_connections_new): refcount
3409 connection_data_slot
3411 * dbus/dbus-auth-script.c (_dbus_auth_script_run): delete unused
3412 bytes so that auth scripts pass.
3414 * bus/dispatch.c: init message_handler_slot so it gets allocated
3417 * bus/dispatch.c (message_handler_slot_ref): fix memleak
3419 * dbus/dbus-server-debug-pipe.c (_dbus_server_debug_pipe_new):
3420 dealloc server_pipe_hash when no longer used for benefit of
3423 * dbus/dbus-auth.c (process_command): memleak fix
3425 * bus/dispatch.c (check_hello_message): memleak fix
3427 2003-03-16 Havoc Pennington <hp@pobox.com>
3429 * dbus/dbus-bus.c (ensure_bus_data): fix double-unref of the data slot
3431 2003-03-17 Anders Carlsson <andersca@codefactory.se>
3433 * bus/activation.c (bus_activation_activate_service): Append
3434 the pending activation entry to the list of pending activations.
3436 2003-03-16 Havoc Pennington <hp@pobox.com>
3438 * bus/dispatch.c (bus_dispatch_test): remove double-unrefs of
3441 * dbus/dbus-address.c (create_entry): fix OOM handling when
3442 failing to alloc entry->method
3444 2003-03-16 Havoc Pennington <hp@pobox.com>
3446 * dbus/dbus-watch.c (_dbus_watch_new): handle failure to malloc
3449 * dbus/dbus-server-debug-pipe.c (_dbus_transport_debug_pipe_new):
3450 add some missing dbus_set_result
3452 * bus/dispatch.c (bus_dispatch_add_connection): handle failure to
3453 alloc the DBusMessageHandler
3455 * dbus/dbus-transport.c (_dbus_transport_disconnect): don't ref
3456 the transport here, since we call this from the finalizer; it
3457 resulted in a double-finalize.
3459 * dbus/dbus-transport.c (_dbus_transport_disconnect): fix a bug
3460 where we tried to use transport->connection that was NULL,
3461 happened when transport was disconnected early on due to OOM
3463 * bus/*.c: adapt to handle OOM for watches/timeouts
3465 * dbus/dbus-transport-unix.c: port to handle OOM during
3468 * dbus/dbus-auth.c (_dbus_auth_get_unused_bytes): return a
3469 reference to unused bytes instead of a copy
3471 * dbus/dbus-server.c (dbus_server_handle_watch): return FALSE for
3474 * dbus/dbus-connection.c (dbus_connection_handle_watch): return
3477 * dbus/dbus-timeout.c (dbus_timeout_handle): return FALSE for out
3480 2003-03-16 Anders Carlsson <andersca@codefactory.se>
3482 * doc/dbus-specification.sgml:
3483 Document reply message for ActivateService.
3485 2003-03-16 Anders Carlsson <andersca@codefactory.se>
3487 * bus/activation.c: (bus_pending_activation_entry_free),
3488 (bus_pending_activation_free), (bus_activation_new),
3489 (bus_activation_unref), (bus_activation_service_created),
3490 (bus_activation_activate_service):
3492 * bus/bus.c: (bus_context_new):
3493 * bus/desktop-file.c: (new_section):
3494 * bus/driver.c: (bus_driver_send_service_deleted),
3495 (bus_driver_handle_activate_service):
3496 * bus/services.c: (bus_registry_new), (bus_registry_ensure):
3498 * dbus/dbus-connection.c:
3499 (dbus_connection_send_with_reply_and_block):
3500 * dbus/dbus-message.c: (dbus_message_append_args_valist):
3501 * dbus/dbus-protocol.h:
3502 Make activation work better. Now pending activations will be queued
3503 and the daemon won't try to activate services that are already registered.
3505 2003-03-16 Havoc Pennington <hp@pobox.com>
3507 * dbus/dbus-bus.c (ensure_bus_data): handle failure to set
3510 * dbus/dbus-memory.c (_dbus_initialize_malloc_debug): support
3511 DBUS_MALLOC_BACKTRACES to print trace when failing an alloc
3513 2003-03-16 Havoc Pennington <hp@pobox.com>
3515 * dbus/dbus-string.c (_dbus_string_validate_utf8): oops, unbreak
3516 this. always run the test suite before commit...
3518 * bus/*: adapt to DBusConnection API changes
3520 * glib/dbus-gmain.c: adapt to DBusConnection API changes,
3521 requires renaming stuff to avoid dbus_connection_dispatch name
3524 * dbus/dbus-transport.c (_dbus_transport_queue_messages): new
3527 * dbus/dbus-message.c (_dbus_message_loader_queue_messages):
3528 separate from _dbus_message_loader_return_buffer()
3530 * dbus/dbus-connection.c (dbus_connection_get_n_messages): remove
3531 this, because it's now always broken to use; the number of
3532 messages in queue vs. the number still buffered by the message
3533 loader is undefined/meaningless. Should use
3534 dbus_connection_get_dispatch_state().
3535 (dbus_connection_dispatch): rename from
3536 dbus_connection_dispatch_message
3538 2003-03-16 Havoc Pennington <hp@pobox.com>
3540 * dbus/dbus-string.c (_dbus_string_validate_utf8): copy in a real
3543 2003-03-16 Anders Carlsson <andersca@codefactory.se>
3545 * dbus/dbus-connection.c:
3546 (dbus_connection_send_with_reply_and_block):
3547 Decrease connection->n_incoming when removing an entry
3549 * dbus/dbus-dict.c: (dbus_dict_entry_free),
3550 (dbus_dict_set_boolean_array), (dbus_dict_set_int32_array),
3551 (dbus_dict_set_uint32_array), (dbus_dict_set_double_array),
3552 (dbus_dict_set_byte_array), (dbus_dict_set_string_array),
3553 (dbus_dict_get_boolean_array), (dbus_dict_get_double_array),
3554 (dbus_dict_get_byte_array):
3555 Handle NULL arrays and strings. Also add support for byte arrays.
3557 * dbus/dbus-marshal.c: (_dbus_marshal_byte_array),
3558 (_dbus_marshal_dict), (_dbus_demarshal_byte_array),
3559 (_dbus_demarshal_int32_array), (_dbus_demarshal_uint32_array),
3560 (_dbus_demarshal_double_array), (_dbus_demarshal_string_array),
3561 (_dbus_demarshal_dict), (demarshal_and_validate_len),
3562 (_dbus_marshal_validate_arg), (_dbus_marshal_test):
3563 * dbus/dbus-marshal.h:
3564 Add support for marshalling and demarshalling empty arrays and strings.
3566 * dbus/dbus-message.c: (dbus_message_append_args_valist),
3567 (dbus_message_append_string_array),
3568 (dbus_message_iter_get_boolean),
3569 (dbus_message_iter_get_boolean_array),
3570 (dbus_message_iter_get_int32_array),
3571 (dbus_message_iter_get_uint32_array),
3572 (dbus_message_iter_get_double_array),
3573 (dbus_message_iter_get_byte_array),
3574 (dbus_message_iter_get_string_array), (dbus_message_iter_get_dict),
3575 (check_message_handling):
3576 Add support for getting empty arrays and dicts.
3578 * dbus/dbus-string.c: (_dbus_string_validate_utf8):
3579 Don't do any validation at all for now, that's better than just checking
3582 * test/data/valid-messages/emptiness.message:
3583 New test message with lots of empty arrays.
3585 2003-03-16 Havoc Pennington <hp@pobox.com>
3587 * dbus/dbus-connection.c
3588 (_dbus_connection_queue_received_message_link): new function that
3589 can't fail due to OOM
3591 * dbus/dbus-message.c (_dbus_message_loader_pop_message_link):
3592 new function pops a message together with a list link
3595 * dbus/dbus-transport-unix.c (queue_messages): use new link-based
3596 message queuing functions to avoid needing to alloc memory
3598 2003-03-16 Havoc Pennington <hp@pobox.com>
3600 Oops - test code was only testing failure of around 30 of the
3601 mallocs in the test path, but it turns out there are 500+
3602 mallocs. I believe this was due to misguided linking setup such
3603 that there was one copy of dbus_malloc etc. in the daemon and one
3604 in the shared lib, and only daemon mallocs were tested. In any
3605 case, the test case now tests all 500+ mallocs, and doesn't pass
3606 yet, though there are lots of fixes in this patch.
3608 * dbus/dbus-connection.c (dbus_connection_dispatch_message): fix
3609 this so that it doesn't need to allocate memory, since it
3610 has no way of indicating failure due to OOM (and would be
3611 annoying if it did).
3613 * dbus/dbus-list.c (_dbus_list_pop_first_link): new function
3615 * bus/Makefile.am: rearrange to create two self-contained
3616 libraries, to avoid having libraries with overlapping symbols.
3617 that was resulting in weirdness, e.g. I'm pretty sure there
3618 were two copies of global static variables.
3620 * dbus/dbus-internals.c: move the malloc debug stuff to
3623 * dbus/dbus-list.c (free_link): free list mempool if it becomes
3626 * dbus/dbus-memory.c (_dbus_disable_mem_pools): new function
3628 * dbus/dbus-address.c (dbus_parse_address): free list nodes
3631 * bus/dispatch.c (bus_dispatch_add_connection): free
3632 message_handler_slot when no longer using it, so
3633 memory leak checkers are happy for the test suite.
3635 * dbus/dbus-server-debug-pipe.c (debug_finalize): free server name
3637 * bus/bus.c (new_connection_callback): disconnect in here if
3638 bus_connections_setup_connection fails.
3640 * bus/connection.c (bus_connections_unref): fix to free the
3642 (bus_connections_setup_connection): if this fails, don't
3643 disconnect the connection, just be sure there are no side
3646 * dbus/dbus-string.c (undo_alignment): unbreak this
3648 * dbus/dbus-auth.c (_dbus_auth_unref): free some stuff we were
3650 (_dbus_auth_new): fix the order in which we free strings
3653 * bus/connection.c (bus_connection_disconnected): fix to
3654 not send ServiceDeleted multiple times in case of memory
3657 * dbus/dbus-bus.c (dbus_bus_get_base_service): new function to
3658 get the base service name
3659 (dbus_bus_register_client): don't return base service name,
3660 instead store it on the DBusConnection and have an accessor
3662 (dbus_bus_register_client): rename dbus_bus_register()
3664 * bus/dispatch.c (check_hello_message): verify that other
3665 connections on the bus also got the correct results, not
3666 just the one sending hello
3668 2003-03-15 Havoc Pennington <hp@pobox.com>
3670 Make it pass the Hello handling test including all OOM codepaths.
3671 Now to do other messages...
3673 * bus/services.c (bus_service_remove_owner): fix crash when
3674 removing owner from an empty list of owners
3675 (bus_registry_ensure): don't leave service in the list of
3676 a connection's owned services if we fail to put the service
3679 * bus/connection.c (bus_connection_preallocate_oom_error): set
3680 error flag on the OOM error.
3682 * dbus/dbus-connection.c (_dbus_connection_new_for_transport):
3683 handle _dbus_transport_set_connection failure
3685 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_fd): modify
3686 to create watches up front and simply enable/disable them as
3688 (unix_connection_set): this can now fail on OOM
3690 * dbus/dbus-timeout.c, dbus/dbus-watch.c: add concept
3691 of enabling/disabling a watch or timeout.
3693 * bus/loop.c (bus_loop_iterate): don't touch disabled
3696 * glib/dbus-gmain.c: adapt to enable/disable watches and timeouts
3698 2003-03-15 Havoc Pennington <hp@pobox.com>
3700 * bus/dispatch.c (bus_dispatch_test): OK, now finally actually
3701 write useful test code, after all that futzing around ;-)
3703 Test does not yet pass because we can't handle OOM in
3704 _dbus_transport_messages_pending (basically,
3705 dbus_connection_preallocate_send() does not prealloc the write
3706 watch). To fix this, I think we need to add new stuff to
3707 set_watch_functions, namely a SetEnabled function so we can alloc
3708 the watch earlier, then enable it later.
3710 * dbus/Makefile.am (libdbus_convenience_la_SOURCES): move
3711 dbus-memory.c to the convenience lib
3713 * bus/test.c: rename some static functions to keep them clearly
3714 distinct from stuff in connection.c. Handle client disconnection.
3716 2003-03-14 Havoc Pennington <hp@pobox.com>
3718 * bus/dispatch.c (bus_dispatch_test): do test using debug-pipe
3719 transport, tests more of the real codepath. Set up clients
3720 with bus_setup_debug_client.
3722 * bus/test.c (bus_setup_debug_client): function to set up debug
3723 "clients" on the main loop
3725 * dbus/dbus-transport.c (_dbus_transport_open): add debug-pipe
3728 * dbus/dbus-server.c (dbus_server_listen): add debug-pipe
3731 * dbus/dbus-server-debug.c: support a debug server based on pipes
3733 * dbus/dbus-sysdeps.c (_dbus_full_duplex_pipe): new function
3734 (_dbus_close): new function
3736 * configure.in: check for socketpair
3738 2003-03-14 Havoc Pennington <hp@redhat.com>
3740 * dbus/dbus-memory.c: add a "detect buffer overwrites on free"
3743 * dbus/dbus-transport-debug.c: rework this a good bit to be
3744 less complicated. hopefully still works.
3746 * dbus/dbus-server-debug.c (handle_new_client): remove timeout
3749 * glib/dbus-gmain.c (timeout_handler): don't remove timeout
3752 * dbus/dbus-message.c (dbus_message_copy): rename from
3753 dbus_message_new_from_message, fix it up to copy
3754 all the message fields, add test case
3756 * bus/dispatch.c (bus_dispatch_test): add some more test code,
3757 not quite passing yet
3759 2003-03-14 Havoc Pennington <hp@pobox.com>
3761 * bus/loop.c (bus_loop_iterate): add this so we can "run loop
3762 until no work remains" in test code. (the large diff here
3763 is just code movement, no actual changes)
3765 * dbus/dbus-server-debug.c (DEFAULT_INTERVAL): change interval to
3766 1, no point waiting around for test code.
3767 (_dbus_server_debug_accept_transport): unref the timeout
3768 after adding it (right?)
3770 * dbus/dbus-transport-debug.c (DEFAULT_INTERVAL): ditto
3772 2003-03-13 Havoc Pennington <hp@redhat.com>
3774 * dbus/dbus-timeout.c (_dbus_timeout_list_set_functions): handle
3777 * dbus/dbus-watch.c (_dbus_watch_list_set_functions): handle out
3780 * dbus/dbus-connection.h: Make AddWatchFunction and
3781 AddTimeoutFunction return a bool so they can fail on out-of-memory
3783 * bus/bus.c (bus_context_new): set up timeout handlers
3785 * bus/connection.c (bus_connections_setup_connection): set up
3788 * glib/dbus-gmain.c: adapt to the fact that set_functions stuff
3791 * bus/bus.c (bus_context_new): adapt to changes
3793 * bus/connection.c: adapt to changes
3795 * test/watch.c: adapt to DBusWatch changes
3797 * bus/dispatch.c (bus_dispatch_test): started adding this but
3800 2003-03-14 Anders Carlsson <andersca@codefactory.se>
3802 * bus/dispatch.c (send_service_nonexistent_error): Fix typo.
3804 2003-03-13 Havoc Pennington <hp@pobox.com>
3806 * bus/test.c, bus/test.h, bus/Makefile.am, bus/test-main.c:
3807 set up a test framework as for the library
3809 2003-03-12 Havoc Pennington <hp@pobox.com>
3811 Throughout: purge global variables, introduce BusActivation,
3812 BusConnections, BusRegistry, etc. objects instead.
3814 * bus/bus.h, bus/bus.c: introduce BusContext as a global
3817 * test/Makefile.am (TEST_BINARIES): disable bus-test for now,
3818 going to redo this a bit differently I think
3820 2003-03-12 Havoc Pennington <hp@redhat.com>
3822 Mega-patch that gets the message bus daemon initially handling
3823 out-of-memory. Work still needed. Also lots of random
3824 moving stuff to DBusError instead of ResultCode.
3826 * dbus/dbus-list.c (_dbus_list_length_is_one): new function
3828 * dbus/dbus-connection.c
3829 (dbus_connection_send_with_reply_and_block): use DBusError
3831 * dbus/dbus-bus.c: adapt to API changes, make it use DBusError not
3834 * dbus/dbus-connection.c (dbus_connection_send): drop the result
3835 code here, as the only failure possible is OOM.
3837 * bus/connection.c (bus_connection_disconnect):
3838 rename bus_connection_disconnected as it's a notification only
3840 * bus/driver.c (bus_driver_handle_acquire_service): don't free
3841 "name" on get_args failure, should be done by get_args;
3842 don't disconnect client for bad args, just return an error.
3843 (bus_driver_handle_service_exists): ditto
3845 * bus/services.c (bus_services_list): NULL-terminate returned array
3847 * bus/driver.c (bus_driver_send_service_lost)
3848 (bus_driver_send_service_acquired): send messages from driver to a
3849 specific client to the client's unique name, not to the broadcast
3852 * dbus/dbus-message.c (decode_header_data): reject messages that
3853 contain no name field
3854 (_dbus_message_get_client_serial): rename to
3855 dbus_message_get_serial and make public
3856 (_dbus_message_set_serial): rename from set_client_serial
3857 (_dbus_message_set_reply_serial): make public
3858 (_dbus_message_get_reply_serial): make public
3860 * bus/connection.c (bus_connection_foreach): allow stopping
3861 iteration by returning FALSE from foreach function.
3863 * dbus/dbus-connection.c (dbus_connection_send_preallocated)
3864 (dbus_connection_free_preallocated_send)
3865 (dbus_connection_preallocate_send): new API for sending a message
3866 without possibility of malloc failure.
3867 (dbus_connection_send_message): rename to just
3868 dbus_connection_send (and same for whole function family)
3870 * dbus/dbus-errors.c (dbus_error_free): make this reinit the error
3872 * dbus/dbus-sysdeps.c (_dbus_exit): new function
3874 * bus/activation.c: handle/return errors
3876 * dbus/dbus-errors.h: add more DBUS_ERROR #define
3878 * dbus/dbus-sysdeps.c (_dbus_directory_open) (_dbus_file_get_contents)
3879 (_dbus_directory_get_next_file): use DBusError instead of DBusResultCode
3880 (_dbus_result_from_errno): move to this file
3882 2003-03-10 Anders Carlsson <andersca@codefactory.se>
3884 * dbus/dbus-marshal.c:
3885 (_dbus_marshal_set_string):
3886 Take a length argument so we can marshal the correct string
3889 (_dbus_marshal_dict), (_dbus_demarshal_dict),
3890 (_dbus_marshal_get_arg_end_pos), (_dbus_marshal_validate_arg),
3891 (_dbus_marshal_test):
3892 * dbus/dbus-marshal.h:
3893 Add support for marshalling and demarshalling dicts.
3895 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
3896 Add support for TYPE DICT.
3898 * dbus/dbus-message.c: (set_string_field):
3899 Adjust header padding.
3901 (dbus_message_append_args_valist), (dbus_message_append_dict),
3902 (dbus_message_get_args_valist), (dbus_message_iter_get_arg_type),
3903 (dbus_message_iter_get_dict), (_dbus_message_loader_return_buffer),
3904 (check_message_handling), (check_have_valid_message):
3905 * dbus/dbus-message.h:
3906 Add functions for setting and getting dicts.
3908 * dbus/dbus-protocol.h:
3914 * doc/dbus-specification.sgml:
3915 Add information about how dicts are marshalled.
3917 * test/data/invalid-messages/dict-with-nil-value.message:
3918 * test/data/invalid-messages/too-short-dict.message:
3919 * test/data/valid-messages/dict-simple.message:
3920 * test/data/valid-messages/dict.message:
3921 Add sample messages containing dicts.
3923 2003-03-08 Anders Carlsson <andersca@codefactory.se>
3925 * dbus/dbus-dict.h: Add DBUS_END_DECLS.
3927 2003-03-07 Anders Carlsson <andersca@codefactory.se>
3930 * dbus/dbus-dict.c: (dbus_dict_entry_free), (dbus_dict_new),
3931 (dbus_dict_get_keys), (insert_entry), (dbus_dict_set_boolean),
3932 (dbus_dict_set_int32), (dbus_dict_set_uint32),
3933 (dbus_dict_set_double), (dbus_dict_set_string),
3934 (dbus_dict_set_boolean_array), (dbus_dict_set_int32_array),
3935 (dbus_dict_set_uint32_array), (dbus_dict_set_double_array),
3936 (dbus_dict_set_string_array), (_dbus_dict_test):
3938 Fix according to comments from Havoc.
3940 2003-03-06 Michael Meeks <michael@server.home>
3942 * configure.in: if we don't have kde-config, disable have_qt.
3944 2003-03-07 Anders Carlsson <andersca@codefactory.se>
3949 * dbus/dbus-dict.c: (dbus_dict_entry_free), (dbus_dict_new),
3950 (dbus_dict_ref), (dbus_dict_unref), (dbus_dict_contains),
3951 (dbus_dict_remove), (dbus_dict_get_value_type),
3952 (dbus_dict_get_keys), (dbus_dict_put_boolean),
3953 (dbus_dict_put_int32), (dbus_dict_put_uint32),
3954 (dbus_dict_put_double), (dbus_dict_put_string),
3955 (dbus_dict_put_boolean_array), (dbus_dict_put_int32_array),
3956 (dbus_dict_put_uint32_array), (dbus_dict_put_double_array),
3957 (dbus_dict_put_string_array), (dbus_dict_get_boolean),
3958 (dbus_dict_get_int32), (dbus_dict_get_uint32),
3959 (dbus_dict_get_double), (dbus_dict_get_string),
3960 (dbus_dict_get_boolean_array), (dbus_dict_get_int32_array),
3961 (dbus_dict_get_uint32_array), (dbus_dict_get_double_array),
3962 (dbus_dict_get_string_array), (_dbus_dict_test):
3964 Add DBusDict implementation
3966 * dbus/dbus-test.c: (dbus_internal_do_not_use_run_tests):
3970 2003-03-04 Havoc Pennington <hp@pobox.com>
3972 * test/data/auth/*: adapt to changes
3974 * dbus/dbus-auth-script.c (_dbus_auth_script_run): add
3975 USERID_BASE64 and change USERNAME_BASE64 to put in username not
3978 * dbus/dbus-keyring.c (_dbus_keyring_validate_context): prevent
3979 more stuff from being in a context name, to make the protocol
3980 simpler to deal with
3982 * dbus/dbus-errors.c (dbus_error_has_name): new function
3983 (dbus_error_is_set): new function
3985 * dbus/dbus-auth.c: replace DBUS_STUPID_TEST_MECH auth
3986 with DBUS_COOKIE_SHA1, implement DBUS_COOKIE_SHA1
3988 * dbus/dbus-connection.c (dbus_connection_flush): also read
3989 messages during a flush operation
3991 * dbus/Makefile.am: remove dbus-md5 since it isn't currently used.
3993 2003-03-05 Anders Carlsson <andersca@codefactory.se>
3995 * configure.in: Check for gethostbyname on Solaris.
3997 * dbus/dbus-transport.c: (_dbus_transport_open):
3998 Remove duplicate "tcp" entry.
4000 * doc/dbus-specification.sgml:
4001 Clarify some things.
4003 2003-03-05 Anders Carlsson <andersca@codefactory.se>
4005 * dbus/dbus-auth.c: (send_rejected), (process_test_subdir):
4006 * dbus/dbus-keyring.c: (_dbus_keyring_new_homedir),
4007 (_dbus_keyring_test):
4008 * dbus/dbus-md5.c: (_dbus_md5_compute):
4009 * dbus/dbus-sha.c: (_dbus_sha_compute):
4012 2003-03-05 Anders Carlsson <andersca@codefactory.se>
4014 * README: Add some things.
4016 2003-03-04 Anders Carlsson <andersca@codefactory.se>
4018 * dbus/dbus-message.c (dbus_message_append_args_valist): Add a break;
4019 after case DBUS_TYPE_BOOELAN.
4021 2003-03-02 Havoc Pennington <hp@pobox.com>
4023 * test/break-loader.c (randomly_set_extreme_ints): add test that
4024 sets really huge and small integers
4026 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): add check
4027 that length of boolean array fits in the string, and that
4028 string has room for boolean value in single-bool case.
4030 * dbus/dbus-message-builder.c (_dbus_message_data_load): add
4031 optional value to "ALIGN" command which is what to fill the
4034 * test/data/valid-messages/no-padding.message: add regression
4035 test for the message padding problem
4037 2003-03-02 Havoc Pennington <hp@pobox.com>
4039 * dbus/dbus-message.c (decode_header_data): fix to always init
4040 message_padding, from Benjamin Dauvergne
4042 2003-03-02 Havoc Pennington <hp@pobox.com>
4048 2003-03-01 Joe Shaw <joe@assbarn.com>
4050 * configure.in: Check for "struct cmsgcred" and try to access its
4051 members for BSD-like unices.
4053 * dbus/dbus-sysdeps.c (read_credentials_byte): Fold this back into
4054 _dbus_read_credentials_unix_socket().
4055 (_dbus_read_credentials_unix_socket): Use recvmsg() instead of
4056 read() for reading the credential byte off the unix socket. Use
4057 struct cmsgcred on systems that support it.
4059 2003-02-27 Alexander Larsson <alexl@redhat.com>
4063 Make gthreads-2.0 dependency optional. Don't build thread test if
4066 2003-02-27 Havoc Pennington <hp@pobox.com>
4068 * dbus/dbus-connection.c
4069 (dbus_connection_send_message_with_reply_and_block): fix doh!
4070 doh! doh! bug that resulted in never removing a reply from the
4071 queue, no wonder we called get_reply_serial so much ;-)
4073 * dbus/dbus-message.c (struct DBusMessage): cache reply serial
4074 and client serial instead of demarshaling them every time
4076 2003-02-27 Havoc Pennington <hp@pobox.com>
4078 * dbus/dbus-marshal.c (_dbus_demarshal_int32): rewrite to be much
4079 more inlined, using dbus-string-private.h, speeds things up
4082 * dbus/dbus-string.c (_dbus_string_free): apply align offset
4083 when freeing the string
4084 (_dbus_string_steal_data): fix for align offset
4085 (undo_alignment): new function
4087 2003-02-26 Havoc Pennington <hp@redhat.com>
4089 All kinds of audit fixes from Owen, plus initial attempt to
4090 handle unaligned memory returned from malloc.
4092 * dbus/dbus-string.c (_dbus_string_init): clamp max length to
4093 leave room for align_offset and nul byte
4094 (fixup_alignment): function to track an align_offset and
4095 ensure real->str is aligned
4096 (DBUS_GENERIC_STRING_PREAMBLE): len must be less than allocated,
4097 to allow a nul byte plus align offset
4098 (_dbus_string_lock): fix overflow issue
4099 (_dbus_string_init_const_len): add assertions on sanity of len,
4100 assign allocated to be ALLOCATION_PADDING larger than len
4101 (set_length): fixup the overflow handling
4102 (_dbus_string_get_data_len): fix overflow in assertion
4103 (open_gap): detect overflow in size of gap to be opened
4104 (_dbus_string_lengthen): add overflow check
4105 (_dbus_string_align_length): fix overflow with _DBUS_ALIGN_VALUE
4106 (_dbus_string_append): add overflow check
4107 (_dbus_string_append_unichar): overflow
4108 (_dbus_string_delete): fix overflow in assertion
4109 (_dbus_string_copy_len): overflow in assertion
4110 (_dbus_string_replace_len): overflows in assertions
4111 (_dbus_string_find): change to implement in terms of
4112 _dbus_string_find_to
4113 (_dbus_string_find_to): assorted fixage
4114 (_dbus_string_equal_c_str): assert c_str != NULL,
4115 fix logic so the function works
4116 (_dbus_string_ends_with_c_str): fix overflow thingy
4117 (_dbus_string_base64_encode): overflow fix
4118 (_dbus_string_validate_ascii): overflow
4119 (_dbus_string_validate_nul): overflow
4121 2003-02-26 Havoc Pennington <hp@redhat.com>
4123 * dbus/dbus-marshal.c (_dbus_marshal_test): fix to work with DISABLE_ASSERTS
4125 2003-02-26 Alexander Larsson <alexl@redhat.com>
4128 Set DBUS_GLIB_THREADS_LIBS for apps using gthread-2.0
4130 * dbus/dbus-connection.c:
4131 * dbus/dbus-connection.h:
4132 Fix _dbus_connection_acquire_io_path and _dbus_connection_acquire_dispatch.
4133 Add dbus_connection_set_wakeup_main_function and use it when queueing
4134 incoming and outgoing messages.
4137 * dbus/dbus-dataslot.c:
4138 Threadsafe usage of DBusDataSlotAllocator
4140 * dbus/dbus-message.c: (dbus_message_get_args_iter):
4143 * dbus/dbus-server-unix.c:
4146 * glib/dbus-gmain.c:
4147 Implement the new wakeup functions for glib.
4150 * glib/test-thread-client.c:
4151 * glib/test-thread-server.c:
4152 * glib/test-thread.h:
4153 Initial cut at some thread test code. Not really done yet.
4155 2003-02-26 Havoc Pennington <hp@pobox.com>
4157 * dbus/dbus-connection.c
4158 (dbus_connection_send_message_with_reply_and_block): fix crash
4159 where we ref'd the outgoing message instead of the returned reply
4161 * dbus/dbus-transport-unix.c (do_authentication): check read watch
4162 at the end of this function, so if we didn't need to read for
4163 authentication, we reinstall it for receiving messages
4165 * dbus/dbus-message.c (dbus_message_new_reply): allow replies to
4166 a NULL sender for peer-to-peer case
4168 * dbus/dbus-transport-unix.c (check_read_watch): handle
4169 !authenticated case correctly
4171 * glib/dbus-gmain.c: add support for DBusServer
4173 * dbus/dbus-server.c: add data slot support
4175 * glib/dbus-gmain.c (dbus_connection_setup_with_g_main): check
4176 return values and handle errors
4178 * dbus/dbus-dataslot.c: factor out the data slot stuff from
4181 * Doxyfile.in (INPUT): add glib subdir
4183 * glib/dbus-gmain.c (dbus_connection_setup_with_g_main): rename
4184 setup_with_g_main instead of hookup_with_g_main; write docs
4186 2003-02-24 Anders Carlsson <andersca@codefactory.se>
4188 * dbus/dbus-marshal.c: (_dbus_marshal_validate_arg):
4189 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
4190 * dbus/dbus-message.c: (dbus_message_append_boolean),
4191 (dbus_message_append_boolean_array),
4192 (dbus_message_get_args_valist), (_dbus_message_test):
4193 * dbus/dbus-message.h:
4194 * doc/dbus-specification.sgml:
4195 Various fixes as pointed out by Havoc.
4197 * test/data/invalid-messages/bad-boolean-array.message:
4198 * test/data/invalid-messages/bad-boolean.message:
4199 Add invalid boolean value test cases.
4201 2003-02-24 Anders Carlsson <andersca@codefactory.se>
4203 * dbus/dbus-internals.c: (_dbus_type_to_string):
4204 * dbus/dbus-marshal.c: (_dbus_marshal_get_arg_end_pos),
4205 (_dbus_marshal_validate_arg):
4206 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
4207 * dbus/dbus-message.c: (dbus_message_append_args_valist),
4208 (dbus_message_append_boolean), (dbus_message_append_boolean_array),
4209 (dbus_message_get_args_valist), (dbus_message_iter_get_boolean),
4210 (dbus_message_iter_get_int32), (dbus_message_iter_get_uint32),
4211 (dbus_message_iter_get_double),
4212 (dbus_message_iter_get_boolean_array), (message_iter_test):
4213 * dbus/dbus-message.h:
4214 * dbus/dbus-protocol.h:
4215 * doc/dbus-specification.sgml:
4216 * test/data/valid-messages/lots-of-arguments.message:
4217 Add support for boolean and boolean array types.
4219 2003-02-23 Havoc Pennington <hp@pobox.com>
4221 * dbus/dbus-keyring.c: finish most of this implementation and
4224 * dbus/dbus-errors.c (dbus_set_error_const, dbus_set_error): make
4225 these barf if the error isn't cleared to NULL
4227 * dbus/dbus-sysdeps.c (_dbus_delete_file): set error on failure
4228 (_dbus_create_directory): new function
4230 * dbus/dbus-errors.c (dbus_set_error): fix warning
4232 * dbus/dbus-string.c (_dbus_string_hex_encode): new function
4233 (_dbus_string_hex_decode): new function
4234 (test_hex_roundtrip): test code
4236 * dbus/dbus-sha.c (_dbus_sha_compute): use dbus_string_hex_encode
4238 * dbus/dbus-md5.c (_dbus_md5_compute): use dbus_string_hex_encode
4240 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): make this use
4241 the save-to-temp/rename trick to atomically write the new file
4242 (_dbus_string_parse_uint): new function
4244 2003-02-22 Havoc Pennington <hp@pobox.com>
4246 * test/Makefile.am (dist-hook): fix dist for test/data/sha-1
4248 2003-02-22 Havoc Pennington <hp@pobox.com>
4250 * dbus/dbus-message.c (dbus_message_iter_get_string_array):
4251 (dbus_message_iter_get_byte_array): Fix up doxygen warnings
4253 * dbus/dbus-sha.c: add implementation of SHA-1 algorithm
4255 * dbus/test/data/sha-1: add US government test suite for SHA-1
4257 2003-02-21 Anders Carlsson <andersca@codefactory.se>
4259 * dbus/dbus-marshal.c: (_dbus_demarshal_string_array):
4260 Make string arrays NULL-terminated.
4262 * dbus/dbus-memory.c: (dbus_free_string_array):
4263 * dbus/dbus-memory.h:
4264 New function for freeing NULL-terminated string arrays.
4266 * dbus/dbus-message-builder.c: (append_quoted_string),
4267 (_dbus_message_data_load):
4268 Add support for array types.
4270 * dbus/dbus-message.c: (check_message_handling):
4271 Add more types as test cases.
4273 * dbus/dbus-sysdeps.c: (_dbus_string_parse_int),
4274 (_dbus_string_parse_double):
4275 Add the start offset to the end offset.
4277 * test/data/valid-messages/lots-of-arguments.message:
4278 New test message with lots of arguments.
4280 2003-02-21 Anders Carlsson <andersca@codefactory.se>
4282 * dbus/dbus-message.c: (dbus_message_append_nil),
4283 (dbus_message_append_int32), (dbus_message_append_uint32),
4284 (dbus_message_append_double), (dbus_message_append_string),
4285 (dbus_message_append_int32_array),
4286 (dbus_message_append_uint32_array),
4287 (dbus_message_append_double_array),
4288 (dbus_message_append_byte_array),
4289 (dbus_message_append_string_array):
4290 Fix all out-of-memory handling in these functions.
4292 2003-02-21 Anders Carlsson <andersca@codefactory.se>
4294 * dbus/dbus-message.c: (dbus_message_append_nil):
4297 2003-02-21 Anders Carlsson <andersca@codefactory.se>
4299 * dbus/dbus-message.c: (dbus_message_append_args_valist),
4300 (dbus_message_append_nil), (dbus_message_append_int32_array),
4301 (dbus_message_append_uint32_array),
4302 (dbus_message_append_double_array),
4303 (dbus_message_append_byte_array),
4304 (dbus_message_append_string_array), (dbus_message_get_args_valist),
4305 (dbus_message_iter_get_int32_array),
4306 (dbus_message_iter_get_uint32_array),
4307 (dbus_message_iter_get_double_array),
4308 (dbus_message_iter_get_byte_array),
4309 (dbus_message_iter_get_string_array):
4311 * dbus/dbus-message.h:
4312 Add functions for appending and getting arrays.
4314 2003-02-21 Anders Carlsson <andersca@codefactory.se>
4316 * dbus/dbus-mempool.c (_dbus_mem_pool_new): Make the
4317 element size at least 8 bytes, fixes mempool tests on
4320 2003-02-20 Alexander Larsson <alexl@redhat.com>
4322 * dbus/dbus-transport-unix.c (unix_do_iteration):
4323 Unlock the connection mutex during a blocking select call.
4324 Add todo about how we need a way to wake up the select.
4326 * dbus/dbus-connection-internal.h:
4327 * dbus/dbus-connection.c:
4328 Add _dbus_connection_lock and _dbus_connection_unlock.
4330 2003-02-19 Havoc Pennington <hp@pobox.com>
4332 * Doxyfile.in (PREDEFINED): put DOXYGEN_SHOULD_SKIP_THIS in
4333 Doxyfile.in, not Doxyfile
4335 * dbus/dbus-keyring.c: do some hacking on this
4337 * dbus/dbus-sysdeps.c (_dbus_delete_file): new
4339 * dbus/dbus-errors.c (dbus_set_error_const): do not call
4341 (dbus_set_error): remove dbus_error_init, check for message ==
4342 NULL *before* we sprintf into it, and add @todo about including
4343 system headers in this file
4345 * dbus/dbus-sysdeps.c (_dbus_create_file_exclusively): new
4347 * dbus/dbus-errors.h (DBUS_ERROR_FAILED): add
4349 * dbus/dbus-sysdeps.c (get_user_info): break this function out to
4350 get various bits of user information based on either username
4352 (_dbus_homedir_from_username): new function
4354 2003-02-19 Anders Carlsson <andersca@codefactory.se>
4357 Add check for nonposix getpwnam_r
4359 * dbus/dbus-mempool.c: (_dbus_mem_pool_new):
4360 Align the pool element size to a sizeof (void *) boundary.
4362 * dbus/dbus-sysdeps.c: (_dbus_setenv), (_dbus_connect_unix_socket),
4363 (_dbus_listen_unix_socket), (_dbus_credentials_from_username):
4364 General Solaris fixes.
4366 * test/data/valid-messages/simplest-manual.message:
4367 Explicitly state that we want little-endian packing.
4369 2003-02-19 Mikael Hallendal <micke@codefactory.se>
4371 * dbus/dbus-server.c (dbus_server_listen): Support tcp: addresses.
4373 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_tcp_socket):
4374 Added to create a transport connecting using a tcp/ip socket.
4376 * dbus/dbus-sysdeps.c (_dbus_connect_tcp_socket): Added to connect
4377 to a tcp socket at given host and port.
4378 (_dbus_listen_tcp_socket): added to listen on tcp socket for given
4381 * dbus/dbus-server.c (dbus_server_listen): Support tcp: addresses.
4383 * dbus/dbus-server-unix.c (_dbus_server_new_for_tcp_socket):
4384 Added to create a server listening on a TCP/IP socket.
4386 2003-02-19 Havoc Pennington <hp@pobox.com>
4388 Throughout: mop up all the Doxygen warnings and undocumented
4391 * dbus/dbus-sysdeps.c (do_exec): do not use execvp, we don't want
4392 to search any paths.
4394 * dbus/dbus-threads.c: move global mutex initializers to
4395 dbus-internals.h, multiple prototypes was confusing doxygen
4396 besides being kind of ugly
4398 * Doxyfile (PREDEFINED): have Doxygen define
4399 DOXYGEN_SHOULD_SKIP_THIS so we can exclude things from
4400 docs with #ifndef DOXYGEN_SHOULD_SKIP_THIS
4401 (do not abuse the feature! it's for stuff like the autogenerated
4402 macros in dbus-md5.c, not just for things you don't feel like
4405 2003-02-18 Havoc Pennington <hp@pobox.com>
4407 * dbus/dbus-string.c (_dbus_string_zero): new function
4409 * dbus/dbus-md5.c: include MD5 implementation by L. Peter Deutsch,
4410 wrap it in some dbus-friendly API
4412 * dbus/dbus-types.h: add 16-bit types
4414 2003-02-18 Joe Shaw <joe@assbarn.com>
4416 * dbus/dbus-auth.c (handle_server_data_stupid_test_mech): Just get
4417 credentials from our currently running process.
4418 (get_word): Fix a buglet where we were copying the entire length
4419 instead of relative to our position.
4421 * dbus/dbus-hash.c (_dbus_hash_test): Don't try to allocate the
4422 keys on the stack... it's 640k of data.
4424 * dbus/dbus-sysdeps.c (_dbus_read_credentials_unix_socket): Always
4425 read the credentials byte off the socket, even if we don't have
4427 (_dbus_poll): Implement poll() using select() for systems which
4430 * glib/test-dbus-glib.c (main): Print out an error if no
4431 parameters are given.
4433 * test/data/auth/fallback.auth-script: Added. Tests that a client
4434 can fallback to a secondary auth mechanism if the first fails.
4436 2003-02-18 Havoc Pennington <hp@pobox.com>
4440 2003-02-17 Havoc Pennington <hp@pobox.com>
4442 * doc/dbus-specification.sgml: lots of cosmetic
4443 cleanups/rearrangement, add assorted FIXME, change DBUS_ADDRESS
4444 env variable to DBUS_BUS_ADDRESS, s/client/application/,
4445 s/server/bus/ (except in authentication section). Add a section
4446 "Message Bus Message Routing"
4448 2003-02-17 Anders Carlsson <andersca@codefactory.se.>
4454 2003-02-17 Anders Carlsson <andersca@codefactory.se>
4456 * doc/dbus-specification.sgml:
4457 Specification updates.
4459 2003-02-17 Anders Carlsson <andersca@codefactory.se>
4461 * bus/activation.c: (bus_activation_init), (child_setup),
4462 (bus_activation_activate_service):
4464 * bus/main.c: (main):
4465 Set DBUS_ADDRESS environment variable.
4467 * dbus/dbus-errors.c: (dbus_set_error):
4468 Don't use va_copy since that's a C99 feature.
4470 * dbus/dbus-sysdeps.c: (_dbus_setenv), (do_exec),
4471 (_dbus_spawn_async):
4472 * dbus/dbus-sysdeps.h:
4473 Add child_setup_func to _dbus_spawn_async.
4475 * doc/dbus-specification.sgml:
4476 Update specification.
4478 * test/spawn-test.c: (setup_func), (main):
4481 2003-02-17 Alexander Larsson <alexl@redhat.com>
4483 * dbus/dbus-connection.c (_dbus_connection_handler_destroyed_locked):
4486 2003-02-17 Anders Carlsson <andersca@codefactory.se>
4490 * doc/dbus-test-plan.sgml:
4491 Add test plan document.
4496 2003-02-17 Anders Carlsson <andersca@codefactory.se>
4498 * dbus/dbus-message.c: (decode_header_data),
4499 (_dbus_message_loader_return_buffer):
4500 Set the header padding amount when loading a message.
4502 2003-02-16 Anders Carlsson <andersca@codefactory.se>
4504 * bus/dispatch.c: (send_one_message):
4505 Only send broadcast messages to registered connections.
4507 * dbus/dbus-message.c: (dbus_message_name_is):
4508 * dbus/dbus-message.h:
4509 New convenience function.
4511 * dbus/dbus-transport-debug.c: (do_reading):
4512 Only dispatch one message per run.
4515 * test/bus-test.c: (new_connection_callback), (die),
4516 (test_hello_client1_handler), (test_hello_client2_handler),
4517 (test_hello_replies), (main):
4519 * test/bus-test-loop.[ch]:
4522 2003-02-16 Havoc Pennington <hp@pobox.com>
4524 * dbus/dbus-connection.c (dbus_connection_dispatch_message): fix
4525 backward conditional
4527 2003-02-16 Alexander Larsson <alexl@redhat.com>
4529 * dbus/dbus-connection.c:
4530 Implement sent_message_with_reply. (with_reply_and block is still
4532 Made dispatch_message not lose message if OOM.
4534 * dbus/dbus-errors.h:
4535 Add NoReply error (for reply timeouts).
4537 2003-02-16 Alexander Larsson <alexl@redhat.com>
4539 * dbus/dbus-hash.c (_dbus_hash_table_unref):
4540 Actually free keys and values when destroying hashtable.
4542 2003-02-16 Anders Carlsson <andersca@codefactory.se>
4544 * dbus/dbus-auth.c: (client_try_next_mechanism):
4547 * dbus/dbus-threads.c: (dbus_condvar_wait_timeout):
4548 Return TRUE if there's no thread implementation around.
4550 * glib/dbus-gmain.c: (free_source),
4551 (dbus_connection_hookup_with_g_main):
4552 Make sure to remove the GSource when the connection is finalized.
4554 2003-02-16 Anders Carlsson <andersca@codefactory.se>
4556 * bus/dispatch.c: (bus_dispatch_message_handler):
4557 * dbus/dbus-errors.h:
4558 Return an error if someone tries to send a message to a service
4561 2003-02-16 Anders Carlsson <andersca@codefactory.se>
4563 * bus/activation.c: (load_directory), (bus_activation_init),
4564 (bus_activation_activate_service):
4567 (bus_driver_handle_activate_service), (bus_driver_handle_message):
4568 More work on the activation handling.
4570 * dbus/dbus-errors.h:
4571 Add some error messages
4573 * dbus/dbus-message.c: (dbus_message_new_error_reply):
4574 * dbus/dbus-message.h:
4575 New function that creates an error message.
4577 * dbus/dbus-protocol.h:
4578 Add ACTIVATE_SERVER message.
4580 * dbus/dbus-server-unix.c: (unix_handle_watch),
4581 (_dbus_server_new_for_domain_socket):
4582 Call _dbus_fd_set_close_on_exec.
4584 * dbus/dbus-sysdeps.c: (make_pipe), (do_exec),
4585 (_dbus_spawn_async), (_dbus_disable_sigpipe),
4586 (_dbus_fd_set_close_on_exec):
4587 * dbus/dbus-sysdeps.h:
4588 Add _dbus_fd_set_close_on exec function. Also add function that checks
4589 that all open fds are set to close-on-exec and warns otherwise.
4591 * dbus/dbus-transport-unix.c:
4592 (_dbus_transport_new_for_domain_socket):
4593 Call _dbus_fd_set_close_on_exec.
4595 2003-02-16 Havoc Pennington <hp@pobox.com>
4597 * dbus/dbus-connection.c (dbus_connection_set_change_sigpipe):
4598 allow people to avoid setting SIGPIPE to SIG_IGN
4599 (_dbus_connection_new_for_transport): disable SIGPIPE unless
4600 we've been asked not to
4602 2003-02-15 Anders Carlsson <andersca@codefactory.se>
4604 * dbus/dbus-list.c: (_dbus_list_append_link),
4605 (_dbus_list_prepend_link):
4606 * dbus/dbus-memory.c: (dbus_malloc), (dbus_malloc0),
4610 2003-02-15 Anders Carlsson <andersca@codefactory.se>
4613 * bus/activation.c: (bus_activation_entry_free),
4614 (add_desktop_file_entry), (load_directory), (bus_activation_init):
4616 * bus/main.c: (main):
4617 Add simple activation support, doesn't work yet though.
4619 2003-02-15 Zack Rusin <zack@kde.org>
4621 * qt/dbus-qthread.cpp: small casting fix
4623 2003-02-15 Anders Carlsson <andersca@codefactory.se>
4625 * dbus/dbus-errors.c: (dbus_set_error):
4626 * dbus/dbus-errors.h:
4627 Add a few errors and make dbus_set_error void.
4629 * dbus/dbus-sysdeps.c:
4630 (_dbus_errno_to_string), (close_and_invalidate), (make_pipe),
4631 (write_err_and_exit), (read_ints), (do_exec), (_dbus_spawn_async):
4632 * dbus/dbus-sysdeps.h:
4633 Add _dbus_spawn_async.
4635 * test/spawn-test.c: (main):
4636 Test for _dbus_spawn_async.
4638 2003-02-15 Anders Carlsson <andersca@codefactory.se>
4640 * dbus/dbus-internals.h:
4641 Fix build without tests.
4643 * dbus/dbus-list.c: (alloc_link):
4644 Fix a segfault when a malloc fails.
4646 * dbus/dbus-memory.c: (initialize_malloc_debug), (dbus_malloc),
4647 (dbus_malloc0), (dbus_realloc):
4648 Add support for malloc debugging.
4650 2003-02-15 Alexander Larsson <alexl@redhat.com>
4652 * dbus/dbus-threads.c:
4653 * dbus/dbus-threads.h:
4654 Add condvars. Remove static mutext from API.
4655 Implement static mutexes by initializing them from threads_init.
4657 * glib/dbus-gthread.c:
4658 * qt/dbus-qthread.cpp:
4659 Update with the thread api changes.
4664 Turn StaticMutex into normal mutex + init function.
4665 Export new functions _dbus_list_alloc_link, _dbus_list_free_link,
4666 _dbus_list_append_link, _dbus_list_prepend_link
4669 * dbus/dbus-sysdeps.c:
4670 * dbus/dbus-sysdeps.h:
4671 New type dbus_atomic_t, and new functions _dbus_atomic_inc,
4672 _dbus_atomic_dec. Only slow fallback implementation at the moment.
4674 * dbus/dbus-protocol.h:
4675 Add DBUS_MESSAGE_LOCAL_DISCONNECT define
4677 * dbus/dbus-message.c:
4678 Make ref/unref atomic.
4681 * dbus/dbus-connection-internal.h:
4682 * dbus/dbus-connection.c:
4683 * dbus/dbus-connection.h:
4685 Change _peek to _borrow,_return & _steal_borrowed.
4686 Change disconnect callback to event.
4687 Make dbus_connection_dispatch_messages reentrant.
4689 * dbus/dbus-transport.c:
4690 Don't ref the connection on calls to the transport
4693 * dbus/dbus-message-handler.c:
4696 * glib/dbus-gmain.c:
4697 Don't use peek_message anymore
4700 * test/debug-thread.c:
4701 * test/debug-thread.h:
4702 Simple thread implementation that asserts() on deadlocks in
4703 single-threaded code.
4706 (main) Call debug_threads_init.
4709 Use disconnect message instead of disconnect callback.
4713 Don't call dbus_connection_set_disconnect_function. Instead export
4714 bus_connection_disconnect.
4717 Call bus_connection_disconnect when we get a disconnected message.
4719 2003-02-15 Havoc Pennington <hp@pobox.com>
4721 * dbus/dbus-message.c (dbus_message_new): fool around with the
4724 2003-02-14 Havoc Pennington <hp@pobox.com>
4726 * dbus/dbus-mempool.c: fail if the debug functions so indicate
4728 * dbus/dbus-memory.c: fail if the debug functions indicate we
4731 * dbus/dbus-internals.c (_dbus_set_fail_alloc_counter)
4732 (_dbus_decrement_fail_alloc_counter): debug functions to
4733 simulate memory allocation failures
4735 2003-02-14 Havoc Pennington <hp@pobox.com>
4737 * dbus/dbus-errors.h (struct DBusError): add a word of padding
4740 2003-02-13 Anders Carlsson <andersca@codefactory.se>
4742 * bus/driver.c: (bus_driver_handle_hello):
4744 * bus/services.c: (bus_service_lookup):
4745 Reorder message sending so we get a more sane order.
4747 * test/bus-test.c: (message_handler):
4750 2003-02-13 Anders Carlsson <andersca@codefactory.se>
4752 * bus/driver.c: (bus_driver_send_service_deleted),
4753 (bus_driver_send_service_created), (bus_driver_send_service_lost),
4754 (bus_driver_send_service_acquired), (bus_driver_handle_hello),
4755 (bus_driver_send_welcome_message),
4756 (bus_driver_handle_list_services),
4757 (bus_driver_handle_acquire_service),
4758 (bus_driver_handle_service_exists):
4759 * dbus/dbus-bus.c: (dbus_bus_register_client),
4760 (dbus_bus_acquire_service), (dbus_bus_service_exists):
4761 * dbus/dbus-errors.c: (dbus_result_to_string):
4762 * dbus/dbus-errors.h:
4763 * dbus/dbus-message.c: (dbus_message_append_args),
4764 (dbus_message_append_args_valist), (dbus_message_get_args),
4765 (dbus_message_get_args_valist), (dbus_message_get_args_iter),
4766 (dbus_message_iter_get_arg_type), (dbus_message_iter_get_string),
4767 (dbus_message_iter_get_byte_array),
4768 (dbus_message_iter_get_string_array), (message_iter_test),
4769 (check_message_handling), (_dbus_message_test):
4770 * dbus/dbus-message.h:
4771 * test/bus-test.c: (main):
4772 Change fields to arguments in messages, so that they won't be
4773 confused with header fields.
4775 * glib/test-dbus-glib.c: (main):
4776 Remove append_fields from hello message.
4778 2003-02-13 Anders Carlsson <andersca@codefactory.se>
4780 * dbus/dbus-errors.c:
4781 * dbus/dbus-message.c:
4782 * dbus/dbus-string.c:
4783 Documentation fixes.
4785 2003-02-13 Anders Carlsson <andersca@codefactory.se>
4787 * glib/dbus-gmain.c: (timeout_handler), (add_timeout),
4789 Implement support for timeouts in dbus-glib.
4791 2003-02-13 Anders Carlsson <andersca@codefactory.se>
4793 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
4794 * dbus/dbus-message.c: (process_test_subdir):
4795 * test/break-loader.c: (find_breaks_based_on):
4796 Plug some memory leaks.
4798 2003-02-13 Richard Hult <rhult@codefactory.se>
4800 * bus/main.c: Fix build.
4802 * dbus/dbus-errors.h:
4803 * dbus/dbus-errors.c: Fix copyright for Anders.
4805 2003-02-13 Anders Carlsson <andersca@codefactory.se>
4810 * bus/connection.c: (bus_connection_foreach):
4813 * bus/desktop-file.c: (grow_lines_in_section), (grow_sections),
4814 (unescape_string), (new_section), (parse_section_start),
4815 (parse_key_value), (report_error), (bus_desktop_file_load),
4816 (bus_desktop_file_get_string):
4817 * bus/desktop-file.h:
4818 Use DBusError for error reporting.
4820 * bus/dispatch.c: (send_one_message),
4821 (bus_dispatch_message_handler):
4822 * bus/driver.c: (bus_driver_send_service_deleted),
4823 (bus_driver_send_service_created), (bus_driver_send_service_lost),
4824 (bus_driver_send_service_acquired), (bus_driver_handle_hello),
4825 (bus_driver_send_welcome_message),
4826 (bus_driver_handle_list_services),
4827 (bus_driver_handle_acquire_service),
4828 (bus_driver_handle_service_exists):
4829 * bus/loop.c: (bus_loop_run):
4831 Use BUS_HANDLE_OOM instead of _DBUS_HANDLE_OOM.
4833 * bus/utils.c: (bus_wait_for_memory):
4835 New files with general utility functions.
4837 * dbus/dbus-internals.h:
4838 Remove _DBUS_HANDLE_OOM.
4840 2003-02-13 Anders Carlsson <andersca@codefactory.se>
4842 * dbus/dbus-errors.c: (dbus_result_to_string), (dbus_error_init),
4843 (dbus_error_free), (dbus_set_error_const), (dbus_set_error):
4844 * dbus/dbus-errors.h:
4845 Add DBusError structure.
4847 2003-02-13 Anders Carlsson <andersca@codefactory.se>
4849 * test/data/valid-messages/standard-acquire-service.message:
4850 * test/data/valid-messages/standard-hello.message:
4851 * test/data/valid-messages/standard-list-services.message:
4852 * test/data/valid-messages/standard-service-exists.message:
4853 Add some standard messages.
4855 2003-02-13 Anders Carlsson <andersca@codefactory.se>
4857 * bus/driver.c: (bus_driver_send_welcome_message),
4858 (bus_driver_handle_list_services),
4859 (bus_driver_handle_acquire_service),
4860 (bus_driver_handle_service_exists), (bus_driver_handle_message):
4861 Update for API changes in libdbus.
4863 * dbus/dbus-message.c: (dbus_message_new_reply):
4864 * dbus/dbus-message.h:
4865 Remove the name argument. The spec states that replies shouldn't
4868 2003-02-13 Anders Carlsson <andersca@codefactory.se>
4870 * bus/desktop-file.c: (parse_section_start), (parse_key_value),
4871 (report_error), (bus_desktop_file_load), (lookup_section),
4872 (lookup_line), (bus_desktop_file_get_raw),
4873 (bus_desktop_file_get_string):
4874 * bus/desktop-file.h:
4875 Some fixes, and new functions for getting a key value from a section.
4877 2003-02-13 Havoc Pennington <hp@pobox.com>
4879 * test/data/auth/fail-after-n-attempts.auth-script: new test
4881 * dbus/dbus-auth.c (send_rejected): shutdown_mech() when we
4884 2003-02-13 Havoc Pennington <hp@pobox.com>
4886 * dbus/dbus-auth.c (handle_server_data_external_mech): args to
4887 dbus_credentials_match were backward
4889 * dbus/dbus-auth-script.c (_dbus_auth_script_run): support
4890 NO_CREDENTIALS and ROOT_CREDENTIALS
4892 * dbus/dbus-auth.c (_dbus_auth_do_work): move get_state() routine
4893 into here. Never process more commands after we've reached an
4894 end state; store further data as unused bytes.
4896 * test/data/auth/*: add more auth tests
4898 * dbus/dbus-auth-script.c (_dbus_auth_script_run): support EXPECT
4899 command to match exact string and EXPECT_UNUSED to match unused
4902 * test/Makefile.am (dist-hook): fix to dist all the test stuff
4904 2003-02-12 Havoc Pennington <hp@pobox.com>
4906 * dbus/dbus-string.c (_dbus_string_pop_line): fix to also strip
4907 \r off of popped lines
4909 * dbus/dbus-auth.c (_dbus_auth_test): write code to run auth
4912 * dbus/dbus-auth-script.c (_dbus_auth_script_run): when doing a
4915 2003-02-12 Havoc Pennington <hp@pobox.com>
4917 * dbus/Makefile.am: remove break-loader from the build, since it
4920 * configure.in: add --enable-gcov to turn on coverage profiling
4921 flags and disable optimization
4923 2003-02-10 Havoc Pennington <hp@pobox.com>
4925 * dbus/dbus-auth-script.c, dbus/dbus-auth-script.h: sync
4926 initial cut at test framework for DBusAuth from laptop.
4927 Doesn't quite work yet but it compiles and I need to get
4928 it off the 266mhz laptop. ;-)
4930 * dbus/dbus-server-debug.c (_dbus_server_debug_accept_transport):
4931 fix a memleak in error case
4933 2003-02-12 Anders Carlsson <andersca@codefactory.se>
4936 * bus/desktop-file.c:
4937 * bus/desktop-file.h:
4938 Add a desktop file parser.
4940 2003-02-11 Zack Rusin <zack@kde.org>
4942 * qt/message.[h|cpp]: sample implementation
4943 of the KDE wrapper for DBusMessage
4945 2003-02-09 Zack Rusin <zack@kde.org>
4947 * test/bus-test.c: make_it_compile
4948 * doc/dbus-specification.sgml: minimal semantic fix
4950 2003-02-06 Anders Carlsson <andersca@codefactory.se>
4956 2003-02-06 Anders Carlsson <andersca@codefactory.se>
4959 * dbus/dbus-break-loader.c:
4961 * test/break-loader.c:
4962 Move dbus-break-loader to test/ and rename it to break-loader.
4964 2003-02-02 Havoc Pennington <hp@pobox.com>
4966 * dbus/dbus-keyring.c, dbus/dbus-keyring.h: template files
4967 for code to manage cookies in your home directory
4969 * dbus/dbus-sysdeps.c (_dbus_generate_random_bytes): new function
4971 * dbus/dbus-auth.c (get_state): impose a maximum number of tries
4972 to authenticate, then disconnect the client.
4974 2003-02-03 Alexander Larsson <alexl@redhat.com>
4976 * dbus/dbus-message.c (dbus_message_append_fields):
4979 2003-02-02 Anders Carlsson <andersca@codefactory.se>
4981 * doc/dbus-specification.sgml:
4982 Update address format section.
4984 2003-02-02 Anders Carlsson <andersca@codefactory.se>
4987 * test/bus-test.c: (get_time), (add_timeout), (remove_timeout),
4988 (message_handler), (new_connection_callback), (loop_quit),
4992 2003-02-02 Anders Carlsson <andersca@codefactory.se>
4994 * bus/driver.c: (bus_driver_handle_service_exists):
4995 Simplify the code a bit.
4997 * dbus/dbus-bus.c: (dbus_bus_service_exists):
5000 2003-02-02 Anders Carlsson <andersca@codefactory.se>
5003 Add libdbus-daemon.la and link to it.
5005 2003-02-01 James Willcox <jwillcox@gnome.org>
5007 * bus/driver.c: (bus_driver_handle_own_service):
5008 Actually include the service reply code in the message.
5010 2003-02-02 Anders Carlsson <andersca@codefactory.se>
5012 * bus/driver.c: (bus_driver_handle_service_exists):
5013 Don't unref the incoming message.
5015 2003-02-02 Anders Carlsson <andersca@codefactory.se>
5017 * dbus/dbus.h: Add dbus-address.h and dbus-bus.h
5019 2003-02-02 Anders Carlsson <andersca@codefactory.se>
5021 * dbus/dbus-server.c: (dbus_server_listen):
5022 * dbus/dbus-transport.c: (_dbus_transport_open):
5023 ifdef out the calls to the debug transport and server.
5025 2003-02-02 Alexander Larsson <alexl@redhat.com>
5027 * dbus/dbus-watch.c (dbus_watch_get_flags):
5028 Add note in the docs that ERROR or HANGUP won't be returned
5029 and are assumed always on.
5031 * glib/dbus-gmain.c (add_watch):
5032 Always add IO_ERR | IO_HUP
5034 * dbus/dbus-message.h:
5035 Add semicolon after dbus_message_iter_get_string_array().
5036 Makes qt code build again
5038 2003-02-01 Anders Carlsson <andersca@codefactory.se>
5040 * bus/driver.c: (create_unique_client_name),
5041 (bus_driver_handle_hello):
5042 Don't take a name, just use a numeric id to identify
5046 * dbus/dbus-bus.c: (dbus_bus_register_client),
5047 (dbus_bus_acquire_service), (dbus_bus_service_exists):
5049 Add new convenience functions for communicating with the bus.
5051 * dbus/dbus-message.h:
5053 * dbus/dbus-protocol.h:
5056 2003-02-01 Alexander Larsson <alexl@redhat.com>
5058 * dbus/dbus-message.c (dbus_message_append_fields):
5059 Add some more doc comments.
5061 2003-02-01 Havoc Pennington <hp@pobox.com>
5063 * dbus/dbus-break-loader.c (randomly_modify_length): change
5064 a 4-byte value in the message as if it were a length
5066 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): don't set
5067 execute bit on saved files
5069 2003-02-01 Havoc Pennington <hp@pobox.com>
5071 * dbus/dbus-break-loader.c (main): new program to find messages
5072 that break the loader.
5074 * dbus/dbus-sysdeps.c (_dbus_string_append_uint): new function
5075 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): new function
5077 * dbus/dbus-string.c (_dbus_string_set_byte): new
5079 2003-01-31 Havoc Pennington <hp@pobox.com>
5081 * dbus/dbus-message.c: refactor the test code to be more general,
5082 in preparation for writing a "randomly permute test cases to
5083 try to break the loader" program.
5085 2003-01-31 Havoc Pennington <hp@pobox.com>
5087 * doc/dbus-specification.sgml: work on the specification
5089 * dbus/dbus-message.c (_dbus_message_loader_return_buffer): check
5090 the protocol version of the message.
5092 * dbus/dbus-protocol.h: drop special _REPLY names, the spec
5093 no longer specifies that.
5094 (DBUS_SERVICE_REPLY_SERVICE_EXISTS): fix flags (1/2/4/8 not
5097 * dbus/dbus-marshal.c (_dbus_marshal_get_arg_end_pos): add missing
5098 "break" for DBUS_TYPE_NIL, remove @todo
5100 2003-01-31 Havoc Pennington <hp@pobox.com>
5102 * dbus/dbus-message.c (dbus_message_set_is_error_reply): rename
5103 just set_is_error/get_is_error as this is a commonly-used
5104 function, and write docs.
5106 2003-01-31 Anders Carlsson <andersca@codefactory.se>
5108 * dbus/dbus-address.c: (dbus_address_entry_free):
5109 Free key and value lists.
5111 * dbus/dbus-internals.c: (_dbus_type_to_string):
5112 Add the types we didn't have.
5114 * dbus/dbus-marshal.c: (_dbus_marshal_get_arg_end_pos),
5115 (_dbus_marshal_validate_arg):
5118 * dbus/dbus-message.c: (dbus_message_set_sender):
5119 Remove todo about being able to set sender to NULL.
5121 (dbus_message_set_is_error_reply),
5122 (dbus_message_get_is_error_reply):
5123 * dbus/dbus-message.h:
5126 * dbus/dbus-protocol.h:
5127 Add error reply flag.
5129 * test/data/valid-messages/opposite-endian.message:
5130 Add NIL type to test.
5132 2003-01-31 Havoc Pennington <hp@pobox.com>
5134 * doc/dbus-specification.sgml: fully specify the header. Add
5135 flags and major protocol version, and change header/body len to
5138 * dbus/dbus-message-builder.c (append_saved_length): append length
5141 * dbus/dbus-message.c (dbus_message_create_header): change header
5142 length and body length to unsigned. Add the new fields from the
5144 (_dbus_message_loader_return_buffer): unsigned header/body len
5146 2003-01-30 Havoc Pennington <hp@pobox.com>
5148 * dbus/dbus-auth.c: rework to use only REJECTED, no
5151 * doc/dbus-sasl-profile.txt: drop MECHANISMS and just
5152 use REJECTED, suggested by Mark McLoughlin
5154 2003-01-30 Havoc Pennington <hp@pobox.com>
5156 * dbus/dbus-server.c (dbus_server_listen): @todo about how we need
5157 a better way to report errors here. e.g. "unix address lacks
5158 path" or something. also "no such file" when the path doesn't
5161 * dbus/dbus-address.c (dbus_address_entries_free): add @todo about
5163 (dbus_parse_address): add @todo about documenting address format,
5164 and allowing , and ; to be escaped
5166 2003-01-30 Anders Carlsson <andersca@codefactory.se>
5169 Add dbus-address.[ch]
5171 * dbus/dbus-address.c: (dbus_address_entry_free),
5172 (dbus_address_entries_free), (create_entry),
5173 (dbus_address_entry_get_method), (dbus_address_entry_get_value),
5174 (dbus_parse_address), (_dbus_address_test):
5175 * dbus/dbus-address.h:
5176 New files for dealing with address parsing.
5178 * dbus/dbus-connection.c:
5179 Document timeout functions.
5181 * dbus/dbus-message.c:
5182 Document dbus_message_new_from_message.
5184 * dbus/dbus-server-debug.c:
5187 * dbus/dbus-server.c: (dbus_server_listen):
5188 Parse address and use correct server implementation.
5190 * dbus/dbus-string.c: (_dbus_string_find_to), (_dbus_string_test):
5191 * dbus/dbus-string.h:
5192 New function with test.
5194 * dbus/dbus-test.c: (dbus_internal_symbol_do_not_use_run_tests):
5198 * dbus/dbus-transport-debug.c:
5201 * dbus/dbus-transport.c: (_dbus_transport_open):
5202 Parse address and use correct transport implementation.
5204 2003-01-30 Havoc Pennington <hp@pobox.com>
5206 * dbus/dbus-message.c: use message->byte_order instead of
5207 DBUS_COMPILER_BYTE_ORDER throughout.
5208 (dbus_message_create_header): pad header to align the
5209 start of the body of the message to 8-byte boundary
5211 * dbus/dbus-marshal.h: make all the demarshalers take const
5212 DBusString arguments.
5214 * dbus/dbus-message.c (_dbus_message_loader_return_buffer):
5215 validate message args here, so we don't have to do slow validation
5216 later, and so we catch bad messages as they are incoming. Also add
5217 better checks on header_len and body_len. Also fill in
5220 * dbus/dbus-string.c (_dbus_string_validate_utf8): new (not
5221 implemented properly)
5222 (_dbus_string_validate_nul): new function to check all-nul
5224 * dbus/dbus-marshal.c (_dbus_marshal_get_field_end_pos): rename
5225 get_arg_end_pos and remove all validation
5226 (_dbus_marshal_validate_arg): actually do validation here.
5228 2003-01-29 Havoc Pennington <hp@pobox.com>
5230 * dbus/dbus-message.c (check_message_handling): fix assertion
5231 failure on set_client_serial
5233 2003-01-28 Havoc Pennington <hp@pobox.com>
5235 * dbus/dbus-server-debug.c: Add doc section comments
5237 * dbus/dbus-transport-debug.c: add doc section comments
5239 2003-01-28 Havoc Pennington <hp@redhat.com>
5241 * dbus/dbus-string.c (_dbus_string_base64_decode): append bytes in
5242 the reverse order from how I had it
5243 (_dbus_string_base64_encode): reverse encoding order. I was
5244 basically byteswapping everything during encoding.
5246 2003-01-28 Anders Carlsson <andersca@codefactory.se>
5248 * dbus/dbus-connection-internal.h:
5249 * dbus/dbus-connection.c: (_dbus_connection_add_timeout),
5250 (_dbus_connection_remove_timeout):
5251 Add functions for adding and removing timeouts.
5253 * dbus/dbus-message.c: (dbus_message_new_from_message):
5254 Add new function that takes a message and creates an exact
5255 copy of it, but with the refcount set to 1.
5256 (check_message_handling):
5259 * dbus/dbus-server-protected.h:
5260 * dbus/dbus-server.c: (_dbus_server_init_base),
5261 (_dbus_server_finalize_base), (_dbus_server_add_timeout),
5262 (dbus_server_set_timeout_functions):
5263 (_dbus_server_remove_timeout):
5264 New functions so that a server can add and remove timeouts.
5266 (dbus_server_listen):
5267 Add commented out call to dbus_server_debug_new.
5269 * dbus/dbus-timeout.c: (_dbus_timeout_new):
5270 Actually set the handler, doh.
5272 * dbus/dbus-transport.c: (_dbus_transport_open):
5273 Add commented out call to dbus_transport_debug_client_new.
5276 Add dbus-transport-debug.[ch] and dbus-server-debug.[ch]
5278 2003-01-28 Havoc Pennington <hp@pobox.com>
5280 * dbus/dbus-message.c (check_message_handling): function to check
5281 on the loaded message, iterates over it etc.
5283 2003-01-28 Havoc Pennington <hp@pobox.com>
5285 * test/Makefile.am (dist-hook): fix make distdir
5287 * dbus/Makefile.am (TESTS_ENVIRONMENT): fix make check
5289 2003-01-27 Havoc Pennington <hp@pobox.com>
5291 * dbus/dbus-mempool.c (time_for_size): replace printf with
5294 * dbus/dbus-message-builder.c (_dbus_message_data_load): allow
5295 empty lines; fix the SAVE_LENGTH stuff to be
5296 START_LENGTH/END_LENGTH so it actually works; couple other
5299 * test/Makefile.am (dist-hook): add dist-hook for .message files
5301 * dbus/dbus-string.c (DBUS_STRING_COPY_PREAMBLE): source of a copy
5302 can be constant or locked.
5303 (_dbus_string_free): allow freeing a const string as
5306 * dbus/dbus-sysdeps.c (_dbus_concat_dir_and_file): utility
5308 * dbus/dbus-test-main.c (main): take an argument which is the
5309 directory containing test data
5311 * dbus/dbus-message.c (_dbus_message_test): pass a test_data_dir
5312 argument to this and load all the messages in test/data/
5313 checking that they can be loaded or not loaded as appropriate.
5315 2003-01-27 Anders Carlsson <andersca@codefactory.se>
5317 * bus/dispatch.c: (bus_dispatch_message_handler):
5318 Dispatch messages sent to services.
5320 * bus/driver.c: (bus_driver_send_service_deleted),
5321 (bus_driver_send_service_created), (bus_driver_send_service_lost),
5322 (bus_driver_send_service_acquired):
5323 Add helper functions for sending service related messages.
5325 (bus_driver_send_welcome_message):
5326 Send HELLO_REPLY instead of WELCOME.
5328 (bus_driver_handle_list_services):
5329 Send LIST_SERVICES_REPLY instead of SERVICES.
5331 (bus_driver_handle_own_service),
5332 (bus_driver_handle_service_exists):
5333 New message handlers.
5335 (bus_driver_handle_message):
5336 Invoke new message handlers.
5338 (bus_driver_remove_connection):
5339 Don't remove any services here since that's done automatically
5340 by bus_service_remove_owner now.
5343 New function signatures.
5345 * bus/services.c: (bus_service_add_owner):
5346 Send ServiceAcquired message if we're the only primary owner.
5348 (bus_service_remove_owner):
5349 Send ServiceAcquired/ServiceLost messages.
5351 (bus_service_set_prohibit_replacement),
5352 (bus_service_get_prohibit_replacement):
5353 Functions for setting prohibit replacement.
5355 (bus_service_has_owner):
5356 New function that checks if a connection is in the owner queue of
5360 Add new function signatures.
5362 * dbus/dbus-list.c: (_dbus_list_test):
5363 Add tests for _dbus_list_remove_last and traversing the list backwards.
5366 Fix a typo in _dbus_list_get_prev_link, if we're at the first element we can't
5367 go any further, so return NULL then.
5369 * dbus/dbus-protocol.h:
5370 Add new messages, service flags and service replies.
5372 2003-01-26 Havoc Pennington <hp@pobox.com>
5374 * dbus/dbus-message-builder.c: implement, completely untested.
5376 * test/data/*: add data to be used in testing.
5377 ".message" files are our simple loadable text format.
5378 ".message-raw" will be binary dumps of messages.
5380 * dbus/dbus-string.c (_dbus_string_starts_with_c_str): new
5382 2003-01-26 Havoc Pennington <hp@pobox.com>
5384 * dbus/dbus-sysdeps.c (_dbus_file_get_contents): new function
5386 * dbus/dbus-errors.c (dbus_result_to_string): add
5389 * dbus/dbus-message-builder.c: new file, will contain code to load
5390 up messages from files. Not implemented yet.
5392 2003-01-26 Havoc Pennington <hp@pobox.com>
5394 * dbus/dbus-message.c (dbus_message_set_sender): support deleting
5395 the sender by setting to NULL
5397 2003-01-26 Havoc Pennington <hp@pobox.com>
5399 The unit tests pass, but otherwise untested. If it breaks, the
5400 tests should have been better. ;-)
5402 * bus/driver.c (bus_driver_handle_hello): return if we disconnect
5405 * dbus/dbus-message.c: redo everything so we maintain
5406 message->header as the only copy of the various fields.
5407 This avoids the possibility of out-of-memory in some cases,
5408 for example dbus_message_lock() can't run out of memory anymore,
5409 and avoids extra copying. Figured I may as well go ahead and do
5410 this since it was busted for dbus_message_lock to not return
5411 failure on OOM, and dbus_message_write_header was totally
5412 unchecked for OOM. Also fixed some random other bugs.
5414 * dbus/dbus-marshal.c (_dbus_marshal_get_field_end_pos): verify
5415 that strings are nul-terminated. Also, end_pos can be equal
5416 to string length just not greater than, I think.
5417 (_dbus_marshal_set_int32): new function
5418 (_dbus_marshal_set_uint32): new function
5419 (_dbus_marshal_set_string): new function
5421 * dbus/dbus-connection.c (_dbus_connection_new_for_transport): fix
5422 a warning, init timeout_list to NULL
5423 (dbus_connection_send_message): don't use uninitialized variable
5426 * dbus/dbus-string.c (_dbus_string_replace_len): new function
5428 2003-01-26 Anders Carlsson <andersca@codefactory.se>
5430 * bus/driver.c: (bus_driver_handle_hello),
5431 (bus_driver_send_welcome_message):
5434 2003-01-26 Anders Carlsson <andersca@codefactory.se>
5436 * dbus/dbus-auth.c: (process_auth), (_dbus_auth_unref):
5437 * dbus/dbus-connection.c: (_dbus_connection_new_for_transport),
5438 (dbus_connection_unref):
5439 * dbus/dbus-marshal.c: (_dbus_marshal_test):
5440 * dbus/dbus-message.c: (dbus_message_unref),
5443 (dbus_message_get_fields):
5444 Remove debugging printout.
5446 (_dbus_message_loader_return_buffer):
5447 Don't store the header string.
5449 (_dbus_message_test):
5452 2003-01-26 Richard Hult <rhult@codefactory.se>
5454 * glib/dbus-gmain.c (dbus_connection_dispatch): Traverse a copy of
5455 the file descriptor list, since it can change under us.
5457 2003-01-25 Anders Carlsson <andersca@codefactory.se>
5459 * glib/dbus-gmain.c: (dbus_connection_prepare),
5460 (dbus_connection_check), (dbus_connection_dispatch), (add_watch),
5461 (remove_watch), (dbus_connection_hookup_with_g_main):
5462 Rewrite the glib handling to use its own GSource instead of a
5463 GIOChannel so we can catch messages put in the queue while waiting
5466 2003-01-25 Anders Carlsson <andersca@codefactory.se>
5469 * bus/connection.c: (connection_disconnect_handler),
5470 (connection_watch_callback), (bus_connection_setup):
5471 * bus/dispatch.c: (send_one_message),
5472 (bus_dispatch_broadcast_message), (bus_dispatch_message_handler),
5473 (bus_dispatch_add_connection), (bus_dispatch_remove_connection):
5475 * bus/driver.c: (bus_driver_send_service_deleted),
5476 (bus_driver_send_service_created), (bus_driver_handle_hello),
5477 (bus_driver_send_welcome_message),
5478 (bus_driver_handle_list_services), (bus_driver_remove_connection),
5479 (bus_driver_handle_message):
5481 Refactor code, put the message dispatching in its own file. Use
5482 _DBUS_HANDLE_OOM. Also send ServiceDeleted messages when a client
5485 2003-01-25 Anders Carlsson <andersca@codefactory.se>
5487 * dbus/dbus-internals.h:
5488 Add _DBUS_HANDLE_OOM macro, it doesn't do anything currently.
5490 * dbus/dbus-message.c: (dbus_message_get_sender):
5491 * dbus/dbus-message.h:
5492 Implement dbus_message_get_sender.
5494 * dbus/dbus-protocol.h:
5495 Add message and service defines.
5497 2003-01-25 Anders Carlsson <andersca@codefactory.se>
5499 * dbus/dbus-connection.c: (dbus_connection_send_message):
5500 * dbus/dbus-message-internal.h:
5501 * dbus/dbus-message.c: (_dbus_message_get_client_serial),
5502 (dbus_message_write_header):
5503 Remove _dbus_messag_unlock and don't set the client serial on a
5504 message if one already exists.
5506 2003-01-24 Havoc Pennington <hp@pobox.com>
5508 * dbus/dbus-list.c (alloc_link): put a thread lock on the global
5511 * bus/driver.c (bus_driver_handle_list_services): fix a leak
5514 2003-01-25 Anders Carlsson <andersca@codefactory.se>
5516 * dbus/dbus-list.c: (alloc_link), (free_link):
5517 Use a memory pool for the links.
5519 2003-01-25 Anders Carlsson <andersca@codefactory.se>
5521 * bus/connection.c: (bus_connection_foreach):
5523 Add new bus_connection_foreach function.
5525 * bus/driver.c: (send_one_message), (bus_driver_broadcast_message):
5526 Add function that broadcasts a message to all clients.
5528 (bus_driver_send_service_created), (bus_driver_handle_hello),
5529 (bus_driver_send_welcome_message),
5530 (bus_driver_handle_list_services), (bus_driver_message_handler):
5531 Implement functions that take care of listing services, and notifying
5532 clients when new services are created.
5534 * bus/services.c: (bus_services_list):
5536 Add new function that returns an array of strings with the currently
5537 registered services.
5540 * glib/dbus-gmain.c:
5541 Update copyright year.
5543 2003-01-25 Anders Carlsson <andersca@codefactory.se>
5545 * dbus/dbus-connection.c: (dbus_connection_send_message):
5546 Unlock the message in case it was sent earlier.
5548 (dbus_connection_send_message_with_reply_and_block):
5549 Remove the reply message from the list.
5551 * dbus/dbus-marshal.c: (_dbus_demarshal_string_array):
5552 Set array_len and new_pos correctly.
5554 (_dbus_marshal_test):
5555 Remove debug output.
5557 * dbus/dbus-message-internal.h:
5558 * dbus/dbus-message.c: (_dbus_message_get_reply_serial):
5559 New function that returns the reply serial.
5561 (_dbus_message_unlock):
5562 New function that unlocks a message and resets its header.
5564 (dbus_message_append_string_array),
5565 (dbus_message_get_fields_valist),
5566 (dbus_message_iter_get_field_type),
5567 (dbus_message_iter_get_string_array),
5568 (dbus_message_get_fields),
5569 (dbus_message_append_fields_valist):
5570 Handle string arrays.
5572 (dbus_message_set_sender):
5573 Make this function public since the bus daemon needs it.
5575 (decode_header_data):
5576 Set the reply serial to -1 initially.
5578 * dbus/dbus-message.h:
5579 Add dbus_message_set_sender.
5581 2003-01-24 Havoc Pennington <hp@pobox.com>
5583 * doc/dbus-specification.sgml: add some stuff
5585 2003-01-22 Havoc Pennington <hp@pobox.com>
5587 * doc/dbus-specification.sgml: Start to document the protocol.
5589 2003-01-22 Havoc Pennington <hp@pobox.com>
5591 * dbus/dbus-connection.c
5592 (dbus_connection_send_message_with_reply_and_block): add some @todo
5594 * bus/driver.c (bus_driver_add_connection): add a FIXME about memleak
5596 2003-01-21 Havoc Pennington <hp@pobox.com>
5598 (patch untested because can't compile)
5600 * bus/driver.c (create_unique_client_name): make this function
5601 never recycle client names. Also, caller should initialize
5604 * dbus/dbus-sysdeps.c (_dbus_get_current_time): new function
5606 2003-01-21 Anders Carlsson <andersca@codefactory.se>
5608 * dbus/dbus-marshal.c: (_dbus_marshal_double),
5609 (_dbus_marshal_int32), (_dbus_marshal_uint32),
5610 (_dbus_marshal_int32_array), (_dbus_marshal_uint32_array),
5611 (_dbus_marshal_double_array), (_dbus_marshal_string_array),
5612 (_dbus_demarshal_int32_array), (_dbus_demarshal_uint32_array),
5613 (_dbus_demarshal_double_array), (_dbus_demarshal_string_array),
5614 (_dbus_marshal_get_field_end_pos), (_dbus_marshal_test):
5615 * dbus/dbus-marshal.h:
5616 * dbus/dbus-protocol.h:
5617 Add support for marshalling and demarshalling integer, double
5620 2003-01-21 Anders Carlsson <andersca@codefactory.se>
5625 * bus/connection.c: (connection_disconnect_handler):
5626 Remove the connection from the bus driver's list.
5628 (connection_watch_callback): Dispatch messages.
5630 (free_connection_data): Free connection name.
5632 (bus_connection_setup): Add connection to the bus driver's list.
5633 (bus_connection_remove_owned_service):
5634 (bus_connection_set_name), (bus_connection_get_name):
5635 Add functions for setting and getting the connection's name.
5638 Add function headers.
5640 * bus/driver.c: (create_unique_client_name),
5641 (bus_driver_handle_hello_message),
5642 (bus_driver_send_welcome_message), (bus_driver_message_handler),
5643 (bus_driver_add_connection), (bus_driver_remove_connection):
5646 * bus/services.c: (bus_service_free):
5648 New file that handles communication and registreation with the bus
5651 2003-01-21 Anders Carlsson <andersca@codefactory.se>
5653 * dbus/dbus-connection.c: (dbus_connection_send_message):
5654 Add a new client_serial parameter.
5656 (dbus_connection_send_message_with_reply):
5657 Remove a @todo since we've implemented the blocking function.
5659 (dbus_connection_send_message_with_reply_and_block):
5660 New function that sends a message and waits for a reply and
5661 then returns the reply.
5663 * dbus/dbus-connection.h:
5666 * dbus/dbus-errors.c: (dbus_result_to_string):
5667 * dbus/dbus-errors.h:
5668 Add new DBUS_RESULT.
5670 * dbus/dbus-message-internal.h:
5671 * dbus/dbus-message.c: (_dbus_message_get_reply_serial),
5672 (_dbus_message_set_sender), (dbus_message_write_header),
5673 (dbus_message_new_reply), (decode_header_data),
5674 (_dbus_message_loader_return_buffer), (_dbus_message_test):
5675 * dbus/dbus-message.h:
5676 Add new functions that set the reply serial and sender.
5677 Also marshal and demarshal them correctly and add test.
5679 * dbus/dbus-protocol.h:
5680 Add new DBUS_MESSAGE_TYPE_SENDER.
5683 * glib/dbus-gmain.c: (watch_callback), (free_callback_data),
5684 (add_watch), (remove_watch), (add_timeout), (remove_timeout),
5685 (dbus_connection_hookup_with_g_main):
5686 * glib/test-dbus-glib.c: (main):
5687 Rewrite to use GIOChannel and remove the GSource crack.
5689 * test/echo-client.c: (main):
5690 * test/watch.c: (check_messages):
5691 Update for changed APIs
5693 2003-01-19 Anders Carlsson <andersca@codefactory.se>
5695 * dbus/Makefile.am: Add dbus-timeout.[cħ]
5697 * dbus/dbus-connection.c: (_dbus_connection_new_for_transport):
5698 Create a DBusTimeoutList.
5699 (dbus_connection_set_timeout_functions): Add new function to
5700 set timeout callbacks
5702 * dbus/dbus-connection.h: Add public DBusTimeout API.
5704 * dbus/dbus-message.c: (dbus_message_get_service):
5705 * dbus/dbus-message.h: New function.
5707 * dbus/dbus-server.c: Fix small doc typo.
5709 * dbus/dbus-timeout.[ch]: New files for mainloop timeouts.
5711 2003-01-19 Anders Carlsson <andersca@codefactory.se>
5713 * dbus/dbus-string.c (_dbus_string_move_len): Don't delete all
5714 of the string, just as long as specified.
5716 2003-01-19 Havoc Pennington <hp@pobox.com>
5718 * dbus/dbus-connection.c (dbus_connection_get_is_authenticated):
5721 * dbus/dbus-server.c (dbus_server_set_max_connections)
5722 (dbus_server_get_max_connections, dbus_server_get_n_connections):
5723 keep track of current number of connections, and add API for
5724 setting a max (but haven't implemented enforcing the max yet)
5726 2003-01-18 Havoc Pennington <hp@pobox.com>
5728 * dbus/dbus-transport-unix.c (unix_do_iteration): only do the
5729 reading/writing if read_watch != NULL or write_watch != NULL.
5731 * dbus/dbus-message.c (_dbus_message_loader_return_buffer): fix
5732 the message loader code to actually load message->header and
5733 message->body into the newly-created message.
5735 * dbus/dbus-transport-unix.c (check_write_watch): fix a mem leak
5738 * dbus/dbus-connection.c (dbus_connection_set_max_message_size)
5739 (dbus_connection_get_max_message_size)
5740 (dbus_connection_set_max_live_messages_size)
5741 (dbus_connection_get_max_live_messages_size): implement some
5742 resource limitation functions
5744 * dbus/dbus-resources.c: new file implementing some of the
5745 resource limits stuff
5747 * dbus/dbus-message.c (dbus_message_iter_get_byte_array): add
5748 missing docs, add @todo to handle OOM etc.
5750 * dbus/dbus-marshal.c (_dbus_demarshal_byte_array): add missing
5753 2003-01-18 Havoc Pennington <hp@pobox.com>
5755 * dbus/dbus-connection.c (dbus_connection_unref): disconnect the
5756 connection if it hasn't been already.
5758 * dbus/dbus-connection.h: kill off the idea of an ErrorFunction,
5759 replace with DisconnectFunction.
5761 2003-01-18 Havoc Pennington <hp@pobox.com>
5763 Building --disable-verbose-mode --disable-asserts --disable-tests
5764 cuts the library from 112K to 45K or so
5766 * configure.in: check for varargs macro support,
5767 add --enable-verbose-mode, --enable-asserts.
5769 * dbus/dbus-internals.h (_dbus_assert): support
5771 (_dbus_verbose): support DBUS_ENABLE_VERBOSE_MODE
5773 2003-01-18 Havoc Pennington <hp@pobox.com>
5775 * dbus/dbus-test.c: include config.h so that tests actually run
5777 * dbus/dbus-string.c: add assertions that stuff is 8-byte aligned,
5778 so the failure mode when that assumption fails will be plenty
5781 2003-01-18 Havoc Pennington <hp@pobox.com>
5783 * configure.in: default --enable-tests to $USE_MAINTAINER_MODE
5785 * dbus/Makefile.am: fix it up so dubs-test-main.c is included in
5788 * test/Makefile.am: don't use special variable "TESTS" for echo-*
5789 since we don't want to use those in make check
5791 2003-01-15 Havoc Pennington <hp@redhat.com>
5797 2003-01-15 Havoc Pennington <hp@redhat.com>
5799 * test/Makefile.am: fix so that test source code ends up in the
5800 distribution on make distcheck
5802 2003-01-15 Havoc Pennington <hp@redhat.com>
5808 2003-01-15 Havoc Pennington <hp@redhat.com>
5810 * dbus/dbus-test.c (dbus_internal_symbol_do_not_use_run_tests):
5811 fix build when --disable-tests
5813 * Makefile.am (EXTRA_DIST): put HACKING in here
5815 * HACKING: document procedure for making a tarball release.
5817 2003-01-14 Anders Carlsson <andersca@codefactory.se>
5819 * bus/connection.c: (connection_error_handler),
5820 (bus_connection_setup):
5821 * bus/main.c: (main):
5822 Make sure that the DBusConnectionData struct is NULLed
5823 out to prevent a segfault.
5825 * dbus/dbus-errors.c: (dbus_result_to_string):
5826 * dbus/dbus-errors.h:
5827 * dbus/dbus-message.c: (dbus_message_get_fields),
5828 (dbus_message_get_fields_valist), (_dbus_message_test):
5829 * dbus/dbus-message.h:
5830 Make dbus_message_get_fields return a result code so we can
5831 track invalid fields as well as oom.
5833 2003-01-11 Havoc Pennington <hp@pobox.com>
5835 * configure.in: change --enable-test/--enable-ansi action-if-given
5836 to enable_foo=$enableval instead of enable_foo=yes
5838 2003-01-08 Havoc Pennington <hp@pobox.com>
5840 * dbus/dbus-string.c (_dbus_string_align_length): new function
5842 * dbus/dbus-test-main.c: move main() for test app here
5844 (dbus_internal_symbol_do_not_use_run_tests): we have to export a
5845 symbol to run tests, because dbus-test isn't in the main
5848 Code review nitpicks.
5850 * dbus/dbus-message.c (dbus_message_write_header): add newlines
5851 for people with narrow emacs ;-). Assert client_serial was filled
5852 in. Assert message->name != NULL.
5853 (dbus_message_append_fields): have "first_field_type" arg separate
5854 from va list, needed for C++ binding that also uses varargs IIRC
5855 and helps with type safety
5856 (dbus_message_new): add @todo about using DBusString to store
5857 service/name internally
5858 (dbus_message_new): don't leak ->service and ->name on OOM later
5860 (dbus_message_unref): free the service name
5861 (dbus_message_get_fields): same change to varargs
5862 i.e. first_field_type
5863 (_dbus_message_loader_return_buffer): assert that the message data
5864 is aligned (if not it's a bug in our code). Put in verbose griping
5865 about why we set corrupted = TRUE.
5866 (decode_header_data): add FIXME that char* is evil. Was going to
5867 add FIXME about evil locale-specific string.h strncmp, but just
5868 switched to wacky string-as-uint32 optimization. Move check for
5869 "no room for field name" above get_const_data_len() to avoid
5870 assertion failure in get_const_data_len if we have trailing 2
5871 bytes or the like. Check for service and name fields being
5872 provided twice. Don't leak service/name on error. Require field
5873 names to be aligned to 4 bytes.
5875 * dbus/dbus-marshal.c: move byte swap stuff to header
5876 (_dbus_pack_int32): uscore-prefix
5877 (_dbus_unpack_int32): uscore-prefix
5878 (_dbus_unpack_uint32): export
5879 (_dbus_demarshal_string): add @todo complaining about use of
5881 (_dbus_marshal_get_field_end_pos): add @todo about bad error
5882 handling allowing corrupt data to go unchecked
5884 2003-01-08 Havoc Pennington <hp@redhat.com>
5886 * dbus/dbus-transport-unix.c (unix_do_iteration): add read/write
5887 to the select() as needed for authentication. (should be using
5888 _dbus_poll() not select, but for another day)
5890 * dbus/dbus.h: include dbus/dbus-protocol.h
5892 2003-01-08 Anders Carlsson <andersca@codefactory.se>
5894 * dbus/Makefile.am (dbusinclude_HEADERS): Install
5897 2003-01-08 Anders Carlsson <andersca@codefactory.se>
5899 * dbus/dbus-internals.c: (_dbus_type_to_string):
5900 New function that returns a string describing a type.
5902 * dbus/dbus-marshal.c: (_dbus_demarshal_byte_array):
5903 * dbus/dbus-marshal.h:
5904 * dbus/dbus-message.c: (dbus_message_get_fields_valist),
5905 (dbus_message_iter_get_field_type), (dbus_message_iter_get_double),
5906 (dbus_message_iter_get_byte_array):
5907 * dbus/dbus-message.h:
5908 Add new convenience functions for appending and getting message fields.
5909 Also add demarshalling routines for byte arrays.
5911 2003-01-07 Anders Carlsson <andersca@codefactory.se>
5913 * dbus/dbus-connection-internal.h:
5914 * dbus/dbus-connection.c: (_dbus_connection_new_for_transport),
5915 (_dbus_connection_get_next_client_serial),
5916 (dbus_connection_send_message):
5917 * dbus/dbus-internals.h:
5918 * dbus/dbus-marshal.c: (unpack_uint32), (dbus_unpack_int32),
5919 (dbus_pack_int32), (_dbus_marshal_double), (_dbus_marshal_int32),
5920 (_dbus_marshal_uint32), (_dbus_demarshal_double),
5921 (_dbus_demarshal_int32), (_dbus_demarshal_uint32),
5922 (_dbus_demarshal_string), (_dbus_marshal_get_field_end_pos),
5923 (_dbus_verbose_bytes), (_dbus_marshal_test):
5924 * dbus/dbus-marshal.h:
5925 * dbus/dbus-message-internal.h:
5926 * dbus/dbus-message.c: (_dbus_message_set_client_serial),
5927 (dbus_message_write_header), (_dbus_message_lock),
5928 (dbus_message_new), (dbus_message_ref), (dbus_message_unref),
5929 (dbus_message_get_name), (dbus_message_append_int32),
5930 (dbus_message_append_uint32), (dbus_message_append_double),
5931 (dbus_message_append_string), (dbus_message_append_byte_array),
5932 (dbus_message_get_fields_iter), (dbus_message_iter_ref),
5933 (dbus_message_iter_unref), (dbus_message_iter_has_next),
5934 (dbus_message_iter_next), (dbus_message_iter_get_field_type),
5935 (dbus_message_iter_get_string), (dbus_message_iter_get_int32),
5936 (dbus_message_iter_get_uint32), (dbus_message_iter_get_double),
5937 (decode_header_data), (_dbus_message_loader_return_buffer),
5938 (message_iter_test), (_dbus_message_test):
5939 * dbus/dbus-message.h:
5940 * dbus/dbus-protocol.h:
5941 * dbus/dbus-test.c: (main):
5943 * glib/test-dbus-glib.c: (message_handler), (main):
5944 * test/echo-client.c: (main):
5945 * test/watch.c: (check_messages):
5946 Make messages sendable and receivable for real.
5948 2003-01-07 Anders Carlsson <andersca@codefactory.se>
5950 * dbus/dbus-marshal.c: (_dbus_marshal_double),
5951 (_dbus_marshal_string), (_dbus_marshal_byte_array):
5952 * dbus/dbus-message.c: (dbus_message_append_int32),
5953 (dbus_message_append_uint32), (dbus_message_append_double),
5954 (dbus_message_append_string), (dbus_message_append_byte_array):
5955 Handle OOM restoration.
5957 2003-01-07 Anders Carlsson <andersca@codefactory.se>
5959 * dbus/dbus-marshal.c: (_dbus_marshal_string),
5960 (_dbus_demarshal_string), (_dbus_marshal_test):
5961 * dbus/dbus-marshal.h:
5962 * dbus/dbus-message.c: (dbus_message_get_name),
5963 Document these functions.
5965 (dbus_message_append_int32), (dbus_message_append_uint32),
5966 (dbus_message_append_double), (dbus_message_append_string),
5967 (dbus_message_append_byte_array):
5968 * dbus/dbus-message.h:
5969 Add functions for adding message fields of different types.
5971 * dbus/dbus-protocol.h:
5972 Add the different types.
5974 2003-01-05 Havoc Pennington <hp@pobox.com>
5976 * bus/connection.c: implement routines for handling connections,
5977 first thing is keeping a list of owned services on each connection
5978 and setting up watches etc.
5980 * bus/services.c: implement a mapping from service names to lists
5983 * dbus/dbus-hash.c: add DBUS_HASH_POINTER
5985 * dbus/dbus-threads.c (dbus_static_mutex_lock): add functions
5986 to use static mutexes for global data
5988 * dbus/dbus-connection.c (dbus_connection_set_data): add new
5989 collection of functions to set/get application-specific data
5990 on the DBusConnection.
5992 2003-01-04 Havoc Pennington <hp@pobox.com>
5994 * dbus/dbus-sysdeps.c (_dbus_sleep_milliseconds): new function
5995 (_dbus_poll): new function
5997 * dbus/dbus-internals.h (_DBUS_STRUCT_OFFSET): new macro
6000 * bus/loop.c: initial code for the daemon main loop
6002 2003-01-04 Havoc Pennington <hp@pobox.com>
6004 * test/watch.c (error_handler): make it safe if the error handler
6005 is called multiple times (if we s/error handler/disconnect
6006 handler/ we should just guarantee it's called only once)
6008 * dbus/dbus-transport.c (_dbus_transport_disconnect): call the
6009 error handler on disconnect (it's quite possible we should
6010 just change the error handler to a "disconnect handler," I'm
6011 not sure we have any other meaningful errors)
6013 * configure.in: check for getpwnam_r
6015 * dbus/dbus-transport.c, dbus/dbus-transport-unix.c,
6016 dbus/dbus-auth.c: add credentials support, add EXTERNAL auth
6017 mechanism as in SASL spec, using socket credentials
6019 * dbus/dbus-sysdeps.c (_dbus_read_credentials_unix_socket): new function
6020 (_dbus_send_credentials_unix_socket): new function
6022 * dbus/dbus-sysdeps.c (_dbus_accept_unix_socket): rename just
6024 (_dbus_write): only check errno if <0 returned
6025 (_dbus_write_two): ditto
6027 2003-01-02 Anders Carlsson <andersca@codefactory.se>
6029 * dbus/dbus-marshal.c: (_dbus_marshal_utf8_string),
6030 (_dbus_marshal_byte_array), (_dbus_demarshal_utf8_string),
6031 (_dbus_marshal_test):
6032 * dbus/dbus-marshal.h:
6033 Add _dbus_marshal_byte_array and rename _dbus_marshal_string
6034 to _dbus_marshal_utf8_string. Also fix some tests.
6036 2002-12-28 Harri Porten <porten@kde.org>
6038 * configure.in: added check for C++ compiler and a very cheesy
6039 check for the Qt integration
6041 * Makefile.am (SUBDIRS): compile qt subdir if support is enabled
6043 * qt/Makefile.am: added
6045 * qt/.cvsignore: added
6047 * qt/dbus-qthread.cc, qt/dbus-qthread.cpp: renamed former to
6048 latter, added #ifdef QT_THREAD_SUPPORT guard.
6050 * dbus/Makefile.am: added missing headers for make dist
6052 2002-12-28 Kristian Rietveld <kris@gtk.org>
6054 * dbus/Makefile.am: fixup export-symbols-regex.
6056 2002-12-27 Anders Carlsson <andersca@codefactory.se>
6058 * acinclude.m4: Add this file and put the
6059 PKG_CHECK_MODULE macro in it.
6061 2002-12-27 Anders Carlsson <andersca@codefactory.se>
6063 * dbus/dbus-marshal.c: (_dbus_marshal_string),
6064 (_dbus_demarshal_double), (_dbus_demarshal_int32),
6065 (_dbus_demarshal_uint32), (_dbus_demarshal_string),
6066 (_dbus_marshal_test):
6067 Make the demarshalling routines align the pos argument.
6068 Add string marshalling tests and fix the obvious bugs
6071 2002-12-26 Havoc Pennington <hp@pobox.com>
6073 * dbus/dbus-auth.c: fixes fixes fixes
6075 * dbus/dbus-transport-unix.c: wire up support for
6076 encoding/decoding data on the wire
6078 * dbus/dbus-auth.c (_dbus_auth_encode_data)
6079 (_dbus_auth_decode_data): append to target string
6080 instead of nuking it.
6082 2002-12-26 Havoc Pennington <hp@pobox.com>
6084 * dbus/dbus-marshal.h (DBUS_COMPILER_BYTE_ORDER): #ifdef
6085 WORDS_BIGENDIAN then compiler byte order is DBUS_BIG_ENDIAN,
6088 * dbus/dbus-marshal.c: Add macros to do int swapping in-place and
6089 avoid swap_bytes() overhead (ignoring possible assembly stuff for
6090 now). Main point is because I wanted unpack_uint32 to implement
6092 (_dbus_verbose_bytes): new function
6094 * dbus/dbus-string.c (_dbus_string_validate_ascii): new function
6096 * dbus/dbus-message.c (_dbus_message_loader_get_is_corrupted): add
6097 mechanism to handle a corrupt message stream
6098 (_dbus_message_loader_new): fix preallocation to only prealloc,
6101 * dbus/dbus-string.c (_dbus_string_skip_blank): fix this function
6102 (_dbus_string_test): enhance tests for copy/move and fix the
6105 * dbus/dbus-transport-unix.c: Hold references in more places to
6106 avoid reentrancy problems
6108 * dbus/dbus-transport.c: ditto
6110 * dbus/dbus-connection.c (dbus_connection_dispatch_message): don't
6111 leak reference count in no-message case
6113 * test/watch.c (do_mainloop): handle adding/removing watches
6114 during iteration over the watches. Also, ref the connection/server
6115 stored on a watch, so we don't try to mangle a destroyed one.
6117 * dbus/dbus-transport-unix.c (do_authentication): perform
6120 * dbus/dbus-auth.c (get_state): add a state
6121 AUTHENTICATED_WITH_UNUSED_BYTES and return it if required
6122 (_dbus_auth_get_unused_bytes): append the unused bytes
6123 to the passed in string, rather than prepend
6125 * dbus/dbus-transport.c (_dbus_transport_init_base): create
6126 the auth conversation DBusAuth
6128 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_fd)
6129 (_dbus_transport_new_for_domain_socket): when creating a
6130 transport, pass in whether it's a client-side or server-side
6131 transport so we know which DBusAuth to create
6133 2002-12-03 Havoc Pennington <hp@pobox.com>
6135 * dbus/dbus-transport-unix.c (unix_finalize): finalize base
6136 _after_ finalizing the derived members
6137 (unix_connection_set): unref watch if we fail to add it
6139 * dbus/dbus-connection.c (dbus_connection_unref): delete the
6140 transport first, so that the connection owned by the
6141 transport will be valid as the transport finalizes.
6143 * dbus/dbus-transport-unix.c (unix_finalize): free the write_watch
6144 if necessary, and remove watches from the connection.
6146 * dbus/dbus-watch.c (_dbus_watch_list_free): improve a comment
6148 2002-12-26 Anders Carlsson <andersca@codefactory.se>
6150 * dbus/dbus-marshal.c: (_dbus_marshal_string),
6151 (_dbus_demarshal_double), (_dbus_demarshal_int32),
6152 (_dbus_demarshal_uint32), (_dbus_demarshal_string),
6153 (_dbus_marshal_test):
6154 * dbus/dbus-marshal.h:
6155 Add string marshal functions and have the demarshal functions
6156 return the new position.
6158 2002-12-25 Havoc Pennington <hp@pobox.com>
6160 * doc/dbus-sasl-profile.txt: docs on the authentication protocol,
6161 it is a simple protocol that just maps directly to SASL.
6163 * dbus/dbus-auth.h, dbus/dbus-auth.c: authentication protocol
6164 initial implementation, not actually used yet.
6166 * dbus/dbus-string.c (_dbus_string_find): new function
6167 (_dbus_string_equal): new function
6168 (_dbus_string_base64_encode): new function
6169 (_dbus_string_base64_decode): new function
6171 2002-12-25 Anders Carlsson <andersca@codefactory.se>
6174 * dbus/dbus-marshal.c: (swap_bytes), (_dbus_marshal_double),
6175 (_dbus_marshal_int32), (_dbus_marshal_uint32),
6176 (_dbus_demarshal_double), (_dbus_demarshal_int32),
6177 (_dbus_demarshal_uint32), (_dbus_marshal_test):
6178 * dbus/dbus-marshal.h:
6179 * dbus/dbus-protocol.h:
6180 * dbus/dbus-test.c: (main):
6182 Add un-optimized marshalling/demarshalling routines.
6184 2002-12-25 Harri Porten <porten@kde.org>
6186 * qt/dbus-qt.h: adjusted ctor and getter to KDE/Qt conventions
6188 2002-12-24 Zack Rusin <zack@kde.org>
6190 * qt/dbus-qthread.cc: adding - integrates QMutex into Dbus
6191 * qt/dbus-qt.h: skeleton with two sample implemenatation of the
6194 2002-12-24 Havoc Pennington <hp@pobox.com>
6196 * glib/dbus-gthread.c: fix include
6198 * glib/dbus-glib.h: rename DBusMessageHandler for now.
6199 I think glib API needs to change, though, as you don't
6200 want to use DBusMessageFunction, you want to use the
6201 DBusMessageHandler object. Probably
6202 dbus_connection_open_with_g_main_loop()
6203 and dbus_connection_setup_g_main_loop() or something like that
6204 (but think of better names...) that just create a connection
6205 that has watch/timeout functions etc. already set up.
6207 * dbus/dbus-connection.c
6208 (dbus_connection_send_message_with_reply): new function just to
6209 show how the message handler helps us deal with replies.
6211 * dbus/dbus-list.c (_dbus_list_remove_last): new function
6213 * dbus/dbus-string.c (_dbus_string_test): free a string that
6216 * dbus/dbus-hash.c: use memory pools for the hash entries
6217 (rebuild_table): be more paranoid about overflow, and
6218 shrink table when we can
6219 (_dbus_hash_test): reduce number of sprintfs and write
6220 valid C89. Add tests for case where we grow and then
6221 shrink the hash table.
6223 * dbus/dbus-mempool.h, dbus/dbus-mempool.c: memory pools
6225 * dbus/dbus-connection.c (dbus_connection_register_handler)
6226 (dbus_connection_unregister_handler): new functions
6228 * dbus/dbus-message.c (dbus_message_get_name): new
6230 * dbus/dbus-list.c: fix docs typo
6232 * dbus/dbus-message-handler.h, dbus/dbus-message-handler.c:
6233 an object representing a handler for messages.
6235 2002-12-16 Anders Carlsson <andersca@codefactory.se>
6238 * glib/dbus-gthread.c: (dbus_gthread_init):
6239 Don't use the gdbus prefix for public functions.
6241 2002-12-16 Anders Carlsson <andersca@codefactory.se>
6245 Add GLib checks and fixup .pc files
6249 * glib/dbus-gmain.c: (gdbus_connection_prepare),
6250 (gdbus_connection_check), (gdbus_connection_dispatch),
6251 (gdbus_add_connection_watch), (gdbus_remove_connection_watch),
6252 (dbus_connection_gsource_new):
6253 * glib/dbus-gthread.c: (dbus_gmutex_new), (dbus_gmutex_free),
6254 (dbus_gmutex_lock), (dbus_gmutex_unlock), (dbus_gthread_init):
6255 * glib/test-dbus-glib.c: (message_handler), (main):
6258 2002-12-15 Harri Porten <porten@kde.org>
6260 * autogen.sh: check for libtoolize before attempting to use it
6262 * dbus/dbus-transport-unix.c: include <sys/time.h> for timeval
6265 * .cvsignore: ignore more stamp files
6267 * dbus/dbus-watch.c (_dbus_watch_list_new): fixed doc error
6269 * test/Makefile.am: added -I$(top_srcdir) to be able to compile
6270 without make install.
6272 2002-12-15 Havoc Pennington <hp@pobox.com>
6274 * dbus/dbus-threads.c: add thread stubs that a higher library
6275 layer can fill in. e.g. the GLib wrapper might fill them in with
6276 GThread stuff. We still need to use this thread API to
6277 thread-safe-ize the library.
6279 2002-12-12 Havoc Pennington <hp@pobox.com>
6281 * dbus/dbus-transport-unix.c, dbus/dbus-server-unix.c: use the
6282 below new interfaces and include fewer system headers.
6284 * dbus/dbus-sysdeps.c (_dbus_read): new function
6285 (_dbus_write): new function
6286 (_dbus_write_two): new function
6287 (_dbus_connect_unix_socket): new function
6288 (_dbus_listen_unix_socket): new function
6290 * dbus/dbus-message-internal.h: change interfaces to use
6293 2002-12-11 Havoc Pennington <hp@pobox.com>
6295 * dbus/dbus-types.h: add dbus_unichar
6297 * dbus/dbus-internals.c (_dbus_verbose): use _dbus_getenv
6299 * dbus/dbus-connection.c (dbus_connection_send_message): return
6302 * dbus/dbus-transport.c: include dbus-watch.h
6304 * dbus/dbus-connection.c: include dbus-message-internal.h
6306 * HACKING: add file with coding guidelines stuff.
6308 * dbus/dbus-string.h, dbus/dbus-string.c: Encapsulate all string
6309 handling here, for security purposes (as in vsftpd). Not actually
6310 using this class yet.
6312 * dbus/dbus-sysdeps.h, dbus/dbus-sysdeps.c: Encapsulate all
6313 system/libc usage here, as in vsftpd, for ease of auditing (and
6314 should also simplify portability). Haven't actually moved all the
6315 system/libc usage into here yet.
6317 2002-11-25 Havoc Pennington <hp@pobox.com>
6319 * dbus/dbus-internals.c (_dbus_verbose): fix to not
6320 always print the first verbose message.
6322 2002-11-24 Havoc Pennington <hp@pobox.com>
6324 * test/echo-client.c, test/echo-server.c: cheesy test
6327 * configure.in (AC_CHECK_FUNCS): check for writev
6329 * dbus/dbus-message.c (_dbus_message_get_network_data): new
6332 * dbus/dbus-list.c (_dbus_list_foreach): new function
6334 * dbus/dbus-internals.c (_dbus_verbose): new function
6336 * dbus/dbus-server.c, dbus/dbus-server.h: public object
6337 representing a server that listens for connections.
6339 * dbus/.cvsignore: create
6341 * dbus/dbus-errors.h, dbus/dbus-errors.c:
6342 public API for reporting errors
6344 * dbus/dbus-connection.h, dbus/dbus-connection.c:
6345 public object representing a connection that
6346 sends/receives messages. (Same object used for
6347 both client and server.)
6349 * dbus/dbus-transport.h, dbus/dbus-transport.c:
6350 Basic abstraction for different kinds of stream
6351 that we might read/write messages from.
6353 2002-11-23 Havoc Pennington <hp@pobox.com>
6355 * dbus/dbus-internals.h (_DBUS_INT_MAX): add _DBUS_INT_MIN
6358 * dbus/dbus-test.c (main): add list test, and include
6359 dbus-test.h as intended
6361 * dbus/dbus-hash.c (_dbus_hash_table_remove_string)
6362 (_dbus_hash_table_remove_int): return value indicates
6363 whether the entry existed to remove
6365 * dbus/dbus-list.c: add linked list utility class,
6368 * dbus/dbus-hash.c: add TODO item about shrinking the hash bucket
6371 2002-11-23 Havoc Pennington <hp@pobox.com>
6373 * Doxyfile.in (INCLUDE_FILE_PATTERNS): expand DBUS_BEGIN_DECLS/
6374 DBUS_END_DECLS to nothing, that should fix this once and for all
6376 * Doxyfile.in (JAVADOC_AUTOBRIEF): set to YES
6378 * dbus/dbus-message.c, dbus/dbus-hash.c:
6379 add some missing @brief
6381 2002-11-23 Havoc Pennington <hp@pobox.com>
6383 * dbus/dbus-message.h: put semicolons after DEBUG_BEGIN_DECLS
6384 to avoid confusing Doxygen
6386 * dbus/dbus-hash.c: @} not }@
6388 * dbus/dbus-message.c (struct DBusMessage): split out
6391 2002-11-23 Havoc Pennington <hp@pobox.com>
6393 * configure.in: pile on more warning flags if using gcc
6395 * Doxyfile.in (EXTRACT_STATIC): set to NO, so we don't have
6396 to document static functions
6398 * configure.in: add summary to end of configure so it
6399 looks nice and attractive
6401 * dbus/dbus-hash.c: finish implementation and write unit
6404 * configure.in: add --enable-tests to enable unit tests
6406 * dbus/dbus-test.c: test program to run unit tests
6407 for all files in dbus/*, initially runs a test for
6410 * dbus/dbus-internals.h: file to hold some internal utility stuff
6412 2002-11-22 Havoc Pennington <hp@redhat.com>
6414 * dbus/dbus-hash.c: copy in Tcl hash table, not yet
6415 "ported" away from Tcl
6417 * dbus/dbus-types.h: header for types such as dbus_bool_t
6419 2002-11-22 Havoc Pennington <hp@redhat.com>
6421 * dbus/dbus.h: fixups for doc warnings
6423 * Doxyfile.in (FILE_PATTERNS): we need to scan .h to pick up
6425 (QUIET): make it quiet so we can see warnings
6427 * dbus/dbus-memory.c: teach D-BUS to allocate and free memory
6429 2002-11-22 Havoc Pennington <hp@redhat.com>
6431 * Makefile.am: include "Doxyfile" target in all-local
6433 * configure.in: generate the Doxyfile
6435 * Doxyfile.in: move Doxyfile here, so we can use
6436 configure to generate a Doxyfile with the right
6439 2002-11-22 Havoc Pennington <hp@redhat.com>
6441 * dbus/dbus-message.c: move inline docs into .c file
6443 * Doxyfile (OUTPUT_DIRECTORY): move output to doc/api
6444 so all docs are under doc/
6445 (MAN_EXTENSION): generate man pages. Use extension
6446 ".3dbus" which matches ".3qt" on my system,
6447 I guess this is OK, I don't know really.
6448 (FILE_PATTERNS): look for .c files not .h, makes sense
6451 2002-11-22 Havoc Pennington <hp@pobox.com>
6453 * Makefile.am (SUBDIRS): rename subdir "server" to "bus"
6454 because any app can be a server, and any app can be a client,
6455 the bus is a special kind of server.
6457 Thu Nov 21 23:35:31 2002 Zack Rusin <zack@kde.org>
6459 * Doxyfile : adding. Still needs Makefile rules to be generated
6460 automatically (just run "doxygen" in the toplevel dir for now to
6463 * dbus/dbus-message.h : Adding sample docs (javadoc since
6464 resembles gtk-doc a little more)
6466 * dbus/dbus.h : Adding sample docs
6468 2002-11-21 Havoc Pennington <hp@redhat.com>
6470 * dbus/Makefile.am (INCLUDES): define DBUS_COMPILATION
6471 so we can allow ourselves to include files directly,
6472 instead of having to use dbus.h
6474 * dbus/dbus.h: fill in
6476 * dbus/dbus-message.h: sketch out a sample header file.
6477 Include griping if you include it directly instead of
6480 * dbus/dbus-macros.h: new file with macros for extern "C",
6481 TRUE/FALSE, NULL, etc.
6483 * doc/file-boilerplate.c: put include guards in here
6485 2002-11-21 Havoc Pennington <hp@redhat.com>
6487 * doc/file-boilerplate.c: include both AFL and GPL boilerplate.
6489 * COPYING: include the GPL as well, and license code
6490 under both AFL and GPL.
6492 2002-11-21 Havoc Pennington <hp@redhat.com>
6494 * acconfig.h: get rid of this
6496 * autogen.sh (run_configure): add --no-configure option
6498 * configure.in: remove AC_ARG_PROGRAM to make
6499 autoconf complain less. add AC_PREREQ.
6500 add AC_DEFINE third arg.
6502 2002-11-21 Anders Carlsson <andersca@codefactory.se>
6505 Fix references so we can distcheck.
6507 2002-11-21 Havoc Pennington <hp@redhat.com>
6509 * Initial module creation