1 2003-09-29 Havoc Pennington <hp@pobox.com>
3 * Merge dbus-object-names branch. To see the entire patch
4 do cvs diff -r DBUS_OBJECT_NAMES_BRANCHPOINT -r dbus-object-names,
6 To revert, I tagged DBUS_BEFORE_OBJECT_NAMES_MERGE.
8 2003-09-28 Havoc Pennington <hp@pobox.com>
10 * HACKING: update to reflect new server
12 2003-09-26 Seth Nickell <seth@gnome.org>
15 * python/examples/example-signals.py:
17 Start implementing some notions of signals. The API
18 is really terrible, but they sort of work (with the
19 exception of being able to filter by service, and to
20 transmit signals *as* a particular service). Need to
21 figure out how to make messages come from the service
24 * python/dbus_bindings.pyx.in:
26 Removed duplicate message_handler callbacks.
28 2003-09-25 Havoc Pennington <hp@redhat.com>
30 * bus/session.conf.in: fix my mess
32 2003-09-25 Havoc Pennington <hp@pobox.com>
34 * bus/session.conf.in: fix security policy, reported by Seth Nickell
36 2003-09-25 Seth Nickell <seth@gnome.org>
38 * python/examples/example-service.py:
40 Johan notices complete wrong code in example-service, but
41 completely wrong in a way that works exactly the same (!).
42 Johan is confused, how could this possibly work? Example
43 code fails to serve purpose of making things clear.
46 2003-09-25 Mark McLoughlin <mark@skynet.ie>
48 * doc/dbus-specification.sgml: don't require header fields
49 to be 4-byte aligned and specify that fields should be
50 distinguished from padding by the fact that zero is not
53 * doc/TODO: remove re-alignment item and add item to doc
56 * dbus/dbus-message.c:
57 (HeaderField): rename the original member to value_offset
58 and introduce a name_offset member to keep track of where
59 the field actually begins.
60 (adjust_field_offsets): remove.
61 (append_int_field), (append_uint_field),
62 (append_string_field): don't align the start of the header
63 field to a 4-byte boundary.
64 (get_next_field): impl finding the next marhsalled field
66 (re_align_field_recurse): impl re-aligning a number of
67 already marshalled fields.
68 (delete_field): impl deleting a field of any type and
69 re-aligning any following fields.
70 (delete_int_or_uint_field), (delete_string_field): remove.
71 (set_int_field), (set_uint_field): no need to re-check
72 that we have the correct type for the field.
73 (set_string_field): ditto and impl re-aligning any
75 (decode_header_data): update to take into account that
76 the fields aren't 4-byte aligned any more and the new
77 way to distinguish padding from header fields. Also,
78 don't exit when there is too much header padding.
79 (process_test_subdir): print the directory.
80 (_dbus_message_test): add test to make sure a following
81 field is re-aligned correctly after field deletion.
83 * dbus/dbus-string.[ch]:
84 (_dbus_string_insert_bytes): rename from insert_byte and
85 allow the insert of multiple bytes.
86 (_dbus_string_test): test inserting multiple bytes.
88 * dbus/dbus-marshal.c: (_dbus_marshal_set_string): add
89 warning note to docs about having to re-align any
90 marshalled values following the string.
92 * dbus/dbus-message-builder.c:
93 (append_string_field), (_dbus_message_data_load):
94 don't align the header field.
96 * dbus/dbus-auth.c: (process_test_subdir): print the
99 * test/break-loader.c: (randomly_add_one_byte): upd. for
102 * test/data/invalid-messages/bad-header-field-alignment.message:
105 * test/data/valid-messages/unknown-header-field.message: shove
106 a dict in the unknown field.
108 2003-09-25 Seth Nickell <seth@gnome.org>
111 * python/dbus_bindings.pyx.in:
113 Handle return values.
115 * python/examples/example-client.py:
116 * python/examples/example-service.py:
118 Pass back return values from the service to the client.
120 2003-09-24 Seth Nickell <seth@gnome.org>
124 Connect Object methods (when you are sharing an object) up... pass
125 in a list of methods to be shared. Sharing all the methods just
126 worked out too weird. You can now create nice Services over the
129 * python/dbus_bindings.pyx.in:
131 Keep references to user_data tuples passed into C functions so
132 Python doesn't garbage collect on us.
134 Implement MethodReturn and Error subclasses of Message for creating
135 DBusMessage's of those types.
137 * python/examples/example-client.py:
138 * python/examples/example-service.py:
140 Simple example code showing both how create DBus services and objects,
143 2003-09-23 Havoc Pennington <hp@pobox.com>
145 * glib/dbus-gproxy.c (dbus_gproxy_manager_filter): implement
147 2003-09-23 Havoc Pennington <hp@redhat.com>
149 * glib/dbus-gproxy.c (dbus_gproxy_connect_signal): implement
150 (dbus_gproxy_disconnect_signal): implement
151 (dbus_gproxy_manager_remove_signal_match): implement
152 (dbus_gproxy_manager_add_signal_match): implement
153 (dbus_gproxy_oneway_call): implement
155 2003-09-23 Havoc Pennington <hp@pobox.com>
157 * glib/dbus-gproxy.c (struct DBusGProxy): convert to a GObject
158 subclass. This means dropping the transparent thread safety of the
159 proxy; you now need a separate proxy per-thread, or your own
160 locking on the proxy. Probably right anyway.
161 (dbus_gproxy_ref, dbus_gproxy_unref): nuke, just use g_object_ref
163 2003-09-22 Havoc Pennington <hp@redhat.com>
165 * glib/dbus-gproxy.c (dbus_gproxy_manager_get): implement
167 2003-09-21 Seth Nickell <seth@gnome.org>
169 First checkin of the Python bindings.
172 * python/Makefile.am:
173 * python/dbus_bindings.pyx.in:
174 * python/dbus_h_wrapper.h:
176 Pieces for Pyrex to operate on, building a dbus_bindings.so
177 python module for low-level access to the DBus APIs.
181 High-level Python module for accessing DBus objects.
186 Build stuff for the python bindings.
190 Extra macro needed for finding the Python C header files.
192 2003-09-21 Havoc Pennington <hp@pobox.com>
194 * glib/dbus-gproxy.c (dbus_gproxy_manager_new): start
195 implementing the proxy manager, didn't get very far.
197 * dbus/dbus-bus.c (dbus_bus_add_match): new
198 (dbus_bus_remove_match): new
200 * glib/dbus-gproxy.c (dbus_gproxy_new_for_service): add a
201 path_name argument; adjust the other not-yet-implemented
202 gproxy constructors to be what I think they should be.
204 2003-09-21 Havoc Pennington <hp@pobox.com>
206 * dbus/dbus-bus.c (dbus_bus_get): set exit_on_disconnect to TRUE
207 by default for message bus connections.
209 * dbus/dbus-connection.c (dbus_connection_dispatch): exit if
210 exit_on_disconnect flag is set and we process the disconnected
212 (dbus_connection_set_exit_on_disconnect): new function
214 2003-09-21 Havoc Pennington <hp@pobox.com>
216 Get matching rules mostly working in the bus; only actually
217 parsing the rule text remains. However, the client side of
218 "signal connections" hasn't been started, this patch is only the
221 * dbus/dispatch.c: fix for the matching rules changes
223 * bus/driver.c (bus_driver_handle_remove_match)
224 (bus_driver_handle_add_match): send an ack reply from these
227 * glib/dbus-gproxy.c (dbus_gproxy_begin_call): fix order of
228 arguments, reported by Seth Nickell
230 * bus/config-parser.c (append_rule_from_element): support
231 eavesdrop=true|false attribute on policies so match rules
232 can be prevented from snooping on the system bus.
234 * bus/dbus-daemon-1.1.in: consistently use terminology "sender"
235 and "destination" in attribute names; fix some docs bugs;
236 add eavesdrop=true|false attribute
238 * bus/driver.c (bus_driver_handle_add_match)
239 (bus_driver_handle_remove_match): handle AddMatch, RemoveMatch
242 * dbus/dbus-protocol.h (DBUS_SERVICE_ORG_FREEDESKTOP_BROADCAST): get
243 rid of broadcast service concept, signals are just always broadcast
245 * bus/signals.c, bus/dispatch.c, bus/connection.c, bus/bus.c:
246 mostly implement matching rules stuff (currently only exposed as signal
249 2003-09-21 Mark McLoughlin <mark@skynet.ie>
251 * doc/dbus-specification.sgml: Change the header field name
252 to be an enum and update the rest of the spec to reference
253 the fields using the conventinal name.
255 * dbus/dbus-protocol.h: update to reflect the spec.
257 * doc/TODO: add item to remove the 4 byte alignment requirement.
259 * dbus/dbus-message.c: Remove the code to generalise the
260 header/body length and serial number header fields as named
261 header fields so we can reference field names using the
263 (append_int_field), (append_uint_field), (append_string_field):
264 Append the field name as a byte rather than four chars.
265 (delete_int_or_uint_field), (delete_string_field): reflect the
266 fact that the field name and typecode now occupy 4 bytes instead
268 (decode_string_field), (decode_header_data): update to reflect
269 protocol changes and move the field specific encoding from
270 decode_string_field() back into decode_header_data().
272 * dbus/dbus-internals.[ch]: (_dbus_header_field_to_string):
273 Add utility to aid debugging.
275 * dbus/dbus-message-builder.c:
276 (append_string_field), (_dbus_message_data_load): Update to
277 reflect protocol changes; Change the FIELD_NAME directive
278 to HEADER_FIELD and allow it to take the field's conventional
279 name rather than the actual value.
281 * test/data/*/*.message: Update to use HEADER_FIELD instead
282 of FIELD_NAME; Always align the header on an 8 byte boundary
283 *before* updating the header length.
285 2003-09-15 Havoc Pennington <hp@pobox.com>
287 * dbus/dbus-pending-call.c: add the get/set object data
288 boilerplate as for DBusConnection, etc. Use generic object data
289 for the notify callback.
291 * glib/dbus-gparser.c (parse_node): parse child nodes
293 * tools/dbus-viewer.c: more hacking on the dbus-viewer
295 * glib/dbus-gutils.c (_dbus_gutils_split_path): add a file to
296 contain functions shared between the convenience lib and the
299 * glib/Makefile.am (libdbus_glib_1_la_LDFLAGS): add
300 -export-symbols-regex to the GLib library
302 * dbus/dbus-object-tree.c (_dbus_object_tree_dispatch_and_unlock):
303 fix the locking in here, and add a default handler for
304 Introspect() that just returns sub-nodes.
306 2003-09-14 Havoc Pennington <hp@pobox.com>
308 * glib/dbus-gthread.c (dbus_g_thread_init): rename to make g_foo
309 rather than gfoo consistent
311 * glib/dbus-gproxy.h: delete for now, move contents to
312 dbus-glib.h, because the include files don't work right since we
313 aren't in the dbus/ subdir.
315 * glib/dbus-gproxy.c (dbus_gproxy_send): finish implementing
316 (dbus_gproxy_end_call): finish
317 (dbus_gproxy_begin_call): finish
319 * glib/dbus-gmain.c (dbus_set_g_error): new
321 * glib/dbus-gobject.c (handle_introspect): include information
322 about child nodes in the introspection
324 * dbus/dbus-connection.c (dbus_connection_list_registered): new
325 function to help in implementation of introspection
327 * dbus/dbus-object-tree.c
328 (_dbus_object_tree_list_registered_and_unlock): new function
330 2003-09-12 Havoc Pennington <hp@pobox.com>
332 * glib/dbus-gidl.h: add common base class for all the foo_info
335 * tools/dbus-viewer.c: add GTK-based introspection UI thingy
338 * test/Makefile.am: try test srcdir -ef . in addition to test
339 srcdir = ., one of them should work (yeah lame)
341 * glib/Makefile.am: build the "idl" parser stuff as a convenience
344 * glib/dbus-gparser.h: make description_load routines return
345 NodeInfo* not Parser*
347 * Makefile.am (SUBDIRS): build test dir after all library dirs
349 * configure.in: add GTK+ detection
351 2003-09-07 Havoc Pennington <hp@pobox.com>
353 * Make Doxygen contented.
355 2003-09-07 Havoc Pennington <hp@pobox.com>
357 * doc/dbus-specification.sgml: more updates
359 2003-09-06 Havoc Pennington <hp@pobox.com>
361 * doc/dbus-specification.sgml: partial updates
363 * bus/dbus-daemon-1.1.in: fix the config file docs for the
364 zillionth time; hopefully I edited the right file this time.
366 * bus/config-parser.c (append_rule_from_element): support
367 send_type, send_path, receive_type, receive_path
369 * bus/policy.c: add message type and path to the list of things
370 that can be "firewalled"
372 2003-09-06 Havoc Pennington <hp@pobox.com>
374 * dbus/dbus-connection.c (dbus_connection_register_fallback): add this
375 (dbus_connection_register_object_path): make this not handle
376 messages to paths below the given path
378 2003-09-03 Havoc Pennington <hp@pobox.com>
380 * test/glib/Makefile.am: add this with random glib-linked test
383 * glib/Makefile.am: remove the random test programs from here,
384 leave only the unit tests
386 * glib/dbus-gobject.c (_dbus_gobject_test): add test for
387 uscore/javacaps conversion, and fix
388 (get_object_property, set_object_property): change to .NET
389 convention for mapping props to methods, set_FooBar/get_FooBar,
390 since one language has such a convention we may as well copy it.
391 Plus real methods in either getFooBar or get_foo_bar style won't
392 collide with this convention.
394 2003-09-01 Havoc Pennington <hp@pobox.com>
396 * glib/dbus-gparser.c: implement
398 * glib/dbus-gobject.c: start implementing skeletons support
400 * configure.in: when disabling checks/assert, also define
401 G_DISABLE_ASSERT and G_DISABLE_CHECKS
403 2003-09-01 Havoc Pennington <hp@pobox.com>
405 * glib/Makefile.am: rearrange a bunch of files and get "make
406 check" framework set up
408 2003-08-31 Havoc Pennington <hp@pobox.com>
410 * fix build with --disable-tests
412 2003-08-30 Havoc Pennington <hp@pobox.com>
414 * dbus/dbus-connection.c: purge DBusMessageHandler
416 * dbus/dbus-message-handler.c: remove DBusMessageHandler, just
417 use callbacks everywhere
419 2003-08-30 Havoc Pennington <hp@pobox.com>
421 * test/data/valid-config-files/system.d/test.conf: change to
422 root for the user so warnings don't get printed
424 * dbus/dbus-message.c: add dbus_message_get_path,
425 dbus_message_set_path
427 * dbus/dbus-object-tree.c (do_test_dispatch): add test of
428 dispatching to a path
430 * dbus/dbus-string.c (_dbus_string_validate_path): add
432 * dbus/dbus-marshal.c (_dbus_demarshal_object_path): implement
433 (_dbus_marshal_object_path): implement
435 * dbus/dbus-protocol.h (DBUS_HEADER_FIELD_PATH): new header field
436 to contain the path to the target object
437 (DBUS_HEADER_FIELD_SENDER_SERVICE): rename
438 DBUS_HEADER_FIELD_SENDER to explicitly say it's the sender service
440 2003-08-30 Havoc Pennington <hp@pobox.com>
442 * dbus/dbus-object-tree.c: write tests and fix the discovered bugs
444 2003-08-29 Havoc Pennington <hp@pobox.com>
446 * dbus/dbus-object-tree.c: modify to allow overlapping paths to be
448 (struct DBusObjectSubtree): shrink this
449 a lot, since we may have a lot of them
450 (_dbus_object_tree_free_all_unlocked): implement
451 (_dbus_object_tree_dispatch_and_unlock): implement
453 2003-08-29 Havoc Pennington <hp@pobox.com>
455 * dbus/dbus-internals.h: fix _DBUS_N_GLOBAL_LOCKS
457 2003-08-28 Havoc Pennington <hp@pobox.com>
461 * dbus/dbus-connection.c: port to no ObjectID, create a
462 DBusObjectTree, rename ObjectTree to ObjectPath in public API
464 * dbus/dbus-connection.h (struct DBusObjectTreeVTable): delete
465 everything except UnregisterFunction and MessageFunction
467 * dbus/dbus-marshal.c: port away from DBusObjectID,
468 add DBUS_TYPE_OBJECT_PATH
470 * dbus/dbus-object-registry.[hc], dbus/dbus-object.[hc],
471 dbus/dbus-objectid.[hc]: remove these, we are moving to
472 path-based object IDs
474 2003-08-25 Havoc Pennington <hp@pobox.com>
476 Just noticed that dbus_message_test is hosed, I wonder when I
477 broke that. I thought make check was passing earlier...
479 * dbus/dbus-object-tree.c: add new "object tree" to match DCOP
480 container tree, will replace most of dbus-object-registry
482 * dbus/dbus-string.c (_dbus_string_append_printf_valist): fix C99
485 2003-08-19 Havoc Pennington <hp@pobox.com>
487 * dbus/dbus-message.c (decode_string_field): support FIELD_SENDER
488 (dbus_message_is_error): fix this function
490 * bus/dbus-daemon-1.1: clarify logic on when <deny>/<allow> rules
493 * bus/policy.c (bus_client_policy_check_can_receive): fix code to
494 reflect clarified man page
495 (bus_client_policy_check_can_send): ditto
497 * bus/session.conf.in: fixup
499 * bus/system.conf.in: fixup
501 2003-08-18 Havoc Pennington <hp@redhat.com>
503 * dbus/dbus-hash.c (_dbus_hash_table_insert_two_strings): fix
505 * dbus/dbus-message.c (_dbus_message_loader_queue_messages): fix
506 dumb bug created earlier (wrong order of args to
507 decode_header_data())
509 * tools/dbus-send.c: port
511 * tools/dbus-print-message.c (print_message): port
513 * test/data/*messages: port all messages over
515 * dbus/dbus-message-builder.c: support including
518 * bus/driver.c: port over
520 * bus/dispatch.c: port over to new stuff
522 * dbus/dbus-connection.c (_dbus_connection_new_for_transport):
523 rename disconnect signal to "Disconnected"
525 2003-08-17 Havoc Pennington <hp@pobox.com>
527 This doesn't compile yet, but syncing up so I can hack on it from
528 work. What are branches for if not broken code? ;-)
530 * dbus/dbus-protocol.h: remove DBUS_HEADER_FIELD_NAME, add
531 DBUS_HEADER_FIELD_INTERFACE, DBUS_HEADER_FIELD_MEMBER,
532 DBUS_HEADER_FIELD_ERROR_NAME
534 * dbus/dbus-hash.c: Introduce DBUS_HASH_TWO_STRINGS as hack to use
535 for the interface+member pairs
536 (string_hash): change to use g_str_hash algorithm
537 (find_direct_function, find_string_function): refactor these to
540 * dbus/dbus-message.c: port all of this over to support
541 interface/member fields instead of name field
543 * dbus/dbus-object-registry.c: port over
545 * dbus/dbus-string.c (_dbus_string_validate_interface): rename
546 from _dbus_string_validate_name
548 * bus/dbus-daemon-1.1: change file format for the
549 <deny>/<allow> stuff to match new message naming scheme
551 * bus/policy.c: port over
553 * bus/config-parser.c: parse new format
555 2003-08-16 Havoc Pennington <hp@pobox.com>
557 * dbus/dbus-object-registry.c (add_and_remove_objects): remove
560 * glib/dbus-gproxy.c: some hacking
562 2003-08-15 Havoc Pennington <hp@redhat.com>
564 * dbus/dbus-pending-call.c (dbus_pending_call_block): implement
566 * dbus/dbus-connection.c
567 (dbus_connection_send_with_reply_and_block): factor out internals;
568 change to convert any error replies to DBusError instead of
569 returning them as a message
571 2003-08-15 Havoc Pennington <hp@pobox.com>
573 * dbus/dbus-connection.c,
574 dbus/dbus-pending-call.c: Finish the pending call stuff
576 2003-08-14 Havoc Pennington <hp@redhat.com>
578 * dbus/dbus-pending-call.c: start on new object that will replace
579 DBusMessageHandler and ReplyHandlerData for tracking outstanding
582 * dbus/dbus-gproxy.c: start on proxy object used to communicate
583 with remote interfaces
585 * dbus/dbus-gidl.c: do the boring boilerplate in here
587 2003-08-12 Havoc Pennington <hp@pobox.com>
589 * bus/dispatch.c (bus_dispatch): make this return proper
590 DBusHandlerResult to avoid DBUS_ERROR_UNKNOWN_METHOD
592 * dbus/dbus-errors.c (dbus_set_error): use
593 _dbus_string_append_printf_valist
595 * dbus/dbus-string.c (_dbus_string_append_printf_valist)
596 (_dbus_string_append_printf): new
598 * dbus/dbus-errors.h (DBUS_ERROR_UNKNOWN_MESSAGE): change to
601 * dbus/dbus-connection.c (dbus_connection_dispatch): handle
602 DBUS_HANDLER_RESULT_NEED_MEMORY; send default error reply if a
603 message is unhandled.
605 2003-08-11 Havoc Pennington <hp@pobox.com>
607 * bus/test.c (client_disconnect_handler): change to return
608 HANDLED (would have been REMOVE_MESSAGE)
610 * dbus/dbus-object.h (enum DBusHandlerResult): rename to
611 HANDLED/NOT_YET_HANDLED instead of
612 REMOVE_MESSAGE/ALLOW_MORE_HANDLERS to make it clearer how it
615 2003-08-10 Havoc Pennington <hp@pobox.com>
617 * tools/dbus-send.c (main): add --type argument, for now
618 supporting only method_call and signal types.
620 * tools/dbus-print-message.c: print message type
622 * dbus/dbus-connection.c (_dbus_connection_new_for_transport):
623 init connection->objects
625 * doc/dbus-specification.sgml: fix sgml
627 * bus/*.c: port over to object-instance API changes
629 * test/test-service.c: ditto
631 * dbus/dbus-message.c (dbus_message_create_header): allow #NULL
632 name, we will have to fix up the rest of the code to also handle
634 (dbus_message_new): generic message-creation call
635 (set_string_field): allow appending name field
637 2003-08-06 Havoc Pennington <hp@pobox.com>
639 * dbus/dbus-object-registry.c: implement signal connection
642 * dbus/dbus-connection.c (_dbus_connection_unref_unlocked): new
644 * dbus/dbus-internals.c (_dbus_memdup): new function
646 2003-08-02 Havoc Pennington <hp@pobox.com>
648 * dbus/dbus-message.c (dbus_message_get_no_reply)
649 (dbus_message_set_no_reply): add these and remove
650 set_is_error/get_is_error
652 * dbus/dbus-protocol.h, doc/dbus-specification.sgml:
653 remove the ERROR flag, since there's now an ERROR type
655 2003-08-01 Havoc Pennington <hp@pobox.com>
657 * dbus/dbus-object-registry.c (_dbus_object_registry_handle_and_unlock):
660 * dbus/dbus-message.c (dbus_message_get_type): new function
662 * doc/dbus-specification.sgml: add "type" byte to messages
664 2003-08-01 Havoc Pennington <hp@pobox.com>
666 * dbus/dbus-protocol.h (DBUS_MESSAGE_TYPE_*): introduce
667 a message type enum to distinguish kinds of message
668 (DBUS_HEADER_FLAG_NO_REPLY_EXPECTED): flag for a message
669 that need not be replied to
671 2003-08-01 Havoc Pennington <hp@pobox.com>
673 * dbus/dbus-marshal.c: adapt to DBusObjectID changes
674 (unpack_8_octets): fix no-64-bit-int bug
676 * dbus/dbus-object-registry.c (validate_id): validate the
677 connection ID bits, not just the instance ID.
679 * dbus/dbus-connection.c (_dbus_connection_init_id): initialize
680 the connection-global 33 bits of the object ID
682 * dbus/dbus-object-registry.c (info_from_entry): fill in
683 object ID in the new way
685 * dbus/dbus-objectid.h: rather than high/low bits, specifically
686 define server/client/instance bits.
688 2003-07-30 Havoc Pennington <hp@pobox.com>
690 * dbus/dbus-connection.c (dbus_connection_register_object): fix
693 2003-07-13 Havoc Pennington <hp@pobox.com>
695 * dbus/dbus-object.h (struct DBusObjectVTable): add padding
696 fields to DBusObjectVTable and DBusObjectInfo
698 2003-07-12 Havoc Pennington <hp@pobox.com>
700 * dbus/dbus-object-registry.c: implement unit test,
701 fix bugs discovered in process
703 * dbus/dbus-connection.c: remove handler_table and
704 register_handler(), add DBusObjectRegistry usage
706 * dbus/dbus-objectid.c (dbus_object_id_is_null)
707 (dbus_object_id_set_null): new functions
709 2003-07-08 Havoc Pennington <hp@pobox.com>
711 * dbus/dbus-object.c: implement some of this
713 * dbus/dbus-object-registry.c
714 (_dbus_object_registry_add_and_unlock): fill in the object_id out
716 (_dbus_object_registry_new): handle OOM
718 2003-07-08 Havoc Pennington <hp@pobox.com>
720 * dbus/dbus-object.h: sketch out an API for registering objects
721 with a connection, that allows us to use as little as 24 bytes
722 per object and lets application code represent an object in
725 * dbus/dbus-object-registry.c: implement the hard bits of the
726 DBusConnection aspect of object API. Not yet wired up.
728 2003-07-06 Havoc Pennington <hp@pobox.com>
730 * dbus/dbus-marshal.c (_dbus_marshal_set_object_id): new function
731 (_dbus_marshal_object_id): new
732 (_dbus_demarshal_object_id): new
733 (_dbus_marshal_get_arg_end_pos): support object ID type, and
734 consolidate identical switch cases. Don't conditionalize handling
735 of DBUS_TYPE_UINT64, need to handle the type always.
736 (_dbus_marshal_validate_arg): consolidate identical cases, and
737 handle DBUS_TYPE_OBJECT_ID
739 * dbus/dbus-objectid.c: new file with DBusObjectID data type.
741 * dbus/dbus-protocol.h: add DBUS_TYPE_OBJECT_ID
743 2003-09-28 Havoc Pennington <hp@pobox.com>
747 2003-09-28 Havoc Pennington <hp@pobox.com>
749 * doc/Makefile.am (dbus-specification.html): testing a funky hack
750 to work with Debian db2html
752 2003-09-28 Havoc Pennington <hp@pobox.com>
756 * doc/Makefile.am (dbus-test-plan.html): accept nonexistence of
757 stylesheet-images for benefit of Debian
759 Change back to using filesystem-linked sockets for the system
760 bus, so only root can create the default system bus address.
762 * bus/system.conf.in: change to use
763 DBUS_SYSTEM_BUS_DEFAULT_ADDRESS
765 * dbus/Makefile.am (INCLUDES): remove DBUS_SYSTEM_BUS_PATH define
768 * configure.in: define DBUS_SYSTEM_BUS_DEFAULT_ADDRESS
769 here, and AC_DEFINE DBUS_SYSTEM_PATH
771 2003-08-09 Anders Carlsson <andersca@codefactory.se>
777 2003-08-09 Anders Carlsson <andersca@codefactory.se>
779 * doc/dbus-specification.sgml:
780 Add activation reply values.
782 2003-08-05 Havoc Pennington <hp@redhat.com>
786 2003-08-05 Anders Carlsson <andersca@codefactory.se>
788 * glib/dbus-gmain.c: (watch_fd_new), (watch_fd_ref),
789 (watch_fd_unref), (dbus_gsource_check), (dbus_gsource_dispatch),
790 (add_watch), (remove_watch), (create_source):
791 Refcount fds, fixes some reentrancy issues.
793 2003-07-30 Havoc Pennington <hp@redhat.com>
795 * dbus/dbus-bus.c (init_connections_unlocked): fix default system
796 bus address to be abstract if we have abstract sockets
800 2003-07-28 Havoc Pennington <hp@redhat.com>
802 * bus/messagebus.in: fix to avoid processname/servicename
803 confusion, from Michael Kearey
804 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=100965
806 2003-07-23 Havoc Pennington <hp@pobox.com>
808 * dbus/dbus-message.c (dbus_message_iter_get_named):
809 fix from Andy Hanton to remove broken "+1"
811 2003-07-16 Havoc Pennington <hp@pobox.com>
813 * tools/dbus-launch.c (babysit): close stdout/stderr in the
814 babysitter process, as suggested by Thomas Leonard, so
815 an "eval `dbus-launch --exit-with-session`" will actually
818 2003-07-16 Havoc Pennington <hp@pobox.com>
820 * configure.in: print out EXPANDED_* variables in the summary at
821 the end; clean up the code that computes EXPANDED_ variables and
822 get the ones using exec_prefix right. Should make things work
823 when you build without --prefix
825 2003-06-29 Havoc Pennington <hp@pobox.com>
827 * mono/Test.cs (class Test): fire up a main loop and run it
829 * mono/DBus.cs (DBus): don't g_thread_init since it can only be
830 done once, the app has to do it
832 2003-06-26 Havoc Pennington <hp@pobox.com>
834 * mono/Connection.cs: set up connection with the glib main loop
836 2003-07-01 Havoc Pennington <hp@redhat.com>
838 * doc/dbus-specification.sgml: clarify the format of a type code,
839 change suggested by Jim Blandy
841 2003-06-29 Miloslav Trmac <mitr@volny.cz>
844 * tools/Makefile.am: Don't assume srcdir == builddir.
846 * dbus/dbus-memory.c (dbus_realloc): Don't check guards after shrinking
848 (_dbus_memory_test): New function.
849 * dbus/dbus-test.h: Add _dbus_memory_test ().
850 * dbus/dbus-test.c (dbus_internal_do_not_use_run_tests): Call it.
852 * dbus/dbus-message.c (decode_header_data): Use %.4s instead
854 (dbus_message_new): Remove obsolete @todo.
856 * dbus/dbus-marshal.c (_dbus_marshal_set_int64)
857 (_dbus_marshal_set_uint64): Fix comment.
859 * dbus/dbus-message.c (append_int_field, append_uint_field): Don't
860 hardcode FIELD_REPLY_SERIAL.
862 * dbus/dbus-mainloop.c (_dbus_loop_remove_watch)
863 (_dbus_loop_remove_timeout): Cast function pointers to (void *) for %p
865 * configure.in: Add -D_POSIX_C_SOURCE=199309L -DBSD_SOURCE to CFLAGS
866 and disable DBUS_USE_ATOMIC_INT_486 when --enable-ansi is used
868 2003-06-24 Havoc Pennington <hp@pobox.com>
870 * mono/*.cs: Use IntPtr.Zero instead of ((IntPtr) 0)
872 2003-06-23 Anders Carlsson <andersca@codefactory.se>
878 * gcj/TestMessage.java: (TestMessage), (TestMessage.main):
879 * gcj/org/.cvsignore:
880 * gcj/org/Makefile.am:
881 * gcj/org/freedesktop/.cvsignore:
882 * gcj/org/freedesktop/Makefile.am:
883 * gcj/org/freedesktop/dbus/.cvsignore:
884 * gcj/org/freedesktop/dbus/Makefile.am:
885 * gcj/org/freedesktop/dbus/Message.java: (Message),
887 * gcj/org/freedesktop/dbus/natMessage.cc:
888 Fix the build system.
890 2003-06-22 Havoc Pennington <hp@pobox.com>
892 * mono/Connection.cs: add more bindings
894 * dbus/dbus-threads.c (dbus_threads_init): allow calling this
897 2003-06-22 Havoc Pennington <hp@pobox.com>
899 * mono/Connection.cs, mono/DBus.cs, mono/Error.cs:
900 Start wrapping more stuff.
902 2003-06-22 Havoc Pennington <hp@pobox.com>
904 * mono/Message.cs: implement Message.Wrap() that ensures we only
905 have a single C# wrapper per DBusMessage, assuming it works which
908 * dbus/dbus-message.c (dbus_message_allocate_data_slot): new
909 (dbus_message_free_data_slot): new
910 (dbus_message_set_data): new
911 (dbus_message_get_data): new
913 2003-06-22 Havoc Pennington <hp@pobox.com>
915 * dbus/dbus-dataslot.c (_dbus_data_slot_allocator_unref)
916 (_dbus_data_slot_allocator_alloc): rework these to keep a
917 reference count on each slot and automatically manage a global
918 slot ID variable passed in by address
920 * bus/bus.c: convert to new dataslot API
922 * dbus/dbus-bus.c: convert to new dataslot API
924 * dbus/dbus-connection.c: convert to new dataslot API
926 * dbus/dbus-server.c: convert to new dataslot API
928 * glib/dbus-gmain.c: ditto
932 * bus/connection.c: ditto
934 2003-06-22 Anders Carlsson <andersca@codefactory.se>
936 * configure.in: Add AM_PROG_GCJ and move AM_PROG_LIBTOOL
937 after the gcj checks so that the correct configuration tags
938 will be added to libtool.
940 * dbus-glib-1.pc.in: No need to specify any includes since
941 dbus-1.pc.in has those.
943 2003-06-22 Havoc Pennington <hp@pobox.com>
945 * mono/*, gcj/*, configure.in, Makefile.am:
946 Check in makefiles and subdirs for mono and gcj bindings.
947 Neither binding actually exists, just trying to get through
948 all the build and other boring bits.
950 2003-06-21 Philip Blundell <philb@gnu.org>
952 * tools/dbus-monitor.1: Updated.
954 * tools/dbus-send.1: Likewise.
956 2003-06-20 Anders Carlsson <andersca@codefactory.se>
958 * dbus/dbus-transport-unix.c (unix_handle_watch): Check
959 for hangup and error after checking read so we won't discard
960 pending data if both hangup and read are set.
962 2003-06-19 Philip Blundell <philb@gnu.org>
964 * tools/dbus-print-message.c (print_message): Handle BOOLEAN.
966 * tools/dbus-send.c: Accept both --system and --session.
968 * tools/dbus-monitor.c: Same here.
970 2003-06-19 Anders Carlsson <andersca@codefactory.se>
972 * glib/dbus-glib.h: Fix so that dbus-glib.h can be used
973 from C++ (Patch by Miloslav Trmac).
975 2003-06-15 Joe Shaw <joe@assbarn.com>
977 * configure.in: Check for socklen_t.
979 * dbus/dbus-sysdeps.c: Define socklen_t if it's not defined.
981 * test/test-segfault.c: Add #include <sys/time.h>
983 * tools/Makefile.am: Add DBUS_X_CFLAGS to the INCLUDES since
984 dbus-launch needs it.
986 2003-06-09 Havoc Pennington <hp@redhat.com>
988 * dbus/dbus-sysdeps.c (_dbus_listen_unix_socket): don't use
989 SUN_LEN, it breaks abstract socket usage
991 * dbus/dbus-internals.c (_dbus_verbose_real): only print PID at
994 2003-06-04 Havoc Pennington <hp@pobox.com>
996 * dbus/dbus-server.c (dbus_server_listen): allow abstract sockets
997 using unix:abstract=/foo, and when listening in a tmpdir
998 i.e. unix:tmpdir=/tmp, always use abstract sockets if we can.
1000 * dbus/dbus-transport.c (_dbus_transport_open): support
1003 * dbus/dbus-server-unix.c (_dbus_server_new_for_domain_socket):
1004 support abstract sockets
1006 * dbus/dbus-transport-unix.c
1007 (_dbus_transport_new_for_domain_socket): support abstract sockets
1009 * dbus/dbus-sysdeps.c (_dbus_connect_unix_socket): add "abstract"
1010 toggle as an argument, implement abstract namespace support
1011 (_dbus_listen_unix_socket): ditto
1013 * configure.in: add --enable-abstract-sockets and implement
1014 a configure check for autodetection of the right value.
1016 2003-06-01 Havoc Pennington <hp@pobox.com>
1018 * tools/dbus-cleanup-sockets.c: add utility to clean up sockets
1019 in /tmp (though on Linux this will end up being useless,
1020 when we add abstract namespace support)
1022 * configure.in: define DBUS_SESSION_SOCKET_DIR in addition to
1025 2003-05-28 Colin Walters <walters@verbum.org>
1027 * tools/dbus-monitor.c (main): Fix silly typo (s/--session/--system/).
1029 2003-05-18 Anders Carlsson <andersca@codefactory.se>
1031 * dbus/dbus-message.c (dbus_message_new): Remove @todo.
1033 2003-05-17 Colin Walters <walters@gnu.org>
1035 * tools/dbus-send.c: Don't exit with an error code if --help was
1036 passed. Default to using the session bus instead of the system
1039 * tools/dbus-launch.c: Ditto.
1041 * tools/dbus-monitor.c: Ditto.
1043 * tools/dbus-send.1: Update with new arguments.
1045 * tools/dbus-launch.c: Emit code to export variables. New
1046 arguments -s and -c to specify shell syntax, and a bit of code to
1047 autodetect syntax. Also, allow specifying a program to run.
1049 * tools/dbus-launch.1: Update with new arguments.
1051 * tools/dbus-send.1: Ditto.
1053 * tools/dbus-monitor.1: Ditto.
1055 2003-05-17 Havoc Pennington <hp@pobox.com>
1057 * bus/config-parser.c (merge_included): merge in policies from
1058 child configuration file.
1060 * bus/policy.c (bus_policy_merge): function to merge two policies
1063 2003-05-16 Havoc Pennington <hp@redhat.com>
1065 * dbus/dbus-connection.c: disable verbose lock spew
1067 * tools/dbus-send.c: add --print-reply command line option
1069 * tools/dbus-print-message.h (print_message): new util function
1070 shared by dbus-send and dbus-monitor
1072 * tools/dbus-monitor.c (handler_func): exit on disconnect
1074 * dbus/dbus-transport-unix.c (do_reading): if the transport is
1075 disconnected, don't try to use the read_watch
1077 * dbus/dbus-watch.c (dbus_watch_get_enabled): assert watch != NULL
1078 so we can find this bug more easily
1080 2003-05-16 Havoc Pennington <hp@redhat.com>
1082 * bus/policy.c (free_rule_list_func): avoid a crash when passed
1083 NULL as DBusHashTable is annoyingly likely to do.
1085 2003-05-16 Colin Walters <walters@verbum.org>
1087 * tools/dbus-monitor.c: Add --session argument and usage()
1090 * tools/dbus-monitor.1: Update with new --session arg.
1092 * bus/Makefile.am (install-data-hook): Create
1093 $(libdir)/dbus-1.0/services so that the session bus is happy.
1095 2003-05-15 Havoc Pennington <hp@redhat.com>
1097 * dbus/dbus-sysdeps.c (_dbus_atomic_dec, _dbus_atomic_inc): work
1098 on non-x86. ifdef's are evil.
1100 2003-05-15 Havoc Pennington <hp@redhat.com>
1102 * configure.in: 0.11
1106 * bus/Makefile.am (initddir): apparently we are supposed to put
1107 init scripts in /etc/rc.d/init.d not /etc/init.d
1109 * bus/Makefile.am: remove the "you must --enable-tests to make
1110 check" as it broke distcheck
1112 * bus/Makefile.am (install-data-hook): create /etc/dbus-1/system.d
1114 2003-05-13 James Willcox <jwillcox@gnome.org>
1117 * bus/activation.c: (bus_activation_service_created),
1118 (bus_activation_activate_service):
1119 * bus/driver.c: (bus_driver_send_service_deleted),
1120 (bus_driver_send_service_created), (bus_driver_send_service_lost),
1121 (bus_driver_send_service_acquired),
1122 (bus_driver_send_welcome_message),
1123 (bus_driver_handle_list_services):
1124 * bus/session.conf.in:
1125 * dbus/dbus-bus.c: (dbus_bus_acquire_service),
1126 (dbus_bus_service_exists), (dbus_bus_activate_service):
1129 Add some convenience API which lets you activate a service, and did a
1130 bunch of s/0/DBUS_TYPE_INVALID/ in calls to dbus_message_append_args()
1131 and dbus_message_get_args()
1133 2003-05-11 Havoc Pennington <hp@pobox.com>
1135 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): fix to avoid
1136 calling _dbus_marshal_validate_arg() for every byte in a byte
1139 * dbus/dbus-message-handler.c: use atomic reference counting to
1140 reduce number of locks slightly; the global lock in here sucks
1142 * dbus/dbus-connection.c
1143 (_dbus_connection_update_dispatch_status_and_unlock): variant of
1144 update_dispatch_status that can be called with lock held; then use
1145 in a couple places to reduce locking/unlocking
1146 (dbus_connection_send): hold the lock over the whole function
1147 instead of acquiring it twice.
1149 * dbus/dbus-timeout.c (_dbus_timeout_new): handle OOM
1151 * bus/connection.c (bus_connections_setup_connection): fix access
1152 to already-freed memory.
1154 * dbus/dbus-connection.c: keep a little cache of linked list
1155 nodes, to avoid using the global linked list alloc lock in the
1156 normal send-message case. Instead we just use the connection lock
1157 that we already have to take.
1159 * dbus/dbus-list.c (_dbus_list_find_last): new function
1161 * dbus/dbus-sysdeps.c (_dbus_atomic_inc, _dbus_atomic_dec):
1162 change to use a struct for the atomic type; fix docs,
1163 they return value before increment, not after increment.
1165 * dbus/dbus-string.c (_dbus_string_append_4_aligned)
1166 (_dbus_string_append_8_aligned): new functions to try to
1167 microoptimize this operation.
1168 (reallocate_for_length): break this out of set_length(), to
1169 improve profile info, and also so we can consider inlining the
1172 * dbus/dbus-message.c (dbus_message_new_empty_header): init data
1173 strings with some preallocation, cuts down on our calls to realloc
1174 a fair bit. Though if we can get the "move entire string to empty
1175 string" optimization below to kick in here, it would be better.
1177 * dbus/dbus-string.c (_dbus_string_move): just call
1178 _dbus_string_move_len
1179 (_dbus_string_move_len): add a special case for moving
1180 an entire string into an empty string; we can just
1181 swap the string data instead of doing any reallocs.
1182 (_dbus_string_init_preallocated): new function
1184 2003-05-11 Havoc Pennington <hp@pobox.com>
1186 Write a "test-profile" that does echo client-server with threads;
1187 profile reveals lock contention, memcpy/realloc of buffers, and
1188 UTF-8 validation as hot spots. 20% of lock contention eliminated
1189 with dbus_atomic_inc/dec implementation on x86. Much remaining
1190 contention is global mempool locks for GList and DBusList.
1192 * dbus/dbus-sysdeps.c (_dbus_atomic_inc, _dbus_atomic_dec): add
1195 * dbus/dbus-connection.c (struct DBusConnection): use
1196 dbus_atomic_t for the reference count
1198 * dbus/dbus-message.c (struct DBusMessage): declare
1199 dbus_atomic_t values as volatile
1201 * configure.in: code to detect ability to use atomic integer
1202 operations in assembly, from GLib patch
1204 * dbus/dbus-internals.c (_dbus_verbose_real): call getpid every
1205 time, tired of it being wrong in threads and forked processes
1207 * glib/test-profile.c: a little program to bounce messages back
1208 and forth between threads and eat CPU
1210 * dbus/dbus-connection.c: add debug spew macros for debugging
1211 thread locks; include config.h at top; fix deadlock in
1212 dbus_connection_flush()
1214 2003-05-08 Havoc Pennington <hp@pobox.com>
1216 * dbus/dbus-spawn.c: s/_exit/exit/ because it was keeping gcov
1217 data from getting written, and there wasn't a good reason to
1220 * test/decode-gcov.c (mark_inside_dbus_build_tests): don't count
1221 dbus_verbose lines in test coverage
1222 (main): add list of functions sorted by # of untested blocks
1223 to the coverage report
1225 * dbus/dbus-mempool.c: put some test-only code in DBUS_BUILD_TESTS
1227 * dbus/dbus-marshal.c (_dbus_marshal_test): extend test coverage
1229 * dbus/dbus-message-handler.c (_dbus_message_handler_test):
1230 extend test coverage
1232 * test/data/auth/cancel.auth-script: test canceling an
1235 * dbus/Makefile.am: remove dbus-server-debug.[hc] for now, as they
1236 aren't used. in CVS history if we end up needing them.
1238 2003-05-04 Havoc Pennington <hp@pobox.com>
1240 * dbus/dbus-message-handler.c (_dbus_message_handler_test): add
1243 * dbus/dbus-marshal.c (_dbus_demarshal_string_array): fix this
1244 function, which assumed length was in # of strings, not bytes
1246 * dbus/dbus-message.c (_dbus_message_test): add tests for some
1249 * dbus/dbus-connection.c
1250 (_dbus_connection_queue_received_message): disable function for
1251 now, we are only using it in test mode
1253 * dbus/dbus-message.c (_dbus_message_loader_queue_messages):
1254 remove a mistaken FIXME
1256 2003-05-04 Havoc Pennington <hp@pobox.com>
1258 * dbus/dbus-connection.c (dbus_connection_preallocate_send):
1259 unlock mutex on successful return, patch from Anders Gustafsson
1261 2003-05-04 Havoc Pennington <hp@pobox.com>
1263 * dbus-glib-1.pc.in (Requires): fix dependencies, from
1266 2003-05-04 Havoc Pennington <hp@pobox.com>
1268 * tools/dbus-launch.c: implement
1270 * bus/main.c (main), bus/bus.c (bus_context_new):
1271 implement --print-pid and --fork
1273 2003-05-03 Havoc Pennington <hp@redhat.com>
1275 * dbus/dbus-address.c (dbus_parse_address): fix bug when a key in
1276 the address had no value, and add to test suite. Fix and
1277 regression test from Miloslav Trmac
1279 2003-05-03 Havoc Pennington <hp@pobox.com>
1281 * dbus/dbus-watch.c (dbus_watch_handle): warn and return if a
1282 watch is invalid when handled
1284 * tools/Makefile.am, tools/dbus-launch.c, tools/dbus-launch.1: add
1285 dbus-launch utility to launch the bus from a shell script. Didn't
1286 actually implement dbus-launch yet, it's just a placeholder still.
1288 2003-05-03 Havoc Pennington <hp@pobox.com>
1290 * bus/Makefile.am, bus/dbus-daemon-1.1.in: man page for the
1291 daemon; also documents daemon config file, so replaces
1292 doc/config-file.txt. Corrected some stuff from config-file.txt in
1293 the process of moving it.
1295 2003-05-03 Havoc Pennington <hp@pobox.com>
1297 * tools/Makefile.am, tools/dbus-send.1, tools/dbus-monitor.1:
1300 2003-05-03 Colin Walters <walters@verbum.org>
1302 * dbus/dbus-sysdeps.c (fill_user_info): Test against
1303 DBUS_UID_UNSET to determine whether to do a uid lookup or not.
1305 * Makefile.am: Update to use new .pc versioning scheme.
1307 2003-05-02 Havoc Pennington <hp@redhat.com>
1309 * bus/system.conf.in: allow send/receive to/from message bus
1312 2003-04-30 Havoc Pennington <hp@redhat.com>
1314 * configure.in: print a note when building with unit tests and
1317 2003-04-30 Havoc Pennington <hp@redhat.com>
1319 * Makefile.am: add a check-local that complains if you didn't
1320 configure with --enable-tests
1322 2003-04-29 Havoc Pennington <hp@redhat.com>
1324 * glib/dbus-gmain.c: docs cleanups
1326 * dbus/dbus-types.h: add docs on int64 types
1328 * dbus/dbus-memory.c: fix docs to avoid putting private API in
1329 public API docs section
1331 2003-04-29 Havoc Pennington <hp@redhat.com>
1333 * dbus-1.pc.in, dbus-glib-1.pc.in: rename these from
1334 dbus-1.0.pc.in, dbus-glib-1.0.pc.in. As these change with the
1335 parallel install API version, not with the D-BUS package version.
1337 * HACKING: move some of README over here
1339 * README: updates, and document API/ABI policy
1341 * configure.in: reindentation
1343 2003-04-29 Havoc Pennington <hp@redhat.com>
1345 * dbus/dbus.h: add "you have to define DBUS_API_SUBJECT_TO_CHANGE
1346 to use this library" to be sure people have the right
1349 2003-04-28 Havoc Pennington <hp@redhat.com>
1351 * configure.in: add --enable-docs which by default is auto yes if
1352 doxygen and db2html found, no otherwise; but can be forced on/off
1354 * doc/Makefile.am: conditionalize whether to build docs on
1357 2003-04-28 Havoc Pennington <hp@redhat.com>
1359 * configure.in: 0.10
1363 * bus/system.conf.in: add <includedir>system.d</includedir>
1365 * dbus/dbus-userdb.c (_dbus_user_database_lookup): fix bug when
1366 username was provided but not uid
1368 * bus/config-parser.c (struct BusConfigParser): keep track of
1369 whether the parser is toplevel or was included; change some
1370 of the error handling if it's included.
1372 2003-04-27 Havoc Pennington <hp@pobox.com>
1376 * dbus/dbus-transport.c (_dbus_transport_get_dispatch_status):
1377 report correct status if we finish processing authentication
1378 inside this function.
1380 * bus/activation.c (try_send_activation_failure): use
1381 bus_transaction_send_error_reply
1383 * bus/connection.c (bus_connection_get_groups): return an error
1384 explaining the problem
1386 * bus/bus.c (bus_context_check_security_policy): implement
1387 restriction here that inactive connections can only send the
1388 hello message. Also, allow bus driver to send anything to
1391 * bus/connection.c (bus_connection_complete): create the
1392 BusClientPolicy here instead of on-demand.
1393 (bus_connection_get_policy): don't return an error
1395 * dbus/dbus-message.c (dbus_message_new_error_reply): allow NULL
1396 sender field in message being replied to
1398 * bus/bus.c (bus_context_check_security_policy): fix silly typo
1399 causing it to return FALSE always
1401 * bus/policy.c (bus_client_policy_check_can_send): fix bug where
1402 we checked sender rather than destination
1404 2003-04-25 Havoc Pennington <hp@redhat.com>
1406 test suite is slightly hosed at the moment, will fix soon
1408 * bus/connection.c (bus_connections_expire_incomplete): fix to
1409 properly disable the timeout when required
1410 (bus_connection_set_name): check whether we can remove incomplete
1411 connections timeout after we complete each connection.
1413 * dbus/dbus-mainloop.c (check_timeout): fix this up a bit,
1414 probably still broken.
1416 * bus/services.c (bus_registry_acquire_service): implement max
1417 number of services owned, and honor allow/deny rules on which
1418 services a connection can own.
1420 * bus/connection.c (bus_connection_get_policy): report errors here
1422 * bus/activation.c: implement limit on number of pending
1425 2003-04-25 Havoc Pennington <hp@redhat.com>
1427 * dbus/dbus-transport.c (_dbus_transport_get_unix_user): fix bug
1428 where we used >= 0 instead of != DBUS_UID_UNSET.
1430 2003-04-25 Havoc Pennington <hp@redhat.com>
1432 * glib/dbus-gmain.c (remove_watch): fix for a crash when watches
1433 were toggled without add/remove, fix from Anders Gustafsson
1435 2003-04-24 Havoc Pennington <hp@redhat.com>
1437 * test/data/valid-config-files/basic.conf: add <limit> tags to
1440 * bus/config-parser.h, bus/config-parser.c, bus/bus.c: Implement
1441 <limit> tag in configuration file.
1443 2003-04-24 Havoc Pennington <hp@redhat.com>
1445 * bus/dispatch.c: somehow missed some name_is
1447 * dbus/dbus-timeout.c (_dbus_timeout_set_enabled)
1448 (_dbus_timeout_set_interval): new
1450 * bus/connection.c (bus_connections_setup_connection): record time
1451 when each connection is first set up, and expire them after the
1452 auth timeout passes.
1454 2003-04-24 Havoc Pennington <hp@redhat.com>
1456 * dbus/dbus-message.c (dbus_message_name_is): rename
1457 (dbus_message_service_is): rename
1458 (dbus_message_sender_is): rename
1459 (dbus_message_get_service): rename
1461 2003-04-24 Havoc Pennington <hp@redhat.com>
1463 * configure.in: add --enable-checks
1465 * dbus/dbus-message.c (dbus_message_new): reverse name/service arguments
1467 * dbus/dbus-connection.c (dbus_connection_preallocate_send): fix
1468 to use thread locks.
1469 (_dbus_connection_handler_destroyed_locked): move some private
1470 functions into proper docs group
1472 * dbus/dbus-internals.h: add _dbus_return_if_fail,
1473 _dbus_return_val_if_fail
1475 Throughout: use dbus_return_if_fail
1477 2003-04-23 James Willcox <jwillcox@gnome.org>
1480 * glib/dbus-gmain.c: (add_timeout), (wakeup_main), (create_source),
1481 (dbus_connection_setup_with_g_main),
1482 (dbus_server_setup_with_g_main):
1483 * glib/test-dbus-glib.c: (main):
1484 * glib/test-thread-client.c: (main):
1485 * glib/test-thread-server.c: (new_connection_callback), (main):
1486 * tools/dbus-monitor.c: (main):
1488 Added a GMainContext argument to dbus_connection_setup_with_g_main()
1489 and dbus_server_setup_with_g_main().
1491 2003-04-20 Havoc Pennington <hp@pobox.com>
1493 * doc/dbus-specification.sgml: document the restrictions on
1494 message and service names
1496 2003-04-22 Havoc Pennington <hp@redhat.com>
1498 * dbus/dbus-message.c, dbus/dbus-marshal.c: add 64-bit integer
1499 support, and do some code cleanups to share more code and
1500 speed up array marshal/demarshal.
1502 * dbus-1.0.pc.in (Cflags): put libdir include file in cflags
1504 * configure.in: generate dbus-arch-deps.h
1506 * dbus/dbus-protocol.h (DBUS_TYPE_INT64, DBUS_TYPE_UINT64): add
1509 2003-04-22 Havoc Pennington <hp@redhat.com>
1511 * test/data/valid-messages/opposite-endian.message: fix test
1512 to use proper type for rply field
1514 * test/data/invalid-messages: add tests for below validation
1516 * dbus/dbus-message.c (decode_header_data): validate field types,
1517 and validate that named fields are valid names
1518 (decode_name_field): consider messages in the
1519 org.freedesktop.Local. namespace to be invalid.
1521 * dbus/dbus-string.c (_dbus_string_validate_name): new
1523 2003-04-19 Havoc Pennington <hp@pobox.com>
1525 * bus/driver.c (bus_driver_handle_hello): check limits and
1526 return an error if they are exceeded.
1528 * bus/connection.c: maintain separate lists of active and inactive
1529 connections, and a count of each. Maintain count of completed
1530 connections per user. Implement code to check connection limits.
1532 * dbus/dbus-list.c (_dbus_list_unlink): export
1534 * bus/bus.c (bus_context_check_security_policy): enforce a maximum
1535 number of bytes in the message queue for a connection
1537 2003-04-18 Havoc Pennington <hp@pobox.com>
1539 * dbus/dbus-auth.c (record_mechanisms): memleak fixes
1541 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): fix some
1544 * dbus/dbus-keyring.c (add_new_key): fix a memleak, and
1545 on realloc be sure to update the pointer in the keyring
1547 * dbus/dbus-string.c (_dbus_string_zero): compensate for align
1548 offset to avoid writing to unallocated memory
1550 * dbus/dbus-auth.c (process_rejected): return FALSE if we fail to
1551 try the next mechanism, so we properly handle OOM
1553 * dbus/dbus-keyring.c (_dbus_keyring_new_homedir): fix double-free
1555 (_dbus_keyring_new): fix OOM bug
1556 (_dbus_keyring_new_homedir): always set error; impose a maximum
1557 number of keys we'll load from the file, mostly to speed up the
1558 test suite and make its OOM checks more useful, but also for
1561 * dbus/dbus-auth.c (process_error_server): reject authentication
1562 if we get an error from the client
1563 (process_cancel): on cancel, send REJECTED, per the spec
1564 (process_error_client): send CANCEL if we get an error from the
1567 2003-04-18 Havoc Pennington <hp@pobox.com>
1569 * dbus/dbus-mainloop.c (_dbus_loop_iterate): fix UMR in verbose
1572 * dbus/dbus-auth.c (handle_client_data_cookie_sha1_mech): fix OOM
1575 * dbus/dbus-keyring.c (_dbus_keyring_new_homedir): only whine
1576 about DBUS_TEST_HOMEDIR once
1578 * bus/Makefile.am (TESTS_ENVIRONMENT): put DBUS_TEST_HOMEDIR in
1581 * bus/dispatch.c (bus_dispatch_sha1_test): actually load sha1
1582 config file so we test the right thing
1584 Throughout: assorted docs improvements
1586 2003-04-18 Havoc Pennington <hp@pobox.com>
1588 * glib/dbus-gmain.c: adapt to watch changes
1590 * bus/bus.c, bus/activation.c, etc.: adjust to watch changes
1592 * dbus/dbus-server.h: remove dbus_server_handle_watch
1594 * dbus/dbus-connection.h: remove dbus_connection_handle_watch
1596 * dbus/dbus-watch.c (dbus_watch_handle): change DBusWatch to work
1597 like DBusTimeout, so we don't need dbus_connection_handle_watch
1600 2003-04-17 Havoc Pennington <hp@redhat.com>
1602 * dbus/dbus-userdb.c, dbus/dbus-sysdeps.c: redo all the passwd
1603 database usage so it all goes via the DBusUserDatabase cache.
1605 2003-04-17 Havoc Pennington <hp@redhat.com>
1607 * dbus/dbus-mainloop.c (_dbus_loop_iterate): fix logic so that if
1608 there was an OOM watch we skipped, we always return TRUE so we
1609 iterate again to have a look at it again. Fixes test suite hang.
1610 Code rearrangement also lets us lose some memset and only iterate
1611 over callbacks once.
1613 * bus/driver.c (bus_driver_handle_message): sense of test for
1616 2003-04-16 Havoc Pennington <hp@pobox.com>
1618 * doc/dbus-specification.sgml: make spec say serials are unsigned
1620 * dbus/dbus-message.h: change message serials to unsigned
1622 * dbus/dbus-connection.c: adapt to message serials being unsigned
1624 2003-04-15 Havoc Pennington <hp@pobox.com>
1626 * bus/bus.c: create and keep around a shared DBusUserDatabase
1629 * bus/connection.c (bus_connection_get_groups): don't cache
1630 groups for user in the connection object, since user database
1631 object now does that.
1633 2003-04-16 Havoc Pennington <hp@redhat.com>
1635 * dbus/dbus-message.c (_dbus_message_add_size_counter): keep a
1636 list of size counters
1637 (_dbus_message_loader_putback_message_link): put back a popped link
1639 * dbus/dbus-connection.c
1640 (dbus_connection_set_max_live_messages_size): rename
1642 (dbus_connection_get_outgoing_size): get size of outgoing
1644 (_dbus_connection_set_connection_counter): remove this cruft
1646 2003-04-14 Havoc Pennington <hp@redhat.com>
1648 * dbus/dbus-userdb.c: user database abstraction, mostly to get
1649 caching, but at some point we might want to be able to use a
1652 * bus/dispatch.c (bus_dispatch_sha1_test): add a test that uses
1653 SHA1 conf file to test the sha1 auth mechanism, since the regular
1654 test always uses EXTERNAL when available.
1657 test/data/valid-config-files/debug-allow-all-sha1.conf.in:
1658 add conf file that requires use of sha1 auth
1660 2003-04-13 Havoc Pennington <hp@pobox.com>
1662 * tools/dbus-send.c, tools/dbus-monitor.c: two utility programs
1663 from Philip Blundell to send messages and monitor them.
1665 2003-04-13 Havoc Pennington <hp@pobox.com>
1667 * dbus/dbus-mainloop.c: fix some reentrancy issues by refcounting
1670 * test/data/valid-config-files/debug-allow-all.conf.in: allow all
1673 * dbus/dbus-transport.c (_dbus_transport_get_dispatch_status):
1674 fix to only recover unused bytes if we're already authenticated
1675 (_dbus_transport_get_is_authenticated): fix to still mark us
1676 authenticated if there are unused bytes.
1678 * bus/dispatch.c: implement security policy checking
1680 * bus/connection.c (bus_transaction_send_from_driver): new
1682 * bus/bus.c (bus_context_check_security_policy): new
1684 * bus/dispatch.c (send_service_nonexistent_error): delete this,
1685 now we just set the DBusError and it gets converted to an error
1688 * bus/connection.c (allow_user_function): enable code using actual
1689 data from the config file
1691 * bus/policy.c (list_allows_user): handle wildcard rules for
1692 user/group connection perms
1694 2003-04-13 Havoc Pennington <hp@pobox.com>
1696 * bus/config-parser.c: Load up the BusPolicy and BusPolicyRules
1698 * dbus/dbus-sysdeps.c (_dbus_get_user_id): new function
1700 * bus/policy.c (bus_policy_append_mandatory_rule)
1701 (bus_policy_append_default_rule, bus_policy_append_user_rule)
1702 (bus_policy_append_group_rule): new functions
1704 2003-04-12 Havoc Pennington <hp@pobox.com>
1706 * bus/config-parser.c (bus_config_parser_new): fix a memleak
1708 * dbus/dbus-sysdeps.c: change DBusCredentials to use longs for
1709 the pid/gid/uid, just for paranoia.
1711 * test/break-loader.c (randomly_do_n_things): find a byte
1712 containing a type code, and randomly change it to a different
1715 2003-04-12 Havoc Pennington <hp@pobox.com>
1717 * bus/policy.h: change BusPolicy to be the thing from the config
1718 file, and rename old BusPolicy to BusClientPolicy
1720 * bus/bus.c, bus/connection.c, bus/config-parser.c: change to
1721 match change in how policy works
1723 * dbus/dbus-internals.h: mark assert_not_reached as
1724 __attribute((noreturn))__
1726 2003-04-11 Havoc Pennington <hp@redhat.com>
1728 * doc/dbus-specification.sgml: fix a spot with the wrong name for
1729 the broadcast service. Use boolean return for ServiceExists.
1731 2003-04-11 Havoc Pennington <hp@redhat.com>
1733 * configure.in: add another directory to look for qt in.
1735 2003-04-11 Havoc Pennington <hp@redhat.com>
1737 * AUTHORS: add Colin Walters
1739 2003-04-11 Havoc Pennington <hp@redhat.com>
1745 2003-04-11 Havoc Pennington <hp@redhat.com>
1747 * bus/messagebus.in: remove pid file when stopping the
1748 message bus, since the bus won't have privileges to remove it
1751 2003-04-11 Havoc Pennington <hp@redhat.com>
1753 * bus/bus.c (bus_context_new): move credentials change after
1756 2003-04-11 Havoc Pennington <hp@pobox.com>
1758 * test/decode-gcov.c: add "below average functions" to the
1759 coverage report, and change how some of the code works.
1761 * bus/test-main.c: bracket some stuff in DBUS_BUILD_TESTS so it's
1762 not in the coverage stats.
1764 * test/test-service.c (main): use _dbus_verbose not fprintf in a
1765 couple places so running the test suite doesn't result in megaspam.
1767 2003-04-11 Havoc Pennington <hp@pobox.com>
1769 * bus/dispatch.c (check_existent_service_activation): accept a no
1770 memory error in a place we didn't before
1772 * bus/test.c (bus_test_run_everything): remove hacky "do it twice
1773 in case the first one failed," since the test suite is less
1776 2003-04-10 Havoc Pennington <hp@pobox.com>
1778 * bus/dispatch.c (check_segfault_service_activation): add test
1779 for launching an executable that just crashes.
1781 * test/test-segfault.c (main): try setting coredumpsize to 0 so we
1782 don't leave a million cores. We'll see how portable this is.
1784 2003-04-10 Havoc Pennington <hp@pobox.com>
1786 * dbus/dbus-spawn.c (_dbus_spawn_async_with_babysitter): move all
1787 the possible parent failures before we fork, so that we don't
1788 fail to create a babysitter after creating the child.
1790 * bus/activation.c (bus_activation_activate_service): kill child
1791 if we don't successfully complete the activation.
1793 2003-04-10 Havoc Pennington <hp@redhat.com>
1795 * dbus/dbus-connection.c (dbus_connection_flush): don't spin on
1796 the connection if it's disconnected
1798 * bus/activation.c (bus_activation_service_created): use new
1799 transaction features to roll back removal of pending activation if
1800 we don't successfully create the service after all. Don't remove
1801 pending activation if the function fails.
1803 * dbus/dbus-list.c (_dbus_list_insert_before_link)
1804 (_dbus_list_insert_after_link): new code to facilitate
1807 * dbus/dbus-hash.c (_dbus_hash_table_insert_string_preallocated):
1808 new functionality, so we can preallocate the ability to insert
1811 * bus/connection.c (bus_transaction_add_cancel_hook): new function
1812 allowing us to put custom hooks in a transaction to be used for
1813 cancelling said transaction
1815 * doc/dbus-specification.sgml: add some discussion of secondary
1816 service owners, and disallow zero-length service names
1818 * bus/services.c (bus_registry_acquire_service): new function,
1819 splits out part of bus_driver_handle_acquire_service() and fixes
1820 a bug where we didn't remove the service doing the acquiring
1821 from the secondary queue if we failed to remove the current owner
1822 from the front of the queue.
1824 2003-04-10 Alexander Larsson <alexl@redhat.com>
1826 * doc/dbus-specification.sgml:
1827 s/org.freedesktop.Broadcast/org.freedesktop.DBus.Broadcast/
1829 2003-04-10 Alexander Larsson <alexl@redhat.com>
1834 Added files to cvsignore
1836 * dbus/dbus-message.h:
1837 * dbus/dbus-message.c: (dbus_message_iter_get_named):
1838 Make get_named() take two out argument and return a boolean.
1839 (dbus_message_iter_get_args_valist):
1840 Update usage of get_named().
1841 (dbus_message_iter_append_byte):
1843 (dbus_message_iter_append_named)
1845 (message_iter_test), (check_message_handling_type), (_dbus_message_test):
1848 2003-04-10 Alexander Larsson <alexl@redhat.com>
1850 * dbus/dbus-marshal.[ch]:
1851 Add array_type_pos argument to _dbus_marshal_validate_arg.
1852 Let you pass a NULL end_pos to _dbus_marshal_validate_type.
1854 * dbus/dbus-message.[ch]:
1855 Multi-dimensional arrays have full type specification in the
1856 outermost array. Iter code re-arranged to handle this.
1857 Added some more iter tests.
1859 * doc/dbus-specification.sgml:
1862 Update new array encoding description.
1863 Correct DBUS_SERVICE_FLAGS_REPLACE_EXISTING description.
1865 * test/data/invalid-messages/array-with-mixed-types.message:
1866 * test/data/valid-messages/array-of-array-of-uint32.message:
1867 Change to the new array format.
1869 * test/data/invalid-messages/too-short-dict.message:
1872 * test/data/valid-messages/recursive-types.message:
1873 Fix up and extend test.
1875 2003-04-10 Havoc Pennington <hp@pobox.com>
1877 * bus/dispatch.c: lots of fixes
1879 * dbus/dbus-mainloop.c (_dbus_loop_dispatch): export
1880 (_dbus_loop_iterate): remove old "quit if no callbacks" code,
1881 that was crack, broke the test service.
1883 * dbus/dbus-transport.c (_dbus_transport_open): fix error
1884 handling to avoid piling up errors if we get a failure on the
1887 * dbus/dbus-internals.c (_dbus_real_assert_not_reached): include
1888 pid in assertion failures.
1890 * dbus/dbus-mainloop.c (_dbus_loop_iterate): use static arrays up
1891 to some fixed size of file descriptor array. Don't return TRUE
1892 anytime a timeout exists, that led to lots of busy loop silliness
1895 2003-04-09 Havoc Pennington <hp@redhat.com>
1897 * dbus/dbus-mainloop.c (check_timeout): fix timeouts, I thought
1898 I'd checked this in earlier but hadn't.
1900 2003-04-09 Havoc Pennington <hp@redhat.com>
1902 * bus/dispatch.c (bus_dispatch_test): get a bit further through
1903 the activation test (man this is getting old!)
1905 2003-04-09 Havoc Pennington <hp@redhat.com>
1907 * test/test-utils.c: use dispatch status function to fix this up
1909 * bus/connection.c (connection_watch_callback): don't dispatch
1911 (connection_timeout_callback): don't dispatch from here
1912 (bus_connections_setup_connection): set the dispatch status function
1913 (bus_connection_disconnected): unset it
1915 * dbus/dbus-mainloop.c (_dbus_loop_queue_dispatch): new function
1916 used to add a connection to be dispatched
1917 (_dbus_loop_iterate): do the dispatching at the end of each
1920 * dbus/dbus-connection.c
1921 (dbus_connection_set_dispatch_status_function): new function
1922 allowing us to fix up main loop usage
1923 (_dbus_connection_last_unref): free all the various function
1925 (dbus_connection_dispatch): call the DispatchStatusFunction
1926 whenever this function returns
1927 (dbus_connection_handle_watch): call DispatchStatusFunction
1928 (dbus_connection_send_with_reply_and_block): call DispatchStatusFunction
1929 (reply_handler_timeout): call DispatchStatusFunction
1930 (dbus_connection_flush): call DispatchStatusFunction
1932 2003-04-09 Havoc Pennington <hp@redhat.com>
1934 * dbus/dbus-bus.c (dbus_bus_register): fix up error handling and
1937 * bus/dispatch.c (check_service_activated): fix bug in test
1939 * dbus/dbus-mainloop.c (check_timeout): fix this up
1941 * dbus/dbus-internals.c (_dbus_verbose_real): include PID in
1942 verbose output so we can sort out output from different processes,
1943 e.g. in the activation case.
1945 2003-04-08 Colin Walters <walters@gnu.org>
1947 * bus/bus.c (struct BusContext) [pidfile]: New member, to store
1949 (bus_context_new): Set it.
1950 (bus_context_unref): Use it to delete the pid file.
1952 2003-04-08 Havoc Pennington <hp@redhat.com>
1954 * test/data/invalid-messages/array-with-mixed-types.message:
1955 regression test that fails for the moment
1957 * dbus/dbus-test.c (dbus_internal_do_not_use_run_tests): reorder
1958 tests for convenience
1960 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): don't allow
1961 array of nil, it broke things.
1963 * test/data/invalid-messages/array-of-nil.message: regression test
1965 * test/data/valid-messages/array-of-array-of-uint32.message:
1966 happened to write this so added it to suite
1968 2003-04-08 Havoc Pennington <hp@redhat.com>
1970 * bus/driver.c (bus_driver_handle_acquire_service): init
1971 retval/reply before checking name
1973 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): add a
1974 recursion depth argument
1976 * dbus/dbus-message.h (struct DBusMessageIter): put some padding
1977 in the public struct for future extension
1979 * dbus/dbus-message-builder.c (_dbus_message_data_load): fix
1982 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): fix a verbose
1985 * doc/dbus-specification.sgml: fix typo
1987 2003-04-08 Alexander Larsson <alexl@redhat.com>
1989 Implemented recursive types, named types and new-style iters
1992 * glib/test-thread-client.c: (thread_func):
1993 * glib/test-thread-server.c: (handle_test_message):
1994 * test/test-service.c: (handle_echo):
2003 * dbus/dbus-internals.c: (_dbus_type_to_string):
2004 Update for new types.
2006 * dbus/dbus-marshal.[ch]:
2007 Implement recursive types and the new marshalling format.
2008 Remove hardcoded dict marshalling.
2009 Marshal named types.
2011 * dbus/dbus-message-builder.c:
2013 Remove references to old types
2015 * dbus/dbus-message.[ch]:
2016 New non-refcounted iter API that supports recursive iters.
2017 Use iters for appending, including support for recursive
2019 Add byte and named type support.
2020 Update everything to new marshalling formats.
2021 Add tests for new API.
2023 * dbus/dbus-protocol.h:
2024 Remove old array types.
2025 Add types: BYTE, ARRAY, DICT, NAMED
2027 * dbus/dbus-string.c:
2028 * dbus/dbus-sysdeps.c:
2029 Make parse_double locale safe.
2031 * dbus/dbus-test-main.c:
2037 * doc/dbus-specification.sgml:
2040 * test/data/incomplete-messages/missing-body.message:
2041 * test/data/invalid-messages/bad-boolean.message:
2042 * test/data/invalid-messages/bad-boolean-array.message:
2043 * test/data/invalid-messages/boolean-array-length-too-long.message-raw:
2044 * test/data/invalid-messages/boolean-has-no-value.message-raw:
2045 * test/data/invalid-messages/too-short-dict.message:
2046 * test/data/valid-messages/dict-simple.message:
2047 * test/data/valid-messages/dict.message:
2048 * test/data/valid-messages/emptiness.message:
2049 * test/data/valid-messages/lots-of-arguments.message:
2050 * test/data/valid-messages/no-padding.message:
2051 * test/data/valid-messages/recursive-types.message:
2052 Add missing NAME fields
2053 Fix up dicts & arrays
2055 * test/data/invalid-messages/dict-with-nil-value.message:
2056 Removed, this is not invalid anymore.
2058 * test/data/valid-messages/recursive-types.message:
2059 Add new test for deeply recursive types.
2061 2003-04-07 Havoc Pennington <hp@pobox.com>
2063 * bus/driver.c (bus_driver_handle_acquire_service): return an
2064 error if you try to acquire a service that starts with ':'
2066 2003-04-07 Havoc Pennington <hp@redhat.com>
2068 * doc/dbus-specification.sgml: require that base service names
2069 start with ':' and that the base service is created/deleted
2070 as first and last things a connection does on the bus
2072 * bus/dispatch.c (check_existent_service_activation): lots more
2073 work on the activation test; it doesn't fully pass yet...
2075 * test/test-service.c (main): fix so we don't memleak the
2076 connection to the message bus
2077 (filter_func): accept a message asking us to exit
2079 2003-04-06 Havoc Pennington <hp@pobox.com>
2081 * qt/Makefile.am (dbusinclude_HEADERS): install dbus-qt.h,
2084 * configure.in: fixes to Qt detection from Colin Walters
2086 * doc/Makefile.am: Only remove generated docbook dirs if they
2087 exist, from Colin Walters
2089 * dbus/dbus-bus.c: change how we set well-known connections to
2090 NULL, so that it works if a single connection is stored in
2091 two well-known array slots.
2093 * test/Makefile.am: remove a lot of stuff that isn't immediately
2094 useful, it's in CVS history if we want it.
2096 * test/test-service.c: use dbus-mainloop instead of that
2099 2003-04-06 Havoc Pennington <hp@pobox.com>
2101 * dbus/Makefile.am: split lists of sources into stuff that goes in
2102 the library, util functions that go in the lib and are also used
2103 elsewhere, and util functions that are used in tests/daemon but
2104 don't go in the lib.
2106 * dbus/dbus-mainloop.h, dbus/dbus-mainloop.c: move bus/loop.[hc]
2107 here so it can be used in test binaries also
2109 2003-04-06 Havoc Pennington <hp@pobox.com>
2111 * dbus/dbus-sysdeps.c (_dbus_become_daemon): write the pidfile
2112 here in the parent process, so we can return an error if it
2113 fails. Also, move some of the code into the child so the parent
2114 is less hosed if we fail midway through.
2116 * bus/bus.c (bus_context_new): move pidfile detection further up
2117 in the function, before we start overwriting sockets and such.
2119 * bus/messagebus.in: adjust this a bit, not sure if it will work.
2121 * configure.in: add --with-system-pid-file and --with-system-socket
2123 2003-04-06 Colin Walters <walters@verbum.org>
2125 * configure.in (DBUS_SYSTEM_PID_FILE): New variable.
2127 * bus/system.conf.in: Declare a pidfile.
2129 * bus/bus.c (bus_context_new): Test for an existing pid file, and
2130 create one (if appropriate).
2132 * bus/config-parser.c (enum ElementType) [ELEMENT_PIDFILE]: New.
2133 (struct BusConfigParser) [pidfile]: New.
2134 (element_type_to_name, merge_included, start_busconfig_child)
2135 (bus_config_parser_end_element, bus_config_parser_content): Handle it.
2136 (bus_config_parser_unref): Free it.
2137 (bus_config_parser_get_pidfile): New function.
2139 * bus/config-parser.h (_dbus_write_pid_file): Prototype.
2141 * dbus/dbus-errors.h (DBUS_ERROR_PIDFILE_EXISTS): New error.
2143 * dbus/dbus-sysdeps.c (_dbus_write_pid_file): New function.
2145 * dbus/dbus-sysdeps.h: Prototype it.
2147 2003-04-06 Havoc Pennington <hp@pobox.com>
2149 * bus/bus.c (bus_context_new): print the address in here, rather
2150 than in main(), because we need to do it before forking the daemon
2152 * bus/dispatch.c (send_service_nonexistent_error): set the sender
2153 on the service nonexistent error
2155 * bus/driver.c (bus_driver_handle_acquire_service): set the
2156 sender on the AcquireService reply
2158 * test/data/valid-config-files/debug-allow-all.conf.in: Make test
2159 server also listen on a UNIX socket so services can connect to it.
2161 2003-04-06 Havoc Pennington <hp@pobox.com>
2163 * dbus/dbus-threads.c: Redo how the fake debug mutexes are done
2164 so it detects deadlocks and also we actually init threads when
2167 2003-04-06 Havoc Pennington <hp@pobox.com>
2169 * dbus/dbus-server-unix.c (_dbus_server_new_for_domain_socket):
2170 save the domain socket name, and unlink it when we disconnect the
2171 server. Means that at least when we exit normally, we won't leave
2172 a bunch of junk in /tmp
2174 * dbus/dbus-transport-unix.c
2175 (_dbus_transport_new_for_domain_socket): code cleanup (nicer
2176 memory management). (I was making a real change here but then
2179 2003-04-06 Havoc Pennington <hp@pobox.com>
2181 * bus/bus.c (bus_context_new): fix wrong handling of
2182 server_data_slot_unref() in the error case.
2184 * dbus/dbus-internals.h (_dbus_assert): change so it passes
2185 "(condition) != 0" to _dbus_real_assert so that
2186 "_dbus_assert (pointer)" doesn't cause a warning
2188 * bus/main.c (main): accept --print-address option to print out
2189 the message bus address
2191 * dbus/dbus-sysdeps.c (_dbus_generate_random_ascii): export this
2193 * dbus/dbus-transport.c (_dbus_transport_open): special error for
2194 "tmpdir" option to unix: address on client side
2196 * dbus/dbus-server.c (dbus_server_listen): handle "tmpdir" option
2199 * configure.in (TEST_SOCKET_DIR): locate a temporary directory
2200 we can use to create sockets in the test suite.
2202 * bus/main.c (signal_handler): on SIGTERM, exit the daemon
2203 cleanly. To be used for testing.
2205 * dbus/dbus-spawn.c (babysit): use _dbus_set_signal_handler()
2207 * dbus/dbus-sysdeps.c (_dbus_set_signal_handler): new
2209 * dbus/dbus-server-debug-pipe.c (_dbus_transport_debug_pipe_new):
2210 handle trying to call this when there's no servers active
2212 2003-04-05 Havoc Pennington <hp@pobox.com>
2218 2003-04-05 Havoc Pennington <hp@pobox.com>
2220 * bus/bus.c (setup_server): fix this so dbus-daemon-1 doesn't
2221 crash on startup. Need to get "try starting the daemon"
2222 in the test suite I guess. ;-)
2224 * dbus/dbus-server.h, dbus/dbus-server.c: remove the stuff that
2225 tracked the number of open connections; it's better done in
2226 application-specific code as you want it to span all servers etc.
2228 2003-04-05 Havoc Pennington <hp@pobox.com>
2230 * bus/Makefile.am (install-data-hook): add missing DESTDIR,
2231 patch from Colin Walters
2233 2003-04-05 Havoc Pennington <hp@pobox.com>
2235 * doc/config-file.txt (Elements): fix docs of <auth> to reflect
2236 reality; in fact multiple mechanisms are allowed.
2238 * dbus/dbus-internals.c (_dbus_real_assert)
2239 (_dbus_real_assert_not_reached): move guts of _dbus_assert() and
2240 _dbus_assert_not_reached() into functions, so that they don't show
2241 up in basic block counts for test coverage, and don't use up as
2242 much disk space. Does mean slower execution speed though, so
2243 assumes --disable-asserts is the normal production case.
2245 2003-04-05 Havoc Pennington <hp@pobox.com>
2247 * test/Makefile.am (dist-hook): also dist *.in files
2253 2003-04-05 Havoc Pennington <hp@pobox.com>
2255 * dbus/dbus-string.c: docs warning
2257 * dbus/dbus-spawn.c: missing docs
2259 * dbus/dbus-memory.c (struct ShutdownClosure): missing docs
2261 2003-04-05 Havoc Pennington <hp@pobox.com>
2263 * bus/loop.c (bus_loop_iterate): fix the timeout code, using
2266 * dbus/dbus-spawn.c (_dbus_babysitter_unref): set sitter_pid
2267 to -1 once we've reaped the babysitter
2268 (_dbus_babysitter_handle_watch): do as much work as we can, not
2271 * bus/activation.c: add code using DBusBabysitter so that we
2272 handle it when a service fails to start up properly.
2273 (bus_activation_service_created): don't remove the activation
2274 entries as we go, just let them get removed when we free the pending
2275 activation. Unref reply messages after sending them.
2277 2003-04-05 Havoc Pennington <hp@pobox.com>
2279 * test/decode-gcov.c (main): print per-directory stats in the report
2281 * Makefile.am (coverage-report.txt): don't include test/* in gcov stats
2283 2003-04-05 Havoc Pennington <hp@pobox.com>
2285 * Makefile.am (coverage-report.txt): add target "coverage-report.txt"
2287 * test/decode-gcov.c: hack up a little program to suck data
2288 out of gcov files. Yes this is sort of silly.
2290 * configure.in: define something in config.h and do an
2291 AM_CONDITIONAL when gcov is enabled
2293 2003-04-04 Havoc Pennington <hp@redhat.com>
2295 * dbus/dbus-spawn.c, dbus/dbus-spawn.h: Change dbus_spawn to
2296 return a "babysitter" object that is used to monitor the status of
2297 the spawned process and reap it when required.
2299 * test/test-segfault.c, test/test-exit.c,
2300 test/test-sleep-forever.c: binaries that do various lame things,
2301 used in the test suite.
2303 * dbus/dbus-sysdeps.c: kill _dbus_errno_to_string()
2305 2003-04-03 Havoc Pennington <hp@pobox.com>
2307 * dbus/dbus-spawn.c: Move dbus-spawn into a separate file
2308 in preparation for modifying it, dbus-sysdeps is getting
2311 2003-04-03 Havoc Pennington <hp@redhat.com>
2313 * bus/loop.h, bus/loop.c: make the mainloop an object so we can
2316 * bus/*.[hc]: adapt to mainloop change
2318 2003-04-03 Havoc Pennington <hp@redhat.com>
2320 * bus/activation.c (load_directory): fix up memleaks
2321 (bus_activation_entry_free): free the entry
2323 * dbus/dbus-bus.c (dbus_bus_acquire_service): return an error if
2324 we get one from the message bus; fix memleaks.
2326 * dbus/dbus-message.c (dbus_set_error_from_message): new function
2328 2003-04-03 Havoc Pennington <hp@pobox.com>
2330 * bus/config-parser.c (bus_config_parser_unref): free
2331 list of mechanisms, bug discovered by test suite enhancements
2332 (putting system.conf and session.conf into suite)
2334 * test/Makefile.am, test/test-service.c: add placeholder for a
2335 test service that we'll activate as part of test suite. Doesn't
2338 * dbus/dbus-sysdeps.c (_dbus_setenv): support unsetenv by
2339 setting NULL value, and use system malloc not dbus_malloc()
2340 when we have unavoidable memleakage.
2342 * dbus/dbus-bus.c (dbus_bus_get): fix bug where bus type of 0
2343 didn't work, and support DBUS_BUS_ACTIVATION.
2345 * bus/activation.c (child_setup): pass our well-known bus type to
2348 * bus/config-parser.c: support <type> to specify well-known type
2350 * doc/dbus-specification.sgml: document the env variables to
2351 locate well-known buses and find service activator
2353 2003-04-02 Havoc Pennington <hp@redhat.com>
2355 * test/Makefile.am (all-local): add a rule to copy tests to
2356 builddir, so we can have generated tests. Use this to remove the
2357 silly hack for testing system.conf and session.conf. Will use this
2358 shortly to generate .service files pointing to test binaries.
2360 2003-04-02 Havoc Pennington <hp@redhat.com>
2362 * dbus/dbus-string.c (set_length): fix a bug - we allocated max of
2363 current alloc and needed new length, not max of the doubled
2364 allocation and needed new length. Also, when building tests,
2365 don't do the double-allocation stuff, just realloc every time.
2367 2003-04-02 Havoc Pennington <hp@redhat.com>
2369 * dbus/dbus-sysdeps.c (_dbus_file_get_contents): include filenames
2371 (_dbus_string_get_dirname): new
2372 (_dbus_sysdeps_test): new
2373 (_dbus_directory_open): include dirnames in error messages
2375 * bus/config-parser.c: interpret <include> and <includedir> and
2376 <servicedir> relative to config file location if the given
2377 filename is not absolute.
2379 * dbus/dbus-string.c (_dbus_string_find_byte_backward): new
2381 2003-04-02 Havoc Pennington <hp@redhat.com>
2383 * bus/connection.c (bus_transaction_send_error_reply): set sender
2384 service for the error, and unref the reply on success
2386 * bus/activation.c: convert to use BusTransaction so OOM can be
2388 (bus_activation_service_created): set sender of the message
2390 2003-04-01 Havoc Pennington <hp@redhat.com>
2392 * bus/config-parser.c, bus/bus.c: implement <servicedir> and
2393 <includedir> (at least mostly)
2395 * dbus/dbus-sysdeps.c (_dbus_change_identity): set the group ID
2396 first, then the user ID
2398 2003-04-01 Havoc Pennington <hp@pobox.com>
2400 * dbus/dbus-server.c (dbus_server_set_auth_mechanisms): new
2403 * dbus/dbus-auth.c (_dbus_auth_set_mechanisms): new
2405 * dbus/dbus-internals.c (_dbus_dup_string_array): new function
2407 * dbus/dbus-sysdeps.c (_dbus_listen_unix_socket): chmod the
2408 socket 0777, and unlink any existing socket.
2410 * bus/bus.c (bus_context_new): change our UID/GID and fork if
2411 the configuration file so specifies; set up auth mechanism
2414 * bus/config-parser.c (bus_config_parser_content): add support
2415 for <fork> option and fill in code for <auth>
2417 * bus/system.conf.in: add <fork/> to default configuration,
2418 and limit auth mechanisms to EXTERNAL
2420 * doc/config-file.txt (Elements): add <fork>
2422 * dbus/dbus-sysdeps.c (_dbus_become_daemon): new function
2423 (_dbus_change_identity): new function
2425 2003-03-31 Havoc Pennington <hp@redhat.com>
2427 * dbus/dbus-sysdeps.c (_dbus_connect_unix_socket)
2428 (_dbus_listen_unix_socket): fix off-by-one error in null
2429 termination spotted by Nalin
2431 2003-03-31 Havoc Pennington <hp@redhat.com>
2433 * dbus/dbus-keyring.c (_dbus_keyring_new_homedir): allow setting
2434 DBUS_TEST_HOMEDIR when tests are enabled, so we can test without
2435 having a real home directory available.
2437 2003-03-31 Havoc Pennington <hp@redhat.com>
2439 * bus/Makefile.am (install-data-hook): create /var/run/dbus
2441 * bus/messagebus.in: add init script for Red Hat /etc/init.d
2443 * configure.in: add support for specifying a style of init script
2446 2003-03-31 Havoc Pennington <hp@redhat.com>
2448 Fix some annoying DBusString API and fix all affected code.
2450 * dbus/dbus-string.c (_dbus_string_init): get rid of annoying
2452 (_dbus_string_get_data): change to return string instead of using
2454 (_dbus_string_get_const_data): ditto
2455 (_dbus_string_get_data_len): ditto
2456 (_dbus_string_get_const_data_len): ditto
2458 2003-03-31 Havoc Pennington <hp@redhat.com>
2460 * bus/main.c (main): fix up the command line arguments to be nicer
2462 2003-03-31 Havoc Pennington <hp@redhat.com>
2464 * dbus/Makefile.am (INCLUDES): use EXPANDED_LOCALSTATEDIR to
2465 define DBUS_SYSTEM_BUS_PATH as we want to compile in the same
2466 final location that lands in the config file
2468 * bus/config-loader-expat.c (bus_config_load): fix type of
2471 * doc/TODO: remove TODO item for dbus_bus_get()
2473 * dbus/dbus-bus.c (bus_data_free): add missing lock/unlock
2475 2003-03-31 Havoc Pennington <hp@pobox.com>
2477 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_domain_socket)
2478 (_dbus_transport_new_for_tcp_socket): these didn't need the "server"
2479 argument since they are always client side
2481 * dbus/dbus-server.c (dbus_server_get_address): new function
2483 * bus/main.c (main): take the configuration file as an argument.
2485 * test/data/valid-config-files/debug-allow-all.conf: new file to
2486 use with dispatch.c tests for example
2488 * bus/test-main.c (main): require test data dir
2490 * bus/bus.c (bus_context_new): change this to take a
2491 configuration file name as argument
2493 * doc/config-file.txt (Elements): add <servicedir>
2495 * bus/system.conf, bus/session.conf: new files
2497 * dbus/dbus-bus.c (dbus_bus_get): look for system bus on
2498 well-known socket if none set
2500 * configure.in: create system.conf and session.conf
2502 2003-03-30 Havoc Pennington <hp@pobox.com>
2504 * bus/config-parser.c: hacking
2506 * dbus/dbus-memory.c: don't use DBusList for the list of stuff
2507 to shut down, since it could cause weirdness with the DBusList
2510 * dbus/dbus-list.c (_dbus_list_test): add tests for the
2511 link-oriented stack routines
2512 (alloc_link): free the mempool if the first alloc from it fails
2514 * dbus/dbus-mempool.c (struct DBusMemBlock): fix alignment issue
2516 * dbus/dbus-string.c (UNICODE_VALID): sync new version of this
2518 (_dbus_string_skip_white): new
2520 * doc/config-file.txt (Elements): add <includedir>
2522 2003-03-28 Havoc Pennington <hp@pobox.com>
2524 * dbus/dbus-string.c (_dbus_string_copy_data_len)
2525 (_dbus_string_copy_data): new functions
2527 2003-03-28 Anders Carlsson <andersca@codefactory.se>
2529 * dbus/dbus-bus.c: (bus_data_free), (dbus_bus_get):
2533 * dbus/dbus-memory.c:
2536 2003-03-28 Havoc Pennington <hp@pobox.com>
2538 * bus/test.c (bus_test_flush_bus): remove the sleep from here,
2539 I think it may have just been superstition. Not sure.
2541 * dbus/dbus-string.c (_dbus_string_base64_decode): catch some OOM
2542 failures that were not being handled.
2544 * dbus/dbus-auth.c (process_auth): fix a memleak in OOM handling
2546 * dbus/dbus-memory.c: add ability to set number of mallocs in a
2547 row that will fail on out-of-memory.
2549 * dbus/dbus-internals.c (_dbus_test_oom_handling): convenience
2550 function for testing out-of-memory handling.
2552 * bus/config-loader-expat.c (memsuite): don't wrap the dbus
2553 allocation functions, they do map exactly to the expat ones.
2555 2003-03-27 Havoc Pennington <hp@redhat.com>
2557 * bus/config-loader-libxml.c (bus_config_load): add another error
2560 2003-03-26 Anders Carlsson <andersca@codefactory.se>
2563 Add note about automatic service activation.
2565 * doc/dbus-specification.sgml:
2566 Rename the specification and clarify a few things.
2568 2003-03-26 Anders Carlsson <andersca@codefactory.se>
2571 * dbus/dbus-address.c:
2573 * dbus/dbus-marshal.c:
2574 * dbus/dbus-server-debug-pipe.c:
2575 * dbus/dbus-transport-unix.c:
2576 Fix documentation warnings.
2578 2003-03-26 Havoc Pennington <hp@pobox.com>
2580 * bus/test-main.c, dbus/dbus-test.c (main): check memleaks
2581 after every test so it's quick and easy to see which leaked, and
2582 so we test multiple dbus_shutdown() calls
2584 * configure.in: change configure.in XML stuff to also support
2587 * config-loader-libxml.c: some hacking
2589 * config-loader-expat.c: some hacking
2591 * config-parser.c: some hacking, plus tests
2593 2003-03-25 Havoc Pennington <hp@redhat.com>
2595 * throughout - add more _DBUS_ASSERT_ERROR_IS_CLEAR
2597 * configure.in: add --with-xml option to specify XML library,
2598 right now only libxml is supported.
2600 * bus/config-loader-libxml.c, config-parser.c: sync some minor
2601 nonworking code between home and work, still just stubs
2603 2003-03-24 Havoc Pennington <hp@redhat.com>
2605 * dbus/dbus-sysdeps.c (_dbus_set_fd_nonblocking): move to this
2608 * dbus/dbus-errors.c (dbus_set_error, dbus_set_error_const): allow
2609 NULL argument for "message" if the error is a well-known one,
2610 fill in a generic message in this case.
2612 * dbus/dbus-errors.h (DBusResultCode): Kill DBusResultCode in
2615 * bus/test.c (bus_test_flush_bus): add
2617 * bus/policy.c (bus_policy_test): test code stub
2619 2003-03-24 Havoc Pennington <hp@pobox.com>
2621 * bus/connection.c (bus_connections_setup_connection): set up
2622 the "can this user connect" function, but it always returns
2623 TRUE until we have a config file parser so we can have a config
2624 file that allows connections.
2626 2003-03-23 Havoc Pennington <hp@pobox.com>
2628 * dbus/dbus-threads.c (dbus_mutex_new, dbus_condvar_new): with
2629 DBUS_BUILD_TESTS, actually alloc/free a block of memory for
2630 the mutex, so we can check for proper memory management
2633 * dbus/dbus-dataslot.c: remove the mutex from
2634 DBusDataSlotAllocator and lock it manually when using it,
2635 to simplify fitting it into the global slots framework.
2637 * dbus/dbus-threads.c (init_static_locks): rework how we're
2638 handling global locks so they are easily shut down.
2640 * bus/policy.c (bus_policy_append_rule): fix
2642 * bus/test-main.c (main): check for memleaks
2644 * dbus/dbus-test.c (dbus_internal_do_not_use_run_tests): make
2645 test suite check for memleaks
2647 * dbus/dbus-memory.c: add support in test mode for tracking
2648 number of outstanding blocks
2650 2003-03-23 Havoc Pennington <hp@pobox.com>
2652 * bus/policy.c, bus/bus.c, bus/connection.c: implement allow/deny
2655 * dbus/dbus-hash.h: add ULONG hash keys
2657 * dbus/dbus-sysdeps.c (_dbus_get_groups): new
2658 (_dbus_get_group_id): new function
2660 2003-03-20 Havoc Pennington <hp@redhat.com>
2662 * dbus/dbus-connection.c (dbus_connection_set_unix_user_function):
2664 (dbus_connection_get_unix_user): new function
2666 2003-03-20 Havoc Pennington <hp@pobox.com>
2668 * bus/connection.c (bus_connection_send_oom_error): assert that
2669 message has a sender
2670 (connection_execute_transaction): ditto
2671 (bus_connection_preallocate_oom_error): fix to set the sender, and
2672 set recipient to the destination service, not the bus driver
2674 * bus/policy.c: hacking
2676 * dbus/dbus-message.c (dbus_message_service_is): new function
2677 (dbus_message_sender_is): new
2679 2003-03-19 Havoc Pennington <hp@redhat.com>
2681 * bus/policy.c: start sketching code for policy restrictions on
2682 what connections can do.
2684 2003-03-18 Havoc Pennington <hp@redhat.com>
2686 * doc/TODO: some notes on high-level todo items. Little nitpick
2687 stuff is all in @todo, so no need to add it here.
2689 * doc/config-file.txt: some notes on how config file might look
2691 2003-03-18 Anders Carlsson <andersca@codefactory.se>
2697 2003-03-17 Havoc Pennington <hp@redhat.com>
2699 * dbus/dbus-internals.h: add gcc attributes so that
2700 our printf-style functions warn on bad arguments to
2703 * dbus/dbus-sysdeps.c (_dbus_connect_tcp_socket): fix printf
2706 * dbus/dbus-message.c (_dbus_message_loader_queue_messages): fix
2709 2003-03-17 Havoc Pennington <hp@redhat.com>
2711 * bus/test-main.c (main): make it print something as it runs
2712 so make check doesn't look stuck
2714 * doc/negotiation.txt, doc/dbus-sasl-profile.txt: remove
2715 from CVS, now obsolete
2717 2003-03-17 Anders Carlsson <andersca@codefactory.se>
2719 * bus/dispatch.c: (bus_dispatch):
2720 Refetch the service name since it may have been reallocated
2721 when dbus_message_set_sender was called.
2723 * dbus/dbus-sysdeps.c: (_dbus_accept):
2724 Add address and address length variables and use them to stop
2725 valgrind from complaining.
2727 2003-03-17 Havoc Pennington <hp@pobox.com>
2729 All tests pass, no memleaks, no valgrind complaints.
2731 * bus/test.c: refcount handler_slot
2733 * bus/connection.c (bus_connections_new): refcount
2734 connection_data_slot
2736 * dbus/dbus-auth-script.c (_dbus_auth_script_run): delete unused
2737 bytes so that auth scripts pass.
2739 * bus/dispatch.c: init message_handler_slot so it gets allocated
2742 * bus/dispatch.c (message_handler_slot_ref): fix memleak
2744 * dbus/dbus-server-debug-pipe.c (_dbus_server_debug_pipe_new):
2745 dealloc server_pipe_hash when no longer used for benefit of
2748 * dbus/dbus-auth.c (process_command): memleak fix
2750 * bus/dispatch.c (check_hello_message): memleak fix
2752 2003-03-16 Havoc Pennington <hp@pobox.com>
2754 * dbus/dbus-bus.c (ensure_bus_data): fix double-unref of the data slot
2756 2003-03-17 Anders Carlsson <andersca@codefactory.se>
2758 * bus/activation.c (bus_activation_activate_service): Append
2759 the pending activation entry to the list of pending activations.
2761 2003-03-16 Havoc Pennington <hp@pobox.com>
2763 * bus/dispatch.c (bus_dispatch_test): remove double-unrefs of
2766 * dbus/dbus-address.c (create_entry): fix OOM handling when
2767 failing to alloc entry->method
2769 2003-03-16 Havoc Pennington <hp@pobox.com>
2771 * dbus/dbus-watch.c (_dbus_watch_new): handle failure to malloc
2774 * dbus/dbus-server-debug-pipe.c (_dbus_transport_debug_pipe_new):
2775 add some missing dbus_set_result
2777 * bus/dispatch.c (bus_dispatch_add_connection): handle failure to
2778 alloc the DBusMessageHandler
2780 * dbus/dbus-transport.c (_dbus_transport_disconnect): don't ref
2781 the transport here, since we call this from the finalizer; it
2782 resulted in a double-finalize.
2784 * dbus/dbus-transport.c (_dbus_transport_disconnect): fix a bug
2785 where we tried to use transport->connection that was NULL,
2786 happened when transport was disconnected early on due to OOM
2788 * bus/*.c: adapt to handle OOM for watches/timeouts
2790 * dbus/dbus-transport-unix.c: port to handle OOM during
2793 * dbus/dbus-auth.c (_dbus_auth_get_unused_bytes): return a
2794 reference to unused bytes instead of a copy
2796 * dbus/dbus-server.c (dbus_server_handle_watch): return FALSE for
2799 * dbus/dbus-connection.c (dbus_connection_handle_watch): return
2802 * dbus/dbus-timeout.c (dbus_timeout_handle): return FALSE for out
2805 2003-03-16 Anders Carlsson <andersca@codefactory.se>
2807 * doc/dbus-specification.sgml:
2808 Document reply message for ActivateService.
2810 2003-03-16 Anders Carlsson <andersca@codefactory.se>
2812 * bus/activation.c: (bus_pending_activation_entry_free),
2813 (bus_pending_activation_free), (bus_activation_new),
2814 (bus_activation_unref), (bus_activation_service_created),
2815 (bus_activation_activate_service):
2817 * bus/bus.c: (bus_context_new):
2818 * bus/desktop-file.c: (new_section):
2819 * bus/driver.c: (bus_driver_send_service_deleted),
2820 (bus_driver_handle_activate_service):
2821 * bus/services.c: (bus_registry_new), (bus_registry_ensure):
2823 * dbus/dbus-connection.c:
2824 (dbus_connection_send_with_reply_and_block):
2825 * dbus/dbus-message.c: (dbus_message_append_args_valist):
2826 * dbus/dbus-protocol.h:
2827 Make activation work better. Now pending activations will be queued
2828 and the daemon won't try to activate services that are already registered.
2830 2003-03-16 Havoc Pennington <hp@pobox.com>
2832 * dbus/dbus-bus.c (ensure_bus_data): handle failure to set
2835 * dbus/dbus-memory.c (_dbus_initialize_malloc_debug): support
2836 DBUS_MALLOC_BACKTRACES to print trace when failing an alloc
2838 2003-03-16 Havoc Pennington <hp@pobox.com>
2840 * dbus/dbus-string.c (_dbus_string_validate_utf8): oops, unbreak
2841 this. always run the test suite before commit...
2843 * bus/*: adapt to DBusConnection API changes
2845 * glib/dbus-gmain.c: adapt to DBusConnection API changes,
2846 requires renaming stuff to avoid dbus_connection_dispatch name
2849 * dbus/dbus-transport.c (_dbus_transport_queue_messages): new
2852 * dbus/dbus-message.c (_dbus_message_loader_queue_messages):
2853 separate from _dbus_message_loader_return_buffer()
2855 * dbus/dbus-connection.c (dbus_connection_get_n_messages): remove
2856 this, because it's now always broken to use; the number of
2857 messages in queue vs. the number still buffered by the message
2858 loader is undefined/meaningless. Should use
2859 dbus_connection_get_dispatch_state().
2860 (dbus_connection_dispatch): rename from
2861 dbus_connection_dispatch_message
2863 2003-03-16 Havoc Pennington <hp@pobox.com>
2865 * dbus/dbus-string.c (_dbus_string_validate_utf8): copy in a real
2868 2003-03-16 Anders Carlsson <andersca@codefactory.se>
2870 * dbus/dbus-connection.c:
2871 (dbus_connection_send_with_reply_and_block):
2872 Decrease connection->n_incoming when removing an entry
2874 * dbus/dbus-dict.c: (dbus_dict_entry_free),
2875 (dbus_dict_set_boolean_array), (dbus_dict_set_int32_array),
2876 (dbus_dict_set_uint32_array), (dbus_dict_set_double_array),
2877 (dbus_dict_set_byte_array), (dbus_dict_set_string_array),
2878 (dbus_dict_get_boolean_array), (dbus_dict_get_double_array),
2879 (dbus_dict_get_byte_array):
2880 Handle NULL arrays and strings. Also add support for byte arrays.
2882 * dbus/dbus-marshal.c: (_dbus_marshal_byte_array),
2883 (_dbus_marshal_dict), (_dbus_demarshal_byte_array),
2884 (_dbus_demarshal_int32_array), (_dbus_demarshal_uint32_array),
2885 (_dbus_demarshal_double_array), (_dbus_demarshal_string_array),
2886 (_dbus_demarshal_dict), (demarshal_and_validate_len),
2887 (_dbus_marshal_validate_arg), (_dbus_marshal_test):
2888 * dbus/dbus-marshal.h:
2889 Add support for marshalling and demarshalling empty arrays and strings.
2891 * dbus/dbus-message.c: (dbus_message_append_args_valist),
2892 (dbus_message_append_string_array),
2893 (dbus_message_iter_get_boolean),
2894 (dbus_message_iter_get_boolean_array),
2895 (dbus_message_iter_get_int32_array),
2896 (dbus_message_iter_get_uint32_array),
2897 (dbus_message_iter_get_double_array),
2898 (dbus_message_iter_get_byte_array),
2899 (dbus_message_iter_get_string_array), (dbus_message_iter_get_dict),
2900 (check_message_handling):
2901 Add support for getting empty arrays and dicts.
2903 * dbus/dbus-string.c: (_dbus_string_validate_utf8):
2904 Don't do any validation at all for now, that's better than just checking
2907 * test/data/valid-messages/emptiness.message:
2908 New test message with lots of empty arrays.
2910 2003-03-16 Havoc Pennington <hp@pobox.com>
2912 * dbus/dbus-connection.c
2913 (_dbus_connection_queue_received_message_link): new function that
2914 can't fail due to OOM
2916 * dbus/dbus-message.c (_dbus_message_loader_pop_message_link):
2917 new function pops a message together with a list link
2920 * dbus/dbus-transport-unix.c (queue_messages): use new link-based
2921 message queuing functions to avoid needing to alloc memory
2923 2003-03-16 Havoc Pennington <hp@pobox.com>
2925 Oops - test code was only testing failure of around 30 of the
2926 mallocs in the test path, but it turns out there are 500+
2927 mallocs. I believe this was due to misguided linking setup such
2928 that there was one copy of dbus_malloc etc. in the daemon and one
2929 in the shared lib, and only daemon mallocs were tested. In any
2930 case, the test case now tests all 500+ mallocs, and doesn't pass
2931 yet, though there are lots of fixes in this patch.
2933 * dbus/dbus-connection.c (dbus_connection_dispatch_message): fix
2934 this so that it doesn't need to allocate memory, since it
2935 has no way of indicating failure due to OOM (and would be
2936 annoying if it did).
2938 * dbus/dbus-list.c (_dbus_list_pop_first_link): new function
2940 * bus/Makefile.am: rearrange to create two self-contained
2941 libraries, to avoid having libraries with overlapping symbols.
2942 that was resulting in weirdness, e.g. I'm pretty sure there
2943 were two copies of global static variables.
2945 * dbus/dbus-internals.c: move the malloc debug stuff to
2948 * dbus/dbus-list.c (free_link): free list mempool if it becomes
2951 * dbus/dbus-memory.c (_dbus_disable_mem_pools): new function
2953 * dbus/dbus-address.c (dbus_parse_address): free list nodes
2956 * bus/dispatch.c (bus_dispatch_add_connection): free
2957 message_handler_slot when no longer using it, so
2958 memory leak checkers are happy for the test suite.
2960 * dbus/dbus-server-debug-pipe.c (debug_finalize): free server name
2962 * bus/bus.c (new_connection_callback): disconnect in here if
2963 bus_connections_setup_connection fails.
2965 * bus/connection.c (bus_connections_unref): fix to free the
2967 (bus_connections_setup_connection): if this fails, don't
2968 disconnect the connection, just be sure there are no side
2971 * dbus/dbus-string.c (undo_alignment): unbreak this
2973 * dbus/dbus-auth.c (_dbus_auth_unref): free some stuff we were
2975 (_dbus_auth_new): fix the order in which we free strings
2978 * bus/connection.c (bus_connection_disconnected): fix to
2979 not send ServiceDeleted multiple times in case of memory
2982 * dbus/dbus-bus.c (dbus_bus_get_base_service): new function to
2983 get the base service name
2984 (dbus_bus_register_client): don't return base service name,
2985 instead store it on the DBusConnection and have an accessor
2987 (dbus_bus_register_client): rename dbus_bus_register()
2989 * bus/dispatch.c (check_hello_message): verify that other
2990 connections on the bus also got the correct results, not
2991 just the one sending hello
2993 2003-03-15 Havoc Pennington <hp@pobox.com>
2995 Make it pass the Hello handling test including all OOM codepaths.
2996 Now to do other messages...
2998 * bus/services.c (bus_service_remove_owner): fix crash when
2999 removing owner from an empty list of owners
3000 (bus_registry_ensure): don't leave service in the list of
3001 a connection's owned services if we fail to put the service
3004 * bus/connection.c (bus_connection_preallocate_oom_error): set
3005 error flag on the OOM error.
3007 * dbus/dbus-connection.c (_dbus_connection_new_for_transport):
3008 handle _dbus_transport_set_connection failure
3010 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_fd): modify
3011 to create watches up front and simply enable/disable them as
3013 (unix_connection_set): this can now fail on OOM
3015 * dbus/dbus-timeout.c, dbus/dbus-watch.c: add concept
3016 of enabling/disabling a watch or timeout.
3018 * bus/loop.c (bus_loop_iterate): don't touch disabled
3021 * glib/dbus-gmain.c: adapt to enable/disable watches and timeouts
3023 2003-03-15 Havoc Pennington <hp@pobox.com>
3025 * bus/dispatch.c (bus_dispatch_test): OK, now finally actually
3026 write useful test code, after all that futzing around ;-)
3028 Test does not yet pass because we can't handle OOM in
3029 _dbus_transport_messages_pending (basically,
3030 dbus_connection_preallocate_send() does not prealloc the write
3031 watch). To fix this, I think we need to add new stuff to
3032 set_watch_functions, namely a SetEnabled function so we can alloc
3033 the watch earlier, then enable it later.
3035 * dbus/Makefile.am (libdbus_convenience_la_SOURCES): move
3036 dbus-memory.c to the convenience lib
3038 * bus/test.c: rename some static functions to keep them clearly
3039 distinct from stuff in connection.c. Handle client disconnection.
3041 2003-03-14 Havoc Pennington <hp@pobox.com>
3043 * bus/dispatch.c (bus_dispatch_test): do test using debug-pipe
3044 transport, tests more of the real codepath. Set up clients
3045 with bus_setup_debug_client.
3047 * bus/test.c (bus_setup_debug_client): function to set up debug
3048 "clients" on the main loop
3050 * dbus/dbus-transport.c (_dbus_transport_open): add debug-pipe
3053 * dbus/dbus-server.c (dbus_server_listen): add debug-pipe
3056 * dbus/dbus-server-debug.c: support a debug server based on pipes
3058 * dbus/dbus-sysdeps.c (_dbus_full_duplex_pipe): new function
3059 (_dbus_close): new function
3061 * configure.in: check for socketpair
3063 2003-03-14 Havoc Pennington <hp@redhat.com>
3065 * dbus/dbus-memory.c: add a "detect buffer overwrites on free"
3068 * dbus/dbus-transport-debug.c: rework this a good bit to be
3069 less complicated. hopefully still works.
3071 * dbus/dbus-server-debug.c (handle_new_client): remove timeout
3074 * glib/dbus-gmain.c (timeout_handler): don't remove timeout
3077 * dbus/dbus-message.c (dbus_message_copy): rename from
3078 dbus_message_new_from_message, fix it up to copy
3079 all the message fields, add test case
3081 * bus/dispatch.c (bus_dispatch_test): add some more test code,
3082 not quite passing yet
3084 2003-03-14 Havoc Pennington <hp@pobox.com>
3086 * bus/loop.c (bus_loop_iterate): add this so we can "run loop
3087 until no work remains" in test code. (the large diff here
3088 is just code movement, no actual changes)
3090 * dbus/dbus-server-debug.c (DEFAULT_INTERVAL): change interval to
3091 1, no point waiting around for test code.
3092 (_dbus_server_debug_accept_transport): unref the timeout
3093 after adding it (right?)
3095 * dbus/dbus-transport-debug.c (DEFAULT_INTERVAL): ditto
3097 2003-03-13 Havoc Pennington <hp@redhat.com>
3099 * dbus/dbus-timeout.c (_dbus_timeout_list_set_functions): handle
3102 * dbus/dbus-watch.c (_dbus_watch_list_set_functions): handle out
3105 * dbus/dbus-connection.h: Make AddWatchFunction and
3106 AddTimeoutFunction return a bool so they can fail on out-of-memory
3108 * bus/bus.c (bus_context_new): set up timeout handlers
3110 * bus/connection.c (bus_connections_setup_connection): set up
3113 * glib/dbus-gmain.c: adapt to the fact that set_functions stuff
3116 * bus/bus.c (bus_context_new): adapt to changes
3118 * bus/connection.c: adapt to changes
3120 * test/watch.c: adapt to DBusWatch changes
3122 * bus/dispatch.c (bus_dispatch_test): started adding this but
3125 2003-03-14 Anders Carlsson <andersca@codefactory.se>
3127 * bus/dispatch.c (send_service_nonexistent_error): Fix typo.
3129 2003-03-13 Havoc Pennington <hp@pobox.com>
3131 * bus/test.c, bus/test.h, bus/Makefile.am, bus/test-main.c:
3132 set up a test framework as for the library
3134 2003-03-12 Havoc Pennington <hp@pobox.com>
3136 Throughout: purge global variables, introduce BusActivation,
3137 BusConnections, BusRegistry, etc. objects instead.
3139 * bus/bus.h, bus/bus.c: introduce BusContext as a global
3142 * test/Makefile.am (TEST_BINARIES): disable bus-test for now,
3143 going to redo this a bit differently I think
3145 2003-03-12 Havoc Pennington <hp@redhat.com>
3147 Mega-patch that gets the message bus daemon initially handling
3148 out-of-memory. Work still needed. Also lots of random
3149 moving stuff to DBusError instead of ResultCode.
3151 * dbus/dbus-list.c (_dbus_list_length_is_one): new function
3153 * dbus/dbus-connection.c
3154 (dbus_connection_send_with_reply_and_block): use DBusError
3156 * dbus/dbus-bus.c: adapt to API changes, make it use DBusError not
3159 * dbus/dbus-connection.c (dbus_connection_send): drop the result
3160 code here, as the only failure possible is OOM.
3162 * bus/connection.c (bus_connection_disconnect):
3163 rename bus_connection_disconnected as it's a notification only
3165 * bus/driver.c (bus_driver_handle_acquire_service): don't free
3166 "name" on get_args failure, should be done by get_args;
3167 don't disconnect client for bad args, just return an error.
3168 (bus_driver_handle_service_exists): ditto
3170 * bus/services.c (bus_services_list): NULL-terminate returned array
3172 * bus/driver.c (bus_driver_send_service_lost)
3173 (bus_driver_send_service_acquired): send messages from driver to a
3174 specific client to the client's unique name, not to the broadcast
3177 * dbus/dbus-message.c (decode_header_data): reject messages that
3178 contain no name field
3179 (_dbus_message_get_client_serial): rename to
3180 dbus_message_get_serial and make public
3181 (_dbus_message_set_serial): rename from set_client_serial
3182 (_dbus_message_set_reply_serial): make public
3183 (_dbus_message_get_reply_serial): make public
3185 * bus/connection.c (bus_connection_foreach): allow stopping
3186 iteration by returning FALSE from foreach function.
3188 * dbus/dbus-connection.c (dbus_connection_send_preallocated)
3189 (dbus_connection_free_preallocated_send)
3190 (dbus_connection_preallocate_send): new API for sending a message
3191 without possibility of malloc failure.
3192 (dbus_connection_send_message): rename to just
3193 dbus_connection_send (and same for whole function family)
3195 * dbus/dbus-errors.c (dbus_error_free): make this reinit the error
3197 * dbus/dbus-sysdeps.c (_dbus_exit): new function
3199 * bus/activation.c: handle/return errors
3201 * dbus/dbus-errors.h: add more DBUS_ERROR #define
3203 * dbus/dbus-sysdeps.c (_dbus_directory_open) (_dbus_file_get_contents)
3204 (_dbus_directory_get_next_file): use DBusError instead of DBusResultCode
3205 (_dbus_result_from_errno): move to this file
3207 2003-03-10 Anders Carlsson <andersca@codefactory.se>
3209 * dbus/dbus-marshal.c:
3210 (_dbus_marshal_set_string):
3211 Take a length argument so we can marshal the correct string
3214 (_dbus_marshal_dict), (_dbus_demarshal_dict),
3215 (_dbus_marshal_get_arg_end_pos), (_dbus_marshal_validate_arg),
3216 (_dbus_marshal_test):
3217 * dbus/dbus-marshal.h:
3218 Add support for marshalling and demarshalling dicts.
3220 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
3221 Add support for TYPE DICT.
3223 * dbus/dbus-message.c: (set_string_field):
3224 Adjust header padding.
3226 (dbus_message_append_args_valist), (dbus_message_append_dict),
3227 (dbus_message_get_args_valist), (dbus_message_iter_get_arg_type),
3228 (dbus_message_iter_get_dict), (_dbus_message_loader_return_buffer),
3229 (check_message_handling), (check_have_valid_message):
3230 * dbus/dbus-message.h:
3231 Add functions for setting and getting dicts.
3233 * dbus/dbus-protocol.h:
3239 * doc/dbus-specification.sgml:
3240 Add information about how dicts are marshalled.
3242 * test/data/invalid-messages/dict-with-nil-value.message:
3243 * test/data/invalid-messages/too-short-dict.message:
3244 * test/data/valid-messages/dict-simple.message:
3245 * test/data/valid-messages/dict.message:
3246 Add sample messages containing dicts.
3248 2003-03-08 Anders Carlsson <andersca@codefactory.se>
3250 * dbus/dbus-dict.h: Add DBUS_END_DECLS.
3252 2003-03-07 Anders Carlsson <andersca@codefactory.se>
3255 * dbus/dbus-dict.c: (dbus_dict_entry_free), (dbus_dict_new),
3256 (dbus_dict_get_keys), (insert_entry), (dbus_dict_set_boolean),
3257 (dbus_dict_set_int32), (dbus_dict_set_uint32),
3258 (dbus_dict_set_double), (dbus_dict_set_string),
3259 (dbus_dict_set_boolean_array), (dbus_dict_set_int32_array),
3260 (dbus_dict_set_uint32_array), (dbus_dict_set_double_array),
3261 (dbus_dict_set_string_array), (_dbus_dict_test):
3263 Fix according to comments from Havoc.
3265 2003-03-06 Michael Meeks <michael@server.home>
3267 * configure.in: if we don't have kde-config, disable have_qt.
3269 2003-03-07 Anders Carlsson <andersca@codefactory.se>
3274 * dbus/dbus-dict.c: (dbus_dict_entry_free), (dbus_dict_new),
3275 (dbus_dict_ref), (dbus_dict_unref), (dbus_dict_contains),
3276 (dbus_dict_remove), (dbus_dict_get_value_type),
3277 (dbus_dict_get_keys), (dbus_dict_put_boolean),
3278 (dbus_dict_put_int32), (dbus_dict_put_uint32),
3279 (dbus_dict_put_double), (dbus_dict_put_string),
3280 (dbus_dict_put_boolean_array), (dbus_dict_put_int32_array),
3281 (dbus_dict_put_uint32_array), (dbus_dict_put_double_array),
3282 (dbus_dict_put_string_array), (dbus_dict_get_boolean),
3283 (dbus_dict_get_int32), (dbus_dict_get_uint32),
3284 (dbus_dict_get_double), (dbus_dict_get_string),
3285 (dbus_dict_get_boolean_array), (dbus_dict_get_int32_array),
3286 (dbus_dict_get_uint32_array), (dbus_dict_get_double_array),
3287 (dbus_dict_get_string_array), (_dbus_dict_test):
3289 Add DBusDict implementation
3291 * dbus/dbus-test.c: (dbus_internal_do_not_use_run_tests):
3295 2003-03-04 Havoc Pennington <hp@pobox.com>
3297 * test/data/auth/*: adapt to changes
3299 * dbus/dbus-auth-script.c (_dbus_auth_script_run): add
3300 USERID_BASE64 and change USERNAME_BASE64 to put in username not
3303 * dbus/dbus-keyring.c (_dbus_keyring_validate_context): prevent
3304 more stuff from being in a context name, to make the protocol
3305 simpler to deal with
3307 * dbus/dbus-errors.c (dbus_error_has_name): new function
3308 (dbus_error_is_set): new function
3310 * dbus/dbus-auth.c: replace DBUS_STUPID_TEST_MECH auth
3311 with DBUS_COOKIE_SHA1, implement DBUS_COOKIE_SHA1
3313 * dbus/dbus-connection.c (dbus_connection_flush): also read
3314 messages during a flush operation
3316 * dbus/Makefile.am: remove dbus-md5 since it isn't currently used.
3318 2003-03-05 Anders Carlsson <andersca@codefactory.se>
3320 * configure.in: Check for gethostbyname on Solaris.
3322 * dbus/dbus-transport.c: (_dbus_transport_open):
3323 Remove duplicate "tcp" entry.
3325 * doc/dbus-specification.sgml:
3326 Clarify some things.
3328 2003-03-05 Anders Carlsson <andersca@codefactory.se>
3330 * dbus/dbus-auth.c: (send_rejected), (process_test_subdir):
3331 * dbus/dbus-keyring.c: (_dbus_keyring_new_homedir),
3332 (_dbus_keyring_test):
3333 * dbus/dbus-md5.c: (_dbus_md5_compute):
3334 * dbus/dbus-sha.c: (_dbus_sha_compute):
3337 2003-03-05 Anders Carlsson <andersca@codefactory.se>
3339 * README: Add some things.
3341 2003-03-04 Anders Carlsson <andersca@codefactory.se>
3343 * dbus/dbus-message.c (dbus_message_append_args_valist): Add a break;
3344 after case DBUS_TYPE_BOOELAN.
3346 2003-03-02 Havoc Pennington <hp@pobox.com>
3348 * test/break-loader.c (randomly_set_extreme_ints): add test that
3349 sets really huge and small integers
3351 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): add check
3352 that length of boolean array fits in the string, and that
3353 string has room for boolean value in single-bool case.
3355 * dbus/dbus-message-builder.c (_dbus_message_data_load): add
3356 optional value to "ALIGN" command which is what to fill the
3359 * test/data/valid-messages/no-padding.message: add regression
3360 test for the message padding problem
3362 2003-03-02 Havoc Pennington <hp@pobox.com>
3364 * dbus/dbus-message.c (decode_header_data): fix to always init
3365 message_padding, from Benjamin Dauvergne
3367 2003-03-02 Havoc Pennington <hp@pobox.com>
3373 2003-03-01 Joe Shaw <joe@assbarn.com>
3375 * configure.in: Check for "struct cmsgcred" and try to access its
3376 members for BSD-like unices.
3378 * dbus/dbus-sysdeps.c (read_credentials_byte): Fold this back into
3379 _dbus_read_credentials_unix_socket().
3380 (_dbus_read_credentials_unix_socket): Use recvmsg() instead of
3381 read() for reading the credential byte off the unix socket. Use
3382 struct cmsgcred on systems that support it.
3384 2003-02-27 Alexander Larsson <alexl@redhat.com>
3388 Make gthreads-2.0 dependency optional. Don't build thread test if
3391 2003-02-27 Havoc Pennington <hp@pobox.com>
3393 * dbus/dbus-connection.c
3394 (dbus_connection_send_message_with_reply_and_block): fix doh!
3395 doh! doh! bug that resulted in never removing a reply from the
3396 queue, no wonder we called get_reply_serial so much ;-)
3398 * dbus/dbus-message.c (struct DBusMessage): cache reply serial
3399 and client serial instead of demarshaling them every time
3401 2003-02-27 Havoc Pennington <hp@pobox.com>
3403 * dbus/dbus-marshal.c (_dbus_demarshal_int32): rewrite to be much
3404 more inlined, using dbus-string-private.h, speeds things up
3407 * dbus/dbus-string.c (_dbus_string_free): apply align offset
3408 when freeing the string
3409 (_dbus_string_steal_data): fix for align offset
3410 (undo_alignment): new function
3412 2003-02-26 Havoc Pennington <hp@redhat.com>
3414 All kinds of audit fixes from Owen, plus initial attempt to
3415 handle unaligned memory returned from malloc.
3417 * dbus/dbus-string.c (_dbus_string_init): clamp max length to
3418 leave room for align_offset and nul byte
3419 (fixup_alignment): function to track an align_offset and
3420 ensure real->str is aligned
3421 (DBUS_GENERIC_STRING_PREAMBLE): len must be less than allocated,
3422 to allow a nul byte plus align offset
3423 (_dbus_string_lock): fix overflow issue
3424 (_dbus_string_init_const_len): add assertions on sanity of len,
3425 assign allocated to be ALLOCATION_PADDING larger than len
3426 (set_length): fixup the overflow handling
3427 (_dbus_string_get_data_len): fix overflow in assertion
3428 (open_gap): detect overflow in size of gap to be opened
3429 (_dbus_string_lengthen): add overflow check
3430 (_dbus_string_align_length): fix overflow with _DBUS_ALIGN_VALUE
3431 (_dbus_string_append): add overflow check
3432 (_dbus_string_append_unichar): overflow
3433 (_dbus_string_delete): fix overflow in assertion
3434 (_dbus_string_copy_len): overflow in assertion
3435 (_dbus_string_replace_len): overflows in assertions
3436 (_dbus_string_find): change to implement in terms of
3437 _dbus_string_find_to
3438 (_dbus_string_find_to): assorted fixage
3439 (_dbus_string_equal_c_str): assert c_str != NULL,
3440 fix logic so the function works
3441 (_dbus_string_ends_with_c_str): fix overflow thingy
3442 (_dbus_string_base64_encode): overflow fix
3443 (_dbus_string_validate_ascii): overflow
3444 (_dbus_string_validate_nul): overflow
3446 2003-02-26 Havoc Pennington <hp@redhat.com>
3448 * dbus/dbus-marshal.c (_dbus_marshal_test): fix to work with DISABLE_ASSERTS
3450 2003-02-26 Alexander Larsson <alexl@redhat.com>
3453 Set DBUS_GLIB_THREADS_LIBS for apps using gthread-2.0
3455 * dbus/dbus-connection.c:
3456 * dbus/dbus-connection.h:
3457 Fix _dbus_connection_acquire_io_path and _dbus_connection_acquire_dispatch.
3458 Add dbus_connection_set_wakeup_main_function and use it when queueing
3459 incoming and outgoing messages.
3462 * dbus/dbus-dataslot.c:
3463 Threadsafe usage of DBusDataSlotAllocator
3465 * dbus/dbus-message.c: (dbus_message_get_args_iter):
3468 * dbus/dbus-server-unix.c:
3471 * glib/dbus-gmain.c:
3472 Implement the new wakeup functions for glib.
3475 * glib/test-thread-client.c:
3476 * glib/test-thread-server.c:
3477 * glib/test-thread.h:
3478 Initial cut at some thread test code. Not really done yet.
3480 2003-02-26 Havoc Pennington <hp@pobox.com>
3482 * dbus/dbus-connection.c
3483 (dbus_connection_send_message_with_reply_and_block): fix crash
3484 where we ref'd the outgoing message instead of the returned reply
3486 * dbus/dbus-transport-unix.c (do_authentication): check read watch
3487 at the end of this function, so if we didn't need to read for
3488 authentication, we reinstall it for receiving messages
3490 * dbus/dbus-message.c (dbus_message_new_reply): allow replies to
3491 a NULL sender for peer-to-peer case
3493 * dbus/dbus-transport-unix.c (check_read_watch): handle
3494 !authenticated case correctly
3496 * glib/dbus-gmain.c: add support for DBusServer
3498 * dbus/dbus-server.c: add data slot support
3500 * glib/dbus-gmain.c (dbus_connection_setup_with_g_main): check
3501 return values and handle errors
3503 * dbus/dbus-dataslot.c: factor out the data slot stuff from
3506 * Doxyfile.in (INPUT): add glib subdir
3508 * glib/dbus-gmain.c (dbus_connection_setup_with_g_main): rename
3509 setup_with_g_main instead of hookup_with_g_main; write docs
3511 2003-02-24 Anders Carlsson <andersca@codefactory.se>
3513 * dbus/dbus-marshal.c: (_dbus_marshal_validate_arg):
3514 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
3515 * dbus/dbus-message.c: (dbus_message_append_boolean),
3516 (dbus_message_append_boolean_array),
3517 (dbus_message_get_args_valist), (_dbus_message_test):
3518 * dbus/dbus-message.h:
3519 * doc/dbus-specification.sgml:
3520 Various fixes as pointed out by Havoc.
3522 * test/data/invalid-messages/bad-boolean-array.message:
3523 * test/data/invalid-messages/bad-boolean.message:
3524 Add invalid boolean value test cases.
3526 2003-02-24 Anders Carlsson <andersca@codefactory.se>
3528 * dbus/dbus-internals.c: (_dbus_type_to_string):
3529 * dbus/dbus-marshal.c: (_dbus_marshal_get_arg_end_pos),
3530 (_dbus_marshal_validate_arg):
3531 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
3532 * dbus/dbus-message.c: (dbus_message_append_args_valist),
3533 (dbus_message_append_boolean), (dbus_message_append_boolean_array),
3534 (dbus_message_get_args_valist), (dbus_message_iter_get_boolean),
3535 (dbus_message_iter_get_int32), (dbus_message_iter_get_uint32),
3536 (dbus_message_iter_get_double),
3537 (dbus_message_iter_get_boolean_array), (message_iter_test):
3538 * dbus/dbus-message.h:
3539 * dbus/dbus-protocol.h:
3540 * doc/dbus-specification.sgml:
3541 * test/data/valid-messages/lots-of-arguments.message:
3542 Add support for boolean and boolean array types.
3544 2003-02-23 Havoc Pennington <hp@pobox.com>
3546 * dbus/dbus-keyring.c: finish most of this implementation and
3549 * dbus/dbus-errors.c (dbus_set_error_const, dbus_set_error): make
3550 these barf if the error isn't cleared to NULL
3552 * dbus/dbus-sysdeps.c (_dbus_delete_file): set error on failure
3553 (_dbus_create_directory): new function
3555 * dbus/dbus-errors.c (dbus_set_error): fix warning
3557 * dbus/dbus-string.c (_dbus_string_hex_encode): new function
3558 (_dbus_string_hex_decode): new function
3559 (test_hex_roundtrip): test code
3561 * dbus/dbus-sha.c (_dbus_sha_compute): use dbus_string_hex_encode
3563 * dbus/dbus-md5.c (_dbus_md5_compute): use dbus_string_hex_encode
3565 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): make this use
3566 the save-to-temp/rename trick to atomically write the new file
3567 (_dbus_string_parse_uint): new function
3569 2003-02-22 Havoc Pennington <hp@pobox.com>
3571 * test/Makefile.am (dist-hook): fix dist for test/data/sha-1
3573 2003-02-22 Havoc Pennington <hp@pobox.com>
3575 * dbus/dbus-message.c (dbus_message_iter_get_string_array):
3576 (dbus_message_iter_get_byte_array): Fix up doxygen warnings
3578 * dbus/dbus-sha.c: add implementation of SHA-1 algorithm
3580 * dbus/test/data/sha-1: add US government test suite for SHA-1
3582 2003-02-21 Anders Carlsson <andersca@codefactory.se>
3584 * dbus/dbus-marshal.c: (_dbus_demarshal_string_array):
3585 Make string arrays NULL-terminated.
3587 * dbus/dbus-memory.c: (dbus_free_string_array):
3588 * dbus/dbus-memory.h:
3589 New function for freeing NULL-terminated string arrays.
3591 * dbus/dbus-message-builder.c: (append_quoted_string),
3592 (_dbus_message_data_load):
3593 Add support for array types.
3595 * dbus/dbus-message.c: (check_message_handling):
3596 Add more types as test cases.
3598 * dbus/dbus-sysdeps.c: (_dbus_string_parse_int),
3599 (_dbus_string_parse_double):
3600 Add the start offset to the end offset.
3602 * test/data/valid-messages/lots-of-arguments.message:
3603 New test message with lots of arguments.
3605 2003-02-21 Anders Carlsson <andersca@codefactory.se>
3607 * dbus/dbus-message.c: (dbus_message_append_nil),
3608 (dbus_message_append_int32), (dbus_message_append_uint32),
3609 (dbus_message_append_double), (dbus_message_append_string),
3610 (dbus_message_append_int32_array),
3611 (dbus_message_append_uint32_array),
3612 (dbus_message_append_double_array),
3613 (dbus_message_append_byte_array),
3614 (dbus_message_append_string_array):
3615 Fix all out-of-memory handling in these functions.
3617 2003-02-21 Anders Carlsson <andersca@codefactory.se>
3619 * dbus/dbus-message.c: (dbus_message_append_nil):
3622 2003-02-21 Anders Carlsson <andersca@codefactory.se>
3624 * dbus/dbus-message.c: (dbus_message_append_args_valist),
3625 (dbus_message_append_nil), (dbus_message_append_int32_array),
3626 (dbus_message_append_uint32_array),
3627 (dbus_message_append_double_array),
3628 (dbus_message_append_byte_array),
3629 (dbus_message_append_string_array), (dbus_message_get_args_valist),
3630 (dbus_message_iter_get_int32_array),
3631 (dbus_message_iter_get_uint32_array),
3632 (dbus_message_iter_get_double_array),
3633 (dbus_message_iter_get_byte_array),
3634 (dbus_message_iter_get_string_array):
3636 * dbus/dbus-message.h:
3637 Add functions for appending and getting arrays.
3639 2003-02-21 Anders Carlsson <andersca@codefactory.se>
3641 * dbus/dbus-mempool.c (_dbus_mem_pool_new): Make the
3642 element size at least 8 bytes, fixes mempool tests on
3645 2003-02-20 Alexander Larsson <alexl@redhat.com>
3647 * dbus/dbus-transport-unix.c (unix_do_iteration):
3648 Unlock the connection mutex during a blocking select call.
3649 Add todo about how we need a way to wake up the select.
3651 * dbus/dbus-connection-internal.h:
3652 * dbus/dbus-connection.c:
3653 Add _dbus_connection_lock and _dbus_connection_unlock.
3655 2003-02-19 Havoc Pennington <hp@pobox.com>
3657 * Doxyfile.in (PREDEFINED): put DOXYGEN_SHOULD_SKIP_THIS in
3658 Doxyfile.in, not Doxyfile
3660 * dbus/dbus-keyring.c: do some hacking on this
3662 * dbus/dbus-sysdeps.c (_dbus_delete_file): new
3664 * dbus/dbus-errors.c (dbus_set_error_const): do not call
3666 (dbus_set_error): remove dbus_error_init, check for message ==
3667 NULL *before* we sprintf into it, and add @todo about including
3668 system headers in this file
3670 * dbus/dbus-sysdeps.c (_dbus_create_file_exclusively): new
3672 * dbus/dbus-errors.h (DBUS_ERROR_FAILED): add
3674 * dbus/dbus-sysdeps.c (get_user_info): break this function out to
3675 get various bits of user information based on either username
3677 (_dbus_homedir_from_username): new function
3679 2003-02-19 Anders Carlsson <andersca@codefactory.se>
3682 Add check for nonposix getpwnam_r
3684 * dbus/dbus-mempool.c: (_dbus_mem_pool_new):
3685 Align the pool element size to a sizeof (void *) boundary.
3687 * dbus/dbus-sysdeps.c: (_dbus_setenv), (_dbus_connect_unix_socket),
3688 (_dbus_listen_unix_socket), (_dbus_credentials_from_username):
3689 General Solaris fixes.
3691 * test/data/valid-messages/simplest-manual.message:
3692 Explicitly state that we want little-endian packing.
3694 2003-02-19 Mikael Hallendal <micke@codefactory.se>
3696 * dbus/dbus-server.c (dbus_server_listen): Support tcp: addresses.
3698 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_tcp_socket):
3699 Added to create a transport connecting using a tcp/ip socket.
3701 * dbus/dbus-sysdeps.c (_dbus_connect_tcp_socket): Added to connect
3702 to a tcp socket at given host and port.
3703 (_dbus_listen_tcp_socket): added to listen on tcp socket for given
3706 * dbus/dbus-server.c (dbus_server_listen): Support tcp: addresses.
3708 * dbus/dbus-server-unix.c (_dbus_server_new_for_tcp_socket):
3709 Added to create a server listening on a TCP/IP socket.
3711 2003-02-19 Havoc Pennington <hp@pobox.com>
3713 Throughout: mop up all the Doxygen warnings and undocumented
3716 * dbus/dbus-sysdeps.c (do_exec): do not use execvp, we don't want
3717 to search any paths.
3719 * dbus/dbus-threads.c: move global mutex initializers to
3720 dbus-internals.h, multiple prototypes was confusing doxygen
3721 besides being kind of ugly
3723 * Doxyfile (PREDEFINED): have Doxygen define
3724 DOXYGEN_SHOULD_SKIP_THIS so we can exclude things from
3725 docs with #ifndef DOXYGEN_SHOULD_SKIP_THIS
3726 (do not abuse the feature! it's for stuff like the autogenerated
3727 macros in dbus-md5.c, not just for things you don't feel like
3730 2003-02-18 Havoc Pennington <hp@pobox.com>
3732 * dbus/dbus-string.c (_dbus_string_zero): new function
3734 * dbus/dbus-md5.c: include MD5 implementation by L. Peter Deutsch,
3735 wrap it in some dbus-friendly API
3737 * dbus/dbus-types.h: add 16-bit types
3739 2003-02-18 Joe Shaw <joe@assbarn.com>
3741 * dbus/dbus-auth.c (handle_server_data_stupid_test_mech): Just get
3742 credentials from our currently running process.
3743 (get_word): Fix a buglet where we were copying the entire length
3744 instead of relative to our position.
3746 * dbus/dbus-hash.c (_dbus_hash_test): Don't try to allocate the
3747 keys on the stack... it's 640k of data.
3749 * dbus/dbus-sysdeps.c (_dbus_read_credentials_unix_socket): Always
3750 read the credentials byte off the socket, even if we don't have
3752 (_dbus_poll): Implement poll() using select() for systems which
3755 * glib/test-dbus-glib.c (main): Print out an error if no
3756 parameters are given.
3758 * test/data/auth/fallback.auth-script: Added. Tests that a client
3759 can fallback to a secondary auth mechanism if the first fails.
3761 2003-02-18 Havoc Pennington <hp@pobox.com>
3765 2003-02-17 Havoc Pennington <hp@pobox.com>
3767 * doc/dbus-specification.sgml: lots of cosmetic
3768 cleanups/rearrangement, add assorted FIXME, change DBUS_ADDRESS
3769 env variable to DBUS_BUS_ADDRESS, s/client/application/,
3770 s/server/bus/ (except in authentication section). Add a section
3771 "Message Bus Message Routing"
3773 2003-02-17 Anders Carlsson <andersca@codefactory.se.>
3779 2003-02-17 Anders Carlsson <andersca@codefactory.se>
3781 * doc/dbus-specification.sgml:
3782 Specification updates.
3784 2003-02-17 Anders Carlsson <andersca@codefactory.se>
3786 * bus/activation.c: (bus_activation_init), (child_setup),
3787 (bus_activation_activate_service):
3789 * bus/main.c: (main):
3790 Set DBUS_ADDRESS environment variable.
3792 * dbus/dbus-errors.c: (dbus_set_error):
3793 Don't use va_copy since that's a C99 feature.
3795 * dbus/dbus-sysdeps.c: (_dbus_setenv), (do_exec),
3796 (_dbus_spawn_async):
3797 * dbus/dbus-sysdeps.h:
3798 Add child_setup_func to _dbus_spawn_async.
3800 * doc/dbus-specification.sgml:
3801 Update specification.
3803 * test/spawn-test.c: (setup_func), (main):
3806 2003-02-17 Alexander Larsson <alexl@redhat.com>
3808 * dbus/dbus-connection.c (_dbus_connection_handler_destroyed_locked):
3811 2003-02-17 Anders Carlsson <andersca@codefactory.se>
3815 * doc/dbus-test-plan.sgml:
3816 Add test plan document.
3821 2003-02-17 Anders Carlsson <andersca@codefactory.se>
3823 * dbus/dbus-message.c: (decode_header_data),
3824 (_dbus_message_loader_return_buffer):
3825 Set the header padding amount when loading a message.
3827 2003-02-16 Anders Carlsson <andersca@codefactory.se>
3829 * bus/dispatch.c: (send_one_message):
3830 Only send broadcast messages to registered connections.
3832 * dbus/dbus-message.c: (dbus_message_name_is):
3833 * dbus/dbus-message.h:
3834 New convenience function.
3836 * dbus/dbus-transport-debug.c: (do_reading):
3837 Only dispatch one message per run.
3840 * test/bus-test.c: (new_connection_callback), (die),
3841 (test_hello_client1_handler), (test_hello_client2_handler),
3842 (test_hello_replies), (main):
3844 * test/bus-test-loop.[ch]:
3847 2003-02-16 Havoc Pennington <hp@pobox.com>
3849 * dbus/dbus-connection.c (dbus_connection_dispatch_message): fix
3850 backward conditional
3852 2003-02-16 Alexander Larsson <alexl@redhat.com>
3854 * dbus/dbus-connection.c:
3855 Implement sent_message_with_reply. (with_reply_and block is still
3857 Made dispatch_message not lose message if OOM.
3859 * dbus/dbus-errors.h:
3860 Add NoReply error (for reply timeouts).
3862 2003-02-16 Alexander Larsson <alexl@redhat.com>
3864 * dbus/dbus-hash.c (_dbus_hash_table_unref):
3865 Actually free keys and values when destroying hashtable.
3867 2003-02-16 Anders Carlsson <andersca@codefactory.se>
3869 * dbus/dbus-auth.c: (client_try_next_mechanism):
3872 * dbus/dbus-threads.c: (dbus_condvar_wait_timeout):
3873 Return TRUE if there's no thread implementation around.
3875 * glib/dbus-gmain.c: (free_source),
3876 (dbus_connection_hookup_with_g_main):
3877 Make sure to remove the GSource when the connection is finalized.
3879 2003-02-16 Anders Carlsson <andersca@codefactory.se>
3881 * bus/dispatch.c: (bus_dispatch_message_handler):
3882 * dbus/dbus-errors.h:
3883 Return an error if someone tries to send a message to a service
3886 2003-02-16 Anders Carlsson <andersca@codefactory.se>
3888 * bus/activation.c: (load_directory), (bus_activation_init),
3889 (bus_activation_activate_service):
3892 (bus_driver_handle_activate_service), (bus_driver_handle_message):
3893 More work on the activation handling.
3895 * dbus/dbus-errors.h:
3896 Add some error messages
3898 * dbus/dbus-message.c: (dbus_message_new_error_reply):
3899 * dbus/dbus-message.h:
3900 New function that creates an error message.
3902 * dbus/dbus-protocol.h:
3903 Add ACTIVATE_SERVER message.
3905 * dbus/dbus-server-unix.c: (unix_handle_watch),
3906 (_dbus_server_new_for_domain_socket):
3907 Call _dbus_fd_set_close_on_exec.
3909 * dbus/dbus-sysdeps.c: (make_pipe), (do_exec),
3910 (_dbus_spawn_async), (_dbus_disable_sigpipe),
3911 (_dbus_fd_set_close_on_exec):
3912 * dbus/dbus-sysdeps.h:
3913 Add _dbus_fd_set_close_on exec function. Also add function that checks
3914 that all open fds are set to close-on-exec and warns otherwise.
3916 * dbus/dbus-transport-unix.c:
3917 (_dbus_transport_new_for_domain_socket):
3918 Call _dbus_fd_set_close_on_exec.
3920 2003-02-16 Havoc Pennington <hp@pobox.com>
3922 * dbus/dbus-connection.c (dbus_connection_set_change_sigpipe):
3923 allow people to avoid setting SIGPIPE to SIG_IGN
3924 (_dbus_connection_new_for_transport): disable SIGPIPE unless
3925 we've been asked not to
3927 2003-02-15 Anders Carlsson <andersca@codefactory.se>
3929 * dbus/dbus-list.c: (_dbus_list_append_link),
3930 (_dbus_list_prepend_link):
3931 * dbus/dbus-memory.c: (dbus_malloc), (dbus_malloc0),
3935 2003-02-15 Anders Carlsson <andersca@codefactory.se>
3938 * bus/activation.c: (bus_activation_entry_free),
3939 (add_desktop_file_entry), (load_directory), (bus_activation_init):
3941 * bus/main.c: (main):
3942 Add simple activation support, doesn't work yet though.
3944 2003-02-15 Zack Rusin <zack@kde.org>
3946 * qt/dbus-qthread.cpp: small casting fix
3948 2003-02-15 Anders Carlsson <andersca@codefactory.se>
3950 * dbus/dbus-errors.c: (dbus_set_error):
3951 * dbus/dbus-errors.h:
3952 Add a few errors and make dbus_set_error void.
3954 * dbus/dbus-sysdeps.c:
3955 (_dbus_errno_to_string), (close_and_invalidate), (make_pipe),
3956 (write_err_and_exit), (read_ints), (do_exec), (_dbus_spawn_async):
3957 * dbus/dbus-sysdeps.h:
3958 Add _dbus_spawn_async.
3960 * test/spawn-test.c: (main):
3961 Test for _dbus_spawn_async.
3963 2003-02-15 Anders Carlsson <andersca@codefactory.se>
3965 * dbus/dbus-internals.h:
3966 Fix build without tests.
3968 * dbus/dbus-list.c: (alloc_link):
3969 Fix a segfault when a malloc fails.
3971 * dbus/dbus-memory.c: (initialize_malloc_debug), (dbus_malloc),
3972 (dbus_malloc0), (dbus_realloc):
3973 Add support for malloc debugging.
3975 2003-02-15 Alexander Larsson <alexl@redhat.com>
3977 * dbus/dbus-threads.c:
3978 * dbus/dbus-threads.h:
3979 Add condvars. Remove static mutext from API.
3980 Implement static mutexes by initializing them from threads_init.
3982 * glib/dbus-gthread.c:
3983 * qt/dbus-qthread.cpp:
3984 Update with the thread api changes.
3989 Turn StaticMutex into normal mutex + init function.
3990 Export new functions _dbus_list_alloc_link, _dbus_list_free_link,
3991 _dbus_list_append_link, _dbus_list_prepend_link
3994 * dbus/dbus-sysdeps.c:
3995 * dbus/dbus-sysdeps.h:
3996 New type dbus_atomic_t, and new functions _dbus_atomic_inc,
3997 _dbus_atomic_dec. Only slow fallback implementation at the moment.
3999 * dbus/dbus-protocol.h:
4000 Add DBUS_MESSAGE_LOCAL_DISCONNECT define
4002 * dbus/dbus-message.c:
4003 Make ref/unref atomic.
4006 * dbus/dbus-connection-internal.h:
4007 * dbus/dbus-connection.c:
4008 * dbus/dbus-connection.h:
4010 Change _peek to _borrow,_return & _steal_borrowed.
4011 Change disconnect callback to event.
4012 Make dbus_connection_dispatch_messages reentrant.
4014 * dbus/dbus-transport.c:
4015 Don't ref the connection on calls to the transport
4018 * dbus/dbus-message-handler.c:
4021 * glib/dbus-gmain.c:
4022 Don't use peek_message anymore
4025 * test/debug-thread.c:
4026 * test/debug-thread.h:
4027 Simple thread implementation that asserts() on deadlocks in
4028 single-threaded code.
4031 (main) Call debug_threads_init.
4034 Use disconnect message instead of disconnect callback.
4038 Don't call dbus_connection_set_disconnect_function. Instead export
4039 bus_connection_disconnect.
4042 Call bus_connection_disconnect when we get a disconnected message.
4044 2003-02-15 Havoc Pennington <hp@pobox.com>
4046 * dbus/dbus-message.c (dbus_message_new): fool around with the
4049 2003-02-14 Havoc Pennington <hp@pobox.com>
4051 * dbus/dbus-mempool.c: fail if the debug functions so indicate
4053 * dbus/dbus-memory.c: fail if the debug functions indicate we
4056 * dbus/dbus-internals.c (_dbus_set_fail_alloc_counter)
4057 (_dbus_decrement_fail_alloc_counter): debug functions to
4058 simulate memory allocation failures
4060 2003-02-14 Havoc Pennington <hp@pobox.com>
4062 * dbus/dbus-errors.h (struct DBusError): add a word of padding
4065 2003-02-13 Anders Carlsson <andersca@codefactory.se>
4067 * bus/driver.c: (bus_driver_handle_hello):
4069 * bus/services.c: (bus_service_lookup):
4070 Reorder message sending so we get a more sane order.
4072 * test/bus-test.c: (message_handler):
4075 2003-02-13 Anders Carlsson <andersca@codefactory.se>
4077 * bus/driver.c: (bus_driver_send_service_deleted),
4078 (bus_driver_send_service_created), (bus_driver_send_service_lost),
4079 (bus_driver_send_service_acquired), (bus_driver_handle_hello),
4080 (bus_driver_send_welcome_message),
4081 (bus_driver_handle_list_services),
4082 (bus_driver_handle_acquire_service),
4083 (bus_driver_handle_service_exists):
4084 * dbus/dbus-bus.c: (dbus_bus_register_client),
4085 (dbus_bus_acquire_service), (dbus_bus_service_exists):
4086 * dbus/dbus-errors.c: (dbus_result_to_string):
4087 * dbus/dbus-errors.h:
4088 * dbus/dbus-message.c: (dbus_message_append_args),
4089 (dbus_message_append_args_valist), (dbus_message_get_args),
4090 (dbus_message_get_args_valist), (dbus_message_get_args_iter),
4091 (dbus_message_iter_get_arg_type), (dbus_message_iter_get_string),
4092 (dbus_message_iter_get_byte_array),
4093 (dbus_message_iter_get_string_array), (message_iter_test),
4094 (check_message_handling), (_dbus_message_test):
4095 * dbus/dbus-message.h:
4096 * test/bus-test.c: (main):
4097 Change fields to arguments in messages, so that they won't be
4098 confused with header fields.
4100 * glib/test-dbus-glib.c: (main):
4101 Remove append_fields from hello message.
4103 2003-02-13 Anders Carlsson <andersca@codefactory.se>
4105 * dbus/dbus-errors.c:
4106 * dbus/dbus-message.c:
4107 * dbus/dbus-string.c:
4108 Documentation fixes.
4110 2003-02-13 Anders Carlsson <andersca@codefactory.se>
4112 * glib/dbus-gmain.c: (timeout_handler), (add_timeout),
4114 Implement support for timeouts in dbus-glib.
4116 2003-02-13 Anders Carlsson <andersca@codefactory.se>
4118 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
4119 * dbus/dbus-message.c: (process_test_subdir):
4120 * test/break-loader.c: (find_breaks_based_on):
4121 Plug some memory leaks.
4123 2003-02-13 Richard Hult <rhult@codefactory.se>
4125 * bus/main.c: Fix build.
4127 * dbus/dbus-errors.h:
4128 * dbus/dbus-errors.c: Fix copyright for Anders.
4130 2003-02-13 Anders Carlsson <andersca@codefactory.se>
4135 * bus/connection.c: (bus_connection_foreach):
4138 * bus/desktop-file.c: (grow_lines_in_section), (grow_sections),
4139 (unescape_string), (new_section), (parse_section_start),
4140 (parse_key_value), (report_error), (bus_desktop_file_load),
4141 (bus_desktop_file_get_string):
4142 * bus/desktop-file.h:
4143 Use DBusError for error reporting.
4145 * bus/dispatch.c: (send_one_message),
4146 (bus_dispatch_message_handler):
4147 * bus/driver.c: (bus_driver_send_service_deleted),
4148 (bus_driver_send_service_created), (bus_driver_send_service_lost),
4149 (bus_driver_send_service_acquired), (bus_driver_handle_hello),
4150 (bus_driver_send_welcome_message),
4151 (bus_driver_handle_list_services),
4152 (bus_driver_handle_acquire_service),
4153 (bus_driver_handle_service_exists):
4154 * bus/loop.c: (bus_loop_run):
4156 Use BUS_HANDLE_OOM instead of _DBUS_HANDLE_OOM.
4158 * bus/utils.c: (bus_wait_for_memory):
4160 New files with general utility functions.
4162 * dbus/dbus-internals.h:
4163 Remove _DBUS_HANDLE_OOM.
4165 2003-02-13 Anders Carlsson <andersca@codefactory.se>
4167 * dbus/dbus-errors.c: (dbus_result_to_string), (dbus_error_init),
4168 (dbus_error_free), (dbus_set_error_const), (dbus_set_error):
4169 * dbus/dbus-errors.h:
4170 Add DBusError structure.
4172 2003-02-13 Anders Carlsson <andersca@codefactory.se>
4174 * test/data/valid-messages/standard-acquire-service.message:
4175 * test/data/valid-messages/standard-hello.message:
4176 * test/data/valid-messages/standard-list-services.message:
4177 * test/data/valid-messages/standard-service-exists.message:
4178 Add some standard messages.
4180 2003-02-13 Anders Carlsson <andersca@codefactory.se>
4182 * bus/driver.c: (bus_driver_send_welcome_message),
4183 (bus_driver_handle_list_services),
4184 (bus_driver_handle_acquire_service),
4185 (bus_driver_handle_service_exists), (bus_driver_handle_message):
4186 Update for API changes in libdbus.
4188 * dbus/dbus-message.c: (dbus_message_new_reply):
4189 * dbus/dbus-message.h:
4190 Remove the name argument. The spec states that replies shouldn't
4193 2003-02-13 Anders Carlsson <andersca@codefactory.se>
4195 * bus/desktop-file.c: (parse_section_start), (parse_key_value),
4196 (report_error), (bus_desktop_file_load), (lookup_section),
4197 (lookup_line), (bus_desktop_file_get_raw),
4198 (bus_desktop_file_get_string):
4199 * bus/desktop-file.h:
4200 Some fixes, and new functions for getting a key value from a section.
4202 2003-02-13 Havoc Pennington <hp@pobox.com>
4204 * test/data/auth/fail-after-n-attempts.auth-script: new test
4206 * dbus/dbus-auth.c (send_rejected): shutdown_mech() when we
4209 2003-02-13 Havoc Pennington <hp@pobox.com>
4211 * dbus/dbus-auth.c (handle_server_data_external_mech): args to
4212 dbus_credentials_match were backward
4214 * dbus/dbus-auth-script.c (_dbus_auth_script_run): support
4215 NO_CREDENTIALS and ROOT_CREDENTIALS
4217 * dbus/dbus-auth.c (_dbus_auth_do_work): move get_state() routine
4218 into here. Never process more commands after we've reached an
4219 end state; store further data as unused bytes.
4221 * test/data/auth/*: add more auth tests
4223 * dbus/dbus-auth-script.c (_dbus_auth_script_run): support EXPECT
4224 command to match exact string and EXPECT_UNUSED to match unused
4227 * test/Makefile.am (dist-hook): fix to dist all the test stuff
4229 2003-02-12 Havoc Pennington <hp@pobox.com>
4231 * dbus/dbus-string.c (_dbus_string_pop_line): fix to also strip
4232 \r off of popped lines
4234 * dbus/dbus-auth.c (_dbus_auth_test): write code to run auth
4237 * dbus/dbus-auth-script.c (_dbus_auth_script_run): when doing a
4240 2003-02-12 Havoc Pennington <hp@pobox.com>
4242 * dbus/Makefile.am: remove break-loader from the build, since it
4245 * configure.in: add --enable-gcov to turn on coverage profiling
4246 flags and disable optimization
4248 2003-02-10 Havoc Pennington <hp@pobox.com>
4250 * dbus/dbus-auth-script.c, dbus/dbus-auth-script.h: sync
4251 initial cut at test framework for DBusAuth from laptop.
4252 Doesn't quite work yet but it compiles and I need to get
4253 it off the 266mhz laptop. ;-)
4255 * dbus/dbus-server-debug.c (_dbus_server_debug_accept_transport):
4256 fix a memleak in error case
4258 2003-02-12 Anders Carlsson <andersca@codefactory.se>
4261 * bus/desktop-file.c:
4262 * bus/desktop-file.h:
4263 Add a desktop file parser.
4265 2003-02-11 Zack Rusin <zack@kde.org>
4267 * qt/message.[h|cpp]: sample implementation
4268 of the KDE wrapper for DBusMessage
4270 2003-02-09 Zack Rusin <zack@kde.org>
4272 * test/bus-test.c: make_it_compile
4273 * doc/dbus-specification.sgml: minimal semantic fix
4275 2003-02-06 Anders Carlsson <andersca@codefactory.se>
4281 2003-02-06 Anders Carlsson <andersca@codefactory.se>
4284 * dbus/dbus-break-loader.c:
4286 * test/break-loader.c:
4287 Move dbus-break-loader to test/ and rename it to break-loader.
4289 2003-02-02 Havoc Pennington <hp@pobox.com>
4291 * dbus/dbus-keyring.c, dbus/dbus-keyring.h: template files
4292 for code to manage cookies in your home directory
4294 * dbus/dbus-sysdeps.c (_dbus_generate_random_bytes): new function
4296 * dbus/dbus-auth.c (get_state): impose a maximum number of tries
4297 to authenticate, then disconnect the client.
4299 2003-02-03 Alexander Larsson <alexl@redhat.com>
4301 * dbus/dbus-message.c (dbus_message_append_fields):
4304 2003-02-02 Anders Carlsson <andersca@codefactory.se>
4306 * doc/dbus-specification.sgml:
4307 Update address format section.
4309 2003-02-02 Anders Carlsson <andersca@codefactory.se>
4312 * test/bus-test.c: (get_time), (add_timeout), (remove_timeout),
4313 (message_handler), (new_connection_callback), (loop_quit),
4317 2003-02-02 Anders Carlsson <andersca@codefactory.se>
4319 * bus/driver.c: (bus_driver_handle_service_exists):
4320 Simplify the code a bit.
4322 * dbus/dbus-bus.c: (dbus_bus_service_exists):
4325 2003-02-02 Anders Carlsson <andersca@codefactory.se>
4328 Add libdbus-daemon.la and link to it.
4330 2003-02-01 James Willcox <jwillcox@gnome.org>
4332 * bus/driver.c: (bus_driver_handle_own_service):
4333 Actually include the service reply code in the message.
4335 2003-02-02 Anders Carlsson <andersca@codefactory.se>
4337 * bus/driver.c: (bus_driver_handle_service_exists):
4338 Don't unref the incoming message.
4340 2003-02-02 Anders Carlsson <andersca@codefactory.se>
4342 * dbus/dbus.h: Add dbus-address.h and dbus-bus.h
4344 2003-02-02 Anders Carlsson <andersca@codefactory.se>
4346 * dbus/dbus-server.c: (dbus_server_listen):
4347 * dbus/dbus-transport.c: (_dbus_transport_open):
4348 ifdef out the calls to the debug transport and server.
4350 2003-02-02 Alexander Larsson <alexl@redhat.com>
4352 * dbus/dbus-watch.c (dbus_watch_get_flags):
4353 Add note in the docs that ERROR or HANGUP won't be returned
4354 and are assumed always on.
4356 * glib/dbus-gmain.c (add_watch):
4357 Always add IO_ERR | IO_HUP
4359 * dbus/dbus-message.h:
4360 Add semicolon after dbus_message_iter_get_string_array().
4361 Makes qt code build again
4363 2003-02-01 Anders Carlsson <andersca@codefactory.se>
4365 * bus/driver.c: (create_unique_client_name),
4366 (bus_driver_handle_hello):
4367 Don't take a name, just use a numeric id to identify
4371 * dbus/dbus-bus.c: (dbus_bus_register_client),
4372 (dbus_bus_acquire_service), (dbus_bus_service_exists):
4374 Add new convenience functions for communicating with the bus.
4376 * dbus/dbus-message.h:
4378 * dbus/dbus-protocol.h:
4381 2003-02-01 Alexander Larsson <alexl@redhat.com>
4383 * dbus/dbus-message.c (dbus_message_append_fields):
4384 Add some more doc comments.
4386 2003-02-01 Havoc Pennington <hp@pobox.com>
4388 * dbus/dbus-break-loader.c (randomly_modify_length): change
4389 a 4-byte value in the message as if it were a length
4391 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): don't set
4392 execute bit on saved files
4394 2003-02-01 Havoc Pennington <hp@pobox.com>
4396 * dbus/dbus-break-loader.c (main): new program to find messages
4397 that break the loader.
4399 * dbus/dbus-sysdeps.c (_dbus_string_append_uint): new function
4400 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): new function
4402 * dbus/dbus-string.c (_dbus_string_set_byte): new
4404 2003-01-31 Havoc Pennington <hp@pobox.com>
4406 * dbus/dbus-message.c: refactor the test code to be more general,
4407 in preparation for writing a "randomly permute test cases to
4408 try to break the loader" program.
4410 2003-01-31 Havoc Pennington <hp@pobox.com>
4412 * doc/dbus-specification.sgml: work on the specification
4414 * dbus/dbus-message.c (_dbus_message_loader_return_buffer): check
4415 the protocol version of the message.
4417 * dbus/dbus-protocol.h: drop special _REPLY names, the spec
4418 no longer specifies that.
4419 (DBUS_SERVICE_REPLY_SERVICE_EXISTS): fix flags (1/2/4/8 not
4422 * dbus/dbus-marshal.c (_dbus_marshal_get_arg_end_pos): add missing
4423 "break" for DBUS_TYPE_NIL, remove @todo
4425 2003-01-31 Havoc Pennington <hp@pobox.com>
4427 * dbus/dbus-message.c (dbus_message_set_is_error_reply): rename
4428 just set_is_error/get_is_error as this is a commonly-used
4429 function, and write docs.
4431 2003-01-31 Anders Carlsson <andersca@codefactory.se>
4433 * dbus/dbus-address.c: (dbus_address_entry_free):
4434 Free key and value lists.
4436 * dbus/dbus-internals.c: (_dbus_type_to_string):
4437 Add the types we didn't have.
4439 * dbus/dbus-marshal.c: (_dbus_marshal_get_arg_end_pos),
4440 (_dbus_marshal_validate_arg):
4443 * dbus/dbus-message.c: (dbus_message_set_sender):
4444 Remove todo about being able to set sender to NULL.
4446 (dbus_message_set_is_error_reply),
4447 (dbus_message_get_is_error_reply):
4448 * dbus/dbus-message.h:
4451 * dbus/dbus-protocol.h:
4452 Add error reply flag.
4454 * test/data/valid-messages/opposite-endian.message:
4455 Add NIL type to test.
4457 2003-01-31 Havoc Pennington <hp@pobox.com>
4459 * doc/dbus-specification.sgml: fully specify the header. Add
4460 flags and major protocol version, and change header/body len to
4463 * dbus/dbus-message-builder.c (append_saved_length): append length
4466 * dbus/dbus-message.c (dbus_message_create_header): change header
4467 length and body length to unsigned. Add the new fields from the
4469 (_dbus_message_loader_return_buffer): unsigned header/body len
4471 2003-01-30 Havoc Pennington <hp@pobox.com>
4473 * dbus/dbus-auth.c: rework to use only REJECTED, no
4476 * doc/dbus-sasl-profile.txt: drop MECHANISMS and just
4477 use REJECTED, suggested by Mark McLoughlin
4479 2003-01-30 Havoc Pennington <hp@pobox.com>
4481 * dbus/dbus-server.c (dbus_server_listen): @todo about how we need
4482 a better way to report errors here. e.g. "unix address lacks
4483 path" or something. also "no such file" when the path doesn't
4486 * dbus/dbus-address.c (dbus_address_entries_free): add @todo about
4488 (dbus_parse_address): add @todo about documenting address format,
4489 and allowing , and ; to be escaped
4491 2003-01-30 Anders Carlsson <andersca@codefactory.se>
4494 Add dbus-address.[ch]
4496 * dbus/dbus-address.c: (dbus_address_entry_free),
4497 (dbus_address_entries_free), (create_entry),
4498 (dbus_address_entry_get_method), (dbus_address_entry_get_value),
4499 (dbus_parse_address), (_dbus_address_test):
4500 * dbus/dbus-address.h:
4501 New files for dealing with address parsing.
4503 * dbus/dbus-connection.c:
4504 Document timeout functions.
4506 * dbus/dbus-message.c:
4507 Document dbus_message_new_from_message.
4509 * dbus/dbus-server-debug.c:
4512 * dbus/dbus-server.c: (dbus_server_listen):
4513 Parse address and use correct server implementation.
4515 * dbus/dbus-string.c: (_dbus_string_find_to), (_dbus_string_test):
4516 * dbus/dbus-string.h:
4517 New function with test.
4519 * dbus/dbus-test.c: (dbus_internal_symbol_do_not_use_run_tests):
4523 * dbus/dbus-transport-debug.c:
4526 * dbus/dbus-transport.c: (_dbus_transport_open):
4527 Parse address and use correct transport implementation.
4529 2003-01-30 Havoc Pennington <hp@pobox.com>
4531 * dbus/dbus-message.c: use message->byte_order instead of
4532 DBUS_COMPILER_BYTE_ORDER throughout.
4533 (dbus_message_create_header): pad header to align the
4534 start of the body of the message to 8-byte boundary
4536 * dbus/dbus-marshal.h: make all the demarshalers take const
4537 DBusString arguments.
4539 * dbus/dbus-message.c (_dbus_message_loader_return_buffer):
4540 validate message args here, so we don't have to do slow validation
4541 later, and so we catch bad messages as they are incoming. Also add
4542 better checks on header_len and body_len. Also fill in
4545 * dbus/dbus-string.c (_dbus_string_validate_utf8): new (not
4546 implemented properly)
4547 (_dbus_string_validate_nul): new function to check all-nul
4549 * dbus/dbus-marshal.c (_dbus_marshal_get_field_end_pos): rename
4550 get_arg_end_pos and remove all validation
4551 (_dbus_marshal_validate_arg): actually do validation here.
4553 2003-01-29 Havoc Pennington <hp@pobox.com>
4555 * dbus/dbus-message.c (check_message_handling): fix assertion
4556 failure on set_client_serial
4558 2003-01-28 Havoc Pennington <hp@pobox.com>
4560 * dbus/dbus-server-debug.c: Add doc section comments
4562 * dbus/dbus-transport-debug.c: add doc section comments
4564 2003-01-28 Havoc Pennington <hp@redhat.com>
4566 * dbus/dbus-string.c (_dbus_string_base64_decode): append bytes in
4567 the reverse order from how I had it
4568 (_dbus_string_base64_encode): reverse encoding order. I was
4569 basically byteswapping everything during encoding.
4571 2003-01-28 Anders Carlsson <andersca@codefactory.se>
4573 * dbus/dbus-connection-internal.h:
4574 * dbus/dbus-connection.c: (_dbus_connection_add_timeout),
4575 (_dbus_connection_remove_timeout):
4576 Add functions for adding and removing timeouts.
4578 * dbus/dbus-message.c: (dbus_message_new_from_message):
4579 Add new function that takes a message and creates an exact
4580 copy of it, but with the refcount set to 1.
4581 (check_message_handling):
4584 * dbus/dbus-server-protected.h:
4585 * dbus/dbus-server.c: (_dbus_server_init_base),
4586 (_dbus_server_finalize_base), (_dbus_server_add_timeout),
4587 (dbus_server_set_timeout_functions):
4588 (_dbus_server_remove_timeout):
4589 New functions so that a server can add and remove timeouts.
4591 (dbus_server_listen):
4592 Add commented out call to dbus_server_debug_new.
4594 * dbus/dbus-timeout.c: (_dbus_timeout_new):
4595 Actually set the handler, doh.
4597 * dbus/dbus-transport.c: (_dbus_transport_open):
4598 Add commented out call to dbus_transport_debug_client_new.
4601 Add dbus-transport-debug.[ch] and dbus-server-debug.[ch]
4603 2003-01-28 Havoc Pennington <hp@pobox.com>
4605 * dbus/dbus-message.c (check_message_handling): function to check
4606 on the loaded message, iterates over it etc.
4608 2003-01-28 Havoc Pennington <hp@pobox.com>
4610 * test/Makefile.am (dist-hook): fix make distdir
4612 * dbus/Makefile.am (TESTS_ENVIRONMENT): fix make check
4614 2003-01-27 Havoc Pennington <hp@pobox.com>
4616 * dbus/dbus-mempool.c (time_for_size): replace printf with
4619 * dbus/dbus-message-builder.c (_dbus_message_data_load): allow
4620 empty lines; fix the SAVE_LENGTH stuff to be
4621 START_LENGTH/END_LENGTH so it actually works; couple other
4624 * test/Makefile.am (dist-hook): add dist-hook for .message files
4626 * dbus/dbus-string.c (DBUS_STRING_COPY_PREAMBLE): source of a copy
4627 can be constant or locked.
4628 (_dbus_string_free): allow freeing a const string as
4631 * dbus/dbus-sysdeps.c (_dbus_concat_dir_and_file): utility
4633 * dbus/dbus-test-main.c (main): take an argument which is the
4634 directory containing test data
4636 * dbus/dbus-message.c (_dbus_message_test): pass a test_data_dir
4637 argument to this and load all the messages in test/data/
4638 checking that they can be loaded or not loaded as appropriate.
4640 2003-01-27 Anders Carlsson <andersca@codefactory.se>
4642 * bus/dispatch.c: (bus_dispatch_message_handler):
4643 Dispatch messages sent to services.
4645 * bus/driver.c: (bus_driver_send_service_deleted),
4646 (bus_driver_send_service_created), (bus_driver_send_service_lost),
4647 (bus_driver_send_service_acquired):
4648 Add helper functions for sending service related messages.
4650 (bus_driver_send_welcome_message):
4651 Send HELLO_REPLY instead of WELCOME.
4653 (bus_driver_handle_list_services):
4654 Send LIST_SERVICES_REPLY instead of SERVICES.
4656 (bus_driver_handle_own_service),
4657 (bus_driver_handle_service_exists):
4658 New message handlers.
4660 (bus_driver_handle_message):
4661 Invoke new message handlers.
4663 (bus_driver_remove_connection):
4664 Don't remove any services here since that's done automatically
4665 by bus_service_remove_owner now.
4668 New function signatures.
4670 * bus/services.c: (bus_service_add_owner):
4671 Send ServiceAcquired message if we're the only primary owner.
4673 (bus_service_remove_owner):
4674 Send ServiceAcquired/ServiceLost messages.
4676 (bus_service_set_prohibit_replacement),
4677 (bus_service_get_prohibit_replacement):
4678 Functions for setting prohibit replacement.
4680 (bus_service_has_owner):
4681 New function that checks if a connection is in the owner queue of
4685 Add new function signatures.
4687 * dbus/dbus-list.c: (_dbus_list_test):
4688 Add tests for _dbus_list_remove_last and traversing the list backwards.
4691 Fix a typo in _dbus_list_get_prev_link, if we're at the first element we can't
4692 go any further, so return NULL then.
4694 * dbus/dbus-protocol.h:
4695 Add new messages, service flags and service replies.
4697 2003-01-26 Havoc Pennington <hp@pobox.com>
4699 * dbus/dbus-message-builder.c: implement, completely untested.
4701 * test/data/*: add data to be used in testing.
4702 ".message" files are our simple loadable text format.
4703 ".message-raw" will be binary dumps of messages.
4705 * dbus/dbus-string.c (_dbus_string_starts_with_c_str): new
4707 2003-01-26 Havoc Pennington <hp@pobox.com>
4709 * dbus/dbus-sysdeps.c (_dbus_file_get_contents): new function
4711 * dbus/dbus-errors.c (dbus_result_to_string): add
4714 * dbus/dbus-message-builder.c: new file, will contain code to load
4715 up messages from files. Not implemented yet.
4717 2003-01-26 Havoc Pennington <hp@pobox.com>
4719 * dbus/dbus-message.c (dbus_message_set_sender): support deleting
4720 the sender by setting to NULL
4722 2003-01-26 Havoc Pennington <hp@pobox.com>
4724 The unit tests pass, but otherwise untested. If it breaks, the
4725 tests should have been better. ;-)
4727 * bus/driver.c (bus_driver_handle_hello): return if we disconnect
4730 * dbus/dbus-message.c: redo everything so we maintain
4731 message->header as the only copy of the various fields.
4732 This avoids the possibility of out-of-memory in some cases,
4733 for example dbus_message_lock() can't run out of memory anymore,
4734 and avoids extra copying. Figured I may as well go ahead and do
4735 this since it was busted for dbus_message_lock to not return
4736 failure on OOM, and dbus_message_write_header was totally
4737 unchecked for OOM. Also fixed some random other bugs.
4739 * dbus/dbus-marshal.c (_dbus_marshal_get_field_end_pos): verify
4740 that strings are nul-terminated. Also, end_pos can be equal
4741 to string length just not greater than, I think.
4742 (_dbus_marshal_set_int32): new function
4743 (_dbus_marshal_set_uint32): new function
4744 (_dbus_marshal_set_string): new function
4746 * dbus/dbus-connection.c (_dbus_connection_new_for_transport): fix
4747 a warning, init timeout_list to NULL
4748 (dbus_connection_send_message): don't use uninitialized variable
4751 * dbus/dbus-string.c (_dbus_string_replace_len): new function
4753 2003-01-26 Anders Carlsson <andersca@codefactory.se>
4755 * bus/driver.c: (bus_driver_handle_hello),
4756 (bus_driver_send_welcome_message):
4759 2003-01-26 Anders Carlsson <andersca@codefactory.se>
4761 * dbus/dbus-auth.c: (process_auth), (_dbus_auth_unref):
4762 * dbus/dbus-connection.c: (_dbus_connection_new_for_transport),
4763 (dbus_connection_unref):
4764 * dbus/dbus-marshal.c: (_dbus_marshal_test):
4765 * dbus/dbus-message.c: (dbus_message_unref),
4768 (dbus_message_get_fields):
4769 Remove debugging printout.
4771 (_dbus_message_loader_return_buffer):
4772 Don't store the header string.
4774 (_dbus_message_test):
4777 2003-01-26 Richard Hult <rhult@codefactory.se>
4779 * glib/dbus-gmain.c (dbus_connection_dispatch): Traverse a copy of
4780 the file descriptor list, since it can change under us.
4782 2003-01-25 Anders Carlsson <andersca@codefactory.se>
4784 * glib/dbus-gmain.c: (dbus_connection_prepare),
4785 (dbus_connection_check), (dbus_connection_dispatch), (add_watch),
4786 (remove_watch), (dbus_connection_hookup_with_g_main):
4787 Rewrite the glib handling to use its own GSource instead of a
4788 GIOChannel so we can catch messages put in the queue while waiting
4791 2003-01-25 Anders Carlsson <andersca@codefactory.se>
4794 * bus/connection.c: (connection_disconnect_handler),
4795 (connection_watch_callback), (bus_connection_setup):
4796 * bus/dispatch.c: (send_one_message),
4797 (bus_dispatch_broadcast_message), (bus_dispatch_message_handler),
4798 (bus_dispatch_add_connection), (bus_dispatch_remove_connection):
4800 * bus/driver.c: (bus_driver_send_service_deleted),
4801 (bus_driver_send_service_created), (bus_driver_handle_hello),
4802 (bus_driver_send_welcome_message),
4803 (bus_driver_handle_list_services), (bus_driver_remove_connection),
4804 (bus_driver_handle_message):
4806 Refactor code, put the message dispatching in its own file. Use
4807 _DBUS_HANDLE_OOM. Also send ServiceDeleted messages when a client
4810 2003-01-25 Anders Carlsson <andersca@codefactory.se>
4812 * dbus/dbus-internals.h:
4813 Add _DBUS_HANDLE_OOM macro, it doesn't do anything currently.
4815 * dbus/dbus-message.c: (dbus_message_get_sender):
4816 * dbus/dbus-message.h:
4817 Implement dbus_message_get_sender.
4819 * dbus/dbus-protocol.h:
4820 Add message and service defines.
4822 2003-01-25 Anders Carlsson <andersca@codefactory.se>
4824 * dbus/dbus-connection.c: (dbus_connection_send_message):
4825 * dbus/dbus-message-internal.h:
4826 * dbus/dbus-message.c: (_dbus_message_get_client_serial),
4827 (dbus_message_write_header):
4828 Remove _dbus_messag_unlock and don't set the client serial on a
4829 message if one already exists.
4831 2003-01-24 Havoc Pennington <hp@pobox.com>
4833 * dbus/dbus-list.c (alloc_link): put a thread lock on the global
4836 * bus/driver.c (bus_driver_handle_list_services): fix a leak
4839 2003-01-25 Anders Carlsson <andersca@codefactory.se>
4841 * dbus/dbus-list.c: (alloc_link), (free_link):
4842 Use a memory pool for the links.
4844 2003-01-25 Anders Carlsson <andersca@codefactory.se>
4846 * bus/connection.c: (bus_connection_foreach):
4848 Add new bus_connection_foreach function.
4850 * bus/driver.c: (send_one_message), (bus_driver_broadcast_message):
4851 Add function that broadcasts a message to all clients.
4853 (bus_driver_send_service_created), (bus_driver_handle_hello),
4854 (bus_driver_send_welcome_message),
4855 (bus_driver_handle_list_services), (bus_driver_message_handler):
4856 Implement functions that take care of listing services, and notifying
4857 clients when new services are created.
4859 * bus/services.c: (bus_services_list):
4861 Add new function that returns an array of strings with the currently
4862 registered services.
4865 * glib/dbus-gmain.c:
4866 Update copyright year.
4868 2003-01-25 Anders Carlsson <andersca@codefactory.se>
4870 * dbus/dbus-connection.c: (dbus_connection_send_message):
4871 Unlock the message in case it was sent earlier.
4873 (dbus_connection_send_message_with_reply_and_block):
4874 Remove the reply message from the list.
4876 * dbus/dbus-marshal.c: (_dbus_demarshal_string_array):
4877 Set array_len and new_pos correctly.
4879 (_dbus_marshal_test):
4880 Remove debug output.
4882 * dbus/dbus-message-internal.h:
4883 * dbus/dbus-message.c: (_dbus_message_get_reply_serial):
4884 New function that returns the reply serial.
4886 (_dbus_message_unlock):
4887 New function that unlocks a message and resets its header.
4889 (dbus_message_append_string_array),
4890 (dbus_message_get_fields_valist),
4891 (dbus_message_iter_get_field_type),
4892 (dbus_message_iter_get_string_array),
4893 (dbus_message_get_fields),
4894 (dbus_message_append_fields_valist):
4895 Handle string arrays.
4897 (dbus_message_set_sender):
4898 Make this function public since the bus daemon needs it.
4900 (decode_header_data):
4901 Set the reply serial to -1 initially.
4903 * dbus/dbus-message.h:
4904 Add dbus_message_set_sender.
4906 2003-01-24 Havoc Pennington <hp@pobox.com>
4908 * doc/dbus-specification.sgml: add some stuff
4910 2003-01-22 Havoc Pennington <hp@pobox.com>
4912 * doc/dbus-specification.sgml: Start to document the protocol.
4914 2003-01-22 Havoc Pennington <hp@pobox.com>
4916 * dbus/dbus-connection.c
4917 (dbus_connection_send_message_with_reply_and_block): add some @todo
4919 * bus/driver.c (bus_driver_add_connection): add a FIXME about memleak
4921 2003-01-21 Havoc Pennington <hp@pobox.com>
4923 (patch untested because can't compile)
4925 * bus/driver.c (create_unique_client_name): make this function
4926 never recycle client names. Also, caller should initialize
4929 * dbus/dbus-sysdeps.c (_dbus_get_current_time): new function
4931 2003-01-21 Anders Carlsson <andersca@codefactory.se>
4933 * dbus/dbus-marshal.c: (_dbus_marshal_double),
4934 (_dbus_marshal_int32), (_dbus_marshal_uint32),
4935 (_dbus_marshal_int32_array), (_dbus_marshal_uint32_array),
4936 (_dbus_marshal_double_array), (_dbus_marshal_string_array),
4937 (_dbus_demarshal_int32_array), (_dbus_demarshal_uint32_array),
4938 (_dbus_demarshal_double_array), (_dbus_demarshal_string_array),
4939 (_dbus_marshal_get_field_end_pos), (_dbus_marshal_test):
4940 * dbus/dbus-marshal.h:
4941 * dbus/dbus-protocol.h:
4942 Add support for marshalling and demarshalling integer, double
4945 2003-01-21 Anders Carlsson <andersca@codefactory.se>
4950 * bus/connection.c: (connection_disconnect_handler):
4951 Remove the connection from the bus driver's list.
4953 (connection_watch_callback): Dispatch messages.
4955 (free_connection_data): Free connection name.
4957 (bus_connection_setup): Add connection to the bus driver's list.
4958 (bus_connection_remove_owned_service):
4959 (bus_connection_set_name), (bus_connection_get_name):
4960 Add functions for setting and getting the connection's name.
4963 Add function headers.
4965 * bus/driver.c: (create_unique_client_name),
4966 (bus_driver_handle_hello_message),
4967 (bus_driver_send_welcome_message), (bus_driver_message_handler),
4968 (bus_driver_add_connection), (bus_driver_remove_connection):
4971 * bus/services.c: (bus_service_free):
4973 New file that handles communication and registreation with the bus
4976 2003-01-21 Anders Carlsson <andersca@codefactory.se>
4978 * dbus/dbus-connection.c: (dbus_connection_send_message):
4979 Add a new client_serial parameter.
4981 (dbus_connection_send_message_with_reply):
4982 Remove a @todo since we've implemented the blocking function.
4984 (dbus_connection_send_message_with_reply_and_block):
4985 New function that sends a message and waits for a reply and
4986 then returns the reply.
4988 * dbus/dbus-connection.h:
4991 * dbus/dbus-errors.c: (dbus_result_to_string):
4992 * dbus/dbus-errors.h:
4993 Add new DBUS_RESULT.
4995 * dbus/dbus-message-internal.h:
4996 * dbus/dbus-message.c: (_dbus_message_get_reply_serial),
4997 (_dbus_message_set_sender), (dbus_message_write_header),
4998 (dbus_message_new_reply), (decode_header_data),
4999 (_dbus_message_loader_return_buffer), (_dbus_message_test):
5000 * dbus/dbus-message.h:
5001 Add new functions that set the reply serial and sender.
5002 Also marshal and demarshal them correctly and add test.
5004 * dbus/dbus-protocol.h:
5005 Add new DBUS_MESSAGE_TYPE_SENDER.
5008 * glib/dbus-gmain.c: (watch_callback), (free_callback_data),
5009 (add_watch), (remove_watch), (add_timeout), (remove_timeout),
5010 (dbus_connection_hookup_with_g_main):
5011 * glib/test-dbus-glib.c: (main):
5012 Rewrite to use GIOChannel and remove the GSource crack.
5014 * test/echo-client.c: (main):
5015 * test/watch.c: (check_messages):
5016 Update for changed APIs
5018 2003-01-19 Anders Carlsson <andersca@codefactory.se>
5020 * dbus/Makefile.am: Add dbus-timeout.[cħ]
5022 * dbus/dbus-connection.c: (_dbus_connection_new_for_transport):
5023 Create a DBusTimeoutList.
5024 (dbus_connection_set_timeout_functions): Add new function to
5025 set timeout callbacks
5027 * dbus/dbus-connection.h: Add public DBusTimeout API.
5029 * dbus/dbus-message.c: (dbus_message_get_service):
5030 * dbus/dbus-message.h: New function.
5032 * dbus/dbus-server.c: Fix small doc typo.
5034 * dbus/dbus-timeout.[ch]: New files for mainloop timeouts.
5036 2003-01-19 Anders Carlsson <andersca@codefactory.se>
5038 * dbus/dbus-string.c (_dbus_string_move_len): Don't delete all
5039 of the string, just as long as specified.
5041 2003-01-19 Havoc Pennington <hp@pobox.com>
5043 * dbus/dbus-connection.c (dbus_connection_get_is_authenticated):
5046 * dbus/dbus-server.c (dbus_server_set_max_connections)
5047 (dbus_server_get_max_connections, dbus_server_get_n_connections):
5048 keep track of current number of connections, and add API for
5049 setting a max (but haven't implemented enforcing the max yet)
5051 2003-01-18 Havoc Pennington <hp@pobox.com>
5053 * dbus/dbus-transport-unix.c (unix_do_iteration): only do the
5054 reading/writing if read_watch != NULL or write_watch != NULL.
5056 * dbus/dbus-message.c (_dbus_message_loader_return_buffer): fix
5057 the message loader code to actually load message->header and
5058 message->body into the newly-created message.
5060 * dbus/dbus-transport-unix.c (check_write_watch): fix a mem leak
5063 * dbus/dbus-connection.c (dbus_connection_set_max_message_size)
5064 (dbus_connection_get_max_message_size)
5065 (dbus_connection_set_max_live_messages_size)
5066 (dbus_connection_get_max_live_messages_size): implement some
5067 resource limitation functions
5069 * dbus/dbus-resources.c: new file implementing some of the
5070 resource limits stuff
5072 * dbus/dbus-message.c (dbus_message_iter_get_byte_array): add
5073 missing docs, add @todo to handle OOM etc.
5075 * dbus/dbus-marshal.c (_dbus_demarshal_byte_array): add missing
5078 2003-01-18 Havoc Pennington <hp@pobox.com>
5080 * dbus/dbus-connection.c (dbus_connection_unref): disconnect the
5081 connection if it hasn't been already.
5083 * dbus/dbus-connection.h: kill off the idea of an ErrorFunction,
5084 replace with DisconnectFunction.
5086 2003-01-18 Havoc Pennington <hp@pobox.com>
5088 Building --disable-verbose-mode --disable-asserts --disable-tests
5089 cuts the library from 112K to 45K or so
5091 * configure.in: check for varargs macro support,
5092 add --enable-verbose-mode, --enable-asserts.
5094 * dbus/dbus-internals.h (_dbus_assert): support
5096 (_dbus_verbose): support DBUS_ENABLE_VERBOSE_MODE
5098 2003-01-18 Havoc Pennington <hp@pobox.com>
5100 * dbus/dbus-test.c: include config.h so that tests actually run
5102 * dbus/dbus-string.c: add assertions that stuff is 8-byte aligned,
5103 so the failure mode when that assumption fails will be plenty
5106 2003-01-18 Havoc Pennington <hp@pobox.com>
5108 * configure.in: default --enable-tests to $USE_MAINTAINER_MODE
5110 * dbus/Makefile.am: fix it up so dubs-test-main.c is included in
5113 * test/Makefile.am: don't use special variable "TESTS" for echo-*
5114 since we don't want to use those in make check
5116 2003-01-15 Havoc Pennington <hp@redhat.com>
5122 2003-01-15 Havoc Pennington <hp@redhat.com>
5124 * test/Makefile.am: fix so that test source code ends up in the
5125 distribution on make distcheck
5127 2003-01-15 Havoc Pennington <hp@redhat.com>
5133 2003-01-15 Havoc Pennington <hp@redhat.com>
5135 * dbus/dbus-test.c (dbus_internal_symbol_do_not_use_run_tests):
5136 fix build when --disable-tests
5138 * Makefile.am (EXTRA_DIST): put HACKING in here
5140 * HACKING: document procedure for making a tarball release.
5142 2003-01-14 Anders Carlsson <andersca@codefactory.se>
5144 * bus/connection.c: (connection_error_handler),
5145 (bus_connection_setup):
5146 * bus/main.c: (main):
5147 Make sure that the DBusConnectionData struct is NULLed
5148 out to prevent a segfault.
5150 * dbus/dbus-errors.c: (dbus_result_to_string):
5151 * dbus/dbus-errors.h:
5152 * dbus/dbus-message.c: (dbus_message_get_fields),
5153 (dbus_message_get_fields_valist), (_dbus_message_test):
5154 * dbus/dbus-message.h:
5155 Make dbus_message_get_fields return a result code so we can
5156 track invalid fields as well as oom.
5158 2003-01-11 Havoc Pennington <hp@pobox.com>
5160 * configure.in: change --enable-test/--enable-ansi action-if-given
5161 to enable_foo=$enableval instead of enable_foo=yes
5163 2003-01-08 Havoc Pennington <hp@pobox.com>
5165 * dbus/dbus-string.c (_dbus_string_align_length): new function
5167 * dbus/dbus-test-main.c: move main() for test app here
5169 (dbus_internal_symbol_do_not_use_run_tests): we have to export a
5170 symbol to run tests, because dbus-test isn't in the main
5173 Code review nitpicks.
5175 * dbus/dbus-message.c (dbus_message_write_header): add newlines
5176 for people with narrow emacs ;-). Assert client_serial was filled
5177 in. Assert message->name != NULL.
5178 (dbus_message_append_fields): have "first_field_type" arg separate
5179 from va list, needed for C++ binding that also uses varargs IIRC
5180 and helps with type safety
5181 (dbus_message_new): add @todo about using DBusString to store
5182 service/name internally
5183 (dbus_message_new): don't leak ->service and ->name on OOM later
5185 (dbus_message_unref): free the service name
5186 (dbus_message_get_fields): same change to varargs
5187 i.e. first_field_type
5188 (_dbus_message_loader_return_buffer): assert that the message data
5189 is aligned (if not it's a bug in our code). Put in verbose griping
5190 about why we set corrupted = TRUE.
5191 (decode_header_data): add FIXME that char* is evil. Was going to
5192 add FIXME about evil locale-specific string.h strncmp, but just
5193 switched to wacky string-as-uint32 optimization. Move check for
5194 "no room for field name" above get_const_data_len() to avoid
5195 assertion failure in get_const_data_len if we have trailing 2
5196 bytes or the like. Check for service and name fields being
5197 provided twice. Don't leak service/name on error. Require field
5198 names to be aligned to 4 bytes.
5200 * dbus/dbus-marshal.c: move byte swap stuff to header
5201 (_dbus_pack_int32): uscore-prefix
5202 (_dbus_unpack_int32): uscore-prefix
5203 (_dbus_unpack_uint32): export
5204 (_dbus_demarshal_string): add @todo complaining about use of
5206 (_dbus_marshal_get_field_end_pos): add @todo about bad error
5207 handling allowing corrupt data to go unchecked
5209 2003-01-08 Havoc Pennington <hp@redhat.com>
5211 * dbus/dbus-transport-unix.c (unix_do_iteration): add read/write
5212 to the select() as needed for authentication. (should be using
5213 _dbus_poll() not select, but for another day)
5215 * dbus/dbus.h: include dbus/dbus-protocol.h
5217 2003-01-08 Anders Carlsson <andersca@codefactory.se>
5219 * dbus/Makefile.am (dbusinclude_HEADERS): Install
5222 2003-01-08 Anders Carlsson <andersca@codefactory.se>
5224 * dbus/dbus-internals.c: (_dbus_type_to_string):
5225 New function that returns a string describing a type.
5227 * dbus/dbus-marshal.c: (_dbus_demarshal_byte_array):
5228 * dbus/dbus-marshal.h:
5229 * dbus/dbus-message.c: (dbus_message_get_fields_valist),
5230 (dbus_message_iter_get_field_type), (dbus_message_iter_get_double),
5231 (dbus_message_iter_get_byte_array):
5232 * dbus/dbus-message.h:
5233 Add new convenience functions for appending and getting message fields.
5234 Also add demarshalling routines for byte arrays.
5236 2003-01-07 Anders Carlsson <andersca@codefactory.se>
5238 * dbus/dbus-connection-internal.h:
5239 * dbus/dbus-connection.c: (_dbus_connection_new_for_transport),
5240 (_dbus_connection_get_next_client_serial),
5241 (dbus_connection_send_message):
5242 * dbus/dbus-internals.h:
5243 * dbus/dbus-marshal.c: (unpack_uint32), (dbus_unpack_int32),
5244 (dbus_pack_int32), (_dbus_marshal_double), (_dbus_marshal_int32),
5245 (_dbus_marshal_uint32), (_dbus_demarshal_double),
5246 (_dbus_demarshal_int32), (_dbus_demarshal_uint32),
5247 (_dbus_demarshal_string), (_dbus_marshal_get_field_end_pos),
5248 (_dbus_verbose_bytes), (_dbus_marshal_test):
5249 * dbus/dbus-marshal.h:
5250 * dbus/dbus-message-internal.h:
5251 * dbus/dbus-message.c: (_dbus_message_set_client_serial),
5252 (dbus_message_write_header), (_dbus_message_lock),
5253 (dbus_message_new), (dbus_message_ref), (dbus_message_unref),
5254 (dbus_message_get_name), (dbus_message_append_int32),
5255 (dbus_message_append_uint32), (dbus_message_append_double),
5256 (dbus_message_append_string), (dbus_message_append_byte_array),
5257 (dbus_message_get_fields_iter), (dbus_message_iter_ref),
5258 (dbus_message_iter_unref), (dbus_message_iter_has_next),
5259 (dbus_message_iter_next), (dbus_message_iter_get_field_type),
5260 (dbus_message_iter_get_string), (dbus_message_iter_get_int32),
5261 (dbus_message_iter_get_uint32), (dbus_message_iter_get_double),
5262 (decode_header_data), (_dbus_message_loader_return_buffer),
5263 (message_iter_test), (_dbus_message_test):
5264 * dbus/dbus-message.h:
5265 * dbus/dbus-protocol.h:
5266 * dbus/dbus-test.c: (main):
5268 * glib/test-dbus-glib.c: (message_handler), (main):
5269 * test/echo-client.c: (main):
5270 * test/watch.c: (check_messages):
5271 Make messages sendable and receivable for real.
5273 2003-01-07 Anders Carlsson <andersca@codefactory.se>
5275 * dbus/dbus-marshal.c: (_dbus_marshal_double),
5276 (_dbus_marshal_string), (_dbus_marshal_byte_array):
5277 * dbus/dbus-message.c: (dbus_message_append_int32),
5278 (dbus_message_append_uint32), (dbus_message_append_double),
5279 (dbus_message_append_string), (dbus_message_append_byte_array):
5280 Handle OOM restoration.
5282 2003-01-07 Anders Carlsson <andersca@codefactory.se>
5284 * dbus/dbus-marshal.c: (_dbus_marshal_string),
5285 (_dbus_demarshal_string), (_dbus_marshal_test):
5286 * dbus/dbus-marshal.h:
5287 * dbus/dbus-message.c: (dbus_message_get_name),
5288 Document these functions.
5290 (dbus_message_append_int32), (dbus_message_append_uint32),
5291 (dbus_message_append_double), (dbus_message_append_string),
5292 (dbus_message_append_byte_array):
5293 * dbus/dbus-message.h:
5294 Add functions for adding message fields of different types.
5296 * dbus/dbus-protocol.h:
5297 Add the different types.
5299 2003-01-05 Havoc Pennington <hp@pobox.com>
5301 * bus/connection.c: implement routines for handling connections,
5302 first thing is keeping a list of owned services on each connection
5303 and setting up watches etc.
5305 * bus/services.c: implement a mapping from service names to lists
5308 * dbus/dbus-hash.c: add DBUS_HASH_POINTER
5310 * dbus/dbus-threads.c (dbus_static_mutex_lock): add functions
5311 to use static mutexes for global data
5313 * dbus/dbus-connection.c (dbus_connection_set_data): add new
5314 collection of functions to set/get application-specific data
5315 on the DBusConnection.
5317 2003-01-04 Havoc Pennington <hp@pobox.com>
5319 * dbus/dbus-sysdeps.c (_dbus_sleep_milliseconds): new function
5320 (_dbus_poll): new function
5322 * dbus/dbus-internals.h (_DBUS_STRUCT_OFFSET): new macro
5325 * bus/loop.c: initial code for the daemon main loop
5327 2003-01-04 Havoc Pennington <hp@pobox.com>
5329 * test/watch.c (error_handler): make it safe if the error handler
5330 is called multiple times (if we s/error handler/disconnect
5331 handler/ we should just guarantee it's called only once)
5333 * dbus/dbus-transport.c (_dbus_transport_disconnect): call the
5334 error handler on disconnect (it's quite possible we should
5335 just change the error handler to a "disconnect handler," I'm
5336 not sure we have any other meaningful errors)
5338 * configure.in: check for getpwnam_r
5340 * dbus/dbus-transport.c, dbus/dbus-transport-unix.c,
5341 dbus/dbus-auth.c: add credentials support, add EXTERNAL auth
5342 mechanism as in SASL spec, using socket credentials
5344 * dbus/dbus-sysdeps.c (_dbus_read_credentials_unix_socket): new function
5345 (_dbus_send_credentials_unix_socket): new function
5347 * dbus/dbus-sysdeps.c (_dbus_accept_unix_socket): rename just
5349 (_dbus_write): only check errno if <0 returned
5350 (_dbus_write_two): ditto
5352 2003-01-02 Anders Carlsson <andersca@codefactory.se>
5354 * dbus/dbus-marshal.c: (_dbus_marshal_utf8_string),
5355 (_dbus_marshal_byte_array), (_dbus_demarshal_utf8_string),
5356 (_dbus_marshal_test):
5357 * dbus/dbus-marshal.h:
5358 Add _dbus_marshal_byte_array and rename _dbus_marshal_string
5359 to _dbus_marshal_utf8_string. Also fix some tests.
5361 2002-12-28 Harri Porten <porten@kde.org>
5363 * configure.in: added check for C++ compiler and a very cheesy
5364 check for the Qt integration
5366 * Makefile.am (SUBDIRS): compile qt subdir if support is enabled
5368 * qt/Makefile.am: added
5370 * qt/.cvsignore: added
5372 * qt/dbus-qthread.cc, qt/dbus-qthread.cpp: renamed former to
5373 latter, added #ifdef QT_THREAD_SUPPORT guard.
5375 * dbus/Makefile.am: added missing headers for make dist
5377 2002-12-28 Kristian Rietveld <kris@gtk.org>
5379 * dbus/Makefile.am: fixup export-symbols-regex.
5381 2002-12-27 Anders Carlsson <andersca@codefactory.se>
5383 * acinclude.m4: Add this file and put the
5384 PKG_CHECK_MODULE macro in it.
5386 2002-12-27 Anders Carlsson <andersca@codefactory.se>
5388 * dbus/dbus-marshal.c: (_dbus_marshal_string),
5389 (_dbus_demarshal_double), (_dbus_demarshal_int32),
5390 (_dbus_demarshal_uint32), (_dbus_demarshal_string),
5391 (_dbus_marshal_test):
5392 Make the demarshalling routines align the pos argument.
5393 Add string marshalling tests and fix the obvious bugs
5396 2002-12-26 Havoc Pennington <hp@pobox.com>
5398 * dbus/dbus-auth.c: fixes fixes fixes
5400 * dbus/dbus-transport-unix.c: wire up support for
5401 encoding/decoding data on the wire
5403 * dbus/dbus-auth.c (_dbus_auth_encode_data)
5404 (_dbus_auth_decode_data): append to target string
5405 instead of nuking it.
5407 2002-12-26 Havoc Pennington <hp@pobox.com>
5409 * dbus/dbus-marshal.h (DBUS_COMPILER_BYTE_ORDER): #ifdef
5410 WORDS_BIGENDIAN then compiler byte order is DBUS_BIG_ENDIAN,
5413 * dbus/dbus-marshal.c: Add macros to do int swapping in-place and
5414 avoid swap_bytes() overhead (ignoring possible assembly stuff for
5415 now). Main point is because I wanted unpack_uint32 to implement
5417 (_dbus_verbose_bytes): new function
5419 * dbus/dbus-string.c (_dbus_string_validate_ascii): new function
5421 * dbus/dbus-message.c (_dbus_message_loader_get_is_corrupted): add
5422 mechanism to handle a corrupt message stream
5423 (_dbus_message_loader_new): fix preallocation to only prealloc,
5426 * dbus/dbus-string.c (_dbus_string_skip_blank): fix this function
5427 (_dbus_string_test): enhance tests for copy/move and fix the
5430 * dbus/dbus-transport-unix.c: Hold references in more places to
5431 avoid reentrancy problems
5433 * dbus/dbus-transport.c: ditto
5435 * dbus/dbus-connection.c (dbus_connection_dispatch_message): don't
5436 leak reference count in no-message case
5438 * test/watch.c (do_mainloop): handle adding/removing watches
5439 during iteration over the watches. Also, ref the connection/server
5440 stored on a watch, so we don't try to mangle a destroyed one.
5442 * dbus/dbus-transport-unix.c (do_authentication): perform
5445 * dbus/dbus-auth.c (get_state): add a state
5446 AUTHENTICATED_WITH_UNUSED_BYTES and return it if required
5447 (_dbus_auth_get_unused_bytes): append the unused bytes
5448 to the passed in string, rather than prepend
5450 * dbus/dbus-transport.c (_dbus_transport_init_base): create
5451 the auth conversation DBusAuth
5453 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_fd)
5454 (_dbus_transport_new_for_domain_socket): when creating a
5455 transport, pass in whether it's a client-side or server-side
5456 transport so we know which DBusAuth to create
5458 2002-12-03 Havoc Pennington <hp@pobox.com>
5460 * dbus/dbus-transport-unix.c (unix_finalize): finalize base
5461 _after_ finalizing the derived members
5462 (unix_connection_set): unref watch if we fail to add it
5464 * dbus/dbus-connection.c (dbus_connection_unref): delete the
5465 transport first, so that the connection owned by the
5466 transport will be valid as the transport finalizes.
5468 * dbus/dbus-transport-unix.c (unix_finalize): free the write_watch
5469 if necessary, and remove watches from the connection.
5471 * dbus/dbus-watch.c (_dbus_watch_list_free): improve a comment
5473 2002-12-26 Anders Carlsson <andersca@codefactory.se>
5475 * dbus/dbus-marshal.c: (_dbus_marshal_string),
5476 (_dbus_demarshal_double), (_dbus_demarshal_int32),
5477 (_dbus_demarshal_uint32), (_dbus_demarshal_string),
5478 (_dbus_marshal_test):
5479 * dbus/dbus-marshal.h:
5480 Add string marshal functions and have the demarshal functions
5481 return the new position.
5483 2002-12-25 Havoc Pennington <hp@pobox.com>
5485 * doc/dbus-sasl-profile.txt: docs on the authentication protocol,
5486 it is a simple protocol that just maps directly to SASL.
5488 * dbus/dbus-auth.h, dbus/dbus-auth.c: authentication protocol
5489 initial implementation, not actually used yet.
5491 * dbus/dbus-string.c (_dbus_string_find): new function
5492 (_dbus_string_equal): new function
5493 (_dbus_string_base64_encode): new function
5494 (_dbus_string_base64_decode): new function
5496 2002-12-25 Anders Carlsson <andersca@codefactory.se>
5499 * dbus/dbus-marshal.c: (swap_bytes), (_dbus_marshal_double),
5500 (_dbus_marshal_int32), (_dbus_marshal_uint32),
5501 (_dbus_demarshal_double), (_dbus_demarshal_int32),
5502 (_dbus_demarshal_uint32), (_dbus_marshal_test):
5503 * dbus/dbus-marshal.h:
5504 * dbus/dbus-protocol.h:
5505 * dbus/dbus-test.c: (main):
5507 Add un-optimized marshalling/demarshalling routines.
5509 2002-12-25 Harri Porten <porten@kde.org>
5511 * qt/dbus-qt.h: adjusted ctor and getter to KDE/Qt conventions
5513 2002-12-24 Zack Rusin <zack@kde.org>
5515 * qt/dbus-qthread.cc: adding - integrates QMutex into Dbus
5516 * qt/dbus-qt.h: skeleton with two sample implemenatation of the
5519 2002-12-24 Havoc Pennington <hp@pobox.com>
5521 * glib/dbus-gthread.c: fix include
5523 * glib/dbus-glib.h: rename DBusMessageHandler for now.
5524 I think glib API needs to change, though, as you don't
5525 want to use DBusMessageFunction, you want to use the
5526 DBusMessageHandler object. Probably
5527 dbus_connection_open_with_g_main_loop()
5528 and dbus_connection_setup_g_main_loop() or something like that
5529 (but think of better names...) that just create a connection
5530 that has watch/timeout functions etc. already set up.
5532 * dbus/dbus-connection.c
5533 (dbus_connection_send_message_with_reply): new function just to
5534 show how the message handler helps us deal with replies.
5536 * dbus/dbus-list.c (_dbus_list_remove_last): new function
5538 * dbus/dbus-string.c (_dbus_string_test): free a string that
5541 * dbus/dbus-hash.c: use memory pools for the hash entries
5542 (rebuild_table): be more paranoid about overflow, and
5543 shrink table when we can
5544 (_dbus_hash_test): reduce number of sprintfs and write
5545 valid C89. Add tests for case where we grow and then
5546 shrink the hash table.
5548 * dbus/dbus-mempool.h, dbus/dbus-mempool.c: memory pools
5550 * dbus/dbus-connection.c (dbus_connection_register_handler)
5551 (dbus_connection_unregister_handler): new functions
5553 * dbus/dbus-message.c (dbus_message_get_name): new
5555 * dbus/dbus-list.c: fix docs typo
5557 * dbus/dbus-message-handler.h, dbus/dbus-message-handler.c:
5558 an object representing a handler for messages.
5560 2002-12-16 Anders Carlsson <andersca@codefactory.se>
5563 * glib/dbus-gthread.c: (dbus_gthread_init):
5564 Don't use the gdbus prefix for public functions.
5566 2002-12-16 Anders Carlsson <andersca@codefactory.se>
5570 Add GLib checks and fixup .pc files
5574 * glib/dbus-gmain.c: (gdbus_connection_prepare),
5575 (gdbus_connection_check), (gdbus_connection_dispatch),
5576 (gdbus_add_connection_watch), (gdbus_remove_connection_watch),
5577 (dbus_connection_gsource_new):
5578 * glib/dbus-gthread.c: (dbus_gmutex_new), (dbus_gmutex_free),
5579 (dbus_gmutex_lock), (dbus_gmutex_unlock), (dbus_gthread_init):
5580 * glib/test-dbus-glib.c: (message_handler), (main):
5583 2002-12-15 Harri Porten <porten@kde.org>
5585 * autogen.sh: check for libtoolize before attempting to use it
5587 * dbus/dbus-transport-unix.c: include <sys/time.h> for timeval
5590 * .cvsignore: ignore more stamp files
5592 * dbus/dbus-watch.c (_dbus_watch_list_new): fixed doc error
5594 * test/Makefile.am: added -I$(top_srcdir) to be able to compile
5595 without make install.
5597 2002-12-15 Havoc Pennington <hp@pobox.com>
5599 * dbus/dbus-threads.c: add thread stubs that a higher library
5600 layer can fill in. e.g. the GLib wrapper might fill them in with
5601 GThread stuff. We still need to use this thread API to
5602 thread-safe-ize the library.
5604 2002-12-12 Havoc Pennington <hp@pobox.com>
5606 * dbus/dbus-transport-unix.c, dbus/dbus-server-unix.c: use the
5607 below new interfaces and include fewer system headers.
5609 * dbus/dbus-sysdeps.c (_dbus_read): new function
5610 (_dbus_write): new function
5611 (_dbus_write_two): new function
5612 (_dbus_connect_unix_socket): new function
5613 (_dbus_listen_unix_socket): new function
5615 * dbus/dbus-message-internal.h: change interfaces to use
5618 2002-12-11 Havoc Pennington <hp@pobox.com>
5620 * dbus/dbus-types.h: add dbus_unichar
5622 * dbus/dbus-internals.c (_dbus_verbose): use _dbus_getenv
5624 * dbus/dbus-connection.c (dbus_connection_send_message): return
5627 * dbus/dbus-transport.c: include dbus-watch.h
5629 * dbus/dbus-connection.c: include dbus-message-internal.h
5631 * HACKING: add file with coding guidelines stuff.
5633 * dbus/dbus-string.h, dbus/dbus-string.c: Encapsulate all string
5634 handling here, for security purposes (as in vsftpd). Not actually
5635 using this class yet.
5637 * dbus/dbus-sysdeps.h, dbus/dbus-sysdeps.c: Encapsulate all
5638 system/libc usage here, as in vsftpd, for ease of auditing (and
5639 should also simplify portability). Haven't actually moved all the
5640 system/libc usage into here yet.
5642 2002-11-25 Havoc Pennington <hp@pobox.com>
5644 * dbus/dbus-internals.c (_dbus_verbose): fix to not
5645 always print the first verbose message.
5647 2002-11-24 Havoc Pennington <hp@pobox.com>
5649 * test/echo-client.c, test/echo-server.c: cheesy test
5652 * configure.in (AC_CHECK_FUNCS): check for writev
5654 * dbus/dbus-message.c (_dbus_message_get_network_data): new
5657 * dbus/dbus-list.c (_dbus_list_foreach): new function
5659 * dbus/dbus-internals.c (_dbus_verbose): new function
5661 * dbus/dbus-server.c, dbus/dbus-server.h: public object
5662 representing a server that listens for connections.
5664 * dbus/.cvsignore: create
5666 * dbus/dbus-errors.h, dbus/dbus-errors.c:
5667 public API for reporting errors
5669 * dbus/dbus-connection.h, dbus/dbus-connection.c:
5670 public object representing a connection that
5671 sends/receives messages. (Same object used for
5672 both client and server.)
5674 * dbus/dbus-transport.h, dbus/dbus-transport.c:
5675 Basic abstraction for different kinds of stream
5676 that we might read/write messages from.
5678 2002-11-23 Havoc Pennington <hp@pobox.com>
5680 * dbus/dbus-internals.h (_DBUS_INT_MAX): add _DBUS_INT_MIN
5683 * dbus/dbus-test.c (main): add list test, and include
5684 dbus-test.h as intended
5686 * dbus/dbus-hash.c (_dbus_hash_table_remove_string)
5687 (_dbus_hash_table_remove_int): return value indicates
5688 whether the entry existed to remove
5690 * dbus/dbus-list.c: add linked list utility class,
5693 * dbus/dbus-hash.c: add TODO item about shrinking the hash bucket
5696 2002-11-23 Havoc Pennington <hp@pobox.com>
5698 * Doxyfile.in (INCLUDE_FILE_PATTERNS): expand DBUS_BEGIN_DECLS/
5699 DBUS_END_DECLS to nothing, that should fix this once and for all
5701 * Doxyfile.in (JAVADOC_AUTOBRIEF): set to YES
5703 * dbus/dbus-message.c, dbus/dbus-hash.c:
5704 add some missing @brief
5706 2002-11-23 Havoc Pennington <hp@pobox.com>
5708 * dbus/dbus-message.h: put semicolons after DEBUG_BEGIN_DECLS
5709 to avoid confusing Doxygen
5711 * dbus/dbus-hash.c: @} not }@
5713 * dbus/dbus-message.c (struct DBusMessage): split out
5716 2002-11-23 Havoc Pennington <hp@pobox.com>
5718 * configure.in: pile on more warning flags if using gcc
5720 * Doxyfile.in (EXTRACT_STATIC): set to NO, so we don't have
5721 to document static functions
5723 * configure.in: add summary to end of configure so it
5724 looks nice and attractive
5726 * dbus/dbus-hash.c: finish implementation and write unit
5729 * configure.in: add --enable-tests to enable unit tests
5731 * dbus/dbus-test.c: test program to run unit tests
5732 for all files in dbus/*, initially runs a test for
5735 * dbus/dbus-internals.h: file to hold some internal utility stuff
5737 2002-11-22 Havoc Pennington <hp@redhat.com>
5739 * dbus/dbus-hash.c: copy in Tcl hash table, not yet
5740 "ported" away from Tcl
5742 * dbus/dbus-types.h: header for types such as dbus_bool_t
5744 2002-11-22 Havoc Pennington <hp@redhat.com>
5746 * dbus/dbus.h: fixups for doc warnings
5748 * Doxyfile.in (FILE_PATTERNS): we need to scan .h to pick up
5750 (QUIET): make it quiet so we can see warnings
5752 * dbus/dbus-memory.c: teach D-BUS to allocate and free memory
5754 2002-11-22 Havoc Pennington <hp@redhat.com>
5756 * Makefile.am: include "Doxyfile" target in all-local
5758 * configure.in: generate the Doxyfile
5760 * Doxyfile.in: move Doxyfile here, so we can use
5761 configure to generate a Doxyfile with the right
5764 2002-11-22 Havoc Pennington <hp@redhat.com>
5766 * dbus/dbus-message.c: move inline docs into .c file
5768 * Doxyfile (OUTPUT_DIRECTORY): move output to doc/api
5769 so all docs are under doc/
5770 (MAN_EXTENSION): generate man pages. Use extension
5771 ".3dbus" which matches ".3qt" on my system,
5772 I guess this is OK, I don't know really.
5773 (FILE_PATTERNS): look for .c files not .h, makes sense
5776 2002-11-22 Havoc Pennington <hp@pobox.com>
5778 * Makefile.am (SUBDIRS): rename subdir "server" to "bus"
5779 because any app can be a server, and any app can be a client,
5780 the bus is a special kind of server.
5782 Thu Nov 21 23:35:31 2002 Zack Rusin <zack@kde.org>
5784 * Doxyfile : adding. Still needs Makefile rules to be generated
5785 automatically (just run "doxygen" in the toplevel dir for now to
5788 * dbus/dbus-message.h : Adding sample docs (javadoc since
5789 resembles gtk-doc a little more)
5791 * dbus/dbus.h : Adding sample docs
5793 2002-11-21 Havoc Pennington <hp@redhat.com>
5795 * dbus/Makefile.am (INCLUDES): define DBUS_COMPILATION
5796 so we can allow ourselves to include files directly,
5797 instead of having to use dbus.h
5799 * dbus/dbus.h: fill in
5801 * dbus/dbus-message.h: sketch out a sample header file.
5802 Include griping if you include it directly instead of
5805 * dbus/dbus-macros.h: new file with macros for extern "C",
5806 TRUE/FALSE, NULL, etc.
5808 * doc/file-boilerplate.c: put include guards in here
5810 2002-11-21 Havoc Pennington <hp@redhat.com>
5812 * doc/file-boilerplate.c: include both AFL and GPL boilerplate.
5814 * COPYING: include the GPL as well, and license code
5815 under both AFL and GPL.
5817 2002-11-21 Havoc Pennington <hp@redhat.com>
5819 * acconfig.h: get rid of this
5821 * autogen.sh (run_configure): add --no-configure option
5823 * configure.in: remove AC_ARG_PROGRAM to make
5824 autoconf complain less. add AC_PREREQ.
5825 add AC_DEFINE third arg.
5827 2002-11-21 Anders Carlsson <andersca@codefactory.se>
5830 Fix references so we can distcheck.
5832 2002-11-21 Havoc Pennington <hp@redhat.com>
5834 * Initial module creation