1 2005-06-13 Jim Meyering <jim@meyering.net>
5 * src/mkdir.c (main): Give a diagnostic for -- and skip -- each
6 relative directory name after make_dir_parents fails to restore
7 the working directory. Before, `mkdir -p' could create directories
8 in the wrong place in unusual circumstances.
9 * src/install.c (main): Likewise.
10 (install_file_in_file_parents): Update make_dir_parents caller.
11 * tests/mkdir/p-3: New test for today's mkdir.c/mkdir-p.c bug fixes.
13 2005-06-10 Paul Eggert <eggert@cs.ucla.edu>
15 Act on the Austin Group's response yesterday to XCU ERN 63; see
16 <http://www.opengroup.org/austin/docs/austin_260.txt>.
17 * NEWS: ls no longer outputs an extra space between mode and link count.
18 * doc/coreutils.texi: Remove the extra spaces in "ls -l" output.
19 * src/ls.c (any_has_acl): New var.
20 (clear_files): Clear it.
21 (gobble_file): Set it if a file has an ACL.
22 (print_long_format): Omit needless space unless some file has an ACL.
24 2005-06-10 Jim Meyering <jim@meyering.net>
26 * src/system.h (VERIFY_W_TYPEOF): Add parentheses.
28 2005-06-02 Jim Meyering <jim@meyering.net>
30 * src/sort.c (usage): Put `Ordering options:' line where it belongs.
32 2005-06-01 Paul Eggert <eggert@cs.ucla.edu>
34 Use "file name" when talking about file names, instead of "filename"
35 or "path", as per the GNU coding standards.
36 * src/basename.c: Don't use "path" or "filename".
37 * src/copy.c: Likewise.
38 * src/copy.h: Likewise.
39 * src/cp-hash.c: Likewise.
42 * src/install.c: Likewise.
44 * src/pinky.c: Likewise.
46 * src/pwd.c: Likewise.
47 * src/remove.c: Likewise.
48 * src/rmdir.c: Likewise.
49 * src/sort.c: Likewise.
50 * src/system.h: Likewise.
51 * src/tty.c: Likewise.
52 * src/who.c: Likewise.
53 * src/cp.c (parents_option): Renamed from flag_path. All uses changed.
54 (make_dir_parents_private): Renamed from make_path_private.
56 * src/cp.c (usage): Don't use "path" to describe a file name.
57 * src/readlink.c (usage): Likewise.
58 * src/rmdir.c (usage): Likewise.
59 * src/df.c: Don't include "path-concat.h"; not needed.
60 * src/install.c (install_file_in_file_parents): Renamed from
61 install_file_to_path. All uses changed.
62 * src/ln.c (FILE_BASENAME_CONCAT): Renamed from PATH_BASENAME_CONCAT.
64 * src/ls.c (make_link_name): Renamed from make_link_path.
66 * src/pwd.c (struct file_name): Renamed from struct Path.
68 (file_name_free): Renamed from path_free. All uses changed.
69 (file_name_init): Renamed from path_init. All uses changed.
70 (file_name_prepend): Renamed from path_prepend. All uses changed.
71 * src/rmdir.c (remove_empty_parents): Renamed from empty_paths.
73 (longopts): Add comment that --path is deprecated.
75 2005-05-31 Jim Meyering <jim@meyering.net>
77 * src/copy.c (chown_privileges, chown_failure_ok): Mark as `extern'.
78 This is a crutch so that `make distcheck's sc_tight_scope rule
79 knows that they really are deliberately declared that way.
81 2005-05-30 Paul Eggert <eggert@cs.ucla.edu>
83 Port to Solaris 10's rules for whether programs can chown files.
84 * src/copy.c [HAVE_PRIV_H]: Include <priv.h>.
85 (DO_CHOWN): Remove. Replaced by chown_failure_ok. All callers
87 (copy_internal): If chown failed, don't worry about what happened
88 to the mode bits; they can't have changed.
89 (chown_privileges, chown_failure_ok): New functions.
90 * src/copy.h: Add copyright notice.
91 (struct cp_options): Remove myeuid member. Add chown_privileges
93 (chown_privileges, chown_failure_ok): New function decls.
94 * src/cp.c (re_protect): Remove unnecessary call to geteuid.
95 Use chown_failure_ok rather than our own code.
96 * src/cp.c (cp_options_init): Use chown_privileges rather than geteuid.
97 * src/install.c (cp_option_init): Likewise.
98 * src/mv.c (cp_option_init): Likewise.
100 2005-05-29 Paul Eggert <eggert@cs.ucla.edu>
102 * src/chgrp.c (getgrnam) [!defined _POSIX_VERSION]: Remove decl.
103 * src/chown-core.c (getgrnam, getgrgid) [!defined _POSIX_VERSION]:
105 * src/cp.c (geteuid) [!defined _POSIX_VERSION]: Remove decl.
106 * src/id.c (getpwuid, getgrgid, getuid, getgid, geteuid, getegid)
107 [!defined _POSIX_VERSION]: Remove decls.
108 * src/install.c (getpwnam, getgrnam): Remove decl.
109 (getuid, getgid) [!defined _POSIX_VERSION]: Remove decls.
110 * src/md5sum.c (OPENOPTS, TEXT1T01, TEXTCNVT): Remove.
111 (digest_file): Use O_BINARY-using expr instead of OPENOPTS.
112 * src/system.h: Don't bother mentioning _POSIX_VERSION in comment.
113 * src/test.c: Include sys/param.h if it exists, not if _POSIX_VERSION
115 Don't include <sys/file.h>; no longer needed.
116 (getegid, geteuid): Remove no-longer-necessary decls.
118 * src/pathchk.c (_POSIX_PATH_MAX) [!defined _POSIX_PATH_MAX]:
119 Define to 256, not 255, as per modern POSIX.
121 2005-05-27 Paul Eggert <eggert@cs.ucla.edu>
123 * NEWS: dd seek=N now conforms to POSIX if the output isn't seekable.
124 * src/dd.c (skip): Return the number of records that were not
125 skipped due to encountering EOF.
126 (dd_copy): If the file wasn't seekable and EOF was encountered,
127 write zeros past EOF until the desired offset is reached.
129 * NEWS: expr and test now correctly compare integers of unlimited size.
130 (Also, correct a comment that claimed that expr detects integer
131 overflow; it does so only when converting from strings.)
132 * src/expr.c: Include strnumcmp.h, xstrtol.h.
133 (looks_like_integer): New function.
134 (toarith): Use it. Also, use xstrtoimax rather than rolling our
136 (eval2): Don't look for trouble if !evaluate; this simplifies things.
137 Compare numbers using string comparison, so that overflow is
139 * src/sort.c: Refactor so that others can use large-integer
140 comparison functions.
141 Include "strnumcmp.h".
142 (NEGATION_SIGN, NUMERIC_ZERO, fraccompare):
143 Remove; moved to strnumcmp.
144 (decimal_point): Now int, to simplify converison overhead with
145 new API. All uses changed.
146 (thousands_sep): Now -1 if there isn't one, as per new API.
148 (numcompare): Move contents to strnumcmp module, except for
150 * src/test.c: Include inttostr.h, strnumcmp.h.
151 (whitespace, digit, digit_value, integer_expected_error): Remove.
152 (is_int): Remove; replaced by...
153 (find_int): New function.
154 (binary_operator): Don't let integers overflow in comparisons;
155 return the correct answer instead. Simplify the code.
156 (unary_operator): Convert the integer ourself, since find_int
158 * tests/expr/basic (bigcmp): New test.
159 * tests/test/Test.pm (eq-6, gt-5, lt-5): New tests.
161 2005-05-26 Paul Eggert <eggert@cs.ucla.edu>
163 * NEWS: nohup now redirects a tty stdin to an unreadable fd
164 instead of closing it.
165 * doc/coreutils.texi (nohup invocation): Document this.
166 * src/nohup.c (main): Implement this.
168 2005-05-26 Jim Meyering <jim@meyering.net>
170 * src/expr.c (toarith): Fix a sign error introduced on 2005-01-14.
171 Reported by David Alan Gilbert.
172 * tests/expr/basic: Add tests using arithmetic on negative integers.
174 2005-05-19 Jim Meyering <jim@meyering.net>
176 * src/remove.c (AD_mark_helper, AD_mark_current_as_unremovable):
177 Remove inaccurate-but-harmless `const' attributes.
179 * src/join.c (decode_field_spec): Add an abort after
180 `error (EXIT_FAILURE, ...' to avoid a gcc warning in caller,
181 about variables being used uninitialized.
183 2005-05-18 Paul Eggert <eggert@cs.ucla.edu>
185 * configure.ac: Add copyright notice. gl_LIB_CHECK -> cu_LIB_CHECK.
186 * src/Makefile.am: Add copyright notice.
187 (factor_LDADD): Remove, as factor no longer needs sqrt.
188 * src/hostname.c: Remove test for HAVE_LIMITS_H; we can assume
189 it's always true now.
191 2005-05-16 Paul Eggert <eggert@cs.ucla.edu>
193 Fix Cygwin porting problem reported by Eric Blake.
194 * src/remove.c (DT_IS_DIR): Remove.
195 (DT_IS_KNOWN, DT_MUST_BE): New macros.
196 (remove_entry): Use them.
198 2005-05-14 Paul Eggert <eggert@cs.ucla.edu>
200 * src/remove.c: Include unlinkdir.h.
201 (UNLINK_CAN_UNLINK_DIRS): Remove.
202 (remove_entry): Use cannot_unlink_dirs () rather than
203 UNLINK_CAN_UNLINK_DIRS.
205 2005-05-14 Jim Meyering <jim@meyering.net>
207 Update FSF postal mail address.
208 * Makefile.maint, Makefile.cfg, gnupload
209 * src/basename.c, src/cat.c, src/checksum.h, src/chgrp.c
210 * src/chmod.c, src/chown-core.c, src/chown-core.h, src/chown.c
211 * src/chroot.c, src/cksum.c, src/comm.c, src/copy.c, src/copy.h
212 * src/cp-hash.c, src/cp-hash.h, src/cp.c, src/csplit.c, src/cut.c
213 * src/date.c, src/dcgen, src/dd.c, src/df.c, src/dircolors.c
214 * src/dirname.c, src/du.c, src/echo.c, src/env.c, src/expand.c
215 * src/expr.c, src/factor.c, src/fmt.c, src/fold.c, src/fs.h
216 * src/groups.sh, src/head.c, src/hostid.c, src/hostname.c, src/id.c
217 * src/install.c, src/join.c, src/kill.c, src/lbracket.c, src/link.c
218 * src/ln.c, src/logname.c, src/ls-dir.c, src/ls-ls.c, src/ls-vdir.c
219 * src/ls.c, src/ls.h, src/md5.c, src/md5sum.c, src/mkdir.c
220 * src/mkfifo.c, src/mknod.c, src/mv.c, src/nice.c, src/nl.c
221 * src/nohup.c, src/od.c, src/paste.c, src/pathchk.c, src/pinky.c
222 * src/pr.c, src/printenv.c, src/printf.c, src/ptx.c, src/pwd.c
223 * src/readlink.c, src/remove.c, src/remove.h, src/rm.c, src/rmdir.c
224 * src/seq.c, src/setuidgid.c, src/sha1sum.c, src/shred.c
225 * src/sleep.c, src/sort.c, src/split.c, src/stat.c, src/stty.c
226 * src/su.c, src/sum.c, src/sync.c, src/system.h, src/tac-pipe.c
227 * src/tac.c, src/tail.c, src/tee.c, src/test.c, src/touch.c
228 * src/tr.c, src/true.c, src/tsort.c, src/tty.c, src/uname.c
229 * src/unexpand.c, src/uniq.c, src/unlink.c, src/uptime.c
230 * src/users.c, src/wc.c, src/who.c, src/whoami.c, src/yes.c
232 2005-05-13 Jim Meyering <jim@meyering.net>
234 * NEWS: `rm -r' now removes all of the files it should, even on
235 systems with a buggy readdir affecting file systems inaccessible
238 In some unusual circumstances `rm -r' would fail to remove --
239 or even consider -- all entries in a directory with more than 254
240 (SunOS) or 338 (Darwin) entries. This could cause trouble even on
241 other types of systems when using an affected file system via e.g.,
242 NFS. The underlying cause was a bug in readdir on those systems.
243 Coreutils-5.2.1 and earlier used a configure-time test designed
244 to detect precisely those problem systems, but it would detect
245 the problem and enable remove.c's work-around code only when its
246 configure-time test was run on a losing file system. Obviously,
247 it couldn't detect a problem if the offending file system wasn't
248 tested or even mounted at coreutils configure time. Now, rm itself
249 performs a minimal-cost run-time test to detect the problem.
251 * src/remove.c (CONSECUTIVE_READDIR_UNLINK_THRESHOLD): Define.
252 (remove_cwd_entries): When readdir returns NULL for a directory from
253 which we've removed more than CONSECUTIVE_READDIR_UNLINK_THRESHOLD
254 entries, call rewinddir and then resume the readdir/unlink loop.
255 (UNLINK_CAN_UNLINK_DIRS): Rename from ROOT_CAN_UNLINK_DIRS.
257 2005-05-12 Paul Eggert <eggert@cs.ucla.edu>
259 * NEWS: nohup now closes stdin if it is a terminal, unless
260 POSIXLY_CORRECT is set. This fixes a glitch noted by Wayne Pollock in
261 <https://www.opengroup.org/sophocles/show_mail.tpl?
262 source=L&listname=austin-group-l&id=8341>.
263 * doc/coreutils.texi (nohup invocation): Document this.
264 * src/nohup.c (main): Implement this.
266 2005-05-12 Jim Meyering <jim@meyering.net>
268 * src/date.c: Assume `free (NULL)' works.
269 * src/dd.c: Likewise.
271 * src/dircolors.c:Likewise.
272 * src/head.c: Likewise.
273 * src/ls.c: Likewise.
274 * src/md5sum.c: Likewise.
275 * src/pr.c: Likewise.
276 * src/sort.c: Likewise.
278 2005-05-10 Jim Meyering <jim@meyering.net>
280 * tests/touch/not-owner: Skip this test if the user running it
281 owns `/' or has write access to it.
283 * src/copy.c (abandon_move): Remove erroneous UNWRITABLE check.
284 This makes `mv -i --reply=no f1 f2' work as expected (in not
285 performing the move operation). But note that specifying `-i'
286 after `--reply=no' does *not* work.
287 Tiny patch from Vlada Macek.
289 * tests/mv/reply-no: New file. Test for the above fix.
290 * tests/mv/Makefile.am (TESTS): Add reply-no.
292 * tests/ls-2/tests: Don't print PATH to stderr.
294 2005-05-08 Paul Eggert <eggert@cs.ucla.edu>
296 * NEWS: cp, ln, mv, rm no longer discard white space when intepreting
299 2005-05-06 Paul Eggert <eggert@cs.ucla.edu>
301 * NEWS: dd has new iflag= and oflag= flags "binary" and "text".
302 * src/dd.c (flags, usage): Add support for "binary" and "text".
304 2005-05-04 Paul Eggert <eggert@cs.ucla.edu>
306 * NEWS: chmod -w now complains if it differs from chmod a-w.
307 * src/chmod.c: Include quotearg.h.
308 (diagnose_surprises): New var.
309 (process_file): Diagnose surprises. Simplify the logic a bit,
311 (main): Prepare to diagnose surprises. Remove useless code for
313 * tests/chmod/Makefile.am (TESTS): Add umask-x.
314 * tests/chmod/umask-x: New file.
316 2005-05-02 Paul Eggert <eggert@cs.ucla.edu>
318 * NEWS: ls --indicator-style=directory renamed to ls
319 --indicator-style=slash, to avoid confusion with ls --directory.
320 * src/ls.c (usage): Likewise.
321 (slash): Renamed from directory_only. All uses changed.
323 2005-05-01 Paul Eggert <eggert@cs.ucla.edu>
325 * NEWS: "chmod +1 foo" is now diagnosed.
327 2005-04-29 Paul Eggert <eggert@cs.ucla.edu>
329 * NEWS: ls -p now marks only directories. New option
330 --indicator-style=directory equivalent to -p.
331 * doc/coreutils.texi (ls invocation): Document this.
332 Also, mention ">" is for doors.
333 * src/ls.c (enum indicator_style): New constant directory_only,
335 (indicator_style_args, indicator_style_types): Set it appropriately.
336 (decode_switches, gobble_file, print_type_indicator):
337 (length_of_file_name_and_frills):
338 Implement the change described in NEWS.
339 (decode_switches): Quote ">", too.
340 (usage): Update to match the new behavior. Describe ">".
341 * tests/ls/file-type: Test for new behavior. Omit -1 option.
342 The "ls --color" test wasn't being checked; add a check for
343 "ls --color=auto" instead.
345 * tests/head/Test.pm: Don't set _POSIX2_VERSION; no longer needed.
346 * tests/misc/split-fail: Likewise.
347 * tests/pr/Test.pm: Likewise.
348 * tests/sort/Test.pm: Fix comment to match new behavior of "sort".
349 * tests/tail/Test.pm (tv): Rename tests from obs to obs-plus
350 if they use file names starting with +.
351 (test_vector): Don't set _POSIX2_VERSION if obs but not obs-plus.
352 * tests/uniq/Test.pm (tv, test_vector): Likewise.
354 The following was partly derived from a tiny change by Eric Blake:
355 * tests/misc/nice: Don't use 'set -'. It's not portable to strict
356 POSIX 1003.1-2001 hosts. Also, don't set _POSIX2_VERSION.
357 * tests/mkdir/perm: Don't use 'set -'. Simplify test construction.
358 Work even if the underyling system attaches ACLs to new dirs.
359 * tests/mv/part-hardlink: Don't use 'set -'.
360 * tests/stty/row-col-1: Don't use 'set -'.
362 2005-04-28 Paul Eggert <eggert@cs.ucla.edu>
364 * NEWS: Document fixes described below.
365 * src/chmod.c (change, umask_value): New static vars.
366 (reference_file): Move this static var to inside "main".
367 (process_file, process_files): Remove CHANGES arg; now taken from
368 static var. All uses changed.
369 (usage): Fix incorrect description of MODE operand.
370 (main): For invalid mode usages, output a brief usage message.
371 Adjust to new modechange API.
372 * install.c (main): Adjust to new modechange API.
373 Also, free the mode_change object when done.
374 * mkdir.c (main): Likewise.
375 * mkfifo.c (main): Likewise.
376 * mknod.c (main): Likewise.
377 * tests/chmod/equal-X: Check for =xX bug.
378 * tests/chmod/equals: Check for =u bug.
379 * tests/chmod/usage: Check for u+gr and ug,+x bugs.
381 2005-04-26 Paul Eggert <eggert@cs.ucla.edu>
383 Restore support for usages like "head -1" and "tail -1",
384 even when conforming to POSIX 1003.1-2001.
385 Fix bug with "POSIXLY_CORRECT=1 fold file -3".
386 join now supports a NUL field separator, e.g., "join -t '\0'".
387 join now detects and reports incompatible options, e.g.,
389 * NEWS: Document this.
390 * src/date.c: Remove posixver.h and its uses.
391 (COMMON_SHORT_OPTIONS): Remove.
392 (short_options): New constant.
393 (short_options, usage): -I now always takes an optional arg.
394 * src/expand.c: Remove posixver.h and its uses.
395 (shortopts): New constant. -DIGIT now always takes an optional arg.
396 (main): Revamp parsing of -DIGIT to let parse_tab_stops handle it.
397 Don't complain about -DIGIT.
398 * src/fold.c: Remove posixver.h and its uses.
399 (shortopts): New constant. -DIGIT now always takes an optional arg.
400 (main): Don't preprocess arg list; that was buggy. Use method
402 * src/head.c: Remove posixver.h and its uses.
403 (header_mode_option): Remove.
404 (main): Don't complain about obsolete -NUM args.
405 * src/join.c: Remove posixver.h and its uses.
406 (obsolete_usage): Remove.
407 (join_field_1, join_field_2): Initialize to SIZE_MAX to indicate
408 they haven't been set yet.
409 (tab): Now int, not char. Initialize to -1 to indicate white space
410 separates columns, so that we can use NUL as a separator.
412 (OBSOLETE_LONG_OPTIONS, get_option): Remove.
413 (string_to_join_field): Remove ERR_MSG_FMT arg; a single format
414 suffices. Use xstrtoul for sizes; it suffices.
415 (decode_field_spec): Report an error and exit on failure. Return void,
417 (add_field_list): Likewise.
418 (set_join_field): New function.
419 (enum operand_status): New enum.
420 (add_file_name): New args OPERAND_STATUS, JOPTION_COUNT,
421 PREV_OPTC_STATUS, OPTC_STATUS to handle the bewildering array of
422 possibilities with obsolete option parsing.
423 (main): Use it. Do not depend on POSIX version.
424 Check for conflicting options. Parse obsolete options -j1 and -j2
425 so that it is a pure extension to POSIX 1003.1-2001.
426 Allow '-t\0' to specify a NUL tab, stealing the code from 'sort'.
427 * src/nice.c: Remove posixver.h and its uses.
428 (main): Always support -NUM option.
429 * src/od.c: Remove posixver.h and its uses.
430 (short_options): New constant, which always supports -w[num].
431 (COMMON_SHORT_OPTIONS): Remove.
432 * src/pr.c: Remove posixver.h and its uses.
433 (short_options): New constant, which always supports -S[string].
434 (COMMON_SHORT_OPTIONS): Remove.
435 * src/sort.c: Remove posixver.h and its uses.
436 (short_options): New constant, which always supports -y arg.
437 (COMMON_SHORT_OPTIONS): Remove.
438 (main): Redo workaround for Solaris compatibility with -y.
439 This change isn't visible to the user; it just cleans up the
440 code so that we don't need posixver.h.
441 * src/split.c: Remove posixver.h and its uses.
442 (main): Don't complain about -NUM option.
443 * src/tail.c (parse_obsolete_option): Don't complain about -NUM.
444 * src/unexpand.c: Remove posixver.h and its uses.
445 (main): Don't complain about -TAB.
446 * src/uniq.c (main): Don't complain about -NUM.
448 2005-04-22 Paul Eggert <eggert@cs.ucla.edu>
450 * src/nohup.c (main): If getopt fails, exit with status 127,
451 not status 1. POSIX requires this.
452 * NEWS: Document this.
454 * src/nice.c (main): Report proper program name when getopt finds
455 trouble. Problem reported by Behdad Esfahbod.
457 * NEWS: Fix bug with "mkdir -m =+x dir"; the umask was being ignored
458 when the "+x" was being evaluated.
459 * mkdir.c (main): Compile mode with MODE_MASK_ALL and initial umask.
460 * mkfifo.c (main): Likewise.
461 * mknod.c (main): Likewise.
462 * tests/mkdir/perm: Test for the above bug.
464 2005-04-20 Paul Eggert <eggert@cs.ucla.edu>
466 Port test cases to Microsoft-Windows-related environments,
467 following suggestions from Eric Blake.
468 * tests/install/Makefile.am (TESTS_ENVIRONMENT): Add EXEEXT.
469 * tests/install/basic-1: Undo previous change.
470 (dd, dd2): New vars, which use $EXEEXT. All uses of dd and dd2 changed.
471 * tests/install/trap: Undo previous change.
472 (sig): New var. Use it insted of "trap '' CHLD".
473 Append $EXEEXT to executable name.
475 "fetish" -> "coreutils" in more places.
476 * tests/Coreutils.pm: Renamed from tests/Fetish.pm.
477 (package Coreutils): Renamed from package Fetish. All uses changed.
478 * tests/Makefile.am (EXTRA_DIST): Add Coreutils.pm and
481 2005-04-19 Paul Eggert <eggert@cs.ucla.edu>
483 * tests/mv/setup (dot_mount_point): Use stat -L, in case the
484 directory is actually a symbolic link. Problem reported by
487 * tests/mv/mv-special-1: Use test -p to test for fifos, rather
488 than the (incorrect) test -f and the (inadequate) ls. ls is
489 inadequate because on some hosts a buggy mv will create a file of
490 the wrong type (problem reported by Eric Blake). Skip this test
491 if test -p doesn't work.
493 * tests/chmod/setgid: Use numeric group ids, not symbolic group names,
494 since the latter can have shell metacharacters in them (e.g., spaces).
495 This follows up to the 2005-01-17 patch, which missed this occurrence.
497 2005-04-18 Paul Eggert <eggert@cs.ucla.edu>
499 "fetish" -> "coreutils" in several places.
500 * Makefile.cfg (ftp): Remove fetish.sf.net.
501 * Makefile.maint (emit_upload_commands): Likewise.
502 * src/Makefile.am (LDADD, $(PROGRAMS)): fetish -> coreutils.
503 * tests/group-names (COREUTILS_GROUPS): Renamed from FETISH_GROUPS.
504 * tests/chmod/setgid (FETISH_GROUP): Renamed from COREUTILS_GROUP.
506 * tests/install/basic-1: Use "cat", not "test", to test for
507 ../../src/dd. Problem reported by Eric Blake.
509 2005-04-18 Jim Meyering <jim@meyering.net>
511 * src/dd.c: Don't include stat-macros.h directly. system.h does that.
513 2005-04-17 Paul Eggert <eggert@cs.ucla.edu>
515 Work around a couple of "make check" failures reported for Cygwin
516 and ash by Eric Blake.
517 * tests/install/basic-1: Skip this test if ../../src/dd isn't readable.
518 * tests/install/trap: Skip this test if "trap '' CHLD" doesn't work.
520 2005-04-16 Jim Meyering <jim@meyering.net>
522 * src/dd.c (S_TYPEISSHM): Remove definition.
523 Get the definition by including "stat-macros.h", instead.
525 2005-04-14 Paul Eggert <eggert@cs.ucla.edu>
527 Fix test suite problems reported by Eric Blake on Cygwin.
528 * tests/mv/mv-special-1: Ignore chatter about when files are removed,
529 since POSIX doesn't require rename to fail across file systems.
530 * tests/mv/setup (dot_mount_point): Use stat rather than df, as
532 (other_partition_tmpdir): Remove df from name as that would be
535 2005-04-14 Jim Meyering <jim@meyering.net>
537 * src/chown-core.c: Correct typo, fchmod -> fchown, in a comment.
539 2005-04-12 Paul Eggert <eggert@cs.ucla.edu>
541 * src/ls.c (usage): "uid" -> "user ID".
543 2005-04-12 Jim Meyering <jim@meyering.net>
545 * src/tsort.c (tsort): Use "%s" as the format string,
546 rather than a diagnostic or a file name.
548 * src/comm.c (compare_files): Remove declaration of unused local.
550 * src/chown-core.c (chopt_free): Mark parameter as unused.
552 2005-04-11 Paul Eggert <eggert@cs.ucla.edu>
554 * man/chown.x: Reword to match user manual.
555 * man/id.x: Likewise.
556 * src/setuidgid.c (usage): Use "user ID", not "UID", and similarly
558 * src/whoami.c (usage, main): Likewise.
560 Add bulletproofing for cases where stdin, stdout, or stderr are closed.
561 * src/comm.c: Include stdio-safer.h.
562 (compare_files): Exit right away on I/O error rather than continuing
563 and producing confusing output and error messages.
564 Return void, not int; all callers changed.
565 Use fopen_safer to avoid confusion with file descriptors.
566 * src/copy.c: Include unistd-safer.h.
567 (copy_reg): Use fd_safer.
568 * src/csplit.c: Include stdio-safer.h.
569 (input_desc): Remove unnecessary static initialization.
570 (set_input_file): Use STDIN_FILENO, not 0.
571 (create_output_file): Use fopen_safer.
572 * src/dircolors.c (dc_parse_file): Don't assume fopen does not
574 * src/head.c (head_file): Don't assume open does not return 0.
575 * src/join.c: Include stdio-safer.h.
576 (main): Use fopen_safer. Simplify the resulting code.
577 * src/md5sum.c (digest_file, digest_check):
578 Don't assume that fopen does not return stdin.
579 * src/nohup.c: Include unistd-safer.h.
580 (main): Don't dup stderr to stdin or stdout by mistake.
581 * src/od.c (check_and_close): Don't assume fopen does not return stdin.
582 * src/paste.c (paste_serial): Likewise.
583 * src/pr.c: Include stdio-safer.h.
584 (open_file): Use fopen_safer.
585 (close_file): Don't assume fopen does not return stdin.
586 * src/ptx.c (main): Don't assume fopen returns stdout after closing
587 stdout. Use freopen instead.
588 * src/shred.c: Include unistd-safer.h.
589 (wipename): Use fd_safer on directory file descriptor.
590 (wipefile): Remove special case for /dev/fd/* on older hosts.
591 It didn't work in general, and wasn't documented.
593 * src/sort.c: Include unistd-safer.h.
594 (create_temp_file): Use fd_safer.
595 (xfclose): Don't assume fileno (stdin) == STDIN_FILENO, etc.
596 * src/split.c: Include unistd-safer.h.
597 (cwrite): Use fd_safer. Replace mystery constant 0666 with symbolic
598 version, as POSIX requires.
599 * src/sum.c (bsd_sum_file, sysv_sym_file):
600 Use same pattern as elsewhere for checking for stdin.
601 * src/tac.c: Include unistd-safer.h.
602 (copy_to_temp): Use fd_safer.
603 (tac_file): Don't assume fopen cannot return stdin.
604 * src/tail.c: Include unistd-safer.h rather than fcntl-safer.h.
605 (recheck, tail_file): Use fd_safer rather than open_safer.
606 * src/tee.c: Include stdio-safer.h.
607 (tee): Use fopen_safer.
608 * src/touch.c: Include unistd-safer.h.
609 (touch): Use fd_safer.
610 * src/tsort.c (have_read_stdin): Remove; no longer needed. All uses
612 (tsort): Do not assume fopen can't return stdin.
613 Close stdin before returning. All uses changed.
614 * src/unexpand.c (next_file): Don't assume fopen cannot return stdin.
615 * src/uniq.c: Include stdio_safer.h.
616 (check_file): Don't assume fopen cannot return stdin or stdout.
618 2005-04-09 Jim Meyering <jim@meyering.net>
620 * src/dd.c (quit): Define with ATTRIBUTE_NORETURN.
622 Now that close_stdout closes standard output unconditionally,
623 these workarounds for dd and cat are no longer necessary.
624 * src/dd.c (close_stdout_wrapper): Remove function.
625 (main): Call atexit with close_stdout, instead.
626 * src/cat.c (close_stdout_wrapper): Likewise.
627 Don't close STDOUT_FILENO explicitly; close_stdout does it.
629 * src/system.h (__attribute__): Readability nit:
631 # define __attribute__(x)
633 # define __attribute__(x) /* empty */
635 2005-04-09 Jim Meyering <jim@meyering.net>
637 * src/rm.c (usage): Mention that --recursive removes listed
638 directories too, not just their contents.
639 Say that by default, rm does not remove directories.
641 * src/pr.c: Don't include "timespec.h". system.h does that.
642 * Makefile.maint (sc_system_h_headers): Propagate exit status
645 2005-04-08 Paul Eggert <eggert@cs.ucla.edu>
647 * NEWS: Document that dd no longer treats QUIT or PIPE specially,
648 and when conforming to POSIX no longer treats USR1 specially.
649 Document that dd no longer dumps core when handling signals.
650 * src/system.h (RETSIGTYPE): Remove; no longer needed. All uses
652 * src/csplit.c (SA_NOCLDSTOP): Define to 0 if not defined.
654 (siginterrupt) [!HAVE_SIGINTERRUPT]: New macro.
655 (delete_all_files): New arg IN_SIGNAL_HANDLER, to avoid undefined
656 behavior when called from a signal handler. All uses changed.
657 (main) [!defined SA_NOCLDSTOP]:
658 Use siginterrupt to specify that system calls should be interrupted.
659 * src/dd.c: Do not include safe-read.h or full-write.h; no longer needed.
660 (process_signals): Add forward decl.
661 (SA_NOCLDSTOP, sigprocmask, sigset_t) [!defined SA_NOCLDSTOP]:
663 (siginterrupt) [! HAVE_SIGINTERRUPT]: New macro.
664 (SA_NODEFER) [!defined SA_NODEFER]: New macro.
665 (SA_RESETHAND) [!defined SA_RESETHAND]: New macro.
666 (caught_signals, interrupt_signal, info_signal_count, catch_siginfo):
668 (usage): Mention -USR1 versus -INFO.
669 (cleanup): Don't invoke print_stats; the caller must do it now.
671 (quit): Process signals just before exiting.
672 (interrupt_handler): Simply record the signal and return.
673 (siginfo_handler): Simply increment the signal counter and return.
674 (install_handler): Remove, replacing with:
675 (install_signal_handlers, process_signals, iread, iwrite):
676 New functions. All callers to safe_read and full_write replaced
677 by iread and iwrite. All callers to install_handler replaced by
679 * src/ls.c (SA_NOCLDSTOP): Define to 0 if not defined.
681 (siginterrupt) [! HAVE_SIGINTERRUPT]: New macro.
682 (main) [! SA_NOCLDSTOP]: Use it.
683 * src/shred.c: Remove all uses of signals; modern hosts have
684 /dev/random and don't need this gorp.
685 Do not include signal.h.
686 (env, sigill_handler, isaac_seed_machdep): Remove. All uses removed.
687 * src/sort.c (SA_NOCLDSTOP): Define to 0 if not defined.
689 (siginterrupt) [! HAVE_SIGINTERRUPT]: New macro.
690 (main) [! SA_NOCLDSTOP]: Use it.
692 * src/dd.c: Do not include inttostr.h, no longer needed.
693 (print_stats, main): Rewrite and simplify formats to use PRIuMAX
694 instead of umaxtostr.
695 (print_stats): Work even in languages that have special
696 forms for two of things, for r_truncate and w_bytes. We can't
697 fix delta_s in this way, since ngettext doesn't support floating-point.
698 (main): Rewrite to avoid casts.
700 2005-04-07 Jim Meyering <jim@meyering.net>
702 Placate gcc-4's -Wuninitialized.
703 * src/md5sum.c (digest_check) [lint]: Initialize hex_digest to NULL.
704 * src/test.c (binary_operator) [lint]: Initialize lt and rt to 0.
706 * src/test.c (is_int, age_of, binop): Declare `char *' parameters to
708 (binop): Move function definition to precede first use so we can...
709 (binop): ...remove prototype.
711 2005-04-05 Paul Eggert <eggert@cs.ucla.edu>
713 * man/Makefile.am (.x.1): Remove "COMMAND.td/" from examples.
714 * src/basename.c (usage): Add examples.
715 * src/cat.c (usage): Likewise.
716 * src/chgrp.c (usage): Likewise.
717 * src/chown.c (usage): Likewise.
718 * src/dirname.c (usage): Likewise.
720 2005-04-05 Jim Meyering <jim@meyering.net>
722 * src/nice.c (usage): Mention that some shells provide a
723 built-in function by the same name.
724 * src/nohup.c (usage): Likewise.
725 * src/printenv.c (usage):Likewise.
727 2005-04-04 Dmitry V. Levin <ldv@altlinux.org>
729 * src/tee.c (tee): When closing files, do not close stdout,
730 leave this job to close_stdout() instead.
731 * configure.ac (AC_CONFIG_FILES): Add tests/tee/Makefile.
732 * tests/Makefile.am (SUBDIRS): Add tee.
733 * tests/tee/Makefile.am: New file.
734 * tests/tee/.cvsignore: Likewise.
735 * tests/tee/{basic,dash}: New tee tests.
737 2005-04-04 Jim Meyering <jim@meyering.net>
739 * src/echo.c (usage): Mention that some shells provide a
740 built-in function by the same name.
741 * src/kill.c (usage): Likewise
742 * src/printf.c (usage): Likewise.
743 * src/pwd.c (usage): Likewise.
744 * src/stat.c (usage): Likewise.
745 * src/test.c (usage): Likewise.
746 * src/true.c (usage):
747 * src/system.h (USAGE_BUILTIN_WARNING): New macro.
749 * man/echo.x: Remove `DESCRIPTION' section, now that --help includes it.
750 * man/printf.x: Likewise.
751 * man/pwd.x: Likewise.
753 2005-04-03 Jim Meyering <jim@meyering.net>
755 * src/pr.c (main): Fix off-by-one error.
756 pr -$(perl -e 'print "0"x63 . 1') would write one byte beyond the
757 end of a malloc'd buffer.
759 2005-04-01 Jim Meyering <jim@meyering.net>
761 * src/pr.c (main): Free column_count_string when done with it.
763 Don't let pr treat +1:-1 like +1:18446744073709551615.
764 * src/pr.c (strtoumax): Remove declaration.
765 (first_last_page): Use xstrtoumax in place of strtoumax,
766 so we don't interpret a negative page number (e.g., in an option
767 like --pages=1:-1) as valid.
768 * tests/pr/Test.pm (neg-page): Add a test for this.
770 2005-03-30 Paul Eggert <eggert@cs.ucla.edu>
772 * src/pinky.c (short_pinky): Adjust to read_utmp signature change.
773 * src/uptime.c (uptime): New arg OPTIONS. All uses changed.
774 * src/users.c (users): Likewise.
775 * src/who.c (who): Likewise.
776 * src/uptime.c (main): Check PIDs when invoked with zero arguments.
777 * src/users.c (main): Likewise.
778 * src/who.c (main): Likewise. Also with two arguments.
779 Omit duplicate code in 2-arg case.
780 (UT_PID): Moved to ../lib/readutmp.h.
782 2005-03-29 Jim Meyering <jim@meyering.net>
784 * src/system.h (ptr_align): Declare `ptr' parameter to be a
785 `const' pointer, since this function never writes through it.
787 * src/uname.c: Indent cpp directives to reflect nesting.
789 2005-03-28 Jim Meyering <jim@meyering.net>
791 * src/seq.c (get_width_format) [HAVE_RINT && HAVE_MODF && HAVE_FLOOR]:
792 Add `void' to make this an ANSI-style function declaration.
793 * src/remove.c (ds_init): Likewise.
794 * src/pr.c (print_sep_string): Likewise.
796 * src/stty.c (speeds): Declare this array to be static.
797 * src/Makefile.am (sc_tight_scope): Adjust to catch any
798 new declarations like that of stty.c's `speeds'.
800 * src/system.h (GETOPT_HELP_OPTION_DECL): Use NULL, not `0'.
801 (GETOPT_VERSION_OPTION_DECL): Likewise.
802 * src/chown.c (long_options): Likewise.
803 * src/chgrp.c (long_options): Likewise.
804 * src/chmod.c (long_options): Likewise.
805 * src/cp.c (sparse_type_string, reply_args, decode_preserve_arg):
807 * src/chown-core.c (chopt_init): Likewise.
808 * src/comm.c (long_options): Likewise.
809 * src/copy.c (copy_reg): Likewise.
810 * src/csplit.c (extract_regexp): Likewise.
811 * src/cut.c (longopts): Likewise.
812 * src/date.c (time_spec_string): Likewise.
813 * src/df.c (find_mount_point, show_point): Likewise.
814 * src/expr.c (docolon): Likewise.
815 * src/fmt.c (long_options): Likewise.
816 * src/ls.c (time_style_args, indicator_style_args, long_options)
817 (format_args, sort_args, time_args, decode_switches)
818 (gobble_file): Likewise.
819 * src/md5sum.c (long_options): Likewise.
820 * src/mv.c (reply_args): Likewise.
821 * src/paste.c (longopts): Likewise.
822 * src/pinky.c (print_entry): Likewise.
823 * src/pr.c (long_options): Likewise.
824 * src/ptx.c (long_options, format_args): Likewise.
825 * src/readlink.c (longopts): Likewise.
826 * src/sort.c (long_options, mergefps): Likewise.
827 * src/stat.c (long_options): Likewise.
828 * src/tac.c (main): Likewise.
829 * src/tail.c (follow_mode_string): Likewise.
830 * src/touch.c (longopts, time_args): Likewise.
831 * src/uniq.c (delimit_method_string): Likewise.
832 * src/uptime.c (print_uptime): Likewise.
833 * src/who.c (print_user): Likewise.
835 2005-03-27 Jim Meyering <jim@meyering.net>
837 * src/dcgen: Simplify further, clean up.
838 Add a standard-output-closing global destructor.
840 * src/wheel-gen.pl: Use the same global destructor as dcgen.
842 2005-03-26 Paul Eggert <eggert@cs.ucla.edu>
844 * src/dcgen: Squeeze multiple blanks into one. Output a simple
845 array of adjacent strings rather than a more complicated data
846 structure; this saves space in the dircolors executable.
847 * src/dircolors.c (parse_line): Use char *, not unsigned char *.
849 (dc_parse_stream, main): Avoid casts.
850 Adjust to simpler data structure generated by new dcgen.
852 2005-03-25 Eric Blake <ebb9@byu.net> (tiny change)
854 * src/ls.c (usage): Document usage of LS_COLORS.
856 2005-03-25 Paul Eggert <eggert@cs.ucla.edu>
858 * src/dircolors.hin: Add "TERM cygwin".
860 2005-03-25 Jim Meyering <jim@meyering.net>
862 * src/system.h (DECIMAL_DIGIT_ACCUMULATE): Reverse the sense of
863 the return value, and update callers:
864 * src/cut.c (set_fields): Update use of DECIMAL_DIGIT_ACCUMULATE.
865 * src/expand.c (parse_tab_stops, main): Likewise.
866 * src/split.c (main): Likewise.
867 * src/unexpand.c (parse_tab_stops, main): Likewise.
868 * src/uniq.c (main): Likewise.
870 2005-03-22 Jim Meyering <jim@meyering.net>
872 * build-aux: New directory. Renamed from config.
873 * configure.ac: Reflect renaming: config -> build-aux.
874 * Makefile.am (dist-hook): Likewise.
875 * Makefile.maint: Likewise.
876 * Makefile.cfg (cvs_files): Likewise.
877 * .x-sc_sun_os_names: Likewise.
878 * .x-sc_trailing_blank: Likewise.
880 * src/ls.c (get_funky_string): Use '\a', rather than 7, for
881 portability to EBCDIC hosts.
883 2005-03-20 Jim Meyering <jim@meyering.net>
885 * src/pr.c (init_header): Add missing `%' in new format string.
886 (init_header): Use zero-filled `.%09d' format, not space-filled `.%9d'.
888 2005-03-19 Jim Meyering <jim@meyering.net>
890 * src/Makefile.am (pr_LDADD): Now that pr uses gettime, add
891 $(LIB_CLOCK_GETTIME) to get the required -lrt on newer Linux systems.
893 2005-03-18 Paul Eggert <eggert@cs.ucla.edu>
895 * NEWS: pr -D "FORMAT" now accepts the same formats that
897 * src/pr.c: Include strftime.h, timespec.h.
898 (init_header): Obtain and format nanosecond part of time stamp.
900 * NEWS: nohup now ignores the umask when creating nohup.out.
901 nohup now closes stderr if it is a terminal and stdout is closed.
902 * src/nohup.c (main): Likewise. Be a little more paranoid about
903 return values; e.g., check for any negative return from open.
904 Assume free (NULL) works.
905 Close file descriptor leak when redirecting standard output to a file.
907 2005-03-17 Jim Meyering <jim@meyering.net>
909 * src/cut.c (set_fields): Use DECIMAL_DIGIT_ACCUMULATE macro,
910 in place of functionally-equivalent code.
911 * src/expand.c (parse_tab_stops, main): Likewise.
912 * src/split.c (main): Likewise.
913 * src/unexpand.c (parse_tab_stops, main): Likewise.
914 * src/uniq.c (main): Likewise.
915 * src/od.c: Use VERIFY macro in place of an equivalent open-coded
917 * src/system.h (VERIFY, VERIFY_EXPR, DECIMAL_DIGIT_ACCUMULATE):
920 Before, this command would make uniq skip 11 fields and print
922 $ _POSIX2_VERSION=1 ./uniq -f1 -1 <(seq --format='1 %g' 2)
925 * src/uniq.c (main): Interpret `uniq -f1 -1' like `uniq -f1',
926 not like `uniq -f11'.
928 2005-03-15 Jim Meyering <jim@meyering.net>
930 Both `pr -0' and e.g., `pr -03' would evoke `column count too large'.
931 `pr -0' should give a better diagnostic and `pr -03' should be
932 equivalent to `pr -3'.
933 * src/pr.c (parse_column_count): Change return type to void.
934 Call error (EXIT_FAILURE, ... for an invalid string.
935 (main): Allocate space for column_count_string using malloc.
936 Accumulate all old-style column-count digits before converting.
937 When the number of columns is specified via both old-style,
938 (e.g., -3), and a long option (--columns=5), ensure that only
939 the last one specified takes effect.
940 * tests/pr/Test.pm: Add tests for the above.
942 2005-03-15 Corinna Vinschen <corinna@vinschen.de> (tiny change)
944 * src/copy.c (copy_reg): Copy regular files in binary mode.
946 2005-03-14 Paul Eggert <eggert@cs.ucla.edu>
948 * NEWS: Restate why ls limits time stamp lengths.
950 2005-03-12 Jim Meyering <jim@meyering.net>
952 Add a little infrastructure to help prevent future bugs like the
954 * src/stat.c (xstrcat): New function.
955 (print_statfs, print_stat): Add buf_len parameter and convert all
956 uses of strcat to xstrcat. Update callers.
957 (print_it): Call print_func with buf_len parameter.
959 Invoking stat -c FMT with a lone format directive of %s, %f, %h, %s,
960 could cause a buffer overrun error.
961 * src/stat.c (print_it): Allocate 2 more bytes, to accommodate our
962 conversion of the stat %s format string to the longer printf %llu one.
963 Patch from Guochun Shi.
965 2005-03-11 Paul Eggert <eggert@cs.ucla.edu>
967 * src/ls.c (TIME_STAMP_LEN_MAXIMUM): New constant.
968 (long_time_expected_width, print_long_format): Use it, to avoid
969 some possible denial-of-service attacks.
970 * NEWS: Document this.
972 2005-03-11 Jim Meyering <jim@meyering.net>
974 Prompt once again for `mv -i A B' when A and B are hard links
975 to the same file. This fixes a bug introduced by my 2003-04-04
976 (coreutils-5.0.1) change. Reported by Thomas Wolff via Eric Blake.
977 * src/copy.c (abandon_move): New function, factored out of
978 copy_internal, now that this code is being used from two places.
979 (copy_internal): Perform the same interactive-related test for
980 whether it's alright to proceed and (usually) overwrite the
982 * tests/mv/i-4: Add tests for the above.
984 Don't segfault for a very long date format string, e.g.,
985 ls -ld --time-style=+%99999999H .
986 * src/ls.c (long_time_expected_width): Use x2nrealloc, not alloca,
987 so format string abuse cannot provoke stack overflow.
988 (print_long_format): Likewise.
990 Don't segfault for a long header date string, e.g.,
991 echo a|pr -D +%9999999A
992 * src/pr.c (init_header): Use x2nrealloc, rather than alloca.
993 Don't bother with fixed-sized initial buffer; always use x*alloc.
995 * src/pr.c (init_header): Use slightly clearer INT_BUFSIZE_BOUND
996 in place of equivalent INT_STRLEN_BOUND + 1.
997 * src/expr.c (tostring, printv): Likewise.
999 2005-03-09 Paul Eggert <eggert@cs.ucla.edu>
1001 * src/system.h: Include intprops.h.
1002 (TYPE_SIGNED, TYPE_MINIMUM, TYPE_MAXIMUM, INT_STRLEN_BOUND): Remove;
1003 they are now defined in intprops.h.
1005 2005-03-09 Jim Meyering <jim@meyering.net>
1007 * TODO: Remove entry about named pipes. It was fixed in 5.3.0.
1009 2005-03-08 Paul Eggert <eggert@cs.ucla.edu>
1011 * src/date.c (usage): Redo to match recent documentation changes.
1012 Don't bother documenting which usages are GNU extensions; the list
1013 wasn't correct, and is better left to the printed manual anyway.
1015 2005-03-06 Jim Meyering <jim@meyering.net>
1017 Factor out column-count processing.
1018 * src/pr.c: Include "inttostr.h".
1019 (parse_column_count): New function.
1020 (main): Use the new function for both old-style, -9, and long,
1021 --columns=-9, options.
1023 * src/cksum.c: Remove `register' keyword.
1024 * src/cut.c: Likewise.
1025 * src/dd.c: Likewise.
1026 * src/env.c: Likewise.
1027 * src/factor.c: Likewise.
1028 * src/fmt.c: Likewise.
1029 * src/fold.c: Likewise.
1030 * src/id.c: Likewise.
1031 * src/logname.c: Likewise.
1032 * src/ls.c: Likewise.
1033 * src/pr.c: Likewise.
1034 * src/printf.c: Likewise.
1035 * src/shred.c: Likewise.
1036 * src/sort.c: Likewise.
1037 * src/sum.c: Likewise.
1038 * src/test.c: Likewise.
1039 * src/tsort.c: Likewise.
1040 * src/uniq.c: Likewise.
1041 * src/wc.c: Likewise.
1042 * src/whoami.c: Likewise.
1044 2005-03-01 Paul Eggert <eggert@cs.ucla.edu>
1046 * src/Makefile.am (nanosec_libs): Remove $(LIB_XANOSLEEP); no
1049 2005-03-01 Jim Meyering <jim@meyering.net>
1051 * src/copy.c (copy_internal): Change test of source type from
1052 !S_ISREG to S_ISLNK. Reported by Paul Eggert in
1053 http://lists.gnu.org/archive/html/bug-coreutils/2004-10/msg00050.html.
1055 2005-02-28 Jim Meyering <jim@meyering.net>
1057 * NEWS: Mention that xnanosleep fixes sleep failure on linux-2.6.8.1.
1059 2005-02-21 Paul Eggert <eggert@cs.ucla.edu>
1061 * src/Makefile.am (dd_LDADD, shred_LDADD): Add $(LIB_GETHRXTIME).
1062 (nanosec_libs): Add $(LIB_XNANOSLEEP). Needed for newer GNU/Linux
1063 hosts with clock_gettime.
1065 2005-02-20 Paul Eggert <eggert@cs.ucla.edu>
1067 * NEWS: Describe user-visible change to dd.
1068 * src/Makefile.am (dd_LDADD, shred_LDADD, nanosec_libs):
1069 Remove $(LIB_CLOCK_GETTIME). These functions now use
1071 * src/dd.c: Include gethrxtime.h, xtime.h.
1072 (start_time): Now of type xtime_t, not struct timespec.
1073 (print_stats, main): Use gethrxtime rather than gettime.
1074 * src/ls.c (time): Remove obsolete decl.
1075 (get_current_time): gettimeofday always returns 0, so don't
1077 * src/shred.c: Include gethrxtime.h.
1078 (isaac_seed): Use gethrxtime rather than a mishmash.
1079 * src/touch.c (time): Remove obsolete decl.
1081 * tests/misc/split-fail: Don't assume that the current host
1082 supports integers wider than 32 bits. Fix comment typo.
1083 * tests/od/x8: Likewise.
1085 * src/chown-core.c (enum RCH_status): Remove trailing comma,
1086 as it's not valid in standard C89.
1088 2005-02-15 Jim Meyering <jim@meyering.net>
1090 * src/stat.c (human_fstype): Add case/definition for S_MAGIC_XFS
1091 so that file systems of type `xfs' are recognized as such.
1092 * src/fs.h: Regenerate.
1093 Reported by Bernd Eckenfels.
1094 * src/stat.c (human_fstype): Likewise for S_MAGIC_JFS/jfs.
1095 * src/fs.h: Regenerate.
1096 Reported by Andreas Schwab.
1098 * src/nice.c (NZERO) [NZERO == 0]: Undefine and define to 20,
1099 to work around the invalid definition from Darwin 7.7.0.
1100 Test failure reported by Sébastien Maret.
1102 2005-02-14 Paul Eggert <eggert@cs.ucla.edu>
1104 * src/sort.c (mergefps): Use binary search rather than linear one
1105 when comparing new line to lines already in main memory.
1106 Idea suggested by James Lemley.
1108 2005-02-09 Jim Meyering <jim@meyering.net>
1110 * src/copy.c (valid_options): Add an assertion that
1111 not both hard_link and symbolic_link are set.
1113 2005-02-08 Paul Eggert <eggert@cs.ucla.edu>
1115 * NEWS: Document stat -f -c %S, plus changes to default formats.
1116 * doc/coreutils.texi (stat invocation): Normalize terminology,
1117 capitalization, and sort order to match --help output. Mention %c
1118 for file systems. Add new -f -c format %S, and document %s versus %S;
1119 problem reported by Jeroen van Wolffelaar.
1120 * src/stat.c (usage): Likewise.
1121 (STATFS_FRSIZE): New macro.
1122 (print_statfs): Use it, for stat -f -c %S.
1123 (do_statfs): Change default formats to output %S.
1125 2005-02-03 Paul Eggert <eggert@cs.ucla.edu>
1127 * src/system.h: Include "memrchr.h".
1128 (memrchr) [!HAVE_DECL_MEMRCHR]: Remove decl.
1130 2005-02-02 Jim Meyering <jim@meyering.net>
1132 * tests/du/8gb: Also adjust the test (s/64/128/) to detect
1133 systems that don't support sparse files.
1134 Check for $2 -ge 128, rather than $2 = 128, in case
1135 there is a file system type that doesn't support sparse files,
1136 yet for which metadata takes up additional space.
1137 Both reported by Andreas Schwab.
1139 2005-02-01 Eric Blake <ebb9@byu.net> (tiny change)
1141 * tests/du/8gb: Create a larger test file, so we properly
1142 detect that sparse files can be created on NTFS under cygwin.
1144 2005-01-30 Jim Meyering <jim@meyering.net>
1146 * src/head.c (elide_tail_bytes_pipe): Correct wording in diagnostic.
1148 * src/stty.c: Remove unnecessary parentheses in all #if directives.
1150 2005-01-29 Eric Blake <ebb9@byu.net> (tiny change)
1152 * .cvsignore: Ignore config.cache and config.status.lineno.
1153 * src/stty.c [VSWTCH]: Some systems, like Cygwin, use VSWTC
1154 instead of VSWTCH, for use with CSWTCH.
1156 2005-01-29 Eric Blake <ebb9@byu.net> (tiny change)
1158 * tests/Makefile.am (.PHONY): Add check-root and root-hint.
1159 * tests/rwx-to-mode: Ignore ACL designation.
1160 * tests/setgid-check: Likewise.
1161 * tests/chown/separator: Quote user and group names.
1163 2005-01-24 Jim Meyering <jim@meyering.net>
1165 * src/cp.c (usage): Merge the descriptions of --no-dereference and -P.
1166 Suggestion from Johan Boule.
1168 2005-01-17 Eric Blake <ebb9@byu.net> (tiny change)
1170 * src/Makefile.am (all_programs.list): Strip $(EXEEXT) and remove
1172 * man/Makefile.am (all_programs): Revert previous patch; updated
1173 all_programs.list fixes this.
1174 (.x.1): No need to add $(EXEEXT).
1176 2005-01-03 Corinna Vinschen <corinna@vinschen.de> (tiny change)
1178 * src/system.h: Use S_BLKSIZE value for ST_NBLOCKSIZE where
1181 2005-01-22 Jim Meyering <jim@meyering.net>
1183 * Makefile.maint (v_etc_file): The version string has moved to
1184 version-etc-fsf.c, search that new file, not version-etc.c.
1186 2005-01-17 Paul Eggert <eggert@cs.ucla.edu>
1188 * tests/group-names: Use numeric group ids, not symbolic group names,
1189 since the latter can have shell metacharacters in them (e.g., spaces).
1190 Problem reported by Eric Blake.
1191 * tests/chgrp/basic: Assume groups are numeric, not symbolic.
1192 * tests/chgrp/deref: Likewise.
1193 * tests/chgrp/posix-H: Likewise.
1194 * tests/chgrp/recurse: Likewise.
1196 2005-01-15 Jim Meyering <jim@meyering.net>
1198 * src/shred.c (isaac_seed) [HAVE_GETHRTIME]: #if-0 this block,
1199 because just calling gethrtime evokes an `illegal instruction'
1200 failure when compiled with Sun's c89 on Solaris 8 and 9.
1201 Reported by Nelson Beebe.
1203 * src/shred.c (isaac_seed) [HAVE_GETHRTIME]: Don't call ISAAC_SEED
1204 twice with the same value of `t'.
1205 Replace nested #if-#else blocks with #if-#elif-#elif chain.
1207 2005-01-14 Jim Meyering <jim@meyering.net>
1209 The test, tests/tail/f-1, failed on powerpc-apple-darwin7.7.0.
1210 * src/tail.c (IS_TAILABLE_FILE_TYPE): Adjust definition also to include
1211 sockets, since that's what you get when reading from a command-line-
1212 supplied pipe on Darwin 7.7.
1213 (IS_PIPE_LIKE_FILE_TYPE): Define.
1214 (main): Use new IS_PIPE_LIKE_FILE_TYPE rather than simply S_ISFIFO.
1215 Reported by Nelson Beebe.
1216 This same change is also required on NetBSD/sparc-1.5.
1217 Reported by Adrian Bunk.
1219 * src/expr.c (toarith): Rewrite to detect/diagnose integer overflow,
1220 rather than suffering silently.
1221 Before, expr would silently overflow and wrap around:
1222 $ expr 9223372036854775808 = 0 # $(echo 2^63|bc)
1224 Now it detects the problem and exits nonzero:
1225 $ ./expr $(echo 2^63|bc) = 0
1226 ./expr: 9223372036854775808: integer is too large
1228 * tests/chown/separator (id_gn): Exit 77, not 1, for a test-framework
1229 failure, so that doesn't cause `make check' to stop. Nelson Beebe
1230 reported that this test would fail with the diagnostic,
1231 `cannot find name for group ID 10', on one of his systems.
1233 2005-01-13 Jim Meyering <jim@meyering.net>
1235 * src/test.c (is_int): Don't overflow when evaluating integer
1236 constants. Before, ./test $(echo 2^64|bc) -eq 0 && echo FAIL
1239 * tests/Fetish.pm (run_tests): Add code (if-0'd out) to detect
1240 names of temporary files that would clash on 8.3 file systems.
1241 * tests/mk-script (validate): Likewise.
1243 2005-01-12 Jim Meyering <jim@meyering.net>
1245 * tests/dd/skip-seek: Shorten test names to accommodate 8.3 systems.
1247 * tests/tr/Test.pm (repeat-xC): Change test name from
1248 `repeat-Compl', to avoid 8.3 conflict with `repeat-compl'.
1249 Reported by Eric Blake.
1250 (repeat-000): Rename to `repeat-zeros' for the same reason.
1252 2005-01-11 Jim Meyering <jim@meyering.net>
1254 * configure.ac: Update version to 5.3.1.
1256 2005-01-11 Eric Blake <ebb9@byu.net>
1258 * src/Makefile.am (check-README, check-AUTHORS): Account for $(EXEEXT).
1259 * man/Makefile.am (all_programs): Account for $(EXEEXT).
1261 2005-01-11 Jim Meyering <jim@meyering.net>
1263 * src/unexpand.c (add_tab_stop): Properly diagnose a tabstop list
1264 with decreasing values.
1266 * src/expand.c (main): Likewise.
1267 * src/unexpand.c (main): Check for overflow in tabstop values
1268 specified via the obsolete form. E.g., now this command fails:
1269 _POSIX2_VERSION=1 ./unexpand -$(echo '2^64+1'|bc)
1270 Before it would act like `_POSIX2_VERSION=1 ./unexpand -1'.
1271 * tests/unexpand/basic-1 (obs-ovflo): New test for this.
1273 2005-01-10 Paul Eggert <eggert@cs.ucla.edu>
1275 Respond to POSIX interpretations about pathchk -p dated 2005-01-06.
1276 * NEWS: Document the changes.
1277 * doc/coreutils.texi (pathchk invocation): Likewise.
1278 * src/pathchk.c (PORTABILITY_OPTION): New constant.
1279 (longopts, usage, main, validate_file_name):
1280 Add support for new -P option.
1281 Reject empty file names (unless -p is not specified and the
1282 current system allows empty file names).
1283 Change --portability so that is now equivalent to -p -P.
1284 Don't test whether file name is too long, if it is known to exist.
1285 (no_leading_hyphen): New function.
1286 * tests/misc/pathchk1: Add tests for empty file names and
1289 2005-01-08 Jim Meyering <jim@meyering.net>
1293 `pr --columns=N' was not equivalent to `pr -N' when also using
1296 * src/pr.c (main): Set `explicit_columns' for --columns=N,
1297 not just for -N. This bug has existed since the introduction
1298 of the --columns=N option on 1998-08-15.
1299 * NEWS: Document this.
1300 * tests/pr/Test.pm (test_vector): For each -N test, automatically
1301 create a new test vector using --columns=N.
1303 2005-01-07 Paul Eggert <eggert@twinsun.com>
1305 * src/pr.c (main): Check for column count overflow with
1306 usages like "pr -2147483648".
1308 2005-01-07 Jim Meyering <jim@meyering.net>
1310 * src/pr.c (init_fps): Use xnmalloc, rather than xmalloc.
1312 2005-01-06 Jim Meyering <jim@meyering.net>
1314 * README: List the precise HP-UX version numbers that are affected.
1315 Suggestion from Bob Proulx.
1317 * Makefile.maint (sc_changelog): Specify find's `-maxdepth 2'
1318 predicate before `-name ChangeLog' to avoid a harmless warning
1321 2005-01-05 Jim Meyering <jim@meyering.net>
1323 * tests/help-version: Punt on the uptime test, since it fails when
1324 it can't get boot time, and I don't want that to stop `make check'.
1326 * src/du.c (process_file): Evaluate exclusion rules against
1327 the entire file name, not just the last component.
1328 Reported by Robert Lindgren.
1329 * tests/du/exclude: Test for this.
1330 * NEWS: Document this.
1332 Ensure that tests/Makefile.am's check-root actions stay up to date.
1333 * Makefile.maint (sc_root_tests): New rule.
1334 (syntax-check-rules): Add it to the list.
1336 2005-01-04 Jim Meyering <jim@meyering.net>
1338 * man/shred.x: Change one-line summary to reflect that shred does
1339 not remove files by default. Suggestion from Helen Faulkner in
1340 http://bugs.debian.org/288552
1342 * README: Request VERBOSE=yes output when reporting test failures.
1343 Other minor changes.
1345 * tests/Makefile.am (check-root): Update.
1347 2005-01-03 Paul Eggert <eggert@cs.ucla.edu>
1349 * src/system.h: Undo previous change; we now use Autoconf.
1351 2005-01-03 Jim Meyering <jim@meyering.net>
1353 * tests/stty/row-col-1: Don't set rows or columns to zero, to avoid
1354 a bug in the TIOCGWINSZ ioctl on at least Solaris5.9 systems. Setting
1355 either (or both) to zero would succeed, but subsequent `stty size'
1356 would say `no size information for this device' due to the ioctl
1357 failing with EINVAL.
1359 * src/system.h: If PRIdMAX, PRIoMAX, PRIuMAX, and PRIxMAX are
1360 not all defined and either ULONG_MAX or ULLONG_MAX is not defined,
1361 then fail at compile-time rather than let tools like od produce
1362 invalid results at run time.
1364 2004-12-21 Jim Meyering <jim@meyering.net>
1366 * src/csplit.c (usage): Say the default names are `xx00, xx01, ...',
1367 not `xx01, xx02, ...'.
1368 Reported by Matt Kraai in http://bugs.debian.org/286605
1370 * tests/misc/split-fail: Avoid spurious failure on x86 Solaris5.9
1373 2004-12-20 Paul Eggert <eggert@cs.ucla.edu>
1375 * src/split.c (usage): Mention default size. Suggested by Dan Jacobson.
1377 2004-12-19 Paul Eggert <eggert@cs.ucla.edu>
1379 * NEWS: Mention that one should eval "`dircolors`" rather than
1382 2004-12-17 Jim Meyering <jim@meyering.net>
1384 * tests/mv/hard-link-1: Rearrange to use newer trap-handling code,
1385 so temporary directories aren't left behind upon e.g., interrupt.
1387 2004-12-16 Paul Eggert <eggert@cs.ucla.edu>
1389 * src/ls.c (print_dir): Use "%s: not listing already-listed
1390 directory", not "not listing already-listed directory: %s", to
1391 format already-listed directories, to be consistent with other
1392 diagnostics involving file names and colons.
1394 2004-12-15 Jim Meyering <jim@meyering.net>
1396 * src/Makefile.am (__LDADD): Define, so that building `[' on
1397 Solaris still uses the -lgen library that it requires in order
1398 to get a definition of eaccess.
1400 2004-12-14 Jim Meyering <jim@meyering.net>
1402 tac would exit immediately upon I/O or temp-file creation failure.
1403 Now it continues on, processing any remaining command line arguments.
1405 * src/tac.c: Include quotearg.h.
1406 Use quotearg_colon in most diagnostics.
1407 (copy_to_temp): Rewrite not to exit upon I/O or temp-file-creation
1408 failure. Before, this command (with /full/tmp being a full partition)
1409 TMPDIR=/full/tmp ./tac /proc/modules tac.c
1410 would exit immediately upon the write error while trying to copy
1411 non-seekable /proc/modules to the full partition. Now it still
1412 reports the failure but continues on with the remaining file.
1413 (tac_nonseekable): Return false also if copy_to_temp fails.
1414 [DONT_UNLINK_WHILE_OPEN]: Add a FIXME comment explaining that
1415 using atexit like this is wrong.
1416 * NEWS: Document this.
1417 * tests/misc/tac-continue: New test for this.
1418 * tests/misc/Makefile.am (TESTS): Add tac-continue.
1420 * tests/chown/basic: Add a few more tests.
1422 2004-12-13 Paul Eggert <eggert@cs.ucla.edu>
1424 * src/ls.c (gobble_file): Change arg name to be command_line_arg
1425 rather than explicit_arg, for consistency with copy.c.
1426 (extract_dirs_from_files): Remove ignore_dot_and_dot_dot arg, since
1427 it is deducible from dirname arg. All callers changed.
1428 (extract_dirs_from_files, print_dir, queue_directory):
1429 Add command_line_arg arg. All callers changed.
1430 (struct pending): Add command_line_arg member.
1431 (main): Use NULL rather than 0 when appropriate.
1432 (set_exit_status, file_failure): New functions.
1433 (queue_directory): Store command_line_arg into new structure.
1434 (print_dir, gobble_file, get_link_name):
1435 Use file_failure to report problems in accessing files,
1436 so that the exit status is set consistently.
1437 (print_dir): Simplify readdir failure code yet again.
1438 If closedir fails, report "closing directory" rather than "reading
1440 (xstrcoll): Use set_exit_status to set status on failure.
1441 * tests/ls-2/tests (no-a-isdir-b): This now exits with status 2,
1444 2004-12-11 Jim Meyering <jim@meyering.net>
1446 Avoid a race condition vulnerability in chown, when used with
1447 --from=O:G and without the (-h) --no-dereference option.
1448 * src/chown-core.c (restricted_chown): New function.
1449 (change_file_owner): Call it.
1450 Reported by Ulrich Drepper.
1451 * NEWS: Mention this.
1453 2004-12-09 Paul Eggert <eggert@cs.ucla.edu>
1455 * ls now exits with status 1 on minor problems, 2 if serious trouble.
1456 * NEWS: Document this.
1457 * src/ls.c (LS_MINOR_PROBLEM, LS_FAILURE): New constants.
1458 All uses of EXIT_FAILURE replaced with LS_FAILURE, unless
1460 (main): Initialize exit failure to LS_FAILURE.
1461 (print_dir, gobble_file, get_link_name, xstrcoll):
1462 Set exit status to LS_MINOR_PROBLEM if the failure is minor.
1463 (print_dir): Do not give up on entire directory merely because readdir
1465 (usage): Explain exit status.
1466 * tests/help-version: ls and variants now exit with status 2
1469 2004-12-08 Paul Eggert <eggert@cs.ucla.edu>
1471 * NEWS: Document new UTC+HH:MM date syntax, and put date changes
1474 2004-12-07 Paul Eggert <eggert@cs.ucla.edu>
1476 * src/factor.c (factor): Don't list 1 as a factor of 1.
1477 Problem reported by Thomas Folz-Donahue.
1479 2004-12-06 Jim Meyering <jim@meyering.net>
1481 * tests/du/files0-from: Sanitize environment.
1482 Otherwise, e.g., BLOCKSIZE=k would cause a failure, and that
1483 setting is the default (exported from /etc/profile) on at least one
1485 * tests/du/no-deref: Likewise.
1486 * tests/cp/symlink-slash: Likewise.
1487 * tests/ls/symlink-slash: Likewise
1489 2004-12-05 Jim Meyering <jim@meyering.net>
1491 * tests/tail/Test.pm (err-6) ["tail -c"]: Avoid test failure when
1492 _POSIX2_VERSION=199209 is in the environment, or when building on
1495 2004-12-04 Jim Meyering <jim@meyering.net>
1497 * NEWS: Mention cut's new --complement option.
1499 2004-10-01 Paolo Bonzini <bonzini@gnu.org>
1501 * cut.c (complement, COMPLEMENT_OPTION): New.
1502 (longopts): Add --complement.
1503 (usage): Say not that -b, -c, and -f `print' fields,
1504 but rather that they `select' fields for printing.
1505 Describe the new --complement option.
1506 (mark_range_start): Extracted from set_fields.
1507 (print_kth): Support --complement.
1508 (compare_ranges): New function.
1509 (set_fields): Rewrite the part that populates range_start_ht,
1510 merging it with the part that populates printable_field.
1511 (main): Handle --complement.
1513 2004-12-03 Paul Eggert <eggert@cs.ucla.edu>
1515 * src/tail.c (tail_file): Set errnum to -1 if the initial "tail"
1516 failed. This works around an assertion failure reported by
1518 http://lists.gnu.org/archive/html/bug-coreutils/2004-12/msg00012.html
1520 2004-12-02 Jim Meyering <jim@meyering.net>
1522 With using --color and with LS_COLORS saying not to color
1523 executables, don't stat every file.
1524 * src/ls.c (is_colored): New function.
1525 (gobble_file): Use it.
1526 (main): Use it here, in place of too-strict tests against NULL:
1527 if either ORPHAN or MISSING was set to 0 from LS_COLORS, the
1528 old test would fail.
1530 2004-12-01 Paul Eggert <eggert@cs.ucla.edu>
1532 * src/comm.c (compare_files): Assume setlocale exists.
1533 * src/join.c (keycmp): Likewise.
1534 * src/seq.c (decimal_point): Treat like sort. Now char.
1536 (main): Assume localeconv exists. Use same code as sort.
1537 * src/sort.c (C_DECIMAL_POINT): Remove. Use changed to '.'.
1538 Assume setlocale exists.
1539 (thousands_sep): Renamed from th_sep.
1540 (IS_THOUSANDS_SEP): Remove. All uses replaced by comparisons.
1541 (NONZERO): Parenthesize use of arg.
1542 (numcompare): Avoid duplicate loads. Use ISDIGIT as boolean, for
1543 consistency. Avoid unnecessary negation by reversing
1545 (main): Rewrite localeconv call to match seq.c.
1546 * src/system.h: Assume locale.h exists.
1547 (HAVE_SETLOCALE): Remove.
1548 * src/uniq.c (different): Assume setlocale exists.
1550 * src/ls.c (sort_files): Minor cleanup. Remove an unnecessary
1551 'volatile' on a local variable. Rewrite to avoid unnecessary
1552 double-assignment to 'func' in the usual case where strcoll does
1555 2004-11-30 Paul Eggert <eggert@cs.ucla.edu>
1557 * src/pinky.c (gethostname): Remove decl.
1558 (scan_entries): Use IS_USER_PROCESS instead of by-hand code.
1559 * src/uptime.c (print_uptime): Use IS_USER_PROCESS and
1560 UT_TYPE_BOOT_TIME instead of by-hand code.
1561 * src/users.c (list_entries_users): Use IS_USER_PROCESS
1562 instead of by-hand code.
1563 * src/who.c (USER_PROCESS, RUN_LVL, INIT_PROCESS, LOGIN_PROCESS,
1564 DEAD_PROCESS, BOOT_TIME, NEW_TIME, UT_TYPE_UNDEF, UT_TYPE): Remove.
1565 (IS_USER_PROCESS): Move to ../lib/readutmp.h.
1566 (UT_TYPE_RUN_LVL, UT_TYPE_INIT_PROCESS, UT_TYPE_LOGIN_PROCESS,
1567 UT_TYPE_DEAD_PROCESS, UT_TYPE_NEW_TIME): New macros.
1568 (gethostname): Remove decl.
1569 (list_entries_who, scan_entries): Use the new macros defined above,
1570 for consistency with pinky, uptime, and users.
1572 2004-11-25 Paul Eggert <eggert@cs.ucla.edu>
1574 Fix problem reported by Scott S. Tinsley for HP-UX 11.11 using
1575 HP's ANSI C compiler. Declaring int functions causes warnings on
1576 some modern systems and shouldn't be needed to compile on ancient
1578 * src/copy.h (stat, lstat, rename): Remove decls.
1579 * src/install.c (stat): Remove decl.
1580 * src/ln.c (link, symlink): Remove decls.
1582 2004-11-25 Jim Meyering <jim@meyering.net>
1584 * man/help2man: Import help2man-1.35.1.
1585 * man/Makefile.am (.x.1): Remove now-unnecessary use of
1586 locally-added --program-name=NAME option. Now, help2man gets
1587 the name from the [NAME] section (i.e. from our .x file).
1588 * man/install.x: Use `install', not `ginstall' in the one-line
1589 description. Reported by Brendan O'Dea.
1590 * man/sha1sum.x: Use `sha1sum', not `shasum'.
1592 2004-11-24 Jim Meyering <jim@meyering.net>
1594 Since the changes of 2004-05-22, the u.saved_cwd member at
1595 the bottom of the active-directory stack was no longer
1596 strictly necessary. This change removes that member and uses
1597 the newer cwd_state parameter for the final restore_cwd.
1599 * src/remove.c (struct AD_ent) [u]: Remove now-unnecessary union.
1600 [dev_ino]: Rename from `a'.
1601 (AD_pop_and_chdir): Add a parameter to play the role of just-removed
1602 bottom-of-stack cwd-state member.
1603 (AD_pop_and_chdir): No longer return boolean. Adjust caller.
1604 (AD_push_initial): Remove CWD parameter. Adjust caller.
1606 2004-11-23 Paul Eggert <eggert@cs.ucla.edu>
1608 Minor performance improvements and cleanups for "touch".
1609 * src/touch.c (posix_date): Remove; not needed as a static var.
1611 (touch): Use new futimens function to operate more efficiently
1612 in some cases. Don't stat/fstat existing file when
1613 (!amtime_now && change_times == (CH_ATIME | CH_MTIME)); the
1614 old time stamps aren't needed in that case.
1615 (main): change_times is int, not bool. Simplify test for
1618 2004-11-20 Paul Eggert <eggert@cs.ucla.edu>
1620 * src/install.c (usage): Avoid usage that runs afoul of Docbook
1621 translation. Problem reported by Eric S. Raymond.
1623 Restore dd's noctty flag, reverting the change of 2004-04-08.
1624 POSIX does not allow "dd" to use O_NOCTTY by default.
1625 * NEWS: Add noctty flag to dd.
1626 * doc/coreutils.texi (dd invocation): Likewise.
1627 * src/dd.c (flags, usage, main): Likewise.
1629 2004-11-19 Alfred M. Szmidt <ams@gnu.org>
1631 * src/ls.c (usage): Clarified description of --no-group (-G),
1632 --human-readable (-h), --inode (-i), --size (-s), --time,
1635 2004-11-19 Jim Meyering <jim@meyering.net>
1637 * src/ls.c (usage): Clarify description of --author.
1638 Tweak indentation so that help2man creates better nroff.
1639 Reported by Dan Jacobson.
1641 * src/uniq.c (check_file): Don't check stdout for errors here.
1643 * src/pwd.c (find_dir_entry): Update comment to match reality.
1645 2004-11-18 Jim Meyering <jim@meyering.net>
1647 * src/pwd.c (robust_getcwd): Correct the comment: this function
1648 constructs the directory name. The caller prints it.
1650 2004-11-16 Paul Eggert <eggert@cs.ucla.edu>
1652 * src/stat.c (STATFS): New macro, for portability to Solaris 9.
1653 (do_statfs): Use it.
1655 * src/basename.c, src/chroot.c, src/cksum.c, src/dd.c, src/dirname.c,
1656 src/factor.c, src/hostid.c, src/hostname.c, src/link.c, src/logname.c,
1657 src/nohup.c, src/printenv.c, src/pwd.c, src/setuidgid.c, src/sleep.c,
1658 src/sync.c, src/tsort.c, src/unlink.c, src/uptime.c, src/users.c,
1659 src/whoami.c, src/yes.c (main): Use getopt_long rather than getopt.
1660 * src/readlink.c (main): argv is not const.
1662 * src/cut.c (usage): Improve documentation along the lines suggested
1664 * src/echo.c (usage): Likewise.
1665 * src/expr.c (usage): Likewise.
1667 * src/dircolors.hin: Add putty, screen-bce.
1669 * src/pinky.c (print_entry): Fix memory leak.
1670 * src/who.c (print_user): Likewise.
1672 2004-11-15 Paul Eggert <eggert@cs.ucla.edu>
1674 * NEWS: New dd operand "status=noxfer".
1675 * src/dd.c (C_ASCII, C_EBCDIC, C_IBM, C_BLOCK, C_UNBLOCK,
1676 C_LCASE, C_UCASE, C_SWAB, C_NOERROR, C_NOTRUNC, C_SYNC, C_TWOBUFS,
1677 C_NOCREAT, C_EXCL, C_FDATASYNC, C_FSYNC): Now constants, not
1679 (STATUS_NOXFER, statuses): New constants.
1680 (usage, print_stats, scanargs): Add support for status=noxfer.
1681 (usage): Update status output to match new behavior.
1682 (print_stats): Always output complete byte count.
1683 Put space between numbers and units, as SI requires.
1684 Use ngettext so that i18n can use plurals for "byte" and "second".
1685 Don't multiply by 1e-9 (inexact); divide by 1e9 (which is exact).
1686 (iflag_error_msgid, oflag_error_msgid): Remove; replace uses by
1688 * tests/dd/skip-seek (@Tests): Use status=noxfer to avoid
1689 problems with regression testing.
1691 2004-11-14 Paul Eggert <eggert@cs.ucla.edu>
1693 * NEWS: dd now outputs total bytes, seconds, and bytes per second.
1694 * src/Makefile.am (dd_LDADD): Add $(LIB_CLOCK_GETTIME).
1695 * src/dd.c: Include "human.h".
1696 (w_bytes, start_time): New vars.
1697 (usage): Document new I/O statistics output
1698 (print_stats): Output new I/O statistics.
1699 (cleanup): Do statistics after closing stdin and stdout, so that
1700 the times are more accurate.
1701 (write_output, dd_copy): Count output bytes.
1702 (main): Get initial value of clock.
1704 2004-11-14 Jim Meyering <jim@meyering.net>
1706 Backslash-escape `-'s in email addresses, so that they are
1707 rendered properly in UTF-locales.
1708 * man/help2man (escape_hyphens): New function.
1709 (main): Call it on email addresses.
1711 * src/sort.c (zaptemp): Mark new diagnostic for translation.
1713 * tests/misc/close-stdout: New file. Test today's closeout.c change.
1714 * tests/misc/Makefile.am (TESTS): Add close-stdout.
1716 2004-11-13 Jim Meyering <jim@meyering.net>
1718 * src/test.c (usage): Put the description of `[-n] STRING'
1719 on two lines, one for `-n STRING' and one for `STRING' so that
1720 help2man properly escapes the `-'. Otherwise, the hyphen is
1721 rendered inappropriately in UTF-8 locales.
1722 Reported by Uwe Zeisberger in http://bugs.debian.org/281069.
1724 2004-11-12 Paul Eggert <eggert@cs.ucla.edu>
1726 * NEWS: Document the following changes.
1728 * src/sort.c: Avoid O(N**2) behavior when there are many temporary
1730 (temptail): New variable, so that we can easily append to list.
1731 (create_temp_file): Create new files at end of list, so that
1732 searching the list has O(N*NMERGE) behavior instead of O(N**2).
1733 (zaptemp): Update temptail if needed.
1734 (mergefps, merge): Accept new arg that counts temp files, and keep it
1735 up to date as we create and remove temporaries. This is for
1736 efficiency, so that we don't call zaptemp so often.
1737 All callers changed.
1738 (sort): Don't create array in reverse order, since the list of
1739 temporaries is now in the correct order.
1741 (zaptemp): Protect against race condition: if 'sort' is
1742 interrupted in the middle of zaptemp, it might unlink the
1743 temporary file twice, and the second time this happens the file
1744 might already have been created by some other process.
1746 (zaptemp): Warn if a temporary file is not removed.
1748 (create_temp_file): Use offsetof for clarity.
1749 (die): Move it up earlier, to clean up the code a bit.
1751 * src/pr.c (strtoumax): Declare if not declared.
1752 (skip_to_page, first_page_number, last_page_number, page_number,
1753 first_last_page, print_header):
1754 Use uintmax_t for page numbers.
1755 (first_last_page): Remove unnecessary forward declaration.
1756 Do not modify arg (it is now a const pointer).
1757 Return a true if successful, false (without print a diagnostic)
1759 (main): If +XXX does not specify a valid page range, treat it
1760 as a file name. This follows the response to Open Group XCU ERN 41
1761 <http://www.opengroup.org/sophocles/show_mail.tpl?source=L&listname=austin-group-l&id=7717>,
1762 which says the behavior is allowed.
1763 (skip_to_page): When starting page number exceeds page count,
1764 print both numbers in the diagnostic.
1765 (print_header): Detect page number overflow.
1767 2004-11-07 Jim Meyering <jim@meyering.net>
1769 * src/uname.c [__APPLE__]: Include <mach/machine.h> and <mach-o/arch.h>.
1770 (main) [__APPLE__]: Get the processor type via syscall rather than
1771 hard-coding "powerpc". From Toby Peterson.
1773 * src/sort.c (merge): Remove declarations of now-unused variables.
1775 2004-11-06 Paul Eggert <eggert@cs.ucla.edu>
1777 * src/sort.c (first_same_file): Remove. Move most of the code to....
1778 (avoid_trashing_input): New function.
1779 (merge): Avoid some silly merges, e.g., copying a single file to
1780 a temporary file when there are exactly 17 input files to merge.
1781 Take a count of temporary files rather than a max_merge arg.
1784 2004-11-06 Jim Meyering <jim@meyering.net>
1786 * src/sort.c (xfclose): Don't close stdout here (just flush it),
1787 since close_stdout now closes stdout unconditionally.
1789 2004-11-05 Paul Eggert <eggert@cs.ucla.edu>
1791 * src/sort.c (inittables, sort_buffer_size, getmonth, mergefps,
1792 first_same_file, merge, sort, main): Use size_t for indexes to arrays.
1793 This fixes some unlikely havoc-wreaking bugs (e.g., more than INT_MAX
1795 (getmonth, keycompare, compare): Rewrite to avoid need for alloca,
1796 thus avoiding unchecked stack overflow in some cases. As a side
1797 effect this improve the performance of "sort -M" by a factor of 4
1800 2004-11-03 Paul Eggert <eggert@cs.ucla.edu>
1802 * src/stty.c: Include "vasprintf.h" since we use vasprintf now.
1804 * src/Makefile.am (check-AUTHORS): Don't assume \? works in a sed
1805 expression; it's not portable. Problem reported by Albert Chin.
1806 Don't invoke a program more than once.
1807 * src/groups.sh (version): New variable, containing author info,
1808 for benefit of AUTHORS check. Use it when acting on --version option.
1809 * AUTHORS: Remove duplicate lines. Remove bogus "chroot:"
1812 * src/system.h: Don't #define and #undef getopt around <stdlib.h>,
1813 as this breaks the new regime that does "#define getopt rpl_getopt".
1814 Problem reported by Albert Chin for Solaris 9 with Sun cc in:
1815 http://lists.gnu.org/archive/html/bug-gnulib/2004-11/msg00019.html
1816 I suppose this may cause problems on ancient hosts with
1817 incompatible getopt declarations, but we'll cross that bridge if
1818 the problem gets reported to us by someone who can test the fix.
1820 2004-11-03 Jim Meyering <jim@meyering.net>
1822 * src/tac.c: quote(...) file names in diagnostics.
1824 2004-10-29 Paul Eggert <eggert@cs.ucla.edu>
1826 * NEWS: Document getdate changes.
1828 2004-10-29 Jim Meyering <jim@meyering.net>
1830 * src/tac.c (tac_file): Remove temporary prototype and move this
1831 function `down' so that it precedes definition of tac_nonseekable.
1833 `tac /proc/modules' would print nothing
1834 Reported by Harald Dunkel in http://bugs.debian.org/278604.
1836 * src/tac.c (copy_to_temp): Renamed from save_stdin, since
1837 now it copies a general file descriptor, not just stdin.
1838 (tac_nonseekable): Renamed/adapted from tac_stdin.
1839 (tac_file): Get fd via `open' directly rather than via fopen/fileno,
1840 since we never used the stream. Perform "-" to stdin mapping here
1841 rather than in main. Determine whether a file is seekable,
1842 by trying to `lseek' to its end, and dispatch to tac_seekable or
1843 tac_nonseekable accordingly.
1844 (main): Rewrite argument handling now that it uses only tac_file.
1845 * NEWS: Mention it here.
1847 2004-10-21 Jim Meyering <jim@meyering.net>
1849 * tests/mv/leak-fd: New file.
1850 * tests/mv/Makefile.am (TESTS): Add it.
1851 * tests/rm/dot-rel: New file.
1852 * tests/rm/Makefile.am (TESTS): Add it.
1854 Correct my patch of 2004-10-18.
1855 * src/remove.c (rm): Destroy the saved_cwd here (via cwd_state),
1856 if necessary, not in remove_dir. Otherwise, removing multiple
1857 `.'-relative nonempty directories no longer worked.
1859 2004-10-20 Paul Eggert <eggert@cs.ucla.edu>
1861 * src/fmt.c (usage): Improve description of --prefix.
1862 Problem reported by Edward Welbourne.
1864 * man/uniq.x: Change summary so that it doesn't imply that
1865 uniq writes to its input file. Problem reported by
1868 2004-10-18 Jim Meyering <jim@meyering.net>
1870 Plug a leak that would cause a cross-device mv to fail when
1871 operating on too many command-line-specified nonempty directories.
1872 * src/remove.c (remove_dir): Destroy the `struct saved_cwd' on the
1873 top of the stack before returning. This usually closes the file
1874 descriptor that was used to return to the original working directory.
1875 Reported by Cyril Bouthors in
1876 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/3048
1877 * NEWS: Mention it here.
1879 * src/pathchk.c (validate_file_name): Give a more descriptive
1880 diagnostic when pathconf fails. This also avoids an unwarranted
1881 warning from gcc-3.3.5 about a format not being a string literal.
1883 * src/sleep.c (main): Remove declaration of unused local, c.
1884 * src/printenv.c (main): Likewise.
1885 * src/logname.c (main): Likewise.
1886 * src/uptime.c (main): Likewise, for optc.
1887 * src/tsort.c (main): Likewise, for opt.
1889 2004-10-17 Paul Eggert <eggert@cs.ucla.edu>
1891 * AUTHORS: Add self to pathchk.
1892 * src/pathchk.c (AUTHORS): Add self.
1893 Change "path" to "file name" whenever possible.
1894 Remove usage comment, as it was a duplication of the code or doc.
1895 Include <wchar.h> if available.
1896 (mbrlen, mbstate_t) [! (HAVE_MBRLEN && HAVE_MBSTATE_T)]: Define.
1897 (NEED_PATHCONF_WRAPPER, PATH_MAX, PATH_MAX_FOR, NAME_MAX,
1898 pathconf_wrapper, portable_chars, dir_ok): Remove.
1899 (NAME_MAX_MINIMUM, PATH_MAX_MINIMUM): New macros.
1900 (pathconf, _PC_NAME_MAX, _PC_PATH_MAX): Define if nonexistent.
1901 (portable_chars_only): New arg FILELEN.
1902 Don't assume ASCII; we might be on an EBCDIC host.
1903 Don't assume unibyte locale in diagnostic.
1904 (component_start, component_len): New functions.
1905 (validate_file_name): Renamed from validate_path. All uses changed.
1906 Pretty much a complete rewrite.
1907 Don't make copy of file arg. Always append trailing slash to
1908 pathconf arg, just in case it's a symlink (this is pure paranoia;
1909 we don't know of any hosts where the trailing slash is required).
1910 Use size_t instead of long int when possible.
1911 Avoid need to call pathconf in most practical cases.
1912 Don't use euidaccess several times to test searchability;
1913 just use lstat once. Reword diagnostic to put the (often very long)
1916 2004-10-15 Paul Eggert <eggert@cs.ucla.edu>
1918 * src/printf.c (usage): Mention Unicode, and use H for hex digits.
1920 2004-10-13 Jim Meyering <jim@meyering.net>
1922 * NEWS: Mention today's fts.c fix.
1924 2004-10-13 Paul Eggert <eggert@cs.ucla.edu>
1926 * tests/stty/row-col-1: Set LC_ALL=C.
1928 2004-10-12 Jim Meyering <jim@meyering.net>
1930 * src/dircolors.hin: Add .flac and .mpc as audio suffixes.
1931 From Jesus Climent in http://bugs.debian.org/276149.
1933 2004-10-05 Paul Eggert <eggert@cs.ucla.edu>
1935 * src/ls.c (ignore_mode): Renamed from ignore, to avoid shadowing
1936 problems. All uses changed.
1938 2004-10-05 Jim Meyering <jim@meyering.net>
1940 * .x-sc_trailing_blank: Add an exclusion for config/texinfo.tex,
1941 since Karl says its trailing blanks are there to stay :-)
1943 2004-10-04 Paul Eggert <eggert@cs.ucla.edu>
1945 * src/expr.c (NEW, OLD): Remove, partly to avoid
1946 reference to obsolescent macro XMALLOC.
1947 All uses replaced by xmalloc and free.
1949 2004-09-28 Jim Meyering <jim@meyering.net>
1951 * src/tail.c (usage): Clarify: --retry works only with --follow=name.
1952 Reported by Nik A. Melchior in http://bugs.debian.org/273781.
1954 2004-09-27 Paul Eggert <eggert@cs.ucla.edu>
1956 * src/od.c (format_address_paren): c is optional, so don't output
1959 2004-09-26 Paul Eggert <eggert@cs.ucla.edu>
1961 Add support for ls --hide. Idea suggested by Bardur Arantsson.
1962 * NEWS: Document this.
1963 * src/ls.c (file_ignored): Renamed from file_interesting, with
1964 inverted return value. Accept the file name, not a struct dirent *.
1965 All uses changed. Avoid the expense of calling fnmatch if the
1966 file is ignorable due to leading '.'.
1967 (all_files, really_all_files): Removed; replaced by:
1968 (ignore): New variable. All uses changed.
1969 (IGNORE_DEFAULT, IGNORE_DOT_AND_DOTDOT, IGNORE_MINIMAL, HIDE_OPTION):
1971 (hide_patterns): New variable.
1972 (long_options, decode_switches, file_ignored, usage):
1973 Add support for --hide.
1974 (patterns_match): New function.
1975 (usage): Replace "hide" with "ignore" in explanation, to avoid
1978 2004-09-25 Paul Eggert <eggert@cs.ucla.edu>
1980 * src/ls.c (gobble_file, print_long_format): Don't assume that
1981 human-readable output has a byte count equal to its column width;
1982 this isn't always true in locales where the radix character is not
1984 (format_user_or_group): Revamp code to match the above fix;
1985 this avoids the (very faint) possibility of integer overflow.
1987 2004-09-24 Paul Eggert <eggert@cs.ucla.edu>
1989 * NEWS: Mention that "chmod -r -w x" now works as expected.
1990 * src/chmod.c (main): Revamp option processing to support this.
1991 * tests/chmod/Makefile.am (TESTS): Add 'usage'.
1992 * tests/chmod/usage: New set of tests for usage like that.
1994 2004-09-24 Jim Meyering <jim@meyering.net>
1996 * Makefile.maint (CVS_LIST): Use --types=AFGM option so that
1997 it lists only cvs-controlled regular files.
1999 * src/csplit.c (xalloc_die): Declare to be `extern', not `static'
2000 to avoid a warning from gcc-3.4.1. Reported by Paul Eggert.
2002 2004-09-23 Paul Eggert <eggert@cs.ucla.edu>
2004 * Makefile.maint (CVS_LIST): New macro.
2005 (sc_space_tab, sc_prohibit_atoi_atof, sc_file_system,
2006 sc_prohibit_jm_in_m4, sc_system_h_headers, sc_sun_os_names,
2007 sc_trailing_blank, po-check): Use it instead of the
2008 nonstandard "cvsu --list".
2010 * src/tail.c (parse_obsolete_option): Bring back support
2011 for obsolete option followed by non-obsolete, or by more
2012 than one file. When obsolete, conform to SUSv2 rather than
2013 original POSIX 1003.2-1992, as SUSv2 corrected the case of
2014 "tail -c". Add support for the SUSv2 "b" modifier.
2015 * NEWS: Mention the above.
2016 * tests/tail/Test.pm: New test case obs-b to check the above.
2017 err-[134] no longer need _POSIX2_VERSION=199209.
2018 Fix comments to match revised behavior.
2020 2004-09-22 Jim Meyering <jim@meyering.net>
2022 * Use automake-1.9.2. Regenerate dependent files.
2024 * src/remove.c (struct dirstack_state) [current_arg_jumpbuf]:
2025 Improve the comment.
2027 Clean up scoping etc. so that some make `distcheck' tests pass.
2028 * src/csplit.c (xalloc_die): Declare to be static.
2029 * src/chown-core.c (chown_files): Declare as `extern'.
2030 * src/cp-hash.c (remember_created): Likewise.
2031 * src/copy.c (copy): Likewise.
2032 * src/checksum.h (enum) [ALG_MD5]: Define to be 1, not 0.
2034 * src/id.c, src/nl.c, src/expand.c: Remove trailing blanks.
2035 * src/unexpand.c: Likewise.
2037 * src/Makefile.am (check-AUTHORS): New rule.
2038 (check): Depend on it.
2041 * Makefile.maint (syntax-check-rules): Remove duplicate sc_tight_scope.
2042 (sc_system_h_headers): Also exclude copy.h; it includes <stdbool.h>.
2044 2004-09-22 Paul Eggert <eggert@cs.ucla.edu>
2046 * src/ls.c (decode_switches): Don't compare a short value
2047 to SIZE_MAX: GCC sometimes complains.
2049 2004-09-21 Paul Eggert <eggert@cs.ucla.edu>
2051 * NEWS: The following commands now reject unknown options:
2052 basename dirname factor hostname link nohup sync unlink yes
2053 Also, pathchk no longer accepts trailing options.
2055 * src/basename.c: Include <getopt.h>.
2056 * src/chroot.c: Likewise.
2057 * src/dirname.c: Likewise.
2058 * src/factor.c: Likewise.
2059 * src/hostid.c: Likewise.
2060 * src/hostname.c: Likewise.
2061 * src/nohup.c: Likewise.
2062 * src/pwd.c: Likewise.
2063 * src/setuidgid.c: Likewise.
2064 * src/sync.c: Likewise.
2066 * src/basename.c (main): Reject unknown options.
2067 * src/dirname.c (main): Likewise.
2068 * src/factor.c (main): Likewise.
2069 * src/hostid.c (main): Likewise.
2070 * src/hostname.c (main): Likewise.
2071 * src/link.c (main): Likewise.
2072 * src/nohup.c (main): Likewise.
2073 * src/pwd.c (main): Likewise.
2074 * src/setuidgid.c (main): Likewise.
2075 * src/sync.c (main): Likewise.
2076 * src/unlink.c (main): Likewise.
2077 * src/yes.c (main): Likewise.
2079 * src/cat.c (main): Remove unused "case 0".
2080 * src/chgrp.c (main): Likewise.
2081 * src/chmod.c (main): Likewise.
2082 * src/chown.c (main): Likewise.
2083 * src/comm.c (main): Likewise.
2084 * src/cp.c (main): Likewise.
2085 * src/csplit.c (main): Likewise.
2086 * src/cut.c (main): Likewise.
2087 * src/date.c (main): Likewise.
2088 * src/df.c (main): Likewise.
2089 * src/du.c (main): Likewise.
2090 * src/env.c (main): Likewise.
2091 * src/expand.c (main): Likewise.
2092 * src/fold.c (main): Likewise.
2093 * src/head.c (main): Likewise.
2094 * src/id.c (main): Likewise.
2095 * src/install.c (main): Likewise.
2096 * src/join.c (main): Likewise.
2097 * src/ln.c (main): Likewise.
2098 * src/ls.c (decode_switches): Likewise.
2099 * src/mkdir.c (main): Likewise.
2100 * src/mkfifo.c (main): Likewise.
2101 * src/mknode.c (main): Likewise.
2102 * src/mv.c (main): Likewise.
2103 * src/nl.c (main): Likewise.
2104 * src/paste.c (main): Likewise.
2105 * src/pinky.c (main): Likewise.
2106 * src/pr.c (main): Likewise.
2107 * src/ptx.c (main): Likewise.
2108 * src/readlink.c (main): Likewise.
2109 * src/rm.c (main): Likewise.
2110 * src/rmdir.c (main): Likewise.
2111 * src/seq.c (main): Likewise.
2112 * src/shred.c (main): Likewise.
2113 * src/split.c (main): Likewise.
2114 * src/sum.c (main): Likewise.
2115 * src/tac.c (main): Likewise.
2116 * src/tail.c (main): Likewise.
2117 * src/tee.c (main): Likewise.
2118 * src/touch.c (main): Likewise.
2119 * src/tr.c (main): Likewise.
2120 * src/tty.c (main): Likewise.
2121 * src/uname.c (main): Likewise.
2122 * src/unexpand.c (main): Likewise.
2123 * src/wc.c (main): Likewise.
2124 * src/who.c (main): Likewise.
2126 * src/chroot.c (main): Use getopt where it suffices, not getopt_long.
2127 * src/cksum.c (main): Likewise.
2128 * src/dd.c (main): Likewise.
2129 * src/logname.c (main): Likewise.
2130 * src/printenv.c (main): Likewise.
2131 * src/sleep.c (main): Likewise.
2132 * src/tsort.c (main): Likewise.
2133 * src/uptime.c (main): Likewise.
2134 * src/users.c (main): Likewise.
2135 * src/whoami.c (main): Likewise.
2137 * src/du.c (long_options): Standardize on NULL vs 0.
2138 * src/rm.c (long_opts): Likewise.
2140 * src/logname.c (long_options): Remove.
2141 * src/printenv.c (long_options): Likewise.
2142 * src/sleep.c (long_options): Likewise.
2143 * src/tsort.c (long_options): Likewise.
2144 * src/uptime.c (longopts): Likewise.
2145 * src/users.c (longopts): Likewise.
2146 * src/whoami.c (long_options): Likewise.
2148 * src/pathchk.c (longopts): Add --help, --version.
2149 (main): Use longopts rather than parse_long_options.
2150 * src/stty.c (longpts, main): Likewise.
2152 * src/pathchk.c (main): Don't reorder arguments, so that
2153 we can check weird file names.
2155 * src/readlink.c: Don't include "long-options.h".
2156 * src/sort.c: Likewise.
2157 * src/stty.c: Likewise.
2159 * src/split.c (verbose): Now bool, not int.
2160 (VERBOSE_OPTION): New enum.
2161 (longopts, main): Use it.
2163 * tests/factor/basic: Adjust to new wording in diagnostic
2164 that results from the above changes.
2166 2004-09-21 Jim Meyering <jim@meyering.net>
2168 * man/rm.x: Say "the response is affirmative" rather than "the
2169 response begins with y or Y", so that the documentation is
2170 accurate in non-English locales. Problem reported by Munzir Taha.
2172 2004-09-19 Paul Eggert <eggert@cs.ucla.edu>
2174 * src/echo.c (main): Don't pass NULL to strcmp when
2175 POSIXLY_CORRECT and given no arguments.
2177 * src/md5sum.c (STRING_OPTION): Remove.
2178 (long_options, main): Remove support for undocumented and
2179 obsolete --string option, as suggested in the 1996-09-26 patch.
2180 * NEWS: Document this.
2182 * tests/rm/fail-eperm: Don't try to remove writeable files in a
2183 sticky /tmp directory, as SVR4-like systems (e.g., Solaris 9) let
2184 you remove such files. Problem reported by Bert Fischer in:
2185 http://lists.gnu.org/archive/html/bug-coreutils/2004-09/msg00074.html
2187 2004-09-18 Paul Eggert <eggert@cs.ucla.edu>
2189 * src/md5sum.c (STATUS_OPTION, STRING_OPTION): New enums.
2190 (long_options, main): Use them instead of magic numbers 2 and 1.
2191 For --string, optarg can't possibly be NULL.
2193 * src/dd.c (usage): Distinguish between options and operands.
2194 (scanargs): Don't mess with argc, argv; getopt_long handles this now.
2195 Say "operands" for operands, not "options".
2196 (main): Use getopt_long, so that "dd --" works as POSIX requires.
2197 * tests/dd/misc: Check for "dd --".
2199 * src/chroot.c (main): Reject unknown options instead of
2200 interpreting them as a directory to chroot to.
2202 * src/cksum.c: Remove obsolete comment about POSIX 1003.2/D11.2.
2203 The current standard (POSIX 1003.1-2004) is correct.
2204 (crc_remainder) [defined CRCTAB]: Renamed from "remainder" to avoid
2205 collision with builtin function.
2206 (main) [defined CRCTAB]: Output in lowercase hexadecimal, and
2207 output the first 0 as 8 digits, to make it easier to compare to
2208 the text of the standard. Output crctab to be a const array.
2209 (crctab): Use result of above changes.
2210 (long_options): Remove; not needed if empty.
2211 (main): getopt_long can't return 0 here, so simplify the code.
2213 2004-09-13 Jim Meyering <jim@meyering.net>
2215 * src/Makefile.am (localedir.h): Don't redirect directly to target.
2217 2004-09-13 Paul Eggert <eggert@cs.ucla.edu>
2219 * src/id.c (print_full_info): Don't exit with failure status simply
2220 because a user or group number can't be turned into a name.
2221 Problem reported by Felipe Kellermann in:
2222 http://lists.gnu.org/archive/html/bug-coreutils/2004-09/msg00081.html
2224 2004-09-12 Jim Meyering <jim@meyering.net>
2226 * Makefile.maint (my-distcheck): When building with -Werror, also
2229 2004-09-10 Paul Eggert <eggert@cs.ucla.edu>
2231 * NEWS: "tail" now handles obscure POSIX 1003.2-1992 cases better.
2232 * src/tail.c (parse_obsolete_option): Renamed from
2233 parse_obsolescent_option, since the options are obsolete now.
2234 Remove bool *arg; just exit if there's an error. Revamp to follow
2235 POSIX 1003.2-1992 more precisely, to handle cases like "tail -
2236 file" and "tail -10 -- file" correctly when we are conforming to
2238 (main): Adjust to this change.
2239 * tests/tail/Test.pm (test_vector): minus-* requires
2240 _POSIX2_VERSION=199209 now, to work correctly if there is
2241 an input file. err-1 and err-3 no longer errors if there
2244 2004-09-09 Paul Eggert <eggert@cs.ucla.edu>
2246 * src/test.c (usage): Document -r, -w, -x more carefully.
2248 2004-09-08 Paul Eggert <eggert@cs.ucla.edu>
2250 * src/test.c (usage): Document "test" (with no args) and "[ ]".
2251 Document that -h and -L don't dereference.
2253 * NEWS: Document that "tr xy -z" now works as per POSIX.
2254 Sort the descriptions.
2255 * src/tr.c (main): Don't reorder options.
2256 * tests/tr/Test.pm (fowler-1): New test case.
2258 2004-09-06 Paul Eggert <eggert@cs.ucla.edu>
2260 * src/touch.c (main): Fix POSIX-conformance bug: "touch --
2261 MMDDhhmm file" must be treated like "touch MMDDhhmm file" when
2262 conforming to pre-2001 POSIX.
2263 * NEWS: Document this.
2264 * tests/touch/obsolescent: Test for this bug. Also, set
2265 _POSIX2_VERSION=199209 and POSIXLY_CORRECT=1 so that it's
2266 a better test for obsolescent features.
2268 * src/sort.c (main): Emulate Solaris 8 and 9 "sort -y", so that
2269 "sort -y abc" is like "sort abc" whereas "sort -y 100" is like
2272 * src/od.c: Several changes for POSIX and FreeBSD compatibility.
2273 (COMMON_SHORT_OPTIONS): Add -B, -D, -e, -F, -H, -I, -L, -O, -s, -X.
2274 (long_options, main): --strings is now -S, not -s.
2275 (usage): Reflect the usage changes.
2276 (parse_old_offset): Do not issue a diagnostic on failure;
2277 callers now do this as necessary.
2278 (main): Support POSIX syntax. Remove unused case 0 from getopt_long.
2279 Add support for new short options (many undocumented) for
2280 compatibility with FreeBSD. Remove FIXME for -s; it's now
2281 POSIX-compatible. Default format is now oS, not o2.
2282 * NEWS: Describe the above.
2284 2004-09-05 Paul Eggert <eggert@cs.ucla.edu>
2286 * src/stty.c (valid_options): Remove.
2287 (main): Fix some bugs in handling invalid option-combinations
2289 (recover_mode): Arg is now char const *, not char *.
2290 (main): Use STDIN_FILENO, not 0.
2291 Simplify option-parsing code a tad.
2292 * tests/stty/basic-1: Check for the fixed bugs.
2294 2004-09-03 Paul Eggert <eggert@cs.ucla.edu>
2296 * src/stat.c (HAVE_STRUCT_STATXFS_F_TYPE): Fix typo that prevented
2297 it from ever being nonzero. Reported by Pozsar Balazs in:
2298 http://lists.gnu.org/archive/html/bug-coreutils/2004-08/msg00189.html
2299 (human_fstype): Add ramfs, squashfs, sysfs.
2300 Reported by Pozsar Balazs in:
2301 http://lists.gnu.org/archive/html/bug-coreutils/2004-08/msg00188.html
2302 (human_fstype): Return char const *, not char *.
2303 Simplify internals a bit, and avoid casts.
2305 * src/dd.c (usage): "alternated EBCDIC" -> "alternate EBCDIC".
2306 (bit_count): Remove. All uses changed to....
2307 (multiple_bits_set): New function.
2308 (scanargs): Use it, and check separately for each set of
2309 incompatible options, to improve diagnostics.
2311 (apply_translations): Move checks for incompatible options
2312 to scanargs, so that they're done consistently.
2314 2004-09-02 Paul Eggert <eggert@cs.ucla.edu>
2316 Output correct errno-related diagnostic on "paste" I/O errors.
2317 * src/paste.c (write_error, xputchar): New functions.
2318 (paste_parallel): Use correct errno value after input error.
2319 (paste_parallel, paste_serial): Report errno value after output error.
2321 Port to diet libc. Problem reported by Felix von Leitner in:
2322 http://lists.gnu.org/archive/html/bug-coreutils/2004-08/msg00171.html
2323 * src/paste.c (dummy_closed, CLOSED, dummy_endlist, ENDLIST): Remove;
2324 it's not portable C to assume FILE is a complete type.
2325 (paste_parallel): Use index test instead of ENDLIST, and NULL
2328 2004-08-24 Paul Eggert <eggert@cs.ucla.edu>
2330 POSIX-conformance fixes for "expand" and "unexpand".
2331 Also, consistently use "tab stop" rather than "tabstop".
2332 * NEWS: Document fixes.
2333 * src/expand.c: Revamp to resemble the new unexpand.c better.
2334 (usage): -i does not convert tabs after non-tabs.
2335 (add_tab_stop): Renamed from add_tabstop. All uses changed.
2336 (parse_tab_stop): Renamed from parse_tabstop. All uses changed.
2337 (validate_tab_stop): Renamed from validate_tabstop. All uses changed.
2338 (next_file, main): Check fclose against 0, not EOF.
2339 (expand): Remove unnecessary casts.
2340 Add another loop nesting level, for lines, so that per-line variables
2341 are initialized cleanly.
2342 Revamp tab checking. Check for write error immediately, rather
2343 than just once at the end of the program.
2344 * src/unexpand.c: Lkewise (for the expand.c changes).
2345 (TAB_STOP_SENTINEL): Remove.
2346 (tab_size): Now size_t, not uintmax_t, since we need to store
2347 the sequences of blanks.
2348 (max_column_width): New var.
2349 (usage): Say "blank" where POSIX requires this.
2350 (add_tab_stop): Calculate maximum column width.
2351 (unexpand): Store the pending blanks, instead of merely counting them.
2352 Follow POSIX's rules about -a requiring two blanks before a tab stop.
2353 Get rid of internal label and goto.
2354 * tests/unexpand/basic-1: Fix infloop-3 to match POSIX.
2355 Add blanks-1 through blanks-13.
2357 2004-08-19 Paul Eggert <eggert@cs.ucla.edu>
2359 * NEWS: "chown : file", "chown '' file", and "chgrp '' file" now
2360 succeed without changing the uid and gid, like FreeBSD.
2361 * src/chgrp.c (parse_group): Return gid_t rather than storing it
2362 through a pointer. Treat "chgrp '' file" as a no-op change,
2364 (main): Set chopt.group_name to NULL if the group is the empty
2366 * src/chown-core.c (describe_change): Describe changes to -1:-1
2367 without using "to OWNERSHIP" phrase.
2368 * src/chown.c (usage): "chown '' file" is now allowed.
2369 (main): Do not set user name to the empty string if the group
2371 * tests/chgrp/basic: Test "chgrp '' file".
2372 * tests/chown/Makefile.am (TESTS): Add separator.
2373 * tests/chown/separator: New file, partly taken from
2374 Dmitry V. Levin's suggestion in
2375 <http://lists.gnu.org/archive/html/bug-coreutils/2004-08/msg00102.html>
2377 2004-08-11 Paul Eggert <eggert@cs.ucla.edu>
2379 * tests/install/basic-1: Test for the -d regression.
2381 2004-08-11 Dmitry V. Levin <ldv@altlinux.org>
2383 * src/install.c (main): Fix -d regression introduced with
2384 --target-directory support at 2004-06-25.
2386 2004-08-11 Paul Eggert <eggert@cs.ucla.edu>
2388 * src/copy.c (copy_internal): When preserving links, unlink
2389 a destination with link count greater than one. This is so
2390 that commands like "cp -a" don't get confused when copying into
2391 a destination that already contains many hard links. Problem
2392 reported by Tim Waugh in:
2393 http://lists.gnu.org/archive/html/bug-coreutils/2004-08/msg00053.html
2395 2004-08-10 Paul Eggert <eggert@cs.ucla.edu>
2397 Convert all files to UTF-8.
2398 * tests/fmt/basic (8-bit-pfx): Use UTF-8, not Latin-1.
2399 * tests/sort/Test.pm (16a): Likewise.
2400 * tests/uniq/Test.pm (8): Likewise.
2401 * tests/misc/printf-hex: Use ASCII, not Latin-1.
2403 * NEWS: Document "sort -o -" and "tee -" POSIX-conformance fixes.
2404 * src/shred.c (usage): "-" is an operand, not an option.
2405 * src/sort.c (die, xfopen, mergefps, first_same_file, merge):
2406 A null file arg means standard output.
2407 (main): "-o -" means to write to a file named "-",
2408 not to standard output.
2409 * src/tee.c (usage, tee): "tee -" writes to standard output, not
2410 to a file named "-".
2412 2004-08-10 Dmitry V. Levin <ldv@altlinux.org>
2414 * src/install.c (change_timestamps): Fix int->bool conversion
2415 bugs introduced on 2004-07-29.
2417 2004-08-09 Paul Eggert <eggert@cs.ucla.edu>
2419 * src/shred.c (wipename): Work even if the directory is writeable
2420 and not readable. Prefer write access, since this should work
2421 better with fdatasync.
2423 * src/csplit.c (xalloc_die): New function.
2424 (main): Remove now-obsolete initialization of xalloc_fail_func.
2426 * src/md5sum.c: Adjust to sha->sha1 renaming.
2428 2004-08-08 Dmitry V. Levin <ldv@altlinux.org>
2431 * src/readlink.c (canonicalize_fname): Remove unneeded proxy function.
2432 (can_mode): Make variable local.
2434 2004-08-07 Paul Eggert <eggert@cs.ucla.edu>
2436 * src/system.h (O_BINARY) [!O_BINARY && defined O_BINARY]:
2437 Do not define, to avoid annoying compiler messages on QNX 6.3.
2438 Problem reported by Johan in:
2439 http://lists.gnu.org/archive/html/bug-coreutils/2004-08/msg00050.html
2441 2004-08-04 Paul Eggert <eggert@cs.ucla.edu>
2443 * src/system.h (PRIdMAX, PRIoMAX, PRIuMAX, PRIxMAX):
2444 Define to a concatenation of string literals, not to an expression;
2445 needed for concatenation contexts.
2446 (INTMAX_MAX, INTMAX_MIN): New macros.
2448 * src/stat.c (print_stat): Don't assume st_ino / st_dev fits in
2449 unsigned long; this isn't true for st_ino on Solaris 9.
2451 2004-08-03 Paul Eggert <eggert@cs.ucla.edu>
2453 * src/uname.c: Do not depend on HAVE_SYSCTL when deciding
2454 whether to include files. Include <sys/param.h> if
2455 HAVE_SYS_PARAM_H (not HAVE_SYSCTL).
2456 (main) [defined __POWERPC__]: Add a kludge to work around a
2457 Mac OS X bug, so that uname -p defaults to "powerpc" if
2458 sysctl ((int[]) {CTL_HW, HW_MACHINE_ARCH}, 2, buffer, &bufsize, 0, 0)
2459 fails. Problem reported by Petter Reinholdtsen in:
2460 http://lists.gnu.org/archive/html/bug-gnu-utils/2003-02/msg00201.html
2462 * src/uniq.c (hard_LC_COLLATE, ignore_case, different, check_file,
2463 main): Use bool for booleans.
2464 (writeline, check_file): Use uintmax_t for line counts.
2465 (check_file): Check for and report line number overflow,
2467 * src/wc.c (iswspace, wc): Use to_uchar rather than a cast.
2468 (print_lines, print_words, print_chars, print_bytes, print_linelength,
2469 have_read_stdin, wc, wc_file, main):
2470 Use bool for booleans.
2471 (exit_status): Remove.
2472 (wc, wc_file): Return bool status. All callers changed.
2473 * src/who.c (scan_entries): 0 -> STDIN_FILENO.
2474 * src/whoami.c (main): Print uids using unsigned long int, not
2477 * src/unexpand.c: Int cleanup and minor reorganization to be more
2479 Include quote.h, xstrndup.h.
2480 (TAB_STOP_SENTINEL): Increase from INT_MAX to INTMAX_MAX.
2481 (convert_entire_line, have_read_stdin, parse_tabstops, next_file,
2483 Use bool for booleans.
2484 (tab_size, tab_list, add_tabstop, validate_tabstops, unexpand):
2485 Use uintmax_t for column counts.
2486 (first_free_tab, validate_tabstops, unexpand): Use size_t for sizes.
2487 (add_tabstop, parse_tabstops, main): Don't reserve UINTMAX_MAX
2489 (parse_tabstops): Don't use ISBLANK on possibly-signed char.
2490 Detect overflow in tab stop string.
2491 (next_file, main): Use EXIT_FAILURE/EXIT_SUCCESS instead of 1/0.
2492 (unexpand): Concatenate input files the same way expand does.
2494 * src/touch.c (no_create, use_ref, posix_date, amtime_now,
2495 touch, main): Use bool for booleans.
2496 (main): Avoid integer overflow when given more than INT_MAX
2498 * src/tsort.c (struct item, n_strings): Use size_t for sizes.
2499 (have_read_stdin, count_items, scan_zeros, detect_loop,
2500 recurse_tree, walk_tree, tsort, main):
2501 Use bool for booleans.
2502 (exit_status): Remove.
2503 (tsort): Return a success flag instead of storing into a global.
2505 * src/tty.c (silent, main): Use bool for booleans.
2506 (main): 0 -> STDIN_FILENO.
2507 * src/uname.c (print_element): Use bool for booleans.
2509 * src/test.c (TRUE, FALSE, SHELL_BOOLEAN, TRUTH_OR, TRUTH_AND):
2510 Remove. All uses replaced by C99 boolean primitives.
2511 (TEST_TRUE, TEST_FALSE): New constants, for readability.
2512 (test_unop, binop, unary_operator, binary_operator, two_arguments,
2513 three_arguments, posixtest, expr, term, and, or, is_int, age_of,
2514 one_argument, main): Use bool for booleans.
2515 (advance, unary_advance): Now inline procedures rather than a macros.
2516 (is_int): Renamed from isint, to avoid namespace clash with ctype.h.
2517 (term, and, or): When it's easy, loop instead of recursing.
2518 (term): Avoid integer overflow if there are INT_MAX-3 args (!).
2519 (binary_operator, unary_operator): Simplify by systematically rewriting
2520 true==FOO to FOO (where FOO is a boolean).
2521 (unary_operator): Don't consider a file to be a regular file
2522 merely because its mode&S_IFMT is zero. Just use S_ISREG.
2523 Remove unnecessary casts. Remove ifdefs for things like
2524 S_ISSOCK that are no longer needed, since stat-macros.h always
2527 * src/tac-pipe.c (buf_init_from_stdin, find_bol, tac_mem):
2528 Use bool for booleans.
2529 (buf_init_from_stdin, buf_free, find_bol, print_line):
2530 Use size_t for sizes.
2531 * src/tac.c (separator_ends_record, tac_seekable, tac_file,
2532 tac_stdin, tac_stdin_to_mem, main): Use bool for booleans.
2533 (match_length, G_buffer_size, tac_seekable, main): Use size_t for sizes.
2534 (tac_seekable): Use ptrdiff_t for pointer subtraction.
2535 Report an error if the result is out of range.
2536 (tac_seekable, main): Check for integer overflow in buffer size
2538 (main): Remove unnecessary casts.
2540 * src/su.c (run_shell): Pass a new n_additional_args arg, so that
2541 the callee doesn't have to count 'em. All callers changed.
2542 Don't allocate more space for the arg vector than we'll need.
2543 Use memcpy to copy the args rather than rolling our own loop.
2544 Use size_t for sizes.
2545 (fast_startup, simulate_login, change_environment, log_su,
2546 correct_password, restricted_shell, main): Use bool for booleans.
2547 (longopts): Don't assume change_environment is an int.
2548 Use NULL, not 0, for pointers.
2549 (xsetenv): New function, replacing xputenv and concat.
2550 All callers changed.
2551 (elements): Remove; no longer needed.
2552 (log_su, correct_passwd, main): Prefer !x to x==NULL.
2553 (log_su): 2 -> STDERR_FILENO.
2554 (modify_environment, main): Don't assume that getenv's returned value
2555 has an indefinite lifetime.
2556 (modify_environment): Allocate a larger environ.
2557 (main): Remove an impossible 'case 0'; if it happens now, it'll
2558 get diagnosed. Don't assume getpwnam results outlive endpwent.
2559 Check for null or empty pw_name, pw_dir and for null pw_passwd.
2561 * src/stty.c (VA_START): Remove. All callers now use va_start.
2562 (_POSIX_VDISABLE): Remove unnecessary cast.
2563 (struct control_info, visible): Use cc_t for control chars.
2564 (struct control_info): Use size_t for sizes.
2565 (recover_mode, set_mode, display_speed, display_window_size,
2566 valid_options, main, display_changed):
2567 Use bool for booleans.
2568 (integer_arg): Return unsigned long int, not long int.
2569 Accept new max arg; all callers changed, to specify a maximum
2570 value for integer parameters instead of silently overflowing.
2571 (wrap): Do not overrun the stack buffer if the output contains
2572 more than 1024 bytes. Instead, malloc a buffer.
2573 (main): Remove a "what is this?!?" FIXME. Nobody knows what it is.
2574 Remove unnecessary casts.
2575 (set_control_char): Allow int values only up to cc_t range.
2576 (screen_columns): Don't reject INT_MAX.
2577 (display_changed, display_all, display_speed, recover_mode):
2578 Don't assume cc_t fits in int.
2580 * src/remove.h: Add copyright notice.
2581 (struct rm_options): Use bool for booleans.
2582 * src/rmdir.c (empty_paths, ignore_fail_on_non_empty, verbose,
2583 errno_rmdir_non_empty, remove_parents, main): Likewise.
2584 * src/sum.c (have_read_stdin, bsd_sum_file, sysv_sum_file,
2586 (main): Don't dump core if invoked with argv[0]==NULL.
2587 * src/tee.c (tee, append, ignore_interrupts, main, tee):
2588 Use bool for booleans.
2589 (tee): Use ssize_t for read returns.
2591 * src/ptx.c: Add a FIXME mentioning that there are many
2592 unchecked integer overflows in this file.
2593 (gnu_extensions, auto_reference, input_reference, right_reference,
2594 ignore_case, initialize_regex, fix_output_parameters,
2595 output_one_roff_line, output_one_text_line, output_one_dumb_line, main):
2596 Use bool for booleans.
2597 (SKIP_SOMETHING, compare_words, digest_break_file,
2598 find_occurs_in_text, fix_output_parameters):
2599 Use to_uchar instead of a caset.
2600 (print_field): Rewrite to avoid cast.
2602 * src/printf.c (posixly_correct): Use bool for booleans.
2603 (verify, main): Use EXIT_FAILURE/EXIT_SUCCESS instead of 1/0.
2604 (STRTOX): Rewrite to avoid casts.
2605 (print_esc_char): Arg is char, not int.
2606 * src/readlink.c (canonicalize): Remove. All uses now merely inspect
2608 (no_newline, verbose): Use bool for booleans.
2609 (can_mode): Now of type int; use -1 to denote otherwise-uninitialized.
2610 * src/shred.c (struct Options, main): Use bool for booleans.
2611 (isaac_seed_data, fillpattern, wipefile): Rewrite to avoid casts.
2612 * src/split.c (cwrite, bytes_split, lines_split, line_bytes_split):
2613 Use bool for booleans.
2614 * src/stat.c (G_fail): Remove.
2615 (print_statfs): Print various gotta-be-nonnegative values using
2616 unsigned long int, not long int or int.
2617 (do_statfs, do_stat): Return a boolean success flag.
2618 (do_stat, main): Use bool for booleans.
2620 * src/pr.c: Add a FIXME mentioning that there are many
2621 unchecked integer overflows in this file.
2622 (TRUE, FALSE): Remove. All uses replaced by true and false.
2623 (struct COLUMN, read_line, print_page, print_stored, open_file,
2624 skip_to_page, init_fps, parallel_files, align_empty_cols,
2625 empty_line, FF_only, explicit_columns, extremities, keep_FF,
2626 print_a_FF, print_a_header, use_form_feed, have_read_stdin,
2627 print_across_flag, storing_columns, balance_columns,
2628 truncate_lines, join_lines, untabify_input, failed_opens,
2629 numbered_lines, skip_count, use_esc_sequence, use_cntrl_prefix,
2630 double_space, ignore_failed_opens, use_col_separator,
2631 pad_vertically, last_line, main, init_parameters, skip_read,
2632 read_line, print_stored):
2633 Use bool for booleans.
2634 (struct COLUMN, char_to_clump, store_char, print_char):
2636 (clump_buff, print_clump): Use char[], not int[], for an array whose
2637 elements are always chars.
2638 (first_last_page, main, getoptarg, balance, add_line_number,
2639 char_to_uclump): Remove unnecessary casts.
2640 (init_parameters): Allocate chars, not ints, for clump_buff.
2641 (print_char): Use to_uchar before invoking ISPRINT.
2642 (char_to_clump): Convert to unsigned char before invoking ISPRINT.
2644 * src/nohup.c (main): Use bool for booleans.
2645 * src/paste.c (paste_parallel, paste_serial, main): Likewise.
2646 * src/pathchk.c (validate-path, main, portable_chars_only): Likewise.
2647 (portable_chars_only): Use to_uchar rather than a cast.
2648 * src/printenv.c (main): Use bool for booleans.
2649 Do not assume that the environ has at most one matching entry
2650 for each option (integer overflow was possible otherwise).
2652 * src/od.c (FMT_BYTES_ALLOCATED): Now an enum, not a decimal
2653 constant. Do not assume PRIdMAX etc. are strings of length 3 or
2655 (struct tspec): Use it. fmt_string is now an array, not
2656 a pointer, as there's little point to the indirection here.
2657 (struct tspec, flag_dump_strings,
2658 traditional, flag_pseudo_start, limit_bytes_to_format,
2659 abbreviate_duplicate_blocks, have_read_stdin, simple_strtoul,
2660 decode_one_format, open_next_file, check_and_close,
2661 decode_format_string, skip, write_block, read_char, read_block,
2662 parse_old_offset, dump, dump_strings, main):
2663 Use bool for booleans.
2664 (struct tspec): Use void *, not char *, for generic pointers.
2665 (bytes_to_oct_digits, bytes_to_signed_dec_digits,
2666 bytes_to_unsigned_dec_digits, bytes_to_hex_digits):
2667 Use char, not unsigned int, since char suffices.
2668 (print_s_char, print_char, print_s_short, print_short,
2669 print_int, print_long, print_long_long, print_float,
2670 print_double, print_long_double): Rewrite to avoid casts.
2671 These now take void * arguments, instead of char *.
2672 Use the same body for all functions, except for the choice
2673 of type. Assume C89 to simplify handling of signed char.
2674 (dump_hexl_mode_trailer, print_named_ascii, print_ascii):
2675 Rewrite to avoid casts.
2676 (print_named_ascii, print_ascii): Now takes void *, not char *.
2677 (decode_one_format): Use int for printf field widths, not
2678 unsigned int. Pass void * to subsidiary printers,
2679 not char *. Simplify handling of floating-point formats
2680 by factoring out common code dealing with precision and field width.
2681 (decode_format_string): Avoid need for temporary copy of
2682 each decoded struct tspec.
2683 (get_lcm): Remove unnecessary cast.
2684 (main): Fix bug where more than INT_MAX failed decodes were ignored.
2686 2004-08-02 Paul Eggert <eggert@cs.ucla.edu>
2688 * src/nl.c (TRUE, FALSE): Remove; all uses changed to true, false.
2689 (enum number_format): Remove.
2690 (FORMAT_RIGHT_NOLZ, FORMAT_RIGHT_LZ, FORMAT_LEFT): Now strings,
2692 (DEFAULT_SECTION_DELIMITERS): Now an array constant, not a macro.
2693 (section_del): Now const.
2694 (print_fmt): Remove.
2695 (starting_line_number, page_incr, blank_join, line_no,
2696 print_lineno, proc_text, main):
2697 Use intmax_t for line numbers.
2698 (reset_numbers, have_read_stdin, build_type_arg, nl_file, main):
2699 Use bool for booleans.
2700 (lineno_format): Now a string, not an enum value.
2701 (build_print_fmt): Remove. All calls removed. This work is
2702 now done within print_lineno.
2703 (build_type_arg): Use size_t for sizes.
2704 (print_lineno): Check for line number overflow.
2705 (proc_text, main): Remove unnecessary cast.
2707 * src/ln.c (symbolic_link, interactive, remove_existing_files,
2708 verbose, hard_dir_link, dereference_dest_dir_symlinks,
2709 do_link, main): Use bool for booleans.
2711 * src/ls.c (struct fileinfo, file_interesting,
2712 extract_dirs_from_files, color_symlink_as_referent,
2713 FILE_OR_LINK_MODE, sort_reverse, print_owner, print_group,
2714 numeric_ids, print_block_size, dired, print_with_color,
2715 check_symlink_color, print_inode, recursive, immediate_dirs,
2716 all_files, really_all_files, qmark_funny_chars,
2717 print_dir_name, format_needs_stat, format_needs_type, visit_dir,
2718 main, decode_switches, parse_ls_color, print_dir, file_interesting,
2719 gobble_file, make_link_path, basename_is_dot_or_dotdot,
2720 extract_dirs_from_files, print_long_format):
2721 Use bool for booleans.
2722 (dir_defaulted): Remove; no longer needed.
2723 (main): Use int to count files, since it suffices for argv.
2724 Rewrite to avoid need for dir_defaulted.
2725 (main, print_dir, gobble_file, get_link_name,
2727 Set exit status to EXIT_SUCCES/EXIT_FAILURE rather than 0/1.
2728 (decode_switches): Put back check for ws.ws_col <= SIZE_MAX.
2729 Remove unnecessary cast to int. Use int instead of unsigned
2730 int to count from 0 to 1.
2731 (get_funky_string, print_type_indicator): Use char for bytes, not int.
2732 (make_link_path): Use NULL for null pointers.
2733 (quote_name): Use to_uchar instead of cast.
2735 * src/id.c (use_name, main, print_user, xgetgroups, print_group_list,
2736 print_full_info): Use bool for booleans.
2737 (problems): Remove, replacing with....
2738 (ok): New var (inverted from old sense).
2739 (print_user, print_group, print_full_info):
2740 Print uids/gids with %lu, not %u.
2741 (xgetgroups): Don't run out of memory if getgroups or getugroups
2743 * src/setuidgid.c (main): Print uids/gids with %lu, not %ld.
2745 * src/factor.c (wheel_tab): Use unsigned char instead of unsigned
2746 int, since it suffices.
2747 (factor, print_factors): Use size_t for sizes.
2748 (print_factors, do_stdin, main): Use bool for booleans.
2749 * src/fold.c (TAB_WIDTH): New macro; use it instead of "8".
2750 (fold_file, main): Use bool for booleans.
2751 (fold_file, main): Use size_t for sizes.
2752 (main): Allow -w options up to SIZE_MAX - TAB_WIDTH - 1, instead
2753 of prohibiting widths greater than INT_MAX.
2754 * src/head.c (presume_input_pipe, print_headers, have_read_stdin,
2755 write_header, elide_tail_bytes_pipe, elide_tail_bytes_file,
2756 elide_tail_lines_pipe, elide_tail_lines_seekable,
2757 elide_tail_lines_file, head_bytes, head_lines, head, head_file,
2758 string_to_integer, main):
2759 Use bool for booleans.
2760 (main): Rewrite to avoid cast.
2762 * src/csplit.c (struct line): Use size_t for sizes.
2763 (main): Remove unnecessary cast.
2764 * src/cut.c (cut_fields): Use to_uchar rather than a cast.
2765 * src/cut.c (cut_file, main): Use bool for booleans.
2766 * src/date.c (show_date, rfc_format, batch_convert, main): Likewise.
2767 * src/env.c (main): Likewise.
2768 * src/expr.c (nextarg): Likewise.
2769 * src/env.c (main): Remove unused and nonstandard envp arg.
2771 * src/fmt.c (COST, MAXWORDS): Add a comment describing some of
2772 fmt's arbitrary limits.
2773 (TRUE, FALSE): Remove; all uses changed to (true, false).
2774 (main): Use bool for booleans.
2775 Limit maximum width to MAXCHARS / 2. Use xstrtoul, not xstrtol,
2777 (copy_rest): Remove unnecessary cast.
2778 (get_prefix): Rewrite to avoid cast.
2779 (check_punctuation): Use char *, not unsigned char *; C89 requires
2780 this. Avoid off-by-one buffer read overrun when line is empty.
2781 (flush_paragraph): Don't assume wptr-parabuf is <= INT_MAX.
2782 Remove unnecessary casts.
2783 * tests/fmt/basic (wide-1, wide-2, bad-suffix): Adjust to above
2786 * src/expand.c (convert_entire_line, have_read_stdin, parse_tabstops,
2787 next_file, expand, main):
2788 Use bool for booleans.
2789 (tab_size, tab_list, add_tabstop, parse_tabstops, validate_tabstops,
2791 Use uintmax_t for column counts.
2792 (add_tabstop): Don't reserve -1 (now UINTMAX_MAX) as a special value.
2793 All callers changed.
2794 (parse_tabstops): Don't pass a negative char to isblank.
2795 Avoid memory leak with large tab stops.
2796 (validate_tabstops, expand): Don't assume number of tab stops is
2798 (next_file, main): Use EXIT_SUCCESS/EXIT_FAILURE rather than 0/1 when
2799 storing values into exit_status.
2800 (expand): Use same pattern as unexpand for reading chars.
2801 Report an error when input line is too long, instead of silently
2802 screwing up. Do not mishandle tab stops when backspacing left
2805 * src/dircolors.c (have_read_stdin, append_quoted,
2806 dc_parse_stream, dc_parse_file, main): Use bool for booleans.
2807 (dc_parse_stream): Use enum for state, rather than int.
2808 Use ssize_t to store getline result.
2810 * src/dd.c (translation_needed, parse_integer, scanargs,
2811 apply_translations, char_is_saved, swab_buffer, skip_via_lseek):
2812 Use bool for booleans.
2813 (translate_buffer): Use to_uchar rather than a cast.
2814 (swab_buffer, copy_simple, copy_with_unblock):
2815 Use size_t for sizes.
2817 * src/seq.c (equal_width, valid_format, main): Use bool for booleans.
2818 * src/sleep.c (apply_suffix): Likewise.
2819 * src/tail.c (struct File_spec, reopen_inaccessible_files, count_lines,
2820 forever, from_start, print_headers, have_read_stdin, valid_file_spec,
2821 write_header, file_lines, pipe_lines, pipe_bytes, recheck,
2822 tail_forever, tail_bytes, tail_lines, tail, tail_file,
2823 parse_obsolescent_option, parse_options, main): Likewise.
2824 * src/sleep.c (apply_suffix): Invert sense of result.
2825 Use int (not unsigned int) for multiplier, as this generates better
2826 code with some compilers. Simplify code a bit.
2827 * src/tail.c (struct File_spec, max_n_unchanged_stats_between_opens,
2828 parse_options): Use uintmax_t, not unsigned int or unsigned long int,
2830 (tail_bytes, tail_lines): Redo test of return value (-1, 0, 1) to
2831 make it a bit clearer.
2833 * src/hostname.c: Include "xgethostname.h".
2834 (xgethostname): Remove decl; xgethostname.h has it.
2835 (sethostname) [!defined(HAVE_SETHOSTNAME) && defined(HAVE_SYSINFO)
2836 && defined (HAVE_SYS_SYSTEMINFO_H) && defined(HAVE_LIMITS_H)]: Use
2837 prototypes rather than K&R form. Assume any negative value from
2838 sysinfo denotes failure, not just -1.
2839 (main): Simplify use of sethostname.
2841 * src/pinky.c (include_idle, include_heading, include_fullname,
2842 include_project, include_plan, include_home_and_shell, do_short_format,
2843 include_where, main): Use bool for booleans.
2844 (count_ampersands, create_fullname, scan_entries, short_pinky):
2845 Use size_t for sizes.
2846 (create_fullname): Check for overflow in size calculations.
2847 (idle_string): Don't assume that the number of idle days
2848 is less than 10**8 and/or INT_MAX/(24*60*60).
2849 (main): No need to pass a non-NULL last arg to getopt_long.
2850 * src/uptime.c (print_uptime, uptime): Use size_t for sizes.
2851 (print_uptime): Remove unused local variable.
2852 (main): No need to pass a non-NULL last arg to getopt_long.
2853 * src/users.c (list_entries_users, users): Use size_t for sizes.
2854 (list_entries_users): Use char for bytes.
2855 (main): No need to pass a non-NULL last arg to getopt_long.
2856 * src/who.c (do_lookup, short_list, short_output, include_idle,
2857 include_heading, include_mesg, include_exit, need_boottime,
2858 need_deadprocs, need_login, need_initspawn, need_clockchange,
2859 need_runlevel, need_users, my_line_only, main): Use bool for booleans.
2860 (print_runlevel): Use unsigned char for bytes.
2861 (list_entries_who, scan_entries, who): Use size_t for sizes.
2862 (main): No need to pass a non-NULL last arg to getopt_long.
2864 * src/install.c (isdir): Remove decl.
2865 (install_file_to_path): Rely on make_path to fail if the destination
2866 is not a directory, by passing preserve_existing==true to it.
2867 Hence we no longer need to call isdir.
2868 Free dest_dir immediately when it's no longer needed, rather than
2869 waiting until the end of the function.
2870 (copy_file): Don't bother calling isdir, as copy will do the
2871 right thing if the destination is a directory.
2873 * src/du.c (fts_debug, opt_all, apparent_size, opt_count_all,
2874 print_grand_total, opt_separate_dirs, hash_ins, process_file, main):
2875 Use bool for booleans.
2876 (max_depth): Now size_t, not int, to avoid an arbitrary limit
2877 of INT_MAX on depth.
2878 (G_fail): Remove: no longer needed, now that the relevant
2879 functions return bool.
2880 (process_file): Use return value to signal success rather than
2881 setting a global. Remove first_call static var; not needed, since
2882 we can look at n_alloc. Use size_t for depths. Remove FIXME
2883 about size_t casts, as it's now fixed. Use xnrealloc rather
2884 than the obsolescent XREALLOC. Don't bother to check whether
2885 reallocation is needed unless level > prev_level.
2886 (du_files): Invert sense of result, for consistency with
2887 other coreutils code. All callers changed.
2888 (main): Allow --max-depth values up to SIZE_MAX.
2890 * src/df.c (inode_format, show_all_fs, show_local_fs,
2891 show_listed_fs, posix_format, require_sync, print_type,
2892 selected_fstype, excluded_fstype, show_dev, show_point, main):
2893 Use bool for booleans.
2894 (df_readable, show_dev): Use UINTMAX_MAX instead of -1.
2895 (show_dev, show_point, main):
2896 Use EXIT_SUCCESS/EXIT_FAILURE instead of 0/1.
2897 Don't assume disk name lengths are <= INT_MAX.
2898 Rewrite pct calculation to avoid cast.
2899 (show_point): Don't assume resolved length is <= SSIZE_MAX.
2901 * src/cut.c (hash_int) [!defined UINTPTR_MAX]: Use size_t
2902 instead of uintptr_t.
2903 * src/shred.c (UINT_MAX_32_BITS): Remove.
2904 (word32): Remove. All uses changed to uint32_t.
2905 (isaac_seed_data): Remove unnecessary cast.
2906 * src/system.h (ptr_align): Use size_t; in practice, this is just as
2907 good as uintptr_t in checking for alignments, and has fewer
2908 configuration hassles.
2910 * src/Makefile.am (localedir.h): Make it readonly; this
2911 undoes part of the 2004-07-27 patch.
2913 2004-07-30 Paul Eggert <eggert@cs.ucla.edu>
2915 * src/sort.c (UCHAR): Remove; all uses changed to to_uchar.
2916 (IS_THOUSANDS_SEP): Use bool when appropriate.
2917 (numcompare, main): Use char, not int, when the value is always a char.
2918 (numcompare): Remove "register"; compilers are smart enough these days.
2919 * src/system.h (errno, CHAR_BIT): Remove decls;
2920 no longer needed now we assume C89 or better.
2921 Include <inttypes.h> before <stdint.h>, as it's the
2922 Autoconf-recommended pattern.
2923 (to_uchar): New inline function, moved here from tr.c.
2924 Use full names for int types, e.g. "long int" rather than "long".
2925 * src/tr.c (to_uchar): Remove; now in system.h.
2926 (is_char_class_member): Use bool when appropriate.
2928 * src/mkdir.c (create_parents, main): Use bool when appropriate.
2929 (main): Use EXIT_SUCCESS/EXIT_FAILURE instead of 0/1.
2931 2004-07-29 Paul Eggert <eggert@cs.ucla.edu>
2933 * src/mkfifo.c (main): Use EXIT_SUCCESS and EXIT_FAILURE, not 0 and 1.
2935 * src/chmod.c (recurse, force_silent, process_file, process_files,
2936 main): Use bool when appropriate.
2937 * src/cksum.c (cksum, main): Likewise.
2938 * src/comm.c (hard_LC_COLLATE, only_file_1, only_file_2, both,
2939 compare_files, main): Likewise.
2941 * src/copy.h (struct cp_options): Likewise.
2942 * src/copy.c (copy_internal, is_ancestor, copy_dir, copy_reg,
2943 same_file_ok, seen_file, copy_internal, valid_options, copy): Likewise.
2944 * src/cp-hash.h (remember_created): Likewise.
2945 * src/cp-hash.c (remember_created): Likewise.
2946 * src/cp.c (struct dir_attr, flag_path, remove_trailing_slashes,
2947 re_protect, make_path_private, target_directory_operand, do_copy,
2948 cp_option_init, decode_preserve_arg, main): Likewise.
2949 * src/install.c (isdir, change_timestamps, change_attributes,
2950 copy_file, install_file_to_path, install_file_in_dir,
2951 install_file_in_file, strip_files, dir_arg, cp_option_init, main,
2952 change_attributes, change_timestamps): Likewise.
2953 * src/mv.c (remove_trailing_slashes, rm_option_init,
2954 cp_option_init, do_move, movefile, main): Likewise.
2955 * src/remove.c (right_justify), full_filename_, AD_pop_and_chdir,
2956 AD_push, prompt, remove_dir): Likewise.
2957 * src/rm.c (rm_option_init, main): Likewise.
2959 * src/remove.c (top_dir, pop_dir, full_filename_):
2960 Use size_t for sizes.
2961 * src/cp.c (target_directory_operand): Do not clear *NEW_DST if stat
2962 succeeds. It's not necessary in that case, as *NEW_DST is always
2964 (do_copy): Rewrite slightly to avoid need for "unreachable" comment.
2965 (main): Use EXIT_SUCCESS, EXIT_FAILURE instead of 0, 1.
2966 * src/rm.c (main): Likewise.
2968 md5sum, sha1sum integer cleanups.
2970 * src/checksum.h: Don't include config.h, sys/types.h, stdio.h:
2972 (ALG_UNSPECIFIED): Remove.
2973 (ALG_MDT): Don't make it equal to CHAR_MAX + 1; this isn't necessary.
2974 * src/md5.c: Don't include any files other than checksum.h.
2975 * src/sha1sum.c: Likewise.
2976 * src/md5sum.c (OPENOPTS, have_read_stdin, status_only, warn,
2977 bsd_split_3, split_3, hex_digits, digest_file, digest_check, main):
2978 Use bool when appropriate.
2979 (digest_check): Increase limit of number of input lines to
2980 UINTMAX_MAX from INT_MAX. Diagnose any overflows of this counter.
2981 Use ngettext instead of hard-to-i18nize hardcoded stuff for plurals.
2983 2004-07-28 Paul Eggert <eggert@cs.ucla.edu>
2985 * src/cat.c (exit_status): Remove. Now done by passing a boolean
2987 (simple_cat, cat): Return true if successful. All callers changed.
2988 (simple_cat, cat, main): Use bool for booleans.
2989 (simple_cat): Use size_t for sizes.
2990 (cat, main): Use the same names for parameters that we use for
2991 long options, to avoid confusion. This inverts the sense of the
2992 show_tabs (formerly output_tabs) and number_nonblank
2993 (formerly numbers_at_empty_lines) variables.
2994 (main): Don't mess up (due to integer overflow) if we are given
2995 INT_MAX - INT_MIN + 1 options.
2996 [O_BINARY]: Don't invoke isatty unless the other options require it.
2997 (main): When deciding whether to use simple_cat, don't worry
2998 about binary option; it's irrelevant.
3000 * src/dcgen: Remove comments, trailing white space, and empty
3001 lines from the output strings, to save space.
3002 Use a narrower type like 'unsigned char' for line lengths, if
3004 Make the output variables static, not extern.
3006 * src/chgrp.c (parse_group): Require base 10 when parsing
3008 (main): int -> bool when appropriate.
3009 * src/chown.c (main): Likewise.
3010 * src/chown-core.c: Include inttostr.h.
3011 (UINT_MAX_DECIMAL_DIGITS, uint_to_string): Remove.
3012 (gid_to_name, uid_to_name): Use imaxtostr/umaxtostr
3013 instead of uint_to_string).
3014 (describe_change): Instead of an int flag, use a char *
3015 auxiliary; this avoids the need for casts.
3016 Assume free (NULL) works.
3017 (change_file_owner): Return true/false, not 0/-1, since
3018 we don't set errno. All callers changed.
3019 Use bool when appropriate.
3020 (chown_files): Likewise.
3021 * src/chown-core.h (chown_files): Likewise.
3023 * tests/chown/basic: Test for proper handling of uids like
3024 "010", which must be parsed as decimal.
3026 * tests/misc/pwd: Don't assume that Perl's getpwd agrees with our
3027 pwd when there are multiple names for the working directory
3028 (which can happen with an automounter, sigh).
3030 * src/Makefile.am ($(SCRIPTS)): Don't depend on Makefile;
3031 this causes Solaris 8 'make' to refuse to build "groups".
3032 (localedir.h): Don't depend on Makefile: this causes Solaris
3033 8 'make' to build localedir.h unnecessarily. The dependence
3034 on Makefile is ineffective anyway, since $(localedir) might
3035 change even if Makefile hasn't.
3037 * src/remove.c (remove_dir): If we can't save the state of the
3038 working directory, pretend we started from "/", not ".".
3039 This avoids a bug on hosts like Solaris that don't let you
3040 remove the working directory.
3042 2004-07-27 Paul Eggert <eggert@cs.ucla.edu>
3044 * src/printf.c (strtiomax, strtoumax): Declare if not already
3045 declared: this fixes a portability bug with Solaris 8 + GCC.
3046 (STRTOX): Parenthesize use of macro arg as expression.
3047 (vstrtoimax, vstrtoumax, vstrtold): Remove now-unnecessary
3049 * configure.ac: Check for declaration of strtoumax, for
3052 * src/Makefile.am (cp_LDADD, ginstall_LDADD, mv_LDADD,
3053 pathchk_LDADD, rm_LDADD, test_LDADD): New vars, for eaccess.
3055 * tests/readlink/can-e: Don't assume that we can remove the
3056 working directory: this isn't possible under Solaris 8, say.
3057 * tests/readlink/can-f: Likewise.
3058 * tests/readlink/can-m: Likewise.
3060 * src/copy.c (copy_internal): find_backup_file_name no longer
3061 returns NULL, so don't bother to check for this.
3062 * src/cp.c (do_copy): Likewise.
3063 * src/ln.c (do_link): Likewise.
3065 2004-07-25 Paul Eggert <eggert@cs.ucla.edu>
3067 * src/nice.c (GET_NICE_VALUE): Renamed from GET_PRIORITY.
3069 (NZERO): New macro, if system doesn't define it already.
3070 (usage): Distinguish priorities from nice values.
3071 Don't assume NZERO is 20.
3072 (main): Use bool instead of int where appropriate.
3073 If user specifies an adjustment out of range, always truncate it
3074 to an inrange value instead of sometimes giving an error message
3076 Do not assume that -1 is an error return from "nice" or
3077 "getpriority", as it might be the current nice value minus NZERO.
3078 If nice/setpriority fails with errno == EPERM, go ahead and run
3079 the command anyway; POSIX requires this.
3081 * src/pathchk.c: Include euidaccess.h.
3082 (dir_ok): Use euidaccess, not access.
3083 * src/test.c (R_OK, W_OK, X_OK, FOK): Remove; system.h defines them.
3084 (eaccess): Remove. All users changed to use euidaccess instead.
3086 2004-07-24 Paul Eggert <eggert@cs.ucla.edu>
3088 * src/uptime.c (print_uptime) [defined BOOT_MSG]:
3089 Don't assume ut_line is null-terminated.
3090 * src/who.c (print_line): New arguments USERLEN and LINELEN,
3091 since USER and LINE might not be null terminated. All callers
3094 2004-07-23 Paul Eggert <eggert@cs.ucla.edu>
3096 Fix bug with "tail -f" reported by Rob Holland in
3097 <http://lists.gnu.org/archive/html/bug-coreutils/2004-07/msg00054.html>.
3098 Also, remove the undocumented and unsupported-since-2000
3099 --max-consecutive-size-changes options. Fix another related bug:
3100 "tail" got confused if stdin, stdout, or stderr were closed.
3101 Also, use output buffering even with "tail -f".
3103 * NEWS: Document this, plus yesterday's patch.
3104 * doc/coreutils.texi (tail invocation): "size has remained the same"
3105 -> "file has not changed", which is more accurate for fifos.
3106 * src/tail.c: Include fcntl-safer.h.
3107 (COPY_TO_EOF): Set to UINTMAX_MAX, not OFF_T_MAX (which was wrong).
3108 (COPY_A_BUFFER): New macro.
3109 (struct File_spec): New members mtime, mode, blocking.
3110 Remove member n_consecutive_size_changes.
3111 (DEFAULT_MAX_N_CONSECUTIVE_SIZE_CHANGES,
3112 max_n_consecutive_size_changes_between_opens,
3113 MAX_CONSECUTIVE_SIZE_CHANGES_OPTION): Remove.
3114 (long_options, tail_forever, parse_options):
3115 Remove (non-)support for --max-consecutive-size-changes.
3116 (record_open_fd): New function.
3117 (recheck, tail_file): Use it. Don't assume that stdin is open.
3118 (dump_remainder): Add support for new COPY_A_BUFFER special value.
3119 Treat errno==EAGAIN like EOF, since it might be a nonblocking read.
3120 (recheck): New arg BLOCKING, specifying whether to use blocking reads.
3122 (n_live_files): Remove, replacing with...
3123 (any_live_files): New function. All uses changed.
3124 (tail_forever): Use nonblocking I/O unless we know that blocking I/O
3125 is safe; this avoids some hangs when reading from a fifo.
3126 Avoid invoking fstat or sleep when using blocking I/O.
3127 Do not check for changes to size if the file is not a regular file,
3128 as the size is undefined in that case.
3129 Check for changes to mtime or mode, too; this works for non-regular
3131 (tail_forever, main): Redo fflush strategy to work even when input
3132 is nonblocking. Don't use unbuffered output; just flush when needed.
3134 2004-07-22 Paul Eggert <eggert@cs.ucla.edu>
3136 * src/tail.c (main): Ignore -f if no file operand is specified
3137 and standard input is a pipe.
3138 * doc/coreutils.texi (tail invocation): Do not ignore -f for
3139 all pipes, just for when standard input is a pipe and no
3140 file operand is specified.
3141 * tests/tail/Test.pm: Reinstate f-1 test, since we now pass.
3142 Add a new commented-out f-2 test, which we still fail.
3143 (test_vector): All f-* tests are special cases, not just f-1.
3145 2004-07-12 Paul Eggert <eggert@cs.ucla.edu>
3147 * src/uptime.c: Include c-strtod.h.
3148 (print_uptime): Use c_strtod instead of setlocale and sscanf.
3149 Use long int rather than int to count days (for 64-bit hosts),
3150 and check for arithmetic overflow when converting double to time_t.
3152 2004-07-11 Paul Eggert <eggert@cs.ucla.edu>
3154 * src/printf.c (vstrtold): Renamed from vstrtod.
3155 Now returns long double. All uses changed.
3156 (print_direc): Use "L" length modifier when printing floating point
3157 numbers, since we're now printing long double.
3159 2004-07-06 Paul Eggert <eggert@cs.ucla.edu>
3161 printf cleanup, to avoid undefined behavior, to add support for
3162 formats that Bash supports, and to support wide integers like
3165 * NEWS: Document this.
3166 * src/printf.c (UNSPECIFIED): Remove. All uses now replaced by
3167 booleans, so that we don't reserve any values for precision or
3169 (STRTOX): Use prototype, not K&R-style definition.
3170 (vstrtoimax): Renamed from xstrtol (to avoid confusion with xstrtol
3171 in ../lib), with type change to intmax_t.
3173 (vstrtoumax): Renamed from xstrtoul, with type change to uintmax_t.
3175 (vstrtod): Renamed from xstrtod. All uses changed.
3176 (print_direc): Use boolean arg instead of special value to indicate
3177 a missing precision or width. LENGTH no longer includes
3178 length modifiers or conversion character. New arg CONVERSION
3179 now specifies conversion character.
3180 Use intmax_t-width formatting for integers (like Bash).
3181 Add support for C99 %a, %A, %F (like Bash).
3182 Add support for field width with %c (POSIX requires this).
3183 Add a FIXME for lack of support for field width and precision
3185 Add support for '\'', '0' flags.
3186 Check for invalid combinations of flags, field width, precision,
3187 and conversion, to prevent use of undefined behavior.
3188 Allow multiple length modifiers, for formats like "%lld" (like Bash).
3189 Add support for C99 'j', 't', 'z' length modifiers (like Bash).
3190 In error message, output entire invalid conversion specification,
3191 instead of merely outputting % followed by the conversion char.
3192 * tests/misc/printf: Add tests for the above.
3194 2004-04-03 Dmitry V. Levin <ldv@altlinux.org>
3196 Change "readlink -f" to be more compatible with prior implementations.
3197 Add more canonicalize options, -e and -m.
3198 Add comprehensive tests for all readlink modes.
3200 * m4/canonicalize.m4 (AC_FUNC_CANONICALIZE_FILE_NAME):
3201 Do not add canonicalize.c here.
3203 * src/readlink.c (longopts): Add new options.
3204 (usage): Document them.
3205 (canonicalize_fname): New proxy function.
3206 (main): Handle new options.
3207 * doc/coreutils.texi (readlink invocation): Document new
3208 "readlink -f" behaviour and new canonicalize options, -e and -m.
3210 * configure.ac (AC_CONFIG_FILES): Add tests/readlink/Makefile.
3211 * tests/Makefile.am (SUBDIRS): Add readlink.
3212 * tests/readlink/Makefile.am: New file.
3213 * tests/readlink/{rl-1,can-e,can-f,can-m}: New readlink tests.
3214 * tests/misc/Makefile.am (TESTS): Remove basic readlink test.
3215 * tests/misc/readlink: Remove file.
3217 2004-07-04 Jim Meyering <jim@meyering.net>
3219 * src/copy.c (copy_internal): Add a FIXME comment.
3221 2004-07-02 Paul Eggert <eggert@cs.ucla.edu>
3223 * src/copy.c (copy_dir): Assume path_concat returns non-NULL.
3224 * src/cp.c (do_copy): Likewise.
3225 * src/mv.c (movefile): Likewise.
3227 * src/cp.c (make_path_private): 2nd arg is now size_t, not int,
3228 to avoid problem when path_concat dir name is longer than 2 GiB (!).
3230 * src/nohup.c (main): Don't pass NULL first argument to path_concat.
3231 This cleans up the semantics a bit, as we no longer try to open the
3234 2004-07-01 Paul Eggert <eggert@cs.ucla.edu>
3236 * NEWS: Add short names -t and -T for --target-directory
3237 and --no-target-directory options, respectively.
3239 * src/cp.c (NO_TARGET_DIRECTORY_OPTION, TARGET_DIRECTORY_OPTION):
3240 Remove. All uses changed to 'T' and 't', respectively.
3241 * src/install.c, src/ln.c, src/mv.c: Likewise.
3243 * src/cp.c (long_opts, usage, do_copy, main): Add -t and -T as
3244 aliases for --target-directory and --no-target-directory,
3246 * src/install.c (long_options, main, usage): Likewise.
3247 * src/ln.c, src/mv.c: Likewise.
3249 2004-07-01 Jim Meyering <jim@meyering.net>
3251 * Makefile.maint (sc_file_system): New target.
3252 (syntax-check-rules): Add it.
3253 .x-sc_file_system: New file.
3254 * Makefile.am (EXTRA_DIST): Add it.
3256 * man/sync.x: Use "file system" rather than "filesystem".
3257 * man/stat.x, man/df.x: Likewise.
3259 2004-06-30 Paul Eggert <eggert@cs.ucla.edu>
3261 * src/df.c (usage, main): Output "file system" rather than
3263 * src/du.c (usage): Likewise.
3264 * src/shred.c (usage): Likewise.
3265 * src/stat.c (usage): Likewise.
3266 * src/stat.c (long_options, usage): Rename "--filesystem" to
3267 "--file-system". But keep the old name around, for compatibility
3270 2004-06-29 Paul Eggert <eggert@cs.ucla.edu>
3272 Add support for --no-target-directory option.
3274 * NEWS: Document it.
3275 * doc/coreutils.texi (Common options, Target directory, cp
3276 invocation, install invocation, mv invocation, ln invocation):
3278 (link invocation): Explain how to rewrite link using ln now
3279 that we have --no-target-directory.
3280 (ln invocation): Explain that --no-target-directory subsumes
3282 (unlink invocation): Modify wording to match new wording in
3285 * src/cp.c (NO_TARGET_DIRECTORY_OPTION): New constant.
3286 (long_opts, usage, do_copy, main): Add support for
3287 --no-target-directory,
3288 * src/install.c (NO_TARGET_DIRECTORY_OPTION, long_options, main,
3290 * src/ln.c (NO_TARGET_DIRECTORY_OPTION, long_options, usage,
3292 * src/mv.c (NO_TARGET_DIRECTORY_OPTION, long_options, usage,
3294 * src/mv.c (enum): Sort values.
3296 2004-06-29 Jim Meyering <jim@meyering.net>
3298 Don't let verbose-mode output from a subshell obscure actual differences.
3299 * tests/rm/inaccessible: Turn off command-echoing just before
3300 invoking subshell, then turn it back on if VERBOSE=yes afterward.
3302 2004-06-25 Paul Eggert <eggert@cs.ucla.edu>
3304 Add support for 'install --target-directory', an option
3305 that has been documented for years but not implemented (!).
3306 * doc/coreutils.texi (install invocation): Document
3307 --target-directory in synopsis, too.
3308 * src/install.c (TARGET_DIRECTORY_OPTION): New var.
3309 (long_options, main, usage): Add --target-directory.
3310 (target_directory_operand): New function, stolen from mv.c.
3311 (main): Use it. Check for -d and --target-directory.
3312 Alter wording of diagnostics to match other programs.
3314 2004-06-28 Jim Meyering <jim@meyering.net>
3316 * src/cp.c (usage): Fix copy+paste error in description of
3317 --target-directory: s/move/copy/. From Paul Jarc.
3319 2004-06-27 Paul Eggert <eggert@cs.ucla.edu>
3321 Use more-consistent rules among cp, ln, and mv when dealing with
3322 last operands that are (or look like) directories.
3324 * src/cp.c (target_directory_operand): New, nearly-common function,
3325 It reports an error if the destination appears to be a directory
3326 (e.g., because it has a trailing slash) but is not.
3327 * src/ln.c, src/mv.c: Likewise.
3328 * src/cp.c (do_copy): Use it.
3329 * src/ln.c (main): Likewise.
3330 * src/mv.c (main): Likewise.
3332 * src/cp.c (do_copy): Don't assume argc is positive.
3333 Don't bother to lstat dest, since copy() will do that for us.
3334 Use "const" to avoid the need for cast.
3336 * src/cp.c (do_copy): Don't output a usage message because of file
3337 problems (e.g., an operand is not a directory). Use it only for
3338 syntax. Standardize on "target %s is not a directory" for the
3340 * src/ln.c (main): Likewise.
3341 * src/mv.c (main): Likewise.
3343 * src/cp.c (do_copy): Remove test for trailing slash, since
3344 target_directory_operand now does this.
3345 * src/ln.c (main): Likewise.
3346 * src/mv.c (movefile): Likewise.
3348 * src/cp.c (main): Reject multiple target directories.
3349 Check whether a specified target is a directory when parsing the
3350 options, using stat. This gives more-accurate diagnostics.
3351 * src/ln.c (main): Likewise.
3353 * src/ln.c (isdir): Remove decl; no longer needed.
3354 * src/mv.c (isdir, lstat): Likewise.
3356 * src/ln.c (do_link): New arg dest_is_dir. All uses changed.
3357 Don't check the destination ourself; rely on dest_is_dir.
3358 This way we can avoid lstatting the destination in the
3359 usual case, and in the worst case we lstat 1, not 3 times.
3360 Don't bother to unlink unless link failed; this saves a syscall.
3361 Remove unnecessary backup_succeeded flag;
3362 it was identical to "dest_backup != NULL".
3364 * src/ln.c (main): Use int to count to argc, not unsigned int.
3365 This handles negative operand counts.
3366 * src/mv.c (main): Likewise.
3368 * src/mv.c (do_move): Don't call hash_init; expect the caller to
3369 do it, for consistency with cp.c and ln.c. All callers changed.
3370 (movefile): dest_is_dir parameter is now bool, not int.
3371 (main): Standardize on "missing destination file operand after %s"
3372 for the diagnostic, for consistency with cp.c.
3374 * tests/mv/diag: Don't assume "mv --target=nonexistentdir"
3375 will complain about the arg count.
3376 Adjust to new (briefer) diagnostics.
3377 * tests/cp/fail-perm: Add a test to verify that we get the new
3378 diagnostic when failing to copy through a symlink-to-inaccessible-dir.
3380 2004-06-27 Paul Eggert <eggert@cs.ucla.edu>
3382 Fix a bug: formerly, if d/x was a directory and x a file, "ln x
3383 d/" incorrectly created a link d/x/x. It also saves some system
3386 * NEWS: Document the fix.
3388 * src/ln.c (main): Don't append basename to dest if this
3389 results in an existing directory name.
3390 * tests/ln/misc: See whether a trailing slash is followed too far.
3392 2004-06-26 Jim Meyering <jim@meyering.net>
3394 * src/printf.c (main): When given no arguments, print the standard
3395 "missing operand\nTry printf --help..." message -- to be consistent.
3397 2004-06-26 Jim Meyering <jim@meyering.net>
3399 * src/mknod.c (main): Add \n at the end of message output via fprintf.
3401 2004-06-25 Jim Meyering <jim@meyering.net>
3403 * tests/ln/misc: Add test for ln subscript error.
3405 2004-06-23 Paul Eggert <eggert@cs.ucla.edu>
3407 * src/ln.c (do_link): Remove unnecessary call to lstat.
3408 (main): Avoid subscript error when the destination is "".
3410 2004-06-23 Jim Meyering <jim@meyering.net>
3412 * tests/*: Replace all occurrences of `(exit N); exit' with
3413 `(exit N); exit N'. Otherwise, those many tests could exit with
3414 improper exit status when exiting via e.g., a trapped interrupt.
3415 Thanks to a report from Bob Proulx.
3417 2004-06-22 Paul Eggert <eggert@cs.ucla.edu>
3419 * src/who.c (idle_string, print_user): New arg boottime,
3420 specifying the most recent boot time. All uses changed.
3421 (idle_string) Consider a line to be "old" if it hasn't been used
3422 since the last boot time. Watch out for overflow when computing
3423 times, and for times in the future.
3424 (idle_string): Record latest boot time.
3426 2004-06-22 Jim Meyering <jim@meyering.net>
3428 * src/test.c (usage): Correct description of `-t FD'. The file
3429 descriptor, FD, is no longer optional. Reported by Ton Nijkes.
3431 2004-06-21 Paul Eggert <eggert@cs.ucla.edu>
3433 The 2004-06-19 fix for who and pinky was incomplete, as ctime
3434 has undefined behavior if the year precedes -999 or follows 9999.
3435 Since we have to stop using ctime anyway, we might as well use
3436 strftime and fix the FIXME, and support internationalized dates.
3438 * NEWS: Document the new behavior.
3439 * src/who.c: Include "hard-locale.h".
3440 (time_format, time_format_width): New vars.
3441 (time_string, print_line): Use them.
3443 (time_string): Use localtime + strftime instead of
3444 ctime, to avoid problems with years before -999 or after 9999.
3445 * src/pinky.c: Likewise.
3447 2004-06-21 Paul Eggert <eggert@cs.ucla.edu>
3449 Fix bug: GNU 'ls' didn't count columns correctly if user or group
3450 names contained multibyte characters where the column count
3451 differed from the byte count. This patch also corrects
3454 * src/ls.c (format_user_or_group): New function, which counts
3456 (format_user, format_group): Use it.
3457 (format_user_or_group_width): New function, which counts columns
3459 (format_user_width, format_group_width): Use it.
3461 2004-06-21 Jim Meyering <jim@meyering.net>
3463 * tests/priv-check: Quote "$PATH" in PATH=$PATH.
3464 Suggestion from Andreas Schwab.
3466 * tests/priv-check: When running as root, be sure to propagate
3467 PATH through to the process we exec as non-root.
3468 Reported by michael@aplatform.com.
3470 * src/mknod.c (main): Don't segfault when calculating the
3471 expected number of operands for `mknod NAME'.
3473 2004-06-20 Jim Meyering <jim@meyering.net>
3475 * src/dd.c (input_seek_errno): Declare file-scoped variable as static.
3477 2004-06-20 Paul Eggert <eggert@cs.ucla.edu>
3479 * src/basename.c (main):
3480 Standardize on the diagnostics given when someone gives
3481 too few operands ("missing operand after `xxx'") or
3482 too many operands ("extra operand `xxx'").
3483 Include "quote.h" and/or "error.h" if it wasn't already being included.
3484 * src/chgrp.c (main): Likewise.
3485 * src/chmod.c (main): Likewise.
3486 * src/chown.c (main): Likewise.
3487 * src/chroot.c (main): Likewise.
3488 * src/comm.c (main): Likewise.
3489 * src/cp.c (do_copy): Likewise.
3490 * src/csplit.c (main): Likewise.
3491 * src/date.c (main): Likewise.
3492 * src/dircolors.c (main): Likewise.
3493 * src/dirname.c (main): Likewise.
3494 * src/du.c (main): Likewise.
3495 * src/expr.c (main): Likewise.
3496 * src/hostid.c (main): Likewise.
3497 * src/hostname.c (main): Likewise.
3498 * src/id.c (main): Likewise.
3499 * src/install.c (main): Likewise.
3500 * src/join.c (add_file_name, main): Likewise.
3501 * src/link.c (main): Likewise.
3502 * src/ln.c (main): Likewise.
3503 * src/logname.c (main): Likewise.
3504 * src/md5sum.c (main): Likewise.
3505 * src/mkdir.c (main): Likewise.
3506 * src/mkfifo.c (main): Likewise.
3507 * src/mknod.c (main): Likewise.
3508 * src/mv.c (main): Likewise.
3509 * src/nohup.c (main): Likewise.
3510 * src/od.c (main): Likewise.
3511 * src/pathchk.c (main): Likewise.
3512 * src/ptx.c (main): Likewise.
3513 * src/readlink.c (main): Likewise.
3514 * src/rm.c (main): Likewise.
3515 * src/rmdir.c (main): Likewise.
3516 * src/seq.c (main): Likewise.
3517 * src/setuidgid.c (main): Likewise.
3518 * src/shred.c (main): Likewise.
3519 * src/sleep.c (main): Likewise.
3520 * src/sort.c (main): Likewise.
3521 * src/split.c (main): Likewise.
3522 * src/stat.c (main): Likewise.
3523 * src/test.c (beyond, main): Likewise.
3524 * src/touch.c (main): Likewise.
3525 * src/tr.c (main): Likewise.
3526 * src/tsort.c (main): Likewise.
3527 * src/tty.c (main): Likewise.
3528 * src/uname.c (main): Likewise.
3529 * src/uniq.c (main): Likewise.
3530 * src/unlink.c (main): Likewise.
3531 * src/uptime.c (main): Likewise.
3532 * src/users.c (main): Likewise.
3533 * src/who.c (main): Likewise.
3534 * src/whoami.c (main): Likewise.
3536 * tests/basename/basic: Adjust to new diagnostics.
3537 * tests/du/files0-from: Likewise.
3538 * tests/expr/basic: Likewise.
3539 * tests/mv/diag: Likewise.
3540 * tests/tsort/basic-1: Likewise.
3542 2004-06-20 Jim Meyering <jim@meyering.net>
3544 * src/ln.c: Remove declaration of yesno.
3545 Instead, include yesno.h.
3546 * src/copy.c: Likewise.
3548 * src/remove.c: Remove declaration of yesno.
3549 Instead, include yesno.h.
3550 (top_dir): Remove now-unnecessary cast of obstack_base.
3551 (pop_dir): Likewise.
3552 (full_filename_): Likewise.
3554 2004-06-19 Paul Eggert <eggert@cs.ucla.edu>
3556 Don't dump core if ctime returns NULL; this is possible on
3557 hosts with 64-bit time_t and 32-bit int.
3558 * src/who.c: Include "inttostr.h".
3559 (time_string): If ctime fails, print the raw time as an integer
3560 instead of dumping core.
3561 * src/pinky.c: Likewise, as follows:
3562 Include "inttostr.h".
3563 (time_string): New function, copied from who.c.
3564 (print_entry): Use it.
3566 2004-06-19 Paul Eggert <eggert@cs.ucla.edu>
3568 * src/who.c (print_line): Don't truncate user names at 8 bytes.
3569 Problem reported by Guido Leenders in:
3570 http://lists.gnu.org/archive/html/bug-coreutils/2004-06/msg00056.html
3571 * NEWS: document this.
3573 2004-06-19 Jim Meyering <jim@meyering.net>
3575 * src/system.h (case_GETOPT_VERSION_CHAR): Switch back to
3576 using GNU_PACKAGE (from PACKAGE) once again. This restores
3577 `GNU' to the parenthesized package name in --version output.
3578 Before, the first argument from AC_INIT, `GNU coreutils', would
3579 be propagated to the PACKAGE variable. Now, `GNU ' is trimmed.
3580 Reported by Richard Stallman.
3582 2004-06-17 Jim Meyering <jim@meyering.net>
3584 * src/tr.c (to_uchar): Rename function from `uchar'. The latter
3585 would clash with a typedef in Tru64's <sys/types.h>. From Albert Chin.
3587 2004-06-15 Paul Eggert <eggert@cs.ucla.edu>
3589 * NEWS: Remove more special cases for POSIXLY_CORRECT when POSIX
3590 allows the GNU behavior. "--" is now supported by chroot, hostid,
3591 hosname, pwd, sync, yes.
3592 * doc/coreutils.texi (yes invocation, false invocation,
3593 true invocation): Document this.
3594 * src/chroot.c (main): Handle "--".
3595 * src/hostid.c (main): Likewise.
3596 * src/hostname.c (main): Likewise.
3597 * src/pwd.c (main): Likewise.
3598 * src/sync.c (main): Likewise.
3599 * src/yes.c (main): Likewise.
3600 * src/true.c (main): Recognize --help and --version even if
3601 POSIXLY_CORRECT is set.
3602 * src/yes.c (main): Likewise.
3604 2004-06-09 Paul Eggert <eggert@cs.ucla.edu>
3606 * NEWS: Remove special cases for POSIXLY_CORRECT when POSIX allows
3608 * doc/coreutils.texi (pr invocation, unlink invocation): Document this.
3609 * src/ls.c (decode_switches): Pay attention to TABSIZE even if
3610 POSIXLY_CORRECT is set. POSIX reserves upper-case environment
3611 variables to the implementation, so it's OK for ls to depend on
3613 * src/pr.c: Include "hard-locale.h".
3614 (main): When in a non-POSIX locale, ignore POSIXLY_CORRECT, since
3615 POSIX specifies the behavior only in the POSIX locale.
3616 * src/printf.c (print_esc): Support \x, \u, \U even if POSIXLY_CORRECT,
3617 since POSIX says the behavior is unspecified here.
3618 * src/tail.c (parse_obsolescent_option): Support multiple file operands
3619 even if POSIXLY_CORRECT, since POSIX does not require a diagnostic.
3620 * src/printf.c (main): Recognize --help, --version even if
3621 POSIXLY_CORRECT. POSIX does not specify any options, but it
3622 does not prohibit options either, so "printf" is like "expr" here.
3623 * src/unlink.c (main): Likewise.
3624 * tests/misc/printf: Adjust to the new semantics for \x if
3627 2004-06-14 Jim Meyering <jim@meyering.net>
3629 * tests/misc/pwd: New test, for fix of 2004-04-19.
3630 * tests/misc/Makefile.am (TESTS): Add pwd.
3631 (BUILD_SRC_DIR): Define BUILD_SRC_DIR.
3633 * src/copy.c: Remove declaration of euidaccess.
3634 Instead, include "euidaccess.h".
3636 2004-06-13 Paul Eggert <eggert@cs.ucla.edu>
3638 * src/who.c (PIDSTR_DECL_AND_INIT): Don't assume pid_t fits in int.
3639 (UT_ID) [!HAVE_STRUCT_XTMP_UT_ID]: Remove bogus comment,
3640 as (sizeof "??") reliably returns 3.
3641 (print_line): Guard against idle and pid being too long
3642 (which is possible when printing headers).
3643 (print_user): Allocate enough bytes for idlestr. Use IDLESTR_LEN.
3644 Avoid unnecessary cast of sizeof to int.
3645 (make_id_equals_comment): Do not assume that UT_ID returns
3646 a string; it might return a non-null-terminated array.
3647 Use strncat instead. It's not very often where strncat is
3648 exactly what you want, but this is one of those rare cases.
3650 2004-06-11 Paul Eggert <eggert@cs.ucla.edu>
3652 * src/who.c (list_entries_who): Don't output a trailing space.
3654 2004-06-09 Jim Meyering <jim@meyering.net>
3656 * src/touch.c (usage): Improve wording in description of the
3657 --time=WORD option. Reported by Dan Jacobson.
3659 * src/chown-core.c (change_file_owner): Change names of parameters
3660 old_uid and old_gid to required_uid and required_gid respectively.
3662 * src/chmod.c (mode_changed): Return false, not 0, now that the
3663 function returns `bool'.
3665 2004-06-08 Paul Eggert <eggert@cs.ucla.edu>
3667 Adjust chmod and chown to be similar if -c or -v are given. In
3668 particular, a no-op chown is no longer reported as a change; this
3669 reverts to previous behavior. Also, fix both commands so that -v
3670 report failures even if the failure is not due to the chmod or
3673 * src/chmod.c (CH_NOT_APPLIED): New constant.
3674 (describe_change): Handle it.
3675 (process_file): Use it, if a symlink wasn't changed.
3676 (mode_changed): Return bool, not int. Accept new argument
3677 NEW_MODE; all callers changed. This lets us avoid statting the
3678 file unless the new mode has unusual bits.
3679 (process_file): Return -1 on error. With -v, report all errors
3680 verbosely, not just some.
3682 * src/chown-core.c (change_file_owner): Return -1 on error, not
3683 1 sometimes and -1 on others. Our caller ORs together our results,
3684 and (-1 | 1) == 0 on ones-complement hosts.
3685 With -v report all errors verbosely, not just some.
3686 Fix bug when chopt->root_dev_ino && !chopt->affect_symlink_referent:
3687 file_stats wasn't set properly in that case.
3689 * tests/chgrp/basic: Adjust to above changes.
3691 2004-05-20 Paul Eggert <eggert@cs.ucla.edu>
3693 * tests/chgrp/basic: Test that chgrp -h does not fail on
3694 symlinks, even on hosts where that's not supported.
3695 Test that if -R is specified without -H or L, -h is assumed.
3696 Test that chown() is not optimized away.
3698 2004-05-18 Paul Eggert <eggert@cs.ucla.edu>
3700 Several fixes to chgrp and chown for compatibility with POSIX and BSD:
3702 Check for incompatible options. When -R and --dereference are
3703 both used, then either -H or -L must also be used. When -R and -h
3704 are both used, then -P must be in effect.
3706 -H, -L, and -P have no effect unless -R is also specified.
3707 If -P and -R are both specified, -h is assumed.
3709 Do not optimize away the chown() system call when the file's owner
3710 and group already have the desired value. This optimization was
3711 incorrect, as it failed to updated the last-changed time and reset
3712 special permission bits, as POSIX requires.
3714 Do not report an error if the owner or group of a
3715 recursively-encountered symbolic link cannot be updated because
3716 the file system does not support it.
3718 * NEWS: Document the above.
3720 * src/chgrp.c (main): Check for incompatible options. -R --dereference
3721 requires either -H or -L, and -R -h requires -P. If -H, specify
3722 FTS_PHYSICAL as well as FTS_COMFOLLOW; this is faster. Make this
3723 file as much like chown.c as possible.
3724 * src/chown.c (main): Likewise.
3726 * src/chown-core.c (change_file_owner): Use ent->fts_statp only if
3727 needed. Chown a directory only after chowning its children; this
3728 avoids problems if the new directory ownership doesn't permit
3729 access to the children. Dereference symlinks before doing
3730 ROOT_DEV_INO_CHECK, not after, so that we catch symlinks to /.
3731 Do not optimize away the chown() system call when the file's owner
3732 and group already have the desired value. POSIX does not permit
3733 this optimization. Rely on chown and lchown to do the right
3734 thing with symlinks and/or -1 arguments, now that we have wrappers
3735 to do this. Use ENOTSUPP not ENOSYS, and ignore all ENOTSUPP
3736 errors, not just command-line errors.
3737 (chown_files): Pass FTS_NOSTAT to xfts_open if we don't need file status.
3739 * src/system.h (ENOTSUP): Remove.
3741 * tests/chgrp/basic: Use chown --from to discover whether the
3742 group changed, since chgrp now changes unconditionally. This
3743 complicates the sed script a bit. Do not specify --dereference,
3744 since it's the default (and we want to test this). Adjust output
3745 to match the fact that chgrp no longer optimizes the case of
3746 changing a file's group to the same value as before.
3747 * tests/chgrp/posix-H: Do not attempt to combine -h and -H; these
3748 options are incompatible, and their behavior is undefined with POSIX.
3749 (changed, not_changed): Adjust to match the fact that -h is no longer
3750 specified. Sort names.
3751 * tests/chown/deref: Adjust error-diagnostic spelling to match new
3754 2004-06-07 Paul Eggert <eggert@cs.ucla.edu>
3756 * src/uname.c (main): Fix typo introduced on 2003-05-10 that
3757 prevented a diagnostic of any operands.
3759 2004-06-08 Jim Meyering <jim@meyering.net>
3761 * src/shred.c (direct_mode): Turn it on/off with directio, too.
3763 2004-06-07 Jim Meyering <jim@meyering.net>
3765 Enable direct-mode I/O (bypassing the buffer cache), if possible.
3766 Prompted by a suggestion from Kalle Olavi Niemitalo
3767 in http://bugs.debian.org/207035.
3768 * src/shred.c (direct_mode): New function.
3769 (do_wipefd): Turn on direct-mode I/O.
3770 (dopass): If a file's first write fails with EINVAL,
3771 turn off direct-mode I/O and retry the write.
3773 2004-06-05 Paul Eggert <eggert@cs.ucla.edu>
3775 * src/tr.c (main): "tr -d a b" is now a fatal error even if
3776 POSIXLY_CORRECT is set. The POSIX SYNOPSIS does not allow this
3779 2004-06-04 Paul Eggert <eggert@cs.ucla.edu>
3781 * src/shred.c (dopass): Don't subtract 1 from the offset after
3782 a write error. Problem reported by Jon Peatfield in:
3783 http://lists.gnu.org/archive/html/bug-coreutils/2004-06/msg00020.html
3785 2004-06-02 Paul Eggert <eggert@cs.ucla.edu>
3787 Fix bug reported by Buciuman Adrian in
3788 <http://mail.gnu.org/archive/html/bug-coreutils/2003-08/msg00105.html>
3789 where 'dd' created a file that was too large. The bug was that dd
3790 assumed that the input file offset does not advance after a failed
3791 read; but POSIX says that the input file offset is undefined after
3794 * src/dd.c (MAX_BLOCKSIZE): New macro.
3795 (input_seekable, input_seek_errno, input_offset,
3796 input_offset_overflow): New vars.
3797 (scanargs): Reject block sizes greater than MAX_BLOCKSIZE.
3798 (advance_input_offset): New function.
3799 (skip_via_lseek): Set errno to zero when reporting our failure,
3800 so that we don't report based on garbage errno.
3801 (skip): If fdesc is standard input, advance the input offset.
3802 Do not quit if reading, and if noerror was specified;
3803 POSIX seems to require this.
3804 If read fails on output file, report the earlier lseek failure
3805 instead; this fixes a FIXME in dd_copy.
3806 (advance_input_after_read_error): New function.
3807 (dd_copy): Use it, instead of assuming that failed reads
3808 do not advance the file pointer. Advance input offset
3809 after nonfailed reads. Advance only a partial block if
3810 the previous read (before the failed read) succeeded, and
3811 do not generate an output block of zeros in this case.
3812 (main): Determine initial input offset, seekability of input,
3813 and error if it wasn't seekable.
3815 2004-06-02 Jim Meyering <jim@meyering.net>
3817 rm (without -f) could hang unnecessarily when attempting to
3818 remove a symlink to a file on an off-line NFS-mounted partition.
3819 Reported by David Howells in https://bugzilla.redhat.com/124699.
3820 * src/remove.c (write_protected_non_symlink): New function.
3821 Don't invoke euidaccess on symlinks.
3822 (prompt): Use write_protected_non_symlink rather than using
3823 euidaccess directly, being careful not to call lstat twice for a file.
3825 Fix a bug in how the --output-delimiter=D option works with
3826 abutting byte or character ranges. Reported by David Krider in
3827 http://lists.gnu.org/archive/html/bug-coreutils/2004-05/msg00132.html
3828 * src/cut.c (print_kth): Remove special case for open-ended range.
3829 (set_fields): Record the range start index for an interval even
3830 when it abuts another interval on its low side.
3831 Also record the range start index of the longest right-open-interval.
3832 * tests/cut/Test.pm: Add tests of --output-delimiter=S with
3833 abutting and overlapping byte ranges.
3835 2004-06-01 Paul Eggert <eggert@cs.ucla.edu>
3837 Some POSIX-conformance cleanups for tr.
3839 * src/tr.c (posix_pedantic): Remove; no longer needed since
3840 we need to test this in just one place now.
3841 (usage): Mention -C.
3842 (unquote): Note that \055, \n, etc are escaped.
3843 Do not worry about POSIXLY_CORRECT when warning about ambiguous
3845 \ at end of string stands for itself.
3846 Do not diagnose invalid backslash escapes: POSIX says the behavior
3847 is unspecified in this case, so we don't need to diagnose it.
3848 (main): Add support for -C (currently an alias for -c).
3849 Do not diagnose 'tr [:upper:] [:upper:], as POSIX does not require
3851 * tests/tr/Test.pm: New tests bs-055, bs-at-end, repeat-Compl.
3852 Fix comment for range-a-a.
3854 2004-05-25 Paul Eggert <eggert@cs.ucla.edu>
3856 Improve the efficiency (and in one case, correctness) of code
3857 that reads symlinks.
3859 * src/copy.c (copy_internal): Don't use alloca, as it can mess up
3860 royally if the link length is long (e.g., GNU/Hurd). Use
3861 xreadlink instead, it's safer. Don't bother to read the link if
3862 it's the wrong size. Add a FIXME because this area is a bit murky
3864 * src/ls.c (get_link_name): Update use of xreadlink.
3865 * src/readlink.c (main): Likewise.
3866 * src/stat.c (print_stat): Likewise.
3868 2004-06-01 Jim Meyering <jim@meyering.net>
3870 * src/env.c (main): Prefer the notation `STREQ (a, b)'
3871 over `!strcmp (a, b)'.
3872 * src/sort.c (main, sort_buffer_size): Prefer the notation
3873 `STREQ (a, b)' over `strcmp (a, b) == 0'.
3874 * src/date.c (batch_convert): Likewise.
3875 * src/expr.c (nextarg): Likewise.
3876 * src/su.c (correct_password, restricted_shell, main): Likewise.
3877 * src/ptx.c (swallow_file_in_memory, main): Likewise.
3878 * src/test.c (binary_operator, and, or, main): Likewise.
3880 2004-05-13 Paul Eggert <eggert@cs.ucla.edu>
3882 * NEWS: echo compatibility cleanup.
3883 * doc/coreutils.texi (echo invocation): Document the changes.
3884 * src/echo.c (V9_ECHO): Remove; always enabled.
3885 (DEFAULT_ECHO_TO_XPG): Renamed from V9_DEFAULT, so that
3886 we use the same naming convention as bash. Now an enum,
3888 (usage): Reword to mention -e/-E more accurately.
3889 Mention \0NNN (the POSIX syntax) rather than \NNN (nonstandard).
3890 (hextobin): New function.
3891 (main): Use bool rather than int for local vars when appropriate.
3892 Do not allow options if POSIXLY_CORRECT, unless we are using
3893 BSD semantics and the first argument is "-n".
3894 Don't pass unnecessary extra arg to parse_long_options.
3895 do_v9 now defaults to DEFAULT_ECHO_TO_XPG, not to allow_options.
3896 Do not look for options if !allow_options.
3897 Use size_t rather than int when appropriate.
3898 Open-code option test rather than using strrchr.
3899 Use faster test for "-".
3900 Avoid redundant argc test.
3901 Add support for \x, for Bash compatibility.
3902 Use e.g. '\a' rather than '\007', for portability to EBCDIC hosts.
3903 When '\c' is encountered, stop printing immediately, as POSIX
3905 Add support for \xhh syntax.
3906 Add support for \0ooo syntax; POSIX requires this.
3908 2004-06-01 Jim Meyering <jim@meyering.net>
3910 * Use automake-1.8b. Regenerate dependent files.
3912 2004-05-31 Jim Meyering <jim@meyering.net>
3914 * tests/Makefile.am.in (TESTS_ENVIRONMENT): Define PATH to include
3915 the build src/ directory -- at the front.
3916 ($(srcdir)/$x-tests): Depend on Makefile.am.
3917 Use $x as the program name, except when it would be `test' (test is
3918 the sole program tested via mk-script that is also a shell built-in).
3919 In that case, use the old ../../src/$x.
3921 2004-05-30 Jim Meyering <jim@meyering.net>
3923 Work around HPUX /bin/cc compiler bug that is exposed, now that
3924 sets are arrays of type `bool'. More details here:
3925 http://lists.gnu.org/archive/html/bug-gnulib/2004-05/msg00094.html
3926 FIXME: verify that the above URL points to the right message
3928 * src/tr.c (card_of_complement): Use cleaner `sizeof in_set'
3929 rather than `N_CHARS * sizeof(in_set[0])'. Using HPUX's /bin/cc
3930 (aC++/ANSI C B3910B A.05.55 [Dec 04 2003]) on an ia64-hp-hpux11.22
3931 system, those two expressions are not the same (256 vs. 1024).
3932 The effect of this problem was that `tr -c x y' would fail:
3933 tr: when not truncating set1, string2 must be non-empty
3934 (set_initialize): Remove unnecessary initialization of the `in_set'
3935 buffer; that initialization triggered the same compiler bug as above.
3937 2004-05-29 Paul Eggert <eggert@cs.ucla.edu>
3939 tr cleanup, mostly having to do with integer type ranges.
3942 * tests/tr/Test.pm: Add a few tests for the below. Alas, most of
3943 the test cases wouldn't be portable, or would take too much CPU
3946 * src/tr.c (N_CHARS, N_CHAR_CLASSES): Now an enum, not a macro.
3947 This is safe since the code already assumes N_CHARS fits in int.
3948 (Filter): Remove: we want to prototype everything.
3949 (ORD, CHR): Remove. All uses removed. Some replaced with:
3950 (uchar): New function. All places where a char must be converted
3951 to an unsigned char are now done this way, not by ad-hoc methods.
3952 (count): New type. Use it whenever counts or states are needed.
3953 (BEGIN_STATE): Increase from INT_MAX - 1 (which was bogus, anyway,
3954 since we used it in an unsigned int context) to UINTMAX_MAX - 1.
3955 (REPEAT_COUNT_MAXIMUM): New macro. Use it in place of BEGIN_STATE
3956 whenever appropriate.
3957 (NOT_A_CHAR): Remove global macro; now a local enum.
3958 (UL_LOWER, UL_UPPER, UL_NONE): No longer specify values, since
3959 the rest of the code no longer depends on them.
3960 (class_ok): Remove; all uses changed to use inline comparisons.
3961 (RE_NO_TYPE): Remove; wasn't used or needed.
3962 (struct List_element): normal_char and equiv_code are now unsigned
3964 first_char, last_char, and the_repeated_char are now unsigned char,
3965 not unsigned int. repeat_count is now count, not size_t.
3967 (struct Spec_list): state is now count, not unsigned int.
3968 lengthis now count, not size_t.
3969 n_indefinite_repeats is now size_t, not int.
3970 has_equiv_class, has_char_class, and has_restricted_char_class
3971 are now bool, not int. All uses changed.
3972 (struct E_string): s is now char *, not unsigned char *.
3973 escaped is now bool *, not int *. All uses changed.
3974 (ES_MATCH): Remove macro, replacing with:
3975 (es_match): New inline function. All uses changed.
3976 (squeeze_repeats, complement, posix_pedantic, truncate_set1,
3977 translating): Now bool, not int.
3978 (io_buf): Now char array, not unsigned char.
3979 (SET_TYPE): Remove. All uses replaced with bool.
3980 (is_equiv_class_member, unquote, append_range, append_char_class,
3981 append_equiv_class, find_closing_delim, star_digits_closebracket,
3982 build_spec_list, parse_str, homogeneous_spec_list):
3983 Now returns bool, not int. All uses changed.
3984 (is_equiv_class_member): Now inline.
3985 (is_equiv_class_member, is_char_class_member, make_printable_str,
3986 append_normal_char, append_range, append_repeated_char,
3988 Args are now of proper integer type.
3989 (unquote, look_up_char_class, make_printable_str,
3990 append_equiv_class, build_spec_list, squeeze_filter):
3991 Avoid unsigned char *p; gently convert *p to unsigned char instead.
3992 (unquote, get_spec_stats): Do not jump past declarations and then
3993 use them; C doesn't allow this in portable programs.
3994 (make_printable_str): Check for overflow in size calculations.
3995 (xmemdup): Remove. All uses rewritten.
3996 (find_bracketed_repeat): Args are now of proper pointer-to-integer
3997 type. Do not reject [c*0]. Use xstrtoumax, not xstrtoul.
3998 (find_bracketed_repeat, star_digits_closebracket): Check that the
3999 digits are not escaped.
4000 (build_spec_list): Don't bother to copy opnd_str; not needed.
4001 (build_spec_list, get_next): Simplify internal logic a bit.
4002 (card_of_complement): Fix bug due to char overflow.
4003 (get_spec_stats): Don't assume len fits into int.
4004 Check for integer overflow. Use abort() rather than assert(0).
4005 (string2_extend): Fix subscript error: is_char_class_member (..., 255)
4007 (squeeze_filter): READER is never null now; simplify code.
4008 READER arg now has a simpler type. Remove unnecessary casts.
4009 (squeeze_filter, main): Calls to fwrite improperly checked result
4010 against zero, rather than against requested size.
4011 (plain_read): New function.
4012 (read_and_delete, read_and_xlate):
4013 Remove unused filter arg, and don't worry about hit_eof.
4014 Simplify by using plain_read.
4015 (set_initialize): Args are bool and bool *, not int and SET_TYPE *.
4016 (main): Always pass a non-null procedure to squeeze_filter.
4017 Rewrite so that class_ok isn't needed.
4019 2004-05-29 Paul Eggert <eggert@cs.ucla.edu>
4021 * src/shred.c (dosync): Ignore EBADF errors, as IRIX 6.5
4022 fdatasync reports EBADF when syncing (unwritable) directories.
4023 Problem reported by Albert Chin-A-Young in:
4024 http://lists.gnu.org/archive/html/bug-coreutils/2004-05/msg00165.html
4026 2004-05-29 Jim Meyering <jim@meyering.net>
4028 * tests/chown/deref: Fix typo: use ls -ldo, not ls -ldg.
4029 Patch from Albert Chin.
4031 * src/ptx.c (text_buffer_maxend): Remove declaration of unused variable.
4033 * src/remove.c (push_dir): Merge declaration and adjacent assignment
4034 into a single statement.
4036 2004-05-28 Jim Meyering <jim@meyering.net>
4038 * src/remove.c (AD_mark_helper): Eliminate an unnecessary comparison.
4040 2004-05-22 Jim Meyering <jim@meyering.net>
4042 rm -r would get a failed assertion when run from an inaccessible
4043 directory and with two or more command line arguments including an
4044 absolute-named directory followed by a relative-named directory.
4046 * src/remove.h (struct rm_options) [require_restore_cwd]: New member.
4047 * src/remove.c (struct cwd_state): Define.
4048 (AD_pop_and_chdir): Redesign interface so that a restore_cwd failure
4049 can be detected by the caller. Instead of returning a malloc'd
4050 directory name, communicate it to caller via a new parameter, and
4051 return an indication of whether restore_cwd failed. Update caller.
4052 Eliminate an unnecessary call to AC_stack_top.
4053 (remove_dir): Change type of cwd_state parameter to `struct cwd_state'
4054 so we can now communicate to caller whether/how functions like
4055 restore_cwd have failed. Update caller.
4056 (rm_1): Fail if we've failed to restore the working directory
4057 and the name of the next file to remove is `.'-relative.
4058 (rm): Fail if the require_restore_cwd flag is true and we've
4059 failed to restore the working directory.
4060 * src/mv.c (rm_option_init): Initialize new member,
4061 x->require_restore_cwd.
4062 * src/rm.c (rm_option_init): Likewise.
4064 2004-05-21 Jim Meyering <jim@meyering.net>
4066 * tests/rm/inaccessible: New test for the above fix.
4067 * tests/rm/Makefile.am (TESTS): Add inaccessible.
4069 * src/remove.c (rm): Use free rather than XFREE.
4070 (remove_dir): Use xmalloc, not XMALLOC.
4071 (ds_init): Likewise.
4073 2004-05-20 Jim Meyering <jim@meyering.net>
4075 * Makefile.maint (sc_unmarked_diagnostics): Now that the unmarked
4076 diagnostics in shred.c have been fixed, don't exempt shred.c from
4079 * src/shred.c: Use translatable diagnostics, e.g.
4080 change "%s: remove" to _("%s: failed to remove") and
4081 change "%s: close" to _("%s: failed to close").
4083 2004-05-17 Paul Eggert <eggert@cs.ucla.edu>
4085 * src/shred.c (names): Bring back lower-case letters, "_", and
4086 ".". But continue to omit +, =, %, @, #, as they're either
4087 shell metacharacters (for some shells) or are not in some
4088 character sets, or (in the case of '%') must be a
4089 metacharacter somewhere.
4091 2004-05-16 Paul Eggert <eggert@cs.ucla.edu>
4093 * src/cut.c (cut_fields): Adjust to new signature of getndelim2.
4095 2004-05-17 Jim Meyering <jim@meyering.net>
4097 * src/shred.c (incname): Decrement `len' only once per loop iteration.
4099 chgrp and chown now dereference symlinks by default, per POSIX.
4100 Reported by Michal Politowski as http://bugs.debian.org/249177.
4102 * src/chown-core.c (chopt_init): Affect each symlink referent by default.
4103 * src/chown.c (usage): Update to reflect this.
4104 * src/chgrp.c (usage): Likewise.
4105 * NEWS: Describe the change.
4106 Adapt tests accordingly.
4107 * tests/chgrp/basic: Use -h where necessary to retain semantics.
4108 * tests/chgrp/deref: Likewise.
4109 * tests/chgrp/posix-H: Likewise.
4111 2004-05-15 Paul Eggert <eggert@cs.ucla.edu>
4113 In shred, check for errors from fdatasync more carefully. If
4114 fdatasync fails with errno==EINVAL, it means this implementation
4115 does not support synchronized I/O for this file. Do not report
4116 this as an error, as (for example) AIX 5.2 fdatasync reports it
4117 for raw disk devices. Problem reported by Albert Chin in
4118 <http://mail.gnu.org/archive/html/bug-gnu-utils/2004-05/msg00028.html>.
4120 Check for write errors, though: the old code ignored them.
4121 Improve error checking in a few other cases, too (e.g., close of a
4124 Also, change several 'int' values to 'bool', so that the error
4125 checking is a bit clearer. Similarly, change unsigned values
4126 to size_t where appropriate.
4128 * src/shred.c: Include "dirname.h".
4129 (datasync) [!HAVE_FDATASYNC]: Remove.
4130 (dosync): New function.
4131 (dopass): Use it. Return 1 on write error, -1 on other error.
4132 All callers changed. Report write error if dosync does.
4133 (do_wipefd, wipefd, wipename, wipefile): Return bool (true/false),
4134 not int (0/-1). All callers changed. Return false if there's a
4136 (incname): Return bool (true/false), not int (0/1). Accept
4137 size_t length, not unsigned. All callers changed. Do not
4138 bother checking for non-digits; it can't happen. Replace
4139 recursion with iteration.
4140 (wipename): Use dir_name, base_name, etc. instead of assuming
4141 Unix file names. Use size_t for length, not unsigned.
4142 Report error if unlink or close fails.
4143 (wipename, main): Use bool for booleans.
4145 (names): Use only digits and uppercase letters, for greater
4148 2004-05-16 Jim Meyering <jim@meyering.net>
4150 * tests/chown/deref: New test for the yesterday's change.
4151 * tests/chown/Makefile.am (TESTS): Add deref.
4153 2004-05-15 Jim Meyering <jim@meyering.net>
4155 chown --dereference did nothing when the owner/group of a
4156 symlink matched the desired owner/group. Reported by David Malone.
4157 Also reported in 1999 as http://bugs.debian.org/39642.
4159 * src/chown-core.c (change_file_owner): When --dereference has
4160 been specified, and when processing a symlink, stat it to get the
4161 owner and group of the referent.
4163 2004-05-14 Jim Meyering <jim@meyering.net>
4165 * man/pwd.x, man/echo.x, man/printf.x: Fix typo:
4166 s/supercede/supersede/ reported by Andrew Fabbro.
4168 2004-05-13 Paul Eggert <eggert@cs.ucla.edu>
4170 Improve performance of `sort -m' on large files, at the cost of
4171 making some contrived examples unsafe. POSIX allows this
4172 optimization. Performance problem reported by Jonathan Baker in
4173 <http://mail.gnu.org/archive/html/bug-coreutils/2004-05/msg00071.html>.
4175 * src/sort.c (first_same_file): Do not treat input pipes
4176 differently from other files.
4177 * doc/coreutils.texi (sort invocation): Document that "sort -m -o F"
4178 might write F before reading all the input.
4181 2004-05-12 Paul Eggert <eggert@cs.ucla.edu>
4183 * src/od.c (print_ascii, dump_strings): Use e.g. '\a' rather than
4184 '\007', for portability to EBCDIC hosts.
4185 * src/printf.c (print_esc_char): Likewise.
4186 * src/tr.c (unquote, make_printable_str): Likewise.
4188 2004-05-12 Jim Meyering <jim@meyering.net>
4190 * src/remove.c (AD_pop_and_chdir): Move lstat-`.' into if-block
4191 where the result is used. This avoids one unnecessary lstat call
4192 per command line argument.
4194 2004-05-12 Paul Eggert <eggert@cs.ucla.edu>
4196 Don't assume that "make -C" works; Solaris "make" doesn't have -C.
4198 * src/Makefile.am (all_programs.list): New rule, copied from
4199 man/Makefile.am and tests/Makefile.am, except that we use the
4200 system tr rather than ./tr and we don't use tr -s.
4201 * tests/Makefile.am (all_programs): Use it.
4202 * man/Makefile.am (all_programs): Likewise. Renamed from programs,
4203 for consistency. All uses changed.
4205 2004-05-11 Jim Meyering <jim@meyering.net>
4207 * tests/rm/unread3: New test, for the above fix and today's
4208 lib/save-cwd.c improvement.
4209 * tests/rm/Makefile.am (TESTS): Add unread3.
4211 * src/rm.c: Don't include "save-cwd.h". It's no longer used.
4213 2004-05-10 Jim Meyering <jim@meyering.net>
4215 * tests/install/trap: New file. Test for bug fix of 2004-04-18.
4216 * tests/install/Makefile.am (TESTS): Add trap.
4218 * src/remove.c (AD_push): Don't use errno in diagnostic about
4221 Remove these generated files from CVS.
4222 * tests/cut/cut-tests, tests/date/date-tests, tests/join/join-tests:
4223 * tests/ls/ls-tests, tests/pr/pr-tests, tests/tac/tac-tests:
4224 * tests/tail/tail-tests, tests/test/test-tests, tests/tr/range-tests:
4225 * tests/tr/tr-tests, tests/wc/wc-tests:
4227 2004-05-09 Jim Meyering <jim@meyering.net>
4229 * src/tr.c (unquote): Use xcalloc rather than xmalloc and
4230 a loop initializing the just-allocated memory to zero.
4232 2004-05-08 Jim Meyering <jim@meyering.net>
4234 * tests/rm/no-give-up: New file; check for today's fix.
4235 * tests/rm/Makefile.am (TESTS): Add no-give-up.
4237 2004-05-08 Paul Eggert <eggert@cs.ucla.edu>
4239 Fix bug where "rm" gave up too easily, reported by Dan Jacobsen in
4240 <http://mail.gnu.org/archive/html/bug-coreutils/2004-05/msg00013.html>.
4242 * src/remove.c (remove_entry): Check for errno values like ENOENT
4243 that show the file cannot be directory, instead of for errno
4244 values like EPERM that show the file might be a directory. This
4245 is necessary because, when a single unlink() call has multiple
4246 reasons to fail, it can set errno to any of those reasons; it's
4247 only the rare errno value like ENOENT that excludes all the other
4248 possible reasons to fail even when the file is a directory.
4249 (remove_cwd_entries): Don't attempt chdir if the file is known
4250 to not be a directory.
4251 (remove_dir): Use the same method that remove_cwd_entries uses
4252 (for some reason they differed). Don't assert that saved_errno
4253 must be EPERM; it might be just about anything.
4255 2004-05-06 Jim Meyering <jim@meyering.net>
4257 * src/id.c (xgetgroups): Use xnmalloc, rather than xmalloc.
4258 Don't add `1' to the buffer size (it was to protect against malloc
4259 implementations that fail to allocate a buffer of size zero).
4260 That is no longer necessary, since we use a malloc wrapper
4263 * src/wc.c (get_input_fstatus): Use xnmalloc, rather than xmalloc.
4264 * src/head.c (elide_tail_bytes_pipe): Likewise.
4265 * src/df.c (main): Likewise.
4266 * src/shred.c (do_wipefd): Likewise.
4267 * src/users.c (list_entries_users): Likewise.
4268 * src/tail.c (main): Likewise.
4269 * src/md5sum.c (main): Likewise.
4271 2004-04-29 Paul Eggert <eggert@cs.ucla.edu>
4273 * src/df.c (show_disk, show_point): If several filesystems are
4274 mounted on the same mount point, prefer the last one, not the first.
4275 Problem reported by Christian Jones in
4276 <http://mail.gnu.org/archive/html/bug-coreutils/2004-04/msg00200.html>.
4277 (show_disk): Remove unused statp arg. Return bool, not int.
4278 (show_point): Rewrite to avoid gotos. Use the same algorithm
4279 for lofs and dummies for each pass through the mount table,
4280 rather than subtly different algorithms (which are probably
4283 2004-05-03 Jim Meyering <jim@meyering.net>
4285 * Makefile.am (EXTRA_DIST): Add m4/ChangeLog, now that we no longer
4288 2004-05-01 Jim Meyering <jim@meyering.net>
4290 When chown or chgrp is modifying the referent of a symlink,
4291 use the chown(2) function, if possible.
4292 * src/chown-core.c (change_file_owner): Don't hard-code the
4293 open/fchown/close kludge here. Use `chown' instead.
4294 The chown function works just fine on conforming systems.
4295 Other systems now go through the new chown wrapper that
4296 resorts to the old kludge.
4298 * src/chown-core.c (change_file_owner): Add a comment.
4300 2004-04-27 Jim Meyering <jim@meyering.net>
4302 * src/ptx.c: Make over 40 global extern variables `static'.
4303 (syntax_table, re_syntax_table): Remove declarations of two unused
4304 variables (they were exposed by the above change).
4306 * src/du.c (G_fail, opt_nul_terminate_output): Declare `static'.
4307 * src/ln.c (backup_type): Likewise.
4309 * src/remove.c (rm): Add `extern' keyword.
4310 * src/cp-hash.c (forget_created, remember_created)
4311 (src_to_dest_lookup, remember_copied, hash_init, forget_all): Likewise.
4312 * src/copy.c (dest_info_init, src_info_init, copy): Likewise.
4313 * src/chown-core.c (chopt_init, chopt_free, gid_to_name)
4314 (uid_to_name, chown_files): Likewise.
4316 * src/Makefile.am (sc_tight_scope): New rule.
4317 * Makefile.maint (sc_tight_scope): New rule.
4318 (syntax-check-rules): Add it.
4320 2004-04-26 Jim Meyering <jim@meyering.net>
4322 * Use automake-1.8.4. Regenerate dependent files.
4324 * src/sort.c (limfield): Make a comment clearer.
4326 2004-04-25 Paul Eggert <eggert@twinsun.com>
4328 Fix POSIX-conformance bug: "sort -k 3,3.5b" is supposed to skip
4329 leading blanks when computing the location of the field end;
4330 it is not supposed to skip trailing blanks. Solaris 8 "sort"
4331 does conform to POSIX. Also fix the documentation to clarify
4332 this and related issues.
4334 * doc/coreutils.texi (sort invocation): Mention -k earlier, so
4335 that the options are in alphabetical order. Describe how -b works
4336 more-accurately; this involves fixing some examples, too. Mention
4337 what happens if the start field falls after an end field or after
4338 a line end. Warn about using -k without -b, -g, -M, -n, or -t.
4339 Add an example of how to sort IPv4 addresses and Apache Common
4340 Log Format dates. Remove a duplicate example.
4341 (Putting the tools together): Use separate options rather
4342 than agglomerating them.
4343 * src/sort.c (limfield): Use skipeblanks, not skipsblanks, to
4344 decode whether to skip leading blanks.
4345 (trailing_blanks): Remove.
4346 (fillbuf, getmonth, keycompare): Don't trim trailing blanks.
4348 * tests/pr/Test.pm: Fix typo in env_default comment.
4349 * tests/sort/Test.pm: Likewise.
4350 (18c, 18d): Reverse the order of output lines, so that the
4351 test cases conform to POSIX.
4353 2004-04-22 Paul Eggert <eggert@twinsun.com>
4355 More signal-handling cleanup for ls.c. Do not allow signals to
4356 happen between arbitrary output bytes, as the
4357 restore-default-color sequence can bollix up multibyte chars or
4358 color-change sequences in the ordinary output. Instead, process
4359 signals only between printing a file name and changing the color
4360 back to non_filename_text color. That way, if the signal handler
4361 changes the color (to the default), 'ls' will change it back when
4362 'ls' continues (after being suspended).
4364 Also, do not bother with signal-handling unless stdout is a
4365 controlling terminal; this lets stdio buffer better when "ls
4366 --color" is piped or sent to a file.
4368 * src/ls.c (sigprocmask, sigset_t) [!defined SA_NOCLDSTOP]: New macros.
4369 Do not include "full-write.h"; no longer needed.
4370 (tcgetpgrp) [! HAVE_TCGETPGRP]: New macro.
4371 (put_indicator_direct): Remove. All callers changed to use
4373 (caught_signals, interrupt_signal, stop_signal_count): New vars.
4374 (restore_default_color): Don't bother checking for put_indicator
4376 (sighandler): Don't handle SIGTSTP; that's another handler now.
4377 Simply set interrupt_signal to the signal, then exit.
4378 (stophandler, process_signals): New functions.
4379 (main): Don't output any color changes until _after_ the signal
4380 handlers are set up. This fixes a race condition where 'ls'
4381 could be interrupted while initializing colors, and leaving the
4382 terminal in an undesirable state.
4383 Don't mess with signal-handling if standard output is not a
4384 controlling terminal.
4385 When exiting, restore the default color, then restore the
4386 default signal handling, then act on any signals that weren't
4388 Do not print //DIRED// etc. in colors; this avoids the need
4389 to catch signals when printing them.
4390 (print_name_with_quoting): Process signals just before switching
4391 color back to non_filename_text.
4393 2004-04-23 Jim Meyering <jim@meyering.net>
4395 Avoid segfault on systems for which SIZE_MAX != (size_t) -1.
4396 * src/ls.c (quote_name): Use SIZE_MAX, not -1, in calls
4397 of quotearg_buffer. Patch by Mikulas Patocka.
4399 2004-04-18 Paul Eggert <eggert@twinsun.com>
4401 tee ignored SIGPIPE, but POSIX doesn't allow this.
4403 * src/tee.c (main): Do not ignore SIGPIPE, as POSIX 1003.1-2001
4404 does not allow this. This undoes the 1996-10-24 patch.
4406 2004-04-18 Paul Eggert <eggert@twinsun.com>
4408 Signal-handling cleanup for coreutils. Here are the highlights:
4410 - csplit sometimes failed to remove files when interrupted.
4411 - csplit didn't clean up if two signals arrived nearly simultaneously.
4412 - install -s would infloop on System V if SIGCHLD was ignored.
4413 - ls could incorrectly restore color if multiple signals
4414 arrived nearly simultaneously.
4416 * src/csplit.c (sigprocmask, sigset_t) [!defined SA_NOCLDSTOP]:
4418 (filename_space, prefix, suffix, digits, files_created, remove_files):
4420 (caught_signals): New var.
4421 (cleanup): Block signals while deleting all files.
4422 (cleanup_fatal, handle_line_error, regexp_error):
4423 Mark with ATTRIBUTE_NORETURN.
4424 (create_output_file, close_output_file, interrupt_handler):
4425 Block signals while changing the number of output files,
4426 to fix some race conditions.
4427 (delete_all_files): Do nothing if remove_files is zero.
4428 Clear files_created.
4429 (main): Don't mess with signals until after argument processing
4432 * src/csplit.c (main): Rewrite signal-catching code to make it
4433 similar to other coreutils programs. When processing signals,
4434 block all signals that we catch, but do not block signals that we
4435 don't catch. Avoid problems with unsigned int warnings.
4436 * src/ls.c (main): Likewise.
4437 * src/sort.c (main): Likewise.
4439 * src/csplit.c (interrupt_handler):
4440 Use void, not (obsolete) RETSIGTYPE.
4441 * src/shred.c (sigill_handler, isaac_seed_machdep): Likewise.
4443 * src/csplit.c (interrupt_handler) [defined SA_NOCLDSTOP]:
4444 Use simpler "signal (sig, SIG_DFL)" rather than sigaction equivalent.
4445 * src/ls.c (sighandler) [defined SA_NOCLDSTOP]: Likewise.
4446 * src/sort.c (sighandler) [defined SA_NOCLDSTOP]: Likewise.
4447 * src/nohup.c (main) [!defined _POSIX_SOURCE]: Likewise, except
4449 * src/tee.c (main) [!defined _POSIX_SOURCE]: Likewise.
4451 * src/install.c: Include <signal.h>.
4452 (main) [defined SIGCHLD]: Set SIGCHLD handler to the default, if -s is
4453 given, since System V fork+wait does not work if SIGCHLD is ignored.
4455 * src/ls.c (sighandler) [!defined SA_NOCLDSTOP]: Reset signal
4456 handler to self, not to SIG_IGN, since SIGTSTP can be received
4458 (main): Use SA_RESTART, as that is simpler than checking for EINTR
4459 failures all over the place.
4461 2004-04-20 Jim Meyering <jim@meyering.net>
4463 * src/remove.c (is_empty_dir): Clarify comment.
4465 * man/help2man: Accept new option: --program-name=NAME, so that we
4466 can override the one in --version output. This is needed solely
4467 so that test.1 doesn't refer to `[' as the program name.
4468 Reported by Benjamin Cutler as http://bugs.debian.org/205251.
4469 * man/Makefile.am (.x.1): Use help2man's new --program-name option.
4471 * src/pwd.c: Don't include pathmax.h; system.h already does it.
4473 * src/cut.c (cut_fields): Free buffer upon getndelim2 failure.
4475 2004-04-19 Jim Meyering <jim@meyering.net>
4477 * src/shred.c (isaac_seed_start) [AVOID_USED_UNINITIALIZED_WARNINGS]:
4478 Initialize a buffer to avoid warnings from tools like valgrind.
4480 * Makefile.maint (sc_trailing_blank): New rule.
4481 (syntax-check-rules): Add it.
4482 * .x-sc_trailing_blank: New file.
4484 Make pwd work even if the resulting name is so long that getcwd fails.
4485 * src/pwd.c: (path_free, path_init, path_prepend): New functions.
4486 (nth_parent, find_dir_entry, robust_getcwd): New functions.
4487 (main): First try getcwd, then, upon failure, robust_getcwd.
4489 2004-04-18 Jim Meyering <jim@meyering.net>
4491 * src/who.c (print_user): Use xrealloc here, rather than
4492 unchecked realloc. Remove anachronistic casts.
4494 * src/remove.c (full_filename_): Don't leak upon failed realloc.
4496 * src/system.h (readdir_ignoring_dot_and_dotdot): New inline function,
4498 * src/remove.c (readdir_ignoring_dotdirs): Move function to system.h,
4499 renaming it. Update uses.
4501 2004-04-17 Jim Meyering <jim@meyering.net>
4503 * configure.ac: Depend on automake-1.8.3.
4505 * src/join.c (add_file_name): Declare function to be `static'.
4506 (string_to_join_field): Likewise.
4507 * src/remove.c (ds_init, ds_free): Likewise.
4509 * Makefile.maint (sc_prohibit_jm_in_m4): New rule.
4510 (syntax-check-rules): Add to the list.
4512 2004-04-13 Paul Eggert <eggert@twinsun.com>
4514 Use page-aligned buffers whenever we bother to do I/O using buffer
4515 sizes that are tailored for the files.
4517 * src/cat.c: Include getpagesize.h.
4518 * src/copy.c: Likewise.
4519 * src/shred.c: Likewise.
4520 * src/split.c: Likewise.
4521 * src/cat.c (main): Align I/O buffers to page boundaries.
4522 * src/copy.c (copy_reg): Likewise.
4523 * src/shred.c (dopass): Likewise.
4524 * src/split.c (main): Likewise.
4525 * src/dd.c (ROUND_UP_OFFSET, PTR_ALIGN): Remove.
4526 All uses replaced by ptr_align.
4527 * src/od.c (gcd, lcm): Remove; now in system.h.
4528 * src/system.h (gcd, lcm, ptr_align): New functions, moved from od.c.
4530 2004-04-14 Jim Meyering <jim@meyering.net>
4532 Remove m4/Makefile.am: it's no longer needed, with newer automake
4533 * configure.ac (AC_CONFIG_FILES): Remove m4/Makefile.in from the list.
4534 * Makefile.am (SUBDIRS): Remove `m4' from the list.
4536 2004-04-13 Jim Meyering <jim@meyering.net>
4538 * configure.ac: Change `jm_' in AC_DEFINE'd names to `gl_'.
4540 2004-03-27 Paul Eggert <eggert@twinsun.com>
4542 * NEWS: cp -pu and mv -u (when copying) now take the destination
4543 file system time stamp resolution into account.
4544 * doc/coreutils.texi (mv invocation): Document this.
4545 (cp invocation): Document -u (it was missing!) with new behavior.
4547 * src/copy.c: Include "utimecmp.h".
4548 (copy_internal): Compare time stamps using utimecmp rather than
4551 2004-04-09 Jim Meyering <jim@meyering.net>
4553 * Makefile.maint (.re-list): New rule/file, to replace
4554 hard-coded list of header file names.
4555 (sc_system_h_headers): Use the new file.
4556 Don't look for sys2.h anymore.
4558 * src/system.h: Include new "stat-macros.h" rather than hard-coding
4559 all of its macro definitions -- the list was slightly out of date.
4560 Suggestion from Dmitry V. Levin.
4562 2004-04-08 Paul Eggert <eggert@cs.ucla.edu>
4564 * NEWS: Remove noctty flag from dd. Suggested by Philippe Troin.
4565 * doc/coreutils.texi (dd invocation): Likewise.
4566 * src/shred.c (O_NOCTTY): Remove redundant decl.
4567 * src/dd.c (flags, usage): Remove noctty flag.
4568 (main): Always use O_NOCTTY when opening files.
4570 2004-04-08 Jim Meyering <jim@meyering.net>
4572 * src/dd.c (dd_copy): Mark two diagnostics for translations.
4573 (set_fd_flags): Undo part of today's change: it's a little
4574 cleaner -- and more efficient in the common case -- to go
4575 ahead and OR in the -1 when fcntl fails.
4577 * Makefile.maint (sc_dd_max_sym_length): New target.
4578 (syntax-check-rules): Add it.
4580 * src/md5sum.c (PROGRAM_NAME) [algorithm == ALG_SHA1]:
4581 Correct spelling: s/shasum/sha1sum. Reported by Jesse Kornblum.
4583 * src/dd.c (set_fd_flags): Don't OR in -1 when fcntl fails.
4584 Rename parameter, flags, to avoid shadowing global.
4585 (LONGEST_SYMBOL): Tweak comment.
4587 2004-04-07 Paul Eggert <eggert@twinsun.com>
4589 * NEWS: New dd conv= symbols nocreat, excl, fdatasync, fsync,
4590 and new dd options iflag= and oflag=.
4591 * src/dd.c (usage): Likewise.
4592 * src/Makefile.am (dd_LDADD, shred_LDADD): Add fdatasync's lib.
4593 * src/dd.c (fdatasync) [!HAVE_FDATASYNC]: New macro.
4594 (C_NOCREAT, C_EXCL, C_FDATASYNC, C_FSYNC): New macros.
4595 (input_flags, output_flags): New vars.
4596 (LONGEST_SYMBOL): New macro.
4597 (struct symbol_value): Renamed from struct conversion. Members
4598 symbol and value renamed from convname and conversion. The
4599 symbol value is now an array instead of a pointer; this saves
4600 a bit of space and time in practice. All uses changed.
4601 (conversions): Add nocreat, excl, fdatasync, fsync. Now const.
4602 (flags): New constant array.
4603 (iflag_error_msgid, oflag_error_msgid): New constants.
4604 (parse_symbols): Renamed from parse_conversion and generalized
4605 to handle either conversion or flag symbols.
4606 (scanargs): Adjust uses of parse_symbols accodingly. Add
4607 support for iflag= and oflag=. Reject attempts to use
4608 both excl and nocreat.
4609 (set_fd_flags): New function.
4610 (dd_copy): Just return X rather than calling quit (X), since our
4611 caller invokes quit with the returned value. Add support for
4612 fdatasync and fsync.
4613 (main): Add support for iflag=, oflag=, and new conv= symbols.
4614 * src/system.h (O_DIRECT, O_DSYNC, O_NDELAY, O_NOFOLLOW,
4615 O_RSYNC, O_SYNC): Define to 0 if not already defined.
4617 * NEWS: Remove duplicate mention of BLOCKSIZE.
4619 2004-04-02 Andreas Schwab <schwab@suse.de>
4621 * src/stty.c: Add support for IUTF8 input flag.
4623 2004-04-06 Jim Meyering <jim@meyering.net>
4625 * src/system.h (makedev) [mkdev && !makedev]: Define in terms of mkdev.
4626 Interix spells it `mkdev'. Reported by Mark Funkenhauser.
4628 2004-04-04 Jim Meyering <jim@meyering.net>
4630 A specified format is no longer automatically newline terminated.
4631 If you want a newline at the end of your format, use `\n'.
4632 * src/stat.c (print_it): Don't print a newline at the end of
4634 (do_statfs): Add a newline at end of each default format string.
4636 2004-03-30 Paul Eggert <eggert@twinsun.com>
4638 * src/nohup.c (main): Adjust to new calling convention
4639 for set_cloexec_flag.
4641 2004-03-31 Jim Meyering <jim@meyering.net>
4643 * tests/Fetish.pm (run_tests): Remove `.orig' file.
4644 Remove debugging diagnostic.
4646 Specifying an invalid --width=N (-w) or --gap-size=N (-g)
4647 would not elicit an error.
4648 * src/ptx.c: Include "xstrtol.h" and "quotearg.h".
4649 (main): Don't use atoi. Use xstrtoul instead.
4651 2004-03-30 Jim Meyering <jim@meyering.net>
4653 * Makefile.maint (sc_prohibit_atoi_atof): New rule.
4654 (syntax-check-rules): Add it.
4655 * .x-sc_prohibit_atoi_atof: New file.
4657 2004-03-29 Jim Meyering <jim@meyering.net>
4659 * tests/du/files0-from: Use new OUT_SUBST directive, so that this
4660 test is not sensitive to system-dependent block size differences.
4661 Prompted by a report of Solaris 8 differences from Paul Eggert.
4663 * tests/Fetish.pm: Accept new directives: OUT_SUBST, ERR_SUBST.
4664 Rename `%tmp' to `%actual'. Reverse order of last two args to
4665 _compare_files (to $actual, $expected) so as to match declaration.
4667 2004-03-28 Paul Eggert <eggert@twinsun.com>
4669 Fix some gotchas encountered when porting to Solaris 8, using
4670 the Forte 6u2 compiler.
4672 * src/hostname.c [HAVE_SETHOSTNAME && !defined sethostname]:
4673 Declare sethostname, since no Solaris header does it.
4674 * src/who.c: Include "vasprintf.h", for asprintf.
4676 2004-03-28 Jim Meyering <jim@meyering.net>
4679 * src/du.c (process_file): Don't record dev/inode for directories.
4681 Under some circumstances, without -c, du would mistakenly count the
4682 space of hard-linked files, not just the first one it encountered.
4683 Reported by Anthony Thyssen.
4684 * src/du.c (du_files): Don't ever clear the set of `seen' dev/inodes.
4686 * src/du.c: Rename global `print_totals' to `print_grand_total'.
4688 * src/du.c (main): Rearrange filtering loop to be a tiny bit
4691 * src/chown-core.c: Don't include savedir.h -- no longer needed.
4692 * src/chmod.c: Likewise.
4694 2004-03-25 Jim Meyering <jim@meyering.net>
4696 * src/du.c (main): Remove now-unused declaration of `i'.
4698 2004-03-24 Paul Eggert <eggert@twinsun.com>
4700 * src/du.c (main): Filter out file names of length zero before
4701 invoking fts, so that they don't cause fatal errors.
4703 2004-03-25 Jim Meyering <jim@meyering.net>
4705 * tests/du/files0-from (zero-len): Add a test for the above.
4707 2004-02-25 Paul Eggert <eggert@twinsun.com>
4709 * NEWS: New environment var BLOCKSIZE.
4710 * lib/human.c (humblock): Support BLOCKSIZE as well as BLOCK_SIZE.
4711 * tests/envvar-check: Test for it. Factor the code to simplify it.
4713 2004-03-23 Paul Eggert <eggert@twinsun.com>
4715 * NEWS: Shorten the du --files0-from announcement, and say
4716 "NUL-terminated" rather than "NUL-separated".
4717 * src/du.c (EXPECTED_BYTES_PER_FILE_NAME, DEFAULT_PROJECTED_N_FILES):
4719 (usage): Say "NUL-terminated", not "NUL-separated".
4720 (main): Check for I/O error when istream is closed.
4721 Allow --files0-from=F even if F is empty; this specifies no files.
4722 (du_files): Now that we allow the list of files to be empty,
4724 * tests/du/files0-from: Adjust to above changes to src/du.c.
4726 2004-03-24 Jim Meyering <jim@meyering.net>
4728 * tests/tail-2/assert: Avoid race condition that could cause
4729 spurious failure. Based on a patch from Andreas Schwab.
4731 2004-03-23 Jim Meyering <jim@meyering.net>
4733 * src/du.c (main): Free the hash table, too.
4735 2004-03-22 Jim Meyering <jim@meyering.net>
4737 * man/Makefile.am (.x.1): Remove --info-page= option, reverting
4738 the change of 2004-01-22. I can no longer reproduce the problem
4739 that prompted that change, and `info coreutils pr' would display the
4740 `printing text' section of the manual, not the one on `pr invocation'.
4742 * tests/du/files0-from (nul-1, nul-2): Adjust expected diagnostics
4743 to match corrected output.
4745 * src/du.c: Include "readtokens0.h" rather than "readtokens.h".
4746 (main): Use readtoken0 functions rather than readtokens.
4747 Don't use errno when diagnosing readtokens0 failure.
4748 Fix off-by-one error in the token number reported in a diagnostic.
4749 (du_files): Return bool, rather than int.
4750 (main): Call readtokens0_free.
4752 2004-03-21 Jim Meyering <jim@meyering.net>
4754 * src/remove.c (ds_free): Plug a small leak.
4756 * tests/Fetish.pm: Fix typo in comment.
4758 2004-03-07 Jim Meyering <jim@meyering.net>
4760 * NEWS: du accepts a new option --files0-from=FILE, where FILE
4761 contains a list of NUL-separated file names.
4763 * src/du.c: Include "readtokens.h".
4764 (usage): Describe the new option, and adjust the `Usage':
4765 with this option, no FILE may be specified on the command line.
4766 (main): Handle the new option.
4768 * tests/du/files0-from: New tests, for the above.
4769 * tests/du/Makefile.am (TESTS): Add files0-from.
4771 * src/factor.c (do_stdin): Reflect changes in use of readtoken.
4772 * src/tsort.c (tsort): Likewise.
4774 2004-02-29 Paul Eggert <eggert@twinsun.com>
4776 * NEWS: Add support for a new notation @N to get_date to represent
4777 the time stamp with numeric value N. Improve support for
4778 fractional time stamps. date's -d and -f options now accept them.
4779 Likewise for touch -t. date has a new option --iso-8601=ns.
4781 * doc/coreutils.texi (touch invocation):
4782 Describe use of fractional seconds.
4783 (date invocation, Options for date): Likewise.
4784 * doc/getdate.texi (General date syntax, Time of day items): Likewise.
4785 * doc/coreutils.texi (date invocation): Mention effect of LC_TIME.
4786 (Options for date): Describe new --iso-8601=ns option.
4788 * doc/getdate.texi: Add copyright notice. Change getdate to
4789 get_date when talking about the function name.
4790 (Seconds since the Epoch): New section, containing the time_t
4791 info moved from Date input formats section, along with new
4792 info about the @ syntax. Mention negative time stamps,
4793 fractional time stamps, and leap seconds.
4794 (General date syntax): Modernize examples a bit to reflect new
4796 (General date syntax, Relative items in date strings):
4797 Use ' rather than " to quote formats.
4798 (Time of day items): Add an example with fractional seconds.
4799 Describe fractional-second syntax.
4801 * src/Makefile.am (touch_LDADD): New macro, since `touch' now
4802 needs clock_gettime.
4804 * src/date.c (enum Time_spec): New enum TIME_SPEC_NS.
4805 (time_spec_string, time_spec, show_date): Support it.
4806 (usage): Remove description of -ITIMESPEC, as it's obsolete and
4807 confusing. Mention --iso-8601=ns.
4808 (batch_convert): getline returns ssize_t, not int.
4810 * src/touch.c (newtime): Now an array of two timespecs, one
4811 for access and one for modification.
4812 (ref_stats): Remove.
4813 (get_reldate): Use get_date's parameter profile.
4814 (touch, main): Adjust to above changes.
4815 (main): Work even if tm_year == INT_MAX (so long as long int is wider).
4816 Use gettime instead of gettimeofday, for new get_date signature.
4818 * tests/date/Test.pm (test_vector): New tests epoch, ns-10, ns-max32,
4821 2004-03-15 Jim Meyering <jim@meyering.net>
4823 * Makefile.maint (alpha beta major): `Make' the emit_upload_commands
4824 target before updating $(prev_version_file).
4826 * tests/misc/date-sec: New file, to test for just-fixed bug in date.
4827 See today's change in lib/getdate.y.
4828 * tests/misc/Makefile.am (TESTS): Add date-sec.
4830 2004-03-14 Jim Meyering <jim@meyering.net>
4832 * announce-gen (print_changelog_deltas): Use `.sig' suffix for
4833 signature files, not `.asc'. Reported by angico@yahoo.com.
4835 2004-03-13 Jim Meyering <jim@meyering.net>
4837 * src/cp.c (do_copy): Tweak wording in a diagnostic.
4838 Suggestion from Karl Berry.
4839 Include "quoatearg.h".
4840 (do_copy): Use quotearg_colon (not quote) for diagnostics
4841 that begin with `"%s:'.
4843 * src/nl.c (usage): Specify that nl uses _basic_ regular expressions.
4844 Suggestion from Dan Jacobson.
4846 2004-03-12 Jim Meyering <jim@meyering.net>
4850 Sometimes, when source and destination partition are different,
4851 mv mistakenly fails to preserve a hard link. Reported by IIDA Yosiaki.
4853 * src/copy.c: When moving a set of N hard-linked files between
4854 partitions, via two or more command line arguments where the
4855 command line argument containing the Nth link contains no other
4856 link to that same file, mv would mistakenly copy the file, rather
4857 than hard-linking it to the other(s). That happens because when the
4858 final link is processed, its link count has been reduced to 1 since
4859 the other links have been `copied' to the destination partition
4860 and the source links have been removed.
4861 (copy_internal): When in move mode, use the source dev/inode
4862 pair to look up destination name even when st_nlink == 1.
4863 * src/cp-hash.c (src_to_dest_lookup): New function.
4864 * src/cp-hash.h (src_to_dest_lookup): Add prototype.
4865 * tests/mv/part-hardlink: New file. Test for the above fix.
4866 * tests/mv/Makefile.am (TESTS): Add part-hardlink.
4868 * announce-gen: Sync with autoconf.
4870 * tests/ls/time-1: Exit 77 (not 1) if we can't set up for the test.
4871 This was triggered on a Linux-2.2.19 system using a file system
4872 NFS-mounted from some sort of Sun.
4874 2004-03-11 Jim Meyering <jim@meyering.net>
4876 * Use automake-1.8.3. Regenerate dependent files.
4878 2004-03-10 Jim Meyering <jim@meyering.net>
4880 * tests/du/deref-args: Also convert sizes in the 70-79 kB range,
4881 so that this test works with SELinux-enabled systems.
4882 Based on a patch from Tim Waugh.
4884 `join -1 x' would give a misleading diagnostic
4885 * src/join.c (string_to_join_field): Report that a non-numeric field
4886 number is invalid, rather than `so large that it is not representable'.
4887 * tests/join/Test.pm (invalid-j): New partial test for the above fix.
4889 2004-03-06 Jim Meyering <jim@meyering.net>
4891 cp --sparse=always sparse-image-file.img /dev/hda1 could
4892 produce an invalid copy on the destination device.
4894 * src/copy.c (copy_reg): Even with --sparse=always, try to
4895 make `holes' only if the destination is a regular file.
4896 Reported by Szakacsits Szabolcs.
4898 2004-03-03 Paul Eggert <eggert@twinsun.com>
4900 * src/nohup.c (main): Don't invoke set_cloexec_flag with
4901 a file descriptor of -1.
4903 2004-03-02 Dmitry V. Levin <ldv@altlinux.org>
4905 * src/nohup.c: Include "cloexec.h".
4906 (main): Set the copy of stderr to close on exec.
4908 2004-03-01 Paul Eggert <eggert@twinsun.com>
4910 * configure.ac: Include <signal.h> when checking for strsignal,
4911 sys_siglist, and friends. Problem reported by Tony Leneis in
4912 <http://mail.gnu.org/archive/html/bug-coreutils/2004-02/msg00136.html>.
4914 2004-02-25 Paul Eggert <eggert@twinsun.com>
4916 * tests/du/deref-args, tests/du/exclude, tests/du/slash:
4917 * tests/du/trailing-slash: Run envvar-check in case BLOCK_SIZE
4920 2004-02-23 Paul Eggert <eggert@twinsun.com>
4922 * NEWS: Document how chown's USER.GROUP argument is now parsed.
4924 2004-02-23 Jim Meyering <jim@meyering.net>
4926 * src/seq.c (usage): Remove stray space after \n in --help output.
4928 2004-02-22 Jim Meyering <jim@meyering.net>
4930 * src/du.c (usage): Separate -H and --si. Say that the meaning
4931 of -H will soon change to that of --dereference-args (-D).
4933 2004-02-21 Jim Meyering <jim@meyering.net>
4935 * src/comm.c (usage): Tell what comm does when there are no options.
4936 Reword in terms of FILE1 and FILE2 rather than `left file' and
4937 `right file'. Suggestion from Dan Jacobson.
4939 2004-02-15 Paul Eggert <eggert@twinsun.com>
4941 Fix some POSIX-conformance bugs in expr.
4943 * NEWS: document the following changes to src/expr.c.
4944 * doc/coreutils.texi (expr invocation): Likewise.
4945 Document what forms integers may take, and say "integer"
4946 consistently instead of "number". Warn about operands
4947 that "expr" can misinterpret, and how to work around the
4949 * src/expr.c (eval, eval7, eval6, eval5, eval4, eval3, eval2, eval1):
4950 Accept a bool argument specifying whether to evaluate the
4951 expression. This is to allow short-circuit evaluation. All
4953 (null): Report that a string is zero even if it has
4954 a form like "-0" or "00".
4955 (eval1, eval): Use short-circuit evaluation for | and &.
4956 (eval): Return 0 if both arguments are null or zero, instead
4957 of returning the first argument.
4958 * tests/expr/basic: Add some tests for the above.
4960 2004-02-17 Jim Meyering <jim@meyering.net>
4964 `make check' from a build inside a chroot environment would fail
4965 * tests/help-version: Specify an argument (`/') for df, in the
4966 unusual event that there is no valid entry in /etc/mtab.
4967 Likewise for id: add the -u option, so we don't get spurious
4968 failures when there are no user or group names.
4971 * src/sort.c (usage) [-u]: Add punctuation so that the description in
4972 the help2man-generated (line-joined) man page is more readable.
4973 Reported by Tim Waugh.
4974 [-T]: Add a semicolon, for the same reason.
4976 2004-02-15 Jim Meyering <jim@meyering.net>
4978 * Makefile.am (dist-hook): Qualify target with $(srcdir)/ prefix.
4980 2004-02-11 Jim Meyering <jim@meyering.net>
4982 * tests/Makefile.am.in ($(srcdir)/Makefile.am): Use more portable
4983 $(srcdir)/../Makefile.am.in, rather than $<.
4984 Suggestion from Michael Elizabeth Chastain.
4986 2004-02-10 Jim Meyering <jim@meyering.net>
4988 * config/install-sh: Make this script executable.
4989 * Makefile.am (dist-hook): New target, to ensure that config/install-sh
4990 is executable. Otherwise, on systems that lack a suitable install
4991 binary, `make install' would fail, because of the way this script
4992 is invoked (without `$SHELL ' prefix).
4993 Reported by Bob Proulx.
4995 2004-02-08 Jim Meyering <jim@meyering.net>
4999 * tests/rm/rm5: Avoid triggering a bug in OSF/Tru64's sed
5000 that would cause an unwarranted test failure.
5001 * tests/rm/rm3: Likewise.
5003 2004-02-07 Jim Meyering <jim@meyering.net>
5005 Remove xstat function pointer member. The way it was used was not
5006 portable, since some systems (OSF V5.1, Solaris 2.5.1) provide static
5007 inline `stat' and `lstat' functions, thus making the tests of
5008 `xstat == lstat' in copy.c always fail.
5009 * src/copy.h (struct cp_options) [xstat]: Remove member.
5011 * src/copy.c (copy_dir): Set `.dereference' member, not .xstat.
5012 (copy_internal): Use `XSTAT (x, ...)' in place of `*(x->xstat) (...)'.
5013 Use `x->dereference == DEREF_NEVER' in place of `x->xstat == lstat'.
5014 (valid_options): Remove now-obsolete FIXME comments.
5016 * src/cp.c (re_protect): Use `XSTAT (x, ...)' in place of
5017 `*(x->xstat) (...)'.
5018 (do_copy): Declare/use local xstat rather than x->xstat.
5019 (main): Remove code that set x.xstat.
5020 * src/mv.c (cp_option_init): Don't initialize xstat member.
5021 * src/install.c (cp_option_init): Likewise.
5023 * Makefile.cfg (gnu_ftp_host-alpha, etc.): Un-factor .gnu.org suffix,
5024 so that emit_upload_commands can use these variables, too.
5026 2004-02-06 Jim Meyering <jim@meyering.net>
5028 * tests/rm/deep-1: Remove `du' stack space test.
5029 Apparently, `ulimit -s N' isn't portable enough.
5030 This test will be restored (with a guard against losing ulimit)
5031 in its own file later.
5033 * tests/rm/deep-1 (deep): Remove progress-style diagnostics,
5034 since this test doesn't take long enough to merit them.
5035 Run du on $tmp (the containing dir), not $deep, the full path to leaf.
5037 * Makefile.maint (signatures): Remove definition.
5038 Now, automake's gnupload handles this.
5039 (%.sig: %): Remove now-unused rule.
5040 (rel-files): Use automake's $(DIST_ARCHIVES), rather than
5041 `$(distdir).tar.bz2 $(distdir).tar.gz'.
5042 (emit-upload-commands): Adjust to use gnupload.
5044 2004-02-05 Jim Meyering <jim@meyering.net>
5046 * src/system.h (ST_TIME_CMP_NS, ST_TIME_CMP): Remove definitions.
5047 (ATIME_CMP, CTIME_CMP, MTIME_CMP, TIMESPEC_NS): Likewise.
5048 Now, those are all defined in timespec.h.
5051 * src/date.c: Don't include timespec.h, now that system.h does it.
5053 2004-02-02 Paul Eggert <eggert@twinsun.com>
5055 Don't dump core if localtime returns NULL (possible on
5056 hosts with 64-bit time_t and 32-bit int).
5057 * src/date.c: Include "inttostr.h".
5058 (batch_convert, main):
5059 If time conversion fails, exit with nonzero status.
5060 (show_date): Return int to report conversion failure.
5061 Print the time as an int if localtime fails.
5062 * src/uptime.c: Print "??" if the current clock can't
5063 be converted by localtime. This won't happen until the year
5064 2*31 + 1900, but we don't want to dump core even if the current
5065 clock has the wrong value.
5067 * src/stat.c: Include "inttostr.h".
5068 (human_time): Print the date/time as a number of seconds since the
5069 epoch if it can't be converted by localtime. This is better than
5070 just saying "invalid", and is consistent with what "ls" does.
5071 Don't dump core if the year has more than 48 digits; this isn't
5072 possible on any contemporary host, but we might as well do it right.
5074 2004-01-31 Paul Eggert <eggert@twinsun.com>
5076 * src/stat.c (human_time): Accept time rather than
5077 pointer-to-const-time parameter, for clarity. All callers changed.
5079 2004-02-02 Jim Meyering <jim@meyering.net>
5081 * src/stat.c (do_stat): Remove extra trailing newline from
5082 default formats. Reported by Nelson H. F. Beebe.
5084 Print actual fractional seconds in time stamps, not just `.00000000'.
5085 * src/stat.c (human_time): Add and use new parameter, t_ns.
5086 (print_stat): Update callers.
5087 * src/ls.c (TIMESPEC_NS): Remove definition.
5088 * src/system.h (TIMESPEC_NS): Define here, instead, now that stat.c
5089 also uses this macro.
5090 Nelson H. F. Beebe noticed that ls --full-time printed nonzero
5091 fractional seconds for files on an XFS file system, but that stat's
5092 fractional seconds were always zero.
5094 2004-01-28 Paul Eggert <eggert@twinsun.com>
5096 * src/seq.c (print_numbers): Use 'double' for loop index, not
5097 'int', to avoid problems with integer overflow. On almost all
5098 machines 'double' works in every case where 'int' works, and
5099 it works on other cases besides.
5101 2004-01-27 Jim Meyering <jim@meyering.net>
5103 * src/seq.c (usage): Mention that if INCREMENT is omitted,
5104 it defaults to 1, even when FIRST is larger than LAST.
5105 Reword so as not to exclude the possibility that INCREMENT be zero.
5107 2004-01-25 Jim Meyering <jim@meyering.net>
5111 * Makefile.maint (signatures): Comment out definition.
5113 2004-01-23 Jim Meyering <jim@meyering.net>
5115 * Makefile.maint (header_regexp): Add exitfail.
5117 * man/Makefile.am (EXTRA_DIST): Add help2man.
5118 Reported by Nelson H. F. Beebe.
5120 * man/Makefile.am (.x.1): Prefix help2man invocation with `$(PERL) --'
5121 so it works on systems with Perl installed somewhere other than in
5124 * src/paste.c (paste_parallel): Declare local, chr, to be of type
5125 `int', not `char', since it must hold EOF. This bug would make
5126 paste infloop on some systems. Test failures reported by
5127 Nelson H. F. Beebe and Christian Krackowizer.
5129 2004-01-22 Jim Meyering <jim@meyering.net>
5131 * tests/rmdir/fail-perm: New file. Test for just-fixed rmdir bug.
5132 * tests/rmdir/Makefile.am (TESTS): Add fail-perm.
5134 * man/help2man: Fix it so using --info-page='coreutils PROG' works.
5135 * man/Makefile.am (.x.1): Invoke our own (tweaked) copy of help2man.
5136 Use --info-page='coreutils PROG' option.
5137 Now, readlink.1 refers the user to `info coreutils readlink'
5138 rather than to `info readlink'. Reported by Matt Swift.
5140 2004-01-21 Paul Eggert <eggert@twinsun.com>
5142 Exit status cleanup.
5144 * src/basename.c (usage): Use EXIT_SUCCESS, not 0, for clarity.
5145 * src/cat.c, src/chgrp.c, src/chmod.c, src/chown.c, src/chroot.c,
5146 * src/cksum.c, src/comm.c, src/cp.c, src/csplit.c, src/cut.c,
5147 * src/date.c, src/dd.c, src/df.c, src/dircolors.c, src/dirname.c,
5148 * src/du.c, src/echo.c, src/env.c, src/expand.c, src/expr.c,
5149 * src/factor.c, src/fmt.c, src/fold.c, src/head.c, src/hostid.c,
5150 * src/hostname.c, src/id.c, src/install.c, src/join.c, src/kill.c,
5151 * src/link.c, src/ln.c, src/logname.c, src/ls.c, src/md5sum.c,
5152 * src/mkdir.c, src/mkfifo.c, src/mknod.c, src/mv.c, src/nice.c,
5153 * src/nl.c, src/nohup.c, src/od.c, src/paste.c, src/pathchk.c,
5154 * src/pinky.c, src/pr.c, src/printenv.c, src/printf.c, src/pwd.c,
5155 * src/rm.c, src/rmdir.c, src/seq.c, src/setuidgid.c, src/shred.c,
5156 * src/sleep.c, src/sort.c, src/split.c, src/stat.c, src/stty.c,
5157 * src/su.c, src/sum.c, src/sync.c, src/tac.c, src/tail.c, src/tee.c,
5158 * src/test.c, src/touch.c, src/tr.c, src/tsort.c, src/tty.c,
5159 * src/uname.c, src/unexpand.c, src/uniq.c, src/unlink.c, src/uptime.c,
5160 * src/users.c, src/wc.c, src/who.c, src/whoami.c, src/yes.c: Likewise.
5162 * src/cat.c (usage): Don't bother normalizing exit status
5163 since the arg is already the correct exit status now.
5164 * src/cksum.c, src/comm.c, src/csplit.c, src/cut.c,
5165 * src/dircolors.c, src/expand.c, src/fmt.c, src/fold.c, src/head.c,
5166 * src/join.c, src/md5sum.c, src/nl.c, src/od.c, src/paste.c,
5167 * src/pr.c, src/split.c, src/sum.c, src/tac.c, src/tail.c, src/tr.c,
5168 * src/tsort.c, unexpand.c, src/src/uniq.c, src/src/wc.c: Likewise.
5170 * src/chown.c (main): Removed unused local 'fail'.
5172 * src/chroot.c (CHROOT_FOUND_BUT_CANNOT_INVOKE, CHROOT_FAILURE):
5175 * src/chroot.c (main): Initialize exit_failure to EXIT_FAIL.
5176 * src/env.c, src/nice.c, src/su.c: Likewise.
5177 * src/nohup.c (main): Likewise, to NOHUP_FAILURE.
5178 * src/setuidgid.c (main): Likewise, to SETUIDGID_FAILURE.
5179 * src/expr.c (main): Use initialize_exit_failure rather than
5180 setting exit_failure directly; this optimizes away redundant
5182 * src/printenv.c, src/sort.c, src/test.c, src/tty.c: Likewise.
5184 * src/chroot.c (main): Exit with status 1 rather than 127
5185 if chroot itself fails, as per documentation.
5187 * src/chroot.c (main): Use EXIT_ENOENT and EXIT_CANNOT_INVOKE
5188 rather than roll-your-own symbols or integers.
5189 * src/env.c (main): Likewise.
5190 * src/nohup.c (main): Likewise.
5191 * src/su.c (run_shell): Likewise.
5193 * src/cp.c (exit_status): Remove static var....
5194 (main): Making it local here instead. Use =, not |=, to set it.
5196 * src/cut.c (FATAL_ERROR, main): Exit with status EXIT_FAILURE,
5198 * src/date.c (batch_convert, main): Likewise.
5199 * src/dd.c (dd_copy): Likewise.
5200 * src/pr.c (first_last_page, main, getoptarg): Likewise.
5201 * src/tr.c (main): Likewise.
5202 * src/date.c (main): Don't assume EXIT_FAILURE == 1, as
5203 POSIX doesn't require it.
5204 * src/dd.c (write_output, skip, dd_copy): Likewise.
5205 * src/df.c (main): Likewise.
5206 * src/id.c (main): Likewise.
5207 * src/install.c (main): Likewise.
5208 * src/ln.c (main): Likewise.
5209 * src/ls.c (main): Likewise.
5210 * src/mv.c (main): Likewise.
5211 * src/shred.c (main): Likewise.
5213 * src/env.c (main): Exit with status 1, not 2, on errors detected
5215 * src/hostname.c (main): Likewise.
5216 * src/nl.c (main): Likewise.
5217 * src/stty.c (main): Likewise.
5219 * src/expr.c (EXPR_FAILURE): Renamed from EXPR_ERROR, for
5220 consistency with the other programs' naming conventions.
5223 * src/factor.c (main): Do not report a usage error simply
5224 because stdin has bad numbers.
5226 * src/id.c (problems): Now a boolean int, not a counter,
5227 so that we don't have to worry about int overflow. All uses changed.
5228 * src/touch.c (err): Likewise.
5230 * src/md5sum.c (main): Use int, not size_t, to store boolean int.
5232 * src/mkfifo.c (main): Exit with status 1, not 4, if not implemented.
5233 * src/mknod.c: Likewise.
5235 * src/nice.c (main): Exit with status EXIT_FAIL, not EXIT_FAILURE,
5236 on error; this is in case EXIT_FAILURE is unusual.
5237 * src/su.c (main): Likewise.
5239 * src/nohup.c (NOHUP_FOUND_BUT_CANNOT_INVOKE): Remove; all uses
5240 changed to EXIT_CANNOT_INVOKE.
5242 * src/printenv.c (PRINTENV_FAILURE): New constant.
5243 (main): Exit with status PRINTENV_FAILURE, not EXIT_FAILURE, on
5244 command-line syntax problems.
5246 * src/rmdir.c (remove_parents): Don't set 'fail' to a negative number.
5247 (main): Avoid integer overflow when seeing whether errors occurred.
5249 * src/seq.c (print_numbers): Now returns void, not (zero) int.
5250 All callers changed.
5251 (main): Remove unused local variable 'errs'. Always exit successfully
5252 if we reach the end.
5254 * src/setuidgid.c (SETUIDGID_FAILURE): Renamed from FAIL_STATUS,
5255 for consistency with other programs here. All uses changed.
5256 (main): Use 'error' to exit rather than invoking 'exit' here.
5258 * src/sort.c: Don't include <assert.h>.
5259 (SORT_OUT_OF_ORDER, SORT_FAILURE): Now enums, not macros.
5260 (usage): Don't use 'assert'.
5261 (main): Remove redundant assignment to exit_failure.
5263 * src/system.h (EXIT_FAIL, EXIT_CANNOT_INVOKE, EXIT_ENOENT):
5265 (initialize_exit_failure): New inline function.
5266 Include exitfail.h here, since we refer to exit_failure.
5267 All callers changed to not include exitfail.h.
5269 * src/tty.c (TTY_FAILURE, TTY_WRITE_ERROR): New enum values;
5270 substitute them for the corresponding integer constants.
5272 * tests/help-version (expected_failure_status_date): Remove, as
5273 'date' is now normal.
5274 (expected_failure_status_nohup): New var.
5276 2004-01-21 Jim Meyering <jim@meyering.net>
5278 * tests/touch/relative: Remove `command' syntax.
5279 Thanks to Nelson H. F. Beebe and Paul Eggert.
5281 * tests/touch/relative: Test only year/month/day, not hours/min/sec,
5282 so as to avoid problems with systems using TAI clocks.
5283 Although it's no longer necessary, set TZ=UTC0 also for the
5284 initial touch command. Reported by Paul Jarc here:
5285 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/1504
5287 2004-01-20 Diego Biurrun <diego@biurrun.de>
5289 * src/dircolors.hin: Add .mov to the list of media files.
5291 2004-01-19 Paul Eggert <eggert@twinsun.com>
5293 * tests/touch/relative: Use TZ=UTC0, not TZ=utc (which isn't
5294 portable). Problem reported by Christian Krackowizer. Also, use
5295 +0000 rather than +0 to specify a time zone, as the documentation
5296 requires four digits.
5298 2004-01-19 Jim Meyering <jim@meyering.net>
5300 * tests/mv/hard-4: Run envvar-check in case SIMPLE_BACKUP_SUFFIX is set.
5301 * tests/mv/backup-is-src: Likewise.
5302 Problem reported by Peter Horst
5304 2004-01-17 Jim Meyering <jim@meyering.net>
5306 * announce-gen (print_changelog_deltas): Use .sig suffix, not .asc.
5310 2003-12-15 Paul Eggert <eggert@twinsun.com>
5312 * NEWS, doc/coreutils.texi: touch -r and -d can now both be specified,
5313 with -r specifying the origin for -d.
5314 * src/touch.c (flexible_date): Remove static var.
5315 (get_reldate): New function.
5316 (main): Use it, to implement this new behavior.
5318 2004-01-16 Jim Meyering <jim@meyering.net>
5320 * tests/touch/relative: New test for the above.
5321 * tests/touch/Makefile.am (TESTS): Add relative.
5323 2004-01-13 Jim Meyering <jim@meyering.net>
5325 * src/system.h: Include contents of sys2.h.
5326 * src/sys2.h: Remove file.
5327 * src/Makefile.am (noinst_HEADERS): Remove sys2.h.
5329 * Use automake-1.8.2. Regenerate dependent files.
5331 * Update to gettext-0.13.1.
5332 * configure.ac: Use gettext-0.13.1.
5333 * .x-sc_space_tab: Add m4/po.m4 to the list of exceptions.
5335 2004-01-12 Jim Meyering <jim@meyering.net>
5337 * Makefile.maint (%.sig): Use .sig suffix rather than .asc.
5339 * Makefile.maint (po-check): Ensure that cvsu works before using it.
5340 Reported by Alexandre Duret-Lutz.
5342 * src/tail.c (main): Warn about following stdin only when it's a tty.
5344 * configure.ac: Use gl_DEFAULT_POSIX2_VERSION.
5346 2004-01-10 Jim Meyering <jim@meyering.net>
5348 * tests/misc/stat-fmt: Use backticks, not `$()' notation.
5350 2004-01-09 Jim Meyering <jim@meyering.net>
5352 * configure.ac: Quote underquoted `jm_DUMMY_1' to avoid new warning.
5354 2004-01-08 Jim Meyering <jim@meyering.net>
5356 * src/stat.c (human_fstype): Use %lx, not %x format for `unsigned long'.
5357 From Andreas Schwab.
5359 * tests/Makefile.am (TESTS_ENVIRONMENT): Remove `/vg' (prerelease test
5360 remnant) from PATH component. That would cause tests in this directory
5361 not to run the just-built binaries, but rather whatever happened
5362 to be in one's PATH. Reported by Christian Krackowizer.
5364 2004-01-04 Jim Meyering <jim@meyering.net>
5366 * src/csplit.c (new_control_record): Use x2nrealloc
5367 rather than xrealloc.
5369 * src/cp.c (re_protect): Use ASSIGN_STRDUPA rather than
5371 (make_path_private): Likewise.
5373 2004-01-03 Jim Meyering <jim@meyering.net>
5375 * src/paste.c: Use `bool' (not int) as the type for a few
5377 (collapse_escapes): Rewrite to set globals rather than modifying
5379 Use size_t (not int) for all counters and related index variables.
5380 (paste_parallel): Remove needless complexity of
5381 using xrealloc in the loop; just allocate the buffers up front.
5382 Free the two temporary buffers.
5383 Move declarations of locals `down' into scope where used.
5384 (paste_serial): Remove `register' attributes.
5385 (main): Simplify delim-related code.
5386 Free `delims', now that it's malloc'd.
5388 2004-01-02 Jim Meyering <jim@meyering.net>
5390 * src/chroot.c: Include "quote.h".
5391 (CHROOT_FOUND_BUT_CANNOT_INVOKE, CHROOT_FAILURE): Define.
5392 (main): Exit with status of 127, not 1, for too-few-args,
5393 chroot failure, or chdir failure.
5394 Give a better diagnostic upon execvp failure.
5396 * src/du.c (usage): Mention that, with its current meaning,
5399 * src/tail.c (main): Warn about following stdin when it's a tty.
5400 Fail when following by name but no names are specified.
5402 2003-12-30 Jim Meyering <jim@meyering.net>
5404 * src/fold.c (main): Use memcpy, not strcpy.
5406 * src/copy.c (copy_internal): Use ASSIGN_STRDUPA rather than
5409 2003-12-28 Jim Meyering <jim@meyering.net>
5411 * src/unexpand.c (n_tabs_allocated): New global.
5412 (add_tabstop): Use x2nrealloc rather than xrealloc.
5413 * src/expand.c: Likewise.
5415 * tests/misc/expand: New file.
5416 * tests/misc/Makefile.am (TESTS): Add expand.
5418 * src/sort.c (add_temp_dir): Use x2nrealloc rather than xrealloc.
5419 (fillbuf): Use x2nrealloc rather than xrealloc.
5420 (sort): Use xnmalloc rather than xmalloc.
5423 2003-12-27 Jim Meyering <jim@meyering.net>
5425 * src/tee.c (tee): Use xnmalloc rather than xmalloc.
5427 2003-12-29 Paul Eggert <eggert@twinsun.com>
5429 * NEWS: Remove support for join -j1 FIELD, -j2 FIELD, and -o LIST1
5430 LIST2 in POSIX 1003.1-2001 hosts, as required by POSIX.
5432 * doc/coreutils.texi (join invocation): Remove documentation
5433 accordingly. Document that -t makes all separators significant.
5435 * src/join.c: Include posixver.h.
5436 (obsolete_usage): New var.
5437 (longopts): Put obsolete options first.
5438 (OBSOLETE_LONG_OPTIONS): New constant.
5439 (get_option, add_file_name): New functions.
5440 (main): Use them to support new behavior.
5441 (usage): Remove documentation for -j1 FIELD and -j2 FIELD.
5442 Do not mark -j FIELD as obsolescent; it is longstanding
5443 UNIX tradition and is a valid extension to POSIX.
5445 * tests/join/Test.pm (tv): Avoid obsolete -o usage.
5447 2003-12-28 Paul Eggert <eggert@twinsun.com>
5449 * src/join.c (add_field_list): Don't use alloca with unbounded
5450 size; just modify the argument, which is no longer const *.
5452 Various other minor cleanups, mostly to avoid the need for casts.
5454 (extract_field): Renamed from ADD_FIELD, as it's now a function.
5456 (struct field.beg): Now char *, not unsigned char const *. All
5457 uses changed. It shouldn't be const since xmemcoll writes on its
5459 (extract_field): Likewise, for 2nd arg.
5460 (keycmp): Remove now-unnecessary cast of xmemcoll args.
5462 (is_blank): New function, to avoid need to cast arg to unsigned char.
5463 (extract_field): Use it.
5465 (xfields): Rewrite pretty much from scratch.
5467 (hard_LC_COLLATE): Now bool, not int.
5468 (get_line, getseq, add_field_list): Now returns bool, not int.
5469 (decode_field_spec, add_field_list): Return true on success (not
5470 false), for consistency with the rest of the code. All uses changed.
5472 (tab): Now char, not unsigned char. This wasn't 100% necessary
5473 but is slightly cleaner.
5474 (prjoin): Hoist (tab ? tab : ' ') expression, to help the compiler.
5476 (empty_filler): Now const *.
5478 (make_blank): Remove; wasn't needed. Remove all calls.
5479 (main): Don't set uni_blank.nfields; zero is fine.
5481 2003-12-27 Jim Meyering <jim@meyering.net>
5483 * src/join.c: Include "quote.h".
5484 (min, max): Remove definitions.
5485 Make a few function parameters and corresponding
5486 locals `const'. Use bool for boolean variables.
5487 Use size_t (not int) for all counters and related index variables.
5488 (prjoin): Remove now-useless assertion.
5489 (string_to_join_field): New function.
5490 (main): Accept join fields as large as SIZE_MAX.
5491 (keycmp): Rename `min' to MIN and max to MAX.
5493 2003-12-26 Jim Meyering <jim@meyering.net>
5495 fold -s didn't work on e.g., alpha-based systems.
5496 * src/fold.c (fold_file): Adjust types (int->size_t) so that using
5497 x2nrealloc works properly on systems with differing sizes for int
5498 and size_t. Reported by Nelson Beebe.
5500 * src/fold.c: Use `bool' (not int) as the type for a few
5503 2003-12-23 Paul Eggert <eggert@twinsun.com>
5505 * src/ls.c (length_of_file_names_and_frills):
5506 Remove forward decl; not needed.
5507 (print_file_name_and_frills, length_of_file_name_and_frills):
5508 With -m, don't output spaces before inum or size.
5509 (print_with_commas): Don't output space just before newline.
5511 2003-12-24 Jim Meyering <jim@meyering.net>
5513 * tests/ls/Makefile.am (TESTS): Add m-option.
5514 * tests/ls/m-option: New file. Test for above fixes.
5516 2003-12-20 Jim Meyering <jim@meyering.net>
5520 * src/pr.c: Change type of global, buff_allocated, to size_t.
5522 * src/join.c [struct seq]: Change types of members count and alloc
5523 from `int' to `size_t'.
5525 * tests/Makefile.am (root-hint): Tweak wording.
5527 * src/du.c: Accept new option (-0, --null) that makes it so each
5528 output line is NUL-terminated rather than newline-terminated.
5530 * src/dd.c (apply_translations): Don't prohibit conv=unblock,sync.
5531 Reported by Volker Paul.
5532 * tests/dd/Makefile.am (TESTS): Add unblock-sync.
5533 * tests/dd/unblock-sync: New test for the above.
5535 2003-12-19 Jim Meyering <jim@meyering.net>
5537 * tests/misc/nohup: Double quote back-ticked expression,
5538 in case it ends up having an unexpected value.
5540 * tests/ls/no-arg: Use ls's -1 option in both runs.
5542 * src/du.c (fts_debug): New global.
5543 (FTS_CROSS_CHECK, DEBUG_OPT): Define.
5544 (main): Make fts use FTS_TIGHT_CYCLE_CHECK.
5545 (main) [DU_DEBUG]: Accept -d option.
5547 2003-12-18 Jim Meyering <jim@meyering.net>
5549 * src/ls.c (format_user): Increment dired_pos via two statements,
5550 `dired_pos += width; dired_pos++;' rather than one,
5551 `dired_pos += width + 1;' since the latter could conceivably overflow.
5552 (format_group): Likewise.
5555 * configure.ac: Require automake-1.8.
5557 2003-12-12 Jim Meyering <jim@meyering.net>
5559 * Use automake-1.8. Regenerate dependent files.
5561 2003-12-08 Jim Meyering <jim@meyering.net>
5563 * Makefile.maint (news-date-check): New rule.
5564 (alpha beta major): Depend on it.
5566 2003-12-03 Paul Eggert <eggert@twinsun.com>
5568 * NEWS: ls -l (and similar options) now adjust all columns to
5569 fit the data. Generalized from a suggestion by Leah Q for file sizes.
5570 * src/ls.c (INODE_DIGITS, LOGIN_NAME_MAX, ID_LENGTH_MAX): Remove.
5571 (format_user_width, format_group_width, unsigned_file_size,
5572 format_group): New functions.
5573 (block_size_width): Renamed from block_size_size.
5574 (inode_number_width, nlink_width, owner_width, group_width,
5575 author_width, major_device_number_width, minor_device_number_width,
5576 file_size_width): New vars.
5577 (clear_files): Initialize them.
5578 (gobble_file): Set them. Don't ceiling block_size_width to 7.
5579 (print_long_file): Use them.
5580 (gobble_file): Use a new local variable 'f' to make the code
5581 smaller and more consistent with other functions.
5582 (format_user): Output to stdout, not to a buffer, so that we
5583 don't have to worry about buffer overrun. Update dired_pos.
5584 (print_long_file): Don't put owner, group, author into buffer;
5585 just print them directly. Don't assume link counts and
5586 major and minor numbers fit into unsigned long int.
5587 * tests/cp/same-file, tests/mv/part-symlink: Don't assume that
5588 'ls' output is fixed-width.
5590 2003-12-02 Jim Meyering <jim@meyering.net>
5592 * src/md5sum.c: Include sha1.h (reflect renaming: sha.h -> sha1.h.
5594 2003-11-27 Jim Meyering <jim@meyering.net>
5596 * Use automake-1.7f. Regenerate dependent files.
5598 2003-11-24 Paul Eggert <eggert@twinsun.com>
5600 Parse floating-point operands and options in the C locale.
5601 POSIX requires this for printf, and we might as well be
5602 consistent elsewhere (tail, sleep, seq).
5604 * src/printf.c: Remove decls of strtod, strtol, strtoul; no longer
5605 needed now that we assume C89. Include "c-strtod.h".
5606 (xstrtod): Call c_strtod, not strtod.
5607 * src/sleep.c: Include "c-strtod.h".
5608 (main): Update xstrtod call to include new argument, c_strtod.
5609 * src/seq.c (scan_double_arg): Likewise.
5610 * src/tail.c (parse_options): Likewise.
5612 2003-11-24 Jim Meyering <jim@meyering.net>
5614 * tests/rm/fail-2eperm: Handle another errno variant (HPUX, EPERM).
5615 Reported by Mark Conty.
5617 2003-11-22 Jim Meyering <jim@meyering.net>
5619 * Makefile.maint (sc_xalloc_h_in_src): Remove rule. Subsumed by...
5620 (sc_system_h_headers): Do this test only if sys2.h exists.
5622 2003-11-20 Jim Meyering <jim@meyering.net>
5624 * tests/help-version: Ensure that the bug-reporting address is
5625 included in the --help output for every program.
5626 * tests/Makefile.am (TESTS_ENVIRONMENT): Add $PACKAGE_BUGREPORT.
5628 * src/ptx.c (usage): Output bug-reporting address.
5629 Reported by Dan Jacobson.
5631 2003-11-19 Jim Meyering <jim@meyering.net>
5633 * src/join.c (usage): Mention that FILE1 and FILE2 must be sorted
5634 on the join fields. Suggestion from Bruce Robertson.
5636 2003-11-18 Jim Meyering <jim@meyering.net>
5638 `od -c -w9999999' could segfault
5639 * src/od.c (dump): Use xnmalloc/free, not alloca.
5641 2003-11-16 Jim Meyering <jim@meyering.net>
5643 * Use autoconf-2.59. Regenerate dependent files.
5645 * tests/du/hard-link: Minor tweak: use mkdir -p.
5647 Fix read-from-free'd-buffer error detected by valgrind.
5648 * src/csplit.c (remove_line): Don't return a pointer to data in
5649 a freed buffer. Instead, arrange to free the buffer on the
5652 * tests/misc/csplit: New test for above fix.
5654 2003-11-11 Jim Meyering <jim@meyering.net>
5656 * src/ls.c (extract_dirs_from_files): Avoid useless copy operations.
5657 This avoids a warning from valgrind about memcpy with overlapping
5658 source and destination.
5660 * configure.ac: Require automake-1.7.8.
5662 2003-11-09 Jim Meyering <jim@meyering.net>
5664 * Use automake-1.7.9. Regenerate dependent files.
5666 * src/rm.c: Support new options: --preserve-root and --no-preserve-root.
5667 * src/chown.c: Likewise.
5669 * src/chown-core.c: Include "root-dev-ino.h".
5670 (chopt_init): Initialize new member.
5671 (change_file_owner): Support rm's new --preserve-root option.
5673 * src/remove.c: Include "root-dev-ino.h".
5674 (remove_cwd_entries): Remove now-obsolete FIXME comment.
5675 (remove_dir): Support rm's new --preserve-root option.
5677 * src/chown.c: Include "root-dev-ino.h".
5678 Add new options: --preserve-root and --no-preserve-root.
5680 * src/chmod.c: Include "root-dev-ino.h".
5681 (process_file): Use newly-factored-out ROOT_DEV_INO_CHECK and
5682 ROOT_DEV_INO_WARN macros.
5683 (get_root_dev_ino): Remove function definition, now that it's
5684 been moved to a separate file.
5685 (usage): Describe new options.
5687 * src/mv.c (rm_option_init): Initialized new member.
5689 * src/remove.h: Include "dev-ino.h".
5690 (struct rm_options): Add new member: root_dev_ino.
5691 * src/chown-core.h: Include "dev-ino.h".
5692 (struct Chown_option): Add new member: root_dev_ino.
5694 2003-11-06 Jim Meyering <jim@meyering.net>
5696 * src/paste.c (paste_parallel): Use `sizeof *var' rather than
5697 hard-coding `sizeof FILE*'.
5699 2003-11-05 Dennis Smit <ds@nerds-incorporated.org>
5701 * src/wc.c (main): Free `fstatus' so there is no confusion about
5702 whether it's leaked or not.
5703 * src/who.c (who): Likewise for `utmp_buf'.
5705 2003-11-05 Paul Eggert <eggert@twinsun.com>
5707 Fix 'cut' problems with size_t overflow and unsigned int.
5708 More generally, resize integer variables to fit use more precisely.
5709 * src/cut.c (ADD_RANGE_PAIR): Remove unnecessary parens.
5710 (struct range_pair): Make members to be of type size_t, not unsigned.
5711 (max_range_endpoint, eol_range_start): Now size_t, not unsigned.
5712 (suppress_non_delimited, output_delimiter_specified,
5713 have_read_stdin, print_kth, set_fields): Now bool, nt int.
5714 (delim): Now unsigned char, not int.
5715 (mark_printable_field, is_printable_field, is_range_start_index,
5716 set_fields, set_fields, cut_bytes, cut_fields):
5717 Use size_t, not unsigned, for field and byte counts.
5718 (hash_int): Use uintptr_t, not unsigned, for pointers converted
5719 to integers. This squeezes more info out of them.
5720 (set_fields, cut_bytes, cut_fields, main):
5721 Use bool, not int, for booleans.
5722 (set_fields): Allocate zeroed byte array with xzalloc, not xcalloc.
5724 2003-11-05 Paul Eggert <eggert@twinsun.com>
5726 * man/Makefile.am (check-programs-vs-x):
5727 Work even if $(programs) contains '$'.
5728 Work even if 'missing=1' in environment.
5729 Don't report an error simply because $(programs) outputs nothing.
5731 2003-11-05 Jim Meyering <jim@meyering.net>
5733 * Use autoconf-2.58. Regenerate dependent files.
5735 * src/tr.c (spec_init): Fix typo in last change.
5737 * src/sys2.h (case_GETOPT_VERSION_CHAR): Cast NULL to `(char *)' in
5738 call to variadic version_etc function, so that it works even on systems
5739 for which sizeof char* != sizeof int.
5740 * src/true.c (main): Likewise.
5741 * basename.c, chroot.c, cksum.c, dd.c, dirname.c, echo.c, expr.c:
5742 * factor.c, hostid.c, hostname.c, link.c, logname.c, nice.c, nohup.c:
5743 * pathchk.c, printenv.c, printf.c, pwd.c, setuidgid.c, sleep.c, stty.c:
5744 * sync.c, test.c, tsort.c, unlink.c, uptime.c, users.c, whoami.c, yes.c:
5745 Similarly, cast NULL to `(char *)' in call to variadic function,
5746 parse_long_options, so that it works even on systems for which
5747 sizeof char* != sizeof int.
5748 A similar problem was reported by Harti Brandt in
5749 http://mail.gnu.org/archive/html/bug-gnu-utils/2003-10/msg00320.html.
5751 * src/users.c (users): Free `utmp_buf' explicitly so that people
5752 don't mistake this for a real leak.
5753 Patch by Dennis Smit <ds@nerds-incorporated.org.
5755 2003-11-04 Paul Eggert <eggert@twinsun.com>
5757 * README: Document _POSIX2_VERSION.
5759 2003-11-04 Jim Meyering <jim@meyering.net>
5761 * src/tac.c (memrchr): Remove #if-0'd function.
5762 (tac_stdin_to_mem): Clean up #if-0'd code.
5764 * src/od.c (decode_format_string): Remove unnecessary casts.
5765 Use more maintainable `sizeof *var'.
5766 (main): Call decode_format_string rather than decode_one_format,
5767 now that `spec' may be NULL.
5769 * src/chmod.c (AUTHORS): Add my name.
5771 * src/split.c (next_file_name): Use `sizeof *var' rather than
5772 hard-coding `sizeof size_t'.
5774 * src/sort.c (new_key): Use xzalloc, not xcalloc (1, ...).
5776 * src/cut.c (ADD_RANGE_PAIR): Use x2nrealloc rather than xrealloc,
5777 to avoid potential overflow in pointer arithmetic.
5778 (set_fields): Use not `1', but rather `sizeof *printable_field' as
5779 second argument to xcalloc.
5780 * src/od.c (decode_format_string, dump_strings): Use x2nrealloc
5781 rather than xrealloc.
5782 * src/date.c (show_date): Likewise.
5783 * src/join.c (ADD_FIELD, initseq, getseq): Likewise.
5784 * src/pr.c (store_char): Likewise.
5785 * src/fold.c (fold_file): Likewise.
5787 * src/copy.c (triple_hash, triple_hash_no_name): Adjust to reflect
5788 type changes (unsigned int -> size_t) in hash.c.
5789 * src/cp-hash.c (src_to_dest_hash): Likewise.
5790 * src/du.c (entry_hash): Likewise.
5791 * src/ls.c (dev_ino_hash): Likewise.
5792 * src/cut.c (hash_int): Likewise. Declare function as static.
5794 2003-11-03 Jim Meyering <jim@meyering.net>
5796 * tests/misc/Makefile.am (TESTS_ENVIRONMENT): Define PACKAGE_VERSION.
5797 * tests/misc/fold: Fail the test immediately if we're not running
5798 the expected version of fold.
5800 2003-11-02 Jim Meyering <jim@meyering.net>
5802 * src/tr.c (append_normal_char, append_range, append_char_class)
5803 (append_repeated_char, append_equiv_class, spec_init): Use `sizeof *var'
5804 rather than `sizeof EXPLICIT_TYPE'. The former is more maintainable
5805 and usually shorter.
5806 * src/copy.c (copy_internal): Likewise.
5807 * src/join.c (initseq, add_field, make_blank): Likewise.
5808 * src/od.c (main): Likewise.
5809 * src/cp.c (make_path_private): Likewise.
5810 * src/tsort.c (new_item, record_relation): Likewise.
5812 * src/df.c (add_fs_type, add_excluded_fs_type, main): Likewise.
5813 (main): Also remove anachronistic cast of xmalloc return value.
5814 * src/ptx.c (alloc_and_compile_regex, main): Likewise.
5815 (main): Also remove anachronistic cast of xmalloc return value.
5816 * src/sort.c (inittables): Likewise.
5817 (sort): Also Split a long line.
5819 2003-10-25 Jim Meyering <jim@meyering.net>
5821 * src/copy.c (triple_hash, triple_hash_no_name): Adjust to reflect
5822 type changes (unsigned int -> size_t) in hash.c.
5823 * src/cp-hash.c (src_to_dest_hash): Likewise.
5824 * src/du.c (entry_hash): Likewise.
5825 * src/ls.c (dev_ino_hash): Likewise.
5826 * src/cut.c (hash_int): Likewise. Declare function as static.
5828 2003-10-21 Jim Meyering <jim@meyering.net>
5830 Don't fail when run with VERBOSE=yes.
5831 * tests/chgrp/basic: Do `set +x' before starting the subshell
5832 from which we invoke chgrp. Otherwise, the output from the
5833 VERBOSE=yes-induced `set -x' would result in spurious differences.
5834 Reported by Russel Coker via Michael Stone.
5836 2003-10-19 Jim Meyering <jim@meyering.net>
5838 chmod now uses fts to perform a directory traversal when -R is
5839 specified. Before, it operated on full path names, and as such
5840 would encounter the PATH_MAX (often 4096) limit.
5842 * src/chmod.c: Include "xfts.h".
5843 (process_file): Rename from change_file_mode.
5844 Adapt to be used with fts.
5845 (process_files): New function.
5847 2003-10-18 Jim Meyering <jim@meyering.net>
5849 * tests/du/deref-args: Ensure that du -D now dereferences all
5850 symlinks specified on the command line, not just those that
5851 reference directories.
5853 * basename.c, cat.c, chroot.c, cksum.c, comm.c, cp.c, csplit.c, cut.c:
5854 * dd.c, df.c, dirname.c, du.c, echo.c, env.c, expr.c, factor.c, head.c:
5855 * hostid.c, hostname.c, id.c, link.c, ln.c, logname.c, ls.c, md5sum.c:
5856 * mv.c, nice.c, nl.c, nohup.c, paste.c, pathchk.c, pinky.c, pr.c:
5857 * printenv.c, printf.c, pwd.c, rm.c, setuidgid.c, sleep.c, sort.c:
5858 * split.c, stty.c, sum.c, sync.c, tac.c, tail.c, tee.c, test.c:
5859 * touch.c, tsort.c, uniq.c, unlink.c, uptime.c, users.c, wc.c:
5860 * who.c, whoami.c, yes.c (AUTHORS): Revert the WRITTEN_BY/AUTHORS change
5861 of 2003-09-19. Now, AUTHORS is a comma-separated list of strings.
5862 Update the call to parse_long_options so that `AUTHORS, NULL' are the
5864 * src/true.c (main): Append NULL to version_etc argument list.
5865 * src/sys2.h (case_GETOPT_VERSION_CHAR): Likewise.
5867 2003-10-17 Andreas Schwab <schwab@suse.de>
5869 * tests/mk-script: Get $srcdir from first parameter instead of
5871 (main): Update usage.
5873 * tests/Makefile.am.in ($(srcdir)/$x-tests): Pass $(srcdir) as
5874 first argument of mk-script.
5875 ($(srcdir)/Makefile.am): Likewise. Prepend $(srcdir) to target.
5877 2003-10-17 Jim Meyering <jim@meyering.net>
5879 * src/mv.c (usage): Tweak descriptions of -i and -f so that the
5880 generated `man' page is more readable. Suggestion from Dan Jacobson.
5882 * src/chown-core.c (change_file_owner): Handle the cases in
5883 which fts_info indicates an error with the given entry.
5885 * src/du.c (main): Simply assign to bit_flags.
5886 Don't bother with bit arithmetic.
5888 * tests/chmod/no-x: New file.
5889 * tests/chgrp/no-x: New file.
5890 * tests/chmod/Makefile.am (TESTS): Add no-x.
5891 * tests/chgrp/Makefile.am (TESTS): Likewise.
5893 * src/du.c: Include "xfts.h".
5894 (du_files): Use xfts_open, rather than fts_open.
5895 * src/chown-core.c (chown_files): Likewise.
5897 2003-10-16 Jim Meyering <jim@meyering.net>
5899 * src/chgrp.c (main): Simply assign to bit_flags.
5900 Don't bother with bit arithmetic.
5901 * src/chown.c (main): Likewise.
5902 Rename a couple of local variables.
5903 Remove unnecessary casts.
5905 * src/tail.c (start_bytes): Rename local, remainder, to avoid
5906 gcc's warning about shadowing a global.
5908 2003-10-15 Jim Meyering <jim@meyering.net>
5910 chown and chgrp now accept POSIX-mandated -H, -L, -P options and
5911 use fts to perform a directory traversal when -R is specified.
5912 Before, they operated on full path names, and as such would
5913 encounter the PATH_MAX (often 4096) limit.
5914 They are more efficient. For example, before, chgrp -R would
5915 take almost 5 seconds to change about 2000 directories and fail
5916 (with `File name too long'), while now it succeeds on a hierarchy
5917 of depth 20,000 in 1/10 the time.
5919 * src/chown.c: Include "userspec.h" and "fts_.h".
5920 (WRITTEN_BY): Add my name.
5921 (getpwnam, getgrnam, getgrgid): Remove declarations.
5922 (endpwent): Remove definition.
5924 (main): Handle new options.
5925 Call new function, chown_files rather than change_file_owner.
5927 * src/chgrp.c: Include "fts_.h".
5928 (WRITTEN_BY): Add my name.
5929 (MAXUID, MAXGID): Remove definitions. Use GID_T_MAX instead of
5932 (main): Handle new options.
5933 Call new function, chown_files rather than change_file_owner.
5935 Rewrite to iterate through hierarchies using fts rather than
5936 via explicit recursion.
5937 * src/chown-core.c: Include "fts_.h"
5938 (change_file_owner): Rewrite to use FTS* and FTSENT* and to operate
5939 on a single file at a time.
5940 (chown_files): New function.
5941 * src/chown-core.h [enum Dereference_symlink]: Remove declaration.
5942 [struct Chown_option] (recurse, force_silent): Change type to `bool'.
5943 [struct Chown_option] (dereference): Remove member with ambiguous name.
5944 [struct Chown_option] (affect_symlink_referent): New member.
5945 (chown_files): New prototype.
5947 * tests/chgrp/recurse: Update tests accordingly.
5948 * tests/chgrp/posix-H: New tests for the above.
5949 * tests/chgrp/Makefile.am (TESTS): Add posix-H.
5951 * src/ln.c (usage): Clarify that --directory, -d, -F probably won't
5952 work even for superuser. Suggestion from Dan Jacobson.
5954 2003-10-14 Paul Eggert <eggert@twinsun.com>
5956 Fix some number-parsing bugs, e.g., "head -n 100k@" wasn't
5958 * lib/human.c, lib/xstrtoimax.c, lib/xstrtol.c, lib/xstrtol.h,
5959 lib/xstrtoul.c, lib/xstrtoumax.c: Sync with gnulib.
5960 * src/sort.c (parse_field_count): Handle the case where overflow
5961 and invalid suffix char are both reported.
5963 2003-10-14 Jim Meyering <jim@meyering.net>
5965 * src/ls.c (decode_switches) [TIOCGWINSZ]: Comment out the
5966 warning-inducing test, ws.ws_col <= SIZE_MAX, since it was always
5969 2003-10-13 Paul Eggert <eggert@twinsun.com>
5971 Fix to avoid a denial-of-service attack if the display width is
5972 enormous. Also, clean up the code a bit by removing duplicate code.
5974 * src/ls.c (init_column_info): Remove forward decl; no longer needed.
5975 (calculate_columns): New function, that contains code that used
5976 to be common to print_many_per_line and print_horizontal.
5977 (print_many_per_line, print_horizontal): Use it.
5978 (decode_switches): Set max_idx here, not in calculate_columns.
5979 (print_current_files): Don't call init_column_info; calculate_columns
5981 (init_column_info): Don't allocate a lot more space than is needed
5982 to represent the current set of files. Allocate all the new
5983 size_t cells in one call to xnmalloc, rather than a row at a time.
5985 2003-10-13 Jim Meyering <jim@meyering.net>
5987 * src/ls.c (init_column_info): Add another FIXME comment.
5989 2003-10-13 Paul Eggert <eggert@twinsun.com>
5991 Fix address-arithmetic bug in 'ls', reported by Georgi Guninski.
5992 Remove several arbitrary limits on hosts where int cannot represent
5995 * src/ls.c (struct bin_str.len, length_of_file_name_and_frills, indent,
5996 nfiles, files_index, tabsize, line_length, struct column_info.line_len,
5997 struct column_info.col_arr[0], max_idx):
5998 Now size_t, not int.
5999 (get_funky_string): Return bool indicating success, instead of
6000 a negative count to indicate failure. Store number of columns
6001 through new parameter OUTPUT_COUNT; that way, they can never
6002 go negative. Change equals_end from int to bool. All uses
6004 (struct column_info.valid_len): Now bool, not int. All uses changed.
6005 (dired_dump_obstack, get_funky_string, clear_files,
6006 extract_dirs_from_files, print_current_files,
6007 print_many_per_line, print_horizontal, init_column_info,
6008 put_indicator, length_of_file_name_and_frills,
6009 print_with_commas): Use size_t, not int, for local variables
6011 (decode_switches): Decode sizes using xstrtoul, not xstrtol.
6012 Check for TIOCGWINSZ returing negative values (or values greater
6014 (visit_dir, main, parse_ls_color, queue_directory, add_ignore_pattern,
6016 Use xmalloc and xnmalloc, not XMALLOC.
6017 (gobble_file): Use xnrealloc, not XREALLOC.
6018 (print_color_indicator): Remove now-unnecessary cast to size_t.
6020 2003-10-12 Paul Eggert <eggert@twinsun.com>
6022 * tests/du/no-x: Change wording of diagnostic to match latest du.c.
6023 * tests/sort/sort-tests: Remove from CVS; assume that people
6024 brave enough to check coreutils out from CVS can rebuild it.
6026 2003-10-12 Jim Meyering <jim@meyering.net>
6028 New options: --preserve-root and --no-preserve-root.
6029 * src/chmod.c (change_file_mode): Honor new option.
6030 (change_file_mode): Strip trailing slashes on directory
6031 argument passed to change_dir_mode.
6032 (get_root_dev_ino): New function.
6033 (main): Initialize global, root_dev_ino.
6035 * src/copy.c (copy_internal): Don't #ifdef-out simple uses of
6036 S_ISLNK or S_ISSOCK. The S_IS* macros are guaranteed to be defined
6038 * src/chmod.c (change_file_mode): Likewise.
6040 2003-10-08 Jim Meyering <jim@meyering.net>
6042 * src/csplit.c (main): Remove obsolete FIXME.
6044 2003-10-07 Jim Meyering <jim@meyering.net>
6046 * Use automake-1.7.8. Regenerate dependent files.
6048 2003-09-29 Paul Eggert <eggert@twinsun.com>
6052 * doc/coreutils.texi (csplit invocation):
6053 The regexp offset need not have a sign; POSIX requires support
6054 for signless offets.
6056 Be more careful about int widths. For example, remove some
6057 arbitrary limits by replacing 'unsigned' with 'size_t',
6058 'uintmax_t', etc. Use standard bool rather than a homegrown type.
6059 * lib/Makefile.am (libfetish_a_SOURCES): Add xstrtoimax.c.
6060 * src/csplit.c (FALSE, TRUE, boolean): Remove. All uses changed
6061 to <stdbool.h> usage.
6062 (struct control): offset is now intmax_t, not int.
6063 repeat_forever is now bool, not int.
6064 (struct cstring): len is now size_t, not unsigned int.
6065 (struct buffer_record): bytes_alloc, bytes_used, num_lines are now
6066 size_t, not unsigned. start_line, first_available are now
6067 uintmax_t, not unsigned.
6068 (hold_count, control_used): Now size_t, not unsigned.
6069 (last_line_number, current_line, bytes_written):
6070 Now uintmax_t, not unsigned.
6071 (save_to_hold_area, red_input, keep_new_line, record_line_starts,
6072 create_new_buffer, get_new_buffer, load_buffer, find_line,
6073 process_regexp, split_file, new_control_record, extract_regexp,
6074 get_format_width, get_format_prec, max_out):
6075 size args, locals, and returned values are now size_t, not unsigned
6077 (get_first_line_in_buffer, find_line, write_to_file,
6078 handle_line_error, process_line_count, regexp_error, process_regexp,
6080 File line, byte, and repetition counts are now uintmax_t, not unsigned.
6081 (check_for_offset): Don't require a sign before the offset.
6082 Use xstrtoimax to do the real work.
6083 (extract_regexp): Remove harmful cast of size to unsigned.
6084 256 -> 1<<CHAR_BIT, for clarity.
6085 (get_format_flags): Return at most 3, to avoid worries about overflow.
6087 (bytes_to_octal_digits): Remove.
6089 (cleanup): Don't check whether output_stream is NULL, since
6090 close_output_file does that for us.
6092 (new_line_control, create_new_buffer): Use "foo *p = xmalloc
6093 (sizeof *p);" instead of the more long-winded alternatives.
6095 (get_new_buffer): Use O(1) algorithm for resizing a buffer
6096 to a much larger size, instead of an O(N) algorithm.
6098 (process_regexp): Use plain NULL rather than casted 0.
6100 (make_filename): Use %u, not %d, to format unsigned file number.
6102 (new_control_record): Use xrealloc exclusively, since it handles
6105 (extract_regexp): Change misspelled word in diagnostic.
6107 (get_format_width): Even if a minimum field width is specified,
6108 allow room for enough octal digits to represent the value of
6109 the maximum representible integer. This fixes a potential
6110 buffer overrun. Calculate this room at compile-time, not
6111 at run-time; this removes the need for bytes_to_octal_digits.
6112 Check for overflow; this removes a FIXME.
6114 (get_format_prec): Don't allow precision to be signed; it's
6115 not ANSI. Check for overflow. Remove hardcoded "11" as
6116 default precision; this fixes a potential buffer overrun
6117 on hosts with wider size_t.
6119 (get_format_conv_type): Change local variable to be of type
6120 unsigned char, not int; this removes a potential subscript
6121 violation on hosts where char is signed.
6123 (max_out): Replace "for (;*p;)" with more-standard "while (*p)".
6124 Allow "%%" in format. Don't overflow when
6125 counting lots of percents.
6127 (usage): Default sprintf format is %02u, not %d.
6129 2003-10-05 Jim Meyering <jim@meyering.net>
6131 * src/chown-core.c (change_file_owner): Remove set-but-not-used local.
6133 * src/du.c (du_files): Mark diagnostic for translation.
6135 2003-10-04 Jim Meyering <jim@meyering.net>
6137 * src/du.c (du_files): Ignore any failure of fts_close.
6138 Give better diagnostics for failed fts_open.
6140 * src/du.c (MAX_N_DESCRIPTORS): Remove now-unused definition.
6142 Deprecate existing use of -H (aka --si).
6143 * src/du.c (enum) [HUMAN_SI_OPTION]: New member.
6144 [long_options]: Use HUMAN_SI_OPTION, not 'H'.
6145 (main): Warn that the meaning of -H will soon change to be
6148 2003-10-03 Jim Meyering <jim@meyering.net>
6150 * src/du.c: Accept --no-dereference (-P).
6152 2003-10-02 Jim Meyering <jim@meyering.net>
6154 * tests/du/trailing-slash: Adjust for slightly different output.
6156 Rewrite du.c to use fts.
6157 * src/du.c: Include "fts_.h", not ftw.h.
6158 (opt_dereference_arguments, arg_length, suffix_length): Remove globals.
6159 (IS_FTW_DIR_TYPE): Remove definition.
6160 (IS_DIR_TYPE): Define.
6161 (is_symlink_to_dir): Remove now-unnecessary function.
6162 (process_file, du_files): Rewrite to use fts.
6164 * tests/du/inaccessible-cwd: Ensure that even when run from an
6165 inaccessible directory, du can still operate on accessible
6166 directories elsewhere.
6167 * tests/du/Makefile.am (TESTS): Add inaccessible-cwd.
6169 * tests/rm/deep-1: Ensure that du can process a hierarchy
6170 of depth 400 while using no more than 50KB of stack space.
6172 2003-10-01 Akim Demaille <akim@epita.fr>
6174 * announce-gen (print_news_deltas): New function, extracted from main.
6175 (main): Make `news_file' an array.
6176 Use '...=s' => \@var for --news and --url-directory specs.
6177 Before there were a couple of portability problems.
6179 2003-09-28 Jim Meyering <jim@meyering.net>
6181 * Makefile.maint (sc_cast_of_alloca_return_value): New rule.
6182 (syntax-check-rules): Add it.
6184 * src/copy.c: Remove unnecessary cast of alloca, since now it's
6185 guaranteed to be (void *).
6186 * src/cp.c: Likewise.
6187 * src/join.c: Likewise.
6188 * src/ln.c: Likewise.
6189 * src/ls.c: Likewise.
6190 * src/od.c: Likewise.
6191 * src/sys2.h (ASSIGN_STRDUPA): Likewise.
6193 2003-09-27 Jim Meyering <jim@meyering.net>
6195 Don't exhaust virtual memory when processing large inputs.
6196 Fix this by removing csplit's internal free-list management;
6197 instead rely on malloc for that.
6199 * src/csplit.c (free_list): Remove global.
6200 (clear_all_line_control): Remove function.
6201 (get_new_buffer): Always use create_new_buffer to obtain a
6202 new buffer, rather than searching free_list.
6203 (free_buffer): Just call free.
6204 Reported by Nikola Milutinovic.
6206 2003-09-26 Jim Meyering <jim@meyering.net>
6208 * man/rm.x: Also list `chattr' in SEE ALSO section.
6209 Suggestion from Mark Hubbart.
6211 2003-09-25 Jim Meyering <jim@meyering.net>
6213 * configure.ac: Don't invoke AC_AIX or AC_MINIX explicitly, now
6214 that we use gl_USE_SYSTEM_EXTENSIONS, since it AC_REQUIREs them.
6216 * Use autoconf-2.57d. Regenerate dependent files.
6218 2003-09-24 Jim Meyering <jim@meyering.net>
6220 Minor efficiency tweak.
6221 * src/ln.c (PATH_BASENAME_CONCAT): Use memcpy rather than strcpy.
6222 (do_link): Likewise.
6224 2003-09-23 Jim Meyering <jim@meyering.net>
6226 * src/paste.c (paste_serial): Save errno after input error,
6227 to report proper errno value.
6228 Based on a patch from Paul Eggert.
6230 * src/tee.c (tee): Adjust fwrite arguments so that the return
6231 value is the number of bytes written.
6233 2003-09-16 Paul Eggert <eggert@twinsun.com>
6235 Don't assume ferror sets errno. Bug reported by Bruno Haible.
6237 * src/comm.c (compare_files): Save errno after input error,
6238 to report proper errno value.
6239 * src/fold.c (fold_file): Likewise.
6240 * src/od.c (check_and_close, skip, read_char, read_block): Likewise.
6241 * src/unexpand.c (unexpand): Likewise.
6243 * src/csplit.c (close_output_file): Don't report bogus errno value
6244 after ferror discovers an output error. We don't know the proper
6245 errno value, since it might have been caused by any of a whole
6246 bunch of calls, and it might have been trashed in the meantime.
6247 Fixing this problem will require much more extensive changes;
6248 in the meantime just say "write error".
6249 * src/od.c (check_and_close, dump, dump_strings): Likewise.
6250 * src/uniq.c (check_file): Likewise.
6252 * src/join.c (get_line): Report error right away if I/O fails,
6253 so that the proper errno value is used.
6254 * src/tac.c (tac_seekable, tac_file, save_stdin): Likewise.
6255 * src/tee.c (tee): Likewise.
6256 * src/uniq.c (check_file): Likewise.
6258 * src/od.c (skip): If a read fails, don't retry it later, so
6259 that we report the proper errno.
6261 * src/tac.c (tac_mem): Don't return a value; nobody uses it.
6263 * src/tee.c (tee): Once a write failure has occurred, don't bother
6264 writing anything more to that stream.
6266 * src/uniq.c (check_file): Check for ferror (stdout) even if
6269 * src/yes.c (UNROLL): Remove.
6270 (main): Exit immediately when write failure is detected.
6271 Simplify code by assigning to argv when argc == 1.
6273 2003-09-21 Paul Eggert <eggert@twinsun.com>
6275 * src/ptx.c: Switch encoding from Latin-1 to UTF-8.
6276 (WRITTEN_BY): Change "Franc,ois" (actually using
6277 c-with-cedilla in Latin-1) to "F.", so that it's ASCII, as
6280 2003-09-19 Jim Meyering <jim@meyering.net>
6282 `du -D symlink-to-dir' would mistakenly omit the slash in
6283 lines like this: 24 symlink-to-dir/subdir
6284 * src/du.c (process_file): Fix offset calculation.
6285 Reported by Jeff Sheinberg as Debian bug #211591;
6286 http://bugs.debian.org/205251
6288 * tests/du/deref-args: New file/test for the above.
6289 * tests/du/Makefile.am (TESTS): Add deref-args.
6291 * src/du.c (process_file): Remove useless disjunct.
6293 * src/sys2.h (case_GETOPT_VERSION_CHAR): Rename parameter, Authors,
6295 * nearly all src/*.c files (WRITTEN_BY): Rename from AUTHORS.
6296 Begin each WRITTEN_BY string with `Written by ' and end it with `.'.
6297 Mark each WRITTEN_BY string as translatable.
6299 * basename.c, cat.c, chroot.c, cksum.c, comm.c, cp.c, csplit.c, cut.c:
6300 * dd.c, df.c, dirname.c, du.c, echo.c, env.c, expr.c, factor.c, head.c:
6301 * hostid.c, hostname.c, id.c, link.c, ln.c, logname.c, ls.c, md5sum.c:
6302 * mv.c, nice.c, nl.c, nohup.c, paste.c, pathchk.c, pinky.c, pr.c:
6303 * printenv.c, printf.c, pwd.c, rm.c, setuidgid.c, sleep.c, sort.c:
6304 * split.c, stty.c, sum.c, sync.c, tac.c, tail.c, tee.c, test.c:
6305 * touch.c, tsort.c, uniq.c, unlink.c, uptime.c, users.c, wc.c:
6306 * who.c, whoami.c, yes.c: Revert yesterday's changes.
6307 Instead, a subsequent change will embed `Written by ' in
6308 each string along with the author names.
6310 * src/true.c: Revert yesterday's changes.
6311 * src/sys2.h: Likewise.
6313 2003-09-18 Jim Meyering <jim@meyering.net>
6315 * basename.c, cat.c, chroot.c, cksum.c, comm.c, cp.c, csplit.c, cut.c:
6316 * dd.c, df.c, dirname.c, du.c, echo.c, env.c, expr.c, factor.c, head.c:
6317 * hostid.c, hostname.c, id.c, link.c, ln.c, logname.c, ls.c, md5sum.c:
6318 * mv.c, nice.c, nl.c, nohup.c, paste.c, pathchk.c, pinky.c, pr.c:
6319 * printenv.c, printf.c, pwd.c, rm.c, setuidgid.c, sleep.c, sort.c:
6320 * split.c, stty.c, sum.c, sync.c, tac.c, tail.c, tee.c, test.c:
6321 * touch.c, tsort.c, uniq.c, unlink.c, uptime.c, users.c, wc.c:
6322 * who.c, whoami.c, yes.c: Update AUTHORS definition to be a
6323 comma-separated list of strings and/or update the call to
6324 parse_long_options so that `AUTHORS, NULL' are the last parameters.
6325 * src/true.c (main): Append NULL to version_etc argument list.
6326 * src/sys2.h (case_GETOPT_VERSION_CHAR): Likewise.
6328 * src/sort.c (numcompare): Rename local, logb, to log_b to avoid
6329 shadowing the math function name. Also rename loga to log_a.
6331 2003-09-14 Jim Meyering <jim@meyering.net>
6333 * src/factor.c (print_factors): Give a separate diagnostic
6334 for numbers that are too large, but otherwise valid.
6335 Reported by Dániel Varga.
6337 2003-09-10 Jim Meyering <jim@meyering.net>
6339 * Use automake-1.7.7. Regenerate dependent files.
6341 * tests/Makefile.am (all_programs): Use ../src/tr -s ' ' '\n' in place
6342 of `fmt -1'. Using the just-built tr is a little cleaner.
6343 Christian Krackowizer reported that HPUX 10.20 doesn't have fmt.
6344 * man/Makefile.am (programs, check-x-vs-1): Likewise.
6346 2003-09-09 Jim Meyering <jim@meyering.net>
6348 * src/copy.c: Alphabetize includes.
6349 Remove duplicate inclusion of "same.h".
6351 2003-09-08 Jim Meyering <jim@meyering.net>
6353 * Makefile.maint (GZIP_ENV): Remove --rsyncable.
6354 Didn't give enough of a benefit, mainly because it's not yet
6359 * man/Makefile.am (programs): Use ../src, not $(srcdir)/../src.
6360 (check-programs-vs-x): Fail if $(programs) is empty.
6362 * src/remove.c: Add a comment.
6364 2003-09-07 Jim Meyering <jim@meyering.net>
6366 * src/remove.c (D_INO, ENABLE_CYCLE_CHECK) [D_INO_IN_DIRENT]:
6367 Don't define. These symbols are no longer used.
6369 * tests/misc/tty-eof: Write ^D as \cD.
6370 Complete the change of 2003-08-02.
6372 * Makefile.maint (po-check): Use cvsu, so that a temporary source
6373 file in lib/ or src/ doesn't induce an unwarranted failure.
6374 Add a kludge to filter out the sole generated source file that
6375 also has translatable messages: src/false.c.
6377 2003-09-06 Jim Meyering <jim@meyering.net>
6379 * src/tail.c (enum): Add ALLOW_MISSING_OPTION.
6380 (parse_options): Give a diagnostic for (but still accept) the
6381 deprecated --allow-missing option.
6383 2003-09-04 Paul Eggert <eggert@twinsun.com>
6385 Don't ignore -S if input is a pipe. Bug report by Michael McFarland in
6386 <http://mail.gnu.org/archive/html/bug-coreutils/2003-09/msg00008.html>.
6388 * src/sort.c (sort_buffer_size): Omit SIZE_BOUND arg. Compute the
6389 size_bound ourselves. if an input file is a pipe and the user
6390 specified a size, use that size instead of trying to guess the
6391 pipe size. This has the beneficial side effect of avoiding the
6392 overhead of default_sort_size in that case. All callers changed.
6393 (sort): Remove static var size; now done by sort_buffer_size.
6395 2003-09-05 Jim Meyering <jim@meyering.net>
6397 * Use automake-1.7.6b and autoconf-2.57b. Regenerate dependent files.
6399 * tests/tail-2/tail-n0f: Wait .5 seconds for backgrounded process
6400 to start, rather than just .1. Upon failure, print unexpected state.
6402 2003-09-04 Paul Eggert <eggert@twinsun.com>
6404 * src/head.c (elide_tail_lines_pipe): Don't assign 0 or
6405 SAFE_READ_ERROR to tmp->nbytes.
6406 * src/tail.c (pipe_lines, pipe_bytes): Likewise.
6408 * src/head.c (struct linebuffer): Change nbytes and nlines
6409 from unsigned int to size_t. unsigned int is safe (after the
6410 2003-09-03 patch) but size_t is cleaner.
6411 * src/tail.c (struct linebuffer, struct charbuffer): Likewise.
6412 (pipe_bytes): Likewise for local variable 'i', which was 'int'.
6414 Standardize on BUFSIZ as opposed to other macro names and values.
6415 * src/head.c (BUFSIZE): Remove. All uses changed to BUFSIZ.
6416 * src/tail.c (BUFSIZ) [!defined BUFSIZ]: Remove.
6417 stdio.h has always defined it,
6418 and other code already assumes it's defined.
6419 * src/tr.c (BUFSIZ) [!defined BUFSIZ]: Likewise.
6420 (IO_BUF_SIZE): Remove; replace all uses with sizeof io_buf.
6421 (io_buf): IO_BUF_SIZE -> BUFSIZ.
6423 2003-09-04 Paul Eggert <eggert@twinsun.com>
6425 * src/seq.c (step): Default to 1.
6426 (print_numbers): Allow the output to be empty.
6427 (main): The default step is 1, even if LAST < FIRST;
6428 as per documentation.
6429 * tests/seq/basic (onearg-2): Output should be empty.
6431 2003-09-05 Jim Meyering <jim@meyering.net>
6433 * Makefile.cfg (wget_files): Temporarily disable, until master
6434 versions are restored to ftp.gnu.org.
6436 * configure.ac (AM_INIT_AUTOMAKE): Specify automake-1.7.6.
6438 Make seq's --width (-w) option work properly even when the
6439 endpoint requiring the larger width is negative and smaller than
6441 * src/seq.c (get_width_format): Include `-' in the set of bytes
6442 allowed in a `simple' number (no decimal point, no exponent).
6443 Reported by Patrick Mauritz.
6445 2003-09-02 Paul Eggert <eggert@twinsun.com>
6447 * NEWS: sort -t '\0' now uses a NUL tab.
6448 sort option order no longer matters, unless POSIX requires it.
6449 * src/sort.c (usage): Say "blanks" instead of "whitespace",
6450 Similar fixes for many comments.
6451 (TAB_DEFAULT): New constant, so that we can support NUL as
6452 the field separator.
6453 (tab): Now int, not char. Initialize to TAB_DEFAULT.
6454 (specify_sort_size): If multiple sizes are specified, use the largest.
6455 (begfield, limfield): Support NUL tab char.
6456 (set_ordering): Do not let -i override -d.
6457 (main): Report an error if incompatible -o or -t options are given.
6458 Report an error for "-t ''". Allow "-t '\0'" to specify a NUL tab.
6460 2003-09-05 Jim Meyering <jim@meyering.net>
6462 * tests/sort/Test.pm [o2, nul-tab]: New tests for the above.
6464 2003-09-03 Andreas Schwab <schwab@suse.de>
6466 Bug report and patch here:
6467 <http://mail.gnu.org/archive/html/bug-coreutils/2003-09/msg00009.html>
6468 * src/tail.c (pipe_lines): Don't truncate return value from safe_read.
6469 * src/head.c (elide_tail_lines_pipe): Likewise.
6471 2003-09-03 Jim Meyering <jim@meyering.net>
6473 * src/du.c (AUTHORS): Remove Larry McVoy's name, since the relatively
6474 small amount of code from him was first moved to lib/human.c, and was
6475 subsequently rewritten entirely.
6476 * src/df.c (AUTHORS): Likewise.
6478 2003-08-22 Lawrence Teo <lcteo@uncc.edu>
6480 * src/md5sum.c (split_3): Accept the BSD format for generic
6481 message digest modes. Currently works with BSD's MD5 and SHA1
6482 formats since these are the two algorithms presently used in
6483 coreutils. Updated comments to reflect this change.
6484 (bsd_split_3): Updated comments.
6486 * tests/md5sum/basic-1: New test to make sure that
6487 `md5sum --check' doesn't accept the BSD SHA1 format (adapted
6488 from `check-bsd' test in tests/sha1sum/basic-1).
6490 * tests/sha1sum/basic-1 (check-bsd2, check-bsd3): New tests for
6491 --check exit status and BSD SHA1 format (adapted from tests
6492 in tests/md5sum/basic-1).
6494 2003-08-30 Jim Meyering <jim@meyering.net>
6496 * src/ln.c (do_link): Use SAME_INODE rather than open-coding it.
6498 When source and destination arguments refer to the same file, reside
6499 on a partition (e.g. VFAT) on which distinct names may refer to the
6500 same directory entry (often due to variations in case), and when the
6501 link count for the file is 1, mv no longer unlinks the file. Instead,
6502 it gives the expected diagnostic that the source and destination are
6503 the same. WARNING: this is an incomplete fix. If the file happens
6504 to have a link count of 2 or greater, such an erroneous mv command
6505 will still unlink it.
6506 Although that is not possible on vfat or umsdos, it is possible on
6507 other file system types, e.g., ntfs, and hpfs.
6508 * src/copy.c (same_file_ok): Invoke same_name (which might still
6509 return false for names that refer to the same directory entry)
6510 only if the link count is 2 or more.
6511 * tests/mv/vfat: Show how to demonstrate the above problem.
6512 This test is not run.
6513 * tests/mv/Makefile.am (EXTRA_DIST): Add vfat.
6515 2003-08-27 Jim Meyering <jim@meyering.net>
6517 * src/who.c: Change meaning of -l from --lookup to --login, per POSIX.
6518 who's -l option has been eliciting an unconditional warning about
6519 this impending change since sh-utils-2.0.12 (April 2002).
6521 * src/paste.c (paste_parallel): Don't output `EOF' (aka -1) as a `char'.
6522 This would happen for nonempty files not ending with a newline.
6523 Reported by Dan Jacobson.
6524 * tests/misc/paste-no-nl: New file. Test for above-fixed bug.
6525 * tests/misc/Makefile.am (TESTS): Add paste-no-nl.
6527 * src/stat.c (print_it): Avoid buffer overrun that would
6528 occur when the user-specified format string ends with `%'.
6529 Patch by Tommi Kyntola.
6530 * tests/misc/stat-fmt: New file. Test for above-fixed bug.
6531 * tests/misc/Makefile.am (TESTS): Add stat-fmt.
6533 2003-08-26 Jim Meyering <jim@meyering.net>
6535 Apply changes from bison.
6536 * GNUmakefile (SHELL): Define to `sh', if necessary.
6538 * Makefile.maint (WGETFLAGS): Define to `-C off'.
6539 Update all uses of $(WGET).
6541 2003-08-22 Akim Demaille <akim@epita.fr>
6543 * Makefile.cfg (local-checks-to-skip): New.
6544 * Makefile.maint (local-check): Rename as...
6545 (local-checks-available): this.
6548 2003-08-26 Akim Demaille <akim@epita.fr>
6550 * announce-gen (print_changelog_deltas): Neutralize "<#" as
6551 "<\#" to avoid magic from Gnus when posting parts of this script.
6553 2003-08-25 Jim Meyering <jim@meyering.net>
6555 * src/stat.c (main): Warn about use of deprecated `-l' option.
6557 2003-08-22 Jim Meyering <jim@meyering.net>
6559 * src/stat.c (do_stat): For link count at end of line, use %h format,
6560 instead of %-5h. The latter would make stat emit trailing spaces.
6561 Reported by Dan Jacobson.
6563 2003-08-20 Jim Meyering <jim@meyering.net>
6565 * Makefile.am (EXTRA_DIST): Add .x-sc_space_tab .x-sc_sun_os_names
6567 2003-08-19 Jim Meyering <jim@meyering.net>
6569 * src/system.h: Include stdlib.h unconditionally,
6570 as we're now assuming that part of hosted C89.
6572 2003-08-18 Jim Meyering <jim@meyering.net>
6574 * src/sys2.h (textdomain, bindtextdomain) [! ENABLE_NLS]: Define away,
6575 to avoid warnings from gcc.
6577 2003-08-17 Jim Meyering <jim@meyering.net>
6579 Avoid unnecessary and sometimes time-consuming hostname lookups.
6580 * src/who.c (print_user): Use strchr, not strrchr.
6581 * src/pinky.c (print_entry): Likewise.
6582 Patch by Michael Stone.
6583 This fixes a typo I introduced in who-users.c on 1996-02-23.
6585 * Makefile.maint (makefile-check): Add 0-9 to the range of characters
6586 disallowed between `@...@'.
6588 2003-08-16 Paul Eggert <eggert@twinsun.com>
6590 * configure.ac (fu_cv_sys_truncating_statfs): Remove; now
6591 done by gnulib .m4 files.
6592 (jm_DUMMY_1): Require gl_READUTMP, not jm_PREREQ_READUTMP.
6593 * src/sys2.h (strtoull): Remove unused declaration.
6595 2003-08-16 Jim Meyering <jim@meyering.net>
6597 * man/Makefile.am (.x.1): Ensure that generated PROGRAM.1 files
6600 * src/tail.c (tail_lines): Fix a potential (but very hard to exercise)
6601 race condition bug. The bug would be triggered when tailing a file
6602 with file pointer not at beginning of file, and where the file was
6603 truncated to have a length of less than the initial offset at just
6604 the right moment (between the two lseek calls in this function).
6606 An invalid initial value for *read_pos would result in
6607 `tail -n0 -f FILE' and `tail -c0 -f FILE' doing what amounted to a
6608 busy-wait rather than sleeping between iterations. The bug manifests
6609 itself only when tailing regular files that are initially nonempty.
6610 * src/tail.c (tail_bytes): Set *read_pos to new file offset after
6612 (tail_lines): Likewise, after lseek calls.
6613 Reported by Nick Estes. See http://bugs.debian.org/205251 for details.
6614 * tests/tail-2/tail-n0f: New file. Test for above fix.
6615 * tests/tail-2/Makefile.am (TESTS): Add tail-n0f.
6617 2003-08-15 Jim Meyering <jim@meyering.net>
6619 * Makefile.maint (sc_space_tab): Use exclusion list in separate file.
6620 (sc_sun_os_names): Likewise.
6621 * .x-sc_space_tab, .x-sc_sun_os_names: New files.
6623 * man/help2man: Remove some SPACEs before TAB.
6625 2003-08-14 Paul Eggert <eggert@twinsun.com>
6627 * Makefile.maint (LC_ALL): Set to C.
6628 * man/Makefile.am (ASSORT): New var.
6629 (check-x-vs-1, programs): Use it.
6630 * src/Makefile.am (ASSORT, check-README, ../AUTHORS): Likewise.
6631 * tests/Makefile.am (ASSORT, all_programs): Likewise.
6633 2003-08-11 Jim Meyering <jim@meyering.net>
6635 fold -s -wN would infloop for N < 8 with TABs in the input.
6636 E.g., this would not terminate: printf 'a\tb' | fold -w2 -s
6637 * src/fold.c (fold_file): Move contents of `else'-block
6638 out of conditional so it's used also for --spaces (-s).
6639 * tests/misc/fold: Test for the above fix.
6640 * tests/misc/Makefile.am (TESTS): Add fold.
6642 2003-08-10 Jim Meyering <jim@meyering.net>
6644 * src/nice.c [!NICE_PRIORITY]: Include <sys/resource.h> after
6645 system.h so the types from time.h and sys/time.h are available.
6646 It appears that this is necessary for OpenBSD, NetBSD, and
6647 Darwin 6.5 (MacOS 10.2.5). Reported by Nelson Beebe.
6649 2003-08-06 Paul Eggert <eggert@twinsun.com>
6651 * NEWS: Add support for setting file timestamps to microsecond
6652 resolution, on hosts that support this.
6653 * src/copy.c, src/cp.c, src/install.c, src/touch.c: Include utimens.h.
6654 * src/copy.c (copy_internal):
6655 Set file timestamps with utimens, not utime.
6656 * src/cp.c (re_protect): Likewise.
6657 * src/install.c (change_timestamps): Likewise.
6658 * src/touch.c (newtime, touch, main): Likewise.
6660 2003-08-09 Jim Meyering <jim@meyering.net>
6662 * Makefile.maint (sc_sun_os_names): New rule based on a regexp
6664 (syntax-check-rules): Add it.
6666 * src/tail.c (main): Tweak Solaris OS version number in comment.
6667 * src/wc.c (wc): Likewise
6668 * tests/tail-2/fflush: Likewise.
6670 * src/tail.c: Add new undocumented option, --presume-input-pipe.
6671 (pipe_lines): Use memchr to skip lines, rather than an explicit loop.
6673 2003-08-08 Paul Eggert <eggert@twinsun.com>
6675 Use new gnulib 'extensions' module.
6676 * configure.ac: Invoke gl_USE_SYSTEM_EXTENSIONS instead of
6679 2003-08-08 Paul Eggert <eggert@twinsun.com>
6681 * tests/du/basic: Ensure that a/b/F has at least 65 bytes too.
6683 2003-08-09 Jim Meyering <jim@meyering.net>
6685 * tests/misc/split-fail: Reflect that `split -a 0' is now accepted.
6686 For tests of obsolete behavior, don't presume that unsetting
6687 _POSIX2_VERSION is equivalent to _POSIX2_VERSION=199209.
6689 2003-08-07 Paul Eggert <eggert@twinsun.com>
6691 * doc/coreutils.texi (split invocation):
6692 Add -d or --numeric-suffixes option to 'split'.
6693 From a suggestion by Jesse Kornblum.
6694 * src/split.c (suffix_alphabet): New var.
6695 (longopts, usage, next_file_name, main): Support -d.
6696 (next_file_name, main): Allow -a0, as POSIX requires.
6697 (next_file_name): Don't assume ASCII-like encoding;
6698 'a' through 'z' are not contiguous in EBCDIC.
6700 2003-08-05 Paul Eggert <eggert@twinsun.com>
6702 Merge getline from gnulib.
6703 * lib/getline.h, lib/getline.c, m4/getline.m4: Merge from gnulib.
6704 * lib/getndelim2.h, lib/getndelim2.c, m4/getndelim2.m4, m4/ssize_t.m4:
6705 New files, from gnulib.
6706 * lib/getdelim2.c, lib/getdelim2.h: Remove.
6707 * lib/Makefile.am (libfetish_a_SOURCES): Change getdelim2.c and
6708 getdelim2.h to getndelim2.c and getndelim2.h.
6709 * m4/jm-macros.m4 (jm_MACROS): Use gl_GETNDELIM2 rather than
6710 checking for getdelim.
6711 (jm_CHECK_ALL_TYPES): Use gt_TYPE_SSIZE_T for ssize_t rather
6712 than rolling our own.
6713 * src/cut.c: Include getndelim2.h rather than getdelim2.h.
6714 (cut_fields): Invoke getndelim2 rather than getdelim2.
6716 2003-08-04 Jim Meyering <jim@meyering.net>
6718 * src/sort.c (main): Use unsigned int instead of int for `nsigs'
6719 and for the indices to iterate through nsigs.
6721 2003-08-02 Paul Eggert <eggert@twinsun.com>
6723 * src/sort.c: Minor code cleanups, mostly to use more accurate
6724 types and to remove unnecessary casts.
6725 (min, max): Remove. All uses changed to MIN and MAX.
6726 (hard_lc_collate, hard_LC_TIME, struct buffer.eof, struct
6727 keyfield.skipsblanks, struct keyfield.skipeblanks, struct
6728 keyfield.numeric, struct keyfield.general_numeric, struct
6729 keyfield.month, struct keyfield.reverse, reverse, unique,
6730 have_read_stdin): Now bool, not int. All uses changed.
6731 (eolchar): Now char, not int.
6732 (struct keyfield.ignore): Now bool const *, not int *.
6733 (struct keyfield.translate): Now char const *, not char *.
6734 (struct month.name): Likewise.
6735 (blanks, nonprinting, nondictionary): Now bool[], not int[].
6736 (cleanup, inittables, keycompare, check, mergefps, first_same_file,
6737 check, sort, main): Use const * pointers when possible.
6738 (month_cmp): Rewrite to avoid casts.
6739 (inittables): Initialize tables unconditionally, to avoid branches.
6740 (fillbuf): Return bool, not int. All uses changed.
6741 (fillbuf, keycompare, new_key, main):
6742 Use SIZE_MAX rather than (size_t) -1.
6743 (trailing_blanks): Renamed from trim_trailing_blanks.
6744 Return the number of blanks to trim. All uses changed.
6745 (getmonth): Use trailing_blanks rather than open code.
6746 (keycompare): Do not cast char * to unsigned char *; not needed.
6747 CMP_WITH_IGNORE converts args to UCHAR, so no need to convert it
6749 (compare, main): Use | rather than || to avoid jumps.
6750 Replace "diff = NONZERO (alen)" with "diff = 1", since alen must
6752 (check, first_same_file, sort, main):
6753 Use bool instead of int local vars when possible.
6754 (check): Merge the old 'checkfp' and 'check' into a single function,
6755 that returns a boolean (true if the file was ordered).
6757 (main): Use int instead of unsigned for iterating through nsigs.
6758 Rename local var "posix_pedantic" to "posixly_correct".
6760 2003-08-02 Jim Meyering <jim@meyering.net>
6762 * src/nice.c [!NICE_PRIORITY]: Include <time.h> before <sys/resource.h>
6763 to avoid compilation error on Ultrix. Reported by Christian Krackowizer.
6765 * src/cut.c (cut_fields): Don't read again after encountering an
6766 initial EOF. E.g., `cut -f2' would do so.
6767 * tests/misc/tty-eof: Add a test for the above fix.
6769 * src/sort.c (sortlines): Add description and references.
6772 * tests/Makefile.am (TESTS_ENVIRONMENT): Set PATH so that
6773 the tests in help-version will use the just-built binaries.
6774 Reported by Christian Krackowizer.
6776 2003-07-31 Paul Eggert <eggert@twinsun.com>
6778 * NEWS: Add --rfc-2822 option to GNU date.
6779 * doc/coreutils.texi (Time directives, Options for date, Examples
6781 * src/date.c (long_options, usage, main): Likewise.
6782 * doc/getdate.texi (General date syntax): Likewise.
6783 * doc/coreutils.texi (Options for date): Fix a typo in format:
6784 it's now %d not %_d. Add URLs.
6786 2003-08-01 Jim Meyering <jim@meyering.net>
6788 * tests/shred/remove: Ensure that $? is 0 for the final `exit 0'.
6789 Otherwise, with at least the /bin/sh from HPUX 10.20,
6790 the trap code would end up converting that to exit 1 and thus an
6791 unexpected test failure. Reported by Christian Krackowizer.
6793 2003-07-31 Paul Eggert <eggert@twinsun.com>
6795 * src/ptx.c: Do not include bumpalloc.h.
6796 (WORD_TABLE): New member alloc.
6797 (ALLOC_NEW_WORD): Remove.
6798 (occurs_alloc): New var.
6799 (digest_word_file, find_occurs_in_text): Check for arithmetic
6800 overflow when computing table size. Use xrealloc rather than
6801 bumpalloc primitives.
6803 2003-07-29 Jim Meyering <jim@meyering.net>
6807 * README: When running tests as root, suggest using
6808 sudo with NON_ROOT_USERNAME=$USER.
6810 * tests/Makefile.am (all_programs): Makefile is in ../src, not
6813 2003-07-28 Jim Meyering <jim@meyering.net>
6815 * Makefile.maint (GZIP_ENV): Try Debian/gzip's new --rsyncable option.
6817 2003-07-28 Paul Eggert <eggert@twinsun.com>
6819 * lib/stdbool.hin (_Bool): Make it signed char, instead of
6820 an enum type, so that it's guaranteed to promote to int.
6821 * src/sort.c (sortlines_temp): Undo previous change.
6823 2003-07-28 Jim Meyering <jim@meyering.net>
6825 * src/sort.c (sortlines_temp): Declare local `swap' to be `int', not
6826 `bool'. Otherwise, at least one buggy compiler (alpha gcc-2.95.4)
6827 would cause lines[-1 - swap] (with swap = false) to evaluate to
6830 2003-07-27 Jim Meyering <jim@meyering.net>
6832 * tests/priv-check (my_uid): Use `!', not `^' in case pattern `[!0-9]',
6833 since /bin/sh of at least NetBSD 1.6 and OpenBSD 3.2 don't accept `^'.
6835 * src/remove.c (prompt) [! recursive]: Don't prompt about unwritable
6836 directories, as required by POSIX. Reported by Karl Berry.
6837 * tests/rm/dir-no-w: New file. Test for the above fix.
6838 * tests/rm/Makefile.am (TESTS): Add dir-no-w.
6840 * tests/mk-script: Emit `$xx', not its expansion.
6842 2003-07-27 Paul Eggert <eggert@twinsun.com>
6844 This change was inspired by a similar proposal by Stepan Kasal.
6845 * src/sort.c (mergelines, sortlines_temp): New functions.
6846 (sortlines): Use them, to reduce the number of times that
6847 we need to copy 'struct line' values. This improved CPU
6848 performance by about 30% on one 18 MB test.
6849 (sort): Don't invoke sortlines unless we have 2 or more lines.
6851 2003-07-26 Stepan Kasal <kasal@ucw.cz>
6853 * src/sort.c (sort): Don't require two `struct line's per text line,
6854 the new sort algorithm requires just 1.5.
6856 2003-07-27 Jim Meyering <jim@meyering.net>
6858 * src/pathchk.c (validate_path): Use %lu, not %ld.
6860 * src/cut.c (is_printable_field): Simplify bit arithmetic.
6862 * src/ls.c (sort_files): Put `volatile' in the right place.
6865 2003-07-26 Jim Meyering <jim@meyering.net>
6867 Use only one bit per field/offset in array, not one `int'.
6868 * src/cut.c (printable_field): Change type to `unsigned char'.
6869 (mark_printable_field, is_printable_field): New functions.
6870 Use them in place of all direct accesses of `printable_field'.
6872 * src/expand.c (parse_tabstops): Detect overflow properly.
6873 * src/cut.c (set_fields): Likewise.
6875 * src/rm.c: Include "dirname.h".
6876 (usage): Use base_name (program_name) in body of --help output.
6878 * man/Makefile.am (.x.1): ...back out the kludge of 2003-07-22.
6879 Idea from Brendan O'Dea, who suggested using
6880 `program_name = basename (argv[0]);' everywhere --
6881 can't do that, but using base_name works just fine here.
6883 * src/Makefile.am (AM_INSTALLCHECK_STD_OPTIONS_EXEMPT): Exempt test.
6885 2003-07-24 Paul Eggert <eggert@twinsun.com>
6887 Fix some POSIX-compliance problems with 'test'. This makes
6888 'test' more compatible with Bash.
6890 * NEWS, doc/coreutils.texi: Document the following.
6891 * src/test.c: Include exitfail.h.
6892 (TEST_FAILURE): New constant, used for exit status if 'test' fails.
6893 (test-syntax_error): Use it.
6894 (binary_operator): Now takes bool arg specifying whether left operand
6895 is -l ARG, so that caller determines this rather than us.
6897 (term): Use posixtest to evaluate parenthesized subexpressions.
6898 (unary_operator, one_argument): Remove support for -t without operand.
6899 (one_argument): Take argument from argv[pos].
6900 (one_argument, two_arguments, three_arguments): Advance pos.
6901 All callers changed.
6902 (three_arguments): Look for binary ops before "!". Then look
6903 for parenthesized one_argument expressions, instead of trusting
6904 expr () to do the right thing.
6905 (posixtest): Now takes number of args. All callers changed.
6906 Treat "( A B )" like "A B".
6907 (main): Set exit_failure to TEST_FAILURE. Don't depend on
6908 POSIXLY_CORRECT, as we now conform to POSIX by default.
6909 (main) [!LBRACKET]: Do not recognize "--help" or "--verbose" unless.
6910 * tests/test/Test.pm (test_vector): Add several tests to check
6911 the above. Syntax errors now exit with status 2, not 1.
6912 * man/Makefile.am (mapped_name): Use `../src/[' binary to create test.1.
6914 2003-07-26 Jim Meyering <jim@meyering.net>
6916 * tests/help-version: Adjust for above change in test behavior:
6917 `[' exits with 2, not 1, and test doesn't accept --help or --version.
6919 * Makefile.maint (ME): Don't use trick suggested in Make manual.
6920 It doesn't work for make-3.79.1. Reported by Christian Krackowizer.
6922 * Makefile.maint (sc_system_h_headers): Another syntax check.
6923 (syntax-check-rules): Add it to the list.
6925 * src/pathchk.c (validate_path): Cast strlen value to `unsigned long'
6926 so it matches `%ld' format even on 32-bit systems.
6928 * src/fmt.c (flush_paragraph): Cast field width to `int' to
6929 avoid warning on 64-bit systems.
6931 * src/ls.c (sort_files): Make `func' volatile, so it can't be
6932 clobbered by a `longjmp' into this function.
6934 2003-07-25 Jim Meyering <jim@meyering.net>
6936 * src/pathchk.c (validate_path): Use %ld format (not %d) for size_t
6939 * tests/misc/split-fail: Disable the --line-bytes=$_4gb test,
6940 because it'd evoke spurious failure on 64-bit systems.
6942 2003-07-24 Jim Meyering <jim@meyering.net>
6944 * src/dd.c (usage): Document the fact that SIGUSR1 makes dd
6945 output its current record counts. Reported by Jurriaan.
6947 * tests/wc/Test.pm (test_vector): Disable the `PIPE' tests when running
6948 `wc' with no options. This goes along with the change of 2003-07-20.
6950 2003-07-23 Jim Meyering <jim@meyering.net>
6952 Don't include headers already included by system.h:
6953 * src/tr.c: Don't include errno.h.
6954 * src/true.c: Don't include version-etc.h.
6955 * src/test.c: Don't include limits.h or error.h.
6956 * src/stat.c: Don't include unistd.h or time.h.
6957 * src/readlink.c: Don't include stdlib.h, unistd.h, or limits.h.
6958 * src/pr.c: Don't include time.h.
6959 * src/pathchk.c: Don't include errno.h.
6960 * src/nice.c: Don't include sys/time.h.
6961 * src/ls.c: Don't include stdlib.h.
6963 * basename.c, cat.c, chroot.c, cksum.c, comm.c, csplit.c, cut.c, date.c:
6964 * dd.c, dirname.c, echo.c, env.c, expand.c, expr.c, factor.c, fmt.c:
6965 * fold.c, head.c, hostid.c, hostname.c, id.c, join.c, kill.c, logname.c:
6966 * md5sum.c, nice.c, nl.c, nohup.c, od.c, paste.c, pathchk.c, pinky.c:
6967 * pr.c, printenv.c, printf.c, ptx.c, pwd.c, seq.c, setuidgid.c, shred.c:
6968 * sleep.c, sort.c, split.c, stat.c, stty.c, su.c, sum.c, tac.c, tail.c:
6969 * tee.c, test.c, tr.c, true.c, tsort.c, tty.c, uname.c, unexpand.c:
6970 * uniq.c, uptime.c, users.c, wc.c, who.c, whoami.c, yes.c:
6971 Don't include closeout.h.
6973 * tests/rm/fail-2eperm: Add a check for whether $NON_ROOT_USERNAME
6974 can access the required version of rm.
6975 * tests/rm/Makefile.am (TESTS_ENVIRONMENT): Define PACKAGE_VERSION.
6977 * tests/cut/Test.pm (out-delim3a): New test.
6979 * man/help2man: Update to version 1.33.
6981 * src/expand.c (parse_tabstops): Detect overflow in tabstop sizes.
6983 * src/dircolors.c: Include xstrndup.h.
6984 (xstrndup): Remove function, now that it's been factored out into
6987 2003-07-22 Paul Eggert <eggert@twinsun.com>
6989 * src/wc.c (wc): Fix typo in computation of file from file_x,
6990 which caused the former to be used uninitialized if file_x was
6993 2003-07-22 Jim Meyering <jim@meyering.net>
6995 * src/cut.c (set_fields): Use xcalloc in place of xmalloc+memset.
6997 * man/Makefile.am (.x.1): Substitute 's,$t/$*,$*,' on output of
6998 help2man, to avoid having `rm.td/rm' appear in rm.1. Reported by
6999 Thomas Luzat. See http://bugs.debian.org/202413 for details.
7001 * src/cut.c (main) [lint]: Initialize spec_list_string to avoid warning.
7003 * src/hostid.c: Don't include <unistd.h>. system.h already does that.
7005 * src/cut.c (set_fields): Mark all selected indices before trying to
7006 determine range endpoints.
7007 * tests/cut/Test.pm: New test for the above fix.
7009 Begin to address this comment: What if someone wants to
7010 extract the 1,000,000-th field of some huge input file?
7011 The first step is to rearrange things so that the values
7012 in the printable_field array are all 0/1 rather than 0/1/2.
7013 * src/cut.c (RANGE_START_SENTINEL): Remove.
7014 Store range-start indices in a hash table, rather than
7015 overloading the `printable_field' array.
7016 (range_start_ht): New global.
7017 (hash_int, hash_compare_ints, is_range_start_index): New functions.
7018 (print_kth): Use is_range_start_index; don't test printable_field.
7019 (set_fields): Detect overflow.
7020 (set_fields): Insert each range-start index into range_start_ht.
7021 (main): Call set_fields only once, and only after
7022 output_delimiter_specified and (if required) range_start_ht have
7025 2003-07-20 Paul Eggert <eggert@twinsun.com>
7027 * src/wc.c (get_input_fstatus): Fix typo: `stat' was being
7028 invoked with a null pointer when there were no file arguments.
7030 2003-07-20 Jim Meyering <jim@meyering.net>
7032 * Makefile.maint (sc_changelog): Add another nit-picky check.
7034 * src/wc.c (write_counts): Add a comment.
7035 (wc): Rename `file' parameter.
7036 Set new local, `file', to be the file name, or (when it's NULL)
7037 _("standard output") so that all uses of `file' use the proper value.
7038 Use STREQ, not strcmp.
7040 2003-07-20 Paul Eggert <eggert@twinsun.com>
7042 wc count field widths now are heuristically adjusted depending
7043 on the input size, if known. If only one count is printed, it
7044 is guaranteed to be printed without leading spaces.
7046 Previously, wc did not align the count fields if
7047 POSIXLY_CORRECT was set, but POSIX did not actually require
7048 this undesirable behavior, so it has been removed.
7050 * NEWS: Document this.
7051 * doc/coreutils.texi (wc invocation): Likewise.
7053 * src/wc.c (number_width): New var.
7054 (posixly_correct): Remove.
7055 (struct fstatus): New struct.
7056 (write_counts): Output fields of width number_width.
7057 Do not worry about POSIXLY_CORRECT.
7058 Use null file, not empty-string file, to denote stdin,
7059 since "" is a valid file name on some hosts.
7060 (wc, wc_file): New arg fstatus. Use it to avoid invoking fstat
7062 (wc): Avoid problems if end_pos - current_pos overflows.
7063 Do not print odd message if stdin has a read error.
7064 (get_input_fstatus, compute_number_width): New functions.
7065 (main): Use them to implement the new behavior.
7066 Ignore POSIXLY_CORRECT.
7068 * tests/wc/Test.pm: Adjust to the new output widths.
7070 2003-07-19 Jim Meyering <jim@meyering.net>
7072 * tests/rm/fail-eperm: Don't create temporary directory --
7075 * tests/shred/remove: Don't open-code test for UID != 0.
7076 Use priv-check's require-non-root instead.
7077 Update to use newer framework.
7079 * tests/help-version (expected_failure_status_expr): Record that
7080 expr exits with status of 3 for e.g., a write error.
7082 * tests/priv-check: Use `id -u' to see if we're running as root,
7083 rather than trying go write to an write-protected file.
7084 When running as root, ensure $NON_ROOT_USERNAME is valid.
7085 When running as root with `require-non-root', ensure that `.'
7086 is writable by $NON_ROOT_USERNAME, then reinvoke $0 set-user-ID
7087 to $NON_ROOT_USERNAME. If `.' is not writable, then skip the test.
7089 * src/printenv.c: Include "exitfail.h".
7090 (main): Set exit_failure rather than calling close_stdout_set_status.
7091 * src/date.c: Likewise.
7092 * src/sort.c: Likewise.
7093 * src/tty.c: Likewise.
7095 2003-07-18 Jim Meyering <jim@meyering.net>
7097 * tests/touch/not-owner: Update to use newer framework.
7099 * tests/rm/fail-eperm: Use $srcdir/../priv-check, create a temporary
7100 directory, and remove Perl-coded `you may not run as root' test.
7101 * tests/cp/fail-perm: Use $srcdir/../priv-check, rather than
7102 hard-coding something not quite equivalent.
7103 Paul Jarc reported the inconsistent diagnostics.
7105 * src/sort.c (main): Use close_stdout via atexit.
7106 Now `sort --version' and `sort --help' fail, as they should
7107 when their output is redirected to /dev/full.
7109 * src/su.c (usage): Don't call close_stdout here.
7110 (main): Use close_stdout via atexit.
7111 Now `su --version > /dev/full' fails, as it should.
7112 Somehow, the change of 2000-05-07 that purports to fix this
7115 * tests/help-version (--help/--version vs. /dev/full): Special-case
7116 `[' to protect it from expected_failure_status-`eval'.
7118 * src/uniq.c (writeline): Use a SPACE, not a TAB between the
7119 count and the corresponding line, as required by POSIX.
7120 Reported by Clement Wang.
7121 * tests/uniq/Test.pm (101, 102): Update tests of -c accordingly.
7123 * tests/expr/basic: Add tests for when exit status is 2.
7125 * src/nohup.c (NOHUP_FOUND_BUT_CANNOT_INVOKE, NOHUP_FAILURE):
7126 Use an anonymous `enum', rather than #define.
7128 2003-07-17 Paul Eggert <eggert@twinsun.com>
7130 * src/expr.c: Include "exitfail.h", "quotearg.h".
7131 (EXPR_INVALID, EXPR_ERROR): New constants.
7132 (nomoreargs, null, toarith, nextarg): Return bool, not int.
7133 (syntax_error): New function, exiting with status 2. Use it
7134 insteading of printing "syntax error" ourselves.
7135 (main): Initialize exit_failure to EXPR_ERROR.
7136 Exit with EXPR_INVALID on syntax error (too few arguments).
7137 (nextarg): Use strcmp, not strcoll; strcoll might return
7138 an undesirable 0, or might fail.
7139 (docolon, eval4, eval3): Exit with status 3 on invalid argument type
7140 or other such error.
7141 (eval2): Report an error if strcoll fails in a string comparison.
7142 * src/sort.c: Include "exitfail.h".
7143 (main): Set exit_failure, not xalloc_exit_failure and
7144 xmemcoll_exit_failure.
7145 * tests/expr/basic: Invalid value exits with status 3, not 2.
7147 2003-07-16 Jim Meyering <jim@meyering.net>
7149 * configure.ac (AC_INIT): Use 5.0.90 as the version, rather than 5.0.2,
7150 per GNU maintainer guidelines. The next non-beta release will be 5.1.
7152 This script would have caught at least two recent bugs:
7153 those in [ and kill.
7154 * tests/help-version: Revive this script.
7155 It wasn't doing anything useful, since $all_programs wasn't being
7156 defined by the invoking Makefile.am.
7157 Reflect that nohup is no longer a script, so don't exclude it.
7158 Add framework to handle the programs added since it was last run:
7159 kill, stat, unlink, [, link, readlink.
7160 Fix path-related problems deriving from the move of this script
7161 from src/ to its present location.
7162 * tests/Makefile.am (all_programs): Define.
7163 (TESTS_ENVIRONMENT): Use it.
7165 * src/kill.c (main): Fix bug introduced on 2003-05-10 (for 5.0.1)
7166 whereby kill would always attempt to operate on argv[0] and fail.
7168 * src/test.c (integer_expected_error): Improve diagnostic -- now,
7169 it also matches the one from bash's builtin test.
7170 (binary_operator): Add \n at end of diagnostic.
7172 * tests/rm/fail-2eperm: Remove setuidgid-related code. Move it to ...
7173 * tests/priv-check: Move setuidgid-related and
7174 NON_ROOT_USERNAME-checking code to this file.
7176 * README: Update section on testing as `root'.
7177 Suggestion from Paul Jarc.
7179 * src/test.c (AUTHORS): Replace 3-letter usernames with the actual
7180 names of authors that I just found in bash's builtins/test.def.
7182 Running `[' with no arguments would evoke a segfault.
7183 * src/test.c (main) [LBRACKET]: Move initialization of argv to
7184 precede potential use via test_syntax_error.
7186 * src/Makefile.am (AM_CPPFLAGS): Rename from `INCLUDES', to avoid
7187 warning from automake -Wall.
7189 2003-07-15 Jim Meyering <jim@meyering.net>
7193 * Makefile.maint (%.asc): Remove target first, so gpg doesn't
7196 * announce-gen (print_changelog_deltas): Relax tests for matching
7197 version-number line in NEWS.
7198 Change the .sig suffix to .asc here, too.
7200 2003-07-14 Jim Meyering <jim@meyering.net>
7202 * Makefile.maint (%.asc): Renamed from %.sig.
7203 Generate and use ascii-armored signatures.
7204 Use gpg's -o option.
7206 2003-07-13 Jim Meyering <jim@meyering.net>
7208 * src/nohup.c (NOHUP_FAILURE, NOHUP_FOUND_BUT_CANNOT_INVOKE): Define.
7211 * Makefile.maint (syntax-check): Move each individual check into
7213 (syntax-check-rules): This is the list of syntax-check targets.
7214 (sc_unmarked_diagnostics, sc_cast_of_argument_to_free):
7215 (sc_cast_of_x_alloc_return_value, sc_space_tab):
7216 (sc_error_exit_success, sc_xalloc_h_in_src): New targets.
7218 2003-07-12 Jim Meyering <jim@meyering.net>
7220 * configure.ac: Remove uses of OPTIONAL_BIN_ZCRIPTS and last
7221 traces of the nohup script.
7223 * src/Makefile.am (bin_SCRIPTS): Remove use of just-removed
7224 $(OPTIONAL_BIN_ZCRIPTS).
7226 * src/Makefile.am (localedir.h): Put the `2>&1' after the redirect
7227 target, not before the `>'.
7229 * src/remove.c (remove_dir): Give a diagnostic upon failed save_cwd,
7230 now that that function no longer calls `error'.
7232 * src/df.c (find_mount_point): Emit a diagnostic for each
7233 failed syscall, rather than relying on caller to do that.
7234 The caller couldn't do a good job, anyhow -- too many different
7235 ways to fail (each with a different referent).
7236 Give a diagnostic upon failed save_cwd, now that that function
7237 no longer calls `error'.
7238 (show_point): Don't diagnose find_mount_point's errors, now that
7239 it handles them itself.
7241 * src/df.c (find_mount_point): Don't let free clobber errno upon
7244 * src/sys2.h: Remove alloca-related block.
7245 * src/system.h: Include <alloca.h> here, instead.
7247 It appears that the `#pragma alloca' included via "system.h" is
7248 adequate, since join.c uses alloca, yet lacked an in-file #pragma.
7249 * src/copy.c, src/cp.c, src/df.c, src/install.c, src/ln.c:
7250 * src/ls.c, src/mv.c, src/remove.c: Remove `#pragma alloca'.
7252 * src/chown-core.c (change_file_owner): Do not restore any special
7253 permission bits (e.g., set-user-ID, set-group-ID) that are reset
7254 by chown(2) on some systems. Suggestion and insistence :-) from
7257 * tests/input-tty: Also check `test -t 1'.
7258 This is necessary on linux-2.4.21. Otherwise, the stty/basic-1
7259 test would block when run in the background.
7261 2003-07-11 Jim Meyering <jim@meyering.net>
7263 * tests/sample-test: Also fail if cat-to-create-expected-output
7264 fails. Otherwise, if both `exp' and `out' were to end up empty
7265 because of e.g., a full disk, they would mistakenly compare equal.
7267 * src/nohup.c: New file. Rewrite of nohup.sh in C.
7268 This solves a portability problem: on at least Solaris systems,
7269 when nohup.sh used the vendor /bin/sh, it would exit with status
7270 of `1' rather than the required 126 or 127 upon failure to exec
7271 the specified program.
7273 * src/Makefile.am (EXTRA_SCRIPTS): Remove definition.
7274 (bin_PROGRAMS): Add nohup.
7275 (EXTRA_DIST): Remove nohup.sh.
7276 (all_programs): Remove use of $(EXTRA_SCRIPTS).
7277 * src/nohup.sh: Remove file.
7278 * man/Makefile.am (nohup.1): Depend on nohup.c, rather than nohup.sh.
7280 * tests/misc/nohup: Tests for the above.
7281 * tests/misc/Makefile.am (TESTS): Add nohup.
7283 * src/head.c (diagnose_copy_fd_failure): New function, renamed from
7284 the macro, COPY_FD_DIAGNOSE.
7285 (diagnose_copy_fd_failure): Enclose diagnostic in _(...).
7286 (head_file): Likewise.
7288 * src/date.c: Include "quote.h".
7289 (batch_convert): Use the quote function rather than using literal `...'
7292 * src/setuidgid.c (main): Enclose diagnostic in _(...).
7293 * src/fmt.c (main): Likewise.
7294 * src/mknod.c (main): Likewise.
7295 * src/tac.c (tac_seekable): Likewise.
7296 * src/yes.c (main): Likewise.
7297 * src/od.c (main): Likewise.
7298 * src/install.c (change_attributes): Likewise.
7300 2003-07-10 Jim Meyering <jim@meyering.net>
7302 * src/head.c (usage): Use 1024*1024 in place of 1048576.
7303 * src/tail.c (usage): Likewise.
7305 * tests/rm/fail-2eperm: Now that we have setuidgid, use it in
7306 place of the kludge in this test. Suggestion from Paul Jarc.
7308 * src/Makefile.am (noinst_PROGRAMS): Define to setuidgid.
7309 * src/setuidgid.c: New program, solely for testing (not installed).
7311 * src/chown-core.c (change_file_owner): Don't leak file descriptors
7312 when dereferencing symlinks.
7314 2003-07-09 Jim Meyering <jim@meyering.net>
7316 * tests/du/slash: New file/test for today's lib/ftw.c fix.
7317 * tests/du/Makefile.am (TESTS): Add slash
7319 * src/tail.c (xlseek): Avoid warning about ``return without value
7320 from function returning non-void''.
7322 2003-07-08 Jim Meyering <jim@meyering.net>
7324 * man/help2man: Update to version 1.29.
7326 * man/help2man: Add END handler to close STDOUT and check for errors.
7328 2003-06-30 Paul Eggert <eggert@twinsun.com>
7330 Add support for a "[" that conforms to the GNU coding standards,
7331 i.e., that does not depend on its name.
7332 * src/lbracket.c: New file.
7334 * man/Makefile.am (programs): Ignore "[", since it doesn't have
7335 a separate man page.
7336 * src/Makefile.am (bin_PROGRAMS): Add "[".
7337 (__SOURCES): New var.
7338 * src/test.c (LBRACKET): Define to 0 if not defined.
7339 (main): Use LBRACKET rather than argv[0].
7341 * src/test.c (one_argument): Do not check for -t if POSIXLY_CORRECT.
7342 Reported by Paul Jarc and Dan Jacobson.
7344 * src/test.c (main): Do not recognize --help or --version if
7345 POSIXLY_CORRECT, when invoked as "test". Handle "[ ]" correctly.
7346 Do not bother testing that margv[margc] is non-null.
7348 2003-07-04 Jim Meyering <jim@meyering.net>
7350 * src/who.c (print_line): Rewrite to use asprintf, in order to be
7351 able to avoid emitting trailing spaces. Reported by Dan Jacobson.
7353 * tests/misc/head-elide-tail: Add tests of head's new --lines=-N
7354 option, and perform the +1600 invocations of head IFF the envvar
7355 RUN_EXPENSIVE_TESTS is set.
7357 2003-07-03 Jim Meyering <jim@meyering.net>
7359 * src/cp.c (do_copy): Give a better diagnostic when failing due
7360 to nonexistent destination directory. Reported by Dmitry Rutsky.
7361 See http://bugs.debian.org/199730 for details.
7363 2003-06-27 Jim Meyering <jim@meyering.net>
7365 split's --verbose option did nothing [broken in 4.5.10 and 5.0]
7366 * src/split.c (longopts): Use `1', not `0' as the value for
7367 for &verbose. Reported by Keith Thompson.
7369 Test for the above fix.
7370 * tests/misc/split-a: Also use --verbose and compare stderr
7371 output with what we'd expect.
7373 2003-06-20 Jim Meyering <jim@meyering.net>
7375 * src/copy.c (copy_internal) [HAVE_STRUCT_STAT_ST_AUTHOR]:
7376 Use `error_t' (rather than int) as type for local `err'.
7377 From Alfred M. Szmidt.
7379 2003-06-19 Marcus Brinkmann <marcus@gnu.org>
7381 * src/copy.c (copy_internal) [HAVE_STRUCT_STAT_ST_AUTHOR]:
7382 Fix author preservation code.
7384 2003-06-19 Jim Meyering <jim@meyering.net>
7386 * src/ln.c (ENABLE_HARD_LINK_TO_SYMLINK_WARNING): Define to 0.
7387 (do_link): Don't warn about hard link to symlink.
7389 2003-06-18 Jim Meyering <jim@meyering.net>
7391 * src/cut.c: Include "getdelim2.h", not "getstr.h".
7392 Reflect renaming: getstr -> getdelim2.
7394 * src/comm.c, src/join.c, src/nl.c, src/uniq.c: Reflect renaming:
7395 readline -> readlinebuffer.
7397 2003-06-09 John David Anglin <dave.anglin@nrc-cnrc.gc.ca>
7399 * src/readlink.c: Include <sys/types.h> before system.h (because
7400 the latter includes <sys/stat.h>). Required on Ultrix 4.3.
7402 2003-06-17 Jim Meyering <jim@meyering.net>
7404 * src/system.h (initialize_main): Define.
7405 Use it in every `main'. Applied via this:
7406 p='initialize_main (&argc, &argv);'
7407 perl -ni -e '/program_name.=.argv.0/ and print " '"$p"'\n"; print' \
7408 $(grep -l program_name.=.argv.0 *.c)
7409 test.c uses margc/margv, so I made the change manually for that file.
7410 Based on a patch from Bernard Giroud.
7412 2003-06-09 John David Anglin <dave.anglin@nrc-cnrc.gc.ca>
7414 Fix for build failure on Ultrix 4.3.
7415 * src/stat.c: Include sys/statvfs.h in preference to sys/vfs.h.
7416 Include sys/param.h and sys/mount.h on ultrix.
7418 2003-06-16 Jim Meyering <jim@meyering.net>
7420 * src/touch.c (O_NDELAY, O_NONBLOCK, O_NOCTTY, EISDIR): Remove
7422 * src/system.h (O_NDELAY, O_NONBLOCK, O_NOCTTY, EISDIR): Define
7423 them here instead, but with one change: define EISDIR to -1, not 0.
7425 * src/cat.c (cat): Remove `#ifndef ENOSYS', now that it's
7426 guaranteed to be defined.
7427 * src/system.h (ENOSYS, ENOTSUP): Define to -1 if not defined.
7429 * README: Mention the CVS repository.
7430 Encourage addition of test cases.
7432 2003-06-12 Jim Meyering <jim@meyering.net>
7434 * src/touch.c (touch): Call close only if necessary.
7437 * src/wc.c (usage): Correct wording: wc prints counts in the order
7438 `newline, word, byte'. Reported by Keith M. Briggs.
7439 * man/wc.x: Fix it here, too. And change `lines' to `newlines'.
7441 2003-06-10 Jim Meyering <jim@meyering.net>
7443 * tests/date/Test.pm: Add a test for the new format, e.g., May-23-2003.
7445 2003-06-07 Jim Meyering <jim@meyering.net>
7447 * Makefile.maint (syntax-check): Add commented-out (over-aggressive)
7450 2003-06-06 Jim Meyering <jim@meyering.net>
7452 * src/extract-magic (main): Avoid newer 3-arg form of open,
7453 so this script works also with e.g., perl5.005_03.
7454 Patch by John David Anglin.
7456 2003-06-04 Paul Eggert <eggert@twinsun.com>
7458 * src/system.h: Include <stdbool.h> unconditionally.
7460 2003-06-04 Jim Meyering <jim@meyering.net>
7462 * man/Makefile.am (check-programs-vs-x): Rename target
7463 from check-programs-vs-1. Adjust rule to check for the
7464 primary (.x) file, not the generated one (.1).
7466 2003-06-03 Tim Mooney <mooney@dogbert.cc.ndsu.NoDak.edu>
7468 * man/kill.x: New file.
7469 * man/Makefile.am (dist_man_MANS): Add kill.1.
7472 2003-06-04 Jim Meyering <jim@meyering.net>
7474 Ensure that the .x file for a new program is never forgotten again.
7475 * man/Makefile.am (programs): Define.
7476 (check-programs-vs-1): New phony target.
7477 (check-local): Depend on it.
7479 2003-06-03 Jim Meyering <jim@meyering.net>
7481 Avoid unnecessary copying of environment.
7482 * src/env.c (main): Rather than clearing the environment and --
7483 unless told to ignore environment -- copying all settings from
7484 the saved, original environment, clear the environment only when
7485 that is requested. Suggested by Jens Elkner.
7487 2003-06-02 Jim Meyering <jim@meyering.net>
7489 * src/system.h: Always include <string.h>, since we assume C89.
7490 Include <limits.h> without checking for HAVE_LIMITS_H.
7492 * src/test.c [!TEST_STANDALONE]: Remove #if-0'd block.
7493 (STREQ, S_IXUGO): Remove redundant (in system.h) definitions.
7495 2003-06-01 Jim Meyering <jim@meyering.net>
7497 Avoid a race condition in `tail -f' described by Ken Raeburn in
7498 http://mail.gnu.org/archive/html/bug-textutils/2003-05/msg00007.html
7499 * src/tail.c (file_lines): Add new parameter, *read_pos, and set it.
7500 (pipe_lines, pipe_bytes, start_bytes, start_lines): Likewise.
7501 (tail_bytes, tail_lines, tail): Likewise.
7502 (tail_file): Use the new `read_pos' value as the size,
7503 rather than stats.st_size from the fstat call.
7505 2003-05-28 Jim Meyering <jim@meyering.net>
7507 * src/extract-magic: Allow expansion of `$file' in the here-
7508 document corresponding to the comment at the top of fs.h.
7510 2003-05-26 Jim Meyering <jim@meyering.net>
7512 * src/stat.c: Fix portability problem on FreeBSD5.0: don't include
7513 <sys/statvfs.h> on systems without HAVE_STRUCT_STATVFS_F_BASETYPE.
7514 Use #if/#elif/... cascade so we get only one set of include files.
7515 Reported by Nelson Beebe.
7517 2003-05-24 Jim Meyering <jim@meyering.net>
7519 * src/md5sum.c (split_3): Accept the BSD format only when in MD5 mode.
7520 * tests/sha1sum/basic-1: Make sure `sha1sum --check' doesn't
7521 accept the BSD format.
7523 2003-03-28 Joe Orton <jorton@redhat.com>
7525 * src/md5sum.c (bsd_split_3): New function.
7526 (split_3): Detect checksums from BSD 'md5' command and handle them
7529 * tests/md5sum/basic-1: New tests for --check exit status, and for
7530 BSD-style checksum files.
7532 2003-05-21 Jim Meyering <jim@meyering.net>
7534 * src/head.c (elide_tail_lines_pipe): Fix a thinko.
7535 This sort of thing is why it'd be *Really Good* to factor
7536 out the common code used here and in tail.c.
7538 2003-05-14 Jim Meyering <jim@meyering.net>
7540 * src/head.c (usage): Document new feature: --bytes=-N and --lines=-N.
7542 * tests/du/slink: Skip this test if `.' is on an XFS file system.
7544 * tests/du/fd-leak: New file. Test for the bug in du that
7545 was fixed by the 2003-05-12 change to lib/ftw.c.
7546 * tests/du/Makefile.am (TESTS): Add fd-leak.
7548 * src/head.c (AUTHORS): Enclose string in N_(...), now that it
7549 includes a translatable word, `and'.
7551 * src/dd.c (usage): Don't use `,' as the thousands separator
7552 in e.g. 1,000,000 and 1,048,576. Instead, do this:
7553 `SIZE may be ..., MB 1000*1000, M 1024*1024 and so on...'
7554 * src/df.c (usage): Likewise.
7555 * src/du.c (usage): Likewise.
7556 * src/ls.c (usage): Likewise.
7558 * Makefile.maint (syntax-check): Add another check.
7560 2003-05-13 Paul Eggert <eggert@twinsun.com>
7562 Fix uniq to conform to POSIX, which requires that "uniq -d -u"
7563 must output nothing. Problem reported by Josh Hyman.
7565 * src/uniq.c (enum output_mode, mode): Remove, replacing with:
7566 (output_unique, output_first_repeated, output_later_repeated):
7567 New vars. All uses of "mode" changed to use these variables,
7568 which are not mutually exclusive as "mode" was.
7569 (writeline): New arg "match", used to control whether to
7570 obey output_first_repeated or output_later_repeated.
7571 All callers changed.
7572 (check_file, main): Adjust to above changes.
7574 * tests/uniq/Test.pm: Test that 'uniq -d -u' outputs nothing.
7576 2003-05-14 Jim Meyering <jim@meyering.net>
7578 * tests/rm/rm3: Use tr's \n notation rather than \012.
7579 This package can afford to do that, since its tests are guaranteed use
7580 GNU tr, which has accepted the more modern notation for 10 years.
7581 * tests/rm/rm5: Likewise.
7582 * tests/cp/same-file: Likewise.
7583 * tests/stty/row-col-1: Likewise.
7584 * tests/stty/basic-1: Likewise.
7585 * tests/rm/deep-1: Likewise.
7586 * tests/mv/part-symlink: Likewise.
7587 * tests/mkdir/perm: Likewise.
7588 * tests/misc/nice: Likewise.
7590 2003-05-13 Jim Meyering <jim@meyering.net>
7592 * src/copy.c (struct F_triple) [name]: Remove const attribute.
7593 (triple_free): Don't apply cast to argument of free.
7594 (seen_file): Add cast here instead.
7596 * src/cp-hash.c (struct Src_to_dest) [name]: Remove const attribute.
7597 (src_to_dest_free): Don't apply cast to argument of free.
7599 * src/sort.c (zaptemp): Don't apply cast to argument of free.
7600 * src/pr.c (init_fps, init_store_cols): Likewise.
7601 * src/join.c (delseq, freeline): Likewise.
7602 * src/expr.c (OLD): Likewise.
7603 * src/sort.c (sort): Likewise.
7604 * src/head.c (elide_tail_lines_pipe): Likewise.
7606 * src/tail.c: Include "quote.h".
7607 Use quote in diagnostics. Change many error format strings
7608 from just `%s' to e.g., `error reading %s'.
7609 (pipe_lines): Change type of parameter, n_lines, to uintmax_t.
7610 Rewrite newline-counting loop to use memchr.
7612 * src/head.c (elide_tail_lines_pipe): Use `if', not assert.
7613 Now that assert is no longer used, don't include <assert.h>.
7615 2003-05-12 Jim Meyering <jim@meyering.net>
7617 * src/head.c: Include <assert.h>.
7618 (AUTHORS): Add my name.
7619 (elide_tail_lines_pipe): New function.
7621 2003-05-10 Jim Meyering <jim@meyering.net>
7623 * Makefile.maint (syntax-check): Check for `error (EXIT_SUCCESS,'.
7625 * src/readlink.c (main): Set program_name before first use.
7626 Remove that (redundant) first use.
7627 Don't exit successfully just because --verbose was specified.
7628 Pass 0, not EXIT_SUCCESS, as first argument to error; when that
7629 parameter is 0, error does not exit.
7631 * src/uname.c (main): When failing due to too many arguments, also say
7632 that, rather than just "Try `uname --help' for more information.".
7633 * src/comm.c (main): Likewise, but for too few arguments.
7634 * src/logname.c: Include error.h.
7635 (main): Say why we're failing.
7637 * src/uniq.c (main): Don't segfault when argc < optind.
7638 * src/who.c (main): Handle argc < optind.
7639 * src/df.c (main): Likewise.
7640 * src/install.c (main): Likewise.
7641 * src/mv.c (main): Likewise.
7642 * src/pwd.c (main): Likewise.
7643 * src/tty.c (main): Likewise.
7644 * src/chroot.c (main): Likewise.
7645 * src/hostname.c: Likewise.
7646 * src/du.c (main): Likewise.
7647 * src/expand.c (main): Likewise.
7648 * src/env.c (main): Likewise.
7649 * src/unexpand.c (main): Likewise.
7650 * src/printenv.c (main): Likewise.
7651 * src/sync.c (main): Handle argc == 0.
7652 * src/expr.c (main): Likewise.
7653 * src/printf.c (main): Likewise.
7654 * src/basename.c (main): Likewise.
7655 * src/ln.c (main): Test for `missing argument' before computing n_files.
7656 * src/tail.c (main): Test for the case of no arguments before
7659 * src/kill.c (send_signals): Don't check command line arguments here.
7660 (main): Check them here instead. Handle argc < optind.
7662 * src/logname.c (main): Use error, rather than fprintf, for the sake
7665 * src/rm.c (main): Don't overrun array bound if argc is 0.
7667 2003-05-09 Jim Meyering <jim@meyering.net>
7669 * src/sort.c (main): Don't overrun array bound if argc is 0.
7670 That would happen when invoked via: execl ("/usr/bin/sort", NULL);
7671 Reported by Wartan Hachaturow.
7673 2003-05-07 Jim Meyering <jim@meyering.net>
7675 Implement support so that `head --lines=-N' works on seekable files.
7676 * src/head.c (enum Copy_fd_status): Define.
7677 (COPY_FD_DIAGNOSE): New macro.
7678 (elide_tail_lines_seekable): New funtion.
7679 (elide_tail_lines_file): Call it here.
7681 2003-05-06 Jim Meyering <jim@meyering.net>
7683 * src/sys2.h (CHAR_BIT): Remove duplicate definition.
7685 2003-05-04 Jim Meyering <jim@meyering.net>
7687 * tests/head/Test.pm: Remove tests of --bytes=-N; using that framework
7688 caused the addition of thousands of small files to the tar archive.
7689 * tests/misc/head-elide-tail: New file. Add them here instead.
7690 * tests/misc/Makefile.am (TESTS): Add head-elide-tail.
7692 2003-05-04 Paul Eggert <eggert@twinsun.com>
7694 * src/remove.c (HAVE_WORKING_READDIR): Define to 0 if not defined.
7695 (IF_READDIR_NEEDS_REWINDDIR): Remove.
7696 (remove_cwd_entries): Rewrite to avoid IF_READDIR_NEEDS_REWINDDIR,
7697 which was a bit weird because it couldn't be emulated by a function.
7699 2003-05-03 Jim Meyering <jim@meyering.net>
7701 Extend head to accept --lines=-N (--bytes=-N) and to print all
7702 but the N lines (bytes) at the end of the file.
7703 * src/head.c: Include full-write.h, full-read.h, inttostr.h, quote.h.
7704 Use quote() in diagnostics, rather than literal `' marks.
7705 (copy_fd, elide_tail_bytes_pipe, elide_tail_bytes_file):
7707 (elide_tail_lines_pipe, elide_tail_lines_file): New functions.
7708 (head_file): Reorganize so as to call head from only one place.
7709 (main): Likewise, for head_file.
7710 Handle new, undocumented option, --presume-input-pipe.
7711 Handle negative line and byte counts.
7712 * tests/head/Test.pm: Add lots of tests to exercise --bytes=-N.
7714 * tests/du/8gb: Skip test if the file system of `.' doesn't support
7715 sparse files -- otherwise it'd create a file of size 8GB.
7717 2003-05-02 Jim Meyering <jim@meyering.net>
7719 * src/fmt.c (usage): Don't mention obsolescent -WIDTH option.
7720 Instead explain about `-' and standard input.
7721 (main): Give a proper diagnostic for e.g., `fmt -c -72'.
7722 Reported by Keith Thompson.
7723 * tests/fmt/basic: Add test for the above fix.
7725 * src/fmt.c: Include "quote.h".
7726 Use quote() in diagnostics, rather than literal `' marks.
7727 (main): Exit nonzero when unable to open an input file.
7728 * tests/fmt/basic: Add test for the above fix.
7730 * src/fmt.c (main): Diagnose invalid suffix on obsolescent width
7731 specifications like `-72x'.
7732 * tests/fmt/basic: Add test for the above fix.
7734 Work around nasty readdir bug on Darwin6.5.
7735 * src/remove.c (IF_READDIR_NEEDS_REWINDDIR): Define.
7736 [! HAVE_WORKING_READDIR] (remove_cwd_entries): If readdir has just
7737 returned NULL and there has been at least one successful unlink or
7738 rmdir call since the opendir or previous rewinddir, then call
7739 rewinddir and reiterate the loop.
7741 Factor out common code.
7742 * src/remove.c (readdir_ignoring_dotdirs): New function.
7743 (is_empty_dir): Use it here.
7744 (remove_cwd_entries): Use it here.
7746 2003-05-01 Jim Meyering <jim@meyering.net>
7748 * tests/rm/r-3: Create 500 rather than just 300 files.
7749 There's a bug in Darwin6.5's readdir that shows up only with
7751 Fix a bug in this test: `cd $pwd' (not to `..'), now that $tmp
7755 Change type of n_units, n_bytes, n_lines to be `uintmax_t'.
7756 (dump_remainder): Move two declarations `down' into the scope
7757 where they are used.
7758 (xlseek): Return the resulting offset.
7759 (file_lines): Rename parameter, file_length, to end_pos.
7760 (pipe_lines): Don't coerce safe_read return value to `int'.
7761 Adapt tests accordingly.
7762 (pipe_bytes) [struct charbuffer] (nbytes): Change type from `int'
7764 Change type of `total_bytes' from `int' to `size_t',
7765 since the former wouldn't always be wide enough.
7766 Don't coerce safe_read return value to `int',
7767 and adapt tests accordingly.
7768 Now that testing for a read error no longer involves
7769 using `tmp', handle that case *after* freeing `tmp'.
7770 (start_bytes): Clean up.
7771 (tail_bytes): Now that `n_bytes' may be larger than
7772 OFF_T_MAX, test for that condition and, if it's true, don't
7773 use lseek optimizations.
7774 (parse_options): Don't fail just because N_UNITS is larger than
7775 the maximum size of a file -- tail may be applied to an input
7776 stream (e.g., a pipe) with more data than that.
7778 * Makefile.maint (syntax-check): Rename from alloc-check.
7779 Also check for SPACE-TAB sequences.
7780 Also check for malloc/calloc/realloc casts.
7782 2003-05-01 Jim Meyering <jim@meyering.net>
7784 * src/tail.c (start_lines): Rewrite to use memchr. Clean up.
7786 2003-04-28 Jim Meyering <jim@meyering.net>
7788 * tests/misc/tty-eof: Send two tokens, not just one, so we don't
7789 make the now-more-picky tsort fail.
7791 2003-04-24 Jim Meyering <jim@meyering.net>
7793 * src/tsort.c (tsort): Remove unnecessary test of have_read_stdin.
7794 (main): Minor syntactic clean-up.
7796 * src/tsort.c (tsort): Fail if the input contains an odd number of
7797 tokens. Reported by junkio@cox.net.
7799 * tests/tsort/basic-1: Test for the above fix.
7801 2003-04-21 Jim Meyering <jim@meyering.net>
7803 * tests/misc/printf: Add tests for the printf fixes below.
7805 * Makefile.cfg (cvs_files): Add $(srcdir)/config/depcomp to the list.
7807 2003-04-20 Paul Eggert <eggert@twinsun.com>
7809 Fix printf POSIX compatibility bug reported by Ben Harris in
7810 <http://mail.gnu.org/archive/html/bug-coreutils/2003-04/msg00070.html>.
7811 * doc/coreutils.texi (printf invocation): It's \NNN in the format,
7812 \0NNN in the %b operand.
7813 * src/printf.c (usage): Likewise.
7814 (print_esc): New arg OCTAL0 to specify whether \0NNN or \NNN
7815 is desired. All uses changed. Behave like Bash printf if %b
7816 operand uses \NNN where the initial N is not 0.
7818 2003-04-17 Jim Meyering <jim@meyering.net>
7820 * src/stty.c: Remove uses of PROTOTYPE macro.
7822 2003-04-15 Jim Meyering <jim@meyering.net>
7824 * Makefile.maint: Remove (or replace-with-TAB(s) to retain alignment)
7825 each sequence of spaces before a TAB character.
7827 2003-04-13 Jim Meyering <jim@meyering.net>
7829 * src/remove.c (is_empty_dir): Don't closedir (NULL).
7831 2003-04-12 Jim Meyering <jim@meyering.net>
7833 Giving nl an invalid STYLE argument (in --header-numbering=STYLE (-h),
7834 --body-numbering=STYLE (-b), or --footer-numbering=STYLE (-f)) or
7835 FORMAT (--number-format=FORMAT (-n)) would not give a useful diagnostic.
7836 * src/nl.c (main): Fix those problems and remove literal quote marks
7837 (e.g., "`%s'") from format string; instead use "%s" in each format
7838 string and `quote (optarg)' as the corresponding argument.
7839 Also, diagnose all invalid command line options before failing.
7841 * src/nl.c (proc_text): Fix a bug that would make nl output extra
7842 newlines in some cases. Details here: http://bugs.debian.org/177256.
7843 This bug was introduced on 2001-11-10 for textutils-2.0.17.
7844 * tests/misc/nl: Add test for the above-fixed bug.
7846 * tests/misc/readlink: New file. Test the --canonicalize option.
7847 * tests/misc/Makefile.am (TESTS): Add readlink.
7849 2003-04-11 Jim Meyering <jim@meyering.net>
7852 * src/chown.c, src/cp.c, src/dircolors.hin, src/du.c, src/ln.c:
7853 * src/mkfifo.c, src/ptx.c, src/spline.c, src/stty.c, src/tail.c:
7854 * src/test.c, src/unexpand.c: Remove (or replace-with-TAB(s) to
7855 retain alignment) each sequence of spaces before a TAB character.
7857 * src/ls.c: Include <stdlib.h> unconditionally.
7859 * Makefile.maint (xalloc-check): Rename from header-check.
7861 * src/yes.c: Include error.h after system.h, not before.
7864 * src/copy.c, src/cp-hash.c, src/cp.c, src/csplit.c, src/cut.c:
7865 * src/date.c, src/df.c, src/du.c, src/expand.c, src/expr.c, src/id.c:
7866 * src/join.c, src/md5sum.c, src/nl.c, src/od.c, src/paste.c, src/pr.c:
7867 * src/ptx.c, src/sort.c, src/split.c, src/su.c, src/tail.c, src/tee.c:
7868 * src/tr.c: * src/unexpand.c, src/users.c:
7869 Remove anachronistic casts of xmalloc, xrealloc, and xcalloc
7870 return values and of xrealloc's first argument.
7871 Fix the former with this:
7872 perl -pi -e 's/\([^(]*?\*\) *(x(m|c|re)alloc)\b/$1/'
7874 2003-04-10 Jim Meyering <jim@meyering.net>
7876 * src/stty.c (wrapf): Declare with format attribute.
7878 The S_MAGIC_... names shouldn't be maintained in two places (prior
7879 to this change, one would have to keep stat.c and fs.h in sync).
7880 This change makes it so those names and the corresponding
7881 hexadecimal constants all reside in stat.c. fs.h is now generated.
7882 * src/Makefile.am (fs.h): New rule to generate fs.h from stat.c.
7883 (BUILT_SOURCES): Add fs.h, now that it's generated.
7884 (EXTRA_DIST): Add extract-magic.
7885 * src/extract-magic: New script to extract fs.h definitions from stat.c.
7886 * src/stat.c (human_fstype) [__linux__]: Append each hex constant from
7887 fs.h in a comment after the corresponding `case S_MAGIC_...:' statement.
7889 * tests/tail-2/big-4gb: Skip this test (don't fail) if creating a
7890 file with nominal length > 4GB fails. Reported by Michael Deutschmann.
7892 * man/unexpand.x: Add `SEE ALSO' reference to expand.
7893 * man/expand.x: Add `SEE ALSO' reference to unexpand.
7894 Suggestion from Dan Jacobson.
7896 2003-04-10 Maciej W. Rozycki <macro@ds2.pg.gda.pl>
7898 * src/fs.h (S_MAGIC_DEVPTS): New magic for Linux's devpts.
7899 * src/stat.c (human_fstype): Handle Linux's devpts.
7901 2003-04-09 Paul Eggert <eggert@twinsun.com>
7903 * src/split.c (line_bytes_split): Arg is of type size_t, since
7904 that's all that is supported for now.
7905 (main): Check for overflow in obsolescent line count option.
7907 2003-04-09 Jim Meyering <jim@meyering.net>
7909 * tests/misc/split-fail: Add a new test for the above fix.
7911 * src/split.c (bytes_split): Use size_t temporary (rather than
7912 uintmax_t original) in remaining computations. From Paul Eggert.
7914 Handle command line option arguments larger than 2^31.
7915 This allows e.g., splitting into files of size 2GB and larger,
7916 and running split --lines=N with N=2^31 or more.
7917 But for --line-bytes=N, the restriction that N <= SIZE_MAX
7918 remains (for now), due to the way it is implemented.
7920 * src/split.c: Include "inttostr.h".
7921 (bytes_split, lines_split, line_bytes_split, main):
7922 Use uintmax_t, not size_t, for file sizes.
7923 (main): Give a better diagnostic for option arguments == 0.
7924 Use umaxtostr to print file sizes.
7925 Reported by Luke Hassell.
7927 2003-04-08 Jim Meyering <jim@meyering.net>
7929 * src/rm.c (usage): Mention that --directory (-d) works only
7930 on some systems. Suggestion from Samuel Tardieu.
7932 * tests/basename/basic: Run $PERL to see if it is available,
7933 rather than testing its value.
7934 * tests/sum/sysv, tests/tsort/basic-1, tests/unexpand/basic-1:
7935 * tests/basename/basic, tests/dd/skip-seek, tests/dircolors/simple:
7936 * tests/expr/basic, tests/factor/basic, tests/fmt/basic:
7937 * tests/ls-2/tests, tests/md5sum/basic-1, tests/md5sum/newline-1:
7938 * tests/misc/sort, tests/misc/tty-eof, tests/mv/i-1:
7939 * tests/rm/empty-name, tests/rm/fail-eperm, tests/rm/unreadable:
7940 * tests/seq/basic, tests/sha1sum/basic-1, tests/sha1sum/sample-vec:
7941 * tests/sum/basic-1, tests/seq/basic: Likewise.
7943 * tests/misc/Makefile.am (TESTS): Add split-fail.
7944 * tests/misc/split-fail: New file.
7946 * src/split.c: Rename local variables: nchars -> n_bytes.
7947 (lines_split): Rename local, nlines -> n_lines.
7948 (main): Rename local variable: s/accum/n_units/.
7949 (main): Use STDIN_FILENO, not literal `0'.
7951 2003-04-07 Jim Meyering <jim@meyering.net>
7953 * src/stat.c: Add #include directives for Ultrix 4.4.
7954 Based on a suggested change from Bert Deknuydt.
7956 2003-04-06 Jim Meyering <jim@meyering.net>
7958 * Makefile.maint (makefile-check): New rule.
7959 (local-check): Add it.
7961 2003-04-05 Jim Meyering <jim@meyering.net>
7963 * Makefile.am (nearly all of them):
7964 Use $(VAR) rather than @VAR@, now that we can rely on automake to
7965 emit a definition for each substituted variable.
7966 * tests/Makefile.am.in: Likewise.
7968 * tests/rm/rm5: Add a comment explaining why this test fails when
7969 using Tru64's broken sed.
7970 * tests/rm/rm3: Likewise.
7972 Make `kill -t' output signal descriptions (not `?') on Tru64.
7973 * src/kill.c (sys_siglist): Also check for __sys_siglist.
7974 Patch by Tony Leneis.
7975 * configure.ac: Also check for declaration of __sys_siglist.
7976 Required for Tru64 4.0D, 4.0F, and 5.1.
7977 Reported by Tony Leneis.
7979 2003-04-04 Jim Meyering <jim@meyering.net>
7981 * src/Makefile.am (PERL): Remove unnecessary definition.
7983 Because of inappropriate (but POSIX-mandated) behavior of rename,
7984 `mv a b' would not remove `a' in some unusual cases. Work around
7985 this by unlinking `a' when necessary.
7987 * src/copy.c (same_file_ok): Add an output parameter.
7988 Set it in the offending case.
7989 (copy_internal): When necessary, unlink SRC_PATH and inform caller.
7990 Reported by Ed Avis.
7991 * tests/mv/hard-4: New test for the above.
7992 * tests/mv/Makefile.am (TESTS): Add hard-4.
7994 Clean up rules for automatically generated sources:
7995 * src/Makefile.am (dircolors.h, wheel-size.h, wheel.h, false.c):
7996 Make each generated file be read-only.
7997 Add each file name to BUILT_SOURCES separately.
7998 (MAINTAINERCLEANFILES): Set to $(BUILT_SOURCES).
8000 Put LOCALEDIR macro definition in new file: localedir.h.
8001 * src/Makefile.am (DEFS): Remove definition.
8002 (localedir.h): New rule.
8003 (BUILT_SOURCES, DISTCLEANFILES): Add localedir.h.
8004 * src/system.h: Include "localedir.h".
8006 2003-04-02 Jim Meyering <jim@meyering.net>
8010 * tests/misc/Makefile.am (TESTS): Add false.
8012 * Makefile.maint (TMPDIR): Make sure it's defined.
8013 (my-distcheck): Build in $(TMPDIR), not `.'.
8015 * src/Makefile.am (false.c): Change all occurrences of
8016 `(EXIT_SUCCESS)' to `(EXIT_FAILURE)' so that false exits
8017 unsuccessfully also with --help. Reported by Paul Jarc,
8018 * tests/misc/false: New test for the above.
8020 2003-03-30 Jim Meyering <jim@meyering.net>
8022 * NEWS: Note the location of older NEWS files.
8024 * src/remove.c (is_empty_dir): Don't let a failing closedir
8025 clobber errno. Spotted by Arnold Robbins.
8027 * src/env.c: Fix typo in comment. From Arnold Robbins.
8029 2003-03-29 Jim Meyering <jim@meyering.net>
8033 * README: Note to expect build problems for stat.c on Ultrix 4.3.
8034 Note that there are some harmless test failures when running
8035 `make check' as root on some systems.
8037 2003-03-28 Jim Meyering <jim@meyering.net>
8039 * tests/stty/row-col-1: Skip this test if stty can't get window size.
8040 This happens when connecting to sparc-solaris5.7 via ssh from within
8041 emacs. Reported by Karl Berry.
8043 * tests/du/basic: Use seq, not `yes' to generate 4KB of data.
8044 Otherwise, on systems (DJGPP) that emulate pipes using files,
8045 this test would never complete, waiting for `yes' to terminate.
8046 * tests/du/slink: As above, use seq, not `yes' to generate link target.
8047 * tests/rm/hash: As above, use seq, not `yes' to generate dir name.
8048 Reported by Rich Dawe.
8050 2003-03-27 Jim Meyering <jim@meyering.net>
8052 * src/id.c: Remove Arnold Robbins' obsolete e-mail address
8053 from `written by...' comment, at his request.
8055 2003-03-24 Paul Eggert <eggert@twinsun.com>
8057 Fix buffer overrun problem reported by TAKAI Kousuke, along
8058 with some other POSIX incompatibilities.
8060 * src/printf.c (print_esc): Do not treat \x specially if
8061 POSIXLY_CORRECT. Avoid buffer overrun if the format ends
8062 in backslash. Treat incomplete escape sequences as strings
8063 of characters, as POSIX requires.
8064 (print_formatted): Allow multiple flags. Avoid buffer overrun
8065 if the format is incomplete.
8067 2003-03-24 Jim Meyering <jim@meyering.net>
8069 * tests/misc/printf: Add tests for the above fixes and changes.
8071 2003-03-26 Jim Meyering <jim@meyering.net>
8073 * src/copy.h (struct cp_options): Add a comment.
8075 2003-03-23 Jim Meyering <jim@meyering.net>
8077 * README: Describe problem with 64-bit mode on HPUX 11.x,
8078 with patch for /usr/include/inttypes.h.
8079 * TODO: Plan to add an autoconf test to work around the bug.
8081 2003-03-22 Jim Meyering <jim@meyering.net>
8083 * src/stat.c: Don't include <sys/sysmacros.h>.
8084 That is already done via system.h. Otherwise, the multiple
8085 inclusion would evoke redefinition warnings from Cray's /bin/cc,
8086 aka Cray Standard C Version 4.0.3 (057126) Mar 22 2003 22:02:28.
8087 (human_fstype): Factor some directives `up', out of this function.
8088 Cast away `const' to avoid error from Cray's /bin/cc.
8090 2003-03-20 Jim Meyering <jim@meyering.net>
8092 * announce-gen (print_changelog_deltas): Ensure that a newline
8093 precedes each row of `*'s.
8095 2003-03-20 Jim Meyering <jim@meyering.net>
8099 * src/seq.c (valid_format): Also accept ` ' and `'' as valid
8100 format flag characters.
8101 Do not require that a field width be specified.
8102 Do not fail when given a field width of `0'.
8103 Reported by Dan Jacobson.
8104 * tests/seq/basic: Add new tests for the above-fixed bug.
8106 * src/Makefile.am (all-local): Append $(EXEEXT) to use of `su'
8107 (install-root): Likewise.
8108 (install-exec-local): Likewise.
8109 Based on a patch from Richard Dawe.
8111 2003-03-19 Jim Meyering <jim@meyering.net>
8113 * man/Makefile.am (.x.1): Use $(LN_S) instead of 'ln -s',
8114 because the DJGPP 2.03 port of 'ln -s' doesn't work.
8115 Include $(EXEEXT) in program names.
8116 Since $(LN_S) may degenerate to `cp -p', be careful
8117 to invoke it from the destination directory.
8118 Mostly from Richard Dawe.
8119 * configure.ac: Use AC_PROG_LN_S.
8121 * tests/mv/part-symlink: Unset CDPATH. Otherwise, having the
8122 CDPATH shell variable set could cause this test to fail.
8123 Reported by Karl Berry.
8125 2003-03-18 Jim Meyering <jim@meyering.net>
8127 * src/fmt.c [struct Word] (paren, period, punct, final): Change the
8128 type of each member from bool <MEMBER>:1 to unsigned int <MEMBER>:1.
8129 AIX 5.1's xlc could not compile the former.
8130 Patch by Petter Reinholdtsen. Also reported by Mike Jetzer.
8132 2003-03-17 Richard Dawe <rich@phekda.freeserve.co.uk>
8134 * configure.ac: Include $(EXEEXT) in OPTIONAL_BIN_PROGS'
8135 program names, since automake only adds $(EXEEXT) to programs
8138 2003-03-16 Jim Meyering <jim@meyering.net>
8140 * src/remove.c (rm): Put two local variables in static storage,
8141 so they can't be clobbered by the potential longjmp.
8143 2003-03-15 Jim Meyering <jim@meyering.net>
8145 * Makefile.cfg (gnu_rel_host): Fix code to match the comment
8146 so that a version number with a two-digit component can still count
8147 as an alpha release. Reported by Richard A Downing.
8148 (gnu_rel_host): Define in terms of $(RELEASE_TYPE) instead.
8150 2003-03-14 Jim Meyering <jim@meyering.net>
8152 * src/ansi2knr.c: Remove no-longer-used file.
8153 * src/ansi2knr.1: Likewise.
8155 * Makefile.maint (prev_version_file): Don't use ?= for this particular
8156 assignment, since it causes trouble with old versions of GNU make
8157 (e.g. 3.76.1). The other uses of `?=' are inoffensive. Details here.
8158 http://mail.gnu.org/archive/html/bug-coreutils/2003-03/msg00028.html
8159 Patch from Alexandre Duret-Lutz.
8161 * Use patched automake-1.7.3. Regenerate Makefile.in files in
8162 subdirectories so that each includes a definition of ACLOCAL_M4.
8164 * announce-gen (main): Label the compressed source URLs.
8168 * tests/du/slink: Relax the test for the `local'ness of a file system,
8169 so that now it works also for tmpfs.
8171 * tests/du/hard-link: Transform output from first du, so that this
8172 test doesn't fail on file systems like tmpfs that order directory
8173 entries differently.
8175 2003-03-13 Jim Meyering <jim@meyering.net>
8177 * tests/du/8gb: Work around what appears to be an NFS failure that
8178 would make this test fail on some systems.
8180 2003-03-11 Jim Meyering <jim@meyering.net>
8182 * tests/du/basic: Make the test file exactly 4k bytes long.
8184 * src/split.c (longopts): Don't hard-code `2' here.
8185 Instead, just specify `&verbose', and ...
8186 (main): ... remove the `case 2:' block for --verbose.
8188 * tests/du/basic: Make the test file larger than 64 bytes, so that
8189 we don't immediately disqualify file systems (e.g., NetApp) on which
8190 smaller files take up zero disk blocks. Reported by Vin Shelton.
8192 2003-03-10 Jim Meyering <jim@meyering.net>
8194 Don't segfault for a negative field width or precision in format string.
8195 Note that this is just a stopgap fix. The longer term solution may
8196 involve adapting bash's builtins/printf.def.
8198 * src/printf.c: (UNSPECIFIED): Define.
8199 (print_direc): Use the special value, UNSPECIFIED, to indicate
8200 that field_width or precision has not been specified.
8201 (print_formatted): Fail if field_width or precision is the
8202 special value, UNSPECIFIED.
8203 Reported by Oliver Kiddle <okiddle@yahoo.co.uk>
8205 * src/sys2.h (INT_MIN): Define, if necessary.
8206 * tests/misc/printf: Add a test for the above-fixed bug.
8208 2003-03-09 Jim Meyering <jim@meyering.net>
8210 * src/remove.c (AD_stack_pop): Cast sizeof... to int before
8211 changing its sign. This avoids a warning from gcc on 64-bit systems.
8212 Reported by Bob Proulx.
8213 (pop_dir): Reverse order of sign change and cast, to be consistent
8216 2003-03-08 Jim Meyering <jim@meyering.net>
8218 * tests/Makefile.am (evar-check): Check for POSIXLY_CORRECT not as a
8219 shell variable, but only in the environment. With /bin/sh->bash, the
8220 shell variable is set to `y', and that would cause a spurious warning.
8221 Reported by Bob Proulx.
8223 * tests/Makefile.am (check-root): Remove touch/fifo.
8224 It doesn't appear to have to be run as root.
8226 * tests/rm/fail-2eperm: Rather than simply using the first non-root
8227 user name, make sure that the selected user name has a usable shell.
8228 Reported by Paul Jarc.
8230 Before, when using shred on a device, one had to specify --exact,
8231 or be careful to choose a size that would not be rounded up and
8232 exceed the maximum value; that could result in a failure of
8234 * src/shred.c (do_wipefd): --exact is now the default for non-regular
8235 files. Suggestion from Ben Elliston.
8238 * tests/misc/tty-eof: Require at least version 1.11 of Expect.pm.
8239 Old versions of Expect.pm (e.g., 1.07) lack the log_user function.
8240 Patch by Bob Proulx.
8242 * src/Makefile.am (check-misc): Check for use of `defined' in
8244 Change to $(srcdir) before running grep.
8246 * src/sleep.c: Remove now-unused #include and #define directives.
8248 * src/du.c (process_file): If a file's size is not being counted
8249 e.g., because it's a hard link to a file we've already counted,
8250 then don't print a line for it.
8252 * tests/du/hard-link: New test for the above-fixed bug.
8253 * tests/du/Makefile.am (TESTS): Add hard-link.
8256 * src/du.c: Revert most of the `reorganization' change of 2003-02-20,
8257 and make the two-array approach work.
8259 * tests/du/basic: Correct/add tests for the above fix.
8260 Set LC_ALL, etc., now that we use sort.
8261 Check the block/size of a small file, too.
8262 Correct expected results for simple dir1/dir2/file case.
8263 Add another test of du -S.
8265 2003-03-07 John David Anglin <dave.anglin@nrc-cnrc.gc.ca>
8267 Avoid build failure with gcc on hppa1.1-hp-hpux10.20 (see GCC PR
8268 middle-end/9986). As one of GCC's optimizations, it transforms a
8269 fputs_unlocked call to a fputc_unlocked call when the string is
8270 one character long. However, hpux doesn't have fputc_unlocked.
8272 * expr.c (usage): Use putchar, not fputs, to output a single character.
8273 * ls.c (dired_dump_obstack): Likewise.
8274 * ptx.c (output_one_tex_line, output_one_dumb_line): Likewise.
8275 * stat.c (print_it): Likewise.
8277 2003-03-07 Jim Meyering <jim@meyering.net>
8279 * src/cp.c: Remove everything associated with mmap-stack.c.
8280 This reverts the two changes of 2003-02-21.
8281 * src/du.c: Remove everything associated with mmap-stack.c.
8282 This reverts the change of 2003-02-19.
8284 2003-03-06 Jim Meyering <jim@meyering.net>
8286 * tests/cp/same-file: Unset CDPATH. Otherwise, having the
8287 CDPATH shell variable set could cause this test to fail.
8288 Reported by Karl Berry.
8290 2003-03-05 Jim Meyering <jim@meyering.net>
8294 * src/printf.c (print_esc): Remove pointless comparison of unsigned
8295 integer with zero, to avoid a warning from Intel's ecc.
8296 Reported by Nelson Beebe.
8298 * src/du.c (process_file): Sizes must all be of type uintmax_t.
8299 Otherwise, for files or totals that are too big, numbers would
8300 be truncated. Patch mostly by Michael Stone.
8301 Reported by Ingo Saitz as Debian bug #183210.
8303 * tests/du/8gb: New test for the above-fixed bug.
8304 * tests/du/Makefile.am (TESTS): Add 8gb.
8306 * src/du.c (MAX_N_DESCRIPTORS): Use 3 * UTILS_OPEN_MAX / 4
8307 rather than UTILS_OPEN_MAX - 10.
8309 2003-03-04 Jim Meyering <jim@meyering.net>
8311 * README: Refer new feature discussion to bug-coreutils@gnu.org,
8312 rather than bug-gnu-utils, now that the former is better known.
8313 Suggestion from Göran Uddeborg.
8315 * src/stat.c (usage): Capitalize consistently.
8316 Reported by Göran Uddeborg.
8318 * Makefile.maint (rel-files): Include $(signatures), so that
8319 those files are also copied into $(release_archive_dir).
8321 * src/df.c (find_mount_point): Call error here, now that restore_cwd
8323 * src/remove.c (AD_pop_and_chdir): Likewise.
8325 * tests/Makefile.am (check-root): Add fail-2eperm.
8327 2003-03-03 Jim Meyering <jim@meyering.net>
8329 * src/remove.c (remove_cwd_entries): Include the full filename of
8330 the offending file, not just the basename.
8332 * tests/misc/tty-eof: Set $ME properly.
8334 * Makefile.maint (THIS_VERSION_REGEXP, PREV_VERSION_REGEXP):
8335 Remove now-unused variables.
8336 (tag-prev-version, prev-cvs-tag): Likewise.
8338 * src/remove.c (remove_cwd_entries) [!ROOT_CAN_UNLINK_DIRS]: Give an
8339 accurate diagnostic when failing to remove a file owned by some other
8340 user. Reported by Ivo Timmermans via Michael Stone.
8341 This fixes Debian bug# 178471.
8343 * tests/rm/Makefile.am (TESTS): Add fail-2eperm.
8344 * tests/rm/fail-2eperm: New test, for the above-fixed bug.
8345 Based on a report from Ivo Timmermans.
8347 2003-03-02 Jim Meyering <jim@meyering.net>
8349 * src/copy.c (copy_internal) [un_backup]: When recovering from a
8350 failure to create a hard link, do not remove the entry associating
8351 the source dev/ino with the destination file name.
8352 * tests/mv/Makefile.am (TESTS): Add hard-3.
8353 * tests/mv/hard-3: New test, for the above-fixed bug.
8354 Inspired by a report from Iida Yosiaki.
8356 2003-03-01 Jim Meyering <jim@meyering.net>
8358 * src/df.c (print_header): Don't embed spaces in a separate `Type'
8359 header string. Instead, put `Filesystem' and `Type' headers in the
8360 same string, so translators can use horizontal space as needed.
8361 Reported by Jean Charles Delepine.
8363 2003-02-28 Jim Meyering <jim@meyering.net>
8365 * src/copy.c (copy_internal): When link fails because of an
8366 existing destination file, unlink that file and try again.
8367 Reported by Iida Yosiaki.
8369 * tests/mv/Makefile.am (TESTS): Add hard-2.
8370 * tests/mv/hard-2: New test for the above-fixed bug.
8371 Based on a test case from Iida Yosiaki.
8373 2003-02-26 Jim Meyering <jim@meyering.net>
8375 * tests/du/basic: Don't test du's -b option here. Directory byte
8376 counts are smaller (512 rather than 4096) on at least OSF/1 5.1
8377 and IBM AIX 4.2. Reported by Nelson Beebe.
8379 2003-02-25 Jim Meyering <jim@meyering.net>
8381 * Makefile.maint (announcement): Now that ChangeLog entries
8382 are output by announce-gen, don't do it here.
8383 * announce-gen (print_changelog_deltas): New function.
8386 2003-02-22 Jim Meyering <jim@meyering.net>
8388 * announce-gen: New option: --release-type=TYPE
8389 * Makefile.maint (beta, major): New targets. Remove `release'.
8390 Put them all together on a line.
8391 Pass the release type (via RELEASE_TYPE envvar) to the MAKE
8392 invocation of `announcement'.
8393 (announcement): Invoke announce-gen with --release-type=$RELEASE_TYPE.
8395 * announce-gen: New option: --news=NEWS_FILE.
8396 Extract NEWS entries here, not via rules in Makefile.maint.
8397 * Makefile.maint (announcement): Now that NEWS entries are
8398 extracted by announce-gen, don't do it here.
8399 (news-r1, news-r2): Remove now-unused definitions.
8401 2003-02-21 Jim Meyering <jim@meyering.net>
8405 Merge in changes from autoconf's version of this file.
8406 * Makefile.maint (www-gnu): Define.
8407 (standards.texi-url_prefix): Use $(www-gnu).
8408 (make-stds.texi-url_prefix): Likewise.
8410 * src/cp.c: Include "mmap-stack.h".
8411 (main): Invoke `run' through a macro that (when possible) runs it
8412 with a large, mmap'd stack.
8414 * src/cp.c (run): New function, preparing for the above.
8415 Exit from this function, not from main
8418 * src/du.c: New option: --apparent-size.
8419 (enum) [APPARENT_SIZE_OPTION]: New member.
8420 (long_options): Add it.
8421 (usage): Describe it.
8423 ['b']: Set apparent_size.
8424 David Eisner reported that the behavior of --bytes had changed.
8425 Paul Eggert proposed the use of a new option, --apparent-size.
8427 * src/du.c (apparent_size): New global.
8428 (print_only_size): Reflect the fact that we're printing byte counts,
8429 not ST_NBLOCKSIZE-byte-block counts.
8430 (print_size): Call print_only_size rather than duplicating its code.
8431 (process_file): Accumulate byte counts, rather than block counts.
8433 * src/du.c (process_file): Always reset size_to_propagate_to_parent
8434 for --separate-dirs (-S).
8436 2003-02-20 Jim Meyering <jim@meyering.net>
8438 * Use automake-1.7.3. Regenerate dependent files.
8440 * src/stat.c (print_stat): New format: %B (to print ST_NBLOCKSIZE).
8441 This makes %b (number of ST_NBLOCKSIZE-byte blocks) more useful.
8442 (usage) [%B]: Describe it.
8445 * src/du.c (process_file): Reorganize the code to use only
8446 one `sum' array, and change how -S works back to the way it was
8447 before 2003-01-31. Patch by Bruno Haible.
8449 * tests/du/basic: New test.
8450 * tests/du/Makefile.am (TESTS): Add basic.
8452 * tests/envvar-check: Add checks for the following:
8453 BLOCK_SIZE, DU_BLOCK_SIZE, DF_BLOCK_SIZE, LS_BLOCK_SIZE.
8455 * tests/Makefile.am: Rename phony target envvar-check to evar-check
8456 so as not to conflict with the distributed file by the same name.
8458 * src/du.c (process_file): Set info->skip before any possible return.
8460 Report correct usage for directories, not 0.
8461 * src/du.c (process_file): Return for `file_type == FTW_DPRE'
8462 _before_ recording the dev/ino of a directory.
8463 Reported by Bruno Haible.
8465 Now, df always displays the device file name corresponding to the
8466 listed mount point under `Filesystem'. Before, for an unmounted
8467 block- or character-special file argument, it would display the
8468 command-line argument instead.
8469 * src/df.c (show_disk): Return a value indicating whether
8470 there was a match. Don't try to find a mount point here.
8471 (show_entry): If show_disk doesn't find a match, call show_point.
8473 2003-02-19 Jim Meyering <jim@meyering.net>
8475 * src/du.c: Include "mmap-stack.h".
8476 (du_files): Add prototype with ATTRIBUTE_NORETURN.
8477 Exit from this function, not from...
8479 Instead, if possible, invoke du_files through a macro that
8480 runs it with a large, mmap'd stack.
8482 * src/join.c (usage): Change wording in --help output:
8483 use FILENUM instead of `SIDE' and say what FILENUM means.
8484 Reported by Bernhard Gabler.
8486 * src/df.c (print_header): Rather than using a hard-coded literal
8487 string of spaces matching the length of the English `...Type' header,
8488 output the right number of spaces to match the selected translation.
8489 Reported by Yann Dirson and Jean Charles Delepine as Debian bug 131113.
8491 * src/split.c (bytes_split): Remove unnecessary `else' after break.
8492 (lines_split): Likewise. and correct misleading indentation.
8494 * src/split.c: Include "full-read.h".
8495 (bytes_split, lines_split, line_bytes_split): Use full_read,
8496 not safe_read. The way split was using the latter, a short read
8497 could cause split to terminate before EOF.
8499 * tests/misc/tty-eof: Test all programs that can read stdin,
8500 requiring no arguments and that write to standard output.
8502 * tests/misc/tty-eof: New file. Renamed from ...
8503 * tests/misc/cat-tty-eof: Remove file. Rename to tty-eof.
8504 * tests/misc/Makefile.am (TESTS): Reflect renaming.
8506 2003-02-18 Jim Meyering <jim@meyering.net>
8508 cksum would perform an extra read after encountering EOF
8509 * src/cksum.c (cksum): Exit the loop upon EOF, too.
8510 Patch by Michael Bacarella.
8512 Test for the bug fixed today in cksum, md5sum, and sha1sum.
8513 * tests/misc/cat-tty-eof: Generalize, clean-up, and test for
8514 cat, cksum, md5sum, and sha1sum all in the same loop.
8516 2003-02-14 Jim Meyering <jim@meyering.net>
8518 * src/remove.c: Include "euidaccess.h".
8519 Remove declaration of euidaccess.
8521 2003-02-12 Jim Meyering <jim@meyering.net>
8523 * src/pathchk.c (portable_chars_only): Remove unnecessary `const'
8524 in cast to avoid warning from icc. Reported by Alexandre Duret-Lutz.
8526 2003-02-10 Jim Meyering <jim@meyering.net>
8528 * src/test.c: Don't include group-member.h.
8529 Include euidaccess.h.
8530 (eaccess): Rewrite function to set the real uid and gid temporarily
8531 to the effective uid and gid, then invoke 'access', and then set the
8532 real uid and gid back. On systems that lack setreuid or setregid,
8533 fall back on the kludges in euidaccess. Before, it would not work
8534 for e.g., files with ACLs, files that were marked immutable,
8535 or on file systems mounted read-only. Nelson Beebe raised the issue.
8536 Paul Eggert suggested the new implementation.
8538 2003-02-09 Jim Meyering <jim@meyering.net>
8540 * src/test.c (test_stat): Remove function. It's job is done (only
8541 when necessary) by the wrapper in lib/stat.c. Adjust all uses.
8543 2003-02-08 Jim Meyering <jim@meyering.net>
8547 * tests/mv/part-symlink: Don't assume that the file owner username
8548 length is less than 9 in ls output: instead, omit that field
8549 altogether. Reported by, and suggested fix from, Ferdinand.
8551 * tests/du/restore-wd: New test for just-fixed bug in ftw.c.
8552 * tests/du/Makefile.am (TESTS): Add restore-wd.
8554 * src/rm.c: Correct now-invalid comment about cycle-detection.
8556 2003-02-06 Jim Meyering <jim@meyering.net>
8558 * NEWS: Add entries from old/*/NEWS
8559 from fileutils-4.1 through 4.1.11 and
8560 from sh-utils-2.0 through 2.0.15. Suggestion from Karl Berry.
8564 * src/du.c (process_file): Don't return early for excluded files
8565 or for files whose dev/inode we've already seen.
8567 2003-02-05 Jim Meyering <jim@meyering.net>
8569 * tests/du/exclude: New file.
8570 * tests/du/Makefile.am (TESTS): Add exclude.
8572 2003-02-04 Dmitry V. Levin <ldv@altlinux.org>
8574 * src/who.c (print_boottime, print_deadprocs, print_runlevel):
8575 Fix memory allocation arithmetic.
8577 2003-02-04 Jim Meyering <jim@meyering.net>
8579 `df /dev/block-or-char-device-file--not-mounted' now reports
8580 the name of the file system on which the file resides, usually `/'.
8581 Before, it would leave the `Mounted on' field blank.
8582 * src/df.c (show_disk): Move function to precede find_mount_point.
8583 (show_disk): Add parameter: STATP.
8584 If we don't find a matching device name, then resort to calling
8585 find_mount_point. Reported by Bob Proulx.
8587 2003-02-03 Andreas Schwab <schwab@suse.de>
8589 * tests/rm/cycle: Require non-root.
8590 * tests/rm/isatty: Likewise.
8592 2003-02-02 Jim Meyering <jim@meyering.net>
8596 * man/Makefile.am (check-x-vs-1): Use @PATH_SEPARATOR@, not `:'.
8598 Ensure that there are no offending uses of `:'.
8599 * Makefile.maint (makefile_path_separator_check): New rule.
8600 (local-check): Add it to the list.
8602 2003-02-01 Jim Meyering <jim@meyering.net>
8604 * src/du.c (MAX_N_DESCRIPTORS): Define.
8606 * src/stat.c (G_fail): New global.
8607 (human_time): Diagnose failed localtime, not failed nstrftime.
8608 (main): Fail if G_fail is set.
8610 2003-01-31 Richard Dawe <rich@phekda.freeserve.co.uk>
8612 * tests/basename/Makefile.am: Use @PATH_SEPARATOR@ instead of
8613 hard-coding the path-separator. Also double-quote the new PATH,
8614 to avoid problems when the path-separator is a semi-colon or when
8615 `pwd` contains e.g. a space.
8616 * tests/chgrp/Makefile.am: Likewise.
8617 * tests/chmod/Makefile.am: Likewise.
8618 * tests/chown/Makefile.am: Likewise.
8619 * tests/cp/Makefile.am: Likewise.
8620 * tests/dd/Makefile.am: Likewise.
8621 * tests/dircolors/Makefile.am: Likewise.
8622 * tests/du/Makefile.am: Likewise.
8623 * tests/expr/Makefile.am: Likewise.
8624 * tests/factor/Makefile.am: Likewise.
8625 * tests/fmt/Makefile.am: Likewise.
8626 * tests/install/Makefile.am: Likewise.
8627 * tests/ln/Makefile.am: Likewise.
8628 * tests/ls/Makefile.am: Likewise.
8629 * tests/ls-2/Makefile.am: Likewise.
8630 * tests/md5sum/Makefile.am: Likewise.
8631 * tests/misc/Makefile.am: Likewise.
8632 * tests/mkdir/Makefile.am: Likewise.
8633 * tests/mv/Makefile.am: Likewise.
8634 * tests/od/Makefile.am: Likewise.
8635 * tests/rm/Makefile.am: Likewise.
8636 * tests/rmdir/Makefile.am: Likewise.
8637 * tests/seq/Makefile.am: Likewise.
8638 * tests/sha1sum/Makefile.am: Likewise.
8639 * tests/shred/Makefile.am: Likewise.
8640 * tests/stty/Makefile.am: Likewise.
8641 * tests/sum/Makefile.am: Likewise.
8642 * tests/tail-2/Makefile.am: Likewise.
8643 * tests/touch/Makefile.am: Likewise.
8644 * tests/tsort/Makefile.am: Likewise.
8645 * tests/unexpand/Makefile.am: Likewise.
8647 2003-01-31 Jim Meyering <jim@meyering.net>
8649 * src/stat.c: Include "file-type.h"
8650 (print_human_type): Remove function.
8651 (human_access): Rename from print_human_access. Return a string.
8652 (human_time): Rename from print_human_time. Return a string.
8653 (print_stat): Arrange so that field width and an alignment specifier
8654 are honored for the %A, %F, %x, %y, and %z formats.
8655 [%F]: Use file_type; this gives slightly different file type strings,
8656 e.g., `directory' instead of `Directory' and `regular file' or
8657 `regular empty file' instead of `Regular file'.
8658 Prompted by a report from Richard Dawe that the uses of
8659 S_IFSOCK and S_IFIFO in print_human_time were not portable
8660 to systems using e.g., DJGPP.
8662 2003-01-31 Richard Dawe <rich@phekda.freeserve.co.uk>
8664 * src/stat.c (print_stat): Use S_ISLNK rather than an explicit
8665 test using S_IFMT and S_IFLNK. S_IFLNK may not be defined.
8667 2003-01-31 Jim Meyering <jim@meyering.net>
8669 * src/du.c (main): Upon processing an invalid option or an invalid
8670 --exclude-from or --max-depth option argument, don't exit right away,
8671 in case there are others. Rather record the failure and exit after
8672 processing other options.
8674 * GNUmakefile (TAR_OPTIONS): Set and export, in order to make
8675 tar archive easier to reproduce.
8677 Rewrite to perform directory traversal using nftw.
8679 * src/du.c: Include "dirname.h", "ftw.h", and "quotearg.h".
8680 (AUTHORS): Add self.
8681 (opt_one_file_system): Move global into `main'.
8682 (path, xstat, exit_status): Remove declarations.
8683 (arg_length, suffix_length): New globals.
8684 (G_fail): New global, sort of like the old `exit_status'.
8685 (IS_FTW_DIR_TYPE): Define.
8686 (print_only_size): New function.
8687 (process_file): New function.
8688 (str_init, ensure_space, str_copyc, str_concatc): Remove functions.
8689 (str_trunc, pop_dir, count_entry): Likewise.
8690 (du_files): Rewrite to use nftw.
8692 2003-01-30 Jim Meyering <jim@meyering.net>
8694 * tests/du/trailing-slash: Ensure that du/ftw follows a command-line
8695 symlink-to-directory with -L, even without the trailing slash.
8697 2003-01-27 Jim Meyering <jim@meyering.net>
8699 * src/Makefile.am (check-misc): Check for st_blocks, too.
8701 * src/stat.c (print_stat): Use ST_NBLOCKS rather than `->st_blocks'.
8702 Reported by Richard Dawe.
8704 2003-01-27 Andreas Schwab <schwab@suse.de>
8706 * src/ls.c (quote_name): Add fourth parameter, width, into which to
8707 store the screen columns, and return the number of bytes instead.
8708 (print_dir): Pass NULL as fourth parameter of quote_name.
8709 (print_name_with_quoting): Likewise.
8710 (length_of_file_name_and_frills): Get the width from the fourth
8711 parameter of quote_name instead of return value.
8713 2003-01-27 Jim Meyering <jim@meyering.net>
8715 * src/ls.c (decode_switches): If `dired' is set without
8716 `format == long_format', then silently reset dired. This doesn't
8717 change the behavior of ls (all prior uses of dired were protected
8718 by `&& format == long_format'), and lets us...
8719 (DIRED_INDENT): ... remove the `format == long_format' conjunct.
8720 (PUSH_CURRENT_DIRED_POS): Likewise.
8723 2003-01-22 Jim Meyering <jim@meyering.net>
8725 * tests/du/no-x: New test, for functionality added to lib/ftw.c.
8726 * tests/du/Makefile.am (TESTS): Add no-x.
8728 2003-01-21 Jim Meyering <jim@meyering.net>
8730 * src/remove.c (remove_entry) [ROOT_CAN_UNLINK_DIRS
8731 && HAVE_STRUCT_DIRENT_D_TYPE]: If a file has d_type == DT_UNKNOWN
8732 it may still be a directory -- or not (e.g., with FreeBSD on an
8733 NFS-mounted file system), so resort to calling lstat to find out.
8734 Based on a patch by Michael van Elst.
8736 * tests/cp/same-file: Don't assume that the file owner username
8737 length is less than 9 in ls output: instead, omit that field
8738 altogether. Reported by, and suggested fix from, Ferdinand.
8740 2003-01-20 Jim Meyering <jim@meyering.net>
8742 * tests/date/Test.pm (wide-fmt): New test to demonstrate that
8743 large format widths no longer cause strftime to infloop.
8745 * Makefile.maint (mail_gpg_sign_cookie): Remove now-unused definition.
8747 2003-01-19 Jim Meyering <jim@meyering.net>
8749 * src/readlink.c: Include "canonicalize.h".
8751 2003-01-18 Jim Meyering <jim@meyering.net>
8753 * src/ls.c (Dereference_symlink) [DEREF_COMMAND_LINE_SYMLINK_TO_DIR]:
8755 (enum) [DEREFERENCE_COMMAND_LINE_SYMLINK_TO_DIR_OPTION]: New member.
8756 (long_options): Add option --dereference-command-line-symlink-to-dir.
8757 (main): Make DEREF_COMMAND_LINE_SYMLINK_TO_DIR be the default,
8758 rather than DEREF_COMMAND_LINE_ARGUMENTS, when none of the
8759 -d, -F, -l options is specified.
8760 (decode_switches): Handle --dereference-command-line-symlink-to-dir.
8761 (gobble_file): Honor DEREF_COMMAND_LINE_SYMLINK_TO_DIR.
8762 Change --dereference-command-line (-H) to dereference *all*
8763 command line arguments, including broken symlinks.
8765 2003-01-15 Paul Eggert <eggert@twinsun.com>
8767 Change ls -H back to the way it was yesterday, since this is
8768 compatible with FreeBSD and the POSIX spec is confusing
8769 and somewhat contradictory.
8771 * src/ls.c (DEREF_COMMAND_LINE_ARGUMENTS): Change name back
8772 from DEREF_COMMAND_LINE_SYMLINK_TO_DIR, updating all uses.
8773 (long_options): Change the long option name back.
8774 (usage): Change the usage back.
8775 (gobble_file): When -H is specified, dereference a top-level
8776 arg even if it points to a non-directory.
8778 2003-01-15 Jim Meyering <jim@meyering.net>
8780 * src/ls.c (gobble_file): Fall back on using lstat when required:
8781 when --dereference (-L) is not specified, and
8782 - when operating on a dangling symlink
8783 - when operating on command-line-symlink-to-directories
8784 This fixes numerous problems. Here are examples:
8785 - `ls dangling-symlink' would fail with `no such file...'
8786 Now it prints `dangling-symlink'.
8787 - `ls -i symlink' would mistakenly print the inode of the referent.
8788 Now it prints the inode of the symlink. Likewise for --size (-s).
8789 Based on a patch from Michael Stone.
8790 Reported by Deepak Goel as Debian bug #173793.
8792 Rename ls's --dereference-command-line (-H)
8793 option to --dereference-command-line-symlink-to-dir.
8794 * src/ls.c [enum Dereference_symlink]
8795 (DEREF_COMMAND_LINE_SYMLINK_TO_DIR): Rename from
8796 DEREF_COMMAND_LINE_ARGUMENTS. Update all uses.
8797 (long_options): Rename the long option.
8798 (usage): Say that --dereference-... changes how ls treats
8799 only symlinks to directories specified on the command line.
8801 2003-01-14 Jim Meyering <jim@meyering.net>
8803 * tests/ls/dangle: New file/test, for the above fix.
8804 * tests/ls/inode: Another new file/test, for the above fix.
8805 * tests/ls/Makefile.am (TESTS): Add dangle and inode.
8807 * src/ls.c (gobble_file): Fix a bug introduced in 4.5.4 that made it
8808 so that ls --color would no longer highlight the names of files with
8809 the execute bit set when not specified on the command line.
8810 Patch by Michael Stone. Reported by Stephen Depooter as
8813 * tests/ls-2/tests (color-exe): New test, for the above fix.
8815 2003-01-13 Jim Meyering <jim@meyering.net>
8817 * tests/shred/exact: Also test for just fixed bug with --zero.
8819 * src/shred.c (long_opts): --zero does not require an argument.
8820 Patch by Michael Stone. Reported by Roland Turner as Debian bug 172019.
8822 2003-01-12 Jim Meyering <jim@meyering.net>
8824 * Makefile.maint (cvs-update): Skip any file with local modifications.
8826 * src/unexpand.c (usage): Document --first-only and mention that
8827 --tabs=N (-t) enables --all (-a). Reported by wiregauze@yahoo.com.
8829 2002-12-01 Dmitry V. Levin <ldv@altlinux.org>
8831 * src/df.c: Include "canonicalize.h".
8832 Use canonicalize_file_name unconditionally.
8834 2003-01-09 Jim Meyering <jim@meyering.net>
8836 * README: Add readlink.
8838 2002-11-30 Dmitry V. Levin <ldv@altlinux.org>
8840 * src/df.c: Include "xgetcwd.h".
8841 * src/pwd.c: Likewise.
8843 2002-11-30 Dmitry V. Levin <ldv@altlinux.org>
8845 * src/shred.c: Remove declaration of xstrdup.
8846 We already get it via xalloc.h which is included via system.h.
8848 2002-08-27 Dmitry V. Levin <ldv@altlinux.org>
8850 New program: readlink.
8852 * src/Makefile.am (bin_PROGRAMS): Add readlink.
8853 * src/readlink.c: New file.
8855 * man/readlink.x: New file.
8856 * man/Makefile.am (dist_man_MANS): Add readlink.1.
8857 (readlink.1): New rule.
8859 2003-01-09 Jim Meyering <jim@meyering.net>
8861 When selecting ranges of byte offsets (as opposed to ranges of fields)
8862 and when --output-delimiter=STRING is specified, output STRING between
8863 ranges of selected bytes.
8864 * src/cut.c (RANGE_START_SENTINEL): Define.
8865 (output_delimiter_specified): New global.
8866 (print_kth): Add parameter. Adjust all callers.
8867 (set_fields): Mark each range-start index with RANGE_START_SENTINEL.
8868 (cut_bytes): When requested, output STRING between ranges of
8870 (main): Make a diagnostic a little clearer.
8871 Based on a patch from Jan Nieuwenhuizen.
8873 * tests/cut/Test.pm: New tests for the above.
8875 * src/cut.c (set_fields): Make code agree with comment:
8876 Don't merge abutting ranges like 4- and 2-3. This makes no
8877 difference currently, but is required to support an upcoming change.
8879 2003-01-07 Jim Meyering <jim@meyering.net>
8881 * src/cut.c (set_fields): Fix typo in comment.
8883 * tests/touch/not-owner: New test, mostly extracted from fail-diag.
8884 * tests/touch/Makefile.am (TESTS): Add not-owner.
8885 * tests/touch/fail-diag: Remove the test for non-owner diagnostic.
8886 Now, this tests only the nonexistent-directory diagnostic.
8887 Suggestion from Michael Stone.
8889 * tests/touch/fail-diag: Fix typo: s/ld/ls/.
8891 2003-01-04 Jim Meyering <jim@meyering.net>
8893 * src/copy.h: Remove use of PARAMS.
8894 * src/remove.h: Likewise.
8895 * src/chown-core.h: Likewise.
8897 rm could be tricked into mistakenly reporting a cycle.
8898 * src/remove.c: [cycle_check_state]: New global.
8899 (remove_cwd_entries): Adapt to new semantics of cycle_check.
8900 (rm): Call cycle_check_init and cycle_check_free for each file.
8901 * tests/rm/cycle (rm): New test, for the above fix.
8902 * tests/rm/Makefile.am (TESTS): Add cycle.
8904 When rm detects a cycle, don't abort the entire command,
8905 but rather just the affected command line argument.
8906 * src/remove.c: Include <setjmp.h>
8907 (struct dirstack_state) [current_arg_jumpbuf]: New member.
8908 (remove_cwd_entries): Call longjmp if we detect a cycle.
8909 (rm): Call setjmp here.
8911 * src/remove.c (cycle_check, is_power_of_two): Remove functions.
8912 Instead, include cycle-check.h and use it.
8914 * src/remove.h (struct dev_ino): Remove declaration.
8916 * src/remove.c (remove_cwd_entries): Fix typos in comment.
8918 Don't include trailing /. in diagnostics about directories.
8919 * src/remove.c (full_filename_): When FILENAME is just `.'
8920 and there is a nonempty directory-name part, don't append `/.'.
8921 * tests/rm/unread2: Remove trailing /. from diagnostic.
8922 * tests/rm/rm2: Likewise.
8924 * src/remove.c (struct dirstack_state): Define.
8925 To be used in place of these file-scoped globals ...
8926 (dir_stack, len_stack, Active_dir): Remove globals.
8927 (ds_init, ds_free): New functions.
8928 (full_filename): Define.
8929 (full_filename_): Rename from full_filename.
8931 Begin to make AD_* functions more generic.
8932 * src/remove.c (AD_push_initial): Don't set status to RM_OK here.
8933 (AD_push): Likewise.
8934 (AD_INIT_OTHER_MEMBERS): Define.
8935 (remove_dir): Define the `status' member manually after each
8936 call to AD_push or AD_push_initial.
8938 * src/Makefile.am (check-misc): New rule, to ensure that no more
8939 S_IS* macro definitions sneak into the code.
8940 (check): Depend on check-misc.
8942 * src/remove.c [S_ISLNK]: Don't define. It's already defined in sys2.h.
8943 * src/du.c (count_entry) [S_ISLNK]: Don't define.
8944 * src/shred.c [S_ISLNK, S_ISFIFO, S_ISSOCK]: Don't define.
8946 2003-01-03 Jim Meyering <jim@meyering.net>
8948 * src/true.c: Add copyright.
8949 (AUTHORS): I suppose I've written it.
8951 * src/Makefile.am (false.c): Make the generated file be read-only.
8953 2003-01-04 Jim Meyering <jim@meyering.net>
8955 * src/ls.c: Include "dev-ino.h".
8956 [struct dev_ino]: Remove declaration.
8958 2003-01-02 Jim Meyering <jim@meyering.net>
8960 * src/cp.c (do_copy): Tweak diagnostic to be consistent with the one
8961 from mv: s/missing file arguments/missing file argument/.
8962 With --target-directory=DIR, cp and mv work with a single file argument.
8963 Reported by Karl Berry.
8965 * tests/rm/isatty: Enable this test.
8967 2002-12-31 Jim Meyering <jim@meyering.net>
8969 * src/remove.c (AD_push_initial): Don't set status to RM_OK here.
8970 (AD_push): Likewise.
8971 (AD_INIT_OTHER_MEMBERS): Define.
8972 (remove_dir): Define the `status' member manually after each
8973 call to AD_push or AD_push_initial.
8975 * src/ls.c [struct dev_ino]: Remove definition.
8976 Include "dev-ino.h" instead.
8978 2002-12-28 Jim Meyering <jim@meyering.net>
8980 * tests/du/Makefile.am (TESTS): Add no-deref.
8981 * tests/du/no-deref: New script.
8983 2002-12-23 Jim Meyering <jim@meyering.net>
8985 * src/remove.c (remove_cwd_entries): Fix typo in comment.
8987 2002-12-21 Jim Meyering <jim@meyering.net>
8989 * announce-gen: Generate MML-formatted announcement.
8990 This makes it a *lot* harder to send stale MD5/SHA1 signatures.
8992 2002-12-20 Jim Meyering <jim@meyering.net>
8994 * src/touch.c (touch): Change the wording of a diagnostic so
8995 that it makes sense both when the file exists and when it doesn't.
8996 Suggestion from Michael Stone.
8998 2002-12-18 Jim Meyering <jim@meyering.net>
9000 * src/stty.c (valid_options): Declare to be static.
9002 2002-12-15 Jim Meyering <jim@meyering.net>
9004 * Makefile.cfg: Remove rules related to generating m4/jm-glibc-io.m4.
9006 * src/chmod.c, src/copy.c, src/copy.h, src/cp-hash.h, src/csplit.c:
9007 * src/date.c, src/expr.c, src/fmt.c, src/id.c, src/install.c:
9008 * src/ls.c, src/od.c, src/pathchk.c, src/pr.c, src/remove.c:
9009 * src/shred.c, src/sort.c, src/stat.c, src/stty.c, src/sum.c:
9010 * src/tee.c, src/test.c: Remove all uses of `PARAMS'.
9012 * src/remove.c (PARAMS): Remove definition.
9013 * src/sys2.h: Likewise.
9015 * src/ls.c, src/stat.c, src/date.c: Remove declaration of nstrftime.
9016 Include strftime.h instead.
9018 2002-12-14 Jim Meyering <jim@meyering.net>
9020 * Makefile.cfg ($(url_dir_list)): Use .../coreutils, not .../fetish.
9022 * src/system.h [! HAVE_DECL_MEMRCHR]: Declare memrchr.
9023 This is necessary at least for Irix6.5 when using c89.
9024 Reported by Nelson Beebe.
9026 * tests/misc/Makefile.am (TESTS): Add cat-tty-eof.
9028 * tests/misc/cat-tty-eof: New test.
9030 * src/mknod.c (usage): Specify how major and minor mode numbers
9031 are interpreted. Report forwarded by Kristin E Thomas.
9032 * src/mknod.c: Remove now-redundant usage-specifying comment.
9034 2002-12-13 Jim Meyering <jim@meyering.net>
9038 * tests/du/trailing-slash: Allow for a directory of size `0'.
9039 That happens at least on file systems of type tmpfs on linux-2.4.18.
9041 * announce-gen: New script to begin replacing the commands
9042 associated with the rule here...
9043 * Makefile.maint (announcement): Invoke announce-gen.
9044 * Makefile.am (EXTRA_DIST): Add announce-gen.
9046 * tests/cp/preserve-2: New file/test, for latest fix.
9047 * tests/cp/Makefile.am (TESTS): Add preserve-2.
9049 2002-12-11 TAKAI Kousuke <takai@vlsi.kuee.kyoto-u.ac.jp>
9051 Fix a bug whereby cp would fail to parse an option like
9052 --preserve=mode,ownership.
9053 * src/cp.c (decode_preserve_arg): Advance `comma' to
9054 point the character following the comma.
9056 2002-12-11 Jim Meyering <jim@meyering.net>
9058 * src/pathchk.c (NEED_PATHCONF_WRAPPER): Undefine before defining,
9059 in case it's already defined.
9061 2002-12-09 Jim Meyering <jim@meyering.net>
9063 * tests/touch/fail-diag: Don't get a test failure if /no exists.
9064 Instead, evoke a framework failure if /no-$$ exists.
9065 Reported by Michael Stone.
9067 2002-12-08 Jim Meyering <jim@meyering.net>
9069 * src/du.c (lstat) [! LSTAT_FOLLOWS_SLASHED_SYMLINK]:
9070 Define to rpl_lstat, so that even on systems like Solaris 5.8,
9071 du honors (per POSIX) the trailing slash on an argument referring
9072 to a symlink-to-directory.
9074 2002-12-06 Jim Meyering <jim@meyering.net>
9076 * Use autoconf-2.57. Regenerate dependent files.
9077 * Use automake-1.7.2. Regenerate dependent files.
9079 * src/ls.c (gobble_file): Also stat the file if it's a
9080 regular file and --indicator-style=classify (aka -F).
9081 Thanks to Ed Santiago for opening my eyes.
9083 * tests/ls/file-type: New file. Test for the above.
9084 A test to contrast ls -F and ls --indicator-style=file-type.
9085 * tests/ls/Makefile.am (TESTS): Add file-type.
9087 2002-12-04 Jim Meyering <jim@meyering.net>
9089 * tests/ls/follow-slink: Make sure the symlink was created.
9090 Richard Dawe reported that `ln -s link link' succeeds, but creates
9091 no file on systems running some version of the DJGPP libc.
9093 2002-12-03 Jim Meyering <jim@meyering.net>
9095 * src/Makefile.am (AUTOMAKE_OPTIONS): Remove definition (to ansi2knr)
9096 since this package no longer panders to K&R compilers.
9098 2002-12-02 Jim Meyering <jim@meyering.net>
9100 * tests/du/slink: Skip this test if `.' is on a non-local file system.
9102 * tests/Fetish.pm (_at_replace): Do the substitution only if there's
9103 something to replace.
9105 2002-12-01 Jim Meyering <jim@meyering.net>
9107 * src/stat.c: Don't include <string.h> or <ctype.h>.
9108 That's already done via system.h.
9109 * src/dircolors.c: Don't include <ctype.h>.
9111 2002-11-30 Jim Meyering <jim@meyering.net>
9113 * ls.c (gobble_file): Remove the block of code that caused
9114 `ls --color -F symlink-to-dir' to list the files in
9115 `symlink-to-dir/.'. Now, it prints `symlink-to-dir@', (just
9116 like `ls -F symlink-to-dir') but with the addition of highlighting.
9117 Similarly, `ls --color -dF symlink-to-dir' would print
9118 `symlink-to-dir/'; now it prints `symlink-to-dir@'.
9119 Reported by Jeff Sheinberg as Debian bug #168203.
9120 * tests/ls-2/tests (sl-F-color, sl-dF-color): New tests for the above.
9122 ls is now more efficient: with certain options, it no longer needs
9123 to stat each directory entry on systems with valid dirent.d_type.
9124 * src/ls.c (print_dir): Add DT_LNK and DT_REG.
9125 (main): Make --recursive set format_needs_type, not format_needs_stat.
9126 (gobble_file): Remove a FIXME comment, now that it's fixed.
9128 2002-11-24 Jim Meyering <jim@meyering.net>
9130 * src/du.c (du_files): Don't strip any trailing slash.
9131 Rewrite so that `/' is no longer represented internally as
9133 (count_entry): When appending a file name component,
9134 account for the fact that the current path may end in `/'.
9135 François Pinard reported that `du symlink-to-dir/' was not
9136 equivalent to `du symlink-to-dir/.'. Now it is.
9137 * tests/du/trailing-slash: New file/test, for the above fix.
9138 * tests/du/Makefile.am (TESTS): Add trailing-slash.
9140 2002-11-23 Jim Meyering <jim@meyering.net>
9142 * src/tac.c (output): Declare some local variables to be of type size_t,
9143 rather than `int' to avoid warnings from gcc.
9145 2002-11-21 Paul Eggert <eggert@twinsun.com>
9147 * src/ls.c (decode_switches): Use case-sensitive matching to
9148 decode the QUOTING_STYLE environment variable. This is more
9149 consistent with the documentation, and with --quoting-style.
9151 2002-11-21 Martin Buck <martin.buck@ascom.ch
9153 * src/stty.c (struct speeds): Add support for all baud rates defined
9156 2002-11-19 Jim Meyering <jim@meyering.net>
9158 * tests/sum/sysv: Export LC_ALL=C, to avoid failure when
9159 run in a UTF locale. Report and suggested fix by Bruno Haible.
9160 * tests/fmt/basic: Likewise.
9162 2002-11-17 Jim Meyering <jim@meyering.net>
9164 * configure.ac: Update via autoupdate.
9165 Add `AM_GNU_GETTEXT_VERSION(0.11.5)'.
9167 * src/mv.c (movefile): Don't remove trailing slashes from SOURCE.
9168 Reported by Hans Ginzel.
9170 2002-11-15 Jim Meyering <jim@meyering.net>
9172 * Makefile.cfg (gnu_rel_host): Define.
9173 (url_dir_list): Choose from (alpha|ftp).gnu.org depending
9174 on whether $(VERSION) looks like a major release number.
9176 * Makefile.maint (mail_gpg_sign_cookie): Backslash-escape `#'.
9177 (release): Rename from `alpha'.
9178 (alpha): Depend on release.
9180 * Makefile.maint (signatures): Define with ?=, so it's easy to override.
9182 2002-11-14 Jim Meyering <jim@meyering.net>
9184 * Makefile.maint (mail_gpg_sign_cookie): Make optional.
9185 (announcement): Use the new variable.
9187 * Makefile.maint: Sync with Bison, i.e.:
9188 (po-check): Scan .l and .y files instead of the
9189 .c and the .h files that they generate. This fixes the bug
9190 reported by Tim Van Holder in:
9191 <http://mail.gnu.org/pipermail/bison-patches/2002-November/001352.html>
9192 Look for N_ as well as for _. Try to avoid matching #define for
9196 2002-11-12 Jim Meyering <jim@meyering.net>
9198 * src/ls.c (HAVE_SYMLINKS): Remove unnecessary macro definition.
9199 Replace sole use with equivalent `#ifdef S_ISLNK'.
9200 Inconsistency reported by Dmitry V. Levin.
9202 2002-11-11 Jim Meyering <jim@meyering.net>
9204 * src/stat.c (usage): Transform --help items output via s/ - / /,
9205 so that help2man produces properly formatted man pages.
9206 Reported by Herbert Xu as Debian bug #168400.
9208 2002-11-10 Jim Meyering <jim@meyering.net>
9210 * src/ls.c (sighandler): Handle SIGTSTP specially.
9211 Based on suggestions from Solar Designer and Dmitry V. Levin.
9214 * Makefile.cfg (cvs_files): Define. From autoconf.
9215 (local_updates): Likewise.
9217 * src/ls.c (restore_default_color_handler, sigtstp_handler):
9219 (sighandler): New function, based on the one in sort.c.
9220 (main): Use sigaction, if possible; otherwise signal.
9221 Handle these signals:
9222 SIGHUP, SIGINT, SIGPIPE, SIGQUIT, SIGTERM, SIGTSTP.
9223 Don't register our handler if the signal is already being ignored.
9225 * src/dd.c (interrupt_handler): Use raise, rather than kill+getpid.
9226 * src/csplit.c (interrupt_handler): Likewise.
9227 * src/sort.c (sighandler): Likewise.
9228 (main): Declare `i' and `nsigs' to be unsigned, not int.
9230 2002-11-09 Jim Meyering <jim@meyering.net>
9232 ls --color: restore terminal text color upon signal.
9233 * src/ls.c: Include "full-write.h" and <signal.h>.
9234 (restore_default_color, restore_default_color_handler): New functions.
9235 (sigtstp_handler, put_indicator_direct): New functions.
9236 (main) [print_with_color]: Register signal handlers.
9237 Patch mostly by Solar Designer and Stanislav Ievlev.
9239 Update from autoconf.
9240 * Makefile.maint (AMTAR): Remove definition.
9241 (update, cvs-update, po-update, do-po-update): New rules.
9242 (wget-update): Update (thus renaming to cvs-update).
9243 (automake_repo): Use anoncvs@sources.redhat.com.
9245 2002-11-06 Jim Meyering <jim@meyering.net>
9247 * tests/misc/Makefile.am (TESTS): Add printf-hex.
9249 * tests/misc/printf: Be careful to test the code in this package,
9250 not the shell built-in function.
9252 * src/printf.c (print_esc): A hexadecimal escape sequence has
9253 at most two hex. digits, not three. Reported by Padraig Brady.
9254 (usage): Update description.
9255 * tests/misc/printf-hex: New file/test, for the above fix.
9257 2002-10-07 Paul Eggert <eggert@twinsun.com>
9259 Add support for locale-specific size indications (e.g.,
9260 thousands-separators) and for explicit size suffixes on output.
9262 * doc/coreutils.texi (Block size): Say that:
9263 This affects display format as well as block size.
9264 Fractional block counts are rounded up.
9265 ls file size blocksize defaults to 1.
9266 A block size spec preceded by ' generates thousands separators.
9267 A suffix without a preceding integer generates suffixes.
9268 (tail invocation): 32k -> 32 KiB.
9269 (What information is listed): ls -h is now equivalent to
9270 ls --block-size=human, and ls -H is now equivalent to
9271 ls --block-size=si. Displayed file size is now always affected by
9274 * lib/inttostr.c, lib/inttostr.h, lib/imaxtostr.c, lib/offtostr.c,
9275 lib/umaxtostr.c: New files, taken from GNU tar.
9277 * lib/Makefile.am (libfetish_a_SOURCES): Add imaxtostr.c, offtostr.c,
9279 (EXTRA_DIST): Add inttostr.c.
9281 * lib/human.c, lib/human.h: Rewrite to support locale-specific
9282 notations like thousands separators.
9283 Specify what includer of include.h must include beforehand.
9284 (human_group_digits, human_suppress_point_zero, human_autoscale,
9285 human_base_1024, human_SI, human_B): New enum values.
9286 (human_readable): Rename from human_readable_inexact; put the
9287 options before the sizes. All uses changed. The old human_readable
9288 function has been removed; use inttostr.h instead.
9289 (human_options): Renamed from human_block_size, with new signature
9290 that allows block sizes up to UINTMAX_MAX. All callers changed.
9292 * m4/prereq.m4 (jm_PREREQ_HUMAN): Check for locale.h, localeconv,
9293 AC_HEADER_STDBOOL. No need to check for limits.h since it's in
9294 freestanding C89. No need to check for stdlib.h or string.h since
9295 autoconf does this now.
9297 * src/cksum.c (cksum): Use primitives from inttostr.h, not
9298 human.h, to print large numbers simply.
9299 * src/csplit.c (handle_line_error, parse_patterns): Likewise.
9300 * src/dd.c (print_stats, main): Likewise.
9301 * src/df.c (print_header): Likewise.
9302 * src/factor.c (print_factors): Likewise.
9303 * src/ls.c (print_long_format, print_file_name_and_frills): Likewise.
9304 * src/shred.c (dopass): Likewise.
9305 * src/sort.c (checkfp): Likewise.
9306 * src/sum.c (bsd_sum_file, sysv_sym_file): Likewise.
9307 * src/tail.c (xlseek): Likewise.
9308 * src/wc.c (write_counts, wc): Likewise.
9310 * src/df.c (human_output_opts): New var.
9311 (output_block_size): Now uintmax_t, not int, to handle larger
9312 block sizes. All uses changed.
9313 * src/du.c: Likewise.
9314 * src/ls.c: Likewise.
9316 * src/df.c (print_header): In the header line, prefer SI to human
9317 representation if it's shorter; if neither is shorter, try to
9318 intuit what the user would prefer.
9320 * src/expr.c (inttostr): Remove; use new imaxtostr library
9323 * src/ls.c (file_output_block_size): New var, to distinguish
9324 file sizes from other sizes.
9325 (decode_switches): Set it.
9327 * src/shred.c (OUTPUT_BLOCK_SIZE): remove.
9328 (dopass): When printing progress, use floor for what has been done
9329 so far (since we should be conservative there), and ceiling for
9330 what needs to be done (since that's what other programs use).
9332 2002-10-19 Jim Meyering <jim@meyering.net>
9334 * src/pinky.c (print_heading): Align TTY and Name headings.
9335 Reported by Karl Eichwalder.
9337 2002-10-18 Jim Meyering <jim@meyering.net>
9339 * src/split.c (cwrite): Change type of `bytes' parameter to size_t
9340 Remove now-useless cast.
9341 (stdread): Remove function.
9342 (bytes_split): Use size_t instead of int.
9343 Use safe_read, not stdread.
9344 (lines_split): Likewise.
9345 Use memchr rather than a `while' loop.
9346 (line_bytes_split): Use size_t instead of int.
9347 Use safe_read, not stdread.
9348 (main): Add some FIXME comments to remind me to remove casts.
9350 * src/system.h (ST_BLKSIZE): Correct comment describing how to
9351 reproduce HPUX-11 cat failure. From Petter Reinholdtsen.
9353 2002-10-17 Jim Meyering <jim@meyering.net>
9355 Fix a problem that could make e.g., `cat' misbehave on systems which
9356 give invalid (unreasonably large) values for stat.st_blksize.
9357 * src/system.h (ST_BLKSIZE): Ensure that the result is in [1..4MB].
9358 Reported by Petter Reinholdtsen.
9360 2002-10-14 Jim Meyering <jim@meyering.net>
9362 Specifying a printf conversion specifer as nl's separator string
9363 could cause nl to segfault.
9364 * src/nl.c (build_print_fmt): Don't include separator string
9365 in the printf format; it might contain `%'.
9366 Use a better bound on the length of the print_fmt buffer.
9367 (print_lineno): Print the separator here instead.
9368 Reported by Doug Coleman.
9370 * tests/misc/nl: New file/tests, including a test for the above.
9371 * tests/misc/Makefile.am (TESTS): Add nl.
9373 * tests/misc/split-l: New test, to make sure `split --lines=N' works.
9374 * tests/misc/Makefile.am (TESTS): Add split-l.
9376 2002-10-13 Jim Meyering <jim@meyering.net>
9380 * src/du.c (usage): Tweak description of --dereference-args/-D.
9382 * src/du.c (count_entry): Also save cwd when dereferencing (via
9383 --dereference-args, -D) a command-line argument.
9384 Reported by Michal Svec. Based on a patch by Andreas Schwab.
9386 * src/Makefile.am (../AUTHORS): New target/rule.
9388 2002-10-12 Jim Meyering <jim@meyering.net>
9390 * src/paste.c (paste_parallel): Declare local, `delims_saved', to be
9391 of type size_t, since that's the way it's used and avoids a warning.
9393 * src/csplit.c (struct cstring) [len]: Declare to be unsigned int,
9394 since that's how it's always used and avoids a new warning from gcc.
9395 (read_input): Adapt to new safe_read ABI.
9397 * src/cut.c (cut_fields): Add a temporary size_t variable, n_bytes,
9400 * src/pinky.c (print_long_entry): fread returns size_t.
9401 Declare local `bytes' accordingly, to avoid warning.
9403 tail -c +N would perform an extra read after encountering EOF
9404 [this change is analogous (bytes vs. lines) to the one of 2002-01-27]
9405 * src/tail.c (start_bytes): Detect EOF, inform caller.
9406 (tail_bytes): Upon EOF in start_bytes, return immediately.
9407 (file_lines): Reorganize to use memrchr rather than an explicit loop.
9408 Adapt to new safe_read ABI.
9410 2002-10-11 Jim Meyering <jim@meyering.net>
9412 * tests/du/deref: New file/test, for the above fix.
9413 * tests/du/Makefile.am (TESTS): Add deref.
9415 2002-10-10 Jim Meyering <jim@meyering.net>
9417 * tests/ln/Makefile.am (TESTS): Add target-1.
9418 * tests/ln/target-1: New file/test, for the fix on 2002-10-08.
9420 2002-10-09 Jim Meyering <jim@meyering.net>
9422 * tests/cp/backup-is-src: Ensure that certain environment variables
9423 are not set (e.g., SIMPLE_BACKUP_SUFFIX). Reported by Duncan Roe.
9425 * tests/tail-2/big-4gb: Mark this as an expensive test; it would
9426 consume 4GB of disk space on systems without support for sparse files.
9427 Fix a logic error that'd make it `cat err' even though dd didn't fail.
9429 * src/dircolors.hin (.jar): Fix typo: s/;3$/;31/.
9430 Patch by steven@magelico.net, forwarded by Michael Stone.
9432 * tests/ls/dired: Ensure that ls produces English messages.
9433 Patch by Alexey Vyskubov, forwarded by Michael Stone.
9435 2002-10-08 Dmitry V. Levin <ldv@altlinux.org>
9437 * src/ln.c (main): Fix target_directory parsing when n_files == 1.
9439 2002-10-08 Jim Meyering <jim@meyering.net>
9441 * tests/tail-2/big-4gb: Use double quotes around diagnostic.
9442 Fix syntax in test: use =, not ==.
9443 Reported by Bob Proulx.
9444 Change all the rest like this: grep -lR "testing framework'" .\
9445 |xargs perl -pi -e 's/'\''(\$0: failure in testing framework)'\''/"$1"/'
9447 * src/sum.c (sysv_sum_file): Adapt to new safe_read ABI.
9448 * src/tr.c (squeeze_filter, read_and_delete, read_and_xlate): Likewise.
9449 * src/tac.c (save_stdin, tac_stdin_to_mem): Likewise.
9450 * src/wc.c (wc): Likewise.
9452 2002-10-07 Paul Eggert <eggert@twinsun.com>
9455 Don't advance the write pointer past the end of the write buffer.
9456 * src/sort.c (begfield, limfield): Likewise.
9458 2002-10-07 Jim Meyering <jim@meyering.net>
9460 * src/cat.c (simple_cat, cat): Adapt to new safe_read ABI.
9461 * src/head.c (head_bytes, head_lines): Likewise.
9463 2002-10-06 Jim Meyering <jim@meyering.net>
9465 * src/dd.c (scanargs): Ensure that specified block sizes (specified
9466 via ibs=N, obs=N, and bs=N) are no larger than SSIZE_MAX.
9467 (skip, dd_copy): Adapt to new safe_read ABI.
9469 * Makefile.maint (signatures): Define.
9471 (announcement): Depend on $(signatures).
9473 * Makefile.maint (announcement): Output all URLs for detached
9474 signatures, not just the last one from the previous loop.
9476 2002-10-05 Jim Meyering <jim@meyering.net>
9480 * src/remove.c (remove_entry) [ROOT_CAN_UNLINK_DIRS]: With `rm -i DIR',
9481 don't recurse into directory, DIR. Prompted by a report from
9484 * tests/rm/i-no-r: New file/test, for the above fix.
9485 * tests/rm/Makefile.am (TESTS): Add i-no-r.
9487 * tests/tail-2/big-4gb: New file/test, for the fix of 2002-09-27.
9488 * tests/tail-2/Makefile.am (TESTS): Add big-4gb.
9490 2002-10-03 Jim Meyering <jim@meyering.net>
9492 * src/rm.c (AUTHORS): Mark translatable string with `N_ (...)'.
9493 * src/df.c (AUTHORS): Likewise.
9494 * src/du.c (AUTHORS): Likewise.
9495 * src/tail.c (AUTHORS): Likewise.
9496 * src/touch.c (AUTHORS): Likewise.
9498 2002-10-02 Jim Meyering <jim@meyering.net>
9500 * Makefile.am (SUBDIRS): Remove `old'.
9501 (EXTRA_DIST): List the files in old/.
9502 * configure.ac (AC_CONFIG_FILES): Remove old/* names.
9503 Suggestion from Akim Demaille.
9505 2002-10-01 Jim Meyering <jim@meyering.net>
9507 * src/sys2.h (SSIZE_MAX): Define.
9509 2002-09-30 Jim Meyering <jim@meyering.net>
9511 * src/csplit.c: Don't include stdlib.h here. It's already included
9514 2002-09-29 Jim Meyering <jim@meyering.net>
9516 * src/tr.c (find_bracketed_repeat): Rearrange pointer/integer
9517 expression to avoid bogus warning from gcc.
9519 * src/cat.c (simple_cat): Use a temporary to avoid bogus warnings.
9520 (cat): Declare insize and outsize to be of type size_t, not int.
9521 Rearrange pointer/integer expressions to avoid bogus warnings.
9522 (main): Declare insize and outsize to be of type size_t, not int.
9524 * src/tail.c (parse_options): Give a sensible diagnostic for
9525 an invalid byte or line count. Reported by Mikko Tuumanen.
9527 * src/touch.c (main): Split a long line.
9529 * tests/du/Makefile.am (TESTS): Add slink.
9530 * tests/du/slink: New test for system.h change of 2002-08-31.
9532 In move mode, always first try to rename. Before, upon failure to
9533 rename a directory, this code would never attempt to rename any
9534 other file in that directory, but would thenceforth always copy.
9535 On some systems (e.g., NetApp's OnTap-6.4), renaming a directory
9536 may fail with EXDEV, yet renaming files within that directory to
9537 a newly-created destination directory succeeds.
9538 * src/copy.c (copy_internal): Remove local, move_mode;
9539 use x->move_mode instead. Based on a patch from Tom Haynes.
9541 2002-09-28 Jim Meyering <jim@meyering.net>
9543 * src/split.c (FAIL_ONLY_ONE_WAY): New macro.
9544 Factor out some duplication.
9546 [case 'a']: Use strtoul rather than strtol to avoid compiler warnings.
9548 * src/sort.c (begfield, limfield): Rearrange comparisons to avoid
9550 (fillbuf, keycompare): Cast literal `-1' to size_t in comparisons,
9551 to avoid compiler warnings.
9553 * src/shred.c (dopass): Use a uintmax_t temporary to avoid bogus
9556 Fix things so `mkdir -p' can create very deep directories, e.g.,
9557 mkdir -p $(perl -e 'print "a/" x 40000') now works.
9558 * src/mkdir.c (main): For --parents (-p), call make_path with the
9559 entire directory name, so we don't ever require that file operations
9560 like stat or chmod be performed on the entire command line argument.
9561 * makepath.c (make_path): Restore umask *before* creating the final
9564 2002-09-27 Andreas Schwab <schwab@suse.de>
9566 * src/tail.c (tail_bytes): Change type of bytes_remaining to off_t
9567 to avoid overflow. Reported by Hans Lermen.
9569 2002-09-26 Jim Meyering <jim@meyering.net>
9571 * src/install.c (get_ids): Use strtoul, not strtol. Remove some casts.
9573 2002-09-25 Jim Meyering <jim@meyering.net>
9575 * src/test.c (eaccess): Change type of local `euid' from int to uid_t
9576 and add a cast, to avoid a warning about `signed and unsigned type in
9577 conditional expression'.
9579 2002-09-22 Jim Meyering <jim@meyering.net>
9581 * src/rmdir.c: Include "dirname.h", for declaration of
9582 strip_trailing_slashes.
9584 * src/stat.c (PRIdMAX, PRIuMAX): Remove definitions.
9585 Now they're defined through system.h.
9587 * src/cp-hash.c, src/dd.c, src/df.c, src/du.c, src/ls.c,
9588 * src/stat.c, src/wc.c: Remove all inclusions of inttypes.h,
9589 since it's already included from sys2.h via system.h.
9591 * Use automake-1.6f. Regenerate dependent files.
9593 * src/Makefile.am (PERL): Remove duplicate definition.
9595 fmt's -s, -t, -c options didn't work properly for long lines.
9596 Since get_line may end up calling put_paragraph (for long lines),
9597 be sure to set global, `other_indent', before it is used there.
9599 * src/fmt.c (set_other_indent): New function, factored out of...
9600 (get_paragraph): ... here. Call it.
9601 (get_line): Call set_other_indent before calling flush_paragraph,
9602 which calls fmt_paragraph, which in turn calls put_paragraph,
9603 which uses other_indent.
9605 * tests/fmt/Makefile.am (TESTS): Add long-line.
9606 * tests/fmt/long-line: New file/test, for the above fix.
9608 2002-09-21 Jim Meyering <jim@meyering.net>
9610 * src/od.c: No longer include deprecated <values.h>.
9611 It was required solely for now-removed reference to BITSPERBYTE.
9612 * src/install.c: Likewise.
9613 Suggestion from Bruno Haible.
9615 2002-09-06 Andreas Schwab <schwab@suse.de>
9617 `rmdir -p dir-specified-with-trailing-slash/' would fail.
9618 * src/rmdir.c (remove_parents): Strip trailing slashes.
9620 2002-09-20 Jim Meyering <jim@meyering.net>
9622 * tests/rmdir/t-slash: New file/test, for the above fix.
9623 * tests/rmdir/Makefile.am (TESTS): Add t-slash.
9625 * Makefile.maint (announcement): Arrange to gpg-sign the message.
9626 Add a URL for each detached signature file.
9628 2002-09-07 Bruno Haible <bruno@clisp.org>
9630 * configure.ac: Add need-ngettext to AM_GNU_GETTEXT invocation.
9632 2002-09-18 Jim Meyering <jim@meyering.net>
9634 `od -t x8' used the wrong (`l'-prefixed) printf format.
9635 Likewise for the o8 and u8 formats.
9636 * src/od.c (ISPEC_TO_FORMAT): Define macro.
9637 (decode_one_format): Use PRIdMAX, PRIoMAX, etc. for LONG_LONG.
9638 Reported by Arun Sharma.
9640 2002-09-17 Jim Meyering <jim@meyering.net>
9642 * src/sys2.h (PRIdMAX, PRIoMAX, PRIuMAX, PRIxMAX): Define if necessary.
9643 From gettext's intl/loadmsgcat.c.
9645 * tests/od/x8: New file/test, for the above fix.
9646 * tests/od/Makefile.am (TESTS): Add x8.
9648 2002-09-15 Jim Meyering <jim@meyering.net>
9650 * Use autoconf-2.54. Regenerate dependent files.
9652 * src/csplit.c (get_format_width): Add cast to avoid
9653 warning about `signed and unsigned type in conditional expression'.
9655 2002-09-14 Jim Meyering <jim@meyering.net>
9657 * src/who.c (print_user): Change type of local to size_t
9658 to avoid warnings about `comparison between signed and unsigned'.
9659 * src/ptx.c (generate_all_output): Likewise.
9661 * src/dd.c (main, skip): Add casts to avoid warnings about
9662 `comparison between signed and unsigned'.
9664 * src/id.c (print_full_info, print_group_list): Add casts to avoid
9665 warnings about `signed and unsigned type in conditional expression'.
9667 * src/md5sum.c: Change type of global, digest_hex_bytes, to size_t
9668 to avoid warnings about `comparison between signed and unsigned'.
9669 (split_3): Change parameter names to be readable and add comment.
9670 Clean up the test for whether a line may be ignored.
9672 2002-09-13 Jim Meyering <jim@meyering.net>
9674 * src/printf.c (main): Handle leading command line argument of `--'.
9675 Reported by Raul: DervishD <raul@pleyades.net>
9676 * tests/misc/printf: New file: test for the above.
9677 * tests/misc/Makefile.am (TESTS): Add printf.
9679 * src/date.c (usage): Explain that %S's range of [0..60] is required --
9680 rather than 0..59 -- to accommodate the occasional positive leap second.
9681 Reported by Richard Neill.
9683 2002-09-12 Jim Meyering <jim@meyering.net>
9685 * src/Makefile.am (nanosec_libs): Define.
9686 (sleep_LDADD, tail_LDADD): Use it here.
9688 Factor nanosleep-related code into ../lib/xnanosleep.c.
9689 * src/sleep.c: Include xnanosleep.h.
9690 Factor out fenv.h-related code.
9691 (timespec_subtract): Remove function.
9692 (main): Remove code that deals with computing start and stop times
9693 as well as the loop around nanosleep. Now that's in xnanosleep.c.
9695 Allow S (in --sleep-interval=S) to be a floating point value.
9696 * src/tail.c: Include xnanosleep.h and xstrtod.h.
9697 Move declaration of global variable, sleep_interval, to ...
9699 (usage): Update description of --sleep-interval option.
9700 (tail_forever): New parameter, sleep_interval. Update caller.
9701 Use xnanosleep, rather than sleep.
9702 (parse_options): New parameter, sleep_interval. Update caller.
9703 Use xstrtod, now that we accept floating point values.
9704 Prompted by a patch from Augey Mikus.
9706 2002-09-06 Jim Meyering <jim@meyering.net>
9708 * src/remove.c (prompt): Change comment to give a better note to
9709 translators. From Michael Piefel.
9711 2002-09-02 Jim Meyering <jim@meyering.net>
9713 * README: A good problem report/patch includes diffs against
9714 the most recent test release.
9716 * src/pathchk.c (NEED_PATHCONF_WRAPPER): Define.
9717 (pathconf_wrapper): Define only if NEED_PATHCONF_WRAPPER is set.
9719 * src/kill.c (print_table_row): Use an unsigned type for widths
9720 to avoid warning about comparison between signed and unsigned.
9721 (list_signals): Likewise.
9723 * src/od.c (skip): Add a cast to avoid warning about comparison
9724 between signed and unsigned.
9725 * src/install.c (get_ids): Likewise. Also rearrange range-checking
9726 comparisons to make them more readable.
9728 2002-09-01 Jim Meyering <jim@meyering.net>
9732 2002-08-31 Jim Meyering <jim@meyering.net>
9734 Symlinks were always reported as using 0 blocks.
9735 * src/system.h (ST_NBLOCKS): Don't depend on file type.
9736 This reverts the change of 2000-01-30.
9737 Based on a report and patch from Neil Brown via Michael Stone.
9738 This fixes Debian Bug#156358.
9740 * Most files: Change `exit (0)' to `exit (EXIT_SUCCESS)',
9741 `exit (1)' to `exit (EXIT_FAILURE)', and
9742 `usage (1)' to `usage (EXIT_FAILURE)'.
9744 * chgrp.c, chmod.c, chown.c, chroot.c, cp.c, date.c, dd.c, du.c,
9745 * hostname.c, id.c, install.c, ln.c, mkdir.c, mkfifo.c, mknod.c,
9746 * nice.c, pinky.c, printf.c, pwd.c, shred.c, sleep.c, stty.c,
9747 * su.c, tac-pipe.c, tail.c, tee.c, touch.c, uname.c, uptime.c,
9748 * users.c, who.c: Change `error (1, ...' to `error (EXIT_FAILURE, ...'.
9749 But don't change `error (0, ...' to `error (EXIT_SUCCESS, ...', since
9750 error never exits successfully.
9752 2002-08-29 Jim Meyering <jim@meyering.net>
9754 * src/remove.c (remove_cwd_entries): Use closedir (not CLOSEDIR)
9755 when ignoring any return value.
9757 * src/remove.c (remove_cwd_entries): Detect and diagnose readdir
9758 failures. On some systems (at least EMC Celerra and Solaris5.8),
9759 this appears to be necessary.
9760 (is_empty_dir): Likewise. Also, always close directory handle.
9761 * src/ls.c (print_dir): Likewise.
9762 (print_dir): Rename local variable: reading -> dirp.
9763 Reported by Mike Coleman.
9765 2002-08-28 Jim Meyering <jim@meyering.net>
9767 * src/remove.c (remove_cwd_entries): Use CLOSEDIR, not closedir.
9768 Give a diagnostic and fail if closedir fails.
9770 2002-08-26 Jim Meyering <jim@meyering.net>
9772 * Makefile.am (THANKS-to-translators): New rule.
9773 (EXTRA_DIST): Add both THANKS-to-translators and THANKStt.in.
9774 * THANKStt.in: New file.
9776 * src/cat.c (close_stdout_wrapper): New, kludgey, function and
9778 (main): Register it with atexit.
9779 Close STDOUT_FILENO, to avoid a problem when writing to
9780 /dev/audio on at least Solaris 5.7 and 5.8 systems.
9781 Reported by Shing-Shong Shei.
9783 2002-08-25 Jim Meyering <jim@meyering.net>
9785 * src/cat.c (main): Close STDIN_FILENO rather than a literal `0'.
9786 * src/tac.c (main): Likewise.
9787 * src/tail.c (main): Likewise.
9788 * src/tee.c (main): Likewise.
9789 * src/tr.c (main): Likewise.
9790 * src/wc.c (main): Likewise.
9792 2002-08-20 Jim Meyering <jim@meyering.net>
9794 * tests/mv/setup: Rewrite not to use `: ${VAR=not_set}' paradigm.
9796 2002-08-10 Paul Eggert <eggert@twinsun.com>
9798 * src/nohup.sh: Don't use "exec --"; it's not portable and
9799 shouldn't be needed.
9801 2002-08-09 Jim Meyering <jim@meyering.net>
9803 * src/pr.c (main): Don't ignore -COLUMN if it's the last option.
9804 (usage): Clarify help text for the -COLUMN option.
9805 Patch by Padraig Brady.
9806 * tests/pr/Test.pm [col-last]: New test for the above.
9808 * configure.ac: Start with version 4.5.1, chosen so that it's larger
9809 than the latest version numbers of the component packages.
9811 * man/Makefile.am (check-x-vs-1): Set and export PATH so we use
9814 2002-08-08 Jim Meyering <jim@meyering.net>
9816 * src/date.c: Guard inclusion of <langinfo.h> with
9817 `#if HAVE_LANGINFO_CODESET', not `#if HAVE_LANGINFO_H'.
9818 * src/sort.c: Likewise.
9819 Patch by GOTO Masanori.
9821 2002-08-05 Paul Eggert <eggert@twinsun.com>
9823 Fix some minor time-related bugs with POSIX time arguments.
9824 Some valid time stamps were being rejected (notably -1, and
9825 time stamps before 1900 on 64-bit hosts). And some invalid
9826 time stamps were being accepted, e.g. September 31.
9828 * src/date.c (main): Adjust to posixtime signature change.
9829 * src/touch.c (main): Likewise. Remove unnecessary initialization.
9830 Use localtime, not posixtm, to warn about obsolete "touch".
9832 2002-08-05 Jim Meyering <jim@meyering.net>
9834 * tests/misc/Makefile.am (TESTS): Add nice and pathchk1.
9836 2002-08-04 Jim Meyering <jim@meyering.net>
9838 * src/Makefile.am (check-README): New target/rule.
9839 (check): Depend on it.
9841 * configure.ac (AC_CONFIG_FILES): Add old/Makefile and old/*/Makefile.
9843 2002-08-03 Jim Meyering <jim@meyering.net>
9845 * Makefile.am (SUBDIRS): Add old.
9846 * old/: New directory, containing legacy ChangeLog* and NEWS files
9847 from the fileutils, sh-utils, and textutils packages.
9849 * src/Makefile.am (AM_INSTALLCHECK_STD_OPTIONS_EXEMPT): Set to false.
9851 2002-08-02 Paul Eggert <eggert@twinsun.com>
9853 * NEWS, doc/coreutils.texi: uniq now obeys LC_COLLATE.
9855 * src/uniq.c: Include hard-locale.h, xmemcoll.h.
9856 (hard_LC_COLLATE): New var.
9857 (different): Args are now char *, not const char *.
9858 Use xmemcoll instead of memcmp to compare lines, so that
9859 LC_COLLATE has effect. However, use memcmp if it is an
9861 (check_file): Do not include newline in comparison, so that
9862 xmemcoll has a byte to stomp on temporarily.
9863 (main): Set hard_LC_COLLATE.
9865 2002-07-29 Jim Meyering <jim@meyering.net>
9867 * Makefile.am (SUBDIRS): Remove djgpp, for now.
9869 2002-07-20 Jim Meyering <jim@meyering.net>
9871 * Makefile.am (false.c): Convert only the final EXIT_SUCCESS
9872 into EXIT_FAILURE. Otherwise, false --help and false --version
9875 2002-07-08 Jim Meyering <jim@meyering.net>
9877 * src/Makefile.am (uninstall-local): Search for @GNU_PACKAGE@,
9878 rather than the hard-coded `sh-utils'.
9880 2002-07-01 Jim Meyering <jim@meyering.net>
9882 * configure.ac: Merge the three files from fileutils,
9883 textutils, and sh-utils.
9884 * Makefile.am: Likewise.
9885 * src/Makefile.am: Likewise.
projects / platform / upstream / coreutils.git / blob