1 2003-04-10 Alexander Larsson <alexl@redhat.com>
6 Added files to cvsignore
9 * dbus/dbus-message.c: (dbus_message_iter_get_named):
10 Make get_named() take two out argument and return a boolean.
11 (dbus_message_iter_get_args_valist):
12 Update usage of get_named().
13 (dbus_message_iter_append_byte):
15 (dbus_message_iter_append_named)
17 (message_iter_test), (check_message_handling_type), (_dbus_message_test):
20 2003-04-10 Alexander Larsson <alexl@redhat.com>
22 * dbus/dbus-marshal.[ch]:
23 Add array_type_pos argument to _dbus_marshal_validate_arg.
24 Let you pass a NULL end_pos to _dbus_marshal_validate_type.
26 * dbus/dbus-message.[ch]:
27 Multi-dimensional arrays have full type specification in the
28 outermost array. Iter code re-arranged to handle this.
29 Added some more iter tests.
31 * doc/dbus-specification.sgml:
34 Update new array encoding description.
35 Correct DBUS_SERVICE_FLAGS_REPLACE_EXISTING description.
37 * test/data/invalid-messages/array-with-mixed-types.message:
38 * test/data/valid-messages/array-of-array-of-uint32.message:
39 Change to the new array format.
41 * test/data/invalid-messages/too-short-dict.message:
44 * test/data/valid-messages/recursive-types.message:
45 Fix up and extend test.
47 2003-04-10 Havoc Pennington <hp@pobox.com>
49 * bus/dispatch.c: lots of fixes
51 * dbus/dbus-mainloop.c (_dbus_loop_dispatch): export
52 (_dbus_loop_iterate): remove old "quit if no callbacks" code,
53 that was crack, broke the test service.
55 * dbus/dbus-transport.c (_dbus_transport_open): fix error
56 handling to avoid piling up errors if we get a failure on the
59 * dbus/dbus-internals.c (_dbus_real_assert_not_reached): include
60 pid in assertion failures.
62 * dbus/dbus-mainloop.c (_dbus_loop_iterate): use static arrays up
63 to some fixed size of file descriptor array. Don't return TRUE
64 anytime a timeout exists, that led to lots of busy loop silliness
67 2003-04-09 Havoc Pennington <hp@redhat.com>
69 * dbus/dbus-mainloop.c (check_timeout): fix timeouts, I thought
70 I'd checked this in earlier but hadn't.
72 2003-04-09 Havoc Pennington <hp@redhat.com>
74 * bus/dispatch.c (bus_dispatch_test): get a bit further through
75 the activation test (man this is getting old!)
77 2003-04-09 Havoc Pennington <hp@redhat.com>
79 * test/test-utils.c: use dispatch status function to fix this up
81 * bus/connection.c (connection_watch_callback): don't dispatch
83 (connection_timeout_callback): don't dispatch from here
84 (bus_connections_setup_connection): set the dispatch status function
85 (bus_connection_disconnected): unset it
87 * dbus/dbus-mainloop.c (_dbus_loop_queue_dispatch): new function
88 used to add a connection to be dispatched
89 (_dbus_loop_iterate): do the dispatching at the end of each
92 * dbus/dbus-connection.c
93 (dbus_connection_set_dispatch_status_function): new function
94 allowing us to fix up main loop usage
95 (_dbus_connection_last_unref): free all the various function
97 (dbus_connection_dispatch): call the DispatchStatusFunction
98 whenever this function returns
99 (dbus_connection_handle_watch): call DispatchStatusFunction
100 (dbus_connection_send_with_reply_and_block): call DispatchStatusFunction
101 (reply_handler_timeout): call DispatchStatusFunction
102 (dbus_connection_flush): call DispatchStatusFunction
104 2003-04-09 Havoc Pennington <hp@redhat.com>
106 * dbus/dbus-bus.c (dbus_bus_register): fix up error handling and
109 * bus/dispatch.c (check_service_activated): fix bug in test
111 * dbus/dbus-mainloop.c (check_timeout): fix this up
113 * dbus/dbus-internals.c (_dbus_verbose_real): include PID in
114 verbose output so we can sort out output from different processes,
115 e.g. in the activation case.
117 2003-04-08 Colin Walters <walters@gnu.org>
119 * bus/bus.c (struct BusContext) [pidfile]: New member, to store
121 (bus_context_new): Set it.
122 (bus_context_unref): Use it to delete the pid file.
124 2003-04-08 Havoc Pennington <hp@redhat.com>
126 * test/data/invalid-messages/array-with-mixed-types.message:
127 regression test that fails for the moment
129 * dbus/dbus-test.c (dbus_internal_do_not_use_run_tests): reorder
130 tests for convenience
132 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): don't allow
133 array of nil, it broke things.
135 * test/data/invalid-messages/array-of-nil.message: regression test
137 * test/data/valid-messages/array-of-array-of-uint32.message:
138 happened to write this so added it to suite
140 2003-04-08 Havoc Pennington <hp@redhat.com>
142 * bus/driver.c (bus_driver_handle_acquire_service): init
143 retval/reply before checking name
145 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): add a
146 recursion depth argument
148 * dbus/dbus-message.h (struct DBusMessageIter): put some padding
149 in the public struct for future extension
151 * dbus/dbus-message-builder.c (_dbus_message_data_load): fix
154 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): fix a verbose
157 * doc/dbus-specification.sgml: fix typo
159 2003-04-08 Alexander Larsson <alexl@redhat.com>
161 Implemented recursive types, named types and new-style iters
164 * glib/test-thread-client.c: (thread_func):
165 * glib/test-thread-server.c: (handle_test_message):
166 * test/test-service.c: (handle_echo):
175 * dbus/dbus-internals.c: (_dbus_type_to_string):
176 Update for new types.
178 * dbus/dbus-marshal.[ch]:
179 Implement recursive types and the new marshalling format.
180 Remove hardcoded dict marshalling.
183 * dbus/dbus-message-builder.c:
185 Remove references to old types
187 * dbus/dbus-message.[ch]:
188 New non-refcounted iter API that supports recursive iters.
189 Use iters for appending, including support for recursive
191 Add byte and named type support.
192 Update everything to new marshalling formats.
193 Add tests for new API.
195 * dbus/dbus-protocol.h:
196 Remove old array types.
197 Add types: BYTE, ARRAY, DICT, NAMED
199 * dbus/dbus-string.c:
200 * dbus/dbus-sysdeps.c:
201 Make parse_double locale safe.
203 * dbus/dbus-test-main.c:
209 * doc/dbus-specification.sgml:
212 * test/data/incomplete-messages/missing-body.message:
213 * test/data/invalid-messages/bad-boolean.message:
214 * test/data/invalid-messages/bad-boolean-array.message:
215 * test/data/invalid-messages/boolean-array-length-too-long.message-raw:
216 * test/data/invalid-messages/boolean-has-no-value.message-raw:
217 * test/data/invalid-messages/too-short-dict.message:
218 * test/data/valid-messages/dict-simple.message:
219 * test/data/valid-messages/dict.message:
220 * test/data/valid-messages/emptiness.message:
221 * test/data/valid-messages/lots-of-arguments.message:
222 * test/data/valid-messages/no-padding.message:
223 * test/data/valid-messages/recursive-types.message:
224 Add missing NAME fields
225 Fix up dicts & arrays
227 * test/data/invalid-messages/dict-with-nil-value.message:
228 Removed, this is not invalid anymore.
230 * test/data/valid-messages/recursive-types.message:
231 Add new test for deeply recursive types.
233 2003-04-07 Havoc Pennington <hp@pobox.com>
235 * bus/driver.c (bus_driver_handle_acquire_service): return an
236 error if you try to acquire a service that starts with ':'
238 2003-04-07 Havoc Pennington <hp@redhat.com>
240 * doc/dbus-specification.sgml: require that base service names
241 start with ':' and that the base service is created/deleted
242 as first and last things a connection does on the bus
244 * bus/dispatch.c (check_existent_service_activation): lots more
245 work on the activation test; it doesn't fully pass yet...
247 * test/test-service.c (main): fix so we don't memleak the
248 connection to the message bus
249 (filter_func): accept a message asking us to exit
251 2003-04-06 Havoc Pennington <hp@pobox.com>
253 * qt/Makefile.am (dbusinclude_HEADERS): install dbus-qt.h,
256 * configure.in: fixes to Qt detection from Colin Walters
258 * doc/Makefile.am: Only remove generated docbook dirs if they
259 exist, from Colin Walters
261 * dbus/dbus-bus.c: change how we set well-known connections to
262 NULL, so that it works if a single connection is stored in
263 two well-known array slots.
265 * test/Makefile.am: remove a lot of stuff that isn't immediately
266 useful, it's in CVS history if we want it.
268 * test/test-service.c: use dbus-mainloop instead of that
271 2003-04-06 Havoc Pennington <hp@pobox.com>
273 * dbus/Makefile.am: split lists of sources into stuff that goes in
274 the library, util functions that go in the lib and are also used
275 elsewhere, and util functions that are used in tests/daemon but
278 * dbus/dbus-mainloop.h, dbus/dbus-mainloop.c: move bus/loop.[hc]
279 here so it can be used in test binaries also
281 2003-04-06 Havoc Pennington <hp@pobox.com>
283 * dbus/dbus-sysdeps.c (_dbus_become_daemon): write the pidfile
284 here in the parent process, so we can return an error if it
285 fails. Also, move some of the code into the child so the parent
286 is less hosed if we fail midway through.
288 * bus/bus.c (bus_context_new): move pidfile detection further up
289 in the function, before we start overwriting sockets and such.
291 * bus/messagebus.in: adjust this a bit, not sure if it will work.
293 * configure.in: add --with-system-pid-file and --with-system-socket
295 2003-04-06 Colin Walters <walters@verbum.org>
297 * configure.in (DBUS_SYSTEM_PID_FILE): New variable.
299 * bus/system.conf.in: Declare a pidfile.
301 * bus/bus.c (bus_context_new): Test for an existing pid file, and
302 create one (if appropriate).
304 * bus/config-parser.c (enum ElementType) [ELEMENT_PIDFILE]: New.
305 (struct BusConfigParser) [pidfile]: New.
306 (element_type_to_name, merge_included, start_busconfig_child)
307 (bus_config_parser_end_element, bus_config_parser_content): Handle it.
308 (bus_config_parser_unref): Free it.
309 (bus_config_parser_get_pidfile): New function.
311 * bus/config-parser.h (_dbus_write_pid_file): Prototype.
313 * dbus/dbus-errors.h (DBUS_ERROR_PIDFILE_EXISTS): New error.
315 * dbus/dbus-sysdeps.c (_dbus_write_pid_file): New function.
317 * dbus/dbus-sysdeps.h: Prototype it.
319 2003-04-06 Havoc Pennington <hp@pobox.com>
321 * bus/bus.c (bus_context_new): print the address in here, rather
322 than in main(), because we need to do it before forking the daemon
324 * bus/dispatch.c (send_service_nonexistent_error): set the sender
325 on the service nonexistent error
327 * bus/driver.c (bus_driver_handle_acquire_service): set the
328 sender on the AcquireService reply
330 * test/data/valid-config-files/debug-allow-all.conf.in: Make test
331 server also listen on a UNIX socket so services can connect to it.
333 2003-04-06 Havoc Pennington <hp@pobox.com>
335 * dbus/dbus-threads.c: Redo how the fake debug mutexes are done
336 so it detects deadlocks and also we actually init threads when
339 2003-04-06 Havoc Pennington <hp@pobox.com>
341 * dbus/dbus-server-unix.c (_dbus_server_new_for_domain_socket):
342 save the domain socket name, and unlink it when we disconnect the
343 server. Means that at least when we exit normally, we won't leave
344 a bunch of junk in /tmp
346 * dbus/dbus-transport-unix.c
347 (_dbus_transport_new_for_domain_socket): code cleanup (nicer
348 memory management). (I was making a real change here but then
351 2003-04-06 Havoc Pennington <hp@pobox.com>
353 * bus/bus.c (bus_context_new): fix wrong handling of
354 server_data_slot_unref() in the error case.
356 * dbus/dbus-internals.h (_dbus_assert): change so it passes
357 "(condition) != 0" to _dbus_real_assert so that
358 "_dbus_assert (pointer)" doesn't cause a warning
360 * bus/main.c (main): accept --print-address option to print out
361 the message bus address
363 * dbus/dbus-sysdeps.c (_dbus_generate_random_ascii): export this
365 * dbus/dbus-transport.c (_dbus_transport_open): special error for
366 "tmpdir" option to unix: address on client side
368 * dbus/dbus-server.c (dbus_server_listen): handle "tmpdir" option
371 * configure.in (TEST_SOCKET_DIR): locate a temporary directory
372 we can use to create sockets in the test suite.
374 * bus/main.c (signal_handler): on SIGTERM, exit the daemon
375 cleanly. To be used for testing.
377 * dbus/dbus-spawn.c (babysit): use _dbus_set_signal_handler()
379 * dbus/dbus-sysdeps.c (_dbus_set_signal_handler): new
381 * dbus/dbus-server-debug-pipe.c (_dbus_transport_debug_pipe_new):
382 handle trying to call this when there's no servers active
384 2003-04-05 Havoc Pennington <hp@pobox.com>
390 2003-04-05 Havoc Pennington <hp@pobox.com>
392 * bus/bus.c (setup_server): fix this so dbus-daemon-1 doesn't
393 crash on startup. Need to get "try starting the daemon"
394 in the test suite I guess. ;-)
396 * dbus/dbus-server.h, dbus/dbus-server.c: remove the stuff that
397 tracked the number of open connections; it's better done in
398 application-specific code as you want it to span all servers etc.
400 2003-04-05 Havoc Pennington <hp@pobox.com>
402 * bus/Makefile.am (install-data-hook): add missing DESTDIR,
403 patch from Colin Walters
405 2003-04-05 Havoc Pennington <hp@pobox.com>
407 * doc/config-file.txt (Elements): fix docs of <auth> to reflect
408 reality; in fact multiple mechanisms are allowed.
410 * dbus/dbus-internals.c (_dbus_real_assert)
411 (_dbus_real_assert_not_reached): move guts of _dbus_assert() and
412 _dbus_assert_not_reached() into functions, so that they don't show
413 up in basic block counts for test coverage, and don't use up as
414 much disk space. Does mean slower execution speed though, so
415 assumes --disable-asserts is the normal production case.
417 2003-04-05 Havoc Pennington <hp@pobox.com>
419 * test/Makefile.am (dist-hook): also dist *.in files
425 2003-04-05 Havoc Pennington <hp@pobox.com>
427 * dbus/dbus-string.c: docs warning
429 * dbus/dbus-spawn.c: missing docs
431 * dbus/dbus-memory.c (struct ShutdownClosure): missing docs
433 2003-04-05 Havoc Pennington <hp@pobox.com>
435 * bus/loop.c (bus_loop_iterate): fix the timeout code, using
438 * dbus/dbus-spawn.c (_dbus_babysitter_unref): set sitter_pid
439 to -1 once we've reaped the babysitter
440 (_dbus_babysitter_handle_watch): do as much work as we can, not
443 * bus/activation.c: add code using DBusBabysitter so that we
444 handle it when a service fails to start up properly.
445 (bus_activation_service_created): don't remove the activation
446 entries as we go, just let them get removed when we free the pending
447 activation. Unref reply messages after sending them.
449 2003-04-05 Havoc Pennington <hp@pobox.com>
451 * test/decode-gcov.c (main): print per-directory stats in the report
453 * Makefile.am (coverage-report.txt): don't include test/* in gcov stats
455 2003-04-05 Havoc Pennington <hp@pobox.com>
457 * Makefile.am (coverage-report.txt): add target "coverage-report.txt"
459 * test/decode-gcov.c: hack up a little program to suck data
460 out of gcov files. Yes this is sort of silly.
462 * configure.in: define something in config.h and do an
463 AM_CONDITIONAL when gcov is enabled
465 2003-04-04 Havoc Pennington <hp@redhat.com>
467 * dbus/dbus-spawn.c, dbus/dbus-spawn.h: Change dbus_spawn to
468 return a "babysitter" object that is used to monitor the status of
469 the spawned process and reap it when required.
471 * test/test-segfault.c, test/test-exit.c,
472 test/test-sleep-forever.c: binaries that do various lame things,
473 used in the test suite.
475 * dbus/dbus-sysdeps.c: kill _dbus_errno_to_string()
477 2003-04-03 Havoc Pennington <hp@pobox.com>
479 * dbus/dbus-spawn.c: Move dbus-spawn into a separate file
480 in preparation for modifying it, dbus-sysdeps is getting
483 2003-04-03 Havoc Pennington <hp@redhat.com>
485 * bus/loop.h, bus/loop.c: make the mainloop an object so we can
488 * bus/*.[hc]: adapt to mainloop change
490 2003-04-03 Havoc Pennington <hp@redhat.com>
492 * bus/activation.c (load_directory): fix up memleaks
493 (bus_activation_entry_free): free the entry
495 * dbus/dbus-bus.c (dbus_bus_acquire_service): return an error if
496 we get one from the message bus; fix memleaks.
498 * dbus/dbus-message.c (dbus_set_error_from_message): new function
500 2003-04-03 Havoc Pennington <hp@pobox.com>
502 * bus/config-parser.c (bus_config_parser_unref): free
503 list of mechanisms, bug discovered by test suite enhancements
504 (putting system.conf and session.conf into suite)
506 * test/Makefile.am, test/test-service.c: add placeholder for a
507 test service that we'll activate as part of test suite. Doesn't
510 * dbus/dbus-sysdeps.c (_dbus_setenv): support unsetenv by
511 setting NULL value, and use system malloc not dbus_malloc()
512 when we have unavoidable memleakage.
514 * dbus/dbus-bus.c (dbus_bus_get): fix bug where bus type of 0
515 didn't work, and support DBUS_BUS_ACTIVATION.
517 * bus/activation.c (child_setup): pass our well-known bus type to
520 * bus/config-parser.c: support <type> to specify well-known type
522 * doc/dbus-specification.sgml: document the env variables to
523 locate well-known buses and find service activator
525 2003-04-02 Havoc Pennington <hp@redhat.com>
527 * test/Makefile.am (all-local): add a rule to copy tests to
528 builddir, so we can have generated tests. Use this to remove the
529 silly hack for testing system.conf and session.conf. Will use this
530 shortly to generate .service files pointing to test binaries.
532 2003-04-02 Havoc Pennington <hp@redhat.com>
534 * dbus/dbus-string.c (set_length): fix a bug - we allocated max of
535 current alloc and needed new length, not max of the doubled
536 allocation and needed new length. Also, when building tests,
537 don't do the double-allocation stuff, just realloc every time.
539 2003-04-02 Havoc Pennington <hp@redhat.com>
541 * dbus/dbus-sysdeps.c (_dbus_file_get_contents): include filenames
543 (_dbus_string_get_dirname): new
544 (_dbus_sysdeps_test): new
545 (_dbus_directory_open): include dirnames in error messages
547 * bus/config-parser.c: interpret <include> and <includedir> and
548 <servicedir> relative to config file location if the given
549 filename is not absolute.
551 * dbus/dbus-string.c (_dbus_string_find_byte_backward): new
553 2003-04-02 Havoc Pennington <hp@redhat.com>
555 * bus/connection.c (bus_transaction_send_error_reply): set sender
556 service for the error, and unref the reply on success
558 * bus/activation.c: convert to use BusTransaction so OOM can be
560 (bus_activation_service_created): set sender of the message
562 2003-04-01 Havoc Pennington <hp@redhat.com>
564 * bus/config-parser.c, bus/bus.c: implement <servicedir> and
565 <includedir> (at least mostly)
567 * dbus/dbus-sysdeps.c (_dbus_change_identity): set the group ID
568 first, then the user ID
570 2003-04-01 Havoc Pennington <hp@pobox.com>
572 * dbus/dbus-server.c (dbus_server_set_auth_mechanisms): new
575 * dbus/dbus-auth.c (_dbus_auth_set_mechanisms): new
577 * dbus/dbus-internals.c (_dbus_dup_string_array): new function
579 * dbus/dbus-sysdeps.c (_dbus_listen_unix_socket): chmod the
580 socket 0777, and unlink any existing socket.
582 * bus/bus.c (bus_context_new): change our UID/GID and fork if
583 the configuration file so specifies; set up auth mechanism
586 * bus/config-parser.c (bus_config_parser_content): add support
587 for <fork> option and fill in code for <auth>
589 * bus/system.conf.in: add <fork/> to default configuration,
590 and limit auth mechanisms to EXTERNAL
592 * doc/config-file.txt (Elements): add <fork>
594 * dbus/dbus-sysdeps.c (_dbus_become_daemon): new function
595 (_dbus_change_identity): new function
597 2003-03-31 Havoc Pennington <hp@redhat.com>
599 * dbus/dbus-sysdeps.c (_dbus_connect_unix_socket)
600 (_dbus_listen_unix_socket): fix off-by-one error in null
601 termination spotted by Nalin
603 2003-03-31 Havoc Pennington <hp@redhat.com>
605 * dbus/dbus-keyring.c (_dbus_keyring_new_homedir): allow setting
606 DBUS_TEST_HOMEDIR when tests are enabled, so we can test without
607 having a real home directory available.
609 2003-03-31 Havoc Pennington <hp@redhat.com>
611 * bus/Makefile.am (install-data-hook): create /var/run/dbus
613 * bus/messagebus.in: add init script for Red Hat /etc/init.d
615 * configure.in: add support for specifying a style of init script
618 2003-03-31 Havoc Pennington <hp@redhat.com>
620 Fix some annoying DBusString API and fix all affected code.
622 * dbus/dbus-string.c (_dbus_string_init): get rid of annoying
624 (_dbus_string_get_data): change to return string instead of using
626 (_dbus_string_get_const_data): ditto
627 (_dbus_string_get_data_len): ditto
628 (_dbus_string_get_const_data_len): ditto
630 2003-03-31 Havoc Pennington <hp@redhat.com>
632 * bus/main.c (main): fix up the command line arguments to be nicer
634 2003-03-31 Havoc Pennington <hp@redhat.com>
636 * dbus/Makefile.am (INCLUDES): use EXPANDED_LOCALSTATEDIR to
637 define DBUS_SYSTEM_BUS_PATH as we want to compile in the same
638 final location that lands in the config file
640 * bus/config-loader-expat.c (bus_config_load): fix type of
643 * doc/TODO: remove TODO item for dbus_bus_get()
645 * dbus/dbus-bus.c (bus_data_free): add missing lock/unlock
647 2003-03-31 Havoc Pennington <hp@pobox.com>
649 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_domain_socket)
650 (_dbus_transport_new_for_tcp_socket): these didn't need the "server"
651 argument since they are always client side
653 * dbus/dbus-server.c (dbus_server_get_address): new function
655 * bus/main.c (main): take the configuration file as an argument.
657 * test/data/valid-config-files/debug-allow-all.conf: new file to
658 use with dispatch.c tests for example
660 * bus/test-main.c (main): require test data dir
662 * bus/bus.c (bus_context_new): change this to take a
663 configuration file name as argument
665 * doc/config-file.txt (Elements): add <servicedir>
667 * bus/system.conf, bus/session.conf: new files
669 * dbus/dbus-bus.c (dbus_bus_get): look for system bus on
670 well-known socket if none set
672 * configure.in: create system.conf and session.conf
674 2003-03-30 Havoc Pennington <hp@pobox.com>
676 * bus/config-parser.c: hacking
678 * dbus/dbus-memory.c: don't use DBusList for the list of stuff
679 to shut down, since it could cause weirdness with the DBusList
682 * dbus/dbus-list.c (_dbus_list_test): add tests for the
683 link-oriented stack routines
684 (alloc_link): free the mempool if the first alloc from it fails
686 * dbus/dbus-mempool.c (struct DBusMemBlock): fix alignment issue
688 * dbus/dbus-string.c (UNICODE_VALID): sync new version of this
690 (_dbus_string_skip_white): new
692 * doc/config-file.txt (Elements): add <includedir>
694 2003-03-28 Havoc Pennington <hp@pobox.com>
696 * dbus/dbus-string.c (_dbus_string_copy_data_len)
697 (_dbus_string_copy_data): new functions
699 2003-03-28 Anders Carlsson <andersca@codefactory.se>
701 * dbus/dbus-bus.c: (bus_data_free), (dbus_bus_get):
705 * dbus/dbus-memory.c:
708 2003-03-28 Havoc Pennington <hp@pobox.com>
710 * bus/test.c (bus_test_flush_bus): remove the sleep from here,
711 I think it may have just been superstition. Not sure.
713 * dbus/dbus-string.c (_dbus_string_base64_decode): catch some OOM
714 failures that were not being handled.
716 * dbus/dbus-auth.c (process_auth): fix a memleak in OOM handling
718 * dbus/dbus-memory.c: add ability to set number of mallocs in a
719 row that will fail on out-of-memory.
721 * dbus/dbus-internals.c (_dbus_test_oom_handling): convenience
722 function for testing out-of-memory handling.
724 * bus/config-loader-expat.c (memsuite): don't wrap the dbus
725 allocation functions, they do map exactly to the expat ones.
727 2003-03-27 Havoc Pennington <hp@redhat.com>
729 * bus/config-loader-libxml.c (bus_config_load): add another error
732 2003-03-26 Anders Carlsson <andersca@codefactory.se>
735 Add note about automatic service activation.
737 * doc/dbus-specification.sgml:
738 Rename the specification and clarify a few things.
740 2003-03-26 Anders Carlsson <andersca@codefactory.se>
743 * dbus/dbus-address.c:
745 * dbus/dbus-marshal.c:
746 * dbus/dbus-server-debug-pipe.c:
747 * dbus/dbus-transport-unix.c:
748 Fix documentation warnings.
750 2003-03-26 Havoc Pennington <hp@pobox.com>
752 * bus/test-main.c, dbus/dbus-test.c (main): check memleaks
753 after every test so it's quick and easy to see which leaked, and
754 so we test multiple dbus_shutdown() calls
756 * configure.in: change configure.in XML stuff to also support
759 * config-loader-libxml.c: some hacking
761 * config-loader-expat.c: some hacking
763 * config-parser.c: some hacking, plus tests
765 2003-03-25 Havoc Pennington <hp@redhat.com>
767 * throughout - add more _DBUS_ASSERT_ERROR_IS_CLEAR
769 * configure.in: add --with-xml option to specify XML library,
770 right now only libxml is supported.
772 * bus/config-loader-libxml.c, config-parser.c: sync some minor
773 nonworking code between home and work, still just stubs
775 2003-03-24 Havoc Pennington <hp@redhat.com>
777 * dbus/dbus-sysdeps.c (_dbus_set_fd_nonblocking): move to this
780 * dbus/dbus-errors.c (dbus_set_error, dbus_set_error_const): allow
781 NULL argument for "message" if the error is a well-known one,
782 fill in a generic message in this case.
784 * dbus/dbus-errors.h (DBusResultCode): Kill DBusResultCode in
787 * bus/test.c (bus_test_flush_bus): add
789 * bus/policy.c (bus_policy_test): test code stub
791 2003-03-24 Havoc Pennington <hp@pobox.com>
793 * bus/connection.c (bus_connections_setup_connection): set up
794 the "can this user connect" function, but it always returns
795 TRUE until we have a config file parser so we can have a config
796 file that allows connections.
798 2003-03-23 Havoc Pennington <hp@pobox.com>
800 * dbus/dbus-threads.c (dbus_mutex_new, dbus_condvar_new): with
801 DBUS_BUILD_TESTS, actually alloc/free a block of memory for
802 the mutex, so we can check for proper memory management
805 * dbus/dbus-dataslot.c: remove the mutex from
806 DBusDataSlotAllocator and lock it manually when using it,
807 to simplify fitting it into the global slots framework.
809 * dbus/dbus-threads.c (init_static_locks): rework how we're
810 handling global locks so they are easily shut down.
812 * bus/policy.c (bus_policy_append_rule): fix
814 * bus/test-main.c (main): check for memleaks
816 * dbus/dbus-test.c (dbus_internal_do_not_use_run_tests): make
817 test suite check for memleaks
819 * dbus/dbus-memory.c: add support in test mode for tracking
820 number of outstanding blocks
822 2003-03-23 Havoc Pennington <hp@pobox.com>
824 * bus/policy.c, bus/bus.c, bus/connection.c: implement allow/deny
827 * dbus/dbus-hash.h: add ULONG hash keys
829 * dbus/dbus-sysdeps.c (_dbus_get_groups): new
830 (_dbus_get_group_id): new function
832 2003-03-20 Havoc Pennington <hp@redhat.com>
834 * dbus/dbus-connection.c (dbus_connection_set_unix_user_function):
836 (dbus_connection_get_unix_user): new function
838 2003-03-20 Havoc Pennington <hp@pobox.com>
840 * bus/connection.c (bus_connection_send_oom_error): assert that
842 (connection_execute_transaction): ditto
843 (bus_connection_preallocate_oom_error): fix to set the sender, and
844 set recipient to the destination service, not the bus driver
846 * bus/policy.c: hacking
848 * dbus/dbus-message.c (dbus_message_service_is): new function
849 (dbus_message_sender_is): new
851 2003-03-19 Havoc Pennington <hp@redhat.com>
853 * bus/policy.c: start sketching code for policy restrictions on
854 what connections can do.
856 2003-03-18 Havoc Pennington <hp@redhat.com>
858 * doc/TODO: some notes on high-level todo items. Little nitpick
859 stuff is all in @todo, so no need to add it here.
861 * doc/config-file.txt: some notes on how config file might look
863 2003-03-18 Anders Carlsson <andersca@codefactory.se>
869 2003-03-17 Havoc Pennington <hp@redhat.com>
871 * dbus/dbus-internals.h: add gcc attributes so that
872 our printf-style functions warn on bad arguments to
875 * dbus/dbus-sysdeps.c (_dbus_connect_tcp_socket): fix printf
878 * dbus/dbus-message.c (_dbus_message_loader_queue_messages): fix
881 2003-03-17 Havoc Pennington <hp@redhat.com>
883 * bus/test-main.c (main): make it print something as it runs
884 so make check doesn't look stuck
886 * doc/negotiation.txt, doc/dbus-sasl-profile.txt: remove
887 from CVS, now obsolete
889 2003-03-17 Anders Carlsson <andersca@codefactory.se>
891 * bus/dispatch.c: (bus_dispatch):
892 Refetch the service name since it may have been reallocated
893 when dbus_message_set_sender was called.
895 * dbus/dbus-sysdeps.c: (_dbus_accept):
896 Add address and address length variables and use them to stop
897 valgrind from complaining.
899 2003-03-17 Havoc Pennington <hp@pobox.com>
901 All tests pass, no memleaks, no valgrind complaints.
903 * bus/test.c: refcount handler_slot
905 * bus/connection.c (bus_connections_new): refcount
908 * dbus/dbus-auth-script.c (_dbus_auth_script_run): delete unused
909 bytes so that auth scripts pass.
911 * bus/dispatch.c: init message_handler_slot so it gets allocated
914 * bus/dispatch.c (message_handler_slot_ref): fix memleak
916 * dbus/dbus-server-debug-pipe.c (_dbus_server_debug_pipe_new):
917 dealloc server_pipe_hash when no longer used for benefit of
920 * dbus/dbus-auth.c (process_command): memleak fix
922 * bus/dispatch.c (check_hello_message): memleak fix
924 2003-03-16 Havoc Pennington <hp@pobox.com>
926 * dbus/dbus-bus.c (ensure_bus_data): fix double-unref of the data slot
928 2003-03-17 Anders Carlsson <andersca@codefactory.se>
930 * bus/activation.c (bus_activation_activate_service): Append
931 the pending activation entry to the list of pending activations.
933 2003-03-16 Havoc Pennington <hp@pobox.com>
935 * bus/dispatch.c (bus_dispatch_test): remove double-unrefs of
938 * dbus/dbus-address.c (create_entry): fix OOM handling when
939 failing to alloc entry->method
941 2003-03-16 Havoc Pennington <hp@pobox.com>
943 * dbus/dbus-watch.c (_dbus_watch_new): handle failure to malloc
946 * dbus/dbus-server-debug-pipe.c (_dbus_transport_debug_pipe_new):
947 add some missing dbus_set_result
949 * bus/dispatch.c (bus_dispatch_add_connection): handle failure to
950 alloc the DBusMessageHandler
952 * dbus/dbus-transport.c (_dbus_transport_disconnect): don't ref
953 the transport here, since we call this from the finalizer; it
954 resulted in a double-finalize.
956 * dbus/dbus-transport.c (_dbus_transport_disconnect): fix a bug
957 where we tried to use transport->connection that was NULL,
958 happened when transport was disconnected early on due to OOM
960 * bus/*.c: adapt to handle OOM for watches/timeouts
962 * dbus/dbus-transport-unix.c: port to handle OOM during
965 * dbus/dbus-auth.c (_dbus_auth_get_unused_bytes): return a
966 reference to unused bytes instead of a copy
968 * dbus/dbus-server.c (dbus_server_handle_watch): return FALSE for
971 * dbus/dbus-connection.c (dbus_connection_handle_watch): return
974 * dbus/dbus-timeout.c (dbus_timeout_handle): return FALSE for out
977 2003-03-16 Anders Carlsson <andersca@codefactory.se>
979 * doc/dbus-specification.sgml:
980 Document reply message for ActivateService.
982 2003-03-16 Anders Carlsson <andersca@codefactory.se>
984 * bus/activation.c: (bus_pending_activation_entry_free),
985 (bus_pending_activation_free), (bus_activation_new),
986 (bus_activation_unref), (bus_activation_service_created),
987 (bus_activation_activate_service):
989 * bus/bus.c: (bus_context_new):
990 * bus/desktop-file.c: (new_section):
991 * bus/driver.c: (bus_driver_send_service_deleted),
992 (bus_driver_handle_activate_service):
993 * bus/services.c: (bus_registry_new), (bus_registry_ensure):
995 * dbus/dbus-connection.c:
996 (dbus_connection_send_with_reply_and_block):
997 * dbus/dbus-message.c: (dbus_message_append_args_valist):
998 * dbus/dbus-protocol.h:
999 Make activation work better. Now pending activations will be queued
1000 and the daemon won't try to activate services that are already registered.
1002 2003-03-16 Havoc Pennington <hp@pobox.com>
1004 * dbus/dbus-bus.c (ensure_bus_data): handle failure to set
1007 * dbus/dbus-memory.c (_dbus_initialize_malloc_debug): support
1008 DBUS_MALLOC_BACKTRACES to print trace when failing an alloc
1010 2003-03-16 Havoc Pennington <hp@pobox.com>
1012 * dbus/dbus-string.c (_dbus_string_validate_utf8): oops, unbreak
1013 this. always run the test suite before commit...
1015 * bus/*: adapt to DBusConnection API changes
1017 * glib/dbus-gmain.c: adapt to DBusConnection API changes,
1018 requires renaming stuff to avoid dbus_connection_dispatch name
1021 * dbus/dbus-transport.c (_dbus_transport_queue_messages): new
1024 * dbus/dbus-message.c (_dbus_message_loader_queue_messages):
1025 separate from _dbus_message_loader_return_buffer()
1027 * dbus/dbus-connection.c (dbus_connection_get_n_messages): remove
1028 this, because it's now always broken to use; the number of
1029 messages in queue vs. the number still buffered by the message
1030 loader is undefined/meaningless. Should use
1031 dbus_connection_get_dispatch_state().
1032 (dbus_connection_dispatch): rename from
1033 dbus_connection_dispatch_message
1035 2003-03-16 Havoc Pennington <hp@pobox.com>
1037 * dbus/dbus-string.c (_dbus_string_validate_utf8): copy in a real
1040 2003-03-16 Anders Carlsson <andersca@codefactory.se>
1042 * dbus/dbus-connection.c:
1043 (dbus_connection_send_with_reply_and_block):
1044 Decrease connection->n_incoming when removing an entry
1046 * dbus/dbus-dict.c: (dbus_dict_entry_free),
1047 (dbus_dict_set_boolean_array), (dbus_dict_set_int32_array),
1048 (dbus_dict_set_uint32_array), (dbus_dict_set_double_array),
1049 (dbus_dict_set_byte_array), (dbus_dict_set_string_array),
1050 (dbus_dict_get_boolean_array), (dbus_dict_get_double_array),
1051 (dbus_dict_get_byte_array):
1052 Handle NULL arrays and strings. Also add support for byte arrays.
1054 * dbus/dbus-marshal.c: (_dbus_marshal_byte_array),
1055 (_dbus_marshal_dict), (_dbus_demarshal_byte_array),
1056 (_dbus_demarshal_int32_array), (_dbus_demarshal_uint32_array),
1057 (_dbus_demarshal_double_array), (_dbus_demarshal_string_array),
1058 (_dbus_demarshal_dict), (demarshal_and_validate_len),
1059 (_dbus_marshal_validate_arg), (_dbus_marshal_test):
1060 * dbus/dbus-marshal.h:
1061 Add support for marshalling and demarshalling empty arrays and strings.
1063 * dbus/dbus-message.c: (dbus_message_append_args_valist),
1064 (dbus_message_append_string_array),
1065 (dbus_message_iter_get_boolean),
1066 (dbus_message_iter_get_boolean_array),
1067 (dbus_message_iter_get_int32_array),
1068 (dbus_message_iter_get_uint32_array),
1069 (dbus_message_iter_get_double_array),
1070 (dbus_message_iter_get_byte_array),
1071 (dbus_message_iter_get_string_array), (dbus_message_iter_get_dict),
1072 (check_message_handling):
1073 Add support for getting empty arrays and dicts.
1075 * dbus/dbus-string.c: (_dbus_string_validate_utf8):
1076 Don't do any validation at all for now, that's better than just checking
1079 * test/data/valid-messages/emptiness.message:
1080 New test message with lots of empty arrays.
1082 2003-03-16 Havoc Pennington <hp@pobox.com>
1084 * dbus/dbus-connection.c
1085 (_dbus_connection_queue_received_message_link): new function that
1086 can't fail due to OOM
1088 * dbus/dbus-message.c (_dbus_message_loader_pop_message_link):
1089 new function pops a message together with a list link
1092 * dbus/dbus-transport-unix.c (queue_messages): use new link-based
1093 message queuing functions to avoid needing to alloc memory
1095 2003-03-16 Havoc Pennington <hp@pobox.com>
1097 Oops - test code was only testing failure of around 30 of the
1098 mallocs in the test path, but it turns out there are 500+
1099 mallocs. I believe this was due to misguided linking setup such
1100 that there was one copy of dbus_malloc etc. in the daemon and one
1101 in the shared lib, and only daemon mallocs were tested. In any
1102 case, the test case now tests all 500+ mallocs, and doesn't pass
1103 yet, though there are lots of fixes in this patch.
1105 * dbus/dbus-connection.c (dbus_connection_dispatch_message): fix
1106 this so that it doesn't need to allocate memory, since it
1107 has no way of indicating failure due to OOM (and would be
1108 annoying if it did).
1110 * dbus/dbus-list.c (_dbus_list_pop_first_link): new function
1112 * bus/Makefile.am: rearrange to create two self-contained
1113 libraries, to avoid having libraries with overlapping symbols.
1114 that was resulting in weirdness, e.g. I'm pretty sure there
1115 were two copies of global static variables.
1117 * dbus/dbus-internals.c: move the malloc debug stuff to
1120 * dbus/dbus-list.c (free_link): free list mempool if it becomes
1123 * dbus/dbus-memory.c (_dbus_disable_mem_pools): new function
1125 * dbus/dbus-address.c (dbus_parse_address): free list nodes
1128 * bus/dispatch.c (bus_dispatch_add_connection): free
1129 message_handler_slot when no longer using it, so
1130 memory leak checkers are happy for the test suite.
1132 * dbus/dbus-server-debug-pipe.c (debug_finalize): free server name
1134 * bus/bus.c (new_connection_callback): disconnect in here if
1135 bus_connections_setup_connection fails.
1137 * bus/connection.c (bus_connections_unref): fix to free the
1139 (bus_connections_setup_connection): if this fails, don't
1140 disconnect the connection, just be sure there are no side
1143 * dbus/dbus-string.c (undo_alignment): unbreak this
1145 * dbus/dbus-auth.c (_dbus_auth_unref): free some stuff we were
1147 (_dbus_auth_new): fix the order in which we free strings
1150 * bus/connection.c (bus_connection_disconnected): fix to
1151 not send ServiceDeleted multiple times in case of memory
1154 * dbus/dbus-bus.c (dbus_bus_get_base_service): new function to
1155 get the base service name
1156 (dbus_bus_register_client): don't return base service name,
1157 instead store it on the DBusConnection and have an accessor
1159 (dbus_bus_register_client): rename dbus_bus_register()
1161 * bus/dispatch.c (check_hello_message): verify that other
1162 connections on the bus also got the correct results, not
1163 just the one sending hello
1165 2003-03-15 Havoc Pennington <hp@pobox.com>
1167 Make it pass the Hello handling test including all OOM codepaths.
1168 Now to do other messages...
1170 * bus/services.c (bus_service_remove_owner): fix crash when
1171 removing owner from an empty list of owners
1172 (bus_registry_ensure): don't leave service in the list of
1173 a connection's owned services if we fail to put the service
1176 * bus/connection.c (bus_connection_preallocate_oom_error): set
1177 error flag on the OOM error.
1179 * dbus/dbus-connection.c (_dbus_connection_new_for_transport):
1180 handle _dbus_transport_set_connection failure
1182 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_fd): modify
1183 to create watches up front and simply enable/disable them as
1185 (unix_connection_set): this can now fail on OOM
1187 * dbus/dbus-timeout.c, dbus/dbus-watch.c: add concept
1188 of enabling/disabling a watch or timeout.
1190 * bus/loop.c (bus_loop_iterate): don't touch disabled
1193 * glib/dbus-gmain.c: adapt to enable/disable watches and timeouts
1195 2003-03-15 Havoc Pennington <hp@pobox.com>
1197 * bus/dispatch.c (bus_dispatch_test): OK, now finally actually
1198 write useful test code, after all that futzing around ;-)
1200 Test does not yet pass because we can't handle OOM in
1201 _dbus_transport_messages_pending (basically,
1202 dbus_connection_preallocate_send() does not prealloc the write
1203 watch). To fix this, I think we need to add new stuff to
1204 set_watch_functions, namely a SetEnabled function so we can alloc
1205 the watch earlier, then enable it later.
1207 * dbus/Makefile.am (libdbus_convenience_la_SOURCES): move
1208 dbus-memory.c to the convenience lib
1210 * bus/test.c: rename some static functions to keep them clearly
1211 distinct from stuff in connection.c. Handle client disconnection.
1213 2003-03-14 Havoc Pennington <hp@pobox.com>
1215 * bus/dispatch.c (bus_dispatch_test): do test using debug-pipe
1216 transport, tests more of the real codepath. Set up clients
1217 with bus_setup_debug_client.
1219 * bus/test.c (bus_setup_debug_client): function to set up debug
1220 "clients" on the main loop
1222 * dbus/dbus-transport.c (_dbus_transport_open): add debug-pipe
1225 * dbus/dbus-server.c (dbus_server_listen): add debug-pipe
1228 * dbus/dbus-server-debug.c: support a debug server based on pipes
1230 * dbus/dbus-sysdeps.c (_dbus_full_duplex_pipe): new function
1231 (_dbus_close): new function
1233 * configure.in: check for socketpair
1235 2003-03-14 Havoc Pennington <hp@redhat.com>
1237 * dbus/dbus-memory.c: add a "detect buffer overwrites on free"
1240 * dbus/dbus-transport-debug.c: rework this a good bit to be
1241 less complicated. hopefully still works.
1243 * dbus/dbus-server-debug.c (handle_new_client): remove timeout
1246 * glib/dbus-gmain.c (timeout_handler): don't remove timeout
1249 * dbus/dbus-message.c (dbus_message_copy): rename from
1250 dbus_message_new_from_message, fix it up to copy
1251 all the message fields, add test case
1253 * bus/dispatch.c (bus_dispatch_test): add some more test code,
1254 not quite passing yet
1256 2003-03-14 Havoc Pennington <hp@pobox.com>
1258 * bus/loop.c (bus_loop_iterate): add this so we can "run loop
1259 until no work remains" in test code. (the large diff here
1260 is just code movement, no actual changes)
1262 * dbus/dbus-server-debug.c (DEFAULT_INTERVAL): change interval to
1263 1, no point waiting around for test code.
1264 (_dbus_server_debug_accept_transport): unref the timeout
1265 after adding it (right?)
1267 * dbus/dbus-transport-debug.c (DEFAULT_INTERVAL): ditto
1269 2003-03-13 Havoc Pennington <hp@redhat.com>
1271 * dbus/dbus-timeout.c (_dbus_timeout_list_set_functions): handle
1274 * dbus/dbus-watch.c (_dbus_watch_list_set_functions): handle out
1277 * dbus/dbus-connection.h: Make AddWatchFunction and
1278 AddTimeoutFunction return a bool so they can fail on out-of-memory
1280 * bus/bus.c (bus_context_new): set up timeout handlers
1282 * bus/connection.c (bus_connections_setup_connection): set up
1285 * glib/dbus-gmain.c: adapt to the fact that set_functions stuff
1288 * bus/bus.c (bus_context_new): adapt to changes
1290 * bus/connection.c: adapt to changes
1292 * test/watch.c: adapt to DBusWatch changes
1294 * bus/dispatch.c (bus_dispatch_test): started adding this but
1297 2003-03-14 Anders Carlsson <andersca@codefactory.se>
1299 * bus/dispatch.c (send_service_nonexistent_error): Fix typo.
1301 2003-03-13 Havoc Pennington <hp@pobox.com>
1303 * bus/test.c, bus/test.h, bus/Makefile.am, bus/test-main.c:
1304 set up a test framework as for the library
1306 2003-03-12 Havoc Pennington <hp@pobox.com>
1308 Throughout: purge global variables, introduce BusActivation,
1309 BusConnections, BusRegistry, etc. objects instead.
1311 * bus/bus.h, bus/bus.c: introduce BusContext as a global
1314 * test/Makefile.am (TEST_BINARIES): disable bus-test for now,
1315 going to redo this a bit differently I think
1317 2003-03-12 Havoc Pennington <hp@redhat.com>
1319 Mega-patch that gets the message bus daemon initially handling
1320 out-of-memory. Work still needed. Also lots of random
1321 moving stuff to DBusError instead of ResultCode.
1323 * dbus/dbus-list.c (_dbus_list_length_is_one): new function
1325 * dbus/dbus-connection.c
1326 (dbus_connection_send_with_reply_and_block): use DBusError
1328 * dbus/dbus-bus.c: adapt to API changes, make it use DBusError not
1331 * dbus/dbus-connection.c (dbus_connection_send): drop the result
1332 code here, as the only failure possible is OOM.
1334 * bus/connection.c (bus_connection_disconnect):
1335 rename bus_connection_disconnected as it's a notification only
1337 * bus/driver.c (bus_driver_handle_acquire_service): don't free
1338 "name" on get_args failure, should be done by get_args;
1339 don't disconnect client for bad args, just return an error.
1340 (bus_driver_handle_service_exists): ditto
1342 * bus/services.c (bus_services_list): NULL-terminate returned array
1344 * bus/driver.c (bus_driver_send_service_lost)
1345 (bus_driver_send_service_acquired): send messages from driver to a
1346 specific client to the client's unique name, not to the broadcast
1349 * dbus/dbus-message.c (decode_header_data): reject messages that
1350 contain no name field
1351 (_dbus_message_get_client_serial): rename to
1352 dbus_message_get_serial and make public
1353 (_dbus_message_set_serial): rename from set_client_serial
1354 (_dbus_message_set_reply_serial): make public
1355 (_dbus_message_get_reply_serial): make public
1357 * bus/connection.c (bus_connection_foreach): allow stopping
1358 iteration by returning FALSE from foreach function.
1360 * dbus/dbus-connection.c (dbus_connection_send_preallocated)
1361 (dbus_connection_free_preallocated_send)
1362 (dbus_connection_preallocate_send): new API for sending a message
1363 without possibility of malloc failure.
1364 (dbus_connection_send_message): rename to just
1365 dbus_connection_send (and same for whole function family)
1367 * dbus/dbus-errors.c (dbus_error_free): make this reinit the error
1369 * dbus/dbus-sysdeps.c (_dbus_exit): new function
1371 * bus/activation.c: handle/return errors
1373 * dbus/dbus-errors.h: add more DBUS_ERROR #define
1375 * dbus/dbus-sysdeps.c (_dbus_directory_open) (_dbus_file_get_contents)
1376 (_dbus_directory_get_next_file): use DBusError instead of DBusResultCode
1377 (_dbus_result_from_errno): move to this file
1379 2003-03-10 Anders Carlsson <andersca@codefactory.se>
1381 * dbus/dbus-marshal.c:
1382 (_dbus_marshal_set_string):
1383 Take a length argument so we can marshal the correct string
1386 (_dbus_marshal_dict), (_dbus_demarshal_dict),
1387 (_dbus_marshal_get_arg_end_pos), (_dbus_marshal_validate_arg),
1388 (_dbus_marshal_test):
1389 * dbus/dbus-marshal.h:
1390 Add support for marshalling and demarshalling dicts.
1392 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
1393 Add support for TYPE DICT.
1395 * dbus/dbus-message.c: (set_string_field):
1396 Adjust header padding.
1398 (dbus_message_append_args_valist), (dbus_message_append_dict),
1399 (dbus_message_get_args_valist), (dbus_message_iter_get_arg_type),
1400 (dbus_message_iter_get_dict), (_dbus_message_loader_return_buffer),
1401 (check_message_handling), (check_have_valid_message):
1402 * dbus/dbus-message.h:
1403 Add functions for setting and getting dicts.
1405 * dbus/dbus-protocol.h:
1411 * doc/dbus-specification.sgml:
1412 Add information about how dicts are marshalled.
1414 * test/data/invalid-messages/dict-with-nil-value.message:
1415 * test/data/invalid-messages/too-short-dict.message:
1416 * test/data/valid-messages/dict-simple.message:
1417 * test/data/valid-messages/dict.message:
1418 Add sample messages containing dicts.
1420 2003-03-08 Anders Carlsson <andersca@codefactory.se>
1422 * dbus/dbus-dict.h: Add DBUS_END_DECLS.
1424 2003-03-07 Anders Carlsson <andersca@codefactory.se>
1427 * dbus/dbus-dict.c: (dbus_dict_entry_free), (dbus_dict_new),
1428 (dbus_dict_get_keys), (insert_entry), (dbus_dict_set_boolean),
1429 (dbus_dict_set_int32), (dbus_dict_set_uint32),
1430 (dbus_dict_set_double), (dbus_dict_set_string),
1431 (dbus_dict_set_boolean_array), (dbus_dict_set_int32_array),
1432 (dbus_dict_set_uint32_array), (dbus_dict_set_double_array),
1433 (dbus_dict_set_string_array), (_dbus_dict_test):
1435 Fix according to comments from Havoc.
1437 2003-03-06 Michael Meeks <michael@server.home>
1439 * configure.in: if we don't have kde-config, disable have_qt.
1441 2003-03-07 Anders Carlsson <andersca@codefactory.se>
1446 * dbus/dbus-dict.c: (dbus_dict_entry_free), (dbus_dict_new),
1447 (dbus_dict_ref), (dbus_dict_unref), (dbus_dict_contains),
1448 (dbus_dict_remove), (dbus_dict_get_value_type),
1449 (dbus_dict_get_keys), (dbus_dict_put_boolean),
1450 (dbus_dict_put_int32), (dbus_dict_put_uint32),
1451 (dbus_dict_put_double), (dbus_dict_put_string),
1452 (dbus_dict_put_boolean_array), (dbus_dict_put_int32_array),
1453 (dbus_dict_put_uint32_array), (dbus_dict_put_double_array),
1454 (dbus_dict_put_string_array), (dbus_dict_get_boolean),
1455 (dbus_dict_get_int32), (dbus_dict_get_uint32),
1456 (dbus_dict_get_double), (dbus_dict_get_string),
1457 (dbus_dict_get_boolean_array), (dbus_dict_get_int32_array),
1458 (dbus_dict_get_uint32_array), (dbus_dict_get_double_array),
1459 (dbus_dict_get_string_array), (_dbus_dict_test):
1461 Add DBusDict implementation
1463 * dbus/dbus-test.c: (dbus_internal_do_not_use_run_tests):
1467 2003-03-04 Havoc Pennington <hp@pobox.com>
1469 * test/data/auth/*: adapt to changes
1471 * dbus/dbus-auth-script.c (_dbus_auth_script_run): add
1472 USERID_BASE64 and change USERNAME_BASE64 to put in username not
1475 * dbus/dbus-keyring.c (_dbus_keyring_validate_context): prevent
1476 more stuff from being in a context name, to make the protocol
1477 simpler to deal with
1479 * dbus/dbus-errors.c (dbus_error_has_name): new function
1480 (dbus_error_is_set): new function
1482 * dbus/dbus-auth.c: replace DBUS_STUPID_TEST_MECH auth
1483 with DBUS_COOKIE_SHA1, implement DBUS_COOKIE_SHA1
1485 * dbus/dbus-connection.c (dbus_connection_flush): also read
1486 messages during a flush operation
1488 * dbus/Makefile.am: remove dbus-md5 since it isn't currently used.
1490 2003-03-05 Anders Carlsson <andersca@codefactory.se>
1492 * configure.in: Check for gethostbyname on Solaris.
1494 * dbus/dbus-transport.c: (_dbus_transport_open):
1495 Remove duplicate "tcp" entry.
1497 * doc/dbus-specification.sgml:
1498 Clarify some things.
1500 2003-03-05 Anders Carlsson <andersca@codefactory.se>
1502 * dbus/dbus-auth.c: (send_rejected), (process_test_subdir):
1503 * dbus/dbus-keyring.c: (_dbus_keyring_new_homedir),
1504 (_dbus_keyring_test):
1505 * dbus/dbus-md5.c: (_dbus_md5_compute):
1506 * dbus/dbus-sha.c: (_dbus_sha_compute):
1509 2003-03-05 Anders Carlsson <andersca@codefactory.se>
1511 * README: Add some things.
1513 2003-03-04 Anders Carlsson <andersca@codefactory.se>
1515 * dbus/dbus-message.c (dbus_message_append_args_valist): Add a break;
1516 after case DBUS_TYPE_BOOELAN.
1518 2003-03-02 Havoc Pennington <hp@pobox.com>
1520 * test/break-loader.c (randomly_set_extreme_ints): add test that
1521 sets really huge and small integers
1523 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): add check
1524 that length of boolean array fits in the string, and that
1525 string has room for boolean value in single-bool case.
1527 * dbus/dbus-message-builder.c (_dbus_message_data_load): add
1528 optional value to "ALIGN" command which is what to fill the
1531 * test/data/valid-messages/no-padding.message: add regression
1532 test for the message padding problem
1534 2003-03-02 Havoc Pennington <hp@pobox.com>
1536 * dbus/dbus-message.c (decode_header_data): fix to always init
1537 message_padding, from Benjamin Dauvergne
1539 2003-03-02 Havoc Pennington <hp@pobox.com>
1545 2003-03-01 Joe Shaw <joe@assbarn.com>
1547 * configure.in: Check for "struct cmsgcred" and try to access its
1548 members for BSD-like unices.
1550 * dbus/dbus-sysdeps.c (read_credentials_byte): Fold this back into
1551 _dbus_read_credentials_unix_socket().
1552 (_dbus_read_credentials_unix_socket): Use recvmsg() instead of
1553 read() for reading the credential byte off the unix socket. Use
1554 struct cmsgcred on systems that support it.
1556 2003-02-27 Alexander Larsson <alexl@redhat.com>
1560 Make gthreads-2.0 dependency optional. Don't build thread test if
1563 2003-02-27 Havoc Pennington <hp@pobox.com>
1565 * dbus/dbus-connection.c
1566 (dbus_connection_send_message_with_reply_and_block): fix doh!
1567 doh! doh! bug that resulted in never removing a reply from the
1568 queue, no wonder we called get_reply_serial so much ;-)
1570 * dbus/dbus-message.c (struct DBusMessage): cache reply serial
1571 and client serial instead of demarshaling them every time
1573 2003-02-27 Havoc Pennington <hp@pobox.com>
1575 * dbus/dbus-marshal.c (_dbus_demarshal_int32): rewrite to be much
1576 more inlined, using dbus-string-private.h, speeds things up
1579 * dbus/dbus-string.c (_dbus_string_free): apply align offset
1580 when freeing the string
1581 (_dbus_string_steal_data): fix for align offset
1582 (undo_alignment): new function
1584 2003-02-26 Havoc Pennington <hp@redhat.com>
1586 All kinds of audit fixes from Owen, plus initial attempt to
1587 handle unaligned memory returned from malloc.
1589 * dbus/dbus-string.c (_dbus_string_init): clamp max length to
1590 leave room for align_offset and nul byte
1591 (fixup_alignment): function to track an align_offset and
1592 ensure real->str is aligned
1593 (DBUS_GENERIC_STRING_PREAMBLE): len must be less than allocated,
1594 to allow a nul byte plus align offset
1595 (_dbus_string_lock): fix overflow issue
1596 (_dbus_string_init_const_len): add assertions on sanity of len,
1597 assign allocated to be ALLOCATION_PADDING larger than len
1598 (set_length): fixup the overflow handling
1599 (_dbus_string_get_data_len): fix overflow in assertion
1600 (open_gap): detect overflow in size of gap to be opened
1601 (_dbus_string_lengthen): add overflow check
1602 (_dbus_string_align_length): fix overflow with _DBUS_ALIGN_VALUE
1603 (_dbus_string_append): add overflow check
1604 (_dbus_string_append_unichar): overflow
1605 (_dbus_string_delete): fix overflow in assertion
1606 (_dbus_string_copy_len): overflow in assertion
1607 (_dbus_string_replace_len): overflows in assertions
1608 (_dbus_string_find): change to implement in terms of
1609 _dbus_string_find_to
1610 (_dbus_string_find_to): assorted fixage
1611 (_dbus_string_equal_c_str): assert c_str != NULL,
1612 fix logic so the function works
1613 (_dbus_string_ends_with_c_str): fix overflow thingy
1614 (_dbus_string_base64_encode): overflow fix
1615 (_dbus_string_validate_ascii): overflow
1616 (_dbus_string_validate_nul): overflow
1618 2003-02-26 Havoc Pennington <hp@redhat.com>
1620 * dbus/dbus-marshal.c (_dbus_marshal_test): fix to work with DISABLE_ASSERTS
1622 2003-02-26 Alexander Larsson <alexl@redhat.com>
1625 Set DBUS_GLIB_THREADS_LIBS for apps using gthread-2.0
1627 * dbus/dbus-connection.c:
1628 * dbus/dbus-connection.h:
1629 Fix _dbus_connection_acquire_io_path and _dbus_connection_acquire_dispatch.
1630 Add dbus_connection_set_wakeup_main_function and use it when queueing
1631 incoming and outgoing messages.
1634 * dbus/dbus-dataslot.c:
1635 Threadsafe usage of DBusDataSlotAllocator
1637 * dbus/dbus-message.c: (dbus_message_get_args_iter):
1640 * dbus/dbus-server-unix.c:
1643 * glib/dbus-gmain.c:
1644 Implement the new wakeup functions for glib.
1647 * glib/test-thread-client.c:
1648 * glib/test-thread-server.c:
1649 * glib/test-thread.h:
1650 Initial cut at some thread test code. Not really done yet.
1652 2003-02-26 Havoc Pennington <hp@pobox.com>
1654 * dbus/dbus-connection.c
1655 (dbus_connection_send_message_with_reply_and_block): fix crash
1656 where we ref'd the outgoing message instead of the returned reply
1658 * dbus/dbus-transport-unix.c (do_authentication): check read watch
1659 at the end of this function, so if we didn't need to read for
1660 authentication, we reinstall it for receiving messages
1662 * dbus/dbus-message.c (dbus_message_new_reply): allow replies to
1663 a NULL sender for peer-to-peer case
1665 * dbus/dbus-transport-unix.c (check_read_watch): handle
1666 !authenticated case correctly
1668 * glib/dbus-gmain.c: add support for DBusServer
1670 * dbus/dbus-server.c: add data slot support
1672 * glib/dbus-gmain.c (dbus_connection_setup_with_g_main): check
1673 return values and handle errors
1675 * dbus/dbus-dataslot.c: factor out the data slot stuff from
1678 * Doxyfile.in (INPUT): add glib subdir
1680 * glib/dbus-gmain.c (dbus_connection_setup_with_g_main): rename
1681 setup_with_g_main instead of hookup_with_g_main; write docs
1683 2003-02-24 Anders Carlsson <andersca@codefactory.se>
1685 * dbus/dbus-marshal.c: (_dbus_marshal_validate_arg):
1686 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
1687 * dbus/dbus-message.c: (dbus_message_append_boolean),
1688 (dbus_message_append_boolean_array),
1689 (dbus_message_get_args_valist), (_dbus_message_test):
1690 * dbus/dbus-message.h:
1691 * doc/dbus-specification.sgml:
1692 Various fixes as pointed out by Havoc.
1694 * test/data/invalid-messages/bad-boolean-array.message:
1695 * test/data/invalid-messages/bad-boolean.message:
1696 Add invalid boolean value test cases.
1698 2003-02-24 Anders Carlsson <andersca@codefactory.se>
1700 * dbus/dbus-internals.c: (_dbus_type_to_string):
1701 * dbus/dbus-marshal.c: (_dbus_marshal_get_arg_end_pos),
1702 (_dbus_marshal_validate_arg):
1703 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
1704 * dbus/dbus-message.c: (dbus_message_append_args_valist),
1705 (dbus_message_append_boolean), (dbus_message_append_boolean_array),
1706 (dbus_message_get_args_valist), (dbus_message_iter_get_boolean),
1707 (dbus_message_iter_get_int32), (dbus_message_iter_get_uint32),
1708 (dbus_message_iter_get_double),
1709 (dbus_message_iter_get_boolean_array), (message_iter_test):
1710 * dbus/dbus-message.h:
1711 * dbus/dbus-protocol.h:
1712 * doc/dbus-specification.sgml:
1713 * test/data/valid-messages/lots-of-arguments.message:
1714 Add support for boolean and boolean array types.
1716 2003-02-23 Havoc Pennington <hp@pobox.com>
1718 * dbus/dbus-keyring.c: finish most of this implementation and
1721 * dbus/dbus-errors.c (dbus_set_error_const, dbus_set_error): make
1722 these barf if the error isn't cleared to NULL
1724 * dbus/dbus-sysdeps.c (_dbus_delete_file): set error on failure
1725 (_dbus_create_directory): new function
1727 * dbus/dbus-errors.c (dbus_set_error): fix warning
1729 * dbus/dbus-string.c (_dbus_string_hex_encode): new function
1730 (_dbus_string_hex_decode): new function
1731 (test_hex_roundtrip): test code
1733 * dbus/dbus-sha.c (_dbus_sha_compute): use dbus_string_hex_encode
1735 * dbus/dbus-md5.c (_dbus_md5_compute): use dbus_string_hex_encode
1737 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): make this use
1738 the save-to-temp/rename trick to atomically write the new file
1739 (_dbus_string_parse_uint): new function
1741 2003-02-22 Havoc Pennington <hp@pobox.com>
1743 * test/Makefile.am (dist-hook): fix dist for test/data/sha-1
1745 2003-02-22 Havoc Pennington <hp@pobox.com>
1747 * dbus/dbus-message.c (dbus_message_iter_get_string_array):
1748 (dbus_message_iter_get_byte_array): Fix up doxygen warnings
1750 * dbus/dbus-sha.c: add implementation of SHA-1 algorithm
1752 * dbus/test/data/sha-1: add US government test suite for SHA-1
1754 2003-02-21 Anders Carlsson <andersca@codefactory.se>
1756 * dbus/dbus-marshal.c: (_dbus_demarshal_string_array):
1757 Make string arrays NULL-terminated.
1759 * dbus/dbus-memory.c: (dbus_free_string_array):
1760 * dbus/dbus-memory.h:
1761 New function for freeing NULL-terminated string arrays.
1763 * dbus/dbus-message-builder.c: (append_quoted_string),
1764 (_dbus_message_data_load):
1765 Add support for array types.
1767 * dbus/dbus-message.c: (check_message_handling):
1768 Add more types as test cases.
1770 * dbus/dbus-sysdeps.c: (_dbus_string_parse_int),
1771 (_dbus_string_parse_double):
1772 Add the start offset to the end offset.
1774 * test/data/valid-messages/lots-of-arguments.message:
1775 New test message with lots of arguments.
1777 2003-02-21 Anders Carlsson <andersca@codefactory.se>
1779 * dbus/dbus-message.c: (dbus_message_append_nil),
1780 (dbus_message_append_int32), (dbus_message_append_uint32),
1781 (dbus_message_append_double), (dbus_message_append_string),
1782 (dbus_message_append_int32_array),
1783 (dbus_message_append_uint32_array),
1784 (dbus_message_append_double_array),
1785 (dbus_message_append_byte_array),
1786 (dbus_message_append_string_array):
1787 Fix all out-of-memory handling in these functions.
1789 2003-02-21 Anders Carlsson <andersca@codefactory.se>
1791 * dbus/dbus-message.c: (dbus_message_append_nil):
1794 2003-02-21 Anders Carlsson <andersca@codefactory.se>
1796 * dbus/dbus-message.c: (dbus_message_append_args_valist),
1797 (dbus_message_append_nil), (dbus_message_append_int32_array),
1798 (dbus_message_append_uint32_array),
1799 (dbus_message_append_double_array),
1800 (dbus_message_append_byte_array),
1801 (dbus_message_append_string_array), (dbus_message_get_args_valist),
1802 (dbus_message_iter_get_int32_array),
1803 (dbus_message_iter_get_uint32_array),
1804 (dbus_message_iter_get_double_array),
1805 (dbus_message_iter_get_byte_array),
1806 (dbus_message_iter_get_string_array):
1808 * dbus/dbus-message.h:
1809 Add functions for appending and getting arrays.
1811 2003-02-21 Anders Carlsson <andersca@codefactory.se>
1813 * dbus/dbus-mempool.c (_dbus_mem_pool_new): Make the
1814 element size at least 8 bytes, fixes mempool tests on
1817 2003-02-20 Alexander Larsson <alexl@redhat.com>
1819 * dbus/dbus-transport-unix.c (unix_do_iteration):
1820 Unlock the connection mutex during a blocking select call.
1821 Add todo about how we need a way to wake up the select.
1823 * dbus/dbus-connection-internal.h:
1824 * dbus/dbus-connection.c:
1825 Add _dbus_connection_lock and _dbus_connection_unlock.
1827 2003-02-19 Havoc Pennington <hp@pobox.com>
1829 * Doxyfile.in (PREDEFINED): put DOXYGEN_SHOULD_SKIP_THIS in
1830 Doxyfile.in, not Doxyfile
1832 * dbus/dbus-keyring.c: do some hacking on this
1834 * dbus/dbus-sysdeps.c (_dbus_delete_file): new
1836 * dbus/dbus-errors.c (dbus_set_error_const): do not call
1838 (dbus_set_error): remove dbus_error_init, check for message ==
1839 NULL *before* we sprintf into it, and add @todo about including
1840 system headers in this file
1842 * dbus/dbus-sysdeps.c (_dbus_create_file_exclusively): new
1844 * dbus/dbus-errors.h (DBUS_ERROR_FAILED): add
1846 * dbus/dbus-sysdeps.c (get_user_info): break this function out to
1847 get various bits of user information based on either username
1849 (_dbus_homedir_from_username): new function
1851 2003-02-19 Anders Carlsson <andersca@codefactory.se>
1854 Add check for nonposix getpwnam_r
1856 * dbus/dbus-mempool.c: (_dbus_mem_pool_new):
1857 Align the pool element size to a sizeof (void *) boundary.
1859 * dbus/dbus-sysdeps.c: (_dbus_setenv), (_dbus_connect_unix_socket),
1860 (_dbus_listen_unix_socket), (_dbus_credentials_from_username):
1861 General Solaris fixes.
1863 * test/data/valid-messages/simplest-manual.message:
1864 Explicitly state that we want little-endian packing.
1866 2003-02-19 Mikael Hallendal <micke@codefactory.se>
1868 * dbus/dbus-server.c (dbus_server_listen): Support tcp: addresses.
1870 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_tcp_socket):
1871 Added to create a transport connecting using a tcp/ip socket.
1873 * dbus/dbus-sysdeps.c (_dbus_connect_tcp_socket): Added to connect
1874 to a tcp socket at given host and port.
1875 (_dbus_listen_tcp_socket): added to listen on tcp socket for given
1878 * dbus/dbus-server.c (dbus_server_listen): Support tcp: addresses.
1880 * dbus/dbus-server-unix.c (_dbus_server_new_for_tcp_socket):
1881 Added to create a server listening on a TCP/IP socket.
1883 2003-02-19 Havoc Pennington <hp@pobox.com>
1885 Throughout: mop up all the Doxygen warnings and undocumented
1888 * dbus/dbus-sysdeps.c (do_exec): do not use execvp, we don't want
1889 to search any paths.
1891 * dbus/dbus-threads.c: move global mutex initializers to
1892 dbus-internals.h, multiple prototypes was confusing doxygen
1893 besides being kind of ugly
1895 * Doxyfile (PREDEFINED): have Doxygen define
1896 DOXYGEN_SHOULD_SKIP_THIS so we can exclude things from
1897 docs with #ifndef DOXYGEN_SHOULD_SKIP_THIS
1898 (do not abuse the feature! it's for stuff like the autogenerated
1899 macros in dbus-md5.c, not just for things you don't feel like
1902 2003-02-18 Havoc Pennington <hp@pobox.com>
1904 * dbus/dbus-string.c (_dbus_string_zero): new function
1906 * dbus/dbus-md5.c: include MD5 implementation by L. Peter Deutsch,
1907 wrap it in some dbus-friendly API
1909 * dbus/dbus-types.h: add 16-bit types
1911 2003-02-18 Joe Shaw <joe@assbarn.com>
1913 * dbus/dbus-auth.c (handle_server_data_stupid_test_mech): Just get
1914 credentials from our currently running process.
1915 (get_word): Fix a buglet where we were copying the entire length
1916 instead of relative to our position.
1918 * dbus/dbus-hash.c (_dbus_hash_test): Don't try to allocate the
1919 keys on the stack... it's 640k of data.
1921 * dbus/dbus-sysdeps.c (_dbus_read_credentials_unix_socket): Always
1922 read the credentials byte off the socket, even if we don't have
1924 (_dbus_poll): Implement poll() using select() for systems which
1927 * glib/test-dbus-glib.c (main): Print out an error if no
1928 parameters are given.
1930 * test/data/auth/fallback.auth-script: Added. Tests that a client
1931 can fallback to a secondary auth mechanism if the first fails.
1933 2003-02-18 Havoc Pennington <hp@pobox.com>
1937 2003-02-17 Havoc Pennington <hp@pobox.com>
1939 * doc/dbus-specification.sgml: lots of cosmetic
1940 cleanups/rearrangement, add assorted FIXME, change DBUS_ADDRESS
1941 env variable to DBUS_BUS_ADDRESS, s/client/application/,
1942 s/server/bus/ (except in authentication section). Add a section
1943 "Message Bus Message Routing"
1945 2003-02-17 Anders Carlsson <andersca@codefactory.se.>
1951 2003-02-17 Anders Carlsson <andersca@codefactory.se>
1953 * doc/dbus-specification.sgml:
1954 Specification updates.
1956 2003-02-17 Anders Carlsson <andersca@codefactory.se>
1958 * bus/activation.c: (bus_activation_init), (child_setup),
1959 (bus_activation_activate_service):
1961 * bus/main.c: (main):
1962 Set DBUS_ADDRESS environment variable.
1964 * dbus/dbus-errors.c: (dbus_set_error):
1965 Don't use va_copy since that's a C99 feature.
1967 * dbus/dbus-sysdeps.c: (_dbus_setenv), (do_exec),
1968 (_dbus_spawn_async):
1969 * dbus/dbus-sysdeps.h:
1970 Add child_setup_func to _dbus_spawn_async.
1972 * doc/dbus-specification.sgml:
1973 Update specification.
1975 * test/spawn-test.c: (setup_func), (main):
1978 2003-02-17 Alexander Larsson <alexl@redhat.com>
1980 * dbus/dbus-connection.c (_dbus_connection_handler_destroyed_locked):
1983 2003-02-17 Anders Carlsson <andersca@codefactory.se>
1987 * doc/dbus-test-plan.sgml:
1988 Add test plan document.
1993 2003-02-17 Anders Carlsson <andersca@codefactory.se>
1995 * dbus/dbus-message.c: (decode_header_data),
1996 (_dbus_message_loader_return_buffer):
1997 Set the header padding amount when loading a message.
1999 2003-02-16 Anders Carlsson <andersca@codefactory.se>
2001 * bus/dispatch.c: (send_one_message):
2002 Only send broadcast messages to registered connections.
2004 * dbus/dbus-message.c: (dbus_message_name_is):
2005 * dbus/dbus-message.h:
2006 New convenience function.
2008 * dbus/dbus-transport-debug.c: (do_reading):
2009 Only dispatch one message per run.
2012 * test/bus-test.c: (new_connection_callback), (die),
2013 (test_hello_client1_handler), (test_hello_client2_handler),
2014 (test_hello_replies), (main):
2016 * test/bus-test-loop.[ch]:
2019 2003-02-16 Havoc Pennington <hp@pobox.com>
2021 * dbus/dbus-connection.c (dbus_connection_dispatch_message): fix
2022 backward conditional
2024 2003-02-16 Alexander Larsson <alexl@redhat.com>
2026 * dbus/dbus-connection.c:
2027 Implement sent_message_with_reply. (with_reply_and block is still
2029 Made dispatch_message not lose message if OOM.
2031 * dbus/dbus-errors.h:
2032 Add NoReply error (for reply timeouts).
2034 2003-02-16 Alexander Larsson <alexl@redhat.com>
2036 * dbus/dbus-hash.c (_dbus_hash_table_unref):
2037 Actually free keys and values when destroying hashtable.
2039 2003-02-16 Anders Carlsson <andersca@codefactory.se>
2041 * dbus/dbus-auth.c: (client_try_next_mechanism):
2044 * dbus/dbus-threads.c: (dbus_condvar_wait_timeout):
2045 Return TRUE if there's no thread implementation around.
2047 * glib/dbus-gmain.c: (free_source),
2048 (dbus_connection_hookup_with_g_main):
2049 Make sure to remove the GSource when the connection is finalized.
2051 2003-02-16 Anders Carlsson <andersca@codefactory.se>
2053 * bus/dispatch.c: (bus_dispatch_message_handler):
2054 * dbus/dbus-errors.h:
2055 Return an error if someone tries to send a message to a service
2058 2003-02-16 Anders Carlsson <andersca@codefactory.se>
2060 * bus/activation.c: (load_directory), (bus_activation_init),
2061 (bus_activation_activate_service):
2064 (bus_driver_handle_activate_service), (bus_driver_handle_message):
2065 More work on the activation handling.
2067 * dbus/dbus-errors.h:
2068 Add some error messages
2070 * dbus/dbus-message.c: (dbus_message_new_error_reply):
2071 * dbus/dbus-message.h:
2072 New function that creates an error message.
2074 * dbus/dbus-protocol.h:
2075 Add ACTIVATE_SERVER message.
2077 * dbus/dbus-server-unix.c: (unix_handle_watch),
2078 (_dbus_server_new_for_domain_socket):
2079 Call _dbus_fd_set_close_on_exec.
2081 * dbus/dbus-sysdeps.c: (make_pipe), (do_exec),
2082 (_dbus_spawn_async), (_dbus_disable_sigpipe),
2083 (_dbus_fd_set_close_on_exec):
2084 * dbus/dbus-sysdeps.h:
2085 Add _dbus_fd_set_close_on exec function. Also add function that checks
2086 that all open fds are set to close-on-exec and warns otherwise.
2088 * dbus/dbus-transport-unix.c:
2089 (_dbus_transport_new_for_domain_socket):
2090 Call _dbus_fd_set_close_on_exec.
2092 2003-02-16 Havoc Pennington <hp@pobox.com>
2094 * dbus/dbus-connection.c (dbus_connection_set_change_sigpipe):
2095 allow people to avoid setting SIGPIPE to SIG_IGN
2096 (_dbus_connection_new_for_transport): disable SIGPIPE unless
2097 we've been asked not to
2099 2003-02-15 Anders Carlsson <andersca@codefactory.se>
2101 * dbus/dbus-list.c: (_dbus_list_append_link),
2102 (_dbus_list_prepend_link):
2103 * dbus/dbus-memory.c: (dbus_malloc), (dbus_malloc0),
2107 2003-02-15 Anders Carlsson <andersca@codefactory.se>
2110 * bus/activation.c: (bus_activation_entry_free),
2111 (add_desktop_file_entry), (load_directory), (bus_activation_init):
2113 * bus/main.c: (main):
2114 Add simple activation support, doesn't work yet though.
2116 2003-02-15 Zack Rusin <zack@kde.org>
2118 * qt/dbus-qthread.cpp: small casting fix
2120 2003-02-15 Anders Carlsson <andersca@codefactory.se>
2122 * dbus/dbus-errors.c: (dbus_set_error):
2123 * dbus/dbus-errors.h:
2124 Add a few errors and make dbus_set_error void.
2126 * dbus/dbus-sysdeps.c:
2127 (_dbus_errno_to_string), (close_and_invalidate), (make_pipe),
2128 (write_err_and_exit), (read_ints), (do_exec), (_dbus_spawn_async):
2129 * dbus/dbus-sysdeps.h:
2130 Add _dbus_spawn_async.
2132 * test/spawn-test.c: (main):
2133 Test for _dbus_spawn_async.
2135 2003-02-15 Anders Carlsson <andersca@codefactory.se>
2137 * dbus/dbus-internals.h:
2138 Fix build without tests.
2140 * dbus/dbus-list.c: (alloc_link):
2141 Fix a segfault when a malloc fails.
2143 * dbus/dbus-memory.c: (initialize_malloc_debug), (dbus_malloc),
2144 (dbus_malloc0), (dbus_realloc):
2145 Add support for malloc debugging.
2147 2003-02-15 Alexander Larsson <alexl@redhat.com>
2149 * dbus/dbus-threads.c:
2150 * dbus/dbus-threads.h:
2151 Add condvars. Remove static mutext from API.
2152 Implement static mutexes by initializing them from threads_init.
2154 * glib/dbus-gthread.c:
2155 * qt/dbus-qthread.cpp:
2156 Update with the thread api changes.
2161 Turn StaticMutex into normal mutex + init function.
2162 Export new functions _dbus_list_alloc_link, _dbus_list_free_link,
2163 _dbus_list_append_link, _dbus_list_prepend_link
2166 * dbus/dbus-sysdeps.c:
2167 * dbus/dbus-sysdeps.h:
2168 New type dbus_atomic_t, and new functions _dbus_atomic_inc,
2169 _dbus_atomic_dec. Only slow fallback implementation at the moment.
2171 * dbus/dbus-protocol.h:
2172 Add DBUS_MESSAGE_LOCAL_DISCONNECT define
2174 * dbus/dbus-message.c:
2175 Make ref/unref atomic.
2178 * dbus/dbus-connection-internal.h:
2179 * dbus/dbus-connection.c:
2180 * dbus/dbus-connection.h:
2182 Change _peek to _borrow,_return & _steal_borrowed.
2183 Change disconnect callback to event.
2184 Make dbus_connection_dispatch_messages reentrant.
2186 * dbus/dbus-transport.c:
2187 Don't ref the connection on calls to the transport
2190 * dbus/dbus-message-handler.c:
2193 * glib/dbus-gmain.c:
2194 Don't use peek_message anymore
2197 * test/debug-thread.c:
2198 * test/debug-thread.h:
2199 Simple thread implementation that asserts() on deadlocks in
2200 single-threaded code.
2203 (main) Call debug_threads_init.
2206 Use disconnect message instead of disconnect callback.
2210 Don't call dbus_connection_set_disconnect_function. Instead export
2211 bus_connection_disconnect.
2214 Call bus_connection_disconnect when we get a disconnected message.
2216 2003-02-15 Havoc Pennington <hp@pobox.com>
2218 * dbus/dbus-message.c (dbus_message_new): fool around with the
2221 2003-02-14 Havoc Pennington <hp@pobox.com>
2223 * dbus/dbus-mempool.c: fail if the debug functions so indicate
2225 * dbus/dbus-memory.c: fail if the debug functions indicate we
2228 * dbus/dbus-internals.c (_dbus_set_fail_alloc_counter)
2229 (_dbus_decrement_fail_alloc_counter): debug functions to
2230 simulate memory allocation failures
2232 2003-02-14 Havoc Pennington <hp@pobox.com>
2234 * dbus/dbus-errors.h (struct DBusError): add a word of padding
2237 2003-02-13 Anders Carlsson <andersca@codefactory.se>
2239 * bus/driver.c: (bus_driver_handle_hello):
2241 * bus/services.c: (bus_service_lookup):
2242 Reorder message sending so we get a more sane order.
2244 * test/bus-test.c: (message_handler):
2247 2003-02-13 Anders Carlsson <andersca@codefactory.se>
2249 * bus/driver.c: (bus_driver_send_service_deleted),
2250 (bus_driver_send_service_created), (bus_driver_send_service_lost),
2251 (bus_driver_send_service_acquired), (bus_driver_handle_hello),
2252 (bus_driver_send_welcome_message),
2253 (bus_driver_handle_list_services),
2254 (bus_driver_handle_acquire_service),
2255 (bus_driver_handle_service_exists):
2256 * dbus/dbus-bus.c: (dbus_bus_register_client),
2257 (dbus_bus_acquire_service), (dbus_bus_service_exists):
2258 * dbus/dbus-errors.c: (dbus_result_to_string):
2259 * dbus/dbus-errors.h:
2260 * dbus/dbus-message.c: (dbus_message_append_args),
2261 (dbus_message_append_args_valist), (dbus_message_get_args),
2262 (dbus_message_get_args_valist), (dbus_message_get_args_iter),
2263 (dbus_message_iter_get_arg_type), (dbus_message_iter_get_string),
2264 (dbus_message_iter_get_byte_array),
2265 (dbus_message_iter_get_string_array), (message_iter_test),
2266 (check_message_handling), (_dbus_message_test):
2267 * dbus/dbus-message.h:
2268 * test/bus-test.c: (main):
2269 Change fields to arguments in messages, so that they won't be
2270 confused with header fields.
2272 * glib/test-dbus-glib.c: (main):
2273 Remove append_fields from hello message.
2275 2003-02-13 Anders Carlsson <andersca@codefactory.se>
2277 * dbus/dbus-errors.c:
2278 * dbus/dbus-message.c:
2279 * dbus/dbus-string.c:
2280 Documentation fixes.
2282 2003-02-13 Anders Carlsson <andersca@codefactory.se>
2284 * glib/dbus-gmain.c: (timeout_handler), (add_timeout),
2286 Implement support for timeouts in dbus-glib.
2288 2003-02-13 Anders Carlsson <andersca@codefactory.se>
2290 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
2291 * dbus/dbus-message.c: (process_test_subdir):
2292 * test/break-loader.c: (find_breaks_based_on):
2293 Plug some memory leaks.
2295 2003-02-13 Richard Hult <rhult@codefactory.se>
2297 * bus/main.c: Fix build.
2299 * dbus/dbus-errors.h:
2300 * dbus/dbus-errors.c: Fix copyright for Anders.
2302 2003-02-13 Anders Carlsson <andersca@codefactory.se>
2307 * bus/connection.c: (bus_connection_foreach):
2310 * bus/desktop-file.c: (grow_lines_in_section), (grow_sections),
2311 (unescape_string), (new_section), (parse_section_start),
2312 (parse_key_value), (report_error), (bus_desktop_file_load),
2313 (bus_desktop_file_get_string):
2314 * bus/desktop-file.h:
2315 Use DBusError for error reporting.
2317 * bus/dispatch.c: (send_one_message),
2318 (bus_dispatch_message_handler):
2319 * bus/driver.c: (bus_driver_send_service_deleted),
2320 (bus_driver_send_service_created), (bus_driver_send_service_lost),
2321 (bus_driver_send_service_acquired), (bus_driver_handle_hello),
2322 (bus_driver_send_welcome_message),
2323 (bus_driver_handle_list_services),
2324 (bus_driver_handle_acquire_service),
2325 (bus_driver_handle_service_exists):
2326 * bus/loop.c: (bus_loop_run):
2328 Use BUS_HANDLE_OOM instead of _DBUS_HANDLE_OOM.
2330 * bus/utils.c: (bus_wait_for_memory):
2332 New files with general utility functions.
2334 * dbus/dbus-internals.h:
2335 Remove _DBUS_HANDLE_OOM.
2337 2003-02-13 Anders Carlsson <andersca@codefactory.se>
2339 * dbus/dbus-errors.c: (dbus_result_to_string), (dbus_error_init),
2340 (dbus_error_free), (dbus_set_error_const), (dbus_set_error):
2341 * dbus/dbus-errors.h:
2342 Add DBusError structure.
2344 2003-02-13 Anders Carlsson <andersca@codefactory.se>
2346 * test/data/valid-messages/standard-acquire-service.message:
2347 * test/data/valid-messages/standard-hello.message:
2348 * test/data/valid-messages/standard-list-services.message:
2349 * test/data/valid-messages/standard-service-exists.message:
2350 Add some standard messages.
2352 2003-02-13 Anders Carlsson <andersca@codefactory.se>
2354 * bus/driver.c: (bus_driver_send_welcome_message),
2355 (bus_driver_handle_list_services),
2356 (bus_driver_handle_acquire_service),
2357 (bus_driver_handle_service_exists), (bus_driver_handle_message):
2358 Update for API changes in libdbus.
2360 * dbus/dbus-message.c: (dbus_message_new_reply):
2361 * dbus/dbus-message.h:
2362 Remove the name argument. The spec states that replies shouldn't
2365 2003-02-13 Anders Carlsson <andersca@codefactory.se>
2367 * bus/desktop-file.c: (parse_section_start), (parse_key_value),
2368 (report_error), (bus_desktop_file_load), (lookup_section),
2369 (lookup_line), (bus_desktop_file_get_raw),
2370 (bus_desktop_file_get_string):
2371 * bus/desktop-file.h:
2372 Some fixes, and new functions for getting a key value from a section.
2374 2003-02-13 Havoc Pennington <hp@pobox.com>
2376 * test/data/auth/fail-after-n-attempts.auth-script: new test
2378 * dbus/dbus-auth.c (send_rejected): shutdown_mech() when we
2381 2003-02-13 Havoc Pennington <hp@pobox.com>
2383 * dbus/dbus-auth.c (handle_server_data_external_mech): args to
2384 dbus_credentials_match were backward
2386 * dbus/dbus-auth-script.c (_dbus_auth_script_run): support
2387 NO_CREDENTIALS and ROOT_CREDENTIALS
2389 * dbus/dbus-auth.c (_dbus_auth_do_work): move get_state() routine
2390 into here. Never process more commands after we've reached an
2391 end state; store further data as unused bytes.
2393 * test/data/auth/*: add more auth tests
2395 * dbus/dbus-auth-script.c (_dbus_auth_script_run): support EXPECT
2396 command to match exact string and EXPECT_UNUSED to match unused
2399 * test/Makefile.am (dist-hook): fix to dist all the test stuff
2401 2003-02-12 Havoc Pennington <hp@pobox.com>
2403 * dbus/dbus-string.c (_dbus_string_pop_line): fix to also strip
2404 \r off of popped lines
2406 * dbus/dbus-auth.c (_dbus_auth_test): write code to run auth
2409 * dbus/dbus-auth-script.c (_dbus_auth_script_run): when doing a
2412 2003-02-12 Havoc Pennington <hp@pobox.com>
2414 * dbus/Makefile.am: remove break-loader from the build, since it
2417 * configure.in: add --enable-gcov to turn on coverage profiling
2418 flags and disable optimization
2420 2003-02-10 Havoc Pennington <hp@pobox.com>
2422 * dbus/dbus-auth-script.c, dbus/dbus-auth-script.h: sync
2423 initial cut at test framework for DBusAuth from laptop.
2424 Doesn't quite work yet but it compiles and I need to get
2425 it off the 266mhz laptop. ;-)
2427 * dbus/dbus-server-debug.c (_dbus_server_debug_accept_transport):
2428 fix a memleak in error case
2430 2003-02-12 Anders Carlsson <andersca@codefactory.se>
2433 * bus/desktop-file.c:
2434 * bus/desktop-file.h:
2435 Add a desktop file parser.
2437 2003-02-11 Zack Rusin <zack@kde.org>
2439 * qt/message.[h|cpp]: sample implementation
2440 of the KDE wrapper for DBusMessage
2442 2003-02-09 Zack Rusin <zack@kde.org>
2444 * test/bus-test.c: make_it_compile
2445 * doc/dbus-specification.sgml: minimal semantic fix
2447 2003-02-06 Anders Carlsson <andersca@codefactory.se>
2453 2003-02-06 Anders Carlsson <andersca@codefactory.se>
2456 * dbus/dbus-break-loader.c:
2458 * test/break-loader.c:
2459 Move dbus-break-loader to test/ and rename it to break-loader.
2461 2003-02-02 Havoc Pennington <hp@pobox.com>
2463 * dbus/dbus-keyring.c, dbus/dbus-keyring.h: template files
2464 for code to manage cookies in your home directory
2466 * dbus/dbus-sysdeps.c (_dbus_generate_random_bytes): new function
2468 * dbus/dbus-auth.c (get_state): impose a maximum number of tries
2469 to authenticate, then disconnect the client.
2471 2003-02-03 Alexander Larsson <alexl@redhat.com>
2473 * dbus/dbus-message.c (dbus_message_append_fields):
2476 2003-02-02 Anders Carlsson <andersca@codefactory.se>
2478 * doc/dbus-specification.sgml:
2479 Update address format section.
2481 2003-02-02 Anders Carlsson <andersca@codefactory.se>
2484 * test/bus-test.c: (get_time), (add_timeout), (remove_timeout),
2485 (message_handler), (new_connection_callback), (loop_quit),
2489 2003-02-02 Anders Carlsson <andersca@codefactory.se>
2491 * bus/driver.c: (bus_driver_handle_service_exists):
2492 Simplify the code a bit.
2494 * dbus/dbus-bus.c: (dbus_bus_service_exists):
2497 2003-02-02 Anders Carlsson <andersca@codefactory.se>
2500 Add libdbus-daemon.la and link to it.
2502 2003-02-01 James Willcox <jwillcox@gnome.org>
2504 * bus/driver.c: (bus_driver_handle_own_service):
2505 Actually include the service reply code in the message.
2507 2003-02-02 Anders Carlsson <andersca@codefactory.se>
2509 * bus/driver.c: (bus_driver_handle_service_exists):
2510 Don't unref the incoming message.
2512 2003-02-02 Anders Carlsson <andersca@codefactory.se>
2514 * dbus/dbus.h: Add dbus-address.h and dbus-bus.h
2516 2003-02-02 Anders Carlsson <andersca@codefactory.se>
2518 * dbus/dbus-server.c: (dbus_server_listen):
2519 * dbus/dbus-transport.c: (_dbus_transport_open):
2520 ifdef out the calls to the debug transport and server.
2522 2003-02-02 Alexander Larsson <alexl@redhat.com>
2524 * dbus/dbus-watch.c (dbus_watch_get_flags):
2525 Add note in the docs that ERROR or HANGUP won't be returned
2526 and are assumed always on.
2528 * glib/dbus-gmain.c (add_watch):
2529 Always add IO_ERR | IO_HUP
2531 * dbus/dbus-message.h:
2532 Add semicolon after dbus_message_iter_get_string_array().
2533 Makes qt code build again
2535 2003-02-01 Anders Carlsson <andersca@codefactory.se>
2537 * bus/driver.c: (create_unique_client_name),
2538 (bus_driver_handle_hello):
2539 Don't take a name, just use a numeric id to identify
2543 * dbus/dbus-bus.c: (dbus_bus_register_client),
2544 (dbus_bus_acquire_service), (dbus_bus_service_exists):
2546 Add new convenience functions for communicating with the bus.
2548 * dbus/dbus-message.h:
2550 * dbus/dbus-protocol.h:
2553 2003-02-01 Alexander Larsson <alexl@redhat.com>
2555 * dbus/dbus-message.c (dbus_message_append_fields):
2556 Add some more doc comments.
2558 2003-02-01 Havoc Pennington <hp@pobox.com>
2560 * dbus/dbus-break-loader.c (randomly_modify_length): change
2561 a 4-byte value in the message as if it were a length
2563 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): don't set
2564 execute bit on saved files
2566 2003-02-01 Havoc Pennington <hp@pobox.com>
2568 * dbus/dbus-break-loader.c (main): new program to find messages
2569 that break the loader.
2571 * dbus/dbus-sysdeps.c (_dbus_string_append_uint): new function
2572 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): new function
2574 * dbus/dbus-string.c (_dbus_string_set_byte): new
2576 2003-01-31 Havoc Pennington <hp@pobox.com>
2578 * dbus/dbus-message.c: refactor the test code to be more general,
2579 in preparation for writing a "randomly permute test cases to
2580 try to break the loader" program.
2582 2003-01-31 Havoc Pennington <hp@pobox.com>
2584 * doc/dbus-specification.sgml: work on the specification
2586 * dbus/dbus-message.c (_dbus_message_loader_return_buffer): check
2587 the protocol version of the message.
2589 * dbus/dbus-protocol.h: drop special _REPLY names, the spec
2590 no longer specifies that.
2591 (DBUS_SERVICE_REPLY_SERVICE_EXISTS): fix flags (1/2/4/8 not
2594 * dbus/dbus-marshal.c (_dbus_marshal_get_arg_end_pos): add missing
2595 "break" for DBUS_TYPE_NIL, remove @todo
2597 2003-01-31 Havoc Pennington <hp@pobox.com>
2599 * dbus/dbus-message.c (dbus_message_set_is_error_reply): rename
2600 just set_is_error/get_is_error as this is a commonly-used
2601 function, and write docs.
2603 2003-01-31 Anders Carlsson <andersca@codefactory.se>
2605 * dbus/dbus-address.c: (dbus_address_entry_free):
2606 Free key and value lists.
2608 * dbus/dbus-internals.c: (_dbus_type_to_string):
2609 Add the types we didn't have.
2611 * dbus/dbus-marshal.c: (_dbus_marshal_get_arg_end_pos),
2612 (_dbus_marshal_validate_arg):
2615 * dbus/dbus-message.c: (dbus_message_set_sender):
2616 Remove todo about being able to set sender to NULL.
2618 (dbus_message_set_is_error_reply),
2619 (dbus_message_get_is_error_reply):
2620 * dbus/dbus-message.h:
2623 * dbus/dbus-protocol.h:
2624 Add error reply flag.
2626 * test/data/valid-messages/opposite-endian.message:
2627 Add NIL type to test.
2629 2003-01-31 Havoc Pennington <hp@pobox.com>
2631 * doc/dbus-specification.sgml: fully specify the header. Add
2632 flags and major protocol version, and change header/body len to
2635 * dbus/dbus-message-builder.c (append_saved_length): append length
2638 * dbus/dbus-message.c (dbus_message_create_header): change header
2639 length and body length to unsigned. Add the new fields from the
2641 (_dbus_message_loader_return_buffer): unsigned header/body len
2643 2003-01-30 Havoc Pennington <hp@pobox.com>
2645 * dbus/dbus-auth.c: rework to use only REJECTED, no
2648 * doc/dbus-sasl-profile.txt: drop MECHANISMS and just
2649 use REJECTED, suggested by Mark McLoughlin
2651 2003-01-30 Havoc Pennington <hp@pobox.com>
2653 * dbus/dbus-server.c (dbus_server_listen): @todo about how we need
2654 a better way to report errors here. e.g. "unix address lacks
2655 path" or something. also "no such file" when the path doesn't
2658 * dbus/dbus-address.c (dbus_address_entries_free): add @todo about
2660 (dbus_parse_address): add @todo about documenting address format,
2661 and allowing , and ; to be escaped
2663 2003-01-30 Anders Carlsson <andersca@codefactory.se>
2666 Add dbus-address.[ch]
2668 * dbus/dbus-address.c: (dbus_address_entry_free),
2669 (dbus_address_entries_free), (create_entry),
2670 (dbus_address_entry_get_method), (dbus_address_entry_get_value),
2671 (dbus_parse_address), (_dbus_address_test):
2672 * dbus/dbus-address.h:
2673 New files for dealing with address parsing.
2675 * dbus/dbus-connection.c:
2676 Document timeout functions.
2678 * dbus/dbus-message.c:
2679 Document dbus_message_new_from_message.
2681 * dbus/dbus-server-debug.c:
2684 * dbus/dbus-server.c: (dbus_server_listen):
2685 Parse address and use correct server implementation.
2687 * dbus/dbus-string.c: (_dbus_string_find_to), (_dbus_string_test):
2688 * dbus/dbus-string.h:
2689 New function with test.
2691 * dbus/dbus-test.c: (dbus_internal_symbol_do_not_use_run_tests):
2695 * dbus/dbus-transport-debug.c:
2698 * dbus/dbus-transport.c: (_dbus_transport_open):
2699 Parse address and use correct transport implementation.
2701 2003-01-30 Havoc Pennington <hp@pobox.com>
2703 * dbus/dbus-message.c: use message->byte_order instead of
2704 DBUS_COMPILER_BYTE_ORDER throughout.
2705 (dbus_message_create_header): pad header to align the
2706 start of the body of the message to 8-byte boundary
2708 * dbus/dbus-marshal.h: make all the demarshalers take const
2709 DBusString arguments.
2711 * dbus/dbus-message.c (_dbus_message_loader_return_buffer):
2712 validate message args here, so we don't have to do slow validation
2713 later, and so we catch bad messages as they are incoming. Also add
2714 better checks on header_len and body_len. Also fill in
2717 * dbus/dbus-string.c (_dbus_string_validate_utf8): new (not
2718 implemented properly)
2719 (_dbus_string_validate_nul): new function to check all-nul
2721 * dbus/dbus-marshal.c (_dbus_marshal_get_field_end_pos): rename
2722 get_arg_end_pos and remove all validation
2723 (_dbus_marshal_validate_arg): actually do validation here.
2725 2003-01-29 Havoc Pennington <hp@pobox.com>
2727 * dbus/dbus-message.c (check_message_handling): fix assertion
2728 failure on set_client_serial
2730 2003-01-28 Havoc Pennington <hp@pobox.com>
2732 * dbus/dbus-server-debug.c: Add doc section comments
2734 * dbus/dbus-transport-debug.c: add doc section comments
2736 2003-01-28 Havoc Pennington <hp@redhat.com>
2738 * dbus/dbus-string.c (_dbus_string_base64_decode): append bytes in
2739 the reverse order from how I had it
2740 (_dbus_string_base64_encode): reverse encoding order. I was
2741 basically byteswapping everything during encoding.
2743 2003-01-28 Anders Carlsson <andersca@codefactory.se>
2745 * dbus/dbus-connection-internal.h:
2746 * dbus/dbus-connection.c: (_dbus_connection_add_timeout),
2747 (_dbus_connection_remove_timeout):
2748 Add functions for adding and removing timeouts.
2750 * dbus/dbus-message.c: (dbus_message_new_from_message):
2751 Add new function that takes a message and creates an exact
2752 copy of it, but with the refcount set to 1.
2753 (check_message_handling):
2756 * dbus/dbus-server-protected.h:
2757 * dbus/dbus-server.c: (_dbus_server_init_base),
2758 (_dbus_server_finalize_base), (_dbus_server_add_timeout),
2759 (dbus_server_set_timeout_functions):
2760 (_dbus_server_remove_timeout):
2761 New functions so that a server can add and remove timeouts.
2763 (dbus_server_listen):
2764 Add commented out call to dbus_server_debug_new.
2766 * dbus/dbus-timeout.c: (_dbus_timeout_new):
2767 Actually set the handler, doh.
2769 * dbus/dbus-transport.c: (_dbus_transport_open):
2770 Add commented out call to dbus_transport_debug_client_new.
2773 Add dbus-transport-debug.[ch] and dbus-server-debug.[ch]
2775 2003-01-28 Havoc Pennington <hp@pobox.com>
2777 * dbus/dbus-message.c (check_message_handling): function to check
2778 on the loaded message, iterates over it etc.
2780 2003-01-28 Havoc Pennington <hp@pobox.com>
2782 * test/Makefile.am (dist-hook): fix make distdir
2784 * dbus/Makefile.am (TESTS_ENVIRONMENT): fix make check
2786 2003-01-27 Havoc Pennington <hp@pobox.com>
2788 * dbus/dbus-mempool.c (time_for_size): replace printf with
2791 * dbus/dbus-message-builder.c (_dbus_message_data_load): allow
2792 empty lines; fix the SAVE_LENGTH stuff to be
2793 START_LENGTH/END_LENGTH so it actually works; couple other
2796 * test/Makefile.am (dist-hook): add dist-hook for .message files
2798 * dbus/dbus-string.c (DBUS_STRING_COPY_PREAMBLE): source of a copy
2799 can be constant or locked.
2800 (_dbus_string_free): allow freeing a const string as
2803 * dbus/dbus-sysdeps.c (_dbus_concat_dir_and_file): utility
2805 * dbus/dbus-test-main.c (main): take an argument which is the
2806 directory containing test data
2808 * dbus/dbus-message.c (_dbus_message_test): pass a test_data_dir
2809 argument to this and load all the messages in test/data/
2810 checking that they can be loaded or not loaded as appropriate.
2812 2003-01-27 Anders Carlsson <andersca@codefactory.se>
2814 * bus/dispatch.c: (bus_dispatch_message_handler):
2815 Dispatch messages sent to services.
2817 * bus/driver.c: (bus_driver_send_service_deleted),
2818 (bus_driver_send_service_created), (bus_driver_send_service_lost),
2819 (bus_driver_send_service_acquired):
2820 Add helper functions for sending service related messages.
2822 (bus_driver_send_welcome_message):
2823 Send HELLO_REPLY instead of WELCOME.
2825 (bus_driver_handle_list_services):
2826 Send LIST_SERVICES_REPLY instead of SERVICES.
2828 (bus_driver_handle_own_service),
2829 (bus_driver_handle_service_exists):
2830 New message handlers.
2832 (bus_driver_handle_message):
2833 Invoke new message handlers.
2835 (bus_driver_remove_connection):
2836 Don't remove any services here since that's done automatically
2837 by bus_service_remove_owner now.
2840 New function signatures.
2842 * bus/services.c: (bus_service_add_owner):
2843 Send ServiceAcquired message if we're the only primary owner.
2845 (bus_service_remove_owner):
2846 Send ServiceAcquired/ServiceLost messages.
2848 (bus_service_set_prohibit_replacement),
2849 (bus_service_get_prohibit_replacement):
2850 Functions for setting prohibit replacement.
2852 (bus_service_has_owner):
2853 New function that checks if a connection is in the owner queue of
2857 Add new function signatures.
2859 * dbus/dbus-list.c: (_dbus_list_test):
2860 Add tests for _dbus_list_remove_last and traversing the list backwards.
2863 Fix a typo in _dbus_list_get_prev_link, if we're at the first element we can't
2864 go any further, so return NULL then.
2866 * dbus/dbus-protocol.h:
2867 Add new messages, service flags and service replies.
2869 2003-01-26 Havoc Pennington <hp@pobox.com>
2871 * dbus/dbus-message-builder.c: implement, completely untested.
2873 * test/data/*: add data to be used in testing.
2874 ".message" files are our simple loadable text format.
2875 ".message-raw" will be binary dumps of messages.
2877 * dbus/dbus-string.c (_dbus_string_starts_with_c_str): new
2879 2003-01-26 Havoc Pennington <hp@pobox.com>
2881 * dbus/dbus-sysdeps.c (_dbus_file_get_contents): new function
2883 * dbus/dbus-errors.c (dbus_result_to_string): add
2886 * dbus/dbus-message-builder.c: new file, will contain code to load
2887 up messages from files. Not implemented yet.
2889 2003-01-26 Havoc Pennington <hp@pobox.com>
2891 * dbus/dbus-message.c (dbus_message_set_sender): support deleting
2892 the sender by setting to NULL
2894 2003-01-26 Havoc Pennington <hp@pobox.com>
2896 The unit tests pass, but otherwise untested. If it breaks, the
2897 tests should have been better. ;-)
2899 * bus/driver.c (bus_driver_handle_hello): return if we disconnect
2902 * dbus/dbus-message.c: redo everything so we maintain
2903 message->header as the only copy of the various fields.
2904 This avoids the possibility of out-of-memory in some cases,
2905 for example dbus_message_lock() can't run out of memory anymore,
2906 and avoids extra copying. Figured I may as well go ahead and do
2907 this since it was busted for dbus_message_lock to not return
2908 failure on OOM, and dbus_message_write_header was totally
2909 unchecked for OOM. Also fixed some random other bugs.
2911 * dbus/dbus-marshal.c (_dbus_marshal_get_field_end_pos): verify
2912 that strings are nul-terminated. Also, end_pos can be equal
2913 to string length just not greater than, I think.
2914 (_dbus_marshal_set_int32): new function
2915 (_dbus_marshal_set_uint32): new function
2916 (_dbus_marshal_set_string): new function
2918 * dbus/dbus-connection.c (_dbus_connection_new_for_transport): fix
2919 a warning, init timeout_list to NULL
2920 (dbus_connection_send_message): don't use uninitialized variable
2923 * dbus/dbus-string.c (_dbus_string_replace_len): new function
2925 2003-01-26 Anders Carlsson <andersca@codefactory.se>
2927 * bus/driver.c: (bus_driver_handle_hello),
2928 (bus_driver_send_welcome_message):
2931 2003-01-26 Anders Carlsson <andersca@codefactory.se>
2933 * dbus/dbus-auth.c: (process_auth), (_dbus_auth_unref):
2934 * dbus/dbus-connection.c: (_dbus_connection_new_for_transport),
2935 (dbus_connection_unref):
2936 * dbus/dbus-marshal.c: (_dbus_marshal_test):
2937 * dbus/dbus-message.c: (dbus_message_unref),
2940 (dbus_message_get_fields):
2941 Remove debugging printout.
2943 (_dbus_message_loader_return_buffer):
2944 Don't store the header string.
2946 (_dbus_message_test):
2949 2003-01-26 Richard Hult <rhult@codefactory.se>
2951 * glib/dbus-gmain.c (dbus_connection_dispatch): Traverse a copy of
2952 the file descriptor list, since it can change under us.
2954 2003-01-25 Anders Carlsson <andersca@codefactory.se>
2956 * glib/dbus-gmain.c: (dbus_connection_prepare),
2957 (dbus_connection_check), (dbus_connection_dispatch), (add_watch),
2958 (remove_watch), (dbus_connection_hookup_with_g_main):
2959 Rewrite the glib handling to use its own GSource instead of a
2960 GIOChannel so we can catch messages put in the queue while waiting
2963 2003-01-25 Anders Carlsson <andersca@codefactory.se>
2966 * bus/connection.c: (connection_disconnect_handler),
2967 (connection_watch_callback), (bus_connection_setup):
2968 * bus/dispatch.c: (send_one_message),
2969 (bus_dispatch_broadcast_message), (bus_dispatch_message_handler),
2970 (bus_dispatch_add_connection), (bus_dispatch_remove_connection):
2972 * bus/driver.c: (bus_driver_send_service_deleted),
2973 (bus_driver_send_service_created), (bus_driver_handle_hello),
2974 (bus_driver_send_welcome_message),
2975 (bus_driver_handle_list_services), (bus_driver_remove_connection),
2976 (bus_driver_handle_message):
2978 Refactor code, put the message dispatching in its own file. Use
2979 _DBUS_HANDLE_OOM. Also send ServiceDeleted messages when a client
2982 2003-01-25 Anders Carlsson <andersca@codefactory.se>
2984 * dbus/dbus-internals.h:
2985 Add _DBUS_HANDLE_OOM macro, it doesn't do anything currently.
2987 * dbus/dbus-message.c: (dbus_message_get_sender):
2988 * dbus/dbus-message.h:
2989 Implement dbus_message_get_sender.
2991 * dbus/dbus-protocol.h:
2992 Add message and service defines.
2994 2003-01-25 Anders Carlsson <andersca@codefactory.se>
2996 * dbus/dbus-connection.c: (dbus_connection_send_message):
2997 * dbus/dbus-message-internal.h:
2998 * dbus/dbus-message.c: (_dbus_message_get_client_serial),
2999 (dbus_message_write_header):
3000 Remove _dbus_messag_unlock and don't set the client serial on a
3001 message if one already exists.
3003 2003-01-24 Havoc Pennington <hp@pobox.com>
3005 * dbus/dbus-list.c (alloc_link): put a thread lock on the global
3008 * bus/driver.c (bus_driver_handle_list_services): fix a leak
3011 2003-01-25 Anders Carlsson <andersca@codefactory.se>
3013 * dbus/dbus-list.c: (alloc_link), (free_link):
3014 Use a memory pool for the links.
3016 2003-01-25 Anders Carlsson <andersca@codefactory.se>
3018 * bus/connection.c: (bus_connection_foreach):
3020 Add new bus_connection_foreach function.
3022 * bus/driver.c: (send_one_message), (bus_driver_broadcast_message):
3023 Add function that broadcasts a message to all clients.
3025 (bus_driver_send_service_created), (bus_driver_handle_hello),
3026 (bus_driver_send_welcome_message),
3027 (bus_driver_handle_list_services), (bus_driver_message_handler):
3028 Implement functions that take care of listing services, and notifying
3029 clients when new services are created.
3031 * bus/services.c: (bus_services_list):
3033 Add new function that returns an array of strings with the currently
3034 registered services.
3037 * glib/dbus-gmain.c:
3038 Update copyright year.
3040 2003-01-25 Anders Carlsson <andersca@codefactory.se>
3042 * dbus/dbus-connection.c: (dbus_connection_send_message):
3043 Unlock the message in case it was sent earlier.
3045 (dbus_connection_send_message_with_reply_and_block):
3046 Remove the reply message from the list.
3048 * dbus/dbus-marshal.c: (_dbus_demarshal_string_array):
3049 Set array_len and new_pos correctly.
3051 (_dbus_marshal_test):
3052 Remove debug output.
3054 * dbus/dbus-message-internal.h:
3055 * dbus/dbus-message.c: (_dbus_message_get_reply_serial):
3056 New function that returns the reply serial.
3058 (_dbus_message_unlock):
3059 New function that unlocks a message and resets its header.
3061 (dbus_message_append_string_array),
3062 (dbus_message_get_fields_valist),
3063 (dbus_message_iter_get_field_type),
3064 (dbus_message_iter_get_string_array),
3065 (dbus_message_get_fields),
3066 (dbus_message_append_fields_valist):
3067 Handle string arrays.
3069 (dbus_message_set_sender):
3070 Make this function public since the bus daemon needs it.
3072 (decode_header_data):
3073 Set the reply serial to -1 initially.
3075 * dbus/dbus-message.h:
3076 Add dbus_message_set_sender.
3078 2003-01-24 Havoc Pennington <hp@pobox.com>
3080 * doc/dbus-specification.sgml: add some stuff
3082 2003-01-22 Havoc Pennington <hp@pobox.com>
3084 * doc/dbus-specification.sgml: Start to document the protocol.
3086 2003-01-22 Havoc Pennington <hp@pobox.com>
3088 * dbus/dbus-connection.c
3089 (dbus_connection_send_message_with_reply_and_block): add some @todo
3091 * bus/driver.c (bus_driver_add_connection): add a FIXME about memleak
3093 2003-01-21 Havoc Pennington <hp@pobox.com>
3095 (patch untested because can't compile)
3097 * bus/driver.c (create_unique_client_name): make this function
3098 never recycle client names. Also, caller should initialize
3101 * dbus/dbus-sysdeps.c (_dbus_get_current_time): new function
3103 2003-01-21 Anders Carlsson <andersca@codefactory.se>
3105 * dbus/dbus-marshal.c: (_dbus_marshal_double),
3106 (_dbus_marshal_int32), (_dbus_marshal_uint32),
3107 (_dbus_marshal_int32_array), (_dbus_marshal_uint32_array),
3108 (_dbus_marshal_double_array), (_dbus_marshal_string_array),
3109 (_dbus_demarshal_int32_array), (_dbus_demarshal_uint32_array),
3110 (_dbus_demarshal_double_array), (_dbus_demarshal_string_array),
3111 (_dbus_marshal_get_field_end_pos), (_dbus_marshal_test):
3112 * dbus/dbus-marshal.h:
3113 * dbus/dbus-protocol.h:
3114 Add support for marshalling and demarshalling integer, double
3117 2003-01-21 Anders Carlsson <andersca@codefactory.se>
3122 * bus/connection.c: (connection_disconnect_handler):
3123 Remove the connection from the bus driver's list.
3125 (connection_watch_callback): Dispatch messages.
3127 (free_connection_data): Free connection name.
3129 (bus_connection_setup): Add connection to the bus driver's list.
3130 (bus_connection_remove_owned_service):
3131 (bus_connection_set_name), (bus_connection_get_name):
3132 Add functions for setting and getting the connection's name.
3135 Add function headers.
3137 * bus/driver.c: (create_unique_client_name),
3138 (bus_driver_handle_hello_message),
3139 (bus_driver_send_welcome_message), (bus_driver_message_handler),
3140 (bus_driver_add_connection), (bus_driver_remove_connection):
3143 * bus/services.c: (bus_service_free):
3145 New file that handles communication and registreation with the bus
3148 2003-01-21 Anders Carlsson <andersca@codefactory.se>
3150 * dbus/dbus-connection.c: (dbus_connection_send_message):
3151 Add a new client_serial parameter.
3153 (dbus_connection_send_message_with_reply):
3154 Remove a @todo since we've implemented the blocking function.
3156 (dbus_connection_send_message_with_reply_and_block):
3157 New function that sends a message and waits for a reply and
3158 then returns the reply.
3160 * dbus/dbus-connection.h:
3163 * dbus/dbus-errors.c: (dbus_result_to_string):
3164 * dbus/dbus-errors.h:
3165 Add new DBUS_RESULT.
3167 * dbus/dbus-message-internal.h:
3168 * dbus/dbus-message.c: (_dbus_message_get_reply_serial),
3169 (_dbus_message_set_sender), (dbus_message_write_header),
3170 (dbus_message_new_reply), (decode_header_data),
3171 (_dbus_message_loader_return_buffer), (_dbus_message_test):
3172 * dbus/dbus-message.h:
3173 Add new functions that set the reply serial and sender.
3174 Also marshal and demarshal them correctly and add test.
3176 * dbus/dbus-protocol.h:
3177 Add new DBUS_MESSAGE_TYPE_SENDER.
3180 * glib/dbus-gmain.c: (watch_callback), (free_callback_data),
3181 (add_watch), (remove_watch), (add_timeout), (remove_timeout),
3182 (dbus_connection_hookup_with_g_main):
3183 * glib/test-dbus-glib.c: (main):
3184 Rewrite to use GIOChannel and remove the GSource crack.
3186 * test/echo-client.c: (main):
3187 * test/watch.c: (check_messages):
3188 Update for changed APIs
3190 2003-01-19 Anders Carlsson <andersca@codefactory.se>
3192 * dbus/Makefile.am: Add dbus-timeout.[cħ]
3194 * dbus/dbus-connection.c: (_dbus_connection_new_for_transport):
3195 Create a DBusTimeoutList.
3196 (dbus_connection_set_timeout_functions): Add new function to
3197 set timeout callbacks
3199 * dbus/dbus-connection.h: Add public DBusTimeout API.
3201 * dbus/dbus-message.c: (dbus_message_get_service):
3202 * dbus/dbus-message.h: New function.
3204 * dbus/dbus-server.c: Fix small doc typo.
3206 * dbus/dbus-timeout.[ch]: New files for mainloop timeouts.
3208 2003-01-19 Anders Carlsson <andersca@codefactory.se>
3210 * dbus/dbus-string.c (_dbus_string_move_len): Don't delete all
3211 of the string, just as long as specified.
3213 2003-01-19 Havoc Pennington <hp@pobox.com>
3215 * dbus/dbus-connection.c (dbus_connection_get_is_authenticated):
3218 * dbus/dbus-server.c (dbus_server_set_max_connections)
3219 (dbus_server_get_max_connections, dbus_server_get_n_connections):
3220 keep track of current number of connections, and add API for
3221 setting a max (but haven't implemented enforcing the max yet)
3223 2003-01-18 Havoc Pennington <hp@pobox.com>
3225 * dbus/dbus-transport-unix.c (unix_do_iteration): only do the
3226 reading/writing if read_watch != NULL or write_watch != NULL.
3228 * dbus/dbus-message.c (_dbus_message_loader_return_buffer): fix
3229 the message loader code to actually load message->header and
3230 message->body into the newly-created message.
3232 * dbus/dbus-transport-unix.c (check_write_watch): fix a mem leak
3235 * dbus/dbus-connection.c (dbus_connection_set_max_message_size)
3236 (dbus_connection_get_max_message_size)
3237 (dbus_connection_set_max_live_messages_size)
3238 (dbus_connection_get_max_live_messages_size): implement some
3239 resource limitation functions
3241 * dbus/dbus-resources.c: new file implementing some of the
3242 resource limits stuff
3244 * dbus/dbus-message.c (dbus_message_iter_get_byte_array): add
3245 missing docs, add @todo to handle OOM etc.
3247 * dbus/dbus-marshal.c (_dbus_demarshal_byte_array): add missing
3250 2003-01-18 Havoc Pennington <hp@pobox.com>
3252 * dbus/dbus-connection.c (dbus_connection_unref): disconnect the
3253 connection if it hasn't been already.
3255 * dbus/dbus-connection.h: kill off the idea of an ErrorFunction,
3256 replace with DisconnectFunction.
3258 2003-01-18 Havoc Pennington <hp@pobox.com>
3260 Building --disable-verbose-mode --disable-asserts --disable-tests
3261 cuts the library from 112K to 45K or so
3263 * configure.in: check for varargs macro support,
3264 add --enable-verbose-mode, --enable-asserts.
3266 * dbus/dbus-internals.h (_dbus_assert): support
3268 (_dbus_verbose): support DBUS_ENABLE_VERBOSE_MODE
3270 2003-01-18 Havoc Pennington <hp@pobox.com>
3272 * dbus/dbus-test.c: include config.h so that tests actually run
3274 * dbus/dbus-string.c: add assertions that stuff is 8-byte aligned,
3275 so the failure mode when that assumption fails will be plenty
3278 2003-01-18 Havoc Pennington <hp@pobox.com>
3280 * configure.in: default --enable-tests to $USE_MAINTAINER_MODE
3282 * dbus/Makefile.am: fix it up so dubs-test-main.c is included in
3285 * test/Makefile.am: don't use special variable "TESTS" for echo-*
3286 since we don't want to use those in make check
3288 2003-01-15 Havoc Pennington <hp@redhat.com>
3294 2003-01-15 Havoc Pennington <hp@redhat.com>
3296 * test/Makefile.am: fix so that test source code ends up in the
3297 distribution on make distcheck
3299 2003-01-15 Havoc Pennington <hp@redhat.com>
3305 2003-01-15 Havoc Pennington <hp@redhat.com>
3307 * dbus/dbus-test.c (dbus_internal_symbol_do_not_use_run_tests):
3308 fix build when --disable-tests
3310 * Makefile.am (EXTRA_DIST): put HACKING in here
3312 * HACKING: document procedure for making a tarball release.
3314 2003-01-14 Anders Carlsson <andersca@codefactory.se>
3316 * bus/connection.c: (connection_error_handler),
3317 (bus_connection_setup):
3318 * bus/main.c: (main):
3319 Make sure that the DBusConnectionData struct is NULLed
3320 out to prevent a segfault.
3322 * dbus/dbus-errors.c: (dbus_result_to_string):
3323 * dbus/dbus-errors.h:
3324 * dbus/dbus-message.c: (dbus_message_get_fields),
3325 (dbus_message_get_fields_valist), (_dbus_message_test):
3326 * dbus/dbus-message.h:
3327 Make dbus_message_get_fields return a result code so we can
3328 track invalid fields as well as oom.
3330 2003-01-11 Havoc Pennington <hp@pobox.com>
3332 * configure.in: change --enable-test/--enable-ansi action-if-given
3333 to enable_foo=$enableval instead of enable_foo=yes
3335 2003-01-08 Havoc Pennington <hp@pobox.com>
3337 * dbus/dbus-string.c (_dbus_string_align_length): new function
3339 * dbus/dbus-test-main.c: move main() for test app here
3341 (dbus_internal_symbol_do_not_use_run_tests): we have to export a
3342 symbol to run tests, because dbus-test isn't in the main
3345 Code review nitpicks.
3347 * dbus/dbus-message.c (dbus_message_write_header): add newlines
3348 for people with narrow emacs ;-). Assert client_serial was filled
3349 in. Assert message->name != NULL.
3350 (dbus_message_append_fields): have "first_field_type" arg separate
3351 from va list, needed for C++ binding that also uses varargs IIRC
3352 and helps with type safety
3353 (dbus_message_new): add @todo about using DBusString to store
3354 service/name internally
3355 (dbus_message_new): don't leak ->service and ->name on OOM later
3357 (dbus_message_unref): free the service name
3358 (dbus_message_get_fields): same change to varargs
3359 i.e. first_field_type
3360 (_dbus_message_loader_return_buffer): assert that the message data
3361 is aligned (if not it's a bug in our code). Put in verbose griping
3362 about why we set corrupted = TRUE.
3363 (decode_header_data): add FIXME that char* is evil. Was going to
3364 add FIXME about evil locale-specific string.h strncmp, but just
3365 switched to wacky string-as-uint32 optimization. Move check for
3366 "no room for field name" above get_const_data_len() to avoid
3367 assertion failure in get_const_data_len if we have trailing 2
3368 bytes or the like. Check for service and name fields being
3369 provided twice. Don't leak service/name on error. Require field
3370 names to be aligned to 4 bytes.
3372 * dbus/dbus-marshal.c: move byte swap stuff to header
3373 (_dbus_pack_int32): uscore-prefix
3374 (_dbus_unpack_int32): uscore-prefix
3375 (_dbus_unpack_uint32): export
3376 (_dbus_demarshal_string): add @todo complaining about use of
3378 (_dbus_marshal_get_field_end_pos): add @todo about bad error
3379 handling allowing corrupt data to go unchecked
3381 2003-01-08 Havoc Pennington <hp@redhat.com>
3383 * dbus/dbus-transport-unix.c (unix_do_iteration): add read/write
3384 to the select() as needed for authentication. (should be using
3385 _dbus_poll() not select, but for another day)
3387 * dbus/dbus.h: include dbus/dbus-protocol.h
3389 2003-01-08 Anders Carlsson <andersca@codefactory.se>
3391 * dbus/Makefile.am (dbusinclude_HEADERS): Install
3394 2003-01-08 Anders Carlsson <andersca@codefactory.se>
3396 * dbus/dbus-internals.c: (_dbus_type_to_string):
3397 New function that returns a string describing a type.
3399 * dbus/dbus-marshal.c: (_dbus_demarshal_byte_array):
3400 * dbus/dbus-marshal.h:
3401 * dbus/dbus-message.c: (dbus_message_get_fields_valist),
3402 (dbus_message_iter_get_field_type), (dbus_message_iter_get_double),
3403 (dbus_message_iter_get_byte_array):
3404 * dbus/dbus-message.h:
3405 Add new convenience functions for appending and getting message fields.
3406 Also add demarshalling routines for byte arrays.
3408 2003-01-07 Anders Carlsson <andersca@codefactory.se>
3410 * dbus/dbus-connection-internal.h:
3411 * dbus/dbus-connection.c: (_dbus_connection_new_for_transport),
3412 (_dbus_connection_get_next_client_serial),
3413 (dbus_connection_send_message):
3414 * dbus/dbus-internals.h:
3415 * dbus/dbus-marshal.c: (unpack_uint32), (dbus_unpack_int32),
3416 (dbus_pack_int32), (_dbus_marshal_double), (_dbus_marshal_int32),
3417 (_dbus_marshal_uint32), (_dbus_demarshal_double),
3418 (_dbus_demarshal_int32), (_dbus_demarshal_uint32),
3419 (_dbus_demarshal_string), (_dbus_marshal_get_field_end_pos),
3420 (_dbus_verbose_bytes), (_dbus_marshal_test):
3421 * dbus/dbus-marshal.h:
3422 * dbus/dbus-message-internal.h:
3423 * dbus/dbus-message.c: (_dbus_message_set_client_serial),
3424 (dbus_message_write_header), (_dbus_message_lock),
3425 (dbus_message_new), (dbus_message_ref), (dbus_message_unref),
3426 (dbus_message_get_name), (dbus_message_append_int32),
3427 (dbus_message_append_uint32), (dbus_message_append_double),
3428 (dbus_message_append_string), (dbus_message_append_byte_array),
3429 (dbus_message_get_fields_iter), (dbus_message_iter_ref),
3430 (dbus_message_iter_unref), (dbus_message_iter_has_next),
3431 (dbus_message_iter_next), (dbus_message_iter_get_field_type),
3432 (dbus_message_iter_get_string), (dbus_message_iter_get_int32),
3433 (dbus_message_iter_get_uint32), (dbus_message_iter_get_double),
3434 (decode_header_data), (_dbus_message_loader_return_buffer),
3435 (message_iter_test), (_dbus_message_test):
3436 * dbus/dbus-message.h:
3437 * dbus/dbus-protocol.h:
3438 * dbus/dbus-test.c: (main):
3440 * glib/test-dbus-glib.c: (message_handler), (main):
3441 * test/echo-client.c: (main):
3442 * test/watch.c: (check_messages):
3443 Make messages sendable and receivable for real.
3445 2003-01-07 Anders Carlsson <andersca@codefactory.se>
3447 * dbus/dbus-marshal.c: (_dbus_marshal_double),
3448 (_dbus_marshal_string), (_dbus_marshal_byte_array):
3449 * dbus/dbus-message.c: (dbus_message_append_int32),
3450 (dbus_message_append_uint32), (dbus_message_append_double),
3451 (dbus_message_append_string), (dbus_message_append_byte_array):
3452 Handle OOM restoration.
3454 2003-01-07 Anders Carlsson <andersca@codefactory.se>
3456 * dbus/dbus-marshal.c: (_dbus_marshal_string),
3457 (_dbus_demarshal_string), (_dbus_marshal_test):
3458 * dbus/dbus-marshal.h:
3459 * dbus/dbus-message.c: (dbus_message_get_name),
3460 Document these functions.
3462 (dbus_message_append_int32), (dbus_message_append_uint32),
3463 (dbus_message_append_double), (dbus_message_append_string),
3464 (dbus_message_append_byte_array):
3465 * dbus/dbus-message.h:
3466 Add functions for adding message fields of different types.
3468 * dbus/dbus-protocol.h:
3469 Add the different types.
3471 2003-01-05 Havoc Pennington <hp@pobox.com>
3473 * bus/connection.c: implement routines for handling connections,
3474 first thing is keeping a list of owned services on each connection
3475 and setting up watches etc.
3477 * bus/services.c: implement a mapping from service names to lists
3480 * dbus/dbus-hash.c: add DBUS_HASH_POINTER
3482 * dbus/dbus-threads.c (dbus_static_mutex_lock): add functions
3483 to use static mutexes for global data
3485 * dbus/dbus-connection.c (dbus_connection_set_data): add new
3486 collection of functions to set/get application-specific data
3487 on the DBusConnection.
3489 2003-01-04 Havoc Pennington <hp@pobox.com>
3491 * dbus/dbus-sysdeps.c (_dbus_sleep_milliseconds): new function
3492 (_dbus_poll): new function
3494 * dbus/dbus-internals.h (_DBUS_STRUCT_OFFSET): new macro
3497 * bus/loop.c: initial code for the daemon main loop
3499 2003-01-04 Havoc Pennington <hp@pobox.com>
3501 * test/watch.c (error_handler): make it safe if the error handler
3502 is called multiple times (if we s/error handler/disconnect
3503 handler/ we should just guarantee it's called only once)
3505 * dbus/dbus-transport.c (_dbus_transport_disconnect): call the
3506 error handler on disconnect (it's quite possible we should
3507 just change the error handler to a "disconnect handler," I'm
3508 not sure we have any other meaningful errors)
3510 * configure.in: check for getpwnam_r
3512 * dbus/dbus-transport.c, dbus/dbus-transport-unix.c,
3513 dbus/dbus-auth.c: add credentials support, add EXTERNAL auth
3514 mechanism as in SASL spec, using socket credentials
3516 * dbus/dbus-sysdeps.c (_dbus_read_credentials_unix_socket): new function
3517 (_dbus_send_credentials_unix_socket): new function
3519 * dbus/dbus-sysdeps.c (_dbus_accept_unix_socket): rename just
3521 (_dbus_write): only check errno if <0 returned
3522 (_dbus_write_two): ditto
3524 2003-01-02 Anders Carlsson <andersca@codefactory.se>
3526 * dbus/dbus-marshal.c: (_dbus_marshal_utf8_string),
3527 (_dbus_marshal_byte_array), (_dbus_demarshal_utf8_string),
3528 (_dbus_marshal_test):
3529 * dbus/dbus-marshal.h:
3530 Add _dbus_marshal_byte_array and rename _dbus_marshal_string
3531 to _dbus_marshal_utf8_string. Also fix some tests.
3533 2002-12-28 Harri Porten <porten@kde.org>
3535 * configure.in: added check for C++ compiler and a very cheesy
3536 check for the Qt integration
3538 * Makefile.am (SUBDIRS): compile qt subdir if support is enabled
3540 * qt/Makefile.am: added
3542 * qt/.cvsignore: added
3544 * qt/dbus-qthread.cc, qt/dbus-qthread.cpp: renamed former to
3545 latter, added #ifdef QT_THREAD_SUPPORT guard.
3547 * dbus/Makefile.am: added missing headers for make dist
3549 2002-12-28 Kristian Rietveld <kris@gtk.org>
3551 * dbus/Makefile.am: fixup export-symbols-regex.
3553 2002-12-27 Anders Carlsson <andersca@codefactory.se>
3555 * acinclude.m4: Add this file and put the
3556 PKG_CHECK_MODULE macro in it.
3558 2002-12-27 Anders Carlsson <andersca@codefactory.se>
3560 * dbus/dbus-marshal.c: (_dbus_marshal_string),
3561 (_dbus_demarshal_double), (_dbus_demarshal_int32),
3562 (_dbus_demarshal_uint32), (_dbus_demarshal_string),
3563 (_dbus_marshal_test):
3564 Make the demarshalling routines align the pos argument.
3565 Add string marshalling tests and fix the obvious bugs
3568 2002-12-26 Havoc Pennington <hp@pobox.com>
3570 * dbus/dbus-auth.c: fixes fixes fixes
3572 * dbus/dbus-transport-unix.c: wire up support for
3573 encoding/decoding data on the wire
3575 * dbus/dbus-auth.c (_dbus_auth_encode_data)
3576 (_dbus_auth_decode_data): append to target string
3577 instead of nuking it.
3579 2002-12-26 Havoc Pennington <hp@pobox.com>
3581 * dbus/dbus-marshal.h (DBUS_COMPILER_BYTE_ORDER): #ifdef
3582 WORDS_BIGENDIAN then compiler byte order is DBUS_BIG_ENDIAN,
3585 * dbus/dbus-marshal.c: Add macros to do int swapping in-place and
3586 avoid swap_bytes() overhead (ignoring possible assembly stuff for
3587 now). Main point is because I wanted unpack_uint32 to implement
3589 (_dbus_verbose_bytes): new function
3591 * dbus/dbus-string.c (_dbus_string_validate_ascii): new function
3593 * dbus/dbus-message.c (_dbus_message_loader_get_is_corrupted): add
3594 mechanism to handle a corrupt message stream
3595 (_dbus_message_loader_new): fix preallocation to only prealloc,
3598 * dbus/dbus-string.c (_dbus_string_skip_blank): fix this function
3599 (_dbus_string_test): enhance tests for copy/move and fix the
3602 * dbus/dbus-transport-unix.c: Hold references in more places to
3603 avoid reentrancy problems
3605 * dbus/dbus-transport.c: ditto
3607 * dbus/dbus-connection.c (dbus_connection_dispatch_message): don't
3608 leak reference count in no-message case
3610 * test/watch.c (do_mainloop): handle adding/removing watches
3611 during iteration over the watches. Also, ref the connection/server
3612 stored on a watch, so we don't try to mangle a destroyed one.
3614 * dbus/dbus-transport-unix.c (do_authentication): perform
3617 * dbus/dbus-auth.c (get_state): add a state
3618 AUTHENTICATED_WITH_UNUSED_BYTES and return it if required
3619 (_dbus_auth_get_unused_bytes): append the unused bytes
3620 to the passed in string, rather than prepend
3622 * dbus/dbus-transport.c (_dbus_transport_init_base): create
3623 the auth conversation DBusAuth
3625 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_fd)
3626 (_dbus_transport_new_for_domain_socket): when creating a
3627 transport, pass in whether it's a client-side or server-side
3628 transport so we know which DBusAuth to create
3630 2002-12-03 Havoc Pennington <hp@pobox.com>
3632 * dbus/dbus-transport-unix.c (unix_finalize): finalize base
3633 _after_ finalizing the derived members
3634 (unix_connection_set): unref watch if we fail to add it
3636 * dbus/dbus-connection.c (dbus_connection_unref): delete the
3637 transport first, so that the connection owned by the
3638 transport will be valid as the transport finalizes.
3640 * dbus/dbus-transport-unix.c (unix_finalize): free the write_watch
3641 if necessary, and remove watches from the connection.
3643 * dbus/dbus-watch.c (_dbus_watch_list_free): improve a comment
3645 2002-12-26 Anders Carlsson <andersca@codefactory.se>
3647 * dbus/dbus-marshal.c: (_dbus_marshal_string),
3648 (_dbus_demarshal_double), (_dbus_demarshal_int32),
3649 (_dbus_demarshal_uint32), (_dbus_demarshal_string),
3650 (_dbus_marshal_test):
3651 * dbus/dbus-marshal.h:
3652 Add string marshal functions and have the demarshal functions
3653 return the new position.
3655 2002-12-25 Havoc Pennington <hp@pobox.com>
3657 * doc/dbus-sasl-profile.txt: docs on the authentication protocol,
3658 it is a simple protocol that just maps directly to SASL.
3660 * dbus/dbus-auth.h, dbus/dbus-auth.c: authentication protocol
3661 initial implementation, not actually used yet.
3663 * dbus/dbus-string.c (_dbus_string_find): new function
3664 (_dbus_string_equal): new function
3665 (_dbus_string_base64_encode): new function
3666 (_dbus_string_base64_decode): new function
3668 2002-12-25 Anders Carlsson <andersca@codefactory.se>
3671 * dbus/dbus-marshal.c: (swap_bytes), (_dbus_marshal_double),
3672 (_dbus_marshal_int32), (_dbus_marshal_uint32),
3673 (_dbus_demarshal_double), (_dbus_demarshal_int32),
3674 (_dbus_demarshal_uint32), (_dbus_marshal_test):
3675 * dbus/dbus-marshal.h:
3676 * dbus/dbus-protocol.h:
3677 * dbus/dbus-test.c: (main):
3679 Add un-optimized marshalling/demarshalling routines.
3681 2002-12-25 Harri Porten <porten@kde.org>
3683 * qt/dbus-qt.h: adjusted ctor and getter to KDE/Qt conventions
3685 2002-12-24 Zack Rusin <zack@kde.org>
3687 * qt/dbus-qthread.cc: adding - integrates QMutex into Dbus
3688 * qt/dbus-qt.h: skeleton with two sample implemenatation of the
3691 2002-12-24 Havoc Pennington <hp@pobox.com>
3693 * glib/dbus-gthread.c: fix include
3695 * glib/dbus-glib.h: rename DBusMessageHandler for now.
3696 I think glib API needs to change, though, as you don't
3697 want to use DBusMessageFunction, you want to use the
3698 DBusMessageHandler object. Probably
3699 dbus_connection_open_with_g_main_loop()
3700 and dbus_connection_setup_g_main_loop() or something like that
3701 (but think of better names...) that just create a connection
3702 that has watch/timeout functions etc. already set up.
3704 * dbus/dbus-connection.c
3705 (dbus_connection_send_message_with_reply): new function just to
3706 show how the message handler helps us deal with replies.
3708 * dbus/dbus-list.c (_dbus_list_remove_last): new function
3710 * dbus/dbus-string.c (_dbus_string_test): free a string that
3713 * dbus/dbus-hash.c: use memory pools for the hash entries
3714 (rebuild_table): be more paranoid about overflow, and
3715 shrink table when we can
3716 (_dbus_hash_test): reduce number of sprintfs and write
3717 valid C89. Add tests for case where we grow and then
3718 shrink the hash table.
3720 * dbus/dbus-mempool.h, dbus/dbus-mempool.c: memory pools
3722 * dbus/dbus-connection.c (dbus_connection_register_handler)
3723 (dbus_connection_unregister_handler): new functions
3725 * dbus/dbus-message.c (dbus_message_get_name): new
3727 * dbus/dbus-list.c: fix docs typo
3729 * dbus/dbus-message-handler.h, dbus/dbus-message-handler.c:
3730 an object representing a handler for messages.
3732 2002-12-16 Anders Carlsson <andersca@codefactory.se>
3735 * glib/dbus-gthread.c: (dbus_gthread_init):
3736 Don't use the gdbus prefix for public functions.
3738 2002-12-16 Anders Carlsson <andersca@codefactory.se>
3742 Add GLib checks and fixup .pc files
3746 * glib/dbus-gmain.c: (gdbus_connection_prepare),
3747 (gdbus_connection_check), (gdbus_connection_dispatch),
3748 (gdbus_add_connection_watch), (gdbus_remove_connection_watch),
3749 (dbus_connection_gsource_new):
3750 * glib/dbus-gthread.c: (dbus_gmutex_new), (dbus_gmutex_free),
3751 (dbus_gmutex_lock), (dbus_gmutex_unlock), (dbus_gthread_init):
3752 * glib/test-dbus-glib.c: (message_handler), (main):
3755 2002-12-15 Harri Porten <porten@kde.org>
3757 * autogen.sh: check for libtoolize before attempting to use it
3759 * dbus/dbus-transport-unix.c: include <sys/time.h> for timeval
3762 * .cvsignore: ignore more stamp files
3764 * dbus/dbus-watch.c (_dbus_watch_list_new): fixed doc error
3766 * test/Makefile.am: added -I$(top_srcdir) to be able to compile
3767 without make install.
3769 2002-12-15 Havoc Pennington <hp@pobox.com>
3771 * dbus/dbus-threads.c: add thread stubs that a higher library
3772 layer can fill in. e.g. the GLib wrapper might fill them in with
3773 GThread stuff. We still need to use this thread API to
3774 thread-safe-ize the library.
3776 2002-12-12 Havoc Pennington <hp@pobox.com>
3778 * dbus/dbus-transport-unix.c, dbus/dbus-server-unix.c: use the
3779 below new interfaces and include fewer system headers.
3781 * dbus/dbus-sysdeps.c (_dbus_read): new function
3782 (_dbus_write): new function
3783 (_dbus_write_two): new function
3784 (_dbus_connect_unix_socket): new function
3785 (_dbus_listen_unix_socket): new function
3787 * dbus/dbus-message-internal.h: change interfaces to use
3790 2002-12-11 Havoc Pennington <hp@pobox.com>
3792 * dbus/dbus-types.h: add dbus_unichar
3794 * dbus/dbus-internals.c (_dbus_verbose): use _dbus_getenv
3796 * dbus/dbus-connection.c (dbus_connection_send_message): return
3799 * dbus/dbus-transport.c: include dbus-watch.h
3801 * dbus/dbus-connection.c: include dbus-message-internal.h
3803 * HACKING: add file with coding guidelines stuff.
3805 * dbus/dbus-string.h, dbus/dbus-string.c: Encapsulate all string
3806 handling here, for security purposes (as in vsftpd). Not actually
3807 using this class yet.
3809 * dbus/dbus-sysdeps.h, dbus/dbus-sysdeps.c: Encapsulate all
3810 system/libc usage here, as in vsftpd, for ease of auditing (and
3811 should also simplify portability). Haven't actually moved all the
3812 system/libc usage into here yet.
3814 2002-11-25 Havoc Pennington <hp@pobox.com>
3816 * dbus/dbus-internals.c (_dbus_verbose): fix to not
3817 always print the first verbose message.
3819 2002-11-24 Havoc Pennington <hp@pobox.com>
3821 * test/echo-client.c, test/echo-server.c: cheesy test
3824 * configure.in (AC_CHECK_FUNCS): check for writev
3826 * dbus/dbus-message.c (_dbus_message_get_network_data): new
3829 * dbus/dbus-list.c (_dbus_list_foreach): new function
3831 * dbus/dbus-internals.c (_dbus_verbose): new function
3833 * dbus/dbus-server.c, dbus/dbus-server.h: public object
3834 representing a server that listens for connections.
3836 * dbus/.cvsignore: create
3838 * dbus/dbus-errors.h, dbus/dbus-errors.c:
3839 public API for reporting errors
3841 * dbus/dbus-connection.h, dbus/dbus-connection.c:
3842 public object representing a connection that
3843 sends/receives messages. (Same object used for
3844 both client and server.)
3846 * dbus/dbus-transport.h, dbus/dbus-transport.c:
3847 Basic abstraction for different kinds of stream
3848 that we might read/write messages from.
3850 2002-11-23 Havoc Pennington <hp@pobox.com>
3852 * dbus/dbus-internals.h (_DBUS_INT_MAX): add _DBUS_INT_MIN
3855 * dbus/dbus-test.c (main): add list test, and include
3856 dbus-test.h as intended
3858 * dbus/dbus-hash.c (_dbus_hash_table_remove_string)
3859 (_dbus_hash_table_remove_int): return value indicates
3860 whether the entry existed to remove
3862 * dbus/dbus-list.c: add linked list utility class,
3865 * dbus/dbus-hash.c: add TODO item about shrinking the hash bucket
3868 2002-11-23 Havoc Pennington <hp@pobox.com>
3870 * Doxyfile.in (INCLUDE_FILE_PATTERNS): expand DBUS_BEGIN_DECLS/
3871 DBUS_END_DECLS to nothing, that should fix this once and for all
3873 * Doxyfile.in (JAVADOC_AUTOBRIEF): set to YES
3875 * dbus/dbus-message.c, dbus/dbus-hash.c:
3876 add some missing @brief
3878 2002-11-23 Havoc Pennington <hp@pobox.com>
3880 * dbus/dbus-message.h: put semicolons after DEBUG_BEGIN_DECLS
3881 to avoid confusing Doxygen
3883 * dbus/dbus-hash.c: @} not }@
3885 * dbus/dbus-message.c (struct DBusMessage): split out
3888 2002-11-23 Havoc Pennington <hp@pobox.com>
3890 * configure.in: pile on more warning flags if using gcc
3892 * Doxyfile.in (EXTRACT_STATIC): set to NO, so we don't have
3893 to document static functions
3895 * configure.in: add summary to end of configure so it
3896 looks nice and attractive
3898 * dbus/dbus-hash.c: finish implementation and write unit
3901 * configure.in: add --enable-tests to enable unit tests
3903 * dbus/dbus-test.c: test program to run unit tests
3904 for all files in dbus/*, initially runs a test for
3907 * dbus/dbus-internals.h: file to hold some internal utility stuff
3909 2002-11-22 Havoc Pennington <hp@redhat.com>
3911 * dbus/dbus-hash.c: copy in Tcl hash table, not yet
3912 "ported" away from Tcl
3914 * dbus/dbus-types.h: header for types such as dbus_bool_t
3916 2002-11-22 Havoc Pennington <hp@redhat.com>
3918 * dbus/dbus.h: fixups for doc warnings
3920 * Doxyfile.in (FILE_PATTERNS): we need to scan .h to pick up
3922 (QUIET): make it quiet so we can see warnings
3924 * dbus/dbus-memory.c: teach D-BUS to allocate and free memory
3926 2002-11-22 Havoc Pennington <hp@redhat.com>
3928 * Makefile.am: include "Doxyfile" target in all-local
3930 * configure.in: generate the Doxyfile
3932 * Doxyfile.in: move Doxyfile here, so we can use
3933 configure to generate a Doxyfile with the right
3936 2002-11-22 Havoc Pennington <hp@redhat.com>
3938 * dbus/dbus-message.c: move inline docs into .c file
3940 * Doxyfile (OUTPUT_DIRECTORY): move output to doc/api
3941 so all docs are under doc/
3942 (MAN_EXTENSION): generate man pages. Use extension
3943 ".3dbus" which matches ".3qt" on my system,
3944 I guess this is OK, I don't know really.
3945 (FILE_PATTERNS): look for .c files not .h, makes sense
3948 2002-11-22 Havoc Pennington <hp@pobox.com>
3950 * Makefile.am (SUBDIRS): rename subdir "server" to "bus"
3951 because any app can be a server, and any app can be a client,
3952 the bus is a special kind of server.
3954 Thu Nov 21 23:35:31 2002 Zack Rusin <zack@kde.org>
3956 * Doxyfile : adding. Still needs Makefile rules to be generated
3957 automatically (just run "doxygen" in the toplevel dir for now to
3960 * dbus/dbus-message.h : Adding sample docs (javadoc since
3961 resembles gtk-doc a little more)
3963 * dbus/dbus.h : Adding sample docs
3965 2002-11-21 Havoc Pennington <hp@redhat.com>
3967 * dbus/Makefile.am (INCLUDES): define DBUS_COMPILATION
3968 so we can allow ourselves to include files directly,
3969 instead of having to use dbus.h
3971 * dbus/dbus.h: fill in
3973 * dbus/dbus-message.h: sketch out a sample header file.
3974 Include griping if you include it directly instead of
3977 * dbus/dbus-macros.h: new file with macros for extern "C",
3978 TRUE/FALSE, NULL, etc.
3980 * doc/file-boilerplate.c: put include guards in here
3982 2002-11-21 Havoc Pennington <hp@redhat.com>
3984 * doc/file-boilerplate.c: include both AFL and GPL boilerplate.
3986 * COPYING: include the GPL as well, and license code
3987 under both AFL and GPL.
3989 2002-11-21 Havoc Pennington <hp@redhat.com>
3991 * acconfig.h: get rid of this
3993 * autogen.sh (run_configure): add --no-configure option
3995 * configure.in: remove AC_ARG_PROGRAM to make
3996 autoconf complain less. add AC_PREREQ.
3997 add AC_DEFINE third arg.
3999 2002-11-21 Anders Carlsson <andersca@codefactory.se>
4002 Fix references so we can distcheck.
4004 2002-11-21 Havoc Pennington <hp@redhat.com>
4006 * Initial module creation