net/phy: Fix phy_connect() for phy addr 0
[platform/kernel/u-boot.git] / .travis.yml
1 # SPDX-License-Identifier: GPL-2.0+
2 # Copyright Roger Meier <r.meier@siemens.com>
3
4 # build U-Boot on Travis CI - https://travis-ci.org/
5
6 sudo: required
7 dist: bionic
8
9 language: c
10
11 addons:
12   apt:
13     sources:
14     - ubuntu-toolchain-r-test
15     - llvm-toolchain-bionic-7
16     packages:
17     - cppcheck
18     - sloccount
19     - sparse
20     - bc
21     - build-essential
22     - libsdl1.2-dev
23     - python
24     - python-pyelftools
25     - python3-virtualenv
26     - python3-pip
27     - swig
28     - libpython-dev
29     - iasl
30     - grub-efi-ia32-bin
31     - grub-efi-amd64-bin
32     - rpm2cpio
33     - wget
34     - device-tree-compiler
35     - lzop
36     - liblz4-tool
37     - lzma-alone
38     - libisl15
39     - clang-7
40     - srecord
41
42 install:
43  # Clone uboot-test-hooks
44  - git clone --depth=1 git://github.com/swarren/uboot-test-hooks.git /tmp/uboot-test-hooks
45  - ln -s travis-ci /tmp/uboot-test-hooks/bin/`hostname`
46  - ln -s travis-ci /tmp/uboot-test-hooks/py/`hostname`
47  # prepare buildman environment
48  - echo -e "[toolchain]\nroot = /usr" > ~/.buildman
49  - echo -e "arc = /tmp/arc_gnu_2018.09_prebuilt_uclibc_le_archs_linux_install" >> ~/.buildman
50  - echo -e "\n[toolchain-alias]\nsh = sh2" >> ~/.buildman
51  - echo -e "x86 = i386" >> ~/.buildman;
52  - echo -e "riscv = riscv64" >> ~/.buildman;
53  - cat ~/.buildman
54  - grub-mkimage --prefix="" -o ~/grub_x86.efi -O i386-efi normal  echo lsefimmap lsefi lsefisystab efinet tftp minicmd
55  - grub-mkimage --prefix="" -o ~/grub_x64.efi -O x86_64-efi normal  echo lsefimmap lsefi lsefisystab efinet tftp minicmd
56  - mkdir ~/grub2-arm
57  - ( cd ~/grub2-arm; wget -O - http://download.opensuse.org/ports/armv7hl/distribution/leap/42.2/repo/oss/suse/armv7hl/grub2-arm-efi-2.02~beta2-87.1.armv7hl.rpm | rpm2cpio | cpio -di )
58  - mkdir ~/grub2-arm64
59  - ( cd ~/grub2-arm64; wget -O - http://download.opensuse.org/ports/aarch64/distribution/leap/42.2/repo/oss/suse/aarch64/grub2-arm64-efi-2.02~beta2-87.1.aarch64.rpm | rpm2cpio | cpio -di )
60  - wget http://mirrors.kernel.org/ubuntu/pool/main/m/mpfr4/libmpfr4_3.1.4-1_amd64.deb && sudo dpkg -i libmpfr4_3.1.4-1_amd64.deb && rm libmpfr4_3.1.4-1_amd64.deb
61
62 env:
63   global:
64     - PATH=/tmp/qemu-install/bin:/tmp/uboot-test-hooks/bin:/usr/bin:/bin:/usr/local/bin
65     - PYTHONPATH=/tmp/uboot-test-hooks/py/travis-ci
66     - BUILD_DIR=build
67     - HOSTCC="cc"
68     - HOSTCXX="c++"
69     - QEMU_VERSION="v3.1.0"
70
71 before_script:
72   # install toolchains based on TOOLCHAIN} variable
73   - if [[ "${TOOLCHAIN}" == *m68k* ]]; then ./tools/buildman/buildman --fetch-arch m68k ; fi
74   - if [[ "${TOOLCHAIN}" == *microblaze* ]]; then ./tools/buildman/buildman --fetch-arch microblaze ; fi
75   - if [[ "${TOOLCHAIN}" == *mips* ]]; then ./tools/buildman/buildman --fetch-arch mips ; fi
76   - if [[ "${TOOLCHAIN}" == *sh* ]]; then ./tools/buildman/buildman --fetch-arch sh2 ; fi
77   - if [[ "${TOOLCHAIN}" == *i386* ]]; then
78       ./tools/buildman/buildman --fetch-arch i386;
79     fi
80   - if [[ "${TOOLCHAIN}" == arc ]]; then
81        wget https://github.com/foss-for-synopsys-dwc-arc-processors/toolchain/releases/download/arc-2018.09-release/arc_gnu_2018.09_prebuilt_uclibc_le_archs_linux_install.tar.gz &&
82        tar -C /tmp -xf arc_gnu_2018.09_prebuilt_uclibc_le_archs_linux_install.tar.gz;
83     fi
84   - if [[ "${TOOLCHAIN}" == "nds32" ]]; then
85        wget https://github.com/vincentzwc/prebuilt-nds32-toolchain/releases/download/20180521/nds32le-linux-glibc-v3-upstream.tar.gz &&
86        tar -C /tmp -xf nds32le-linux-glibc-v3-upstream.tar.gz &&
87        echo -e "\n[toolchain-prefix]\nnds32 = /tmp/nds32le-linux-glibc-v3-upstream/bin/nds32le-linux-" >> ~/.buildman;
88     fi
89   - if [[ "${TOOLCHAIN}" == *xtensa* ]]; then
90        wget https://github.com/foss-xtensa/toolchain/releases/download/2018.02/x86_64-2018.02-${TOOLCHAIN}.tar.gz &&
91        tar -C /tmp -xf x86_64-2018.02-${TOOLCHAIN}.tar.gz &&
92        echo -e "\n[toolchain-prefix]\nxtensa = /tmp/2018.02/${TOOLCHAIN}/bin/${TOOLCHAIN}-" >> ~/.buildman;
93     fi
94   # If TOOLCHAIN is unset, we're on some flavour of ARM.
95   - if [[ "${TOOLCHAIN}" == "" ]]; then
96        ./tools/buildman/buildman --fetch-arch arm &&
97        ./tools/buildman/buildman --fetch-arch aarch64;
98     fi
99   - if [[ "${TOOLCHAIN}" == "powerpc" ]]; then ./tools/buildman/buildman --fetch-arch powerpc; fi
100   - if [[ "${TOOLCHAIN}" == "riscv" ]]; then
101        ./tools/buildman/buildman --fetch-arch riscv64;
102     fi
103   - if [[ "${QEMU_TARGET}" != "" ]]; then
104        git clone git://git.qemu.org/qemu.git /tmp/qemu;
105        pushd /tmp/qemu;
106        git submodule update --init dtc &&
107        git checkout ${QEMU_VERSION} &&
108        ./configure --prefix=/tmp/qemu-install --target-list=${QEMU_TARGET} &&
109        make -j4 all install;
110        popd;
111     fi
112
113 script:
114  # Comments must be outside the command strings below, or the Travis parser
115  # will get confused.
116  #
117  # From buildman, exit code 129 means warnings only.  If we've been asked to
118  # use clang only do one configuration.
119  - if [[ "${BUILDMAN}" != "" ]]; then
120      ret=0;
121      tools/buildman/buildman -P -E ${BUILDMAN} ${OVERRIDE}|| ret=$?;
122      if [[ $ret -ne 0 && $ret -ne 129 ]]; then
123        tools/buildman/buildman -sdeP ${BUILDMAN};
124        exit $ret;
125      fi;
126    fi
127  # "not a_test_which_does_not_exist" is a dummy -k parameter which will
128  # never prevent any test from running. That way, we can always pass
129  # "-k something" even when $TEST_PY_TEST_SPEC doesnt need a custom
130  # value.
131  - export UBOOT_TRAVIS_BUILD_DIR=`cd .. && pwd`/.bm-work/${TEST_PY_BD};
132    cp ~/grub_x86.efi $UBOOT_TRAVIS_BUILD_DIR/;
133    cp ~/grub_x64.efi $UBOOT_TRAVIS_BUILD_DIR/;
134    cp ~/grub2-arm/usr/lib/grub2/arm-efi/grub.efi $UBOOT_TRAVIS_BUILD_DIR/grub_arm.efi;
135    cp ~/grub2-arm64/usr/lib/grub2/arm64-efi/grub.efi $UBOOT_TRAVIS_BUILD_DIR/grub_arm64.efi;
136    if [[ -n "${TEST_PY_TOOLS}" ]]; then
137      PYTHONPATH="${UBOOT_TRAVIS_BUILD_DIR}/scripts/dtc/pylibfdt"
138      PATH="${UBOOT_TRAVIS_BUILD_DIR}/scripts/dtc:${PATH}"
139      ./tools/binman/binman --toolpath ${UBOOT_TRAVIS_BUILD_DIR}/tools test &&
140      ./tools/patman/patman --test &&
141      ./tools/buildman/buildman -t &&
142      PYTHONPATH="${UBOOT_TRAVIS_BUILD_DIR}/scripts/dtc/pylibfdt"
143      PATH="${UBOOT_TRAVIS_BUILD_DIR}/scripts/dtc:${PATH}"
144      ./tools/dtoc/dtoc -t;
145    fi;
146    if [[ "${TEST_PY_BD}" != "" ]]; then
147      virtualenv -p /usr/bin/python3 /tmp/venv;
148      . /tmp/venv/bin/activate;
149      pip install -r test/py/requirements.txt;
150      ./test/py/test.py --bd ${TEST_PY_BD} ${TEST_PY_ID}
151        -k "${TEST_PY_TEST_SPEC:-not a_test_which_does_not_exist}"
152        --build-dir "$UBOOT_TRAVIS_BUILD_DIR";
153      ret=$?;
154      if [[ $ret -ne 0 ]]; then
155        exit $ret;
156      fi;
157    fi
158
159 matrix:
160   include:
161   # we need to build by vendor due to 50min time limit for builds
162   # each env setting here is a dedicated build
163     - name: "buildman arc"
164       env:
165         - BUILDMAN="arc"
166           TOOLCHAIN="arc"
167     - name: "buildman arm11 arm7 arm920t arm946es"
168       env:
169         - BUILDMAN="arm11 arm7 arm920t arm946es"
170     - name: "buildman arm926ejs (non-NXP,siemens,at91,kirkwood,spear)"
171       env:
172         - JOB="arm926ejs"
173           BUILDMAN="arm926ejs -x freescale,siemens,at91,kirkwood,spear,omap"
174     - name: "buildman at91 (non arm v7)"
175       env:
176         - BUILDMAN="at91 -x armv7"
177     - name: "buildman at91 (non arm926ejs)"
178       env:
179         - BUILDMAN="at91 -x arm926ejs"
180     - name: "buildman boundary engicam toradex"
181       env:
182         - BUILDMAN="boundary engicam toradex"
183     - name: "buildman ARM bcm"
184       env:
185         - BUILDMAN="bcm -x mips"
186     - name: "buildman NXP ARM32 (catch-all)"
187       env:
188         - BUILDMAN="freescale -x powerpc,m68k,aarch64,ls101,ls102,ls104,ls108,ls20,lx216"
189     - name: "buildman NXP LS101x"
190       env:
191         - BUILDMAN="freescale&ls101"
192     - name: "buildman NXP LS102x"
193       env:
194         - BUILDMAN="freescale&ls102"
195     - name: "buildman NXP LS104x"
196       env:
197         - BUILDMAN="freescale&ls104"
198     - name: "buildman NXP LS108x"
199       env:
200         - BUILDMAN="freescale&ls108"
201     - name: "buildman NXP LS20xx"
202       env:
203         - BUILDMAN="freescale&ls20"
204     - name: "buildman NXP LX216x"
205       env:
206         - BUILDMAN="freescale&lx216"
207     - name: "buildman i.MX6 tqc"
208       env:
209         - BUILDMAN="mx6&tqc"
210     - name: "buildman i.MX6 (catch-all)"
211       env:
212         - BUILDMAN="mx6 -x boundary,engicam,freescale,technexion,toradex,tqc"
213     - name: "buildman i.MX (non-i.MX6 catch-all)"
214       env:
215         - BUILDMAN="mx -x freescale,mx6,toradex,technexion"
216     - name: "buildman keystone 2/3"
217       env:
218         - BUILDMAN="k2 k3"
219     - name: "buildman samsung socfpga"
220       env:
221         - BUILDMAN="samsung socfpga"
222     - name: "buildman spear"
223       env:
224         - BUILDMAN="spear"
225     - name: "buildman sun4i"
226       env:
227         - BUILDMAN="sun4i"
228     - name: "buildman sun5i"
229       env:
230         - BUILDMAN="sun5i"
231     - name: "buildman sun6i"
232       env:
233         - BUILDMAN="sun6i"
234     - name: "buildman sun7i"
235       env:
236         - BUILDMAN="sun7i"
237     - name: "buildman 64bit sun8i"
238       env:
239         - BUILDMAN="sun8i&aarch64 -x orangepi"
240     - name: "buildman 32bit sun8i"
241       env:
242         - BUILDMAN="sun8i&armv7 -x orangepi"
243     - name: "buildman sun9i"
244       env:
245         - BUILDMAN="sun9i"
246     - name: "buildman sun50i"
247       env:
248         - BUILDMAN="sun50i -x orangepi"
249     - name: "buildman catch-all ARM"
250       env:
251         - BUILDMAN="arm -x arm11,arm7,arm9,aarch64,at91,bcm,freescale,kirkwood,mvebu,siemens,tegra,uniphier,mx,samsung,sunxi,am33xx,omap,rockchip,toradex,socfpga,k2,k3,zynq"
252     - name: "buildman sandbox x86"
253       env:
254         - BUILDMAN="sandbox x86"
255           TOOLCHAIN="i386"
256     - name: "buildman technexion"
257       env:
258         - BUILDMAN="technexion"
259     - name: "buildman kirkwood"
260       env:
261         - BUILDMAN="kirkwood"
262     - name: "buildman mvebu"
263       env:
264         - BUILDMAN="mvebu"
265     - name: "buildman m68k"
266       env:
267         - BUILDMAN="m68k"
268           TOOLCHAIN="m68k"
269     - name: "buildman microblaze"
270       env:
271         - BUILDMAN="microblaze"
272           TOOLCHAIN="microblaze"
273     - name: "buildman mips"
274       env:
275         - BUILDMAN="mips"
276           TOOLCHAIN="mips"
277     - name: "buildman non-Freescale PowerPC"
278       env:
279         - BUILDMAN="powerpc -x freescale"
280           TOOLCHAIN="powerpc"
281     - name: "buildman mpc85xx&freescale (excluding many)"
282       env:
283         - BUILDMAN="mpc85xx&freescale -x t208xrdb -x t4qds -x t102* -x p1_p2_rdb_pc -x p1010rdb -x corenet_ds -x b4860qds -x bsc91*"
284           TOOLCHAIN="powerpc"
285     - name: "buildman t208xrdb corenet_ds"
286       env:
287         - BUILDMAN="t208xrdb corenet_ds"
288           TOOLCHAIN="powerpc"
289     - name: "buildman Freescale PowerPC"
290       env:
291         - BUILDMAN="t4qds b4860qds mpc83xx&freescale mpc86xx&freescale"
292           TOOLCHAIN="powerpc"
293     - name: "buildman t102*"
294       env:
295         - BUILDMAN="t102*"
296           TOOLCHAIN="powerpc"
297     - name: "buildman p1_p2_rdb_pc"
298       env:
299         - BUILDMAN="p1_p2_rdb_pc"
300           TOOLCHAIN="powerpc"
301     - name: "buildman p1010rdb bsc91"
302       env:
303         - BUILDMAN="p1010rdb bsc91"
304           TOOLCHAIN="powerpc"
305     - name: "buildman siemens"
306       env:
307         - BUILDMAN="siemens"
308     - name: "buildman tegra"
309       env:
310         - BUILDMAN="tegra -x toradex"
311     - name: "buildman am33xx (no siemens)"
312       env:
313         - BUILDMAN="am33xx -x siemens"
314     - name: "buildman omap"
315       env:
316         - BUILDMAN="omap"
317     - name: "buildman orangepi"
318       env:
319         - BUILDMAN="orangepi"
320     - name: "buildman uniphier"
321       env:
322         - BUILDMAN="uniphier"
323     - name: "buildman catch-all AArch64"
324       env:
325         - BUILDMAN="aarch64 -x bcm,k3,tegra,ls1,ls2,mvebu,uniphier,sunxi,samsung,rockchip,versal,zynq"
326     - name: "buildman rockchip"
327       env:
328         - BUILDMAN="rockchip -x orangepi"
329     - name: "buildman sh"
330       env:
331         - BUILDMAN="sh -x arm"
332           TOOLCHAIN="sh"
333     - name: "buildman Zynq* (ARMv7)"
334       env:
335         - BUILDMAN="zynq&armv7"
336     - name: "buildman ZynqMP and Versal"
337       env:
338         - BUILDMAN="versal|zynqmp&aarch64"
339     - name: "buildman xtensa"
340       env:
341         - BUILDMAN="xtensa"
342           TOOLCHAIN="xtensa-dc233c-elf"
343     - name: "buildman riscv"
344       env:
345         - BUILDMAN="riscv"
346           TOOLCHAIN="riscv"
347     - name: "buildman nds32"
348       env:
349         - BUILDMAN="nds32"
350           TOOLCHAIN="nds32"
351
352     # QA jobs for code analytics
353     # static code analysis with cppcheck (we can add --enable=all later)
354     - name: "cppcheck"
355       script:
356         - cppcheck --force --quiet --inline-suppr .
357     # search for TODO within source tree
358     - name: "grep TODO"
359       script:
360         - grep -r TODO .
361     # search for FIXME within source tree
362     - name: "grep FIXME HACK"
363       script:
364         - grep -r FIXME .
365     # search for HACK within source tree and ignore HACKKIT board
366       script:
367         - grep -r HACK . | grep -v HACKKIT
368     # some statistics about the code base
369     - name: "sloccount"
370       script:
371         - sloccount .
372     # ensure all configs have MAINTAINERS entries
373     - name: "Check for configs without MAINTAINERS entry"
374       script:
375         - if [ `./tools/genboardscfg.py -f 2>&1 | wc -l` -ne 0 ]; then exit 1; fi
376     # Ensure host tools build
377     - name: "Build tools-only"
378       script:
379         - make tools-only_config tools-only -j$(nproc)
380     # Ensure env tools build
381     - name: "Build envtools"
382       script:
383         - make tools-only_config envtools -j$(nproc)
384
385     # test/py
386     - name: "test/py sandbox"
387       env:
388         - TEST_PY_BD="sandbox"
389           BUILDMAN="^sandbox$"
390           TOOLCHAIN="i386"
391     - name: "test/py sandbox with clang"
392       env:
393         - TEST_PY_BD="sandbox"
394           BUILDMAN="^sandbox$"
395           OVERRIDE="-O clang-7"
396     - name: "test/py sandbox_spl"
397       env:
398         - TEST_PY_BD="sandbox_spl"
399           TEST_PY_TEST_SPEC="test_ofplatdata"
400           BUILDMAN="^sandbox$"
401           TOOLCHAIN="i386"
402           TEST_PY_TOOLS="yes"
403     - name: "test/py sandbox_flattree"
404       env:
405         - TEST_PY_BD="sandbox_flattree"
406           BUILDMAN="^sandbox_flattree$"
407           TOOLCHAIN="i386"
408     - name: "test/py evb-ast2500"
409       env:
410         - TEST_PY_BD="evb-ast2500"
411           TEST_PY_ID="--id qemu"
412           QEMU_TARGET="arm-softmmu"
413           QEMU_VERSION="506179e42112be77bfd071f050b15762d3b2cd43"
414           BUILDMAN="^evb-ast2500$"
415     - name: "test/py vexpress_ca15_tc2"
416       env:
417         - TEST_PY_BD="vexpress_ca15_tc2"
418           TEST_PY_ID="--id qemu"
419           QEMU_TARGET="arm-softmmu"
420           QEMU_VERSION="v3.0.0"
421           BUILDMAN="^vexpress_ca15_tc2$"
422     - name: "test/py vexpress_ca9x4"
423       env:
424         - TEST_PY_BD="vexpress_ca9x4"
425           TEST_PY_ID="--id qemu"
426           QEMU_TARGET="arm-softmmu"
427           BUILDMAN="^vexpress_ca9x4$"
428     - name: "test/py integratorcp_cm926ejs"
429       env:
430         - TEST_PY_BD="integratorcp_cm926ejs"
431           TEST_PY_TEST_SPEC="not sleep"
432           TEST_PY_ID="--id qemu"
433           QEMU_TARGET="arm-softmmu"
434           BUILDMAN="^integratorcp_cm926ejs$"
435     - name: "test/py qemu_arm"
436       env:
437         - TEST_PY_BD="qemu_arm"
438           TEST_PY_TEST_SPEC="not sleep"
439           QEMU_TARGET="arm-softmmu"
440           BUILDMAN="^qemu_arm$"
441     - name: "test/py qemu_arm64"
442       env:
443         - TEST_PY_BD="qemu_arm64"
444           TEST_PY_TEST_SPEC="not sleep"
445           QEMU_TARGET="aarch64-softmmu"
446           BUILDMAN="^qemu_arm64$"
447     - name: "test/py qemu_mips"
448       env:
449         - TEST_PY_BD="qemu_mips"
450           TEST_PY_TEST_SPEC="not sleep"
451           QEMU_TARGET="mips-softmmu"
452           BUILDMAN="^qemu_mips$"
453           TOOLCHAIN="mips"
454     - name: "test/py qemu_mipsel"
455       env:
456         - TEST_PY_BD="qemu_mipsel"
457           TEST_PY_TEST_SPEC="not sleep"
458           QEMU_TARGET="mipsel-softmmu"
459           BUILDMAN="^qemu_mipsel$"
460           TOOLCHAIN="mips"
461     - name: "test/py qemu_mips64"
462       env:
463         - TEST_PY_BD="qemu_mips64"
464           TEST_PY_TEST_SPEC="not sleep"
465           QEMU_TARGET="mips64-softmmu"
466           BUILDMAN="^qemu_mips64$"
467           TOOLCHAIN="mips"
468     - name: "test/py qemu_mips64el"
469       env:
470         - TEST_PY_BD="qemu_mips64el"
471           TEST_PY_TEST_SPEC="not sleep"
472           QEMU_TARGET="mips64el-softmmu"
473           BUILDMAN="^qemu_mips64el$"
474           TOOLCHAIN="mips"
475     - name: "test/py qemu-ppce500"
476       env:
477         - TEST_PY_BD="qemu-ppce500"
478           TEST_PY_TEST_SPEC="not sleep"
479           QEMU_TARGET="ppc-softmmu"
480           BUILDMAN="^qemu-ppce500$"
481           TOOLCHAIN="powerpc"
482     - name: "test/py qemu-riscv64"
483       env:
484         - TEST_PY_BD="qemu-riscv64"
485           TEST_PY_TEST_SPEC="not sleep"
486           QEMU_TARGET="riscv64-softmmu"
487           BUILDMAN="^qemu-riscv64$"
488           TOOLCHAIN="riscv"
489     - name: "test/py qemu-x86"
490       env:
491         - TEST_PY_BD="qemu-x86"
492           TEST_PY_TEST_SPEC="not sleep"
493           QEMU_TARGET="i386-softmmu"
494           BUILDMAN="^qemu-x86$"
495           TOOLCHAIN="i386"
496           BUILD_ROM="yes"
497     - name: "test/py qemu-x86_64"
498       env:
499         - TEST_PY_BD="qemu-x86_64"
500           TEST_PY_TEST_SPEC="not sleep"
501           QEMU_TARGET="x86_64-softmmu"
502           BUILDMAN="^qemu-x86_64$"
503           TOOLCHAIN="i386"
504           BUILD_ROM="yes"
505     - name: "test/py zynq_zc702"
506       env:
507         - TEST_PY_BD="zynq_zc702"
508           TEST_PY_TEST_SPEC="not sleep"
509           QEMU_TARGET="arm-softmmu"
510           TEST_PY_ID="--id qemu"
511           BUILDMAN="^zynq_zc702$"
512     - name: "test/py xilinx_versal_virt"
513       env:
514         - TEST_PY_BD="xilinx_versal_virt"
515           TEST_PY_TEST_SPEC="not sleep"
516           QEMU_TARGET="aarch64-softmmu"
517           TEST_PY_ID="--id qemu"
518           BUILDMAN="^xilinx_versal_virt$"
519     - name: "test/py xtfpga"
520       env:
521         - TEST_PY_BD="xtfpga"
522           TEST_PY_TEST_SPEC="not sleep"
523           QEMU_TARGET="xtensa-softmmu"
524           TEST_PY_ID="--id qemu"
525           BUILDMAN="^xtfpga$"
526           TOOLCHAIN="xtensa-dc233c-elf"
527
528 # TODO make it perfect ;-r